*** shaohe_feng has quit IRC | 00:01 | |
*** slaweq has joined #openstack-nova | 00:03 | |
*** hoonetorg has joined #openstack-nova | 00:03 | |
*** slaweq has quit IRC | 00:08 | |
*** owalsh has joined #openstack-nova | 00:09 | |
*** dixiaoli has joined #openstack-nova | 00:09 | |
*** gmann has quit IRC | 00:10 | |
*** gmann has joined #openstack-nova | 00:10 | |
*** iceyao has joined #openstack-nova | 00:12 | |
*** dixiaoli has quit IRC | 00:14 | |
*** dtp has quit IRC | 00:16 | |
*** yangyape_ has quit IRC | 00:17 | |
*** iceyao has quit IRC | 00:17 | |
*** yangyapeng has joined #openstack-nova | 00:17 | |
*** arahal_ has quit IRC | 00:18 | |
*** mriedem has quit IRC | 00:21 | |
*** yangyapeng has quit IRC | 00:22 | |
*** mriedem has joined #openstack-nova | 00:24 | |
*** nic has left #openstack-nova | 00:29 | |
*** iceyao has joined #openstack-nova | 00:33 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | 00:37 |
---|---|---|
*** iceyao has quit IRC | 00:37 | |
*** jwcroppe has joined #openstack-nova | 00:38 | |
*** zhurong has joined #openstack-nova | 00:41 | |
*** Apoorva has quit IRC | 00:43 | |
*** thorst has quit IRC | 00:43 | |
*** ijw has joined #openstack-nova | 00:46 | |
*** tbachman has quit IRC | 00:49 | |
*** xinliang has quit IRC | 00:53 | |
*** iceyao has joined #openstack-nova | 00:54 | |
*** iceyao has quit IRC | 00:58 | |
*** slaweq has joined #openstack-nova | 01:03 | |
*** xinliang has joined #openstack-nova | 01:06 | |
*** slaweq has quit IRC | 01:08 | |
*** dixiaoli has joined #openstack-nova | 01:09 | |
*** iceyao has joined #openstack-nova | 01:14 | |
*** iceyao has quit IRC | 01:18 | |
*** yangyapeng has joined #openstack-nova | 01:19 | |
*** liujiong has joined #openstack-nova | 01:24 | |
*** yangyapeng has quit IRC | 01:24 | |
*** litao__ has joined #openstack-nova | 01:25 | |
*** iceyao has joined #openstack-nova | 01:26 | |
Kevin_Zheng | ping mriedem | 01:27 |
mriedem | pong | 01:27 |
*** yangyapeng has joined #openstack-nova | 01:28 | |
Kevin_Zheng | Hi, about tag creation | 01:29 |
Kevin_Zheng | http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/tag.py#n70 | 01:29 |
Kevin_Zheng | it is a class method and takes ['tag1','tag2'] as param | 01:30 |
Kevin_Zheng | so I think it cannot be used directly | 01:30 |
mriedem | because we have a TagList, | 01:30 |
mriedem | so you'd have to convert the TagList to a list of simple tags | 01:31 |
mriedem | tags = [tag.tag for tag in tags] | 01:31 |
mriedem | something like that right? | 01:31 |
Kevin_Zheng | besides, build_request contains TagList.obj so I build taglist in API layer | 01:31 |
Kevin_Zheng | yes | 01:31 |
mriedem | i wonder if people would be ok with checking the type for the tags parameter in TagList.create | 01:32 |
mriedem | and if it's a TagList, convert it to a simple form | 01:32 |
mriedem | it's just a lot more efficient to do it that way in a single call if we have multiple tags for the server | 01:33 |
*** yangyapeng has quit IRC | 01:33 | |
mriedem | because every separate tag create call does this extra _check_instance_exists_in_project db query | 01:34 |
mriedem | and context switch | 01:34 |
Kevin_Zheng | you mean do it in objects/tag.py? | 01:34 |
*** yangyapeng has joined #openstack-nova | 01:34 | |
mriedem | well that would abstract the check which would be nice and clean, but people might not like that, like dansmith | 01:34 |
mriedem | otherwise we could just convert the TagList to a simple list in the conductor method | 01:35 |
mriedem | i think passing the TagList object from the compute api to conductor is still ok and what we want | 01:35 |
Kevin_Zheng | yeah, and we also need it in build_request | 01:36 |
mriedem | sure i think that's fine | 01:36 |
mriedem | i wish TagList just had a non-classmethod create() but that would conflict with the classmethod | 01:36 |
mriedem | we could add a TagList.create_all(context) or something | 01:37 |
mriedem | TagList.create_all(context, resource_id) | 01:37 |
mriedem | which would use the tags already stored in the TagList | 01:37 |
mriedem | create_all() is a confusing name when there is already a create() method | 01:37 |
Kevin_Zheng | yeah | 01:37 |
mriedem | i'm just kicking out ideas, i could talk to dan in the morning, | 01:38 |
mriedem | but i'd really like to do the create in the single call fashion rather than iterate in conductor manager | 01:38 |
Kevin_Zheng | OK, I will have a try and have all the other comments addressed | 01:38 |
Kevin_Zheng | first | 01:38 |
mriedem | the simplest way to do that today is just doing tags = [tag.tag for tag in tags] in conductor manager | 01:38 |
mriedem | we could always move ^ into TagList later if we wanted | 01:39 |
Kevin_Zheng | OK | 01:39 |
*** yangyape_ has joined #openstack-nova | 01:39 | |
*** yangyapeng has quit IRC | 01:39 | |
*** rajathagasthya has joined #openstack-nova | 01:40 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: mark instance action events parameter as optional https://review.openstack.org/480792 | 01:42 |
*** tbachman has joined #openstack-nova | 01:43 | |
*** ijw has quit IRC | 01:43 | |
*** acormier has joined #openstack-nova | 01:55 | |
*** gyee has quit IRC | 01:58 | |
*** hongbin has joined #openstack-nova | 02:01 | |
openstackgerrit | Merged openstack/nova master: Fix arguments in calling _delete_nic_metadata https://review.openstack.org/480369 | 02:03 |
*** slaweq has joined #openstack-nova | 02:04 | |
*** tbachman has quit IRC | 02:07 | |
openstackgerrit | Merged openstack/nova master: Delete all inventory has its own method DELETE https://review.openstack.org/460147 | 02:08 |
*** slaweq has quit IRC | 02:09 | |
*** acormier has quit IRC | 02:10 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 02:10 |
*** mriedem has quit IRC | 02:10 | |
*** acormier has joined #openstack-nova | 02:10 | |
*** bkopilov has quit IRC | 02:12 | |
*** acormier_ has joined #openstack-nova | 02:14 | |
*** acormier has quit IRC | 02:15 | |
*** yamahata has quit IRC | 02:22 | |
*** slaweq has joined #openstack-nova | 02:33 | |
*** slaweq has quit IRC | 02:37 | |
*** edmondsw has joined #openstack-nova | 02:38 | |
*** edmondsw has quit IRC | 02:39 | |
*** shaohe_feng has joined #openstack-nova | 02:41 | |
*** udesale has joined #openstack-nova | 02:43 | |
*** thorst has joined #openstack-nova | 02:44 | |
*** thorst has quit IRC | 02:49 | |
*** Shunli has joined #openstack-nova | 02:49 | |
*** dave-mccowan has quit IRC | 02:53 | |
*** iceyao has quit IRC | 02:54 | |
*** slaweq has joined #openstack-nova | 03:04 | |
*** slaweq_ has joined #openstack-nova | 03:05 | |
*** slaweq has quit IRC | 03:09 | |
*** mmehan has quit IRC | 03:10 | |
*** slaweq_ has quit IRC | 03:11 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Update quota class spec to filter out networks quota https://review.openstack.org/480815 | 03:15 |
*** yamahata has joined #openstack-nova | 03:16 | |
*** hongbin_ has joined #openstack-nova | 03:20 | |
*** hongbin has quit IRC | 03:21 | |
*** hongbin has joined #openstack-nova | 03:23 | |
*** hongbin_ has quit IRC | 03:24 | |
*** markvoelker has quit IRC | 03:26 | |
*** markvoelker has joined #openstack-nova | 03:26 | |
gmann | alex_xu, mriedem: updated spec for filter out network quotas in os-quota-class - https://review.openstack.org/#/c/480815/1 | 03:27 |
alex_xu | gmann: thanks | 03:27 |
*** markvoelker has quit IRC | 03:30 | |
*** acormier_ has quit IRC | 03:31 | |
*** acormier has joined #openstack-nova | 03:32 | |
*** bkopilov has joined #openstack-nova | 03:32 | |
*** cNilesh has joined #openstack-nova | 03:32 | |
*** gjayavelu has joined #openstack-nova | 03:33 | |
*** yamamoto has joined #openstack-nova | 03:33 | |
*** cNilesh has quit IRC | 03:35 | |
*** cNilesh has joined #openstack-nova | 03:36 | |
*** acormier has quit IRC | 03:36 | |
*** hongbin has quit IRC | 03:38 | |
*** sanfern has joined #openstack-nova | 03:40 | |
*** edmondsw has joined #openstack-nova | 03:41 | |
*** iceyao has joined #openstack-nova | 03:43 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 03:45 |
*** edmondsw has quit IRC | 03:46 | |
*** mdnadeem has joined #openstack-nova | 03:47 | |
*** itlinux has joined #openstack-nova | 03:56 | |
*** mdrabe has quit IRC | 03:58 | |
*** claudiub has joined #openstack-nova | 03:58 | |
*** slaweq has joined #openstack-nova | 04:04 | |
*** links has joined #openstack-nova | 04:05 | |
*** slaweq_ has joined #openstack-nova | 04:06 | |
openstackgerrit | zhangdaolong proposed openstack/python-novaclient master: Fix the inappropriate parameter name https://review.openstack.org/480826 | 04:06 |
*** slaweq has quit IRC | 04:10 | |
*** slaweq_ has quit IRC | 04:11 | |
*** psachin has joined #openstack-nova | 04:14 | |
*** gjayavelu has quit IRC | 04:16 | |
*** sridharg has joined #openstack-nova | 04:18 | |
*** trinaths has joined #openstack-nova | 04:19 | |
*** fragatin_ has joined #openstack-nova | 04:22 | |
*** rajathagasthya has quit IRC | 04:23 | |
*** fragatina has quit IRC | 04:26 | |
*** fragatin_ has quit IRC | 04:26 | |
*** fragatina has joined #openstack-nova | 04:32 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276 | 04:33 |
*** adisky__ has joined #openstack-nova | 04:35 | |
*** fragatina has quit IRC | 04:36 | |
*** moshele has joined #openstack-nova | 04:40 | |
*** thorst has joined #openstack-nova | 04:45 | |
*** thorst has quit IRC | 04:51 | |
*** ratailor has joined #openstack-nova | 04:55 | |
*** jwcroppe has quit IRC | 04:57 | |
*** jwcroppe has joined #openstack-nova | 04:57 | |
*** dixiaoli has quit IRC | 04:58 | |
*** psachin has quit IRC | 05:01 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.49 - Virt device tagged attach https://review.openstack.org/480392 | 05:04 |
*** Shunli has quit IRC | 05:08 | |
*** dixiaoli has joined #openstack-nova | 05:11 | |
*** psachin has joined #openstack-nova | 05:11 | |
*** andymccr_ has joined #openstack-nova | 05:11 | |
*** cargonza_ has joined #openstack-nova | 05:13 | |
*** ujjain- has joined #openstack-nova | 05:14 | |
*** klipka_ has joined #openstack-nova | 05:15 | |
*** frickler_ has joined #openstack-nova | 05:15 | |
*** fmccrthy_ has joined #openstack-nova | 05:16 | |
*** anish_ has joined #openstack-nova | 05:17 | |
*** adisky___ has joined #openstack-nova | 05:17 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 05:19 |
*** clarkb1 has joined #openstack-nova | 05:19 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 05:20 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 05:20 |
*** dosaboy_ has joined #openstack-nova | 05:20 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | 05:21 |
*** harlowja has quit IRC | 05:22 | |
*** andymccr has quit IRC | 05:22 | |
*** ujjain has quit IRC | 05:22 | |
*** cargonza has quit IRC | 05:22 | |
*** fmccrthy has quit IRC | 05:22 | |
*** adisky__ has quit IRC | 05:22 | |
*** frickler has quit IRC | 05:22 | |
*** klipka has quit IRC | 05:22 | |
*** anish has quit IRC | 05:22 | |
*** devananda has quit IRC | 05:22 | |
*** clarkb has quit IRC | 05:22 | |
*** dosaboy has quit IRC | 05:22 | |
*** adisky___ is now known as adisky__ | 05:22 | |
*** cargonza_ is now known as cargonza | 05:22 | |
*** fmccrthy_ is now known as fmccrthy | 05:22 | |
*** prateek has joined #openstack-nova | 05:24 | |
*** john51 has quit IRC | 05:24 | |
*** mnaser has quit IRC | 05:24 | |
*** john51 has joined #openstack-nova | 05:24 | |
*** jotr has quit IRC | 05:25 | |
*** markvoelker has joined #openstack-nova | 05:27 | |
*** mnaser has joined #openstack-nova | 05:28 | |
*** prateek has quit IRC | 05:28 | |
*** jotr has joined #openstack-nova | 05:28 | |
*** edmondsw has joined #openstack-nova | 05:29 | |
*** prateek_ has joined #openstack-nova | 05:30 | |
*** karthiks has joined #openstack-nova | 05:30 | |
*** prateek_ is now known as 7GHABESXC | 05:30 | |
*** prateek_ has joined #openstack-nova | 05:30 | |
*** prateek_ has quit IRC | 05:30 | |
*** edmondsw has quit IRC | 05:33 | |
openstackgerrit | zhangdaolong proposed openstack/nova master: Fix parameters and description for os-volume_attachments https://review.openstack.org/480832 | 05:34 |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.50 - Enable cold migration with target host https://review.openstack.org/406707 | 05:35 |
*** sgordon has quit IRC | 05:41 | |
*** devananda has joined #openstack-nova | 05:43 | |
*** stephenfin has quit IRC | 05:44 | |
*** dgonzalez has quit IRC | 05:44 | |
*** stephenfin has joined #openstack-nova | 05:45 | |
*** dgonzalez has joined #openstack-nova | 05:46 | |
*** Shunli has joined #openstack-nova | 05:46 | |
*** sgordon has joined #openstack-nova | 05:50 | |
*** ijw has joined #openstack-nova | 05:50 | |
openstackgerrit | Moshe Levi proposed openstack/os-vif master: fix read the representor phys_port_name https://review.openstack.org/480213 | 05:53 |
*** andreas_s has joined #openstack-nova | 05:53 | |
*** reedip has joined #openstack-nova | 05:53 | |
reedip | Hi guys, With Ceph as backend, and using cinder, when we attach a volume to an instance, the following error is visible in the compute's nova-compute.log | 05:54 |
reedip | libvirtError: Secret not found: rbd no secret matches uuid '------------------------------------' | 05:54 |
reedip | any ideas how to resolve it ? | 05:55 |
reedip | we have one ceph, one compute and one controller+network node | 05:55 |
*** ijw has quit IRC | 05:56 | |
*** armax has quit IRC | 05:56 | |
*** armax has joined #openstack-nova | 05:56 | |
*** armax has quit IRC | 05:57 | |
*** itlinux has quit IRC | 05:58 | |
*** rcernin has joined #openstack-nova | 05:59 | |
*** litao__ has quit IRC | 06:00 | |
*** markvoelker has quit IRC | 06:00 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999 | 06:01 |
*** rcernin has quit IRC | 06:04 | |
*** slaweq has joined #openstack-nova | 06:06 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608 | 06:08 |
*** slaweq_ has joined #openstack-nova | 06:09 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483 | 06:09 |
*** Oku_OS-away is now known as Oku_OS | 06:11 | |
*** slaweq has quit IRC | 06:11 | |
*** karthiks has quit IRC | 06:12 | |
*** karthiks has joined #openstack-nova | 06:12 | |
*** slaweq_ has quit IRC | 06:13 | |
*** gouthamr has quit IRC | 06:14 | |
*** johnthetubaguy has quit IRC | 06:21 | |
*** anthonyper has quit IRC | 06:21 | |
*** masayukig has quit IRC | 06:21 | |
*** ttx has quit IRC | 06:21 | |
*** anthonyper has joined #openstack-nova | 06:21 | |
*** rha has quit IRC | 06:24 | |
*** Shunli has quit IRC | 06:24 | |
*** rha has joined #openstack-nova | 06:26 | |
*** johnthetubaguy has joined #openstack-nova | 06:27 | |
*** masayukig has joined #openstack-nova | 06:28 | |
*** ttx has joined #openstack-nova | 06:34 | |
*** sanfern has quit IRC | 06:35 | |
*** sanfern has joined #openstack-nova | 06:37 | |
*** ttx has quit IRC | 06:40 | |
*** ttx has joined #openstack-nova | 06:40 | |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform keypair.import notification https://review.openstack.org/467514 | 06:41 |
*** Nel1x has quit IRC | 06:41 | |
openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.50 - List/Show all server migration types https://review.openstack.org/430839 | 06:45 |
*** thorst has joined #openstack-nova | 06:46 | |
*** fragatina has joined #openstack-nova | 06:50 | |
gaurangt | Hi, I'm facing an issue where quota is not getting updated when the failed instance is deleted. Is there any work around for setting the right values for the quotas? | 06:50 |
*** thorst has quit IRC | 06:52 | |
*** fragatina has quit IRC | 06:54 | |
*** hshiina has joined #openstack-nova | 06:55 | |
openstackgerrit | Merged openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938 | 06:55 |
*** markus_z has joined #openstack-nova | 06:57 | |
*** markvoelker has joined #openstack-nova | 06:58 | |
*** belmoreira has joined #openstack-nova | 06:59 | |
*** bhagyashri_s has quit IRC | 07:00 | |
*** abalutoiu has joined #openstack-nova | 07:02 | |
*** sshwarts has joined #openstack-nova | 07:03 | |
*** tesseract has joined #openstack-nova | 07:04 | |
*** tesseract-RH has joined #openstack-nova | 07:04 | |
*** tesseract has quit IRC | 07:04 | |
*** tesseract-RH has quit IRC | 07:04 | |
*** tesseract has joined #openstack-nova | 07:05 | |
*** vladikr has quit IRC | 07:06 | |
*** slaweq has joined #openstack-nova | 07:07 | |
*** slaweq_ has joined #openstack-nova | 07:10 | |
*** slaweq has quit IRC | 07:12 | |
*** abalutoiu_ has joined #openstack-nova | 07:12 | |
*** chenying_ has joined #openstack-nova | 07:12 | |
*** slaweq_ has quit IRC | 07:14 | |
*** damien_r has joined #openstack-nova | 07:14 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add X-Openstack-Request-Id description https://review.openstack.org/474847 | 07:15 |
*** abalutoiu has quit IRC | 07:16 | |
*** chenying has quit IRC | 07:16 | |
*** vladiskuz has quit IRC | 07:17 | |
*** edmondsw has joined #openstack-nova | 07:17 | |
*** damien_r has quit IRC | 07:18 | |
*** mkucia has quit IRC | 07:18 | |
*** damien_r has joined #openstack-nova | 07:18 | |
*** edmondsw has quit IRC | 07:21 | |
*** mkucia has joined #openstack-nova | 07:22 | |
*** silvrax has quit IRC | 07:27 | |
*** yamamoto has quit IRC | 07:29 | |
*** _pewp_ has quit IRC | 07:30 | |
*** markvoelker has quit IRC | 07:30 | |
*** _pewp_ has joined #openstack-nova | 07:33 | |
*** alexchadin has joined #openstack-nova | 07:33 | |
*** yamamoto has joined #openstack-nova | 07:34 | |
*** jpena|off is now known as jpena | 07:34 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Use URIOpt https://review.openstack.org/479215 | 07:37 |
openstackgerrit | Silvan Kaiser proposed openstack/nova master: [WIP] Add truncate for images if prealloc is true https://review.openstack.org/480464 | 07:42 |
*** frickler_ is now known as frickler | 07:44 | |
*** ralonsoh has joined #openstack-nova | 07:46 | |
*** yamamoto has quit IRC | 07:47 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_console_auth_tokens.py https://review.openstack.org/477374 | 07:52 |
*** yamamoto has joined #openstack-nova | 07:53 | |
*** mkucia has quit IRC | 07:55 | |
*** mkucia has joined #openstack-nova | 07:55 | |
*** moshele has quit IRC | 07:55 | |
*** trinaths has quit IRC | 07:58 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-nova | 08:01 | |
*** avolkov` has joined #openstack-nova | 08:01 | |
*** VAhl has joined #openstack-nova | 08:10 | |
*** slaweq has joined #openstack-nova | 08:10 | |
*** slaweq has quit IRC | 08:15 | |
*** mlakat has quit IRC | 08:16 | |
*** lucas-afk is now known as lucasagomes | 08:18 | |
*** klipka_ is now known as klipka | 08:22 | |
*** slaweq has joined #openstack-nova | 08:23 | |
*** slaweq has quit IRC | 08:23 | |
*** mlakat has joined #openstack-nova | 08:24 | |
*** slaweq has joined #openstack-nova | 08:25 | |
*** abalutoiu_ is now known as abalutoiu | 08:26 | |
*** markvoelker has joined #openstack-nova | 08:27 | |
*** efoley has joined #openstack-nova | 08:31 | |
*** zhurong has quit IRC | 08:32 | |
*** litao__ has joined #openstack-nova | 08:32 | |
*** zhurong has joined #openstack-nova | 08:39 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437 | 08:41 |
*** artom has joined #openstack-nova | 08:46 | |
*** thorst has joined #openstack-nova | 08:48 | |
*** tuanluong has joined #openstack-nova | 08:49 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | 08:50 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP traits https://review.openstack.org/474550 | 08:53 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocations https://review.openstack.org/470933 | 08:53 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for usages https://review.openstack.org/480563 | 08:53 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP usages https://review.openstack.org/450105 | 08:53 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP allocations https://review.openstack.org/450550 | 08:53 |
*** thorst has quit IRC | 08:53 | |
*** takedakn has joined #openstack-nova | 08:57 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_console_auth_tokens.py https://review.openstack.org/477374 | 08:59 |
*** yamamoto has quit IRC | 09:00 | |
*** markvoelker has quit IRC | 09:02 | |
*** yamamoto has joined #openstack-nova | 09:05 | |
*** andymccr_ is now known as andymccr | 09:11 | |
*** slaweq has quit IRC | 09:12 | |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Make placement_api_docs.py failing https://review.openstack.org/480924 | 09:12 |
*** slaweq has joined #openstack-nova | 09:12 | |
*** _jarvis has joined #openstack-nova | 09:13 | |
*** slaweq_ has joined #openstack-nova | 09:13 | |
*** jangutter has quit IRC | 09:13 | |
*** abalutoiu has quit IRC | 09:13 | |
*** yamamoto has quit IRC | 09:16 | |
*** slaweq has quit IRC | 09:17 | |
*** trinaths has joined #openstack-nova | 09:17 | |
*** kaisers_ has joined #openstack-nova | 09:19 | |
openstackgerrit | Andreas Scheuring proposed openstack/nova master: DO NOT MERGE! Dummy patch https://review.openstack.org/478186 | 09:20 |
*** slaweq_ is now known as slaweq | 09:21 | |
*** slaweq has quit IRC | 09:26 | |
*** yamamoto has joined #openstack-nova | 09:29 | |
*** slaweq has joined #openstack-nova | 09:36 | |
bauzas | sfinucan: very old bug https://review.openstack.org/#/c/391060/ | 09:38 |
stephenfin | bauzas: I feel like I already reviewed that? | 09:38 |
bauzas | I know, you did +1 | 09:39 |
bauzas | but it was a long time ago :p | 09:39 |
stephenfin | bauzas: Was there something similar to that a few weeks back though? | 09:40 |
stephenfin | with requestspec objects | 09:40 |
stephenfin | Oh yeah, commit e211fca55a11c80058d5d78e31dc3ad466d7edfd | 09:41 |
*** abalutoiu has joined #openstack-nova | 09:41 | |
stephenfin | Cool. I'll take a look once I've finished resolving the merge conflict on https://review.openstack.org/#/c/415921/ | 09:41 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance-live_migration_post notification https://review.openstack.org/480119 | 09:45 |
*** slaweq has quit IRC | 09:45 | |
*** slaweq has joined #openstack-nova | 09:45 | |
*** igordcard has quit IRC | 09:48 | |
*** igordcard has joined #openstack-nova | 09:48 | |
*** takashin has left #openstack-nova | 09:48 | |
*** thorst has joined #openstack-nova | 09:49 | |
*** slaweq has quit IRC | 09:50 | |
*** dixiaoli has quit IRC | 09:51 | |
*** yamamoto has quit IRC | 09:53 | |
*** thorst has quit IRC | 09:54 | |
*** markvoelker has joined #openstack-nova | 09:59 | |
bauzas | sorry, was afk for getting my daughter at school | 09:59 |
*** yassine has joined #openstack-nova | 10:00 | |
*** yassine has quit IRC | 10:00 | |
*** yassine has joined #openstack-nova | 10:01 | |
*** yamamoto has joined #openstack-nova | 10:01 | |
*** cdent has joined #openstack-nova | 10:11 | |
*** sambetts|afk is now known as sambetts | 10:12 | |
_jarvis | need help in this bug | 10:17 |
_jarvis | https://bugs.launchpad.net/nova/+bug/1698253 | 10:17 |
openstack | Launchpad bug 1698253 in OpenStack Compute (nova) "InvalidInput: Invalid input received: vif type bridge not supported" [Undecided,In progress] - Assigned to PRAVIN (jarvisopenstack) | 10:17 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955 | 10:19 |
_jarvis | these was working in liberity | 10:19 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 10:20 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 10:20 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: set/check if inventory change in tree https://review.openstack.org/470575 | 10:20 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921 | 10:20 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 10:20 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 10:20 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: add ProviderTree.is_inventory_empty https://review.openstack.org/480957 | 10:20 |
*** moshele has joined #openstack-nova | 10:21 | |
*** liujiong has quit IRC | 10:22 | |
*** tbachman has joined #openstack-nova | 10:22 | |
*** liujiong has joined #openstack-nova | 10:23 | |
*** _jarvis has quit IRC | 10:24 | |
*** alexchadin has quit IRC | 10:24 | |
*** smatzek has joined #openstack-nova | 10:31 | |
*** smatzek has quit IRC | 10:32 | |
*** markvoelker has quit IRC | 10:32 | |
*** smatzek has joined #openstack-nova | 10:32 | |
*** yangyape_ has quit IRC | 10:35 | |
*** mkucia has quit IRC | 10:36 | |
*** mkucia has joined #openstack-nova | 10:36 | |
*** slaweq has joined #openstack-nova | 10:41 | |
*** slaweq has quit IRC | 10:41 | |
*** slaweq has joined #openstack-nova | 10:42 | |
*** liujiong has quit IRC | 10:42 | |
*** bkopilov has quit IRC | 10:45 | |
*** slaweq has quit IRC | 10:46 | |
*** slaweq has joined #openstack-nova | 10:46 | |
*** slaweq_ has joined #openstack-nova | 10:47 | |
*** lpetrut has joined #openstack-nova | 10:50 | |
*** slaweq_ has quit IRC | 10:51 | |
*** edmondsw has joined #openstack-nova | 10:53 | |
*** slaweq has quit IRC | 10:53 | |
*** sanfern has quit IRC | 10:54 | |
*** slaweq has joined #openstack-nova | 10:54 | |
*** edmondsw has quit IRC | 10:58 | |
*** slaweq has quit IRC | 10:58 | |
*** slaweq has joined #openstack-nova | 11:00 | |
*** vladikr has joined #openstack-nova | 11:00 | |
*** slaweq has quit IRC | 11:00 | |
*** jpena is now known as jpena|lunch | 11:00 | |
*** slaweq has joined #openstack-nova | 11:01 | |
*** slaweq has quit IRC | 11:02 | |
*** markvoelker has joined #openstack-nova | 11:02 | |
*** slaweq has joined #openstack-nova | 11:02 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526 | 11:05 |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 11:05 |
*** liujiong has joined #openstack-nova | 11:06 | |
*** slaweq has quit IRC | 11:07 | |
*** thorst has joined #openstack-nova | 11:12 | |
*** thorst has quit IRC | 11:13 | |
*** smatzek has quit IRC | 11:15 | |
*** Guest5975 has joined #openstack-nova | 11:15 | |
*** smatzek has joined #openstack-nova | 11:15 | |
*** thorst has joined #openstack-nova | 11:18 | |
*** thorst_ has joined #openstack-nova | 11:19 | |
*** slaweq has joined #openstack-nova | 11:19 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make notification publisher_id consistent https://review.openstack.org/480984 | 11:20 |
*** thorst has quit IRC | 11:22 | |
*** Guest5975 has quit IRC | 11:22 | |
*** mkucia has quit IRC | 11:22 | |
*** mkucia has joined #openstack-nova | 11:23 | |
*** sree has joined #openstack-nova | 11:28 | |
*** slaweq has quit IRC | 11:29 | |
openstackgerrit | Arundhati Surpur proposed openstack/python-novaclient master: Removed extra 'method' from the NOTE https://review.openstack.org/480988 | 11:30 |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform keypair.import notification https://review.openstack.org/467514 | 11:33 |
*** sree has quit IRC | 11:34 | |
*** sree has joined #openstack-nova | 11:36 | |
*** kaisers_ has quit IRC | 11:37 | |
alex_xu | bauzas: another fix for placement https://review.openstack.org/#/c/480130/, this should be easy :) | 11:41 |
*** litao__ has quit IRC | 11:42 | |
*** sree has quit IRC | 11:42 | |
*** sree has joined #openstack-nova | 11:43 | |
*** thorst_ has quit IRC | 11:44 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use enum value instead of string service name https://review.openstack.org/476538 | 11:51 |
*** jaypipes has joined #openstack-nova | 11:52 | |
*** kaisers_ has joined #openstack-nova | 11:56 | |
*** iceyao has quit IRC | 11:59 | |
*** iceyao has joined #openstack-nova | 11:59 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | 12:01 |
*** kaisers_ has quit IRC | 12:01 | |
*** alexchadin has joined #openstack-nova | 12:01 | |
*** kaisers_ has joined #openstack-nova | 12:02 | |
*** yangyapeng has joined #openstack-nova | 12:02 | |
*** jpena|lunch is now known as jpena | 12:03 | |
openstackgerrit | sudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/481007 | 12:04 |
*** sanfern has joined #openstack-nova | 12:06 | |
*** kaisers_ has quit IRC | 12:06 | |
*** mkucia has quit IRC | 12:07 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | 12:07 |
*** kaisers_ has joined #openstack-nova | 12:08 | |
*** jmlowe has joined #openstack-nova | 12:08 | |
bauzas | alex_xu: heh | 12:09 |
*** tuanluong has quit IRC | 12:10 | |
*** kaisers_ has quit IRC | 12:12 | |
*** edmondsw has joined #openstack-nova | 12:14 | |
*** oanson has quit IRC | 12:15 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955 | 12:15 |
*** jmlowe has quit IRC | 12:16 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient master: Fix cropping the endpoint url https://review.openstack.org/479818 | 12:17 |
*** ratailor has quit IRC | 12:19 | |
openstackgerrit | zhangdaolong proposed openstack/python-novaclient master: Fix the inappropriate parameter name https://review.openstack.org/480826 | 12:19 |
*** sree has quit IRC | 12:19 | |
*** oanson has joined #openstack-nova | 12:20 | |
*** sree has joined #openstack-nova | 12:23 | |
*** sree_ has joined #openstack-nova | 12:25 | |
*** sree_ is now known as Guest63377 | 12:25 | |
*** sree has quit IRC | 12:28 | |
*** Guest63377 has quit IRC | 12:29 | |
*** sree has joined #openstack-nova | 12:30 | |
*** bhagyashris has joined #openstack-nova | 12:32 | |
jaypipes | ralonsoh: no idea what the deal is on that "missing link" unit test that's failing on your openstack/releases patch for os-traits 0.3.2.... | 12:33 |
*** liverpooler has joined #openstack-nova | 12:34 | |
ralonsoh | jaypipes: uhmmm I'll check this now. Thanks for the heads up | 12:34 |
*** crushil has quit IRC | 12:34 | |
jaypipes | ralonsoh: yeah, I have no idea why that is failing. :( | 12:35 |
*** crushil has joined #openstack-nova | 12:35 | |
cdent | morning jaypipes: i've spiked that gabbi feature you were looking for while doing allocation_candates: https://github.com/cdent/gabbi/pull/215 | 12:36 |
*** liverpooler has quit IRC | 12:36 | |
*** liverpooler has joined #openstack-nova | 12:37 | |
jaypipes | cdent: w00tness. :) | 12:37 |
cdent | i'm not sure it is quite good enough yet, so if you can looksee that'd be keen | 12:37 |
jaypipes | cdent: though, to be honest, the feature I'd *really* love is to be able to represent in YAML the expected HTTP response without using JSONPath at all. | 12:37 |
cdent | i'm not sure what you mean by that | 12:38 |
jaypipes | cdent: I mean, I'd like to be able to something like: | 12:38 |
jaypipes | http_response_expect: | 12:38 |
jaypipes | allocation_requests: | 12:38 |
jaypipes | - allocations: | 12:38 |
jaypipes | resource_provider: | 12:38 |
jaypipes | uuid: <blah> | 12:39 |
jaypipes | etc etc | 12:39 |
jaypipes | cdent: make sense? | 12:39 |
*** cNilesh has quit IRC | 12:39 | |
cdent | full response, or piecemeal? | 12:39 |
jaypipes | cdent: would be awesome to have options. | 12:39 |
*** kaisers_ has joined #openstack-nova | 12:39 | |
jaypipes | cdent: like http_response_full_expect: or something like that which would fail if not exact | 12:39 |
jaypipes | cdent: and otherwise, just fail if the listed parts of the http_response_expect: were not included in the response. | 12:40 |
cdent | piecemeal is hard because you need some way to say "this" allocations, and that's what led to the json paths | 12:40 |
jaypipes | understood. | 12:40 |
jaypipes | code is hard. | 12:40 |
jaypipes | :P | 12:40 |
cdent | the fully query stuff see this thread: http://lists.openstack.org/pipermail/openstack-dev/2017-July/119286.html | 12:40 |
*** acormier has joined #openstack-nova | 12:42 | |
cdent | in any case, you can fake the full stuff by matching the root ($) key, see last half of: https://gabbi.readthedocs.io/en/latest/jsonpath.html | 12:42 |
*** mdrabe has joined #openstack-nova | 12:42 | |
*** mdnadeem has quit IRC | 12:42 | |
jaypipes | cdent: sure, but that's ugly as f**k :) | 12:42 |
cdent | that looks almost exactly what you have above (which is also ugly as fuck) | 12:43 |
jaypipes | ok, I'm done. | 12:43 |
cdent | heh | 12:43 |
*** acormier has quit IRC | 12:44 | |
*** pchavva has joined #openstack-nova | 12:44 | |
*** lyan has joined #openstack-nova | 12:44 | |
jaypipes | cdent: oh, I see you're referring to the final example in that page | 12:44 |
cdent | yes | 12:44 |
jaypipes | cdent: and not the one above it.. | 12:44 |
*** acormier has joined #openstack-nova | 12:44 | |
cdent | yes | 12:44 |
cdent | yeah, the filter stuff is ghastly, I agree | 12:45 |
jaypipes | cdent: didn't know I could do that. | 12:45 |
cdent | it just falls out of the nature of json path '$' is 'everything' | 12:45 |
jaypipes | cdent: that would work. though a little hackery would allow one to remove the need for the $: | 12:45 |
jaypipes | cdent: if, say, Gabbit saw a "response_yaml_exact" tag in the gabbit. | 12:46 |
*** mkucia has joined #openstack-nova | 12:46 | |
cdent | jaypipes: if you read around in that thread, especially the message I linked to, there's some discussion on options for how to do it. A little more discussino ought to lead to some reasonable outcomes | 12:46 |
cdent | the main thrust of the thread is to be able to read in files that are the json, but it's the same deal in the abstract | 12:47 |
bauzas | cdent: out of curiosity because I had the problem on Monday, how can I introspect a gabbi functional test? | 12:47 |
cdent | bauzas: depends on the kind of introspection you want to be doing, but you can make an individual test 'verbose' with 'verbose: True' but frequently the output will be swallowed, depending on the environment | 12:48 |
*** acormier has quit IRC | 12:49 | |
cdent | another option is to add a response_strings:\n- something that won't match | 12:49 |
cdent | and then it will fail and you can see the response | 12:49 |
bauzas | cdent: basically debugging | 12:49 |
bauzas | ie. pdb'ing | 12:49 |
bauzas | since tox can't do that, I generally use testtools.run directly | 12:49 |
bauzas | but since placement tests are generated by an helper, I can't directly use it | 12:50 |
bauzas | because testtools.run can't find the test I wanted to debug | 12:50 |
cdent | subunit.run can | 12:50 |
* cdent checks on whether testools.run can | 12:50 | |
bauzas | a-ha! | 12:51 |
bauzas | at least "python -m testtools.run discover --load-list my-list" is not possible | 12:51 |
*** eharney has joined #openstack-nova | 12:52 | |
*** takedakn has quit IRC | 12:53 | |
*** trinaths has left #openstack-nova | 12:54 | |
*** jmlowe has joined #openstack-nova | 12:57 | |
*** esberglu has joined #openstack-nova | 12:58 | |
*** sree has quit IRC | 12:59 | |
*** sree has joined #openstack-nova | 13:01 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '_has_dns_extension' function https://review.openstack.org/480675 | 13:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Always refresh cache when checking extensions https://review.openstack.org/480674 | 13:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: metadata: Don't use nova-net DNS values with neutron https://review.openstack.org/480616 | 13:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Use dns_domain value from neutron in os-vif wiring https://review.openstack.org/480676 | 13:04 |
*** sanfern has quit IRC | 13:04 | |
*** slaweq has joined #openstack-nova | 13:04 | |
*** sanfern has joined #openstack-nova | 13:04 | |
*** slaweq has quit IRC | 13:04 | |
*** slaweq has joined #openstack-nova | 13:05 | |
*** slaweq has quit IRC | 13:08 | |
*** 7GHABESXC has quit IRC | 13:10 | |
*** mriedem has joined #openstack-nova | 13:11 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: metadata: Don't use nova-net DNS values with neutron https://review.openstack.org/480616 | 13:12 |
*** alexchadin has quit IRC | 13:13 | |
*** sree has quit IRC | 13:15 | |
*** sree has joined #openstack-nova | 13:16 | |
stephenfin | mriedem, sean-k-mooney: Could either of you explain to me how 'os_vif.objects.network.Network' relates to 'nova.network.model.Network'? | 13:16 |
stephenfin | sorry - jaypipes ^ | 13:16 |
stephenfin | I thought we were using the former in [1], but it seems we're not. What's the whole point of the os_vif version if we define our own model? [1] https://review.openstack.org/#/c/480676/ | 13:17 |
jaypipes | stephenfin: the idea is to eventually get rid of the nova model. | 13:17 |
jaypipes | stephenfin: and have Neutron just return a serialized os-vif object. | 13:17 |
jaypipes | stephenfin: we're gradually getting there. but will be a while before we do. | 13:18 |
stephenfin | jaypipes: I'm guessing that means the 'neutron.objects.network.Network' model will go away then too? | 13:18 |
stephenfin | Ideally | 13:18 |
*** gouthamr has joined #openstack-nova | 13:18 | |
jaypipes | stephenfin: well, that may store some internal (to Neutron) stuff, so not sure... | 13:18 |
stephenfin | Well, maybe not, but neutron will translate 'neutron.objects.network.Network' -> 'os_vif.objects.network.Network' for sending over the wire | 13:18 |
jaypipes | stephenfin: os-vif objects are intended to be the shared model between nova and neutron. | 13:19 |
jaypipes | stephenfin: ya, zactly. | 13:19 |
*** lucasxu has joined #openstack-nova | 13:19 | |
*** sree has quit IRC | 13:20 | |
cdent | bauzas: you can do something like the following. part of the trick is getting the name of the test right in the face of your discover path: | 13:20 |
cdent | .tox/functional/bin/python -m subunit.run discover -v nova/tests/functional/api/openstack/placement --load-list <(echo test_placement_api.allocations_check_usages.test_request) | subunit-trace | 13:20 |
stephenfin | jaypipes: Gotcha. Thanks for the info :) | 13:21 |
*** zhurong has quit IRC | 13:22 | |
bauzas | cdent: okay | 13:22 |
bauzas | I need to look more at the subunit framework | 13:23 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: metadata: Don't use nova-net DNS values with neutron https://review.openstack.org/480616 | 13:23 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Store dns_domain value from neutron https://review.openstack.org/480676 | 13:23 |
cdent | that works for testtools.run as well. if you s/subunit/testtools/ is all good | 13:23 |
*** mkucia has quit IRC | 13:23 | |
cdent | (and get rid of subunit-trace) | 13:23 |
cdent | bauzas: then I guess you'd hork pdb in there somewhere. What would your normal of doing that be? | 13:25 |
*** catintheroof has joined #openstack-nova | 13:25 | |
bauzas | I usually pdb.set_trace() somewhere and then I just python -m testtools.run the UT I wanna check | 13:25 |
stephenfin | bauzas: RE: https://review.openstack.org/#/c/391060, I'm going to leave that til mriedem and melwitt come back to it, as they'd similar feedback and it's unchanged since | 13:27 |
*** baoli has joined #openstack-nova | 13:27 | |
*** igordcard has quit IRC | 13:28 | |
*** thorst has joined #openstack-nova | 13:29 | |
*** igordcard has joined #openstack-nova | 13:29 | |
*** sree has joined #openstack-nova | 13:30 | |
*** yamamoto has quit IRC | 13:33 | |
*** slaweq has joined #openstack-nova | 13:33 | |
*** yamamoto has joined #openstack-nova | 13:33 | |
cdent | bauzas: heh, turns out I wrote a faq about this a while ago: https://gabbi.readthedocs.io/en/latest/faq.html#is-gabbi-only-for-testing-python-based-apis | 13:34 |
cdent | whoops, wrong link: https://gabbi.readthedocs.io/en/latest/faq.html#how-do-i-run-just-one-test | 13:34 |
*** catintheroof has quit IRC | 13:36 | |
jaypipes | tox -efunctional && ./jay-get-breakfast.bash | 13:37 |
*** catintheroof has joined #openstack-nova | 13:37 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | 13:37 |
*** moshele has quit IRC | 13:39 | |
*** sree_ has joined #openstack-nova | 13:40 | |
*** sanfern has left #openstack-nova | 13:41 | |
*** sree_ is now known as Guest23770 | 13:41 | |
*** kaisers_ has quit IRC | 13:41 | |
*** sree has quit IRC | 13:42 | |
*** krtaylor has quit IRC | 13:42 | |
*** jwcroppe has quit IRC | 13:43 | |
*** slaweq_ has joined #openstack-nova | 13:48 | |
bauzas | stephenfin: fair enough | 13:48 |
*** slaweq has quit IRC | 13:49 | |
bauzas | cdent: cool, I looked at the gabbi docs, but didn't find it | 13:49 |
ildikov | jaypipes: it could almost include breakfast and lunch... :) | 13:50 |
*** slaweq has joined #openstack-nova | 13:50 | |
dansmith | jaypipes: that will get breakfast after the run, I think you want (tox -e functional&); ./jay-get-breakfast.sh | 13:51 |
*** _jarvis has joined #openstack-nova | 13:51 | |
*** edleafe- is now known as edleafe | 13:52 | |
*** sree has joined #openstack-nova | 13:52 | |
*** slaweq_ has quit IRC | 13:53 | |
*** Guest23770 has quit IRC | 13:53 | |
*** krtaylor has joined #openstack-nova | 13:56 | |
*** slaweq has quit IRC | 13:57 | |
*** baoli has quit IRC | 13:59 | |
mriedem | stephenfin: what happened to sfinucan? | 14:00 |
*** hongbin has joined #openstack-nova | 14:01 | |
stephenfin | mriedem: I wanted cross-promotional, deal mechanics, revenue streams, jargon synergy | 14:01 |
*** jwcroppe has joined #openstack-nova | 14:01 | |
*** baoli has joined #openstack-nova | 14:01 | |
stephenfin | i.e. I use 'stephenfin' everywhere else and wanted to switch here too | 14:01 |
mriedem | gah | 14:01 |
* cdent hires stephenfin as his social media consultant | 14:02 | |
stephenfin | plus there's an 'e' missing from 'sfinucan' which has resulted in more than one incorrectly addressed email | 14:02 |
cdent | I'm suffering from brand dilution with this cdent/anticdent thing | 14:03 |
stephenfin | (that is also my Red Hat email alias, but not for long) | 14:03 |
mriedem | dansmith: i'm in a quandary if you have 5 minutes | 14:03 |
*** slaweq has joined #openstack-nova | 14:03 | |
*** slaweq has quit IRC | 14:03 | |
mriedem | otherwise i shall take it to the ML | 14:03 |
dansmith | mriedem: okay | 14:03 |
stephenfin | cdent: You should hire Liz Lemon - she's much better than me at this stuff https://www.youtube.com/watch?v=aocZo3oeNxw | 14:04 |
*** slaweq has joined #openstack-nova | 14:04 | |
mriedem | dansmith: the extend volume change in nova - https://review.openstack.org/#/c/454322/ - i started writing a tempest test for that yesterday, since there is also a cinder change, | 14:04 |
*** sree has quit IRC | 14:04 | |
mriedem | the user (non-admin) can extend their volume in cinder, so like 1G->2G, | 14:04 |
cdent | stephenfin: she's probably busy | 14:04 |
*** sree has joined #openstack-nova | 14:05 | |
mriedem | cinder will call the os-server-external-events API telling nova the volume attached to a server was resized, | 14:05 |
mriedem | we send that down to the compute to fiddle the os-brick bits (i'm channeling johnthetubaguy-speak here) | 14:05 |
mriedem | "fiddling bits" is a british term right? | 14:05 |
*** awaugama has joined #openstack-nova | 14:05 | |
*** pkoniszewski has quit IRC | 14:05 | |
dansmith | mriedem: I believe it is yes | 14:05 |
mriedem | so i asked that an instance action get tracked on the nova side since this is all async, | 14:05 |
mriedem | that's done, all well and good, | 14:05 |
edleafe | stephenfin: I settled on 'edleafe' long ago for all my accounts. Not enough brain cells to keep track of different handles | 14:06 |
mriedem | problem comes in on the api user side trying to sort out when the actual operation is done on the nova side, | 14:06 |
edleafe | stephenfin: plus all the branding synergy, of course | 14:06 |
mriedem | i was relying on the instance action events in tempest - however, the events are only shown for admin users | 14:06 |
stephenfin | edleafe: Yup, my problem exactly. Plus it helps with branding | 14:06 |
stephenfin | jinx :) | 14:06 |
edleafe | :) | 14:06 |
mriedem | so we can get tempest to work since we have admin and non-admin creds, but that's a hack, | 14:06 |
mriedem | so i was thinking, we should probably set a task_state on the instance in this case, | 14:06 |
dansmith | mriedem: UGH | 14:07 |
mriedem | so the api user can poll the task state change to know when the nova side is done | 14:07 |
mriedem | i know | 14:07 |
dansmith | mriedem: that's not really what task_state is for, IMHO, so it would be a bad choice | 14:07 |
dansmith | that and it will lock us from doing anything like a shutdown or something if that gets hung | 14:07 |
mriedem | well, unless there is something else, it's task_state or instance actions, | 14:07 |
dansmith | which is fairly icky | 14:07 |
mriedem | and as noted, the action events are admin-only | 14:07 |
mriedem | well, | 14:07 |
dansmith | well, vm_state has fewer issues with that, | 14:08 |
dansmith | but I'm loathe to alter any of them really | 14:08 |
mriedem | i considered that an upside - that someone can't stop your instance while it's having the volume extended | 14:08 |
mriedem | but, | 14:08 |
dansmith | so they can see the action but not the events? | 14:08 |
mriedem | we also can't accept the call from cinder if the task_state is already set either, b/c we'd get UnexpectedTaskStateERror | 14:08 |
mriedem | dansmith: correct | 14:08 |
mriedem | https://review.openstack.org/#/c/480792/ | 14:09 |
dansmith | mriedem: does the action get the finish_time set when it's done? | 14:09 |
mriedem | nope | 14:09 |
mriedem | that's on the event | 14:09 |
* dansmith knows dangerously little about this | 14:09 | |
dansmith | mriedem: not according to the object model | 14:09 |
sean-k-mooney | stephenfin: os_vif.objects.network.Network is used to pass info the os-vif plugins about the network such as mtu, it is created from nova.network.model.Network. nova.network.model.Network is used to pass network related info that will be needed to influenc the libvirt xml generation. you only need to modify nova.network.model.Network so that you can populate the metatda for cloud init | 14:09 |
dansmith | mriedem: https://github.com/openstack/nova/blob/master/nova/objects/instance_action.py#L39-L39 | 14:09 |
*** hshiina has quit IRC | 14:10 | |
mriedem | hmm, i don't know if anything calls action_finish or finish, | 14:10 |
mriedem | looking | 14:10 |
mriedem | i know we don't expose finish_time in the api for the action https://developer.openstack.org/api-ref/compute/?expanded=list-actions-for-server-detail#servers-actions-servers-os-instance-actions | 14:11 |
mriedem | only the events | 14:11 |
mriedem | but that could easily be changed | 14:11 |
dansmith | heh | 14:11 |
sean-k-mooney | stephenfin: we basicaly need to create os_vif.objects.network.Network so that there would not be a circular dependency between os-vif and nova. | 14:11 |
stvnoyes1 | good morning mriedem: I updated the live migrate review, addressing your comments. Please take a look when you get a chance. Thanks. - https://review.openstack.org/#/c/463987/ | 14:11 |
*** kaisers_ has joined #openstack-nova | 14:11 | |
dansmith | mriedem: I wonder why that is, but it seems like that'd be a thing you look for if you're using the action to identify the long-running thing | 14:11 |
mriedem | dansmith: yeah so nothing calls InstanceAction.action_finish / finish today | 14:12 |
mriedem | so we have the finish-time field in the data model, but nothing sets it | 14:12 |
mriedem | stvnoyes1: ok | 14:13 |
dansmith | hrm, that seems weird | 14:13 |
dansmith | and unfortunate | 14:13 |
mriedem | i think i asked alaski about this a long time ago, | 14:13 |
mriedem | and the tasks api came up | 14:13 |
dansmith | mriedem: so, exposing events is one way I guess, as long as you filter out traceback for the non-admins, but that's a whole thing | 14:14 |
mriedem | and then a black hole opened somewhere | 14:14 |
dansmith | hehe | 14:14 |
mriedem | dansmith: right, that's another option, | 14:14 |
*** pkoniszewski has joined #openstack-nova | 14:14 | |
mriedem | expose events but filter the traceback like we do for instance fault | 14:14 |
dansmith | I really think using one of the states to handle this is just asking for trouble, but ... | 14:14 |
dansmith | yeah | 14:14 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add sample test for instance audit https://review.openstack.org/480955 | 14:14 |
mriedem | i would prefer not to complicate this with a new task_state | 14:14 |
*** arahal_ has joined #openstack-nova | 14:14 | |
mriedem | because at that point, | 14:14 |
mriedem | using the os-server-external-events api for this is really overloading it's function | 14:15 |
dansmith | my concern with a new state is destabilizing everything else with a new task state, which doesn't expose itself until it's out in the wild and someone finds a dead end in the "state machine" | 14:15 |
*** vladikr_ has joined #openstack-nova | 14:15 | |
mriedem | yeah so to recap options, | 14:15 |
mriedem | 1. do nothing - end user can see the action show up for the instance but after that, shrug - maybe they can check something by ssh'ing into the guest, idk, | 14:16 |
mriedem | 2. start setting the finish_time on the action record and expose that out of the instance actions api (in the same microversion i suppose) | 14:16 |
*** kaisers_ has quit IRC | 14:16 | |
mriedem | 3. expose the events but hide the traceback for non-admins by default (in a microversion) | 14:16 |
*** acormier has joined #openstack-nova | 14:17 | |
dansmith | 4. break the "state machine" | 14:17 |
mriedem | i was intentionally excluding that one | 14:17 |
dansmith | ack | 14:17 |
mriedem | #3 is probably the easiest | 14:18 |
*** vladikr has quit IRC | 14:18 | |
*** links has quit IRC | 14:18 | |
mriedem | #2 would be new plumbing since we haven't ever "finished" an action record before, | 14:18 |
mriedem | so i don't know what dragons are there | 14:18 |
*** slaweq_ has joined #openstack-nova | 14:18 | |
dansmith | might also be confusing because people will see all their actions suddenly look unfinished | 14:18 |
dansmith | like, years-old actions if they're still there | 14:18 |
mriedem | yeah, | 14:18 |
mriedem | on that note, | 14:18 |
dansmith | we couldfix that, but we'd need to finish all our actions everywhere going forward | 14:18 |
mriedem | my musing last night led to something like, consider the action finished if it had at least one event and all events had a finish_time set, | 14:19 |
mriedem | but there is a window where that could be wrong | 14:19 |
dansmith | yeah, it would flap back and forth | 14:19 |
mriedem | assuming we have any actions with >1 event | 14:19 |
dansmith | because we don't declare all our events ahead of time | 14:19 |
dansmith | would be nice if we did, but.. | 14:19 |
mriedem | sure, that's tasks api | 14:19 |
mriedem | i guess | 14:19 |
dansmith | right | 14:20 |
mriedem | watch your footing | 14:20 |
dansmith | heh | 14:20 |
mriedem | so i'm thinking "expose the events but hide the traceback for non-admins by default (in a microversion)" is the winner | 14:20 |
dansmith | I guess so | 14:20 |
dansmith | I like #1, but... yeah :) | 14:20 |
mriedem | "winner" | 14:20 |
mriedem | do quotes help? | 14:21 |
dansmith | yeah, hard to feel like you won, when that's the solution | 14:21 |
dansmith | heh | 14:21 |
mriedem | i also don't feel like working this into the same microversion, since it will clutter up an already large change, | 14:21 |
mriedem | but also not sure i want to create a new separate microversion just for that | 14:21 |
mriedem | alright, anyway, this was helpful | 14:22 |
dansmith | yeah, I dunno.. would be nice to save a microversion, but reading the history, it'll be like "this volume thing and oh also we exposed this other random thing, kthxbai" | 14:22 |
sean-k-mooney | stephenfin: by the way if you have not seen https://review.openstack.org/#/c/390513/ and https://review.openstack.org/#/c/390512/ they are releated to the issue your trying to solve | 14:22 |
*** esberglu has quit IRC | 14:22 | |
stephenfin | sean-k-mooney: I think I saw one but not the other. I'll take a look now :) | 14:23 |
*** slaweq_ has quit IRC | 14:23 | |
stephenfin | sean-k-mooney: meanwhile, I _think_ this is correct, but I'm not sure if it's even necessary given your comments about not using a fqdn for hostname https://review.openstack.org/#/c/480676/ | 14:24 |
mriedem | dansmith: that's basically how the services/hypervisors uuid api changes read out in the rest api version history and release notes :) | 14:24 |
dansmith | mriedem: heh | 14:24 |
mriedem | "take and return uuid instead of id, plus a whole bunch of other shit" | 14:24 |
sean-k-mooney | stephenfin: the first one is proposing a single api endpoint to return all the info to populate the metadat. the second is the nova/neutont negociation sepc where i would like to use os vif as the serialisation format | 14:24 |
mriedem | 500 microversions also sucks | 14:24 |
dansmith | yeah | 14:24 |
*** esberglu has joined #openstack-nova | 14:25 | |
sean-k-mooney | stephenfin: lookin at it now. did you add the dns_domain field in the previous patches | 14:26 |
stephenfin | sean-k-mooney: I don't think it's necessary - that model does weird stuff with a 'meta' field that's mostly autopopulated | 14:27 |
stephenfin | sean-k-mooney: Look at the patch that added 'mtu' support | 14:27 |
*** markus_z has quit IRC | 14:28 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: fix memory locking limit https://review.openstack.org/472633 | 14:30 |
*** slaweq has quit IRC | 14:30 | |
jaypipes | dansmith, ildikov: :) | 14:30 |
mriedem | mgagne: fyi in case you haven't been following along https://review.openstack.org/#/c/454322/27/nova/compute/api.py | 14:31 |
mriedem | mgagne: let's talk about how you'd like to proceed - if you want me to work on the os-instance-actions api change in there | 14:31 |
*** slaweq has joined #openstack-nova | 14:32 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | 14:32 |
*** vvargaszte has quit IRC | 14:36 | |
*** foutatoro has joined #openstack-nova | 14:39 | |
foutatoro | hi all, I'm trying to create KVM instance with ubuntu cloud images used in Openstack with virt-install but I always get the error "No bootable device found". | 14:40 |
foutatoro | can someone help me to solve that please ? | 14:41 |
openstackgerrit | Merged openstack/os-vif master: Rehome unit tests to ``tests\unit`` folder https://review.openstack.org/476623 | 14:42 |
openstackgerrit | Merged openstack/os-vif master: Use ``assert_has_calls`` to check function calls https://review.openstack.org/477469 | 14:42 |
*** Swami has joined #openstack-nova | 14:53 | |
*** vladikr_ has quit IRC | 14:54 | |
*** vladikr_ has joined #openstack-nova | 14:55 | |
jaypipes | while `tox -epy27,pep8`; do process_emails.sh; done | 14:57 |
*** liujiong has quit IRC | 14:57 | |
mriedem | ildikov: so the cinder v3 api changes are stacked such that swap volume should get tested in the top patch which does the new style attach, right? | 14:58 |
*** catintheroof has quit IRC | 14:58 | |
mriedem | ildikov: because there is a swap volume test in tempest, but i don't think it runs in the normal tempest dsvm jobs because it's marked as 'slow' | 14:58 |
ildikov | mriedem: it should run as it was failing until I added the swap patch in the chain | 14:59 |
mriedem | ok i'll take a look | 14:59 |
ildikov | mriedem: you can take a thorough look at both the dependencies and on the attach patch | 15:00 |
ildikov | just to keep everyone busy :) | 15:00 |
*** catintheroof has joined #openstack-nova | 15:02 | |
jaypipes | mriedem: ralonsoh is looking for this (yet unmerged) patch: https://review.openstack.org/#/c/466040/ | 15:06 |
*** psachin has quit IRC | 15:07 | |
*** READ10 has joined #openstack-nova | 15:07 | |
jaypipes | mriedem: but you're right to say that 0.3.2 doesn't include that (since obvi it's not merged yet) | 15:07 |
jaypipes | I'm approving that now. it needed rebasing after the unit test re-org | 15:07 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: fix memory locking limit https://review.openstack.org/472633 | 15:07 |
mriedem | jaypipes: ok | 15:08 |
mriedem | something didn't smell right | 15:08 |
jaypipes | mriedem: ack | 15:08 |
jaypipes | mriedem: there's also an os-vif thing too :) | 15:08 |
mriedem | plus this monster https://review.openstack.org/#/c/449257/ | 15:09 |
jaypipes | mriedem: well, yeah, but that depends on all the others :) | 15:09 |
mriedem | right | 15:09 |
mriedem | i see a few os-vif changes, | 15:09 |
mriedem | not sure which are related, they are all marked as bug fixes | 15:09 |
*** belmoreira has quit IRC | 15:11 | |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP traits https://review.openstack.org/474550 | 15:16 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for traits https://review.openstack.org/474186 | 15:16 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocations https://review.openstack.org/470933 | 15:16 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for usages https://review.openstack.org/480563 | 15:16 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Make placement_api_docs.py failing https://review.openstack.org/480924 | 15:16 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP usages https://review.openstack.org/450105 | 15:16 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP allocations https://review.openstack.org/450550 | 15:16 |
openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocation_candidates https://review.openstack.org/481112 | 15:16 |
*** rdo_ has quit IRC | 15:16 | |
*** Oku_OS is now known as Oku_OS-away | 15:21 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631 | 15:22 |
openstackgerrit | Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632 | 15:22 |
jaypipes | dansmith, mriedem, efried, bauzas: addressed all of your comments on https://review.openstack.org/476631 | 15:24 |
*** reedip has quit IRC | 15:24 | |
efried | just pulling it up, thanks. | 15:24 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass the req_dest fielf of ReqSpec in the filter props https://review.openstack.org/481116 | 15:25 |
jaypipes | efried: I changed the code style to put every word and paren on its own line, just for you and dansmith. | 15:25 |
efried | Love it. | 15:25 |
jaypipes | heh | 15:25 |
dansmith | jaypipes: (I hope you are kidding | 15:27 |
dansmith | ) | 15:27 |
jaypipes | dansmith: no, | 15:27 |
jaypipes | not, | 15:27 |
jaypipes | kidding, | 15:27 |
*** foutatoro has quit IRC | 15:27 | |
jaypipes | ) | 15:27 |
jaypipes | dansmith: j | 15:27 |
jaypipes | k | 15:27 |
* dansmith 's head explodes | 15:28 | |
jaypipes | boom. | 15:28 |
jaypipes | mission accomplished. | 15:28 |
*** markmc has quit IRC | 15:28 | |
mriedem | some day someone will have to explain the kerfuffle from last week about ( | 15:29 |
mriedem | this | 15:29 |
mriedem | ) | 15:29 |
jaypipes | mriedem: basically, it makes dansmith and efried want to do this to my head: http://bit.ly/2tl79kj | 15:30 |
jaypipes | and edleafe :) | 15:31 |
bauzas | mriedem: dansmith: not sure you remembered our convo yesterday about https://bugs.launchpad.net/nova/+bug/1702454 but I just provided a fix https://review.openstack.org/481116 | 15:32 |
openstack | Launchpad bug 1702454 in OpenStack Compute (nova) "Transforming the RequestSpec object into legacy dicts doesn't support the requested_destination field" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 15:32 |
bauzas | mriedem: dansmith: targeted for backport to ocata and newton as well | 15:32 |
mriedem | jaypipes: well, just keep an eye out for when one of them do something similar with a dict or list and then you can drop the gd mfing hammer | 15:32 |
jaypipes | mriedem: I'm a pacifist. | 15:33 |
mriedem | bauzas: what is a "fielf"? | 15:33 |
*** sree has quit IRC | 15:33 | |
efried | mriedem TL;DR: jaypipes has been indoctrinating himself in golang, where this kind of wasted vspace is acceptable, even encouraged. Which would be one thing if it matched the style of the code anywhere else in nova, but it doesn't. For dicts, yes. For lists, less so, but sometimes. For method calls, never. | 15:33 |
bauzas | mriedem: a covfefe | 15:33 |
jaypipes | mriedem: it's a field that dresses up at Christmas. | 15:33 |
edleafe | I suspect that jaypipes gets paid by LOC | 15:34 |
bauzas | then write Java | 15:34 |
mriedem | bauzas: comments inline | 15:34 |
bauzas | mriedem: <3 | 15:35 |
mriedem | efried: ok, but meh | 15:35 |
jaypipes | edleafe: erm, definitely not :) https://twitter.com/jaypipes/status/854680490485456896 | 15:35 |
mriedem | i know jay isn't using pycharm, but pycharm does that by default when dropping a line to add params to a method call | 15:35 |
jaypipes | vimftw | 15:35 |
mriedem | and some projects i've worked in in openstack actually enforce that format, like manila | 15:35 |
mriedem | i believe i was -1ed for not doing something like that | 15:36 |
mriedem | anywho | 15:36 |
efried | mriedem I use pycharm and don't even notice that I delete those extraneous newlines :) | 15:36 |
efried | Just happens automatically. | 15:36 |
efried | you know, on this side of the keyboard. | 15:36 |
bauzas | is that really a thing ? | 15:37 |
bauzas | I mean, does it hurt ? | 15:37 |
*** andreas_s has quit IRC | 15:37 | |
cdent | dansmith: you made a sad face in a review about the thing this fixes, does it look good enough to you: https://github.com/cdent/gabbi/pull/215 | 15:37 |
bauzas | I tend to be more concerned by people not using a pattern like (foo,\n) | 15:37 |
*** reedip has joined #openstack-nova | 15:37 | |
bauzas | because gerrit would modify the line instead of adding a new one when you're adding a new key | 15:38 |
gibi | sfinucan, mriedem: hi! I fixed the comments in https://review.openstack.org/#/c/476538/ | 15:38 |
mriedem | i'm currently in cinder v3 attach mode now, going into tunnel vision | 15:39 |
mgagne | mriedem: I read your comments. I understand the technical challenge but it starts to fall outside my scope of expertise. I would need someone else to work on this specific task. | 15:39 |
mriedem | mgagne: ok, i can help work on the instance actions stuff later | 15:40 |
mgagne | mriedem: re in-use volume extend | 15:40 |
mgagne | sure, thanks! | 15:40 |
*** chyka has joined #openstack-nova | 15:40 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass requested_destination in filter_properties https://review.openstack.org/481116 | 15:41 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (3) https://review.openstack.org/452820 | 15:43 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | 15:43 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | 15:43 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor instance.power-off notification samples https://review.openstack.org/475860 | 15:43 |
*** sree has joined #openstack-nova | 15:43 | |
*** sree has quit IRC | 15:43 | |
*** sree has joined #openstack-nova | 15:43 | |
*** penick has joined #openstack-nova | 15:44 | |
*** dtp has joined #openstack-nova | 15:44 | |
*** slaweq has quit IRC | 15:44 | |
*** slaweq has joined #openstack-nova | 15:45 | |
*** awaugama has quit IRC | 15:45 | |
*** awaugama has joined #openstack-nova | 15:46 | |
vdrok | dansmith: one more question about the multicell setup. we don't have to change the hash ring logic we have at https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L539-L553 ? ServiceList will contain only computes from this cell's database? | 15:48 |
*** hieulq_ has joined #openstack-nova | 15:48 | |
*** slaweq has quit IRC | 15:50 | |
*** gyee has joined #openstack-nova | 15:51 | |
*** hshiina has joined #openstack-nova | 15:52 | |
*** dixiaoli has joined #openstack-nova | 15:53 | |
*** clarkb1 is now known as clarkb | 15:54 | |
*** tesseract has quit IRC | 15:54 | |
*** itlinux has joined #openstack-nova | 15:55 | |
*** Apoorva has joined #openstack-nova | 15:56 | |
*** Apoorva has quit IRC | 15:56 | |
alaski | mriedem: I never tackled instance action finish times because there was enough complexity around it that I didn't feel that I could make it reliable. There are too many places where errors can occur and it will be easy to miss one, or have a new one added at some point and miss the instance action finish call. | 15:57 |
mriedem | vdrok: the GET /os-services API will iterate the cells | 15:57 |
mriedem | so you should get all services from all cells via the REST API | 15:57 |
*** dixiaoli has quit IRC | 15:57 | |
alaski | it was optimistic to add that field in, and has just been a source of confusion since then | 15:57 |
*** Apoorva has joined #openstack-nova | 15:57 | |
mriedem | alaski: ok - we also decided to not go down that route | 15:57 |
mriedem | maybe i'll add some comments in the code explaining it's never used currently, | 15:58 |
alaski | cool | 15:58 |
mriedem | and if we did, we'd have to do a data migration to actually "finish" old actions | 15:58 |
*** Nel1x has joined #openstack-nova | 15:58 | |
*** Apoorva has quit IRC | 15:58 | |
vdrok | mriedem: hrm, that means we can remap a running instance from compute in one cell to a compute in another one. I guess we'll need to change that | 15:58 |
mriedem | remap? | 15:59 |
vdrok | yeah, we decide which compute manages which instance by hash ring, IIRC | 15:59 |
*** burgerk has joined #openstack-nova | 15:59 | |
vdrok | s/instance/hypervisor in our case | 16:00 |
*** Apoorva has joined #openstack-nova | 16:00 | |
*** david-lyle has joined #openstack-nova | 16:00 | |
*** sree has quit IRC | 16:01 | |
*** penick has quit IRC | 16:03 | |
*** dtp has quit IRC | 16:03 | |
*** _jarvis has quit IRC | 16:04 | |
*** arahal__ has joined #openstack-nova | 16:07 | |
*** arahal_ has quit IRC | 16:09 | |
*** rajathagasthya has joined #openstack-nova | 16:17 | |
*** lucasagomes is now known as lucas-afk | 16:21 | |
*** tbachman has quit IRC | 16:21 | |
*** sree has joined #openstack-nova | 16:22 | |
*** tuanla_fujitsu has joined #openstack-nova | 16:25 | |
*** tbachman has joined #openstack-nova | 16:25 | |
dansmith | vdrok: correct | 16:27 |
*** slaweq has joined #openstack-nova | 16:27 | |
vdrok | dansmith: correct about ServiceList containing only this cell computes or about "we have to change it"? :) | 16:28 |
*** eharney has quit IRC | 16:28 | |
dansmith | vdrok: sorry, I was reading the scrollback in order and answering in order | 16:28 |
mriedem | vdrok: who changes the mapping? ironic? or the driver? | 16:28 |
dansmith | vdrok: so, if you put computes in two cells and point them at a single ironic, | 16:28 |
dansmith | then you'd have problems | 16:28 |
mriedem | if it's the driver, the driver is in a cell and only has visibility to other compute services in that same cell | 16:28 |
*** eharney has joined #openstack-nova | 16:28 | |
vdrok | mriedem: the driver | 16:28 |
dansmith | vdrok: but you can't really handle that in your hash ring code, so I would say that the only reason you'd have multiple cells in ironic would be if you had two ironics | 16:28 |
dansmith | vdrok: or if ironic grows a cells-like partitioning scheme at some point in the future | 16:29 |
vdrok | dansmith: mhm, so it seems like multicell is not for us at all in gate :) | 16:29 |
vdrok | gotcha | 16:29 |
dansmith | vdrok: that might be a good reason to not run the gate job in multicell mode forever | 16:29 |
dansmith | yeah | 16:29 |
*** slaweq has quit IRC | 16:31 | |
*** slaweq has joined #openstack-nova | 16:31 | |
*** slaweq_ has joined #openstack-nova | 16:31 | |
*** karthiks has quit IRC | 16:32 | |
*** slaweq_ has quit IRC | 16:32 | |
*** Swami has quit IRC | 16:32 | |
*** slaweq_ has joined #openstack-nova | 16:33 | |
*** yamamoto has quit IRC | 16:33 | |
*** ralonsoh has quit IRC | 16:34 | |
*** sambetts is now known as sambetts|afk | 16:35 | |
mriedem | what is a PV guest in xen? | 16:35 |
mriedem | paravirtualization? | 16:35 |
mriedem | == nested virt? | 16:35 |
mriedem | like qemu? | 16:35 |
*** slaweq has quit IRC | 16:35 | |
*** felipemonteiro has joined #openstack-nova | 16:36 | |
*** dtp has joined #openstack-nova | 16:36 | |
cdent | mriedem: did you already find this: https://wiki.xen.org/wiki/Paravirtualization_(PV) | 16:40 |
mriedem | yeah | 16:40 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add release note for xenapi virt device tagging support https://review.openstack.org/481148 | 16:40 |
mriedem | i was just being lazy | 16:40 |
cdent | how virtuous of you | 16:40 |
*** rajathag_ has joined #openstack-nova | 16:42 | |
*** kaisers_ has joined #openstack-nova | 16:42 | |
dansmith | mriedem: pv is not like nested virt or qemu | 16:42 |
dansmith | not sure if you gathered all that | 16:42 |
mriedem | dansmith: yeah got that from the wiki | 16:42 |
dansmith | it's closer to a container, but with a full separate guest kernel | 16:42 |
dansmith | okay | 16:42 |
*** rajathagasthya has quit IRC | 16:42 | |
*** hieulq_ has quit IRC | 16:43 | |
*** slaweq_ has quit IRC | 16:44 | |
*** kaisers_ has quit IRC | 16:46 | |
*** slaweq has joined #openstack-nova | 16:46 | |
*** hshiina has quit IRC | 16:47 | |
*** vks1 has joined #openstack-nova | 16:51 | |
*** armax has joined #openstack-nova | 16:56 | |
gaurangt | hi, is there a bug in nova (ocata) where when failed instances are removed, the quota values are not updated? I am observing this behavior in my setup. Used quota values are updated properly only when an active instance is deleted. | 16:57 |
*** Swami has joined #openstack-nova | 16:59 | |
*** baoli has quit IRC | 17:00 | |
*** baoli has joined #openstack-nova | 17:01 | |
*** damien_r has quit IRC | 17:02 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Improve allocation_cadidates coverage https://review.openstack.org/481153 | 17:05 |
cdent | jaypipes: ^ discovered that while trying to reacquaint myself with the allocation candidates code | 17:06 |
cdent | should be an easy merge | 17:06 |
mriedem | yeah i think alex asked for that test | 17:09 |
jaypipes | cdent: +2 from me. | 17:09 |
cdent | ah well, there it is | 17:09 |
cdent | cool, thanks | 17:09 |
*** vks1 has quit IRC | 17:11 | |
*** fragatina has joined #openstack-nova | 17:11 | |
*** harlowja has joined #openstack-nova | 17:13 | |
*** zzzeek has quit IRC | 17:14 | |
*** sridharg has quit IRC | 17:14 | |
*** lpetrut has quit IRC | 17:16 | |
*** baoli has quit IRC | 17:16 | |
*** abalutoiu has quit IRC | 17:21 | |
dansmith | jaypipes: even with that typo? | 17:23 |
*** jmlowe has quit IRC | 17:23 | |
jaypipes | dansmith: hmm? | 17:23 |
dansmith | jaypipes: allocation_cadidates | 17:24 |
jaypipes | dansmith: cadidated? :) | 17:24 |
jaypipes | heh, yeah, just noticed that | 17:24 |
cdent | oh noes | 17:24 |
jaypipes | although I just typoed the typo. | 17:24 |
cdent | orz | 17:24 |
jaypipes | dansmith: it would have been fine if it had a parens on a single line. | 17:24 |
*** fragatina has quit IRC | 17:25 | |
*** udesale has quit IRC | 17:25 | |
*** baoli has joined #openstack-nova | 17:25 | |
*** fragatina has joined #openstack-nova | 17:25 | |
dansmith | jaypipes: so what you're saying is, you have low standards in general, right? | 17:25 |
jaypipes | dansmith: you're awfully ornery today. | 17:26 |
* dansmith snarls | 17:26 | |
*** vks1 has joined #openstack-nova | 17:28 | |
*** ijw has joined #openstack-nova | 17:31 | |
*** tuanla_fujitsu has quit IRC | 17:32 | |
*** hieulq has quit IRC | 17:33 | |
*** zzzeek has joined #openstack-nova | 17:33 | |
*** trungnv has quit IRC | 17:33 | |
*** jwcroppe has quit IRC | 17:33 | |
*** ijw has quit IRC | 17:33 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: xenapi: avoid unnecessary BDM query when building device metadata https://review.openstack.org/481162 | 17:33 |
*** ijw has joined #openstack-nova | 17:34 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: [placement] Improve allocation_candidates coverage https://review.openstack.org/481153 | 17:34 |
*** yamamoto has joined #openstack-nova | 17:34 | |
mriedem | there you go | 17:34 |
*** ijw has quit IRC | 17:35 | |
*** krtaylor has quit IRC | 17:35 | |
*** zzzeek has quit IRC | 17:37 | |
*** jpena is now known as jpena|off | 17:38 | |
*** yamamoto has quit IRC | 17:39 | |
*** zzzeek has joined #openstack-nova | 17:41 | |
*** sshwarts has quit IRC | 17:43 | |
*** itlinux has quit IRC | 17:43 | |
*** smatzek has quit IRC | 17:44 | |
*** arahal__ has quit IRC | 17:47 | |
*** rajathag_ has quit IRC | 17:48 | |
*** hieulq has joined #openstack-nova | 17:48 | |
*** trungnv has joined #openstack-nova | 17:48 | |
dansmith | mriedem: thanks now I can sleep tonight | 17:49 |
mriedem | just fyi, i lost all kinds of sleep last night over that task_state thing we talked about | 17:51 |
*** sree has quit IRC | 17:51 | |
dansmith | heh | 17:51 |
*** zzzeek has quit IRC | 17:53 | |
*** iceyao has quit IRC | 17:57 | |
*** rdo_ has joined #openstack-nova | 17:58 | |
*** arahal__ has joined #openstack-nova | 17:59 | |
*** jwcroppe has joined #openstack-nova | 17:59 | |
*** fragatin_ has joined #openstack-nova | 17:59 | |
*** zzzeek has joined #openstack-nova | 18:00 | |
*** vks1 has quit IRC | 18:00 | |
*** efoley has quit IRC | 18:01 | |
*** fragatina has quit IRC | 18:03 | |
*** dave-mccowan has joined #openstack-nova | 18:03 | |
*** jwcroppe has quit IRC | 18:04 | |
*** slaweq has quit IRC | 18:05 | |
*** rajathagasthya has joined #openstack-nova | 18:05 | |
*** slaweq has joined #openstack-nova | 18:05 | |
*** baoli has quit IRC | 18:06 | |
*** jwcroppe has joined #openstack-nova | 18:07 | |
*** zzzeek_ has joined #openstack-nova | 18:08 | |
*** zzzeek has quit IRC | 18:09 | |
*** slaweq has quit IRC | 18:11 | |
*** slaweq has joined #openstack-nova | 18:11 | |
*** krtaylor has joined #openstack-nova | 18:12 | |
*** abalutoiu has joined #openstack-nova | 18:12 | |
*** ijw has joined #openstack-nova | 18:14 | |
cdent | jaypipes: are you around, I'm having some confusion over the format of the allocations requests in the candidates response | 18:15 |
cdent | this is what an allocation update looks like: https://review.openstack.org/#/c/470933/10/placement-api-ref/source/update-allocations-request.json | 18:15 |
cdent | it's a list of multiple providers | 18:15 |
jaypipes | cdent: right. | 18:16 |
*** slaweq has quit IRC | 18:16 | |
jaypipes | cdent: and allocation candidates is a list of that HTTP request structure. | 18:16 |
cdent | but the output from allocation_candidates (by the docstring at least) is not | 18:16 |
jaypipes | (without the project_id and user_id of course, since it's not yet known) | 18:16 |
jaypipes | cdent: link? | 18:16 |
*** slaweq has joined #openstack-nova | 18:17 | |
*** gjayavelu has joined #openstack-nova | 18:17 | |
*** slaweq has quit IRC | 18:17 | |
cdent | oh wait, I think maybe I'm just misreading the docstring on _transform_allocation_requests | 18:17 |
*** burt has joined #openstack-nova | 18:17 | |
cdent | not sure | 18:17 |
*** slaweq has joined #openstack-nova | 18:17 | |
cdent | I see a list of dicts | 18:17 |
cdent | but I'm expecting to see a list of lists of dicts | 18:18 |
*** ijw has quit IRC | 18:18 | |
*** burgerk_ has joined #openstack-nova | 18:18 | |
cdent | https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/allocation_candidate.py#L55 | 18:18 |
jaypipes | cdent: well, the allocation requests response part is a list of dicts, with the dicts having a single key "allocations" that itself is a list of dicts :) | 18:18 |
jaypipes | cdent: thus, matching the required request payload for PUT /allocations/{uuid} | 18:19 |
cdent | ah, so the word 'allocations' is repeated many times | 18:19 |
cdent | that's what threw me off | 18:19 |
jaypipes | cdent: yeah, I know :( | 18:20 |
*** lpetrut has joined #openstack-nova | 18:20 | |
jaypipes | cdent: it's just that's the payload of the request... | 18:20 |
jaypipes | cdent: the code originally didn't have that repeated allocations key thing but then I realized that wasn't actually what the HTTP payload needed :) | 18:20 |
cdent | except without the project and user it has to be cooked anyway | 18:20 |
jaypipes | ya | 18:20 |
* cdent shrugs | 18:21 | |
cdent | this is probably not the best code for getting me back into a reviewing frame of mind. it is rather dense | 18:21 |
jaypipes | cdent: indeed. | 18:21 |
jaypipes | cdent: WELCOME BACK from PTO! :P | 18:22 |
*** burgerk has quit IRC | 18:22 | |
*** lpetrut has quit IRC | 18:22 | |
*** burgerk_ has quit IRC | 18:22 | |
cdent | I liked it out there in the world. I might have to go back. | 18:23 |
*** yamahata has quit IRC | 18:24 | |
*** krtaylor has quit IRC | 18:28 | |
*** kaisers_ has joined #openstack-nova | 18:28 | |
cdent | jaypipes: i left some comment on the scheduler side of using candidates (both patches). Overall it seems mostly sane (if a bit dense). instance_uuids is only ever greater than one if someone has requested N of the exact same thing, yes? So affinity doesn't come into play? | 18:28 |
jaypipes | cdent: correct. | 18:29 |
*** lpetrut has joined #openstack-nova | 18:29 | |
cdent | ✔ | 18:29 |
*** ijw has joined #openstack-nova | 18:31 | |
*** kaisers_ has quit IRC | 18:32 | |
*** krtaylor has joined #openstack-nova | 18:33 | |
*** ijw has quit IRC | 18:36 | |
*** yamamoto has joined #openstack-nova | 18:37 | |
*** slaweq has quit IRC | 18:37 | |
*** slaweq has joined #openstack-nova | 18:37 | |
*** slaweq has quit IRC | 18:38 | |
*** kaisers_ has joined #openstack-nova | 18:38 | |
*** ijw has joined #openstack-nova | 18:40 | |
*** arahal__ has quit IRC | 18:41 | |
*** arahal__ has joined #openstack-nova | 18:41 | |
*** ckopper has joined #openstack-nova | 18:42 | |
*** yamamoto has quit IRC | 18:45 | |
cdent | jaypipes, edleafe: has there been discussion or decision on whether the query parameter interfaces to /resource_providers and /allocation_candidates should/will have parity? | 18:47 |
*** ijw has quit IRC | 18:47 | |
*** bauzas has quit IRC | 18:47 | |
cdent | related, edleafe, is this (filtering rps on traits) still a thing: https://review.openstack.org/#/c/474602/ | 18:48 |
*** bauzas has joined #openstack-nova | 18:49 | |
edleafe | cdent: Heh, your guess is as good as mine. I'm not sure if the plan is still to add that for Pike | 18:50 |
edleafe | cdent: And if it is, it will have to be copied to the allocation code. | 18:50 |
cdent | I guess the more immediately salient question for edleafe is: are you still managing that patch? | 18:51 |
edleafe | cdent: yes | 18:51 |
cdent | cool, thanks | 18:51 |
*** hieulq has quit IRC | 18:51 | |
*** trungnv has quit IRC | 18:51 | |
cdent | i'm regrouping my links to things | 18:51 |
edleafe | cdent: I'm also not clear on whether the /resource_providers filtering is going to continue to be a supported thing | 18:52 |
mriedem | filtering by traits is definitely high risk at this point | 18:52 |
mriedem | i don't see why we'd add more to GET /resource_providers, | 18:52 |
mriedem | when we use /allocation_candidates now | 18:52 |
mriedem | i mean, we could, but not a priority for nova scheduling atm | 18:52 |
cdent | mriedem: because sometimes you just want to know about resource providers? | 18:52 |
cdent | oh, yeah, that | 18:52 |
cdent | sure | 18:52 |
edleafe | mriedem: well, yeah, that's my thinking. Except that others may be relying on it being completed | 18:53 |
mriedem | what others? | 18:53 |
mriedem | changes or people? | 18:53 |
mriedem | or https://en.wikipedia.org/wiki/The_Others_(2001_film) ? | 18:53 |
edleafe | mriedem: any other group that is waiting for placement to be fully funcitonal for their needs | 18:53 |
mriedem | gggghost kids! | 18:53 |
*** READ10 has quit IRC | 18:54 | |
mriedem | edleafe: let those groups speak up if they are | 18:54 |
mriedem | because so far they are silent | 18:54 |
mriedem | probably b/c they are ghost kids | 18:54 |
edleafe | mriedem: I just have this silly voice in my head that wants me to think that Placement != Nova | 18:54 |
mriedem | sure, but realize we have 3 weeks | 18:54 |
mriedem | claims in the scheduler is the end goal right? | 18:54 |
mriedem | and allocation candidates is a dependency for that | 18:54 |
edleafe | mriedem: for pike, yes | 18:54 |
mriedem | any other utopian sugar is probably queens | 18:54 |
edleafe | I didn't mean to imply that it would be a thing for pike, just that it might be useful to others at some point | 18:55 |
mriedem | sure, but let's worry about that when it definitely is | 18:55 |
edleafe | if we never worry about it, it never will be | 18:56 |
*** itlinux has joined #openstack-nova | 18:58 | |
mriedem | are we going to compete on the worriness scale? | 18:58 |
edleafe | like I said, I keep thinking that placement is a thing in itself, and not a nova subsystem | 19:01 |
mriedem | nothing i'm talking about makes it a nova subsystem | 19:01 |
*** yamahata has joined #openstack-nova | 19:02 | |
*** jmlowe has joined #openstack-nova | 19:03 | |
* cdent offers jmlowe a bourbon | 19:03 | |
jmlowe | thanks! | 19:04 |
jmlowe | you have my attention | 19:04 |
jaypipes | cdent: parity, no. will there likely be a couple more parameters to the allocation candidates call? yeah. | 19:04 |
cdent | jmlowe: that's all you get | 19:04 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/481189 | 19:05 |
jmlowe | damn, I'll go back to ignoring this channel for another 1k-2k messages | 19:05 |
cdent | best choice for your mental health | 19:05 |
openstackgerrit | Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288 | 19:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | 19:06 |
*** hieulq has joined #openstack-nova | 19:06 | |
*** trungnv has joined #openstack-nova | 19:07 | |
* cdent waves | 19:11 | |
*** cdent has quit IRC | 19:11 | |
*** shaner has quit IRC | 19:11 | |
*** tbachman has quit IRC | 19:11 | |
*** abalutoiu has quit IRC | 19:11 | |
*** pcaruana has quit IRC | 19:12 | |
*** yamamoto has joined #openstack-nova | 19:13 | |
*** adisky__ has quit IRC | 19:14 | |
melwitt | dansmith: I've mostly removed the instance uuid from the access url for the console stuff, but met a confusing point regarding the transition period between consoleauth/memcached and the database backend, | 19:16 |
melwitt | the code in the console proxy was using the presence of the instance uuid to determine whether to go to the database backend for validation vs going to the consoleauth service, | 19:16 |
melwitt | without the instance uuid, we don't really know if the access url is old or new, memcached or database. I'm not sure what to do about that | 19:16 |
melwitt | I thought, could try first for the database, if that fails, try consoleauth, if that fails too then it's really invalid. but that assumes the operator is running consoleauth still. which might be okay | 19:16 |
melwitt | my concern there is after all of the outstanding consoles have moved to the database backend, it's safe to stop running consoleauth, but then the fallback behavior should also be turned off. | 19:17 |
melwitt | so I was thinking we might need a config option | 19:17 |
dansmith | I don't have this cached in my head.. if hitting the DB is the way forward, | 19:17 |
dansmith | why not just always do that and stop looking at the auth cache? | 19:17 |
dansmith | could have a workaround conf for it I guess, but if database always works... | 19:18 |
melwitt | because of existing urls that people might be using, that had been generated pre-database | 19:18 |
mriedem | jaypipes: ok comments inline https://review.openstack.org/#/c/476631/ | 19:18 |
dansmith | melwitt: aren't those expired in like an hour or something? | 19:18 |
melwitt | dansmith: maybe. I was thinking that, the easy way would be just invalidate them all and make people get new urls. but I dunno how accommodating we need to be about the transition | 19:19 |
dansmith | melwitt: if it's a short timeout, I don't think we should need to jump through crazy hoops for that | 19:19 |
melwitt | k. I'll double check what it is | 19:20 |
dansmith | I wish we could talk about this and fix it in like one week.. I keep paging this data in and out of my brain | 19:20 |
*** yamamoto has quit IRC | 19:21 | |
*** slaweq has joined #openstack-nova | 19:23 | |
*** slaweq has quit IRC | 19:25 | |
*** fragatin_ has quit IRC | 19:28 | |
*** fragatina has joined #openstack-nova | 19:29 | |
mriedem | give your mind a break, | 19:29 |
mriedem | with christopher cross https://www.youtube.com/watch?v=VMkIuKXwmlU | 19:29 |
mriedem | he's like the fat older brother of that guy from the guardians of the galaxy movies | 19:29 |
melwitt | hah, I was just thinking, he looks like somebody else | 19:30 |
mriedem | chris pratt | 19:30 |
mriedem | http://i.huffpost.com/gen/1939272/images/o-CHRIS-PRATT-facebook.jpg | 19:30 |
mriedem | same fing person | 19:30 |
melwitt | hahaha | 19:31 |
mriedem | he's got 18 strings but only needs like 6 | 19:32 |
mriedem | maybe 4 | 19:32 |
melwitt | there's a lot about this scene I didn't expect considering how the song sounds | 19:32 |
mriedem | the jersey | 19:32 |
*** shaner has joined #openstack-nova | 19:32 | |
mriedem | laid | 19:32 |
mriedem | back | 19:32 |
melwitt | this consoles code doesn't make any sense to me. says "Remove expired tokens from the cache." but I only see a "get" no delete of them | 19:35 |
*** tbachman has joined #openstack-nova | 19:37 | |
mriedem | shouldn't the cache auto remove things based on the timer? | 19:38 |
mriedem | using oslo.cache i assume | 19:38 |
mriedem | it might just be an old comment from when we switched over to oslo.cache, | 19:38 |
mriedem | that was never cleaned up | 19:38 |
melwitt | the token cache is a memcached thing. and as far as I can tell, it doesn't expire anything. I'm sure I'm just not finding where it is maybe | 19:39 |
mriedem | i.e. maybe before that refactor we were manually removing things? | 19:39 |
melwitt | oh, hm | 19:39 |
mriedem | i think there is a default timeout in oslo.cache | 19:39 |
mriedem | https://docs.openstack.org/oslo.cache/latest/opts.html | 19:39 |
melwitt | I see. thanks | 19:40 |
mriedem | i'm only guessing, i do remember going over the patch in nova that converted to use oslo.cache though and had questions like this | 19:40 |
*** arahal__ has quit IRC | 19:41 | |
*** arahal_ has joined #openstack-nova | 19:41 | |
melwitt | yeah, I think you're right though. the consoleauth stuff just uses nova/cache_utils and in cache_utils I see there's oslo_cache.dict and dogpile.cache.memcached as options. I'm not sure what/how we default to | 19:42 |
melwitt | default TTL is 600, so 10 minutes. a lot shorter than I thought | 19:45 |
* melwitt plays christopher cross again | 19:47 | |
mriedem | ildikov: i see the live migration change isn't in this series https://review.openstack.org/#/c/330285/ | 19:47 |
mriedem | ildikov: so, i guess to test the new api flow plus live migration, we can just do a DNM nova change that depends on both | 19:47 |
mriedem | yeah? | 19:47 |
*** yamamoto has joined #openstack-nova | 19:49 | |
*** xyang1 has joined #openstack-nova | 19:49 | |
ildikov | mriedem: I can add it to the chain or just do what you say | 19:50 |
mriedem | ildikov: let's test it out first, i'll push a patch | 19:50 |
ildikov | mriedem: sounds good, thanks | 19:51 |
melwitt | okay, so if they configured oslo.cache themselves we use that, if they didn't, we make it a oslo_cache.dict | 19:51 |
*** moshele has joined #openstack-nova | 19:51 | |
mriedem | from what i remember, if it's not configured for some other backend, we use an in-memory dogpile cache dict cache yeah | 19:52 |
melwitt | your memory is excellent | 19:52 |
openstackgerrit | Moshe Levi proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265 | 19:53 |
mriedem | all that clean livin' | 19:53 |
*** yamamoto has quit IRC | 19:53 | |
*** iceyao has joined #openstack-nova | 19:55 | |
melwitt | dansmith: so the default TTL is 10 minutes but they could configure it for a lot longer | 19:55 |
dansmith | melwitt: yeah | 19:55 |
dansmith | melwitt: I dunno, I think it's fine to say "db is the way forward, memcache is deprecated, if you need, make sure you've configured for db and given enough time for things to expire before rolling | 19:56 |
melwitt | I dunno how big of a deal it would be. if we don't try to fall back on consoleauth, then at worst they get a InvalidToken and have to re-get a new access url and do again | 19:57 |
dansmith | right | 19:57 |
dansmith | there's some config thing now to choose whether we use memcache for that or not, right? | 19:58 |
*** lbragstad has quit IRC | 19:58 | |
melwitt | dansmith: not yet. there was described in the spec, but I think it wasn't added bc instance uuid presence could be used to detect old vs new (that's my speculation, I don't see it documented why they didn't go ahead with the config option) | 19:58 |
dansmith | oh I see | 19:58 |
dansmith | but | 19:59 |
dansmith | and so the code to always do it in the DB is unmerged? | 19:59 |
melwitt | I think the original design didn't have instance uuid (that was only added bc cells v2 + one proxy at top) and so they had the idea of the config option | 19:59 |
melwitt | yeah, nothing is happening in the DB yet | 19:59 |
*** iceyao has quit IRC | 19:59 | |
dansmith | ah, okay I see | 20:00 |
dansmith | so | 20:00 |
dansmith | how about: | 20:00 |
dansmith | 1. Default to only db | 20:00 |
dansmith | 2. Workaround to check memcache first, fall back to db | 20:00 |
dansmith | 3. Expect that going forward for Queens it'll be db only | 20:00 |
dansmith | and a reno to say if you really really care about not resetting consoles, do the workaorund | 20:01 |
dansmith | I think we discussed forcing the console reset at some point | 20:01 |
*** pchavva has quit IRC | 20:02 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova master: update live migration to use v3 cinder api https://review.openstack.org/463987 | 20:02 |
melwitt | dansmith: you mean add the config option for that right? where the choices are "DB only" and "consoleauth + DB" | 20:02 |
dansmith | melwitt: well, make it a workarounds config | 20:03 |
melwitt | oh, workarounds config. okay | 20:03 |
melwitt | I forgot about those | 20:03 |
dansmith | melwitt: call it [workarounds]/my_users_are_very_delicate_and_need_handholding=True | 20:03 |
*** lbragstad has joined #openstack-nova | 20:03 | |
melwitt | :D sure | 20:03 |
dansmith | I think that messages it as "this is a transitional helper thingy" | 20:03 |
melwitt | yeah, makes sense | 20:04 |
dansmith | could default it to true I guess, but I would say default to false and note it in the reno | 20:04 |
dansmith | because I expect very few people will need it | 20:04 |
* melwitt nods | 20:04 | |
openstackgerrit | Moshe Levi proposed openstack/os-vif master: unplug_vf_passthrough: don't try to delete representor netdev https://review.openstack.org/478820 | 20:05 |
openstackgerrit | Moshe Levi proposed openstack/os-vif master: fix read the representor phys_port_name https://review.openstack.org/480213 | 20:05 |
*** ijw has joined #openstack-nova | 20:06 | |
* melwitt forges ahead | 20:06 | |
*** gbarros has joined #openstack-nova | 20:09 | |
*** moshele has quit IRC | 20:10 | |
*** kaisers_ has quit IRC | 20:10 | |
*** kaisers_ has joined #openstack-nova | 20:11 | |
*** arahal_ has quit IRC | 20:12 | |
*** ijw has quit IRC | 20:13 | |
*** felipemonteiro has quit IRC | 20:14 | |
*** liverpooler has quit IRC | 20:15 | |
*** iceyao has joined #openstack-nova | 20:16 | |
*** kaisers_ has quit IRC | 20:16 | |
*** iceyao has quit IRC | 20:20 | |
*** hieulq has quit IRC | 20:21 | |
*** trungnv has quit IRC | 20:23 | |
*** ijw has joined #openstack-nova | 20:32 | |
*** trungnv has joined #openstack-nova | 20:36 | |
*** hieulq has joined #openstack-nova | 20:37 | |
*** ijw has quit IRC | 20:37 | |
dims | mriedem : jaypipes : do you remember "why" there was pushback on the ConfKeyManager being in castellan? can't seem to find the email thread mentioned in the spec | 20:38 |
mriedem | ConfKeyManager? | 20:38 |
dims | mriedem : https://github.com/openstack/nova/search?utf8=%E2%9C%93&q=ConfKeyManager&type= | 20:39 |
*** slaweq has joined #openstack-nova | 20:39 | |
*** iceyao has joined #openstack-nova | 20:40 | |
dims | mriedem : was reading "Move ConfKeyManager elsewhere" section in https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/use-castellan-key-manager.html | 20:40 |
mriedem | i think the spec was updated here https://review.openstack.org/#/c/338518/ | 20:40 |
dims | yep, reading the updated text | 20:41 |
mriedem | i don't think it was in the ML | 20:41 |
mriedem | it was discussion in a patch or irc between kfarr, sdague and myself | 20:41 |
dims | mriedem : "Might be good to add a link to a ML discussion about the expressed concern?" was a note jay added to the review | 20:42 |
mriedem | yeah, it wasn't in the ML | 20:42 |
dims | ok, the only reference i see in ML is an assertion "but it will not live in castellan" http://lists.openstack.org/pipermail/openstack-dev/2016-January/083347.html | 20:42 |
mriedem | i can't seem to find where this came up in gerrit | 20:44 |
*** iceyao has quit IRC | 20:44 | |
dims | mriedem : i am looking at line 125 in https://review.openstack.org/#/c/338518/3/specs/newton/implemented/use-castellan-key-manager.rst | 20:44 |
dims | "The community has expressed concern about ConfKeyManager" | 20:45 |
mriedem | dims: i understand that you're reading that :) | 20:45 |
dims | ah :) | 20:45 |
mriedem | where and how the community expressed concern is not clear | 20:45 |
*** awaugama has quit IRC | 20:45 | |
mriedem | i'm pretty sure it was an irc discussion or something like that between kfarr, sdague and myself | 20:45 |
dims | right, just seems kaitlin's email | 20:45 |
mriedem | and we asked kfarr to update the spec | 20:45 |
mriedem | which is that change | 20:45 |
mriedem | that spec update was last july | 20:46 |
mriedem | the ML thread was from jan 2016 | 20:46 |
dims | y, chasing ghosts | 20:46 |
mriedem | i think it basically amounted to, | 20:47 |
mriedem | barbican didn't want a fake key manager b/c it's not secure, obviously, | 20:47 |
mriedem | but the rest of us don't want fake key managers in nova/cinder/anywhere else that's copied that pattern for testing, | 20:47 |
dims | right, this is castellan | 20:47 |
mriedem | and because barbican isn't in base devstack, | 20:47 |
mriedem | we can't get it from barbican | 20:47 |
mriedem | *we can't use barbican, or rely on it being in the dsvm env | 20:47 |
dims | yep | 20:47 |
dims | that's what i am chasing prompted by a ping from ttx about potentially making barbican a base service in the future | 20:48 |
dims | there are 2 ConfKeyManager(s) one in cinder and one in nova :) | 20:48 |
mriedem | yeah and the cinder one is a copy of the nova one | 20:49 |
*** ijw has joined #openstack-nova | 20:53 | |
mriedem | found it | 20:53 |
mriedem | you owe me $5 | 20:53 |
dims | looks like setting the api_class is never used in any tests | 20:53 |
*** takashin has joined #openstack-nova | 20:54 | |
dims | http://codesearch.openstack.org/?q=BarbicanKeyManager&i=nope&files=&repos= | 20:54 |
mriedem | http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2016-06-13.log.html#t2016-06-13T18:44:47 | 20:54 |
mriedem | https://review.openstack.org/#/c/273717/ | 20:54 |
mriedem | it was prompted by that devstack change | 20:54 |
*** krtaylor has quit IRC | 20:54 | |
dims | thanks mriedem ! i still have some RMB you can have :) | 20:55 |
mriedem | me too | 20:55 |
*** butt is now known as hemna | 20:57 | |
*** esberglu has quit IRC | 20:57 | |
*** lucasxu has quit IRC | 20:57 | |
*** esberglu has joined #openstack-nova | 20:57 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Pre-load instance.device_metadata in InstanceMetadata https://review.openstack.org/481235 | 20:59 |
mriedem | dansmith: claudiub pointed this out the other day ^ | 20:59 |
*** iceyao has joined #openstack-nova | 20:59 | |
dansmith | mriedem: I put a patch up for it, | 20:59 |
mriedem | oh | 20:59 |
mriedem | same big | 20:59 |
mriedem | *bug? | 20:59 |
dansmith | mriedem: but I think the right approach is different, and he put one up for it | 20:59 |
dansmith | https://review.openstack.org/#/c/479335/ | 21:00 |
dansmith | yeah | 21:00 |
*** ijw has quit IRC | 21:00 | |
*** ijw has joined #openstack-nova | 21:00 | |
melwitt | are we doing a nova meeting today? | 21:01 |
mriedem | yes | 21:01 |
mriedem | crap | 21:01 |
*** jmlowe has quit IRC | 21:01 | |
mriedem | dansmith: this is his i guess? https://review.openstack.org/#/c/479335/ | 21:02 |
*** esberglu has quit IRC | 21:02 | |
dansmith | mriedem: I just pasted that bove :) | 21:02 |
*** cdent has joined #openstack-nova | 21:02 | |
mriedem | oh i was looking at yours | 21:03 |
*** iceyao has quit IRC | 21:03 | |
*** jmlowe has joined #openstack-nova | 21:09 | |
*** baoli has joined #openstack-nova | 21:12 | |
*** baoli has quit IRC | 21:13 | |
*** cdent has quit IRC | 21:13 | |
dansmith | mriedem: oh I bet you were | 21:13 |
mriedem | i was less than impressed | 21:13 |
dansmith | daaaum.. | 21:14 |
mriedem | not sure i care for claudiub's change since it's specific to the virt driver, and xenapi just added this same support | 21:15 |
mriedem | but i think xenapi will be ok because they also blindly set instance.device_metadata | 21:15 |
dansmith | mriedem: well, the deal is, we needn't load this because libvirt always has this set once it has resolved the devices | 21:15 |
dansmith | so I think the better thing is to make sure that's the assumed behavior, | 21:15 |
mriedem | i know it's not an issue for libvirt | 21:15 |
dansmith | otherwise we're just lazy-loading nothing | 21:15 |
dansmith | we can do both I guess just to make sure we don't get the 'splosion | 21:16 |
*** baoli has joined #openstack-nova | 21:16 | |
mriedem | yeah see that's the other thing, the comment in the change to pre-load those said it was doing ec2_ids and keypairs because those are known to be used in there, | 21:16 |
mriedem | device_metadata clearly is also | 21:16 |
dansmith | yeah, fair enough | 21:17 |
*** tbachman has quit IRC | 21:17 | |
mriedem | i'll just move my test over to your patch and +W it | 21:17 |
dansmith | already abandoned and +2d yours | 21:18 |
mriedem | guh | 21:18 |
dansmith | you had nothing but mean things to say about mine | 21:18 |
mriedem | i'm sorry | 21:19 |
mriedem | a little | 21:19 |
dansmith | yours was a little bigger | 21:19 |
mriedem | "I think you mean "touch"" - i try to avoid getting sued | 21:20 |
dansmith | since when? | 21:20 |
dansmith | this is news to me | 21:20 |
mriedem | about 20 minutes ago | 21:20 |
dansmith | haha | 21:20 |
*** jmlowe has quit IRC | 21:25 | |
*** lpetrut has quit IRC | 21:30 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test new style volume attach with live migration https://review.openstack.org/481290 | 21:30 |
mriedem | ildikov: stvnoyes1: ^ should test live migration with the new style volume attachments | 21:30 |
mriedem | assuming it all merges | 21:30 |
ildikov | mriedem: fingers crossed :) | 21:31 |
ildikov | mriedem: and thanks | 21:31 |
*** thorst has quit IRC | 21:33 | |
*** krtaylor has joined #openstack-nova | 21:35 | |
*** itlinux has quit IRC | 21:40 | |
melwitt | mriedem: looks like zuul is angry with your patch | 21:41 |
mriedem | zuul be damned | 21:41 |
melwitt | heh | 21:41 |
*** itlinux has joined #openstack-nova | 21:41 | |
*** jmlowe has joined #openstack-nova | 21:42 | |
*** tbachman has joined #openstack-nova | 21:45 | |
*** slaweq has quit IRC | 21:51 | |
*** slaweq has joined #openstack-nova | 21:51 | |
*** xyang1 has quit IRC | 21:52 | |
*** hieulq has quit IRC | 21:53 | |
*** trungnv has quit IRC | 21:53 | |
openstackgerrit | Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | 21:54 |
*** catintheroof has quit IRC | 21:55 | |
openstackgerrit | Mike Perez proposed openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | 21:56 |
*** tbachman has quit IRC | 21:58 | |
*** ckopper has quit IRC | 21:59 | |
*** mkucia has joined #openstack-nova | 22:02 | |
*** lyan has quit IRC | 22:02 | |
*** slaweq has quit IRC | 22:03 | |
*** burt has quit IRC | 22:03 | |
*** dave-mccowan has quit IRC | 22:05 | |
*** felipemonteiro has joined #openstack-nova | 22:07 | |
*** trungnv has joined #openstack-nova | 22:08 | |
*** tbachman has joined #openstack-nova | 22:08 | |
*** hieulq has joined #openstack-nova | 22:08 | |
openstackgerrit | Octave Orgeron proposed openstack/nova master: Enables MySQL Cluster Support for Nova https://review.openstack.org/446643 | 22:08 |
*** slaweq has joined #openstack-nova | 22:09 | |
*** slaweq has quit IRC | 22:10 | |
*** slaweq has joined #openstack-nova | 22:12 | |
*** ijw has quit IRC | 22:16 | |
*** slaweq has quit IRC | 22:17 | |
*** ijw has joined #openstack-nova | 22:18 | |
*** jamesdenton has quit IRC | 22:18 | |
*** jamesdenton has joined #openstack-nova | 22:20 | |
*** ijw has quit IRC | 22:22 | |
*** jamesden_ has joined #openstack-nova | 22:23 | |
*** edmondsw has quit IRC | 22:23 | |
*** arahal_ has joined #openstack-nova | 22:24 | |
*** jamesdenton has quit IRC | 22:25 | |
*** ijw has joined #openstack-nova | 22:26 | |
openstackgerrit | Merged openstack/nova master: [placement] Improve allocation_candidates coverage https://review.openstack.org/481153 | 22:27 |
*** jamesdenton has joined #openstack-nova | 22:27 | |
*** jamesden_ has quit IRC | 22:27 | |
*** edmondsw has joined #openstack-nova | 22:28 | |
*** ckopper has joined #openstack-nova | 22:32 | |
*** edmondsw has quit IRC | 22:32 | |
*** acormier has quit IRC | 22:35 | |
*** acormier has joined #openstack-nova | 22:35 | |
*** mdrabe has quit IRC | 22:40 | |
*** ckopper has quit IRC | 22:40 | |
*** acormier has quit IRC | 22:40 | |
*** ijw has quit IRC | 22:40 | |
*** jamesdenton has quit IRC | 22:43 | |
*** abalutoiu has joined #openstack-nova | 22:44 | |
dansmith | mriedem: oooh, you fail | 22:50 |
mriedem | ildikov: went through the swap volume change - https://review.openstack.org/#/c/456971/ - there are a bunch of missing tests, i can work on adding those | 22:50 |
mriedem | since i have it in my head what i'd like to see | 22:50 |
mriedem | dansmith: holy god yeah i did | 22:51 |
mriedem | gah it's that damn ec2_ids | 22:51 |
mriedem | fixing | 22:51 |
mriedem | looks like it's going to be an all nighter | 22:51 |
ildikov | mriedem: yeah, I fixed a few added just a few more and went ahead to fix the attach patch... | 22:52 |
mriedem | np | 22:52 |
mriedem | i'll add the rest | 22:52 |
ildikov | mriedem: prolly waaaay faster if you add the rest | 22:52 |
*** ckopper has joined #openstack-nova | 22:52 | |
ildikov | mriedem: I owe you | 22:53 |
ildikov | mriedem: thank you! | 22:54 |
*** edmondsw has joined #openstack-nova | 22:56 | |
*** eharney has quit IRC | 22:58 | |
mriedem | ildikov: confirmed that the new style volume swap was tested in the change at the top of the series http://logs.openstack.org/85/330285/86/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/15d8c0f/console.html#_2017-07-05_17_04_17_100023 | 23:00 |
*** edmondsw has quit IRC | 23:00 | |
mriedem | that's the nova-initiated swap, not the cinder one, | 23:01 |
mriedem | we have another job that tests that in the experimental queue i htink | 23:01 |
ildikov | mriedem: I saw it failing when I messed up something earlier so I knew it's supposed to run | 23:02 |
mriedem | the tempest test is TestVolumeMigrateRetypeAttached | 23:02 |
ildikov | Hmm I don't recall that one | 23:02 |
mriedem | i think it's tested from the lvm multibackend job | 23:02 |
mriedem | that's the one that scottda added for testing volume migration/retype | 23:03 |
*** lbragstad has quit IRC | 23:03 | |
*** thorst has joined #openstack-nova | 23:04 | |
mriedem | i think tempest-dsvm-neutron-scenario-multinode-lvm-multibackend | 23:04 |
ildikov | Yeah, I remember that I just don't remember having any issues with it so I didn't deal with it | 23:04 |
mriedem | there is also tempest-dsvm-lvm-multibackend but that doesn't run slow tests, and this is tagged as a slow test | 23:04 |
mriedem | experimental queue jobs won't vote | 23:04 |
mriedem | so you likely wouldn't notice | 23:04 |
ildikov | I checked the non-voting jobs too when they failed | 23:05 |
mriedem | yeah but check queue non-voting != experimental queue non-voting | 23:05 |
mriedem | experimental queue jobs are all run on-demand | 23:06 |
ildikov | ok, missed the experimental part for a sec | 23:07 |
*** iceyao has joined #openstack-nova | 23:08 | |
*** thorst has quit IRC | 23:09 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Pre-load instance.device_metadata in InstanceMetadata https://review.openstack.org/481235 | 23:11 |
mriedem | dansmith: melwitt: ^ fixed | 23:11 |
*** slaweq has joined #openstack-nova | 23:12 | |
*** iceyao has quit IRC | 23:13 | |
mriedem | jaypipes: i might just update this one https://review.openstack.org/#/c/476631/ | 23:13 |
*** ijw has joined #openstack-nova | 23:17 | |
*** slaweq has quit IRC | 23:18 | |
*** dtp has quit IRC | 23:19 | |
*** takedakn has joined #openstack-nova | 23:21 | |
*** ijw has quit IRC | 23:22 | |
*** hieulq has quit IRC | 23:24 | |
*** trungnv has quit IRC | 23:24 | |
*** baoli has quit IRC | 23:26 | |
*** chyka has quit IRC | 23:28 | |
*** iceyao has joined #openstack-nova | 23:28 | |
*** chyka has joined #openstack-nova | 23:29 | |
*** armax has quit IRC | 23:30 | |
*** moshele has joined #openstack-nova | 23:33 | |
*** iceyao has quit IRC | 23:33 | |
*** thorst has joined #openstack-nova | 23:33 | |
*** chyka has quit IRC | 23:34 | |
*** thorst has quit IRC | 23:34 | |
*** takedakn has quit IRC | 23:35 | |
*** lbragstad has joined #openstack-nova | 23:36 | |
*** takedakn has joined #openstack-nova | 23:37 | |
*** hongbin has quit IRC | 23:38 | |
*** trungnv has joined #openstack-nova | 23:40 | |
*** hieulq has joined #openstack-nova | 23:40 | |
*** Sukhdev has joined #openstack-nova | 23:40 | |
*** ijw has joined #openstack-nova | 23:41 | |
*** efried has quit IRC | 23:41 | |
*** itlinux has quit IRC | 23:43 | |
-openstackstatus- NOTICE: nb03.openstack.org has been cleaned up and rebooted, and should return to building rotation | 23:44 | |
*** arahal_ has quit IRC | 23:45 | |
*** takedakn has quit IRC | 23:46 | |
*** takedakn has joined #openstack-nova | 23:47 | |
*** takedakn has quit IRC | 23:47 | |
*** ijw has quit IRC | 23:48 | |
*** iceyao has joined #openstack-nova | 23:49 | |
*** efried has joined #openstack-nova | 23:51 | |
*** iceyao has quit IRC | 23:54 | |
*** Swami has quit IRC | 23:57 | |
jaypipes | melwitt: go for it | 23:57 |
jaypipes | lol, that should have been mriedem. | 23:58 |
jaypipes | mriedem: but I can fix those issues. sorry, was out of the hosue. | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!