Friday, 2017-07-07

gmannmriedem, good morning. can you check this spec, i updated the quota class APi fix spec for network quota filter out  - https://review.openstack.org/#/c/480815/00:06
*** sree_ has joined #openstack-nova00:06
*** sree_ is now known as Guest8944300:06
*** gmann has quit IRC00:10
*** gmann has joined #openstack-nova00:10
*** yangyapeng has quit IRC00:14
*** slaweq has joined #openstack-nova00:14
*** yangyapeng has joined #openstack-nova00:14
openstackgerritJay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates  https://review.openstack.org/47663100:16
openstackgerritJay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler  https://review.openstack.org/47663200:16
jaypipesmriedem: ^ k, fixed up.00:16
*** abalutoiu has quit IRC00:17
*** yangyapeng has quit IRC00:18
*** slaweq has quit IRC00:18
*** Sukhdev has quit IRC00:21
*** thorst has joined #openstack-nova00:23
*** thorst has quit IRC00:26
*** armax has joined #openstack-nova00:26
*** felipemonteiro has quit IRC00:28
mriedemcool00:30
*** Guest89443 has quit IRC00:30
*** moshele has quit IRC00:34
jaypipesmriedem: sorry for the delay. was out this afternoon.00:35
mriedemnp, one teeny tiny thing https://review.openstack.org/#/c/476631/1700:35
mriedemand then +2 to the extreme00:35
*** rajathagasthya has quit IRC00:39
jaypipesmriedem: done.00:41
openstackgerritJay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates  https://review.openstack.org/47663100:41
openstackgerritJay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler  https://review.openstack.org/47663200:41
alex_xujaypipes: easy fix for AllocationCandidates https://review.openstack.org/480379 :)00:42
alex_xujaypipes: sorry, that is the hard one, need your feedback, the easy one is https://review.openstack.org/48013000:42
*** claudiub has quit IRC00:42
jaypipesalex_xu: cool, will review both later tonight.00:42
alex_xujaypipes: thanks!00:42
*** zhurong has joined #openstack-nova00:44
*** ijw has joined #openstack-nova00:46
openstackgerrityuanyue proposed openstack/nova master: Add log info in scheduler to mark start of scheduling  https://review.openstack.org/48134000:46
jaypipesalex_xu: approved the one. nice catch! :)00:47
alex_xujaypipes: thanks \o/00:47
jaypipesalex_xu: would be good to add a functional test that verified that (though, I understand that all of our fixtures and the way we currently do testing would *not* have shown that issue since the usages table was appropriately filtered by resource_class_id already.00:48
alex_xujaypipes: you mean a functional test for usage filtered by resource_class_id?00:49
jaypipesalex_xu: no, I mean add a functional test that showed the missing WHERE condition that was fixed in your patch.00:51
alex_xujaypipes: emm..I changed the function tests to expose that bug https://review.openstack.org/#/c/480130/3/nova/tests/functional/db/test_resource_provider.py00:52
*** ijw has quit IRC00:52
*** Shunli has joined #openstack-nova00:52
mriedemjaypipes: +200:52
mriedemdansmith: for your morning, +2 on the allocation candidates in scheduler change https://review.openstack.org/#/c/476631/00:53
*** dixiaoli has joined #openstack-nova00:53
*** iceyao has joined #openstack-nova00:53
jaypipesalex_xu: understood. but those tests, while exposing the bug, didn't directly call _get_usages_by_provider_and_rc(). that's all I was saying, sorry, I wasn't being clear!00:55
*** dixiaoli has quit IRC00:55
alex_xujaypipes: ah, I see now00:56
*** lbragstad has quit IRC00:56
*** trungnv has quit IRC00:56
alex_xuI will check that00:56
*** iceyao has quit IRC00:58
openstackgerritMerged openstack/nova master: Updated from global requirements  https://review.openstack.org/48118901:03
*** fragatin_ has joined #openstack-nova01:05
*** sree_ has joined #openstack-nova01:05
*** sree_ is now known as Guest1214801:06
*** thorst has joined #openstack-nova01:06
*** thorst has quit IRC01:07
*** fragati__ has joined #openstack-nova01:07
*** ijw has joined #openstack-nova01:08
*** fragatina has quit IRC01:08
*** lbragstad has joined #openstack-nova01:10
*** fragatin_ has quit IRC01:10
*** kaisers_ has joined #openstack-nova01:11
*** fragati__ has quit IRC01:12
*** ijw has quit IRC01:13
*** slaweq has joined #openstack-nova01:15
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: test new style volume attach with live migration  https://review.openstack.org/48129001:15
openstackgerrityuanyue proposed openstack/nova master: Add log info in scheduler to mark start of scheduling  https://review.openstack.org/48134001:15
*** kaisers_ has quit IRC01:16
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: test new style volume attach with live migration  https://review.openstack.org/48129001:16
*** jwcroppe_ has joined #openstack-nova01:18
*** trungnv has joined #openstack-nova01:19
*** yamahata has quit IRC01:19
*** slaweq has quit IRC01:20
*** yangyapeng has joined #openstack-nova01:20
*** iceyao has joined #openstack-nova01:21
alex_xujaypipes: https://review.openstack.org/#/c/480379/2/nova/objects/resource_provider.py@2422...i'm doing stupid thing...why I join the table!01:21
jaypipesalex_xu: :) done that many times myself.01:21
*** jwcroppe has quit IRC01:21
*** yangyapeng has quit IRC01:21
*** yangyapeng has joined #openstack-nova01:21
alex_xujaypipes: for 2637, it should be English problem, I shouldn't use 'filter out', I will reparse01:22
jaypipeskk01:22
alex_xujaypipes: bauzas expect one SQL to done all the things, do you expect that, or you are happy the current way.01:22
jaypipesalex_xu: I don't mind if there's >1 SQL statement, no.01:23
mriedemare you asking jaypipes if he thinks sql can do everything?01:23
jaypipesheh01:23
alex_xumriedem: :)01:23
*** itlinux has joined #openstack-nova01:23
*** itlinux has quit IRC01:23
mriedemjay's quest in life is to find the one single sql statement that can rule them all01:24
jaypipesSELECT 42 FROM DUAL.01:24
alex_xujaypipes: can you rewrite the whole nova api with one sql? please01:24
jaypipeslol. dansmith would kill me.01:24
*** itlinux has joined #openstack-nova01:25
openstackgerrityuanyue proposed openstack/nova master: Add log info in scheduler to mark start of scheduling  https://review.openstack.org/48134001:27
*** acormier has joined #openstack-nova01:30
*** Apoorva has quit IRC01:30
*** acormier has quit IRC01:31
*** acormier has joined #openstack-nova01:32
*** liujiong has joined #openstack-nova01:34
*** ijw has joined #openstack-nova01:36
*** wong_ has joined #openstack-nova01:37
*** smatzek has joined #openstack-nova01:38
*** ijw has quit IRC01:47
*** sapcc-bot has quit IRC01:47
*** sapcc-bot has joined #openstack-nova01:47
Kevin_ZhengHi, when we boot instance, in cells v2, we call schedule_and_build_instances, but if we have to reschedule, we called build_instances, why is that?01:53
Kevin_Zhengshouldn't we call schedule_and_build_instances again?01:54
mriedembecause nova-compute has always done a reschedule by doing an rpc cast to build_instances01:54
mriedemKevin_Zheng: no, build_instances is in the cell-level conductor,01:54
mriedemso the compute can reach it01:54
mriedembut schedule_and_build_instances talks to the scheduler, which is all at the top01:55
Kevin_ZhengAH, ok01:55
mriedemand we don't want the computes to be able to reach the top01:55
mriedem"super" conductor01:55
Kevin_ZhengI understood now01:55
mriedemalthough, build_instances calls the scheduler too...01:55
mriedembuild_instances isn't cell aware either,01:55
*** hongbin has joined #openstack-nova01:55
mriedemschedule_and_build_instances is working under the assumption that the instance does not exist in a cell yet01:56
mriedemthat's the better reason why the compute doesn't call it01:56
Kevin_Zhengerror isntances should stay in cell0 or cellN?01:57
mriedemcell001:57
mriedemif you're talking about an instance that fails to build at the top and doesn't reach a cell01:58
mriedemif it reaches a cell and eventually goes to error, then it's in the cell it was scheduled in01:58
Kevin_ZhengOK01:58
Kevin_Zhenggot it01:59
mriedemwe should probably have something in https://docs.openstack.org/nova/latest/cells.html#faqs about cells001:59
mriedemsince that's a common question01:59
mriedemalthough higher up it describes cell0,02:00
mriedem"Instances that are never scheduled are relegated to the cell0 database, which is effectively a graveyard of instances that failed to start. All successful/running instances are stored in “cell1”."02:00
mriedeman instance can reach a cell and still fail to start,02:00
mriedemso that sentence is not entirely clear02:00
Kevin_Zhengyeah, not only successful02:03
*** litao__ has joined #openstack-nova02:05
*** gjayavelu has quit IRC02:14
*** acormier_ has joined #openstack-nova02:19
*** acormier has quit IRC02:22
*** gyee has quit IRC02:23
*** smatzek has quit IRC02:39
*** Guest12148 has quit IRC02:51
*** hieulq_ has joined #openstack-nova02:52
openstackgerritZhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4)  https://review.openstack.org/46980002:53
*** lucasxu has joined #openstack-nova02:53
openstackgerritMerged openstack/nova master: placement: filter usage records by resource provider id  https://review.openstack.org/48013002:57
*** hieulq_ has quit IRC02:58
*** hieulq_ has joined #openstack-nova02:58
*** hieulq_ has quit IRC02:59
*** lucasxu has quit IRC02:59
*** acormier_ has quit IRC03:03
*** hieulq_ has joined #openstack-nova03:07
*** karthiks has joined #openstack-nova03:07
*** thorst has joined #openstack-nova03:07
*** thorst has quit IRC03:13
*** felipemonteiro has joined #openstack-nova03:23
*** Shunli has quit IRC03:25
*** Shunli has joined #openstack-nova03:26
*** psachin has joined #openstack-nova03:27
*** Nel1x has quit IRC03:29
*** hieulq_ has quit IRC03:32
openstackgerritNgo Quoc Cuong proposed openstack/nova master: Remove translation of log messages  https://review.openstack.org/46699503:37
*** felipemonteiro has quit IRC03:43
*** cNilesh has joined #openstack-nova03:51
*** Shunli has quit IRC03:54
*** Shunli has joined #openstack-nova03:55
*** yamamoto has joined #openstack-nova03:56
*** kaisers_ has joined #openstack-nova03:57
*** kaisers_ has quit IRC04:02
*** kaisers_ has joined #openstack-nova04:05
*** thorst has joined #openstack-nova04:09
*** karthiks has quit IRC04:10
*** iceyao has quit IRC04:10
*** cNilesh is now known as cNilesh|bf04:13
*** thorst has quit IRC04:14
*** lbragstad has quit IRC04:14
*** yamahata has joined #openstack-nova04:16
*** iceyao has joined #openstack-nova04:18
*** slaweq has joined #openstack-nova04:19
openstackgerritMerged openstack/nova master: Fix comment for API binary name in WSGIService  https://review.openstack.org/48064804:19
*** iceyao has quit IRC04:22
*** slaweq has quit IRC04:24
*** vladikr_ has quit IRC04:24
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.49 - Virt device tagged attach  https://review.openstack.org/48039204:28
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.50 - Enable cold migration with target host  https://review.openstack.org/40670704:28
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.50 - List/Show all server migration types  https://review.openstack.org/43083904:28
*** links has joined #openstack-nova04:29
*** iceyao has joined #openstack-nova04:32
*** claudiub has joined #openstack-nova04:35
*** iceyao has quit IRC04:36
*** adisky__ has joined #openstack-nova04:41
openstackgerritsudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid()  https://review.openstack.org/48100704:41
*** faizy has joined #openstack-nova04:42
*** trinaths has joined #openstack-nova04:43
*** trinaths1 has joined #openstack-nova04:44
*** armax has quit IRC04:45
*** armax has joined #openstack-nova04:46
*** trinaths has quit IRC04:47
*** liujiong is now known as liujiong|away04:52
*** hongbin has quit IRC04:55
*** zzzeek has joined #openstack-nova04:55
*** dixiaoli has joined #openstack-nova04:56
*** zzzeek has quit IRC04:56
*** zzzeek has joined #openstack-nova05:02
*** zzzeek has quit IRC05:02
*** zzzeek has joined #openstack-nova05:04
*** zzzeek has quit IRC05:04
*** cNilesh has joined #openstack-nova05:07
*** karthiks has joined #openstack-nova05:07
*** zzzeek has joined #openstack-nova05:08
*** zzzeek has quit IRC05:09
*** cNilesh|bf has quit IRC05:09
*** zzzeek has joined #openstack-nova05:10
*** iceyao has joined #openstack-nova05:11
*** cNilesh has quit IRC05:15
*** cNilesh has joined #openstack-nova05:16
*** zzzeek has quit IRC05:16
*** slaweq has joined #openstack-nova05:19
*** thorst has joined #openstack-nova05:21
*** zzzeek has joined #openstack-nova05:22
*** zzzeek has quit IRC05:23
*** slaweq has quit IRC05:25
openstackgerritMatt Riedemann proposed openstack/nova master: Handle Cinder 3.27 style attachments in swap_volume  https://review.openstack.org/45697105:25
openstackgerritMatt Riedemann proposed openstack/nova master: Remove check_detach  https://review.openstack.org/44667105:25
openstackgerritMatt Riedemann proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028505:25
mriedemildikov: tests and stuff are done in the swap volume patch now ^05:25
*** prateek has joined #openstack-nova05:25
mriedemi think i'll +1 since i'm good with it now05:25
*** thorst has quit IRC05:25
*** ratailor has joined #openstack-nova05:28
openstackgerritArundhati Surpur proposed openstack/python-novaclient master: Removed extra 'method' from the NOTE  https://review.openstack.org/48098805:29
openstackgerritArundhati Surpur proposed openstack/python-novaclient master: Removed extra word 'method' from the NOTE  https://review.openstack.org/48098805:30
*** sapcc-bot2 has joined #openstack-nova05:32
*** sapcc-bot has quit IRC05:32
*** yamahata has quit IRC05:32
*** yangyape_ has joined #openstack-nova05:33
*** yangyapeng has quit IRC05:35
*** mdnadeem has joined #openstack-nova05:37
*** zzzeek has joined #openstack-nova05:40
*** zzzeek has quit IRC05:40
*** sridharg has joined #openstack-nova05:41
openstackgerritjoohyun proposed openstack/nova master: Remove TODO message  https://review.openstack.org/48143605:43
openstackgerritjoohyun proposed openstack/nova master: Remove TODO message  https://review.openstack.org/48143605:44
*** rcernin has joined #openstack-nova05:46
*** Abhishek has joined #openstack-nova05:47
*** shaohe_feng has quit IRC05:50
AbhishekHi..My nova-compute is keep on getting inactive after few seconds.Can anyone suggest what could be the issue05:50
*** markvoelker has quit IRC05:50
*** markvoelker has joined #openstack-nova05:51
*** shaohe_feng has joined #openstack-nova05:51
Abhishekhttp://www.heypasteit.com/clip/0IIO6P ->here is the log file05:51
mriedem2017-07-07 11:10:51.754 23129 ERROR oslo_service.service AttributeError: 'module' object has no attribute 'VIR_MIGRATE_POSTCOPY'05:55
*** ianw is now known as ianw_pto05:55
mriedemyour libvirt-python package likely has a problem05:55
*** markvoelker has quit IRC05:55
mriedemand needs to be rebuilt05:55
Abhishekmriedem:Should i remove the package and re-install it05:57
mriedemthat probably won't fix it05:57
mriedemi can't remember what the exact nature of this usually is, but it's something to do with the packaging,05:57
mriedemit's saying it's a newer libvirt version than the libvirt-python was built against05:58
mriedembut the libvirt-python code was built against an older version05:58
*** junbo has quit IRC06:01
*** zzzeek has joined #openstack-nova06:02
Abhishekmriedem:Basically,is it a version mismatch between the version installed in Ubuntu16.04 and the nova-compute conf file06:03
mriedemhas nothing to do with nova06:03
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add ability to signal and perform online volume size change  https://review.openstack.org/45432206:04
Abhishekmriedem:Any way to fix this06:04
*** andreas_s has joined #openstack-nova06:04
mriedemclarkb has tricks, but i don't remember them. i think it ultimately means the libvirt-python package wasn't built against the same version of libvirt that you have on the system, so you need to make sure those are the same06:05
mriedemrpm -qa | grep libvirt06:05
mriedem?06:05
mriedemmake sure those are the same06:05
Abhishekroot@01hw467434:/var/lib/dpkg# rpm -qa | grep libvirt root@01hw467434:/var/lib/dpkg#06:05
Abhisheki do not see any06:05
mriedemapt list | grep libvirt06:07
mriedem?06:07
*** armax has quit IRC06:07
*** slaweq has joined #openstack-nova06:07
*** armax has joined #openstack-nova06:07
openstackgerritKaiLi proposed openstack/nova master: Add "default" rule when generate policy.yaml.sample  https://review.openstack.org/48144306:08
*** armax has quit IRC06:08
*** armax has joined #openstack-nova06:08
Abhishekmriedem:http://www.heypasteit.com/clip/0IIO6S06:08
*** armax has quit IRC06:08
*** armax has joined #openstack-nova06:09
*** Oku_OS-away is now known as Oku_OS06:09
*** armax has quit IRC06:09
*** armax has joined #openstack-nova06:10
*** armax has quit IRC06:10
*** yangyape_ has quit IRC06:10
*** vvargaszte has joined #openstack-nova06:10
*** armax has joined #openstack-nova06:10
*** yangyapeng has joined #openstack-nova06:11
*** armax has quit IRC06:11
Abhishekmriedem:apt list | grep libvirt output is in the location ->http://www.heypasteit.com/clip/0IIO6S06:11
*** armax has joined #openstack-nova06:11
*** armax has quit IRC06:12
mriedemsorry but i can't help you much further here06:12
*** yangyape_ has joined #openstack-nova06:13
Abhishekmriedem:No problem,Thank you for your time06:13
*** shaohe_feng has quit IRC06:14
openstackgerritKaiLi proposed openstack/nova master: Add "default" rule when generate policy.yaml.sample  https://review.openstack.org/48144306:15
*** yangyapeng has quit IRC06:16
openstackgerritMatt Riedemann proposed openstack/nova master: Remove reverts_task_state decorator from swap_volume  https://review.openstack.org/48144706:16
*** zzzeek has quit IRC06:17
*** Abhishek has quit IRC06:18
openstackgerritShunli Zhou proposed openstack/nova master: Transform servergroup.create notification  https://review.openstack.org/45402306:18
*** markus_z has joined #openstack-nova06:24
mriedemKevin_Zheng: want to fix the little issue in here? https://review.openstack.org/#/c/459593/06:25
mriedemthen i'm +206:25
*** shaohe_feng has joined #openstack-nova06:25
Kevin_Zhengsure thanks, wow, you still up yet?06:25
*** lpetrut has joined #openstack-nova06:25
mriedemyeah, decided it was going to be a long night06:26
*** liujiong|away is now known as liujiong06:26
openstackgerritZhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4)  https://review.openstack.org/45959306:28
openstackgerritZhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4)  https://review.openstack.org/46980006:28
Kevin_Zheng4/4 also rebased to the latest version06:29
mriedemcool, now just need to get alex_xu to look at https://review.openstack.org/#/c/459593/ again, i remember he was +2 on it before06:29
*** yangyape_ has quit IRC06:30
*** yangyapeng has joined #openstack-nova06:30
Kevin_Zhengand the notification patch is also on the way, I messed up with a bad rebase last time ... will fix latter today06:31
*** yangyapeng has quit IRC06:32
*** yangyapeng has joined #openstack-nova06:33
*** yangyapeng has quit IRC06:33
*** yangyapeng has joined #openstack-nova06:34
*** gabor_antal_ has joined #openstack-nova06:35
*** sridharg has quit IRC06:35
*** thomasem_ has quit IRC06:36
*** sneti_ has quit IRC06:36
*** mrodden has quit IRC06:37
*** beagles has quit IRC06:37
openstackgerritAlex Xu proposed openstack/nova master: placement: ensure shared RP maps with correct root RP  https://review.openstack.org/48037906:37
*** htruta has quit IRC06:38
*** NostawRm has quit IRC06:38
*** gabor_antal has quit IRC06:38
*** thomasem_ has joined #openstack-nova06:38
*** sneti has joined #openstack-nova06:38
*** mrodden has joined #openstack-nova06:39
*** diga has joined #openstack-nova06:39
*** sridharg has joined #openstack-nova06:39
*** rha has quit IRC06:41
*** htruta has joined #openstack-nova06:42
*** NostawRm has joined #openstack-nova06:43
*** b3nt_pin has joined #openstack-nova06:43
*** b3nt_pin is now known as Guest964006:43
*** rha has joined #openstack-nova06:46
*** gouthamr has quit IRC06:47
openstackgerritsudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid()  https://review.openstack.org/48100706:47
*** ijw has joined #openstack-nova06:48
*** ijw has quit IRC06:52
mriedemalex_xu: i've replied to your comments in https://review.openstack.org/#/c/471899/06:54
mriedemthanks for going through that, it's a massive change06:54
alex_xumriedem: np, will check soon06:54
ildikovmriedem: thank you!06:54
*** liujiong has quit IRC07:01
openstackgerritMatt Riedemann proposed openstack/nova master: Handle Cinder 3.27 style attachments in swap_volume  https://review.openstack.org/45697107:01
openstackgerritMatt Riedemann proposed openstack/nova master: Remove check_detach  https://review.openstack.org/44667107:01
openstackgerritMatt Riedemann proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028507:02
mriedemKevin_Zheng: it would be good if you could review that bottom swap volume change as well ^07:02
mriedemKevin_Zheng: the new cinder v3 attach flow needs some more people involved on the nova side,07:02
mriedemfor reviews and understanding07:02
Kevin_Zhengsure, will do07:02
alex_xumriedem: replied07:04
*** slaweq has quit IRC07:05
*** mkucia has quit IRC07:05
openstackgerritAlex Szarka proposed openstack/nova master: Refactor init_instance:resume_guests_state  https://review.openstack.org/34958207:06
openstackgerritAlex Szarka proposed openstack/nova master: Transform instance.exists notification  https://review.openstack.org/40366007:06
mriedemalex_xu: got it, thanks again. i would say i will deal with that tomorrow, but it's already tomorrow :)07:07
mriedemso i'll deal with it in a few hours07:07
alex_xumriedem: :) yea, really shock you still awake up now07:09
openstackgerritiswarya vakati proposed openstack/nova master: Fixed wrap from taking negative values  https://review.openstack.org/48146507:10
mriedemnot for long, i'm signing off - see you in awhile07:10
openstackgerritBalazs Gibizer proposed openstack/nova master: Add sample test for instance audit  https://review.openstack.org/48095507:10
*** mriedem has quit IRC07:10
*** lpetrut has quit IRC07:13
*** alexchadin has joined #openstack-nova07:16
*** itlinux has quit IRC07:16
*** tesseract has joined #openstack-nova07:17
*** jpena|off is now known as jpena07:18
*** thorst has joined #openstack-nova07:21
*** damien_r has joined #openstack-nova07:24
*** thorst has quit IRC07:27
openstackgerritjichenjc proposed openstack/nova master: Add device tag support info in support matrix  https://review.openstack.org/48147807:44
openstackgerritjichenjc proposed openstack/nova master: Add description for tag support in attach  https://review.openstack.org/48147907:44
*** ralonsoh has joined #openstack-nova07:48
*** rajathagasthya has joined #openstack-nova07:51
openstackgerritjichenjc proposed openstack/nova master: add description for supports_migrate_to_same_host  https://review.openstack.org/48148307:51
*** markvoelker has joined #openstack-nova07:51
openstackgerritKaiLi proposed openstack/nova master: Add "default" rule when generate policy.yaml.sample  https://review.openstack.org/48144307:52
*** iceyao has quit IRC07:54
*** efoley has joined #openstack-nova07:59
*** zzzeek_ has quit IRC08:00
*** zzzeek has joined #openstack-nova08:00
*** abalutoiu has joined #openstack-nova08:09
*** diga has quit IRC08:10
openstackgerritjichenjc proposed openstack/nova master: WIP: remove extension pop  https://review.openstack.org/48149108:11
openstackgerritjichenjc proposed openstack/nova master: Remove nova.api.extensions.server.extensions usage  https://review.openstack.org/48149408:15
*** wong_ has quit IRC08:16
*** david-lyle has quit IRC08:19
*** david-lyle has joined #openstack-nova08:19
*** iceyao has joined #openstack-nova08:19
*** iceyao has quit IRC08:24
*** yangyap__ has joined #openstack-nova08:25
*** yangyapeng has quit IRC08:26
*** markvoelker has quit IRC08:26
openstackgerritjichenjc proposed openstack/nova master: add cli to support matrix  https://review.openstack.org/48149808:26
*** pabardina has joined #openstack-nova08:28
pabardinahello, Is it normal I don't see "locked_by" attribute when I'm using "nova show XX" on mitaka? I have "Locked: True" information, no more... But in the code there is the "locked_by" attr... any ideas ?08:31
*** lucas-afk is now known as lucasagomes08:33
*** iceyao has joined #openstack-nova08:37
*** iceyao has quit IRC08:42
*** purplerbot has quit IRC08:44
*** purplerbot has joined #openstack-nova08:44
*** dixiaoli has quit IRC08:45
*** dixiaoli has joined #openstack-nova08:45
*** cdent has joined #openstack-nova08:49
*** Oku_OS has quit IRC08:49
*** priteau has joined #openstack-nova08:51
*** Oku_OS has joined #openstack-nova08:51
*** tojuvone has quit IRC08:53
*** tojuvone has joined #openstack-nova08:54
stephenfinjohnthetubaguy: Next time you're about, would appreciate it if you could remove the -2 on this change as it no longer applies https://review.openstack.org/#/c/44958408:54
openstackgerritAlex Szarka proposed openstack/nova master: Reduce code complexity - manager.py  https://review.openstack.org/35986808:58
openstackgerritAlex Szarka proposed openstack/nova master: Reduce code complexity - linux_net.py  https://review.openstack.org/35987109:04
openstackgerritAlex Szarka proposed openstack/nova master: Reduce code complexity - libvirt/config.py  https://review.openstack.org/35987909:04
*** faizy has quit IRC09:04
*** psachin_ has joined #openstack-nova09:04
*** psachin_ has quit IRC09:05
*** faizy has joined #openstack-nova09:05
openstackgerritMerged openstack/nova master: Add 'networks' quota in quota sample files  https://review.openstack.org/47922709:06
*** lpetrut has joined #openstack-nova09:14
*** yangyapeng has joined #openstack-nova09:19
*** yangyap__ has quit IRC09:22
*** markvoelker has joined #openstack-nova09:23
*** thorst has joined #openstack-nova09:23
*** reedip has quit IRC09:25
*** thorst has quit IRC09:28
*** Shunli has quit IRC09:29
gmannpabardina, that will be present if you request API with microversion >2.909:29
gmannpabardina, and its there since liberty so mitaka is all fine to get that09:30
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot  https://review.openstack.org/44925709:32
pabardinagmann, yes with microversion > 2.9, "locked" is present, but no "locked_by"09:32
openstackgerritTakashi NATSUME proposed openstack/nova master: Use URIOpt  https://review.openstack.org/47921509:33
gmannpabardina, ahh, yes its boolean 'locked'09:34
*** karthiks has quit IRC09:34
pabardinagmann, ok, it's fine then. thanks :)09:35
gmannpabardina, API never publish 'locked_by' i think it was only internally used09:35
pabardinapabardina, alright09:35
pabardinagmann, alright09:36
*** takashin has left #openstack-nova09:36
*** aloga has quit IRC09:38
*** aloga has joined #openstack-nova09:38
*** reedip has joined #openstack-nova09:39
*** rajathagasthya has quit IRC09:39
*** yamahata has joined #openstack-nova09:41
*** alexchadin has quit IRC09:42
*** dixiaoli_ has joined #openstack-nova09:42
*** dixiaoli_ has quit IRC09:42
*** dixiaoli has quit IRC09:46
*** sulo has quit IRC09:47
*** sulo has joined #openstack-nova09:47
openstackgerritjichenjc proposed openstack/nova master: WIP: remove extension pop  https://review.openstack.org/48149109:48
*** openstackgerrit has quit IRC09:48
*** openstackgerrit has joined #openstack-nova09:48
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request  https://review.openstack.org/45177709:48
*** ZZelle has joined #openstack-nova09:51
*** sulo has quit IRC09:52
*** slaweq has joined #openstack-nova09:53
*** sulo has joined #openstack-nova09:55
*** markvoelker has quit IRC09:56
*** pabardina has quit IRC09:56
*** avolkov has quit IRC10:00
*** sambetts|afk is now known as sambetts10:06
cdentjaypipes: another gabbi change you might be interested in:     https://github.com/cdent/gabbi/pull/21610:08
*** jmlowe_ has joined #openstack-nova10:10
*** jmlowe has quit IRC10:11
bauzascdent: jaypipes: you knew that we had a problem with traits not synced in gabbi testing ?10:16
bauzasthat's fixed by Monday but just to make sure you knew it10:16
*** slaweq has quit IRC10:20
*** slaweq has joined #openstack-nova10:21
cdentbauzas: this last monday? yeah10:25
*** slaweq has quit IRC10:26
*** yamahata has quit IRC10:26
bauzascdent: kewl10:31
bauzaswas just a FYI10:32
cdentyeah, thanks10:32
*** alexchadin has joined #openstack-nova10:35
*** cNilesh has quit IRC10:39
*** cNilesh has joined #openstack-nova10:40
*** alexchadin has quit IRC10:42
*** yamamoto has quit IRC10:46
*** zhurong has quit IRC10:46
openstackgerritsudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid()  https://review.openstack.org/48100710:46
*** slaweq has joined #openstack-nova10:49
*** slaweq has quit IRC10:50
*** slaweq has joined #openstack-nova10:50
*** markvoelker has joined #openstack-nova10:53
*** ratailor has quit IRC10:58
openstackgerritDinesh Bhor proposed openstack/nova master: Trivial: Remove unnecessary format specifier  https://review.openstack.org/48157410:59
*** thorst has joined #openstack-nova11:00
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Format NIC features using os-traits definitions  https://review.openstack.org/46605111:01
jaypipesbauzas: yeah, that was the thing edleafe fixed, yeah?11:02
bauzasjaypipes: nope, he missed something11:05
bauzasjaypipes: https://review.openstack.org/#/c/480198/11:05
*** thorst has quit IRC11:05
*** cNilesh has quit IRC11:06
*** cNilesh has joined #openstack-nova11:06
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocation_candidates  https://review.openstack.org/48111211:17
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP traits  https://review.openstack.org/47455011:17
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for traits  https://review.openstack.org/47418611:17
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocations  https://review.openstack.org/47093311:17
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for usages  https://review.openstack.org/48056311:17
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Make placement_api_docs.py failing  https://review.openstack.org/48092411:17
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP usages  https://review.openstack.org/45010511:17
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP allocations  https://review.openstack.org/45055011:17
jaypipescdent: nice on that full JSON gabbi enhancement. :)11:21
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocation_candidates  https://review.openstack.org/48111211:22
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP traits  https://review.openstack.org/47455011:22
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocations  https://review.openstack.org/47093311:22
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for usages  https://review.openstack.org/48056311:22
*** trinaths1 has left #openstack-nova11:22
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Make placement_api_docs.py failing  https://review.openstack.org/48092411:22
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP usages  https://review.openstack.org/45010511:22
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP allocations  https://review.openstack.org/45055011:22
cdentjaypipes: if you want to put a thumbs up of some kind on either or both of #215 and #216 that will help convince some of the other people.11:23
jaypipescdent: sure thing.11:23
cdentthanks11:23
jaypipescdent: and... done. :)11:24
cdentword11:24
*** markvoelker has quit IRC11:26
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocation_candidates  https://review.openstack.org/48111211:26
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Make placement_api_docs.py failing  https://review.openstack.org/48092411:26
*** lucasagomes is now known as lucas-hungry11:27
jaypipescdent: the bird.11:27
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Add api-ref for allocation_candidates  https://review.openstack.org/48111211:27
openstackgerritAndrey Volkov proposed openstack/nova master: [placement] Make placement_api_docs.py failing  https://review.openstack.org/48092411:27
jaypipesI wonder what avolkov` is working on ... :)11:28
avolkov`jaypipes: sorry )11:28
jaypipesavolkov`: why? it's a much-needed patch series! ++11:28
jaypipesavolkov`: thank you very much for leading these doc efforts!11:29
avolkov`jaypipes: I'm about all these rebases those spam chat ), always miss something11:30
*** yamamoto has joined #openstack-nova11:30
jaypipesavolkov`: heh, no worries :)11:30
cdentavolkov`++11:30
*** gbarros has quit IRC11:34
*** iceyao has joined #openstack-nova11:34
*** psachin has quit IRC11:36
avolkov`cdent: jaypipes: btw, there is some initiative to migrate docs, probably placement api ref would be the first one, https://review.openstack.org/#/c/480991/11:36
*** sdague has joined #openstack-nova11:36
cdentavolkov`: yeah, saw that. I guess it makes sense given the docs migration spec (which feels a bit complicated but necessary)11:37
cdentI reckon we should merge all the pending placement-api-ref before moving stuff?11:38
jaypipescdent: ++11:39
*** zhurong has joined #openstack-nova11:41
avolkov`cdent: I think yes, we should have some accomplished thing before migration11:42
*** yangyapeng has quit IRC11:44
*** markvoelker has joined #openstack-nova11:44
*** zhurong has quit IRC11:46
*** slaweq has quit IRC11:48
*** pcaruana has joined #openstack-nova11:49
bhagyashriscdent: Hi, Thanks for your responses and suggestions.11:52
cdentbhagyashris: thank you for bringing it up11:52
cdentI'll be making a new release of gabbi probalby today11:53
cdentand then doing the global requirements changes11:53
bhagyashriscdent: Actually I am new to gabbi trying to understand it.11:53
bhagyashriscdent: Ohh, that will be great and thanks11:53
bhagyashriscdent: Just for my understanding i am going to changes #215 and #216. and trying take it as assignment so I have few difficulties.11:56
*** thorst has joined #openstack-nova11:56
cdentbhagyashris: what do you mean by "take it as assigment"?11:56
*** vladikr_ has joined #openstack-nova11:58
*** cNilesh has quit IRC11:59
*** cNilesh has joined #openstack-nova12:00
*** jpena is now known as jpena|lunch12:01
bhagyashriscdent: I have separately clone gabbi project and install in my environment. And applied the changes as in #216. But i am unaware about how to test the sample test.12:02
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.openstack.org/47709112:03
cdentbhagyashris: the new changes can be tested with: tox -epy27 -- test_intercept.data12:03
cdentthat will test just the tests in the data.yaml12:04
bhagyashriscdent: ok12:04
*** litao__ has quit IRC12:04
bhagyashriscdent: thanks12:05
*** iceyao has quit IRC12:09
*** tbachman has quit IRC12:10
*** hongda has joined #openstack-nova12:10
*** iceyao has joined #openstack-nova12:11
*** jamesdenton has joined #openstack-nova12:14
*** edmondsw has joined #openstack-nova12:21
*** sapcc-bot2 has quit IRC12:23
*** carthaca_ has quit IRC12:23
*** carthaca_ has joined #openstack-nova12:24
*** mkoderer_ has joined #openstack-nova12:24
*** sapcc-bot has joined #openstack-nova12:24
*** tpatzig_ has joined #openstack-nova12:24
*** david_1 has joined #openstack-nova12:24
*** dgonzalez_ has joined #openstack-nova12:24
*** lucas-hungry is now known as lucasagomes12:25
*** mkoderer_ has quit IRC12:26
*** tpatzig_ has quit IRC12:26
*** david_1 has quit IRC12:26
*** dgonzalez_ has quit IRC12:26
*** hongda has quit IRC12:26
*** smatzek has joined #openstack-nova12:27
*** faizy has quit IRC12:28
*** smatzek has quit IRC12:31
*** ijw has joined #openstack-nova12:36
*** smatzek has joined #openstack-nova12:37
*** _pewp_ has quit IRC12:37
masbergood morning, may I ask a question?12:38
kashyapmasber: Just ask :-)12:39
*** catintheroof has joined #openstack-nova12:40
masberI am trying to deploy a baremetal using ironic, my issue is that nova is telling me that I am exceeding my quota, however that is not true, I can see that I have enough resources12:40
*** _pewp_ has joined #openstack-nova12:40
kashyapHmm, afraid not sure about it myself, as I don't know much about Ironic.12:41
*** ijw has quit IRC12:41
masberis there a command to show the resources used?12:41
kashyapA gentle note: Operator questions are best asked on #openstack-operators (or is it 'users'?)12:41
kashyapmasber: `nova quota-show`?12:42
kashyapDepeding on what you're looking for, you may have to specify tenant12:43
masberthat will show me the whole quota, is there a way to see the free resources but from a quota point of view?12:44
*** acormier has joined #openstack-nova12:44
masberlike an overview to see how many cpus, ram, disks I am currently using?12:44
masbersomething like openstack hypervisor stats show but with quotas12:45
*** lyan has joined #openstack-nova12:46
*** slaweq has joined #openstack-nova12:48
*** jaypipes is now known as leakypipes12:50
*** liverpooler has joined #openstack-nova12:50
*** fragatina has joined #openstack-nova12:52
*** acormier has quit IRC12:53
*** acormier has joined #openstack-nova12:53
*** slaweq has quit IRC12:54
*** cNilesh has quit IRC12:55
*** fragatina has quit IRC12:57
*** acormier has quit IRC12:59
*** acormier has joined #openstack-nova12:59
*** lucasxu has joined #openstack-nova12:59
*** edleafe is now known as figleaf12:59
*** pchavva has joined #openstack-nova13:03
*** gcb has quit IRC13:03
*** acormier has quit IRC13:04
*** links has quit IRC13:06
*** tbachman has joined #openstack-nova13:06
*** slaweq has joined #openstack-nova13:07
*** acormier has joined #openstack-nova13:07
*** takedakn has joined #openstack-nova13:08
*** jpena|lunch is now known as jpena13:08
*** slaweq has quit IRC13:11
*** acormier has quit IRC13:11
*** acormier has joined #openstack-nova13:12
*** mdnadeem has quit IRC13:14
*** mdnadeem has joined #openstack-nova13:14
openstackgerritAnthony PERARD proposed openstack/nova master: Skip boot from encrypted volume on Xen+libvirt  https://review.openstack.org/48162713:16
*** acormier has quit IRC13:16
*** slaweq has joined #openstack-nova13:16
cdentfigleaf: yay! we don't agree on something!13:19
*** zhurong has joined #openstack-nova13:23
*** alexchadin has joined #openstack-nova13:24
*** eharney has joined #openstack-nova13:26
*** esberglu has joined #openstack-nova13:28
*** Dinesh_Bhor has quit IRC13:32
*** slaweq_ has joined #openstack-nova13:32
*** jwcroppe_ has quit IRC13:37
*** slaweq_ has quit IRC13:37
*** jwcroppe has joined #openstack-nova13:37
*** sdague has quit IRC13:39
*** jwcroppe has quit IRC13:42
*** takedakn has quit IRC13:43
*** david_1 has joined #openstack-nova13:44
*** dgonzalez_ has joined #openstack-nova13:44
*** seife_ has joined #openstack-nova13:44
*** mkoderer_ has joined #openstack-nova13:44
*** dgonzalez_ has quit IRC13:46
*** seife_ has quit IRC13:46
*** david_1 has quit IRC13:46
*** mkoderer_ has quit IRC13:46
*** slaweq_ has joined #openstack-nova13:48
figleafcdent: oh, there's a lot. I'm just too polite to express myself :)13:48
cdentfigleaf: polite is never a word I heard near you13:48
*** jwcroppe has joined #openstack-nova13:53
*** burt has joined #openstack-nova13:53
*** baoli has joined #openstack-nova13:54
*** baoli has quit IRC13:54
*** baoli has joined #openstack-nova13:55
leakypipesdansmith: morning superdan.13:55
*** dansmith is now known as superdan13:55
superdanshame is so effective13:55
leakypipeslol13:56
*** efried is now known as fried_rice13:56
leakypipesah, knock-on effects. :)13:56
fried_riceHappy Friday!13:56
fried_riceFrieday13:56
superdanwe should do more of these three-day workweek deals13:56
leakypipesheh13:56
fried_rice+113:56
*** slaweq_ has quit IRC13:58
*** mriedem has joined #openstack-nova13:58
mriedemo/13:58
leakypipesmriedem: mornin.13:59
*** alexchadin has quit IRC14:03
*** adisky__ has quit IRC14:08
*** hongbin has joined #openstack-nova14:08
*** amotoki is now known as amotoki_away14:09
*** slaweq has quit IRC14:09
*** slaweq has joined #openstack-nova14:10
mriedemgmann: looking at https://review.openstack.org/#/c/480815/1/specs/pike/approved/fix-to-return-server-groups-quota-in-quota-class.rst@5114:10
mriedemdid we also miss those other resources in the quota class api, like fixed ips, floating ips, etc?14:11
mriedemor was it just 'networks'?14:11
*** iceyao has quit IRC14:12
*** slaweq has quit IRC14:14
*** prateek has quit IRC14:14
*** slaweq has joined #openstack-nova14:14
*** tbachman has quit IRC14:17
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Update quota class spec to filter out networks quota  https://review.openstack.org/48081514:18
*** gouthamr has joined #openstack-nova14:19
*** itlinux has joined #openstack-nova14:19
*** slaweq has quit IRC14:19
*** felipemonteiro_ has joined #openstack-nova14:19
*** felipemonteiro__ has joined #openstack-nova14:21
*** felipemonteiro_ has quit IRC14:24
openstackgerritMerged openstack/nova-specs master: Update quota class spec to filter out networks quota  https://review.openstack.org/48081514:26
*** zhurong has quit IRC14:26
*** slaweq has joined #openstack-nova14:26
*** awaugama has joined #openstack-nova14:27
*** armax has joined #openstack-nova14:27
*** mkucia has joined #openstack-nova14:27
mriedemso who wants to review this change to use the cinder 3.27 attachments API flow in swap volume? https://review.openstack.org/#/c/456971/14:31
*** mdnadeem has quit IRC14:31
*** slaweq has quit IRC14:31
mriedemtempest has already passed on it from higher in the stack which triggers the new behavior14:31
*** mdnadeem has joined #openstack-nova14:32
*** mdnadeem has quit IRC14:32
leakypipesmriedem: do you want me to move those two lines in the allocation candidates patch or do it in a followup patch?14:37
mriedemleakypipes: follow up is fine14:37
leakypipesk14:37
*** andreas_s has quit IRC14:41
*** sdague has joined #openstack-nova14:44
*** lbragstad has joined #openstack-nova14:45
*** stvnoyes1 has quit IRC14:49
*** catintheroof has quit IRC14:52
mriedemruh roh14:53
*** catintheroof has joined #openstack-nova14:53
*** itlinux has quit IRC14:53
mriedemsuperdan: melwitt: i know you're on a call, but after that, let me ruin your day https://github.com/openstack/nova/blob/56cd608d3a199dcb02ac2ae071ff3057241259da/nova/compute/api.py#L372314:53
mriedemwhen attaching a volume to a shelved offloaded instance, we create the bdm in the api - so cell014:54
mriedemwe must not have a tempest test for this14:54
melwittrats14:54
mriedemcould probably recreate with a functional test, but i'll start by reporting abug14:55
*** catinthe_ has joined #openstack-nova14:56
mriedemhmm, AttachVolumeShelveTestJSON in tempest should test this14:56
superdanguh14:57
mriedemso either the tempest test is busted, or i'm missing something that makes this work14:59
*** catintheroof has quit IRC14:59
*** lucasxu has quit IRC15:04
*** Oku_OS is now known as Oku_OS-away15:04
*** rcernin has quit IRC15:06
*** catintheroof has joined #openstack-nova15:06
*** ociuhandu has joined #openstack-nova15:09
*** catinthe_ has quit IRC15:09
superdanmriedem: well, that clearly needs to be targeted15:10
*** sudipto has joined #openstack-nova15:10
*** sudipto_ has joined #openstack-nova15:10
leakypipescdent: thx for continuing your resource providers weekly summaries. good job catching up on all the change while you were on PTO. look to have gotten everything correct, AFAICT.15:11
cdentleakypipes: it's my UVP15:11
*** markus_z has quit IRC15:11
mriedemsuperdan: yeah, just really odd that the tempest test wouldn't fail, unless the test is broken15:11
cdentthanks for the confirmation that I didn't miss anything obvious15:12
superdanmriedem: yeah15:12
superdanmriedem: does that fail with a constraint error, or do we just create it and then it never attaches on unshelve?15:12
superdanbecause maybe the tempest test isn't validating via ssh15:12
mriedemthe tempest test does do some ssh counting of volumes on the guest15:13
superdanmriedem: actually,15:13
superdanmriedem: until my devstack patch, the control services are not pointing at cell0 for their default15:14
superdanso that's why15:14
mriedemhmm, so why doesn't your devstack patch fail on this though?15:14
superdanmriedem: it'd be the canary against nova that d-o it that would fail15:14
superdanthis guy: https://review.openstack.org/#/c/473565/15:15
superdanis that test new or something?15:15
superdanhmm, nope passing in the canary15:15
*** acormier has joined #openstack-nova15:16
cdentleakypipes: requirements change for new gabbi if you're inclined to move that along: https://review.openstack.org/48166515:16
*** zzzeek_ has joined #openstack-nova15:17
*** zzzeek_ has quit IRC15:17
mriedemtempest is configured to run ssh validatoin, so it should do this: http://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/volumes/test_attach_volume.py#n18115:19
mriedemmaybe the counter is broken so it always reports 0 and it's comparing 0 to 0 and passes?15:19
leakypipescdent: done15:20
superdanmriedem: heh15:20
mriedemalthough this would fail http://git.openstack.org/cgit/openstack/tempest/tree/tempest/api/compute/volumes/test_attach_volume.py#n21915:20
mriedemnum_vol + 115:20
*** burgerk has joined #openstack-nova15:22
mriedemsuperdan: we need to update your canary patch to depend on I08d7da843d18b426dda8a8a231039d950a4c0ce5 now15:25
mriedemshall i push the button?15:25
superdanmriedem: I'm working on a target change, so I will do that when I'm done here15:26
cdentthanks leakypipes15:26
*** ckopper has quit IRC15:26
openstackgerritMerged openstack/nova master: Support tag instances when boot(3/4)  https://review.openstack.org/45959315:27
* cdent dines15:27
*** cdent has quit IRC15:27
*** ckopper has joined #openstack-nova15:28
superdanmriedem: was there a bug for this shelved issue?15:31
mriedemno, i can create one15:31
superdanthanks15:31
mriedemyou know,15:33
mriedemanother thing,15:33
mriedemwhen we shelve offload a server, we never clean up it's InstanceMapping,15:34
mriedemand when we unshelve it, conductor asks the scheduler for a new host, which could be in a different cell,15:34
mriedembut we never create a new instance mapping, or update the existing instance mapping, for that new cell15:34
*** catinthe_ has joined #openstack-nova15:35
superdanmriedem: we can't move it between cells,15:35
superdanso if that's true, we need to be asking the scheduler to limit to one cell,15:35
superdanlike we do for resize15:35
mriedemi don't see anything in conductor that's doing that15:35
mriedemis it in the req spec?15:35
superdanyep15:35
superdanreqspec.destination.cell15:35
*** ckopper has quit IRC15:36
*** catintheroof has quit IRC15:36
mriedemok this https://github.com/openstack/nova/blob/56cd608d3a199dcb02ac2ae071ff3057241259da/nova/conductor/tasks/migrate.py#L63-L6615:38
mriedemthat's the only place we set destination.cell from what i can tell15:39
*** amotoki_away is now known as amotoki15:39
superdanyep15:40
mriedemok i'll open a separate bug for that15:41
*** abalutoiu has quit IRC15:42
superdancool15:42
*** chyka has joined #openstack-nova15:42
superdanwell, not cool, but..15:42
mriedemabout as cool as a kick in the pants15:42
mriedemmaybe another nail in the shelve coffin15:42
superdanmeh, anyone that uses shelve is probably used to shelve being broken15:43
mriedem"Days since shelve failed: 0"15:43
mriedem^ in their office15:43
superdanhah yeah15:44
*** tbachman has joined #openstack-nova15:47
mriedemhmm, in the multi-cell job, the cpu config database is also pointing at cell015:48
mriedemhttp://logs.openstack.org/65/473565/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fcfedba/logs/etc/nova/nova-cpu.conf.txt.gz15:48
mriedembut it should go through conductor when the compute manager queries for the list of bdms right?15:48
mriedemand cell conductor should be using http://logs.openstack.org/65/473565/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fcfedba/logs/etc/nova/nova_cell1.conf.txt.gz ?15:48
superdanyeah15:48
*** amotoki is now known as amotoki_away15:49
*** itlinux has joined #openstack-nova15:49
superdanreally we should unset the db connection for both main and api in that cpu config,15:49
superdanbut the way I generate it is kinda weird15:49
*** tbachman_ has joined #openstack-nova15:49
mriedemthe [database] one for sure,15:49
mriedembut the api_database one is needed for the retry and affinity crap15:50
superdannot in compute15:50
mriedemwell, at least affinity15:50
mriedemsure it is, the compute manager pulls server groups from the api db right?15:50
*** damien_r has quit IRC15:50
superdanno, it would ask conductor like anything else15:51
superdanand conductor in cell1 is configured to not be able to find the api db: http://logs.openstack.org/65/473565/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fcfedba/logs/etc/nova/nova_cell1.conf.txt.gz15:51
superdanwhich means it can't retry in that configuration nor do the affinity check,15:51
mriedemso how does the affinity stuff not all blow up?15:51
superdanwhich is why that workaround config was added and the devstack patch sets it15:51
mriedemoh15:51
*** tbachman has quit IRC15:52
*** tbachman_ is now known as tbachman15:52
superdanmriedem: got a bug for the offload target thing yet?15:52
mriedemhttp://logs.openstack.org/65/473565/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fcfedba/logs/etc/nova/nova_cell1.conf.txt.gz15:52
mriedemoops15:52
mriedemi meant, if not CONF.workarounds.disable_group_policy_check_upcall:15:52
*** sridharg has quit IRC15:52
mriedemok15:52
mriedemhttps://bugs.launchpad.net/nova/+bug/170293215:53
openstackLaunchpad bug 1702932 in OpenStack Compute (nova) "Unshelving an offloaded server with volume attachments may not attach to the guest in multi-cell env" [Undecided,New]15:53
mriedemi'll crank out another one for the unshelve limit to same cell thing15:53
superdanthanks15:53
*** yangyapeng has joined #openstack-nova15:54
*** klipka has quit IRC15:54
openstackgerritDan Smith proposed openstack/nova master: DNM: Canary  https://review.openstack.org/47356515:54
openstackgerritDan Smith proposed openstack/nova master: Fix targeting cell when attaching a volume to a shelved instance  https://review.openstack.org/48168315:54
superdanhere's that first fix and updated canary ^15:54
*** Apoorva has joined #openstack-nova15:55
mriedemhttps://bugs.launchpad.net/nova/+bug/170293515:56
openstackLaunchpad bug 1702935 in OpenStack Compute (nova) "Unshelving an offloaded server does not restrict to the original cell" [Undecided,New]15:56
*** lucasagomes is now known as lucas-afk15:58
*** gyee has joined #openstack-nova15:58
mriedemcool https://review.openstack.org/#/c/481683/ is easier than i thought, but makes sense. still really wondering how this wasn't caught in tempest16:01
*** ckopper has joined #openstack-nova16:04
*** jmlowe_ has quit IRC16:05
*** yamahata has joined #openstack-nova16:07
*** acormier has quit IRC16:08
mriedemso normal attach volume works to create the volume bdm in the same cell as the instance because when we lookup the instance, set target the context16:12
mriedemand we create that bdm in the cell compute service16:13
*** rajathagasthya has joined #openstack-nova16:14
*** thorst has quit IRC16:15
*** catinthe_ has quit IRC16:19
*** catintheroof has joined #openstack-nova16:19
*** mkucia has quit IRC16:21
*** READ10 has joined #openstack-nova16:21
*** sapcc-bot has quit IRC16:24
*** dfisher has joined #openstack-nova16:24
*** carthaca_ has quit IRC16:24
*** sapcc-bot has joined #openstack-nova16:24
*** carthaca_ has joined #openstack-nova16:24
*** iceyao has joined #openstack-nova16:29
mriedemanother one https://bugs.launchpad.net/nova/+bug/170295916:34
openstackLaunchpad bug 1702959 in OpenStack Compute (nova) "MigrationNotFound in multi-cell setup doing server external events processing" [High,Triaged]16:34
*** ociuhandu has quit IRC16:36
*** iceyao has quit IRC16:36
*** dtp has joined #openstack-nova16:36
mriedemi'll take a crack at that one16:38
*** jpena is now known as jpena|off16:38
dfisheranybody know of attach/detach issues with current nova/cinder (via devstack) bits?  I can't seem to get a simple volume to attach to a simple Ubuntu or Cirros VM16:38
mriedemno known issues16:39
dfisherhmm, ok.16:39
dfisherthanks16:39
*** amotoki_away is now known as amotoki16:40
superdanmriedem: is that one resolved by the patch that is up already?16:43
superdanmriedem: https://review.openstack.org/#/c/445142/16:43
clarkbmriedem: http://logs.openstack.org/31/476631/18/gate/gate-nova-tox-functional-ubuntu-xenial/2cafb17/console.html#_2017-07-07_15_29_18_416631 known issue? that reset the gate not too long ago. Looks like test is attempting admin request and failing without admin rights16:46
*** psachin has joined #openstack-nova16:47
*** amotoki is now known as amotoki_away16:49
mriedemclarkb: i'm not aware of that one16:50
mriedemsuperdan: maybe given https://review.openstack.org/#/c/445142/10/nova/compute/api.py@426316:50
mriedemsuperdan: are you ok with me making the fleetify change depend on that patch as well?16:51
superdanmriedem: sure16:51
*** jmlowe has joined #openstack-nova16:52
*** tbachman has quit IRC16:53
openstackgerritmelanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens  https://review.openstack.org/32538116:56
openstackgerritmelanie witt proposed openstack/nova master: Use ConsoleConnection object to generate authorizations  https://review.openstack.org/32541416:56
openstackgerritmelanie witt proposed openstack/nova master: Add console connection object  https://review.openstack.org/32006316:56
openstackgerritmelanie witt proposed openstack/nova master: Add access_url_base to console_auth_tokens table  https://review.openstack.org/33461416:56
openstackgerritmelanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation  https://review.openstack.org/33399016:56
openstackgerritmelanie witt proposed openstack/nova master: Add console_auth_token_get() method to DB API  https://review.openstack.org/48170016:56
mriedemok, fleeitify updated, will check out the api logs when that's done to see if the migration not found is gone16:56
*** psachin has quit IRC16:57
*** efoley has quit IRC16:58
mriedemclarkb: have you checked logstash?16:58
*** READ10 has quit IRC16:59
mriedemprobably can't really17:00
clarkbmriedem: not yet trying to diagnose problems with my desktop :/17:00
mriedemin general we've had very weird failures like that with the nova functional tests,17:00
mriedemsomething is making a request to the placement service and another is making a request to the compute api service, and the response goes the wrong way,17:01
mriedemassuming eventlet weirdness17:01
*** ralonsoh has quit IRC17:03
mriedemaha17:05
mriedemvdrok: found that weird sql connection thing in the fleetify patch17:05
openstackgerritJohn Griffith proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028517:06
mriedemhttp://logs.openstack.org/56/477556/3/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/ee3e9b6/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_05_20_44_19_70564617:06
mriedemthe subnode n-cpu is doing the server group affinity check, which blows up b/c the cell conductor doesn't have an api db connection,17:06
mriedemthe nova-cpu.conf on the subnode is missing the config option to disable that upcall17:06
*** sdague has quit IRC17:09
*** jmlowe has quit IRC17:10
vdrokmriedem: cool, thanks! Do we need to set it in ironic plugin or it's going to be handled on Nova side?17:10
mriedemnot sure, it needs to be handled in https://review.openstack.org/#/c/477556/4/lib/nova though17:10
*** trungnv has quit IRC17:11
mriedemi think this is where the nova-cpu.conf is used https://review.openstack.org/#/c/477556/4/lib/nova@81817:11
*** iceyao has joined #openstack-nova17:11
*** hieulq has quit IRC17:12
*** fragatina has joined #openstack-nova17:13
vdrokmriedem: aha, ok.17:13
mriedemi don't know what nova.conf it's copying though, or where that is configured17:15
*** Swami has joined #openstack-nova17:15
*** iceyao has quit IRC17:16
mriedemah i think i know where to set it17:17
mriedemif dan is ok with me touching his change17:17
mriedemsuperdan: i think i know how to fix the subnode nova.conf thing for the upcall in https://review.openstack.org/#/c/477556/ - ok with me doing that?17:19
*** tbachman has joined #openstack-nova17:20
superdanmriedem: not sure what you mean "fix the upcall"17:20
* superdan just got off the phone17:21
mriedemthe subnode n-cpu conf isn't configured to disable the server group upcall17:21
mriedemi know where to fix it in the fleetify change17:21
mriedemasking permission17:21
superdanit's not?17:21
mriedemf no17:21
superdanohh, subnode17:21
superdangotcha17:21
superdanyes please17:21
mriedemaye aye17:21
mriedemis it weird when i can see the mail man out of the corner of my eye and look at him and he nods at me cross my yard to drop something off?17:22
mriedemshould we have such a familiar relationship at this point?17:22
mriedemok it's up https://review.openstack.org/#/c/477556/4..5/lib/nova17:23
mriedemand now it's taco time17:23
*** dave-mccowan has joined #openstack-nova17:24
smcginnismriedem: But it's not Tuesday.17:24
*** links has joined #openstack-nova17:25
*** jmlowe has joined #openstack-nova17:25
*** trungnv has joined #openstack-nova17:26
*** hieulq has joined #openstack-nova17:26
*** baoli has quit IRC17:27
openstackgerritMathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change  https://review.openstack.org/45432217:28
*** baoli has joined #openstack-nova17:28
*** links has quit IRC17:29
*** links has joined #openstack-nova17:30
*** sambetts is now known as sambetts|afk17:34
melwittunless I'm missing something, we have some bugs in nova/conductor/manager.py where RequestSpec objects are being passed to _set_vm_state_and_notify() that doesn't handle them17:34
*** sudipto has quit IRC17:35
*** sudipto_ has quit IRC17:35
*** ociuhandu has joined #openstack-nova17:36
*** links has quit IRC17:36
*** slaweq has joined #openstack-nova17:37
*** gjayavelu has joined #openstack-nova17:39
melwittnevermind, I think I see where it's being converted to a dict before calling the notify17:39
*** baoli has quit IRC17:40
*** amotoki_away is now known as amotoki17:40
*** baoli has joined #openstack-nova17:41
*** fragatina has quit IRC17:42
*** fragatina has joined #openstack-nova17:43
mriedemmelwitt: i need you to solve the riddle of why shelved offloaded volume attach wasn't failing in the multi-cell setup17:43
mriedemonly you are capable of cracking that nut17:43
melwittnow that you've said that, you'll probably figure it out within a few minutes :)17:44
*** bnemec is now known as beekneemech17:45
mriedemno i gave up17:45
melwittdangit17:46
*** fragatina has quit IRC17:47
*** slaweq has quit IRC17:49
*** yamahata has quit IRC17:49
*** thorst has joined #openstack-nova17:49
*** slaweq has joined #openstack-nova17:50
*** amotoki is now known as amotoki_away17:50
*** kaisers_ has quit IRC17:50
*** kaisers_ has joined #openstack-nova17:51
*** fragatina has joined #openstack-nova17:51
*** fragatina has quit IRC17:51
melwittI keep reading _BaseTaskTestCase as BasketCase17:52
*** iceyao has joined #openstack-nova17:52
*** fragatina has joined #openstack-nova17:52
*** thorst has quit IRC17:52
*** thorst has joined #openstack-nova17:52
figleafdo you have the time to listen to me whine?17:52
*** iceyao has quit IRC17:57
* superdan wonders who that was intended to be a /msg for17:59
*** gjayavelu has quit IRC17:59
melwittit was for the channel. important stuff18:01
figleaffor all the basket cases in the channel18:01
*** kaisers_ has quit IRC18:01
figleafsuperdan: https://www.youtube.com/watch?v=NUTGr5t3MoY18:02
*** gjayavelu has joined #openstack-nova18:02
superdanah, dang, I didn't make the connection18:02
*** stvnoyes has joined #openstack-nova18:06
*** lpetrut has quit IRC18:08
*** dtantsur|afk has quit IRC18:10
*** dtantsur has joined #openstack-nova18:13
*** tesseract has quit IRC18:21
mriedemleakypipes: is this complete now? https://blueprints.launchpad.net/nova/+spec/shared-resources-pike18:23
mriedemthere are no open changes, and the allocation request candidate stuff handles RPs associated via aggregate18:24
*** yamahata has joined #openstack-nova18:24
leakypipesmriedem: yeah. #4 on that list is the only one not done, and the allocation candidates will handle that (not in the scheduler reporting client, but rather int he scheduler during claims)18:24
mriedemleakypipes: ok cool i'm going to close it out then18:25
mriedemthanks18:25
leakypipeskk18:25
mriedemfried_rice: same with https://blueprints.launchpad.net/nova/+spec/powervm-nova-compute-driver - i think i'm going to close that out18:26
mriedemi don't see anything critical in there that we need to get in for pike18:26
fried_ricemriedem Critical, no.  Some nice-to-haves.  But closing the bp shouldn't preclude further changes in pike, right?18:27
*** itlinux has quit IRC18:27
mriedemclosing it means i'm not going to look at anything proposed for it18:29
mriedemin pike18:29
mriedembecause i need to narrow my focus on what still needs to get done18:29
*** pchavva has quit IRC18:31
openstackgerritJay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates  https://review.openstack.org/47663118:31
openstackgerritJay Pipes proposed openstack/nova master: placement: claim resources in scheduler  https://review.openstack.org/47663218:31
leakypipesmriedem, superdan: ^^18:32
leakypipesdefinitely should add some functional testing for that.18:32
leakypipesbut it's good enough to get reviews on IMO.18:32
superdandid you just kick that out of the gate with that push?18:34
superdanyup18:34
mriedemgit review -R18:35
mriedemftw18:35
superdanyeah18:35
*** bit_lySLH2uSZHed has joined #openstack-nova18:36
leakypipesmriedem, superdan: yeah, sorry about that :(18:36
leakypipesfigleaf had a worry about the previous patch, so perhaps you could see his review on the previous revision of https://review.openstack.org/47663218:37
*** bit_lySLH2uSZHed has quit IRC18:37
clarkbfwiw git review -R shouldn't really be necessary anymore. You should only get a rebase from git review if it hits a merge conflict18:39
clarkbin which case you hvae to push a rebase at some point18:39
*** amotoki_away is now known as amotoki18:41
superdanclarkb: gerrit identified the bottom as a rebase only.18:42
superdanso I don't think that is accurate for this case18:42
leakypipessuperdan: I rebased to master explicitly (by mistake)18:43
figleafleakypipes: did that comment make any sense?18:43
superdanleakypipes: right I know18:43
leakypipesfigleaf: well, I tried to answer as best I could. did you see my response?18:43
figleafjust looking...18:43
leakypipesguys, I need to run out for a couple hours... I will be back later on. sorry!18:44
figleafleakypipes: np - I have to run out now too18:44
figleafleakypipes: but I'm still confused as to how this is going to work w/o returning alloc candidates18:44
*** kaisers_ has joined #openstack-nova18:47
*** itlinux has joined #openstack-nova18:47
*** slaweq has quit IRC18:49
*** slaweq has joined #openstack-nova18:49
*** amotoki is now known as amotoki_away18:51
*** slaweq has quit IRC18:54
*** lpetrut has joined #openstack-nova18:54
*** Sukhdev has joined #openstack-nova18:58
mriedemsuperdan: booya fleetify is passing the multinode job http://logs.openstack.org/56/477556/5/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/aed9486/19:01
superdanschwing19:01
mriedemand the migration not found errors are gone19:02
mriedemsubnode nova-cpu.conf also has the disable flag http://logs.openstack.org/56/477556/5/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/aed9486/logs/subnode-2/etc/nova/nova-cpu.conf.txt.gz19:02
*** bit_lySLH2uSZHed has joined #openstack-nova19:04
*** bit_lySLH2uSZHed has left #openstack-nova19:05
*** jamesden_ has joined #openstack-nova19:06
*** jamesdenton has quit IRC19:07
mriedemjgriffith: clarified what i meant in https://review.openstack.org/#/c/330285/88/nova/compute/api.py@390119:11
openstackgerritSumedh Degaonkar proposed openstack/nova master: Adds 'sata' as a valid disk bus for qemu and kvm hypervisors  https://review.openstack.org/45979419:12
jgriffithmriedem thanks, once they get network back up in the lab I'll go back through and fix the unit tests and pep8 I appear to have broken19:12
jgriffithalso will see if I can figure out what broke after the rebase19:12
jgriffithmriedem oh... looks like you didn't see the update19:13
jgriffithmriedem https://review.openstack.org/#/c/330285/89/nova/compute/api.py@390119:13
mriedemha19:14
jgriffith:)19:14
mriedemvolume_id doesn't exist19:14
mriedemvolume['id'] is what you need19:14
jgriffithawww crap!!!19:14
mriedemotherwise looks good19:14
openstackgerritSumedh Degaonkar proposed openstack/nova master: Adds 'sata' as a valid disk bus for qemu and kvm hypervisors  https://review.openstack.org/45979419:14
mriedemlet me pad some stats here19:14
jgriffithmriedem thanks, knew I was screwed when I couldn't test19:15
mriedemfigleaf: we have some other changes to do in https://blueprints.launchpad.net/nova/+spec/custom-resource-classes-in-flavors right? there is some data migration thing that is supposed to happen on startup of the nova-compute service with ironic, so it can retrofit older flavors19:16
mriedemah yeah this https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/custom-resource-classes-in-flavors.html#data-model-impact19:18
mriedemsuperdan: in ^ should that say "will not be schedulable" ?19:19
superdanmriedem: I think it's saying that until you account for the new resource types,19:20
superdannova will think it could schedule instances to nodes that are already used, because they haven't yet reported that the instance is consuming one of the new resources19:21
mriedemah19:21
superdanyou buy that?19:21
*** kaisers_ has left #openstack-nova19:21
mriedemso CUSTOM_BAREMETAL_INFINIBAND_GOLD is used but not reported as used19:21
superdanyar19:22
mriedemok,19:22
mriedemso,19:22
mriedemif we move the claim/allocation stuff to the scheduler, can we still do this data migration sync up on nova-compute start?19:22
mriedemi mean, we can, we have the scheduler report client,19:22
mriedemand the update_available_resource periodic,19:23
mriedemjust wondering if that will handle it19:23
superdanmriedem: the compute node also isn't going to report any GOLD resources available until it starts up on new code either19:23
superdanso I think if you restart onto the new scheduler,19:23
*** ckopper has quit IRC19:24
superdanwe'll start asking for resources that expose GOLD once the flavors are updated, but no computes will have any GOLDs to give until they are restarted and start exposing that19:24
superdanwait19:24
superdandid we already do that part in ocata?19:24
superdanyeah, okay yeah19:24
superdanI think I've got this now19:24
superdanlemme try again:19:24
superdanIn ocata, we got the ironic driver to expose 1 $ironic_node_resource_class for each node to placement19:24
superdanif we update the real flavors with the new resource type,19:25
openstackgerritmelanie witt proposed openstack/nova master: Make security_group_rules use check_deltas() for quota  https://review.openstack.org/47770019:25
openstackgerritmelanie witt proposed openstack/nova master: Remove 'reserved' count from used limits  https://review.openstack.org/44624219:25
openstackgerritmelanie witt proposed openstack/nova master: Make key_pairs use check_deltas() for quota  https://review.openstack.org/47769919:25
openstackgerritmelanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage  https://review.openstack.org/44624319:25
openstackgerritmelanie witt proposed openstack/nova master: Count instances to check quota  https://review.openstack.org/41652119:25
superdanscheduler would send instances to busy computes thinking there was room19:25
openstackgerritmelanie witt proposed openstack/nova master: Make Quotas object favor the API database  https://review.openstack.org/41094519:25
superdanwhat we need,19:25
openstackgerritmelanie witt proposed openstack/nova master: Add online migration to move quotas to API database  https://review.openstack.org/41094619:25
openstackgerritmelanie witt proposed openstack/nova master: Limit maximum pending resizes for preventing over quota  https://review.openstack.org/48173919:25
superdanis to data migrate the _instance_ flavors to also report that they use one of the new resources,19:25
superdanso that the computes start reporting 1 total, 1 used, 0 available19:25
superdanso really,19:26
superdanops just need to run data migrations before they update the main flavors to use the override I think19:26
superdanmake sense/19:26
mriedemyeah, that's where i was going in my head,19:27
mriedemthat the compute updates the existing instance embedded flavor on startup so we can fix the allocations reported in,19:27
superdanright19:28
mriedemand it's good that none of it turns on until you fiddle the flavors19:28
superdanyeah19:28
mriedemalthough, we don't actually pull the custom resource off the instance.flavor in the compute, we pull it off the node19:28
mriedemso i'm a bit fuzzy on where the existing instance.flavor comes into play19:29
mriedemthis https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L65819:29
superdanwe report inventory based on the node19:29
superdanwe report allocations based on the instance/flavor19:29
superdanand we request from placement based on the real flavor19:30
mriedemok so RT updates allocations here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L101219:30
*** dfisher has left #openstack-nova19:31
mriedemand this is where we get the allocations off the instance right? https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L14119:31
mriedemwhich is only ram, cpu and disk19:32
mriedemnot fancy pants ironic stuff19:32
*** smatzek has quit IRC19:32
superdanyeah19:32
superdanwe kinda need the ironic driver to do the instance flavor migration though I think19:32
mriedemsure, but there are 2 parts to this if i'm understanding,19:32
superdanbecause it'd be hard to do that from nova-manage, not being 100% sure the hypervisor type of an instance I think19:33
mriedem1. ironic driver updates the instance.flavor if it doesn't have the custome rresource class but the node.resource_class is set19:33
mriedem2. scheduler report client needs to account for custom resource class allocations off the instance flavor19:33
mriedemthen 3. deployer fiddles the bits19:33
mriedem4. cleanup19:33
*** Apoorva has quit IRC19:34
mriedemi think #2 is missing from the spec, unless i'm missing something19:34
superdanyeah I suppose you're right19:34
*** yamamoto has quit IRC19:34
superdanit's implied19:34
mriedemheh19:35
*** jjung has joined #openstack-nova19:35
mriedemmayhap i'll update the spec quick19:35
melwittsuperdan: can you tell where I would need to put an "objects.register_all()" to call object classmethods in the websocketproxy? would it have to be here or is there a way it could only be done once? https://github.com/openstack/nova/blob/master/nova/console/websocketproxy.py#L7119:38
*** jjung has quit IRC19:39
superdanmelwitt: you could do it at module-level.. it is only needed once per process19:39
melwittsuperdan: okay, cool. thanks19:40
superdanyou wouldn't want to do it per-request like that19:40
melwittyeah, that's what I was thinking19:41
*** amotoki_away is now known as amotoki19:42
openstackgerritmelanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation  https://review.openstack.org/33399019:42
*** awaugama has quit IRC19:44
*** dtantsur has quit IRC19:45
*** sdague has joined #openstack-nova19:46
*** slaweq has joined #openstack-nova19:49
*** slaweq_ has joined #openstack-nova19:50
*** jamesden_ has quit IRC19:50
*** dtantsur has joined #openstack-nova19:50
*** amotoki is now known as amotoki_away19:52
*** slaweq has quit IRC19:53
*** esberglu has quit IRC19:53
*** esberglu has joined #openstack-nova19:54
mriedemsuperdan: oh i guess that allocations thing was mentioned in the deps section https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/custom-resource-classes-in-flavors.html#dependencies19:55
mriedemmaybe that was supposed to or expected to happen in http://specs.openstack.org/openstack/nova-specs/specs/ocata/implemented/custom-resource-classes.html19:55
superdanmriedem: that part is done already19:55
mriedem"This depends on work to change the resource tracker to allow drivers to expose allocations of custom resource classes"19:55
superdanthe migration of existing instances is different from what is described there, and is specific to ironic19:55
superdanright that depends-on is done19:55
mriedemwe don't expose allocations for custom resource classes19:55
mriedemwe expose inventory for custom resource classess19:56
superdanwe can from the driver, hang on19:56
*** iceyao has joined #openstack-nova19:56
superdanoh19:56
mriedemthat's what i was talking about in https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L14119:56
*** catinthe_ has joined #openstack-nova19:56
superdanyeah okay19:56
superdanI was glossing over the allocation word there19:56
*** dtantsur has quit IRC19:57
superdanthere's still the migration work that needs doing which is neither of these19:57
*** tjones has joined #openstack-nova19:57
mriedemyeah i think i've covered that here in this spec update, hold on19:57
*** tjones has quit IRC19:58
superdancool, I gotsta jump on a call19:58
*** tjones has joined #openstack-nova19:58
*** esberglu has quit IRC19:58
*** catintheroof has quit IRC19:59
mriedemgeez another one19:59
mriedemthese aren't 900 numbers are they?19:59
superdanI have a problem19:59
*** jmlowe has quit IRC20:00
*** iceyao has quit IRC20:00
*** dtantsur has joined #openstack-nova20:02
*** jamesdenton has joined #openstack-nova20:05
*** liverpooler has quit IRC20:09
melwittgrr, internet is on the fritz again20:11
*** jamesdenton has quit IRC20:11
*** jamesdenton has joined #openstack-nova20:12
openstackgerritMatt Riedemann proposed openstack/nova-specs master: Amend spec for "Allow custom resource classes in flavor extra specs"  https://review.openstack.org/48174820:15
mriedemsuperdan: leakypipes: figleaf: ^20:15
melwittmriedem: I think that tempest test works because the common.get_instance() method gets the instance via compute/api and that does a set_target_cell() that targets the context to the cell the instance is in20:15
mriedemmelwitt: so the same reason that normal attach works20:15
mriedemso even though the instance isn't on a host,20:15
mriedemit's still mapped to the original cell20:15
mriedemtricksy baggins20:16
mriedemmelwitt: i told you you were the only one that could figure it out20:16
* mriedem goes to +2 dan's fix then20:16
* melwitt wipes nails on lapel20:16
mriedemha20:16
mriedemmayhap you'd like to +W https://review.openstack.org/#/c/481683/20:17
*** esberglu has joined #openstack-nova20:18
mriedemactually,20:18
mriedemso maybe this means we don't need that fix20:18
mriedemyeah, it was'nt failing b/c the context is already targeted20:19
melwittmriedem: yeah I was wondering, what broke that brought up the bug?20:19
mriedemnothing :(20:20
mriedemi noticed the local creation part during a review of something unrelated,20:20
mriedemand because of how local delete has bit us with cells,20:20
melwittah, okay20:20
mriedemi immediately thought this was also busted in a similar way20:20
melwittyeah, the set_target_cell is so hidden that it's hard to tell when we need an extra target cell or not20:21
*** burgerk_ has joined #openstack-nova20:22
*** burgerk has quit IRC20:25
*** markvoelker has quit IRC20:27
*** markvoelker has joined #openstack-nova20:27
*** burgerk_ has quit IRC20:28
openstackgerritAndrey Kurilin proposed openstack/python-novaclient master: Fix cropping the endpoint url  https://review.openstack.org/47981820:33
*** Apoorva has joined #openstack-nova20:35
*** yamamoto has joined #openstack-nova20:35
*** iceyao has joined #openstack-nova20:37
*** ijw has joined #openstack-nova20:38
*** yamamoto has quit IRC20:39
*** catinthe_ has quit IRC20:39
*** Apoorva has quit IRC20:39
*** mriedem1 has joined #openstack-nova20:40
*** iceyao has quit IRC20:41
*** abalutoiu has joined #openstack-nova20:41
*** sambetts|afk has quit IRC20:42
*** priteau has quit IRC20:42
*** mriedem has quit IRC20:42
*** abalutoiu_ has joined #openstack-nova20:43
*** amotoki_away is now known as amotoki20:43
*** sambetts has joined #openstack-nova20:43
*** Apoorva has joined #openstack-nova20:45
*** ijw has quit IRC20:45
*** abalutoiu has quit IRC20:46
*** ijw has joined #openstack-nova20:46
*** owalsh has quit IRC20:47
*** abalutoiu has joined #openstack-nova20:48
*** abalutoiu_ has quit IRC20:49
*** ckopper has joined #openstack-nova20:50
*** amotoki is now known as amotoki_away20:52
superdanmriedem1: ah yeah, so we probably don't need that20:53
superdanmriedem1: hence my asking where/how this came hup20:53
superdanup even20:53
*** abalutoiu has quit IRC20:54
mriedem1sorry20:55
*** abalutoiu has joined #openstack-nova20:55
*** mriedem1 is now known as mriedem20:55
mriedemthe local create thing scared me because of local delete issues20:55
superdanhah20:55
mriedemleakypipes: i went through https://review.openstack.org/#/c/476632/ - we can't actually allocate in the scheduler until we've done the changes in the compute to not claim if the allocations are already done, right?20:55
mriedemotheriwse we allocate in scheduler and still claim in compute20:56
superdanmriedem: we already have that right?20:56
mriedemdo we?20:56
superdanmriedem: compute just checks the allocations in placement, changing them only if need be20:56
mriedembut i thought the big win was not doing the claim at all20:56
mriedemin the resourc etracker20:56
superdanwe can't drop the RT until this is in place20:56
mriedemplus,20:56
mriedemthere should be a minimum compute version check somewhere i thought,20:57
mriedemwe had the whole back and forth about sending the actual allocations down to the compute over rpc20:57
*** abalutoiu_ has joined #openstack-nova20:57
superdanmriedem: I dunno, ocata computes did the allocation stuff right?20:57
mriedemto tell the compute if it should claim20:57
*** ijw has quit IRC20:57
superdanthat's to tell it if it should forego the normal RT claiming right?20:57
mriedemand i thought we settled on not sending hte allocations claimed over rpc, but instead just have the compute check to see if the allocations were already done for it20:57
mriedemand by pass the claim (noop)20:57
superdanyeah20:58
superdanhere's the short and curly of it:20:59
superdanthere is BBQ hurling its way towards me at about 60MPH, so I stop caring about this when it gets here20:59
*** ijw has joined #openstack-nova20:59
*** abalutoiu has quit IRC21:00
mriedemat 2pm?21:00
superdanhell yes.. taylor gets half day fridays in the summer21:00
*** owalsh has joined #openstack-nova21:01
mriedemso https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/placement-claims.html#other-deployer-impact21:01
mriedemand https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/placement-claims.html#work-items21:01
mriedem"Make compute nodes GET /allocations/<instance_id> for verifying if already created, and if so, don’t POST allocations to Placement service."21:01
mriedemthat's what i'm thinking of21:01
mriedemwe can sort it out on monday when everyone is actually around21:02
mriedemincluding his bauzasness21:02
superdanhttps://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L859-L87721:02
superdanL868 stops if they're equal21:02
mriedemyeah i know about that,21:03
*** ckopper has quit IRC21:03
superdanbypassing the existing RT still needs to happen21:03
mriedembut we're still doing all of this other claim checking stuff in the compute that seems unnecessary - although there are going to be things the compute side claim will pick up that we don't in the scheduler, like pci/numa and overhead21:03
superdanyep21:03
mriedemi wasn't sure what we were going to do about the nfv resources21:04
mriedemand i thought in boston for overhead we said, well, you adjust the reserved amount configs to buffer your inventory21:04
superdanwe said we'd do the simple thing first, expecting the op to reserve enough,21:04
*** ijw has quit IRC21:04
superdanpotentially updating reserved automatically after that yeah21:05
mriedemi'll just go back to my corner with https://review.openstack.org/#/c/471899/ where things make sense21:06
*** abalutoiu has joined #openstack-nova21:07
*** yamamoto has joined #openstack-nova21:08
*** smatzek has joined #openstack-nova21:08
*** abalutoiu_ has quit IRC21:09
*** thorst has quit IRC21:16
*** yamamoto has quit IRC21:17
*** iceyao has joined #openstack-nova21:18
*** owalsh has quit IRC21:19
*** abalutoiu has quit IRC21:21
*** owalsh has joined #openstack-nova21:21
*** acormier has joined #openstack-nova21:22
*** iceyao has quit IRC21:22
*** acormier has quit IRC21:24
*** itlinux has quit IRC21:26
ApoorvaOur Cinder CI is failing with following error http://paste.openstack.org/show/614811/. Is this a known issue?21:30
*** catintheroof has joined #openstack-nova21:33
*** edmondsw has quit IRC21:34
*** lpetrut has quit IRC21:34
*** thorst has joined #openstack-nova21:38
*** thorst has quit IRC21:38
*** dave-mccowan has quit IRC21:41
*** lyan has quit IRC21:42
*** amotoki_away is now known as amotoki21:43
sgordonso i am looking at this thread http://lists.openstack.org/pipermail/openstack/2017-July/thread.html#4513921:44
sgordon"[Openstack] Live Migration and LibVirt CPU Mode"21:44
sgordonand i could swear there was a legit bug around this at some point but am struggling to pin down where it was discussed/fixed21:44
*** yamamoto has joined #openstack-nova21:45
sgordonspecifically "Therefore it appears if  a VM XML CPU definition contains "cpu mode='host-model'" the cpu model is ignored and the 2 host CPU models are compared."21:45
openstackgerritMathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change  https://review.openstack.org/45432221:45
*** openstackgerrit has quit IRC21:47
*** smatzek has quit IRC21:49
sgordonring any bells for anyone?21:50
*** thorst has joined #openstack-nova21:50
*** yamamoto has quit IRC21:51
*** ijw has joined #openstack-nova21:51
superdansgordon: I think maybe kashyap was discussing that with someone at some point?21:51
*** priteau has joined #openstack-nova21:52
*** esberglu has quit IRC21:52
*** esberglu has joined #openstack-nova21:52
sgordonsuperdan, yeah - it definitely sounds familiar i just cant remember the outcome21:53
superdanyeah that's about all I know21:53
*** amotoki is now known as amotoki_away21:53
*** gjayavelu has quit IRC21:56
cburgesssuperdan sgordon That sounds about right. What is the specific question?21:56
*** priteau has quit IRC21:56
*** openstackstatus has quit IRC21:56
*** openstack has joined #openstack-nova21:58
cburgessif so then... working as intended.21:58
sgordonyeah but host model is not really host model21:58
sgordonit's an approximation of the host model21:59
cburgessRight21:59
*** iceyao has joined #openstack-nova21:59
sgordonif you go downthread i think they are saying they get the same when using custom and specifying westmere21:59
cburgessLet me keep reading...22:00
cburgessI wonder if he has different versions of libvirt/kvm between the hosts.22:02
sgordonpossibly22:02
cburgess"I'm beginning to suspect that because the VM has "cpu mode='host-model'" in its xml CPU definition,"22:02
sgordonthere is not much/any info about what versions of anything are in use22:02
cburgessAs I said.. working as intended.22:02
sgordonyeah - in that email they contradict themselves22:03
cburgessIf its using host-model.. you are screwed.22:03
cburgessPeriod..22:03
sgordonsay it's not working with custom, then say it is22:03
sgordonright22:03
cburgessRight..22:03
cburgessThis message...22:03
cburgesshttp://lists.openstack.org/pipermail/openstack/2017-July/045145.html22:03
sgordonand there is no way to get out of that without rebooting instances22:03
cburgessbasically describes thats in the XML22:03
cburgessand based upon that XML.. what he is seeing is whats expected.22:03
cburgessCorrect.22:04
*** iceyao has quit IRC22:04
cburgessHe could disable the CPU checks but... he runs the risk of the VM crashing on live migration because it sees the flags change.22:04
cburgessI know he doesn't want to reboot but once you are using host-model there is absolutely no safe/guaranteed way to got from new to old.22:05
sgordonright22:05
cburgessSo I feel for them.. but there is no solution. They could comment the checks out of nova if they wanted to but even that is a just rolling the device on the VMs crashing on migration.22:06
cburgessOr libvirt just refusing to do it.22:06
*** felipemonteiro__ has quit IRC22:07
sgordoni dont think that helps them anyway22:07
sgordonbecause it's passed the nova checks22:07
sgordonit's the libvirt checks kicking it out22:07
cburgessOh yeah.. well.. like I said...22:07
sgordonthanks for being a sounding board, clearly i have friday afternoon brain22:08
sgordoni will try and frame this in an email22:08
*** claudiub has quit IRC22:08
*** zzzeek_ has joined #openstack-nova22:08
*** zzzeek_ has quit IRC22:09
cburgesssgordon No worries, we dealt with this very issue a lot in the essex/folsom days. Trying to figure out exacly what CPU type and model info to use to guarnatee the best mix of performance and portability.22:10
*** figleaf is now known as edleafe22:10
*** jwcroppe has quit IRC22:11
*** burt has quit IRC22:11
*** jwcroppe has joined #openstack-nova22:11
sgordoncburgess, yeah - it's basically impossible to set defaults this because any given selection is a tradeoff22:12
sgordoncburgess, depends on the characteristics and requirements of each environment22:12
cburgesssgordon I think the key bit to explains is that all the config values are basically useless once you get down to the libvirt internal code. It will *always* use whats defined in the running VMs XML.22:12
sgordon(i mean obviously we *do* set defaults for this, it's just that they arent going to fit for everyone)22:12
cburgesssgordon Exactly. So we have to play around with a sane "default" for our product and then enable customers to change it for their deployment based upon their needs.22:13
cburgessThough to be fair most use our default since its designed around maximum portability and most of customers can't have downtime for their pets. :(22:13
*** zzzeek_ has joined #openstack-nova22:14
*** zzzeek_ has quit IRC22:14
*** edleafe- has joined #openstack-nova22:14
*** zzzeek_ has joined #openstack-nova22:14
*** zzzeek_ has quit IRC22:15
*** jwcroppe has quit IRC22:15
*** edleafe has quit IRC22:16
sgordonyeah the other aspect of course is someone may not notice when doing a greenfield deployment22:16
sgordonthe problem comes when they expand later and add a new generation of hosts22:16
cburgessYup. we didn't notice it until our first client did a server refresh after about a year.22:18
*** zzzeek_ has joined #openstack-nova22:19
*** zzzeek_ has quit IRC22:24
*** jamesdenton has quit IRC22:24
*** jamesdenton has joined #openstack-nova22:25
*** edleafe- is now known as edleafe22:25
*** zzzeek_ has joined #openstack-nova22:29
*** jamesdenton has quit IRC22:29
*** zzzeek_ has quit IRC22:30
*** zzzeek_ has joined #openstack-nova22:31
*** jamesdenton has joined #openstack-nova22:31
*** zzzeek- has joined #openstack-nova22:33
*** zzzeek_ has quit IRC22:35
*** iceyao has joined #openstack-nova22:40
*** zzzeek- has quit IRC22:41
*** catintheroof has quit IRC22:42
*** leakypipes has quit IRC22:43
*** amotoki_away is now known as amotoki22:44
*** iceyao has quit IRC22:45
*** sdague has quit IRC22:47
*** slaweq_ has quit IRC22:47
*** slaweq has joined #openstack-nova22:48
*** acormier has joined #openstack-nova22:51
*** slaweq has quit IRC22:53
*** amotoki is now known as amotoki_away22:54
*** acormier has quit IRC22:54
*** acormier has joined #openstack-nova22:54
*** gbarros has joined #openstack-nova22:55
*** tjones has left #openstack-nova22:56
*** jmlowe has joined #openstack-nova23:07
*** openstackgerrit has joined #openstack-nova23:12
openstackgerritMatt Riedemann proposed openstack/nova master: Handle uuids in os-hypervisors API  https://review.openstack.org/47189923:12
openstackgerritMatt Riedemann proposed openstack/nova master: Use uuid for id in os-services API  https://review.openstack.org/46428023:12
*** zzzeek_ has joined #openstack-nova23:17
openstackgerritMatt Riedemann proposed openstack/nova master: Handle uuids in os-hypervisors API  https://review.openstack.org/47189923:19
*** zzzeek_ has quit IRC23:21
*** zzzeek_ has joined #openstack-nova23:21
*** acormier has quit IRC23:22
*** abalutoiu has joined #openstack-nova23:23
mriedemmgagne: you overwrote my changes and re-introduced a bug https://review.openstack.org/#/c/454322/29..31 :)23:24
mriedemi'll just push my version again23:24
*** iceyao has joined #openstack-nova23:25
*** Apoorva has quit IRC23:26
*** acormier has joined #openstack-nova23:26
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Add ability to signal and perform online volume size change  https://review.openstack.org/45432223:26
*** rajathagasthya has quit IRC23:26
*** iceyao has quit IRC23:29
*** gbarros has quit IRC23:34
*** chyka has quit IRC23:34
*** chyka has joined #openstack-nova23:35
mriedemfixed, now i just need to flesh out the tests and docs for the os-instance-actions details changes in there, probably over the weekend23:35
mriedemthe tempest/devstack test stack had a clean run last night though, which is awesome23:35
*** gbarros has joined #openstack-nova23:37
*** chyka has quit IRC23:39
*** dtp has quit IRC23:40
*** iceyao has joined #openstack-nova23:44
*** abalutoiu has quit IRC23:45
*** amotoki_away is now known as amotoki23:45
*** abalutoiu has joined #openstack-nova23:47
*** Apoorva has joined #openstack-nova23:47
*** jmlowe has quit IRC23:48
*** abalutoiu has quit IRC23:48
*** iceyao has quit IRC23:49
*** abalutoiu has joined #openstack-nova23:49
*** acormier has quit IRC23:50
*** jmlowe has joined #openstack-nova23:50
*** ijw has quit IRC23:52
*** acormier has joined #openstack-nova23:52
*** abalutoiu_ has joined #openstack-nova23:52
*** ijw has joined #openstack-nova23:52
*** abalutoiu has quit IRC23:54
*** amotoki is now known as amotoki_away23:55
*** abalutoiu__ has joined #openstack-nova23:56
*** ijw has quit IRC23:57
*** abalutoiu has joined #openstack-nova23:57
*** thorst has joined #openstack-nova23:57
*** ijw has joined #openstack-nova23:58
*** Apoorva has quit IRC23:58
*** abalutoiu_ has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!