*** yangyapeng has joined #openstack-nova | 00:00 | |
*** yangyapeng has quit IRC | 00:05 | |
*** yamamoto has joined #openstack-nova | 00:08 | |
*** yangyapeng has joined #openstack-nova | 00:09 | |
*** gmann has quit IRC | 00:14 | |
*** gmann has joined #openstack-nova | 00:14 | |
*** jmlowe has quit IRC | 00:18 | |
*** jmlowe has joined #openstack-nova | 00:19 | |
*** yangyapeng has quit IRC | 00:20 | |
*** jmlowe_ has joined #openstack-nova | 00:22 | |
*** jmlowe has quit IRC | 00:24 | |
*** lbragsta_ has quit IRC | 00:28 | |
*** thorst has joined #openstack-nova | 00:31 | |
*** catintheroof has joined #openstack-nova | 00:33 | |
*** kiennt has joined #openstack-nova | 00:35 | |
*** thorst has quit IRC | 00:36 | |
*** Shunli has joined #openstack-nova | 00:46 | |
*** gouthamr has joined #openstack-nova | 01:01 | |
*** mriedem has joined #openstack-nova | 01:03 | |
*** thorst has joined #openstack-nova | 01:03 | |
*** thorst has quit IRC | 01:03 | |
*** trungnv has joined #openstack-nova | 01:05 | |
*** acormier_ has joined #openstack-nova | 01:06 | |
*** mdnadeem has joined #openstack-nova | 01:08 | |
*** acormier has quit IRC | 01:09 | |
*** r-daneel has joined #openstack-nova | 01:18 | |
*** acormier_ has quit IRC | 01:20 | |
*** acormier has joined #openstack-nova | 01:21 | |
*** phuongnh has joined #openstack-nova | 01:21 | |
*** Daisy_ has joined #openstack-nova | 01:23 | |
*** yufei has joined #openstack-nova | 01:23 | |
*** acormier has quit IRC | 01:25 | |
*** Daisy_ has quit IRC | 01:30 | |
*** Daisy_ has joined #openstack-nova | 01:33 | |
openstackgerrit | Tristan Cacqueray proposed openstack/nova master: Mask the token used to allow access to consoles https://review.openstack.org/220622 | 01:38 |
---|---|---|
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add tags to instance.create Notification https://review.openstack.org/459493 | 01:39 |
*** Daisy_ has quit IRC | 01:40 | |
*** Daisy_ has joined #openstack-nova | 01:45 | |
*** mtanino has joined #openstack-nova | 01:55 | |
*** mtanino has quit IRC | 01:55 | |
*** r-daneel has quit IRC | 02:06 | |
*** armax has joined #openstack-nova | 02:07 | |
*** catintheroof has quit IRC | 02:22 | |
*** acormier has joined #openstack-nova | 02:22 | |
*** r-daneel has joined #openstack-nova | 02:23 | |
*** acormier has quit IRC | 02:27 | |
*** mriedem has quit IRC | 02:43 | |
*** sbezverk has quit IRC | 02:44 | |
*** lbragsta_ has joined #openstack-nova | 02:48 | |
*** gouthamr has quit IRC | 02:49 | |
*** Daisy_ has quit IRC | 03:03 | |
*** thorst has joined #openstack-nova | 03:04 | |
*** Shunli has quit IRC | 03:05 | |
*** Shunli has joined #openstack-nova | 03:05 | |
*** vishwanathj has quit IRC | 03:08 | |
*** vishwanathj has joined #openstack-nova | 03:08 | |
*** thorst has quit IRC | 03:10 | |
*** mtreinish has quit IRC | 03:14 | |
*** mtreinish has joined #openstack-nova | 03:20 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: WIP: support os_xenapi's VDI streaming https://review.openstack.org/486475 | 03:26 |
*** fragatina has quit IRC | 03:38 | |
*** fragatina has joined #openstack-nova | 03:39 | |
*** mamandle has joined #openstack-nova | 03:40 | |
openstackgerrit | Tristan Cacqueray proposed openstack/nova master: Mask the token used to allow access to consoles https://review.openstack.org/220622 | 03:40 |
*** udesale has joined #openstack-nova | 03:42 | |
*** links has joined #openstack-nova | 03:46 | |
*** Nel1x has quit IRC | 04:01 | |
*** lbragsta_ has quit IRC | 04:02 | |
*** lbragsta_ has joined #openstack-nova | 04:03 | |
*** anish has quit IRC | 04:09 | |
*** mamandle has quit IRC | 04:11 | |
*** jjung has joined #openstack-nova | 04:17 | |
*** bhagyashris has quit IRC | 04:23 | |
*** adisky__ has joined #openstack-nova | 04:28 | |
*** fragatina has quit IRC | 04:31 | |
*** fragatina has joined #openstack-nova | 04:32 | |
*** lbragsta_ has quit IRC | 04:35 | |
*** prateek has joined #openstack-nova | 04:48 | |
*** bhagyashris has joined #openstack-nova | 04:50 | |
*** sbezverk has joined #openstack-nova | 04:51 | |
*** Dinesh_Bhor has joined #openstack-nova | 04:56 | |
openstackgerrit | sudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/481007 | 04:56 |
*** ratailor has joined #openstack-nova | 04:57 | |
*** wasmum has quit IRC | 05:01 | |
*** wasmum has joined #openstack-nova | 05:02 | |
*** thorst has joined #openstack-nova | 05:05 | |
*** thorst has quit IRC | 05:10 | |
*** bkopilov_ has joined #openstack-nova | 05:10 | |
openstackgerrit | Jianghua Wang proposed openstack/nova-specs master: Support virtual GPU resources https://review.openstack.org/450122 | 05:11 |
*** sridharg has joined #openstack-nova | 05:13 | |
openstackgerrit | Jianghua Wang proposed openstack/nova-specs master: Support virtual GPU resources https://review.openstack.org/450122 | 05:18 |
*** psachin has joined #openstack-nova | 05:30 | |
*** boris-42____ has joined #openstack-nova | 05:31 | |
*** kiennt has quit IRC | 05:32 | |
*** moshele has joined #openstack-nova | 05:35 | |
*** sree_ has joined #openstack-nova | 05:36 | |
*** sree_ is now known as Guest55915 | 05:36 | |
openstackgerrit | sudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/481007 | 05:44 |
*** mamandle has joined #openstack-nova | 06:03 | |
*** kiennt has joined #openstack-nova | 06:04 | |
*** Oku_OS-away is now known as Oku_OS | 06:07 | |
*** udesale__ has joined #openstack-nova | 06:07 | |
*** udesale has quit IRC | 06:10 | |
*** kiennt has quit IRC | 06:18 | |
*** kiennt has joined #openstack-nova | 06:18 | |
*** rcernin has joined #openstack-nova | 06:23 | |
*** cfriesen has quit IRC | 06:25 | |
*** thorst has joined #openstack-nova | 06:27 | |
*** andreas_s has joined #openstack-nova | 06:27 | |
*** mamandle has quit IRC | 06:28 | |
*** thorst has quit IRC | 06:31 | |
*** mamandle has joined #openstack-nova | 06:32 | |
*** tuanluong has joined #openstack-nova | 06:32 | |
*** yufei has quit IRC | 06:33 | |
*** yamamoto has quit IRC | 06:34 | |
*** mlakat has joined #openstack-nova | 06:34 | |
*** zsli_ has joined #openstack-nova | 06:41 | |
*** Shunli has quit IRC | 06:44 | |
*** moshele has quit IRC | 06:48 | |
*** sshwarts has joined #openstack-nova | 07:01 | |
*** udesale has joined #openstack-nova | 07:02 | |
*** nicolasbock has joined #openstack-nova | 07:03 | |
*** udesale__ has quit IRC | 07:04 | |
*** dixiaoli has joined #openstack-nova | 07:04 | |
*** mamandle has quit IRC | 07:06 | |
*** dixiaoli has quit IRC | 07:06 | |
*** migi_ is now known as migi | 07:12 | |
*** ralonsoh has joined #openstack-nova | 07:13 | |
*** damien_r has joined #openstack-nova | 07:18 | |
*** lennyb has quit IRC | 07:19 | |
*** ralonsoh_ has joined #openstack-nova | 07:22 | |
*** ralonsoh has quit IRC | 07:22 | |
*** wasmum has quit IRC | 07:28 | |
*** wasmum has joined #openstack-nova | 07:28 | |
*** rmart04 has joined #openstack-nova | 07:29 | |
*** lennyb has joined #openstack-nova | 07:32 | |
*** rmart04 has quit IRC | 07:34 | |
*** belmoreira has joined #openstack-nova | 07:39 | |
*** rmart04 has joined #openstack-nova | 07:43 | |
*** yamamoto has joined #openstack-nova | 07:45 | |
*** moshele has joined #openstack-nova | 07:47 | |
*** david-lyle has quit IRC | 07:50 | |
*** dklyle has joined #openstack-nova | 07:50 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 07:51 |
*** alexchadin has joined #openstack-nova | 07:54 | |
*** markus_z has joined #openstack-nova | 08:06 | |
*** trinaths has joined #openstack-nova | 08:09 | |
*** wasmum has quit IRC | 08:13 | |
*** wasmum has joined #openstack-nova | 08:14 | |
openstackgerrit | Moshe Levi proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265 | 08:15 |
*** yamahata has quit IRC | 08:15 | |
*** markus_z has quit IRC | 08:16 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyperv: Cleans up live migration Planned VM https://review.openstack.org/478943 | 08:16 |
*** danpawlik has quit IRC | 08:17 | |
*** danpawlik has joined #openstack-nova | 08:17 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove an unnecessary argument in _prep_resize https://review.openstack.org/486521 | 08:22 |
*** derekh has joined #openstack-nova | 08:23 | |
*** lucas-afk is now known as lucasagomes | 08:26 | |
openstackgerrit | sudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/481007 | 08:26 |
*** thorst has joined #openstack-nova | 08:27 | |
*** jjung has quit IRC | 08:29 | |
*** thorst has quit IRC | 08:32 | |
*** dklyle has quit IRC | 08:32 | |
*** dklyle has joined #openstack-nova | 08:33 | |
*** dtantsur|afk is now known as dtantsur | 08:34 | |
*** dklyle has quit IRC | 08:36 | |
*** mamandle has joined #openstack-nova | 08:39 | |
*** chohoor has quit IRC | 08:40 | |
*** jangutter has joined #openstack-nova | 08:42 | |
*** markus_z has joined #openstack-nova | 08:42 | |
*** david-lyle has joined #openstack-nova | 08:47 | |
kashyap | lyarwood: mdbooth: When you get a moment, mind taking a gander at this. It's in your wheelhouse: https://review.openstack.org/#/c/485752 -- "libvirt/driver.py: Set cache value for Cinder volume post-migration" | 08:47 |
*** david-lyle has quit IRC | 08:49 | |
*** david-lyle has joined #openstack-nova | 08:50 | |
*** dklyle has joined #openstack-nova | 08:53 | |
*** david-lyle has quit IRC | 08:53 | |
openstackgerrit | Moshe Levi proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265 | 08:55 |
*** litao__ has joined #openstack-nova | 08:58 | |
*** yamamoto has quit IRC | 09:02 | |
*** jaosorior has joined #openstack-nova | 09:02 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | 09:09 |
*** yamamoto has joined #openstack-nova | 09:15 | |
*** sambetts|afk is now known as sambetts | 09:16 | |
*** cdent has joined #openstack-nova | 09:17 | |
*** boris-42____ has quit IRC | 09:19 | |
openstackgerrit | Hangdong Zhang proposed openstack/os-vif master: Update the documentation link for doc migration https://review.openstack.org/486536 | 09:21 |
openstackgerrit | Gábor Antal proposed openstack/nova master: Add helper method for waiting migrations in functional tests https://review.openstack.org/486537 | 09:27 |
*** zsli_ has quit IRC | 09:29 | |
*** claudiub has joined #openstack-nova | 09:38 | |
*** yamamoto has quit IRC | 09:47 | |
openstackgerrit | sudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid() https://review.openstack.org/481007 | 09:48 |
*** jjung has joined #openstack-nova | 09:50 | |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform rescue/unrescue instance notifications https://review.openstack.org/385644 | 10:00 |
*** tuanluong has quit IRC | 10:02 | |
*** sdague has joined #openstack-nova | 10:02 | |
lyarwood | kashyap: done btw | 10:02 |
*** yamamoto has joined #openstack-nova | 10:02 | |
*** yamamoto has quit IRC | 10:02 | |
kashyap | lyarwood: Cool, thank you. Will look. Yes, tests are missing, but wanted to get the core change out of the way first | 10:03 |
kashyap | lyarwood: On your point about: "We can remove this now given the _get_volume_config call for each item in devices above." | 10:04 |
*** udesale__ has joined #openstack-nova | 10:04 | |
kashyap | I think we should make such changes a separate one, to make backporting easier? | 10:04 |
kashyap | Or does that fall under "related change, and therefore it's OK" | 10:05 |
lyarwood | kashyap: erm, it's the same change, you shouldn't introduce duplicate calls to the same method in these flows | 10:05 |
kashyap | lyarwood: Oeps, yes agreed. Too much switching between tasks, I'll address it | 10:06 |
lyarwood | kashyap: np | 10:06 |
kashyap | Thanks for looking! | 10:06 |
lyarwood | anytime, I really need to get on top of the stable branch review queue | 10:06 |
*** udesale has quit IRC | 10:07 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | 10:07 |
*** cdent has quit IRC | 10:08 | |
*** mdnadeem has quit IRC | 10:16 | |
*** Guest55915 has quit IRC | 10:21 | |
*** sree_ has joined #openstack-nova | 10:22 | |
*** sree_ is now known as Guest4234 | 10:22 | |
*** cdent has joined #openstack-nova | 10:23 | |
*** ratailor has quit IRC | 10:23 | |
*** Guest4234 has quit IRC | 10:26 | |
*** thorst has joined #openstack-nova | 10:29 | |
openstackgerrit | Alex Szarka proposed openstack/nova master: Transform the transformed notifications functional tests https://review.openstack.org/483448 | 10:32 |
*** yamamoto has joined #openstack-nova | 10:33 | |
*** thorst has quit IRC | 10:33 | |
*** kiennt has quit IRC | 10:33 | |
openstackgerrit | Moshe Levi proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265 | 10:41 |
*** udesale has joined #openstack-nova | 10:42 | |
*** udesale__ has quit IRC | 10:43 | |
*** chohoor has joined #openstack-nova | 10:44 | |
sdague | alex_xu: nice catch on - https://review.openstack.org/#/c/485602 I didn't realize we had a conf var for that | 10:47 |
sdague | alex_xu: would you want them merged? | 10:47 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: query instance after save to avoid partial update https://review.openstack.org/486561 | 10:48 |
*** phuongnh has quit IRC | 10:50 | |
*** lucasagomes is now known as lucas-hungry | 10:52 | |
*** smatzek has joined #openstack-nova | 10:55 | |
*** udesale has quit IRC | 10:55 | |
*** r-daneel has quit IRC | 10:55 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture https://review.openstack.org/486237 | 10:56 |
cdent | bauzas: you might be interested in that ^ | 10:57 |
*** jjung has quit IRC | 11:02 | |
*** kristian__ has joined #openstack-nova | 11:06 | |
*** Dinesh_Bhor has quit IRC | 11:07 | |
*** cdent has quit IRC | 11:08 | |
*** kristia__ has joined #openstack-nova | 11:09 | |
*** kristian__ has quit IRC | 11:09 | |
*** cdent has joined #openstack-nova | 11:16 | |
*** mamandle has quit IRC | 11:21 | |
*** acormier_ has joined #openstack-nova | 11:24 | |
*** jwcroppe has quit IRC | 11:29 | |
*** jjung has joined #openstack-nova | 11:35 | |
*** acormier_ has quit IRC | 11:39 | |
*** acormier has joined #openstack-nova | 11:39 | |
claudiub | moshele: hello. around? :) | 11:40 |
*** acormier has quit IRC | 11:41 | |
*** acormier has joined #openstack-nova | 11:42 | |
*** owalsh_ is now known as owalsh | 11:42 | |
*** jwcroppe has joined #openstack-nova | 11:43 | |
*** tbachman has joined #openstack-nova | 11:44 | |
openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.live_migration_force_complete notification https://review.openstack.org/480561 | 11:46 |
*** acormier has quit IRC | 11:46 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyperv: Cleans up live migration Planned VM https://review.openstack.org/478943 | 11:48 |
*** sree has joined #openstack-nova | 11:52 | |
*** thorst has joined #openstack-nova | 11:54 | |
*** dikonoor has joined #openstack-nova | 11:55 | |
sdague | cdent: if you want to redo OSAPIFixture to use wsgi intercept, I'd be all pro that | 11:55 |
*** thorst_ has joined #openstack-nova | 11:56 | |
*** thorst_ has quit IRC | 11:56 | |
cdent | sdague: cool, I’ll look into that when I have another window of opportunity (which is likely relatively soon) | 11:56 |
*** thorst_ has joined #openstack-nova | 11:57 | |
*** belmoreira has quit IRC | 11:58 | |
*** litao__ has quit IRC | 11:58 | |
*** thorst has quit IRC | 11:58 | |
alex_xu | sdague: i'm ok to merge that. we can add note for that conf later if people want | 11:59 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | 12:00 |
openstackgerrit | sahid proposed openstack/nova master: libvirt: fix memory locking limit https://review.openstack.org/472633 | 12:01 |
alex_xu | sdague: the patch https://review.openstack.org/#/c/486414/ removed stevedore loading from the nova api. after that patch merged, we finish the goal of pike. The later cleanup can be done later, since we still have some garbage in the unittest. | 12:02 |
*** lucas-hungry is now known as lucasagomes | 12:03 | |
alex_xu | sdague: oh, I missed understand your words. I think you mean the merge of log_format in the new middelware and config var. I think that sounds good. | 12:07 |
alex_xu | sdague: the only strange thing is 'microversion' won't work with eventlet. If the config val includes $(microversion)s, it will generate a KeyError I guess? | 12:09 |
sdague | alex_xu: yeh, that's going to be the issue | 12:12 |
sdague | maybe wait for mriedem to get up and figure out what approach he wants | 12:13 |
*** lyan has joined #openstack-nova | 12:13 | |
moshele | claudiub: hi | 12:14 |
*** gszasz has joined #openstack-nova | 12:15 | |
*** cdent has quit IRC | 12:18 | |
*** khappone has quit IRC | 12:19 | |
*** yamamoto has quit IRC | 12:19 | |
*** khappone has joined #openstack-nova | 12:20 | |
openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | 12:22 |
*** mamandle has joined #openstack-nova | 12:23 | |
*** baoli has joined #openstack-nova | 12:24 | |
*** jjung has quit IRC | 12:24 | |
*** ekuris has quit IRC | 12:26 | |
*** cdent has joined #openstack-nova | 12:27 | |
*** jjung has joined #openstack-nova | 12:29 | |
*** pchavva has joined #openstack-nova | 12:31 | |
*** baoli has quit IRC | 12:34 | |
*** baoli has joined #openstack-nova | 12:34 | |
*** cleong has joined #openstack-nova | 12:35 | |
*** yamamoto has joined #openstack-nova | 12:36 | |
*** yamamoto has quit IRC | 12:36 | |
claudiub | moshele: so, i have a few other issues with sr-iov, if you have some time. :) | 12:36 |
moshele | claudiub: I am in a meeting, but I can try to help | 12:37 |
*** jwcroppe has quit IRC | 12:37 | |
*** ratailor has joined #openstack-nova | 12:37 | |
claudiub | moshele: so, I see that the vendor_id, and product_id are mandatory, but the issue i'm having is that I cannot extract those from *all* the sr-iov capable nics. | 12:37 |
claudiub | moshele: for example, for Intel NICs, it's straight-forward and easy to do, as they are included in the DeviceID, but not for the Mellanox or Chelsio NICs | 12:38 |
claudiub | moshele: so, I was wondering - wouldn't reporting the device_id sufficient? | 12:38 |
claudiub | *be sufficient | 12:39 |
moshele | claudiub: I am not sure is mandatory, can you point me to the place in the code. as I remember it can be use in the pci whitelist | 12:39 |
claudiub | sure, just a second. | 12:40 |
*** ekuris has joined #openstack-nova | 12:41 | |
claudiub | moshele: currently, if i'm not reporting any vendor_id or product_id, it fails here: https://github.com/openstack/nova/blob/master/nova/pci/devspec.py#L277 | 12:41 |
moshele | claudiub: this for the pci whitelist, you can use also pci address/ pf name instead | 12:42 |
*** catintheroof has joined #openstack-nova | 12:42 | |
moshele | claudiub: did you try to whitelist with pci address? | 12:43 |
jangutter | claudiub: where do you need to extract the SR-IOV capable PCI nics, is this for capabilities? | 12:43 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s) https://review.openstack.org/485752 | 12:43 |
jangutter | claudiub: I was confused with device_id for a bit, until I realised it's a synonym for product_id. | 12:44 |
claudiub | jangutter: nope, product_id, vendor_id, and device_id are distinct | 12:44 |
claudiub | you can have multiple devices with the same product_id, vendor_id, but not with the same device_id | 12:45 |
jangutter | claudiub: whoops, you're right! I forgot about that! | 12:45 |
claudiub | for example, 2 identical devices will have the same product_id and vendor_id, but different device_ids | 12:45 |
jangutter | claudiub: Is there something in lspci that indicates SR-IOV capability? | 12:46 |
claudiub | jangutter: i'm on windows / hyper-v. :) | 12:46 |
claudiub | jangutter: but yeah. | 12:46 |
jangutter | claudiub: you poor soul. | 12:47 |
jangutter | claudiub: "Capabilities: [200 v1] Single Root I/O Virtualization (SR-IOV)" | 12:48 |
claudiub | moshele: hm, I should be able to whitelist it using "devname" too, right? | 12:52 |
moshele | claudiub: yes | 12:52 |
claudiub | hm, let's see. | 12:52 |
claudiub | jangutter: hah. :)) | 12:53 |
claudiub | jangutter: what is that "Capabilities: [200 v1] Single Root I/O Virtualization (SR-IOV)" about? | 12:54 |
*** ralonsoh_ is now known as ralonsoh | 12:54 | |
*** trinaths has quit IRC | 12:57 | |
ralonsoh | claudiub: can I ask you what capabilities do you need? rso, tso, txvlan, etc? | 12:57 |
*** mriedem has joined #openstack-nova | 12:59 | |
*** edmondsw has joined #openstack-nova | 12:59 | |
jangutter | claudiub: sorry, that's what I see with lspci. | 13:00 |
*** mgiles has joined #openstack-nova | 13:02 | |
*** vladikr has joined #openstack-nova | 13:02 | |
claudiub | jangutter: ah, i see. | 13:03 |
*** kylek3h has joined #openstack-nova | 13:03 | |
jangutter | claudiub: is there perhaps something like that in the Windows Device Manager registry? | 13:03 |
*** jaypipes has joined #openstack-nova | 13:04 | |
claudiub | jangutter: you mean for sr-iov? it can easily be checked through this: Get-VMHost (check if the host supports SR-IOV), and Get-NetAdapterSriov (check if the NICs support SR-IOV) | 13:05 |
claudiub | i'm good in both cases. :) | 13:05 |
claudiub | ralonsoh: any / all. :) currently looking into hyper-v sr-iov. will have to see what capabilities are available. | 13:06 |
*** esberglu has joined #openstack-nova | 13:07 | |
ralonsoh | claudiub: hmmm, sorry, I didn't read that part (hyper-v). I'll take a look | 13:07 |
*** r-daneel has joined #openstack-nova | 13:09 | |
*** lucasxu has joined #openstack-nova | 13:11 | |
*** ratailor has quit IRC | 13:11 | |
*** eharney has joined #openstack-nova | 13:11 | |
*** r-daneel has quit IRC | 13:13 | |
sdague | mriedem: when you get a chance this morning, I'd like to figure out what's needed to merge this - https://review.openstack.org/#/c/485602/ - I think the outstanding question is around using the existing config definition | 13:15 |
sdague | though that might be a reasonable follow on patch to pull that in for both nova-api and placement | 13:15 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 13:17 |
*** takashin has left #openstack-nova | 13:17 | |
openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform rescue/unrescue instance notifications https://review.openstack.org/385644 | 13:17 |
*** jamesdenton has joined #openstack-nova | 13:18 | |
*** links has quit IRC | 13:20 | |
*** mgiles has quit IRC | 13:22 | |
mriedem | sdague: so the question is if you're using eventlet, wsgi_log_format config is how you tailor the log format however you want, but with this it's hard-coded so you lose the ability | 13:23 |
*** mgiles has joined #openstack-nova | 13:23 | |
sdague | mriedem: yes | 13:23 |
sdague | I guess we should determine if that is valuable as config or not | 13:24 |
sdague | placement goes the hard coded route here as well | 13:24 |
*** prateek has quit IRC | 13:24 | |
sdague | so this is consistent with placement | 13:24 |
mriedem | %(request_line)s must come from eventlet? | 13:24 |
mriedem | and we're hard-coding: %(REQUEST_METHOD)s %(REQUEST_URI)s | 13:24 |
*** jamesdenton has quit IRC | 13:25 | |
mriedem | this is the eventlet wsgi default | 13:25 |
mriedem | log_format='%(client_ip)s - - [%(date_time)s] "%(request_line)s" %(status_code)s %(body_length)s %(wall_seconds).6f' | 13:25 |
*** jamesdenton has joined #openstack-nova | 13:25 | |
mriedem | seems odd that we define a default for our config option that's different from the eventlet wsgi default | 13:26 |
sdague | mriedem: https://github.com/openstack/oslo.service/blob/5a8a712c26cb053cbabf49044e6831ed98a2c2d5/oslo_service/wsgi.py#L184 | 13:26 |
sdague | mriedem: yeh, well, it's all leaky abstraction | 13:26 |
sdague | those are eventlet native stanzas | 13:27 |
mriedem | nova uses it here https://github.com/openstack/nova/blob/master/nova/wsgi.py#L184 | 13:27 |
*** zz9pzza has quit IRC | 13:29 | |
*** efried_zzz is now known as efried | 13:29 | |
sdague | mriedem: ah, I guess we're duping more of oslo.service than I realized, I thought that had been fully factored back out | 13:30 |
sdague | but, regardless, the current keying are eventlet server keywords | 13:30 |
mriedem | right, what i'm thinking is if we used the config, | 13:31 |
mriedem | it would be nice to have it default to None so we could tell if the operator actually cares about overriding it, | 13:31 |
mriedem | if it's None, and you're using eventlet wsgi, then you get eventlet wsgi defaults for the log format | 13:31 |
bauzas | mdbooth: do you remember some problems with volume migrations for their type ? https://bugs.launchpad.net/nova/+bug/1705700 | 13:31 |
sdague | mriedem: yeh, very much good point | 13:31 |
openstack | Launchpad bug 1705700 in OpenStack Compute (nova) "live migration does not work after volume migration" [Undecided,New] | 13:31 |
mriedem | if it's None and you're using apache, then you get our hard-coded line | 13:31 |
sdague | mriedem: we'd also have to normalize the keywords, because things like microversion aren't going to exist where eventlet does this | 13:32 |
mriedem | right, i'd munge that in with request_line | 13:32 |
bauzas | mdbooth: tl;dr cinder block volumes seem to be transformed as files | 13:32 |
mdbooth | bauzas: Looking | 13:32 |
sdague | https://github.com/eventlet/eventlet/blob/ce72c4378b176cdb0d8b6039023e3ad0026becde/eventlet/wsgi.py#L603-L611 - is where eventlet does it's thing | 13:33 |
mdbooth | bauzas: That does ring a bell, actually | 13:33 |
mriedem | sdague: fyi it's also a default value in oslo.service https://github.com/openstack/oslo.service/blob/master/oslo_service/_options.py#L59 | 13:33 |
sdague | mriedem: yep | 13:33 |
mdbooth | kashyap: You've fixed ^^^ recently, haven't you? | 13:33 |
bauzas | mdbooth: yup, I remember some discussion we had for that | 13:33 |
* kashyap reads the scroll | 13:33 | |
bauzas | kashyap: https://bugs.launchpad.net/nova/+bug/1705700 | 13:33 |
openstack | Launchpad bug 1705700 in OpenStack Compute (nova) "live migration does not work after volume migration" [Undecided,New] | 13:33 |
sdague | mriedem: so, honestly, my inclination is to just say this isn't customizable any more, and only bring that back if people really complain about it | 13:34 |
kashyap | mdbooth: It's the cache value being not set on the Cinder volume post-migration? | 13:34 |
mriedem | seems we could deprecate the nova specific wsgi_log_format, although if we want to default it to None we'd then end up relying on the config from oslo.service, which gets messy | 13:34 |
sdague | because the value in making that site specific seems really weird | 13:34 |
mdbooth | kashyap: No, different bug | 13:34 |
kashyap | If so -- https://review.openstack.org/#/c/485752/ -- libvirt: Post-migration, set cache value for Cinder volume(s) | 13:34 |
openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.resize_revert notification https://review.openstack.org/396811 | 13:34 |
kashyap | mdbooth: Oh, is it the one bauzas pointed out just now? | 13:34 |
mdbooth | kashyap: Yes | 13:34 |
* kashyap reads | 13:34 | |
sdague | mriedem: because it feels like you could do a lot of effort here for 0 people ever doing this thing | 13:35 |
kashyap | mdbooth: Oh, this one -- I recall it | 13:35 |
mdbooth | https://bugs.launchpad.net/nova/+bug/1705700 | 13:35 |
openstack | Launchpad bug 1705700 in OpenStack Compute (nova) "live migration does not work after volume migration" [Undecided,New] | 13:35 |
mriedem | sdague: yeah i'm asking in the operators channel, but i don't care to bend over backwards for the config option | 13:35 |
bauzas | mdbooth: looked related but not the same problem | 13:35 |
bauzas | oops kashyap rather | 13:35 |
kashyap | mdbooth: Not me (Artom), but I did the triage of it with Eric Blake. The change was simple | 13:36 |
mdbooth | bauzas: Yeah, I've definitely seen a patch for the file='block device' thing | 13:36 |
bauzas | claudiub: I'm unclear whether https://bugs.launchpad.net/nova/+bug/1705683 is only for hyper-v driver | 13:36 |
openstack | Launchpad bug 1705683 in compute-hyperv "vif ports are not unplugged after cold migration" [Undecided,In progress] - Assigned to Alexandru Muresan (amuresan) | 13:36 |
mriedem | sdague: https://github.com/openstack/nova/commit/c01c852c808970ff649c26a0e52d34b3c2d80b0b | 13:36 |
*** yamamoto has joined #openstack-nova | 13:36 | |
kashyap | We need both the flags: VIR_DOMAIN_BLOCK_REBASE_COPY _and_ VIR_DOMAIN_BLOCK_REBASE_COPY_DEV | 13:36 |
mriedem | sdague: sounds like that was a bug fix at one point or a workaround for a limitation in eventlet | 13:37 |
mriedem | sdague: and then oslo.service copied it from nova | 13:37 |
mriedem | https://github.com/openstack/oslo.service/commit/6dd3ad50b6fee79b4cc08fe0830327803d4b2f5b | 13:37 |
bauzas | mdbooth: if you can find it, you'll get eternal gratitudes | 13:37 |
mdbooth | bauzas: I'll have a hunt in a bit. Just doing some fun, fun, fun bugzilla diving. | 13:38 |
bauzas | mdbooth: but I can lookup gerrit for libvirt/volume.py recent changes | 13:38 |
mriedem | sdague: so i'd say we keep them separate and actually deprecate the nova wsgi_log_format option since it's in oslo.service, and doesn't even really seem useful anymore | 13:38 |
bauzas | mdbooth: nah, I can try to find so | 13:38 |
kashyap | mdbooth: Whoops, I think I see the cause: "The issue is caused by the fact that dist type is changed from 'block' to 'file' after volume migration." | 13:39 |
bauzas | mdbooth: you'll just miss unlimited beer credits | 13:39 |
kashyap | It should _retain_ 'block' as the disk type post-migration, too. | 13:39 |
sdague | mriedem: ah, right, because we're going through the python logger the default logger in eventlet is also putting in timestamping | 13:39 |
bauzas | kashyap: that is the root cause as per the reporter indeed | 13:39 |
* mdbooth modifies the xslt he wrote to process bugzilla query output, and weeps :( | 13:39 | |
sdague | mriedem: ok, same patch for deprecation, or follow on? | 13:40 |
bauzas | kashyap: I lean to mark the bug as confirmed, but finding a duplicate or even a bugfix would be awesomeness | 13:40 |
mriedem | follow on | 13:40 |
*** kristia__ has quit IRC | 13:40 | |
*** Dinesh_Bhor has joined #openstack-nova | 13:40 | |
sdague | mriedem: then you want to hit the +A on the current one? | 13:40 |
kashyap | bauzas: Yeah, have to look for the dupliate. First, trying to wrap my head around another unit test fix. Want to get this out before I'm out for 2-ish weeks starting 01 Aug | 13:40 |
sdague | it has to +2s, but was waiting for you to come back around | 13:40 |
*** gouthamr has joined #openstack-nova | 13:40 | |
mriedem | sdague: i'm goign to push a devstack change that makes nova-api run under eventlet again and depends-on this change to make sure the eventlet stuff is as expected | 13:41 |
*** kristian__ has joined #openstack-nova | 13:41 | |
bauzas | kashyap: np, will try to wake up my gerrit search skills | 13:41 |
kashyap | bauzas: I don't think there's a duplicate. I'm looking at this change for the first time | 13:41 |
kashyap | s/change/bug/ | 13:41 |
sdague | mriedem: sure, though the unit tests mostly cover that as well | 13:41 |
kashyap | bauzas: And the above bug you point to seems caused by this (merged) change: https://review.openstack.org/#/c/465205/ | 13:41 |
gibi | mriedem: hi! I made some progress on the missing update on the updated_at field. However fix I'm currently proposing might not what we want at the end https://review.openstack.org/#/c/486561/ | 13:41 |
bauzas | kashyap: was just digging in https://review.openstack.org/#/q/project:openstack/nova+file:%255Enova/virt/libvirt/volume.py | 13:42 |
gibi | mriedem: I will try to dig deeper in oslo.db as time allows | 13:42 |
bauzas | kashyap: ok, I'll set the bug as confirmed | 13:43 |
mriedem | gibi: ok | 13:43 |
*** yamamoto has quit IRC | 13:44 | |
*** xyang1 has joined #openstack-nova | 13:44 | |
bauzas | mriedem: would it be reasonable to target bug reports as pike-rc-potential if anyone didn't provided a fix yet (ie. not in Progress) ? | 13:44 |
bauzas | mriedem: having in-progress bugs in the bucket is cool for reviews, but I'd also like to make sure we're like telling to the world that the release is worth getting those unassigned bugs fixed so someone could step up ? | 13:45 |
mriedem | bauzas: yes | 13:46 |
bauzas | mriedem: tbc, I'm worried of any bad press of https://bugs.launchpad.net/nova/+bug/1705700 if not fixed by Ocata timeframe | 13:46 |
openstack | Launchpad bug 1705700 in OpenStack Compute (nova) "live migration does not work after volume migration" [High,Confirmed] | 13:46 |
claudiub | bauzas: we've only observed that bug on hyper-v. libvirt seems to unplug the vifs on confirm_migration. | 13:47 |
mriedem | bauzas: is it latent or a regression in pike? | 13:48 |
bauzas | mriedem: it's Ocata | 13:48 |
mriedem | so a regression introduced in ocata | 13:48 |
bauzas | mriedem: but looks like https://review.openstack.org/#/c/465205/ was backported to Ocata | 13:48 |
bauzas | mriedem: I can try to investigate further | 13:49 |
bauzas | at least the bugfix above was backported in a point release | 13:49 |
bauzas | we can ask to test some compute with some older release | 13:49 |
openstackgerrit | sahid proposed openstack/nova-specs master: virt: provide a mask to selection pCPUs to run emu. threads https://review.openstack.org/486617 | 13:50 |
edleafe | Scheduler subteam meeting in 10 minutes in #openstack-meeting-alt | 13:50 |
*** eharney has quit IRC | 13:50 | |
*** randomhack has joined #openstack-nova | 13:51 | |
*** chyka has joined #openstack-nova | 13:51 | |
openstackgerrit | Jianghua Wang proposed openstack/nova-specs master: Support virtual GPU resources https://review.openstack.org/450122 | 13:51 |
*** mamandle has quit IRC | 13:52 | |
*** MVenesio has joined #openstack-nova | 13:53 | |
*** jwcroppe has joined #openstack-nova | 13:54 | |
*** eharney has joined #openstack-nova | 13:55 | |
*** randomha1k has joined #openstack-nova | 13:56 | |
*** crushil has joined #openstack-nova | 13:56 | |
*** chyka has quit IRC | 13:57 | |
*** randomhack has quit IRC | 13:57 | |
*** awaugama has joined #openstack-nova | 13:58 | |
*** tylerderosagrund has joined #openstack-nova | 13:58 | |
*** mamandle has joined #openstack-nova | 13:58 | |
edleafe | Scheduler subteam meeting running now in #openstack-meeting-alt | 14:01 |
openstackgerrit | Sean Dague proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable https://review.openstack.org/486623 | 14:01 |
*** zz9pzza has joined #openstack-nova | 14:03 | |
*** efoley has joined #openstack-nova | 14:04 | |
*** alexchadin has quit IRC | 14:06 | |
*** crushil has quit IRC | 14:06 | |
artom | kashyap, mdbooth, you mean | 14:08 |
artom | Err | 14:09 |
artom | kashyap, mdbooth, you mean https://review.openstack.org/#/c/471356/ ? | 14:09 |
openstackgerrit | Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566 | 14:09 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s) https://review.openstack.org/485752 | 14:09 |
artom | This is the yet unmerged newton backport, the other ones have merged | 14:09 |
mdbooth | bauzas: artom gets all your beer :) | 14:09 |
* kashyap clicks at artom's link | 14:10 | |
*** tylerderosagrund has quit IRC | 14:10 | |
kashyap | artom: Ah, nice one. Yep, that's it | 14:10 |
*** ekuris has quit IRC | 14:10 | |
bauzas | mdbooth: FWIW I just marked the bug we discussed as incomplete since I'd like the reporter to test the last ocata point release | 14:11 |
bauzas | as it includes artom's patch | 14:11 |
mdbooth | +1 | 14:11 |
*** crushil has joined #openstack-nova | 14:12 | |
*** crushil has quit IRC | 14:13 | |
*** crushil has joined #openstack-nova | 14:13 | |
bauzas | dansmith: mmm, we have lots of docs mentioning it's worth doing SIGHUPs for upgrades or mutable config but I don't see how nova-compute service is hooking up this signal :) | 14:14 |
bauzas | dansmith: since it's not inheriting from oslo.service AFAICT | 14:14 |
bauzas | and we don't have any signal handling in that code | 14:15 |
dansmith | bauzas: oh, this reminds me, someone recently asked me about a doc they found that says they could change the log level at runtime | 14:15 |
dansmith | by SIGHUP | 14:15 |
dansmith | it clearly was not working and I told them I expected that was oslo documentation, but never circled back | 14:16 |
bauzas | dansmith: https://bugs.launchpad.net/nova/+bug/1705680 led me investigating and honesly I don't see how the magic can happen | 14:17 |
openstack | Launchpad bug 1705680 in OpenStack Compute (nova) "nova compute does nothing on receiving sighup signal" [Undecided,New] | 14:17 |
bauzas | if we were inheriting from oslo.service manager, then OK | 14:17 |
bauzas | but we're not | 14:17 |
dansmith | we do process sighup for rpc version pins | 14:17 |
dansmith | bauzas: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L539 | 14:18 |
bauzas | dansmith: I saw the hook | 14:18 |
bauzas | dansmith: but I don't see how we define that hook to be called on a sighup signal | 14:18 |
dansmith | I think we do get it from oslo.service | 14:19 |
dansmith | but it's buried pretty deep | 14:19 |
bauzas | dansmith: that was my assumption | 14:19 |
bauzas | but | 14:19 |
bauzas | we don't inherit from it | 14:19 |
dansmith | we do | 14:19 |
dansmith | bauzas: https://github.com/openstack/nova/blob/master/nova/service.py#L98-L98 | 14:19 |
dansmith | bauzas: service is oslo.service there | 14:19 |
dansmith | L27 | 14:20 |
bauzas | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L482 | 14:20 |
bauzas | manager is nova.manager, right? | 14:20 |
dansmith | yes, but the service hooks Service.reset() to Manager.reset() | 14:20 |
dansmith | https://github.com/openstack/nova/blob/master/nova/service.py#L289-L289 | 14:20 |
*** annegentle has joined #openstack-nova | 14:20 | |
bauzas | but https://github.com/openstack/nova/blob/master/nova/manager.py#L91 | 14:21 |
mriedem | dansmith: the mutable config stuff is in oslo.config docs | 14:21 |
bauzas | dansmith: ooooh, it's fucking cryptic | 14:21 |
mriedem | https://docs.openstack.org/oslo.config/latest/reference/mutable.html | 14:21 |
dansmith | bauzas: not really, managers and services have always had this relationship | 14:21 |
bauzas | I see | 14:21 |
dansmith | mriedem: oh right and I think we're writing into our default nova config that log level is mutable or something | 14:21 |
dansmith | because of that | 14:22 |
mriedem | i thought it was only 'debug' | 14:22 |
*** acormier has joined #openstack-nova | 14:22 | |
mriedem | https://review.openstack.org/#/c/280851 | 14:23 |
mriedem | https://review.openstack.org/#/c/254821/ | 14:23 |
bauzas | mriedem: I was just looking at the mutable-config series | 14:23 |
dansmith | mriedem: okay I never saw this, but it completely wasn't working | 14:23 |
mriedem | so default_log_levels config wouldn't use that | 14:23 |
dansmith | I think it was debug= they were toggling, but maybe not | 14:24 |
mriedem | we only have 4 | 14:24 |
mriedem | https://docs.openstack.org/nova/latest/sample_config.html | 14:24 |
mriedem | if you search for "Note: This option can be changed without restarting." | 14:24 |
dansmith | wonder if we're supposed to be hooking our sighup handler to oslo.log somehow? | 14:25 |
bauzas | mriedem: correct, the mutable-config series was mostly still in progress when lxsli left | 14:25 |
dansmith | unless it registers its own signal handler quietly | 14:25 |
*** sree has quit IRC | 14:26 | |
bauzas | the point with https://bugs.launchpad.net/nova/+bug/1705680 is that I suspect the sighup to be caught but just the fact that we only reload a very few flags made the reporter thinking it wasn't working | 14:26 |
openstack | Launchpad bug 1705680 in OpenStack Compute (nova) "nova compute does nothing on receiving sighup signal" [Undecided,New] | 14:26 |
bauzas | either way, I can call out for details | 14:26 |
*** yamahata has joined #openstack-nova | 14:28 | |
*** felipemonteiro has joined #openstack-nova | 14:30 | |
*** baoli has quit IRC | 14:31 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | 14:31 |
*** felipemonteiro_ has joined #openstack-nova | 14:31 | |
*** crushil has quit IRC | 14:31 | |
*** crushil has joined #openstack-nova | 14:32 | |
*** mgiles has quit IRC | 14:34 | |
*** mgiles has joined #openstack-nova | 14:34 | |
*** felipemonteiro has quit IRC | 14:34 | |
*** yufei has joined #openstack-nova | 14:36 | |
*** yufei has quit IRC | 14:36 | |
*** yufei has joined #openstack-nova | 14:36 | |
*** mtanino has joined #openstack-nova | 14:38 | |
*** kristian__ has quit IRC | 14:39 | |
*** kristian__ has joined #openstack-nova | 14:39 | |
*** marst has quit IRC | 14:39 | |
*** kristian__ has quit IRC | 14:43 | |
*** coreywright has quit IRC | 14:44 | |
*** marst has joined #openstack-nova | 14:47 | |
*** chyka has joined #openstack-nova | 14:50 | |
*** jamesdenton has quit IRC | 14:51 | |
*** jamesdenton has joined #openstack-nova | 14:52 | |
*** baoli has joined #openstack-nova | 14:52 | |
*** sree has joined #openstack-nova | 14:53 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Adopt new pypowervm power_off APIs https://review.openstack.org/476945 | 14:55 |
openstackgerrit | Sean Dague proposed openstack/nova master: Increase cpu time for image conversion https://review.openstack.org/486642 | 14:56 |
*** s-dean has joined #openstack-nova | 14:56 | |
*** coreywright has joined #openstack-nova | 14:57 | |
*** cdent has quit IRC | 14:59 | |
*** jamesdenton has quit IRC | 14:59 | |
s-dean | can somebody please confirm that the cells table in nova db is meant to be empty, I have been trying to setup the cells database and every time i run su -s /bin/sh -c "nova-manage db sync" nova , I get the following output ERROR: could not access cell mapping database - has api db been created?, I have been at this for 5 days and same error everytime i reinstall | 14:59 |
jangutter | sean-k-mooney: are you inline? | 14:59 |
jangutter | s/inline/online/? | 14:59 |
*** baoli has quit IRC | 14:59 | |
*** zz9pzza has quit IRC | 15:00 | |
*** zz9pzza has joined #openstack-nova | 15:00 | |
*** annegentle has quit IRC | 15:00 | |
*** kristian__ has joined #openstack-nova | 15:01 | |
*** sree has quit IRC | 15:01 | |
*** kristian__ has quit IRC | 15:02 | |
*** kristian__ has joined #openstack-nova | 15:02 | |
*** kristian__ has quit IRC | 15:02 | |
*** sree has joined #openstack-nova | 15:02 | |
sean-k-mooney | yes though i have to drop for meeting in an hour | 15:02 |
*** kristian__ has joined #openstack-nova | 15:02 | |
*** jamesdenton has joined #openstack-nova | 15:02 | |
sean-k-mooney | jangutter: ^ | 15:03 |
*** lucasxu has quit IRC | 15:03 | |
jangutter | sean-k-mooney: I split off https://review.openstack.org/#/c/486426/ but I'm not sure I wrote the test right. | 15:03 |
*** MVenesio has quit IRC | 15:04 | |
*** MVenesio has joined #openstack-nova | 15:04 | |
sean-k-mooney | jangutter: well that is partly a technically question and partly a political one. you added _set_config_VIFHostDevice | 15:05 |
*** sree has quit IRC | 15:06 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from 'ip' commands to pyroute2 https://review.openstack.org/484386 | 15:06 |
*** markus_z has quit IRC | 15:07 | |
*** kristian__ has quit IRC | 15:07 | |
*** kristian__ has joined #openstack-nova | 15:07 | |
*** crushil has quit IRC | 15:07 | |
mriedem | s-dean: yes the cells table is for cells v1 only | 15:08 |
*** crushil has joined #openstack-nova | 15:08 | |
jangutter | sean-k-mooney: yep, and used "unplugin" rather than "plugin" -> other VIF tests that don't go out via an os-vif plugin seem to use that, rather than "plugin" | 15:08 |
sean-k-mooney | jangutter: technically in test_vif.py you should only assert that the designer was called. and then in https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_designer.py you should assert that correct xml is generated when you pass in the os_vif_hostdevice | 15:08 |
mriedem | s-dean: you have a nova_api db yes? | 15:08 |
*** yufei has quit IRC | 15:08 | |
mriedem | s-dean: did you run nova-manage api_db sync ? | 15:08 |
mriedem | s-dean: also https://docs.openstack.org/nova/latest/cells.html and https://docs.openstack.org/ocata/install-guide-ubuntu/nova.html for docs | 15:09 |
sean-k-mooney | jangutter: but politcally nova has not done it this way else where in the file so you should follow the files convention of have test_vif.py also test desighern fuctionality though really this should be change across the board in that file in a seperate patch | 15:09 |
jangutter | sean-k-mooney: ah, that makes it a lot finer-grained. | 15:09 |
*** mamandle has quit IRC | 15:10 | |
*** baoli has joined #openstack-nova | 15:10 | |
sean-k-mooney | jangutter: yes unfutrnetlly that is not how the other unitest have been written so it better to follow the convention in the file though we should proably file a bug to make it more granular | 15:10 |
sean-k-mooney | jangutter: i think the current patch is fine given the convention that is inplace | 15:11 |
mriedem | s-dean: it could also mean that the nova.conf that you're running nova-manag db sync against doesn't have the [api_database]connection option set? | 15:11 |
s-dean | yes I have nova_api database, I have run the commands in order as specified in the documentation, However ERROR: could not access cell mapping database - has api db been created? | 15:12 |
s-dean | keeps appearing | 15:12 |
mriedem | s-dean: the command is looking for entries in the cell_mappings table in the nova_api db | 15:12 |
*** cfriesen has joined #openstack-nova | 15:12 | |
s-dean | they exist | 15:12 |
jangutter | sean-k-mooney: thanks, I and that clears up the other questions I also had. I had wondered why there seemed to be two sets of tests in test_vif.py | 15:13 |
mriedem | or whatever you called it, but it would be defined by the [api_database]connection url in nova.conf | 15:13 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 15:13 |
mriedem | s-dean: how do the cell_mappings entries exist if you don't have a nova_api db? | 15:13 |
mriedem | oh you said you have it | 15:13 |
stvnoyes | mriedem good morning Matt, when you get some time, please take a look at the updated cinder v3 migrate review. thanks. - https://review.openstack.org/#/c/463987/ | 15:13 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 15:13 |
*** rmart04 has quit IRC | 15:13 | |
mriedem | s-dean: is [api_database]connection set in nova.conf when running nova-manage db sync? | 15:13 |
s-dean | I have created it, Is this a potential bug | 15:13 |
*** dklyle is now known as david-lyle | 15:14 | |
*** dikonoor has quit IRC | 15:14 | |
s-dean | yes my connection string is correct | 15:14 |
mriedem | s-dean: just to be clear, so you have both [database]/connection and [api_database]/connection set in nova.conf? | 15:14 |
mriedem | and they are different values, yes? | 15:14 |
s-dean | yes | 15:14 |
s-dean | yes | 15:14 |
s-dean | one for nova_api | 15:15 |
mriedem | ok, and you ran nova-manage api_db sync ? | 15:15 |
s-dean | and on for nova db | 15:15 |
s-dean | yes | 15:15 |
sean-k-mooney | jangutter: i think its a legacy thing. but generally when writhing unit test you should mock any fuction call to other modules in the current project and test only how the output of the fuction is used and test the internals of that fuction in a seperate test in that modules test file | 15:15 |
mriedem | did you run nova-manage cell_v2 map_cell0 | 15:15 |
openstackgerrit | Gábor Antal proposed openstack/nova master: Transform HostAPI-set_enabled notifications https://review.openstack.org/482622 | 15:16 |
sean-k-mooney | jangutter: but in all cases the convention of the file you are extending take presedence over teh convetions of the project as a whole though one would hope they more or less agree | 15:16 |
mriedem | stephenfin: fyi, docs theme is jacked here https://docs.openstack.org/nova/latest/cells.html | 15:16 |
s-dean | I have run Step 3,4,5,6 at step 6 following error | 15:17 |
s-dean | ERROR: could not access cell mapping database - has api db been created? | 15:17 |
jangutter | sean-k-mooney: yep. No joke "writhing unit test" is pretty accurate. | 15:17 |
mriedem | s-dean: steps in which doc? the install guide? | 15:17 |
s-dean | ubuntu 16.04 | 15:17 |
s-dean | ocata install guide | 15:18 |
mriedem | s-dean: so you have a nova_cell0 database as well? | 15:18 |
mriedem | there are 3 dbs involved | 15:18 |
s-dean | yeah | 15:18 |
mriedem | ok | 15:18 |
s-dean | nova_api | 15:18 |
s-dean | nova | 15:18 |
*** Oku_OS is now known as Oku_OS-away | 15:18 | |
s-dean | _cell0 | 15:18 |
s-dean | nova_cell0 | 15:19 |
mriedem | ok and the cell_mappings.database_connection url for the cell_0 entry in the nova_api database is correct? | 15:19 |
s-dean | all exist | 15:19 |
knikolla | o/ is the rbd information for the ephemeral disks only in the nova,ceph.conf files? We've changed monitor IPs but old VMs still have the old information with old IPs. | 15:19 |
*** annegentle has joined #openstack-nova | 15:20 | |
s-dean | i shall check | 15:20 |
*** Apoorva has joined #openstack-nova | 15:21 | |
s-dean | transport url for cell1 exists, cell0 has the following none:/// | 15:21 |
mriedem | for the database_connection/ | 15:21 |
mriedem | ? | 15:21 |
s-dean | no | 15:21 |
s-dean | database connection on both cell0 and cell1 are the same | 15:21 |
mriedem | except one should point at cell0 and one should point at cell1 | 15:22 |
mriedem | well, the cell0 mapping should point at the nova_cell0 db, | 15:22 |
*** kashyap has quit IRC | 15:22 | |
mriedem | and the cell1 mapping should point at the nova db | 15:22 |
s-dean | mysql+pymysql://nova:mypassword@my_ip/nova?charset=utf8&ssl_ca=/etc/nova/tls/mysql/ca-cert.pem&ssl_cert=/etc/nova/tls/mysql/server-cert.pem&ssl_key=/etc/nova/tls/mysql/server-key.pemnova_cell0 | 15:23 |
s-dean | is this the issue > nova_cell0 | 15:23 |
s-dean | is this the issue > server-key.pemnova_cell | 15:23 |
sdague | mriedem / dansmith - is there a new timing issue where GET right after POST is going to 404 - https://bugs.launchpad.net/nova/+bug/1682423 ? | 15:23 |
openstack | Launchpad bug 1682423 in OpenStack Compute (nova) "create instance with dashbaord / 404 returned" [Undecided,New] | 15:23 |
mriedem | s-dean: i think the issue is that's pointing at the nova db | 15:24 |
mriedem | nova? | 15:24 |
mriedem | i think that should be nova_cell0? | 15:25 |
s-dean | why is it on the end of the connection string ? | 15:25 |
dansmith | sdague: in ocata? | 15:25 |
mriedem | s-dean: my guess is a string substitution bug in map_cell0 | 15:25 |
mriedem | s-dean: do you have the latest stable/ocata code? or 15.0.0? | 15:25 |
s-dean | from the cloud archive | 15:25 |
sdague | dansmith: yeh, I was wondering if the cells v2 transition opens up a window there | 15:25 |
dansmith | sdague: it's not supposed to, no | 15:26 |
dansmith | if it was master just now I'd suspect some quota thing | 15:26 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_console_auth_tokens.py https://review.openstack.org/477374 | 15:26 |
*** yufei has joined #openstack-nova | 15:26 | |
mriedem | s-dean: what's the version of nova? | 15:27 |
s-dean | to seconds | 15:27 |
s-dean | two | 15:27 |
*** sridharg has quit IRC | 15:27 | |
*** kristia__ has joined #openstack-nova | 15:27 | |
s-dean | nova-api | 2:13.0.0-0ubuntu2 | 15:27 |
mriedem | s-dean: whoa that's mitaka | 15:27 |
mriedem | ocata is 15.0.0 | 15:27 |
s-dean | wait | 15:28 |
s-dean | sorry | 15:28 |
s-dean | nova-api | 2:15.0.5-0ubuntu1~cloud0 | 15:28 |
*** kristian__ has quit IRC | 15:28 | |
mriedem | ok that's better | 15:28 |
*** _pewp_ has joined #openstack-nova | 15:28 | |
mriedem | s-dean: did you run map_cell0 with 15.0.5 or earlier? | 15:29 |
mriedem | because https://docs.openstack.org/releasenotes/nova/ocata.html | 15:29 |
s-dean | fresh install | 15:29 |
mriedem | https://launchpad.net/bugs/1673613 | 15:29 |
openstack | Launchpad bug 1673613 in OpenStack Compute (nova) ocata "Special characters are not allowed in connection string" [High,Fix committed] - Assigned to Matt Riedemann (mriedem) | 15:29 |
mriedem | if your an map_cell0 at 15.0.5 then my guess is the ssl stuff in the url got messed up and put nova_cell0 at the end of the URL | 15:30 |
mriedem | *if you ran | 15:30 |
s-dean | ok | 15:30 |
s-dean | that makes more sense | 15:30 |
s-dean | I've been scratching my head over this for over a week | 15:30 |
s-dean | im required to implement TLS throughout openstack | 15:31 |
mriedem | s-dean: ok can you file a bug? | 15:31 |
s-dean | of course | 15:31 |
s-dean | happy to help | 15:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide hints when nova-manage db sync fails to sync cell0 https://review.openstack.org/486660 | 15:31 |
mriedem | https://bugs.launchpad.net/nova/ | 15:31 |
mriedem | thanks | 15:31 |
mriedem | s-dean: also ^ | 15:31 |
mriedem | should help with that crappy error message | 15:31 |
s-dean | ok in the mean time to get this fixed, can i just modify the database_connection string, | 15:32 |
s-dean | do both cell0 and cell1 need to point at the nova_cell0 ? | 15:33 |
mriedem | s-dean: you can modify the db yes, but cell0 points at nova_cell0 | 15:33 |
mriedem | and cell1 points at the 'nova' db | 15:33 |
s-dean | ok perfect | 15:34 |
mriedem | cell1 is where your compute services and instances live | 15:34 |
openstackgerrit | Merged openstack/nova master: Update policy description for 'instance_actions' https://review.openstack.org/484609 | 15:34 |
mriedem | bdm table, etc | 15:34 |
s-dean | i will file a big report thank you so much for your help | 15:34 |
s-dean | much appreciated | 15:34 |
mriedem | yw, just ping me here with the bug number later, i'll be afk for awhile - sorry for the headache here | 15:34 |
*** rcernin has quit IRC | 15:34 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.53 - services and hypervisors using UUIDs https://review.openstack.org/485435 | 15:34 |
s-dean | will do, take care | 15:34 |
*** wasmum has quit IRC | 15:36 | |
*** wasmum has joined #openstack-nova | 15:39 | |
*** _pewp_ has quit IRC | 15:40 | |
*** _pewp_ has joined #openstack-nova | 15:40 | |
ildikov | mriedem: hi | 15:42 |
ildikov | mriedem: so I did some polishing with the tests and I have one single functional test failing | 15:42 |
ildikov | mriedem: I cannot figure out whether what I do is a completely bad idea or I'm just missing some small thing | 15:42 |
ildikov | mriedem: ping me if you have a few seconds or just give it a review when you can and then I'll fix things up as you say | 15:43 |
ildikov | mriedem: either works | 15:43 |
ildikov | mriedem: thanks in advance | 15:43 |
claudiub | moshele: eh, it didn't work to whitelist by devname, since the implementation for devname is linux-specific. :) | 15:44 |
moshele | claudiub: so just add windows support | 15:45 |
moshele | claudiub: also the pci address is linux spacifc | 15:45 |
openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/486434 | 15:45 |
openstackgerrit | Merged openstack/nova master: Dump versioned notifications when test_create_delete_server https://review.openstack.org/486301 | 15:46 |
*** Apoorva has quit IRC | 15:46 | |
*** imacdonn has quit IRC | 15:46 | |
openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/486435 | 15:46 |
*** armax has quit IRC | 15:47 | |
*** crushil has quit IRC | 15:47 | |
*** kristia__ has quit IRC | 15:48 | |
*** ratailor has joined #openstack-nova | 15:49 | |
*** kristian__ has joined #openstack-nova | 15:49 | |
jaypipes | edleafe, mriedem: so, I was wrong about that "good spot" comment. That block of code is actually where it needs to be. instance_uuid is defined within that block of code and if I de-indent, I get a local variable instance_uuid referenced before assignment error. | 15:49 |
*** prateek has joined #openstack-nova | 15:50 | |
*** kashyap has joined #openstack-nova | 15:50 | |
*** armax has joined #openstack-nova | 15:52 | |
claudiub | moshele: cool. will do. anyways. i still have one more question though. The CONF.pci.alias is a list of jsons, but the only valid keys are: name, product_id, vendor_id, and device_type, which doesn't really help me. can we add some other fields, like device_id, or devname? | 15:53 |
*** kristian__ has quit IRC | 15:54 | |
*** damien_r has quit IRC | 15:55 | |
edleafe | jaypipes: I still don't understand how instance_uuids could be None at that point, since you got instance_uuid from it in line 185 | 15:55 |
*** pchavva has quit IRC | 15:55 | |
moshele | claudiub: the pci.alias is used for pci passthrough. you don't need it for SR-IVO with networking | 15:55 |
*** jamesden_ has joined #openstack-nova | 15:55 | |
moshele | claudiub: isn't product_id and device_id the same | 15:55 |
moshele | claudiub: ? | 15:56 |
*** kristian__ has joined #openstack-nova | 15:56 | |
claudiub | moshele: no. if you have 2 identical devices, they will have the same vendor_id and product_id, but different device_ids | 15:56 |
jaypipes | edleafe: if I de-indent block 205-215 one level, line 185 may not have run. | 15:56 |
*** randomha1k has quit IRC | 15:56 | |
*** nicolasbock has quit IRC | 15:57 | |
*** jamesdenton has quit IRC | 15:57 | |
jaypipes | edleafe: oh, nm, I think I know what you're after. | 15:58 |
jaypipes | edleafe: duh, sorry... one sec. | 15:58 |
edleafe | jaypipes: Then don't de-indent. I'm wondering why there is a condition on instance_uuids is not None | 15:58 |
*** rcernin has joined #openstack-nova | 15:58 | |
jaypipes | edleafe: yep, sorry, I was being dense | 15:58 |
*** imacdonn has joined #openstack-nova | 15:58 | |
moshele | claudiub: so what is the device_id stand for in windows? in linux we have vendor_id and prodct_id (which is the device_id there is not such thing as product_id in linux) | 15:58 |
*** jjung_ has joined #openstack-nova | 15:59 | |
*** jmlowe_ has quit IRC | 15:59 | |
moshele | claudiub: I have to go home but you can send me a mail moshele@mellanox.com with all you questions .. | 15:59 |
openstackgerrit | Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566 | 16:00 |
jaypipes | edleafe: ok, sorry about that. done now :) ^^ | 16:00 |
jaypipes | mriedem: ^ | 16:00 |
claudiub | openstackgerrit: sure, thanks. :) | 16:00 |
jaypipes | claudiub: I don't think openstackgerrit is very responsive to thanks. :P | 16:01 |
*** moshele has quit IRC | 16:01 | |
*** randomhack has joined #openstack-nova | 16:01 | |
claudiub | ha, openstackgerrit wanted some attention, and jumped in front of my click. :D | 16:02 |
*** baoli has quit IRC | 16:02 | |
*** baoli has joined #openstack-nova | 16:02 | |
*** lucasagomes is now known as lucas-afk | 16:04 | |
*** armax has quit IRC | 16:04 | |
*** ijw has joined #openstack-nova | 16:05 | |
*** baoli has quit IRC | 16:07 | |
*** andreas_s has quit IRC | 16:08 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Migrate Ironic Flavors https://review.openstack.org/484949 | 16:08 |
edleafe | dansmith: ^^ hope this is closer to what you want | 16:08 |
*** trinaths has joined #openstack-nova | 16:08 | |
dansmith | edleafe: I was about to ask ... I'll go have a look | 16:08 |
dansmith | edleafe: the move from eventlet is purely a nova-api thing for wsgi stuff, fwiw | 16:09 |
openstackgerrit | Chris Friesen proposed openstack/nova master: Add validation for cpu_realtime_mask https://review.openstack.org/468203 | 16:10 |
openstackgerrit | Chris Friesen proposed openstack/nova master: Tweak the cpu_realtime_mask handling slightly https://review.openstack.org/461456 | 16:10 |
*** ijw has quit IRC | 16:10 | |
*** jjung_ has quit IRC | 16:10 | |
mdbooth | kashyap: https://review.openstack.org/#/c/485752/ Can you remind me where we rewrite the guest xml post migration? | 16:14 |
mdbooth | kashyap: NM, I didn't read your commit message carefully enough | 16:15 |
*** ratailor has quit IRC | 16:15 | |
*** claudiub has quit IRC | 16:15 | |
*** randomhack has quit IRC | 16:20 | |
*** jamesden_ has quit IRC | 16:21 | |
*** jamesdenton has joined #openstack-nova | 16:23 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 16:27 |
melwitt | mriedem: your comments addressed ^ | 16:29 |
*** yufei has quit IRC | 16:29 | |
*** lyan has quit IRC | 16:29 | |
s-dean | mriedem: https://bugs.launchpad.net/nova/+bug/1706118 | 16:31 |
openstack | Launchpad bug 1706118 in OpenStack Compute (nova) "Adding TLS Connection String To Database Connection Causes malformed URL in cell_mappings DB" [Undecided,New] | 16:31 |
edleafe | dansmith: still not clear how nodes could be batched in the ironic driver. Wouldn't that require some way of persisting what has been done already? | 16:32 |
*** baoli has joined #openstack-nova | 16:33 | |
*** dtp has joined #openstack-nova | 16:35 | |
*** crushil has joined #openstack-nova | 16:40 | |
*** rajathagasthya has joined #openstack-nova | 16:41 | |
*** Apoorva has joined #openstack-nova | 16:42 | |
*** sshwarts has quit IRC | 16:42 | |
*** ratailor has joined #openstack-nova | 16:43 | |
*** jjung has quit IRC | 16:47 | |
melwitt | mriedem: I went to change the counting quotas blueprint to Implemented and it automatically changed it to Complete (I didn't know it would do that) https://blueprints.launchpad.net/nova/+spec/cells-count-resources-to-check-quota-in-api | 16:47 |
melwitt | sorry about that | 16:48 |
*** rajathagasthya has quit IRC | 16:48 | |
*** rajathag_ has joined #openstack-nova | 16:48 | |
melwitt | oh, it let me change it back | 16:50 |
melwitt | phew. | 16:50 |
*** armax has joined #openstack-nova | 16:52 | |
dansmith | edleafe: by batching I mean do 25 at a time, in that thread | 16:52 |
dansmith | edleafe: like for i in range(0, len(uuids), 25): do_instances(uuids[i:i+25]) | 16:53 |
*** mgiles has quit IRC | 16:56 | |
edleafe | batching which? I'm going through the nodes 1 by 1, and creating the instances one at a time | 16:56 |
*** mgiles has joined #openstack-nova | 16:56 | |
*** derekh has quit IRC | 16:56 | |
edleafe | I thought that doing it that way would satisfy your memory explosion concern | 16:56 |
dansmith | edleafe: it does, but now we're hammering the database and conductor with one-by-one queries on every single boot | 16:58 |
*** felipemonteiro_ has quit IRC | 16:59 | |
*** ralonsoh has quit IRC | 17:02 | |
*** randomhack has joined #openstack-nova | 17:05 | |
*** lyan has joined #openstack-nova | 17:05 | |
*** moshele has joined #openstack-nova | 17:05 | |
*** fragatina has quit IRC | 17:06 | |
*** ircuser-1 has joined #openstack-nova | 17:08 | |
*** harlowja has joined #openstack-nova | 17:09 | |
*** moshele has quit IRC | 17:10 | |
*** randomhack has quit IRC | 17:13 | |
*** efoley has quit IRC | 17:15 | |
*** gszasz has quit IRC | 17:15 | |
melwitt | dansmith, mriedem: I was wondering whether we're gonna try to get this list instances across cells merge done this week? https://review.openstack.org/#/c/463618/ | 17:16 |
dansmith | melwitt: I talked to mdbooth last week and it sounded like it wasn't going to happen | 17:17 |
dansmith | melwitt: especially since to do it right I think we'll need some refactoring of our db layer | 17:17 |
openstackgerrit | Sean Dague proposed openstack/nova master: Suppress some test warnings https://review.openstack.org/486700 | 17:17 |
melwitt | dansmith: oh. I took a quick look at the patch but wasn't sure the detail of what's left to do with it and whether one of us can finish it up | 17:18 |
melwitt | one of us could be me, I mean | 17:18 |
dansmith | well, we could, but I don't think it's a reasonable thing to throw in at the last minute | 17:18 |
melwitt | k | 17:19 |
*** baoli has quit IRC | 17:20 | |
openstackgerrit | Chris Friesen proposed openstack/nova master: Ensure we unshelve in the cell the instance is mapped https://review.openstack.org/486208 | 17:21 |
cfriesen | I added some assertions to existing tests here ^....if you want entirely new tests I can do that, but I wasn't sure it was worth the overhead. | 17:22 |
*** jmlowe has joined #openstack-nova | 17:22 | |
*** jmlowe has quit IRC | 17:22 | |
*** baoli has joined #openstack-nova | 17:23 | |
*** jmlowe has joined #openstack-nova | 17:25 | |
*** ratailor has quit IRC | 17:25 | |
*** jmlowe has quit IRC | 17:26 | |
*** randomhack has joined #openstack-nova | 17:28 | |
*** jmlowe has joined #openstack-nova | 17:29 | |
*** jmlowe has quit IRC | 17:31 | |
*** jmlowe has joined #openstack-nova | 17:31 | |
*** sambetts is now known as sambetts|afk | 17:33 | |
*** fragatin_ has joined #openstack-nova | 17:34 | |
*** fragatin_ has quit IRC | 17:34 | |
*** fragatin_ has joined #openstack-nova | 17:34 | |
s-dean | hi, any pointers on how i may solve this issue ? MessagingTimeout: Timed out waiting for a reply to message ID | 17:35 |
s-dean | its telling me to submit a bug report | 17:35 |
*** eharney has quit IRC | 17:35 | |
s-dean | sorry not it> Nova* | 17:35 |
*** trinaths has quit IRC | 17:35 | |
s-dean | nova.api.openstack.extensions [req-3ed5c135-64bd-4c39-934d-3d3d7a32a6b5 14d1055c2e2d4f0eab6739671b2688a8 cf7b827f55de4406b9325ab3505b973d - default default] Unexpected exception in API method | 17:36 |
*** fragatina has joined #openstack-nova | 17:37 | |
*** fragatina has quit IRC | 17:37 | |
*** baoli has quit IRC | 17:37 | |
*** fragatin_ has quit IRC | 17:37 | |
*** fragatina has joined #openstack-nova | 17:38 | |
*** thorst_ has quit IRC | 17:38 | |
melwitt | s-dean: I think that's an RPC timeout, so you will want to check your transport_url for your cell1 and make sure it's correct | 17:39 |
s-dean | ok cheers will do that now | 17:40 |
*** felipemonteiro has joined #openstack-nova | 17:43 | |
*** felipemonteiro_ has joined #openstack-nova | 17:44 | |
*** bkopilov has quit IRC | 17:44 | |
*** ed___ has joined #openstack-nova | 17:44 | |
*** thorst has joined #openstack-nova | 17:44 | |
*** ed___ has quit IRC | 17:45 | |
*** baoli has joined #openstack-nova | 17:45 | |
*** edleafe_ has joined #openstack-nova | 17:45 | |
*** bkopilov_ has quit IRC | 17:46 | |
*** felipemonteiro has quit IRC | 17:47 | |
s-dean | yeah, cell1's RPC mapping was wrong, i have changed it and restarted all nova services, no dice :/ | 17:49 |
s-dean | still same error | 17:49 |
*** thorst has quit IRC | 17:49 | |
*** bkopilov_ has joined #openstack-nova | 17:49 | |
s-dean | can i ask would it be better to implement SSL/TLS after successfully setting up openstack unencrypted ? | 17:50 |
*** bkopilov has joined #openstack-nova | 17:50 | |
*** baoli has quit IRC | 17:50 | |
dansmith | s-dean: I'm not following along, but you're sure that the cell1 mapping points to the same rpc endpoint that your other services do? | 17:50 |
*** eharney has joined #openstack-nova | 17:50 | |
*** yamahata has quit IRC | 17:50 | |
melwitt | s-dean: did you change it using "nova-manage cell_v2 update_cell"? as shown https://docs.openstack.org/nova/latest/cli/nova-manage.html#man-page-cells-v2 | 17:51 |
mriedem | melwitt: i think https://blueprints.launchpad.net/nova/+spec/cells-count-resources-to-check-quota-in-api is done | 17:51 |
mriedem | https://review.openstack.org/#/c/446243/ was the last change to merge | 17:52 |
*** mvk has quit IRC | 17:52 | |
s-dean | no i did not | 17:52 |
*** edleafe- has joined #openstack-nova | 17:52 | |
melwitt | s-dean: yeah you need to use the nova-manage commands to get it set right in the database. you can use "nova-manage cell_v2 list_cells --verbose" to see what you currently have | 17:52 |
s-dean | ok cheers | 17:53 |
melwitt | these are stored in the database now because the API needs to know how to contact each of the cells you have | 17:53 |
melwitt | mriedem: agreed, I just didn't mean to set the Completed state because I think usually you do that | 17:53 |
melwitt | but it does it automatically if you put Implemented | 17:54 |
*** kristian__ has quit IRC | 17:54 | |
*** felipemonteiro_ has quit IRC | 17:54 | |
*** felipemonteiro has joined #openstack-nova | 17:54 | |
*** kristian__ has joined #openstack-nova | 17:55 | |
mriedem | melwitt: i like to yeah because i have a spreadsheet keeping track of when things are closed out | 17:55 |
mriedem | b/c i'm a nerd | 17:55 |
*** edleafe has quit IRC | 17:55 | |
melwitt | mriedem: heh. I would probably do the same thing. don't want to mess up your system | 17:55 |
mriedem | just please be sure to put scissors, pens and dusters back where you got them if you're ever at my house | 17:56 |
mriedem | and windex | 17:56 |
melwitt | lol | 17:56 |
*** edleafe_ has quit IRC | 17:56 | |
*** rajathag_ is now known as rajathagasthya | 17:56 | |
*** edleafe- is now known as edleafe | 17:56 | |
*** claudiub has joined #openstack-nova | 17:58 | |
*** kristian__ has quit IRC | 17:59 | |
s-dean | do ineed to sync the db's after running that update command | 18:00 |
melwitt | s-dean: no, just need to restart your nova-api services I think | 18:00 |
dansmith | unless he never properly sync'd it as a result | 18:00 |
*** FL1SK has quit IRC | 18:00 | |
s-dean | yeah, still timing out | 18:01 |
melwitt | hm | 18:01 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide hints when nova-manage db sync fails to sync cell0 https://review.openstack.org/486660 | 18:02 |
dansmith | s-dean: so if you grep transport_url out of your configs on all nodes, they match exactly what is in the db for the cell1 transport_url? | 18:03 |
*** mgiles has quit IRC | 18:05 | |
*** dtantsur is now known as dtantsur|afk | 18:05 | |
*** mgiles has joined #openstack-nova | 18:05 | |
s-dean | ok so i can confirm, that on my controller node the URL's are correct, however on the compute node it is not because of: https://docs.openstack.org/security-guide/messaging/security.html | 18:06 |
*** jbernard has quit IRC | 18:06 | |
mriedem | sdague: did you ever report a bug for the request log thing with uwsgi? | 18:07 |
sdague | mriedem: I don't think I did actually | 18:07 |
*** wasmum has quit IRC | 18:09 | |
mriedem | sdague: ok, did the same thing need to be done in other projects like cinder? | 18:10 |
*** dtp has quit IRC | 18:10 | |
mriedem | if so, could be good to track with a bug for those other projects too | 18:10 |
*** wasmum has joined #openstack-nova | 18:10 | |
*** jbernard has joined #openstack-nova | 18:11 | |
*** thorst has joined #openstack-nova | 18:12 | |
dansmith | s-dean: so...the compute node is not correct? | 18:13 |
s-dean | does the username need to be consistent across all nodes, or is having different users for each compute node ok ? | 18:14 |
s-dean | yes i gave the compute node its on users | 18:14 |
s-dean | user | 18:14 |
s-dean | and assigned it all permissions | 18:14 |
s-dean | own* | 18:14 |
dansmith | s-dean: they can be different, they just all have to point at the same vhost of course | 18:14 |
s-dean | in my case my vhost is / | 18:15 |
dansmith | as long as that is the same for all the nodes then that's fine | 18:15 |
dansmith | s-dean: aside from that, we need more context on which thing is failing, so more detailed logs, and a sanitized dump of your config and cell_mappings table are needed | 18:16 |
*** psachin has quit IRC | 18:16 | |
*** rcernin has quit IRC | 18:16 | |
s-dean | paste bin urls ok ? | 18:17 |
dansmith | yeah | 18:17 |
*** prateek has quit IRC | 18:17 | |
s-dean | https://pastebin.com/WEu7JCWW | 18:18 |
dansmith | s-dean: are you running n-net? | 18:20 |
dansmith | s-dean: and looks like you're configured for cellsv1, is that intentional or did you think that was related? | 18:20 |
dansmith | because this timeout is trying to call the cellsv1 service, which if you're not running it, will always time out :) | 18:20 |
s-dean | oh ok | 18:21 |
s-dean | i didnt know i was running cells v1 | 18:22 |
s-dean | is this because of the following config line compute_api_class=nova.compute.cells_api.ComputeCellsAPI | 18:22 |
s-dean | my config is here | 18:22 |
s-dean | https://bugs.launchpad.net/nova/+bug/1706118 | 18:22 |
dansmith | s-dean: you definitely know if you're running cellsv1 because it's a huge friggin nightmare, | 18:22 |
openstack | Launchpad bug 1706118 in OpenStack Compute (nova) ocata "Adding TLS Connection String To Database Connection Causes malformed URL in cell_mappings DB" [High,Confirmed] | 18:22 |
dansmith | so I'm guessing maybe you configured that while trying to resolve this problem? | 18:22 |
s-dean | yeah i have been poking about quite a bit | 18:23 |
dansmith | s-dean: this is an upgrade from a previously working deployment, right? | 18:23 |
s-dean | no fresh install, but because of that DB error, i have been trying to debug and find the right settings | 18:23 |
dansmith | oh, okay | 18:24 |
dansmith | s-dean: well, you went down a bad path | 18:24 |
*** felipemonteiro_ has joined #openstack-nova | 18:24 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable https://review.openstack.org/486623 | 18:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: request_log addition for running under uwsgi https://review.openstack.org/485602 | 18:24 |
dansmith | s-dean: might want to start fresh if it's not too much trouble and avoid any of that cellsv1 stuff, depending | 18:24 |
s-dean | haha, is my install screwed ? | 18:24 |
s-dean | ok i will od | 18:24 |
s-dean | do | 18:24 |
mriedem | fear leads to anger, anger leads to hate, hate leads to cells v1 | 18:24 |
dansmith | it's definitely rescue-able, but if you're trying to nail down a procedure it'll be confusing from here | 18:24 |
dansmith | cellsv1 leads to? | 18:25 |
mriedem | showing up in nova freenode irc? | 18:25 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove the useless FakeExt https://review.openstack.org/486415 | 18:25 |
s-dean | xD | 18:25 |
mriedem | which is equivalent to the dark side | 18:25 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove the useless extension block_device_mapping_v1 object https://review.openstack.org/486069 | 18:25 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove the useless fake ExtensionManager from API unittests https://review.openstack.org/486416 | 18:25 |
s-dean | awww man wish i came here sooner, i dont like asking for help i prefer to bash it out, and use google | 18:25 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Move the note about '/os-volume_boot' to the correct place https://review.openstack.org/486071 | 18:25 |
mriedem | sdague: requestlog thing is approved | 18:27 |
mriedem | sdague: you want to skim over this hot little number? https://review.openstack.org/#/c/485435/ | 18:27 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Migrate Ironic Flavors https://review.openstack.org/484949 | 18:27 |
*** felipemonteiro has quit IRC | 18:27 | |
*** yamahata has joined #openstack-nova | 18:30 | |
*** baoli has joined #openstack-nova | 18:32 | |
*** mgiles has quit IRC | 18:34 | |
*** mgiles has joined #openstack-nova | 18:34 | |
dansmith | jaypipes: edleafe: I was thinking that the ironic node class was required now.. do we really need to concern ourselves with that not being set? | 18:35 |
s-dean | shouldnt that config option be removed from the docs ? | 18:35 |
s-dean | https://docs.openstack.org/ocata/config-reference/compute/cells.html | 18:36 |
dansmith | s-dean: we can't yet | 18:36 |
dansmith | s-dean: people still run that stuff and have to for a bit longer | 18:36 |
s-dean | a fair enough | 18:36 |
*** baoli has quit IRC | 18:37 | |
*** wasmum has quit IRC | 18:41 | |
mriedem | s-dean: we're in the process of moving those docs into nova, at which point we can put a big fat warning at the top saying that's for cells v1 | 18:42 |
edleafe | jaypipes: regarding your comments about splitting the patch for https://review.openstack.org/#/c/486215/, do you want me to build the list of alternates, but continue to only return the selected hosts? And then change all the method signatures in https://review.openstack.org/#/c/486253/ ? | 18:43 |
*** wasmum has joined #openstack-nova | 18:43 | |
edleafe | dansmith: I asked dtantsur|afk about that. He said that while adding the resource_class attribute was required, populating it completely was not | 18:43 |
dansmith | edleafe: okay so, we should check it and if it's not present, log a warning and bail? | 18:44 |
edleafe | dansmith: if it's not present, just skip | 18:45 |
dansmith | edleafe: we have to log a warning, since not having it set will lead to brokenness later, but.. your code currently is not skipping right? | 18:46 |
dansmith | in PS10 I mean | 18:46 |
edleafe | dansmith: correct. Want me to add some safety stuff there? | 18:47 |
dansmith | edleafe: yeah, warn and skip if unset, test for those cases and then I think we can land this and argue about the batching after | 18:47 |
s-dean | mriedem: that would be brilliant. before i head home for the night, can i specify in keystone, glance and nova their database connections to be localhost skipping the need for TLS, or do they need to be specified with a network address like in the docs? do the other service such as neutron and and nova-compute need to access the DB over the network? | 18:48 |
edleafe | dansmith: ok cool. I asked in -ironic about how often the compute service would be restarted. Got one answer from jroll, and that was he only did it during upgrades | 18:49 |
edleafe | IOW, not a common thing for him | 18:49 |
*** jamesden_ has joined #openstack-nova | 18:49 | |
mriedem | s-dean: nova-compute definitely does not use the db locally | 18:49 |
mriedem | i don't know about the various neutron agents | 18:49 |
*** jamesdenton has quit IRC | 18:49 | |
dansmith | edleafe: heh, sure, but jroll knows what he's doing | 18:49 |
mriedem | or cinder-volume | 18:49 |
dansmith | edleafe: like I said there are other config management approaches that are pretty darn restart happy | 18:49 |
dansmith | I know of one very specifically | 18:50 |
dansmith | one that has lots of Os in it | 18:50 |
*** itlinux has joined #openstack-nova | 18:53 | |
mriedem | s-dean: got it https://review.openstack.org/#/c/486724/ | 18:53 |
jaypipes | edleafe: re: separate patch, yeah, I'm thinking it's best to generate that list of alternates in the first patch (but not change the returned value from select_destinations() and then in the followup patch, change the RPC API signature and the corresponding conductor stuff | 18:53 |
s-dean | mriedem: I'm installing a general compute cloud, nothing to fancy, | 18:53 |
openstackgerrit | Merged openstack/nova master: placement: add retry tight loop claim_resources() https://review.openstack.org/486170 | 18:54 |
s-dean | mriedem: cheers :) | 18:54 |
dansmith | jaypipes: edleafe agreed | 18:54 |
mriedem | s-dean: but the nova-compute services are running on separate hosts right/ | 18:54 |
mriedem | ? | 18:54 |
s-dean | yes | 18:54 |
mriedem | nova-compute will interact with the db via nova-conductor | 18:54 |
s-dean | compute01 | 18:54 |
s-dean | ok sweet | 18:54 |
edleafe | jaypipes: ok, so the last change will go from the current return of a list of hosts to the monsterous list of hosts+alternates+allocation_candidates, right? | 18:54 |
mriedem | so if nova-conductor is on the control nodes local to the db, then you could use localhost for nova.conf for conductor | 18:54 |
mriedem | but not nova-compute | 18:54 |
mriedem | s-dean: nova-compute shouldn't even need the [database] section filled in for nova.conf | 18:55 |
s-dean | ok awsome, yeah all the scheduler conductor novncproxy etc are on 1 controller node | 18:55 |
mriedem | then localhost or 127.0.0.1 is fine for those | 18:55 |
s-dean | looks like neutron needs access to the DB from across the network :/ | 18:55 |
s-dean | ill cross that brige when i come to it i guess | 18:55 |
mriedem | i'm not familar with everything they do | 18:56 |
jaypipes | edleafe: not sure that we need to return a list of alternates instead of just a list of allocation candidates, but wondering what dansmith thinks. | 18:56 |
mriedem | s/everything/most anything/ | 18:56 |
*** claudiub has quit IRC | 18:56 | |
jaypipes | edleafe: the only reason to do so would be to keep the allocation candidates entirely opaque | 18:56 |
*** jwcroppe has quit IRC | 18:58 | |
dansmith | jaypipes: we have to keep allocation candidates | 18:58 |
dansmith | jaypipes: the cell conductor can't know what else to claim otherwise.. a hostname/uuid isn't enough | 18:58 |
*** jwcroppe has joined #openstack-nova | 18:59 | |
jaypipes | dansmith: no, I'm referring to whether we return a list of alternate hosts PLUS the allocation candidates OR just a list of allocation candidates. | 18:59 |
dansmith | jaypipes: ah okay | 18:59 |
*** rajathag_ has joined #openstack-nova | 19:00 | |
mriedem | would the alternate hosts be used for anything? | 19:00 |
mriedem | does conductor use them to monkey with the request spec or scheduler hints? | 19:00 |
*** annegentle has quit IRC | 19:00 | |
jaypipes | mriedem: nothing other than preventing the conductor from needing to know anything about the allocation_candidates. | 19:00 |
jaypipes | mriedem: the alternate_hosts would replace the retry block in the request spec essentially. | 19:01 |
*** rajathagasthya has quit IRC | 19:01 | |
dansmith | jaypipes: if that allows conductor to be ignorant of theallocation then yes, good plan | 19:01 |
jaypipes | dansmith: k.\ | 19:01 |
*** jwcroppe_ has joined #openstack-nova | 19:01 | |
jaypipes | the decision comes down to how much opacity we want those allocation_request blocks to be. :) | 19:01 |
mriedem | where is the code being proposed that needs them together? | 19:02 |
jaypipes | mriedem: edleafe's currently working on the series. | 19:02 |
*** jwcroppe has quit IRC | 19:03 | |
edleafe | jaypipes: the way I understood it is that we would return a series of alternate hosts in case the cell had to retry a build. Each of those hosts would need its corresponding allocation_candidate so that the cell conductor could do the proper claiming. | 19:03 |
dansmith | right | 19:04 |
dansmith | however, I was thinking that: | 19:04 |
jaypipes | edleafe: yes, that's exactly correct. I was only pointing out that technically the allocation_requests contain all the information in the alternate_hosts list. | 19:04 |
dansmith | conductor would throw the first allocation candidate at placement, and then parse the result to determine which compute host it should send the rpc message to | 19:04 |
jaypipes | edleafe: but like I said, that would require the cell conductor to understand what an allocation request was (i.e. the allocation_request would no longer be opaque) | 19:05 |
dansmith | that would mean no extra list, but also opaque allocation request | 19:05 |
dansmith | jaypipes: not if ^ | 19:05 |
jaypipes | right. :) | 19:05 |
mriedem | "conductor would throw the first allocation candidate at placement" - that's the cell conductor yes? | 19:05 |
edleafe | dansmith: "parse the result"? | 19:05 |
mriedem | during a retry | 19:05 |
dansmith | edleafe: parse the result of the POST of the allocation | 19:06 |
jaypipes | I think the most appropriate return value from select_destinations() would be a list of (host, allocation_request) tuples. | 19:06 |
jaypipes | for the first item in that list, the allocation_request would be the one that had already been successfully claimed for the selected host. | 19:07 |
jaypipes | dansmith: agree? | 19:07 |
mriedem | select_destinations today returns as the first entry the one that was chosen, right? | 19:07 |
dansmith | sure that's fine, if that's how you want it to look | 19:07 |
jaypipes | mriedem: for each instance in num_instances, yes | 19:07 |
edleafe | dansmith: reportclient.claim_resources returns a boolean | 19:08 |
jaypipes | so actually, the return value needs to be list of list of that tuple. | 19:08 |
dansmith | edleafe: what's your point? | 19:08 |
jaypipes | with the outer list being for the num_instances | 19:08 |
edleafe | dansmith: what's there to parse? | 19:08 |
mriedem | a list of lists of tuples | 19:08 |
mriedem | what could go wrong | 19:08 |
edleafe | dansmith: the cell conductor would still need to "know" about the allocation_candidate structure | 19:09 |
dansmith | edleafe: the actual POST call for /allocations returns the allocation you made right? | 19:09 |
mriedem | it's not a POST | 19:09 |
edleafe | It's a PUT | 19:09 |
dansmith | edleafe: the cell conductor can, but I think it should look at the result of the http call not the thing it was passed in rpc, otherwise we've got version mess | 19:09 |
edleafe | And it returns a 204 on success | 19:10 |
dansmith | christ, whatever | 19:10 |
mriedem | yeah no content on success | 19:10 |
jaypipes | mriedem: well, tell me if you want to stop supporting num_instances > 1 and I'll gladly submit that patch ;) | 19:10 |
dansmith | okay then that clearly won't work | 19:10 |
edleafe | For each host, you get a list of (host, alloc) tuples. | 19:11 |
jaypipes | right | 19:11 |
jaypipes | ++ | 19:11 |
edleafe | On a retry in the cell, you try claiming the alloc. If that succeeds, you build on that host | 19:12 |
jaypipes | +1 | 19:12 |
dansmith | I don't love it, but I'm also not sure why we're even discussing it | 19:12 |
edleafe | If it fails, move to the next one in the list | 19:12 |
jaypipes | right, zactly.\ | 19:12 |
edleafe | jaypipes: so I don't understand why you would want to only return alloc | 19:12 |
mriedem | and just to confirm my understand, we only ever care about the list of lists for the server create case, b/c for everything else, like migrations and unshelve, it gets back the list of host states today but just takes the first one for the rpc cast to compute | 19:14 |
mriedem | *understanding | 19:14 |
jaypipes | edleafe: never mind my thought about only returning the allocations. I've been convinced that's a bad idea. | 19:14 |
edleafe | jaypipes: roger that | 19:15 |
*** thorst is now known as thorst_afk | 19:15 | |
mriedem | seems you have to have both the HostState and allocation requests because of all the filter properties and az and limits and node crap that's embedded in the HostState object | 19:15 |
mriedem | which conductor is using before casting to compute | 19:16 |
mriedem | yeah? | 19:16 |
dansmith | hope not since hoststate is very scheduler-specific | 19:16 |
dansmith | all conductor needs is the hostname of the target compute | 19:16 |
mriedem | sec | 19:16 |
mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L689-L700 | 19:16 |
mriedem | ^ just for unshelve | 19:16 |
dansmith | oh, that's not HostState, | 19:17 |
dansmith | that's the dict of randomness | 19:17 |
mriedem | but there is all sorts of redonkulous in there for limits and such | 19:17 |
dansmith | which was based on HostState | 19:17 |
mriedem | this? https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L48 | 19:17 |
dansmith | yeah, that's going to fsck us | 19:17 |
mriedem | still has limits in it | 19:17 |
mriedem | b/c N-mfing-UMA | 19:17 |
dansmith | oh well, nice knowing you gents | 19:17 |
* dansmith pulls the trigger | 19:18 | |
mriedem | well now that dan is taken care of | 19:18 |
mriedem | and i guess it's getting the az from the chosen host via the aggregates on that host | 19:19 |
mriedem | limits go into filter properties for the claim in the compute | 19:19 |
mriedem | and i guess the node is also passed down explicitly for the RT claim | 19:19 |
mriedem | i wonder if anyone has ever tried shelve offloading and unshelving an instance that had pci/numa stuff on it :) | 19:20 |
dansmith | that is also an unversioned dict result from that scheduler rpc call | 19:22 |
dansmith | we should *not* commit that same sin in the boot calls | 19:22 |
*** baoli has joined #openstack-nova | 19:22 | |
jaypipes | ok, let's focus on what we need to do here to get retries working in cellsv2 | 19:23 |
jaypipes | are we all in agreement about the proposed return value from select_destinations() for edleafe's patch? | 19:23 |
dansmith | no I think that's mriedem's point | 19:23 |
jaypipes | a list of lists of (host, alloc_request) tuples, yes? | 19:23 |
mriedem | we agree we need allocation requests and the host_state dict thingies i think | 19:23 |
mriedem | or maybe we don't agree | 19:24 |
dansmith | I think he's saying we need to pass the HostState mess, right mriedem ? | 19:24 |
mriedem | yes | 19:24 |
* jaypipes goes to investigate whether limits['numa' | 19:24 | |
jaypipes | is even used.... | 19:24 |
mriedem | it is | 19:24 |
mriedem | in the claim code | 19:24 |
dansmith | oh it is | 19:24 |
dansmith | yeah | 19:24 |
* dansmith hands jaypipes the 9mm | 19:24 | |
mriedem | note that all of the docstrings say the limits are vcpus/ram/disk | 19:24 |
mriedem | not numa | 19:24 |
mriedem | so it's totally f'ing confusing | 19:24 |
mriedem | no desert eagle? | 19:25 |
mriedem | you want open casket? | 19:25 |
jaypipes | yeah, it is. :( | 19:25 |
dansmith | mriedem: it's what I have within reach | 19:25 |
jaypipes | dansmith, mriedem: k, so the returned value needs to be list of lists of (host_dict_with_limits_thing, alloc_request) | 19:25 |
jaypipes | edleafe: ^ | 19:25 |
dansmith | no | 19:26 |
dansmith | because | 19:26 |
dansmith | host_dict_with_limits is an unversioned structure and we're not adding a parameter with a LIST OF TUPLES OF THAT THING to one of our clean rpc calls | 19:26 |
mriedem | clean rpc calls? | 19:26 |
jaypipes | dansmith: don't we already pass the limits stuff down to build_instance()? | 19:27 |
* jaypipes wonders where we get the limits thing... | 19:27 | |
mriedem | select_destinations today returns the unversioned host_dict_with_limits_thing | 19:27 |
dansmith | jaypipes: no we get it fromthe scheduler | 19:27 |
mriedem | jaypipes: the NUMATopologyFilter | 19:27 |
jaypipes | mriedem: no, I know that. I meant where does the limits get passed to instance_claim() on the compute host. | 19:27 |
mriedem | jaypipes: let me present exhibit Z98 https://review.openstack.org/#/c/484439/ | 19:27 |
mriedem | via the filter props | 19:28 |
mriedem | actually no, | 19:28 |
mriedem | build_and_run_instance has a limits kwarg | 19:28 |
mriedem | which is the limits from the scheduler | 19:28 |
* dansmith pours gas on this whole thing and lights a match | 19:28 | |
mriedem | which as far as i know just contains the numa topology limits | 19:28 |
mriedem | EXCEPT | 19:28 |
mriedem | for out of tree scheduler drivers that stash crap in there too :) | 19:28 |
mriedem | *and filters | 19:28 |
dansmith | hmm | 19:29 |
dansmith | so maybe we talk to scheduler late enough in this process that we're only calling ugly rpc calls with limits as a param from here on out? | 19:29 |
mriedem | do we need a hangout? | 19:29 |
dansmith | I need a therapist. | 19:29 |
mriedem | laura's mom went to grad school for that i think, she'll talk your ear off | 19:30 |
mriedem | about vacuums that also polish wood floors | 19:30 |
mriedem | controlled via your iphone app | 19:30 |
jaypipes | I'm wondering if we can't just recreate the limits['numa_topology'] on the compute host.... | 19:30 |
mriedem | i guess i'm failing to see the issue with sending both back from select_destinations | 19:31 |
mriedem | we're already sending host_dict_with_limits_thing | 19:31 |
jaypipes | dansmith: ^ | 19:31 |
mriedem | we're just tacking allocation_request(s)? onto that | 19:31 |
mriedem | as a tuple | 19:31 |
mriedem | btw, are these allocation requests plural or singular? | 19:31 |
mriedem | one per host right? so singular | 19:32 |
edleafe | mriedem: we're changing 2 things | 19:32 |
jaypipes | mriedem: singular per host, yeah. | 19:32 |
edleafe | instead of a single host | 19:32 |
dansmith | yeah, like I said above, I think I was missing that we're already passing that grossness in the rpc calls downstream from where we get them | 19:32 |
*** rajathag_ has quit IRC | 19:32 | |
edleafe | we're sending a list of hosts | 19:32 |
edleafe | and each of those has an associated allocation_candidate | 19:32 |
mriedem | edleafe: please provide context | 19:32 |
mriedem | "sending" from where to where? | 19:32 |
edleafe | to the cell conductor | 19:32 |
edleafe | from the super conductor | 19:32 |
dansmith | super conductor doesn't call cell conductor | 19:33 |
dansmith | super conductor calls the first compute node, which will call cell conductor on retry | 19:33 |
mriedem | edleafe: ok so here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1046 | 19:33 |
edleafe | I thought that was changing so that we supported alternates | 19:33 |
*** randomhack has quit IRC | 19:33 | |
dansmith | no | 19:34 |
edleafe | So we're sending the compute node the big honking list of list of stuff? | 19:34 |
mriedem | api -> super conductor > scheduler > super conductor > compute > cell conductor (retry) > compute | 19:34 |
dansmith | right | 19:34 |
edleafe | And then it sends it to cell conductor on retry? | 19:34 |
mriedem | yes | 19:34 |
mriedem | the allocation requests are getting passed through | 19:35 |
mriedem | like barnacles | 19:35 |
mriedem | or a tube sock in mortier | 19:35 |
mriedem | *mortimer | 19:35 |
edleafe | more like kidney stones | 19:35 |
mriedem | 2nd question, | 19:35 |
melwitt | lol omg, mortimer | 19:35 |
mriedem | are we changing the build_and_run_instances compute rpc api to pass allocation requests, or shoving those into something else already being sent, like request spec or filter properties? | 19:36 |
*** vladikr has quit IRC | 19:37 | |
dansmith | one of those | 19:37 |
mriedem | which would also impact the build_and_run_instance method in conductor rpc api | 19:37 |
*** vladikr has joined #openstack-nova | 19:37 | |
mriedem | *build_instances | 19:38 |
dansmith | if we put it into something like reqspec, we won't be able to send them to older computes | 19:38 |
dansmith | which will break our upgrade process | 19:38 |
dansmith | because they'll kick the newer version back | 19:38 |
mriedem | personally i think it's cleaner as a new parameter on the rpc api | 19:39 |
dansmith | which I guess is the same for the new param approach | 19:39 |
dansmith | we just need to handle the case in the retry logic, | 19:39 |
dansmith | if we didn't get these new things, assume we can talk to the scheduler and do a reschedule | 19:39 |
mriedem | but if your cell conductor is blocked from up calls to the scheduler, how would that work? | 19:40 |
dansmith | if you have old computes, | 19:40 |
dansmith | then you don't have a multi-tier cellsv2 environment, | 19:40 |
dansmith | because we didn't support it before, | 19:40 |
dansmith | thus it must be fine | 19:40 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Migrate Ironic Flavors https://review.openstack.org/484949 | 19:40 |
mriedem | idk, we don't really have anything doc'ed for this | 19:41 |
dansmith | eh? | 19:41 |
dansmith | it can't work right now | 19:41 |
dansmith | no need to doc it :) | 19:41 |
mriedem | what does old computes have to do with multi-tier cells v2? | 19:41 |
dansmith | can we discuss on a hangout? I'm about out of steam and have to move onto something else soon | 19:42 |
dansmith | be quicker if we can hash it out like that I think | 19:42 |
mriedem | i'm fine with a hangout | 19:42 |
jaypipes | me too. | 19:42 |
*** avolkov has joined #openstack-nova | 19:42 | |
* dansmith urls | 19:42 | |
dansmith | https://hangouts.google.com/call/pjno3bssgba33a343nf47d357iu | 19:43 |
*** jwcroppe_ has quit IRC | 19:45 | |
*** jwcroppe has joined #openstack-nova | 19:45 | |
*** randomhack has joined #openstack-nova | 19:46 | |
*** mgiles has quit IRC | 19:48 | |
*** danpawlik has quit IRC | 19:48 | |
*** mgiles has joined #openstack-nova | 19:48 | |
*** jwcroppe has quit IRC | 19:50 | |
*** danpawlik has joined #openstack-nova | 19:50 | |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted certificates to InstanceExtras https://review.openstack.org/457711 | 19:52 |
*** jwcroppe has joined #openstack-nova | 19:53 | |
openstackgerrit | Merged openstack/nova master: Remove an unnecessary argument in _prep_resize https://review.openstack.org/486521 | 19:53 |
openstackgerrit | Merged openstack/python-novaclient master: Expect id and disabled_reason in GET /os-services response https://review.openstack.org/485409 | 19:54 |
*** rajathagasthya has joined #openstack-nova | 19:54 | |
*** ekhugen has quit IRC | 20:03 | |
*** Guest30741 has quit IRC | 20:04 | |
*** jwcroppe has quit IRC | 20:05 | |
*** ekhugen_alt has quit IRC | 20:05 | |
*** patriciadomin has quit IRC | 20:05 | |
*** mdrabe has quit IRC | 20:05 | |
*** Sukhdev has joined #openstack-nova | 20:05 | |
*** Apoorva_ has joined #openstack-nova | 20:08 | |
*** crushil has quit IRC | 20:08 | |
*** Apoorva_ has quit IRC | 20:09 | |
openstackgerrit | Eric Fried proposed openstack/nova master: nova.utils.get_service_url() https://review.openstack.org/458257 | 20:09 |
*** Apoorva_ has joined #openstack-nova | 20:09 | |
*** mdrabe has joined #openstack-nova | 20:09 | |
*** patriciadomin has joined #openstack-nova | 20:09 | |
*** ekhugen has joined #openstack-nova | 20:09 | |
*** ekhugen_alt has joined #openstack-nova | 20:10 | |
*** egarbade has joined #openstack-nova | 20:10 | |
*** Apoorva_ has quit IRC | 20:10 | |
*** egarbade is now known as Guest51738 | 20:10 | |
*** Apoorva_ has joined #openstack-nova | 20:10 | |
efried | mriedem mordred os-service-types didn't get released last week. If it gets released soon, is it too late to get it through and use it in nova for pike? | 20:10 |
*** Apoorva has quit IRC | 20:11 | |
mriedem | efried: i haven't reviewed the nova code so can't really say what the risk is, or if this is all disabled by default and then people have to opt-in, or what | 20:11 |
efried | mriedem I was about to crank back up on the nova side, now that all the ksa stuff has landed. But one of the main pieces I need is os-service-types. If I can't have that, I'm going to have to basically inline a bunch of it. | 20:12 |
efried | mriedem os-service-types is brand new, so there's no risk of breaking backward compatibility or whatever. | 20:13 |
efried | mriedem It'll be a brand new dep, for whatever that means. | 20:13 |
*** mgiles has quit IRC | 20:16 | |
*** mgiles has joined #openstack-nova | 20:17 | |
*** mgiles has quit IRC | 20:19 | |
*** mgiles has joined #openstack-nova | 20:19 | |
*** randomhack has quit IRC | 20:22 | |
*** jwcroppe has joined #openstack-nova | 20:24 | |
mriedem | edleafe: so let's hold off on the alternatives stuff for pike, it's too high risk at this point in the schedule, we'll work on that for queens. it means you can't do multi-tier multi-cell with retries, but if you don't care about retries, like CERN, then you're still golden for pike. | 20:27 |
mriedem | edleafe: so focus on the ironic flavor migration stuff for pike | 20:28 |
edleafe | mriedem: ok | 20:30 |
*** baoli has quit IRC | 20:31 | |
*** mgiles has quit IRC | 20:35 | |
*** mgiles has joined #openstack-nova | 20:35 | |
*** mgiles has quit IRC | 20:37 | |
*** mgiles has joined #openstack-nova | 20:38 | |
*** kristian__ has joined #openstack-nova | 20:40 | |
*** jdurgin has quit IRC | 20:41 | |
*** baoli has joined #openstack-nova | 20:44 | |
*** kristian__ has quit IRC | 20:44 | |
*** baoli has quit IRC | 20:45 | |
*** baoli has joined #openstack-nova | 20:45 | |
*** eharney has quit IRC | 20:47 | |
*** crushil has joined #openstack-nova | 20:48 | |
*** kristian__ has joined #openstack-nova | 20:50 | |
*** burt has quit IRC | 20:52 | |
*** annegentle has joined #openstack-nova | 20:54 | |
*** mgiles has quit IRC | 21:00 | |
*** mgiles has joined #openstack-nova | 21:01 | |
*** cleong has quit IRC | 21:01 | |
*** edmondsw has quit IRC | 21:04 | |
openstackgerrit | Jeroen van Bemmel proposed openstack/nova master: Closes-Bug: 1702475 https://review.openstack.org/486753 | 21:04 |
openstack | bug 1702475 in OpenStack Compute (nova) "IPv6 data missing from latest/metadata info" [Medium,Confirmed] https://launchpad.net/bugs/1702475 | 21:04 |
*** edmondsw has joined #openstack-nova | 21:04 | |
*** crushil has quit IRC | 21:05 | |
openstackgerrit | Jeroen van Bemmel proposed openstack/nova master: Closes-Bug: 1702475 https://review.openstack.org/486753 | 21:05 |
*** armax has quit IRC | 21:05 | |
*** edmondsw_ has joined #openstack-nova | 21:05 | |
*** crushil has joined #openstack-nova | 21:08 | |
*** edmondsw has quit IRC | 21:09 | |
*** yamamoto_ has joined #openstack-nova | 21:09 | |
*** crushil has quit IRC | 21:10 | |
*** edmondsw_ has quit IRC | 21:10 | |
*** crushil has joined #openstack-nova | 21:10 | |
*** jmlowe has quit IRC | 21:11 | |
*** cdent has joined #openstack-nova | 21:12 | |
*** baoli has quit IRC | 21:15 | |
*** crushil has quit IRC | 21:16 | |
*** baoli has joined #openstack-nova | 21:16 | |
*** crushil has joined #openstack-nova | 21:18 | |
*** MVenesio has quit IRC | 21:19 | |
*** smatzek has quit IRC | 21:20 | |
*** yamamoto_ has quit IRC | 21:20 | |
*** baoli has quit IRC | 21:20 | |
*** crushil has quit IRC | 21:21 | |
*** jwcroppe has quit IRC | 21:26 | |
*** crushil has joined #openstack-nova | 21:26 | |
*** mvk has joined #openstack-nova | 21:28 | |
*** crushil has quit IRC | 21:28 | |
*** baoli has joined #openstack-nova | 21:28 | |
*** jdurgin has joined #openstack-nova | 21:29 | |
openstackgerrit | Merged openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | 21:31 |
mriedem | cdent: the thing that your wsgi-intercept patch failed on failed in another unrelated change http://logs.openstack.org/02/485602/6/check/gate-nova-tox-functional-ubuntu-xenial/edf4c41/testr_results.html.gz | 21:32 |
mriedem | so probably just some new fun | 21:32 |
cdent | le sigh | 21:32 |
*** jwcroppe has joined #openstack-nova | 21:32 | |
cdent | i have the OSAPIFixture using wsgi-intercept in progress | 21:32 |
cdent | I might stack them and see if that gets us anywhere | 21:33 |
*** Apoorva_ has quit IRC | 21:34 | |
*** Apoorva has joined #openstack-nova | 21:34 | |
*** crushil has joined #openstack-nova | 21:38 | |
*** cdent has quit IRC | 21:38 | |
*** edmondsw has joined #openstack-nova | 21:39 | |
*** awaugama has quit IRC | 21:39 | |
*** crushil has quit IRC | 21:40 | |
*** baoli has quit IRC | 21:41 | |
*** crushil has joined #openstack-nova | 21:41 | |
*** jwcroppe has quit IRC | 21:42 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Migrate Ironic Flavors https://review.openstack.org/484949 | 21:42 |
*** crushil has quit IRC | 21:43 | |
*** edmondsw has quit IRC | 21:44 | |
*** crushil has joined #openstack-nova | 21:44 | |
*** jwcroppe has joined #openstack-nova | 21:45 | |
*** esberglu has quit IRC | 21:46 | |
*** Apoorva has quit IRC | 21:47 | |
*** crushil has quit IRC | 21:48 | |
*** Apoorva has joined #openstack-nova | 21:48 | |
*** crushil has joined #openstack-nova | 21:49 | |
*** jmlowe has joined #openstack-nova | 21:50 | |
*** crushil has quit IRC | 21:50 | |
mriedem | think i know what's causing the spike in the functional tests failing | 21:51 |
mriedem | https://review.openstack.org/#/c/484154/2/nova/tests/functional/api/openstack/placement/gabbits/resource-class-in-use.yaml | 21:51 |
mriedem | i think we have gabbits racing that work against the same custom resource class | 21:52 |
*** chyka has quit IRC | 21:52 | |
*** chyka has joined #openstack-nova | 21:52 | |
*** marst has quit IRC | 21:52 | |
dansmith | they use the same db instance in parallel? | 21:52 |
mriedem | creating the same custom resource class, | 21:52 |
mriedem | in one case it already exists i think so it returns 204 | 21:53 |
mriedem | which fails the assertion for a 201 | 21:53 |
mriedem | https://bugs.launchpad.net/nova/+bug/1706207 | 21:53 |
openstack | Launchpad bug 1706207 in OpenStack Compute (nova) "resource-class-in-use_delete_resource_class fails with "AssertionError: '404' not found in ['204']" since 7/22" [High,Confirmed] | 21:53 |
dansmith | oh, the same placement fixture I guess? | 21:54 |
mriedem | yeah | 21:54 |
dansmith | I see | 21:54 |
*** xyang1 has quit IRC | 21:54 | |
*** armax has joined #openstack-nova | 21:56 | |
mriedem | although these tests should be using isolated sqlite dbs | 21:57 |
mriedem | so i'm not sure why this should happen | 21:57 |
*** mgiles has quit IRC | 21:59 | |
*** felipemonteiro_ has quit IRC | 22:00 | |
mriedem | "On a successful create return 201. Return 204 if the class already | 22:00 |
mriedem | exists." | 22:00 |
mriedem | not sure why the test is doing a PUT instead of a POST | 22:00 |
mriedem | i guess because the PUT handles both cases | 22:01 |
openstackgerrit | Dan Smith proposed openstack/nova master: Migrate Ironic Flavors https://review.openstack.org/484949 | 22:01 |
*** yamamoto has joined #openstack-nova | 22:01 | |
dansmith | jaypipes: can haz: https://review.openstack.org/#/c/484949 | 22:01 |
dansmith | mriedem: well, I thought you meant we're hitting the wrong fixture | 22:02 |
dansmith | like starting two but always hitting the first one from the tests or something | 22:02 |
*** itlinux has quit IRC | 22:04 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add tags to instance.create Notification https://review.openstack.org/459493 | 22:05 |
*** esberglu has joined #openstack-nova | 22:05 | |
dansmith | mriedem: I'll fix that since I have it open | 22:06 |
openstackgerrit | Dan Smith proposed openstack/nova master: Migrate Ironic Flavors https://review.openstack.org/484949 | 22:06 |
jaypipes | dansmith: done | 22:07 |
dansmith | jaypipes: thanks | 22:07 |
jaypipes | pas de probleme | 22:08 |
dansmith | "done" about sums it up for me too | 22:08 |
mriedem | https://review.openstack.org/#/c/459493/ closes out the searchlight notifications bp | 22:08 |
jaypipes | heh | 22:08 |
*** esberglu has quit IRC | 22:10 | |
*** jgriffith has quit IRC | 22:10 | |
*** jgriffith has joined #openstack-nova | 22:10 | |
openstackgerrit | Merged openstack/nova master: doc: Populate the 'configuration' section https://review.openstack.org/478473 | 22:12 |
*** jgriffith has quit IRC | 22:12 | |
openstackgerrit | Merged openstack/nova master: doc: Populate the 'contributor' section https://review.openstack.org/478474 | 22:12 |
openstackgerrit | Merged openstack/nova master: doc: Populate the 'reference' section https://review.openstack.org/478484 | 22:13 |
*** kylek3h has quit IRC | 22:13 | |
*** fragatin_ has joined #openstack-nova | 22:14 | |
mriedem | so there is one other set of gabbits that create a CUSTOM_GOLD resource class | 22:14 |
mriedem | but they both use the APIFixture which creates separate db fixtures | 22:15 |
mriedem | so i'm not sure how those would overlap | 22:15 |
mriedem | unless it's eventlet again | 22:15 |
*** jgriffith has joined #openstack-nova | 22:15 | |
*** jgriffith has quit IRC | 22:16 | |
*** fragatina has quit IRC | 22:18 | |
mriedem | when this failed, both tests were running on the same process | 22:18 |
mriedem | so maybe | 22:18 |
*** jgriffith has joined #openstack-nova | 22:19 | |
*** jgriffith has quit IRC | 22:19 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use different resource class for resource-class-in-use tests https://review.openstack.org/486782 | 22:22 |
mriedem | see if you can stomach this ^ | 22:22 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Use different resource class for resource-class-in-use tests https://review.openstack.org/486782 | 22:23 |
*** jgriffith has joined #openstack-nova | 22:23 | |
openstackgerrit | Merged openstack/nova master: doc: Populate the 'user' section https://review.openstack.org/478475 | 22:25 |
openstackgerrit | Merged openstack/nova master: Update ironic feature matrix https://review.openstack.org/486148 | 22:25 |
*** gouthamr has quit IRC | 22:27 | |
mriedem | melwitt: simple issue in https://review.openstack.org/#/c/410946/ | 22:31 |
*** acormier has quit IRC | 22:31 | |
mriedem | and then i'll +2 before dansmith is completely out | 22:31 |
*** jaypipes has quit IRC | 22:32 | |
*** acormier has joined #openstack-nova | 22:32 | |
dansmith | mriedem: worth trying that rc change right? | 22:32 |
dansmith | mriedem: jay is out so unless melwitt responds soon and is willing, we might as well slam that in | 22:33 |
mriedem | i'll update it | 22:34 |
dansmith | mriedem: I mean your resource class gabbit thing | 22:34 |
mriedem | oh | 22:34 |
mriedem | yes it's worth trying | 22:34 |
mriedem | won't hurt | 22:34 |
mriedem | slamaro | 22:34 |
mriedem | *slamaroo | 22:34 |
dansmith | slamaroo'd | 22:35 |
*** acormier has quit IRC | 22:36 | |
mriedem | rebuild reno for the quotas change and then will push that up | 22:36 |
mriedem | *rebuilding | 22:37 |
cfriesen | what will be the ordering of steps when adding a new cellsv2 cell? create the new cell in the central DB and then start up the services or vice versa? | 22:37 |
*** jwcroppe has quit IRC | 22:37 | |
mriedem | create the cell first | 22:38 |
mriedem | and then start services within it | 22:39 |
mriedem | just like with the single cell case | 22:39 |
cfriesen | okay, that makes sense | 22:40 |
*** gouthamr has joined #openstack-nova | 22:42 | |
*** fragatin_ has quit IRC | 22:42 | |
cfriesen | mriedem: I guess we need the DB server for the new cell up and running before creating the new cell in nova | 22:43 |
*** fragatina has joined #openstack-nova | 22:43 | |
cfriesen | or at least we need to know what it will be | 22:43 |
*** jwcroppe has joined #openstack-nova | 22:44 | |
mriedem | yes | 22:46 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | 22:46 |
mriedem | because when you run nova-manage cell_v2 create_cell you need to specify the MQ and DB URLs for the new cell | 22:46 |
mriedem | which get inserted into the cell_mappings table in the nova_api db | 22:46 |
mriedem | dansmith: ^ addressed the comments in the quotas changetest_migrate_quota_limits | 22:47 |
mriedem | oops | 22:47 |
mriedem | https://review.openstack.org/410946 | 22:47 |
openstackgerrit | Gage Hugo proposed openstack/nova master: Admin API Policy contingent on is_admin_project https://review.openstack.org/384148 | 22:55 |
*** crushil has joined #openstack-nova | 22:57 | |
*** crushil has quit IRC | 23:01 | |
*** itlinux has joined #openstack-nova | 23:05 | |
*** Sukhdev has quit IRC | 23:05 | |
*** danpawlik has quit IRC | 23:06 | |
*** jwcroppe has quit IRC | 23:06 | |
*** itlinux has quit IRC | 23:10 | |
melwitt | mriedem, dansmith: thanks yall | 23:16 |
melwitt | I was at the dentist, being angry | 23:17 |
*** randomhack has joined #openstack-nova | 23:19 | |
*** catintheroof has quit IRC | 23:21 | |
*** randomhack has quit IRC | 23:23 | |
*** chyka has quit IRC | 23:26 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 23:28 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 23:29 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | 23:30 |
*** acormier has joined #openstack-nova | 23:33 | |
*** takashin has joined #openstack-nova | 23:34 | |
*** acormier has quit IRC | 23:37 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove the useless fake ExtensionManager from API unittests https://review.openstack.org/486416 | 23:38 |
*** rajathagasthya has quit IRC | 23:42 | |
*** coreywright has quit IRC | 23:42 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!