Tuesday, 2017-07-25

*** coreywright has joined #openstack-nova00:00
*** chyka has joined #openstack-nova00:01
*** sree__ has joined #openstack-nova00:03
*** thorst_afk has quit IRC00:03
*** rajathagasthya has joined #openstack-nova00:04
*** sree__ has quit IRC00:07
*** chyka has quit IRC00:09
*** jwcroppe has joined #openstack-nova00:14
*** gmann has quit IRC00:14
*** gmann has joined #openstack-nova00:14
*** tbachman has quit IRC00:16
*** tbachman has joined #openstack-nova00:20
*** sdague has quit IRC00:21
*** annegentle has quit IRC00:24
*** acormier has joined #openstack-nova00:27
*** acormier has quit IRC00:28
*** acormier has joined #openstack-nova00:29
*** jwcroppe has quit IRC00:32
*** baoli has joined #openstack-nova00:34
*** mtanino has quit IRC00:35
*** eswenson has joined #openstack-nova00:37
*** eswenson has left #openstack-nova00:38
*** baoli has quit IRC00:38
openstackgerritTakashi NATSUME proposed openstack/nova master: Stop using mox stubs in cast_as_call.py  https://review.openstack.org/47773000:40
*** mdnadeem has joined #openstack-nova00:41
*** itlinux has joined #openstack-nova00:45
*** fragatina has quit IRC00:45
*** rajathagasthya has quit IRC00:46
*** fragatina has joined #openstack-nova00:46
*** chyka has joined #openstack-nova00:46
*** catintheroof has joined #openstack-nova00:47
*** fragatin_ has joined #openstack-nova00:49
*** fragatin_ has quit IRC00:50
*** fragatina has quit IRC00:50
*** fragatin_ has joined #openstack-nova00:50
*** chyka has quit IRC00:51
*** fragatin_ has quit IRC00:52
*** fragatina has joined #openstack-nova00:52
*** baoli has joined #openstack-nova00:55
openstackgerritMerged openstack/nova master: Add tags to instance.create Notification  https://review.openstack.org/45949300:55
*** fragatina has quit IRC00:56
*** baoli has quit IRC00:59
*** tuanluong has joined #openstack-nova01:00
openstackgerritHironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume  https://review.openstack.org/21538501:02
*** phuongnh has joined #openstack-nova01:02
openstackgerritMerged openstack/nova master: Allow wrapping of closures  https://review.openstack.org/47980101:04
openstackgerritChris Dent proposed openstack/nova master: [placement] Flush RC_CACHE after each gabbit sequence  https://review.openstack.org/48680501:05
*** cdent has joined #openstack-nova01:07
cdentdansmith: if you’re still around, this is probably a better fix for that 201 204 problem: https://review.openstack.org/#/c/486805/01:08
cdent(I couldn’t sleep, got bored, read mail…)01:08
alex_xuoomichi: appreciate if you can take a look at https://review.openstack.org/#/c/486414/, that patch is the goal of pike01:08
*** Apoorva_ has joined #openstack-nova01:13
*** harlowja has quit IRC01:13
mriedemcdent: i'll drop mine once yours passes functional tests01:15
cdentmriedem: roger that01:15
*** Apoorva has quit IRC01:16
*** Apoorva_ has quit IRC01:17
*** catintheroof has quit IRC01:18
*** fragatina has joined #openstack-nova01:25
*** hshiina has joined #openstack-nova01:25
*** cdent has quit IRC01:26
*** fragatina has quit IRC01:29
*** cdent has joined #openstack-nova01:30
*** yufei has joined #openstack-nova01:32
openstackgerritMerged openstack/nova master: Migrate Ironic Flavors  https://review.openstack.org/48494901:32
*** lyan has quit IRC01:45
*** litao__ has joined #openstack-nova01:48
*** Shunli has joined #openstack-nova01:49
*** crushil has joined #openstack-nova01:50
*** baoli has joined #openstack-nova01:51
*** baoli has quit IRC01:56
*** dave-mccowan has joined #openstack-nova01:57
*** mamandle has joined #openstack-nova01:58
*** bkopilov_ has quit IRC01:59
*** bkopilov has quit IRC01:59
*** yamahata has quit IRC02:00
*** itlinux has quit IRC02:00
*** itlinux has joined #openstack-nova02:00
*** mamandle has quit IRC02:05
*** jwcroppe has joined #openstack-nova02:07
*** dave-mccowan has quit IRC02:07
openstackgerritMerged openstack/nova master: Add online migration to move quotas to API database  https://review.openstack.org/41094602:07
*** jwcroppe has quit IRC02:12
*** fragatina has joined #openstack-nova02:16
openstackgerritChris Dent proposed openstack/nova master: WIP: Using wsgi-intercept in OSAPIFixture  https://review.openstack.org/48682502:28
*** kristian__ has quit IRC02:29
openstackgerritChris Dent proposed openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture  https://review.openstack.org/48623702:29
*** kristian__ has joined #openstack-nova02:29
openstackgerritChris Dent proposed openstack/nova master: WIP: Using wsgi-intercept in OSAPIFixture  https://review.openstack.org/48682502:30
*** acormier_ has joined #openstack-nova02:33
*** gbarros has joined #openstack-nova02:33
*** fragatina has quit IRC02:34
*** kristian__ has quit IRC02:34
*** esberglu has joined #openstack-nova02:35
*** acormier has quit IRC02:36
*** baoli has joined #openstack-nova02:37
*** esberglu has quit IRC02:40
openstackgerritChris Dent proposed openstack/nova master: WIP: Optimize MiniDNS for fewer syscalls  https://review.openstack.org/48682902:40
*** baoli has quit IRC02:41
openstackgerritChris Dent proposed openstack/nova master: [placement] Update the placement deployment instructions  https://review.openstack.org/46904802:41
*** marst has joined #openstack-nova02:44
openstackgerritTony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt  https://review.openstack.org/47222902:44
openstackgerritTony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself.  https://review.openstack.org/45916602:44
openstackgerritTony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt  https://review.openstack.org/47222802:44
openstackgerritTony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py  https://review.openstack.org/48590702:44
openstackgerritTony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep.  https://review.openstack.org/47197202:44
openstackgerritTony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files  https://review.openstack.org/48683102:44
*** gouthamr has quit IRC02:46
*** fragatina has joined #openstack-nova02:55
openstackgerritChris Dent proposed openstack/nova master: WIP: Using wsgi-intercept in OSAPIFixture  https://review.openstack.org/48682502:56
*** jwcroppe has joined #openstack-nova02:57
openstackgerritHironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector  https://review.openstack.org/46835303:01
openstackgerritChris Dent proposed openstack/nova master: WIP: Optimize MiniDNS for fewer syscalls  https://review.openstack.org/48682903:01
*** acormier_ has quit IRC03:01
*** acormier has joined #openstack-nova03:02
*** lbragsta_ has joined #openstack-nova03:04
*** cdent has quit IRC03:05
*** acormier has quit IRC03:06
*** yushb has joined #openstack-nova03:07
*** gbarros has quit IRC03:10
*** fragatina has quit IRC03:12
*** chohoor has quit IRC03:13
*** bkopilov_ has joined #openstack-nova03:15
*** bkopilov has joined #openstack-nova03:15
*** vishwana_ has joined #openstack-nova03:19
*** vishwana_ has quit IRC03:19
*** randomhack has joined #openstack-nova03:19
*** vishwanathj has quit IRC03:22
*** fragatina has joined #openstack-nova03:23
*** kiennt has joined #openstack-nova03:24
*** yushb has quit IRC03:25
*** yushb has joined #openstack-nova03:26
*** randomhack has quit IRC03:26
*** chohoor has joined #openstack-nova03:29
TheJuliahshiina: looks like https://review.openstack.org/215385 is already in merge conflict again :(03:30
*** yushb has quit IRC03:30
*** hshiina has quit IRC03:41
*** yamamoto has quit IRC03:45
*** lbragsta_ has quit IRC03:48
*** armax has quit IRC03:52
openstackgerritJulia Kreger proposed openstack/nova master: Ironic: Support boot from Cinder volume  https://review.openstack.org/21538503:58
openstackgerritZhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API  https://review.openstack.org/48685003:58
*** yamamoto has joined #openstack-nova04:00
*** hshiina has joined #openstack-nova04:01
*** gbarros has joined #openstack-nova04:05
*** gbarros has quit IRC04:13
*** nicolasbock has joined #openstack-nova04:13
*** markvoelker has quit IRC04:14
openstackgerritNgo Quoc Cuong proposed openstack/nova master: Remove translation of log messages  https://review.openstack.org/46699504:17
*** esberglu has joined #openstack-nova04:23
*** esberglu has quit IRC04:28
*** links has joined #openstack-nova04:30
*** dikonoor has joined #openstack-nova04:33
*** thorst_afk has joined #openstack-nova04:38
*** thorst_afk has quit IRC04:43
*** diga has joined #openstack-nova04:45
openstackgerritMerged openstack/nova master: request_log addition for running under uwsgi  https://review.openstack.org/48560204:47
*** sree_ has joined #openstack-nova04:54
*** sree_ is now known as Guest8138104:54
*** Guest81381 has quit IRC04:55
*** jaypipes has joined #openstack-nova04:56
*** prateek has joined #openstack-nova05:12
*** dikonoor has quit IRC05:16
openstackgerritsudhir agarwal proposed openstack/nova master: Replaces uuid.uuid4 with uuidutils.generate_uuid()  https://review.openstack.org/48100705:17
*** jjung has joined #openstack-nova05:18
*** diga has quit IRC05:22
*** diga has joined #openstack-nova05:25
*** sridharg has joined #openstack-nova05:26
*** ratailor has joined #openstack-nova05:29
*** jwcroppe has quit IRC05:30
*** josecastroleon has joined #openstack-nova05:30
*** josecastroleon1 has quit IRC05:30
*** itlinux has quit IRC05:31
*** dikonoor has joined #openstack-nova05:31
*** josecastroleon has quit IRC05:34
*** kristian__ has joined #openstack-nova05:34
*** psachin has joined #openstack-nova05:36
*** randomhack has joined #openstack-nova05:38
*** ekuris has joined #openstack-nova05:38
*** kristian__ has quit IRC05:38
*** sree_ has joined #openstack-nova05:40
*** sree_ is now known as Guest6001805:41
*** randomhack has quit IRC05:42
*** yamahata has joined #openstack-nova05:42
*** trinaths has joined #openstack-nova05:44
*** moshele has joined #openstack-nova05:46
*** kiennt has quit IRC05:46
*** josecastroleon has joined #openstack-nova05:51
*** jjung_ has joined #openstack-nova05:58
*** kiennt has joined #openstack-nova06:03
*** rcernin has joined #openstack-nova06:10
*** esberglu has joined #openstack-nova06:11
*** udesale has joined #openstack-nova06:13
*** markvoelker has joined #openstack-nova06:15
*** esberglu has quit IRC06:16
openstackgerritTony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt  https://review.openstack.org/47222906:17
openstackgerritTony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself.  https://review.openstack.org/45916606:17
openstackgerritTony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt  https://review.openstack.org/47222806:17
openstackgerritTony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py  https://review.openstack.org/48590706:17
openstackgerritTony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep.  https://review.openstack.org/47197206:17
openstackgerritTony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files  https://review.openstack.org/48683106:17
openstackgerritZhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API  https://review.openstack.org/48685006:20
*** andreas_s has joined #openstack-nova06:22
*** bkopilov has quit IRC06:24
trinathshi, I'm using nova (mitaka) compute. when I spawn a VM, it will auto shutoff after 10 minutes. and at qemu logs, it was the error:  2017-07-25T00:52:49.334691Z qemu-system-aarch64: Failed initializing vhost-user memory map, consider using -object memory-backend-file share=on06:30
trinathsqemu-system-aarch64: /root/qemu/hw/virtio/vhost.c:1186: vhost_virtqueue_mask: Assertion `vdev->use_guest_notifier_mask' failed. Please help me in resolving this issue.06:30
openstackgerritTony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt  https://review.openstack.org/47222906:33
*** amuresan has joined #openstack-nova06:34
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time  https://review.openstack.org/46595406:37
*** kristian__ has joined #openstack-nova06:38
*** thorst_afk has joined #openstack-nova06:39
*** kiennt has quit IRC06:41
*** belmoreira has joined #openstack-nova06:44
*** thorst_afk has quit IRC06:44
*** jamesden_ has quit IRC06:47
*** kristian__ has quit IRC06:48
*** jamesdenton has joined #openstack-nova06:48
*** kristian__ has joined #openstack-nova06:49
*** markvoelker has quit IRC06:49
*** tiendc has joined #openstack-nova06:50
*** kristian__ has quit IRC06:53
openstackgerritTony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt  https://review.openstack.org/47222906:54
openstackgerritTony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself.  https://review.openstack.org/45916606:54
openstackgerritTony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt  https://review.openstack.org/47222806:54
openstackgerritTony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py  https://review.openstack.org/48590706:54
openstackgerritTony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep.  https://review.openstack.org/47197206:54
openstackgerritTony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files  https://review.openstack.org/48683106:54
*** kristian__ has joined #openstack-nova06:57
*** danpawlik has joined #openstack-nova06:58
*** josecastroleon has quit IRC06:58
*** alexchadin has joined #openstack-nova06:59
*** josecastroleon has joined #openstack-nova07:06
*** sshwarts has joined #openstack-nova07:19
*** hferenc has quit IRC07:19
*** hferenc has joined #openstack-nova07:21
*** kiennt has joined #openstack-nova07:23
*** markus_z has joined #openstack-nova07:26
*** avolkov has quit IRC07:31
*** avolkov has joined #openstack-nova07:31
*** hferenc has quit IRC07:32
*** chohoor has quit IRC07:33
*** hferenc has joined #openstack-nova07:38
*** damien_r has joined #openstack-nova07:43
*** josecastroleon has quit IRC07:45
*** markvoelker has joined #openstack-nova07:46
openstackgerritHironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector  https://review.openstack.org/46835307:47
*** josecastroleon has joined #openstack-nova07:51
*** josecastroleon has quit IRC07:52
*** josecastroleon has joined #openstack-nova07:54
*** ralonsoh has joined #openstack-nova07:54
*** claudiub has joined #openstack-nova07:55
*** josecastroleon has quit IRC07:56
*** ralonsoh has quit IRC07:59
*** efoley has joined #openstack-nova08:00
*** josecastroleon1 has joined #openstack-nova08:03
openstackgerritRawan Herzallah proposed openstack/nova master: Adding NVMEoF for libvirt driver  https://review.openstack.org/48264008:03
*** aarefiev_afk is now known as aarefiev08:05
*** ralonsoh has joined #openstack-nova08:06
*** josecastroleon has joined #openstack-nova08:07
*** josecastroleon1 has quit IRC08:07
openstackgerritZhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API  https://review.openstack.org/48685008:07
*** derekh has joined #openstack-nova08:10
*** josecastroleon has quit IRC08:13
jangutterHi, there are two patches left for netronome-smartnic-enablement. Would anyone have cycles to leave comments? 50 lines of code, 300 lines of tests, many litres of blood. https://review.openstack.org/#/c/486426/ and https://review.openstack.org/#/c/483459/08:15
*** jhesketh has joined #openstack-nova08:16
*** ralonsoh has quit IRC08:16
*** ralonsoh has joined #openstack-nova08:16
jangutterFor that matter, Mellanox's got a similar patch: https://review.openstack.org/#/c/398265/08:16
*** randomhack has joined #openstack-nova08:19
*** markvoelker has quit IRC08:20
*** mamandle has joined #openstack-nova08:22
*** jjung has quit IRC08:22
*** jhesketh_ has joined #openstack-nova08:22
*** jjung_ has quit IRC08:22
*** lucas-afk is now known as lucasagomes08:23
*** randomhack has quit IRC08:23
*** josecastroleon has joined #openstack-nova08:24
*** jhesketh has quit IRC08:25
*** johnhaan has joined #openstack-nova08:26
*** josecastroleon has quit IRC08:29
*** jhesketh_ is now known as jhesketh08:30
*** yamamoto has quit IRC08:33
*** roeyc has joined #openstack-nova08:35
*** priteau has joined #openstack-nova08:36
*** jjung_ has joined #openstack-nova08:38
*** jjung has joined #openstack-nova08:39
*** thorst_afk has joined #openstack-nova08:40
*** _pewp_ has quit IRC08:40
openstackgerritArtem Tiumentcev proposed openstack/nova-specs master: SPEC: nova disk quota tracking  https://review.openstack.org/48694708:42
*** _pewp_ has joined #openstack-nova08:44
*** thorst_afk has quit IRC08:45
*** yamamoto has joined #openstack-nova08:46
openstackgerritTony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt  https://review.openstack.org/47222908:49
*** yamamoto has quit IRC08:50
*** esberglu has joined #openstack-nova08:53
*** yamamoto has joined #openstack-nova08:57
*** esberglu has quit IRC08:57
*** yamahata has quit IRC09:00
kashyapmdbooth: Thanks for the review here: https://review.openstack.org/#/c/485752/09:01
kashyapmdbooth: Test - I will fix, that's also why I -1ed it myself.09:01
kashyapmdbooth: But the core change itself is working; the downstream bug reporter has tested the fix and confirmed that they don't see the perf regression anymore with this fix09:01
*** yamamoto has quit IRC09:05
*** yamamoto has joined #openstack-nova09:11
*** markvoelker has joined #openstack-nova09:17
mdboothkashyap: Yeah, I said it looked good :)09:18
mdboothExcept for the bits which didn't, but you can sort those easily enough.09:18
kashyapmdbooth: Sure, did notice your remark.  :-)09:18
kashyapmdbooth: The bits which didn't are - (a) missing tests; (b) adding in the config line that accidentally removed09:19
kashyapAnything else you noticed?09:19
mdboothNope.09:19
mdboothThe code structure is kinda ugly, but sahid already noted that09:20
openstackgerritAlexandru Muresan proposed openstack/nova master: Ensure that vif ports are unplugged during cold migration  https://review.openstack.org/48695509:20
kashyapmdbooth: There's a comment from Sahid?  I don't even see it, /me refreshes the URL09:22
mdboothNot a review comment09:22
kashyapMaybe you mean in the code09:22
kashyapYeah, noted.09:22
mdboothA code comment from the distant past09:22
kashyapYep09:23
*** mvk has quit IRC09:25
openstackgerritZhenyu Zheng proposed openstack/nova master: Add tags fields for server list detail/show api-ref  https://review.openstack.org/46584209:25
*** yamamoto has quit IRC09:28
*** Shunli has quit IRC09:29
openstackgerritRikimaru Honjo proposed openstack/nova master: compute: Sweep duplicated bdm records  https://review.openstack.org/29079309:31
openstackgerritBéla Vancsics proposed openstack/nova master: Transform instance.resize_confirm notification  https://review.openstack.org/48255709:32
*** tiendc has quit IRC09:32
bauzasgabor_antal: gibi: about https://review.openstack.org/#/c/467514/7/nova/compute/api.py@4977 honestly my only concern was that I think "import" is probably not a great RESTful action09:36
*** yamamoto has joined #openstack-nova09:36
bauzasgabor_antal: gibi: cdent reminded me previously that a PUT can create or update with a body so in theory there should only be one notification of creation09:37
bauzasbut anyway, seems I'm nitpicking09:37
*** yamamoto has quit IRC09:40
*** yamamoto has joined #openstack-nova09:44
*** ralonsoh has quit IRC09:45
*** ralonsoh has joined #openstack-nova09:45
bauzasgibi: btw. any notifications patches I could help to land before FF ?09:45
*** yamamoto has quit IRC09:48
*** _pewp_ has quit IRC09:48
*** markvoelker has quit IRC09:49
*** _pewp_ has joined #openstack-nova09:51
*** mvk has joined #openstack-nova09:54
*** kornicameister has quit IRC09:56
*** Guest60018 has quit IRC09:58
*** Drankis has joined #openstack-nova09:59
*** sdague has joined #openstack-nova09:59
*** kiennt has quit IRC10:04
*** sambetts|afk is now known as sambetts10:06
*** phuongnh has quit IRC10:08
*** konan_abhi has joined #openstack-nova10:08
*** dtantsur|afk is now known as dtantsur10:10
*** abhishek_k has quit IRC10:11
*** yamamoto has joined #openstack-nova10:13
*** konan_abhi has quit IRC10:15
*** rmart04 has joined #openstack-nova10:16
*** abhishekk has joined #openstack-nova10:17
*** openstackgerrit has quit IRC10:17
*** openstackgerrit has joined #openstack-nova10:18
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2``  https://review.openstack.org/48438610:18
*** gszasz has joined #openstack-nova10:19
*** alexchadin has quit IRC10:22
*** cdent has joined #openstack-nova10:22
*** thorst_afk has joined #openstack-nova10:24
gibibauzas: hi! thanks for the feedback. I don't have direct user feedback so I cannot say for sure that we need import in the notification but it feels useful for me10:29
bauzascools10:29
gibibauzas: for patches to help in, I see on patch that needs a second +2 https://review.openstack.org/#/c/480984/10:31
gibibauzas: besides that we have a list of patches that looks good from subteam perspective (and has +1) here https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/versioned-notification-transformation-pike+label:Code-Review%253E%253D%252B1+label:Verified%253E%253D1+AND+NOT+label:Verified%253C0+AND+NOT+label:Code-Review%253C010:31
* gibi still has to send the weekly notification focus mail10:32
*** dikonoor has quit IRC10:33
openstackgerritGábor Antal proposed openstack/nova master: Transform HostAPI-set_enabled notifications  https://review.openstack.org/48262210:34
gibibauzas: any help is appreciated10:34
*** jjung_ has quit IRC10:37
*** jjung has quit IRC10:37
bauzasgibi: going out for lunch but will review those afterwards10:38
openstackgerritMerged openstack/nova master: Remove check_detach  https://review.openstack.org/44667110:40
gibibauzas: enjoy for lunch, I just brought mine in the meantime10:43
*** markvoelker has joined #openstack-nova10:46
gibis/for/your/10:49
openstackgerritAlexandra Settle proposed openstack/nova master: doc: Rework index page per new sections  https://review.openstack.org/47848510:50
*** jjung has joined #openstack-nova10:51
*** jjung_ has joined #openstack-nova10:51
*** dikonoor has joined #openstack-nova10:52
*** bkopilov_ has quit IRC10:55
*** lucasagomes has quit IRC10:55
*** wachu has quit IRC10:58
*** dikonoor has quit IRC10:59
*** dikonoor has joined #openstack-nova11:03
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896411:03
*** dinesh_ has joined #openstack-nova11:06
*** yassine has joined #openstack-nova11:06
*** dinesh_ has left #openstack-nova11:06
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896411:09
*** mdnadeem has quit IRC11:10
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action  https://review.openstack.org/41004211:14
*** dikonoor has quit IRC11:15
*** markvoelker has quit IRC11:20
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896411:21
*** mamandle has quit IRC11:23
ildikovstephenfin: hi11:25
ildikovstephenfin: I just wanted to ask whether you got a chance to check stvnoyes's answers here: https://review.openstack.org/#/c/463987/ to see whether they address your concerns?11:26
*** jjung_ has quit IRC11:27
*** jjung has quit IRC11:27
*** smatzek has joined #openstack-nova11:27
openstackgerritTakashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action  https://review.openstack.org/41004211:28
*** takashin has left #openstack-nova11:28
*** smatzek has quit IRC11:29
*** smatzek has joined #openstack-nova11:29
*** dikonoor has joined #openstack-nova11:29
*** mamandle has joined #openstack-nova11:30
*** baoli has joined #openstack-nova11:32
*** baoli has quit IRC11:32
*** baoli has joined #openstack-nova11:33
*** ralonsoh has quit IRC11:33
*** lucasagomes has joined #openstack-nova11:35
mamandlebauzas: https://review.openstack.org/#/c/483911/ needs a second +2, can you please take a look?11:38
openstackgerritIldiko Vancsa proposed openstack/nova master: WIP: Allow multi-attach in compute api  https://review.openstack.org/27104711:43
openstackgerritIldiko Vancsa proposed openstack/nova master: libvirt: Allow multiple volume attachments  https://review.openstack.org/26758711:43
*** danpawlik has quit IRC11:45
*** danpawlik has joined #openstack-nova11:47
*** alexchadin has joined #openstack-nova11:48
*** lbragsta_ has joined #openstack-nova11:51
*** zz9pzza has quit IRC11:53
*** amuresan has quit IRC11:53
*** zz9pzza has joined #openstack-nova11:54
*** alexchadin has quit IRC11:58
*** dikonoo has joined #openstack-nova11:59
*** pchavva has joined #openstack-nova12:00
*** dikonoor has quit IRC12:02
*** acormier has joined #openstack-nova12:04
*** litao__ has quit IRC12:05
*** tuanluong has quit IRC12:06
*** acormier has quit IRC12:08
*** alexchadin has joined #openstack-nova12:10
*** chohoor has joined #openstack-nova12:10
*** lbragsta_ has quit IRC12:12
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.openstack.org/47709112:12
mamandlestephenfin: can you please check https://review.openstack.org/#/c/483911/ , its waiting on another +2.12:14
*** markvoelker has joined #openstack-nova12:17
*** yamamoto has quit IRC12:18
*** jjung has joined #openstack-nova12:18
*** jjung_ has joined #openstack-nova12:18
*** tylerderosagrund has joined #openstack-nova12:18
*** tylerderosagrund has quit IRC12:19
*** tylerderosagrund has joined #openstack-nova12:19
*** tylerderosagrund has quit IRC12:19
*** tylerderosagrund has joined #openstack-nova12:19
openstackgerritMerged openstack/nova master: [placement] Flush RC_CACHE after each gabbit sequence  https://review.openstack.org/48680512:19
mriedemildikov: stephenfin is on vacation all week12:25
*** jwcroppe has joined #openstack-nova12:25
*** tylerderosagrund has quit IRC12:26
*** markvoelker has quit IRC12:26
*** gouthamr has joined #openstack-nova12:26
*** markvoelker has joined #openstack-nova12:26
*** links has quit IRC12:27
*** trinaths has quit IRC12:28
*** MVenesio has joined #openstack-nova12:28
s-deanHi, im a at a loss trying to get this working, this is a RPC problem right ? <class 'oslo_messaging.exceptions.MessagingTimeout'>12:30
*** jwcroppe has quit IRC12:30
sdaguecdent: so it looks like you got to the bottom of the fixture issue?12:30
sdaguethough we seem to be bouncing off a keystone issue12:30
cdentsdague: I _think_ so12:30
openstackgerritRawan Herzallah proposed openstack/nova master: Adding NVMEoF for libvirt driver  https://review.openstack.org/48264012:32
cdentI started working on the OSAPIFixture too, but something has introduced some painful slowness. not clear if it is just wsgi intercept itself, or some other weirdness12:32
*** lyan has joined #openstack-nova12:34
mriedemjaypipes: i think i'm going to mark this done for pike https://blueprints.launchpad.net/nova/+spec/placement-allocation-requests12:35
*** edmondsw has joined #openstack-nova12:36
*** yamamoto has joined #openstack-nova12:36
jaypipesmriedem: ack12:39
*** catintheroof has joined #openstack-nova12:39
*** catintheroof has quit IRC12:39
jaypipesmriedem: I'll update the spec12:39
*** catintheroof has joined #openstack-nova12:39
mriedemthank12:41
mriedems12:41
*** links has joined #openstack-nova12:43
*** sree has joined #openstack-nova12:43
*** sree_ has joined #openstack-nova12:48
*** sree_ is now known as Guest2193112:48
*** mamandle has quit IRC12:50
*** hshiina has quit IRC12:50
*** Guest21931 has quit IRC12:51
*** sree has quit IRC12:51
*** sree has joined #openstack-nova12:51
openstackgerritGábor Antal proposed openstack/nova master: use context mgr in instance.delete  https://review.openstack.org/44376412:51
*** yufei has quit IRC12:54
s-deanHi, could someone take a look at this log this is really weird. compute01 connects to rabbit, but throws this error. https://pastebin.com/ZbpJtBq812:55
bauzasjaypipes: I just thought about a possible problem with https://review.openstack.org/#/c/483566/1012:55
bauzasjaypipes: tl;dr how can we be sure that the first allocation request node is accepted by the filters ?12:55
*** esberglu has joined #openstack-nova12:55
*** abhishekk has quit IRC12:55
openstackgerritAlexandra Settle proposed openstack/nova master: doc: Rework index page per new sections  https://review.openstack.org/47848512:56
bauzasjaypipes: when we're getting a list of hosts after we run filters, we should possibly subset the alloc_reqs list to be only for accepted nodes, nope ?12:56
bauzasjaypipes: unless you're changing it somewhere and I'm blind12:56
*** acormier has joined #openstack-nova12:56
*** eharney has joined #openstack-nova12:58
*** ralonsoh has joined #openstack-nova12:58
*** felipemonteiro_ has joined #openstack-nova12:59
*** jwcroppe has joined #openstack-nova12:59
*** acormier has quit IRC13:00
*** acormier has joined #openstack-nova13:01
mriedemTheJulia: looks like CI for https://review.openstack.org/#/c/215385/ has passed using https://review.openstack.org/#/c/485812/ yes?13:02
mriedemalthough maybe not on the latest change?13:02
*** mgiles has joined #openstack-nova13:02
cdentsdague: is this nutbar or crazy pants or hmmm? https://review.openstack.org/#/c/486829/13:03
openstackgerritChris Dent proposed openstack/nova master: Use wsgi-intercept in OSAPIFixture  https://review.openstack.org/48682513:03
openstackgerritChris Dent proposed openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture  https://review.openstack.org/48623713:03
mriedemTheJulia: or are you testing here now? https://review.openstack.org/#/c/485349/13:04
bauzascdent: I'd be okay with wsgi-intercept but my concern goes with how many people are working for it13:04
cdentbauzas: the crazy pants question was about modify MiniDNS not wsgi-intercept.13:05
*** ralonsoh has quit IRC13:05
*** ralonsoh has joined #openstack-nova13:05
cdenton wsgi-intercept: we are already committed to using it because we are committed to using gabbi13:05
bauzascdent: I'm looking at its github page, and it means nova would have a dependency for a small package13:05
*** lucasxu has joined #openstack-nova13:05
cdentit’s had that dependency for over a year13:05
bauzascdent: sure, but gabbi looks pretty vibrant and I'm hoping it to have more contributors13:05
bauzascdent: do we use it elsewhere but in that fixture ?13:06
bauzasif so, nevermind my concern13:06
cdentin gabbi itself13:06
*** acormier has quit IRC13:06
sdaguecdent: that's just optimizing for the opens?13:06
bauzasa-ha, so a transitive dependency anyway13:06
cdentsdague: that, and for avoiding on disk files when CONF.log_dir is not set. I was doing an strace and so many lines of open and closing dnstest.txt13:07
*** rmart04_ has joined #openstack-nova13:07
openstackgerritAlexandra Settle proposed openstack/nova master: doc: Rework index page per new sections  https://review.openstack.org/47848513:07
sdagueyeh, that seems reasonable13:07
bauzascdent: any plan to push wsgi-intercept to for example openstack ?13:07
sdaguecdent: I kind of wonder whether the write to disk path is needed at all13:07
TheJuliamriedem: not ignoring you, presently debating a related grenade issue in another channel13:07
cdentbauzas: neither wsgi-intercept nor gabbi will come to openstack because a few of the other contributors _really_ do not want that13:08
*** rmart04 has quit IRC13:08
*** rmart04_ is now known as rmart0413:08
bauzascdent: that's understandable13:08
bauzaswell, if we already have that transitive dependency for gabbi, anyway...13:08
sdaguecdent: I remember seeing minidns spew a bunch in the past, and was always curious about getting it to stop that13:08
cdentsdague: I tried that, and what I found was there are few different tests where there are more than one dns manager (instance/floating ip) that are sharing the same data file13:09
mriedemTheJulia: np, take your time13:09
cdentsdague: and I didn’t have the horsepower to go digging to see if that could be changed13:09
cdentsdague: for most tests the in-memory thing is used13:10
*** prateek has quit IRC13:10
*** acormier has joined #openstack-nova13:12
*** yamamoto has quit IRC13:12
*** thorst_afk is now known as thorst13:13
mriedemTheJulia: found what i was looking for http://logs.openstack.org/49/485349/4/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/376d4dd/console.html#_2017-07-25_04_37_15_09437113:13
TheJuliamriedem: I do love how much faster test runs :)13:14
mriedem4 minutes is faster?13:14
TheJuliathis can cut a reboot out of the process of handing a ready machine off, so naturally much faster :)13:15
mriedemTheJulia: final questions when you get a moment are, i see some patches in flight on the ironic side, should we hold the nova change for those? or make the nova change depends-on them?13:16
mriedemlike https://review.openstack.org/#/c/484032/513:16
*** acormier has quit IRC13:16
*** randomhack has joined #openstack-nova13:17
*** mgiles has quit IRC13:19
dtantsurif jlvillal agrees, we can merge it now, and address the tests issues in a follow-up13:19
*** mgiles has joined #openstack-nova13:19
dtantsurI suspect this is the only in-flight patch that matters13:20
openstackgerritZhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API  https://review.openstack.org/48685013:20
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2``  https://review.openstack.org/48438613:21
TheJuliadtantsur: I already got agreement from him to do that last night :)13:22
*** mmehan has joined #openstack-nova13:22
*** dikonoo has quit IRC13:23
TheJuliadtantsur: well, agreement on the ironic patch :)13:23
dtantsurokie, let's wait for Sam's review, and Just Do It (tm)13:23
*** acormier_ has joined #openstack-nova13:25
TheJuliaExcellent!13:26
openstackgerritGábor Antal proposed openstack/nova master: Transform missing delete notifications  https://review.openstack.org/41029713:26
openstackgerritChris Dent proposed openstack/nova master: Optimize MiniDNS for fewer syscalls  https://review.openstack.org/48682913:26
*** kylek3h has joined #openstack-nova13:26
*** smatzek has quit IRC13:29
*** acormier_ has quit IRC13:30
s-deanHi, dont wana be a pest, any of you guys able to help me for 2 seconds ?13:31
*** baoli_ has joined #openstack-nova13:33
*** mamandle has joined #openstack-nova13:34
mriedemdtantsur: TheJulia: so i'm hearing we're good to go on the nova change then13:34
mriedemif so, i will hassle mr dague13:34
*** kristia__ has joined #openstack-nova13:34
*** baoli has quit IRC13:35
*** crushil has quit IRC13:35
*** kristian__ has quit IRC13:35
*** crushil has joined #openstack-nova13:35
jaypipesbauzas: alloc_reqs_by_rp_uuid is a map of compute node UUID to list of allocation requests13:36
dtantsuryeah, I suspect so13:36
dtantsurthe final word is for TheJulia though :)13:36
TheJuliaI think so13:38
*** alexchadin has quit IRC13:39
*** ratailor has quit IRC13:40
bauzasjaypipes: sure, but what if the first compute node UUID is not corresponding to the first host from the ones given by get_sorted_hosts() ?13:40
jaypipesbauzas: it's a dict...13:41
jaypipesbauzas: not sure what you're asking, sorry...13:41
bauzasjaypipes: oh sorry, just saw edleafe's comment13:42
bauzashttps://review.openstack.org/#/c/483566/10/nova/scheduler/filter_scheduler.py@20213:42
*** bkopilov_ has joined #openstack-nova13:42
bauzaswe're getting a list of allocation requests *per* compute node13:42
* bauzas facepalms13:42
*** ansiwen[q] has joined #openstack-nova13:43
jaypipesbauzas: right13:43
sdaguemriedem: what's up now?13:43
bauzasjaypipes: I was confused by your TODO in https://review.openstack.org/#/c/483566/10/nova/scheduler/filter_scheduler.py@27013:43
edleafebauzas: don't feel bad - I had to read that over several times before it made sense to me, too13:43
jaypipesbauzas: that alloc_reqs_by_rp_uuid is a dict, keyed by compute node UUID, of allocation requests that contain that compute node13:44
bauzasjaypipes: so the same compute node could have more than one allocation request ?13:44
bauzasjust tbc13:44
edleafebauzas: there could be several allocs for a given compute node. The TODO is about being smarter about picking which one to use13:44
bauzasthe real problem I had is that allocation_candidates just was discussed when I was in and out, and now I'm paying the price by giving you silly comments :/13:44
jaypipesbauzas: yep. imagine in the future, nested r-p's there may be dozens of allocation requests that partially allocate resources on the compute node.13:44
jaypipesbauzas: same with things like shared storage13:45
jaypipesbauzas: not a problem, don't worry about it.13:45
mriedemsdague: https://review.openstack.org/#/c/215385/13:45
bauzasjaypipes: ah, right13:45
bauzasnested RPs is understandable by me13:45
bauzasbecause you could consume more than one thing for a specific compute node13:46
bauzasah, and I see your point with shared storage13:46
jaypipesbauzas: so, imagine a compute host with 2 NUMA nodes and 4 PCI devices, affined to the different NUMA cells. We might potentially have a lot of allocation requests (candidates) for those child providers plus resources on the compute host itself (like VCPU, etc)13:46
*** rmart04 has quit IRC13:46
bauzaswe could potentially have the compute node having allocation request for local resources + shared resource ?13:46
*** rmart04_ has joined #openstack-nova13:46
jaypipesbauzas: yep13:46
bauzasjaypipes: that, I'm clear for nested RPs13:46
bauzasokay, nevermind all my comments then13:46
bauzasI'm on board now :)13:46
jaypipesbauzas: one alloc request might have local disk, another consuming from shared disk.13:46
sdaguemriedem: ah, that one. Approved13:47
jaypipesbauzas: of course, that's not currently possible, but you see the idea13:47
bauzasjaypipes: thanks for explaning it13:47
jaypipesno worries13:47
mriedemdtantsur: TheJulia: what is the story on https://review.openstack.org/#/c/468353/ ?13:48
mriedemrequired for pike?13:48
*** armax has joined #openstack-nova13:48
sdaguemelwitt: https://bugs.launchpad.net/nova/+bug/1706310 that's addressed by your new quota counting?13:49
openstackLaunchpad bug 1706310 in OpenStack Compute (nova) "Quota usage is not updated if an instance is deleted while booting" [Undecided,New]13:49
dtantsurmriedem: I think this is nice-to-have, but still optional13:49
*** crushil has quit IRC13:49
dtantsurI guess it may cause some longer discussions13:49
TheJuliamriedem: the consensus is not required this cycle, it just allows for greater use case flexibility ultimately shipping a source IP address off to cinder in the event there is firewalling present.13:49
bauzasjaypipes: +2d FTW13:50
sdaguemriedem: that one is a little less straight forward, and honestly probably a good ptg conversation13:50
sdagueit adds virt driver methods13:50
mriedemright i'd like to defer it13:50
sdaguemriedem: agreed13:51
TheJuliasdague: good point13:51
mriedemas something else - ironic bfv + network-managed storage13:51
*** ansiwen[q] has quit IRC13:51
jaypipesedleafe: I can clean those nits up later. at this point, I'm nervous about kicking off another gate recheck odyssey ;)13:51
cdentjaypipes: you might like these then: https://review.openstack.org/#/c/486237/13:52
edleafejaypipes: totally agree13:52
*** ansiwen[q] has joined #openstack-nova13:52
ildikovmriedem: oh ok, tnx for the info :)13:52
*** annegentle has joined #openstack-nova13:53
*** mgiles has quit IRC13:55
*** mgiles has joined #openstack-nova13:56
mriedemsdague: about that quota bug, yes counting quotas would address that, but also, it could already be a known issue fixed in ocata,13:56
mriedemthe reporter didn't say what version they were using13:56
mriedemi'm leaving comments13:56
*** annegentle has quit IRC13:59
*** crushil has joined #openstack-nova13:59
*** ansiwen[q] has quit IRC14:00
*** dtantsur is now known as dtantsur|brb14:01
*** radish_ has joined #openstack-nova14:02
*** radish_ has left #openstack-nova14:02
*** smatzek has joined #openstack-nova14:04
*** smatzek has quit IRC14:05
*** smatzek has joined #openstack-nova14:05
openstackgerritJan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver  https://review.openstack.org/48642614:06
*** mgiles_ has joined #openstack-nova14:09
openstackgerritJan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver  https://review.openstack.org/48642614:09
*** awaugama has joined #openstack-nova14:09
*** FL1SK has joined #openstack-nova14:10
*** coreywright has quit IRC14:11
*** diga has quit IRC14:11
mriedemsdague: the dependencies for the cells fleetify devstack change are all merged https://review.openstack.org/#/c/477556/14:11
mriedemsdague: thoughts on putting that in right now?14:12
*** mgiles has quit IRC14:12
mriedemor,14:12
mriedemmaybe i should run a novaclient change against it quick?14:12
dansmithdamn the torpedos14:12
mriedemi think it blew up novaclient functional ci on the first go around14:12
mriedemb/c it wasn't dependent on the quotas stuff14:12
mriedemand that job is single tenant14:12
*** acormier has joined #openstack-nova14:12
*** cdent has quit IRC14:12
mriedemi'll push a novaclient test change quick just to be sure14:13
dansmithcool14:14
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: DNM: test conductor fleet with single-tenant job  https://review.openstack.org/48709114:15
*** efoley has quit IRC14:15
*** efoley has joined #openstack-nova14:16
*** yamamoto has joined #openstack-nova14:17
*** mgiles_ has quit IRC14:20
*** mgiles has joined #openstack-nova14:20
*** mgiles has quit IRC14:22
*** rmart04_ has quit IRC14:22
*** mgiles has joined #openstack-nova14:23
*** coreywright has joined #openstack-nova14:23
*** mtanino has joined #openstack-nova14:24
*** yamamoto has quit IRC14:25
*** links has quit IRC14:26
*** mgiles has quit IRC14:29
*** mgiles has joined #openstack-nova14:29
*** claudiub has quit IRC14:30
*** marst has quit IRC14:32
*** eharney has quit IRC14:32
*** marst has joined #openstack-nova14:32
*** udesale has quit IRC14:33
*** mgiles has quit IRC14:36
*** mgiles has joined #openstack-nova14:36
*** lucasxu has quit IRC14:38
*** psachin has quit IRC14:40
*** marst has quit IRC14:41
openstackgerritJan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345914:43
openstackgerritSean Dague proposed openstack/nova master: Clean up second ephemeral disk  https://review.openstack.org/34100814:43
*** marst has joined #openstack-nova14:45
*** jjung has quit IRC14:46
*** jjung_ has quit IRC14:46
*** eharney has joined #openstack-nova14:47
*** marst has quit IRC14:48
*** sree_ has joined #openstack-nova14:48
*** sree_ is now known as Guest3563714:48
openstackgerritJay Pipes proposed openstack/nova master: hardware offload support for openvswitch  https://review.openstack.org/39826514:49
openstackgerritJan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345914:51
*** sree has quit IRC14:51
openstackgerritJan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345914:52
*** Guest35637 has quit IRC14:53
mriedemjangutter: question in https://review.openstack.org/#/c/486426/3/nova/virt/libvirt/vif.py14:54
*** sree has joined #openstack-nova14:54
janguttermriedem: let me see if the downstream code checks that. It hadn't occured to me to do input validation there!14:55
mriedemwell, one would probably never think to check it if only testing against a single configuratoin14:56
mriedem*configuration14:56
sdaguemriedem: we had to revert it once before right?14:56
sdaguemaybe an ironic issue14:56
mriedemsdague: yes, but for two issues,14:57
mriedem1. notifications14:57
sdagueif you all tell me it's good to go, I'm fine doing it14:57
mriedem2. it didn't depent on the quotas change14:57
mriedemsdague: i'm just running tests before we do14:57
sdaguesfinucan: https://bugs.launchpad.net/nova/+bug/1704458 that bug on your radar?14:57
openstackLaunchpad bug 1704458 in OpenStack Compute (nova) "The use_ipv6 flag not only influences nova networking" [Undecided,New]14:57
mriedemsdague: sfinucan is now stephenfin and stephenfin is out this week14:58
sdagueok14:58
dansmithsdague: ironic and notification issues are fixed, and quotas are merged so those are the things we knew about and reverted for before14:58
*** tylerderosagrund has joined #openstack-nova14:58
sdaguemriedem: ok, so run the test you want to run, then poke me when it's successful14:58
moshelemriedem: the generic is used in the old way https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L341-L343 so we can skip it for now14:58
dansmithack, thanks14:58
*** sree has quit IRC14:58
mriedemmoshele: what controls that getting called over the other?14:59
mriedemfor VIFHostDevice?14:59
moshelemriedem: the vif type that send from neutron15:00
janguttermriedem, moshele: VIFHostDevice isn't used anywhere _yet_, it's not too difficult to fix though.15:00
moshelemriedem: some code uses os-vif path, but most of it not15:00
*** prateek has joined #openstack-nova15:00
openstackgerritEric Fried proposed openstack/nova master: nova.utils.get_service_url()  https://review.openstack.org/45825715:00
janguttermoshele, mriedem: it amounts to adding an if that will prevent future idiots like me to plonk in potholes.15:01
mriedemmoshele: ok so a vif with type 'hostdev_physical' would go down that old path, but couldn't something on the neutron side start sending VIFHostDev with dev_type='generic'?15:01
mriedemjangutter: yes that's basically what i'm looking for15:01
moshelemriedem:  the nova code create it15:02
moshelemriedem: let me look for it15:02
mriedemmoshele: you mean this? https://review.openstack.org/#/c/483459/12/nova/network/os_vif_util.py15:02
mriedemL32315:03
moshelemriedem: yes15:03
janguttermriedem: good spot, I had forgotten "GENERIC" even existed.15:03
*** eharney has quit IRC15:03
mriedemok, i guess we should at least have some if check that raises an exception if dev_type isn't 'ethernet' or something15:04
moshelemriedem:  so either the vif type will work with the old way of get config or with the new os-vif15:04
mriedemso this doesn't fail in really weird ways15:04
*** jamesdenton has quit IRC15:04
*** jamesden_ has joined #openstack-nova15:04
moshelemriedem: we can and also a TODO comment to address generic when it will be use by os-vif15:05
mriedemsure15:06
mriedemjust something so we don't have to hunt in the weeds later15:07
*** sree has joined #openstack-nova15:07
mriedemjangutter: ^15:07
*** mamandle has quit IRC15:07
janguttermriedem: isn't this verified as os-vif level?15:07
janguttermriedem: https://github.com/openstack/os-vif/blob/master/os_vif/objects/fields.py#L6115:08
mriedemsdague: dansmith: novaclient functional single tenant job passed on the fleetify conductor patch, i'm just waiting for some experimental queue jobs to pass on it now15:08
mriedemlike cells v115:08
mriedemjangutter: that's not what i mean15:08
mriedemi meant in https://review.openstack.org/#/c/486426/3/nova/virt/libvirt/vif.py15:08
*** baoli_ has quit IRC15:09
mriedemif vif.dev_type != 'ethernet': raise some error,15:09
dansmithmriedem: swebster15:09
dansmithmriedem: er, sweet :)15:09
mriedemor just add a TODO as moshele said15:09
janguttermriedem: aaah, but I'm almost done adding the GENERIC! (I think....)15:09
mriedemok whatever floats your boat15:09
*** lifeless has quit IRC15:09
mgileslyarwood: It looks like you were the last person working on https://review.openstack.org/#/c/389798 but it's been a couple of months with no activity15:10
sdaguemriedem: sounds good15:10
mgileslyarwood Any objection if I take this over and fix up the tests to work with the latest codebase?15:10
mriedemmgiles: just take it over, lyarwood is on nova sabbatical15:10
janguttermriedem: GENERIC == designer.set_vif_host_backend_hostdev_pci_config15:10
mgilesmriedem thanks for the info15:11
mriedemjangutter: yeah just like this https://github.com/openstack/nova/blob/master/nova/virt/libvirt/vif.py#L341-L34315:11
mriedemjangutter: that's easy then15:11
janguttermriedem: more effort to write the comment than the code.15:11
*** chyka has joined #openstack-nova15:12
*** mgiles has quit IRC15:15
*** mgiles has joined #openstack-nova15:15
*** tbachman has quit IRC15:16
*** yassine has quit IRC15:16
*** tbachman has joined #openstack-nova15:17
*** rcernin has quit IRC15:17
openstackgerritMerged openstack/nova master: Ironic: Support boot from Cinder volume  https://review.openstack.org/21538515:18
*** eharney has joined #openstack-nova15:19
*** moshele has quit IRC15:20
*** yamahata has joined #openstack-nova15:21
*** lifeless has joined #openstack-nova15:22
*** Drankis has quit IRC15:22
*** vishwanathj has joined #openstack-nova15:24
*** mgiles has quit IRC15:26
*** mgiles has joined #openstack-nova15:27
openstackgerritEric Fried proposed openstack/nova master: Trim the fat from InstanceInfo  https://review.openstack.org/47114615:27
*** sree has quit IRC15:27
*** sree has joined #openstack-nova15:28
*** smatzek has quit IRC15:29
*** lifeless has quit IRC15:29
*** smatzek has joined #openstack-nova15:30
*** marst has joined #openstack-nova15:30
*** felipemonteiro__ has joined #openstack-nova15:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Use enum value instead of string service name  https://review.openstack.org/47653815:32
openstackgerritBalazs Gibizer proposed openstack/nova master: rename binary to source in versioned notifications  https://review.openstack.org/48712615:32
*** andreas_s has quit IRC15:32
*** sree has quit IRC15:33
*** tylerderosagrund has quit IRC15:33
*** felipemonteiro_ has quit IRC15:34
*** jwcroppe has quit IRC15:34
*** tylerderosagrund has joined #openstack-nova15:35
*** lifeless has joined #openstack-nova15:36
*** vishwanathj has quit IRC15:36
*** baoli has joined #openstack-nova15:36
openstackgerritBalazs Gibizer proposed openstack/nova master: Use enum value instead of string service name  https://review.openstack.org/47653815:37
openstackgerritBalazs Gibizer proposed openstack/nova master: rename binary to source in versioned notifications  https://review.openstack.org/48712615:37
*** vishwanathj has joined #openstack-nova15:37
openstackgerritSean Dague proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable  https://review.openstack.org/48662315:38
openstackgerritSean Dague proposed openstack/nova master: Suppress some test warnings  https://review.openstack.org/48670015:39
mriedemsdague: see my questions in https://review.openstack.org/#/c/486623/1/nova/conf/wsgi.py@54 ?15:39
*** felipemonteiro__ has quit IRC15:39
openstackgerritRobert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver.  https://review.openstack.org/48580315:42
*** MVenesio has quit IRC15:42
*** annegentle has joined #openstack-nova15:45
*** belmoreira has quit IRC15:45
openstackgerritBalazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref  https://review.openstack.org/45366715:47
openstackgerritBalazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications  https://review.openstack.org/45307715:47
openstackgerritMerged openstack/nova master: Make notification publisher_id consistent  https://review.openstack.org/48098415:48
openstackgerritGábor Antal proposed openstack/nova master: Send soft_delete from context manager  https://review.openstack.org/47645915:51
*** sshwarts has quit IRC15:53
*** damien_r has quit IRC15:54
janguttermriedem: I spoke completely too soon. It looks like implementing that second branch is going to cause a bit of a ripple effect. get_base_config creates an instance of LibvirtConfigGuestInterface, but to get the proper xml rendered we need it to be of class LibvirtConfigGuestHostdevPCI.15:55
*** _pewp_ has quit IRC15:55
sdaguemriedem: commented15:55
sdaguebasically, I don't think it's useful to rollback to oslo.service, because the point is to remove oslo.service from nova-api15:55
*** roeyc has quit IRC15:56
*** Apoorva has joined #openstack-nova15:57
*** baoli has quit IRC15:57
*** prateek_ has joined #openstack-nova15:57
*** jistr is now known as jistr|mtg15:58
*** smatzek has quit IRC15:58
*** _pewp_ has joined #openstack-nova15:58
*** prateek has quit IRC15:58
*** imacdonn_ has joined #openstack-nova15:59
janguttermriedem: So it looks like the xml renderer in config.LibvirtConfigGuestInterface needs to be extended to support generic devices (basically duping the functionality in LibvirtConfigGuestHostdevPCI)15:59
*** smatzek has joined #openstack-nova15:59
*** rajathagasthya has joined #openstack-nova15:59
*** baoli has joined #openstack-nova15:59
*** edmondsw has quit IRC15:59
*** edmondsw has joined #openstack-nova16:00
*** imacdonn has quit IRC16:01
*** shaner_ has joined #openstack-nova16:03
*** edmondsw_ has joined #openstack-nova16:03
*** dr_gogeta86_ has joined #openstack-nova16:03
*** randomhack has quit IRC16:03
*** jwcroppe has joined #openstack-nova16:04
mriedemsdague: makes sense16:04
mriedemjangutter: ok so let's not try to do that now16:04
mriedemjust leave a todo or error or something16:04
sdaguemriedem: https://review.openstack.org/#/c/486700/ also, just trying to clean up the test runs to make them easier to read16:04
janguttermriedem: roger wilco. Not throwing an exception?16:04
dansmithsdague: so we're good on that right?16:05
dansmithsdague: the fleetify patch16:05
*** edmondsw has quit IRC16:05
dansmithsdague: the dependent job passed16:05
mriedemdansmith: sdague: i wanted to go through experimental queue job results16:05
sdaguedansmith: mriedem was looking at some experimental bits as well16:05
dansmithoh okay I missed that16:05
*** shaner has quit IRC16:06
*** dr_gogeta86 has quit IRC16:06
sdagueI am waiting on mriedem to say go, then I'll +A it.16:06
*** edmondsw_ has quit IRC16:07
*** markmc has quit IRC16:07
*** FL1SK has quit IRC16:07
*** mamandle has joined #openstack-nova16:07
*** cburgess has quit IRC16:08
openstackgerritSean Dague proposed openstack/nova master: API ref: associate floating IP requires Active status  https://review.openstack.org/36364216:08
*** markmc has joined #openstack-nova16:09
*** markus_z has quit IRC16:09
*** cburgess has joined #openstack-nova16:09
*** s1061123 has quit IRC16:10
openstackgerritSean Dague proposed openstack/nova master: API ref: associate floating IP requires Active status  https://review.openstack.org/36364216:11
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s)  https://review.openstack.org/48575216:11
*** mamandle has quit IRC16:12
*** sridharg has quit IRC16:12
kashyapmdbooth: or mriedem: When you get a sec, I fixed the "broken" unit tests the above change brings in.  But I'm duking around adding the actual test for test_get_volume_config(), any suggestions welcome.16:13
*** s1061123 has joined #openstack-nova16:13
kashyapThe core change is simple and does two things:16:14
kashyap(1) In libvirt/driver.py, call _set_cache_mode() from _get_volume_config() method so that libvirt will set disk cache value for Cinder volumes *after* migration.16:14
*** lucasagomes is now known as lucas-hungry16:14
kashyap(2) Remove duplicate calls to _set_cache_mode() in _get_guest_storage_config() and attach_volume() methods.16:14
*** lucas-hungry is now known as lucas-afk16:14
*** rcernin has joined #openstack-nova16:14
kashyapThe reporter has tested the change and confirmed that it removes the perf regression (post migration) on the Cinder volume.16:15
*** s1061123 has quit IRC16:16
*** oomichi has quit IRC16:16
*** edmondsw has joined #openstack-nova16:18
*** oomichi has joined #openstack-nova16:18
*** s1061123 has joined #openstack-nova16:19
*** jistr|mtg is now known as jistr16:19
openstackgerritArtem Tiumentcev proposed openstack/nova master: Add root and ephemeral disk quota  https://review.openstack.org/48439016:22
*** edmondsw has quit IRC16:22
*** edmondsw has joined #openstack-nova16:24
*** dtp has joined #openstack-nova16:25
*** lucasxu has joined #openstack-nova16:26
*** lucasxu has quit IRC16:28
*** edmondsw has quit IRC16:28
*** rgerganov has quit IRC16:29
openstackgerritJan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver  https://review.openstack.org/48642616:29
*** MikeG451 has quit IRC16:30
*** tobasco has quit IRC16:30
*** derekh has quit IRC16:30
openstackgerritJan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver  https://review.openstack.org/48642616:31
*** cdent has joined #openstack-nova16:31
janguttermriedem: ^^ hope this one has the right idea.16:32
*** annegentle has quit IRC16:32
*** mgiles has quit IRC16:34
*** mgiles has joined #openstack-nova16:35
*** rgerganov has joined #openstack-nova16:35
*** tobasco has joined #openstack-nova16:36
*** lyan has quit IRC16:38
*** mgiles has quit IRC16:41
*** mgiles has joined #openstack-nova16:42
*** jmlowe has quit IRC16:42
*** mgiles has quit IRC16:44
*** Swami has joined #openstack-nova16:44
*** mgiles has joined #openstack-nova16:45
*** mgiles has quit IRC16:47
*** mgiles has joined #openstack-nova16:47
*** mgiles has quit IRC16:49
*** mgiles has joined #openstack-nova16:50
mriedemjbernard: dansmith: ceph job failed on the devstack fleetify change for an unrelated reason but fyi since it looks nasty http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-py35-full-devstack-plugin-ceph-ubuntu-xenial-nv/6066e44/logs/screen-g-api.txt.gz?level=TRACE#_Jul_25_14_37_19_66743416:51
dansmitheesh yeah16:52
*** edmondsw has joined #openstack-nova16:52
*** mgiles has quit IRC16:54
*** lucasxu has joined #openstack-nova16:54
*** mgiles has joined #openstack-nova16:55
*** links has joined #openstack-nova16:55
*** edmondsw has quit IRC16:56
mriedemmaybe just a py35 thing16:57
mriedemmaybe librados doesn't support py3516:57
dansmithbut we get that far only to find radios is None?16:58
*** ralonsoh has quit IRC16:58
*** randomhack has joined #openstack-nova16:59
mriedemyeah17:00
mriedemimport error sets that rados package import to None17:00
mriedemhttps://github.com/openstack/glance_store/blob/0.21.0/glance_store/_drivers/rbd.py#L4117:00
mriedemand rados isn't in the pip freeze output for py35 but it is for py2717:00
mriedemhttps://bugs.launchpad.net/glance-store/+bug/170640517:00
openstackLaunchpad bug 1706405 in glance_store "ceph jobs failing to upload images in pike due to "AttributeError: 'NoneType' object has no attribute 'Rados'" on py35" [Undecided,New]17:00
mriedemso this is just some py35 package install thing for librados17:00
dansmithno error log when we fail to import?17:01
mriedemeff no17:01
mriedemerror logs are in the enterprise edition of glance-store17:01
*** mgiles has quit IRC17:03
gibimriedem: hi! Do you have time to joint to the notification subteam meeting or we should simply skip that? I'm not against skipping it today.17:03
*** mgiles has joined #openstack-nova17:04
sdaguemriedem: ok, how is your look on the experimental job? As I'm going to walk away from the computer for a bit shortly17:04
*** annegentle has joined #openstack-nova17:04
openstackgerritMerged openstack/nova master: [placement] Use wsgi_intercept in PlacementFixture  https://review.openstack.org/48623717:05
*** lyan has joined #openstack-nova17:05
mriedemsdague: going through results17:06
mriedembut now in the notification meeting17:06
mriedemso you might as well walk17:06
*** smatzek has quit IRC17:06
*** randomhack has quit IRC17:06
*** dtantsur|brb is now known as dtantsur17:09
*** mvk has quit IRC17:09
*** sambetts is now known as sambetts|afk17:10
*** MikeG451 has joined #openstack-nova17:12
jangutterOK, this is a python newbie question (due to lack of caffeine)... Why would vif.get('ovs_interfaceid',"foobar") return None? ( https://github.com/openstack/nova/blob/master/nova/network/os_vif_util.py#L281 )17:12
openstackgerritGábor Antal proposed openstack/nova master: Transform missing delete notifications  https://review.openstack.org/41029717:13
openstackgerritGábor Antal proposed openstack/nova master: Send soft_delete from context manager  https://review.openstack.org/47645917:15
edleafejangutter: if there is a key named 'ovs_interfaceid' and its value is None17:15
edleafejangutter: it only returns the default param if the key isn't found17:15
mriedemjangutter: so do vif.get('ovs_interfaceid',"foobar") or 'foobar'17:17
*** baoli has quit IRC17:17
jangutteredleafe: yeah, that makes sense. That's why I see the pattern there.17:17
*** baoli has joined #openstack-nova17:18
*** tbachman_ has joined #openstack-nova17:19
sdaguelyarwood: was there any progress on this bug - https://bugs.launchpad.net/nova/+bug/1640506 ?17:20
openstackLaunchpad bug 1640506 in OpenStack Compute (nova) "Switch to os-brick encryptor provider implementations" [Wishlist,New]17:20
*** tbachman has quit IRC17:20
*** tbachman_ is now known as tbachman17:20
openstackgerritChris Dent proposed openstack/nova master: Use wsgi-intercept in OSAPIFixture  https://review.openstack.org/48682517:20
sdaguemriedem: ok, brain sufficiently fried, so walking away from computer now, but the number of bugs in new is down to 60 - https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New - so it's back on one page now17:21
mriedemyay17:22
openstackgerritJan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345917:22
mriedemdansmith: neutron dvr ha job is busted, but that's probably old news http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-neutron-dvr-ha-multinode-full-ubuntu-xenial-nv/432c235/console.html#_2017-07-25_15_47_52_09284017:23
*** baoli has quit IRC17:23
*** mgiles has quit IRC17:26
*** cdent has quit IRC17:26
*** mgiles has joined #openstack-nova17:26
jaypipesmriedem, dansmith: if you have a chance to review https://review.openstack.org/#/c/483566/ that would be great. (the final placemnet-claims one)17:28
mriedemjaypipes: yeah i was checking out the ci results before digging into the review17:28
jaypipesk17:28
*** baoli has joined #openstack-nova17:28
mriedemshould be done this afternoon17:28
*** david-lyle has quit IRC17:29
openstackgerritRobert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver.  https://review.openstack.org/48580317:30
*** links has quit IRC17:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications  https://review.openstack.org/47527617:31
gibimriedem: rebased the update_at bugfix ^^17:32
gibimriedem: I mean I've rebased17:33
mriedemthanks17:33
*** randomhack has joined #openstack-nova17:36
*** jwcroppe has quit IRC17:38
*** gszasz has quit IRC17:40
*** mvk has joined #openstack-nova17:41
openstackgerritMark Giles proposed openstack/nova master: Do not attempt volume swap when guest is stopped/suspended  https://review.openstack.org/38979817:42
*** yamahata has quit IRC17:43
*** mgiles has quit IRC17:46
*** mgiles has joined #openstack-nova17:47
*** jwcroppe has joined #openstack-nova17:48
*** moshele has joined #openstack-nova17:49
*** mgiles has quit IRC17:51
*** oomichi_ has joined #openstack-nova17:51
*** mgiles has joined #openstack-nova17:52
*** baoli has quit IRC17:52
*** oomichi has quit IRC17:52
*** oomichi_ is now known as oomichi17:52
*** harlowja has joined #openstack-nova17:55
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Remove the code related to extension loading from APIRouterV21  https://review.openstack.org/48641417:58
*** baoli has joined #openstack-nova17:58
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Remove the useless FakeExt  https://review.openstack.org/48641517:58
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Remove the useless extension block_device_mapping_v1 object  https://review.openstack.org/48606917:58
*** annegentle has quit IRC17:59
ildikovmriedem: I added a comment to the translation patch17:59
ildikovmriedem: I think the base for the confusion there is that the namings there are pretty confusing18:00
oomichialex_xu: re: https://review.openstack.org/#/c/486414/  yeah, that is an important one. +218:00
ildikovmriedem: would that be fine to make that human readable or you want the structure change too?18:00
*** andreaf has quit IRC18:01
*** david-lyle has joined #openstack-nova18:01
*** annegentle has joined #openstack-nova18:02
melwittsdague: yeah, that shouldn't be a thing with counting quotas in Pike. but maybe probably there needs to be a fix on stable only? I can't remember if we ever do that cc mriedem18:02
mriedemildikov: i said in https://review.openstack.org/#/c/486194/2/nova/volume/cinder.py@218 that we should rename that data_keys variable to connection_info18:02
mriedemildikov: however, _translate_attachment_ref doesn't return a connection_info dict18:02
mriedemit mangles the attachment dict,18:03
mriedemand adds a ['data'] key in it18:03
mriedemand shoves the attachment['connection_info'] stuff in there18:03
mriedemas far as i can tell18:03
ildikovas connection_info is a free form data structure having stuff under the 'data' key and 'driver_volume_type' on top level with it basically fulfills the criteria as far as I can tell18:04
*** ansiwen[q] has joined #openstack-nova18:04
*** penick has joined #openstack-nova18:04
ildikovbut jgriffith is smarter than me on this front18:05
*** eharney has quit IRC18:05
*** jmlowe has joined #openstack-nova18:05
mriedemewww yeah i don't like that18:06
mriedemand i just got now what it's doing18:06
mriedemit's the attachment ref PLUS all of the crap from the connection_info, mainlined into the attachment ref body resp18:06
mriedemthat's super confusing and i don't think we should do that18:06
mriedemlet's just translate the connection_info within the attachment ref as i said in there18:06
ildikovwell, connection_info goes under 'data' as how it used to be before18:07
*** Apoorva_ has joined #openstack-nova18:07
mriedemthios https://review.openstack.org/#/c/486194/2/nova/volume/cinder.py@22018:07
*** FL1SK has joined #openstack-nova18:07
mriedem*this18:07
mriedemyes i get that18:08
mriedembut it's also mangled into the attachment response body18:08
mriedemif the cinder API returns attachment: {connection_info: {'foo': 'bar'}} and now we turn that into attachment: {'data': {'foo': 'bar'}} that gets confusing18:09
*** andreaf has joined #openstack-nova18:09
mriedemi'd prefer to just see attachment: {connection_info: 'data': {{'foo': 'bar'}}} at the end18:10
mriedemwell ^ is busted, but you know18:10
*** Apoorva has quit IRC18:10
janguttermriedem, jaypipes: https://review.openstack.org/#/c/486426 got the checkmark from Jenkins.... but did I throw my first exception correctly?18:11
*** ansiwen[q] has quit IRC18:11
mriedemjangutter: omfg you don't throw anything!18:11
mriedem:P18:12
jgriffithmriedem ok, well this is why I dumped all that crap in the first place (which got us to that point)18:12
mriedemyou RAISE!18:12
jgriffithmriedem the issue being that in my opinion that original return info was a confusing free form mess18:12
janguttermriedem: what the heck? is this Poker or Python?18:12
jgriffithbut then *we* decided we wanted to keep it consistent18:12
mriedemjangutter: seems ok18:12
jgriffithso that's why it's now stuffing in the way it is18:12
mriedemjgriffith: i'm fine if cinder 3.27 wanted to flatten the connection_info dict and drop the 'data' subkey18:13
mriedembut what i don't like is doing attachment_ref.update(attachment_ref.pop('connection_info', {})) basically18:14
mriedemsans the driver_volume_type key18:14
mriedemer attachment_ref.update(dict(data=attachment_ref.pop('connection_info', {})))18:14
ildikovmriedem: the removal of the 'data' key on the Nova side is quite an amount of code line change apparently :(18:14
mriedembecause then am i dealing with an attachment representation, or a connection_info, or some weird hybrid?18:14
ildikovmriedem: that's why we thought to do that at another time18:15
*** ansiwen[q] has joined #openstack-nova18:15
mriedemildikov: yes it should be done another time18:15
*** nikhil has quit IRC18:15
jgriffithmriedem so wait... do you have a better idea on how to translate that other than popping it out into a new struct?18:15
ildikovmriedem: ok, at least one thing we agree at :)18:15
*** yamahata has joined #openstack-nova18:18
mriedemjgriffith: i'm fine with popping out the original one and writing it back into attachment_ref['connection_info']18:18
mriedemi just don't want it munged into attachment_ref itself18:18
mriedemper https://review.openstack.org/#/c/486194/2/nova/volume/cinder.py@22018:18
jgriffithmriedem that's reasonable18:18
jgriffithmriedem ildikov I think I see the problem here...18:20
jgriffithmriedem ildikov the attachment_create sadly returns a dict, while the attachment_update returns an attachment_ref object18:20
*** eharney has joined #openstack-nova18:20
ildikovjgriffith: don't we "play" with both?18:21
jgriffithildikov I don't know what you mean, but regardless...18:21
mriedemjgriffith: yes the cinderclient code is confusing as well18:21
ildikovjgriffith: that we translate both after calling to_dict()18:21
mriedemildikov: i think jgriffith is just talking about the cinderclient attachments code itself18:22
jgriffithildikov yes18:22
jgriffithmriedem correct18:22
mriedemcreate returns an object and update returns a dict18:22
mriedemwhich i got wrong when i originally wrote the nova side code18:22
jgriffithmriedem ildikov and the comment in the review asks "This is a VolumeAttachment object, yes?"18:22
jgriffithI'm answering "no"18:22
jgriffithit's not18:22
jgriffithmriedem you had a 50/50 shot18:23
jgriffithwhich is sad18:23
*** baoli has quit IRC18:23
mriedemjangutter: small issues inline18:24
*** avolkov` has joined #openstack-nova18:26
janguttermriedem: I'm running out of 80 characters!!!18:26
ildikovmriedem: jgriffith: ok, so we conclude to the format of: attachment_ref: {connection_info: {'data': {'foo': 'bar'}}}18:26
mriedemjangutter: drop a line18:27
*** penick has quit IRC18:27
mriedemildikov: yes18:27
ildikovmriedem: jgriffith: I will upload an update hopefully soon18:27
jgriffithildikov yeah; I think the whole point is to just make it a 1:1 mapping, I can put together the exact structures for you if you like?18:27
*** avolkov has quit IRC18:27
ildikovmriedem: another thing, there's a test failure in the attach patch, which I cannot figure out18:27
jgriffithildikov I'm also happy to work on the patch if you want, but I'll send you a git-diff because I want nothing to do with your rebase magic :)18:28
ildikovmriedem: if you happen to have a view on what to do that that would be pretty great :)18:28
*** fragatina has quit IRC18:28
ildikovmriedem: otherwise I will duplicate a bit more code for now and optimize later when I learn Python a bit more...18:28
ildikovjgriffith: it's ok if only one of us is messing with rebase, I can do that :)18:29
jgriffithildikov roger that18:29
mriedemildikov: this http://logs.openstack.org/85/330285/104/check/gate-nova-tox-functional-ubuntu-xenial/231f3e5/testr_results.html.gz ?18:30
ildikovmriedem: yes18:31
mriedemTestInstanceNotificationSample is using the CinderFixture18:31
ildikovmriedem: it gets the service version mock and I have no idea why18:32
ildikovmriedem: here's the relevant change: https://review.openstack.org/#/c/330285/104/nova/tests/functional/notification_sample_tests/test_instance.py18:32
*** baoli has joined #openstack-nova18:32
ildikovmriedem: I created a new fixture for the new flow and had the TestInstanceNotificationSample class using that one18:33
janguttermriedem: newbie question: I should check for the exception ... raised ... in the unit test, not trying to go check for the ideal output of the function?18:33
ildikovmriedem: and created another class which uses the old fixture and gets the mock for the service version to switch back to the old flow18:33
mriedemildikov: we shouldn't have to mess with the notification sample tests at all18:33
ildikovmriedem: you mean then to duplicate them?18:33
mriedemildikov: really we shouldn't have to mess with anything under nova/tests/functional18:33
ildikovmriedem: why not?18:33
mriedemleave nova/tests/functional for the old flows18:34
mriedemildikov: we can test the new flows with unit tests18:34
mriedemjangutter: yes, basically the same as the test as you have except dev_type='generic' and then the test uses self.assertRaises18:34
ildikovmriedem: it works nicely except that one test, which I can figure out in another way which means more duplication though18:35
janguttermriedem: roger18:35
ildikovmriedem: or I can just delete that part and leave the mocks only to switch back to the old flow, that works too18:35
ildikovmriedem: I guess we should run with that for now18:35
mriedemildikov: sorry i'm in a meeting and doing a few things at once and i don't have all of your changes in my head right now,18:36
mriedembut in general, we shouldn't have to touch nova/tests/functional for the new stuff,18:36
mriedemsince that is mostly all for api samples and notification samples, which are stubbing out cinder in specific ways for the old flows18:36
mriedemi mostly care about test coverage for the *new* flows using unit tests18:37
mriedemwe can worry about changing the various fixtures and functional tests over when we actually drop the *old* flows18:37
mriedemwhich is not going to be anytime soon18:37
ildikovmriedem: I figured out the swap stuff already and the rest is simple, the test failure is a mock and inheritance issue, and has nothing to do with Cinder18:37
ildikovmriedem: but anyway, if you don't want changes there I will remove it and I will add mocks to the places which fails due to having the highest service version but no new Cinder calls available to switch back to the old flow and these tests in a follow up patch18:38
ildikovmriedem: anyway, sorry for eating up this much of your time, I will go and do the updates we agreed on and then we can check if there's anything else to fix18:39
mriedemildikov: just leave the tests you have then in the api change, i can look into them at some point18:39
ildikovmriedem: ok18:40
ildikovmriedem: thanks18:40
*** ansiwen[q] has quit IRC18:42
*** kristia__ has quit IRC18:43
*** kristian__ has joined #openstack-nova18:43
*** priteau_ has joined #openstack-nova18:44
*** markmcclain has quit IRC18:44
*** priteau has quit IRC18:45
*** dtantsur is now known as dtantsur|afk18:45
*** itlinux_ has joined #openstack-nova18:46
*** baoli has quit IRC18:47
*** baoli has joined #openstack-nova18:47
*** kristian__ has quit IRC18:48
*** markmcclain has joined #openstack-nova18:48
*** priteau_ has quit IRC18:48
sdaguemelwitt: if you could comment on the bug, and move it to Fix Released, that would be cool18:50
*** penick has joined #openstack-nova18:51
*** prateek_ has quit IRC18:51
*** fragatina has joined #openstack-nova18:51
*** baoli has quit IRC18:52
sdaguemriedem: back for a bit, you look through those results yet?18:53
sdaguealso, anyone, this is a pretty easy deprecation of a conf variable - https://review.openstack.org/#/c/486623/18:53
mriedemsdague: melwitt: the quotas bug for ocata pointed out earlier is not necessarily fix released18:54
mriedemyou can't backport counting quotas to ocata18:54
mriedembut the fix might already be available, which i pointd out in the bug report and marked it incomplete since they didn't provide the version18:54
sdaguemriedem: sure, but fixed in master does count as fixed18:54
sdaguethen it's a backport question18:54
*** jdillaman has quit IRC18:55
mriedemit's incomplete either way at this point18:55
sdaguebut that doesn't make it not fixed18:55
sdagueincomplete doesn't mean that18:55
*** jdillaman has joined #openstack-nova18:55
*** phealy has quit IRC18:55
sdaguesure, as long as we're talking about incomplete just meaning "question back to reporter that needs an answer"18:55
sdaguebut if it's fixed in master, then I'd say it's probably correct to comment as such and put Fix Released on it18:56
*** penick has quit IRC18:58
*** mgiles has quit IRC19:00
*** mgiles has joined #openstack-nova19:00
*** baoli has joined #openstack-nova19:02
*** claudiub has joined #openstack-nova19:04
openstackgerritMatt Riedemann proposed openstack/nova master: Add oslo_concurrency=INFO to default log levels for nova-manage  https://review.openstack.org/48717919:07
*** mgiles_ has joined #openstack-nova19:07
*** mgiles has quit IRC19:08
openstackgerritJan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver  https://review.openstack.org/48642619:09
*** mgiles_ has quit IRC19:12
*** penick has joined #openstack-nova19:12
*** mgiles has joined #openstack-nova19:13
*** smatzek has joined #openstack-nova19:13
*** mgiles has quit IRC19:15
*** mgiles has joined #openstack-nova19:15
*** mgiles has quit IRC19:17
mriedemsdague: dansmith: i've dumped my debug notes in https://review.openstack.org/#/c/477556/19:18
*** mgiles has joined #openstack-nova19:18
mriedemwe discover and map the compute node on the primary host as part of the devstack stack.sh run on the primary host,19:18
mriedemwe discover and map the subnodes (2 of them) after the subnodes are stacked19:18
openstackgerritJan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345919:18
mriedembut it looks like when discover_hosts runs, we only discover and map the subnode-2, but miss subnode-319:18
mriedemso this might just be a latent issue in 3-node jobs19:19
mriedembut makes me wonder why we don't hit this more often in 2-node jobs19:19
*** mgiles has quit IRC19:22
*** mgiles has joined #openstack-nova19:22
*** xyang1 has joined #openstack-nova19:22
openstackgerritDan Smith proposed openstack/nova master: [WIP] Add some more cellsv2 doc goodness  https://review.openstack.org/48718319:24
*** randomhack has quit IRC19:25
dansmithmriedem: okay I really hadn't done any 3 node thinking yet19:25
mriedemdansmith: as far as i can tell, the 3rd node is being setup the same as the 2nd node19:25
dansmithmriedem: are there actual production 3-node jobs that we'll break with this?19:26
mriedemi don't know if there are any 3 node voting jobs, but i can dig19:26
dansmithokay19:26
mriedemi think we're basically getting lucky in the 2 node jobs19:26
openstackgerritRobert Ellis proposed openstack/nova master: Clarifying node_uuid usage in ironic driver.  https://review.openstack.org/48580319:26
mriedemfor example, this is a normal 2 node job19:27
mriedemwe discover subnode host here19:27
mriedemhttp://logs.openstack.org/66/483566/10/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/770b47e/console.html#_2017-07-24_16_27_34_06288419:27
dansmithmeaning we're getting the first subnode from the main node?19:27
mriedem2017-07-24 16:27:34.062884 | + /opt/stack/new/devstack-gate/devstack-vm-gate.sh:main:L777:   discover_hosts19:27
mriedemand that subnode compute node was actually created after that19:28
mriedemhttp://logs.openstack.org/66/483566/10/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/770b47e/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_24_16_27_35_40361719:28
mriedemJul 24 16:27:35.403617 ubuntu-xenial-2-node-osic-cloud1-disk-10046822-741313 nova-compute[1379]: INFO nova.compute.resource_tracker [None req-29fd1bd5-8730-42d5-8075-04acacfe704a None None] Compute node record created for ubuntu-xenial-2-node-osic-cloud1-disk-10046822-741313:ubuntu-xenial-2-node-osic-cloud1-disk-10046822-741313 with uuid: d09dec50-566e-41ea-adde-7ff566b6386719:28
mriedemdansmith: yes the first compute node comes from the primary19:28
mriedemthe compute node on the primary host gets discovered as part of the primary host setup https://github.com/openstack-dev/devstack/blob/master/stack.sh#L144819:28
dansmithokay19:28
mriedemso our docs say19:29
mriedem"Configure and start your compute hosts. Before step 7, make sure you have compute hosts in the database by running nova service-list --binary nova-compute."19:29
mriedemstep 7 is running discover_hosts19:29
mriedemso,19:29
mriedemwhat we should really probably be doing is passing a variable down from devstack-gate to the tools/discover_hosts.sh script in devstack telling it how many hosts we expect to show up19:30
mriedembefore doing discovery19:30
dansmithI thought we were specifically not supposed to do that?19:30
dansmithlike, I thought we had an argument about that19:30
mriedemwell, if you've got a slow subnode then i'm not sure what the other options are19:31
mriedemwe have the periodic task, but that's still a race window19:31
dansmithagreed, I just thought we were told not to19:31
mriedemdansmith: isn't it fun we're having the same conversation we had almost exactly 6 months ago?!19:32
mriedemexcept i was in cabo san lucas at that time, which was more fun19:32
* dansmith isn't amused19:32
mriedemso, i dont think this is a problem in your fleetify change which is the key point19:33
*** rajathagasthya has quit IRC19:33
mriedemit's just a latent thing we aren't handling well in our infra19:34
dansmithmriedem: do these graphs do anything for you? http://docs-draft.openstack.org/83/487183/1/check/gate-nova-docs-ubuntu-xenial/ef53873//doc/build/html/user/cellsv2_layout.html19:34
dansmithmostly the second one19:34
dansmithokay19:34
openstackgerritIldiko Vancsa proposed openstack/nova master: Translate the return value of attachment_create and _update  https://review.openstack.org/48619419:34
*** gbarros has joined #openstack-nova19:34
mriedemdansmith: looks pretty good19:35
mriedemthe first graph is kind of a webby mess19:35
dansmithwish I could fix a few visual aberrations on it, but it took a lot of screwing around to make it look this good19:35
dansmithI spent less time on the first one I can muck some more19:36
*** phealy has joined #openstack-nova19:37
*** fragatin_ has joined #openstack-nova19:38
sdaguemriedem: ok, so have you confirmed if the 3 node is voting yet?19:40
openstackgerritMoshe Levi proposed openstack/nova master: hardware offload support for openvswitch  https://review.openstack.org/39826519:40
sdaguemriedem: I thought we were doing discover hosts at the end of the d-g run?19:40
*** fragatina has quit IRC19:41
*** pchavva has quit IRC19:41
mriedemsdague: we are,19:41
mriedembut the compute node getting created is asynchronous to that19:42
mriedemthe 3-node job could be slowing down the controller services just enough to hit the latent window19:42
sdaguebecause the startup of nova-compute takes that long?19:42
*** claudiub has quit IRC19:42
*** cdent has joined #openstack-nova19:43
*** gbarros has quit IRC19:43
sdagueso the race is that nova-compute service start doesn't make it to the db before discover hosts runs?19:43
*** phealy has quit IRC19:43
mriedemyes19:44
mriedem+1 on https://review.openstack.org/#/c/477556/ and my debug notes are all in there19:45
sdagueso... related, what's the deal with the stack trace here - http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-neutron-dvr-ha-multinode-full-ubuntu-xenial-nv/432c235/logs/subnode-3/screen-n-cpu.txt.gz#_Jul_25_15_06_55_30928319:46
mriedemthat's the thing where the libvirt starts up and tries to enable itself19:47
sdagueok, so we're going to stacktrace on every clean start19:47
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L356319:48
mriedemsdague: that's been around19:48
mriedemit's not a result of this change19:48
*** annegentle has quit IRC19:48
sdaguemriedem: sure19:48
sdagueit's just not good19:48
mriedemyeah, i don't like it either19:48
sdagueok, http://logs.openstack.org/56/477556/5/experimental/gate-tempest-dsvm-neutron-dvr-ha-multinode-full-ubuntu-xenial-nv/432c235/logs/subnode-3/screen-n-cpu.txt.gz#_Jul_25_15_07_02_323379 is where the compute node is built, that's about 7 seconds later19:48
mriedemyes19:48
mriedemi'm not sure why these stacktrace19:49
mriedemi guess because of https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3567 ?19:50
*** annegentle has joined #openstack-nova19:50
mriedemso it hits the generic Exception block as ComputeHostNotFound_Remote?19:50
openstackgerritDan Smith proposed openstack/nova master: [WIP] Add some more cellsv2 doc goodness  https://review.openstack.org/48718319:50
*** nicolasbock has quit IRC19:52
sdaguemriedem: yeh19:52
*** mtreinish has quit IRC19:55
*** mgiles has quit IRC19:58
*** mgiles has joined #openstack-nova19:58
*** phealy has joined #openstack-nova19:59
sdaguemriedem: do we have a way of telling that nova-compute is ready. Is that resource tracker at 07_02 the event we need?19:59
*** kristian__ has joined #openstack-nova20:00
openstackgerritMerged openstack/nova master: API ref: associate floating IP requires Active status  https://review.openstack.org/36364220:00
sdagueI'm trying to think about who should wait for what to get us there. Is there something we could tell from the subnode easily about it being ready so we knew we were in the clear when stack.sh finished?20:00
mriedemsdague: our docs tell you to run 'nova service-list --binary nova-compute' and make sure the compute shows up before you run discover_hosts20:01
*** Apoorva_ has quit IRC20:02
mriedembecause that API iterates all cells and gathers up the services running in them20:02
mriedemso the host mapping isn't required for that20:02
*** Apoorva has joined #openstack-nova20:03
sdagueso we could put a flag in to wait for compute20:03
sdagueand run: nova service-list --host `hostname` --binary nova-compute20:03
sdagueon the child until it is true?20:03
*** kristian__ has quit IRC20:05
*** mgiles has quit IRC20:07
*** mgiles has joined #openstack-nova20:07
dansmithnot on the child, on the main node20:08
*** cdent has quit IRC20:08
mriedemright we run discover_hosts from the primary20:08
mriedemb/c it needs to get to the api db to find the cell mappings20:08
mriedemand the compute nodes don't have access to that20:08
dansmithwell and you need the main node to do the waiting20:09
dansmithbecause it's going to run tests that need to wait until all the nodes are up20:09
*** phealy has quit IRC20:09
*** priteau has joined #openstack-nova20:09
*** armax has quit IRC20:10
*** fragatin_ has quit IRC20:10
mriedemthis is what i see for the 'host is not mapped to any cell' failures in voting jobs20:10
*** mtreinish has joined #openstack-nova20:10
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Host%5C%22%20AND%20message%3A%5C%22is%20not%20mapped%20to%20any%20cell%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20voting%3A1%20AND%20build_status%3A%5C%22FAILURE%5C%22&from=7d20:10
*** cdent has joined #openstack-nova20:10
mriedemthey are all grenade multinode jobs20:11
*** fragatina has joined #openstack-nova20:11
*** fragatina has quit IRC20:11
*** fragatina has joined #openstack-nova20:12
openstackgerritDan Smith proposed openstack/nova master: Add some more cellsv2 doc goodness  https://review.openstack.org/48718320:12
*** mgiles has quit IRC20:16
*** mgiles has joined #openstack-nova20:16
*** kristian__ has joined #openstack-nova20:17
*** mgiles has quit IRC20:21
*** mgiles has joined #openstack-nova20:21
*** mgiles has quit IRC20:23
*** mgiles has joined #openstack-nova20:24
sdaguedansmith: if the child doesn't return until n-cpu has checked in, that also works, right?20:26
sdaguebasically make stack.sh synchronous on nova-compute being up20:26
*** cfriesen has quit IRC20:27
dansmithsdague: by child you mean the subnode right?20:27
*** oomichi has quit IRC20:28
*** oomichi has joined #openstack-nova20:28
*** mgiles has quit IRC20:30
*** mgiles has joined #openstack-nova20:31
*** mgiles has quit IRC20:31
mriedemright so there are two places you could do that in the ComputeManager,20:32
*** kristian__ has quit IRC20:32
mriedem1. init_host()20:32
mriedem2. pre_start_hook()20:32
mriedemthe latter already tries to get the compute node20:32
mriedem*post_start_hook() i mean20:32
*** moshele has quit IRC20:32
mriedemdamn, sorry, no i meant pre_start_hook20:33
mriedemi did think that pre_start_hook should do it20:33
mriedembecause it calls update_available_resource_for_node20:34
mriedemwhich calls rt.update_available_resource20:34
mriedemwhich should then do the init compute node stuff20:34
sdaguedansmith: yeh20:34
mriedemso i'm not entirely sure why that doesn't happen in the pre_start_hook phase20:34
sdaguemriedem: are you sure it didn't?20:35
*** phealy has joined #openstack-nova20:36
mriedemi'm not sure no20:37
mriedemi can dig20:37
mriedemmy shovel is going to be pretty gd blunt after the end of this day20:38
sdaguemriedem: I was assuming that virt driver init host just took that long to start20:38
*** rajathagasthya has joined #openstack-nova20:38
mriedemthe virt driver init_host doesn't do much20:38
mriedemat least for the libvirt driver, it registers event listeners and connects to libvirt20:38
mriedemok so this is a subnode starting up20:39
mriedemhttp://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_42_12536020:39
mriedemJul 25 19:30:42.125360 ubuntu-xenial-2-node-osic-cloud1-disk-10073644-745537 nova-compute[711]: INFO nova.service [-] Starting compute node (version 16.0.0)20:39
mriedemthat's in nova.service.Service.start()20:39
mriedemthen you see the libvirt event stuff20:40
*** edmondsw has joined #openstack-nova20:40
*** crushil has quit IRC20:41
*** randomhack has joined #openstack-nova20:41
mriedemthen you see this from the libvirt driver http://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_42_15082320:41
mriedembecause the compute node doesn't exist yet20:41
mriedemthen you see this in the compute manager http://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_44_39480020:41
mriedemwhich is from _get_compute_nodes_in_db20:41
mriedemi'm not sure why that traces20:43
mriedemthat warning is here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L662720:43
*** randomhack has quit IRC20:45
*** armax has joined #openstack-nova20:47
mriedemanyway then we call the resource tracker https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L660220:47
mriedemhttp://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_44_39928120:47
mriedemJul 25 19:30:44.399281 ubuntu-xenial-2-node-osic-cloud1-disk-10073644-745537 nova-compute[711]: DEBUG nova.compute.resource_tracker [None req-9286123e-31d0-45c4-a951-fe1e3947db00 None None] Auditing locally available compute resources for ubuntu-xenial-2-node-osic-cloud1-disk-10073644-745537 (node: ubuntu-xenial-2-node-osic-cloud1-disk-10073644-745537) {{(pid=711) update_available_resource /opt/stack/new/nova/nova/compute/res20:47
mriedeme_tracker.py:609}}20:47
*** cfriesen has joined #openstack-nova20:47
*** priteau has quit IRC20:48
mriedemthen we should get in here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L48820:49
mriedemand we'll hit this https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L70920:50
mriedemhttp://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_44_44173420:50
*** crushil has joined #openstack-nova20:51
mriedemand so we'll create the compute node record here https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L53120:51
mriedemhttp://logs.openstack.org/79/487179/1/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/1dd9db5/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_25_19_30_44_45968620:51
mriedemsdague: but does systemd wait or does it just launch off the service start and not block on it?20:52
sdaguemriedem: define wait20:52
sdaguemriedem: we're starting in the foreground, it's tracking the parent process, but the issue is it's much later that things are ready20:55
sdagueanyway, I need to work on dinner, I've got this half assed patch running locally, if it works I'll push it20:56
mriedemright when we start the n-cpu service, and the service is launched, that's all async20:56
sdaguemriedem: it's not async20:56
janguttermriedem, jaypipes: should I assert on exception.NovaException or exception.InternalError at https://review.openstack.org/#/c/486426/6/nova/tests/unit/virt/libvirt/test_vif.py@161620:56
sdagueit's that it's not ready for 25 - 30 seconds after start20:56
sdagueand, there is no /health to know that20:57
sdaguewe poll api processes that we start to know they are ready before we move on20:57
*** jmlowe has quit IRC20:57
sdaguebut there isn't a direct interface for that20:57
mriedemright i meant https://github.com/openstack/nova/blob/master/nova/service.py#L13820:57
*** tylerderosagrund has quit IRC20:57
mriedemwhich is what calls compute manager pre_start_hook that sets this all up20:57
*** smatzek has quit IRC20:57
sdaguemriedem: ok, before I leave, I want to make sure we get this question clear :)20:58
sdaguesystemd is starting things, and it's running as parent process as soon as python exec happens20:58
*** cdent has quit IRC20:58
mriedemi guess i was thinking about like sysv init scripts and services,20:59
mriedemwhere you can run service nova-compute status20:59
mriedemand see if it's started or not20:59
sdaguesure, but all that tells you is if the process is running20:59
sdaguethe process is running20:59
sdagueeventually the process is ready20:59
mriedembut can't the start routine block until it's actually started or crashed?20:59
sdagueit is started20:59
sdaguethe process is running20:59
*** priteau has joined #openstack-nova20:59
sdaguehow does anything external know if a process is ready other than pid existing?21:00
mriedemok, well this is all latent stuff and shouldn't block https://review.openstack.org/#/c/477556/21:00
mriedemso can we get that in?21:00
mriedemlike, this behavior goes back to ocata21:00
sdaguehttps://www.freedesktop.org/software/systemd/man/systemd-notify.html if you want deeper state interaction between process and systemd21:01
*** awaugama has quit IRC21:01
sdaguemriedem: the neutron folks are currently borked?21:01
mriedemno21:01
*** gouthamr has quit IRC21:01
mriedemthe dvr-ha multinode job is non-voting and in the experimental queue21:01
sdagueok21:01
mriedemi've already talked to haleyb about it21:01
sdagueif they are cool with it, that's fine21:02
sdagueI'll try to get this wait call in place21:02
sdagueI just appoved the fleet patch21:02
mriedemok21:03
sdaguethis other thing takes a while to run, so off for the night, we'll see what it looks like in the morning21:03
openstackgerritMatt Riedemann proposed openstack/nova master: Remove redundant free_vcpus logging in _report_hypervisor_resource_view  https://review.openstack.org/48721621:06
*** yamamoto_ has joined #openstack-nova21:07
*** lucasxu has quit IRC21:09
janguttermriedem, jaypipes: should I assert on exception.NovaException or exception.InternalError at https://review.openstack.org/#/c/486426/6/nova/tests/unit/virt/libvirt/test_vif.py@161621:11
*** catintheroof has quit IRC21:11
*** jotr has quit IRC21:11
*** jmlowe has joined #openstack-nova21:13
*** priteau has quit IRC21:13
mriedeminternal error21:14
*** jotr has joined #openstack-nova21:14
mriedemyou should assert the thing being raised21:14
*** efoley has quit IRC21:14
jangutterroger, tightening the noose.21:14
mriedemtry/catch Throwable21:14
openstackgerritJan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver  https://review.openstack.org/48642621:15
jaypipesmriedem: raisable. :P21:17
openstackgerritJan Gutter proposed openstack/nova master: Netronome SmartNIC Enablement  https://review.openstack.org/48345921:22
*** gouthamr has joined #openstack-nova21:23
mriedemdansmith: fyi about fleet week to the dev list21:26
mriedemsent21:26
*** annegentle has quit IRC21:27
dansmithmriedem: ack, I'll read when I return in a bit21:28
*** eharney has quit IRC21:28
*** esberglu has quit IRC21:31
*** baoli has quit IRC21:34
mriedemjaypipes: your claims in the scheduler change21:35
mriedemthe ironic nv job failed on a scheduling novalidhost21:35
mriedemhttp://logs.openstack.org/66/483566/10/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial-nv/3a475d1/logs/screen-n-sch.txt.gz#_Jul_24_16_26_25_37204521:35
mriedemJul 24 16:26:25.372045 ubuntu-xenial-osic-cloud1-disk-10046831 nova-scheduler[11679]: DEBUG nova.scheduler.filter_scheduler [None req-76fb384b-64f6-4ed7-86fd-dbb616497e43 tempest-BaremetalBasicOps-2030059131 tempest-BaremetalBasicOps-2030059131] Found host state None that wasn't in allocation requests. Skipping. {{(pid=11679) _schedule /opt/stack/new/nova/nova/scheduler/filter_scheduler.py:196}}21:35
mriedemaha21:38
mriedemYES!21:38
openstackgerritIldiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow  https://review.openstack.org/33028521:40
*** mtreinish has quit IRC21:42
ildikovmriedem: I fixed the translate patch and the attach patch too should have a clean test run now21:43
*** penick has quit IRC21:44
ildikovmriedem: let me know if there's anything else I should do21:44
ildikovmriedem: tnx21:44
*** esberglu has joined #openstack-nova21:45
*** mtreinish has joined #openstack-nova21:46
*** rtjure has joined #openstack-nova21:47
*** Apoorva_ has joined #openstack-nova21:51
*** annegentle has joined #openstack-nova21:52
*** rtjure has quit IRC21:52
openstackgerritMatt Riedemann proposed openstack/nova master: claim resources in placement API during schedule()  https://review.openstack.org/48356621:53
openstackgerritMatt Riedemann proposed openstack/nova master: Set IronicNodeState.uuid in _update_from_compute_node  https://review.openstack.org/48722721:53
mriedemjaypipes: ^21:53
*** Apoorva has quit IRC21:54
*** avolkov` has quit IRC21:54
*** penick has joined #openstack-nova21:57
*** gouthamr has quit IRC21:58
*** jackie-truong has joined #openstack-nova22:01
jackie-truongHi @dansmith, are you available? I have some questions on nova/objects/instance.py that I think you can answer22:04
dansmithjackie-truong: for a few minutes yeah22:04
*** yamamoto_ has quit IRC22:05
jackie-truongdansmith: I'm helping out with this patch https://review.openstack.org/#/c/457711/22:05
jackie-truongdansmith: And we're having some issues with properly initializing the list of strings (trusted_certs) so that it is actually an Instance field22:06
dansmithjackie-truong: well, it's defined as a field, which means it's actually a field, but go on...22:07
jackie-truongWe're seeing the error "Instance object has no attribute 'trusted_cert'"22:07
dansmithjackie-truong: well, it's defined as "trusted_certs" (note the plural), so maybe that's why?22:08
jackie-truongdansmith: Sorry, that was a typo on my part22:08
*** xyang1 has quit IRC22:08
jackie-truong"Instance object has no attribute 'trusted_certs' "22:08
dansmithdamn, thought that was going to be quick :P22:08
jackie-truongdansmith: lol22:09
dansmithwell, I'd need to see where/how it's used then I guess,22:09
jackie-truongdansmith: If you need to head out, I can hop on later this week22:09
*** yamamoto has joined #openstack-nova22:09
jackie-truongdansmith: We thought this would be sufficient: "instance['trusted_certs'] = db_inst['trusted_certs']"22:09
dansmithbut you really shouldn't get an AttributeError the way you have it defined here22:09
dansmithL457?22:09
*** acormier has quit IRC22:09
jackie-truongdansmith: Yes, L45722:10
dansmithdb_inst is an "Instance" as well although it's from the model.. maybe it's actually complaining about that one?22:10
jackie-truongdansmith: Would we need to add some lines to load the trusted_certs attribute in obj_load_attr?22:10
dansmithjackie-truong: I don't see trusted_certs on the db model22:11
dansmithso I expect that's the problem. is there some other patch that is supposed to be under this?22:11
jackie-truongYes, this is part of the Nova certificate validation blueprint https://blueprints.launchpad.net/openstack/?searchtext=nova-validate-certificates22:12
*** kylek3h has quit IRC22:12
jackie-truongdansmith: But no, we didn't add anything to nova/db/sqlalchemy/models.py22:12
dansmithjackie-truong: well, uh, where do you think it's getting stored then? :P22:13
jackie-truongGood point ><22:13
dansmithjackie-truong: but yeah, I bet that's what you're hitting22:13
jackie-truongCool, thanks! So there's no need to add anything to instance.py's obj_load_attr?22:13
jackie-truongIn other words, once we put trusted_certs in the db models, then L457 should be good?22:14
dansmithL457 will be yeah.. you only need obj_load_attr() changes if you want to be able to lazy-load this field, which I think I said on that review a while back22:15
dansmithyou'll need a sql migration to add the column, then support on the model, then this patch and it should load22:15
dansmithalthough a list is a list, not a column, so you need to figure out how you're going to store that and bring it in as a list of things, but I'm sure you know that22:16
jackie-truongGot it. Thanks a lot, dansmith!22:16
*** rtjure has joined #openstack-nova22:17
*** cfriesen has quit IRC22:20
openstackgerritVipin Balachandran proposed openstack/nova master: VMware:Use power_state const for power state check  https://review.openstack.org/48312222:24
dansmithjackie-truong: np22:26
openstackgerritTony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt  https://review.openstack.org/47222922:38
openstackgerritTony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself.  https://review.openstack.org/45916622:38
openstackgerritTony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt  https://review.openstack.org/47222822:38
openstackgerritTony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py  https://review.openstack.org/48590722:38
openstackgerritTony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep.  https://review.openstack.org/47197222:38
openstackgerritTony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files  https://review.openstack.org/48683122:38
*** marst has quit IRC22:40
*** mtanino has quit IRC22:41
openstackgerritNicolas Simonds proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes  https://review.openstack.org/48499722:43
*** annegentle has quit IRC22:49
*** xinliang has quit IRC22:56
*** yassine has joined #openstack-nova22:56
*** rcernin has quit IRC22:58
jaypipesmriedem: sorry, was out back mowing the dirt patch...23:00
jaypipesmriedem: what did you find?23:00
jaypipesmriedem: ah, I read the comments on the patch. nice catch, and thank you sir.23:01
*** rajathagasthya has quit IRC23:05
*** thorst has quit IRC23:06
*** sdague has quit IRC23:07
dansmithwow, big information leak from papa cisco there23:07
*** acormier has joined #openstack-nova23:07
*** lyan has quit IRC23:10
*** xinliang has joined #openstack-nova23:10
*** edmondsw has quit IRC23:10
*** edmondsw has joined #openstack-nova23:11
*** cfriesen has joined #openstack-nova23:11
*** acormier has quit IRC23:12
cburgessdansmith Do what...?23:13
*** rtjure has quit IRC23:14
dansmithcburgess: the forward of the internal cisco "go sway the vote" email that got forwarded to the dev list with a ton of cisco email and mailing lists23:14
smcginnisSomeone's probably going to get a sterm talking to.23:15
*** edmondsw has quit IRC23:15
* melwitt looks23:15
smcginnismelwitt: http://lists.openstack.org/pipermail/openstack-dev/2017-July/120115.html23:15
melwittlol23:16
*** chyka has quit IRC23:16
smcginnisGah - s/sterm/stern/23:16
*** rtjure has joined #openstack-nova23:17
dansmithI really really want to go register for some interesting websites with those group addresses23:18
dansmith"Dear openstack summit core, please confirm your registration to Latex Fetish Weekly"23:19
smcginnislol23:19
melwitt:)23:19
melwittI assumed it was an accident when I opened it but it looks to be on purpose?23:21
dansmithseems purposeful to me. misguided and naive, but purposeful23:22
dansmithneedless to say, I've already voted :)23:22
melwittyeah23:22
melwitthah23:22
cburgessSo... sorry about that. Someone internal wasn't aware of the proper community norms. Gary, our internal person who owns our summit participation is going to make sure that individual, and everyone internal involved in summit talks understand community norms and adheres to them in the future.23:26
*** marst has joined #openstack-nova23:28
*** deep-book-gk_ has joined #openstack-nova23:29
*** deep-book-gk_ has left #openstack-nova23:32
*** Swami has quit IRC23:32
*** takashin has joined #openstack-nova23:34
mtreinishheh, I'm also pretty sure that voting page isn't ready yet23:35
mtreinishlike there's still the deadlines from boston listed23:35
*** jwcroppe has quit IRC23:36
mtreinishand the backend isn't filtering at all. I searched for dansmith's name and it showed all of his proposed talks going back to atl23:36
*** jwcroppe has joined #openstack-nova23:37
*** vishwanathj has quit IRC23:37
dansmithyeah I noticed that too23:37
*** vishwanathj has joined #openstack-nova23:37
*** jwcroppe has quit IRC23:37
*** chyka has joined #openstack-nova23:38
*** acormier has joined #openstack-nova23:39
*** penick has quit IRC23:39
*** penick has joined #openstack-nova23:40
jaypipescburgess: Gary was the one that sent the internal Cisco email...23:42
cburgessjaypipes I take it by that statement that you are also pointing out that the internal email is somewhat against the community spirit?23:44
*** mmehan has quit IRC23:45
jaypipescburgess: wasn't it? it's basically the "go vote for all of Cisco's submissions" email.23:45
*** penick has quit IRC23:45
*** rajathagasthya has joined #openstack-nova23:45
cburgessjaypipes I suppose thats a fair statement. There is some desire internally to show our level of involvement and promote our talka. But I agree that it is also a form of vote swaying that is at odds with the community standards.23:46
*** acormier has quit IRC23:46
cburgessI'll discuss it internally, though I'm fairly certain other companies do, or have done similar things in the past. But its a fair point that its not in keeping with the spirit.23:47
jaypipescburgess: totes23:47
jaypipescburgess: an email saying "hey everyone, please do your civic duty and go review and vote on summit talk proposals so that the summit schedule has excellent content" would be perfectly fine.23:47
cburgessjaypipes and those do happen as well. Its a fair point. Gary is, in general, very supportive of the community and its standards (he is co-organizer of the LA OpenStack meetup). There is some conflict at times between the community and internal desires. I agree that we could do better and I'll bring those up.23:48
jaypipescburgess: I'm not bitching about it. :)23:49
jaypipescburgess: was just pointing out that Gary (the person you mentioned was responsible for adhering to community norms) was the one who sent the email internally at Cisco :)23:49
jaypipescburgess: I didn't know if you were aware of that.23:50
jaypipescburgess: trust me, I've bitched about similar emails that Mirantis marketing has sent out internally.23:50
*** acormier has joined #openstack-nova23:50
*** sdague has joined #openstack-nova23:50
jaypipescburgess: and anyway, there's way more important things for me to bitch about: https://twitter.com/jaypipes/status/88988983202516582723:51
jaypipesclearly.23:51
cburgessjaypipes Well everyone is responsible for community norms (and yeah I'm aware I saw the thread, internally and on the dev list). Its hard for me to apply more the mild pressure on the internal type comms. But both Gary and I can apply much more preasure as it relates to external community involvement and comms.23:51
cburgessjaypipes LOL.. seen more then a few of those myself.23:52
jaypipescburgess: hey, if it makes you feel better, I voted up your proposed talk :)23:52
cburgesslol thanks23:52
jaypipesand now.. I'm off.23:54
jaypipesciao23:54
*** jaypipes has quit IRC23:54
openstackgerritJackie Truong proposed openstack/nova master: Add trusted certificates to InstanceExtras  https://review.openstack.org/45771123:54

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!