| *** namnh has quit IRC | 00:02 | |
| *** takashin has joined #openstack-nova | 00:02 | |
| *** ijw has joined #openstack-nova | 00:05 | |
| *** sapcc-bot has quit IRC | 00:05 | |
| *** sapcc-bot has joined #openstack-nova | 00:06 | |
| *** namnh has joined #openstack-nova | 00:06 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: de-ORM ResourceProvider.get_by_uuid() https://review.openstack.org/509025 | 00:06 |
|---|---|---|
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: Move RP._get|set_aggregates() to module scope https://review.openstack.org/509026 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: Remove RP.get_traits() method https://review.openstack.org/509027 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove CRUD operations on Inventory class https://review.openstack.org/509029 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: streamline InventoryList.get_all_by_rp_uuid() https://review.openstack.org/509030 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove dead code in Allocation._create_in_db() https://review.openstack.org/509031 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove ability to delete 1 allocation record https://review.openstack.org/509032 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: fix up AllocList.get_by_resource_provider_uuid https://review.openstack.org/509033 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove bad comment in AllocList.create_all() https://review.openstack.org/509034 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: rework AllocList.get_all_by_consumer_id() https://review.openstack.org/509035 | 00:06 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove _HasAResourceProvider mixin https://review.openstack.org/509036 | 00:06 |
| *** jaypipes has quit IRC | 00:07 | |
| *** hieulq has quit IRC | 00:09 | |
| *** hieulq has joined #openstack-nova | 00:10 | |
| *** namnh has quit IRC | 00:10 | |
| *** mriedem has quit IRC | 00:21 | |
| *** sdague has quit IRC | 00:22 | |
| *** gbarros has quit IRC | 00:28 | |
| *** acormier has joined #openstack-nova | 00:29 | |
| *** itlinux has joined #openstack-nova | 00:35 | |
| *** yamahata has quit IRC | 00:37 | |
| *** chyka has quit IRC | 00:41 | |
| *** chyka has joined #openstack-nova | 00:42 | |
| *** lnxnut has joined #openstack-nova | 00:42 | |
| *** chyka has quit IRC | 00:46 | |
| *** chyka has joined #openstack-nova | 00:49 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove 400 as expected error https://review.openstack.org/509039 | 00:51 |
| *** lnxnut has quit IRC | 00:53 | |
| *** chyka has quit IRC | 00:54 | |
| *** edmondsw has joined #openstack-nova | 01:01 | |
| *** tbachman has quit IRC | 01:03 | |
| *** sapcc-bot3 has joined #openstack-nova | 01:04 | |
| *** sapcc-bot has quit IRC | 01:05 | |
| *** phuongnh has joined #openstack-nova | 01:05 | |
| *** acormier has quit IRC | 01:07 | |
| *** tbachman has joined #openstack-nova | 01:07 | |
| *** acormier has joined #openstack-nova | 01:07 | |
| *** adisky_ has joined #openstack-nova | 01:07 | |
| *** gjayavelu has quit IRC | 01:09 | |
| *** edmondsw has quit IRC | 01:17 | |
| *** penick has joined #openstack-nova | 01:18 | |
| *** acormier has quit IRC | 01:25 | |
| *** penick has quit IRC | 01:25 | |
| *** acormier has joined #openstack-nova | 01:26 | |
| *** itlinux has quit IRC | 01:29 | |
| *** itlinux has joined #openstack-nova | 01:29 | |
| *** acormier_ has joined #openstack-nova | 01:30 | |
| *** acormier has quit IRC | 01:30 | |
| *** itlinux has quit IRC | 01:48 | |
| *** lnxnut has joined #openstack-nova | 01:50 | |
| *** lbragstad has joined #openstack-nova | 01:51 | |
| openstackgerrit | melanie witt proposed openstack/nova-specs master: Propose counting quota usage from placement https://review.openstack.org/509042 | 01:51 |
| *** szaher has quit IRC | 01:57 | |
| *** lnxnut has quit IRC | 02:01 | |
| *** baoli has quit IRC | 02:02 | |
| *** baoli has joined #openstack-nova | 02:03 | |
| *** szaher has joined #openstack-nova | 02:07 | |
| *** acormier_ has quit IRC | 02:18 | |
| *** tbachman has quit IRC | 02:20 | |
| *** tbachman has joined #openstack-nova | 02:25 | |
| *** itlinux has joined #openstack-nova | 02:31 | |
| *** bnemec has quit IRC | 02:39 | |
| *** baoli has quit IRC | 02:43 | |
| *** itlinux has quit IRC | 02:44 | |
| *** yamamoto has joined #openstack-nova | 02:45 | |
| *** hongbin has joined #openstack-nova | 02:50 | |
| *** baoli has joined #openstack-nova | 02:51 | |
| *** baoli has quit IRC | 02:57 | |
| *** FL1SK has quit IRC | 02:57 | |
| *** baoli has joined #openstack-nova | 02:58 | |
| *** lnxnut has joined #openstack-nova | 02:59 | |
| *** hongbin has quit IRC | 03:00 | |
| *** hongbin has joined #openstack-nova | 03:00 | |
| *** erlon has quit IRC | 03:02 | |
| *** lnxnut has quit IRC | 03:07 | |
| *** vladikr has quit IRC | 03:08 | |
| openstackgerrit | Tony Breeds proposed openstack/nova master: [DNM] Yesting the legacy-requirements job https://review.openstack.org/509054 | 03:12 |
| *** baoli has quit IRC | 03:14 | |
| *** esberglu has joined #openstack-nova | 03:17 | |
| *** esberglu has quit IRC | 03:17 | |
| *** lbragstad has quit IRC | 03:17 | |
| *** sam_nowitzki has joined #openstack-nova | 03:29 | |
| *** gbarros has joined #openstack-nova | 03:32 | |
| *** thorst has joined #openstack-nova | 03:33 | |
| *** gyee has joined #openstack-nova | 03:37 | |
| *** gyee has quit IRC | 03:38 | |
| *** vladikr has joined #openstack-nova | 03:38 | |
| *** crushil has joined #openstack-nova | 03:43 | |
| openstackgerrit | Philip Choi proposed openstack/nova master: commit ce26619af3f7ac8c55567d6aa8125b77e457af19 Author: Philip Choi <phchoi@cisco.com> Date: Fri Sep 8 10:52:42 2017 +0800 https://review.openstack.org/509060 | 03:45 |
| *** udesale has joined #openstack-nova | 03:45 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:47 | |
| *** thorst has quit IRC | 03:50 | |
| *** vladikr has quit IRC | 03:56 | |
| *** gouthamr has joined #openstack-nova | 04:01 | |
| *** lnxnut has joined #openstack-nova | 04:04 | |
| *** ijw has quit IRC | 04:06 | |
| *** FL1SK has joined #openstack-nova | 04:09 | |
| *** esberglu has joined #openstack-nova | 04:10 | |
| *** esberglu has quit IRC | 04:14 | |
| *** mingyu has quit IRC | 04:17 | |
| *** acormier has joined #openstack-nova | 04:18 | |
| *** mingyu has joined #openstack-nova | 04:19 | |
| *** mingyu has quit IRC | 04:19 | |
| *** lnxnut has quit IRC | 04:21 | |
| *** oanson has quit IRC | 04:21 | |
| *** acormier has quit IRC | 04:23 | |
| *** gbarros has quit IRC | 04:28 | |
| *** oanson has joined #openstack-nova | 04:30 | |
| *** sree has joined #openstack-nova | 04:30 | |
| *** sridharg has joined #openstack-nova | 04:32 | |
| *** hongbin has quit IRC | 04:32 | |
| *** yamahata has joined #openstack-nova | 04:33 | |
| *** armax has quit IRC | 04:35 | |
| *** diga has joined #openstack-nova | 04:38 | |
| *** mdnadeem has joined #openstack-nova | 04:39 | |
| *** claudiub|2 has joined #openstack-nova | 04:45 | |
| *** ijw has joined #openstack-nova | 04:47 | |
| *** ijw_ has joined #openstack-nova | 04:50 | |
| *** gouthamr has quit IRC | 04:50 | |
| *** crushil has quit IRC | 04:51 | |
| *** ijw has quit IRC | 04:53 | |
| *** ijw_ has quit IRC | 04:58 | |
| *** pcaruana has joined #openstack-nova | 05:01 | |
| *** markvoelker_ has joined #openstack-nova | 05:03 | |
| *** namnh_ has joined #openstack-nova | 05:03 | |
| *** psachin has joined #openstack-nova | 05:04 | |
| *** markvoelker has quit IRC | 05:05 | |
| *** ratailor has joined #openstack-nova | 05:07 | |
| *** namnh_ has quit IRC | 05:07 | |
| *** manasm has joined #openstack-nova | 05:10 | |
| *** masber has joined #openstack-nova | 05:12 | |
| *** lpetrut has joined #openstack-nova | 05:16 | |
| *** edand has joined #openstack-nova | 05:16 | |
| *** lnxnut has joined #openstack-nova | 05:18 | |
| *** mingyu has joined #openstack-nova | 05:20 | |
| *** pcaruana has quit IRC | 05:23 | |
| *** mingyu has quit IRC | 05:25 | |
| *** lnxnut has quit IRC | 05:28 | |
| *** oanson has quit IRC | 05:36 | |
| *** oanson has joined #openstack-nova | 05:36 | |
| *** markvoelker_ has quit IRC | 05:37 | |
| *** markvoelker has joined #openstack-nova | 05:37 | |
| *** Eran_Kuris has joined #openstack-nova | 05:41 | |
| *** markvoelker has quit IRC | 05:42 | |
| *** tetsuro has joined #openstack-nova | 05:45 | |
| *** hieulq has quit IRC | 05:49 | |
| *** phuongnh has quit IRC | 05:49 | |
| *** manasm has quit IRC | 05:49 | |
| *** phuongnh has joined #openstack-nova | 05:49 | |
| *** hieulq has joined #openstack-nova | 05:49 | |
| *** manasm has joined #openstack-nova | 05:51 | |
| *** josecastroleon has joined #openstack-nova | 05:53 | |
| *** rcernin has joined #openstack-nova | 05:53 | |
| *** mingyu has joined #openstack-nova | 05:55 | |
| *** jamesdenton has quit IRC | 05:56 | |
| *** lpetrut has quit IRC | 06:09 | |
| *** Oku_OS-away is now known as Oku_OS | 06:09 | |
| *** mvk has quit IRC | 06:13 | |
| *** sahid has joined #openstack-nova | 06:13 | |
| *** rletrocquer has quit IRC | 06:13 | |
| *** Apoorva has joined #openstack-nova | 06:23 | |
| *** namnh_ has joined #openstack-nova | 06:24 | |
| *** nikhil has quit IRC | 06:24 | |
| *** lnxnut has joined #openstack-nova | 06:24 | |
| *** hoonetorg has quit IRC | 06:27 | |
| *** namnh_ has quit IRC | 06:28 | |
| *** aloga has quit IRC | 06:29 | |
| *** lajoskatona has joined #openstack-nova | 06:30 | |
| *** aloga has joined #openstack-nova | 06:30 | |
| *** Apoorva has quit IRC | 06:30 | |
| *** lnxnut has quit IRC | 06:34 | |
| *** slaweq has quit IRC | 06:35 | |
| *** slaweq has joined #openstack-nova | 06:36 | |
| *** ociuhandu has joined #openstack-nova | 06:38 | |
| *** slaweq has quit IRC | 06:40 | |
| *** hoonetorg has joined #openstack-nova | 06:41 | |
| *** slaweq has joined #openstack-nova | 06:42 | |
| *** mlakat has joined #openstack-nova | 06:43 | |
| *** pcaruana has joined #openstack-nova | 06:44 | |
| *** hferenc has quit IRC | 06:48 | |
| *** cfriesen has quit IRC | 06:54 | |
| *** esberglu has joined #openstack-nova | 06:55 | |
| *** esberglu has quit IRC | 06:55 | |
| *** lpetrut has joined #openstack-nova | 06:56 | |
| *** Eran_Kuris has quit IRC | 07:00 | |
| *** lpetrut has quit IRC | 07:05 | |
| openstackgerrit | Merged openstack/nova master: check query param for service's index function https://review.openstack.org/489492 | 07:07 |
| openstackgerrit | Merged openstack/nova master: Do not setup conductor in BaseAPITestCase https://review.openstack.org/508120 | 07:08 |
| *** ragiman has joined #openstack-nova | 07:11 | |
| *** migi_ is now known as migi | 07:13 | |
| *** tesseract has joined #openstack-nova | 07:17 | |
| *** hferenc has joined #openstack-nova | 07:19 | |
| *** ralonsoh has joined #openstack-nova | 07:24 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove 400 as expected error https://review.openstack.org/509039 | 07:27 |
| *** brault has joined #openstack-nova | 07:28 | |
| *** sree has quit IRC | 07:30 | |
| *** lnxnut has joined #openstack-nova | 07:31 | |
| *** sree has joined #openstack-nova | 07:31 | |
| *** sree has quit IRC | 07:35 | |
| *** markvoelker has joined #openstack-nova | 07:38 | |
| *** jpena|off is now known as jpena | 07:39 | |
| *** lnxnut has quit IRC | 07:41 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732 | 07:44 |
| *** brault has quit IRC | 07:46 | |
| *** brault has joined #openstack-nova | 07:46 | |
| bauzas | good specs day to everyone | 07:47 |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: serial console log (completed) https://review.openstack.org/450636 | 07:48 |
| *** esberglu has joined #openstack-nova | 07:48 | |
| *** esberglu has quit IRC | 07:53 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Move 'ips' field from Subnet object to VIF object https://review.openstack.org/508498 | 07:53 |
| *** josecastroleon has quit IRC | 07:55 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix test_get_volume_config method https://review.openstack.org/489467 | 07:58 |
| *** takashin has left #openstack-nova | 08:00 | |
| *** alexchadin has joined #openstack-nova | 08:00 | |
| *** Eran_Kuris has joined #openstack-nova | 08:02 | |
| *** sree has joined #openstack-nova | 08:05 | |
| *** manasm has quit IRC | 08:06 | |
| *** mvk has joined #openstack-nova | 08:10 | |
| *** markvoelker has quit IRC | 08:12 | |
| *** ociuhandu has quit IRC | 08:14 | |
| *** boris_42_ has quit IRC | 08:15 | |
| openstackgerrit | sahid proposed openstack/nova master: pci: update PciDevice object field 'address' to accept NULL https://review.openstack.org/508175 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: pci: add for PciDevice object new field mdev https://review.openstack.org/508176 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: pci: generalize object unit-tests for different framework https://review.openstack.org/508177 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: pci: add support for mdev device type request https://review.openstack.org/508178 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: pci: generalize stats unit-tests for different framework https://review.openstack.org/508179 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: pci: add support for mdev devices type in devspec https://review.openstack.org/508180 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: pci: add support for resource pool stats of mdev devices https://review.openstack.org/508181 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: pci: make manager to accept handling mdev devices https://review.openstack.org/508182 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: update PCI node device to report mdev devices https://review.openstack.org/508183 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: report mdev resources https://review.openstack.org/508184 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: add support to start vm with using mdev (vGPU) https://review.openstack.org/508185 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: functional: rework fakelibvirt host pci devices https://review.openstack.org/508186 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: functional: resuse SRIOV funtional tests for MDEV devices https://review.openstack.org/508187 | 08:19 |
| openstackgerrit | sahid proposed openstack/nova master: WIP - functional: rewrite class to generate pci devices https://review.openstack.org/508835 | 08:19 |
| *** oanson has quit IRC | 08:21 | |
| *** oanson has joined #openstack-nova | 08:22 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Change Subnet.dhcp_server to contain multiple IPs https://review.openstack.org/509107 | 08:25 |
| *** alexchadin has quit IRC | 08:27 | |
| *** lucas-afk is now known as lucasagomes | 08:30 | |
| *** alexchadin has joined #openstack-nova | 08:35 | |
| *** trinaths has joined #openstack-nova | 08:37 | |
| *** mvk has quit IRC | 08:38 | |
| *** lnxnut has joined #openstack-nova | 08:39 | |
| *** spectr has joined #openstack-nova | 08:41 | |
| *** manasm has joined #openstack-nova | 08:42 | |
| *** tpatil has joined #openstack-nova | 08:44 | |
| *** derekh has joined #openstack-nova | 08:44 | |
| *** cdent has joined #openstack-nova | 08:48 | |
| *** lnxnut has quit IRC | 08:48 | |
| *** tpatil has quit IRC | 08:50 | |
| *** mvk has joined #openstack-nova | 08:54 | |
| *** gszasz has joined #openstack-nova | 08:56 | |
| *** diga has quit IRC | 09:00 | |
| *** markvoelker has joined #openstack-nova | 09:09 | |
| *** alexchadin has quit IRC | 09:10 | |
| *** tssurya has joined #openstack-nova | 09:11 | |
| openstackgerrit | Jan Zerebecki proposed openstack/nova master: Fix wording of debug message for future releases https://review.openstack.org/508261 | 09:13 |
| *** ociuhandu has joined #openstack-nova | 09:16 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | 09:17 |
| *** mvk has quit IRC | 09:20 | |
| openstackgerrit | Jan Zerebecki proposed openstack/nova master: Fix wording of debug message for future releases https://review.openstack.org/508261 | 09:22 |
| *** sdague has joined #openstack-nova | 09:23 | |
| *** yamamoto has quit IRC | 09:24 | |
| *** priteau has joined #openstack-nova | 09:25 | |
| *** diga has joined #openstack-nova | 09:25 | |
| *** igordc has quit IRC | 09:26 | |
| *** igordc has joined #openstack-nova | 09:27 | |
| cdent | bauzas: that’s a great looking dog you have | 09:27 |
| bauzas | cdent: hah thanks | 09:28 |
| bauzas | Eurasier FTW | 09:28 |
| *** TuanLA has joined #openstack-nova | 09:28 | |
| bauzas | FWIW, since it's specs review day, I'm just fixing my own dashs because of Gerrit 2.13 :) | 09:30 |
| *** alexchadin has joined #openstack-nova | 09:31 | |
| bauzas | in case people face the same problem, sdague explained the issue in http://lists.openstack.org/pipermail/openstack-dev/2017-September/122277.html | 09:31 |
| *** mvk has joined #openstack-nova | 09:34 | |
| *** Eran_Kuris has quit IRC | 09:35 | |
| *** belmoreira has joined #openstack-nova | 09:39 | |
| *** yamamoto has joined #openstack-nova | 09:41 | |
| *** markvoelker has quit IRC | 09:42 | |
| *** rmart04 has joined #openstack-nova | 09:44 | |
| *** edand has quit IRC | 09:44 | |
| *** sree has quit IRC | 09:45 | |
| *** sree has joined #openstack-nova | 09:45 | |
| *** yamamoto has quit IRC | 09:46 | |
| *** lpetrut has joined #openstack-nova | 09:46 | |
| *** lnxnut has joined #openstack-nova | 09:46 | |
| *** yamamoto has joined #openstack-nova | 09:46 | |
| *** Eran_Kuris has joined #openstack-nova | 09:47 | |
| *** sree has quit IRC | 09:50 | |
| *** udesale has quit IRC | 09:51 | |
| *** yamamoto has quit IRC | 09:51 | |
| *** alexchadin has quit IRC | 09:53 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Intel Fortville Dynamic Device Personalization (DDP) https://review.openstack.org/503001 | 09:53 |
| *** yassine has quit IRC | 09:56 | |
| *** lnxnut has quit IRC | 09:56 | |
| *** jangutter has joined #openstack-nova | 09:57 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Intel Fortville Dynamic Device Personalization (DDP) https://review.openstack.org/503001 | 09:59 |
| *** yamamoto has joined #openstack-nova | 10:00 | |
| *** priteau has quit IRC | 10:00 | |
| *** chyka has joined #openstack-nova | 10:00 | |
| *** lpetrut_ has joined #openstack-nova | 10:04 | |
| *** chyka has quit IRC | 10:05 | |
| *** lpetrut has quit IRC | 10:06 | |
| *** yamahata has quit IRC | 10:08 | |
| *** phuongnh has quit IRC | 10:13 | |
| *** edand has joined #openstack-nova | 10:14 | |
| *** belmoreira has quit IRC | 10:16 | |
| *** sam_nowitzki has quit IRC | 10:17 | |
| *** mingyu has quit IRC | 10:18 | |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Enable SR-IOV NIC offload feature discovery https://review.openstack.org/504895 | 10:20 |
| *** claudiub has joined #openstack-nova | 10:22 | |
| *** claudiub|2 has quit IRC | 10:25 | |
| *** brault has quit IRC | 10:29 | |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Fix issues for post-allocations spec https://review.openstack.org/509136 | 10:31 |
| cdent | efried: that ^ should fix some of your comments, thanks for them | 10:32 |
| *** pooja_jadhav has quit IRC | 10:33 | |
| *** esberglu has joined #openstack-nova | 10:33 | |
| *** esberglu has quit IRC | 10:33 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove dead code of api.fault notification sending https://review.openstack.org/505164 | 10:37 |
| *** oanson has quit IRC | 10:38 | |
| *** markvoelker has joined #openstack-nova | 10:39 | |
| *** oanson has joined #openstack-nova | 10:40 | |
| *** aloga has quit IRC | 10:40 | |
| *** aloga has joined #openstack-nova | 10:43 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add documentation for cpu_realtime, cpu_realtime_mask https://review.openstack.org/502056 | 10:45 |
| stephenfin | gibi, bauzas: Any chance of a (re-)review of ^ | 10:46 |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Spec for limiting GET /allocation_candidates https://review.openstack.org/504540 | 10:52 |
| *** lnxnut has joined #openstack-nova | 10:53 | |
| *** tbachman has quit IRC | 10:54 | |
| *** alexchadin has joined #openstack-nova | 10:57 | |
| tetsuro | The patch I brought in the latest PTG is ready for review https://review.openstack.org/#/c/465160/. | 10:59 |
| tetsuro | This is a bug that falls into silent error with NUMATopology when virt_type is not set to kvm. | 10:59 |
| *** edand has quit IRC | 11:02 | |
| *** lnxnut has quit IRC | 11:02 | |
| *** udesale has joined #openstack-nova | 11:03 | |
| *** edand has joined #openstack-nova | 11:06 | |
| *** spectr has quit IRC | 11:07 | |
| *** nicolasbock_ has joined #openstack-nova | 11:09 | |
| *** mingyu has joined #openstack-nova | 11:09 | |
| *** READ10 has quit IRC | 11:12 | |
| *** markvoelker has quit IRC | 11:12 | |
| *** yassine has joined #openstack-nova | 11:13 | |
| *** priteau has joined #openstack-nova | 11:14 | |
| *** lucasagomes is now known as lucas-hungry | 11:16 | |
| gibi | stephenfin: done. +2 | 11:18 |
| *** nicolasbock_ has quit IRC | 11:18 | |
| *** smatzek has joined #openstack-nova | 11:18 | |
| gibi | stephenfin: thanks for the respin of the api.fault check. Is there something on master that will help pleasing jenkins? Should I rebase my other patches as well? | 11:18 |
| gibi | s/check/patch.// | 11:18 |
| *** yangyapeng has joined #openstack-nova | 11:25 | |
| *** esberglu has joined #openstack-nova | 11:27 | |
| *** nicolasbock_ has joined #openstack-nova | 11:31 | |
| *** esberglu has quit IRC | 11:31 | |
| *** yangyapeng has quit IRC | 11:34 | |
| *** yangyapeng has joined #openstack-nova | 11:35 | |
| *** chyka has joined #openstack-nova | 11:35 | |
| *** yangyapeng has quit IRC | 11:39 | |
| *** chyka has quit IRC | 11:40 | |
| *** tetsuro has quit IRC | 11:47 | |
| *** vladikr has joined #openstack-nova | 11:47 | |
| *** edmondsw has joined #openstack-nova | 11:50 | |
| *** brault has joined #openstack-nova | 11:50 | |
| *** tbachman has joined #openstack-nova | 11:54 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Update RT aggregate map less frequently https://review.openstack.org/489633 | 11:54 |
| *** udesale has quit IRC | 11:57 | |
| *** artom has joined #openstack-nova | 11:57 | |
| *** thorst has joined #openstack-nova | 11:58 | |
| *** lnxnut has joined #openstack-nova | 11:59 | |
| *** thorst_ has joined #openstack-nova | 12:00 | |
| *** liverpooler has joined #openstack-nova | 12:00 | |
| *** liverpooler has quit IRC | 12:00 | |
| *** liverpooler has joined #openstack-nova | 12:01 | |
| *** thorst has quit IRC | 12:02 | |
| *** artom has quit IRC | 12:03 | |
| *** chyka has joined #openstack-nova | 12:05 | |
| *** TuanLA has quit IRC | 12:07 | |
| *** markvoelker has joined #openstack-nova | 12:09 | |
| *** lnxnut has quit IRC | 12:09 | |
| *** thorst_ has quit IRC | 12:10 | |
| *** jmlowe has quit IRC | 12:10 | |
| *** chyka has quit IRC | 12:10 | |
| *** jaypipes has joined #openstack-nova | 12:10 | |
| *** john5223_ has joined #openstack-nova | 12:11 | |
| *** markvoelker has quit IRC | 12:12 | |
| *** markvoelker has joined #openstack-nova | 12:12 | |
| *** jmlowe has joined #openstack-nova | 12:14 | |
| *** manasm has quit IRC | 12:16 | |
| *** lucas-hungry is now known as lucasagomes | 12:17 | |
| *** jpena is now known as jpena|lunch | 12:19 | |
| *** thorst has joined #openstack-nova | 12:20 | |
| *** udesale has joined #openstack-nova | 12:22 | |
| *** thorst has quit IRC | 12:24 | |
| *** spectr has joined #openstack-nova | 12:24 | |
| *** aloga has quit IRC | 12:25 | |
| *** aloga has joined #openstack-nova | 12:26 | |
| *** jamesdenton has joined #openstack-nova | 12:26 | |
| *** baoli has joined #openstack-nova | 12:27 | |
| *** dave-mccowan has joined #openstack-nova | 12:28 | |
| *** erlon has joined #openstack-nova | 12:32 | |
| *** manasm has joined #openstack-nova | 12:33 | |
| *** catintheroof has joined #openstack-nova | 12:36 | |
| *** catintheroof has quit IRC | 12:36 | |
| *** catintheroof has joined #openstack-nova | 12:36 | |
| stephenfin | sahid: Can you reword the comment here? I'm not sure what you mean https://review.openstack.org/#/c/461456/5/nova/virt/hardware.py | 12:40 |
| *** catintheroof has quit IRC | 12:41 | |
| *** baoli has quit IRC | 12:41 | |
| *** baoli has joined #openstack-nova | 12:42 | |
| *** hemna__ has joined #openstack-nova | 12:42 | |
| *** thorst has joined #openstack-nova | 12:44 | |
| *** rmart04 has quit IRC | 12:44 | |
| sahid | stephenfin: yes i will, there are several points on what i'm not agree with that change | 12:45 |
| *** alexchadin has quit IRC | 12:46 | |
| stephenfin | sahid: Cool, thanks. I don't personally see the downside so there's a chance I'm missing something | 12:46 |
| *** mdnadeem has quit IRC | 12:48 | |
| *** acormier has joined #openstack-nova | 12:48 | |
| sahid | well firstable we add new syntax to provide the same fonctionnality, the previous one already brought bugs, adding a new one is not going to help | 12:49 |
| *** baoli has quit IRC | 12:49 | |
| *** smatzek has quit IRC | 12:50 | |
| *** pchavva has joined #openstack-nova | 12:50 | |
| *** chyka has joined #openstack-nova | 12:51 | |
| *** esberglu has joined #openstack-nova | 12:51 | |
| sahid | then with this new syntax, we allow users to specify the set of vCPUs used to apply the mask on where in my sense that shouldn't be allowed, the mask is applied on the set of vCPUs of the guest which Nova do provide | 12:51 |
| *** smatzek has joined #openstack-nova | 12:52 | |
| *** smatzek has quit IRC | 12:52 | |
| *** smatzek has joined #openstack-nova | 12:52 | |
| *** udesale has quit IRC | 12:52 | |
| *** acormier has quit IRC | 12:53 | |
| stephenfin | Yeah, they do achieve basically the same thing. However, from a usability perspective, I do think this second pattern is more intuitive | 12:54 |
| *** tbachman has quit IRC | 12:54 | |
| stephenfin | I mean, if the option was called 'cpu_realtime_excludes' or something, then the current pattern would make sense (and the carat wouldn't be necessary) | 12:54 |
| *** catintheroof has joined #openstack-nova | 12:54 | |
| *** lyan has joined #openstack-nova | 12:55 | |
| stephenfin | However, while nova definitely should keep track of total number of CPUs, I don't see why we should allow "explicit exclude-implicit include", but not "explicit include-implicit exclude" | 12:55 |
| *** alexchadin has joined #openstack-nova | 12:55 | |
| *** chyka has quit IRC | 12:55 | |
| stephenfin | "explicit include-explicit exclude" is an odd one, but it's no harm and already works, so if someone's silly enough to do it I don't see why we shouldn't just let them | 12:56 |
| stephenfin | This is a usability improvement and nothing more, IMO | 12:57 |
| *** ratailor has quit IRC | 12:57 | |
| sahid | ok that is the subjective point, i can hear it. what about the fact we add more and more code to achieve the same result? | 12:57 |
| *** acormier has joined #openstack-nova | 12:59 | |
| *** acormier has quit IRC | 13:04 | |
| *** mriedem has joined #openstack-nova | 13:07 | |
| *** manasm has quit IRC | 13:07 | |
| *** yangyapeng has joined #openstack-nova | 13:07 | |
| *** lnxnut has joined #openstack-nova | 13:07 | |
| *** mdnadeem has joined #openstack-nova | 13:08 | |
| *** alexchadin has quit IRC | 13:09 | |
| *** yangyapeng has quit IRC | 13:09 | |
| mriedem | blarg my nova-specs dashboard doesn't work with new gerrit | 13:13 |
| *** alexchadin has joined #openstack-nova | 13:13 | |
| cdent | mriedem: bauzas had some links earlier today about ways to fix that | 13:14 |
| bauzas | mriedem: yeah, I had to modify my own dashes | 13:14 |
| cdent | mriedem: http://lists.openstack.org/pipermail/openstack-dev/2017-September/122277.html | 13:14 |
| sdague | bauzas / mriedem are you using the ones from upstream? | 13:14 |
| bauzas | mriedem: tl;dr: labeling your votes doesn't work, you need to use another one | 13:15 |
| sdague | I tried to fix everything in that repo | 13:15 |
| sdague | but, I'm sure they could use tweaks | 13:15 |
| stephenfin | Yeah, https://github.com/openstack/gerrit-dash-creator/blob/master/dashboards/nova-specs.dash looks good to me | 13:15 |
| stephenfin | and I'm using https://github.com/openstack/gerrit-dash-creator/blob/master/dashboards/nova.dash daily | 13:15 |
| bauzas | sdague: I'm using the same queries than yours, but I use https://review.openstack.org/#/settings/preferences | 13:15 |
| *** MarginHu has joined #openstack-nova | 13:16 | |
| sdague | bauzas: ok, cool | 13:16 |
| *** yangyapeng has joined #openstack-nova | 13:16 | |
| sdague | bauzas: yeh, I end up just using browser bookmarks for them as they sync between chrome | 13:16 |
| bauzas | sdague: so, tbh I modified my queries thanks to you :) | 13:16 |
| *** kylek3h has joined #openstack-nova | 13:16 | |
| *** yamamoto has quit IRC | 13:16 | |
| bauzas | that, plus Zuul v3 \o/ | 13:17 |
| *** lnxnut has quit IRC | 13:17 | |
| bauzas | https://docs.openstack.org/infra/manual/zuulv3.html | 13:17 |
| *** smatzek has quit IRC | 13:17 | |
| *** awaugama has joined #openstack-nova | 13:17 | |
| bauzas | is anyone currently working on moving our jobs to the nova repo btw. ? | 13:17 |
| bauzas | sdague: do you know that ^ ? | 13:18 |
| *** eharney has joined #openstack-nova | 13:18 | |
| *** liverpooler has quit IRC | 13:19 | |
| jaypipes | sdague, mriedem: is it worth rechecking anything at the moment? | 13:19 |
| sdague | jaypipes: I don't know, I rechecked a few things, I'll let you know if anything works | 13:19 |
| jaypipes | kk | 13:19 |
| mriedem | jaypipes: don't think so | 13:19 |
| jaypipes | sdague: seeing a lot of POST_FAILURE stuff right now... | 13:19 |
| sdague | bauzas: no, but given that zuul v3 is still not passing many things, it didn't seem really useful to change the queries yet | 13:19 |
| mriedem | what i have rechecked is not queueing up | 13:19 |
| *** yangyap__ has joined #openstack-nova | 13:19 | |
| sdague | jaypipes: yeh... that's what I saw from stuff that hit lastnight | 13:20 |
| jaypipes | mordred: any particular activity that would be useful from us in identifying issues with Zuulv3? | 13:20 |
| bauzas | sdague: well, you're right | 13:20 |
| *** yangyapeng has quit IRC | 13:20 | |
| bauzas | jaypipes: there is an etherpad | 13:20 |
| bauzas | jaypipes: https://etherpad.openstack.org/p/zuulv3-migration-faq | 13:21 |
| jaypipes | bauzas: cheers | 13:21 |
| *** mdnadeem has quit IRC | 13:21 | |
| * bauzas took a couple of time to look at all the zuul v3 docs :) | 13:21 | |
| *** bnemec has joined #openstack-nova | 13:21 | |
| sdague | mriedem: you want me to restrict down the specs dashboard to only stuff proposed for queens? | 13:21 |
| *** smatzek has joined #openstack-nova | 13:22 | |
| bauzas | sdague: it's another dash I guess | 13:22 |
| bauzas | sdague: honestly, I'm directly querying for that | 13:22 |
| *** baoli has joined #openstack-nova | 13:22 | |
| mriedem | sdague: no that's fine | 13:23 |
| *** yangyap__ has quit IRC | 13:24 | |
| *** jpena|lunch is now known as jpena | 13:24 | |
| sdague | https://goo.gl/JxQn1r is an attempt to slice things off | 13:25 |
| *** yangyapeng has joined #openstack-nova | 13:25 | |
| sdague | so queens for everything, then a bucket at the bottom for non queens stuff | 13:25 |
| openstackgerrit | John Garbutt proposed openstack/nova master: Re-use existing ComputeNode on ironic rebalance https://review.openstack.org/508555 | 13:26 |
| *** yangyapeng has quit IRC | 13:27 | |
| *** jmlowe has quit IRC | 13:27 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Libvirt: Native LUKS decryption by QEMU https://review.openstack.org/490824 | 13:28 |
| *** lpetrut_ has quit IRC | 13:30 | |
| *** manasm has joined #openstack-nova | 13:30 | |
| *** smatzek has quit IRC | 13:32 | |
| *** smatzek has joined #openstack-nova | 13:33 | |
| *** smatzek has quit IRC | 13:34 | |
| *** yamamoto has joined #openstack-nova | 13:35 | |
| *** edand has quit IRC | 13:35 | |
| jaypipes | cdent: there isn't a call to get the aggregates for >1 resource provider is there? | 13:37 |
| * cdent tries to remember | 13:38 | |
| jaypipes | cdent: nm, no there isn't... | 13:38 |
| * cdent decompresses archived memories | 13:38 | |
| cdent | jaypipes: I believe you are correct | 13:38 |
| jaypipes | cdent: was thinking if there was, we could further simplify your agg perf patch to do a single batch call. | 13:38 |
| jaypipes | cdent: but meh, no worries :) | 13:38 |
| *** brault has quit IRC | 13:39 | |
| *** brault has joined #openstack-nova | 13:39 | |
| cdent | I had a version which was more brute force (but as a result required multiple requests) and decided that was not the way to go. | 13:40 |
| *** felipemonteiro has joined #openstack-nova | 13:40 | |
| jaypipes | cdent: no, this looks quite good. ++ | 13:40 |
| *** mdnadeem has joined #openstack-nova | 13:40 | |
| *** ijw has joined #openstack-nova | 13:40 | |
| *** lbragstad has joined #openstack-nova | 13:41 | |
| jaypipes | mriedem, dansmith: https://review.openstack.org/#/c/489633/ looks like a small, well-scoped patch with a good performance benefit. | 13:41 |
| bauzas | cdent: just a slight concern about possibly overthinking about times with https://review.openstack.org/#/c/496853/3 | 13:42 |
| cdent | bauzas: your etag fear has been noted on your api merit badge worksheet as a demerit | 13:42 |
| *** alexchadin has quit IRC | 13:43 | |
| *** alexchadin has joined #openstack-nova | 13:43 | |
| bauzas | hah | 13:43 |
| jaypipes | lol | 13:43 |
| *** brault has quit IRC | 13:44 | |
| bauzas | honestly, I just want to make sure we have a very small implementation for that | 13:44 |
| cdent | bauzas: on the last-modified time: since the time info is already there, seems like we may as well use it, because the spec says we should (if possible) include the _real_ time of update | 13:44 |
| bauzas | sure, I understand that | 13:44 |
| bauzas | but IMHO, keeping it simple for Queens isn't bad | 13:44 |
| cdent | since we dismissed etags as part of placement long ago, I think we should stick with that plan, I only include the option to be complete | 13:44 |
| bauzas | unless you really wanna cache | 13:44 |
| bauzas | and then, we should possibly use etags | 13:44 |
| bauzas | so, my thoughts are : do the very small change and just use the current time, or use Etags :p | 13:45 |
| cdent | I think the last-modified time is useful metadata for generic users of the placement service, maybe not in nova-scheduler, but for random unknowns. And since I’ve alrady got a working implementation, it’s not too much effort to finish it | 13:45 |
| *** mmehan has joined #openstack-nova | 13:46 | |
| bauzas | cdent: well, it needs then to leak out the DB details to the object | 13:46 |
| bauzas | we do that for a lot of stuff of course | 13:46 |
| cdent | one sec | 13:46 |
| bauzas | but I thought our placement objects shouldn't be using that | 13:46 |
| bauzas | anyway, I don't want to nitpick over it | 13:47 |
| cdent | bauzas: this is the wip, is not hard: https://review.openstack.org/#/c/495380/7/nova/objects/resource_provider.py | 13:47 |
| cdent | we alraedy have those fields | 13:47 |
| bauzas | yeah I know | 13:47 |
| bauzas | using a mixin isn't hard | 13:47 |
| bauzas | it's just we're exposing those DB details out to the API | 13:47 |
| bauzas | cdent: is it the first OpenStack project doing that ? (please use your API SIG hat :p ) | 13:48 |
| cdent | I don’t understand what you mean by “exposing those db details out the to the api”. You mean last modified time? Why is that a problem? | 13:48 |
| sdague | mriedem: ok, I'm really struggling about why on - https://review.openstack.org/#/c/501017/2/specs/queens/approved/flavor-description.rst | 13:49 |
| sdague | because that's really already there with flavor name | 13:49 |
| jaypipes | edleafe, bauzas, cdent, stephenfin, dansmith, mriedem: I think the only thing remaining on https://review.openstack.org/#/c/497713/10/specs/queens/approved/add-trait-support-in-allocation-candidates.rst is to agree on the name of the parameter. The options are traits=, required=, required_traits=. Let's just pick one. Please #vote for your first and second pick. I'll go first. | 13:49 |
| jaypipes | #vote 1. required=, 2. traits= | 13:50 |
| bauzas | I need to review that spec | 13:50 |
| dansmith | #vote 1. required 2. required= 3. requires= | 13:50 |
| jaypipes | lol | 13:50 |
| dansmith | jaypipes: I thought everyone was okay with required=? | 13:50 |
| *** josecastroleon has joined #openstack-nova | 13:50 | |
| jaypipes | dansmith: I don't believe mriedem was and I know edleafe wasn't. | 13:50 |
| edleafe | required= or traits= are fine with me | 13:50 |
| dansmith | edleafe: said he was | 13:50 |
| cdent | bauzas In my limited review of openstack apis, there’s a mix of who does and does not use last-modifed. If we’re looking to limit the amount of work in Queens, we could choose not to do this spec, it isn’t really required in any way. | 13:50 |
| edleafe | requires= is definitely not | 13:50 |
| jaypipes | or was it requires=... | 13:50 |
| bauzas | required= for me | 13:50 |
| jaypipes | yeah, sorry | 13:50 |
| stephenfin | #vote 1. traits=, 2. required= | 13:51 |
| cdent | mriedem expresed dislike for required, yes? | 13:51 |
| dansmith | jaypipes: I think mriedem said required= was okay too | 13:51 |
| edleafe | verbs don't work | 13:51 |
| bauzas | because we could implement preferred= later | 13:51 |
| jaypipes | understood. | 13:51 |
| dansmith | bauzas: exactly | 13:51 |
| stephenfin | ahhh | 13:51 |
| edleafe | preferred won't be in placement, right? | 13:51 |
| edleafe | that's a weigher issue | 13:51 |
| openstackgerrit | John Garbutt proposed openstack/nova master: Re-use existing ComputeNode on ironic rebalance https://review.openstack.org/508555 | 13:51 |
| cdent | #vote 1. required 2. required_traits | 13:52 |
| mriedem | i said i cared less about required= even though i didn't like it | 13:52 |
| bauzas | edleafe: I'm not advocating for it now | 13:52 |
| mriedem | i was -1 on the ?required='' thing | 13:52 |
| bauzas | edleafe: I'm just saying it *could* be possible | 13:52 |
| dansmith | edleafe: I don't think so, we still have to pull out things that might have that over things that don't at all, right? | 13:52 |
| jaypipes | edleafe: no plans *currently*, but we still would likely need a corresponding parameter for preferred to pass to the scheduler of course. | 13:52 |
| cdent | yeah, I fixed the required=‘’ thing, thank goodness | 13:52 |
| mriedem | sdague: i can't say how often people are changing flavor names randomly | 13:52 |
| edleafe | jaypipes: ok, I thought we were just thinking of the placement api | 13:52 |
| mriedem | there were a few operators that said they would use this on the spec | 13:52 |
| jaypipes | mriedem: what's your vote then? traits=? | 13:53 |
| sdague | mriedem: sure, so let's just make name mutable | 13:53 |
| bauzas | cdent: honestly, like I said, I don't want to take too much time on that spec, +Wd :) | 13:53 |
| sdague | mriedem: I guess, it feels really weird to add a **3rd** 255 character string to flavor | 13:53 |
| mriedem | sdague: from a ux perspective i don't think name is the thing you want to have 255 characters of detail in | 13:53 |
| *** liverpooler has joined #openstack-nova | 13:53 | |
| *** liverpooler has quit IRC | 13:53 | |
| sdague | mriedem: because it's called name? | 13:53 |
| mriedem | we have server name and description | 13:53 |
| mriedem | yes | 13:53 |
| *** liverpooler has joined #openstack-nova | 13:54 | |
| mriedem | i don't expect the name of a resource to be super detailed | 13:54 |
| mriedem | jaypipes: huh? i can't handle 3 conversations at once plus reviews right now. | 13:54 |
| sdague | mriedem: we do, but servers' don't also have a server_id field that's a 255 character string | 13:54 |
| mriedem | jaypipes: i thought agreement was on required=? | 13:54 |
| *** liverpooler has quit IRC | 13:54 | |
| mriedem | since we could have preferred later | 13:54 |
| *** baoli_ has joined #openstack-nova | 13:54 | |
| jaypipes | mriedem: got it. ok, it's settled then. | 13:54 |
| jaypipes | I just wanted to hold a final vote. | 13:54 |
| mriedem | sdague: i don't know why flavor is the weirdo resource with a 255 char id field either | 13:55 |
| sdague | mriedem: because flavor_id == server.name | 13:55 |
| mriedem | but id and name are generally short things | 13:55 |
| sdague | and flavor.name == server.description | 13:55 |
| sdague | or, at least should be treated as such | 13:55 |
| *** liverpooler has joined #openstack-nova | 13:55 | |
| mriedem | how many clouds are filling out the full flavor.name to express everything in that field today? | 13:56 |
| *** baoli has quit IRC | 13:56 | |
| mriedem | including details about baremetal and extra specs | 13:56 |
| sdague | mriedem: don't know, but if that's the concern I'd make the microversion start returning name as a description field instead, and make it mutable after that point | 13:57 |
| *** brault has joined #openstack-nova | 13:57 | |
| mriedem | i'm not going to do that | 13:57 |
| mriedem | we also embed the flavor name in the instance details now, | 13:57 |
| mriedem | so if name starts becoming big ass description, then your output in things like nova show are going to bloat up | 13:58 |
| sdague | mriedem: but that can already be an issue today | 13:58 |
| *** acormier has joined #openstack-nova | 13:58 | |
| *** READ10 has joined #openstack-nova | 13:58 | |
| *** spectr has quit IRC | 13:58 | |
| *** crushil has joined #openstack-nova | 13:58 | |
| sdague | if you put a 64 char constraint on id and name at the same time, I'd be fine with it. But I think choose your own adventure on 3 255 character fields is going to lead to more confusion | 13:59 |
| efried | cdent Nice, thanks. | 13:59 |
| *** spectr has joined #openstack-nova | 13:59 | |
| *** cfriesen has joined #openstack-nova | 13:59 | |
| bauzas | jaypipes: question in https://review.openstack.org/#/c/497713/10 | 13:59 |
| mriedem | sdague: i don't see how it's confusing, | 13:59 |
| mriedem | name is the name, | 13:59 |
| mriedem | id is a uuid by default | 13:59 |
| mriedem | description is a description, name and description are different things | 13:59 |
| *** kylek3h has quit IRC | 13:59 | |
| mriedem | in english | 14:00 |
| *** kylek3h has joined #openstack-nova | 14:00 | |
| bauzas | jaypipes: tl;dr say I have a host with 2 PFs, and only one tagged with a trait | 14:00 |
| sdague | but your concern was also bloat because 255 characters should not be used | 14:00 |
| bauzas | jaypipes: if I'm asking for 1 VF with that specific trait, I wouldn't get that host ? | 14:00 |
| jaypipes | bauzas: responding on the review... | 14:00 |
| bauzas | cool thanks :) | 14:00 |
| sdague | so, if that's what you believe, then put a 40 character limit on flavor_id, a 64 on name, and add description as the mutable big one | 14:01 |
| *** jmlowe has joined #openstack-nova | 14:01 | |
| mriedem | sdague: that would be an upgrade issue for anyone that has larger values for those fields already, as a workaround | 14:01 |
| bauzas | jaypipes: oh and FWIW, just discovered https://www.instagram.com/itsdougthepug/ | 14:01 |
| sdague | mriedem: start with it as json schema enforcement | 14:01 |
| mriedem | that might e ok | 14:02 |
| mriedem | *be | 14:02 |
| efried | mriedem sdague jaypipes bauzas edleafe Put me to work, guys. | 14:02 |
| mriedem | review specs | 14:03 |
| edleafe | efried: paint my house | 14:03 |
| efried | Right right; any particular ones? (Is there a dashboard to look at? | 14:03 |
| efried | ) | 14:03 |
| efried | edleafe Be there in 90 minutes | 14:03 |
| jaypipes | bauzas: :) on dougthepug | 14:04 |
| bauzas | sorry, I'm living in the countryside | 14:04 |
| sdague | mriedem: ok, well that's my current counter proposal in the spec. If we really believe people should only be doing flavor_id as uuid and name should be short, then enforce that on new types past that microversion. | 14:04 |
| bauzas | so, in case that's something people know like since 2 years, :p | 14:05 |
| *** smatzek has joined #openstack-nova | 14:05 | |
| mriedem | efried: https://goo.gl/QidAVs | 14:07 |
| efried | coo | 14:08 |
| *** chyka has joined #openstack-nova | 14:08 | |
| bauzas | jaypipes: sorry, my question wasn't clear | 14:09 |
| bauzas | jaypipes: if I'm taking your example | 14:09 |
| *** smatzek has quit IRC | 14:09 | |
| mriedem | lyarwood: a few small things in https://review.openstack.org/#/c/490824/ to update | 14:09 |
| bauzas | jaypipes: what if I'm having a node that is having 2 PFs, each of them having 8 VFs ? | 14:10 |
| bauzas | jaypipes: in a nested world, I'd have a root RP (the node) and 2 chidren (the PFs) | 14:10 |
| *** smatzek has joined #openstack-nova | 14:10 | |
| *** smatzek has quit IRC | 14:10 | |
| bauzas | jaypipes: then, if I'm asking for required=HW_NIC_OFFLOAD_TSO, should I get that node as a candidate? | 14:11 |
| *** smatzek has joined #openstack-nova | 14:11 | |
| *** burt has joined #openstack-nova | 14:11 | |
| bauzas | jaypipes: because alex_xu is saying NO to this https://review.openstack.org/#/c/497713/10/specs/queens/approved/add-trait-support-in-allocation-candidates.rst@44 | 14:11 |
| bauzas | jaypipes: to clarify, only *one* PF would have HW_NIC_OFFLOAD_TSO | 14:12 |
| bauzas | the other PF would have other traits | 14:12 |
| edleafe | jaypipes: on https://review.openstack.org/#/c/498830/9/specs/queens/approved/return-selection-objects.rst - are you saying that I should drop the limits field entirely? | 14:12 |
| *** nikhil_ has joined #openstack-nova | 14:13 | |
| *** chyka has quit IRC | 14:13 | |
| jaypipes | edleafe: yes, and add a numa_limits field that is a NUMATopologyLimits object. | 14:13 |
| *** nikhil_ is now known as Guest61849 | 14:13 | |
| edleafe | jaypipes: ok, I'll revise | 14:13 |
| *** jmlowe has quit IRC | 14:13 | |
| *** Guest61849 is now known as nikhil_k | 14:14 | |
| jaypipes | bauzas: when you say "what if I'm having a node that is having 2 PFs" are you really saying "what if I am *requesting* an instance that has two PFs"? | 14:14 |
| *** lnxnut has joined #openstack-nova | 14:14 | |
| bauzas | jaypipes: no, that's probably where I'm unclear | 14:15 |
| sdague | mriedem: does https://review.openstack.org/#/c/466595 solve cburgess's desire as well? | 14:15 |
| *** jmlowe has joined #openstack-nova | 14:15 | |
| bauzas | jaypipes: nevermind the SR-IOV language | 14:15 |
| *** thorst has quit IRC | 14:15 | |
| bauzas | and keep things simple : one root RP and 2 children RPs | 14:15 |
| efried | bauzas jaypipes If I'm understanding the algorithm correctly, we'll hit the PF that has the right trait; and then look up that guy's root_provider_id to include in the result set. | 14:15 |
| mriedem | sdague: that is the exact same spec/blueprint we've shot down numerous times, | 14:16 |
| mriedem | which i commented on back in may | 14:16 |
| efried | So we don't even consider the child PF RP that lacks the trait in question. | 14:16 |
| bauzas | jaypipes: each of those children RPs would have an inventory of 'foo': 8 | 14:16 |
| efried | mriedem Paperwork question: I don't see esberglu's https://review.openstack.org/#/c/503061/ in that dashboard. (Expected to see it under "needs final +2") | 14:16 |
| bauzas | jaypipes: but only one would have a trait 'MISC_FOO' | 14:16 |
| jaypipes | bauzas: k | 14:17 |
| bauzas | jaypipes: my question is, if I'm asking in my query for resources=FOO:1&required=MISC_FOO, could I get that node ? | 14:17 |
| jaypipes | bauzas: yes | 14:17 |
| jaypipes | bauzas: Alex is talking about *aggregates* on line 43-44. | 14:18 |
| mriedem | sdague: -1ed again | 14:18 |
| sdague | mriedem: sure, but if there really are a bunch of different operators that are all coming forward with "please we need this" it would be good to figure out who they are all | 14:18 |
| jaypipes | bauzas: he's being explicit that aggregates don't have traits associated with them. only RPs do. | 14:18 |
| *** artom has joined #openstack-nova | 14:18 | |
| bauzas | ah, shiy | 14:18 |
| bauzas | shit | 14:18 |
| mriedem | sdague: don't know who they all are now, at one point i found the various proposals and blueprints for this, and ML threads, | 14:18 |
| mriedem | that could be collected, but i'm not going to do it today, | 14:19 |
| jaypipes | bauzas: ah, hold up, I see now where your confusion lies | 14:19 |
| mriedem | it could probably be better served as a user survey question, but i do'nt really want to tie us to the response | 14:19 |
| sdague | mriedem: right, that's fair, not actually asking you to do it | 14:19 |
| jaypipes | bauzas: one sec. | 14:19 |
| mriedem | we've said, since boston, | 14:19 |
| efried | jaypipes bauzas Yeah, from that point of view, the traits *do* in fact propagate upwards. | 14:19 |
| efried | sort of | 14:19 |
| sdague | but cburgess might be the right volunteer for that activity | 14:19 |
| sdague | given his interest | 14:19 |
| mriedem | implement the cinder ephemeral backend and you can pass the volume type through extra specs - but that doesn't really pertain to non-ephemeral volumes we create on behalf of the user | 14:20 |
| jaypipes | bauzas: so, your confusion stems from the sentence "However, traits defined on a child | 14:20 |
| jaypipes | RP do not apply to the parent (ancestor) RPs" | 14:20 |
| bauzas | exactly | 14:20 |
| jaypipes | bauzas: what he's saying is correct, but weird :) | 14:20 |
| bauzas | it doesn't bubble up | 14:20 |
| *** namnh has joined #openstack-nova | 14:20 | |
| bauzas | so I just want to make sure we walk in the tree | 14:20 |
| efried | jaypipes bauzas I take that to mean: if the parent RP has *inventory*, you wouldn't get that *inventory* | 14:20 |
| efried | It would be weird (but not forbidden) for a parent to have inventory in the same resource class as its child. | 14:21 |
| *** namnh has quit IRC | 14:21 | |
| jaypipes | bauzas: the trait itself doesn't apply to the parent specifically, but when looking for providers to return in allocation candidates, any traits for any provider in a *tree* will be considered as being "traits of the tree" | 14:21 |
| efried | That's the case where the traits don't propagate upwards. | 14:21 |
| *** namnh has joined #openstack-nova | 14:21 | |
| bauzas | well, I'd say I would easily imagine the same resources:FOO:9&required=MISC_FOO not getting the node if only the child is having 8 FOOs per child | 14:22 |
| mriedem | stephenfin: this has been around for a month without any patches https://bugs.launchpad.net/nova/+bug/1714017 | 14:22 |
| openstack | Launchpad bug 1714017 in OpenStack Compute (nova) "User guide was not migrated to the nova repo" [Medium,In progress] - Assigned to Pavlukhin Max (mpavlukhin) | 14:22 |
| mriedem | stephenfin: so if you're keen maybe you want to take that over, | 14:23 |
| jaypipes | bauzas: that is correct. | 14:23 |
| *** itlinux has joined #openstack-nova | 14:23 | |
| jaypipes | bauzas: quantitatively it's not possible. | 14:23 |
| mriedem | stephenfin: keeping in mind we need to backport whatever the changes are | 14:23 |
| mriedem | so maybe step 1 is just import the user guide docs and backport, then step 2 is re-arrange and clean them up | 14:23 |
| mriedem | since some of the config drive user guide docs are really for admins | 14:23 |
| bauzas | jaypipes: but I had the same concern without traits, say I have 2 children with each of them having 8 FOOs | 14:23 |
| jaypipes | bauzas: but remember that the max_unit/min_unit part of hte inventory records will solve that query problem. | 14:23 |
| stephenfin | mriedem: I was going to, but Takashi NATSUME (I don't know his IRC nick) might be on it | 14:23 |
| bauzas | jaypipes: if I'm asking for 9 FOOs, I wouldn't get them even if I could have 8 in a child and 1 in the other child | 14:24 |
| *** lnxnut has quit IRC | 14:24 | |
| stephenfin | see https://bugs.launchpad.net/nova/+bug/1720873 | 14:24 |
| openstack | Launchpad bug 1714017 in OpenStack Compute (nova) "duplicate for #1720873 User guide was not migrated to the nova repo" [Medium,In progress] - Assigned to Pavlukhin Max (mpavlukhin) | 14:24 |
| *** Eran_Kuris has quit IRC | 14:24 | |
| *** jmlowe has quit IRC | 14:24 | |
| bauzas | jaypipes: mmm, I don't see how that helps but okay :) | 14:24 |
| jaypipes | bauzas: if you request 9 foo and there are 2 child providers having 8 foo inventories, each of those inventory records would have max_unit = 8 and that would mean a failing WHERE condition on max_unit <= $requested_amount | 14:24 |
| bauzas | jaypipes: I certainly understand *why* it's failing | 14:25 |
| bauzas | jaypipes: but I can easily imagine operators asking for spreading their resources | 14:25 |
| efried | yeah, that's a bug. | 14:25 |
| mriedem | stephenfin: ok | 14:25 |
| stephenfin | If they haven't done anything by next week, I'll pick it up | 14:25 |
| *** yamamoto has quit IRC | 14:26 | |
| bauzas | snap, I need to disappear for my daily daddy work | 14:26 |
| *** itlinux has quit IRC | 14:26 | |
| jaypipes | bauzas: sorry, I'm not following you still. :( | 14:26 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Move 'ips' field from Subnet object to VIF object https://review.openstack.org/508498 | 14:26 |
| * bauzas rushing out for 20 mins :( | 14:26 | |
| jaypipes | efried: do you think bauzas is talking about the resources1=, required1= stuff we discussed at the PTG? | 14:27 |
| *** cleong has joined #openstack-nova | 14:28 | |
| stephenfin | jaypipes: Fancy taking a look at this some time today? https://review.openstack.org/#/c/502056/ | 14:28 |
| stephenfin | (it's docs) | 14:28 |
| *** krtaylor has quit IRC | 14:29 | |
| efried | jaypipes A side effect thereof, yes. | 14:29 |
| *** sambetts|afk is now known as sambetts | 14:29 | |
| efried | jaypipes bauzas The two scenarios starting on L83 here: https://etherpad.openstack.org/p/nova-multi-alloc-request-syntax-brainstorm | 14:30 |
| efried | ...as far as spreading resources across RPs. | 14:30 |
| *** hongbin has joined #openstack-nova | 14:31 | |
| *** thorst has joined #openstack-nova | 14:31 | |
| jaypipes | efried: ok. I don't disagree that any of those scenarios are important. just that it's kind of a distraction at this point and an acknowledged thing we'll need to look at at a later time | 14:32 |
| efried | For the other discussion - how do traits "propagate" - perhaps it should be phrased: "With nested resource providers, traits defined on a parent RP are assumed to belong to all its child (descendant) RPs >>for purposes of inventory allocation<<. Traits defined on a child RP do not apply to the parent (ancestor) RPs. >>Although inventory is only claimed from a RP having the requested traits, the entire RP tree is returned in the provider summary for | 14:33 |
| efried | that allocation candidate.<<" | 14:33 |
| efried | or something like that. | 14:34 |
| * cdent stays out of this for the sake of progress ;) | 14:35 | |
| cdent | 🤐 | 14:35 |
| efried | cdent Glad you're staying out of it. | 14:36 |
| *** felipemonteiro has quit IRC | 14:37 | |
| efried | bauzas jaypipes We may want to defer this discussion; replace that chunk with "how traits are handled in nested RPs is out of scope and will be discussed in a subsequent spec". But that spec needs to land in Queens. | 14:37 |
| sdague | melwitt: https://review.openstack.org/#/c/486947/ is a quotas spec that would be great to have your commentary on | 14:37 |
| efried | jaypipes The "numbered resources querystring" spec would be a reasonable place for that discussion. | 14:38 |
| mriedem | dansmith: you should probably go through this https://review.openstack.org/#/c/433603/ | 14:39 |
| dansmith | mriedem: ugh, do I have to? | 14:39 |
| mriedem | yes | 14:39 |
| mriedem | and finish your peas | 14:39 |
| openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Network bandwitdh resource provider https://review.openstack.org/502306 | 14:40 |
| efried | jaypipes How does the scheduler determine that a particular RP is a compute host for the purposes of landing an instance? | 14:42 |
| efried | (Yes, this is ultimately relevant to the discussion) | 14:43 |
| *** MarginHu has quit IRC | 14:43 | |
| *** priteau has quit IRC | 14:44 | |
| jaypipes | efried: right now, the scheduler has a mapping of hostname to compute node UUIDs. the hostname is the same as the nova-compute service RPC topic queue | 14:45 |
| dansmith | mriedem: gawd moooom | 14:45 |
| jaypipes | efried: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L640 | 14:45 |
| efried | jaypipes Okay, cool. Cause when we have more than just compute host RPs, that's going to be pretty crucial. | 14:46 |
| jaypipes | efried: we already do... | 14:46 |
| *** corey_ has joined #openstack-nova | 14:46 | |
| jaypipes | efried: Ironic nodes and shared storage providers are not compute nodes. | 14:46 |
| efried | jaypipes Nested, then. Where that ties in is, you'll get your inventory from the child RP, but the whole tree is going to be (explicitly or implicitly via root_provider_id) part of your provider summaries. That's going to have to be how the scheduler figures out which compute node it should go to. | 14:47 |
| *** cleong has quit IRC | 14:47 | |
| mriedem | cdent: L105 here https://review.openstack.org/#/c/506552/4/specs/queens/approved/allow-update-instance-keypair.rst | 14:48 |
| mriedem | PUT /servers/{server_id/ | 14:48 |
| efried | jaypipes Cause at some point, there's gonna be a model where the compute node RP actually doesn't have *any* resources (e.g. VCPU and MEMORY_MB belong to NUMA node RPs under the compute host; DISK_GB belongs to a shared RP somewhere; etc.) | 14:48 |
| mriedem | if the server is not found by id, it's a 404, but if something in the request body isn't found, then it's a 400, right? | 14:48 |
| cdent | mriedem: correct, that’s the general rule | 14:48 |
| jaypipes | efried: the allocation_requests part of the GET /allocation_candidates HTTP response has the exact allocations against the exact resource providers that the instance will consume from (compute node providers and otherwise) | 14:48 |
| cdent | if the uri fails to hit, 404, otherwise 400 | 14:48 |
| *** esberglu has quit IRC | 14:49 | |
| *** esberglu has joined #openstack-nova | 14:49 | |
| efried | jaypipes Right, but see above (..:48:16). The compute host RP may not actually be in the list of exact RPs the instance will consume from). | 14:50 |
| *** jmlowe has joined #openstack-nova | 14:50 | |
| *** alexchadin has quit IRC | 14:50 | |
| mriedem | sdague: i see you found the competing instance keypair update specs | 14:50 |
| mriedem | and i know you saw the ML thread | 14:50 |
| * artom never did figure out if they were competing or complementary | 14:50 | |
| mriedem | what i don't know is what most deployments do about cloud-init behavior | 14:50 |
| mriedem | if they refresh on reboot or only on new build | 14:51 |
| jaypipes | efried: the compute node provider will always be the root_provider_id, though. | 14:51 |
| efried | jaypipes Right. That's my point. Generically, the scheduler will have to find the compute host by backtracking to the root_provider_id. | 14:51 |
| jaypipes | efried: and the provider_summaries part of the GET /allocation_candidates HTTP response informs the caller that a particular provider is a child of another. | 14:51 |
| jaypipes | efried: yes, that is true. | 14:52 |
| jaypipes | efried: and expected. | 14:52 |
| efried | jaypipes Right. That's another question I've had, though: will provider summaries include the whole tree, or only the "exact resource providers that the instance will consume from"? | 14:52 |
| jaypipes | efried: the placement doesn't know or care that a particular provider represents a compute node. | 14:52 |
| efried | right - the scheduler has to figure that out, I get that. | 14:52 |
| efried | hence my original leading question. | 14:53 |
| jaypipes | efried: placement doesn't care about anything other than inventory and allocation records... | 14:53 |
| jaypipes | efried: so it's the scheduler's responsibility to understand those things. | 14:53 |
| efried | Yup. | 14:53 |
| *** ijw has quit IRC | 14:53 | |
| jaypipes | efried: currently, the scheduler does that by keeping that map of service RPC to compute node UUID in memory. It will need to be adapted to understand nested/root providers | 14:53 |
| *** esberglu has quit IRC | 14:53 | |
| efried | jaypipes Will provider summaries include the whole tree, or only the exact RPs being consumed from? | 14:54 |
| jaypipes | efried: the exact RPs that could be consumed from and their parents. | 14:54 |
| jaypipes | efried: which is needed for callers to piece the tree together. | 14:54 |
| efried | parents/ancestors | 14:54 |
| jaypipes | yes | 14:54 |
| efried | up to the root | 14:54 |
| jaypipes | yes | 14:54 |
| efried | okay. | 14:54 |
| efried | I dig that. Saves an extra call from the scheduler. | 14:55 |
| jaypipes | efried: I wasn't planning on making provider_summaries into a tree structure, though. was relying on the caller to do that as needed. | 14:55 |
| *** eharney has quit IRC | 14:56 | |
| efried | I don't see the need for the whole tree - except that's easier to build, cause you'll already have that code for that API (forget which one) that returns a whole tree. | 14:56 |
| efried | The chain of parents is simple enough, but a separate algorithm. | 14:56 |
| bauzas | efried: jaypipes: sorry I had to disappear due to family business | 14:56 |
| bauzas | but yeah let's punt that discussion | 14:56 |
| * jaypipes gets out his red typo pen for ralonsoh's Network "bandwitdh" spec. | 14:56 | |
| *** MikeW has left #openstack-nova | 14:56 | |
| *** manasm has quit IRC | 14:56 | |
| jaypipes | bauzas: commented on the spec. | 14:57 |
| ralonsoh | jaypipes: hello. About https://review.openstack.org/#/c/502306/2/specs/queens/approved/bandwidth-resource-provider.rst@111. I don't understand what you mean. Should ML2 plugin be able to make RP claims? Or create/delete allocation records? | 14:57 |
| bauzas | the thoughts that I had was about saying "what if I'm asking for more than the inventory amount supported by one child" | 14:57 |
| *** brault has quit IRC | 14:57 | |
| cdent | jaypipes: I just had a quick confused run through there. Looks like some fundamental misconceptions. | 14:57 |
| jaypipes | ralonsoh: heh, I was just making a joke about the repeated misspellings of the word "bandwidth" :) | 14:58 |
| ralonsoh | jaypipes: sorry! | 14:58 |
| jaypipes | Including in the spec title ;) | 14:58 |
| jaypipes | ralonsoh: it's cool, I'm just kidding with ya | 14:58 |
| * cdent wonders what the name of dandysmith’s horse is | 14:58 | |
| jaypipes | cdent: "Horse". | 14:59 |
| cdent | such disappoint | 14:59 |
| jaypipes | ralonsoh: I'll comment on the spec, k? | 14:59 |
| ralonsoh | jaypipes: perfect! and thanks | 15:00 |
| jaypipes | ralonsoh: no problemo | 15:00 |
| mriedem | stephenfin: you've made the diff on this impossible https://review.openstack.org/#/c/496160/ | 15:00 |
| mriedem | to compare to the pike spec | 15:00 |
| *** brault has joined #openstack-nova | 15:00 | |
| mriedem | stephenfin: if you're re-proposing a spec from a previous release, please leave the stylistic changes for a separate patch | 15:00 |
| stephenfin | mriedem: How so? | 15:00 |
| mriedem | you change all the line wrapping | 15:01 |
| mriedem | i think you are going to need to setup a dr visit about your serious ocd issue | 15:01 |
| jaypipes | wait... mriedem is calling someone ocd? | 15:02 |
| cdent | my thoughts exactly | 15:02 |
| stephenfin | mriedem: Ah, I can undo those, but the only functional changes are the things that were already commented on | 15:02 |
| jaypipes | :P | 15:02 |
| mriedem | stephenfin: already approved | 15:04 |
| mriedem | but for next time | 15:04 |
| stephenfin | mriedem: (y) | 15:04 |
| mriedem | jaypipes: i'm not the one that -1s your changes for putting closing ] and } and ) on separate lines :P | 15:05 |
| jaypipes | mriedem: lol, tru dat | 15:05 |
| jaypipes | mriedem: that would be edleafe and dansmith, or as I call them "The Parens Posse" | 15:05 |
| *** Oku_OS is now known as Oku_OS-away | 15:06 | |
| *** eharney has joined #openstack-nova | 15:08 | |
| * edleafe is happy to be part of a gang | 15:09 | |
| cdent | dan’s down with tpp | 15:09 |
| cfriesen | tpp ya you know me... | 15:09 |
| *** thorst has quit IRC | 15:10 | |
| sdague | mriedem: yeh, I don't know either | 15:10 |
| *** armax has joined #openstack-nova | 15:10 | |
| *** chyka has joined #openstack-nova | 15:10 | |
| sdague | also, I think there is lots of confusion about "rebuild" | 15:10 |
| sdague | because even in the ML thread where someone said "yes, this would be great!" | 15:10 |
| sdague | and I asked "on just rebuild or you want reboot", A: "we never use rebuild" | 15:10 |
| *** thorst has joined #openstack-nova | 15:11 | |
| mriedem | i'm trying to get some more answers in the ops channel | 15:11 |
| *** thorst has quit IRC | 15:11 | |
| mriedem | and the answer i'm getting there is, "we don't use cloud-init to manage keys in the guest" | 15:11 |
| sdague | um... so huh what? | 15:12 |
| *** rcernin has quit IRC | 15:12 | |
| sdague | mriedem: joined there late, who said that? | 15:12 |
| mriedem | bloomberg runs a script which is in the image that refreshes the users for the vm, or something | 15:12 |
| mriedem | mihalis68 | 15:12 |
| sdague | yeh, cool, so they don't use the keypairs api then | 15:13 |
| sdague | which, honestly, makes sense | 15:13 |
| jaypipes | mriedem: probably they mean there's a single key they use for chef and then rely on chef to inject/write other user keys. | 15:13 |
| sdague | do the whole thing out of band | 15:13 |
| *** mdnadeem has quit IRC | 15:14 | |
| mriedem | cburgess: do you have input on this keypair update thing? do you configure cloud-init in the images to refresh keys on reboot or only new build of the guest? | 15:14 |
| sdague | mriedem: I think the question probably should be A) do you regularly use the keypairs api | 15:15 |
| mriedem | basically what i don't like about Kevin's spec is the 2-3 step dance, which varies from cloud to cloud based on how cloud-init is configured in the image | 15:15 |
| mriedem | because it's (1) update server with new key_name, (2) reboot and check if that worked, else (3) rebuild | 15:15 |
| *** kfarr has joined #openstack-nova | 15:15 | |
| *** priteau has joined #openstack-nova | 15:15 | |
| mriedem | restricting it to just rebuild is definitely simpler | 15:15 |
| mriedem | maybe infra users could help here, since they also have a use case for updating keypair in an instance | 15:16 |
| *** dave-mccowan has quit IRC | 15:17 | |
| mriedem | i've also considered this might be something that needs to be discussed at the summit with ops and users in the room | 15:18 |
| *** trinaths has left #openstack-nova | 15:18 | |
| cfriesen | cdent: for https://review.openstack.org/#/c/508164/1/specs/queens/approved/symmetric-allocations.rst I assume that with the new microversion the data would be *required* to be in the dict form? The spec makes it sound optional. | 15:19 |
| *** dave-mccowan has joined #openstack-nova | 15:19 | |
| *** jmlowe has quit IRC | 15:19 | |
| sdague | mriedem: it's not really clear to me that there is any more feedback there then virtually | 15:20 |
| *** esberglu has joined #openstack-nova | 15:20 | |
| mriedem | sdague: isn't the point of the forum to get the devs and ops and users in the same room? | 15:20 |
| *** pcaruana has quit IRC | 15:20 | |
| *** priteau has quit IRC | 15:20 | |
| jaypipes | stephenfin: done | 15:21 |
| *** tbachman has joined #openstack-nova | 15:21 | |
| *** lnxnut has joined #openstack-nova | 15:21 | |
| *** felipemonteiro has joined #openstack-nova | 15:22 | |
| melwitt | sdague: ack, will review that spec | 15:22 |
| *** felipemonteiro_ has joined #openstack-nova | 15:23 | |
| cdent | cfriesen: sorry was on the phone. the idea is that if you want to do it the old way you can always use the old microversion | 15:23 |
| *** jmlowe has joined #openstack-nova | 15:23 | |
| stephenfin | jaypipes: sahid had a similar complaint about "correctly configured host". I'm working on a larger doc a la '/admin/cpu-topologies': do I need to have that done before this merges? | 15:24 |
| cdent | cfriesen: is there a specific place where I could make that more clear? | 15:24 |
| stephenfin | I didn't include it there and there's a million and one steps necessary and I didn't want to bloat that doc, which is a reference-style doc | 15:24 |
| stephenfin | *as there's | 15:24 |
| openstackgerrit | Andrey Volkov proposed openstack/nova master: AZ operations: check host has no instances https://review.openstack.org/509206 | 15:24 |
| *** tbachman has quit IRC | 15:25 | |
| jaypipes | stephenfin: I'd be cool with a comment on the commit message pointing to or referencing it | 15:26 |
| *** yamamoto has joined #openstack-nova | 15:26 | |
| jaypipes | stephenfin: be sure to mention the moon cycle and solar flares. | 15:26 |
| *** lajoskatona has quit IRC | 15:27 | |
| *** felipemonteiro has quit IRC | 15:27 | |
| sdague | mriedem: you get a really small micro slice of the devs and operators that also had a big travel budget and time | 15:27 |
| *** brault has quit IRC | 15:27 | |
| *** crushil has quit IRC | 15:28 | |
| jaypipes | sdague: micro slice, huh? is that a new container technology? :) | 15:28 |
| sdague | :) | 15:29 |
| *** itlinux has joined #openstack-nova | 15:29 | |
| sdague | really more of a uni-kernel .... | 15:29 |
| jaypipes | heh | 15:29 |
| mriedem | ok, so what's the point in going to the summit at all? | 15:29 |
| mriedem | but we've been here before, i don't mean to digress | 15:30 |
| gibi | mriedem: I'm thinking about skipping the notification subteam meeting not to disturb your spec review focus. Is that OK for you? | 15:31 |
| *** lnxnut has quit IRC | 15:31 | |
| mriedem | gibi: yeah | 15:31 |
| *** itlinux has quit IRC | 15:31 | |
| melwitt | mriedem: fwiw I know that at yahoo they inject keypairs via cloud-init and have wanted to be able to pass new userdata on a rebuild to update those | 15:31 |
| sdague | mriedem: because you get higher bandwidth ability to work through hard things | 15:31 |
| gibi | mriedem: OK | 15:31 |
| *** tbachman has joined #openstack-nova | 15:31 | |
| cfriesen | cdent: review updated | 15:33 |
| *** yamamoto has quit IRC | 15:34 | |
| *** penick has joined #openstack-nova | 15:35 | |
| *** coreywright has quit IRC | 15:37 | |
| *** crushil has joined #openstack-nova | 15:39 | |
| *** mvk has quit IRC | 15:40 | |
| *** coreywright has joined #openstack-nova | 15:40 | |
| *** user_am has joined #openstack-nova | 15:41 | |
| *** user_am is now known as amodi | 15:42 | |
| *** amodi is now known as archit | 15:42 | |
| *** namnh has quit IRC | 15:42 | |
| *** priteau has joined #openstack-nova | 15:42 | |
| *** namnh has joined #openstack-nova | 15:43 | |
| *** tbachman has quit IRC | 15:43 | |
| *** priteau has quit IRC | 15:43 | |
| *** itlinux has joined #openstack-nova | 15:44 | |
| *** dave-mcc_ has joined #openstack-nova | 15:44 | |
| *** brault has joined #openstack-nova | 15:45 | |
| *** psachin has quit IRC | 15:45 | |
| *** dave-mccowan has quit IRC | 15:46 | |
| *** namnh has quit IRC | 15:47 | |
| jaypipes | efried: you had a nice little ascii diagram in one of your review comments of a provider tree... which review/spec was that? | 15:48 |
| efried | jaypipes This is the one I just did a few minutes ago: https://review.openstack.org/#/c/502306/ | 15:48 |
| *** kuzko has quit IRC | 15:48 | |
| mriedem | melwitt: i'm confused, we don't allow passing in new user_data during rebuild | 15:49 |
| mriedem | oh, "have wanted" | 15:49 |
| jaypipes | efried: donkey shame. | 15:49 |
| *** tbachman has joined #openstack-nova | 15:49 | |
| efried | jaypipes bitter | 15:49 |
| mriedem | melwitt: maybe you want to comment on this then, https://review.openstack.org/#/c/509013/ because i said we wouldn't allow psasing user_data during rebuild even if we remove the ability to pass personality files during rebuild | 15:50 |
| melwitt | mriedem: yeah, just another data point on how ppl do ssh keys | 15:50 |
| melwitt | mriedem: o rly? I thought at the PTG what came out of that discussion was that we'd be allowing user_data during rebuild | 15:51 |
| *** tbachman_ has joined #openstack-nova | 15:52 | |
| *** archit has quit IRC | 15:52 | |
| *** gbarros has joined #openstack-nova | 15:53 | |
| melwitt | L441 on https://etherpad.openstack.org/p/nova-ptg-queens | 15:53 |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Add spec for symmetric GET and PUT of allocations https://review.openstack.org/508164 | 15:53 |
| *** tbachman has quit IRC | 15:54 | |
| *** tbachman_ is now known as tbachman | 15:54 | |
| mriedem | melwitt: i know, see the ML thread i just started | 15:55 |
| melwitt | okay | 15:56 |
| *** baoli_ has quit IRC | 15:58 | |
| *** baoli has joined #openstack-nova | 16:01 | |
| *** lucasagomes is now known as lucas-afk | 16:01 | |
| *** gyee has joined #openstack-nova | 16:02 | |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs master: Return Selection Objects https://review.openstack.org/498830 | 16:02 |
| *** archit_ has joined #openstack-nova | 16:05 | |
| *** smatzek has quit IRC | 16:07 | |
| sahid | mriedem: can you have this in your list for the spec review? https://review.openstack.org/#/c/485522/ | 16:07 |
| *** namnh has joined #openstack-nova | 16:07 | |
| sahid | jaypipes: ^ perhaps you can have a look, the code is ready but you might want this to wait for one of your work in-progress | 16:07 |
| *** smatzek has joined #openstack-nova | 16:07 | |
| jaypipes | mriedem, dansmith, bauzas, cdent: OK, I'm good with https://review.openstack.org/#/c/498830/. I say ship it. | 16:07 |
| mriedem | i'm still in keypair update land | 16:08 |
| jaypipes | heh, ok :) | 16:08 |
| *** yassine has quit IRC | 16:08 | |
| *** hemna__ has quit IRC | 16:09 | |
| *** smatzek_ has joined #openstack-nova | 16:10 | |
| *** smatzek_ has quit IRC | 16:10 | |
| bauzas | jaypipes: edleafe: I'm still not sold on the cell_uuid usefulness but meh | 16:11 |
| jaypipes | bauzas: I can see what edleafe was saying about being beneficial to the superconductor. | 16:11 |
| *** namnh has quit IRC | 16:12 | |
| *** smatzek has quit IRC | 16:12 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Support traits in the Ironic driver https://review.openstack.org/507052 | 16:12 |
| bauzas | jaypipes: sure, but adding a new field because of that doesn't seem very nice | 16:12 |
| jaypipes | bauzas: I don't think it hurts. | 16:13 |
| *** dave-mcc_ is now known as dave-mccowan | 16:13 | |
| bauzas | if we don't persist it, for sure | 16:13 |
| bauzas | but between a versioned field and just an object var, I'd tend to prefer an object variable | 16:14 |
| *** tonygunk has joined #openstack-nova | 16:14 | |
| bauzas | if that's just for helping to not lookup | 16:14 |
| bauzas | anyway, an implementation detail | 16:14 |
| *** yamahata has joined #openstack-nova | 16:14 | |
| mriedem | jaypipes: edleafe: confused about something in https://review.openstack.org/#/c/505209/ | 16:15 |
| dansmith | jaypipes: edleafe bauzas: yeah, edleafe's explanation makes sense to me.. if we make it an actual CellMapping object them we're sending credentials over the RPC wire, and we don't really need to do that, so just the uuid seems fine to me | 16:15 |
| mriedem | do we or do we not change GET /allocation_candidates, and if we do, is it just the response body that changes to show the root provider in the response? | 16:15 |
| bauzas | dansmith: if we can avoid a lookup, then okay | 16:16 |
| jaypipes | mriedem: you are correct. | 16:16 |
| bauzas | dansmith: the real problem I have with that is that (host, node, cell) is a single tuple | 16:17 |
| bauzas | I mean, those are interdependent | 16:17 |
| jaypipes | mriedem: well, not even the root provider ID. rather, the parent_provider_uuid will be included in the provider_summaries section and providers that aren't contained in allocation_requests will appear in the provider_summaries (if they are parents of allocated providers) | 16:17 |
| mriedem | jaypipes: ok then i'm going to update the nested rp spec quick to point out that distinction and then i'm +W | 16:17 |
| bauzas | here, we're creating 3 distinct fields but where 2 are related to the third | 16:17 |
| jaypipes | mriedem: ++ | 16:17 |
| bauzas | mriedem: well, good point | 16:17 |
| edleafe | mriedem: we don't change the API call as we do for GET /resource_providers. Both will have changed response bodies to include root/parent | 16:18 |
| edleafe | mriedem: that's noted in the first paragraph of that section | 16:18 |
| bauzas | edleafe: mriedem's point is that it's unclear | 16:19 |
| *** krtaylor has joined #openstack-nova | 16:19 | |
| *** brault has quit IRC | 16:19 | |
| *** xyang1 has joined #openstack-nova | 16:19 | |
| mriedem | edleafe: ok i guess "of appropriate placement REST APIs." is your way of saying GET /resource_providers and GET /allocation_candidates | 16:19 |
| mriedem | bauzas: right, it says, "There is no change proposed to `GET /allocation_candidates`" but clearly there is | 16:20 |
| mriedem | so i'll just update to say that the filter parameter won't be added to GET /allocation_candidates | 16:20 |
| bauzas | mriedem: ping me when you're done and I +2 | 16:20 |
| edleafe | mriedem: ok, I can clarify the wording | 16:20 |
| edleafe | oh wait, are you going to update? | 16:21 |
| bauzas | in the mean time, I'm disappearing for dinner | 16:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Re-propose nested resource providers spec https://review.openstack.org/505209 | 16:21 |
| mriedem | edleafe: ^ | 16:21 |
| edleafe | heh, question answered | 16:21 |
| mriedem | if that looks ok i'll +W | 16:21 |
| edleafe | mriedem: looks like you forgot to clean up L235 | 16:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'move-nova-cmds-to-cliff' spec https://review.openstack.org/433603 | 16:22 |
| *** sahid has quit IRC | 16:22 | |
| *** smatzek has joined #openstack-nova | 16:22 | |
| stephenfin | mriedem: I just dropped the nova-status bit. We can look at that separately down the line | 16:23 |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs master: Re-propose nested resource providers spec https://review.openstack.org/505209 | 16:23 |
| edleafe | mriedem: fixed it. Guess you need to re-+2 it | 16:23 |
| mriedem | edleafe: done | 16:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Re-propose nested resource providers spec https://review.openstack.org/505209 | 16:23 |
| mriedem | doh | 16:23 |
| *** smatzek_ has joined #openstack-nova | 16:23 | |
| edleafe | mriedem: well, looks good now | 16:24 |
| *** jmlowe has quit IRC | 16:24 | |
| ralonsoh | cdent, jaypipes: I was mixing concepts and terms in https://review.openstack.org/#/c/502306. Thanks for your reviews | 16:25 |
| jaypipes | ralonsoh: np | 16:25 |
| cdent | ralonsoh: it’s (too) easy to do | 16:25 |
| ralonsoh | jaypipes: I always have this in mind: https://youtu.be/LVkknWuGq_I?t=841 | 16:25 |
| *** yamahata has quit IRC | 16:25 | |
| *** smatzek has quit IRC | 16:27 | |
| mriedem | edleafe: we don't really need both https://blueprints.launchpad.net/nova/+spec/return-selection-objects and https://blueprints.launchpad.net/nova/+spec/return-alternate-hosts do we? | 16:27 |
| *** gbarros has quit IRC | 16:27 | |
| mriedem | alternate hosts depends on the selection object stuff, and that's just an object model thing | 16:27 |
| *** smatzek_ has quit IRC | 16:28 | |
| *** lnxnut has joined #openstack-nova | 16:29 | |
| edleafe | mriedem: the selection object spec only came about because of disagreement over a) whether it is needed at all, and b) what it should look like. It was simply a way to reach consensus. | 16:29 |
| mriedem | ok, but all code is going to be written under the return-alternate-hosts bp right? | 16:29 |
| edleafe | alternate hosts could work with the unstructured glob | 16:29 |
| *** smatzek has joined #openstack-nova | 16:29 | |
| mriedem | maybe i just don't know how you're going to split this up | 16:30 |
| stephenfin | jaypipes: Per comments on that doc you reviewed, you should probably look at https://review.openstack.org/#/c/461456/5 | 16:30 |
| edleafe | it's just the result of switching direction in the middle. Moving forward, let's put all the code under the return-alternate-hosts bp | 16:31 |
| mriedem | ok | 16:31 |
| jaypipes | stephenfin: you mean my "clear as mud..." comment? | 16:31 |
| stephenfin | claudiub: Think this is something you could tackle, given that you are the Hyper-V guy https://bugs.launchpad.net/nova/+bug/1660001 | 16:31 |
| openstack | Launchpad bug 1660001 in OpenStack Compute (nova) " Hyper-V PCI Passthrough" [Low,Confirmed] | 16:31 |
| stephenfin | jaypipes: Correct | 16:31 |
| jaypipes | stephenfin: heh, ok, will do. :) | 16:32 |
| *** sree has joined #openstack-nova | 16:32 | |
| stephenfin | fwiw, I get where sahid is coming from but I think it's a helpful enough usability improvement to warrant inclusion | 16:32 |
| stephenfin | jaypipes: Spot on | 16:32 |
| * stephenfin calls it for the evening | 16:32 | |
| *** smatzek has quit IRC | 16:33 | |
| mriedem | oh btw who is going to be brave and just push this through? https://review.openstack.org/#/c/457532/ | 16:35 |
| *** smatzek has joined #openstack-nova | 16:35 | |
| *** lnxnut has quit IRC | 16:36 | |
| *** tesseract has quit IRC | 16:37 | |
| *** kenperkins has joined #openstack-nova | 16:38 | |
| *** smatzek has quit IRC | 16:40 | |
| claudiub | stephenfin: docimpact, huh. hm, adding details about how to configure assignable PCI devices on Hyper-V in doc/source/admin/pci-passthrough.rst should be enough, IMO. any other thing is the same as other drivers. | 16:41 |
| *** peter-hamilton has joined #openstack-nova | 16:41 | |
| claudiub | stephenfin: will send a patch today / tomorrow | 16:41 |
| jaypipes | mriedem: done. | 16:44 |
| *** smatzek has joined #openstack-nova | 16:44 | |
| mriedem | danke | 16:45 |
| *** smatzek has quit IRC | 16:46 | |
| cfriesen | mriedem: I've reviewed https://review.openstack.org/#/c/381912 (Strict isolation of group of hosts for image and flavor) as promised. | 16:46 |
| *** abalutoiu has joined #openstack-nova | 16:48 | |
| mriedem | ok | 16:49 |
| openstackgerrit | Merged openstack/osc-placement master: CLI for resource providers https://review.openstack.org/457532 | 16:50 |
| *** smatzek has joined #openstack-nova | 16:51 | |
| *** slaweq_ has quit IRC | 16:51 | |
| *** priteau has joined #openstack-nova | 16:52 | |
| *** smatzek has quit IRC | 16:52 | |
| jaypipes | holy shit, the osc thing merged. | 16:52 |
| cdent | limited tess | 16:52 |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Spec for limiting GET /allocation_candidates https://review.openstack.org/504540 | 16:52 |
| cdent | ts | 16:52 |
| cfriesen | mriedem: I had an alternate proposal...rather than "strict" flags on the flavor/image (which would affect all the other image properties/flavor extra-specs) I think it'd make more sense to have a "strict" prefix on the metadata key in the host aggregate. | 16:53 |
| cfriesen | that way you could be strict on some keys but not on others | 16:53 |
| *** priteau has quit IRC | 16:54 | |
| efried | cdent Nits/questions https://review.openstack.org/#/c/508164/ | 16:54 |
| cdent | roger con aye | 16:54 |
| *** smatzek has joined #openstack-nova | 16:55 | |
| *** smatzek has quit IRC | 16:55 | |
| *** derekh has quit IRC | 16:55 | |
| *** smatzek has joined #openstack-nova | 16:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/489029 | 16:56 |
| *** esberglu has quit IRC | 16:58 | |
| *** sree has quit IRC | 16:58 | |
| *** yamahata has joined #openstack-nova | 16:58 | |
| *** esberglu has joined #openstack-nova | 16:58 | |
| cfriesen | I just noticed something really weird...can someone confirm? It looks like AggregateInstanceExtraSpecsFilter will *not* match if a flavor specifies something and a host is not in an aggregate or the aggregate metadata doesn't have what the flavor is looking for. | 17:00 |
| *** sree has joined #openstack-nova | 17:00 | |
| cfriesen | But it looks like AggregateImagePropertiesIsolation *will* match if the image specifies something that isn't in the aggregate metadata | 17:00 |
| cfriesen | AggregateInstanceExtraSpecsFilter loops over the flavor extra-specs looking for a match, but AggregateImagePropertiesIsolation loops over the aggregate metadata looking for a match. | 17:01 |
| *** crushil_ has joined #openstack-nova | 17:02 | |
| *** exarr has joined #openstack-nova | 17:02 | |
| *** baoli has quit IRC | 17:02 | |
| exarr | Anyone around I can ask about rabbit connection problems? | 17:02 |
| openstackgerrit | Merged openstack/nova-specs master: Return Alternate Hosts https://review.openstack.org/504275 | 17:02 |
| exarr | Invalid credentials it says. So I readd the user, change password, check the transtport_url details, all seems correct. | 17:02 |
| exarr | rabbit logs say "AMQPLAIN login refused: user 'openstack' - invalid credentials" | 17:02 |
| exarr | Seems clear cut, huh? | 17:03 |
| *** baoli has joined #openstack-nova | 17:03 | |
| *** ralonsoh has quit IRC | 17:03 | |
| *** edand has joined #openstack-nova | 17:04 | |
| *** nikhil_k has quit IRC | 17:04 | |
| *** kuzko has joined #openstack-nova | 17:04 | |
| *** ijw has joined #openstack-nova | 17:05 | |
| *** liangy has joined #openstack-nova | 17:06 | |
| *** gouthamr has joined #openstack-nova | 17:06 | |
| *** sree has quit IRC | 17:07 | |
| *** lyan has quit IRC | 17:07 | |
| *** sree has joined #openstack-nova | 17:07 | |
| *** namnh has joined #openstack-nova | 17:08 | |
| *** jpena is now known as jpena|off | 17:10 | |
| *** sree has quit IRC | 17:11 | |
| *** hemna__ has joined #openstack-nova | 17:12 | |
| *** namnh has quit IRC | 17:12 | |
| dansmith | mriedem: stephenfin: so what is the deal on this nova-manage spec? we're going to just dump syntax compatibility across one release? | 17:13 |
| *** Swami has joined #openstack-nova | 17:13 | |
| mriedem | i wondered about that too, since it said it was unavoidable when moving to cliff | 17:14 |
| mriedem | which is kind of a non-starter for me | 17:14 |
| dansmith | seems kinda bad to me | 17:14 |
| mriedem | you can't break everyone's tooling | 17:14 |
| mriedem | just because we don't like our under the hood impl | 17:14 |
| dansmith | right, that's my concern | 17:14 |
| mriedem | well, unless it's cells v1 :) | 17:14 |
| mriedem | then break away! | 17:14 |
| *** ociuhandu has quit IRC | 17:15 | |
| *** kukacz has quit IRC | 17:20 | |
| sdague | the flagging structure should be the same more or less | 17:20 |
| sdague | I guess the devil in the details there, but I wasn't imaging a big shift | 17:20 |
| openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Libvirt: Native LUKS decryption by QEMU https://review.openstack.org/490824 | 17:21 |
| *** baoli has quit IRC | 17:21 | |
| melwitt | I'd think we'd need a deprecation cycle for changing nova-manage syntax. is that clock already in motion? | 17:21 |
| *** baoli has joined #openstack-nova | 17:22 | |
| mriedem | sdague: cdent: this needs some more thought https://review.openstack.org/#/c/507762/ | 17:22 |
| mriedem | plus, it came up in newton | 17:22 |
| mriedem | and there are some issues to overcome | 17:22 |
| clarkb | as a drive by comment, the use of stevedore (via cliff aiui) in osc is what makes it so painfully slow to use for commands | 17:22 |
| clarkb | so please don't use entrypoints for cli commands | 17:23 |
| mriedem | dansmith: you too on https://review.openstack.org/#/c/507762/ because it would require paging instance actions across cells... | 17:23 |
| melwitt | good to know | 17:23 |
| mriedem | which we know is fun | 17:23 |
| mriedem | melwitt: there were some deprecations made in pike | 17:23 |
| mriedem | to prep for this in queens | 17:23 |
| cdent | ah, fart, forgot about cross cell biz | 17:23 |
| mriedem | it's not only that - it's that we literally don't update the updated_at column for intsance actions | 17:24 |
| mriedem | so filtering on changes-since for that is kind of dumb | 17:24 |
| *** efried has quit IRC | 17:24 | |
| dansmith | mriedem: ack will look | 17:24 |
| sdague | clarkb: it's not going to be entry points | 17:24 |
| mriedem | like i said, it's come up before | 17:24 |
| *** slaweq_ has joined #openstack-nova | 17:24 | |
| cdent | mriedem, why is that not a bug? (as in, to fix) | 17:24 |
| sdague | clarkb: it's just going to be non custom cli parsing | 17:24 |
| sdague | clarkb: there is nothing about stevedore here | 17:24 |
| mriedem | Kevin_Zheng is on holiday this week but i'll also bug him on the wechat-o-sphere | 17:24 |
| dansmith | mriedem: instance action list is per instance, right? so no paging across cells? | 17:25 |
| clarkb | sdague: I thought cliff had some baked in ideas of registering commands via stevedore as part of its command parsing | 17:26 |
| clarkb | sdague: but maybe its optional | 17:26 |
| *** kukacz has joined #openstack-nova | 17:27 | |
| cdent | mriedem: “ it's that we literally don't update the updated_at column for intsance actions” <- Is there a reason why for that? Isn’t that what updated_at means? | 17:27 |
| melwitt | I didn't think we updated individual instance action records. aren't they just written once? | 17:28 |
| *** slaweq_ has quit IRC | 17:28 | |
| *** slaweq_ has joined #openstack-nova | 17:28 | |
| melwitt | like, "instance created" "instance rebooted" "instance rebuilt" it's not like you go back and edit those | 17:28 |
| *** gjayavelu has joined #openstack-nova | 17:29 | |
| *** crushil_ has quit IRC | 17:29 | |
| dansmith | updated_at is built into oslo.db | 17:30 |
| dansmith | so if it's never set on those, it's because we never did a save, AFAIK | 17:30 |
| dansmith | there are other things missing in that spec, | 17:30 |
| dansmith | like it doesn't show them actually using the marker they say they're going to, | 17:30 |
| *** hferenc has quit IRC | 17:30 | |
| *** slaweq_ has quit IRC | 17:30 | |
| *** gabor_antal has quit IRC | 17:30 | |
| *** gabor_antal_ has joined #openstack-nova | 17:31 | |
| dansmith | but I assume they really mean start_time, which is its own field | 17:31 |
| dansmith | separate from the usual three default ones | 17:31 |
| *** hferenc has joined #openstack-nova | 17:31 | |
| dansmith | there is a finish_time on that object too | 17:31 |
| melwitt | yeah, I was trying to say I don't think instance action rows are ever saved, they're created/written once and that's it | 17:31 |
| sdague | melwitt: how is end time set then? | 17:31 |
| sdague | or, only if it's set all at once | 17:32 |
| dansmith | we can update them actually | 17:32 |
| dansmith | action_event_finish() | 17:32 |
| dansmith | sets the finish time and calls action.update() | 17:32 |
| melwitt | oh, weird | 17:32 |
| dansmith | I'd bet we don't finish all the actions we start though.. like everything else:P | 17:33 |
| *** lnxnut has joined #openstack-nova | 17:34 | |
| *** crushil has quit IRC | 17:35 | |
| *** ijw has quit IRC | 17:36 | |
| mriedem | i'd have to read back through the specs, but we create the action record and then we just deal with the events | 17:38 |
| mriedem | which are different records | 17:38 |
| mriedem | so there is event_start and event_finish | 17:39 |
| mriedem | and i don't see us ever updating the action record when the event is finished | 17:40 |
| *** itlinux has quit IRC | 17:41 | |
| *** ociuhandu has joined #openstack-nova | 17:41 | |
| dansmith | mriedem: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L6224 | 17:41 |
| dansmith | ohh, the action and event I'm getting confused I guess | 17:41 |
| dansmith | we actually just return the action from the action_finish() thing | 17:42 |
| dansmith | not sure why or how that makes sense | 17:42 |
| dansmith | but I guess that means we're never updating the _action_ | 17:42 |
| mriedem | correct | 17:42 |
| *** itlinux has joined #openstack-nova | 17:42 | |
| dansmith | it doesn't matter though, because changes-since should key on the start_time I would think | 17:42 |
| *** crushil has joined #openstack-nova | 17:42 | |
| dansmith | or it could be on max(start_time, finish_time) in case we ever set finish_time | 17:43 |
| dansmith | but not updated_at I wouldn't think | 17:43 |
| *** lnxnut has quit IRC | 17:43 | |
| melwitt | I think the question was, why isn't updated_at updated and I was saying because it's never updated | 17:43 |
| cdent | tautology alert | 17:44 |
| cdent | but: yes | 17:44 |
| melwitt | haha yeah | 17:44 |
| dansmith | melwitt: right, I get that, and it's because we're not updating it from action_finish | 17:44 |
| dansmith | melwitt: I had found action_event_finish() when looking for action_finish() which _does_ | 17:44 |
| melwitt | yeah | 17:44 |
| dansmith | I dunno _why_ we're not updating it during the finish, but.. | 17:44 |
| *** jmlowe has joined #openstack-nova | 17:45 | |
| melwitt | well, because each action is just "instance create started" "instance create finished" and they're separate right? | 17:45 |
| dansmith | regardless, I would expect changes-since on this kind of thing to use the inbuilt fields | 17:45 |
| dansmith | not the default one | 17:45 |
| melwitt | there's nothing to update about it, it's just there | 17:45 |
| dansmith | melwitt: except we have a finish method that doesn't finish it, and a finish_time field we never set, apparently | 17:45 |
| mriedem | dansmith: i don't think anything actually calls action_event_finish() | 17:45 |
| mriedem | i remember talking to laski about that at one point | 17:46 |
| melwitt | oh | 17:46 |
| mriedem | and it was like, something something tasks...we never used it | 17:46 |
| dansmith | fine, extend my argument to why we have those in addition to why they do nothing :) | 17:46 |
| mriedem | the EventReporter context manager calls objects.InstanceActionEvent.event_finish_with_failure | 17:46 |
| dansmith | it's beside the point though, IMHO | 17:46 |
| melwitt | I think I don't know what instance action events are. I'm just thinking of the "instance actions" which are a basic log of things that have happened to the instance | 17:47 |
| *** sambetts is now known as sambetts|afk | 17:47 | |
| *** sridharg has quit IRC | 17:47 | |
| mriedem | the events are tied to the action | 17:47 |
| dansmith | right, an action is a high level thing, | 17:48 |
| mriedem | see the EventReporter class | 17:48 |
| dansmith | events are small steps | 17:48 |
| *** itlinux has quit IRC | 17:48 | |
| mriedem | ever notice the @wrap_instance_event decorator on the compute manager methods? | 17:48 |
| mriedem | that creates the event start on entry, and event finish on exit | 17:48 |
| mriedem | the action record is created in the API before casting to compute where the real business happens, and that real bidness is recorded with events | 17:48 |
| mriedem | on the action | 17:48 |
| melwitt | bidness | 17:50 |
| melwitt | okay, so I guess someone forgot to ever finish_time instance actions after creating the data model | 17:51 |
| mriedem | jesus i thought this was merged in pike https://review.openstack.org/#/c/480746/ | 17:51 |
| mriedem | so ^ gives an example of how a user can use these things for polling when an operation is complete | 17:51 |
| melwitt | that's leet | 17:52 |
| mriedem | leet? | 17:53 |
| *** itlinux has joined #openstack-nova | 17:54 | |
| mriedem | also, note that if we ever rename methods in the compute manager which have the @wrap_instance_event decorator, we break that api | 17:55 |
| dansmith | which we have, I think | 17:55 |
| melwitt | like elite use of that API | 17:55 |
| dansmith | hasn't gibi complained? | 17:55 |
| mriedem | don't remember | 17:55 |
| dansmith | I think when we moved things from compute to conductor there was a thing about that | 17:55 |
| dansmith | I don't recall if there was an override to fix it or just "meh, this is an internal api" | 17:56 |
| mriedem | for events or notifications? | 17:56 |
| *** bnemec has quit IRC | 17:56 | |
| dansmith | oh yeah I guess I'm thinking of notifications | 17:56 |
| dansmith | but similar deal | 17:56 |
| *** itlinux has quit IRC | 17:58 | |
| *** bnemec has joined #openstack-nova | 18:01 | |
| *** dave-mccowan has quit IRC | 18:01 | |
| mriedem | heh coincidentally https://bugs.launchpad.net/nova/+bug/1719561 | 18:01 |
| openstack | Launchpad bug 1719561 in OpenStack Compute (nova) "Instance action's updated_at doesn't updated when action created or action event updated." [Undecided,In progress] - Assigned to Yikun Jiang (yikunkero) | 18:01 |
| *** slaweq_ has joined #openstack-nova | 18:01 | |
| mriedem | i guess they found this out on their own... | 18:01 |
| *** dave-mccowan has joined #openstack-nova | 18:03 | |
| *** baoli has quit IRC | 18:06 | |
| mriedem | huh we have no indexes on the events table | 18:06 |
| *** hferenc has quit IRC | 18:06 | |
| *** gabor_antal_ has quit IRC | 18:06 | |
| *** baoli has joined #openstack-nova | 18:06 | |
| *** hferenc has joined #openstack-nova | 18:07 | |
| *** jmlowe has quit IRC | 18:07 | |
| *** gabor_antal has joined #openstack-nova | 18:07 | |
| *** jmlowe has joined #openstack-nova | 18:09 | |
| *** dave-mccowan has quit IRC | 18:10 | |
| mriedem | might be time to fire up the ol' create 1000 instances and list some things out of the api machine | 18:10 |
| cdent | mriedem: one of the last times you did that there were 409s coming out of placement, did that ever get narrowed down, or did the rest of the world come rushing in and flush that for a while? | 18:11 |
| *** ijw has joined #openstack-nova | 18:12 | |
| *** dave-mccowan has joined #openstack-nova | 18:12 | |
| mriedem | i've got a patch | 18:12 |
| mriedem | but zuul has been zuuling it up | 18:12 |
| mriedem | https://review.openstack.org/#/c/507918/ | 18:12 |
| cdent | that’s the recreate patch, right, not the “here’s my theory” patch? | 18:13 |
| mriedem | it's a recreate yeah | 18:14 |
| mriedem | to see if we can find out from the logs where the 409 comes from | 18:14 |
| mriedem | what triggers it i mean | 18:14 |
| cdent | ✔ | 18:15 |
| cdent | cool, I just wanted to be sure I hadn’t missed a revelation | 18:15 |
| *** gabor_antal has quit IRC | 18:15 | |
| *** gabor_antal has joined #openstack-nova | 18:16 | |
| *** ijw has quit IRC | 18:16 | |
| *** jmlowe has quit IRC | 18:17 | |
| *** jmlowe has joined #openstack-nova | 18:17 | |
| mriedem | cdent: if you scroll down to the bottom http://logs.openstack.org/18/507918/4/check/legacy-tempest-dsvm-neutron-full/8f969e2/logs/devstacklog.txt.gz you'll see what's going on | 18:18 |
| mriedem | my check is failing, because i've apparently failed at bash | 18:19 |
| mriedem | sdague: maybe you know how to bashtastify this ^ https://review.openstack.org/#/c/507918/5/stack.sh | 18:19 |
| cdent | bash failing is an easy thing to do | 18:20 |
| *** esberglu has quit IRC | 18:20 | |
| *** esberglu has joined #openstack-nova | 18:21 | |
| *** markmcclain has quit IRC | 18:21 | |
| *** itlinux has joined #openstack-nova | 18:21 | |
| *** esberglu has quit IRC | 18:21 | |
| sdague | mriedem: I can look after, I have a call think shortly | 18:21 |
| *** esberglu has joined #openstack-nova | 18:22 | |
| mriedem | it could just be we didn't actually fail, or i timed out too early | 18:22 |
| *** priteau has joined #openstack-nova | 18:22 | |
| *** markmcclain has joined #openstack-nova | 18:23 | |
| mriedem | this is where it starts in the scheduler http://logs.openstack.org/18/507918/4/check/legacy-tempest-dsvm-neutron-full/8f969e2/logs/screen-n-sch.txt.gz#_Sep_28_20_12_08_486249 | 18:24 |
| mriedem | look at all of those beautiful uuids | 18:24 |
| mriedem | i seem to have also totally f'ed up the logging of the request id | 18:25 |
| mriedem | because the req-47868c4f-61d3-4c32-9ece-94fb6ad35404 used for the instance create it also being logged for running periodic tasks... | 18:26 |
| mriedem | cdent: heh, yeah, i think it actually scheduled the 500 instances | 18:27 |
| cdent | blargh | 18:27 |
| mriedem | yup | 18:28 |
| cdent | you want it to break, no break. want it to work, break. | 18:28 |
| mriedem | "Starting instance..." shows up 500 times in n-cpu | 18:28 |
| mriedem | well, i could bump it to 1000 instances | 18:28 |
| * cdent raises pinkie to mouth | 18:28 | |
| dansmith | lol | 18:28 |
| mriedem | ok bombs away with 1000 | 18:30 |
| mriedem | so there is no unique constraint on instance_actions.request_id, | 18:32 |
| mriedem | but we key off it in the API https://developer.openstack.org/api-ref/compute/#show-server-action-details | 18:33 |
| mriedem | so there should probably be a unique constraint on that column yes? | 18:33 |
| *** mingyu has quit IRC | 18:33 | |
| mriedem | comment in the code even says, | 18:34 |
| mriedem | "The intention is that there will only be one of these per user request. A | 18:34 |
| mriedem | lookup by (instance_uuid, request_id) should always return a single result." | 18:34 |
| mriedem | but don't bother enforcing that in the table schema... | 18:34 |
| exarr | Anyone around I can ask about rabbit connection problems? :-( | 18:35 |
| exarr | Invalid credentials it says. So I readd the user, change password, check the transtport_url details, all seems correct. | 18:35 |
| exarr | rabbit logs say "AMQPLAIN login refused: user 'openstack' - invalid credentials" | 18:35 |
| exarr | Seems clear cut, huh? | 18:35 |
| *** baoli has quit IRC | 18:35 | |
| *** slaweq_ has quit IRC | 18:35 | |
| *** slaweq_ has joined #openstack-nova | 18:35 | |
| *** baoli has joined #openstack-nova | 18:37 | |
| mriedem | exarr: are you using ocata+? | 18:40 |
| *** lnxnut has joined #openstack-nova | 18:41 | |
| mriedem | if so, you have to make sure the transport_url in your cell mappings records match | 18:41 |
| *** tbachman has quit IRC | 18:41 | |
| *** slaweq_ has quit IRC | 18:42 | |
| *** sean-k-mooney has quit IRC | 18:44 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512 | 18:45 |
| *** priteau has quit IRC | 18:47 | |
| *** smatzek has quit IRC | 18:48 | |
| *** smatzek has joined #openstack-nova | 18:50 | |
| *** smatzek has quit IRC | 18:50 | |
| *** lnxnut has quit IRC | 18:50 | |
| *** smatzek has joined #openstack-nova | 18:52 | |
| exarr | mriedem: Ocata, yes. | 18:56 |
| exarr | Just updated to latest today | 18:56 |
| *** mvk has joined #openstack-nova | 18:56 | |
| exarr | transport_url in the cell mapping? oooh. Let me have a look, thanks :-) | 18:56 |
| mriedem | nova-manage cell_v2 list_cells | 18:59 |
| mriedem | exarr: if you had to change the transport_url in config, the cell mappings are probably stale | 18:59 |
| mriedem | and that's what's being used when switching rpc context at runtime | 18:59 |
| mriedem | you can use the nova-manage cell_v2 update_cell command to update the transport_url for a given cell if needed | 19:00 |
| mriedem | esberglu: i've left some comments in https://review.openstack.org/#/c/503061/ but you can address those in a follow up if you want, or don't, whatever | 19:00 |
| *** peter-hamilton has quit IRC | 19:04 | |
| openstackgerrit | Merged openstack/nova-specs master: PowerVM Driver Integration (Queens) https://review.openstack.org/503061 | 19:05 |
| exarr | mriedem: hmmm. I think I have updated as you suggested. However I am still encountering the same problem. | 19:05 |
| exarr | It's very much as though the credentials are simply incorrect, or rabbit is not allowing the authentication ptotocol. | 19:07 |
| exarr | *protocol | 19:07 |
| exarr | Can I check the cell mapping details somehow? :-/ | 19:07 |
| mriedem | nova-manage cell_v2 list_cells --verbose | 19:08 |
| mriedem | will dump the cells and their transport_url as they are stored in the db | 19:08 |
| mriedem | keep in mind that if you update the cell's transport_url, you'll have to restart some services because those values are cached in memory | 19:08 |
| *** smatzek has quit IRC | 19:08 | |
| exarr | mriedem: ahhh. I'll restart the machine, that should help. | 19:08 |
| exarr | thanks for helping a noob. | 19:09 |
| esberglu | mriedem: I can fix it quick in that review. Unless you guys don't want to have to re-review, you seem busy atm | 19:10 |
| *** smatzek has joined #openstack-nova | 19:10 | |
| esberglu | In that case I'll take care of it later | 19:10 |
| mriedem | exarr: also fyi https://docs.openstack.org/nova/pike/user/cells.html#faqs | 19:10 |
| *** smatzek has quit IRC | 19:10 | |
| mriedem | see #2 | 19:10 |
| exarr | mriedem: I could bloody kiss you. | 19:11 |
| dansmith | ew, a bloody kiss? | 19:11 |
| dansmith | sounds terrible. | 19:11 |
| mriedem | only on goth thursdays please | 19:11 |
| exarr | :-) | 19:11 |
| *** slaweq_ has joined #openstack-nova | 19:12 | |
| *** MasterOfBugs has joined #openstack-nova | 19:13 | |
| *** smatzek has joined #openstack-nova | 19:15 | |
| *** hemna__ has quit IRC | 19:22 | |
| *** slaweq_ has quit IRC | 19:22 | |
| *** slaweq_ has joined #openstack-nova | 19:22 | |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Add spec for symmetric GET and PUT of allocations https://review.openstack.org/508164 | 19:23 |
| penick | And now I have an image of mriedem dressed up as The Crow. | 19:28 |
| cdent | penick: my eyes! | 19:29 |
| penick | You're welcome. | 19:29 |
| *** READ10 has quit IRC | 19:30 | |
| *** ijw_ has joined #openstack-nova | 19:30 | |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Add spec for symmetric GET and PUT of allocations https://review.openstack.org/508164 | 19:32 |
| *** catintheroof has quit IRC | 19:32 | |
| *** vvargaszte has joined #openstack-nova | 19:32 | |
| *** catintheroof has joined #openstack-nova | 19:32 | |
| melwitt | I wish I knew why we didn't already have disk quota in nova | 19:33 |
| penick | I thought it used to be there, but left when cinder split out | 19:34 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] gabbi tests for shared custom resource class https://review.openstack.org/485209 | 19:34 |
| melwitt | let me check the archived scrolls | 19:35 |
| penick | I think it was in folsom, but got 'et by the Grizzly | 19:35 |
| cdent | I’m now picturing melwitt (in the boots) sitting in dark loft with mriedem as crow “I wish I knew why…” | 19:35 |
| cdent | mriedem gets up slowly from his crushed velvet chair | 19:36 |
| cdent | fist clenched he walks to the broken window | 19:36 |
| cdent | and shouts into the city | 19:36 |
| melwitt | lol | 19:36 |
| penick | I just assumed that was how his home office was configured | 19:37 |
| cdent | WE STIILL DON’T KNOW | 19:37 |
| sdague | I really don't think it was ever implemented | 19:37 |
| penick | mriedem is an enigma wrapped in a tortilla | 19:37 |
| sdague | I thought I ran this code stream a couple months ago | 19:37 |
| sdague | because quota only matters for the things you have the least of | 19:38 |
| sdague | using local disk that's just there doing nothing on computers was never the limiting factor for rax | 19:38 |
| melwitt | yeah, so far not finding anything in the folsom-eol tag | 19:38 |
| mriedem | disk quota also gets goofed up when you're talking about boot from volume | 19:38 |
| * melwitt slowly backs away | 19:39 | |
| sdague | mriedem: right, there is quota on volumes, because that's off the expensive storage units | 19:39 |
| mriedem | is it that time of the week to link in that change again? | 19:39 |
| cdent | the words dripped from mriedem’s black lips | 19:39 |
| cdent | boot | 19:39 |
| cdent | from | 19:39 |
| cdent | volume | 19:39 |
| mriedem | https://review.openstack.org/#/c/428481/ | 19:39 |
| *** vvargaszte has quit IRC | 19:39 | |
| melwitt | so not only will ppl be complaining about consuming > 0 disk with BFV they'll also complain about consuming > 0 quota with BFV | 19:40 |
| sdague | heh | 19:40 |
| sdague | yeh, well landing that would clearly be a prereq | 19:40 |
| sdague | I guess disk quota only really makes sense when your instances are all on network storage like ceph or nfs, right? | 19:41 |
| melwitt | I have at least two patches that are like "the patches that shall not be named" | 19:41 |
| sdague | which basically didn't work back then anyway | 19:41 |
| melwitt | that one and then there's the thrice reverted bug fix one | 19:41 |
| *** sapcc-bot3 has quit IRC | 19:42 | |
| *** sapcc-bot has joined #openstack-nova | 19:42 | |
| *** efried has joined #openstack-nova | 19:43 | |
| mriedem | heh https://review.openstack.org/#/c/218639/ still around | 19:43 |
| melwitt | sdague: hm, yeah ... the spec says they want to be able to bill for storage and restrict storage and currently the only way to do that is with cinder volumes | 19:43 |
| mriedem | when is the last time someone ran the auto-abandon script | 19:43 |
| sdague | mriedem: it's been a while | 19:44 |
| mriedem | several other bugs like this: create instance, attach volume, snapshot instance (the snapshot image has bdms in it now), create another instance, rebuild that 2nd instance with the snapshot image with image-defined-bdms, kablammo | 19:45 |
| sdague | melwitt: right, I guess if you have flavors with a wide range of disk storage sizes, vs. coupling them to the mem/cpu sizing | 19:45 |
| *** gszasz has quit IRC | 19:46 | |
| sdague | mriedem: so... I feel like there were enough interesting side conversations about the key_pair thing that they probably warrent a summary email, they will not capture very cleanly in 2 specs and 4 irc threads | 19:47 |
| sdague | I can write that up if you like | 19:47 |
| melwitt | yeah, must be. I haven't really heard this come up before, so it's probably like you said, for most ppl the limiting factor is cpu/mem | 19:47 |
| *** lnxnut has joined #openstack-nova | 19:48 | |
| mriedem | sdague: that's probably a good idea | 19:48 |
| *** bnemec has quit IRC | 19:49 | |
| *** edand has quit IRC | 19:52 | |
| mriedem | is any of the accessIPv4 still valid? | 19:53 |
| mriedem | *accessIPv4 stuff | 19:53 |
| mriedem | that seems to be another one of those legacy things which we don't test but it's all over the api | 19:53 |
| mriedem | like diskConfig | 19:53 |
| sdague | it's user facing | 19:54 |
| sdague | and user updatable | 19:54 |
| sdague | sometimes it gets filled out, depending on the config | 19:54 |
| sdague | if you update it yourself, we don't validate it, it's just reflected | 19:55 |
| sdague | mriedem: ok, because it's been a while, a rebuild doesn't go through the scheduler, right? | 19:55 |
| *** archit_ is now known as archit | 19:55 | |
| *** edand has joined #openstack-nova | 19:55 | |
| sdague | you get to rebuild in place, which means it's probably faster because your base image is already tehre | 19:55 |
| sdague | correct? | 19:55 |
| mriedem | sdague: rebuild (not evacuate) bypasses the scheduler yes | 19:56 |
| sdague | I'm trying to make sure I cover all the reasons this could be interesting | 19:56 |
| *** jangutter has quit IRC | 19:58 | |
| *** jangutter has joined #openstack-nova | 19:58 | |
| *** lnxnut has quit IRC | 19:59 | |
| sdague | also, out of curiosity, because of the user scoping of keys, if you rebuild someone else's instance in the same project today, does it actually scope check the key and not add it? | 20:00 |
| penick | that's an interesting question | 20:02 |
| mriedem | sdague: you mean in the proposed spec? | 20:03 |
| mriedem | or today? | 20:03 |
| mriedem | because you can't change the key on rebuild today, hence the spec | 20:04 |
| sdague | mriedem: no | 20:04 |
| sdague | I mean, you build a server with your key | 20:05 |
| sdague | I'm in your project | 20:05 |
| sdague | I rebuild your server | 20:05 |
| sdague | but I'm not you | 20:05 |
| sdague | and I don't have access to your key | 20:05 |
| sdague | what happens | 20:05 |
| sdague | do we "never check that scope" | 20:06 |
| sdague | do we "check the scope and not add the key" | 20:06 |
| mriedem | just because you rebuild my server doesn't mean you get access to my key to ssh into it, right? | 20:06 |
| mriedem | so i'm not seeing the issue | 20:07 |
| *** liverpooler has quit IRC | 20:08 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: remove redundant preserve_ephemeral mention from rebuild docs https://review.openstack.org/509273 | 20:09 |
| penick | mriedem but isn't there a spec to add userdata to rebuild? | 20:10 |
| mriedem | no | 20:10 |
| penick | Or maybe I took crazy pills | 20:10 |
| mriedem | there is a spec to remove personality files from rebuild, | 20:10 |
| melwitt | penick: they're talking about the nova keypair API. | 20:10 |
| *** pchavva has quit IRC | 20:10 | |
| *** catintheroof has quit IRC | 20:10 | |
| mriedem | we're really talking about like 5 things | 20:11 |
| *** catintheroof has joined #openstack-nova | 20:11 | |
| mriedem | there is a spec proposed to pass a new key_name during rebuild, | 20:11 |
| mriedem | there is a spec proposed to remove peronality files from server create and rebuild | 20:11 |
| cfriesen | jaypipes: thanks for the suggestions on https://review.openstack.org/#/c/46820 (proposing "hw:realtime_cpu_set"). I imagine we'd need to support both "set" and "mask" for a release or two? | 20:11 |
| mriedem | the question came up if we should allow passing new user_data during rebuild if we're not going to allow passing personality files anymore, and the spec currently states that we will not allow that | 20:11 |
| penick | Yeah, my concern was if I can rebuild your instance, and that rebuild pulls in your user ssh keys, and If I can do something to inject my user into your instance on rebuild then i'd gain access to your ssh keys. | 20:12 |
| melwitt | penick: if two ppl are in the same project and one person A creates an instance with their --key_name in it and the second person B does a rebuild on person A's instance, what happens to the key | 20:12 |
| cfriesen | penick: resources are owned by projects, not individual users | 20:12 |
| mriedem | cfriesen: except keys | 20:12 |
| mriedem | penick: i think your question belongs in https://review.openstack.org/#/c/375221/ | 20:13 |
| mriedem | in the security impact section | 20:13 |
| *** smatzek has quit IRC | 20:13 | |
| cfriesen | penick: mriedem: logically though any keys should belong to the project, not the individual user | 20:13 |
| mriedem | i think what would happen here is if you specified a new key_name during rebuild, we are going to be looking up that keypair in the api to see if it exists, | 20:14 |
| mriedem | that check is going to use the context.user_id, | 20:14 |
| *** smatzek has joined #openstack-nova | 20:14 | |
| mriedem | and if you're rebuilding my server, and don't have access to my keys, that keypair lookup will fail and you'll get an error | 20:14 |
| mriedem | now if user A and user B are in the same project, and both have a key named mykey, that could work, but the user A mykey and user B mykey should still be different | 20:14 |
| penick | melwitt: yeah that's what i'm wondering | 20:15 |
| cfriesen | mriedem: why did we ever tie keys to users? | 20:15 |
| *** smatzek_ has joined #openstack-nova | 20:16 | |
| mriedem | you will have to ask someone else | 20:16 |
| mriedem | but, why wouldn't we? | 20:16 |
| mriedem | keys are private | 20:16 |
| penick | cfriesen: it makes sense for user ssh keys. Just not for headless keys or server keys | 20:16 |
| melwitt | probably bc when you create one via the API it gives you the private key | 20:16 |
| cfriesen | mriedem: instances are owned by the project. keys are used to access instances. therefore keys should be owned by the project | 20:17 |
| mriedem | are we venturing into the application credentials hullabaloo? | 20:17 |
| sdague | it is only the public keys that we store | 20:17 |
| sdague | so it's not really a security risk | 20:17 |
| sdague | but it's funny that you can't list those keys for other users | 20:17 |
| sdague | but they can be put on a server for you | 20:18 |
| cfriesen | melwitt: sure, then you dump the private key into some local "project team storage area" with permission controls | 20:18 |
| *** smatzek has quit IRC | 20:18 | |
| dansmith | does this matter at all? we'd have to do some pretty major surgery to change the ownership of keys, and it would be hard to support old microversions for them | 20:18 |
| sdague | cfriesen: keys attached to users are from "the before time" | 20:18 |
| dansmith | unless we're really going to change key ownership, we might as well talk about problems we're going to solve | 20:19 |
| sdague | dansmith: yeh, it's just an interesting edge question about how the system works because of the scope mismatch | 20:20 |
| dansmith | sure, | 20:20 |
| *** smatzek_ has quit IRC | 20:20 | |
| dansmith | but then we can move on once identified right? :) | 20:20 |
| *** david-lyle has quit IRC | 20:20 | |
| sdague | anyway, I tried to build a summary email from all the conversations I saw today | 20:21 |
| cfriesen | dansmith: fair enough...so in mriedem's scenario would we allow user B to replace user A's "mykey" with user B's "mykey" on a rebuild? | 20:21 |
| *** artom has quit IRC | 20:21 | |
| *** david-lyle has joined #openstack-nova | 20:21 | |
| dansmith | IMHO, if you specify a key, it's looked up based on your context, and if that's your key instead of the original one, then so be it | 20:21 |
| sdague | dansmith: sure, I just think it might be an unexpected thing | 20:21 |
| dansmith | if you don't, then we should keep the same I think | 20:21 |
| *** itlinux has quit IRC | 20:22 | |
| dansmith | sdague: if you specify a key? you can't list other people's keys so what other intent could the user have if they specify one? | 20:22 |
| penick | Well for preserving the host key, the private key will need to be stored as well | 20:22 |
| *** edand has quit IRC | 20:22 | |
| sdague | penick: we don't do that | 20:22 |
| penick | there's no point in keeping a public ssh host key, if you don't preserve the private key | 20:22 |
| dansmith | penick: we do nothing with the host key | 20:22 |
| dansmith | these are all user access keys we're talking about | 20:22 |
| penick | Oh hell, I completely misunderstood this spec. | 20:22 |
| *** corey_ has quit IRC | 20:22 | |
| sdague | this is all just the root ssh key | 20:22 |
| sdague | root user | 20:23 |
| dansmith | not even root, | 20:23 |
| sdague | being configed on cloud init | 20:23 |
| dansmith | whatever user the image has for access | 20:23 |
| sdague | dansmith: yeh, right | 20:23 |
| mriedem | cfriesen: ok, so i think what would probably need to happen for rebuild, is if another user does the rebuild, then we have to lookup the keypair by the instance.user_id, | 20:24 |
| mriedem | not the context.user_id | 20:24 |
| dansmith | and doesn't specify a key.. agreed | 20:24 |
| dansmith | we just have to be careful not to expose non-project-user keys when we're doing that override, | 20:25 |
| dansmith | since it happens deep in the db layer I think | 20:25 |
| sdague | yeh, I just wonder what happens in the current code | 20:25 |
| dansmith | sdague: we fail I think | 20:25 |
| *** david-lyle has quit IRC | 20:25 | |
| penick | ahhh ok. So not a security issue then. Usually people want to preserve the ssh host key between reimages. I do think this is an operability issue if keys stay scoped to only a user, instead of a tenant. | 20:25 |
| mriedem | you can't specify a new key on rebuild today, so i'm lost as to what the concerns are about the current code | 20:25 |
| *** kenperkins has quit IRC | 20:25 | |
| dansmith | I thought we break if another user tries to rebuild today, no? | 20:26 |
| sdague | dansmith: I don't know if we do, that was the question | 20:26 |
| sdague | rebuild is an instance operation that's project scoped | 20:26 |
| sdague | and keys are user scoped | 20:26 |
| sdague | and I actually haven't checked if B rebuilds a server that A built with A's key if it: a) still has that key, b) has no key, c) errors out | 20:27 |
| sdague | I'll do some testing around that in the morning, my end of day is now | 20:27 |
| dansmith | sdague: right, I thought it was an oopsie on our part that other users couldn't rebuild successfully | 20:28 |
| mriedem | on a rebuild today, we'll use the original key associated with the instance when it was created | 20:28 |
| mriedem | regardless of who rebuilds the isntance | 20:28 |
| dansmith | people want a key during rebuild for taking ownership I think, but that's a destructive operation and not a good argument, IMHO | 20:28 |
| sdague | mriedem: ok, cool | 20:28 |
| dansmith | mriedem: okay, i thought there was a whole big stink about us not being able to look up the key again on rebuild if triggered by another user | 20:28 |
| sdague | dansmith: no, it was a question because of the scoping difference. | 20:29 |
| mriedem | as far as i know, TODAY, we don't ever look up the key during rebuild, | 20:29 |
| *** cdent has quit IRC | 20:29 | |
| mriedem | because you can't change it | 20:29 |
| dansmith | okay | 20:29 |
| mriedem | the only thing i think that happens today, | 20:30 |
| sdague | mriedem: well, it has to be looked up to go in the config drive, right? | 20:30 |
| mriedem | is when driver.spawn happens, we rebuild config drive, and that's going to call the InstanceMetadata code to get the keypair | 20:30 |
| mriedem | to shove into the config drive | 20:30 |
| mriedem | sdague: yes | 20:30 |
| mriedem | and that is the keypair that's stashed in the instance | 20:31 |
| mriedem | just like a flavor | 20:31 |
| dansmith | but we store that on the instance | 20:31 |
| dansmith | right | 20:31 |
| *** eharney has quit IRC | 20:31 | |
| dansmith | maybe this was broken before and now isn't | 20:31 |
| sdague | we store keypair name | 20:31 |
| dansmith | sdague: no we store the whole thing | 20:31 |
| *** dave-mccowan has quit IRC | 20:31 | |
| mriedem | we store the whole gd thing | 20:31 |
| dansmith | sdague: keypairs live in the api db and compute can't get them | 20:31 |
| sdague | oh | 20:31 |
| mriedem | https://github.com/openstack/nova/blob/cfff910b0d1a0d9f24b6c1596ceef8dd6b8b3ac6/nova/api/metadata/base.py#L355 | 20:31 |
| sdague | ok, so yeh, maybe cells v2 did move this around and fix a thing | 20:31 |
| dansmith | um, ya'll'er welcome? | 20:32 |
| *** itlinux has joined #openstack-nova | 20:32 | |
| sdague | dansmith: so, the use case that people seem to want is because keeping IP and device model (mac address) is useful to folks | 20:32 |
| dansmith | but changing ownership via key, yeah | 20:33 |
| mriedem | you also keep your volumes attached | 20:33 |
| sdague | mriedem: right | 20:33 |
| dansmith | I get why people want that | 20:33 |
| dansmith | I wish they didn't want it, but.. | 20:33 |
| sdague | I'd still like a more detailed set of use cases in the spec. | 20:34 |
| *** jmlowe has quit IRC | 20:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: add note about rebuild not replacing volume-backed root disk https://review.openstack.org/509282 | 20:36 |
| mriedem | ^ is my answer to the buttload of duplicate bugs | 20:37 |
| *** kenperkins has joined #openstack-nova | 20:40 | |
| *** catintheroof has quit IRC | 20:42 | |
| *** catintheroof has joined #openstack-nova | 20:42 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient stable/newton: Fix aggregate_update name and availability_zone clash https://review.openstack.org/507816 | 20:43 |
| sdague | mriedem: so rebuild on bfv is just a reboot? | 20:44 |
| sdague | it might be better to actually make that a 400 | 20:44 |
| sdague | because it's not actually doing what the user expects | 20:44 |
| dansmith | sdague: but evacuate (rebuild) on BFV is hiiiiiiighly utilized | 20:45 |
| *** archit has quit IRC | 20:45 | |
| dansmith | which is a little different, granted, but.. | 20:45 |
| mriedem | can't specify a new image on evacuate | 20:45 |
| dansmith | rebuild on bfv with a key becomes more useful | 20:45 |
| dansmith | right I know | 20:45 |
| mriedem | the issue here is you specify a different image on rebuild | 20:45 |
| sdague | right | 20:45 |
| cfriesen | sdague: you can specify a different personality on rebuild | 20:45 |
| dansmith | ah, if you specify an image sure | 20:45 |
| mriedem | i really need to just get a devstack setup and play with some of this a bit, because a lot of the bug reports are really old and confusing, and mixing issues | 20:45 |
| sdague | mriedem: yeh | 20:46 |
| sdague | I was thinking about doing that tomorrow morning | 20:46 |
| mriedem | the linked bug in there shows a recreate where the rebuild doesn't fail but doesn't change the root disk either | 20:46 |
| sdague | and just mapping out the space a bit | 20:46 |
| mriedem | it does change the instance image ref | 20:46 |
| cfriesen | mriedem: I think we hit that one....was sort of confusing due to the mismatch | 20:46 |
| mriedem | but, that's probably because we change that in the api | 20:46 |
| mriedem | i bet the rebuild actually fails on the compute | 20:47 |
| mriedem | because we can't detach the root disk | 20:47 |
| mriedem | also, unrelated, i just updated an approved change and removed something in the commit message, and it re-applied the +W on the patch | 20:49 |
| *** flanders_ has joined #openstack-nova | 20:49 | |
| mriedem | which seems like odd new behavior | 20:49 |
| mriedem | https://review.openstack.org/#/c/507816/5..6 | 20:49 |
| sdague | if it's litterally exactly the same patch, I though all the votes come back | 20:50 |
| sdague | https://review.openstack.org/#/c/507816/1..6 | 20:50 |
| sdague | because you +W PS1 | 20:51 |
| sdague | and 6 is the same as 1 bit for bit, the votes pop back | 20:51 |
| melwitt | I had thought commit messages counted as part of the patch in the past | 20:51 |
| sdague | message contents | 20:51 |
| sdague | not metadata | 20:51 |
| sdague | the commit message is also the same | 20:52 |
| melwitt | mriedem changed the commit message in PS6 | 20:52 |
| melwitt | oh, you're saying it's the same as PS1 | 20:53 |
| melwitt | I see now | 20:53 |
| *** smatzek has joined #openstack-nova | 20:55 | |
| *** smatzek has quit IRC | 20:56 | |
| *** smatzek has joined #openstack-nova | 20:57 | |
| *** itlinux has quit IRC | 20:57 | |
| openstackgerrit | Merged openstack/nova-specs master: Libvirt: Native LUKS decryption by QEMU https://review.openstack.org/490824 | 20:59 |
| melwitt | I put up a spec for counting instances, CPU, RAM from placement https://review.openstack.org/#/c/509042 and it seems like we'd need a new query in placement to be able to figure out "instances" | 20:59 |
| melwitt | unless I'm missing something | 20:59 |
| mriedem | melwitt: we have the consumers table | 20:59 |
| mriedem | s/table/api/ | 20:59 |
| mriedem | although, that's going to contain migration records now too... | 20:59 |
| melwitt | oh, I was wondering about that. it's not merged yet right? I didn't find anything in the code or the placement api-ref | 21:00 |
| mriedem | consumers is in the api-ref for placement | 21:00 |
| * melwitt looks again | 21:00 | |
| *** crushil has quit IRC | 21:00 | |
| mriedem | oh nvm it's not | 21:00 |
| mriedem | there must be a change up for that | 21:00 |
| mriedem | avolkov probably knows | 21:01 |
| *** ragiman has quit IRC | 21:01 | |
| *** avolkov has quit IRC | 21:01 | |
| dansmith | mriedem: and anything else that isn't an instance | 21:01 |
| melwitt | I hadn't seen anything about consumers in https://github.com/openstack/nova/tree/master/nova/api/openstack/placement/handlers either | 21:01 |
| dansmith | like, anything could claim some space on a cinder provider that isn't an instance | 21:02 |
| exarr | Anyone able to offer a decent link to multi-regions for ocata? (Ubuntu) | 21:02 |
| exarr | (as in to learn) | 21:02 |
| melwitt | okay, that's what I was wondering, whether we could assume consumers are instances. so apparently not | 21:03 |
| dansmith | nope | 21:03 |
| *** jmlowe has joined #openstack-nova | 21:03 | |
| dansmith | that's why they're called consumers and not instances :P | 21:03 |
| melwitt | well, yeah. I thought someone had said we could derive it from allocations and I guess I didn't know how else other than consumers | 21:03 |
| *** itlinux has joined #openstack-nova | 21:03 | |
| dansmith | well same deal, allocations could be for other things | 21:04 |
| melwitt | instance mappings would work but they will also contain deleted instances | 21:04 |
| dansmith | yeah | 21:04 |
| *** boris_42_ has joined #openstack-nova | 21:05 | |
| melwitt | my initial thought was, put a deleted column on instance mapping. but that comes with the challenge of "if delete fails, don't set it." maybe if we hooked it up to instance.destroy() and set the flag from there it would work | 21:07 |
| *** namnh has joined #openstack-nova | 21:10 | |
| *** crushil has joined #openstack-nova | 21:11 | |
| *** david-lyle has joined #openstack-nova | 21:11 | |
| *** namnh has quit IRC | 21:15 | |
| jaypipes | cfriesen: yeah, no way around that (supporting both for a release or two). | 21:17 |
| *** baoli has quit IRC | 21:19 | |
| efried | jaypipes Where do we stand on specs like https://review.openstack.org/#/c/485522/ which include a) enhancements to the existing PCI manager code; which also talk about b) new trait- or inventory-ish additions to the [pci]passthrough_whitelist in same ? | 21:22 |
| efried | jaypipes There's a kind of push for (a) to do stuff we want sooner than it would be possible under NRP/GDM. And (b) is compounding a problem we're explicitly getting rid of... but getting rid of *later*; i.e. it'll all go away at once, so does it matter that we add to it now? | 21:23 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Add ScaleIO ephemeral storage backend https://review.openstack.org/495922 | 21:23 |
| *** slaweq_ has quit IRC | 21:27 | |
| cfriesen | jaypipes: pretty much what I figured. I'll try and respin along the lines of your suggestion. Also, could you take a look at https://review.openstack.org/#/c/339715/ ? | 21:28 |
| dansmith | melwitt: deletes are finished on compute nodes, which can't access that bit | 21:29 |
| *** smatzek has quit IRC | 21:29 | |
| dansmith | melwitt: and we also said we weren't going to do soft deleted stuff in the api db, because it will only get _more_ out of sync than it does today | 21:29 |
| melwitt | dansmith: if it's in Instance.destroy wouldn't that happen in conductor? or you're saying cell conductor not supposed to access API DB | 21:30 |
| dansmith | melwitt: cell conductor can't talk to the api db right | 21:31 |
| melwitt | yeah, just brainstorming. AFAIK there's no way to determine instances from placement. I guess could count allocations of "CPU" or something like that? | 21:31 |
| dansmith | except if something outside of nova has allocations for your tenant, | 21:31 |
| dansmith | like bifrost or mogan :) | 21:31 |
| melwitt | would they not use a different resource class than our canned ones? | 21:32 |
| dansmith | it's not NOVA_CPU, it's CPU | 21:32 |
| dansmith | and MEMORY_MB and DISK_GB | 21:32 |
| dansmith | (actually VCPUS, but you get the idea) | 21:33 |
| openstackgerrit | Merged openstack/nova-specs master: Add a spec for minimal cache headers in placement https://review.openstack.org/496853 | 21:33 |
| melwitt | so we should abandon the idea of trying to count resources in placement? if something outside nova can consume CPU and RAM, then we wouldn't want to compare those against nova quota | 21:34 |
| *** gyee has quit IRC | 21:34 | |
| dansmith | I guess that's a good point | 21:34 |
| *** smatzek has joined #openstack-nova | 21:35 | |
| dansmith | at ptg we were talking about using placement to make sure that nova and straight ironic uses don't step on each other's compute nodes | 21:35 |
| dansmith | and this'd be a similar thing if mogan or zun or something like that was in the picture | 21:36 |
| mriedem | dansmith: another fun paging spec https://review.openstack.org/#/c/506030/3 | 21:36 |
| dansmith | we could just say that you have to have different tenants, but that's not always going to work and counting usage by other services as quota in nova is just not right at all | 21:36 |
| melwitt | yeah | 21:36 |
| openstackgerrit | Merged openstack/nova-specs master: Add ScaleIO ephemeral storage backend https://review.openstack.org/495922 | 21:36 |
| dansmith | mriedem: ah yeah that one has to legit be cells aware | 21:37 |
| *** armax has quit IRC | 21:37 | |
| *** claudiub has quit IRC | 21:38 | |
| *** liangy has quit IRC | 21:38 | |
| *** lyan has joined #openstack-nova | 21:39 | |
| mriedem | so begins my great recheckaning | 21:40 |
| dansmith | mriedem: so do I just get all future pagination specs to review? | 21:41 |
| dansmith | I'm so thrilled. | 21:41 |
| *** priteau has joined #openstack-nova | 21:41 | |
| *** priteau has quit IRC | 21:41 | |
| mriedem | dansmith: you are mr multi-cells | 21:41 |
| mriedem | so yes | 21:41 |
| mriedem | to be fair, these were all approved back in newton apparently, but never merged | 21:41 |
| mriedem | oh yeah, on that migrations paging one, | 21:42 |
| mriedem | i noted that the marker they propose won't work | 21:42 |
| dansmith | yep | 21:42 |
| *** ijw_ has quit IRC | 21:43 | |
| melwitt | I know, we could have consumer classes in a class column! "nova_instance" | 21:45 |
| mriedem | consumer_type=instance | 21:45 |
| mriedem | :) | 21:45 |
| mriedem | it would be like osc | 21:45 |
| dansmith | so, I thought at one point about having each instance consume one instance type | 21:45 |
| *** david-lyle has quit IRC | 21:45 | |
| dansmith | it's breaking the model though | 21:45 |
| dansmith | what we need, IMHO, is the thing I suggested back in bristol when we were talking about this, | 21:46 |
| dansmith | which is a service type on a consume (and maybe resource provider too), | 21:46 |
| dansmith | so we know "this consumer is an instance" and "this provider is a compute node" | 21:46 |
| dansmith | but jaypipes shot me down | 21:46 |
| melwitt | yeah, on the surface I think it makes sense to be able to have some more info about consumers | 21:46 |
| dansmith | IMHO, doing quotas in placement isn't critical and probably not worth that much trouble, at least at the moment | 21:48 |
| dansmith | if people actually start deploying multiple cells and hit dead cells and perf issues, then we might do this to fix that, or we might have to do something totally differently | 21:48 |
| dansmith | depending on what that data tells us | 21:48 |
| melwitt | yeah, I didn't expect it to be this complex when I proposed it, so I'm cool with punting it for later | 21:48 |
| dansmith | yeah, I should have thought of the other-things-consume-stuff thing earlier | 21:49 |
| dansmith | so blame me | 21:49 |
| melwitt | heh | 21:50 |
| *** smatzek has quit IRC | 21:51 | |
| *** mmehan has quit IRC | 21:51 | |
| *** smatzek has joined #openstack-nova | 21:52 | |
| *** itlinux has quit IRC | 21:53 | |
| *** esberglu has quit IRC | 21:53 | |
| *** aries has quit IRC | 21:54 | |
| *** lnxnut has joined #openstack-nova | 21:55 | |
| *** smatzek has quit IRC | 21:56 | |
| *** edmondsw has quit IRC | 21:57 | |
| *** slaweq_ has joined #openstack-nova | 21:58 | |
| jaypipes | efried: I believe I already commented on that particular spec? | 21:59 |
| jaypipes | dansmith: actually it's VCPU, not VCPUS :) | 21:59 |
| dansmith | jaypipes: yeah yeah | 22:00 |
| jaypipes | dansmith: I originally had the can_host attribute of the resource_providers table but edleafe shot me down and said we could just use a trait to indicate a sharing provider. | 22:01 |
| jaypipes | edleafe is now under the bus that jaypipes was under. | 22:01 |
| dansmith | jaypipes: yeah can_host was wrong | 22:01 |
| jaypipes | also, jaypipes now heads to dinner with wifey.' | 22:01 |
| dansmith | we could do it on providers with traits for sure | 22:01 |
| *** xyang1 has quit IRC | 22:02 | |
| melwitt | we could have a who_dat attribute on consumers | 22:02 |
| penick | hah | 22:05 |
| efried | jaypipes You did, on a couple that had that issue, but didn't address that issue specifically. | 22:06 |
| efried | I mean, I'd like to be able to say, "-1: we're not mucking with the PCI manager." and/or, "-1: we're not going to do any (more) overloading of the whitelist for non-whitelisty stuff." | 22:07 |
| *** lnxnut has quit IRC | 22:07 | |
| efried | But I don't feel that "we" have fully landed on either policy. | 22:07 |
| dansmith | I do | 22:08 |
| *** yassine has joined #openstack-nova | 22:08 | |
| efried | dansmith In the negative? | 22:13 |
| dansmith | efried: I feel like both your -1 reasons are supported by the feelings of people who have expressed feelings on the matter | 22:13 |
| *** burt has quit IRC | 22:15 | |
| *** tonygunk has quit IRC | 22:15 | |
| *** tonygunk has joined #openstack-nova | 22:16 | |
| *** krtaylor has quit IRC | 22:17 | |
| *** gouthamr has quit IRC | 22:21 | |
| *** acormier has quit IRC | 22:22 | |
| *** claudiub has joined #openstack-nova | 22:23 | |
| *** lyan has quit IRC | 22:28 | |
| *** slaweq_ has quit IRC | 22:31 | |
| *** penick has quit IRC | 22:31 | |
| *** lbragstad has quit IRC | 22:34 | |
| *** slaweq_ has joined #openstack-nova | 22:40 | |
| mriedem | instance action events in action http://paste.openstack.org/show/622590/ | 22:42 |
| mriedem | so apparently rebuilding a bfv instance does not fail | 22:42 |
| mriedem | sdague: ^ | 22:42 |
| mriedem | created a bootable volume with an image, created a server from that volume, then rebuilt it with the same image that is in the volume, no failures | 22:43 |
| mriedem | it won't replace the root disk, but it doesn't explode | 22:46 |
| *** mingyu has joined #openstack-nova | 22:49 | |
| *** gouthamr has joined #openstack-nova | 22:50 | |
| *** jaypipes has quit IRC | 22:50 | |
| *** jmlowe has quit IRC | 22:51 | |
| *** jmlowe has joined #openstack-nova | 22:52 | |
| *** armax has joined #openstack-nova | 22:53 | |
| *** jmlowe has quit IRC | 22:53 | |
| *** kenperkins has quit IRC | 22:53 | |
| *** mingyu has quit IRC | 22:53 | |
| *** sdague has quit IRC | 22:56 | |
| cfriesen | mriedem: I think I found something a bit "off", though most of the time it shouldn't cause problems. In online_data_migrations() we call aggregate_obj.migrate_aggregates(), which copies the data over to the api_db and then calls db.aggregate_delete() but never deletes the entries in 'aggregate_hosts' or 'aggregate_metadata' | 22:56 |
| *** chyka_ has joined #openstack-nova | 22:57 | |
| cfriesen | mriedem: normally we'd only delete aggregates that don't have any hosts in them, but the migration code doesn't do that check | 22:57 |
| *** jmlowe has joined #openstack-nova | 22:58 | |
| *** chyka has quit IRC | 23:00 | |
| *** awaugama has quit IRC | 23:00 | |
| *** catintheroof has quit IRC | 23:01 | |
| *** chyka_ has quit IRC | 23:01 | |
| cfriesen | whoops, I'm wrong about not deleting the aggregate_metadata, that's handled in aggregate_delete(). But unless I'm missing something else I don't think we delete all the entries in table 'aggregate_hosts' | 23:03 |
| *** lnxnut has joined #openstack-nova | 23:04 | |
| *** hongbin has quit IRC | 23:05 | |
| *** namnh has joined #openstack-nova | 23:07 | |
| *** ijw has joined #openstack-nova | 23:09 | |
| *** slaweq_ has quit IRC | 23:13 | |
| *** lnxnut has quit IRC | 23:14 | |
| *** claudiub has quit IRC | 23:15 | |
| *** felipemonteiro_ has quit IRC | 23:17 | |
| *** itlinux has joined #openstack-nova | 23:21 | |
| *** slaweq_ has joined #openstack-nova | 23:24 | |
| *** bnemec has joined #openstack-nova | 23:25 | |
| *** chyka has joined #openstack-nova | 23:26 | |
| *** abalutoiu has quit IRC | 23:27 | |
| *** acormier has joined #openstack-nova | 23:29 | |
| *** chyka has quit IRC | 23:30 | |
| *** acormier has quit IRC | 23:31 | |
| *** acormier has joined #openstack-nova | 23:31 | |
| *** kenperkins has joined #openstack-nova | 23:31 | |
| openstackgerrit | Merged openstack/python-novaclient stable/newton: Fix aggregate_update name and availability_zone clash https://review.openstack.org/507816 | 23:32 |
| *** itlinux has quit IRC | 23:32 | |
| *** takashin has joined #openstack-nova | 23:33 | |
| *** acormier has quit IRC | 23:39 | |
| *** mriedem has quit IRC | 23:39 | |
| *** acormier has joined #openstack-nova | 23:39 | |
| *** namnh has quit IRC | 23:42 | |
| *** acormier has quit IRC | 23:44 | |
| *** david-lyle has joined #openstack-nova | 23:44 | |
| *** Swami has quit IRC | 23:44 | |
| *** namnh has joined #openstack-nova | 23:46 | |
| *** slaweq_ has quit IRC | 23:56 | |
| *** markvoelker has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!