*** jistr has quit IRC | 00:00 | |
*** jistr has joined #openstack-nova | 00:01 | |
*** slaweq_ has joined #openstack-nova | 00:05 | |
*** chyka has joined #openstack-nova | 00:06 | |
*** sree has joined #openstack-nova | 00:08 | |
*** chyka has quit IRC | 00:10 | |
*** prometheanfire has joined #openstack-nova | 00:11 | |
prometheanfire | so, what's the story with nova-func tests? | 00:11 |
---|---|---|
*** lnxnut has joined #openstack-nova | 00:11 | |
*** sree has quit IRC | 00:12 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova master: Remove doc todo related to bug/1506667 https://review.openstack.org/509315 | 00:16 |
*** namnh has quit IRC | 00:17 | |
*** namnh has joined #openstack-nova | 00:18 | |
*** yamamoto has joined #openstack-nova | 00:18 | |
*** flanders_ has quit IRC | 00:19 | |
*** lnxnut has quit IRC | 00:21 | |
*** namnh has quit IRC | 00:22 | |
*** yamamoto has quit IRC | 00:23 | |
*** exarr has quit IRC | 00:24 | |
*** acormier has joined #openstack-nova | 00:28 | |
*** ijw has quit IRC | 00:29 | |
*** ijw has joined #openstack-nova | 00:30 | |
*** acormier has quit IRC | 00:31 | |
*** acormier has joined #openstack-nova | 00:32 | |
*** ijw has quit IRC | 00:35 | |
*** ijw has joined #openstack-nova | 00:36 | |
*** gyee has joined #openstack-nova | 00:36 | |
*** itlinux has joined #openstack-nova | 00:36 | |
*** slaweq_ has quit IRC | 00:37 | |
*** slaweq_ has joined #openstack-nova | 00:41 | |
*** ragiman has joined #openstack-nova | 00:42 | |
*** ijw has quit IRC | 00:48 | |
*** TuanLA has joined #openstack-nova | 00:50 | |
*** hongbin has joined #openstack-nova | 00:50 | |
*** ijw_ has joined #openstack-nova | 00:50 | |
*** ijw_ has quit IRC | 00:53 | |
*** itlinux has quit IRC | 00:58 | |
*** markvoelker has joined #openstack-nova | 01:01 | |
*** mingyu has joined #openstack-nova | 01:07 | |
*** MarginHu has joined #openstack-nova | 01:11 | |
*** tonygunk has quit IRC | 01:11 | |
*** slaweq_ has quit IRC | 01:13 | |
*** lnxnut has joined #openstack-nova | 01:18 | |
*** slaweq_ has joined #openstack-nova | 01:18 | |
*** nicolasbock_ has quit IRC | 01:26 | |
*** Kevin_Zheng has joined #openstack-nova | 01:27 | |
*** mingyu has quit IRC | 01:28 | |
*** lnxnut has quit IRC | 01:29 | |
*** mingyu has joined #openstack-nova | 01:31 | |
*** sree has joined #openstack-nova | 01:34 | |
*** itlinux has joined #openstack-nova | 01:36 | |
*** gjayavelu has quit IRC | 01:36 | |
*** gouthamr has quit IRC | 01:37 | |
*** yamahata has quit IRC | 01:39 | |
*** phuongnh has joined #openstack-nova | 01:39 | |
*** itlinux has quit IRC | 01:42 | |
*** sree has quit IRC | 01:42 | |
*** Tom has joined #openstack-nova | 01:43 | |
*** gyee has quit IRC | 01:47 | |
*** slaweq_ has quit IRC | 01:51 | |
openstackgerrit | Merged openstack/nova master: Move ploop commands to privsep. https://review.openstack.org/492325 | 01:52 |
*** slaweq_ has joined #openstack-nova | 01:54 | |
openstackgerrit | melanie witt proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481 | 01:57 |
openstackgerrit | melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505 | 01:57 |
*** takashin has quit IRC | 02:03 | |
*** catintheroof has joined #openstack-nova | 02:03 | |
*** tbachman has joined #openstack-nova | 02:10 | |
*** baoli has joined #openstack-nova | 02:13 | |
*** kenperkins has quit IRC | 02:13 | |
*** catintheroof has quit IRC | 02:19 | |
*** mingyu has quit IRC | 02:22 | |
*** mingyu has joined #openstack-nova | 02:22 | |
*** lnxnut has joined #openstack-nova | 02:26 | |
*** slaweq_ has quit IRC | 02:28 | |
*** yamamoto has joined #openstack-nova | 02:28 | |
*** catintheroof has joined #openstack-nova | 02:29 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Improve the performance of filtering instances by IP. https://review.openstack.org/509326 | 02:31 |
*** slaweq_ has joined #openstack-nova | 02:32 | |
*** lnxnut has quit IRC | 02:36 | |
*** takashin has joined #openstack-nova | 02:48 | |
*** acormier has quit IRC | 02:50 | |
*** acormier has joined #openstack-nova | 02:50 | |
*** Yikun__ has joined #openstack-nova | 02:52 | |
*** acormier has quit IRC | 02:55 | |
*** MasterOfBugs has quit IRC | 02:56 | |
*** erlon has quit IRC | 03:01 | |
openstackgerrit | Merged openstack/nova master: Use improved instance_list module in compute API https://review.openstack.org/505418 | 03:03 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove 400 as expected error https://review.openstack.org/509039 | 03:06 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove 400 as expected error https://review.openstack.org/509039 | 03:06 |
*** catintheroof has quit IRC | 03:09 | |
openstackgerrit | Merged openstack/python-novaclient stable/pike: Updated from global requirements https://review.openstack.org/493187 | 03:14 |
*** itlinux has joined #openstack-nova | 03:23 | |
*** edand has joined #openstack-nova | 03:24 | |
*** baoli has quit IRC | 03:30 | |
*** itlinux has quit IRC | 03:31 | |
*** takashin has quit IRC | 03:32 | |
*** itlinux has joined #openstack-nova | 03:32 | |
*** lnxnut has joined #openstack-nova | 03:34 | |
*** hongbin has quit IRC | 03:36 | |
*** slaweq_ has quit IRC | 03:36 | |
*** Kevin_Zheng has quit IRC | 03:37 | |
*** edand has quit IRC | 03:37 | |
*** slaweq_ has joined #openstack-nova | 03:38 | |
*** itlinux has quit IRC | 03:41 | |
*** udesale has joined #openstack-nova | 03:44 | |
*** lnxnut has quit IRC | 03:44 | |
*** boris_42_ has quit IRC | 03:44 | |
openstackgerrit | Merged openstack/nova master: Move allocation manipulation out of drop_move_claim() https://review.openstack.org/498947 | 03:54 |
*** armax has quit IRC | 04:05 | |
*** sapcc-bot has quit IRC | 04:07 | |
*** sapcc-bot has joined #openstack-nova | 04:07 | |
*** ratailor has joined #openstack-nova | 04:09 | |
*** slaweq_ has quit IRC | 04:10 | |
*** mnaser has quit IRC | 04:15 | |
*** slaweq_ has joined #openstack-nova | 04:16 | |
*** tristanC has quit IRC | 04:16 | |
*** tristanC has joined #openstack-nova | 04:23 | |
*** mnaser has joined #openstack-nova | 04:28 | |
*** claudiub has joined #openstack-nova | 04:30 | |
*** tbh_ has joined #openstack-nova | 04:31 | |
*** yamahata has joined #openstack-nova | 04:37 | |
*** lnxnut has joined #openstack-nova | 04:40 | |
*** slaweq_ has quit IRC | 04:49 | |
openstackgerrit | Merged openstack/nova stable/pike: Split out the core of the ironic flavor migration https://review.openstack.org/505901 | 04:52 |
*** slaweq_ has joined #openstack-nova | 04:53 | |
*** Yikun__ has quit IRC | 05:01 | |
*** sree has joined #openstack-nova | 05:04 | |
*** lnxnut has quit IRC | 05:06 | |
*** psachin has joined #openstack-nova | 05:15 | |
*** markvoelker has quit IRC | 05:20 | |
openstackgerrit | Merged openstack/nova stable/pike: Add ComputeNodeList.get_by_hypervisor_type() https://review.openstack.org/505902 | 05:21 |
*** takashin has joined #openstack-nova | 05:24 | |
*** slaweq_ has quit IRC | 05:26 | |
*** gbarros has joined #openstack-nova | 05:28 | |
*** sree has quit IRC | 05:31 | |
*** slaweq_ has joined #openstack-nova | 05:32 | |
*** sree has joined #openstack-nova | 05:32 | |
*** lnxnut has joined #openstack-nova | 05:33 | |
*** sree has quit IRC | 05:36 | |
*** lnxnut has quit IRC | 05:37 | |
*** lajoskatona has joined #openstack-nova | 05:39 | |
*** manasm has joined #openstack-nova | 05:46 | |
*** markmc has quit IRC | 05:54 | |
*** kashyap has quit IRC | 05:55 | |
*** rnoriega has quit IRC | 05:55 | |
*** jmlowe has quit IRC | 05:55 | |
*** migi has quit IRC | 05:55 | |
*** weshay has quit IRC | 05:55 | |
*** jmlowe has joined #openstack-nova | 05:56 | |
*** mdnadeem has joined #openstack-nova | 06:00 | |
*** edand has joined #openstack-nova | 06:00 | |
*** cfriesen has quit IRC | 06:04 | |
*** udesale__ has joined #openstack-nova | 06:05 | |
*** slaweq_ has quit IRC | 06:05 | |
*** udesale has quit IRC | 06:06 | |
*** sree has joined #openstack-nova | 06:07 | |
*** MarginHu has quit IRC | 06:07 | |
*** Oku_OS-away is now known as Oku_OS | 06:08 | |
*** pooja_jadhav has joined #openstack-nova | 06:09 | |
*** slaweq_ has joined #openstack-nova | 06:11 | |
*** rm_work has quit IRC | 06:11 | |
*** rm_work has joined #openstack-nova | 06:14 | |
*** Apoorva has joined #openstack-nova | 06:15 | |
*** avolkov has joined #openstack-nova | 06:16 | |
*** Apoorva has quit IRC | 06:20 | |
*** rnoriega has joined #openstack-nova | 06:20 | |
*** weshay has joined #openstack-nova | 06:20 | |
*** kashyap has joined #openstack-nova | 06:20 | |
*** gbarros has quit IRC | 06:24 | |
*** sahid has joined #openstack-nova | 06:24 | |
*** markmc has joined #openstack-nova | 06:25 | |
*** udesale__ has quit IRC | 06:25 | |
*** udesale__ has joined #openstack-nova | 06:25 | |
*** migi has joined #openstack-nova | 06:27 | |
*** rcernin has joined #openstack-nova | 06:30 | |
*** sridharg has joined #openstack-nova | 06:32 | |
*** edmondsw has joined #openstack-nova | 06:33 | |
*** lnxnut has joined #openstack-nova | 06:34 | |
*** _pewp_ has quit IRC | 06:35 | |
*** _pewp_ has joined #openstack-nova | 06:36 | |
*** edmondsw has quit IRC | 06:37 | |
*** belmoreira has joined #openstack-nova | 06:38 | |
openstackgerrit | Merged openstack/nova stable/pike: Test InstanceNotFound handling in 'nova usage' https://review.openstack.org/499208 | 06:39 |
*** slaweq_ has quit IRC | 06:43 | |
*** sshwarts has joined #openstack-nova | 06:43 | |
*** jgriffit1 has joined #openstack-nova | 06:44 | |
*** chyka has joined #openstack-nova | 06:45 | |
*** pcaruana has joined #openstack-nova | 06:48 | |
*** chyka has quit IRC | 06:50 | |
*** slaweq_ has joined #openstack-nova | 06:51 | |
*** udesale has joined #openstack-nova | 06:51 | |
*** tbh_ has quit IRC | 06:51 | |
*** chyka has joined #openstack-nova | 06:52 | |
*** udesale__ has quit IRC | 06:53 | |
*** spectr has quit IRC | 06:54 | |
*** andreas_s has joined #openstack-nova | 06:54 | |
*** spectr has joined #openstack-nova | 06:55 | |
*** chyka has quit IRC | 06:56 | |
*** lnxnut has quit IRC | 06:57 | |
*** gjayavelu has joined #openstack-nova | 06:57 | |
*** udesale__ has joined #openstack-nova | 07:02 | |
*** udesale has quit IRC | 07:04 | |
*** tesseract has joined #openstack-nova | 07:16 | |
*** sdake_ has joined #openstack-nova | 07:16 | |
*** sdake_ is now known as Guest52279 | 07:17 | |
*** Guest52279 has quit IRC | 07:17 | |
*** markvoelker has joined #openstack-nova | 07:21 | |
*** slaweq_ has quit IRC | 07:24 | |
*** slaweq_ has joined #openstack-nova | 07:28 | |
*** flanders_ has joined #openstack-nova | 07:40 | |
*** jpena|off is now known as jpena | 07:44 | |
*** gjayavelu has quit IRC | 07:44 | |
*** manasm has quit IRC | 07:45 | |
*** ralonsoh has joined #openstack-nova | 07:47 | |
*** brault has joined #openstack-nova | 07:47 | |
*** manasm has joined #openstack-nova | 07:49 | |
*** acormier has joined #openstack-nova | 07:51 | |
*** markvoelker has quit IRC | 07:55 | |
*** acormier has quit IRC | 07:55 | |
*** abalutoiu has joined #openstack-nova | 08:01 | |
*** udesale has joined #openstack-nova | 08:02 | |
*** udesale__ has quit IRC | 08:03 | |
*** takashin has left #openstack-nova | 08:14 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: serial console log (completed) https://review.openstack.org/450636 | 08:15 |
stephenfin | dansmith: RE: so what is the deal on this nova-manage spec? we're going to just dump syntax compatibility across one release? | 08:21 |
*** edmondsw has joined #openstack-nova | 08:21 | |
stephenfin | dansmith: we're going to drop compatibility for a single option - '--version' - for the 'db sync' and 'api_db sync' commands. This was replaced by a positional argument in Pike (I bugged mriedem relentlessly to get it in) | 08:22 |
stephenfin | dansmith: All the commands will otherwise stay the exact same, to the best of my knowledge | 08:23 |
stephenfin | melwitt: ^ | 08:23 |
*** edmondsw has quit IRC | 08:26 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'move-nova-cmds-to-cliff' spec https://review.openstack.org/433603 | 08:26 |
*** lucas-afk is now known as lucasagomes | 08:27 | |
*** lnxnut has joined #openstack-nova | 08:28 | |
*** slaweq_ has quit IRC | 08:33 | |
*** slaweq_ has joined #openstack-nova | 08:43 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add documentation for cpu_realtime, cpu_realtime_mask https://review.openstack.org/502056 | 08:47 |
*** lnxnut has quit IRC | 08:47 | |
*** jaosorior has quit IRC | 08:51 | |
*** derekh has joined #openstack-nova | 08:52 | |
*** markvoelker has joined #openstack-nova | 08:52 | |
*** jaosorior has joined #openstack-nova | 08:56 | |
*** yamamoto has quit IRC | 09:01 | |
*** tssurya has quit IRC | 09:01 | |
*** sshwarts has quit IRC | 09:05 | |
*** dgonzalez_ has joined #openstack-nova | 09:10 | |
*** mkoderer_ has joined #openstack-nova | 09:10 | |
*** david_ has joined #openstack-nova | 09:10 | |
*** dgonzalez_ has quit IRC | 09:12 | |
*** mkoderer_ has quit IRC | 09:12 | |
*** david_ has quit IRC | 09:12 | |
openstackgerrit | Merged openstack/os-vif master: Add Port Profile info to VIF objects OVS plugin https://review.openstack.org/490819 | 09:12 |
*** tssurya has joined #openstack-nova | 09:13 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Fix race in delete allocation in ServerMovingTests https://review.openstack.org/508872 | 09:15 |
*** slaweq_ has quit IRC | 09:16 | |
*** cshen has joined #openstack-nova | 09:18 | |
*** slaweq_ has joined #openstack-nova | 09:23 | |
*** abhishekk has joined #openstack-nova | 09:24 | |
*** markvoelker has quit IRC | 09:26 | |
*** yamamoto has joined #openstack-nova | 09:27 | |
*** gszasz has joined #openstack-nova | 09:33 | |
*** brault has quit IRC | 09:36 | |
*** yamahata has quit IRC | 09:38 | |
*** sdague has joined #openstack-nova | 09:38 | |
*** lnxnut has joined #openstack-nova | 09:45 | |
*** brault has joined #openstack-nova | 09:47 | |
*** artom has joined #openstack-nova | 09:54 | |
*** trinaths has joined #openstack-nova | 09:54 | |
*** lnxnut has quit IRC | 09:56 | |
*** slaweq_ has quit IRC | 09:56 | |
*** abalutoiu has quit IRC | 10:00 | |
*** artom_ has joined #openstack-nova | 10:01 | |
*** hshiina has joined #openstack-nova | 10:04 | |
*** artom has quit IRC | 10:05 | |
*** TuanLA has quit IRC | 10:06 | |
*** edmondsw has joined #openstack-nova | 10:09 | |
*** edmondsw has quit IRC | 10:13 | |
*** phuongnh has quit IRC | 10:17 | |
*** markvoelker has joined #openstack-nova | 10:23 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.<action> https://review.openstack.org/483324 | 10:26 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.<action> (2) https://review.openstack.org/483955 | 10:26 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.create https://review.openstack.org/483969 | 10:26 |
*** chyka has joined #openstack-nova | 10:29 | |
*** yamamoto has quit IRC | 10:30 | |
gmann | alex_xu: ping | 10:31 |
*** slaweq_ has joined #openstack-nova | 10:31 | |
*** udesale has quit IRC | 10:32 | |
*** chyka has quit IRC | 10:33 | |
*** mingyu has quit IRC | 10:34 | |
*** andreas_s_ has joined #openstack-nova | 10:34 | |
*** edand has quit IRC | 10:36 | |
*** andreas_s has quit IRC | 10:37 | |
*** tesseract has quit IRC | 10:40 | |
*** tesseract has joined #openstack-nova | 10:44 | |
openstackgerrit | Merged openstack/nova master: Do not monkey patch eventlet in unit tests https://review.openstack.org/507923 | 10:47 |
*** gszasz has quit IRC | 10:50 | |
*** sambetts|afk is now known as sambetts | 10:50 | |
*** gszasz has joined #openstack-nova | 10:50 | |
*** yamamoto has joined #openstack-nova | 10:51 | |
*** lucasagomes is now known as lucas-hungry | 10:51 | |
*** sree has quit IRC | 10:53 | |
*** sree has joined #openstack-nova | 10:53 | |
*** lnxnut has joined #openstack-nova | 10:53 | |
*** cdent has joined #openstack-nova | 10:54 | |
*** markvoelker has quit IRC | 10:55 | |
*** sree has quit IRC | 10:57 | |
*** spectr-RH has joined #openstack-nova | 10:59 | |
*** dave-mccowan has joined #openstack-nova | 11:01 | |
*** spectr has quit IRC | 11:02 | |
*** lnxnut has quit IRC | 11:03 | |
*** nicolasbock_ has joined #openstack-nova | 11:03 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539 | 11:08 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: factor out compute service start in ServerMovingTest https://review.openstack.org/503037 | 11:08 |
*** nicolasbock_ has quit IRC | 11:08 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159 | 11:08 |
*** dave-mcc_ has joined #openstack-nova | 11:11 | |
*** ociuhandu has quit IRC | 11:11 | |
*** hamzy has joined #openstack-nova | 11:12 | |
*** dave-mccowan has quit IRC | 11:13 | |
*** brault has quit IRC | 11:14 | |
*** tonygunk has joined #openstack-nova | 11:16 | |
openstackgerrit | Sean Dague proposed openstack/nova master: test_mount_unmount cleanup https://review.openstack.org/509409 | 11:19 |
*** tonygunk has quit IRC | 11:20 | |
*** josecastroleon has quit IRC | 11:21 | |
openstackgerrit | Sean Dague proposed openstack/nova master: test_mount_unmount cleanup https://review.openstack.org/509409 | 11:21 |
*** dtantsur|afk is now known as dtantsur | 11:22 | |
*** smatzek has joined #openstack-nova | 11:25 | |
*** abhishekk has quit IRC | 11:35 | |
*** ociuhandu has joined #openstack-nova | 11:37 | |
*** karts is now known as karthiks | 11:44 | |
*** tonygunk has joined #openstack-nova | 11:50 | |
*** markvoelker has joined #openstack-nova | 11:53 | |
cdent | sdague: if you get a chance, could you review: https://review.openstack.org/#/c/501359/ You were involved in some of the discussion on the related bug | 11:55 |
*** jaypipes has joined #openstack-nova | 11:56 | |
jaypipes | morning supernovas | 11:59 |
*** lnxnut has joined #openstack-nova | 12:00 | |
* cdent waves meekly | 12:02 | |
*** ralonsoh has quit IRC | 12:02 | |
*** lpetrut has joined #openstack-nova | 12:03 | |
*** lucas-hungry is now known as lucasagomes | 12:03 | |
cdent | looks like this long lifed spec about cert validation didn’t get much attention in the spec review, it’s a preposal: https://review.openstack.org/#/c/488541/ | 12:04 |
*** sapcc-bot has quit IRC | 12:04 | |
*** sapcc-bot has joined #openstack-nova | 12:04 | |
*** david_1 has joined #openstack-nova | 12:05 | |
*** dgonzalez_ has joined #openstack-nova | 12:05 | |
*** jpena is now known as jpena|lunch | 12:06 | |
*** dgonzalez_ has quit IRC | 12:06 | |
*** david_1 has quit IRC | 12:06 | |
*** Tom has quit IRC | 12:08 | |
sdague | cdent: +2 | 12:09 |
*** brault has joined #openstack-nova | 12:09 | |
cdent | huzzah | 12:09 |
*** slaweq_ has quit IRC | 12:09 | |
*** lnxnut has quit IRC | 12:11 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: serial console log (completed) https://review.openstack.org/450636 | 12:11 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: Move last_bytes into the path module https://review.openstack.org/509417 | 12:11 |
*** slaweq_ has joined #openstack-nova | 12:13 | |
*** Tom_____ has joined #openstack-nova | 12:14 | |
*** edmondsw has joined #openstack-nova | 12:16 | |
*** edmondsw_ has joined #openstack-nova | 12:17 | |
*** manasm has quit IRC | 12:20 | |
*** edmondsw has quit IRC | 12:21 | |
*** udesale has joined #openstack-nova | 12:23 | |
*** hemna__ has joined #openstack-nova | 12:26 | |
*** markvoelker has quit IRC | 12:26 | |
*** markvoelker has joined #openstack-nova | 12:27 | |
*** smatzek has quit IRC | 12:27 | |
*** smatzek has joined #openstack-nova | 12:28 | |
openstackgerrit | Merged openstack/nova-specs master: Return Selection Objects https://review.openstack.org/498830 | 12:29 |
*** trinaths has left #openstack-nova | 12:32 | |
*** smatzek has quit IRC | 12:34 | |
openstackgerrit | Merged openstack/nova-specs master: Re-propose nested resource providers spec https://review.openstack.org/505209 | 12:34 |
*** namnh has joined #openstack-nova | 12:37 | |
bauzas | jaypipes: around ? | 12:38 |
bauzas | jaypipes: I discussed with sahid about the vGPU spec | 12:39 |
bauzas | jaypipes: and we discussed about a specific question | 12:39 |
jaypipes | bauzas: yep, go ahead | 12:39 |
bauzas | jaypipes: say the virt driver is providing an inventory for VGPU:8 | 12:39 |
bauzas | jaypipes: then the scheduler would allocate a VGPU:1 | 12:40 |
bauzas | jaypipes: if so, the compute service would ask to get a vGPU to the virt driver | 12:40 |
bauzas | jaypipes: so, it would be the virt driver that would look at which MDEV to use ? | 12:41 |
jaypipes | bauzas: well, since QEMU/KVM is the only one that understands mdev currently, yes. | 12:42 |
jaypipes | bauzas: but placement has no concerns about that. | 12:42 |
bauzas | okay, say I have multiple children RPs (because for example of multple GPUs) | 12:42 |
*** kylek3h has quit IRC | 12:43 | |
jaypipes | bauzas: placement deals with UUIDs, of course. so it's up to the virt driver (or the generic device manager in the future once efried hurries up and finishes that work please) to map UUIDs of resource providers to internal names/identifiers of actual devices. | 12:43 |
jaypipes | bauzas: or pGPU *groups* in the case of Xen, but yes. | 12:43 |
bauzas | jaypipes: okay, so it would be the virt driver who would mapping in between RP UUIDs and specific virt identifiers ? | 12:44 |
bauzas | say I have two children UUIDs, we would be passing the one that was allocated to the virt driver, so it would use one specific mdev or PCI device ? | 12:44 |
jaypipes | bauzas: yep, and that's the update_provider_tree() virt driver method that we've been discussing at the PTG and since. | 12:45 |
bauzas | ok | 12:45 |
*** namnh has quit IRC | 12:45 | |
jaypipes | bauzas: again, the scheduler doesn't know or care what the PCI device address or mdev identifier is. | 12:45 |
*** namnh has joined #openstack-nova | 12:45 | |
jaypipes | bauzas: it will just be passing a UUID in the allocation request. | 12:45 |
bauzas | jaypipes: yup I know about that, hence my discussion with sahid | 12:45 |
jaypipes | bauzas: and the virt driver (or generic device manager in future) is responsible for looking up that UUID to a known device. | 12:46 |
jaypipes | bauzas: I just wish efried would get off his ass and finish the generic device manager already. sheeesh. ;) | 12:46 |
*** trinaths has joined #openstack-nova | 12:46 | |
*** namnh_ has joined #openstack-nova | 12:46 | |
*** slaweq_ has quit IRC | 12:46 | |
bauzas | jaypipes: okay I'm cool with that, that's just different from the existing, where we have some specific tracker that passes the specific virt device to the virt driver | 12:47 |
jaypipes | bauzas: yes, understood. | 12:47 |
bauzas | roger. | 12:47 |
*** kfarr has quit IRC | 12:47 | |
jaypipes | bauzas: same | 12:48 |
bauzas | jaypipes: looks like something was misundertood in the ML thread, but I'll leave sahid explain it | 12:48 |
jaypipes | bauzas: again, it's not that we're not responding on the ML. it's that we have priority items we're trying to complete before sahid's patch series. | 12:48 |
bauzas | from what I understand, for Queens, we would just map in the driver between the virt device (here, mdevs) and the RP UUID, that's it | 12:49 |
*** derekh has quit IRC | 12:49 | |
*** namnh has quit IRC | 12:50 | |
*** sridharg has quit IRC | 12:50 | |
*** liverpooler has joined #openstack-nova | 12:51 | |
*** esberglu has joined #openstack-nova | 12:51 | |
*** hshiina has quit IRC | 12:53 | |
*** smatzek has joined #openstack-nova | 12:53 | |
*** hemna__ has quit IRC | 12:54 | |
*** rodrigods has quit IRC | 12:54 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/ocata: Updated from global requirements https://review.openstack.org/490256 | 12:54 |
*** lyan has joined #openstack-nova | 12:54 | |
*** sree has joined #openstack-nova | 12:55 | |
*** slaweq_ has joined #openstack-nova | 12:57 | |
bauzas | jaypipes: follow-up thoughts | 12:58 |
bauzas | jaypipes: since we create allocations by the scheduler, we could imagine an allocation for VGPU:1 | 12:58 |
gmann | Nova API meeting in 5 min on #openstack-meeting-4 channel | 12:59 |
bauzas | jaypipes: then, how the virt driver is knowing that we asked for that specific resource and should therefore use an existing mdev ? | 12:59 |
*** eharney has joined #openstack-nova | 12:59 | |
bauzas | because we're passing the flavor and we introspect it ? | 12:59 |
*** spectr-RH has quit IRC | 13:00 | |
*** takashin has joined #openstack-nova | 13:00 | |
gmann | takashin: can you check my comment in - https://review.openstack.org/#/c/459483/33 | 13:01 |
gmann | takashin: i feel we should return 'type' always | 13:01 |
takashin | gmann: Thank you for your review. | 13:01 |
takashin | gmann: I will check your comment. | 13:02 |
gmann | takashin: thanks. i am reviewing tempest patch also, hope we get all these in soon. | 13:02 |
*** mriedem has joined #openstack-nova | 13:02 | |
*** pcaruana has quit IRC | 13:02 | |
gmann | takashin: got that while checking the schema where you added 'type' as required param | 13:03 |
*** smatzek has quit IRC | 13:04 | |
*** lbragstad has joined #openstack-nova | 13:05 | |
*** sridharg has joined #openstack-nova | 13:07 | |
*** ratailor has quit IRC | 13:07 | |
*** ratailor has joined #openstack-nova | 13:08 | |
*** kylek3h has joined #openstack-nova | 13:08 | |
*** lnxnut has joined #openstack-nova | 13:08 | |
*** flanders_ has quit IRC | 13:09 | |
*** krtaylor has joined #openstack-nova | 13:09 | |
*** pchavva has joined #openstack-nova | 13:09 | |
jaypipes | bauzas: sorry, reading back... electricians at my house | 13:09 |
*** hemna_ has joined #openstack-nova | 13:10 | |
*** smatzek has joined #openstack-nova | 13:11 | |
*** karthiks is now known as karthiks_afk | 13:11 | |
mriedem | still looking for a final +2 on this pike regression fix https://review.openstack.org/#/c/507938/ | 13:11 |
mriedem | bauzas: ^ is in your wheelhouse | 13:12 |
*** ratailor has quit IRC | 13:12 | |
*** spectr-RH has joined #openstack-nova | 13:12 | |
bauzas | mriedem: oh coolness | 13:12 |
*** jpena|lunch is now known as jpena | 13:13 | |
*** trinaths has left #openstack-nova | 13:13 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539 | 13:14 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: factor out compute service start in ServerMovingTest https://review.openstack.org/503037 | 13:14 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159 | 13:14 |
bauzas | mriedem: if you remember, I also have https://review.openstack.org/#/c/481116/ that is related | 13:15 |
bauzas | I need to rebase it | 13:15 |
*** pcaruana has joined #openstack-nova | 13:15 | |
*** smatzek has quit IRC | 13:15 | |
*** spectr-RH has quit IRC | 13:16 | |
bauzas | jaypipes: np, my 2nd question is more about how you see the virt driver consuming that specific allocation | 13:17 |
*** spectr-RH has joined #openstack-nova | 13:17 | |
*** lnxnut has quit IRC | 13:17 | |
bauzas | jaypipes: that will be set by the scheduler | 13:17 |
bauzas | jaypipes: for the moment, we can just do things in the virt driver by introspecting the flavor and see that if we have VGPU:1 in the flavor, we need to hook up a mdev device | 13:18 |
*** sree has quit IRC | 13:18 | |
bauzas | jaypipes: but that's not a super clear interface | 13:18 |
bauzas | note that the problem is identical for Xen | 13:18 |
*** sree has joined #openstack-nova | 13:18 | |
bauzas | with the slight detail it doesn't use mdevs, of course | 13:18 |
sahid | bauzas, jaypipes: without talking about mdev, how that is going to work for the physical devices, which is on what you are working i think | 13:19 |
mriedem | maciejjozefczyk: question about https://review.openstack.org/#/c/494973/ - it was listed as Partial-Bug fix in the commit message but why? is there more to fix in that bug? | 13:19 |
jaypipes | bauzas: k, so the way we've been talking about that is that on startup, the generic device manager (or virt driver) would go through the host devices it discovers and populate a ProviderTree object supplied to it by the RT. The ProviderTree allows looking up providers by UUID or by name. So, when creating nodes in the ProviderTree, the device manager / virt driver would create the resource provider with a UUID and a unique name. It would then | 13:19 |
jaypipes | look up resource providers by UUID or by name later on | 13:19 |
bauzas | jaypipes: that I understood | 13:20 |
bauzas | jaypipes: how we consume that ? by passing the allocation down to the compute ? | 13:21 |
jaypipes | bauzas: yes, the allocation request contains the resource provider UUID(s) of the providers providing resources for an instance. If the scheduler claimed one VGPU resource against a particular device represented by UUID1, the allocation request will contain UUID1: {resources: {VGPU: 1}}} | 13:22 |
*** sree has quit IRC | 13:22 | |
jaypipes | bauzas: and it will be up to the virt driver or generic device manager to look up which device corresponds to which UUID. | 13:23 |
gmann | sdague: mriedem need your eyes and feedback on policy removal list in this spec - https://review.openstack.org/#/c/508101/ | 13:23 |
*** lnxnut has joined #openstack-nova | 13:23 | |
bauzas | jaypipes: so that requires https://review.openstack.org/#/c/486215 | 13:23 |
bauzas | jaypipes: if we say we're just going to do a quick POC for Queens with vGPUs, we won't have that yet, so permission to just introspect the flavor in the virt driver ? | 13:24 |
jaypipes | bauzas: not really, no. The compute host looks up allocations for an instance at the moment by doing a GET /allocations/{consumer_uuid} in the RT | 13:24 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.<action> https://review.openstack.org/483324 | 13:24 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.<action> (2) https://review.openstack.org/483955 | 13:24 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.create https://review.openstack.org/483969 | 13:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: doc: fix flavor notes https://review.openstack.org/509438 | 13:24 |
jaypipes | bauzas: the alternate hosts thing is for retry ability. | 13:24 |
bauzas | jaypipes: oh that's right | 13:24 |
*** catintheroof has joined #openstack-nova | 13:24 | |
bauzas | we don't need to pass them over RPC | 13:24 |
bauzas | because compute is already looking up them | 13:24 |
bauzas | okay, so the RT knows the allocation, it can then passes the allocation to the virt driver, right? | 13:25 |
bauzas | jaypipes: ^ | 13:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Account for compute.metrics.update in legacy notification whitelist https://review.openstack.org/509439 | 13:25 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Account for compute.metrics.update in legacy notification whitelist https://review.openstack.org/509440 | 13:25 |
jaypipes | bauzas: yes. | 13:26 |
bauzas | gotcha | 13:26 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/newton: Account for compute.metrics.update in legacy notification whitelist https://review.openstack.org/509441 | 13:26 |
bauzas | jaypipes: sahid: I think it's enough for us to be able to assign vGPUs for Queens | 13:26 |
mriedem | sdague: how do you feel about this backport https://review.openstack.org/#/c/505546/ ? | 13:27 |
jaypipes | bauzas, sahid: if the virt driver (or generic device manager in the future) wants to store that mapping of mdev identifier to resource provider UUID in a DB table (pci_devices?), cool. If it wants to store it in etcd, cool. An inventory.yaml file on the host? also cool, doesn't matter to me :) | 13:27 |
bauzas | sahid: the virt driver reports how many vGPUs it can assign by filling in the get_inventory() method | 13:27 |
mriedem | sdague: i think it's ok, it's adding the ability to specify certs when talking to keystone for the os-quota-sets and flavor-access APIs | 13:27 |
*** yamamoto has quit IRC | 13:27 | |
bauzas | sahid: then at the creation time, the RT would pass the allocated claim (I mean the allocation record) to the virt driver so it would get the RP UUID and the amount to consume | 13:28 |
sahid | jaypipes: it' good point, since currently libvirt is using PciDevice, so it will be a good transition then | 13:28 |
bauzas | then the virt driver would allocate from the pool of physical devices it manages | 13:28 |
jaypipes | sahid: yup | 13:28 |
jaypipes | bauzas: no, not really... the device will have already been picked by the scheduler. all the virt driver would need to do is plumb the specific device to the guest. | 13:29 |
*** slaweq_ has quit IRC | 13:29 | |
bauzas | jaypipes: sahid: I guess the most important matter is that whatever the technical persistence is, it's not provided outside of the virt driver | 13:29 |
jaypipes | bauzas: and that's the point we're trying to get to. the RT and scheduler do the claiming/allocating resources stuff and the virt driver does the guest plumbing. | 13:30 |
bauzas | jaypipes: if we pass VGPU:8 as a RC | 13:30 |
*** alexchadin has joined #openstack-nova | 13:30 | |
bauzas | jaypipes: then the allocation would be against the root RP | 13:30 |
bauzas | for queens I mean | 13:30 |
jaypipes | bauzas: no, not necessarily. | 13:30 |
*** baoli has joined #openstack-nova | 13:30 | |
bauzas | I'm all ears :) | 13:31 |
jaypipes | bauzas: we're aiming to get n-r-p work done in Queens. so, the allocation would be against one or more child providers (in libvirt, those would be pGPUs, in Xen they would be pGPU groups). | 13:31 |
*** ralonsoh has joined #openstack-nova | 13:32 | |
jaypipes | bauzas: so all the virt driver would be responsible for doing is a) looking up physical device information by resource provider UUID and b) doing the necessary guest plumbing for the device (in other words, in libvirt's case, writing the XML snippet information for the device, etc) | 13:32 |
bauzas | I agree, I just thought we said we could try to provide GPU resources as a global resource class for the node in Queens | 13:33 |
bauzas | if nested-RPs is already there, then of course we would modify that to just lookup the child RP | 13:33 |
*** tbachman has quit IRC | 13:33 | |
dansmith | bauzas: yes that's wht we should do | 13:34 |
*** tbachman has joined #openstack-nova | 13:34 | |
dansmith | bauzas: we can expose gpu resources for the compute node right now | 13:34 |
*** mingyu has joined #openstack-nova | 13:34 | |
* efried enters the conversation late | 13:36 | |
sahid | efried: please ping me when you have a moment so we can talk about your work on the generic devices management | 13:36 |
efried | jaypipes GDM dig accepted | 13:36 |
jaypipes | efried: lol :) | 13:36 |
efried | sahid Now's good, unless I need to catch up on the ML first. | 13:36 |
efried | jaypipes BUT - I've actually been thinking along the lines that, once NRP is in place, there will be no need for such a thing as a GDM. | 13:37 |
sahid | i did not expected to see you respond so quickly :) | 13:37 |
maciejjozefczyk | mriedem: Yes other patch should be applied to rollback migration when delete is called, similiar to: https://review.openstack.org/#/c/185958/ | 13:37 |
maciejjozefczyk | mriedem: I solved an effect of broken migration, not the source | 13:38 |
jaypipes | efried: oh, there still will be. | 13:38 |
jaypipes | efried: there's still a need for discovery of hardware on the host. | 13:38 |
efried | virt driver | 13:38 |
sahid | efried: do you have some pointers of work in progress? | 13:38 |
efried | whitelisting? virt driver | 13:39 |
jaypipes | efried: doing so would probably lead to a lot of dup code. | 13:39 |
efried | Mapping devices to RPs? virt driver. | 13:39 |
*** mingyu has quit IRC | 13:39 | |
efried | sahid The only "work in progress" is scribbles on etherpads, which we discussed at the PTG. | 13:39 |
sahid | efried: yes i was not here, if you can give me the link | 13:40 |
efried | sahid https://etherpad.openstack.org/p/nova-ptg-queens-generic-device-management | 13:40 |
efried | sahid It has generally been a drive towards understanding how devices are going to be managed once we go full-bore with placement & resource providers | 13:40 |
*** gmann is now known as gmann_sleep | 13:40 | |
*** slaweq_ has joined #openstack-nova | 13:40 | |
efried | sahid The goal being to get rid of the existing PCI manager code. | 13:40 |
mriedem | gmann_sleep: doesn't it seem odd that we still have this filtering code when listing instances to be able to filter by metadata and system_metadata? https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2328-L2332 | 13:41 |
mriedem | i thought that was a 400 in the API now | 13:41 |
mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L182 | 13:41 |
efried | jaypipes Potentially duplication among the linuxy hypervisors, I suppose. I would still expect the code to ultimately run under the auspices of the virt driver. | 13:42 |
sahid | efried: no transition phase as suggested jaypipes by adding a update_from_inventory() method to the PciManager? | 13:42 |
efried | jaypipes So I could see having some shared class above the ComputeDriver base class that provides linuxy impls for devicey methods. | 13:43 |
efried | sahid Well, the cores have made their position pretty clear: Investment in the existing PCI manager is going to be very limited. | 13:44 |
*** cleong has joined #openstack-nova | 13:44 | |
*** armax has joined #openstack-nova | 13:45 | |
*** burt has joined #openstack-nova | 13:45 | |
*** tonygunk has quit IRC | 13:46 | |
efried | sahid That said, I think it may be possible to get very close to what you want just using NRP with traits and careful modeling, which is happening in Queens. | 13:46 |
efried | sahid Fancy use cases like (anti)affinity won't work yet. | 13:46 |
jaypipes | efried: yeah, we're gonna need to have some sort of transitionary plan anyway... | 13:46 |
efried | jaypipes Oh, like sahid is saying with update_from_inventory() - presumably a RT method that peels dev info out of the virt inventory and flushes it back to the PCI manager? | 13:47 |
jaypipes | efried: chatting with dansmith and bauzas, I'm cool with trying to get single-inventory VGPU support pushed for Queens if we miss nested resource provider targets. That would means no support for multiple GPU types on a single compute node, but would at least get some rudimentary VGPU support | 13:47 |
*** sree has joined #openstack-nova | 13:48 | |
dansmith | jaypipes: multiple gpu types can be handled with aggregates until we have richer support, and at least one customer has told me that's fine, FWIW | 13:49 |
jaypipes | k | 13:49 |
bauzas | efried: I just wanted to clarify how we would translate a specific {'VPGU:1"} request into something very virt-specific | 13:49 |
*** crushil has quit IRC | 13:49 | |
bauzas | heh VGPUs even | 13:49 |
sahid | it seems that XenServer provides an abstraction which makes easy what you want to achieve | 13:49 |
sahid | but that does not look reasonable for libvirt | 13:49 |
efried | bauzas So the only way we're going to translate an allocation to a specific device is if the RP is modeled as representing that specific device. | 13:50 |
sahid | XenServer is doing the managmenet ofr the devices, libvirt is using the PciManager | 13:50 |
bauzas | efried: sahid: dansmith: I just feel we need code so we could chat on the details | 13:50 |
bauzas | reporting the inventory for those resource classes is easy | 13:51 |
efried | The virt driver will ultimately be responsible for designing that model, maintaining that mapping, and providing the appropriate RPs and inventory to placement (via get_inventory, or update_provider_tree, or whatever it winds up being) | 13:51 |
dansmith | bauzas: you're asking how the virt driver knows a thing has been requested? | 13:51 |
bauzas | dansmith: yup, correct | 13:51 |
dansmith | bauzas: in the simple case it can just look at extra_specs on instance.flavor | 13:51 |
bauzas | dansmith: jaypipes told me RT looks up the allocation | 13:52 |
bauzas | dansmith: yeah that was my initial approach | 13:52 |
dansmith | bauzas: we have a routine that can parse the flavor and give you a merged resource view | 13:52 |
bauzas | that would be an easy thing then | 13:52 |
bauzas | okay, I need coding then | 13:52 |
dansmith | or look at the allocation, yeah, but plumbing that from rt to virt will take a little work | 13:52 |
efried | The virt driver will be able to see the allocation, no? | 13:52 |
bauzas | yeah, for a POC, introspecting the flavor seems the quickiest path | 13:52 |
dansmith | you will need the allocation once we have n-r-p or traits though | 13:52 |
mriedem | these -1s from zuul messing up my dashboard is messing up my life | 13:53 |
bauzas | efried: it requires a new interface which we don't have yet | 13:53 |
dansmith | efried: it could fetch it itself, yeah, but better if it didn't I think | 13:53 |
*** gouthamr has joined #openstack-nova | 13:53 | |
bauzas | dansmith: yeah, I'm not a fan of the virt driver calling placement | 13:53 |
dansmith | bauzas: yeah, a good first step would be figuring out the best way to tell the virt driver about the allocation | 13:53 |
dansmith | bauzas: yep | 13:53 |
efried | Talking like something in the Instance object? | 13:53 |
bauzas | anyway, /me coding then | 13:53 |
dansmith | efried: no | 13:53 |
efried | param to spawn? | 13:54 |
dansmith | efried: maybe just a param in spawn | 13:54 |
dansmith | yeah | 13:54 |
efried | ight | 13:54 |
efried | btw, virt will at some point be calling placement. | 13:54 |
efried | Not necessarily in spawn | 13:54 |
bauzas | dansmith: jaypipes was thinking of a specific interface for nested RPs | 13:54 |
bauzas | dansmith: something like update_my_provider_tree() | 13:54 |
dansmith | efried: you're saying that because of virt drivers reporting resource? | 13:54 |
efried | but in init_host, and/or get_inventory, and/or update_provider_tree, whatever - to set up the RPs and whatnot. | 13:55 |
efried | Yeah, for example, to know whether a RP has been created yet. | 13:55 |
dansmith | efried: that should be abstracted by the compute manager, not virt calling placement directly | 13:55 |
dansmith | IMHO | 13:55 |
dansmith | bauzas: yep makes sense | 13:55 |
*** manasm has joined #openstack-nova | 13:55 | |
efried | dansmith Yeah, I suppose it could be. | 13:55 |
bauzas | I second dansmith on not having placement calls from the driver | 13:55 |
efried | This means virt is always responsible for producing RP UUIDs. | 13:56 |
dansmith | efried: I think we should shoot for that goal, and if there's some compelling reason to break that rule, then we can discuss it | 13:56 |
efried | dansmith Dig. | 13:56 |
bauzas | mriedem: (Zuul, Jenkins) is now the tuple to care | 13:56 |
jaypipes | dansmith: right. RT constructs the known ProviderTree. passes it to the virt driver's update_provider_tree() method, virt driver adds, removes, changes inventory and traits for resource providers in the tree, RT then saves any of those changes to placement. | 13:56 |
dansmith | jaypipes: yes, that | 13:56 |
efried | bauzas What is it you're going off to code now? | 13:56 |
bauzas | efried: I'll just update libvirt to pass vGPU resources and lookup the flavor extraspecs for plumbing a mdev | 13:57 |
efried | bauzas Pass vGPU resources from get_inventory? | 13:57 |
bauzas | correct | 13:57 |
*** crushil has joined #openstack-nova | 13:58 | |
efried | bauzas and look up flavor extra specs from spawn? | 13:58 |
bauzas | efried: yup | 13:58 |
efried | bauzas Cool. sahid ^ | 13:58 |
*** felipemonteiro_ has joined #openstack-nova | 14:00 | |
*** stephenfin has quit IRC | 14:00 | |
*** Suramya has joined #openstack-nova | 14:01 | |
*** stephenfin has joined #openstack-nova | 14:01 | |
*** felipemonteiro__ has joined #openstack-nova | 14:01 | |
sahid | that seems a bit archaic - get_inventory to retourn ResourceClass.GPU and then ? you are going to hack the virt driver to read a flavor in the spawn phase? add a conditon that a vgpu, (which kind?, what numa?) and then update the XML | 14:02 |
*** yamamoto has joined #openstack-nova | 14:03 | |
*** yamamoto has quit IRC | 14:03 | |
bauzas | that's basically my intent, yes :) | 14:03 |
*** hongbin has joined #openstack-nova | 14:03 | |
dansmith | 460 uses of instance.flavor in the virt drivers today | 14:03 |
dansmith | not exactly a hack | 14:03 |
*** felipemonteiro_ has quit IRC | 14:05 | |
sahid | It is totally a hack and it's going to provide a very basic support | 14:05 |
sahid | libvirt have a pci device manager, and it's a bad idea to just ignore it | 14:05 |
dansmith | yep, it's a first step to get us basic support, as stated above | 14:05 |
sahid | but it's a hack, no need ot RP or anything to provide that basic support | 14:07 |
*** edmondsw_ is now known as edmondsw | 14:07 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | 14:09 |
*** archit has joined #openstack-nova | 14:10 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512 | 14:13 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Port Profile info to VIF objects Linux Bridge plugin https://review.openstack.org/490829 | 14:13 |
*** slaweq_ has quit IRC | 14:14 | |
*** READ10 has joined #openstack-nova | 14:14 | |
*** smatzek has joined #openstack-nova | 14:15 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add VersionedObjectPrintable mixin https://review.openstack.org/493082 | 14:15 |
*** smatzek has quit IRC | 14:15 | |
*** smatzek has joined #openstack-nova | 14:15 | |
*** kenperkins has joined #openstack-nova | 14:18 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix test_get_volume_config method https://review.openstack.org/489467 | 14:18 |
*** acormier has joined #openstack-nova | 14:19 | |
*** takashin has left #openstack-nova | 14:19 | |
*** slaweq_ has joined #openstack-nova | 14:20 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: factor out compute service start in ServerMovingTest https://review.openstack.org/503037 | 14:20 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159 | 14:20 |
*** acormier has quit IRC | 14:20 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused get_all_instance_*metadata methods https://review.openstack.org/508299 | 14:23 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old compat code from servers ViewBuilder._get_metadata https://review.openstack.org/508326 | 14:23 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop joining on system_metadata when listing instances https://review.openstack.org/508335 | 14:23 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove system_metadata loading in Instance._load_flavor https://review.openstack.org/508357 | 14:23 |
*** kenperkins has quit IRC | 14:23 | |
dansmith | jaypipes: bauzas: stephenfin: easy +W on this cleanup: https://review.openstack.org/#/c/508299/2 | 14:24 |
jaypipes | dansmith: finito | 14:25 |
dansmith | jaypipes: ${thanks_in_some_fancy_language} | 14:26 |
jaypipes | :) | 14:26 |
*** mdnadeem has quit IRC | 14:27 | |
*** eharney has quit IRC | 14:29 | |
*** gbarros has joined #openstack-nova | 14:30 | |
*** udesale has quit IRC | 14:32 | |
*** pcaruana has quit IRC | 14:33 | |
mriedem | whew, got my aussy visitor visa | 14:35 |
dansmith | um I believe it's "aussie" | 14:36 |
*** cfriesen has joined #openstack-nova | 14:38 | |
*** spectr-RH has quit IRC | 14:41 | |
*** smatzek has quit IRC | 14:42 | |
*** spectr has joined #openstack-nova | 14:42 | |
*** smatzek has joined #openstack-nova | 14:43 | |
*** smatzek has quit IRC | 14:44 | |
*** eharney has joined #openstack-nova | 14:45 | |
*** pcaruana has joined #openstack-nova | 14:45 | |
*** sree has quit IRC | 14:47 | |
*** sree has joined #openstack-nova | 14:48 | |
*** alexchadin has quit IRC | 14:50 | |
*** sdague has quit IRC | 14:50 | |
*** sree has quit IRC | 14:52 | |
*** slaweq_ has quit IRC | 14:53 | |
*** tonygunk has joined #openstack-nova | 14:55 | |
*** Nel1x has joined #openstack-nova | 14:55 | |
*** smatzek has joined #openstack-nova | 14:55 | |
cdent | anybody able to sail this gabbi test addition, already has jay’s +2: https://review.openstack.org/#/c/485209/ | 14:56 |
*** lnxnut_ has joined #openstack-nova | 14:56 | |
*** awaugama has joined #openstack-nova | 14:56 | |
*** slaweq_ has joined #openstack-nova | 14:56 | |
gibi | cdent: looking... | 14:57 |
*** smatzek_ has joined #openstack-nova | 14:57 | |
cdent | thanks | 14:57 |
gibi | dansmith was faster | 14:58 |
cdent | thanks danpawlik | 14:58 |
cdent | oh noes! thanks dansmith | 14:58 |
*** lnxnut has quit IRC | 14:58 | |
danpawlik | cdent: lol | 14:58 |
* dansmith bows | 14:58 | |
danpawlik | :D | 14:58 |
danpawlik | cdent: I was wondering why you thanks me :D | 14:59 |
cdent | danpawlik: I’m sure you’ve done something worth being thanked for? Thanks for existing. | 14:59 |
gibi | danpawlik: now you have to do someting for cdent :) | 14:59 |
*** smatzek has quit IRC | 15:00 | |
*** smatzek_ is now known as smatzek | 15:00 | |
danpawlik | gibi: In that case, Im going to work! | 15:00 |
*** diegows has quit IRC | 15:00 | |
danpawlik | cdent: :D | 15:00 |
*** diegows has joined #openstack-nova | 15:01 | |
*** edleafe- has joined #openstack-nova | 15:03 | |
*** sahid has quit IRC | 15:03 | |
*** yamamoto has joined #openstack-nova | 15:04 | |
*** sahid has joined #openstack-nova | 15:05 | |
*** edleafe has quit IRC | 15:06 | |
*** Oku_OS is now known as Oku_OS-away | 15:08 | |
melwitt | mriedem: I started looking at the ceph job last night and something weird is happening where keystone can't start. still researching how to fix it | 15:10 |
mriedem | ok, but it's still a smoldering pile despite that | 15:11 |
*** manasm has quit IRC | 15:11 | |
*** yamamoto has quit IRC | 15:13 | |
*** rcernin has quit IRC | 15:13 | |
*** sdague has joined #openstack-nova | 15:14 | |
*** andreas_s_ has quit IRC | 15:16 | |
*** Suramya has quit IRC | 15:19 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Modernize set_vm_state_and_notify https://review.openstack.org/499799 | 15:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass migration from API to conductor for evacuate https://review.openstack.org/500176 | 15:19 |
*** gbarros has quit IRC | 15:20 | |
*** brault has quit IRC | 15:20 | |
*** lajoskatona has left #openstack-nova | 15:23 | |
*** erlon has joined #openstack-nova | 15:25 | |
*** psachin has quit IRC | 15:25 | |
melwitt | mriedem: I see now, the keystone thing must have been from getting zuul'd. the failures I see now are from a 404 from cinder api test, like you said last time | 15:26 |
*** burt has quit IRC | 15:26 | |
smcginnis | melwitt: Anything you need us to look at? | 15:26 |
mriedem | there was a long-standing change in cinder for ceph, | 15:27 |
mriedem | that jbernard thought would help stabilize some things | 15:27 |
*** slaweq_ has quit IRC | 15:27 | |
mriedem | https://review.openstack.org/#/c/281550/ | 15:27 |
*** slaweq_ has joined #openstack-nova | 15:28 | |
*** pcaruana has quit IRC | 15:28 | |
mriedem | and there was an alternative proposed https://review.openstack.org/#/c/432326/ | 15:28 |
*** tesseract has quit IRC | 15:29 | |
mriedem | as far as i can tell, something something locks | 15:29 |
*** gyee has joined #openstack-nova | 15:29 | |
mriedem | there are some newer volume snaphot tests in tempest that are failing at a pretty high rate, globally, so those are probably not helping the situation | 15:30 |
melwitt | smcginnis: not yet sure. there's a couple of cinder api tempest tests failing on only our ceph job (for a long time) and I'm starting to look at it | 15:30 |
mriedem | and by "the situation", yes, i mean this guy http://pmcdeadline2.files.wordpress.com/2014/03/mike-the-situation__140331172717.jpg | 15:31 |
*** Sukhdev_ has joined #openstack-nova | 15:31 | |
openstackgerrit | Merged openstack/nova-specs master: List/show all server migration types https://review.openstack.org/489029 | 15:32 |
*** igordc has quit IRC | 15:32 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: What is the meaning of....recreate? https://review.openstack.org/508190 | 15:32 |
*** igordc has joined #openstack-nova | 15:33 | |
*** yamahata has joined #openstack-nova | 15:33 | |
*** belmoreira has quit IRC | 15:35 | |
mriedem | sdague: dansmith: grenade creates a vm and leaves it running through the upgrade so it can ping it on the other side right? | 15:38 |
*** smatzek has quit IRC | 15:38 | |
dansmith | mriedem: yeah | 15:39 |
mriedem | ok, i guess nova supports accessible upgrades then! | 15:39 |
mriedem | yay more tags | 15:39 |
*** mdavidson has quit IRC | 15:39 | |
*** smatzek has joined #openstack-nova | 15:39 | |
dansmith | is that what that tag means? | 15:39 |
dansmith | because there was "no-impact-upgrades" proposed at one point that covered that bit | 15:40 |
cdent | nobody is ever sure | 15:40 |
cdent | smcginnis tried to kill the accessible tag but then someone came along and said, but wait, nova and cinder match that one | 15:40 |
*** prometheanfire has left #openstack-nova | 15:40 | |
mriedem | there are like 5-6 upgrade tags | 15:40 |
mriedem | i didn't know what a "controlled resource" was in reading the description, | 15:41 |
mriedem | assumed it was a VM, | 15:41 |
mriedem | but without examples in the tag descriptions it's hard to know what the author intended | 15:41 |
mriedem | i know what it means to the ATF... | 15:42 |
cdent | in nova’s case it does mean that running vm survives and can be worked with (accessed) through an upgrade | 15:42 |
mriedem | so what is "no-impact-upgrades"? | 15:42 |
cdent | but yeah, it’s entirely unclear | 15:42 |
cdent | dunno! :) | 15:42 |
cdent | I don’t like tags | 15:42 |
mriedem | weeeeeeeee | 15:42 |
mriedem | i don't either really, but probably for slightly different reasons | 15:42 |
cdent | i cannot say, since I dont know why you don’t like | 15:43 |
mriedem | no one in the dev teams probably thinks about tags | 15:43 |
*** smatzek_ has joined #openstack-nova | 15:43 | |
mriedem | e.g. there is no bi-annual audit | 15:43 |
mriedem | i do'nt know what stick or carrot exists for us to care about tags | 15:43 |
*** smatzek has quit IRC | 15:43 | |
mriedem | and i do'nt know if people consuming openstack are really giving them much weight, but maybe they are depending on project, | 15:44 |
mriedem | e.g. if there are 3 monitoring type projects, you'd care about what tags are applied to those | 15:44 |
cdent | the stick or carror aspect is part of my concerns | 15:44 |
*** chyka has joined #openstack-nova | 15:45 | |
*** trinaths has joined #openstack-nova | 15:45 | |
*** tuanla_fujitsu has joined #openstack-nova | 15:45 | |
*** smatzek_ has quit IRC | 15:46 | |
sdague | mriedem: a bunch of them were going to be purged | 15:46 |
sdague | mriedem: there is a distinction somewhere about 0 api downtime | 15:47 |
sdague | which is important for things like keystone | 15:47 |
sdague | because, if keystone is out, operations fail randomly | 15:47 |
*** penick has joined #openstack-nova | 15:48 | |
*** slaweq_ has quit IRC | 15:49 | |
*** smatzek has joined #openstack-nova | 15:49 | |
*** slaweq_ has joined #openstack-nova | 15:50 | |
*** slaweq_ has quit IRC | 15:50 | |
*** smatzek_ has joined #openstack-nova | 15:51 | |
*** slaweq_ has joined #openstack-nova | 15:51 | |
mriedem | i think that's the zero-downtime-upgrade one | 15:51 |
mriedem | the zero-impact-upgrade one is about performance during upgrade, as my understanding | 15:51 |
mriedem | so there are subtle differences | 15:51 |
dansmith | yeah something | 15:51 |
mriedem | replied to the ML thread on this, | 15:51 |
mriedem | but i'd think zero-impact-upgrade re perf would be something like strain on the network doing live migrations while upgrading compute hosts | 15:52 |
*** edleafe- is now known as edleafe | 15:52 | |
mriedem | but i'm not sure how nova would really have anything to do with that, it seems like a deployment topology decision | 15:52 |
mriedem | let's put that tag on openstack public clouds :) | 15:53 |
*** smatzek has quit IRC | 15:54 | |
mriedem | onto another topic, sounds like cern would like to be able to pass user_data to rebuild... | 15:54 |
*** smatzek_ has quit IRC | 15:54 | |
mriedem | sounds like they rely on rebuild pretty heavily | 15:55 |
*** slaweq_ has quit IRC | 15:55 | |
*** smatzek has joined #openstack-nova | 15:57 | |
*** lucasagomes is now known as lucas-afk | 15:57 | |
*** penick has quit IRC | 15:58 | |
*** smatzek_ has joined #openstack-nova | 16:00 | |
cfriesen | does anyone know why AggregateImagePropertiesIsolation and AggregateInstanceExtraSpecsFilter behave differently? It's confusing... | 16:01 |
*** smatzek has quit IRC | 16:01 | |
*** smatzek_ has quit IRC | 16:03 | |
*** smatzek has joined #openstack-nova | 16:03 | |
*** smatzek has quit IRC | 16:03 | |
*** smatzek has joined #openstack-nova | 16:04 | |
*** tuanla_fujitsu has quit IRC | 16:04 | |
bauzas | cfriesen: the reason is "historical" | 16:11 |
bauzas | in other words, two efforts made by two teams | 16:11 |
*** trinaths has left #openstack-nova | 16:13 | |
cfriesen | bauzas: why am I not surprised. :) | 16:15 |
bauzas | the problem is that changing a filter behaviour is something tricky | 16:16 |
bauzas | I'd prefer providing a new filter that would do both image and flavor checks with the same behaviour, and in the meantime deprecate the old two filters | 16:17 |
bauzas | so we would be super clear that the behaviour is changing | 16:17 |
bauzas | keep those filters for a couple of releases, and then remove them from the tree | 16:17 |
bauzas | if people want to keep them out-of-tree, I'm fine | 16:17 |
bauzas | cfriesen: fancy proposing that ? :) | 16:18 |
bauzas | after all, it's just filters | 16:18 |
*** hemna_ has quit IRC | 16:18 | |
cfriesen | bauzas: Will propose it internally. What do you think of my proposal for https://review.openstack.org/#/c/381912/ to have the "strictness" of the isolation be scoped to individual keys? | 16:19 |
mriedem | i thought that's what the new psec was | 16:19 |
mriedem | yeah that one | 16:19 |
cfriesen | mriedem: they're just proposing adding a new boolean flag on either the image or flavor to say the matching is strict....but that doesn't factor in that the behaviour of the two filters is different | 16:20 |
dansmith | edleafe: are you revising your alt hosts thing? | 16:20 |
cfriesen | mriedem: and I think it'd make more sense to allow strict matching on a per-key basis, specified in the aggregate metadata | 16:20 |
edleafe | dansmith: which alt hosts thing? | 16:20 |
dansmith | edleafe: https://review.openstack.org/#/c/486215/12 | 16:20 |
edleafe | dansmith: yeah, I'm working through the whole series to incorporate the changes to the Selection object based on the spec changes | 16:21 |
dansmith | edleafe: okay cool | 16:21 |
bauzas | cfriesen: well, I think I said "meh" in my comment | 16:23 |
bauzas | cfriesen: so, basically, I'm not opiniated | 16:23 |
bauzas | cfriesen: I tend to avoid having filter behaviours driven by keys | 16:23 |
bauzas | but looks like we need to be pragmatic | 16:23 |
bauzas | another option could be a config option, but that would be worst I think for interop | 16:24 |
bauzas | because two clouds would behave differently | 16:24 |
*** gbarros has joined #openstack-nova | 16:24 | |
bauzas | cfriesen: so, honestly, maybe a key is okay | 16:25 |
bauzas | I dunno, I need more time to think about that | 16:25 |
cfriesen | bauzas: I was thinking that we might want to be strictly isolationist for some keys but not for others (as opposed to the all-or-nothing that the current spec proposes) | 16:25 |
bauzas | when you say "isolationist for a specific *key*", you mean either an aggregate extraspec key for matching the flavor, or an image property? | 16:27 |
bauzas | cfriesen: ^ | 16:27 |
*** penick has joined #openstack-nova | 16:28 | |
bauzas | cfriesen: I just wonder how you would express that in the aggregate metadata | 16:28 |
bauzas | because of the k=v pair | 16:28 |
cfriesen | bauzas: I was thinking that the aggregate key could be something like '{"strict:os": "windows"}', in which case only instances with image property or flavor extra-spec of "os:windows" would match | 16:29 |
cfriesen | basically just a "strict:" namespace on the aggregate key | 16:29 |
bauzas | namespacing ? I don't like that | 16:29 |
bauzas | we already namespace keys AFAIKK | 16:29 |
cfriesen | we namespace them on the flavor/image, but not on the aggregate currently I think | 16:30 |
bauzas | nevermind, we namespace the image properties or the flavor specs | 16:30 |
bauzas | yeah that | 16:30 |
bauzas | cfriesen: the problem is that if you do that, you change the API | 16:30 |
cfriesen | bauzas: the nice thing about that is that it works with existing flavors/images | 16:30 |
cfriesen | bauzas: we're talking about a new filter anyway | 16:31 |
bauzas | cfriesen: say I already have aggregates that are tagged and filters | 16:31 |
bauzas | cfriesen: how can that work in an upgrade way? | 16:31 |
bauzas | you would default no namespace to the current behaviour ? | 16:31 |
cfriesen | bauzas: yes | 16:31 |
bauzas | cfriesen: honesty, I don't like that | 16:31 |
cfriesen | in the existing filters | 16:31 |
bauzas | you can create as many aggregates as you want | 16:32 |
cfriesen | in the new filter we'd want consistent behaviour for both image/flavor | 16:32 |
bauzas | and a host can be part of 1:N aggs | 16:32 |
bauzas | so, if you need strict isolation for only a couple of keys, why just not define two aggregates, one containing keys with no strictness, and the other with keys needing to be strict ? | 16:32 |
*** larainema has quit IRC | 16:32 | |
cfriesen | bauzas: with strict matching you'd need the flavor/image to match all the strict keys from all the aggregates the host is in | 16:32 |
cfriesen | bauzas: you're thinking a "strict-match" boolean flag on the aggregate? yeah, that could work. | 16:33 |
bauzas | I'm just talking of the current proposal | 16:34 |
bauzas | he proposes to add new keys that are global per-aggregate | 16:34 |
bauzas | cfriesen: in that case, if you need some keys with strict isolation, and some with not, just define two aggregates and only apply the new metadata tag image_strict_isolation=True to the aggregate containing the keys you want to be strict | 16:35 |
mriedem | dansmith: looking at https://review.openstack.org/#/c/498950/ - it occurs to me that if prep_resize fails, i don't think we ever set the migration status to 'failed' | 16:36 |
mriedem | dansmith: which i think is just a latent bug | 16:36 |
mriedem | if resize_instance fails it will, but we might not get that far | 16:37 |
cfriesen | bauzas: I guess. Although AggregateInstanceExtraSpecsFilter doesn't do isolation currently, and AggregateImagePropertiesIsolation doesn't ensure that what you specify in the image is present in the aggregate. | 16:38 |
mriedem | dansmith: oh i know why - because we never had the migration before that point, because the RT always created it | 16:38 |
cfriesen | bauzas: hence the rationale for a new filter with common behaviour | 16:39 |
*** jgriffith is now known as Guest73111 | 16:39 | |
*** jgriffit1 is now known as jgriffith | 16:39 | |
dansmith | mriedem: right, because _prep_resize's with resize_claim would do that right? | 16:39 |
mriedem | yeah | 16:39 |
*** jgriffith_ has joined #openstack-nova | 16:39 | |
mriedem | but now you're passing down a migration record and not handling errors | 16:39 |
dansmith | yup | 16:40 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | 16:40 |
dansmith | the bottom one if this series was just kicked out of the gate anyway, so I'll rebase and freshen since we're like 8 hours from merge anyway | 16:42 |
*** felipemonteiro__ has quit IRC | 16:44 | |
bauzas | cfriesen: I don't disagree | 16:46 |
*** trinaths1 has joined #openstack-nova | 16:46 | |
mriedem | dansmith: still going through this if you want to hold up | 16:46 |
mriedem | into the conductor stuff now | 16:46 |
cfriesen | bauzas: will comment on the review | 16:46 |
dansmith | mriedem: sure | 16:46 |
*** gbarros has quit IRC | 16:47 | |
*** dtantsur is now known as dtantsur|afk | 16:47 | |
* bauzas drops ofrf | 16:48 | |
cfriesen | bauzas: it occurs to me that combining flavor extra-specs and image properties is tricky...some of that logic is way down in the virt code. | 16:48 |
*** tonygunk has quit IRC | 16:50 | |
mriedem | dansmith: ok done :) | 16:53 |
dansmith | mriedem: I can't wait to see what gifts you have left for me | 16:54 |
mriedem | they are bountiful | 16:54 |
mriedem | i'm going to go pat myself on the back with lunch | 16:54 |
*** sambetts is now known as sambetts|afk | 16:55 | |
mriedem | jaypipes: cdent: fyi https://review.openstack.org/#/c/498950/ | 16:56 |
cdent | mriedem: mlph | 16:57 |
cdent | this shit is too confusing | 16:57 |
*** Swami has joined #openstack-nova | 16:58 | |
*** jpena is now known as jpena|off | 16:58 | |
*** yamahata has quit IRC | 17:08 | |
mriedem | cdent: yeah, there are like 10 things that happen outside the scenes of everything... | 17:10 |
*** lpetrut has quit IRC | 17:10 | |
*** hemna_ has joined #openstack-nova | 17:13 | |
*** manasm has joined #openstack-nova | 17:18 | |
*** trinaths has joined #openstack-nova | 17:18 | |
efried | jaypipes ( cdent ) I finished reviewing the series starting at https://review.openstack.org/#/c/470575/ -- is there anything else to look at for NRP or related at the moment? | 17:18 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Network bandwitdh resource provider https://review.openstack.org/502306 | 17:18 |
cdent | efried: have you seen jay’s orm removal stack? | 17:19 |
cdent | it’s tangentially related | 17:19 |
efried | What's an orm/ | 17:19 |
efried | ? | 17:19 |
efried | (But I guess not) | 17:19 |
cdent | https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:no-orm-resource-providers | 17:19 |
efried | cdent rgr | 17:21 |
*** trinaths1 has quit IRC | 17:21 | |
cdent | efried: you’re already aware of alex’s traits work I think? | 17:22 |
efried | cdent Ah, sort of, but need to plug into it. Got a starter patch? | 17:22 |
cdent | it’s currently merge conflict, but: https://review.openstack.org/#/c/489206/7 | 17:23 |
efried | beaut | 17:23 |
efried | Amago eat, will dig in after. | 17:24 |
*** andrewbogott has left #openstack-nova | 17:25 | |
*** efried is now known as efried_nomnom | 17:25 | |
* cdent now wants sushi | 17:26 | |
cfriesen | question for someone with more sqlalchemy-foo than I....will the soft_delete() call at https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L5932 affect both the "aggregate" table and the "aggregate_hosts" table? Or just the "aggregate" table? | 17:28 |
*** ralonsoh has quit IRC | 17:30 | |
*** markvoelker has quit IRC | 17:30 | |
*** markvoelker has joined #openstack-nova | 17:30 | |
*** trinaths1 has joined #openstack-nova | 17:33 | |
*** lbragstad has quit IRC | 17:34 | |
*** trinaths has quit IRC | 17:34 | |
*** felipemonteiro_ has joined #openstack-nova | 17:35 | |
openstackgerrit | priyaduggirala proposed openstack/nova master: Rename parameters in call() of nova/image/glance.py https://review.openstack.org/508533 | 17:35 |
*** felipemonteiro__ has joined #openstack-nova | 17:36 | |
*** smatzek has quit IRC | 17:37 | |
*** smatzek has joined #openstack-nova | 17:38 | |
openstackgerrit | Merged openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486 | 17:40 |
*** felipemonteiro_ has quit IRC | 17:40 | |
openstackgerrit | Merged openstack/nova stable/ocata: Fix 500 if list servers called with empty regex pattern https://review.openstack.org/506760 | 17:40 |
*** smatzek_ has joined #openstack-nova | 17:40 | |
*** esberglu has quit IRC | 17:41 | |
*** manasm has quit IRC | 17:42 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Make allocation cleanup honor new by-migration rules https://review.openstack.org/498948 | 17:42 |
openstackgerrit | Dan Smith proposed openstack/nova master: Pre-create migration object https://review.openstack.org/498950 | 17:42 |
openstackgerrit | Dan Smith proposed openstack/nova master: Revert allocations by migration uuid https://review.openstack.org/498949 | 17:42 |
openstackgerrit | Dan Smith proposed openstack/nova master: Refactor resource tracker to account for migration allocations https://review.openstack.org/506419 | 17:42 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | 17:42 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make live migration hold resources with a migration allocation https://review.openstack.org/507638 | 17:42 |
*** smatzek has quit IRC | 17:42 | |
*** esberglu has joined #openstack-nova | 17:42 | |
*** esberglu has quit IRC | 17:42 | |
*** smatzek_ has quit IRC | 17:42 | |
*** esberglu has joined #openstack-nova | 17:42 | |
*** trinaths1 has left #openstack-nova | 17:43 | |
*** smatzek has joined #openstack-nova | 17:44 | |
*** gjayavelu has joined #openstack-nova | 17:44 | |
*** trinaths has joined #openstack-nova | 17:44 | |
*** yamahata has joined #openstack-nova | 17:44 | |
*** jgriffith has quit IRC | 17:45 | |
mriedem | cfriesen: the latter | 17:45 |
mriedem | there is no such thing as cascading soft deletes | 17:45 |
*** jgriffith_ is now known as jgriffith | 17:45 | |
mriedem | cfriesen: you could write a simple db api unit test to recreate that | 17:46 |
*** smatzek_ has joined #openstack-nova | 17:46 | |
*** smatzek__ has joined #openstack-nova | 17:48 | |
*** smatzek has quit IRC | 17:48 | |
*** itlinux has joined #openstack-nova | 17:49 | |
*** acormier has joined #openstack-nova | 17:50 | |
*** smatzek_ has quit IRC | 17:50 | |
*** smatzek__ has quit IRC | 17:51 | |
*** trinaths has left #openstack-nova | 17:51 | |
cfriesen | mriedem: I think that our online_data_migration will end up leaving a bunch of entries in the "aggregate_hosts" table after a migration....though properly written code shouldn't care. | 17:52 |
cfriesen | /s/migration/upgrade | 17:52 |
*** smatzek has joined #openstack-nova | 17:53 | |
mriedem | write a test to show that | 17:53 |
*** itlinux has quit IRC | 17:53 | |
*** smatzek has quit IRC | 17:54 | |
*** smatzek has joined #openstack-nova | 17:55 | |
*** trinaths has joined #openstack-nova | 17:57 | |
dansmith | mriedem: are you sure that dest_host is the ip in the case of cold migration? https://review.openstack.org/#/c/508603/1/nova/objects/migration.py | 17:57 |
*** lbragstad has joined #openstack-nova | 17:57 | |
dansmith | I was surprised to find this was true for live migration a couple weeks ago when debugging a real thing, | 17:58 |
dansmith | but I'm not sure it's the same for cold migration | 17:58 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Only query BDMs once in API during rebuild https://review.openstack.org/509574 | 17:58 |
mriedem | dansmith: yeah, that's what the RT sets it to | 17:58 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L368 | 17:59 |
mriedem | https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L393 | 17:59 |
mriedem | does live migration even set the migration.dest_host anywhere? | 17:59 |
melwitt | mriedem: it looks like the ceph package from the pike uca pulls in python-pastedeploy which gets install in parallel with a pip installed PasteDeploy package and keystone can't start because it has trouble referencing when there are multiple? (see last comment on https://ask.openstack.org/en/question/11458/keystone-all-importerror-cannot-import-name-deploy/) | 17:59 |
dansmith | actually we don't use moveclaim for live migration right? | 17:59 |
mriedem | dansmith: correct | 18:00 |
dansmith | maybe I had that reversed | 18:00 |
mriedem | that's why live migration creates the migratoin in conductor | 18:00 |
dansmith | ack | 18:00 |
dansmith | I think it's wrong for us to be setting the ip in that host field | 18:00 |
dansmith | in a "it's wrong but I'm not going to fix it any time soon" sort of way | 18:00 |
mriedem | dansmith: heh agree that it's surely confusing as hell | 18:00 |
*** MasterOfBugs has joined #openstack-nova | 18:00 | |
mriedem | hence my putting a patch to comment on those damn fields | 18:01 |
mriedem | b/c i have to re-look it up every time | 18:01 |
dansmith | yeah | 18:01 |
clarkb | melwitt: on ubuntu (where uca is a thing) the deb packages should install to /usr and pip installed things to /usr/local. So if you get the order sorted out I expect it would just work | 18:02 |
mriedem | melwitt: weird, is there an ubuntu bug report? | 18:03 |
mriedem | we could ask jamespage about a fix | 18:03 |
mriedem | melwitt: alternatively we could workaround that maybe in the devstack-plugin-ceph repo by monkeying with the packages | 18:03 |
*** itlinux has joined #openstack-nova | 18:04 | |
*** ijw has joined #openstack-nova | 18:04 | |
mriedem | heh, wtf, the compute rpcapi method for reboot_instance has a 'block_device_info' parameter that is always None from the API | 18:08 |
*** lpetrut has joined #openstack-nova | 18:09 | |
*** Sukhdev_ has quit IRC | 18:11 | |
*** itlinux has quit IRC | 18:12 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028 | 18:13 |
openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove CRUD operations on Inventory class https://review.openstack.org/509029 | 18:13 |
openstackgerrit | Jay Pipes proposed openstack/nova master: rp: streamline InventoryList.get_all_by_rp_uuid() https://review.openstack.org/509030 | 18:13 |
openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove dead code in Allocation._create_in_db() https://review.openstack.org/509031 | 18:13 |
openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove ability to delete 1 allocation record https://review.openstack.org/509032 | 18:13 |
openstackgerrit | Jay Pipes proposed openstack/nova master: rp: fix up AllocList.get_by_resource_provider_uuid https://review.openstack.org/509033 | 18:13 |
openstackgerrit | Jay Pipes proposed openstack/nova master: rp: rework AllocList.get_all_by_consumer_id() https://review.openstack.org/509035 | 18:13 |
openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove _HasAResourceProvider mixin https://review.openstack.org/509036 | 18:13 |
*** jdwidari has joined #openstack-nova | 18:15 | |
*** jdwidari has quit IRC | 18:15 | |
*** tonygunk has joined #openstack-nova | 18:16 | |
*** jdwidari has joined #openstack-nova | 18:18 | |
*** jdwidari has quit IRC | 18:18 | |
cdent | jaypipes: is that orm-removal stuff basically ready for review, or are you still working through the kinks? i’m out of juice to review it now, but tomorrow morning might be good | 18:19 |
*** edmondsw has quit IRC | 18:20 | |
jaypipes | cdent: ready for review, thanks. | 18:20 |
cdent | coolio | 18:20 |
jaypipes | cdent: even doing three or four of the bottom ones would be useful. | 18:21 |
jaypipes | they're pretty smallish patches. | 18:21 |
*** jdwidari has joined #openstack-nova | 18:21 | |
*** ociuhandu has quit IRC | 18:21 | |
jaypipes | cdent: fwiw, the HEAD of that series gets the resource_provider.py file to the point where I can do the root_provider_id/parent_provider_id fields (instead of the root_provider_uuid/parent_provider_uuid fields) that dansmith has asked for on the nested series. | 18:22 |
jaypipes | that dansmith has requested and that I agree with, btw | 18:22 |
mriedem | that reminds me, | 18:23 |
mriedem | andreykurilin: is there a devstack plugin for rally to make it easy to get an env setup? | 18:23 |
*** edmondsw has joined #openstack-nova | 18:23 | |
mriedem | oooo there is https://github.com/openstack/rally/tree/master/devstack | 18:24 |
mriedem | does it work? | 18:24 |
andreykurilin | mriedem: sure | 18:24 |
mriedem | what is the default backend when doing that? like do i need to also have ceilometer enabled? | 18:24 |
andreykurilin | mriedem: yes. it is used in all our gates | 18:24 |
andreykurilin | hm... ceilometer? rally has nothing related to ceilometer except test plugins for it. the default database backend is sqllite | 18:25 |
mriedem | ok yeah i was wondering about a db, i don't know much about rally, and i thought there was something to do with configuring it to send metrics collection to ceilometer | 18:25 |
mriedem | i'm looking for something simple to setup so i can compare test runs before and after some nova patch is applied | 18:26 |
mriedem | or, comparing scheduling times between ocata and pike | 18:26 |
mriedem | for example | 18:26 |
*** edmondsw has quit IRC | 18:28 | |
mriedem | i guess i should shut up and just read https://rally.readthedocs.io/en/latest/quick_start/tutorial.html | 18:28 |
andreykurilin | mriedem: so rally is quite simple and doesn't require any additional services to be installed. All the results are stored in the sql-dabase. One rally installation can check different clusters. The latest clients work perfectly with older releases of openstack. For example we have regular job which launch the scenarios at mitaka release | 18:29 |
mriedem | ok, i'm mostly interested in scheduling performance between ocata and pike, | 18:29 |
*** eharney has quit IRC | 18:29 | |
mriedem | i only have a single node devstack, so i'd have to get creative with mocking out computes | 18:30 |
*** eharney has joined #openstack-nova | 18:30 | |
*** sean-k-mooney has joined #openstack-nova | 18:30 | |
mriedem | i know devstack has some flags for mocking out fake compute services when using the fake virt driver, but not sure if that works anymore with the tiered conductor stuff in devstack | 18:31 |
mriedem | i could run it in singleconductor mode to workaround that | 18:31 |
*** efried_nomnom is now known as efried | 18:32 | |
*** vvargaszte has joined #openstack-nova | 18:32 | |
openstackgerrit | Merged openstack/nova master: Log consumer uuid when retrying claims in the scheduler https://review.openstack.org/507705 | 18:36 |
openstackgerrit | Merged openstack/nova master: [placement] gabbi tests for shared custom resource class https://review.openstack.org/485209 | 18:36 |
andreykurilin | mriedem: btw, I know some guys from huawei who are working on inner performance testing of openstack(as far as I know). I'll contact them about the hardware for such testing as you need | 18:38 |
mriedem | andreykurilin: are they in toronto? | 18:39 |
mriedem | hongbin's team? | 18:39 |
andreykurilin | mriedem: they are from China | 18:39 |
mriedem | oh | 18:39 |
mriedem | well, if you can get answers on internal openstack perf testing at huawei faster than i can, kudos to you sir | 18:40 |
andreykurilin | mriedem: heh. At least I'll try, but it will happen tomorrow, since they are slipping now | 18:41 |
mriedem | it's a chinese national holiday this week too | 18:41 |
openstackgerrit | priyaduggirala proposed openstack/nova master: Rename parameters in call() of nova/image/glance.py https://review.openstack.org/508533 | 18:41 |
melwitt | clarkb: sorry, was on a call. what did you mean by get the order sorted out between the uca package being installed and the pip package being installed? | 18:42 |
melwitt | mriedem: yeah, there's no ubuntu bug I don't think, because I think this is a unique problem to having devstack install PasteDeploy via pip and then the installation of ceph packages in the devstack plugin installing the uca packages | 18:43 |
melwitt | I thought the same, that I could probably do something like try uninstalling the uca python-pastedeploy package in the ceph devstack plugin and see if that would work | 18:44 |
clarkb | melwitt: basically make sure that apt-get happens first, then pip install, then keystone start | 18:44 |
melwitt | clarkb: ah, okay thanks. I'll see if that's possible in devstack plugin land, if there's a hook point for plugins that occurs before the pip installs that devstack does | 18:45 |
andreykurilin | mriedem: oh... yes, I forgot about it | 18:46 |
melwitt | because the devstack ceph plugin is doing the apt-get installs | 18:46 |
*** eharney has quit IRC | 18:47 | |
mriedem | melwitt: should be in this phase https://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/plugin.sh#L12 | 18:48 |
mriedem | check the logs and see if that happens before or after the pip install happens | 18:48 |
*** edmondsw has joined #openstack-nova | 18:48 | |
melwitt | hm, yeah ... so it should be doing the right thing already. looking | 18:49 |
melwitt | says "Requirement already satisfied: PasteDeploy===1.5.2 in /usr/lib/python2.7/dist-packages" which means it skipped the pip install | 18:54 |
melwitt | (I think) | 18:54 |
melwitt | so how is keystone not finding it | 18:54 |
openstackgerrit | Merged openstack/nova master: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/490722 | 18:54 |
melwitt | I had thought that because PasteDeploy was in the pip freeze output, that it had been pip installed too http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/pip2-freeze.txt.gz | 18:55 |
*** cdent has quit IRC | 18:55 | |
melwitt | but I guess that's not necessarily true | 18:55 |
mriedem | not necessarily | 18:55 |
mriedem | i remember yum installed packages show up in pip freeze output too | 18:55 |
mriedem | you just generally aren't using pip with rpms because things get wonky | 18:55 |
melwitt | yeah, huh. | 18:56 |
mriedem | right so it's setup via deb first http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/devstacklog.txt.gz | 18:57 |
mriedem | and then pip ignores it http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/devstacklog.txt.gz#_2017-10-04_01_50_59_811 | 18:57 |
clarkb | hrm pastedeploy 1.5.2 is latest | 18:57 |
clarkb | so is the ubuntu package just broken and not including all the bits? | 18:57 |
mriedem | oops first link is http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/devstacklog.txt.gz#_2017-10-04_01_49_51_453 | 18:57 |
melwitt | do you think it has anything to do with this? wsgi-file = /usr/local/bin/keystone-wsgi-public http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/etc/keystone/keystone-uwsgi-public.ini.txt.gz | 18:58 |
mriedem | we are using pike uca now | 18:58 |
mriedem | as of last week | 18:58 |
*** gouthamr has quit IRC | 18:58 | |
*** vvargaszte has quit IRC | 18:58 | |
melwitt | is the /usr/local/ there causing keystone to only look under /usr/local for paste deploy? | 18:58 |
*** dillaman has joined #openstack-nova | 18:58 | |
*** gouthamr_ has joined #openstack-nova | 18:59 | |
*** MasterOfBugs has quit IRC | 18:59 | |
melwitt | clarkb: hm, maybe. I hadn't considered the package could be broken | 18:59 |
cfriesen | is there a way to specify running a single functional test class? | 19:00 |
clarkb | cfriesen: tox -e functional -- ClassNameHere ? | 19:00 |
melwitt | mriedem: yeah, the ceph-mgr started pulling in python-pastedeploy starting in the pike uca | 19:00 |
clarkb | that actually takes a regex (or should) | 19:00 |
cfriesen | clarkb: will try it...I had done that with the full dotted path to the class and it didn't like it. | 19:00 |
*** artom_ is now known as artom | 19:01 | |
artom | cfriesen, clarkb's right, it should be a regex | 19:01 |
artom | So just ClassName should do it | 19:01 |
artom | Or even assName, because it matches as wlel | 19:01 |
mriedem | sorry make that monday https://review.openstack.org/#/c/505674/ | 19:01 |
cfriesen | artom: clarkb: nope. I ran "tox -e functional -- AggregateMigrationTestCase" and it started doing tests from nova.tests.functional.api.openstack.placement.test_placement_api | 19:02 |
*** baoli has quit IRC | 19:02 | |
melwitt | cfriesen: do you have an old checkout? there was some issues around the regex functionality that got fixed while we were at the PTG | 19:02 |
artom | cfriesen, hrmm - try without the --? | 19:02 |
mriedem | cfriesen: rebuild | 19:02 |
cfriesen | melwitt: entirely possible | 19:02 |
mriedem | tox -r -e | 19:02 |
*** baoli has joined #openstack-nova | 19:03 | |
*** eharney has joined #openstack-nova | 19:03 | |
melwitt | cfriesen: https://github.com/openstack/nova/commits/master/tox.ini I'd make sure you have the latest version of tox.ini | 19:03 |
*** felipemonteiro__ has quit IRC | 19:04 | |
*** felipemonteiro__ has joined #openstack-nova | 19:04 | |
*** oomichi is now known as oomichi_afk | 19:05 | |
*** edmondsw has quit IRC | 19:06 | |
*** edmondsw has joined #openstack-nova | 19:06 | |
*** crushil has quit IRC | 19:07 | |
*** crushil has joined #openstack-nova | 19:07 | |
cfriesen | combination of a fresh pull and tox -r seems to have done the trick | 19:08 |
cfriesen | thansk | 19:08 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: use already loaded BDM in instance.<action> https://review.openstack.org/483324 | 19:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: use already loaded BDM in instance.<action> (2) https://review.openstack.org/483955 | 19:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: use already loaded BDM in instance.create https://review.openstack.org/483969 | 19:14 |
*** slaweq_ has joined #openstack-nova | 19:14 | |
*** krypto has joined #openstack-nova | 19:17 | |
krypto | hello all i have a strange problem with Mitaka release ,on one compute if i enable debug to true nova-compute is restarting continously with error "UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 335: ordinal not in range(128)" with out debug everything is working as expected ,any idea? | 19:18 |
mriedem | krypto: there is likely some debug-only log message hitting something that's not encoded properly | 19:20 |
mriedem | i probably know what / where it is too | 19:20 |
*** tonygunk has quit IRC | 19:20 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1624277 is similar | 19:20 |
openstack | Launchpad bug 1624277 in OpenStack Compute (nova) mitaka "nova-scheduler: UnicodeDecodeError in host aggregates handling" [Medium,Confirmed] - Assigned to Nazeema Begum (nazeema123) | 19:20 |
mriedem | krypto: look at this fix in oslo.log https://review.openstack.org/#/c/371582/ which was never released in the mitaka series | 19:21 |
cfriesen | mriedem: I tweaked the code slightly to test the host aggregate migration, and confirmed that we don't soft-delete the entries in table 'aggregate_hosts'. Diff is here, with functional test output at bottom: http://paste.openstack.org/show/622702/ This shouldn't affect normal code, but it messed up one of our audits that verified DB consistency. | 19:21 |
mriedem | looks like oslo.log 3.9.0 has that fix | 19:21 |
mriedem | krypto: i've also seen one in nova-compute when logging the vif | 19:22 |
mriedem | i can't find the bug for it though | 19:23 |
krypto | i see thank you mriedem ,thanks alot i didnt know that turning debug=true could bring down nova-compute :) not sure whats wrong with my compute | 19:23 |
*** tonygunk has joined #openstack-nova | 19:23 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215 | 19:24 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 19:24 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 19:24 |
*** bnemec is now known as bnemec-backlater | 19:24 | |
mriedem | krypto: you would need to capture the stacktrace from the n-cpu logs and put those in a paste to know where the actual problem needs to be fixed, or if it's already fixed and you can cherry pick that fix to your mitaka env, since mitaka is eol upstream | 19:25 |
mriedem | it might not be in nova, it could be in glanceclient, i see fixed bugs for the same thing in glanceclient from several years ago | 19:26 |
krypto | okk let me check how to do that | 19:26 |
mriedem | http://paste.openstack.org/ | 19:26 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: use already loaded BDM in instance.<action> (2) https://review.openstack.org/483955 | 19:28 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: use already loaded BDM in instance.create https://review.openstack.org/483969 | 19:28 |
cfriesen | is there a way to boot an instance from a volume-exposed-as-cdrom, install to another volume-exposed-as-disk, then unmount the CDROM volume? Or to change boot order of volumes in the instance after it's created? | 19:28 |
*** trinaths has left #openstack-nova | 19:28 | |
*** hemna_ has quit IRC | 19:29 | |
*** READ10 has quit IRC | 19:34 | |
*** lbragstad has quit IRC | 19:35 | |
rybridges | Hello. Did we remove the ability to list servers by project/tenant id in the novaclient? | 19:36 |
rybridges | nova list --tenant-id <tenant_id> is not working. same if i try with openstack client | 19:36 |
rybridges | have tried all combinations of tenant_id, tenant-id, project_id, project-id in both openstack client and novaclient | 19:37 |
rybridges | but I see it in the documentation here https://developer.openstack.org/api-ref/compute/#listServers | 19:37 |
mriedem | rybridges: which version of novaclient? | 19:37 |
*** vladikr has quit IRC | 19:38 | |
mriedem | nova help list | 19:38 |
mriedem | shows me: | 19:38 |
mriedem | --tenant [<tenant>] Display information from single tenant (Admin | 19:38 |
mriedem | only). | 19:38 |
melwitt | you might have to specific --all-tenants too. and make sure tenant is a UUID | 19:39 |
melwitt | *specify | 19:39 |
mriedem | nova list --tenant f7832bfb6daf4a00b6c5687b2ab756fd totally works for me | 19:39 |
mriedem | as the admin and ^ is the demo tenant in devstack | 19:39 |
melwitt | oh, cool | 19:39 |
rybridges | I also tried using the raw python binding like so: nova_client.servers.list(detailed=True, search_opts={'tenant_id': '9dfb1c98d6224351b55ca6dd8e4246c6'}) but it does not seem to be filtering. it only returns the servers in the tenant which i instantiated the novaclient with. that tenant btw is admin so it should be able to query machines from other tenants. | 19:39 |
*** Sukhdev has joined #openstack-nova | 19:39 | |
*** baoli_ has joined #openstack-nova | 19:39 | |
*** sridharg has quit IRC | 19:40 | |
rybridges | novaclient version is 7.1.3 | 19:40 |
mriedem | i'm on 9.1.0 | 19:40 |
rybridges | ahh ok nova list --tenant is working | 19:40 |
mriedem | yeah, use the help to see what's supported | 19:40 |
mriedem | nova help list | 19:40 |
rybridges | used to be --tenant_id | 19:41 |
rybridges | was a bit confusing b/c docs make it sound like tenant_id will work | 19:41 |
*** baoli has quit IRC | 19:41 | |
mriedem | the api reference docs != the nova cli | 19:41 |
rybridges | right | 19:42 |
rybridges | well, nova list --tenant <id> does seem to work | 19:42 |
rybridges | now how can i do the same thing from the python binding | 19:42 |
mriedem | for review, gibi's bdm perf fixup series has my +2, https://review.openstack.org/#/q/topic:bug/1718226+(status:open+OR+status:merged) - it's pretty mechanical plumbing stuff | 19:42 |
mriedem | easy review | 19:42 |
rybridges | the docs just pointed me to the page i linked above | 19:42 |
rybridges | for a full list of search opts | 19:42 |
rybridges | but tenant, tenant_id, tenant-id, project, project_id, project-id all do not filter properly when using the python binding directly | 19:43 |
mriedem | rybridges: project_id and tenant_id are valid search opts to the GET /servers API | 19:44 |
mriedem | however, as noted in the docs, they only work if you're an admin making the request | 19:44 |
mriedem | so, are you doing this with an admin token | 19:44 |
mriedem | is the first question | 19:44 |
rybridges | when i instantiated the novaclient object in python | 19:45 |
rybridges | i passed it admin user/password | 19:45 |
mriedem | i guess the docs don't say this, but the nova cli help does | 19:45 |
rybridges | and i can list servers in the admin tenant | 19:45 |
mriedem | can you do: nova service-list? | 19:45 |
rybridges | when i pass a tenant id as a search opt, it still just returns the same servers that are in the admin tenant, not those in the project i specified | 19:45 |
mriedem | ok i think i see the issue | 19:46 |
*** ijw has quit IRC | 19:46 | |
rybridges | yes, nova.services.list() does work | 19:46 |
rybridges | from the python binding | 19:46 |
mriedem | https://review.openstack.org/#/c/426259/ | 19:46 |
rybridges | with the instance of nova client that i created | 19:46 |
mriedem | yup so we suck at documenting things in the api reference... | 19:46 |
rybridges | oh | 19:47 |
mriedem | rybridges: so try searching with project_id | 19:47 |
rybridges | so i must specify all_tenants | 19:47 |
mriedem | rather than tenant_id | 19:47 |
mriedem | well try ^ first | 19:47 |
rybridges | i have tried with project_id and i get the same behavior | 19:47 |
mriedem | ok probably because of search_opts['project_id'] = context.project_id | 19:48 |
mriedem | it overwrites the requested project_id filter with the one in the token | 19:48 |
mriedem | which is your admin project | 19:48 |
rybridges | okay i see now | 19:48 |
mriedem | so yeah you have to specify all_tenants | 19:48 |
rybridges | this is working: nova.servers.list(detailed=True, search_opts={'project_id': '9dfb1c98d6224351b55ca6dd8e4246c6', 'all_tenants': True}) | 19:48 |
rybridges | oof that sucks =( | 19:48 |
mriedem | yeah, we need to note this in the docs | 19:48 |
mriedem | i can push a patch in a bit | 19:48 |
mriedem | for the docs, not the actual api behavior | 19:49 |
rybridges | ok | 19:49 |
rybridges | that would be great | 19:49 |
melwitt | I think it used to be that all_tenants had to be passed to the CLI too but someone added automagic to do it if --tenant was passed since it's required for --tenant to work | 19:49 |
*** Sukhdev has quit IRC | 19:51 | |
rybridges | okay one more thing | 19:51 |
rybridges | since in the python binding i have to pass all_tenants | 19:51 |
rybridges | whenever i want to filter by project id | 19:51 |
rybridges | does that mean that novaclient is actually pulling all of the instances for all tenants back, and then filtering based on project id on the front end? | 19:51 |
rybridges | we dont want that, because we have tens of thousands of instances | 19:52 |
rybridges | and filtering all of that on the front end would be very slow | 19:52 |
mriedem | rybridges: it is filtering server-side | 19:52 |
*** nicolasbock has joined #openstack-nova | 19:52 | |
rybridges | okay | 19:52 |
rybridges | thank you ^.^ | 19:52 |
mriedem | which release are you testing this on? | 19:52 |
rybridges | stable/ocata | 19:53 |
mriedem | is this penick's cluster? | 19:53 |
rybridges | heh yes, penick is our architect | 19:53 |
mriedem | he is our lord and savior | 19:53 |
mriedem | ignore that | 19:54 |
rybridges | yes he is my lord and savior as well | 19:54 |
rybridges | :) | 19:54 |
jaypipes | heh | 19:54 |
jaypipes | well, with penick, most people are always looking UP at him. :) | 19:54 |
rybridges | i am one of the few who does not have to look up | 19:54 |
jaypipes | rybridges: wow, lucky you :) | 19:55 |
rybridges | i have 6'7" so he is only a couple inches taller than me | 19:55 |
jaypipes | :) | 19:55 |
rybridges | i am** | 19:55 |
jaypipes | rybridges: basically, all of us nova cores have capitulated to all of penick's demands because we're all afraid he will crush us with his pinky finger if we give him any lip. | 19:56 |
*** Sukhdev_ has joined #openstack-nova | 19:56 | |
jaypipes | rybridges: well, that and, you know, melwitt :) | 19:56 |
rybridges | bahahahaa | 19:56 |
jaypipes | rybridges: though melwitt could easily stomp on any of us with her boots :) | 19:57 |
mriedem | jaypipes: he doesn't have demands, because he know we can't fulfill anything for juno | 19:57 |
jaypipes | mriedem: lol, dig! | 19:57 |
mriedem | YES! | 19:57 |
rybridges | yea... freakin juno man | 19:57 |
dansmith | rybridges: that's what we call him | 19:57 |
dansmith | rybridges: "juno man" | 19:57 |
dansmith | like a superhero but...sadder | 19:57 |
jaypipes | edleafe: we ready on the alternate hosts/selection objects patches? just a rebase just now? | 19:58 |
jaypipes | edleafe: or blueprint changed... | 19:58 |
*** gszasz has quit IRC | 20:00 | |
edleafe | jaypipes: I changed the structure of the Selection object to match the spec | 20:02 |
jaypipes | got it. | 20:02 |
edleafe | jaypipes: should be ready for review | 20:02 |
edleafe | jaypipes: working on the code that changes the return from select_destinations now | 20:02 |
edleafe | it's... involved :) | 20:02 |
jaypipes | indeed. | 20:02 |
*** tbachman has quit IRC | 20:03 | |
*** vvargaszte has joined #openstack-nova | 20:04 | |
*** ianw is now known as ianw|pto | 20:04 | |
*** vvargaszte has quit IRC | 20:04 | |
*** felipemonteiro_ has joined #openstack-nova | 20:08 | |
*** pchavva has quit IRC | 20:09 | |
*** felipemonteiro__ has quit IRC | 20:11 | |
*** ijw has joined #openstack-nova | 20:17 | |
openstackgerrit | Merged openstack/nova master: Fix inconsistency of 'NOTE:' description https://review.openstack.org/508074 | 20:17 |
*** baoli_ has quit IRC | 20:20 | |
melwitt | clarkb: I think python-pastedeploy isn't being installed from the uca repo based on this http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/devstacklog.txt.gz#_2017-10-04_01_49_38_030 and trying installing it locally I'm able to do "from paste import deploy". so AFAICT the package isn't broken | 20:22 |
*** burt has joined #openstack-nova | 20:23 | |
dansmith | jaypipes: edleafe: slap me if I missed something on any of these comments: https://review.openstack.org/#/c/486215 | 20:24 |
*** flanders_ has joined #openstack-nova | 20:26 | |
openstackgerrit | Merged openstack/nova master: [placement] Update the placement deployment instructions https://review.openstack.org/469048 | 20:26 |
openstackgerrit | Merged openstack/nova master: api-ref: remove redundant preserve_ephemeral mention from rebuild docs https://review.openstack.org/509273 | 20:27 |
*** lbragstad has joined #openstack-nova | 20:27 | |
openstackgerrit | Merged openstack/nova master: api-ref: add note about rebuild not replacing volume-backed root disk https://review.openstack.org/509282 | 20:27 |
*** smatzek has quit IRC | 20:28 | |
*** smatzek has joined #openstack-nova | 20:28 | |
*** Nel1x has quit IRC | 20:29 | |
mriedem | aha, found a bug in a test | 20:29 |
penick | Take that, stupid test | 20:32 |
mriedem | yeah! | 20:32 |
*** smatzek has quit IRC | 20:33 | |
melwitt | does anyone know anything about wsgi_scripts in setup.cfg? I found that it's a directive for pbr to install scripts and they get installed to what setuptools considers to be the "install directory" and they end up in /usr/local/bin | 20:34 |
melwitt | is there any reason installing them that way would make it so they can't import modules that had been installed via apt-get? | 20:34 |
mriedem | sounds like a sdague question | 20:37 |
sdague | melwitt: import path will be determined by the python interpretter | 20:38 |
sdague | what's the execute line on it? | 20:38 |
*** zzzeek has quit IRC | 20:39 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid redundant BDM lookup in check_can_live_migrate_source https://review.openstack.org/509633 | 20:39 |
edleafe | dansmith: tempting, but I think those are good points | 20:39 |
dansmith | edleafe: \o/ | 20:40 |
melwitt | sdague: on the script? I'm not sure, it's generated by pbr from this https://github.com/openstack/keystone/blob/d20a3e971f5665604a739166987ed64e12c8de3d/keystone/server/wsgi.py#L36 | 20:40 |
sdague | right | 20:40 |
sdague | on my devstack it's #!/usr/bin/python | 20:40 |
*** ijw has quit IRC | 20:40 | |
sdague | the only thing I can imagine is if it got a weird value during build | 20:41 |
melwitt | I'm trying to debug a ceph job failure so I don't have info like that for that env | 20:41 |
sdague | melwitt: url? | 20:41 |
melwitt | the only difference I see between it and normal gate jobs is paste deploy is being installed from apt-get instead of pip | 20:41 |
sdague | that shouldn't really matter, as long as we aren't talking about a venv | 20:42 |
melwitt | sdague: here's how keystone fails to start http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/screen-keystone.txt.gz | 20:42 |
jaypipes | dansmith: no, I think those are accurate issues you've identified. | 20:43 |
melwitt | sdague: I don't understand how it's not able to import paste deploy if paste deploy is installed (with apt-get) | 20:43 |
melwitt | and I don't think it's double installed with apt-get AND pip. I think the pip installs are skipped because it was already installed with apt-get | 20:43 |
*** yassine has quit IRC | 20:44 | |
melwitt | like this is it being skipped later http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/devstacklog.txt.gz#_2017-10-04_01_50_59_811 | 20:44 |
sdague | melwitt: so... the more concerning thing is paste gets deployed again | 20:44 |
sdague | I think this is the python namespace issue | 20:44 |
sdague | paste & paste-deploy (which is really paste.deploy using a python namespace) | 20:45 |
sdague | end up being installed by apt | 20:45 |
sdague | then pip install new paste | 20:45 |
*** ijw has joined #openstack-nova | 20:45 | |
sdague | in /usr/local/lib | 20:45 |
sdague | which now means the search path for paste.* is in /usr/local/lib, the new one | 20:45 |
*** cleong has quit IRC | 20:45 | |
sdague | paste-deploy is not installed again, because the version looks the same to pip | 20:45 |
sdague | but it's in a different namespaced part of the tree | 20:46 |
sdague | so when you start importing it's not visible | 20:46 |
melwitt | oh, I see. damn | 20:46 |
sdague | this is why we got oslo to stop doing namespaces | 20:46 |
*** gouthamr_ has quit IRC | 20:46 | |
melwitt | I was focused only on paste.deploy | 20:46 |
sdague | yeh | 20:46 |
*** ijw has quit IRC | 20:46 | |
sdague | when I saw the upgrade of paste, that reminded me of this funky issue | 20:46 |
sdague | for this reason we try really hard to install very little python from system packages | 20:47 |
sdague | because you end up in exactly this situation | 20:47 |
melwitt | okay, so paste install wasn't skipped by pip for already existing because the version probably didn't satisfy | 20:47 |
sdague | I think the answer is to remove paste & paste-deploy from the dpkg list | 20:47 |
sdague | yes | 20:47 |
sdague | because of upper-constraints | 20:47 |
melwitt | guuhh | 20:47 |
melwitt | okay | 20:47 |
*** tbachman has joined #openstack-nova | 20:48 | |
clarkb | isn't paste-deploy coming in transitively in the dpkg list though? that could get tricky to remove | 20:48 |
melwitt | it's coming in through ceph package | 20:48 |
sdague | http://logs.openstack.org/32/508432/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/575e932/logs/devstacklog.txt.gz#_2017-10-04_01_51_18_464 | 20:48 |
sdague | melwitt: yeh, well that's going to be non compatible with the way we do things | 20:48 |
sdague | you could hack in a: pip install -U --force paste.deploy | 20:49 |
sdague | at the right part of the process | 20:49 |
sdague | that's probably the best option if the ceph package is dragging that stuff in | 20:50 |
melwitt | sdague: okay, yeah thanks. I'll see where I could put something like that in the devstack ceph plugin | 20:51 |
melwitt | thanks for your help cracking this | 20:51 |
*** tssurya_ has joined #openstack-nova | 20:53 | |
*** lpetrut has quit IRC | 20:54 | |
*** ijw has joined #openstack-nova | 20:55 | |
mriedem | omfg cells meeting in 5 minutes | 20:55 |
melwitt | !!! | 20:56 |
openstack | melwitt: Error: "!!" is not a valid command. | 20:56 |
melwitt | haha | 20:56 |
melwitt | my alarm alarmed openstack too | 20:56 |
*** ijw has quit IRC | 20:56 | |
*** ijw has joined #openstack-nova | 20:56 | |
*** zzzeek has joined #openstack-nova | 20:57 | |
*** smatzek has joined #openstack-nova | 20:57 | |
*** smatzek has quit IRC | 21:00 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512 | 21:03 |
*** vladikr has joined #openstack-nova | 21:08 | |
*** tssurya_ has quit IRC | 21:14 | |
*** felipemonteiro_ has quit IRC | 21:19 | |
*** felipemonteiro_ has joined #openstack-nova | 21:19 | |
*** zzzeek has quit IRC | 21:19 | |
*** krypto has quit IRC | 21:20 | |
*** ociuhandu has joined #openstack-nova | 21:20 | |
*** zzzeek has joined #openstack-nova | 21:20 | |
*** tbachman has quit IRC | 21:21 | |
edleafe | dansmith: I may get to slap you yet | 21:22 |
edleafe | dansmith: The test removed from test_filter_scheduler was testing pre-pike conductors that didn't pass instance_uuids. Now that we're in Queens, that test is no longer needed | 21:23 |
*** zzzeek has quit IRC | 21:23 | |
*** cali_boxer has joined #openstack-nova | 21:23 | |
cali_boxer | hello all | 21:24 |
*** zzzeek has joined #openstack-nova | 21:25 | |
*** crushil has quit IRC | 21:26 | |
mriedem | edleafe: if the test is no longer needed, did you also remove the code that's checking for empty instance_uuids? | 21:29 |
mriedem | edleafe: and if so, that should be split into a separate change | 21:30 |
*** sahid has quit IRC | 21:30 | |
*** edmondsw has quit IRC | 21:32 | |
dansmith | edleafe: the rpc api still allows for it to be empty right? | 21:32 |
*** edmondsw has joined #openstack-nova | 21:32 | |
melwitt | hm, devstack post-config happens after keystone is started. would not have expected that | 21:32 |
dansmith | edleafe: you don't just get to drop rpc compat when it's been long enough, you have to do the version work | 21:33 |
clarkb | melwitt: we were just talking about why that is in the keystone channel | 21:33 |
clarkb | melwitt: long story short there is no default default domain | 21:33 |
dansmith | edleafe: otherwise people that have version mismatches get uncool error messages instead of "this is too old for that" | 21:33 |
clarkb | melwitt: so you have to get keystone fully up and running before you can configure anything else | 21:33 |
dansmith | edleafe: I just dealt with one of those yesterday, where they thought they had upgraded conductor but hadn't | 21:33 |
melwitt | clarkb: hah, good coincidence. thanks for sharing | 21:34 |
*** slaweq_ has quit IRC | 21:34 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: note that project_id filter only works with all_tenants https://review.openstack.org/509650 | 21:36 |
mriedem | rybridges: ^ | 21:36 |
*** edmondsw has quit IRC | 21:37 | |
*** gszasz has joined #openstack-nova | 21:38 | |
*** tonygunk has quit IRC | 21:39 | |
*** catintheroof has quit IRC | 21:41 | |
openstackgerrit | Merged openstack/nova master: Remove unused get_all_instance_*metadata methods https://review.openstack.org/508299 | 21:42 |
openstackgerrit | Merged openstack/nova master: Remove old compat code from servers ViewBuilder._get_metadata https://review.openstack.org/508326 | 21:43 |
edleafe | dansmith: so if filter_scheduler gets a request without instance_uiuds, it has to return the old-style host_states without alternates? | 21:44 |
*** sree has joined #openstack-nova | 21:49 | |
*** takashin has joined #openstack-nova | 21:52 | |
*** ijw has quit IRC | 21:53 | |
*** sree has quit IRC | 21:53 | |
*** ijw has joined #openstack-nova | 21:54 | |
*** lyan has quit IRC | 21:54 | |
melwitt | sigh, I need to be able to do something after devstack does pip installs but before keystone starts and I'm not seeing a way | 21:57 |
melwitt | (in a devstack plugin) | 21:57 |
*** ijw has quit IRC | 21:58 | |
mriedem | https://github.com/openstack-dev/devstack/blob/master/stack.sh#L1196 ? | 22:00 |
mriedem | melwitt: look at the run phases in stack.sh | 22:00 |
mriedem | those are the hook points i think | 22:00 |
melwitt | yeah. but I noticed keystone starts before post-config, which it's not supposed to (or originally wasn't). clarkb explained about that a little bit ago | 22:01 |
mriedem | it looks like everything is started after post-config, EXCEPT keystone | 22:01 |
mriedem | yup | 22:01 |
* melwitt dies | 22:02 | |
mriedem | ah yup here https://github.com/openstack-dev/devstack/blob/master/stack.sh#L1064 | 22:02 |
*** kylek3h has quit IRC | 22:02 | |
mriedem | i'm guessing b/c the accounts are needed to configure the other services? | 22:03 |
mriedem | like configure nova to talk to cinder/glance/neutron | 22:03 |
mriedem | you have to have those things created in keystone first, which means starting keystone | 22:03 |
melwitt | he said it's because there's no default default domain | 22:03 |
mriedem | so besides a pre-start phase being added, | 22:03 |
mriedem | you could probably hack something up in stack.sh to at least test the theory, | 22:03 |
mriedem | by checking to see if ceph is configured for the backend | 22:04 |
*** slaweq_ has joined #openstack-nova | 22:04 | |
mriedem | like, if [[ $ENABLE_CEPH_CINDER == "True" ]]; then | 22:05 |
mriedem | https://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/override-defaults | 22:05 |
*** Sukhdev_ has quit IRC | 22:05 | |
melwitt | ah, I see. yeah, thanks | 22:06 |
mriedem | so like check that right here https://github.com/openstack-dev/devstack/blob/master/stack.sh#L1062 | 22:06 |
mriedem | and if ceph is enabled, do the dirty package thing | 22:06 |
melwitt | yeah, thanks. I was thinking, "how can I tell that if it's the ceph devstack plugin" but you were already on it | 22:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/509656 | 22:07 |
mriedem | there is probably also a way to find out if the ceph plugin is enabled, but this is an easier hack most likely | 22:07 |
mriedem | oh heh | 22:08 |
mriedem | is_plugin_enabled | 22:08 |
melwitt | oh hey | 22:08 |
mriedem | if [[ is_plugin_enabled "ceph" ]]; then | 22:08 |
mriedem | do that dirty package thing | 22:08 |
melwitt | saweet | 22:08 |
mriedem | fi | 22:08 |
mriedem | melwitt: devstack also has the ceph job in it's experimental queue so you can test it right in the devstack change itself | 22:09 |
melwitt | yesss | 22:10 |
*** brault has joined #openstack-nova | 22:10 | |
mriedem | eglynn can send checks to my house directly | 22:10 |
melwitt | lol | 22:10 |
*** awaugama has quit IRC | 22:10 | |
*** acormier has quit IRC | 22:11 | |
*** eharney has quit IRC | 22:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/509659 | 22:11 |
efried | jaypipes Is <SELECT Traits.id, Traits.name FROM Traits JOIN ResourceProviderTraits ON Traits.id == ResourceProviderTraits.trait_id and ResourceProviderTraits.resource_provider_id == $rp_id> more efficient than (or equivalent to) <SELECT id, name from Traits where id in (SELECT trait_id from ResourceProviderTraits WHERE resource_provider_id == $rp_id)> ?)> | 22:11 |
*** tbachman has joined #openstack-nova | 22:12 | |
*** acormier has joined #openstack-nova | 22:12 | |
*** gszasz has quit IRC | 22:14 | |
*** brault has quit IRC | 22:14 | |
*** felipemonteiro_ has quit IRC | 22:15 | |
*** acormier has quit IRC | 22:17 | |
jaypipes | efried: yes. | 22:19 |
efried | jaypipes Which, more efficient, or equivalent? | 22:19 |
jaypipes | efried: former is more efficient. | 22:20 |
efried | Because no sub-query | 22:20 |
efried | Dig, thanks. | 22:20 |
jaypipes | efried: though many modern optimizers will rewrite the subquery in the WHERE clause to be a JOIN | 22:20 |
efried | Yeah, I figured that was probably the case. | 22:20 |
efried | jaypipes The stuff we're using here, that looks like python code doing the joins and stuff - is that actually doing the magic in the database layer or in python? | 22:21 |
jaypipes | efried: DB | 22:21 |
efried | Must be some pretty heavy logic in there, like when some of those "methods" have conditionals embedded in 'em. | 22:22 |
jaypipes | efried: when using ORM queries that use things like joined_load eager and all that jazz, the SQL produced is less efficient. | 22:22 |
efried | jaypipes Like, how does something like ``sa.and_(t.c.id == rpt.c.trait_id, rpt.c.resource_provider_id == rp_id)`` *not* interpret those `==`s in python? | 22:23 |
dansmith | edleafe: yeah, you need to adjust the return value of that rpc method as well | 22:26 |
jaypipes | efried: oh, that's actually the beauty of SQLAlchemy's core expression API... it *does* interpret those things actually :) it's just what rpt.c.resource_provider_id == rp_id turns into is an expression object in SQLAlchemy that is processed with the __eq__ magic function... | 22:26 |
efried | ahhhh, __eq__, of course. Very cool. | 22:27 |
*** gouthamr has joined #openstack-nova | 22:27 | |
efried | jaypipes So I guess that means the order of the arguments in there is crucial. (rpt.c.resource_provider_id == rp_id) is cool, but (rp_id == rpt.c.resource_provider_id) is nonsense. | 22:28 |
jaypipes | efried: no... | 22:28 |
dansmith | edleafe: that's the next patch though right? | 22:28 |
efried | Wouldn't it try to use rp_id's __eq__ in that case? | 22:28 |
*** gjayavelu has quit IRC | 22:29 | |
jaypipes | efried: there's some magic reflection happening in the sa.and_() function. | 22:29 |
jaypipes | efried: where it's looking at the structure of the parameters supplied to it. | 22:29 |
efried | before the interpreter gets hold of it? That *is* magic. | 22:29 |
efried | jaypipes Because http://paste.openstack.org/show/622705/ | 22:30 |
dansmith | efried: if rp_id is an integer, then yes | 22:30 |
dansmith | the order would matter | 22:30 |
efried | dansmith Phew, that makes me feel more sane. | 22:31 |
*** tbachman has quit IRC | 22:32 | |
jaypipes | efried: there's lots o magic happening in https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/sql/operators.py | 22:32 |
jaypipes | efried: have fun reading :) | 22:32 |
efried | This is my first day looking at this sqlalchemy business. Appreciate the pointers. | 22:32 |
*** ociuhandu has quit IRC | 22:32 | |
jaypipes | no prob. BTW, zzzeek is the author of SQLAlchemy. I am sure he would be the best person to ask about magicalities in the core expression API. :) | 22:32 |
*** archit has quit IRC | 22:33 | |
*** gjayavelu has joined #openstack-nova | 22:34 | |
*** penick has quit IRC | 22:35 | |
efried | I'm pleased to report that nothing in that file blew my freaking mind, or made me expect (int == magic_sqlalchemy_object) not to explode. | 22:37 |
*** lbragstad has quit IRC | 22:38 | |
mriedem | so, dansmith, | 22:38 |
mriedem | have you and edleafe been up to something you're not telling the rest of us? | 22:38 |
*** tbachman has joined #openstack-nova | 22:38 | |
*** slaweq_ has quit IRC | 22:39 | |
dansmith | mriedem: um, what? | 22:40 |
mriedem | https://github.com/jaypipes/articles/commit/1a3dffb5f6fe688874c4f6617d139bf7af8f94c3 | 22:40 |
dansmith | mriedem: the banter was about the alternate hosts patch | 22:40 |
dansmith | WAT | 22:40 |
efried | dansmith Oh. On the other hand, it looks like __eq__ may internally handle the left-hand side not understanding the right: http://paste.openstack.org/show/622706/ | 22:40 |
efried | So it probably *would* work. | 22:41 |
dansmith | efried: I dunno how that works, | 22:41 |
*** edmondsw has joined #openstack-nova | 22:41 | |
dansmith | unless it only works against primitives or something | 22:41 |
melwitt | mriedem: lol | 22:41 |
efried | I imagine it's like 'except TypeError: try_the_other_guy's___eq___method' | 22:42 |
mriedem | i enjoy getting to do a pull request once per year | 22:42 |
dansmith | efried: see the second answer: https://stackoverflow.com/questions/3588776/how-is-eq-handled-in-python-and-in-what-order | 22:43 |
edleafe | mriedem: dansmith and I were trying to keep that a secret until the Forum! | 22:43 |
*** dillaman has quit IRC | 22:44 | |
* dansmith scowls at edleafe | 22:44 | |
efried | dansmith Beaut, thanks. | 22:44 |
*** slaweq_ has joined #openstack-nova | 22:44 | |
dansmith | efried: I did not think that worked that way | 22:44 |
efried | dansmith TIL, for sure. | 22:45 |
dansmith | and I might be remembering really old behavior, pre-new-style classes and all | 22:45 |
efried | Makes sense. Very prescient of those who wrote python itself. | 22:45 |
edleafe | dansmith: well, both patches change what is returned: this adds alternates, and the next changes them all to Selection objects | 22:45 |
edleafe | Old conductors won't know what to do with alternates | 22:46 |
*** edmondsw has quit IRC | 22:46 | |
dansmith | edleafe: yeah, then you need to pass a flag that says "give me the new stuff", or as mikal would say "do it to me big boy" | 22:46 |
dansmith | edleafe: I was thinking with all the "make this look like the existing return, change in next patch" stuff that we were remaining compatible here | 22:47 |
*** tbachman has quit IRC | 22:49 | |
*** gbarros has joined #openstack-nova | 22:49 | |
edleafe | dansmith: what's returned from the scheduler manager is the same. These changes are all internal to the scheduler | 22:50 |
edleafe | the next patch in the series is where all hell breaks loose | 22:50 |
dansmith | edleafe: okay but not all internal to the scheduler if the rpc api changes | 22:50 |
edleafe | I hope to have that in a decent state by tomorrow | 22:50 |
edleafe | the rpc api isn't changing in these | 22:50 |
edleafe | e.g.: https://review.openstack.org/#/c/486215/13/nova/scheduler/filter_scheduler.py@114 | 22:52 |
*** gbarros has quit IRC | 22:54 | |
dansmith | I'm confused | 22:55 |
*** ijw has joined #openstack-nova | 22:55 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146 | 22:55 |
dansmith | edleafe: you said that new conductors will always be passing uuids now.. that is an rpc interface between conductor and scheduler.. we're agreed that you need to keep the test and compat behavior there, yes? | 22:55 |
dansmith | and the other question is if you're changing the return type of the rpc call that conductor is making.. | 22:56 |
edleafe | dansmith: the instance_uuid change was in Pike | 22:56 |
dansmith | right | 22:57 |
edleafe | yeah, I'm keeping the test | 22:57 |
dansmith | okay, so .. the return value of the rpc call is changed here or no? | 22:57 |
edleafe | not yet | 22:57 |
edleafe | I am working on the next patch in the series where is changes | 22:57 |
edleafe | Needless to say, that breaks a lot of tests | 22:57 |
dansmith | edleafe: this one right? https://review.openstack.org/#/c/495854/5 | 22:58 |
dansmith | or that one is just internal still and then another one after will change what the rpc consumer gets? | 22:59 |
edleafe | no, that just changes the scheduler driver's return value to the manager | 22:59 |
edleafe | the next patch will change what the manager returns, which is the rpc boundary | 22:59 |
dansmith | right, okay | 22:59 |
dansmith | so in _that_ one you'll need a flag to say "give me the new stuff" | 22:59 |
*** sdague has quit IRC | 23:00 | |
dansmith | and in these before, as long as you keep that test for the empty uuids I think you're good | 23:00 |
*** esberglu has quit IRC | 23:00 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add alternate hosts https://review.openstack.org/486215 | 23:01 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 23:01 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 23:01 |
*** ijw has quit IRC | 23:01 | |
edleafe | dansmith: ^^ fixed per your comments | 23:01 |
*** esberglu has joined #openstack-nova | 23:01 | |
edleafe | only the first patch changed; the rest are rebases | 23:01 |
*** armax has quit IRC | 23:01 | |
edleafe | and with that it's time to make dinner | 23:03 |
dansmith | edleafe: cool, thanks | 23:05 |
dansmith | jaypipes: ^ | 23:05 |
*** esberglu has quit IRC | 23:05 | |
*** brault has joined #openstack-nova | 23:08 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146 | 23:08 |
*** brault has quit IRC | 23:13 | |
*** edmondsw has joined #openstack-nova | 23:13 | |
*** slaweq__ has joined #openstack-nova | 23:16 | |
*** mingyu has joined #openstack-nova | 23:16 | |
*** slaweq_ has quit IRC | 23:17 | |
*** crushil has joined #openstack-nova | 23:17 | |
*** hongbin has quit IRC | 23:18 | |
*** felipemonteiro_ has joined #openstack-nova | 23:20 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/newton: Updated from global requirements https://review.openstack.org/373293 | 23:20 |
*** slaweq__ has quit IRC | 23:21 | |
*** felipemonteiro__ has joined #openstack-nova | 23:21 | |
*** acormier has joined #openstack-nova | 23:24 | |
*** felipemonteiro_ has quit IRC | 23:25 | |
*** acormier has quit IRC | 23:28 | |
*** gmann_sleep is now known as gmann | 23:32 | |
*** dillaman has joined #openstack-nova | 23:33 | |
*** edmondsw has quit IRC | 23:35 | |
openstackgerrit | Merged openstack/nova stable/pike: Add nova-manage db command for ironic flavor migrations https://review.openstack.org/505903 | 23:37 |
*** chyka has quit IRC | 23:40 | |
openstackgerrit | LIU Yulong proposed openstack/nova-specs master: Reset the instance keypair while rebuilding (spec) https://review.openstack.org/375221 | 23:40 |
*** chyka has joined #openstack-nova | 23:41 | |
*** chyka has quit IRC | 23:45 | |
*** slaweq_ has joined #openstack-nova | 23:46 | |
openstackgerrit | Merged openstack/nova stable/ocata: Fix --max-count handling for nova-manage cell_v2 map_instances https://review.openstack.org/507556 | 23:51 |
gmann | mriedem: yes, that is kind of dead code. those are not going to be in filter_mapping as API 400 before it | 23:51 |
*** namnh_ has quit IRC | 23:52 | |
*** ijw has joined #openstack-nova | 23:53 | |
gmann | mriedem: we left this while doing schema for index. you have patch up for that cleanup otherwise i can push one. | 23:54 |
*** jdg has joined #openstack-nova | 23:56 | |
*** baoli has joined #openstack-nova | 23:58 | |
*** armax has joined #openstack-nova | 23:58 | |
*** ijw has quit IRC | 23:59 | |
*** baoli has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!