| *** tbachman has quit IRC | 00:02 | |
| *** baoli has quit IRC | 00:03 | |
| *** andreas_s has joined #openstack-nova | 00:04 | |
| *** claudiub|2 has quit IRC | 00:04 | |
| *** andreas_s has quit IRC | 00:08 | |
| *** andreas_s has joined #openstack-nova | 00:09 | |
| *** john51 has quit IRC | 00:12 | |
| *** john51 has joined #openstack-nova | 00:13 | |
| *** yangyapeng has quit IRC | 00:15 | |
| *** andreas_s has quit IRC | 00:15 | |
| *** yangyapeng has joined #openstack-nova | 00:15 | |
| *** andreas_s has joined #openstack-nova | 00:15 | |
| *** Swami has quit IRC | 00:16 | |
| *** yangyapeng has quit IRC | 00:20 | |
| *** andreas_s has quit IRC | 00:21 | |
| *** andreas_s has joined #openstack-nova | 00:21 | |
| *** links has joined #openstack-nova | 00:23 | |
| openstackgerrit | melanie witt proposed openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339 | 00:26 |
|---|---|---|
| *** andreas_s has quit IRC | 00:27 | |
| *** andreas_s has joined #openstack-nova | 00:27 | |
| *** andreas_s has quit IRC | 00:32 | |
| *** Apoorva_ has joined #openstack-nova | 00:32 | |
| *** andreas_s has joined #openstack-nova | 00:33 | |
| openstackgerrit | melanie witt proposed openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339 | 00:35 |
| *** Apoorva has quit IRC | 00:35 | |
| *** Apoorva_ has quit IRC | 00:36 | |
| *** baoli has joined #openstack-nova | 00:37 | |
| *** andreas_s has quit IRC | 00:44 | |
| *** trozet has quit IRC | 00:45 | |
| *** andreas_s has joined #openstack-nova | 00:53 | |
| *** namnh has joined #openstack-nova | 00:55 | |
| *** jichen has joined #openstack-nova | 00:58 | |
| *** litao__ has joined #openstack-nova | 00:59 | |
| *** lyan has quit IRC | 01:01 | |
| openstackgerrit | Merged openstack/nova master: Import the config drive docs from openstack-manuals https://review.openstack.org/514723 | 01:04 |
| openstackgerrit | Merged openstack/nova master: Import user-data page from openstack-manuals https://review.openstack.org/514738 | 01:04 |
| *** phuongnh has joined #openstack-nova | 01:05 | |
| *** dave-mccowan has quit IRC | 01:05 | |
| *** andreas_s has quit IRC | 01:06 | |
| *** andreas_s has joined #openstack-nova | 01:08 | |
| *** tinwood has quit IRC | 01:10 | |
| *** tinwood has joined #openstack-nova | 01:11 | |
| *** dave-mccowan has joined #openstack-nova | 01:12 | |
| *** andreas_s has quit IRC | 01:13 | |
| *** andreas_s has joined #openstack-nova | 01:14 | |
| *** trungnv has quit IRC | 01:15 | |
| *** salv-orl_ has joined #openstack-nova | 01:18 | |
| *** esberglu has joined #openstack-nova | 01:20 | |
| *** esberglu has quit IRC | 01:20 | |
| *** salv-orlando has quit IRC | 01:21 | |
| *** andreas_s has quit IRC | 01:24 | |
| *** huanxie has joined #openstack-nova | 01:24 | |
| openstackgerrit | Merged openstack/nova master: Handle exception on adding secgroup https://review.openstack.org/465173 | 01:25 |
| *** andreas_s has joined #openstack-nova | 01:26 | |
| *** yangyapeng has joined #openstack-nova | 01:26 | |
| *** yangyape_ has joined #openstack-nova | 01:27 | |
| *** yangyapeng has quit IRC | 01:27 | |
| *** esberglu has joined #openstack-nova | 01:30 | |
| *** yamahata has joined #openstack-nova | 01:33 | |
| *** andreas_s has quit IRC | 01:35 | |
| *** andreas_s has joined #openstack-nova | 01:36 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 01:37 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Rocky https://review.openstack.org/514101 | 01:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/pike: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513717 | 01:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova stable/ocata: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513721 | 01:38 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix an example in "Delete Assisted Volume Snapshot" https://review.openstack.org/514128 | 01:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | 01:39 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | 01:40 |
| *** psachin has joined #openstack-nova | 01:41 | |
| *** andreas_s has quit IRC | 01:45 | |
| *** esberglu has quit IRC | 01:46 | |
| *** andreas_s has joined #openstack-nova | 01:47 | |
| *** bbbbzhao_ has joined #openstack-nova | 01:47 | |
| *** trungnv has joined #openstack-nova | 01:49 | |
| *** gus has quit IRC | 01:50 | |
| *** itlinux has joined #openstack-nova | 01:50 | |
| *** AlexeyAbashkin has joined #openstack-nova | 01:51 | |
| *** gus has joined #openstack-nova | 01:51 | |
| *** gyee has quit IRC | 01:52 | |
| *** dikonoor has joined #openstack-nova | 01:55 | |
| *** yamahata has quit IRC | 01:55 | |
| *** AlexeyAbashkin has quit IRC | 01:55 | |
| *** andreas_s has quit IRC | 01:56 | |
| *** dikonoor has quit IRC | 02:01 | |
| *** amodi has joined #openstack-nova | 02:02 | |
| *** spectr has quit IRC | 02:03 | |
| *** Tom__ has joined #openstack-nova | 02:03 | |
| *** spectr has joined #openstack-nova | 02:05 | |
| *** coreywright has quit IRC | 02:11 | |
| *** liuyulong has joined #openstack-nova | 02:18 | |
| *** felipemonteiro_ has joined #openstack-nova | 02:20 | |
| *** Sukhdev has joined #openstack-nova | 02:20 | |
| *** dillaman has quit IRC | 02:22 | |
| *** hongbin has joined #openstack-nova | 02:27 | |
| *** phuongnh has quit IRC | 02:27 | |
| *** phuongnh has joined #openstack-nova | 02:28 | |
| *** itlinux has quit IRC | 02:29 | |
| *** masuberu has quit IRC | 02:34 | |
| *** gongysh has joined #openstack-nova | 02:35 | |
| *** gongysh has quit IRC | 02:36 | |
| openstackgerrit | Merged openstack/nova master: VGPU: Define vgpu resource class https://review.openstack.org/511180 | 02:41 |
| openstackgerrit | Merged openstack/nova stable/newton: Remove unused placement_database config options https://review.openstack.org/514685 | 02:41 |
| openstackgerrit | Merged openstack/nova master: Fix AttributeError in BlockDeviceMapping.obj_load_attr https://review.openstack.org/514825 | 02:41 |
| *** mrodden has quit IRC | 02:41 | |
| openstackgerrit | Merged openstack/nova master: Move blkid calls to privsep. https://review.openstack.org/500398 | 02:42 |
| *** larsks has quit IRC | 02:42 | |
| *** mrodden has joined #openstack-nova | 02:44 | |
| *** larsks has joined #openstack-nova | 02:44 | |
| *** itlinux has joined #openstack-nova | 02:45 | |
| *** coreywright has joined #openstack-nova | 02:48 | |
| *** itlinux has quit IRC | 02:48 | |
| *** AlexeyAbashkin has joined #openstack-nova | 02:51 | |
| *** Tom__ has quit IRC | 02:52 | |
| *** Tom has joined #openstack-nova | 02:52 | |
| *** itlinux has joined #openstack-nova | 02:53 | |
| *** masber has joined #openstack-nova | 02:55 | |
| *** AlexeyAbashkin has quit IRC | 02:55 | |
| *** masber has quit IRC | 02:57 | |
| *** masber has joined #openstack-nova | 02:57 | |
| *** phuongnh has quit IRC | 03:00 | |
| *** phuongnh has joined #openstack-nova | 03:01 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035 | 03:07 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035 | 03:09 |
| *** dave-mccowan has quit IRC | 03:10 | |
| *** annp has joined #openstack-nova | 03:14 | |
| *** zerda3 has joined #openstack-nova | 03:14 | |
| *** masber has quit IRC | 03:19 | |
| *** nicolasbock has quit IRC | 03:22 | |
| *** itlinux has quit IRC | 03:22 | |
| *** yamamoto has joined #openstack-nova | 03:22 | |
| *** dikonoor has joined #openstack-nova | 03:25 | |
| *** gouthamr has quit IRC | 03:25 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: [WIP] Add migration db and object pagination support. https://review.openstack.org/514904 | 03:35 |
| *** thorst has joined #openstack-nova | 03:35 | |
| *** amodi has quit IRC | 03:39 | |
| *** thorst has quit IRC | 03:41 | |
| *** AlexeyAbashkin has joined #openstack-nova | 03:51 | |
| *** mdnadeem has joined #openstack-nova | 03:54 | |
| *** AlexeyAbashkin has quit IRC | 03:55 | |
| *** sree has joined #openstack-nova | 03:56 | |
| *** erlon has quit IRC | 04:00 | |
| *** felipemonteiro_ has quit IRC | 04:01 | |
| *** masber has joined #openstack-nova | 04:02 | |
| *** yangyape_ has quit IRC | 04:03 | |
| *** masber has quit IRC | 04:04 | |
| *** masber has joined #openstack-nova | 04:04 | |
| *** baoli has quit IRC | 04:05 | |
| *** hongbin has quit IRC | 04:05 | |
| *** catintheroof has joined #openstack-nova | 04:19 | |
| *** catintheroof has quit IRC | 04:19 | |
| *** huanxie has quit IRC | 04:20 | |
| *** udesale has joined #openstack-nova | 04:22 | |
| *** markvoelker has quit IRC | 04:23 | |
| *** catintheroof has joined #openstack-nova | 04:23 | |
| *** diga has joined #openstack-nova | 04:26 | |
| *** abhishekk has joined #openstack-nova | 04:29 | |
| *** udesale has quit IRC | 04:34 | |
| *** diga has quit IRC | 04:35 | |
| Dinesh_Bhor | cfriesen: Hi, you there? | 04:37 |
| *** catintheroof has quit IRC | 04:38 | |
| *** catintheroof has joined #openstack-nova | 04:38 | |
| *** rmcallis has quit IRC | 04:41 | |
| *** catintheroof has quit IRC | 04:43 | |
| *** rmcallis has joined #openstack-nova | 04:44 | |
| *** bbbbzhao_ has quit IRC | 04:47 | |
| *** claudiub|2 has joined #openstack-nova | 04:49 | |
| *** dikonoor has quit IRC | 04:51 | |
| *** sridharg has joined #openstack-nova | 04:52 | |
| *** markvoelker has joined #openstack-nova | 04:55 | |
| *** vladikr has quit IRC | 04:55 | |
| *** diga has joined #openstack-nova | 04:55 | |
| *** vladikr has joined #openstack-nova | 04:55 | |
| *** huanxie has joined #openstack-nova | 04:59 | |
| *** vladikr has quit IRC | 05:07 | |
| *** vladikr has joined #openstack-nova | 05:07 | |
| *** yamahata has joined #openstack-nova | 05:12 | |
| *** gcb has joined #openstack-nova | 05:16 | |
| *** vks1 has joined #openstack-nova | 05:17 | |
| *** yamamoto has quit IRC | 05:17 | |
| *** yangyapeng has joined #openstack-nova | 05:18 | |
| *** Tom has quit IRC | 05:21 | |
| *** yangyapeng has quit IRC | 05:23 | |
| *** markvoelker has quit IRC | 05:24 | |
| *** armax has quit IRC | 05:24 | |
| *** armax has joined #openstack-nova | 05:24 | |
| *** markvoelker has joined #openstack-nova | 05:24 | |
| *** armax has quit IRC | 05:25 | |
| *** armax has joined #openstack-nova | 05:25 | |
| *** armax has quit IRC | 05:25 | |
| *** avolkov has joined #openstack-nova | 05:27 | |
| *** markvoelker has quit IRC | 05:28 | |
| *** vladikr has quit IRC | 05:31 | |
| *** vladikr has joined #openstack-nova | 05:31 | |
| *** ratailor has joined #openstack-nova | 05:33 | |
| *** thorst has joined #openstack-nova | 05:37 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035 | 05:39 |
| *** tbachman has joined #openstack-nova | 05:40 | |
| *** thorst has quit IRC | 05:41 | |
| *** trinaths has joined #openstack-nova | 05:43 | |
| *** nikhil has quit IRC | 05:45 | |
| *** tbachman has quit IRC | 05:48 | |
| *** sahid has joined #openstack-nova | 05:50 | |
| *** sree has quit IRC | 06:00 | |
| *** sree has joined #openstack-nova | 06:00 | |
| *** salv-orlando has joined #openstack-nova | 06:03 | |
| *** sshwarts has joined #openstack-nova | 06:03 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:03 | |
| *** Oku_OS-away is now known as Oku_OS | 06:04 | |
| *** salv-orl_ has quit IRC | 06:04 | |
| *** sree_ has joined #openstack-nova | 06:05 | |
| *** sree has quit IRC | 06:05 | |
| *** sree_ is now known as Guest13914 | 06:05 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580 | 06:10 |
| *** liusheng has joined #openstack-nova | 06:15 | |
| *** lajoskatona has joined #openstack-nova | 06:17 | |
| *** vladikr has quit IRC | 06:17 | |
| *** vladikr has joined #openstack-nova | 06:17 | |
| *** AlexeyAbashkin has quit IRC | 06:19 | |
| *** josecastroleon has quit IRC | 06:19 | |
| *** Sukhdev has quit IRC | 06:19 | |
| *** andreas_s has joined #openstack-nova | 06:20 | |
| *** rodolof has joined #openstack-nova | 06:30 | |
| *** udesale has joined #openstack-nova | 06:30 | |
| *** janki has joined #openstack-nova | 06:31 | |
| *** lpetrut has joined #openstack-nova | 06:33 | |
| *** lpetrut has quit IRC | 06:34 | |
| *** josecastroleon has joined #openstack-nova | 06:36 | |
| *** josecastroleon has quit IRC | 06:37 | |
| *** vladikr has quit IRC | 06:45 | |
| *** vladikr has joined #openstack-nova | 06:45 | |
| *** Eran_Kuris has quit IRC | 06:48 | |
| *** Eran_Kuris has joined #openstack-nova | 06:48 | |
| *** yamamoto has joined #openstack-nova | 06:49 | |
| *** gongysh has joined #openstack-nova | 06:52 | |
| *** ociuhandu has joined #openstack-nova | 06:53 | |
| *** josecastroleon has joined #openstack-nova | 06:55 | |
| *** fmount9 has joined #openstack-nova | 06:57 | |
| *** vladikr has quit IRC | 06:57 | |
| *** sahid has quit IRC | 06:58 | |
| *** sahid has joined #openstack-nova | 06:59 | |
| *** kaisers_ has joined #openstack-nova | 07:00 | |
| *** gszasz has joined #openstack-nova | 07:02 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Update document related to host aggregate https://review.openstack.org/514499 | 07:03 |
| *** josecastroleon has quit IRC | 07:03 | |
| *** rcernin has quit IRC | 07:04 | |
| *** ociuhandu has quit IRC | 07:05 | |
| *** yangyapeng has joined #openstack-nova | 07:05 | |
| *** josecastroleon has joined #openstack-nova | 07:07 | |
| *** tesseract has joined #openstack-nova | 07:09 | |
| *** gszasz has quit IRC | 07:10 | |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/511459 | 07:10 |
| *** salv-orlando has quit IRC | 07:12 | |
| *** salv-orlando has joined #openstack-nova | 07:12 | |
| *** salv-orlando has quit IRC | 07:16 | |
| *** ralonsoh has joined #openstack-nova | 07:19 | |
| *** markvoelker has joined #openstack-nova | 07:25 | |
| *** sahid has quit IRC | 07:26 | |
| *** gongysh has quit IRC | 07:28 | |
| *** huanxie has quit IRC | 07:31 | |
| *** sahid has joined #openstack-nova | 07:31 | |
| *** diga has quit IRC | 07:33 | |
| *** ragiman has joined #openstack-nova | 07:34 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Downgrade log for keystone verify client fail https://review.openstack.org/513243 | 07:34 |
| openstackgerrit | jichenjc proposed openstack/nova master: [Placement] Add create inventories doc for placement https://review.openstack.org/512215 | 07:36 |
| *** gszasz has joined #openstack-nova | 07:36 | |
| *** Tom has joined #openstack-nova | 07:36 | |
| *** yamamoto_ has joined #openstack-nova | 07:38 | |
| *** gongysh has joined #openstack-nova | 07:39 | |
| *** huanxie has joined #openstack-nova | 07:39 | |
| *** kashyap has joined #openstack-nova | 07:40 | |
| *** yamamoto has quit IRC | 07:42 | |
| *** salv-orlando has joined #openstack-nova | 07:42 | |
| *** jpena|off is now known as jpena | 07:43 | |
| *** hferenc has quit IRC | 07:45 | |
| openstackgerrit | jichenjc proposed openstack/nova master: add regression test for 1546396 https://review.openstack.org/293709 | 07:47 |
| openstackgerrit | jichenjc proposed openstack/nova master: fix race condition of instance host https://review.openstack.org/494458 | 07:47 |
| openstackgerrit | jichenjc proposed openstack/nova master: Fix warning on {'cell_id': 1} is an invalid UUID https://review.openstack.org/505471 | 07:52 |
| *** zerda3 has quit IRC | 07:53 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Remove incorrect comment about instance.locked https://review.openstack.org/515306 | 07:56 |
| *** markvoelker has quit IRC | 07:59 | |
| *** hferenc has joined #openstack-nova | 08:00 | |
| *** gcb has quit IRC | 08:01 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Remove incorrect comment about instance.locked https://review.openstack.org/515306 | 08:02 |
| *** diga has joined #openstack-nova | 08:03 | |
| *** AlexeyAbashkin has joined #openstack-nova | 08:03 | |
| *** namnh has quit IRC | 08:04 | |
| *** namnh has joined #openstack-nova | 08:04 | |
| *** sapcc-bot1 has quit IRC | 08:05 | |
| *** seife_ has joined #openstack-nova | 08:06 | |
| *** carthaca_ has joined #openstack-nova | 08:06 | |
| *** mkoderer_ has joined #openstack-nova | 08:06 | |
| *** sapcc-bot has joined #openstack-nova | 08:06 | |
| *** david_1 has joined #openstack-nova | 08:06 | |
| *** seife_ has quit IRC | 08:08 | |
| *** carthaca_ has quit IRC | 08:08 | |
| *** mkoderer_ has quit IRC | 08:08 | |
| *** david_1 has quit IRC | 08:08 | |
| *** hferenc has quit IRC | 08:08 | |
| *** rodolof has quit IRC | 08:10 | |
| *** hferenc has joined #openstack-nova | 08:10 | |
| *** slaweq has joined #openstack-nova | 08:14 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Add description for resource class creation https://review.openstack.org/508083 | 08:16 |
| *** yamamoto_ has quit IRC | 08:18 | |
| *** slaweq has quit IRC | 08:18 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 08:20 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 08:22 |
| *** rodolof has joined #openstack-nova | 08:22 | |
| *** david_1 has joined #openstack-nova | 08:22 | |
| *** carthaca_ has joined #openstack-nova | 08:22 | |
| *** mkoderer_ has joined #openstack-nova | 08:22 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 08:24 |
| *** carthaca_ has quit IRC | 08:24 | |
| *** mkoderer_ has quit IRC | 08:24 | |
| *** david_1 has quit IRC | 08:24 | |
| *** david-lyle has quit IRC | 08:24 | |
| *** hamzy has quit IRC | 08:24 | |
| bauzas | naichuans: jianghuaw: could you please upload new revisions in a series by rebasing on the existing changes? | 08:24 |
| *** david-lyle has joined #openstack-nova | 08:25 | |
| bauzas | naichuans: jianghuaw: https://review.openstack.org/#/c/512580/ is no longer dependent on https://review.openstack.org/#/c/514942/ | 08:25 |
| *** hamzy has joined #openstack-nova | 08:26 | |
| bauzas | naichuans: jianghuaw: I'll rebase those | 08:26 |
| bauzas | jianghuaw: thanks for your comment https://review.openstack.org/#/c/514763/ you're right | 08:28 |
| *** yamamoto has joined #openstack-nova | 08:28 | |
| jianghuaw | bauzas, u r welcome. Have you rebased the patch set. Otherwise Naichuan can do it now. | 08:29 |
| *** huanxie has quit IRC | 08:29 | |
| kashyap | bauzas: stephenfin: Hi there, what is the way to restore a specification? | 08:33 |
| *** yamamoto has quit IRC | 08:33 | |
| *** huanxie has joined #openstack-nova | 08:35 | |
| stephenfin | kashyap: In Gerrit? If it's not your spec, you need a core to do it I think? bauzas can | 08:35 |
| kashyap | stephenfin: Yeah, it's not my specc. | 08:35 |
| bauzas | stephenfin: kashyap: which spec? | 08:35 |
| kashyap | Context is, I was talking to KVM / QEMU developers at KVM Forum here. Incidentally Markus Zoeller was also here | 08:36 |
| kashyap | And I'd like to work on this spec -- https://review.openstack.org/#/c/230968/ | 08:36 |
| kashyap | bauzas: ^ | 08:36 |
| kashyap | "libvirt: iothreads for disk devices" | 08:36 |
| *** lpetrut has joined #openstack-nova | 08:36 | |
| bauzas | kashyap: you know it'll be a rocky spec, right? | 08:36 |
| kashyap | It's a future thing: since it's a performance feature, need to backup any claims in the spec with a couple of real benchmarks. | 08:37 |
| kashyap | bauzas: Yep, sure. | 08:37 |
| bauzas | kashyap: okay, so restoring | 08:37 |
| kashyap | bauzas: No urgency right now. Just want to chug along at it, as I get time | 08:37 |
| kashyap | Thank you | 08:37 |
| bauzas | restored | 08:37 |
| kashyap | bauzas: Merci beaucoup. (/me heads out for a break) | 08:38 |
| *** rmcallis has quit IRC | 08:39 | |
| *** lucas-afk is now known as lucasagomes | 08:41 | |
| *** rmcallis has joined #openstack-nova | 08:44 | |
| *** derekh has joined #openstack-nova | 08:45 | |
| *** ociuhandu has joined #openstack-nova | 08:47 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: VGPU_support: add enabled white list https://review.openstack.org/512580 | 08:49 |
| jianghuaw | bauzas, ^ | 08:50 |
| bauzas | jianghuaw: ta | 08:53 |
| jianghuaw | bauzas, how to get the allocation for vgpu in driver? | 08:55 |
| *** yamahata has quit IRC | 08:56 | |
| *** markvoelker has joined #openstack-nova | 08:57 | |
| bauzas | jianghuaw: I'm working on your comment | 08:58 |
| bauzas | basically, I should just add availableInstances + mdevs | 08:58 |
| jianghuaw | yeah, it should work. | 08:59 |
| jianghuaw | bauzas, I'm wondering how to get the allocation in driver at spawn. | 09:00 |
| bauzas | jianghuaw: the allocations are not passed by the parameter in spawn | 09:01 |
| bauzas | now* | 09:01 |
| bauzas | s/not/now | 09:01 |
| *** yamamoto has joined #openstack-nova | 09:01 | |
| jianghuaw | bauzas, where? I didn't find it. | 09:02 |
| *** AlexeyAbashkin has quit IRC | 09:02 | |
| jianghuaw | ah, yes. I see it. | 09:03 |
| jianghuaw | that's great. I was in a old branch. | 09:03 |
| *** huanxie has quit IRC | 09:05 | |
| *** yikun_jiang has joined #openstack-nova | 09:05 | |
| *** AlexeyAbashkin has joined #openstack-nova | 09:06 | |
| *** gszasz has quit IRC | 09:06 | |
| *** diga has quit IRC | 09:10 | |
| openstackgerrit | jichenjc proposed openstack/nova-specs master: Adds spec for instance live resize https://review.openstack.org/141219 | 09:14 |
| *** gszasz has joined #openstack-nova | 09:15 | |
| openstackgerrit | jichenjc proposed openstack/nova stable/pike: propagate OSError to MigrationPreCheckError https://review.openstack.org/515330 | 09:16 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: block_device_mapping_v2.bus_type is missing from api-ref https://review.openstack.org/499488 | 09:17 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190 | 09:18 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 09:20 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 09:20 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 09:20 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 09:20 |
| jaypipes | gibi: ^ | 09:20 |
| *** huanxie has joined #openstack-nova | 09:23 | |
| *** gongysh has quit IRC | 09:23 | |
| *** namnh has quit IRC | 09:24 | |
| *** namnh has joined #openstack-nova | 09:24 | |
| sahid | bauzas: you don't want to deal with availableInstances | 09:24 |
| sahid | that is informining of the number of a specific mdev type can be allocated by operators | 09:25 |
| *** david-lyle has quit IRC | 09:26 | |
| sahid | in this implmentation you are not going to allocate the mdev devices | 09:26 |
| *** dklyle has joined #openstack-nova | 09:26 | |
| sahid | the mdev devices are going to be pre-allocated | 09:26 |
| sahid | what you want is to list the allocated mdev devices | 09:26 |
| sahid | calling libvirt with list_devices('mdevs') | 09:27 |
| *** yikun_jiang has quit IRC | 09:27 | |
| *** hamzy has quit IRC | 09:27 | |
| *** yikun_jiang has joined #openstack-nova | 09:27 | |
| *** hamzy has joined #openstack-nova | 09:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-policy: Migrate to cliff https://review.openstack.org/515149 | 09:28 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 09:28 |
| *** markvoelker has quit IRC | 09:29 | |
| *** dtantsur|afk is now known as dtantsur | 09:31 | |
| stephenfin | jaypipes, bauzas: Trivial "move nova-network stuff around" patch here, if you want it? https://review.openstack.org/#/c/499168/ | 09:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Move additional nova-net opts to 'network' https://review.openstack.org/499168 | 09:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Move additional nova-net opts to 'network' https://review.openstack.org/499168 | 09:33 |
| openstackgerrit | jichenjc proposed openstack/nova-specs master: Adds spec for instance live resize https://review.openstack.org/141219 | 09:35 |
| *** AlexeyAbashkin has quit IRC | 09:37 | |
| gibi | jaypipes: thanks, the server side patches look good to me. Now reading the report client patch | 09:38 |
| *** yamamoto has quit IRC | 09:38 | |
| *** thorst has joined #openstack-nova | 09:39 | |
| *** takashin has left #openstack-nova | 09:39 | |
| jaypipes | gibi: cheers | 09:40 |
| gibi | jaypipes: Do I understand correctly that you will change the versioning still in the report client, based on your answer in https://review.openstack.org/#/c/385693/54/nova/scheduler/client/report.py ? | 09:41 |
| bauzas | jaypipes: I have a design question for you | 09:41 |
| bauzas | jaypipes: do you think it's acceptable to have an inventory of some resource class that is based on the sum of "left available resources" + "existing resources" ? | 09:42 |
| jaypipes | gibi: see latest patch on that. yeah, I set it to always pass 1.11 and bomb if server doesn't support that. | 09:42 |
| bauzas | jaypipes: speaking of the total value of course | 09:42 |
| jaypipes | bauzas: no | 09:42 |
| gibi | jaypipes: so the always doesn't mean that it is set in the __init__ of the client | 09:42 |
| bauzas | jaypipes: what makes me a sad panda is that I misread some documentation in https://libvirt.org/drvnodedev.html#MDEVCap | 09:43 |
| *** trinaths has left #openstack-nova | 09:43 | |
| jaypipes | gibi: no, just that that method always passes 1.11 | 09:43 |
| *** thorst has quit IRC | 09:43 | |
| jaypipes | gibi: because it expects to operate on the n-r-p attrs | 09:43 |
| bauzas | jaypipes: I thought "availableInstances" was the total capacity of a specific device for creating vGPUs, but that's actually just an integer which decrements every time you create a mediated device | 09:43 |
| jaypipes | bauzas: that is available i.e. total - used. | 09:44 |
| bauzas | jaypipes: yeah, my point | 09:44 |
| bauzas | jaypipes: so I can't use it for reporting the inventory | 09:44 |
| jaypipes | bauzas: it's a pointless attribute if you already have total and used counts. | 09:44 |
| bauzas | libvirt doesn't give me the API for the total number | 09:44 |
| jaypipes | bauzas: oh well, that's a flaw in libvirt. | 09:45 |
| bauzas | the "still" word in "how many instances of the given type can still be successfully created on the physical device" is just pissing me off | 09:45 |
| *** jichen has quit IRC | 09:45 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Convert IVS VIF plugging / unplugging to privsep. https://review.openstack.org/515196 | 09:46 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move infiniband vif plugging to privsep. https://review.openstack.org/515197 | 09:46 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move midonet vif plugging to privsep. https://review.openstack.org/515198 | 09:46 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move plumgrid vif plugging to privsep. https://review.openstack.org/515336 | 09:46 |
| *** AlexeyAbashkin has joined #openstack-nova | 09:46 | |
| bauzas | jaypipes: so seriously you would nack some reporting that would sum up that value with the existing already created mediated devices? | 09:46 |
| bauzas | I know, it's something racy racy | 09:47 |
| jaypipes | bauzas: no, I would be fine if you wanted to calculate total from used and available. | 09:47 |
| bauzas | ah ok, you make my day then | 09:47 |
| jaypipes | bauzas: just saying don't pass available as total :) | 09:47 |
| bauzas | jaypipes: of course | 09:47 |
| bauzas | sorry if I was unclear | 09:47 |
| jaypipes | since available is a calculated value | 09:48 |
| bauzas | I just spotted that as being a "left", not a "total" | 09:48 |
| jaypipes | bauzas: yup, that's totally cool with me (pun intended) | 09:48 |
| bauzas | English subtilities FTW | 09:48 |
| jaypipes | stephenfin: done | 09:48 |
| jaypipes | bauzas: or even subtleties :) | 09:48 |
| stephenfin | jaypipes: Ta :) | 09:49 |
| * stephenfin read that as subtitles | 09:49 | |
| *** gongysh has joined #openstack-nova | 09:49 | |
| bauzas | jaypipes: man, I should seriously consider being the Master of the World | 09:49 |
| bauzas | so, languages wouldn't be a problem | 09:49 |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/511459 | 09:49 |
| jaypipes | bauzas: :) | 09:49 |
| gibi | jaypipes: so _create_resource_provider() will always return an RP that contains the parent_provider_uuid but the _get_resource_provider only does the same is the placement latest version is bigger than 1.11. | 09:50 |
| jaypipes | stephenfin: I suppose that's better than "sub titties". | 09:50 |
| sahid | bauzas: in you implmentation, you want to also allocate the mdev? | 09:50 |
| bauzas | sahid: nope | 09:50 |
| bauzas | sahid: not in that change | 09:50 |
| gibi | jaypipes: s/is/if/ , s/bigger/bigger or equal/ | 09:51 |
| sahid | so why you don't len(allocated_mdev) ? | 09:51 |
| sahid | to get the total? | 09:51 |
| sahid | allocated does not mean assigned to a guest | 09:51 |
| bauzas | sahid: in that change, I'll focus on reporting the total number of possible mediated devices, which will be the sum up of what availableInstances reports + the sum of the mediated devices that belong to the same physical device | 09:51 |
| gibi | jaypipes: do we assume that the user of the report clean alway tries creating thing first and bails out if placement is older than 1.11 ? | 09:51 |
| jaypipes | gibi: yeah, I need to change that to have get_resource_provider() send 1.11 too | 09:52 |
| bauzas | sahid: oh my bad, a misunderstanding | 09:52 |
| gibi | jaypipes: s/clean/client/ | 09:52 |
| bauzas | sahid: yeah, I want to get the total number of possible mediated devices to be created, including the allocated mdevs | 09:52 |
| gibi | jaypipes: OK, then it would be easier to set a minimum version for the whole report client | 09:52 |
| bauzas | sahid: the fact they are assigned to the guest is unrelated with that change | 09:52 |
| jaypipes | gibi: ack, as edleafe said. | 09:53 |
| *** AlexeyAbashkin has quit IRC | 09:53 | |
| sahid | bauzas: so you just have to ask libvirt to get list the mdev devices, filter them by mdev_type | 09:53 |
| sahid | and use len() to get the total | 09:53 |
| bauzas | sahid: yup | 09:54 |
| gibi | jaypipes: will you do that in the current patch or as a followup? (/me triest to figure out what to vote on the current patch) | 09:54 |
| bauzas | for the allocated part | 09:54 |
| sahid | bauzas: what you are trying to do with availableinstance does not work | 09:54 |
| bauzas | available will give me the left amount | 09:54 |
| sahid | off course not | 09:54 |
| jaypipes | gibi: doing it now... | 09:55 |
| sahid | since when operator will allocate all the mdev, that value will be 0 | 09:55 |
| bauzas | what I need to report from the inventory is the total amount of VGPUs a specific resource provider can create | 09:55 |
| gibi | jaypipes: colle, then I will check back later | 09:55 |
| sahid | you do not need of it | 09:55 |
| gibi | jaypipes: s/colle/cool/ | 09:55 |
| * gibi cannot type today | 09:55 | |
| bauzas | sahid: ah, I see your point | 09:55 |
| bauzas | sahid: you were expecting the mdev to be manually created by the operator ? | 09:55 |
| sahid | bauzas: well that one was question at the beginning | 09:56 |
| bauzas | sahid: I was rather thinking of libvirt doing the syscall | 09:56 |
| sahid | bauzas: libvirt does not provide any api to allocate mdev | 09:56 |
| bauzas | sahid: we could make the sys call | 09:56 |
| bauzas | not by libvirt of course | 09:56 |
| bauzas | in the virt driver | 09:57 |
| sahid | oh ok so you want to also manage the allocation of mdev | 09:57 |
| bauzas | that's right | 09:57 |
| bauzas | because mdevs don't support reboots | 09:57 |
| sahid | basically that was my first question: 11:50 < sahid> bauzas: in you implmentation, you want to also allocate the mdev? | 09:57 |
| *** erlon has joined #openstack-nova | 09:57 | |
| sahid | but it's better like that for sure | 09:57 |
| sahid | +1 | 09:58 |
| bauzas | sahid: sorry about the confusion, the 'allocation' word is heavily used in my mind :p | 09:58 |
| bauzas | tbc, the workflow I see is that when you ask for an instance, the virt driver will lookup the allocations and see there is one for VGPUs | 09:58 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 09:59 |
| jaypipes | gibi: done, sir ^ | 09:59 |
| bauzas | then, it will call the system to create the mdev, and then create the XML with the according UUID | 09:59 |
| gibi | jaypipes: lookgin | 09:59 |
| bauzas | at init (when we reboot), we could also lookup the instances and see if they have mdevs in their domain XML, so we could recreate it on the fly | 10:00 |
| *** Guest62896 has quit IRC | 10:00 | |
| sahid | bauzas: well the uuid will be different | 10:01 |
| bauzas | sahid: you can create a mdev by passing a specific UUID right? | 10:01 |
| sahid | bauzas: yes you right, my mistake | 10:01 |
| bauzas | anyway, I need to fix a problem with my testing machine | 10:02 |
| bauzas | can't see the created mdevs for some reason | 10:02 |
| bauzas | very frustrating | 10:02 |
| *** sdague has joined #openstack-nova | 10:03 | |
| *** sambetts|afk is now known as sambetts | 10:09 | |
| *** masber has quit IRC | 10:09 | |
| gibi | jaypipes: thanks, I'm +2 | 10:10 |
| openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: implement get_inventory() driver method https://review.openstack.org/506175 | 10:11 |
| *** Tom has quit IRC | 10:12 | |
| *** andreas_s has quit IRC | 10:12 | |
| *** andreas_s has joined #openstack-nova | 10:13 | |
| *** namnh has quit IRC | 10:16 | |
| *** andreas_s has quit IRC | 10:17 | |
| *** gszasz has quit IRC | 10:22 | |
| *** rabel has joined #openstack-nova | 10:22 | |
| *** gszasz has joined #openstack-nova | 10:23 | |
| *** andreas_s has joined #openstack-nova | 10:24 | |
| *** markvoelker has joined #openstack-nova | 10:26 | |
| efried | jaypipes You're up early | 10:28 |
| *** andreas_s has quit IRC | 10:29 | |
| *** gmann is now known as gmann_afk | 10:29 | |
| *** Tom__ has joined #openstack-nova | 10:29 | |
| *** Tom__ has quit IRC | 10:34 | |
| *** gszasz has quit IRC | 10:34 | |
| *** Guest13914 has quit IRC | 10:34 | |
| *** sree has joined #openstack-nova | 10:35 | |
| *** andreas_s has joined #openstack-nova | 10:36 | |
| *** vks1 has quit IRC | 10:36 | |
| efried | dansmith FYI, this is what we were discussing yesterday: https://review.openstack.org/#/c/515223/ | 10:36 |
| efried | alex_xu yt? | 10:39 |
| *** yamamoto has joined #openstack-nova | 10:39 | |
| openstackgerrit | Merged openstack/nova master: Remove usage of kwarg retry_on_request in API https://review.openstack.org/501073 | 10:39 |
| *** sree has quit IRC | 10:40 | |
| *** cdent has joined #openstack-nova | 10:42 | |
| *** gcb has joined #openstack-nova | 10:43 | |
| *** yamamoto has quit IRC | 10:44 | |
| *** yamamoto has joined #openstack-nova | 10:47 | |
| *** andreas_s has quit IRC | 10:47 | |
| *** andreas_s has joined #openstack-nova | 10:49 | |
| *** gongysh has quit IRC | 10:52 | |
| *** andreas_s has quit IRC | 10:54 | |
| *** andreas_s has joined #openstack-nova | 10:54 | |
| *** nicolasbock has joined #openstack-nova | 10:54 | |
| *** jpena is now known as jpena|lunch | 10:59 | |
| *** markvoelker has quit IRC | 10:59 | |
| *** Tom__ has joined #openstack-nova | 11:03 | |
| *** huanxie has quit IRC | 11:03 | |
| *** phuongnh has quit IRC | 11:05 | |
| *** vks1 has joined #openstack-nova | 11:06 | |
| *** nicolasbock has quit IRC | 11:06 | |
| *** AlexeyAbashkin has joined #openstack-nova | 11:07 | |
| *** Tom__ has quit IRC | 11:07 | |
| *** vladikr has joined #openstack-nova | 11:08 | |
| *** andreas_s has quit IRC | 11:10 | |
| *** udesale has quit IRC | 11:13 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Do not attempt volume swap when guest is stopped/suspended https://review.openstack.org/389798 | 11:14 |
| *** nicolasbock has joined #openstack-nova | 11:20 | |
| *** masber has joined #openstack-nova | 11:22 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | 11:24 |
| *** yassine has joined #openstack-nova | 11:26 | |
| *** yassine is now known as Guest26707 | 11:26 | |
| *** gongysh has joined #openstack-nova | 11:26 | |
| *** andreas_s has joined #openstack-nova | 11:27 | |
| *** bkopilov_ has quit IRC | 11:28 | |
| *** janki has quit IRC | 11:31 | |
| *** links has quit IRC | 11:36 | |
| *** andreas_s has quit IRC | 11:36 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Add migration db and object pagination support. https://review.openstack.org/514904 | 11:36 |
| *** andreas_s has joined #openstack-nova | 11:38 | |
| *** smatzek has joined #openstack-nova | 11:39 | |
| *** lucasagomes is now known as lucas-hungry | 11:40 | |
| *** annp has quit IRC | 11:46 | |
| *** andreas_s has quit IRC | 11:48 | |
| *** andreas_s has joined #openstack-nova | 11:50 | |
| *** edmondsw has joined #openstack-nova | 11:50 | |
| *** vks1 has quit IRC | 11:51 | |
| *** dave-mccowan has joined #openstack-nova | 11:51 | |
| *** artom_ has joined #openstack-nova | 11:52 | |
| *** markvoelker has joined #openstack-nova | 11:57 | |
| *** jmccarthy has joined #openstack-nova | 11:57 | |
| *** ociuhandu_ has joined #openstack-nova | 12:01 | |
| *** thorst has joined #openstack-nova | 12:01 | |
| *** ociuhandu has quit IRC | 12:01 | |
| avolkov | jaypipes: hi, if not allowing to delete RP with associated traits is error or feature? | 12:02 |
| efried | cdent FWIW, my IDE complains when I use set([]) instead of {} for set literals. I agree it's tougher to read (though it's fewer characters, which is all-important in python :) Maybe I'll switch that IDE warning off. | 12:02 |
| *** ociuhandu_ has quit IRC | 12:02 | |
| cdent | yeah about that “fewer characters” thing,wait for my review on the next in the seriues | 12:02 |
| Dinesh_Bhor | jaypipes, bauzas: Hi, could you please give your opinion on this: https://review.openstack.org/#/c/512990/ when you get time. | 12:03 |
| cdent | efried: in that particular case since it is a doc string you can do whatever you like | 12:03 |
| jmccarthy | There seems to be an issue with console logging (in horizon) on xen compute, looking at the instance xml - I don't find any of the path .. console.log type definitions (as seen on other computes) ? Looking at https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py for clues .. | 12:03 |
| *** ratailor has quit IRC | 12:03 | |
| efried | cdent Roger wilco. | 12:03 |
| alex_xu | efried: hi, i'm here | 12:05 |
| jmccarthy | Any suggestions ? Editing the xml by hand works to a point (to try and find out what actually works), but changes it doesn't like don't seem to be applied | 12:05 |
| efried | alex_xu Hey, so I was thinking perhaps you and I should try to do some collaboration on these placement changes, edleafe style. | 12:05 |
| *** salv-orl_ has joined #openstack-nova | 12:06 | |
| alex_xu | efried: yea, that's good idea | 12:07 |
| efried | alex_xu E.g. I'd like to feel at liberty to write tests and make tweaks, but sometimes it makes a lot more sense to do it in the same change set rather than trying to do separate ones with commits based on each other and whatnot. | 12:08 |
| *** salv-orlando has quit IRC | 12:09 | |
| efried | alex_xu Here's the edleafe reference: https://blog.leafe.com/pair-development/ | 12:09 |
| alex_xu | give me 10 mins to ready edleafe's blog :) | 12:09 |
| alex_xu | s/ready/read/ | 12:10 |
| jaypipes | avolkov: the user should be able to delete a provider unless that provider has allocations against it. nothing to do with traits. | 12:10 |
| jaypipes | avolkov: does that answer your question? | 12:10 |
| efried | Dinesh_Bhor FYI, spec freeze has passed - is this proposed for Rocky? | 12:11 |
| avolkov | jaypipes: Yes, I file a bug then | 12:12 |
| Dinesh_Bhor | efried: yes, I will do the needful for that. I just want to take the early feedback. | 12:12 |
| jaypipes | avolkov: sounds good, thanks Andrey! :) | 12:12 |
| jaypipes | Dinesh_Bhor: ok, I can review it. but as efried said, please update it to point to rocky first, ok? | 12:12 |
| efried | jaypipes avolkov I don't remember if/where we landed on the issue of removing a trait from an RP with allocations against it. | 12:12 |
| alex_xu | efried: I guess edleafe means two people work on different timezone, anyone can fix the problem when review the code? | 12:13 |
| Dinesh_Bhor | jaypipes: yes, I will update it | 12:13 |
| *** jpena|lunch is now known as jpena | 12:13 | |
| efried | alex_xu I think of it as a tighter collaboration than that. You and I would agree to work on a particular patch or series, like the one you're doing for AllocationCandidates, together. | 12:14 |
| jaypipes | efried: since traits are not consumed, I don't have an issue with deleting providers that have traits assigned to them. | 12:14 |
| efried | jaypipes Other way around: removing a trait from a provider if that provider has allocations against it. | 12:14 |
| efried | jaypipes Objection being that then the RP may no longer "satisfy" the conditions that were originally in play when the allocation was made. | 12:15 |
| efried | jaypipes My take: who cares? You're never, like, re-checking afterwards. | 12:15 |
| efried | jaypipes If you need to do a migration or resize, you would have to reschedule anyway and find appropriate RPs. | 12:15 |
| *** Tom__ has joined #openstack-nova | 12:16 | |
| alex_xu | efried: ok, then what we can do? | 12:16 |
| efried | jaypipes I guess it could make resize-to-same-host impossible. But so could resource exhaustion. So... | 12:16 |
| jaypipes | efried: agreed. | 12:16 |
| efried | alex_xu Each of us ensures we upload patches in progress before we sign off for the day (so that we don't have local work-in-progress that gets overridden by the other) | 12:16 |
| efried | alex_xu Ideally we have a "handoff" time when we can briefly discuss anything as one of us leaves and the other comes on. | 12:17 |
| alex_xu | edleafe: ok, that should be under the situation the direction is solid | 12:17 |
| alex_xu | efried: yea, edleafe help me update the patches before when I'm sleeping | 12:17 |
| efried | alex_xu Okay. I obviously didn't want to start patching up your changes without discussing it first :) | 12:18 |
| efried | alex_xu So I assume you're at least close to done for the evening at this point. (What time zone are you in?) Want to talk about what's in progress, and how I can most effectively take over? | 12:19 |
| alex_xu | efried: yea, I will upload a version, and I think I can write some todo note in the code | 12:19 |
| alex_xu | basically, I want to add more unittest for next step | 12:20 |
| alex_xu | and then overall to look at the code, and see if there is anything need to be adjust | 12:20 |
| efried | alex_xu The ones about _get_provider_ids_with_any_resource returning incorrectly when there are exhausted inventories in play? | 12:21 |
| alex_xu | efried: I totally rewrite that sql | 12:21 |
| alex_xu | currently, what I'm doing is rewrite the comments...and add more unittests | 12:21 |
| artom_ | kaisers1, ping? | 12:22 |
| alex_xu | efried: how about I write some todo note in the commit message, then you can continue those todo, or fix anything you found when review the code? | 12:22 |
| efried | alex_xu Perfect. | 12:23 |
| kaisers_ | artom_: pong Hi | 12:23 |
| alex_xu | efried: cool, let us try how was that | 12:24 |
| *** sree has joined #openstack-nova | 12:24 | |
| efried | alex_xu 很好 :) | 12:25 |
| artom_ | kaisers_, hey, do you still run quobyte ci with dynamic_ownership = 0 in libvirt conf? | 12:25 |
| * alex_xu hopes all the developers speek Chinese | 12:25 | |
| *** sree has quit IRC | 12:29 | |
| *** markvoelker has quit IRC | 12:29 | |
| efried | jaypipes These failures are weird http://logs.openstack.org/93/385693/58/check/openstack-tox-py27/786b250/testr_results.html.gz -- you on top of it or want me to debug? | 12:29 |
| jaypipes | efried: on it already. | 12:29 |
| efried | jaypipes coo | 12:29 |
| kaisers_ | artom_: i think the setup did not change, yes. why? | 12:30 |
| efried | jaypipes Oh, the headers. I was misreading those as being part of the endpoint filter. Phew, not crazy. | 12:31 |
| artom_ | kaisers_, we've run into an interesting side effect of the workaround we put in place for that | 12:31 |
| artom_ | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3033 specifically | 12:31 |
| artom_ | If the compute node dies ungracefully, instances can't be started again because of permission denied on console.log | 12:32 |
| artom_ | We can probably hack something around that | 12:32 |
| artom_ | But I was kinda hoping the original reason for the original workaround had gone away | 12:32 |
| kaisers_ | artom_: hmm, yeah, would be great to get rid of that whole thing. I think i've an open idea on how to improve on that but currently i'm not coming 'round to implement that, at least not in the next 5-8 weeks | 12:34 |
| *** lucas-hungry is now known as lucasagomes | 12:34 | |
| artom_ | kaisers_, does the idea depend on knowledge of quobyte? Otherwise I'm game :) | 12:35 |
| *** READ10 has joined #openstack-nova | 12:35 | |
| kaisers_ | artom_: only marginally i think. I've to re-check my notes. I think it was centered around the idea to give a specific tag to libvirt which should ensure Quobyte is understood as a shared file system and libvirt should refrain from touching the files | 12:36 |
| kaisers_ | artom_: but that's from clouded memory | 12:36 |
| kaisers_ | pun not intended | 12:37 |
| artom_ | kaisers_, ah, Dan Berrange's comment | 12:37 |
| artom_ | I've read that | 12:37 |
| artom_ | That wouldn't be in nova code though, correct? | 12:37 |
| kaisers_ | artom_: yep, that's what i thought | 12:37 |
| kaisers_ | artom_: i think it should be in nova | 12:37 |
| kaisers_ | The libvirt xml would have to contain the tag iirc | 12:38 |
| artom_ | kaisers_, ah? I'll try to read up on that | 12:38 |
| *** gszasz has joined #openstack-nova | 12:38 | |
| kaisers_ | artom_: i think i started on that some time ago but had a hard time determining how exactly the tag has to look like | 12:39 |
| *** markvoelker has joined #openstack-nova | 12:40 | |
| artom_ | kaisers_, alright, I'll try and figure out what exact shape the fix should take | 12:41 |
| artom_ | Are you usually around at this time? I might poke you for info :) | 12:41 |
| *** gcb has quit IRC | 12:42 | |
| *** gcb has joined #openstack-nova | 12:42 | |
| *** sree has joined #openstack-nova | 12:43 | |
| kaisers_ | yep, usually i'm online around 07h - 15h UTC | 12:44 |
| *** sree_ has joined #openstack-nova | 12:44 | |
| *** sree_ is now known as Guest18426 | 12:45 | |
| artom_ | kaisers_, gotcha, thanks! Right this instant I need to tend to daycare logistics, but I'll try to work on this some more this morning (I'm on NA east coast) | 12:46 |
| *** sree has quit IRC | 12:48 | |
| *** gcb has quit IRC | 12:48 | |
| kaisers_ | artom: Go for it! :) | 12:49 |
| *** vks1 has joined #openstack-nova | 12:51 | |
| *** litao__ has quit IRC | 12:52 | |
| *** mvk has quit IRC | 12:52 | |
| *** baoli has joined #openstack-nova | 12:54 | |
| openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/511459 | 12:54 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 12:55 |
| jaypipes | efried, gibi: ^ fixed unit test failrues | 12:57 |
| efried | jaypipes +1 thanks | 12:58 |
| *** pchavva has joined #openstack-nova | 13:00 | |
| *** gongysh has quit IRC | 13:00 | |
| *** lyan has joined #openstack-nova | 13:02 | |
| *** tbachman has joined #openstack-nova | 13:06 | |
| *** rgerganov has quit IRC | 13:06 | |
| gibi | jaypipes: thanks, I but back my vote | 13:09 |
| *** mriedem has joined #openstack-nova | 13:11 | |
| openstackgerrit | Elod Illes proposed openstack/nova master: Transform keypair.import notification https://review.openstack.org/467514 | 13:13 |
| mriedem | claudiub|2: lpetrut: looks like hyperv ci might have issues on stable/pike https://review.openstack.org/#/c/515330/ | 13:13 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix AttributeError in BlockDeviceMapping.obj_load_attr https://review.openstack.org/515404 | 13:13 |
| *** hemna_ has joined #openstack-nova | 13:14 | |
| mriedem | sdague: bauzas: simple fix backport for a regression in pike https://review.openstack.org/#/c/515404/ | 13:14 |
| *** jaosorior has quit IRC | 13:16 | |
| *** mdnadeem has quit IRC | 13:17 | |
| *** eharney has joined #openstack-nova | 13:20 | |
| *** sbezverk has joined #openstack-nova | 13:20 | |
| *** strigazi has joined #openstack-nova | 13:22 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add _get_providers_with_any_resource method https://review.openstack.org/514197 | 13:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Enable _get_usages_by_provider_and_rc not filter on the resource class id https://review.openstack.org/514649 | 13:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add _get_traits_by_rp_ids method https://review.openstack.org/511184 | 13:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add ProviderSummaryList object https://review.openstack.org/514198 | 13:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add more caches for the ProviderSummary and ProviderSummaryList https://review.openstack.org/514199 | 13:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add AggregatedProviderSummary and AggregatedProviderSummaryList objects https://review.openstack.org/514200 | 13:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add has_resources method to the AggregatedProviderSummary object https://review.openstack.org/514650 | 13:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add as_allocation_request_obj method to AggregatedProvierSummary obj https://review.openstack.org/514651 | 13:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: rewrite AllocationCandidates.get_by_filters https://review.openstack.org/479766 | 13:22 |
| alex_xu | efried: jaypipes, all the functional tests passed ^ in the last patch, but it still is WIP, more unittests, and better commit message, and so on... | 13:23 |
| efried | alex_xu Ack. Anything in particular in there that I could/should work on today? | 13:24 |
| alex_xu | efried: I added todo note in the commit message https://review.openstack.org/#/c/514197/ | 13:25 |
| alex_xu | I want to separate that single unittest to multiple one | 13:25 |
| cdent | I like this todo in commit message handoff idea | 13:25 |
| efried | alex_xu Okay, I'll see if I can tackle that today. | 13:25 |
| jaypipes | alex_xu: yup, I'm getting to those reviews this morning. thanks for your patience. | 13:26 |
| *** yamamoto has quit IRC | 13:26 | |
| alex_xu | efried: and for other patch, few of them just missing the unittest, I didn't write the todo | 13:26 |
| alex_xu | but you can find them easily | 13:26 |
| alex_xu | jaypipes: thanks | 13:26 |
| efried | alex_xu I think I mentioned this in a comment, but eventually I'd like to extend _get_providers_with_any_resource to be able to do either 'any' or 'all'. | 13:27 |
| efried | alex_xu Because numbered groups are going to want *all*. | 13:27 |
| efried | which is a much easier thing to write SQL for. | 13:27 |
| efried | In fact, perhaps I can just write a separate method that does all resources *and* traits at the same time. | 13:27 |
| *** rmart04 has joined #openstack-nova | 13:27 | |
| alex_xu | efried: that what we doing currently, finally that will be huge sql, that is hard to maintain I think | 13:28 |
| efried | alex_xu I think the "any" thing is what makes it really tricky. But I'll play with it and see if it winds up looking too heinous to do in one shot. | 13:29 |
| alex_xu | efried: yea, it will be good you can take a look at the overall first, let us see which direction better | 13:30 |
| efried | alex_xu Sure thing. I'll go over the updates today in any case. | 13:31 |
| *** mvk has joined #openstack-nova | 13:32 | |
| *** smatzek has quit IRC | 13:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix the ocata config-reference URLs https://review.openstack.org/515410 | 13:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Import the config drive docs from openstack-manuals https://review.openstack.org/515053 | 13:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Import user-data page from openstack-manuals https://review.openstack.org/515054 | 13:35 |
| *** gouthamr has joined #openstack-nova | 13:35 | |
| lbragstad | gmann_afk: as far as i know, the policy deprecation work in oslo policy is just waiting on reviews | 13:36 |
| *** burt has joined #openstack-nova | 13:36 | |
| *** liuyulong has quit IRC | 13:38 | |
| *** awaugama has joined #openstack-nova | 13:39 | |
| *** rodolof has quit IRC | 13:40 | |
| *** felipemonteiro_ has joined #openstack-nova | 13:40 | |
| mriedem | stvnoyes: did you ever get a chance to test the new cinder attach patches and try to attach the same volume to the same instance multiple times even if the volume wasn't multiattach=true? | 13:42 |
| stvnoyes | no, I've been off on something else for the past week. I'll give it a try today | 13:43 |
| edleafe | alex_xu: I think adding a TODO in a commit message for a WIP patch is very smart | 13:43 |
| mriedem | stvnoyes: ok, alternatively i can just add something to a tempest test, push that up and make it depend on the nova api change | 13:44 |
| stvnoyes | having it in tempest would be good to have | 13:44 |
| mriedem | ok i'll put something up this morning | 13:44 |
| *** catintheroof has joined #openstack-nova | 13:45 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151 | 13:46 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223 | 13:46 |
| cdent | edleafe, efried, alex_xu: are you familiar with the “park on a slope” concept, when experiencing task interruptions? | 13:46 |
| efried | cdent I went ahead and made those couple of changes since I was editing the base patch anyway ^ | 13:46 |
| efried | cdent Not by that name. Googling... | 13:46 |
| *** catintheroof has quit IRC | 13:46 | |
| *** catintheroof has joined #openstack-nova | 13:46 | |
| edleafe | cdent: sorry, you just interrupted my task | 13:46 |
| cdent | efried: cool, given other commitments today it is unlikely I would have got back to it and/or there’s not enough coffee in the world to make my brain work | 13:46 |
| edleafe | cdent: no, not familiar | 13:46 |
| efried | Turns out that's kind of a tough thing to google. | 13:47 |
| cdent | it’s aligned with this idea of leaving a TODO in the wip commit. park your car in a way that if the battery is flat when you get back to it, you can still rolling start it | 13:48 |
| cdent | or in general: make it easy, by leaving info, to rolling start | 13:48 |
| cdent | stigmergy | 13:48 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Implement query param schema for flavor index https://review.openstack.org/515413 | 13:48 |
| *** dosaboy has quit IRC | 13:48 | |
| cdent | efried: google stigmergy if you want something detailed to google | 13:49 |
| *** amodi has joined #openstack-nova | 13:49 | |
| efried | cdent Neat - the ants-following-scent-trails thing was a great way to crystallize the concept in my head. | 13:50 |
| edleafe | efried: that's what we are, after all :) | 13:50 |
| efried | cdent edleafe Not sure I would go so far as to say we "lack any memory, intelligence or even individual awareness of each other" though. | 13:51 |
| edleafe | efried: so effin' literal! | 13:51 |
| *** catinthe_ has joined #openstack-nova | 13:52 | |
| cdent | efried: that somehow reminded me of an old blog post: https://www.burningchrome.com/~cdent/mt/archives/000187.html | 13:52 |
| cdent | efried: if we want to be an inclusive community that accepts all comers we should behave in a way that assumes there is no shared memory, that only external things can operate as memory | 13:52 |
| efried | *mind blown* | 13:53 |
| *** jaosorior has joined #openstack-nova | 13:53 | |
| *** catintheroof has quit IRC | 13:55 | |
| edleafe | efried: that's cdent's fancy way of saying "write it down!" | 13:55 |
| * cdent hires edleafe translate | 13:56 | |
| *** hongbin has joined #openstack-nova | 13:56 | |
| bauzas | sahid: as you pointed out, there is a bug that prevents mediated devices to be shown by libvirt https://bugzilla.redhat.com/show_bug.cgi?id=1463285#c6 | 13:57 |
| openstack | bugzilla.redhat.com bug 1463285 in libvirt "mediated devices are not shown in nodedev-list --cap mdev output" [High,Post] - Assigned to eskultet | 13:57 |
| bauzas | sahid: now, the problem is about which specific operator impact we should provide | 13:57 |
| stephenfin | dansmith: Wanna direct your nova-network wrath on this? https://review.openstack.org/#/c/499168/ | 13:58 |
| bauzas | sahid: if we ask operators to pre-create the mdevs, it can work for the next instances to be created | 13:58 |
| dansmith | stephenfin: I don't really have n-net wrath, but sure :) | 13:58 |
| bauzas | sahid: but for existing instances, it can be an operator painpoint because you need to exactly recreate the mdev with the same existing UUID | 13:58 |
| dansmith | anything to avoid working on this slide deck sitting in front of me | 13:59 |
| *** smatzek has joined #openstack-nova | 13:59 | |
| bauzas | as reboots wipe out mediated devices | 13:59 |
| bauzas | sahid: that's why I feel we should leave nova drive the creation, and not the operator | 13:59 |
| bauzas | sahid: unless mediated devices become persistent upon reboot :) | 13:59 |
| sahid | bauzas: what i could say is that, for SR-IOV we ask operator to allocate the VFs | 14:00 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Enable _get_usages_by_provider_and_rc not filter on the resource class id https://review.openstack.org/514649 | 14:00 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add _get_traits_by_rp_ids method https://review.openstack.org/511184 | 14:00 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add ProviderSummaryList object https://review.openstack.org/514198 | 14:00 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add more caches for the ProviderSummary and ProviderSummaryList https://review.openstack.org/514199 | 14:00 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add AggregatedProviderSummary and AggregatedProviderSummaryList objects https://review.openstack.org/514200 | 14:00 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add has_resources method to the AggregatedProviderSummary object https://review.openstack.org/514650 | 14:00 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add as_allocation_request_obj method to AggregatedProvierSummary obj https://review.openstack.org/514651 | 14:00 |
| openstackgerrit | Alex Xu proposed openstack/nova master: placement: rewrite AllocationCandidates.get_by_filters https://review.openstack.org/479766 | 14:00 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Reformat _get_all_with_shared https://review.openstack.org/512799 | 14:00 |
| sahid | if host is rebooting the operator can have the module to pre-allocate VFs anyway | 14:00 |
| sahid | but without the insurance that the PCI addresses will be the same as previously | 14:00 |
| *** dosaboy has joined #openstack-nova | 14:00 | |
| bauzas | sahid: but the domain XML will be incorrect then, right? | 14:00 |
| dansmith | stephenfin: can you fix that typo in the commit message and then I'll fast approve? | 14:00 |
| sahid | right | 14:00 |
| *** smatzek has quit IRC | 14:00 | |
| bauzas | sahid: if the VF is on the wrong PCI device | 14:01 |
| sahid | so operator have to deal with that | 14:01 |
| alex_xu | efried: ^ more todo, some of them is more interest than unittest, | 14:01 |
| bauzas | sahid: how can they deal with that ? | 14:01 |
| *** smatzek has joined #openstack-nova | 14:01 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Move additional nova-net opts to 'network' https://review.openstack.org/499168 | 14:01 |
| dansmith | stephenfin: or I can just do it in the ui I guess | 14:01 |
| *** smatzek has quit IRC | 14:01 | |
| sahid | reboot --force | 14:01 |
| stephenfin | dansmith: Done | 14:01 |
| bauzas | sahid: they dump all the instances XML before starting nova-compute? | 14:01 |
| stephenfin | ...from the UI :) | 14:01 |
| efried | alex_xu Ack | 14:01 |
| dansmith | stephenfin: done | 14:01 |
| *** smatzek has joined #openstack-nova | 14:01 | |
| bauzas | sahid: but a reboot breaks existing instances using VFs, right? | 14:01 |
| bauzas | since as you said, there is no guarantee that the newly created VF will match the one descibed in the domain XML | 14:02 |
| sahid | bauzas: there are some limitations, it's clear... what i'm trying to say is, if you can make them clear for your implementation so operator could deal with them | 14:02 |
| sahid | the libvirt design merged upstream for pci devices does not manage the devices | 14:03 |
| bauzas | sahid: I'm thinking about the fact that if I'm implementing something like nova creating the mdevs directly, we could just ask the operator to restart their libvirt deamon right after they start nova-computez | 14:04 |
| sahid | you could try to do it in nova | 14:04 |
| sahid | but that seems to be complicated | 14:04 |
| sahid | bauzas: what about to ask operator to do a force reboot? | 14:04 |
| dansmith | bauzas: restarting libvirt after nova-compute isn't reasonable, IMHO | 14:05 |
| dansmith | or starting | 14:05 |
| sahid | we have to double check but with a force-reboot we recreating the domainXML from scratch | 14:05 |
| *** mlavalle has joined #openstack-nova | 14:05 | |
| alex_xu | cdent: yea, always be interrupted, like meeting... | 14:06 |
| sahid | dansmith is right | 14:06 |
| bauzas | dansmith: that's a separate problem | 14:06 |
| bauzas | dansmith: there are two issues with libvirt managing mdevs | 14:07 |
| *** esberglu has joined #openstack-nova | 14:07 | |
| bauzas | dansmith: #1 is that mdevs aren't persistent upon reboots | 14:07 |
| bauzas | dansmith: #2 is that there is a kernel bug that prevents newly created mdevs to be seen by libvirt | 14:08 |
| *** rcernin has joined #openstack-nova | 14:08 | |
| bauzas | for #1, my take is that we shouldn't leave the operators deal with the mess of recreating specific mdevs based on specific UUIDs | 14:08 |
| bauzas | rather, it should be nova that should deal with that | 14:08 |
| dansmith | yeah | 14:09 |
| bauzas | for #2, it's just a kernel bug that is tackled by https://bugzilla.redhat.com/show_bug.cgi?id=1463285#c6 | 14:09 |
| openstack | bugzilla.redhat.com bug 1463285 in libvirt "mediated devices are not shown in nodedev-list --cap mdev output" [High,Post] - Assigned to eskultet | 14:09 |
| bauzas | then, it's unrelated to nova | 14:09 |
| dansmith | if restarting libvirt is a requirement as a workaround for a bug that will be fixed, then that's fine | 14:09 |
| bauzas | but we could workaround that by asking operators to restart their libvirt deamon | 14:09 |
| openstackgerrit | Hongbin Lu proposed openstack/nova stable/pike: Handle exception on adding secgroup https://review.openstack.org/515418 | 14:09 |
| dansmith | but yeah, if nova is creating mdevs with uuids and then we lose those on reboot, we have to recreate them, IMHO | 14:10 |
| bauzas | dansmith: that's my point, it's just a stupid workaround | 14:10 |
| dansmith | ack, makes sense | 14:10 |
| bauzas | and with some hope, distributions would ship the right fixed kernel | 14:11 |
| bauzas | or the fix could be backported in the supported kernel, either way | 14:11 |
| bauzas | sahid: dansmith: wait, I have another idea | 14:12 |
| bauzas | oVirt does get the mdev list by not calling the libvirt API, but rather directly checking the FS | 14:12 |
| *** rabel_b1 has joined #openstack-nova | 14:12 | |
| bauzas | that's why they're not impacted by the bug | 14:12 |
| bauzas | that could be another idea | 14:13 |
| bauzas | although I definitely prefer to use the libvirt API | 14:13 |
| *** marst has joined #openstack-nova | 14:13 | |
| openstackgerrit | Hongbin Lu proposed openstack/nova stable/ocata: Handle exception on adding secgroup https://review.openstack.org/515421 | 14:13 |
| dansmith | bauzas: it would be better to use libvirt too, but using sysfs directly isn't terrible.. however, if it's just a bug that will be fixed, it's not worth spending time on, IMHO | 14:14 |
| bauzas | yeah hopefully | 14:14 |
| bauzas | it's just a matter of correctly designing the interface for getting the mdevs | 14:14 |
| *** rabel__b1 has joined #openstack-nova | 14:14 | |
| *** dklyle has quit IRC | 14:15 | |
| bauzas | how we're getting them is just an implementation detail | 14:15 |
| *** rabel__b1 has quit IRC | 14:15 | |
| *** rabel has quit IRC | 14:15 | |
| *** rabel_b1 has quit IRC | 14:17 | |
| *** catinthe_ has quit IRC | 14:17 | |
| *** catintheroof has joined #openstack-nova | 14:17 | |
| *** armax has joined #openstack-nova | 14:18 | |
| *** jmlowe has joined #openstack-nova | 14:18 | |
| openstackgerrit | sean mooney proposed openstack/nova master: [WIP] add vif info to migration object https://review.openstack.org/515423 | 14:19 |
| cdent | jaypipes: responded to your query about empty allocations, it’s for the eventual use in POST, and at the api level it is only allowed in POST, not PUT. dansmith may have additional input. | 14:20 |
| dansmith | cdent: jaypipes: we need to be able to *atomically* replace an allocation with one from a different consumer, so we need to be able to nuke one and replace one in a single post | 14:21 |
| *** Swami has joined #openstack-nova | 14:22 | |
| mriedem | bauzas: you could add a workarounds config option to fallback to check the filesystem using privsep if you can't discover mdevs via the libvirt api | 14:24 |
| mriedem | so people affected by the bug could turn that option on | 14:24 |
| mriedem | and it sets a timer on when we remove the workaround | 14:24 |
| bauzas | mriedem: I thought on that, glad we're on the same page | 14:26 |
| *** yamamoto has joined #openstack-nova | 14:26 | |
| bauzas | mriedem: I'll either way need to use privsep for creating the mdev | 14:27 |
| bauzas | mriedem: because there is nothing in the libvirt API, that's a sysfs call | 14:27 |
| mriedem | stvnoyes: https://review.openstack.org/515426 | 14:30 |
| *** yamamoto has quit IRC | 14:32 | |
| *** nikhil has joined #openstack-nova | 14:41 | |
| *** scottda_ has quit IRC | 14:44 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: vgpu: add enabled white list https://review.openstack.org/512580 | 14:47 |
| *** david-lyle has joined #openstack-nova | 14:48 | |
| *** armax has quit IRC | 14:50 | |
| *** burgerk has joined #openstack-nova | 14:51 | |
| *** felipemonteiro__ has joined #openstack-nova | 14:52 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove 'vendordata_driver' opt https://review.openstack.org/397835 | 14:54 |
| bauzas | sahid: I don't understand exactly what you want as a format for https://review.openstack.org/#/c/514763/5/nova/virt/libvirt/config.py@2481 | 14:55 |
| *** felipemonteiro_ has quit IRC | 14:55 | |
| bauzas | sahid: you want a dictionary of dictionaries ? | 14:55 |
| bauzas | I'm fully open to ideas for a clear attribute | 14:55 |
| *** rmart04 has quit IRC | 14:58 | |
| sahid | bauzas: we have an instance of this class for each mdev device, right? no need of dictionary of dictionaries, a dictionary is enough | 14:58 |
| bauzas | sahid: no | 14:58 |
| bauzas | sahid: we have the list of all the supported types for that specific device | 14:59 |
| bauzas | sahid: with each type, we get the deviceAPI, availableInstances and the optional name | 14:59 |
| sahid | oh yes it's the mdev capabilities of the pci device | 14:59 |
| bauzas | yup, that https://libvirt.org/drvnodedev.html#MDEVCap | 14:59 |
| sahid | list of dict, no? | 14:59 |
| bauzas | that's what I wrote :p | 14:59 |
| sahid | :) | 15:00 |
| bauzas | the brackets could have confused you but it's not a list of tuples | 15:00 |
| *** trozet has joined #openstack-nova | 15:00 | |
| bauzas | I'll remove them to clarify | 15:00 |
| *** slaweq_ has quit IRC | 15:00 | |
| sahid | no no it's your comment the example which confused me, but it's my mistake I should have read better than that | 15:01 |
| *** lajoskatona has left #openstack-nova | 15:01 | |
| bauzas | I do wonder if I should use a namedtuple | 15:01 |
| bauzas | but let's see what other think | 15:02 |
| bauzas | others* | 15:02 |
| *** spectr has quit IRC | 15:02 | |
| *** jdandrea has quit IRC | 15:02 | |
| *** jaosorior has quit IRC | 15:02 | |
| *** baoli has quit IRC | 15:02 | |
| mriedem | edleafe: bauzas: dansmith: jaypipes: a shmorgasbord of comments in the Selection object patch https://review.openstack.org/#/c/499239/ | 15:03 |
| mriedem | edleafe: wondering if we should use the existing SchedulerLimits object to contain the limits/numa_limit fields | 15:03 |
| mriedem | like the reqspec | 15:03 |
| *** vks1 has quit IRC | 15:03 | |
| openstackgerrit | Merged openstack/nova master: Accept all standard resource classes in flavor extra specs https://review.openstack.org/514942 | 15:04 |
| edleafe | mriedem: things have come full circle :) | 15:04 |
| *** rcernin has quit IRC | 15:04 | |
| mriedem | you started with that? | 15:04 |
| edleafe | Is the plan that limits would be something that is not going away? | 15:04 |
| mriedem | they aren't going away in the near future | 15:05 |
| mriedem | why does that matter? | 15:05 |
| bauzas | -ETOOMANYTHINGSTODO | 15:05 |
| *** baoli has joined #openstack-nova | 15:05 | |
| edleafe | It was Jay's comment that limits are going away that got me to drop limits | 15:06 |
| dansmith | what does that have to do with how we put it in the object, if we know we need them for the short term? | 15:07 |
| mriedem | right - we need to pass limits down either way | 15:07 |
| mriedem | we are still supporting the caching scheduler | 15:07 |
| mriedem | so do we pass them differently from the requestspec when we already have an object that handles the exact same thing? | 15:07 |
| mriedem | i'd rather just re-use SchedulerLimits | 15:07 |
| edleafe | ok, if that's the current feeling | 15:08 |
| edleafe | I'll get started on that soon | 15:08 |
| mriedem | cool. i also tried to document some of the discussion we had in irc with dansmith a week or two ago about how redundant this all is with passing limits to compute in 3 different ways now, | 15:09 |
| mriedem | and that there isn't really a way around that for the time being | 15:09 |
| mriedem | and eventually the legacy filter props *should* go away | 15:09 |
| dansmith | ah | 15:09 |
| *** vks1 has joined #openstack-nova | 15:10 | |
| dansmith | edleafe: that SchedulerLimits object calls out the few limits we have specifically, which is better than just a dict of ints, yeah | 15:10 |
| dansmith | even more confined | 15:10 |
| dansmith | I didn't realize we had this | 15:10 |
| edleafe | dansmith: gotcha | 15:10 |
| edleafe | dansmith: I didn't know about it either | 15:10 |
| *** liverpooler has joined #openstack-nova | 15:12 | |
| *** baoli has quit IRC | 15:13 | |
| jaypipes | mriedem: so this one of your comments on a previous patchset should be ignored? "Given that, I think it's OK to restrict the limits field value to only things that we know about for in-tree filters and how limits are used in the claim/resource tracker code. Filters are pluggable, but the resource tracker is not." | 15:14 |
| dansmith | no? | 15:15 |
| dansmith | we're still talking about restricting the limits to the ones we know about | 15:15 |
| dansmith | we just can't get rid of them just yet | 15:15 |
| jaypipes | dansmith: ok. | 15:15 |
| jaypipes | dansmith: but we're only keeping them for the caching scheduler users, *not* because of out of tree filters. correct? | 15:16 |
| edleafe | dansmith: question: if SchedulerLimits is already part of the reqspec object, why is it needed in the Seleciton object at all? | 15:16 |
| dansmith | jaypipes: that's what his comment is saying | 15:16 |
| jaypipes | dansmith: ok. | 15:16 |
| dansmith | edleafe: because it differs per host | 15:16 |
| *** Oku_OS is now known as Oku_OS-away | 15:16 | |
| dansmith | edleafe: and because we have to pass at least ten copies of limits to the compute node or we lose our heavyweight championship title | 15:17 |
| *** Guest18426 has quit IRC | 15:17 | |
| *** sree has joined #openstack-nova | 15:18 | |
| *** josecastroleon has quit IRC | 15:18 | |
| *** baoli has joined #openstack-nova | 15:18 | |
| edleafe | dansmith: more is better! | 15:18 |
| dansmith | obvi | 15:18 |
| *** catintheroof has quit IRC | 15:20 | |
| *** catintheroof has joined #openstack-nova | 15:20 | |
| jaypipes | dansmith, mriedem: so I'm confused. if the RequestSpec and legacy filter properties are always passed to the compute service during a build operation, and those things contain the limits cruft, why do we want to pass limits information in the Selection object? | 15:21 |
| mriedem | sorry, was trying to cleanup reqspec madness in compute while it's fresh in my mind - sounds like we're all good? | 15:21 |
| mriedem | jaypipes: different limits per alternate | 15:21 |
| dansmith | that ^ | 15:21 |
| jaypipes | mriedem: gah. ok. | 15:21 |
| jaypipes | ack | 15:21 |
| mriedem | plus, the request spec is not passed back to the cell conductor during reschedules, | 15:21 |
| mriedem | so it won't be there for alternates | 15:21 |
| mriedem | i'm just noticing... | 15:21 |
| jaypipes | k, another good point, thanks. | 15:22 |
| mriedem | i'm going to polish some turds this morning | 15:22 |
| *** sree has quit IRC | 15:22 | |
| mriedem | oh i forgot, | 15:23 |
| mriedem | dansmith: :) | 15:23 |
| mriedem | limits are also passed as a direct kwarg from conductor to compute.build_and_run_instance | 15:24 |
| dansmith | ? | 15:24 |
| mriedem | 1. requestspec.limits | 15:24 |
| mriedem | 2. filterproperties.limits | 15:24 |
| mriedem | 3. direct limits kwarg | 15:24 |
| mriedem | 4. selection.limits | 15:24 |
| dansmith | and once per alternate | 15:24 |
| dansmith | because we rock | 15:24 |
| mriedem | * 4. selection.limits * max_attempts | 15:24 |
| dansmith | actually it's max_attempts +1 I think | 15:24 |
| *** sree has joined #openstack-nova | 15:24 | |
| dansmith | well, maybe not | 15:24 |
| dansmith | whatever | 15:24 |
| dansmith | too fucking many | 15:24 |
| mriedem | i mean seriously, can i just get some limits please | 15:25 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: proper fix for Quobyte CI https://review.openstack.org/515447 | 15:25 |
| *** catintheroof has quit IRC | 15:25 | |
| mriedem | unlimited ways to get the limits | 15:25 |
| artom_ | kaisers_, still around? | 15:25 |
| dansmith | we should limit our limits | 15:25 |
| *** artom_ is now known as artom | 15:25 | |
| mriedem | "nova: blowing up your rpc queue with limits since 2014" | 15:25 |
| efried | mriedem If your req spec turd polishing overlaps with https://review.openstack.org/#/c/515223/2/nova/scheduler/utils.py please let me know. | 15:27 |
| mriedem | right now it doesn't | 15:28 |
| mriedem | just going to try and clean up some things in the compute | 15:28 |
| mriedem | so that maybe by S we can stop passing at least limits and filter_properties down to the compute | 15:28 |
| *** yamamoto has joined #openstack-nova | 15:28 | |
| *** sree has quit IRC | 15:29 | |
| kaisers_ | artom: yep, few mins | 15:29 |
| *** jdwidari has joined #openstack-nova | 15:29 | |
| kaisers_ | artom: saw the cl | 15:29 |
| *** jdwidari has quit IRC | 15:29 | |
| *** AlexeyAbashkin has quit IRC | 15:29 | |
| *** ijw has joined #openstack-nova | 15:30 | |
| kaisers_ | artom: I'll check that out in detail tomorrow | 15:30 |
| *** jdwidari has joined #openstack-nova | 15:31 | |
| *** jdwidari has quit IRC | 15:31 | |
| *** jdwidari has joined #openstack-nova | 15:31 | |
| artom | kaisers_, aha, thanks! This is very very very preliminary | 15:31 |
| artom | kaisers_, but if we could get a quobyte CI run against that without dynamic_ownership = 0, it would be a first step | 15:32 |
| *** ijw has quit IRC | 15:32 | |
| artom | And ideally a way to recheck, still without dynamic_ownership = 0 | 15:32 |
| kaisers_ | artom: exactly. I'll spin up a manual instance and run tests, etc. | 15:32 |
| kaisers_ | that related to the previous comment... :) | 15:33 |
| *** yamamoto has quit IRC | 15:33 | |
| kaisers_ | artom: not sure about the automated recheck, I'll comment in the CL | 15:35 |
| artom | kaisers_, fantastic, thanks | 15:35 |
| artom | To be honest it might fail Jenkins CI | 15:36 |
| artom | So maybe wait for that to at least be sure we can still boot generic VMs with that patch ;) | 15:36 |
| *** baoli has quit IRC | 15:38 | |
| *** mvk has quit IRC | 15:39 | |
| *** baoli has joined #openstack-nova | 15:39 | |
| *** itlinux has joined #openstack-nova | 15:39 | |
| *** fmount9 has quit IRC | 15:41 | |
| *** baoli has quit IRC | 15:43 | |
| *** gyee has joined #openstack-nova | 15:43 | |
| *** trozet has quit IRC | 15:45 | |
| *** andreas_s has quit IRC | 15:46 | |
| *** andreas_s has joined #openstack-nova | 15:47 | |
| *** felipemonteiro_ has joined #openstack-nova | 15:49 | |
| *** baoli has joined #openstack-nova | 15:49 | |
| *** jdwidari has left #openstack-nova | 15:49 | |
| mriedem | bauzas: why does RequestSpec._from_hints turn the key=value from filter_properties into a key=[value] ? | 15:50 |
| *** catintheroof has joined #openstack-nova | 15:51 | |
| *** andreas_s has quit IRC | 15:51 | |
| *** felipemonteiro__ has quit IRC | 15:52 | |
| openstackgerrit | Merged openstack/nova master: Move project_id and user_id to Allocation object https://review.openstack.org/500410 | 15:53 |
| *** andreas_s has joined #openstack-nova | 15:53 | |
| *** ragiman has quit IRC | 15:53 | |
| *** baoli has quit IRC | 15:53 | |
| *** hemna_ has quit IRC | 15:54 | |
| mriedem | i guess because you can pass in hints like key=value1 key=value2 and the CLI will convert those to a key=[value1,value2] | 15:54 |
| mriedem | seems that _validate_instance_group_policy in the compute manager doesn't handle the hint value being a list at all | 15:55 |
| *** catintheroof has quit IRC | 15:55 | |
| mriedem | oh becaues the 'group' hint schema only allows a string value | 15:56 |
| mriedem | https://github.com/openstack/nova/blob/d36dcd52c24c32418fd358d245688c86664025d5/nova/api/openstack/compute/schemas/scheduler_hints.py#L21 | 15:57 |
| mriedem | fun, all of this being undocumented... :) | 15:57 |
| *** Apoorva has joined #openstack-nova | 15:59 | |
| *** catintheroof has joined #openstack-nova | 16:01 | |
| *** andreas_s has quit IRC | 16:03 | |
| *** andreas_s has joined #openstack-nova | 16:03 | |
| *** Guest26707 has quit IRC | 16:03 | |
| *** baoli has joined #openstack-nova | 16:08 | |
| *** fragatina has quit IRC | 16:09 | |
| *** andreas_s has quit IRC | 16:09 | |
| *** andreas_s has joined #openstack-nova | 16:10 | |
| *** armax has joined #openstack-nova | 16:10 | |
| *** sree has joined #openstack-nova | 16:14 | |
| *** slaweq has joined #openstack-nova | 16:16 | |
| *** baoli has quit IRC | 16:16 | |
| *** derekh has quit IRC | 16:17 | |
| *** psachin has quit IRC | 16:17 | |
| *** lucasagomes is now known as lucas-afk | 16:17 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use the RequestSpec when getting scheduler_hints in compute https://review.openstack.org/515461 | 16:18 |
| mriedem | bauzas: here you go ^ i'm helping! | 16:18 |
| *** andreas_s has quit IRC | 16:19 | |
| *** sree has quit IRC | 16:20 | |
| *** sridharg has quit IRC | 16:21 | |
| *** baoli has joined #openstack-nova | 16:21 | |
| *** baoli has quit IRC | 16:22 | |
| *** kaisers_ has quit IRC | 16:22 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use the RequestSpec when getting scheduler_hints in compute https://review.openstack.org/515461 | 16:22 |
| *** andreas_s has joined #openstack-nova | 16:24 | |
| *** yamamoto has joined #openstack-nova | 16:30 | |
| cdent | jaypipes: thanks for the review on the stack leading to POST /allocations. No, nobody suggested I split things up, I did that to try and keep things a bit smaller, led in part by the stack that is adding last-modified to lots of things, all under the same microversion | 16:31 |
| *** baoli has joined #openstack-nova | 16:32 | |
| jaypipes | cdent: sorry, I may have missed the last-modified thing... I don't see that anywhere in this patch series? | 16:32 |
| cfriesen | In _post_live_migration() at https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6075 why are we calling self._update_scheduler_instance_info() rather than self._delete_scheduler_instance_info() ? | 16:32 |
| cdent | jaypipes: it’s a different series, but has the same split behavior of docs/reno coming later | 16:32 |
| jaypipes | cdent: ack. I'd like to see all public API-modified changes in a single commit please. even if it leads to large commits. | 16:33 |
| cfriesen | One of our devs thinks that this is causing issues with the server group affinity filter by causing the scheduler to get out-of-date with the compute nodes. | 16:33 |
| jaypipes | cdent: just enables us to keep our "this single commit changes the API and in these ways" behaviour. | 16:33 |
| jaypipes | dansmith: thoughts on ^? | 16:33 |
| cdent | I thought we had relaxed some of that in favor of being able to review things a bit more discreetly? | 16:34 |
| sean-k-mooney | cfriesen: oh hi since your about do you know if the patches to fix live migration with vnic=macvtap were ever merged | 16:34 |
| jaypipes | cdent: I'm not aware of such a relaxation... | 16:34 |
| dansmith | yeah, we can't | 16:34 |
| jaypipes | cdent: but of course, I very easily could be wrong :) | 16:34 |
| cdent | it’s doable of course, but will require a fair bit of reordering on the last-modified stuff | 16:34 |
| cdent | which is fine | 16:34 |
| *** yamamoto has quit IRC | 16:34 | |
| dansmith | the only way around it is adding dead code in a commit, then turning it on later when you add the microversion | 16:34 |
| dansmith | but we can't add real functionality separate from the microversion itself | 16:34 |
| cdent | I’m not _not_ adding the microversion, just not doccing it | 16:35 |
| cdent | which perhaps should be considered the same thing? /me shrugs | 16:35 |
| dansmith | oh, I thought it was asserted that you were | 16:35 |
| cfriesen | sean-k-mooney: I don't think so....see https://review.openstack.org/#/c/136077/ and https://review.openstack.org/#/c/251387/ | 16:35 |
| *** andreas_s has quit IRC | 16:36 | |
| cdent | dansmith: no I’m starting a microversion and then adding different pieces of functionality or docs that are within that microversion in subsequent patches | 16:36 |
| cdent | so for example | 16:36 |
| cdent | https://review.openstack.org/#/c/495380/ | 16:36 |
| dansmith | cdent: that's the same thing as adding the functionality before the microversion, | 16:36 |
| sean-k-mooney | cfriesen: ok cool ill assume its stil broken then. ill try to make sure we can handel it properly in the multiple port binding work im doing | 16:37 |
| dansmith | although with the latter you can keep it dead until the microversion which is what you'd have to do | 16:37 |
| sean-k-mooney | cfriesen: i might not actully fix it but ill make sure not to break it more | 16:37 |
| cfriesen | sean-k-mooney: :) | 16:37 |
| cdent | dansmith: I’m not sure I’m fully parsing “that's the same thing as adding the functionality before the microversion," | 16:37 |
| dansmith | cdent: opening a microversion in one commit and extending it in another defeats the point of it, in that clients can't depend on the functionality you're adding when the microversion is exposed | 16:37 |
| dansmith | jaypipes: that's what you're trying to say right? ^ | 16:38 |
| jaypipes | dansmith: yeah | 16:38 |
| cdent | right, that’s where I guess I was misinformed/misunderstood on some of the relaxation with regard to CD | 16:38 |
| cdent | ain’t no thing, I’ll just fix it | 16:39 |
| cdent | but first I must go home | 16:39 |
| * cdent waves | 16:39 | |
| *** cdent has quit IRC | 16:39 | |
| openstackgerrit | Merged openstack/nova stable/pike: Fix AttributeError in BlockDeviceMapping.obj_load_attr https://review.openstack.org/515404 | 16:41 |
| edleafe | dansmith: so is it frowned upon to create separate patches to create the base for the version change in digestible chunks, and then turn it on with a single patch? | 16:41 |
| dansmith | edleafe: that's what I was saying above: if it makes real sense to do that, I think it's cool, you just need to make sure it's dead until the microversion gets added | 16:41 |
| jaypipes | edleafe: yes. AFAIK, we've never done/allowed that. | 16:41 |
| edleafe | Heh, I'll leave it to you two to fight it out | 16:42 |
| dansmith | jaypipes: we have definitely done that in the past, I'm quite sure.. as long as it's dead | 16:42 |
| dansmith | jaypipes: cdent was doing the opposite though AIUI, which is definitely not okay | 16:42 |
| jaypipes | edleafe: we've not allowed adding code that adds the microversion in one patch and modifies code that touches that microversion in a later patch. | 16:43 |
| *** lpetrut has quit IRC | 16:43 | |
| dansmith | right, exactly that | 16:43 |
| sean-k-mooney | dansmith: do you know why we never versioned the base LiveMigrationData object. im fixing that in https://review.openstack.org/#/c/515423/1/nova/objects/migrate_data.py but not sure why it was not done in the first place when changes to the base require version bumps to all the childeren anyway. | 16:43 |
| jaypipes | sorry, I guess I misread edleafe's comment. | 16:43 |
| edleafe | jaypipes: sure, but that's not what I asked | 16:43 |
| edleafe | sorta jinx | 16:43 |
| dansmith | sean-k-mooney: because it's required to be implemented per virt driver, so it's not possible to use the base object | 16:43 |
| dansmith | sean-k-mooney: so please don't "fix" that :) | 16:43 |
| *** namnh has joined #openstack-nova | 16:43 | |
| jaypipes | edleafe: ok. so is it clear now then? | 16:44 |
| sean-k-mooney | dansmith: but that breaks the versioning of all child objects if we dont... | 16:44 |
| dansmith | sean-k-mooney: breaks how? | 16:44 |
| edleafe | jaypipes: yes; it seemed earlier you were stating the opposite | 16:44 |
| *** baoli has quit IRC | 16:44 | |
| dansmith | sean-k-mooney: adding something to the base object requires a bump in all the subclasses.. that's intentional, not broken :) | 16:44 |
| *** ijw has joined #openstack-nova | 16:44 | |
| jaypipes | edleafe: ok, not sure why/how I was unclear earlier but as long as I'm clear now, ok. | 16:44 |
| *** baoli has joined #openstack-nova | 16:45 | |
| dansmith | sean-k-mooney: it's like an abc. just a template for the real implementations and a common superclass parent | 16:45 |
| dansmith | jaypipes: I was confused about what you said initially too, so.. | 16:45 |
| sean-k-mooney | dansmith: yes it does but not versioning the base mean we have to copy the make compatible function to all the childern | 16:45 |
| *** Swami has quit IRC | 16:45 | |
| dansmith | sean-k-mooney: I'm not sure what or why you say that | 16:46 |
| dansmith | oh I see what you mean | 16:46 |
| dansmith | sean-k-mooney: then yeah, that's what it means | 16:46 |
| *** andreas_s has joined #openstack-nova | 16:47 | |
| dansmith | the versions are all different, so you have to handle the version each one took that new change in | 16:47 |
| dansmith | registering doesn't help AFAIK | 16:47 |
| mriedem | heh, wtf, this dict is already a primitive :) https://github.com/openstack/nova/blob/d36dcd52c24c32418fd358d245688c86664025d5/nova/scheduler/utils.py#L83 | 16:48 |
| sean-k-mooney | ill be off until wednesday. but let me know if you would perfer me to duplicate the removal of the vifs into all the childeren or if the approch in the patch is ok | 16:48 |
| *** slaweq has quit IRC | 16:48 | |
| dansmith | sean-k-mooney: if that's what you have to do then yeah | 16:48 |
| *** slaweq has joined #openstack-nova | 16:48 | |
| dansmith | sean-k-mooney: you can unify a handler for that in the base class, and then just trigger it at the appropriate version for each child object or something | 16:49 |
| *** ijw has quit IRC | 16:49 | |
| sean-k-mooney | that what i basically did in https://review.openstack.org/#/c/515423/1/nova/objects/migrate_data.py | 16:49 |
| *** baoli has quit IRC | 16:49 | |
| dansmith | sean-k-mooney: ack, will comment | 16:50 |
| sean-k-mooney | dansmith: i don't really mind which way its done i just taught this refactor would be cleaner but im happy to do it another way too. | 16:51 |
| *** andreas_s has quit IRC | 16:51 | |
| dansmith | okay | 16:51 |
| *** mwynne has joined #openstack-nova | 16:52 | |
| *** slaweq has quit IRC | 16:53 | |
| *** jmccarthy has left #openstack-nova | 16:53 | |
| *** AlexeyAbashkin has joined #openstack-nova | 16:53 | |
| *** mvk has joined #openstack-nova | 16:54 | |
| *** AlexeyAbashkin has quit IRC | 16:57 | |
| *** sambetts is now known as sambetts|afk | 16:58 | |
| *** jpena is now known as jpena|off | 16:59 | |
| *** slaweq has joined #openstack-nova | 17:00 | |
| *** Swami has joined #openstack-nova | 17:02 | |
| *** avolkov has quit IRC | 17:03 | |
| *** claudiub|2 has quit IRC | 17:03 | |
| *** ralonsoh has quit IRC | 17:04 | |
| *** andreas_s has joined #openstack-nova | 17:06 | |
| *** ijw has joined #openstack-nova | 17:07 | |
| *** baoli has joined #openstack-nova | 17:09 | |
| *** fragatina has joined #openstack-nova | 17:10 | |
| *** hemna_ has joined #openstack-nova | 17:11 | |
| *** baoli has quit IRC | 17:12 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: rbd: flatten images when unshelving https://review.openstack.org/457886 | 17:16 |
| *** andreas_s has quit IRC | 17:17 | |
| *** cdent has joined #openstack-nova | 17:17 | |
| *** baoli has joined #openstack-nova | 17:17 | |
| *** jamesdenton has quit IRC | 17:17 | |
| *** jamesden_ has joined #openstack-nova | 17:17 | |
| *** jamesden_ is now known as jamesdenton | 17:18 | |
| *** yamahata has joined #openstack-nova | 17:18 | |
| *** dtantsur is now known as dtantsur|afk | 17:22 | |
| *** slaweq has quit IRC | 17:22 | |
| *** namnh has quit IRC | 17:25 | |
| *** sshwarts has quit IRC | 17:26 | |
| *** gszasz has quit IRC | 17:27 | |
| *** namnh has joined #openstack-nova | 17:29 | |
| *** yamamoto has joined #openstack-nova | 17:31 | |
| *** ijw has quit IRC | 17:33 | |
| *** yamamoto has quit IRC | 17:36 | |
| *** ijw has joined #openstack-nova | 17:36 | |
| *** andreas_s has joined #openstack-nova | 17:38 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 17:39 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 17:39 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159 | 17:39 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 17:39 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 17:40 |
| edleafe | mriedem: jaypipes: ^^ implemented SchedulerLimits for Selection | 17:40 |
| *** ijw has quit IRC | 17:40 | |
| gibi | mriedem: I've left my report about the notification subteam on the today's meeting agenda as I cannot participate. | 17:43 |
| mriedem | gibi: ok, thanks | 17:43 |
| *** andreas_s has quit IRC | 17:43 | |
| *** tesseract has quit IRC | 17:45 | |
| mriedem | edleafe: thanks, soft -1 on the new comment that got added | 17:47 |
| *** namnh has quit IRC | 17:47 | |
| mriedem | since i'm working on making that comment partially untrue | 17:47 |
| *** sree has joined #openstack-nova | 17:48 | |
| *** AlexeyAbashkin has joined #openstack-nova | 17:48 | |
| *** yamahata has quit IRC | 17:49 | |
| *** andreas_s has joined #openstack-nova | 17:50 | |
| *** Apoorva has quit IRC | 17:51 | |
| *** AlexeyAbashkin has quit IRC | 17:52 | |
| *** sree has quit IRC | 17:52 | |
| jaypipes | edleafe: cheers. will review shortly. | 17:53 |
| *** andreas_s has quit IRC | 17:55 | |
| *** andreas_s has joined #openstack-nova | 17:57 | |
| *** Apoorva has joined #openstack-nova | 17:58 | |
| edleafe | mriedem: well, since Jay wanted it recorded, I thought I'd include it, but I can easily remove it | 17:59 |
| mriedem | jaypipes: i assumed he meant recorded in gerrit | 17:59 |
| edleafe | mriedem: and Ill remove the mixin | 17:59 |
| edleafe | Hmmm... when I'm researching code behavior, Gerrit isn't where I look | 18:00 |
| *** slaweq has joined #openstack-nova | 18:00 | |
| *** slaweq has quit IRC | 18:01 | |
| mriedem | so leave a generic comment about us having to include limits in this thing because they are per-alternative host which isn't the same thing as limits in reqspec and filter_properties | 18:01 |
| mriedem | idk | 18:01 |
| *** andreas_s has quit IRC | 18:02 | |
| edleafe | I removed it. It's not like adding it there will suddenly unlock the secrets of Nova to future generations of coders :) | 18:06 |
| mriedem | right - i will still have to re-learn limits everytime i need to look at any of this | 18:07 |
| cdent | jaypipes: since you were in that stack recently, you have time to blip in the spec tune up? https://review.openstack.org/#/c/509136/ | 18:10 |
| *** Aditya has joined #openstack-nova | 18:11 | |
| *** ijw has joined #openstack-nova | 18:12 | |
| *** catintheroof has quit IRC | 18:13 | |
| *** vvargaszte has joined #openstack-nova | 18:14 | |
| *** andreas_s has joined #openstack-nova | 18:15 | |
| *** lpetrut has joined #openstack-nova | 18:18 | |
| *** andreas_s has quit IRC | 18:20 | |
| *** yamahata has joined #openstack-nova | 18:21 | |
| *** andreas_s has joined #openstack-nova | 18:22 | |
| *** Sukhdev has joined #openstack-nova | 18:25 | |
| *** slaweq has joined #openstack-nova | 18:26 | |
| *** slaweq has quit IRC | 18:29 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:30 | |
| *** andreas_s has quit IRC | 18:32 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Use the RequestSpec when getting scheduler_hints in compute https://review.openstack.org/515461 | 18:32 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass RequestSpec to ConductorTaskAPI.build_instances https://review.openstack.org/515495 | 18:32 |
| *** vks1 has quit IRC | 18:32 | |
| *** yamamoto has joined #openstack-nova | 18:32 | |
| *** Sukhdev has quit IRC | 18:33 | |
| *** AlexeyAbashkin has quit IRC | 18:34 | |
| *** sree has joined #openstack-nova | 18:35 | |
| *** gszasz has joined #openstack-nova | 18:35 | |
| *** andreas_s has joined #openstack-nova | 18:38 | |
| *** yamamoto has quit IRC | 18:38 | |
| cfriesen | repeat of earlier question since nobody answered it before...In _post_live_migration() at https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6075 why are we calling self._update_scheduler_instance_info() rather than self._delete_scheduler_instance_info() ? Seems logical that we would want to tell the scheduler "hey, this instance isn't here anymore". | 18:39 |
| *** sahid has quit IRC | 18:39 | |
| *** sree has quit IRC | 18:40 | |
| jaypipes | cdent: done | 18:40 |
| cdent | thanks | 18:40 |
| *** andreas_s has quit IRC | 18:42 | |
| mriedem | cfriesen: it's likely wrong | 18:42 |
| mriedem | cfriesen: i don't see post_live_migration_at_destination calling _update_scheduler_instance_info either | 18:42 |
| lbragstad | mriedem: i'm reading some of nova's policy documentation - is this a typo? https://github.com/openstack/nova/blob/master/nova/policies/security_groups.py#L35 | 18:44 |
| lbragstad | s/not/now/ / | 18:44 |
| mriedem | lbragstad: no, | 18:45 |
| mriedem | because you can still add/remove a security group to a server | 18:46 |
| mriedem | via the addSecurityGroup API action on the server resource | 18:46 |
| mriedem | https://developer.openstack.org/api-ref/compute/#add-security-group-to-a-server-addsecuritygroup-action | 18:46 |
| lbragstad | mriedem: ok - cool, just double checking | 18:46 |
| mriedem | we could probably deprecate that... | 18:46 |
| mriedem | we deprecated things like addFixedIP and addFloatingIP in pike | 18:47 |
| mriedem | because you can do those in neutron via the port associated with the instance | 18:47 |
| mriedem | and all nova is doing is getting the ports for the instance and the security group and updating the port to use the secgroup | 18:47 |
| *** AlexeyAbashkin has joined #openstack-nova | 18:47 | |
| mriedem | that's stuff you could do in neutron | 18:47 |
| mriedem | i can't remember if alex_xu proposed removing the secgroup actions as well | 18:48 |
| lbragstad | yeah - i was just double checking because as i was reading it i wasn't sure if it was suppose to be deprecated or not and was a type | 18:48 |
| lbragstad | typo* | 18:48 |
| *** catintheroof has joined #openstack-nova | 18:51 | |
| *** AlexeyAbashkin has quit IRC | 18:52 | |
| *** Aditya has quit IRC | 18:52 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Allow _set_allocations to delete allocations https://review.openstack.org/501051 | 18:54 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Limit number of attempts to delete allocations https://review.openstack.org/507224 | 18:54 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Include project_id and user_id in AllocationList.get_all_by_consumer_id https://review.openstack.org/512420 | 18:54 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Symmetric GET and PUT /allocations/{consumer_uuid} https://review.openstack.org/510626 | 18:54 |
| openstackgerrit | Chris Dent proposed openstack/nova master: [placement] POST /allocations to set allocations for >1 consumers https://review.openstack.org/500073 | 18:54 |
| cdent | jaypipes: ^ that ought to have it squashed and address the issues (I think) | 18:55 |
| jaypipes | cdent: awesomesauce. thanks man. will review shortly. | 18:56 |
| *** catintheroof has quit IRC | 18:56 | |
| openstackgerrit | Merged openstack/nova-specs master: Fix issues for post-allocations spec https://review.openstack.org/509136 | 19:01 |
| *** lpetrut has quit IRC | 19:04 | |
| *** lpetrut has joined #openstack-nova | 19:04 | |
| *** catintheroof has joined #openstack-nova | 19:05 | |
| *** slaweq has joined #openstack-nova | 19:06 | |
| *** catintheroof has quit IRC | 19:09 | |
| cdent | that’s the end of my day | 19:17 |
| * cdent waves | 19:17 | |
| *** cdent has quit IRC | 19:17 | |
| *** sree has joined #openstack-nova | 19:17 | |
| *** pchavva has quit IRC | 19:17 | |
| *** tssurya_ has joined #openstack-nova | 19:22 | |
| *** apokalypse has joined #openstack-nova | 19:22 | |
| edleafe | mriedem: so tests get messy without the ComparableVersionedObject. Is there a strong objection to keeping it in Selection? | 19:22 |
| *** eharney has quit IRC | 19:23 | |
| *** awaugama has quit IRC | 19:24 | |
| *** sree has quit IRC | 19:25 | |
| *** hemna_ has quit IRC | 19:26 | |
| efried | cfriesen Could it be because we don't want to delete allocations from a shared RP, at least in theory? | 19:27 |
| *** catintheroof has joined #openstack-nova | 19:28 | |
| *** jmlowe has quit IRC | 19:31 | |
| smatzek | I'm seeing some VM spawn issues in the Trove gate and am wondering if anyone has seen similar behavior. Trove spins up VMs in the nova-compute in devstack as part of its CI. 10-20% of the time now I'm seeing the VMs get stuck in spawn. It looks like the VM is started in libvirt and then Nova hangs out in this timer and never leaves. https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2824 | 19:32 |
| *** yamamoto has joined #openstack-nova | 19:34 | |
| *** apokalypse has left #openstack-nova | 19:35 | |
| *** READ10 has quit IRC | 19:35 | |
| *** bfife has joined #openstack-nova | 19:37 | |
| *** yamamoto has quit IRC | 19:39 | |
| *** harlowja has quit IRC | 19:46 | |
| *** ijw has quit IRC | 19:48 | |
| *** gszasz has quit IRC | 19:51 | |
| *** tssurya_ has quit IRC | 19:55 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Add _get_providers_with_any_resource method https://review.openstack.org/514197 | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Enable _get_usages_by_provider_and_rc not filter on the resource class id https://review.openstack.org/514649 | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add _get_traits_by_rp_ids method https://review.openstack.org/511184 | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add ProviderSummaryList object https://review.openstack.org/514198 | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add more caches for the ProviderSummary and ProviderSummaryList https://review.openstack.org/514199 | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add AggregatedProviderSummary and AggregatedProviderSummaryList objects https://review.openstack.org/514200 | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add has_resources method to the AggregatedProviderSummary object https://review.openstack.org/514650 | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add as_allocation_request_obj method to AggregatedProvierSummary obj https://review.openstack.org/514651 | 19:56 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: rewrite AllocationCandidates.get_by_filters https://review.openstack.org/479766 | 19:56 |
| *** ijw has joined #openstack-nova | 19:56 | |
| efried | alex_xu ^ I uncovered a bug, so I WIP'd the bottom change - see notes in commit message. | 19:56 |
| mikal | jaypipes: Mr Finucane and I have a question for you on https://review.openstack.org/#/c/515196 when you have a moment. | 19:56 |
| *** Kvisle has joined #openstack-nova | 19:57 | |
| cfriesen | efried: mriedem: thanks, just wanted to make sure it wasn't something I missed | 19:58 |
| *** tssurya_ has joined #openstack-nova | 19:58 | |
| bfife | kashyap: ping, bug#1706083. In Newton after an upgrade, I'm not seeing the proper cache value assigned to ephemeral ceph-backed storage on newly created instances. I've traced it to this commit | 19:59 |
| *** tssurya_ has quit IRC | 19:59 | |
| *** vvargaszte has quit IRC | 20:01 | |
| *** lpetrut has quit IRC | 20:02 | |
| *** liverpooler has quit IRC | 20:02 | |
| jaypipes | mikal: done | 20:04 |
| *** Apoorva has quit IRC | 20:06 | |
| *** vvargaszte has joined #openstack-nova | 20:06 | |
| mikal | jaypipes: thanks man | 20:06 |
| *** eharney has joined #openstack-nova | 20:08 | |
| *** slaweq has quit IRC | 20:09 | |
| *** slaweq has joined #openstack-nova | 20:10 | |
| mriedem | edleafe: why would the tests care? | 20:13 |
| mriedem | because of equality checks? | 20:13 |
| edleafe | yeah | 20:14 |
| *** slaweq has quit IRC | 20:14 | |
| mriedem | hmm, i think in other tests we have some types of compare_obj methods | 20:14 |
| *** hamzy has quit IRC | 20:14 | |
| mriedem | which compare the fields | 20:14 |
| edleafe | comparing the expected selection with the one that the filter_scheduler returns | 20:14 |
| mriedem | i don't have a real strong objection to leaving it though | 20:15 |
| mriedem | i just thought it was unused | 20:15 |
| edleafe | Yeah, we went through this back in PS 5-7 | 20:15 |
| mriedem | the good old PSs | 20:16 |
| edleafe | I had an explicit __eq__ method, and Jay wanted me to use the mixin instead | 20:16 |
| mriedem | i think the mixin would be better than our own __eq__ sure | 20:16 |
| mriedem | since that's what it's for | 20:16 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 20:17 |
| edleafe | ok, here it comes... | 20:17 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 20:17 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159 | 20:17 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 20:17 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 20:17 |
| mriedem | lgtm | 20:19 |
| openstackgerrit | Merged openstack/nova master: conf: Move additional nova-net opts to 'network' https://review.openstack.org/499168 | 20:20 |
| *** sree has joined #openstack-nova | 20:24 | |
| *** smatzek has quit IRC | 20:25 | |
| *** armax has quit IRC | 20:26 | |
| *** smatzek has joined #openstack-nova | 20:27 | |
| *** sree has quit IRC | 20:29 | |
| *** manjeets has joined #openstack-nova | 20:30 | |
| *** AlexeyAbashkin has joined #openstack-nova | 20:31 | |
| *** smatzek has quit IRC | 20:32 | |
| *** harlowja has joined #openstack-nova | 20:33 | |
| *** burgerk has quit IRC | 20:34 | |
| *** Apoorva has joined #openstack-nova | 20:35 | |
| *** AlexeyAbashkin has quit IRC | 20:35 | |
| *** yamamoto has joined #openstack-nova | 20:35 | |
| *** ijw has quit IRC | 20:37 | |
| *** ijw has joined #openstack-nova | 20:38 | |
| *** trozet has joined #openstack-nova | 20:40 | |
| *** yamamoto has quit IRC | 20:40 | |
| mriedem | bauzas: interested about your thoughts on this when you're up https://bugs.launchpad.net/nova/+bug/1727855 | 20:43 |
| openstack | Launchpad bug 1727855 in OpenStack Compute (nova) "conductor rebuild_instance does not properly handle image_ref if request_spec is not provided" [Low,Triaged] | 20:43 |
| *** ijw has quit IRC | 20:44 | |
| *** takashin has joined #openstack-nova | 20:47 | |
| *** AlexeyAbashkin has joined #openstack-nova | 20:47 | |
| *** andreas_s has joined #openstack-nova | 20:48 | |
| *** catintheroof has quit IRC | 20:49 | |
| *** thorst has quit IRC | 20:50 | |
| *** awaugama has joined #openstack-nova | 20:52 | |
| *** AlexeyAbashkin has quit IRC | 20:52 | |
| *** shvepsy has quit IRC | 20:53 | |
| *** shvepsy has joined #openstack-nova | 20:53 | |
| *** smatzek has joined #openstack-nova | 20:55 | |
| *** andreas_s has quit IRC | 20:58 | |
| dansmith | mriedem: jaypipes I was hoping we could avoid merging that object until we had all the patches above it settled, | 20:58 |
| dansmith | since we've changed it like a hundred times already | 20:58 |
| *** tssurya_ has joined #openstack-nova | 20:59 | |
| *** vvargaszte has quit IRC | 20:59 | |
| mriedem | oh i see | 20:59 |
| mriedem | yeah that's fair | 20:59 |
| jaypipes | dansmith: it's dependent on mriedem's https://review.openstack.org/#/c/513931 anyway. | 20:59 |
| *** andreas_s has joined #openstack-nova | 20:59 | |
| mriedem | mine is actually fixing a perf thing, but yeah | 20:59 |
| mriedem | jaypipes: maybe we convert to +1s | 21:00 |
| dansmith | jaypipes: sure but that one is easy to merge ahead of all the rest | 21:00 |
| jaypipes | dansmith: I removed the +W | 21:00 |
| mriedem | changed to +1 | 21:00 |
| dansmith | jaypipes: thanks | 21:00 |
| mriedem | maybe we need to put a -2 pin in there? | 21:00 |
| mriedem | there are other cores that aren't privy to this convo | 21:00 |
| dansmith | that's fine | 21:01 |
| *** smatzek has quit IRC | 21:01 | |
| mriedem | shit meeting itme | 21:01 |
| *** andreas_s has quit IRC | 21:10 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: Remove RP.get_traits() method https://review.openstack.org/509027 | 21:10 |
| *** amodi has quit IRC | 21:10 | |
| *** trozet has quit IRC | 21:11 | |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028 | 21:11 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: remove _HasAResourceProvider mixin https://review.openstack.org/509036 | 21:11 |
| openstackgerrit | Jay Pipes proposed openstack/nova master: rp: break functions out of _set_traits() https://review.openstack.org/509908 | 21:11 |
| melwitt | does anyone happen to know what's going bonkers in the legacy-grenade-dsvm-neutron-multinode-live-migration job failing what seems like all the time? http://logs.openstack.org/31/513931/3/check/legacy-grenade-dsvm-neutron-multinode-live-migration/a5f4740/logs/testr_results.html.gz | 21:18 |
| mriedem | melwitt: yes | 21:18 |
| mriedem | https://review.openstack.org/#/c/508271/ | 21:19 |
| *** andreas_s has joined #openstack-nova | 21:19 | |
| mriedem | it's mfing ceph | 21:19 |
| mriedem | again | 21:19 |
| mriedem | + superconductor | 21:19 |
| mriedem | i pleaded for help in last week's meeting but to no avail | 21:19 |
| mriedem | sdague is probably able to sort that one out easily | 21:19 |
| mriedem | if i say his name enough | 21:19 |
| mriedem | sdague: | 21:20 |
| melwitt | oh :( I'll try to look at it too. I didn't notice it in the meeting notes (my fault) | 21:20 |
| mriedem | we need to be able to source the local.conf | 21:20 |
| mriedem | created via grenade | 21:20 |
| mriedem | to know if we're doing superconductor or not | 21:21 |
| *** tssurya_ has quit IRC | 21:21 | |
| melwitt | oh, hrm | 21:21 |
| mriedem | this might just be easier to do: if [ -f /etc/nova/nova-cpu.conf ]; then | 21:21 |
| mriedem | hacky but it would work | 21:21 |
| mriedem | if ^ then superconductor, else singleconductor | 21:21 |
| melwitt | do we not already have some kind of logic about superconductor vs singleconductor? I mean, how is the decision made in the first place | 21:22 |
| *** armax has joined #openstack-nova | 21:22 | |
| melwitt | just "if grenade, then"? | 21:22 |
| mriedem | grenade forces singleconductor mode | 21:22 |
| mriedem | the CELLSV2_SETUP flag goes into local.conf | 21:23 |
| mriedem | which is what i'm trying to source here | 21:23 |
| mriedem | but don't have permission apparently | 21:23 |
| melwitt | okay. so things downstream of that need to be able to determine what mode it's in | 21:23 |
| mriedem | yup | 21:23 |
| mriedem | i think when this post_test_hook runs, all we have for variables is what devstack-gate gives us | 21:23 |
| mriedem | which is why $GRENADE_OLD_BRANCH works | 21:23 |
| melwitt | I wonder if we could check for the presence of the n-super-cond service? or is that not a thing hooks can do | 21:27 |
| mriedem | it's running on the dest node so i think that's possible | 21:27 |
| mriedem | can try that quick | 21:27 |
| melwitt | is_service_enabled n-super-cond | 21:27 |
| mriedem | yeah | 21:27 |
| *** vladikr has quit IRC | 21:28 | |
| mriedem | let me wrap up what i'm currently fixing | 21:28 |
| *** andreas_s has quit IRC | 21:28 | |
| mriedem | dansmith: btw, i've been thinking, | 21:28 |
| melwitt | k | 21:28 |
| mriedem | it would be really nice if we had an online_data_migration that found all of your old instances that don't have request_specs, | 21:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151 | 21:28 |
| mriedem | built a request spec for them - like we do EVERYWHERE in the api and conductor, and then we just burned all of that backward compat code out in a later release | 21:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223 | 21:29 |
| dansmith | I thought we did? | 21:29 |
| mriedem | migrate_instances_add_request_spec | 21:29 |
| mriedem | heh | 21:29 |
| mriedem | shit yup we sure do | 21:29 |
| mriedem | doesn't have the original filter properties in it, but... | 21:30 |
| *** andreas_s has joined #openstack-nova | 21:30 | |
| mriedem | ok so migrate_instances_add_request_spec was added in newton, | 21:30 |
| mriedem | does that mean that soon once newton eol, we can drop that online data migration and say, that's it | 21:30 |
| mriedem | we drop the old compat code | 21:30 |
| mriedem | i mean, if you skip this and go from mitaka to queens, it's your fault | 21:31 |
| dansmith | normally we'd have a blocker migration, but yeah I think it's prolly safe at this point | 21:31 |
| mriedem | blocker migration would be tricky, | 21:31 |
| mriedem | since reqspecs are in the api db | 21:32 |
| mriedem | i guess the blocker could be in the api db migratoin scripts, lookup the instances in the instance_mappings table and compare those to the reqspecs table? | 21:32 |
| dansmith | we've done that haven't we? regardless, prolly not worth it at this point | 21:32 |
| *** andreas_s has quit IRC | 21:34 | |
| *** yamamoto has joined #openstack-nova | 21:37 | |
| *** baoli has quit IRC | 21:42 | |
| *** yamamoto has quit IRC | 21:42 | |
| *** baoli has joined #openstack-nova | 21:43 | |
| *** baoli has quit IRC | 21:43 | |
| mriedem | we have quite a few online data migrations from newton actually | 21:46 |
| mriedem | 6 | 21:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass the correct image to build_request_spec in conductor.rebuild_instance https://review.openstack.org/515530 | 21:47 |
| *** andreas_s has joined #openstack-nova | 21:48 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass the correct image to build_request_spec in conductor.rebuild_instance https://review.openstack.org/515530 | 21:49 |
| *** tssurya_ has joined #openstack-nova | 21:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix live migration grenade ceph setup https://review.openstack.org/508271 | 21:53 |
| mriedem | melwitt: ^ | 21:53 |
| melwitt | I shall stalk it on zuul status | 21:54 |
| *** tssurya_ has quit IRC | 21:54 | |
| *** andreas_s has quit IRC | 21:58 | |
| *** gouthamr has quit IRC | 21:59 | |
| *** marst has quit IRC | 22:00 | |
| *** thorst has joined #openstack-nova | 22:00 | |
| *** andreas_s has joined #openstack-nova | 22:04 | |
| *** thorst has quit IRC | 22:06 | |
| *** esberglu has quit IRC | 22:07 | |
| *** andreas_s has quit IRC | 22:09 | |
| *** smatzek has joined #openstack-nova | 22:10 | |
| *** lyan has quit IRC | 22:15 | |
| *** andreas_s has joined #openstack-nova | 22:15 | |
| mriedem | melwitt: i have a question in the commit message here https://review.openstack.org/#/c/514339/ | 22:15 |
| mriedem | don't know what "Wrongly set the cache mode for Ceph storage backend to be 'none', while it should be set to 'writeback' to extract optimal performance." is referring to | 22:16 |
| mriedem | the libvirt volume net driver doesn't set driver_cache in conf at all | 22:16 |
| mriedem | maybe that's some rhosp special sauce ?! | 22:16 |
| melwitt | mriedem: that's not really relevant I don't think. I was hesitant to change/remove too much from a commit message I didn't write, but kashyap is away at kvm forum | 22:16 |
| melwitt | I think the thing that's wrong that's happening is libvirt driver isn't honoring the nova.conf setting for disk_cachemodes and there's nothing automatic about ceph there | 22:17 |
| *** smatzek has quit IRC | 22:18 | |
| mriedem | hmm, maybe it comes from the rbd image backend via image properties or something, idk | 22:18 |
| melwitt | just depends on how the nova.conf is deployed, I'm guessing our deployment tooling sets nova.conf that way for ceph or something | 22:18 |
| mriedem | but it's confusing in the commit message b/c there is no code in nova that defaults the cache_mode for rbd disks to writethrough | 22:18 |
| melwitt | yeah, I was torn about whether to hack up the commit message because I agree it's confusing | 22:19 |
| mriedem | ok i'd -1 | 22:19 |
| *** andreas_s has quit IRC | 22:20 | |
| *** andreas_s has joined #openstack-nova | 22:21 | |
| mriedem | i'll just mod the commit inline and +W | 22:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339 | 22:22 |
| melwitt | mriedem: okay. to your question about the disk_cachemodes, yes, the _set_cache_mode function takes the setting from the CONF.libvirt.disk_cachemodes and applies it | 22:23 |
| mriedem | yup | 22:23 |
| melwitt | k, thanks for updating the commit message | 22:23 |
| mriedem | oh wait maybe it's this _supports_direct_io method | 22:24 |
| mriedem | def disk_cachemode(self): | 22:24 |
| mriedem | which sends the cache mode into the rbd imagebackend | 22:24 |
| *** felipemonteiro_ has quit IRC | 22:24 | |
| mriedem | maybe that's what he meant | 22:24 |
| * melwitt looks | 22:24 | |
| mriedem | yeah so maybe that's what it was | 22:27 |
| melwitt | I dunno, in the ceph case the high perf value is writeback, not writethrough | 22:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339 | 22:30 |
| mriedem | done, approved | 22:31 |
| mriedem | melwitt: want to start the backport party? | 22:31 |
| mriedem | then dansmith and i can +W those | 22:32 |
| melwitt | mriedem: yep, on it | 22:32 |
| mriedem | cool, thanks | 22:32 |
| openstackgerrit | melanie witt proposed openstack/nova stable/pike: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/515538 | 22:35 |
| *** yamamoto has joined #openstack-nova | 22:39 | |
| *** jmlowe has joined #openstack-nova | 22:39 | |
| *** itlinux has quit IRC | 22:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup build_request_spec https://review.openstack.org/515539 | 22:41 |
| melwitt | mriedem: are we supposed to leave multiple cherry-pick comments in the commit message? I can't remember | 22:41 |
| mriedem | melwitt: not a big deal | 22:41 |
| melwitt | like if I cherry picked from pike to ocata. okay | 22:41 |
| mriedem | if you are then just leave them in there | 22:41 |
| melwitt | ack | 22:41 |
| tonyb | melwitt: It makes things slightly easier but really it only helps if your first cherry-pick had fixups that you don't want to do a second time. | 22:42 |
| tonyb | melwitt: my tools work with either scenario | 22:43 |
| mriedem | heh, tony's special stable tools | 22:43 |
| melwitt | okay, cool. I started doing it this way after I think dansmith pointed out maybe less likely to hit conflicts this way | 22:43 |
| tonyb | melwitt: cool | 22:43 |
| * tonyb watches for the backports | 22:43 | |
| tonyb | mriedem: FWIW I | 22:43 |
| openstackgerrit | melanie witt proposed openstack/nova stable/ocata: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/515540 | 22:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add microversion to allow setting flavor description https://review.openstack.org/515213 | 22:44 |
| *** yamamoto has quit IRC | 22:44 | |
| tonyb | 'll probably wait for your +2 and the +2W them even thought they haven't actually landed on "upper" branches | 22:44 |
| tonyb | mriedem: they're "magic tools" not special ;P | 22:44 |
| mriedem | oh sorry | 22:45 |
| mriedem | so like rabbits in hats | 22:45 |
| mriedem | coins behind ears | 22:45 |
| mriedem | shitty magic | 22:45 |
| * tonyb dies a little on the inside | 22:45 | |
| mriedem | ha, sorry tony :) | 22:45 |
| tonyb | mriedem: I'll cope | 22:46 |
| *** AlexeyAbashkin has joined #openstack-nova | 22:46 | |
| mriedem | i'm not sure what tooling you have which is scraping commit messages for (cherry picked from) messages | 22:46 |
| tonyb | mriedem: one of my magic tools: http://eavesdrop.openstack.org/irclogs/%23openstack-requirements/%23openstack-requirements.2017-10-26.log.html#t2017-10-26T07:02:00 | 22:47 |
| tonyb | mriedem: I have a git plugin call diff-backport that grabs the review and the sha for the cherrypick and compares them so can see where they diverge | 22:48 |
| *** andreas_s has quit IRC | 22:48 | |
| tonyb | mriedem: makes it quick to see conflicts that havn't been called out | 22:48 |
| *** claudiub|2 has joined #openstack-nova | 22:48 | |
| tonyb | mriedem: It also verifies that the cherry-picked commit has merged | 22:49 |
| mriedem | it's like the swiss army knife of stable review tools | 22:49 |
| *** andreas_s has joined #openstack-nova | 22:49 | |
| tonyb | mriedem: I *should* teach it to look for ^.*Bug: (\d+)$ and open that in a browser | 22:50 |
| mriedem | umm tony | 22:50 |
| tonyb | mriedem: Just automates the simple stuff so my gray matter doesn't get over taxed (which is easy to do) | 22:50 |
| mriedem | that regex will fail if the # is properly used for the bug number | 22:50 |
| *** AlexeyAbashkin has quit IRC | 22:50 | |
| mriedem | or lower-case b | 22:50 |
| mriedem | people do it | 22:50 |
| *** jaypipes has quit IRC | 22:51 | |
| tonyb | mriedem: Oh I'd use re.IGNORE_CASE | 22:51 |
| * tonyb can't parse "if the # is properly used for the bug number" | 22:52 | |
| tonyb | mriedem: wat do you mean there ...? | 22:52 |
| openstackgerrit | melanie witt proposed openstack/nova stable/newton: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/515543 | 22:53 |
| mriedem | Closes-Bug: #123456 | 22:53 |
| openstack | bug 123456 in xine-lib (Ubuntu) "podcast crashes amarok" [Undecided,Fix released] https://launchpad.net/bugs/123456 | 22:53 |
| *** salv-orl_ has quit IRC | 22:53 | |
| *** andreas_s has quit IRC | 22:54 | |
| *** salv-orlando has joined #openstack-nova | 22:54 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass RequestSpec to ConductorTaskAPI.build_instances https://review.openstack.org/515495 | 22:55 |
| tonyb | mriedem: Ahh okay | 22:55 |
| *** salv-orlando has quit IRC | 22:59 | |
| mriedem | stvnoyes: ildikov: jgriffith: looks like the cinder v3 attach patch in nova now allows you to attach the same volume to the same instance: | 23:00 |
| mriedem | http://logs.openstack.org/26/515426/1/check/legacy-tempest-dsvm-py35/0f534c8/job-output.txt.gz#_2017-10-26_16_09_57_091507 | 23:00 |
| *** andreas_s has joined #openstack-nova | 23:00 | |
| *** trozet has joined #openstack-nova | 23:04 | |
| mriedem | tonyb: dansmith: +2 on all of these now https://review.openstack.org/#/q/I7370cc2942a6c8c51ab5355b50a9e5666cca042e | 23:06 |
| *** mriedem is now known as mriedem_away | 23:07 | |
| *** AlexeyAbashkin has joined #openstack-nova | 23:07 | |
| *** AlexeyAbashkin has quit IRC | 23:11 | |
| *** andreas_s has quit IRC | 23:11 | |
| tonyb | mriedem_away, dansmith, melwitt: done | 23:13 |
| *** andreas_s has joined #openstack-nova | 23:13 | |
| *** trozet has quit IRC | 23:17 | |
| *** andreas_s has quit IRC | 23:27 | |
| *** AlexeyAbashkin has joined #openstack-nova | 23:27 | |
| *** andreas_s has joined #openstack-nova | 23:28 | |
| *** claudiub|2 has quit IRC | 23:28 | |
| *** jamesdenton has quit IRC | 23:28 | |
| *** awaugama has quit IRC | 23:29 | |
| *** thorst has joined #openstack-nova | 23:29 | |
| *** jamesdenton has joined #openstack-nova | 23:31 | |
| *** AlexeyAbashkin has quit IRC | 23:32 | |
| *** sdague has quit IRC | 23:33 | |
| melwitt | mriedem_away: live migration job passed on https://review.openstack.org/#/c/508271 \o/ | 23:33 |
| *** andreas_s has quit IRC | 23:33 | |
| *** andreas_s has joined #openstack-nova | 23:35 | |
| *** mlavalle has quit IRC | 23:35 | |
| tonyb | melwitt: when we EOL newton your 2 DNM changes will get abandoned, just so you know | 23:37 |
| melwitt | tonyb: ack, thanks | 23:37 |
| *** yassine has joined #openstack-nova | 23:38 | |
| *** yassine is now known as Guest40670 | 23:38 | |
| *** yamamoto has joined #openstack-nova | 23:40 | |
| *** thorst has quit IRC | 23:43 | |
| *** andreas_s has quit IRC | 23:44 | |
| *** yamamoto has quit IRC | 23:46 | |
| *** links has joined #openstack-nova | 23:46 | |
| *** andreas_s has joined #openstack-nova | 23:47 | |
| *** salv-orlando has joined #openstack-nova | 23:54 | |
| *** andreas_s has quit IRC | 23:57 | |
| *** Swami has quit IRC | 23:59 | |
| *** salv-orlando has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!