*** andreas_s has joined #openstack-nova | 00:00 | |
*** hongbin has quit IRC | 00:01 | |
*** READ10 has joined #openstack-nova | 00:01 | |
*** vladikr has joined #openstack-nova | 00:04 | |
*** AlexeyAbashkin has joined #openstack-nova | 00:10 | |
*** itlinux has joined #openstack-nova | 00:10 | |
*** catintheroof has joined #openstack-nova | 00:11 | |
*** burgerk has joined #openstack-nova | 00:13 | |
*** AlexeyAbashkin has quit IRC | 00:14 | |
*** rcernin has joined #openstack-nova | 00:21 | |
*** andreas_s has quit IRC | 00:26 | |
*** andreas_s has joined #openstack-nova | 00:28 | |
*** catintheroof has quit IRC | 00:32 | |
*** burgerk has quit IRC | 00:36 | |
*** catintheroof has joined #openstack-nova | 00:38 | |
*** gyee has quit IRC | 00:40 | |
*** sree has joined #openstack-nova | 00:40 | |
*** vladikr has quit IRC | 00:42 | |
*** catintheroof has quit IRC | 00:42 | |
*** andreas_s has quit IRC | 00:43 | |
*** Apoorva_ has joined #openstack-nova | 00:43 | |
*** catintheroof has joined #openstack-nova | 00:44 | |
*** andreas_s has joined #openstack-nova | 00:44 | |
*** sree has quit IRC | 00:45 | |
*** AlexeyAbashkin has joined #openstack-nova | 00:46 | |
*** Apoorva has quit IRC | 00:47 | |
*** Apoorva_ has quit IRC | 00:47 | |
*** gouthamr has joined #openstack-nova | 00:48 | |
*** andreas_s has quit IRC | 00:48 | |
*** litao__ has joined #openstack-nova | 00:49 | |
*** AlexeyAbashkin has quit IRC | 00:51 | |
*** andreas_s has joined #openstack-nova | 00:55 | |
*** catintheroof has quit IRC | 00:55 | |
*** catintheroof has joined #openstack-nova | 00:56 | |
*** zzzeek has quit IRC | 00:58 | |
*** jichen has joined #openstack-nova | 00:59 | |
*** andreas_s has quit IRC | 01:00 | |
*** zzzeek has joined #openstack-nova | 01:00 | |
*** andreas_s has joined #openstack-nova | 01:01 | |
*** phuongnh has joined #openstack-nova | 01:02 | |
*** smatzek has joined #openstack-nova | 01:02 | |
*** andreas_s has quit IRC | 01:12 | |
*** huanxie has joined #openstack-nova | 01:13 | |
*** mriedem has joined #openstack-nova | 01:15 | |
*** mriedem_away has quit IRC | 01:15 | |
mriedem | melwitt: nice re https://review.openstack.org/#/c/508271 - maybe you want to +2 :) | 01:16 |
---|---|---|
*** thorst has joined #openstack-nova | 01:16 | |
melwitt | mriedem: yep, wanted to get the a-ok from you first in case there was anything else | 01:16 |
*** thorst has quit IRC | 01:17 | |
*** andreas_s has joined #openstack-nova | 01:18 | |
*** amodi has joined #openstack-nova | 01:20 | |
*** catintheroof has quit IRC | 01:20 | |
*** namnh has joined #openstack-nova | 01:21 | |
*** catintheroof has joined #openstack-nova | 01:21 | |
*** Kevin_Zheng has joined #openstack-nova | 01:22 | |
*** catintheroof has quit IRC | 01:24 | |
*** gmann_afk is now known as gmann | 01:25 | |
*** dave-mccowan has quit IRC | 01:26 | |
*** dave-mccowan has joined #openstack-nova | 01:27 | |
*** andreas_s has quit IRC | 01:28 | |
*** vladikr has joined #openstack-nova | 01:32 | |
*** psachin has joined #openstack-nova | 01:36 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle network-changed event for a specific port https://review.openstack.org/465787 | 01:37 |
mriedem | cfriesen: finally got back to updating that ^ still needs unit tests, but i'm seeing the code hitting in the live migration job now that the live migration tests in tempest are building a tenant network | 01:37 |
*** andreas_s has joined #openstack-nova | 01:37 | |
*** rcernin has quit IRC | 01:43 | |
*** yamamoto has joined #openstack-nova | 01:43 | |
*** rcernin has joined #openstack-nova | 01:44 | |
*** READ10 has quit IRC | 01:47 | |
*** andreas_s has quit IRC | 01:47 | |
*** yamamoto has quit IRC | 01:49 | |
*** smatzek has quit IRC | 01:50 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: remove extraneous retry assignment in cleanup method https://review.openstack.org/409199 | 01:54 |
*** catintheroof has joined #openstack-nova | 01:55 | |
*** salv-orlando has joined #openstack-nova | 01:55 | |
*** andreas_s has joined #openstack-nova | 01:56 | |
*** salv-orlando has quit IRC | 02:00 | |
*** catintheroof has quit IRC | 02:00 | |
*** Tom__ has quit IRC | 02:00 | |
*** tbachman has quit IRC | 02:01 | |
*** andreas_s has quit IRC | 02:02 | |
Kevin_Zheng | https://review.openstack.org/#/c/507769/ | 02:02 |
Kevin_Zheng | mriedem ^ what should I do about this? Should I add it in master | 02:03 |
Kevin_Zheng | or stable/pike? | 02:03 |
Kevin_Zheng | oh, just saw Tony's comment | 02:04 |
*** hongbin has joined #openstack-nova | 02:05 | |
mriedem | hmm, well, master will be kind of weird if we fix the bug in 17.0.0 | 02:06 |
mriedem | we'd have to remove the release note from master if it gets fixed there | 02:06 |
Kevin_Zheng | so add a new one just in stable/pike? | 02:07 |
mriedem | i think do it in master, and then if we get it fixed in master we'll remove the reno in the same patch | 02:07 |
mriedem | i think reno can deal with deleted release notes | 02:08 |
Kevin_Zheng | OK | 02:08 |
*** Tom__ has joined #openstack-nova | 02:08 | |
*** Tom__ has quit IRC | 02:09 | |
*** Tom__ has joined #openstack-nova | 02:09 | |
*** Tom__ has quit IRC | 02:09 | |
*** gcb has joined #openstack-nova | 02:16 | |
*** thorst has joined #openstack-nova | 02:18 | |
*** huanxie has quit IRC | 02:22 | |
*** andreas_s has joined #openstack-nova | 02:22 | |
*** thorst has quit IRC | 02:23 | |
*** annp has joined #openstack-nova | 02:23 | |
mriedem | Kevin_Zheng: http://lists.openstack.org/pipermail/openstack-operators/2017-October/014459.html | 02:24 |
Kevin_Zheng | Thanks alot | 02:25 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: [WIP]Implement query param schema for flavor index https://review.openstack.org/515413 | 02:25 |
*** andreas_s has quit IRC | 02:26 | |
*** catintheroof has joined #openstack-nova | 02:28 | |
*** yamahata has quit IRC | 02:29 | |
*** andreas_s has joined #openstack-nova | 02:33 | |
*** catintheroof has quit IRC | 02:33 | |
*** fragatina has quit IRC | 02:40 | |
*** andreas_s has quit IRC | 02:44 | |
*** Tom__ has joined #openstack-nova | 02:45 | |
*** yamamoto has joined #openstack-nova | 02:45 | |
*** fragatina has joined #openstack-nova | 02:45 | |
*** AlexeyAbashkin has joined #openstack-nova | 02:47 | |
*** trozet has joined #openstack-nova | 02:47 | |
*** fragatina has quit IRC | 02:50 | |
*** yamamoto has quit IRC | 02:51 | |
*** AlexeyAbashkin has quit IRC | 02:52 | |
*** amodi has quit IRC | 02:53 | |
*** andreas_s has joined #openstack-nova | 02:57 | |
openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: properly decode error message from qemu guest agent https://review.openstack.org/511459 | 03:05 |
*** andreas_s has quit IRC | 03:07 | |
*** AlexeyAbashkin has joined #openstack-nova | 03:08 | |
*** trozet has quit IRC | 03:11 | |
*** andreas_s has joined #openstack-nova | 03:12 | |
*** AlexeyAbashkin has quit IRC | 03:12 | |
*** yikun has quit IRC | 03:12 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035 | 03:13 |
*** dave-mccowan has quit IRC | 03:14 | |
*** yamamoto has joined #openstack-nova | 03:16 | |
*** andreas_s has quit IRC | 03:18 | |
*** andreas_s has joined #openstack-nova | 03:19 | |
*** huanxie has joined #openstack-nova | 03:19 | |
*** andreas_s has quit IRC | 03:24 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 03:28 |
openstackgerrit | Yikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 03:29 |
*** nicolasbock has quit IRC | 03:30 | |
*** andreas_s has joined #openstack-nova | 03:34 | |
*** hongbin has quit IRC | 03:35 | |
*** yamamoto has quit IRC | 03:36 | |
*** andreas_s has quit IRC | 03:38 | |
*** yamahata has joined #openstack-nova | 03:39 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix instance lookup in hide_server_addresses extension https://review.openstack.org/467772 | 03:42 |
*** markvoelker has quit IRC | 03:43 | |
*** andreas_s has joined #openstack-nova | 03:47 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle network-changed event for a specific port https://review.openstack.org/465787 | 03:48 |
*** tyrefors has quit IRC | 03:50 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Remove incorrect comment about instance.locked https://review.openstack.org/515306 | 03:51 |
*** andreas_s has quit IRC | 03:52 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Avoid unnecessary lazy-loads in mutated_migration_context https://review.openstack.org/515581 | 03:53 |
*** gongysh has joined #openstack-nova | 03:53 | |
*** yamamoto has joined #openstack-nova | 03:54 | |
*** yamamoto has quit IRC | 03:54 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: see what else is doing useless migration context stuff https://review.openstack.org/471491 | 03:55 |
*** yamamoto has joined #openstack-nova | 03:55 | |
*** salv-orlando has joined #openstack-nova | 03:56 | |
*** fragatina has joined #openstack-nova | 03:57 | |
*** fragatina has quit IRC | 03:58 | |
*** udesale has joined #openstack-nova | 03:58 | |
*** fragatina has joined #openstack-nova | 03:58 | |
*** salv-orlando has quit IRC | 04:00 | |
*** huanxie has quit IRC | 04:01 | |
*** catintheroof has joined #openstack-nova | 04:01 | |
*** psachin has quit IRC | 04:03 | |
*** catintheroof has quit IRC | 04:05 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle InstanceNotFound when setting password via metadata https://review.openstack.org/472933 | 04:06 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Implement query param schema for flavor index https://review.openstack.org/515413 | 04:08 |
*** mdnadeem has joined #openstack-nova | 04:08 | |
*** yangyape_ has joined #openstack-nova | 04:09 | |
*** yangyapeng has quit IRC | 04:11 | |
*** vks1 has joined #openstack-nova | 04:14 | |
*** mriedem has quit IRC | 04:15 | |
*** bhagyashri_s has joined #openstack-nova | 04:15 | |
*** pooja-jadhav has joined #openstack-nova | 04:15 | |
*** fragatina has quit IRC | 04:16 | |
*** Apoorva has joined #openstack-nova | 04:16 | |
*** pooja_jadhav has quit IRC | 04:17 | |
*** bhagyashris has quit IRC | 04:17 | |
*** thorst has joined #openstack-nova | 04:19 | |
*** annp has quit IRC | 04:20 | |
*** claudiub|2 has joined #openstack-nova | 04:20 | |
*** psachin has joined #openstack-nova | 04:21 | |
*** thorst has quit IRC | 04:24 | |
*** bhagyashri_s is now known as bhagyashris | 04:24 | |
*** rmcallis has quit IRC | 04:27 | |
*** annp has joined #openstack-nova | 04:28 | |
*** janki has joined #openstack-nova | 04:36 | |
*** sree has joined #openstack-nova | 04:37 | |
*** logan- has quit IRC | 04:38 | |
*** logan- has joined #openstack-nova | 04:42 | |
*** gongysh has quit IRC | 04:42 | |
*** bhagyashris has quit IRC | 04:46 | |
*** Apoorva has quit IRC | 04:46 | |
*** rmk has quit IRC | 04:50 | |
*** cburgess has quit IRC | 04:51 | |
*** rmcallis has joined #openstack-nova | 04:53 | |
*** yikun_jiang has quit IRC | 04:54 | |
*** yikun_jiang has joined #openstack-nova | 04:54 | |
*** Tom__ has quit IRC | 04:55 | |
*** Tom__ has joined #openstack-nova | 04:56 | |
*** rmcallis has quit IRC | 04:58 | |
*** gabor_antal_km has quit IRC | 04:59 | |
*** rmcallis has joined #openstack-nova | 04:59 | |
*** Tom__ has quit IRC | 05:00 | |
*** cburgess has joined #openstack-nova | 05:03 | |
*** vvargaszte has joined #openstack-nova | 05:03 | |
*** rmk has joined #openstack-nova | 05:05 | |
*** rmk has quit IRC | 05:05 | |
*** rmk has joined #openstack-nova | 05:05 | |
*** jaosorior has joined #openstack-nova | 05:05 | |
*** huanxie has joined #openstack-nova | 05:08 | |
*** tbachman has joined #openstack-nova | 05:08 | |
*** slaweq has joined #openstack-nova | 05:11 | |
*** vvargaszte has quit IRC | 05:14 | |
*** psachin has quit IRC | 05:14 | |
*** masuberu has joined #openstack-nova | 05:15 | |
*** psachin has joined #openstack-nova | 05:16 | |
*** slaweq has quit IRC | 05:16 | |
*** lpetrut has joined #openstack-nova | 05:16 | |
*** masber has quit IRC | 05:18 | |
*** masber has joined #openstack-nova | 05:20 | |
*** yamamoto has quit IRC | 05:21 | |
*** masuberu has quit IRC | 05:23 | |
*** salv-orlando has joined #openstack-nova | 05:25 | |
*** gongysh has joined #openstack-nova | 05:25 | |
*** tbachman has quit IRC | 05:26 | |
*** trinaths has joined #openstack-nova | 05:34 | |
*** trinaths has left #openstack-nova | 05:36 | |
*** salv-orlando has quit IRC | 05:38 | |
*** takashin has left #openstack-nova | 05:38 | |
*** salv-orlando has joined #openstack-nova | 05:38 | |
*** avolkov has joined #openstack-nova | 05:40 | |
*** markvoelker has joined #openstack-nova | 05:43 | |
*** BenderRodriguez has quit IRC | 05:47 | |
*** ratailor has joined #openstack-nova | 06:03 | |
*** lpetrut has quit IRC | 06:17 | |
*** markvoelker has quit IRC | 06:18 | |
*** thorst has joined #openstack-nova | 06:20 | |
*** gouthamr has quit IRC | 06:21 | |
*** spectr has joined #openstack-nova | 06:22 | |
*** andreas_s has joined #openstack-nova | 06:24 | |
*** ratailor has quit IRC | 06:24 | |
*** thorst has quit IRC | 06:25 | |
*** bhagyashris has joined #openstack-nova | 06:26 | |
*** lpetrut has joined #openstack-nova | 06:27 | |
*** lpetrut has quit IRC | 06:33 | |
*** lpetrut has joined #openstack-nova | 06:34 | |
*** sahid has joined #openstack-nova | 06:34 | |
*** Tom___ has joined #openstack-nova | 06:34 | |
*** gongysh has quit IRC | 06:36 | |
*** ratailor has joined #openstack-nova | 06:37 | |
*** Tom___ has quit IRC | 06:40 | |
*** Tom___ has joined #openstack-nova | 06:40 | |
*** Tom___ has quit IRC | 06:41 | |
*** Tom___ has joined #openstack-nova | 06:41 | |
*** tssurya_ has joined #openstack-nova | 06:43 | |
*** tssurya_ has quit IRC | 06:43 | |
*** lpetrut has quit IRC | 06:44 | |
*** lajoskatona has joined #openstack-nova | 06:44 | |
*** ratailor has quit IRC | 06:56 | |
*** ratailor has joined #openstack-nova | 06:56 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations. https://review.openstack.org/330406 | 07:06 |
*** slaweq has joined #openstack-nova | 07:12 | |
*** vvargaszte has joined #openstack-nova | 07:13 | |
*** vvargaszte has quit IRC | 07:14 | |
*** markvoelker has joined #openstack-nova | 07:14 | |
*** slaweq has quit IRC | 07:16 | |
*** armax has quit IRC | 07:21 | |
*** tesseract has joined #openstack-nova | 07:22 | |
*** armax has joined #openstack-nova | 07:22 | |
*** armax has quit IRC | 07:22 | |
*** armax has joined #openstack-nova | 07:23 | |
*** armax has quit IRC | 07:23 | |
*** armax has joined #openstack-nova | 07:24 | |
*** armax has quit IRC | 07:24 | |
*** armax has joined #openstack-nova | 07:24 | |
*** armax has quit IRC | 07:25 | |
*** armax has joined #openstack-nova | 07:25 | |
*** armax has quit IRC | 07:25 | |
*** armax has joined #openstack-nova | 07:26 | |
*** armax has quit IRC | 07:26 | |
*** slaweq has joined #openstack-nova | 07:26 | |
*** armax has joined #openstack-nova | 07:27 | |
*** armax has quit IRC | 07:27 | |
*** salv-orlando has quit IRC | 07:30 | |
*** salv-orlando has joined #openstack-nova | 07:31 | |
*** tssurya has quit IRC | 07:31 | |
*** tssurya has joined #openstack-nova | 07:32 | |
*** thorst has joined #openstack-nova | 07:33 | |
*** namnh has quit IRC | 07:34 | |
*** salv-orlando has quit IRC | 07:35 | |
*** yikun has joined #openstack-nova | 07:36 | |
*** yikun_jiang has quit IRC | 07:37 | |
*** rmart04 has joined #openstack-nova | 07:38 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Mention API behavior change when over quota limit https://review.openstack.org/515631 | 07:38 |
*** thorst has quit IRC | 07:38 | |
*** josecastroleon has joined #openstack-nova | 07:41 | |
*** ratailor has quit IRC | 07:41 | |
*** itlinux has quit IRC | 07:43 | |
*** markvoelker has quit IRC | 07:48 | |
*** trungnv has quit IRC | 07:49 | |
*** jpena|off is now known as jpena | 07:49 | |
*** ralonsoh has joined #openstack-nova | 07:50 | |
*** salv-orlando has joined #openstack-nova | 07:52 | |
*** ratailor has joined #openstack-nova | 07:54 | |
kashyap | Hi melwitt: Thanks for sheperding this through -- https://review.openstack.org/#/c/514339/ | 07:55 |
melwitt | kashyap: np, it was ... a learning experience | 07:56 |
*** AlexeyAbashkin has joined #openstack-nova | 07:56 | |
melwitt | (it took me a long time to figure out how to test it) :P | 07:56 |
kashyap | melwitt: :-) Are the confusing bits from the commit message replaced? | 07:56 |
kashyap | melwitt: From the bug report, seems like you've tested it directly from `virsh` :-) | 07:57 |
melwitt | kashyap: yeah, mriedem updated the commit message to take out the part about ceph + writeback because I don't think that's related to the bug. that is, I don't think there's anything in nova that makes ceph automatically configure itself for writeback | 07:57 |
*** rcernin has quit IRC | 07:58 | |
kashyap | melwitt: Yep, just noticed. Thank you | 07:58 |
kashyap | Also feel free to edit away the commit message even if you didn't write if it's wrong / confusing :-) | 07:58 |
melwitt | kashyap: no, I was able to reproduce it in unit tests. the virsh stuff is from the downstream bug report, I thought it would more clearly illustrate what the problem was | 07:58 |
kashyap | Ah, right | 07:58 |
melwitt | in case ppl don't know what "cache mode" means, just to show it's part of the domain xml stuff | 07:59 |
melwitt | k, noted for the future :) | 07:59 |
kashyap | Yeah, true | 07:59 |
kashyap | melwitt: Also about the different cache modes, this is a nice page that explains what it means: https://rwmj.wordpress.com/2013/09/02/new-in-libguestfs-allow-cache-mode-to-be-selected/ | 08:00 |
*** gcb has quit IRC | 08:00 | |
melwitt | ah, nice. thanks | 08:00 |
bauzas | melwitt: GO TO BED! | 08:00 |
kashyap | But MattR also copied some verbiage from somewhere in Nova conf as well. | 08:00 |
kashyap | melwitt: Yeah, I was wondering. Wauw, isn't it 01:00 AM for you there?! | 08:01 |
kashyap | Surprised to hear you answer to my ping here actually. | 08:01 |
melwitt | bauzas: I will, soon :) was stubbornly working on solving something | 08:01 |
bauzas | melwitt: Ted Mosby said a couple of times that nothing good can happen after 2am, so you only have 1 hour left | 08:01 |
melwitt | lol | 08:02 |
*** gcb has joined #openstack-nova | 08:03 | |
*** slaweq has quit IRC | 08:04 | |
*** slaweq has joined #openstack-nova | 08:05 | |
melwitt | kashyap: oh, in case you didn't know, the reason we were moving so fast on that change is because newton eol was being held back on it | 08:05 |
kashyap | melwitt: Ah, I recall dansmith saying during a call last week | 08:05 |
kashyap | melwitt: Thank you for the unit test fixes. I struggle a bit with it | 08:06 |
melwitt | np. writing the tests is the most challenging part for me most of the time | 08:06 |
kashyap | melwitt: Any tips you have (write later, when you rested) to get better at it are welcome :-) | 08:07 |
melwitt | heh, k | 08:07 |
kashyap | Maybe just: keep reading and tinkering more and write more of them :-) | 08:07 |
melwitt | yeah, that's most of it. gets better with practice | 08:08 |
*** trungnv has joined #openstack-nova | 08:09 | |
melwitt | alright yall, seeya in some hours | 08:11 |
*** yamahata has quit IRC | 08:14 | |
kashyap | Get some sleep. | 08:14 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface https://review.openstack.org/512190 | 08:14 |
openstackgerrit | Yikun Jiang proposed openstack/python-novaclient master: Use utils.prepare_query_string instead of duplicated code https://review.openstack.org/515640 | 08:19 |
openstackgerrit | Merged openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks https://review.openstack.org/514339 | 08:21 |
*** lucas-afk is now known as lucasagomes | 08:26 | |
*** mhickey has joined #openstack-nova | 08:31 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: vgpu: add enabled white list https://review.openstack.org/512580 | 08:33 |
openstackgerrit | Jianghua Wang proposed openstack/nova master: vGPU: XenAPI: get vgpu stats from hypervisor https://review.openstack.org/512965 | 08:33 |
*** udesale has quit IRC | 08:35 | |
*** Laurene has joined #openstack-nova | 08:37 | |
*** gszasz has joined #openstack-nova | 08:38 | |
*** Tom___ has quit IRC | 08:43 | |
*** rmcallis has quit IRC | 08:44 | |
*** huanxie has quit IRC | 08:44 | |
*** markvoelker has joined #openstack-nova | 08:45 | |
*** derekh has joined #openstack-nova | 08:45 | |
*** rmcallis has joined #openstack-nova | 08:46 | |
*** namnh has joined #openstack-nova | 08:51 | |
*** udesale has joined #openstack-nova | 08:53 | |
*** rmcallis has quit IRC | 08:53 | |
*** sdague has joined #openstack-nova | 08:54 | |
*** Tom__ has joined #openstack-nova | 08:54 | |
*** jichen has quit IRC | 08:55 | |
*** Tom__ has quit IRC | 08:57 | |
*** Tom__ has joined #openstack-nova | 08:57 | |
*** lpetrut has joined #openstack-nova | 09:09 | |
openstackgerrit | Chen Hanxiao proposed openstack/python-novaclient master: inject file: add description of injecting multiple files. https://review.openstack.org/515655 | 09:10 |
*** slaweq has quit IRC | 09:16 | |
*** slaweq has joined #openstack-nova | 09:17 | |
*** markvoelker has quit IRC | 09:18 | |
*** slaweq has quit IRC | 09:22 | |
*** slaweq has joined #openstack-nova | 09:22 | |
*** Tom__ has quit IRC | 09:24 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove 'vendordata_driver' opt https://review.openstack.org/397835 | 09:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Validate '[api] vendordata_providers' options https://review.openstack.org/513318 | 09:28 |
*** Tom__ has joined #openstack-nova | 09:28 | |
*** Tom__ has quit IRC | 09:28 | |
*** Tom__ has joined #openstack-nova | 09:29 | |
stephenfin | mikal: Could you have a look at https://review.openstack.org/#/c/513318 and the preceding patch? | 09:29 |
*** huanxie has joined #openstack-nova | 09:29 | |
*** Tom__ has quit IRC | 09:33 | |
*** thorst has joined #openstack-nova | 09:34 | |
*** Lirt has joined #openstack-nova | 09:35 | |
*** gcb has quit IRC | 09:37 | |
*** rmart04 has quit IRC | 09:37 | |
*** thorst has quit IRC | 09:39 | |
*** links has quit IRC | 09:42 | |
*** Laurene has quit IRC | 09:42 | |
*** avolkov has quit IRC | 09:43 | |
*** avolkov has joined #openstack-nova | 09:44 | |
*** ratailor is now known as rtailor | 09:45 | |
*** fragatina has joined #openstack-nova | 09:48 | |
*** maciejjozefczyk has joined #openstack-nova | 09:52 | |
*** slaweq_ has joined #openstack-nova | 09:52 | |
*** dpawlik has joined #openstack-nova | 09:52 | |
*** cdent has joined #openstack-nova | 09:53 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: fix memory stats https://review.openstack.org/515666 | 09:54 |
*** slaweq has quit IRC | 09:54 | |
*** danpawlik has quit IRC | 09:55 | |
*** maciejjo1 has quit IRC | 09:55 | |
openstackgerrit | Yikun Jiang proposed openstack/python-novaclient master: Use utils.prepare_query_string instead of duplicated code https://review.openstack.org/515640 | 10:02 |
*** gmann is now known as gmann_afk | 10:02 | |
*** kaisers1 has quit IRC | 10:05 | |
*** psachin has quit IRC | 10:05 | |
openstackgerrit | Merged openstack/nova master: Complete dostring of live_migration related methods https://review.openstack.org/490807 | 10:07 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: implement get_inventory() driver method https://review.openstack.org/506175 | 10:13 |
*** kaisers has joined #openstack-nova | 10:14 | |
*** markvoelker has joined #openstack-nova | 10:15 | |
*** mhickey has quit IRC | 10:17 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: resolve the error of VM_MISSING_PV_DRIVERS for PV VM https://review.openstack.org/514902 | 10:19 |
*** yamamoto has joined #openstack-nova | 10:24 | |
*** phuongnh has quit IRC | 10:24 | |
*** andreas_s has quit IRC | 10:26 | |
*** andreas_s has joined #openstack-nova | 10:27 | |
*** namnh has quit IRC | 10:36 | |
*** andreas_s has quit IRC | 10:37 | |
*** andreas_s has joined #openstack-nova | 10:39 | |
*** sridharg has joined #openstack-nova | 10:40 | |
jianghuaw | bauzas, could you help to look at this patch? https://review.openstack.org/#/c/339204 | 10:43 |
*** yamamoto has quit IRC | 10:45 | |
*** markvoelker has quit IRC | 10:49 | |
*** rtailor has quit IRC | 10:49 | |
*** rmcallis has joined #openstack-nova | 10:49 | |
*** andreas_s has quit IRC | 10:50 | |
*** rmcallis has quit IRC | 10:54 | |
*** andreas_s has joined #openstack-nova | 10:55 | |
*** trungnv has quit IRC | 10:57 | |
*** andreas_s has quit IRC | 11:01 | |
*** rtailor has joined #openstack-nova | 11:02 | |
*** andreas_s has joined #openstack-nova | 11:02 | |
*** robcresswell has quit IRC | 11:03 | |
*** annp has quit IRC | 11:03 | |
*** yamamoto has joined #openstack-nova | 11:05 | |
*** lucasagomes is now known as lucas-hungry | 11:07 | |
*** andreas_s has quit IRC | 11:12 | |
*** andreas_s has joined #openstack-nova | 11:13 | |
*** rtailor has quit IRC | 11:15 | |
*** smatzek has joined #openstack-nova | 11:15 | |
*** andreas_s has quit IRC | 11:15 | |
*** andreas_s has joined #openstack-nova | 11:16 | |
*** vladikr has quit IRC | 11:17 | |
*** yamamoto has quit IRC | 11:21 | |
openstackgerrit | Merged openstack/python-novaclient master: Use generic user for both zuul v2 and v3 https://review.openstack.org/512515 | 11:30 |
*** hamzy has joined #openstack-nova | 11:30 | |
*** sdague has quit IRC | 11:31 | |
*** sdague has joined #openstack-nova | 11:32 | |
*** rtailor has joined #openstack-nova | 11:34 | |
*** baoli has joined #openstack-nova | 11:34 | |
*** trinaths has joined #openstack-nova | 11:35 | |
*** thorst has joined #openstack-nova | 11:35 | |
*** litao__ has quit IRC | 11:36 | |
*** sdague has quit IRC | 11:37 | |
*** rtailor has quit IRC | 11:37 | |
*** baoli has quit IRC | 11:37 | |
*** ratailor has joined #openstack-nova | 11:37 | |
*** sdague has joined #openstack-nova | 11:38 | |
*** trinaths has left #openstack-nova | 11:38 | |
*** sdague has quit IRC | 11:38 | |
*** baoli has joined #openstack-nova | 11:38 | |
*** thorst has quit IRC | 11:40 | |
*** sambetts|afk is now known as sambetts | 11:41 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: implement get_inventory() driver method https://review.openstack.org/506175 | 11:42 |
*** nicolasbock has joined #openstack-nova | 11:43 | |
*** belmoreira has joined #openstack-nova | 11:45 | |
*** thorst has joined #openstack-nova | 11:46 | |
*** sdague has joined #openstack-nova | 11:46 | |
*** markvoelker has joined #openstack-nova | 11:46 | |
*** yamamoto has joined #openstack-nova | 11:50 | |
*** jpena is now known as jpena|lunch | 11:58 | |
*** dtantsur|afk is now known as dtantsur | 11:58 | |
*** ratailor has quit IRC | 11:58 | |
*** jmccarthy has joined #openstack-nova | 11:58 | |
*** ratailor has joined #openstack-nova | 11:58 | |
*** yamamoto has quit IRC | 11:59 | |
*** huanxie has quit IRC | 12:01 | |
jmccarthy | Any folks notice an issue where on a xen compute, in horizon, you may get a working console, or working console logging (depending on the instance you spin up) - but not both ? | 12:01 |
*** dillaman has joined #openstack-nova | 12:03 | |
*** liverpooler has joined #openstack-nova | 12:05 | |
*** pooja_jadhav has joined #openstack-nova | 12:07 | |
*** bhagyashri_s has joined #openstack-nova | 12:07 | |
*** abhishek_k has joined #openstack-nova | 12:08 | |
*** nsingh has joined #openstack-nova | 12:08 | |
*** abhishekk has quit IRC | 12:09 | |
*** niraj_singh has quit IRC | 12:09 | |
*** bhagyashris has quit IRC | 12:10 | |
*** pooja-jadhav has quit IRC | 12:10 | |
*** vks1 has quit IRC | 12:11 | |
*** jaypipes has joined #openstack-nova | 12:12 | |
*** yamamoto has joined #openstack-nova | 12:14 | |
*** lucas-hungry is now known as lucasagomes | 12:14 | |
*** ratailor has quit IRC | 12:17 | |
*** markvoelker has quit IRC | 12:20 | |
jaypipes | bauzas, stephenfin, gibi: series starting at https://review.openstack.org/#/c/509027/ should be relatively easy reviews. just cleanups in the resource_provider.py module. | 12:25 |
*** markvoelker has joined #openstack-nova | 12:27 | |
gibi | jaypipes: opening... | 12:28 |
*** StevenK has quit IRC | 12:29 | |
*** rm_work has quit IRC | 12:29 | |
*** rm_work has joined #openstack-nova | 12:30 | |
*** rm_work has joined #openstack-nova | 12:30 | |
*** baoli has quit IRC | 12:32 | |
*** baoli has joined #openstack-nova | 12:37 | |
*** StevenK has joined #openstack-nova | 12:41 | |
*** jpena|lunch is now known as jpena | 12:50 | |
*** pchavva has joined #openstack-nova | 12:50 | |
*** lyan has joined #openstack-nova | 12:57 | |
*** mdbooth has quit IRC | 12:58 | |
gibi | jaypipes: what is the reason you pass a whole RP object to get_all_by_resource_provider ? It only uses the id of that RP today so it would be enough to pass that id. | 12:58 |
jaypipes | gibi: because I don't then have to reconstruct a ResourceProvider object for each allocation record. | 12:58 |
*** ansiwen has quit IRC | 12:58 | |
jaypipes | gibi: and that would entail more joins and/or queries to the DB | 12:59 |
*** marst has joined #openstack-nova | 13:01 | |
bauzas | jianghuaw: jaypipes: I had a comment in https://review.openstack.org/#/c/339204/8 | 13:01 |
*** edleafe is now known as figleaf | 13:02 | |
*** jaypipes is now known as leakypipes | 13:02 | |
*** vvargaszte has joined #openstack-nova | 13:02 | |
leakypipes | bauzas: nice catch :) | 13:03 |
bauzas | oh man, friday | 13:04 |
*** bauzas is now known as bauwser | 13:04 | |
*** catintheroof has joined #openstack-nova | 13:04 | |
gibi | leakypipes: I'm not sure we are looking at the same patch. I try to understand TraitList.get_all_by_resource_provider() here https://review.openstack.org/#/c/509027/5/nova/objects/resource_provider.py@2289 | 13:04 |
gibi | leakypipes: and I don't see how this connects to the allocation records you refer to | 13:05 |
leakypipes | gibi: lol. sorry, thought you were referring to the AllocationList.get_all_by_provider() | 13:05 |
bauwser | leakypipes: honestly, it's a known problem, and we should maybe discuss about how to modify the RC to use bytes and not GB but meh | 13:05 |
bauwser | changing that should be a very huge modification unfortunately | 13:05 |
leakypipes | gibi: I have no idea why that isn't get_by_provider_id()... | 13:06 |
leakypipes | gibi: lemme fix. | 13:06 |
openstackgerrit | Hironori Shiina proposed openstack/nova-specs master: Ironic: Resize and cold migration support https://review.openstack.org/449155 | 13:06 |
leakypipes | gibi: might just be copy-pasta | 13:06 |
gibi | leakypipes: thanks | 13:07 |
leakypipes | gibi: sorry about that! | 13:07 |
*** naichuans has quit IRC | 13:07 | |
gibi | leakypipes: no problem | 13:08 |
leakypipes | gibi: although... | 13:08 |
leakypipes | gibi: based on the commit message | 13:08 |
*** udesale has quit IRC | 13:08 | |
leakypipes | gibi: looks like this was intentional to make the calling interfaces consistent | 13:09 |
leakypipes | gibi: from the commit message: | 13:09 |
leakypipes | In following patches, I change similar method on List objects like UsageList.get_all_by_resource_provider_uuid() and AllocationList.get_all_by_resource_provider_uuid() to match this new pattern of get_all_by_resource_provider() and passing in a ResourceProvider object. | 13:09 |
*** baoli has quit IRC | 13:09 | |
leakypipes | gibi: those "following patches" were re-ordered and are actually already merged. | 13:09 |
gibi | leakypipes: that removes some of my confusion :) anyhow if there is pattern and it is intentional then I'm OK with it | 13:10 |
leakypipes | gibi: so, long story short, I did it for consistency with the other calls | 13:10 |
gibi | leakypipes: make sense now, thanks for the explanation | 13:11 |
*** efried is now known as fried_rice | 13:14 | |
*** andreas_s has quit IRC | 13:15 | |
*** gibi is now known as pow_2_30 | 13:17 | |
*** mriedem has joined #openstack-nova | 13:18 | |
* pow_2_30 joining to the Friday naming trends | 13:19 | |
*** andreas_s has joined #openstack-nova | 13:19 | |
*** mdbooth has joined #openstack-nova | 13:21 | |
*** ansiwen has joined #openstack-nova | 13:21 | |
*** vks1 has joined #openstack-nova | 13:22 | |
*** andreas_s has quit IRC | 13:25 | |
*** andreas_s has joined #openstack-nova | 13:25 | |
*** hemna_ has joined #openstack-nova | 13:25 | |
belmoreira | mriedem, dansmith I continue to test how to migrate from newton to ocata with cellsV1 | 13:25 |
belmoreira | If I have multiple nova_api(s) DBs/placements I will need to merge the allocation tables when moving to pike and cellsV2 | 13:26 |
belmoreira | This is not easy to achieve because "allocations" table uses the "resource_provider_id" instead "resource_provider_uuid" | 13:26 |
jmccarthy | Question about using libvirt + xen on xen compute, anyone familiar with how to get changes to 'stick' when virsh editing the xml ? I'm trying to add another serial device to file, for console logging for example: http://paste.openstack.org/show/624831/ | 13:26 |
belmoreira | There is any way to recreate the "allocations" table from scratch when I'm in pike? | 13:26 |
jmccarthy | (I have what is on the right, but I think I need what is on the left) | 13:26 |
mriedem | belmoreira: would likely have to write a tool to migrate the entries out of the separate placement/api db's into the global one when you upgrade | 13:27 |
mriedem | we mentioned this as one of the trade offs the other day of doing placement per cell for now | 13:27 |
*** artom has quit IRC | 13:28 | |
*** claudiub has joined #openstack-nova | 13:28 | |
dansmith | what mriedem said | 13:28 |
*** artom has joined #openstack-nova | 13:28 | |
dansmith | belmoreira: the use of integer ids is for performance there | 13:28 |
*** hieulq has quit IRC | 13:29 | |
*** tbachman has joined #openstack-nova | 13:29 | |
mriedem | bauwser: what is your -1 for specifically on this? https://review.openstack.org/#/c/515530/ | 13:30 |
*** dansmith is now known as superdan | 13:30 | |
*** claudiub|2 has quit IRC | 13:31 | |
bauwser | mriedem: on a meeting | 13:31 |
*** sheel has joined #openstack-nova | 13:32 | |
*** mhickey has joined #openstack-nova | 13:33 | |
*** catintheroof has quit IRC | 13:34 | |
fried_rice | mriedem superdan Can we please move the ksa adapter series along a little bit? It's been stagnating. Here's one that involves placement https://review.openstack.org/#/c/492247/ -- sdague was +2 6 weeks ago and no actual changes since. | 13:34 |
*** janki has quit IRC | 13:37 | |
sdague | fried_rice: it has a gerrit cannot merge on it atm | 13:37 |
fried_rice | sdague Aaargh, missed that. | 13:37 |
fried_rice | rebasing... | 13:37 |
* mriedem stops reviewing | 13:37 | |
superdan | also, I'm not really the best person to look at that | 13:37 |
superdan | probably mriedem and sdague though | 13:37 |
mriedem | fried_rice: you're just doing all of these separately right? | 13:38 |
mriedem | for some reason i thought they were all lined up behind the glance one, which looked scary | 13:38 |
fried_rice | mriedem Yes | 13:38 |
fried_rice | mriedem Oh, some of them are lined up behind the glance one. | 13:38 |
fried_rice | But this one isn't. | 13:38 |
*** vvargaszte has quit IRC | 13:40 | |
*** esberglu has joined #openstack-nova | 13:40 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146 | 13:41 |
sdague | realized that after going from Ubuntu Unity -> Gnome 3 in 17.10, I lost my mechanism of knowing people had pinged me on irc. Think I got a solution for that today. Which hopefully means noticing when mriedem pokes at me | 13:41 |
*** catintheroof has joined #openstack-nova | 13:42 | |
*** mlavalle has joined #openstack-nova | 13:43 | |
belmoreira | mriedem, dansmith in newton when placement is enabled the resource_providers/allocations tables are populated. This doesn't happen for pike. Could this be achieved somehow? would be better than having a tool to merge the dbs | 13:43 |
mriedem | belmoreira: once all computes are upgraded to pike, the compute resource tracker stops reporting allocations in the update_available_resource periodic task | 13:44 |
mriedem | on purpose, | 13:44 |
mriedem | because in pike the scheduler creates allocations during create and move operations like migrate, | 13:44 |
mriedem | and the ocata computes would overwrite the allocations created by the pike scheduler | 13:44 |
superdan | what mriedem said again :) | 13:46 |
superdan | belmoreira: I think we should probably be on the hook to help with said merging tool because you won't be the only one that needs it | 13:47 |
*** abhishek_k has quit IRC | 13:48 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247 | 13:49 |
fried_rice | sdague mriedem ^ | 13:49 |
mriedem | superdan: is there any specific reason that nova.objects.base.obj_to_primitive doesn't convert datetimes to primitives? | 13:49 |
*** spectr has quit IRC | 13:49 | |
superdan | mriedem: um | 13:49 |
belmoreira | mriedem if in ocata the resource tracker still reports the allocations, means that in my upgrade procedure I move to the global placement just before upgrade to pike. In that case I would not need to merge the dbs. | 13:49 |
mriedem | belmoreira: so you're going to update nova.conf on all of the computes to point at global placement, take down the control plane and wait for the periodic task to do the inventory and allocation population? | 13:51 |
mriedem | s/control plane/api | 13:51 |
mriedem | belmoreira: to be clear, the resource tracker will continue to update allocations in placement as long as there is at least 1 <pike compute | 13:51 |
superdan | oh _that_ obj_to_primitive | 13:52 |
mriedem | it's just once all computes are >= pike we stop doing that | 13:52 |
mriedem | superdan: yeah i expected that to turn the entire object and it's fields into primitives | 13:52 |
superdan | mriedem: that is really obj_to_dict() for doing unholy things.. it doesn't serialize an object | 13:52 |
mriedem | ok - was trying to figure out why we needed this https://review.openstack.org/#/c/515539/1/nova/scheduler/utils.py@a83 | 13:52 |
mriedem | when we had already converted objects to primitives above | 13:52 |
mriedem | guess it's not what i thought it was | 13:53 |
*** awaugama has joined #openstack-nova | 13:53 | |
mriedem | like the bears in that cardinals game in the late 90s | 13:53 |
mriedem | with the dennis green post-game conference | 13:53 |
mriedem | leakypipes: ^ | 13:53 |
superdan | because someone wants a dict that looks like the object, probably for compat | 13:53 |
*** dave-mccowan has joined #openstack-nova | 13:53 | |
superdan | I would confirm, but a83 is not a line number | 13:53 |
mriedem | it's the left side of the diff | 13:54 |
*** pooja-jadhav has joined #openstack-nova | 13:54 | |
belmoreira | mriedem yes, and then upgrade control plane/compute nodes to pike, and do the cellsV2 mappings. All of this in downtime of course. maybe it will be more error prone and easier than the DB merging | 13:54 |
*** sree has quit IRC | 13:54 | |
mriedem | belmoreira: "less" error prone? | 13:54 |
superdan | oh sure enough | 13:55 |
*** niraj_singh has joined #openstack-nova | 13:55 | |
mriedem | ok i'll just return the to_primitive call with a note | 13:55 |
*** sree has joined #openstack-nova | 13:55 | |
belmoreira | s/more/less :) | 13:55 |
*** pooja_jadhav has quit IRC | 13:55 | |
*** bhagyashris has joined #openstack-nova | 13:55 | |
*** nsingh has quit IRC | 13:55 | |
leakypipes | mriedem: not sure why the jsonutils call is there :( | 13:56 |
*** owalsh has quit IRC | 13:56 | |
*** bhagyashri_s has quit IRC | 13:56 | |
*** arxcruz is now known as arxcruz|pto | 13:56 | |
superdan | belmoreira: the merging should be easy I would think.. tbh that seems less concerning that running ocata computes for a period of time to build new placement data, but it's your call.. I assume you'll test it | 13:56 |
mriedem | leakypipes: i meant the football reference! | 13:56 |
mriedem | i need at least one football person in this channel | 13:56 |
mriedem | clarkb: | 13:57 |
leakypipes | mriedem: sorry, you lost me at hello on that one. | 13:57 |
superdan | mriedem: I'm still a big confused, because that's jsonutils, not obj_to_primitive | 13:57 |
mriedem | superdan: i removed the jsonutils.to_primitive becaues it's calling that on a request_spec dict, which i thought had already-serialized items in it, | 13:57 |
mriedem | because of the obj_to_primitive calls that happen above for the instance and flavor | 13:57 |
mriedem | so i thought it was a redundant call and removed it | 13:58 |
mriedem | leakypipes: https://www.youtube.com/watch?v=SWmQbk5h86w | 13:58 |
superdan | mriedem: oh I see.. dear god | 13:58 |
superdan | mriedem: those are dictified instance and flavor not a serialized instance | 13:58 |
mriedem | let'em off the hook jay | 13:58 |
leakypipes | mriedem: :) ok, gotcha now. | 13:59 |
superdan | I think what we've learned here is that football references have no place in a nerd hangout | 13:59 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup build_request_spec https://review.openstack.org/515539 | 13:59 |
*** owalsh has joined #openstack-nova | 13:59 | |
*** sree has quit IRC | 14:00 | |
leakypipes | superdan: a lesson learned. it's a game of inches. sometimes you just need to go for it on fourth and ten. | 14:01 |
belmoreira | superdan if the data it's correctly recreated I would prefer to let the resource tracker do it. At the end should be faster than all the work required for the DB merging. Yes, I will test and let you know. Thanks | 14:01 |
*** gouthamr has joined #openstack-nova | 14:01 | |
*** baoli has joined #openstack-nova | 14:01 | |
mriedem | leakypipes: pretty risky unless you're in the red zone under the 2 minute warning and behind by over 3 | 14:03 |
mriedem | then you have no choise | 14:03 |
mriedem | *choice | 14:03 |
*** lyan has quit IRC | 14:03 | |
*** Dinesh_Bhor has quit IRC | 14:04 | |
*** vladikr has joined #openstack-nova | 14:04 | |
leakypipes | mriedem: right. though that's just a hail-mary pass to superdan at that point. | 14:04 |
* superdan runs screaming from the ball | 14:04 | |
mriedem | belmoreira: ok - the key thing being that you leave one compute at ocata until all of the other pike computes have reported their information | 14:05 |
mriedem | belmoreira: and you'd need some tooling to verify that is done, like querying placement for all active instances to make sure they show up with allocations | 14:06 |
*** andreas_s has quit IRC | 14:06 | |
belmoreira | mriedem ok. thanks | 14:08 |
bauwser | mriedem: https://review.openstack.org/#/c/515530/2/nova/conductor/manager.py@831 are you sure we can't have a rebuild where host=None ? I thought it was | 14:09 |
*** lyan has joined #openstack-nova | 14:09 | |
mriedem | bauwser: not for "rebuild" | 14:09 |
bauwser | mmmm | 14:09 |
bauwser | okay, then nevermind my -1, I'll changeit | 14:09 |
*** spectr has joined #openstack-nova | 14:09 | |
mriedem | bauwser: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2948 | 14:09 |
mriedem | rebuild wants to bypass the scheduler | 14:09 |
*** andreas_s has joined #openstack-nova | 14:10 | |
bauwser | that was my only concern, I was wanting to make sure that we were rebuilding by using the right image, which is image_ref | 14:10 |
bauwser | I mean, the target image | 14:10 |
mriedem | see the plethora of comments in the rebuild_intsance method i added recently about all of the fun conditionals and in what cases we get there from the voodoo in the api | 14:10 |
bauwser | yeah | 14:10 |
mriedem | bauwser: yeah that's a long-standing bug | 14:10 |
mriedem | "new image for rebuild!? sure, what the hell, we trust you!" | 14:10 |
bauwser | yeah :( | 14:11 |
bauwser | I thought we were checking the image even for a rebuild | 14:11 |
bauwser | the evacuate is a special case because we can pass a destination as a target on the CLI | 14:11 |
bauwser | while rebuild is not | 14:11 |
mriedem | https://bugs.launchpad.net/nova/+bug/1667667 | 14:12 |
openstack | Launchpad bug 1667667 in OpenStack Compute (nova) "Rebuilding instance ignores image's property hw_disk_bus" [Low,In progress] - Assigned to 赵明俊 (falseuser) | 14:12 |
bauwser | I wonder what a true use ris | 14:12 |
bauwser | user is* | 14:12 |
*** amodi has joined #openstack-nova | 14:12 | |
bauwser | wait, you said we use instance.host right? | 14:12 |
mriedem | bauwser: for "rebuild" | 14:12 |
mriedem | yes | 14:12 |
bauwser | so, we're *always* rebuilding on the same host ? | 14:12 |
mriedem | for "rebuild" yes | 14:12 |
bauwser | WAAAAAAAAT | 14:13 |
bauwser | a world is failling down to me | 14:13 |
mriedem | rebuild != evacuate | 14:13 |
bauwser | that I know | 14:13 |
bauwser | I just thought we were just finding another host unless you allow the rebuild on the same host | 14:13 |
*** claudiub has quit IRC | 14:13 | |
mriedem | that wasn't the bug, it was this one https://bugs.launchpad.net/nova/+bug/1664931 | 14:13 |
openstack | mriedem: Error: malone bug 1664931 not found | 14:13 |
*** andreas_s has quit IRC | 14:14 | |
*** andreas_s has joined #openstack-nova | 14:14 | |
* bauwser has headache | 14:14 | |
*** andreas_s has quit IRC | 14:14 | |
*** hongbin has joined #openstack-nova | 14:15 | |
*** andreas_s has joined #openstack-nova | 14:15 | |
*** Tom___ has joined #openstack-nova | 14:16 | |
bauwser | mriedem: okay, looks like I just forgot | 14:16 |
bauwser | mriedem: then, we need to tackle ^ | 14:16 |
bauwser | the patch is still valid in my mind | 14:16 |
*** armax has joined #openstack-nova | 14:17 | |
*** ratailor has joined #openstack-nova | 14:17 | |
mriedem | fried_rice: sdague: https://review.openstack.org/#/c/492247/ | 14:17 |
fried_rice | mriedem These get handled by passing them to KSA. | 14:19 |
fried_rice | mriedem But I'll see if cfg.DeprecatedOpt has a way for me to fill out 'since' and 'reason'. | 14:19 |
mriedem | fried_rice: the options themselves aren't called out as deprecated, | 14:19 |
mriedem | or when they were deprecated | 14:19 |
*** andreas_s has quit IRC | 14:19 | |
mriedem | fried_rice: you'd mark the nova opts as deprecated | 14:19 |
mriedem | in their definition | 14:19 |
mriedem | as normal | 14:19 |
*** dave-mccowan has quit IRC | 14:20 | |
fried_rice | ah, okay, will do. | 14:20 |
mriedem | but, i'm not done with this review yet, | 14:20 |
mriedem | so hold up | 14:20 |
* leakypipes grabs food | 14:21 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | 14:22 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | 14:22 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820 | 14:22 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860 | 14:22 |
*** rmart04 has joined #openstack-nova | 14:22 | |
openstackgerrit | Merged openstack/nova-specs master: Remove barbican from scope of ksa adapter work https://review.openstack.org/511524 | 14:23 |
*** jmccarthy has left #openstack-nova | 14:26 | |
*** felipemonteiro_ has joined #openstack-nova | 14:26 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: rt: Implement XenAPI get_inventory() method https://review.openstack.org/339204 | 14:27 |
jianghuaw | bauzas, leakypipes: ^ | 14:28 |
mriedem | fried_rice: ok comments inline | 14:29 |
fried_rice | mriedem Thanks | 14:29 |
*** baoli has quit IRC | 14:29 | |
jianghuaw | bauzas, thanks for spotting the issue. | 14:29 |
*** felipemonteiro__ has joined #openstack-nova | 14:32 | |
openstackgerrit | Merged openstack/nova master: Convert IVS VIF plugging / unplugging to privsep. https://review.openstack.org/515196 | 14:32 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data https://review.openstack.org/452818 | 14:34 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2) https://review.openstack.org/452819 | 14:34 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples https://review.openstack.org/452820 | 14:34 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples https://review.openstack.org/475860 | 14:34 |
*** baoli has joined #openstack-nova | 14:35 | |
*** felipemonteiro_ has quit IRC | 14:36 | |
*** spectr has quit IRC | 14:39 | |
*** Lirt has quit IRC | 14:40 | |
*** baoli has quit IRC | 14:42 | |
openstackgerrit | Merged openstack/nova master: Make migration uuid hold allocations for migrating instances https://review.openstack.org/506420 | 14:42 |
bauwser | jianghuaw: friday nick FWIW | 14:43 |
*** andreas_s has joined #openstack-nova | 14:45 | |
*** baoli has joined #openstack-nova | 14:45 | |
*** josecastroleon has quit IRC | 14:46 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247 | 14:47 |
fried_rice | mriedem See if those responses make sense ^ | 14:47 |
*** baoli has quit IRC | 14:48 | |
openstackgerrit | Merged openstack/nova master: rp: Remove RP.get_traits() method https://review.openstack.org/509027 | 14:48 |
*** andreas_s has quit IRC | 14:51 | |
*** andreas_s has joined #openstack-nova | 14:52 | |
*** andreas_s has quit IRC | 14:57 | |
*** Tom___ has quit IRC | 14:57 | |
*** ijw has joined #openstack-nova | 15:01 | |
*** ijw_ has joined #openstack-nova | 15:02 | |
fried_rice | leakypipes superdan https://review.openstack.org/#/c/499826/ please if you have a sec. (I'm trying to win cdent's prize.) (And the race to 1.11.) | 15:03 |
*** marst has quit IRC | 15:06 | |
*** ijw has quit IRC | 15:06 | |
*** marst has joined #openstack-nova | 15:06 | |
*** mdnadeem has quit IRC | 15:06 | |
*** rmart04 has quit IRC | 15:06 | |
*** baoli has joined #openstack-nova | 15:07 | |
jianghuaw | bauwser, thanks:-) | 15:07 |
*** belmoreira has quit IRC | 15:09 | |
*** coreywright has quit IRC | 15:10 | |
*** mdnadeem has joined #openstack-nova | 15:10 | |
*** dave-mccowan has joined #openstack-nova | 15:11 | |
leakypipes | fried_rice: I'm trying to win the same prize :) | 15:11 |
fried_rice | leakypipes Oh, if that de-orm stuff counts, you're gonna win. | 15:12 |
leakypipes | fried_rice: damn it. | 15:12 |
leakypipes | fried_rice: nah, the n-r-p series adds 1.11 | 15:12 |
leakypipes | it's ok, though. I can rebase easy enough. | 15:12 |
fried_rice | leakypipes Yeah, we had like seven different 1.11 patches in flight. | 15:12 |
leakypipes | yeah it's cool :) | 15:13 |
leakypipes | I mean.. cool as in I know we did :) | 15:13 |
leakypipes | not that I relish rebasing | 15:13 |
fried_rice | leakypipes It made me think there ought to be a way to automate it. But that way lies madness. | 15:13 |
*** AlexeyAbashkin has quit IRC | 15:13 | |
leakypipes | fried_rice: indeed | 15:13 |
*** yamahata has joined #openstack-nova | 15:14 | |
*** jmlowe_ has joined #openstack-nova | 15:14 | |
mriedem | fried_rice: you didn't update the placement api-ref https://review.openstack.org/#/c/499826/ | 15:15 |
mriedem | time to -1? | 15:15 |
fried_rice | mriedem I thought it was because that guy already documented the missing link | 15:15 |
*** hemna_ has quit IRC | 15:15 | |
cdent | le sigh. so much rebase. | 15:16 |
*** sree has joined #openstack-nova | 15:16 | |
*** jmlowe has quit IRC | 15:16 | |
mriedem | https://developer.openstack.org/api-ref/placement/#id2 ? | 15:16 |
fried_rice | mriedem Yeah, not. | 15:16 |
mriedem | fried_rice: just roll it on top | 15:16 |
mriedem | but know that i'm watching, always watching | 15:16 |
fried_rice | mriedem Will do. | 15:16 |
leakypipes | that reminds me I need to update the n-r-p REST API patch to amend the devref docs | 15:17 |
fried_rice | mriedem leakypipes I *was* thinking there should be some kind of "add a microversion checklist" internal doc for devs. | 15:17 |
mriedem | fried_rice: there are docs on adding microversions, | 15:17 |
mriedem | for both compute and placement | 15:17 |
*** links has joined #openstack-nova | 15:19 | |
mriedem | fried_rice: this is the doc for compute microversions https://docs.openstack.org/nova/pike/contributor/microversions.html | 15:21 |
*** dave-mccowan has quit IRC | 15:21 | |
mriedem | fried_rice: maybe add something here? https://docs.openstack.org/nova/pike/contributor/microversions.html#other-necessary-changes | 15:21 |
fried_rice | mriedem Remind me where the source for the api-ref docs is? | 15:21 |
mriedem | and this for placement https://docs.openstack.org/nova/pike/contributor/placement.html#microversions | 15:21 |
mriedem | nova/api-ref? | 15:22 |
mriedem | nova/placement-api-ref | 15:22 |
*** armax_ has joined #openstack-nova | 15:22 | |
*** salv-orlando has quit IRC | 15:22 | |
bauwser | mriedem, sdague: crazy thoughts, could we just get rid of block_device_mapping.device_name as an API param ? | 15:22 |
*** armax has quit IRC | 15:22 | |
*** armax_ is now known as armax | 15:22 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.interface_attach samples https://review.openstack.org/515740 | 15:23 |
*** salv-orlando has joined #openstack-nova | 15:23 | |
mriedem | bauwser: i already tried | 15:23 |
bauwser | mriedem, sdague: it's not like we can pretend it works | 15:23 |
bauwser | mriedem: the fun part of that is OSC https://github.com/openstack/python-openstackclient/blob/e0d7119c6dcba5666f2a0916b9a6e347e2e2758c/openstackclient/compute/v2/server.py#L621 | 15:23 |
mriedem | bauwser: https://review.openstack.org/#/c/452546/ | 15:23 |
*** coreywright has joined #openstack-nova | 15:23 | |
*** yamamoto has quit IRC | 15:24 | |
* bauwser sighes | 15:24 | |
*** slaweq_ has quit IRC | 15:25 | |
*** salv-orlando has quit IRC | 15:27 | |
*** andreas_s has joined #openstack-nova | 15:27 | |
leakypipes | fried_rice, mriedem: I'm just going to wait on updating the REST API n-r-p patch to update the placement-api-ref until fried_rice's patch lands, since I'm gonna need to change to 1.12 anyway. | 15:28 |
fried_rice | ack | 15:28 |
bauwser | mriedem: not fully understanding the problem with device names that feodor is mentioning | 15:28 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.live_migration notification samples https://review.openstack.org/515745 | 15:29 |
bauwser | mriedem: oh they somehow want some way to identify which BDM to update | 15:29 |
bauwser | don't BDMs have UUIDs ? | 15:30 |
mriedem | bauwser: not yet | 15:30 |
mriedem | bauwser: but mdbooth is adding them in i think | 15:30 |
*** itlinux has joined #openstack-nova | 15:30 | |
*** itlinux has quit IRC | 15:30 | |
bauwser | mriedem: so that would solve the problem IMHO | 15:31 |
*** andreas_s has quit IRC | 15:31 | |
*** mdnadeem has quit IRC | 15:31 | |
mdbooth | bauwser: Indeed I will add BDM uuids. | 15:33 |
mriedem | bauwser: idk, it | 15:33 |
*** awaugama has quit IRC | 15:33 | |
mriedem | it's been a long time since i had ftersin's bfv issue in my head | 15:33 |
mriedem | but it was something for ec2 of course | 15:33 |
mdbooth | bauwser: I was thinking during our call earlier, btw, that device names in the context of the api do mean something, just not really what people think. | 15:33 |
*** rabel has joined #openstack-nova | 15:33 | |
mdbooth | Which looks like what I wrote in that review ages ago that I'd completely forgotten about. | 15:34 |
mdbooth | i.e. 'sda' means 'the first disk on a scsi bus' | 15:34 |
mdbooth | It *doesn't* mean that your linux OS will create it as /dev/sda, though | 15:35 |
*** mwynne has quit IRC | 15:35 | |
bauwser | mdbooth: right, it's an identifier | 15:35 |
mdbooth | tags mean something specific | 15:35 |
bauwser | mdbooth: but for the worst, we decided that this identifier should look like a device name, which is IMHO the worst terrible idea | 15:36 |
rabel | Hi there, can we merge https://review.openstack.org/#/c/494169/ now? I think it is really ready by now. | 15:36 |
mdbooth | uuids would also mean something specific, although I don't have any plans to expose them to the user explicitly | 15:36 |
bauwser | mdbooth: looks to me it's a cinder problem | 15:36 |
mdbooth | bauwser: Yes, agreed. | 15:36 |
mdbooth | ... but not to cinder ... | 15:37 |
bauwser | mdbooth: if you need something to tag your volumes, it's cinder, not nova | 15:37 |
mdbooth | How's it a cinder thing? | 15:37 |
mdbooth | Nah, that's totally a Nova thing | 15:37 |
*** andreas_s has joined #openstack-nova | 15:37 | |
mdbooth | Cinder just gives us a repository of bits. It's entirely Nova's domain how that's presented to the guest. | 15:37 |
bauwser | mdbooth: what is the purpose of tagging that? | 15:38 |
bauwser | I'm surely not getting the full picture, but I don't get why I need to keep information on how my volume is presented to the guest | 15:39 |
mdbooth | Device tagging? It's so the guest OS can identify specific devices which were specified by the api. | 15:39 |
bauwser | mdbooth: oh, but that's a totally different problem | 15:39 |
bauwser | mdbooth: and surely device names don't solve it | 15:39 |
bauwser | mdbooth: if you need some device tagging like we did for NICs, I understand that's a nova problem | 15:40 |
mdbooth | Device tagging is a much, much better way to solve the same problem. | 15:40 |
bauwser | I just don't understand why it blocks us to get rid of device names | 15:40 |
bauwser | because device names wasn't helping to solve the problem you mention on the guest side | 15:40 |
bauwser | it's even worst : you think it will help | 15:41 |
bauwser | by 'you', I mean the application developer | 15:41 |
bauwser | so for example, I'm a user | 15:41 |
*** sheel has quit IRC | 15:41 | |
bauwser | I'm using device names because I think it will give me a way to know which device I'm getting on the guest side | 15:42 |
bauwser | guess what ? It doesn't work | 15:42 |
bauwser | like I said to you in our meeting, I played with it in Essex | 15:42 |
bauwser | and Folsom | 15:42 |
bauwser | totally a mess | 15:42 |
openstackgerrit | Eric Fried proposed openstack/nova master: Update placement api-ref: allocations link in 1.11 https://review.openstack.org/515748 | 15:43 |
bauwser | I learned hard that device names weren't a firm contract | 15:43 |
fried_rice | mriedem leakypipes ^ I didn't bother to base it on the one in the gate; should I? | 15:43 |
leakypipes | fried_rice: I don't personally mind if mriedem is cool with that | 15:43 |
mriedem | add a depends-on at least | 15:45 |
leakypipes | fried_rice: +2 from me. | 15:45 |
leakypipes | fried_rice: good point from mriedem on the depends-on | 15:45 |
*** andreas_s has quit IRC | 15:46 | |
*** andreas_s has joined #openstack-nova | 15:47 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Update placement api-ref: allocations link in 1.11 https://review.openstack.org/515748 | 15:47 |
fried_rice | leakypipes mriedem depends-on ^ | 15:47 |
mdbooth | bauwser: Was just reading that review back. I've evicted that context from my mental cache ;) | 15:47 |
mdbooth | bauwser: Sounds like the issue was that there's an existing useful interaction with image-defined bdms | 15:48 |
*** jaosorior has quit IRC | 15:48 | |
mdbooth | Without more spelunking, though, I don't recall what that interaction is | 15:48 |
*** tssurya has quit IRC | 15:49 | |
*** BenderRodriguez has joined #openstack-nova | 15:49 | |
*** BenderRodriguez has quit IRC | 15:49 | |
*** BenderRodriguez has joined #openstack-nova | 15:49 | |
mdbooth | If that were the case, though, bdm uuids wouldn't be a replacement. | 15:49 |
mdbooth | ...but device tags could be | 15:51 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Deduplicate instance.reboot notification samples https://review.openstack.org/515751 | 15:51 |
*** derekh has quit IRC | 15:52 | |
*** andreas_s has quit IRC | 15:52 | |
*** andreas_s has joined #openstack-nova | 15:53 | |
fried_rice | sdague FYI, I think there's still something wrong with that cinder patch. I should -W it. | 15:55 |
*** sree has quit IRC | 15:55 | |
*** sree has joined #openstack-nova | 15:55 | |
*** trinaths has joined #openstack-nova | 15:55 | |
*** itlinux has joined #openstack-nova | 15:57 | |
*** artom has quit IRC | 15:58 | |
leakypipes | rabel: reviewed. | 15:59 |
*** sree has quit IRC | 16:00 | |
rabel | leakypipes: thank you | 16:00 |
*** yamamoto has joined #openstack-nova | 16:01 | |
*** andreas_s has quit IRC | 16:02 | |
*** lpetrut has quit IRC | 16:03 | |
*** Apoorva has joined #openstack-nova | 16:03 | |
*** dave-mccowan has joined #openstack-nova | 16:04 | |
*** andreas_s has joined #openstack-nova | 16:04 | |
*** fried_rice has quit IRC | 16:05 | |
*** ratailor has quit IRC | 16:06 | |
cdent | leakypipes: see my response on https://review.openstack.org/#/c/510626/ for why project_id and user_id was not added on /rp/u/allocations _now_ | 16:09 |
*** sridharg has quit IRC | 16:10 | |
*** lucasagomes is now known as lucas-afk | 16:13 | |
*** andreas_s has quit IRC | 16:14 | |
*** andreas_s has joined #openstack-nova | 16:16 | |
*** hemna_ has joined #openstack-nova | 16:18 | |
*** fried_rice has joined #openstack-nova | 16:18 | |
*** ijw_ has quit IRC | 16:18 | |
*** robcresswell has joined #openstack-nova | 16:19 | |
jianghuaw | leakypipes, bauwser: I have a question about vGPU's inventory update. it invoking get_inventory() when compute_node is changed: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L807 | 16:19 |
jianghuaw | But for vGPU, we only report it via inventory no new fields saved in obj of compute_node. | 16:20 |
*** andreas_s has quit IRC | 16:21 | |
*** artom has joined #openstack-nova | 16:21 | |
jianghuaw | I see there is inventory caching in resource provider tree. and a new function update_inventory() is implemented. | 16:22 |
jianghuaw | But I assume that's only for nest-RP. right? | 16:22 |
openstackgerrit | David Rabel proposed openstack/nova master: VMware: add support for graceful shutdown of instances https://review.openstack.org/494169 | 16:23 |
*** catintheroof has quit IRC | 16:23 | |
*** salv-orlando has joined #openstack-nova | 16:23 | |
*** jmlowe_ has quit IRC | 16:23 | |
*** andreas_s has joined #openstack-nova | 16:23 | |
jianghuaw | leakypipes, bauwser: I think our plan is to implement vGPU by associate the inventory on compute node as the first step. so not depending on the n-r-p. | 16:24 |
jianghuaw | then how to trigger the inventory update without resource provider tree? | 16:25 |
*** dave-mccowan has quit IRC | 16:26 | |
*** catintheroof has joined #openstack-nova | 16:27 | |
bauwser | jianghuaw: see my libvirt change | 16:27 |
bauwser | jianghuaw: I'm hoping to push a new revision by tonight | 16:27 |
*** salv-orlando has quit IRC | 16:27 | |
*** andreas_s has quit IRC | 16:28 | |
jianghuaw | is this already included in the existing patch? bauwser | 16:29 |
*** andreas_s has joined #openstack-nova | 16:29 | |
jianghuaw | or will be in the new revision? | 16:29 |
rabel | leakypipes: is the new patchset ok? | 16:30 |
jianghuaw | bauwser, I didn't see that part in https://review.openstack.org/#/c/514763 | 16:30 |
*** jamesden_ has joined #openstack-nova | 16:32 | |
*** jamesdenton has quit IRC | 16:32 | |
*** catintheroof has quit IRC | 16:35 | |
jianghuaw | bauwser, I was thinking we should make it to invoke get_inventory regardless compute_node changed or not. caching inventory locally; and update inventory to placement if inventory changed. | 16:35 |
*** dtantsur is now known as dtantsur|afk | 16:36 | |
*** catintheroof has joined #openstack-nova | 16:36 | |
jianghuaw | bauwser, Good to know you've already considered it. | 16:36 |
*** shvepsy has quit IRC | 16:37 | |
*** shvepsy has joined #openstack-nova | 16:37 | |
*** links has quit IRC | 16:38 | |
*** catintheroof has quit IRC | 16:39 | |
*** rabel has quit IRC | 16:39 | |
*** catintheroof has joined #openstack-nova | 16:39 | |
*** andreas_s has quit IRC | 16:40 | |
jianghuaw | leakypipes, bauwser, superdan: it's appreciated if you can have a look at this patch for get_inventory in XenAPI: https://review.openstack.org/#/c/339204/ | 16:40 |
jianghuaw | hope it be an easy one:-) | 16:40 |
leakypipes | jianghuaw: will do shortly. on phone right now. | 16:40 |
jianghuaw | leakypipes, thanks:-) | 16:41 |
*** sambetts is now known as sambetts|afk | 16:41 | |
*** ttsiouts has quit IRC | 16:43 | |
leakypipes | cdent: yes, that makes sense. | 16:45 |
bauwser | jianghuaw: sorry, I was super busy prepping the new rev | 16:47 |
bauwser | jianghuaw: so, basically, we have the same problem with libvirt | 16:47 |
bauwser | jianghuaw: for example, we have a list of supported types | 16:47 |
bauwser | jianghuaw: then, the operator selects a specific type | 16:48 |
bauwser | (if you see my change, we only support one) | 16:48 |
bauwser | jianghuaw: so, the inventory is saying N+M | 16:48 |
bauwser | where N is the allocatable mdevs, and M is the already allocated ones | 16:48 |
bauwser | if the operator modifies that, then it's creating a problem because when you create a mdev by a type, the other types for the same device are getting 0 allocable mdevs | 16:49 |
*** dave-mccowan has joined #openstack-nova | 16:50 | |
*** andreas_s has joined #openstack-nova | 16:51 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: libvirt: Provide VGPU inventory for a single GPU type https://review.openstack.org/514763 | 16:51 |
bauwser | jianghuaw: new revision ^ | 16:51 |
jianghuaw | yes. I see. It can't create mdev for the other types once created a specific type of mdev. | 16:51 |
jianghuaw | looking at it | 16:51 |
*** AlexeyAbashkin has joined #openstack-nova | 16:53 | |
jianghuaw | bauwser, no. my problem is different: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L807 | 16:53 |
jianghuaw | it will return if the compute_node resource is not changed. | 16:53 |
jianghuaw | bauwser, at the moment it only compare some resource fields of compute-node's: e.g. vcpu, memory. | 16:54 |
bauwser | jianghuaw: so, what's your concern ? | 16:54 |
*** Guest40670 has quit IRC | 16:55 | |
jianghuaw | the vGPU resource is not saved in compute-node. so my concern is the vGPU inventory may be not be updated if the other resource is not changed. | 16:55 |
bauwser | a-ja | 16:56 |
*** andreas_s has quit IRC | 16:56 | |
jianghuaw | bauwser, as vGPU is only reported by get_inventory() | 16:56 |
*** AlexeyAbashkin has quit IRC | 16:57 | |
bauwser | jianghuaw: right, good point | 16:57 |
bauwser | jianghuaw: so we should somehow signal those the old way | 16:57 |
*** andreas_s has joined #openstack-nova | 16:58 | |
bauwser | not saying to add the VGPU resources in the Computenode object :) | 16:58 |
bauwser | just having a way to signal it thru update_available_resources | 16:58 |
openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247 | 16:58 |
bauwser | or other way, I dunno | 16:58 |
bauwser | I need to think about it | 16:58 |
jianghuaw | I see. what I was thinking is to invoked always get_inventory(). | 16:59 |
*** mhickey has quit IRC | 16:59 | |
jianghuaw | but I'm not sure if that's acceptable. | 16:59 |
*** ralonsoh has quit IRC | 17:00 | |
jianghuaw | bauwser, here it defines update_inventory https://github.com/openstack/nova/blob/master/nova/compute/provider_tree.py#L233 | 17:01 |
bauwser | jianghuaw: one way to see that is that we could call get_inventory() first, pass it to _resource_change, keep it in memory and compare it at the next _resource_change run | 17:02 |
jianghuaw | but it requires some way to determine how and when to get the new inventory. | 17:02 |
bauwser | because _resource_change is just for making sure we don't update the DB every 60 secs | 17:02 |
*** dave-mccowan has quit IRC | 17:03 | |
openstackgerrit | Merged openstack/nova master: rp: move RP._set_traits() to module scope https://review.openstack.org/509028 | 17:03 |
*** dave-mccowan has joined #openstack-nova | 17:03 | |
bauwser | jianghuaw: for Queens, I really would like my series to not be depending on n-r-p | 17:03 |
*** fragatina has quit IRC | 17:03 | |
*** trinaths has left #openstack-nova | 17:03 | |
jianghuaw | bauwser, the n-r-p seems in good progress. isn't it? | 17:04 |
jianghuaw | maybe we can use n-r-p? | 17:04 |
*** Matias has joined #openstack-nova | 17:05 | |
*** andreas_s has quit IRC | 17:07 | |
jianghuaw | bauwser, anyway I also agree that passing it to _resource_change looks like a good solution. | 17:07 |
*** rmcallis has joined #openstack-nova | 17:07 | |
bauwser | jianghuaw: I can write that change | 17:07 |
jianghuaw | I'd like to see the viewpoint from leakypipes also. | 17:08 |
bauwser | I need to dinner, but I'd be around by the next 2 hours | 17:08 |
jianghuaw | bauwser, yes you can go ahead with the change. | 17:08 |
bauwser | jianghuaw: which TZ are you in ? | 17:08 |
jianghuaw | I'm in China. | 17:09 |
*** vladikr has quit IRC | 17:09 | |
jianghuaw | so 1:09 am:-) | 17:09 |
jianghuaw | please go ahead with your dinner. We can chat further on next Monday. | 17:09 |
jianghuaw | :-) | 17:10 |
*** andreas_s has joined #openstack-nova | 17:13 | |
bauwser | ++ | 17:13 |
*** yamamoto has quit IRC | 17:13 | |
bauwser | jianghuaw: and go to bed | 17:13 |
bauwser | ! | 17:13 |
*** awaugama has joined #openstack-nova | 17:13 | |
jianghuaw | bauwser, cheers. wish you a nice weekend:-) | 17:14 |
openstackgerrit | Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151 | 17:16 |
openstackgerrit | Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223 | 17:16 |
jianghuaw | bauwser, when you come back, hope you have seconds to look at this patch for get_inventory in xenapi: https://review.openstack.org/#/c/339204 | 17:18 |
*** jpena is now known as jpena|off | 17:19 | |
jianghuaw | bauwser, also I have a patching to report vGPU resources from XenAPI: https://review.openstack.org/#/c/512965/ | 17:19 |
*** andreas_s has quit IRC | 17:19 | |
jianghuaw | I'm preparing another patch to create vGPU inventory. | 17:20 |
*** yamamoto has joined #openstack-nova | 17:21 | |
*** fragatina has joined #openstack-nova | 17:21 | |
*** aarefiev is now known as aarefiev_afk | 17:21 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Only filter/weigh hosts once if scheduling a single instance https://review.openstack.org/513931 | 17:24 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add Selection objects https://review.openstack.org/499239 | 17:24 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver https://review.openstack.org/495854 | 17:24 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Change RPC for select_destinations() https://review.openstack.org/510159 | 17:24 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils https://review.openstack.org/511357 | 17:24 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Make conductor pass and use host_lists https://review.openstack.org/511358 | 17:24 |
*** awaugama has quit IRC | 17:26 | |
*** gszasz has quit IRC | 17:27 | |
*** itlinux has quit IRC | 17:28 | |
*** Swami has joined #openstack-nova | 17:29 | |
*** sapcc-bot has quit IRC | 17:29 | |
*** mkoderer_ has joined #openstack-nova | 17:29 | |
*** sapcc-bot has joined #openstack-nova | 17:29 | |
*** dave-mccowan has quit IRC | 17:29 | |
*** jmlowe has joined #openstack-nova | 17:30 | |
*** mkoderer_ has quit IRC | 17:31 | |
jianghuaw | leakypipes, thanks for the +2. | 17:31 |
leakypipes | jianghuaw: np | 17:32 |
leakypipes | jianghuaw: now go to bed! :) | 17:32 |
jianghuaw | :) | 17:33 |
*** awaugama has joined #openstack-nova | 17:37 | |
*** lajoskatona has quit IRC | 17:38 | |
*** tssurya has joined #openstack-nova | 17:40 | |
openstackgerrit | Merged openstack/nova master: Include /resource_providers/uuid/allocations link https://review.openstack.org/499826 | 17:45 |
*** yamamoto has quit IRC | 17:49 | |
*** penick has joined #openstack-nova | 17:50 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223 | 17:50 |
*** yamahata has quit IRC | 17:52 | |
*** yamamoto has joined #openstack-nova | 17:53 | |
*** itlinux has joined #openstack-nova | 17:53 | |
*** yamamoto has quit IRC | 17:59 | |
*** rmart04 has joined #openstack-nova | 18:02 | |
*** harlowja has quit IRC | 18:05 | |
*** harlowja has joined #openstack-nova | 18:05 | |
*** vks1 has quit IRC | 18:12 | |
*** Apoorva has quit IRC | 18:15 | |
*** Apoorva has joined #openstack-nova | 18:17 | |
*** tssurya has quit IRC | 18:19 | |
*** salv-orlando has joined #openstack-nova | 18:24 | |
*** salv-orlando has quit IRC | 18:29 | |
*** tssurya has joined #openstack-nova | 18:32 | |
*** rtjure has quit IRC | 18:34 | |
*** rtjure has joined #openstack-nova | 18:35 | |
mriedem | figleaf: superdan: leakypipes: cdent: how would you guys all love to have a thrilling hangout to make sure we're on the same page about https://review.openstack.org/#/c/510159/ ? | 18:35 |
mriedem | assuming cdent not so much given friday night fun time | 18:35 |
superdan | you mean now? | 18:35 |
cdent | i’m around actually, but haven’t been following along today | 18:36 |
mriedem | superdan: i'm game, i don't think this would be a long call | 18:36 |
mriedem | else it waits | 18:36 |
mriedem | i think in at least one retrospective we said, 'when in doubt, hangout' | 18:37 |
mriedem | and, 'if it's brown, flush it down' | 18:37 |
figleaf | mriedem: I can do it in the next 15 min; then I have to run out for a bit | 18:38 |
*** dave-mccowan has joined #openstack-nova | 18:38 | |
* cdent would enjoy listening in | 18:38 | |
mriedem | figleaf: as in you're free at 2pm? | 18:39 |
mriedem | or out at 2pm? | 18:39 |
figleaf | mriedem: no, I'm free now. Gotta be somewhere at 2 | 18:39 |
*** rtjure has quit IRC | 18:39 | |
mriedem | https://hangouts.google.com/call/M3gJOjmdi0q0Ayha5KkYAAEE | 18:40 |
superdan | cdent: you're breathing.. heavily | 18:41 |
*** sahid has quit IRC | 18:43 | |
*** dave-mccowan has quit IRC | 18:44 | |
*** rtjure has joined #openstack-nova | 18:45 | |
*** fragatina has quit IRC | 18:48 | |
leakypipes | mriedem: cool with me. | 18:48 |
*** rtjure has quit IRC | 18:50 | |
*** smatzek has quit IRC | 18:52 | |
figleaf | superdan: you have that effect on people | 18:55 |
superdan | I'm going to pretend you didn't say that | 18:56 |
* cdent regrets not having a chance to make a dan I’m your father crack | 18:56 | |
mriedem | figleaf: ok left a summary in the patch | 18:57 |
mriedem | https://review.openstack.org/#/c/510159/ | 18:57 |
mriedem | thanks | 18:57 |
*** yamamoto has joined #openstack-nova | 18:59 | |
*** yamamoto has quit IRC | 19:06 | |
*** lpetrut has joined #openstack-nova | 19:08 | |
*** awaugama has quit IRC | 19:08 | |
*** sree has joined #openstack-nova | 19:11 | |
*** avolkov has quit IRC | 19:14 | |
*** sree has quit IRC | 19:16 | |
*** andreas_s has joined #openstack-nova | 19:21 | |
*** smatzek has joined #openstack-nova | 19:27 | |
*** rmart04 has quit IRC | 19:27 | |
*** Apoorva has quit IRC | 19:28 | |
*** Apoorva has joined #openstack-nova | 19:29 | |
*** catintheroof has quit IRC | 19:29 | |
*** andreas_s has quit IRC | 19:31 | |
*** andreas_s has joined #openstack-nova | 19:32 | |
*** Apoorva has quit IRC | 19:33 | |
*** tesseract has quit IRC | 19:33 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138 | 19:34 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215 | 19:34 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 19:34 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 19:34 |
openstackgerrit | Eric Fried proposed openstack/nova master: ResourceRequest.to_querystring() https://review.openstack.org/515811 | 19:37 |
*** andreas_s has quit IRC | 19:37 | |
*** dave-mccowan has joined #openstack-nova | 19:37 | |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807 | 19:37 |
openstackgerrit | Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693 | 19:37 |
*** andreas_s has joined #openstack-nova | 19:38 | |
*** catintheroof has joined #openstack-nova | 19:41 | |
*** Apoorva has joined #openstack-nova | 19:43 | |
fried_rice | leakypipes Would you mind skimming the next couple patches in the series? I can dig having a RequestGroup class, but I'd like to keep the encompassing thing as a class (rather than a plain list of RequestGroup) so it do things like merge all the resources and produce a querystring. | 19:45 |
fried_rice | s/so it do/so it can do/ | 19:45 |
*** catintheroof has quit IRC | 19:45 | |
*** sree has joined #openstack-nova | 19:46 | |
leakypipes | fried_rice: yup, I definitely will go through the remainder of the series. Probably won't be today, though... | 19:47 |
*** smatzek has quit IRC | 19:47 | |
leakypipes | fried_rice: you're high in my queue, though. | 19:48 |
fried_rice | leakypipes Cool man. | 19:48 |
*** dave-mccowan has quit IRC | 19:49 | |
*** sree has quit IRC | 19:51 | |
*** pchavva has quit IRC | 19:51 | |
*** andreas_s has quit IRC | 19:54 | |
*** smatzek has joined #openstack-nova | 19:55 | |
*** andreas_s has joined #openstack-nova | 19:56 | |
*** rcernin has joined #openstack-nova | 19:57 | |
*** sree has joined #openstack-nova | 19:58 | |
*** andreas_s has quit IRC | 20:01 | |
*** itlinux has quit IRC | 20:01 | |
*** yamamoto has joined #openstack-nova | 20:02 | |
*** andreas_s has joined #openstack-nova | 20:02 | |
*** sree has quit IRC | 20:03 | |
*** rmart04 has joined #openstack-nova | 20:03 | |
*** rmart04 has quit IRC | 20:03 | |
bauwser | leakypipes: around ? | 20:04 |
leakypipes | bauwser: yup! | 20:04 |
bauwser | leakypipes: not sure you saw the discussion we had with jianghuaw | 20:04 |
bauwser | leakypipes: about https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L807 | 20:05 |
leakypipes | bauwser: no, I didn't | 20:05 |
bauwser | leakypipes: the problem is that if the compute node resources are not changing, then we don't call the inventory | 20:05 |
*** smatzek has quit IRC | 20:05 | |
leakypipes | bauwser: yes? | 20:06 |
bauwser | leakypipes: which is a problem with the VGPU resources | 20:06 |
leakypipes | bauwser: why? | 20:06 |
bauwser | since they're not in the compute node | 20:06 |
leakypipes | bauwser: ah, yeah... | 20:07 |
bauwser | leakypipes: I thought about that | 20:07 |
leakypipes | bauwser: that line can be moved to after the call to get_inventory() eventually | 20:07 |
bauwser | leakypipes: that's my point :p | 20:07 |
leakypipes | yup | 20:07 |
bauwser | I was asking you if you were okay with that :) | 20:07 |
*** yamamoto has quit IRC | 20:08 | |
bauwser | leakypipes: we could also persist the inventory | 20:08 |
bauwser | leakypipes: so passing it to the _resource_change method too | 20:08 |
bauwser | and so, not setting the inventory if that's not changing too :) | 20:09 |
bauwser | anyway, lemme provide the chnage | 20:09 |
leakypipes | bauwser: that's kind of what my nested resource provider series is doing. | 20:10 |
*** ijw has joined #openstack-nova | 20:11 | |
*** penick has quit IRC | 20:11 | |
leakypipes | bauwser: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L609 | 20:12 |
leakypipes | bauwser: basically, that needs to come before the _resource_changed() thing in the RT. | 20:12 |
leakypipes | bauwser: or we just get rid of the _resource_changed() thing entirely... | 20:13 |
bauwser | mmmm | 20:13 |
bauwser | leakypipes: what I honestly need is to look at your series :p | 20:14 |
*** jmlowe has quit IRC | 20:14 | |
*** tssurya has quit IRC | 20:15 | |
*** andreas_s has quit IRC | 20:15 | |
*** ijw has quit IRC | 20:16 | |
*** andreas_s has joined #openstack-nova | 20:17 | |
*** hongbin has quit IRC | 20:20 | |
*** tssurya has joined #openstack-nova | 20:21 | |
*** salv-orlando has joined #openstack-nova | 20:25 | |
*** yamahata has joined #openstack-nova | 20:25 | |
fried_rice | leakypipes Sure makes it trickier to test... | 20:26 |
leakypipes | fried_rice: makes what trickier to test? | 20:27 |
*** hongbin has joined #openstack-nova | 20:27 | |
fried_rice | leakypipes The resource groups being objects instead of a big dict I can just build up and compare. It's not a big deal. Just prolly going to write some test-only methods on the objects. | 20:28 |
leakypipes | fried_rice: ack. | 20:28 |
leakypipes | fried_rice: well, I prefer if you don't add methods to the objects themselves. rather, add a comparator method to the test class. | 20:28 |
leakypipes | assertRequestGroupsSame() or something like that... | 20:29 |
fried_rice | leakypipes Yuh. | 20:29 |
*** salv-orlando has quit IRC | 20:29 | |
*** andreas_s has quit IRC | 20:31 | |
fried_rice | leakypipes But then I have to build up RequestGroups for the 'expected' side. | 20:31 |
leakypipes | fried_rice: correct. | 20:31 |
leakypipes | fried_rice: which is explicit. and good. | 20:31 |
fried_rice | leakypipes But reduces the test coverage, cause I'm using Thing to test Thing. | 20:32 |
fried_rice | leakypipes Again, not a big deal, can do. | 20:32 |
leakypipes | fried_rice: if Thing is just a plain-old-data object, that's good. | 20:32 |
*** andreas_s has joined #openstack-nova | 20:32 | |
*** dave-mccowan has joined #openstack-nova | 20:33 | |
*** ijw has joined #openstack-nova | 20:35 | |
*** ijw has quit IRC | 20:35 | |
*** salv-orlando has joined #openstack-nova | 20:35 | |
*** ijw has joined #openstack-nova | 20:36 | |
openstackgerrit | Merged openstack/nova master: Update placement api-ref: allocations link in 1.11 https://review.openstack.org/515748 | 20:36 |
*** mdbooth has quit IRC | 20:37 | |
*** ansiwen has quit IRC | 20:37 | |
*** andreas_s has quit IRC | 20:37 | |
*** dave-mccowan has quit IRC | 20:38 | |
*** thorst has quit IRC | 20:38 | |
*** andreas_s has joined #openstack-nova | 20:38 | |
*** itlinux has joined #openstack-nova | 20:41 | |
openstackgerrit | Michael Still proposed openstack/nova master: Move infiniband vif plugging to privsep. https://review.openstack.org/515197 | 20:42 |
openstackgerrit | Michael Still proposed openstack/nova master: Move midonet vif plugging to privsep. https://review.openstack.org/515198 | 20:42 |
openstackgerrit | Michael Still proposed openstack/nova master: Move plumgrid vif plugging to privsep. https://review.openstack.org/515336 | 20:42 |
openstackgerrit | Michael Still proposed openstack/nova master: Move control vif plugging to privsep. https://review.openstack.org/515916 | 20:42 |
*** andreas_s has quit IRC | 20:44 | |
*** mdbooth has joined #openstack-nova | 20:44 | |
openstackgerrit | Michael Still proposed openstack/nova master: Move plumgrid vif plugging to privsep. https://review.openstack.org/515336 | 20:44 |
openstackgerrit | Michael Still proposed openstack/nova master: Move contrail vif plugging to privsep. https://review.openstack.org/515916 | 20:44 |
*** ansiwen has joined #openstack-nova | 20:44 | |
*** yamahata has quit IRC | 20:44 | |
*** andreas_s has joined #openstack-nova | 20:44 | |
*** pchavva has joined #openstack-nova | 20:45 | |
*** felipemonteiro__ has quit IRC | 20:48 | |
*** andreas_s has quit IRC | 20:50 | |
*** andreas_s has joined #openstack-nova | 20:51 | |
*** pchavva has quit IRC | 20:52 | |
openstackgerrit | Merged openstack/nova master: [placement] Allow _set_allocations to delete allocations https://review.openstack.org/501051 | 20:53 |
mriedem | fried_rice: comments in 16 and 18 https://review.openstack.org/#/c/492247/ | 20:55 |
*** READ10 has joined #openstack-nova | 20:55 | |
fried_rice | ... | 20:55 |
fried_rice | mriedem Roger wilco, will update. Thanks. | 20:56 |
mriedem | |_o_| | 20:56 |
mriedem | 3 points if you do | 20:57 |
mriedem | superdan knows what that 3 points is for | 20:57 |
cdent | been a lot of football today | 20:57 |
mriedem | heh | 20:57 |
mriedem | that reminds me | 20:57 |
mriedem | vikings in london on sunday | 20:57 |
mriedem | that means i get football at 8:30, noon, 3:30 and 7:30 | 20:58 |
cdent | apparently when the nfl go to london _loads_ of people go nutbar and dress up for the game | 20:58 |
superdan | obviously three points for a three pointer shot from midfield | 20:58 |
cdent | which when I heard about it, completely surprised me | 20:58 |
superdan | swish | 20:58 |
superdan | goooooooal | 20:58 |
* superdan wonders if he's going in the right direction | 20:58 | |
mriedem | close, field goal | 20:59 |
*** Apoorva_ has joined #openstack-nova | 20:59 | |
mriedem | cdent: yes, if you watch the game, it's all people dressed up in different stuff | 20:59 |
mriedem | because there is no home team, just ex-pats | 20:59 |
cdent | weird | 20:59 |
mriedem | i think the official home team is jacksonville or miami, both of whom are pretty bad every year, so you're welcome | 20:59 |
cdent | is it ex-pats? I was under the impression it was crazy brits deciding they love american football and not knowing how to show it | 20:59 |
mriedem | could be worse, | 20:59 |
mriedem | could be the gd browns | 21:00 |
mriedem | oh shit | 21:00 |
mriedem | guess who the vikings play on sunday in london? | 21:00 |
mriedem | the f'ing browns! | 21:00 |
*** andreas_s has quit IRC | 21:01 | |
*** hemna_ has quit IRC | 21:01 | |
*** Apoorva has quit IRC | 21:02 | |
*** andreas_s has joined #openstack-nova | 21:02 | |
openstackgerrit | Merged openstack/nova master: Only filter/weigh hosts once if scheduling a single instance https://review.openstack.org/513931 | 21:03 |
bauwser | mriedem: well, Barca-Juv was in NYC this summer :p | 21:03 |
mriedem | no one knows what that is | 21:03 |
bauwser | gdi | 21:03 |
bauwser | man, soccer! | 21:03 |
*** pchavva has joined #openstack-nova | 21:04 | |
bauwser | you know, the game that US folks try to play and at the end, they loose :p | 21:04 |
mriedem | unless they are women | 21:04 |
cdent | us women’s soccer rocs | 21:04 |
*** fragatina has joined #openstack-nova | 21:04 | |
* cdent gets all nostalgic for high school | 21:04 | |
bauwser | that's correct :) | 21:04 |
*** yamamoto has joined #openstack-nova | 21:05 | |
cdent | tickets to the london nfl games are a lot cheaper than I would have predicted | 21:06 |
mriedem | because they need to fill the seats to look good on t | 21:06 |
mriedem | *tv | 21:06 |
cdent | fried_rice: can you try a bit harder, only 50% of my pending patches are in merge conflict | 21:06 |
fried_rice | cdent Somebody had to take the fall. | 21:07 |
*** itlinux has quit IRC | 21:07 | |
cdent | I think if leakypipes merges a couple more de-orms that should break the rest of the nova ones | 21:07 |
*** smatzek has joined #openstack-nova | 21:07 | |
*** andreas_s has quit IRC | 21:08 | |
*** pchavva has quit IRC | 21:09 | |
*** andreas_s has joined #openstack-nova | 21:09 | |
* cdent actually likes merge conflicts | 21:09 | |
cdent | they’re a bit like mile markers on the highway | 21:09 |
*** yamamoto has quit IRC | 21:10 | |
*** itlinux has joined #openstack-nova | 21:15 | |
*** tssurya has quit IRC | 21:15 | |
*** marst has quit IRC | 21:15 | |
*** andreas_s has quit IRC | 21:18 | |
*** andreas_s has joined #openstack-nova | 21:19 | |
*** leakypipes has quit IRC | 21:23 | |
*** andreas_s has quit IRC | 21:24 | |
*** yamahata has joined #openstack-nova | 21:24 | |
*** penick has joined #openstack-nova | 21:25 | |
*** rcernin has quit IRC | 21:28 | |
*** andreas_s has joined #openstack-nova | 21:29 | |
*** sree has joined #openstack-nova | 21:32 | |
*** esberglu has quit IRC | 21:34 | |
*** READ10 has quit IRC | 21:35 | |
*** sree has quit IRC | 21:37 | |
*** amodi has quit IRC | 21:38 | |
*** andreas_s has quit IRC | 21:39 | |
*** jamesden_ is now known as jamesdenton | 21:41 | |
*** andreas_s has joined #openstack-nova | 21:41 | |
*** baoli has quit IRC | 21:42 | |
*** itlinux has quit IRC | 21:44 | |
*** salv-orlando has quit IRC | 21:50 | |
*** salv-orlando has joined #openstack-nova | 21:50 | |
*** salv-orlando has quit IRC | 21:55 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements https://review.openstack.org/493146 | 21:57 |
*** sapcc-bot has quit IRC | 21:58 | |
*** sapcc-bot has joined #openstack-nova | 21:58 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035 | 22:00 |
*** andreas_s has quit IRC | 22:01 | |
*** figleaf is now known as edleafe | 22:01 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/511035 | 22:01 |
*** salv-orlando has joined #openstack-nova | 22:03 | |
*** ijw has quit IRC | 22:05 | |
*** ijw has joined #openstack-nova | 22:05 | |
*** burt has quit IRC | 22:06 | |
*** yamamoto has joined #openstack-nova | 22:06 | |
*** andreas_s has joined #openstack-nova | 22:06 | |
*** smatzek has quit IRC | 22:09 | |
*** smatzek has joined #openstack-nova | 22:10 | |
*** smatzek has quit IRC | 22:11 | |
*** yamamoto has quit IRC | 22:11 | |
*** awaugama has joined #openstack-nova | 22:11 | |
*** smatzek has joined #openstack-nova | 22:11 | |
openstackgerrit | Merged openstack/nova master: rt: Implement XenAPI get_inventory() method https://review.openstack.org/339204 | 22:12 |
*** lyan has quit IRC | 22:12 | |
*** dave-mccowan has joined #openstack-nova | 22:14 | |
*** smatzek has quit IRC | 22:16 | |
*** andreas_s has quit IRC | 22:16 | |
*** awaugama has quit IRC | 22:17 | |
*** andreas_s has joined #openstack-nova | 22:17 | |
*** sree has joined #openstack-nova | 22:19 | |
*** artom has quit IRC | 22:19 | |
*** andreas_s has quit IRC | 22:22 | |
*** sree has quit IRC | 22:23 | |
*** thorst has joined #openstack-nova | 22:24 | |
*** dave-mccowan has quit IRC | 22:24 | |
*** salv-orlando has quit IRC | 22:27 | |
*** andreas_s has joined #openstack-nova | 22:28 | |
*** salv-orlando has joined #openstack-nova | 22:28 | |
*** thorst has quit IRC | 22:29 | |
rm_work | Do you guys have a feel for how commonly deployments use the AZ extension? | 22:32 |
rm_work | I'm curious if it's close to 100%, or much less | 22:32 |
mriedem | i'd say pretty common | 22:33 |
*** itlinux has joined #openstack-nova | 22:33 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs https://review.openstack.org/515151 | 22:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec} https://review.openstack.org/515223 | 22:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: ResourceRequest.to_querystring() https://review.openstack.org/515811 | 22:33 |
mriedem | but probably better input if you ask in #openstack-operators | 22:33 |
rm_work | hmm, k | 22:33 |
*** salv-orlando has quit IRC | 22:35 | |
*** salv-orlando has joined #openstack-nova | 22:36 | |
*** lpetrut has quit IRC | 22:36 | |
*** andreas_s has quit IRC | 22:38 | |
*** salv-orlando has quit IRC | 22:40 | |
bfife | kashyap / melwitt; thanks for https://review.openstack.org/#/c/514339/. what i came here to sort out :-) | 22:41 |
fried_rice | mriedem Okay, so here's how those deprecations work with ksa... | 22:45 |
fried_rice | If you were to access the deprecated opt directly (e.g. CONF.placement.os_region_name), you would get the deprecation message from the deprecated_reason. | 22:46 |
fried_rice | But you would never do that. | 22:46 |
*** itlinux has quit IRC | 22:46 | |
fried_rice | What actually happens is you call utils.get_ksa_adapter, which references that var from within ksa, where it keys off of the fact that we passed that guy as a deprecated opt. | 22:47 |
fried_rice | whereupon it emits the warning that looks like: WARNING:oslo_config.cfg:Option "os_region_name" from group "placement" is deprecated. Use option "region-name" from group "placement". | 22:47 |
fried_rice | So... it's only useful for me to even put the deprecated_reason into the conf for developers' eyeballs to look at. (Unless the deprecation shows up in the config sample - but it doesn't, does it?) | 22:48 |
mriedem | it does show up in the conf sample | 22:48 |
mriedem | which is why i asked for it | 22:48 |
mriedem | otherwise you have to look at the others to see the link | 22:48 |
*** ijw has quit IRC | 22:48 | |
*** ijw has joined #openstack-nova | 22:49 | |
fried_rice | mriedem Okay, cool. Will fix. | 22:49 |
*** sdague has quit IRC | 22:50 | |
*** andreas_s has joined #openstack-nova | 22:54 | |
*** andreas_s has quit IRC | 22:58 | |
*** yamamoto has joined #openstack-nova | 23:07 | |
*** andreas_s has joined #openstack-nova | 23:08 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests https://review.openstack.org/492247 | 23:09 |
fried_rice | mriedem Done, I think ^ | 23:10 |
fried_rice | mriedem Though I built the conf sample, and I couldn't get that stuff to show up in it... | 23:10 |
*** ansiwen[q] has quit IRC | 23:10 | |
fried_rice | I think the deprecation from ksa is doing some funkiness that overrides. | 23:10 |
*** yamahata has quit IRC | 23:10 | |
fried_rice | but at least it's visible to the guy looking at the file. | 23:10 |
fried_rice | I want to say I looked at all of this when I first started slinging this blueprint around, but clearly I've slept since then. | 23:11 |
mriedem | ok | 23:11 |
*** yamamoto has quit IRC | 23:12 | |
bauwser | mriedem: heh, related kaboom https://bugs.launchpad.net/nova/+bug/1721522 | 23:13 |
openstack | Launchpad bug 1721522 in OpenStack Compute (nova) "encrypted volumes: Cannot format device /dev/sdb which is still in use" [Undecided,Incomplete] | 23:13 |
bauwser | mriedem: looks like the folk asked for sdb | 23:13 |
bauwser | oh even better https://docs.openstack.org/cinder/pike/configuration/block-storage/volume-encryption.html | 23:14 |
mriedem | because we pass the user-supplied device to the cryptsetup command rather than taking what we calculated as the device ourselves? | 23:14 |
bauwser | openstack server add volume --device /dev/vdc TESTVM 'encrypted volume' | 23:14 |
mriedem | openstack server add volume --device /dev/vdc TESTVM 'encrypted volume' | 23:14 |
mriedem | heh | 23:14 |
mriedem | yeah | 23:14 |
bauwser | mriedem: looks like | 23:15 |
*** ansiwen[q] has joined #openstack-nova | 23:15 | |
mriedem | probably need a .. note:: that says "don't pass device" | 23:15 |
bauwser | :) | 23:15 |
bauwser | I'll wait for the reply | 23:15 |
bauwser | mriedem: also FYI https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L621 | 23:16 |
* bauwser <3 OSC | 23:16 | |
bauwser | even if the user doesn't specify it, OSC forces it | 23:16 |
mriedem | yeah you already showed me that | 23:16 |
mriedem | i'd say that should all be deprecated in osc | 23:16 |
bauwser | ah yeah | 23:16 |
mriedem | looks like chenrui added a bunch of that | 23:17 |
mriedem | he's at huawei | 23:17 |
*** andreas_s has quit IRC | 23:17 | |
bauwser | cool | 23:17 |
mriedem | although it also looks like that predated his changes https://github.com/openstack/python-openstackclient/commit/95c8661f86e74c9d5217869a740da11350f1f0eb | 23:18 |
*** cdent has quit IRC | 23:19 | |
*** andreas_s has joined #openstack-nova | 23:19 | |
mriedem | https://github.com/openstack/python-openstackclient/commit/2c9d263611190996d64e35bc74a8575aeb25ed3e | 23:20 |
mriedem | anyway, deprecate it | 23:20 |
mriedem | Kevin_Zheng: ^ :) | 23:20 |
bauwser | mriedem: indeed | 23:20 |
bauwser | that change trampled your colleague | 23:20 |
*** hongbin has quit IRC | 23:21 | |
bauwser | wait, it's Saturday now here | 23:21 |
*** bauwser is now known as bauzas | 23:21 | |
bauzas | mriedem: before going to bed, I'd love your thoughts on https://bugs.launchpad.net/nova/+bug/1723165 | 23:22 |
openstack | Launchpad bug 1723165 in OpenStack Compute (nova) "Volume is not detached when deleted VM was in error state" [Undecided,New] | 23:22 |
bauzas | that's not a quota problem, just the fact we don't unattach the volumz | 23:22 |
*** ansiwen[q] has quit IRC | 23:22 | |
*** fried_rice is now known as efried | 23:22 | |
bauzas | I tend to think it's legit | 23:23 |
Kevin_Zheng | mriedem: will check latter, 4th Saturday of the month... still have to work | 23:23 |
*** andreas_s has quit IRC | 23:24 | |
*** penick has quit IRC | 23:25 | |
*** thorst has joined #openstack-nova | 23:27 | |
mriedem | bauzas: sounds like a bug | 23:29 |
mriedem | we don't test image-defined bdms very well | 23:29 |
*** owalsh is now known as owalsh_pto | 23:29 | |
mriedem | error scenarios anyway | 23:29 |
bauzas | triaging it | 23:29 |
bauzas | if it's something else, then meh | 23:29 |
*** andreas_s has joined #openstack-nova | 23:30 | |
mriedem | bauzas: oh i see, | 23:31 |
mriedem | so it goes to error state in the compute service, | 23:31 |
mriedem | because that's going to create some new volumes in cinder from the snapshot bdms | 23:31 |
mriedem | cinder fails on the volume create because overquota | 23:31 |
bauzas | right | 23:31 |
mriedem | and we probably don't "detach" the volumes because we never attached them in the first place - because of overquota | 23:31 |
mriedem | or maybe we attached 2 but didn't finish one of them in time, idk | 23:32 |
bauzas | looks like it's the instance which fails, not the volume creation | 23:33 |
mriedem | would probably be helpful for them to give us the information about the volumes after the failure | 23:33 |
mriedem | like their status and if they show an instance id | 23:33 |
bauzas | because the volume is there | 23:33 |
mriedem | but the instance failure would be due to _prep_block_devices failing to create the last volume | 23:33 |
mriedem | because cinder returns overquota | 23:33 |
mriedem | they started with 3 volumes, | 23:33 |
mriedem | snapshot | 23:33 |
mriedem | set vol quota to 5 | 23:33 |
mriedem | create new instance from the image snapshot which has 3 image-defined bdms in it, | 23:34 |
mriedem | so nova is going to create 3 more volumes from the snapshot bdms, | 23:34 |
mriedem | 2 will get created, 1 will fail with overquota from cinder | 23:34 |
mriedem | which makes _prep_block_devices fail and the instance goes to ERROR state on the compute | 23:34 |
bauzas | right | 23:34 |
*** thorst has quit IRC | 23:38 | |
*** andreas_s has quit IRC | 23:38 | |
*** andreas_s has joined #openstack-nova | 23:44 | |
*** Swami has quit IRC | 23:46 | |
*** stvnoyes has quit IRC | 23:48 | |
*** thorst has joined #openstack-nova | 23:49 | |
*** thorst has quit IRC | 23:49 | |
*** andreas_s has quit IRC | 23:49 | |
*** oanson has quit IRC | 23:54 | |
*** andreas_s has joined #openstack-nova | 23:54 | |
*** oanson has joined #openstack-nova | 23:55 | |
bauzas | mriedem: last point, are we unquoting a shelved instance or not ? | 23:55 |
bauzas | of course, an offloaded instance | 23:56 |
bauzas | I think we shouldn't | 23:56 |
mriedem | can't talk about bugs anymore | 23:57 |
mriedem | go to be you crazy frenchman | 23:57 |
mriedem | *bed | 23:57 |
bauzas | :p | 23:58 |
bauzas | we have 18 open bugs and next week, I'll have a talk about bug triaging :p | 23:58 |
mriedem | yeah i know why you've been on top of it, | 23:59 |
mriedem | you should have to give a talk about bug triaging every quarter | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!