Friday, 2017-10-27

*** andreas_s has joined #openstack-nova00:00
*** hongbin has quit IRC00:01
*** READ10 has joined #openstack-nova00:01
*** vladikr has joined #openstack-nova00:04
*** AlexeyAbashkin has joined #openstack-nova00:10
*** itlinux has joined #openstack-nova00:10
*** catintheroof has joined #openstack-nova00:11
*** burgerk has joined #openstack-nova00:13
*** AlexeyAbashkin has quit IRC00:14
*** rcernin has joined #openstack-nova00:21
*** andreas_s has quit IRC00:26
*** andreas_s has joined #openstack-nova00:28
*** catintheroof has quit IRC00:32
*** burgerk has quit IRC00:36
*** catintheroof has joined #openstack-nova00:38
*** gyee has quit IRC00:40
*** sree has joined #openstack-nova00:40
*** vladikr has quit IRC00:42
*** catintheroof has quit IRC00:42
*** andreas_s has quit IRC00:43
*** Apoorva_ has joined #openstack-nova00:43
*** catintheroof has joined #openstack-nova00:44
*** andreas_s has joined #openstack-nova00:44
*** sree has quit IRC00:45
*** AlexeyAbashkin has joined #openstack-nova00:46
*** Apoorva has quit IRC00:47
*** Apoorva_ has quit IRC00:47
*** gouthamr has joined #openstack-nova00:48
*** andreas_s has quit IRC00:48
*** litao__ has joined #openstack-nova00:49
*** AlexeyAbashkin has quit IRC00:51
*** andreas_s has joined #openstack-nova00:55
*** catintheroof has quit IRC00:55
*** catintheroof has joined #openstack-nova00:56
*** zzzeek has quit IRC00:58
*** jichen has joined #openstack-nova00:59
*** andreas_s has quit IRC01:00
*** zzzeek has joined #openstack-nova01:00
*** andreas_s has joined #openstack-nova01:01
*** phuongnh has joined #openstack-nova01:02
*** smatzek has joined #openstack-nova01:02
*** andreas_s has quit IRC01:12
*** huanxie has joined #openstack-nova01:13
*** mriedem has joined #openstack-nova01:15
*** mriedem_away has quit IRC01:15
mriedemmelwitt: nice re https://review.openstack.org/#/c/508271 - maybe you want to +2 :)01:16
*** thorst has joined #openstack-nova01:16
melwittmriedem: yep, wanted to get the a-ok from you first in case there was anything else01:16
*** thorst has quit IRC01:17
*** andreas_s has joined #openstack-nova01:18
*** amodi has joined #openstack-nova01:20
*** catintheroof has quit IRC01:20
*** namnh has joined #openstack-nova01:21
*** catintheroof has joined #openstack-nova01:21
*** Kevin_Zheng has joined #openstack-nova01:22
*** catintheroof has quit IRC01:24
*** gmann_afk is now known as gmann01:25
*** dave-mccowan has quit IRC01:26
*** dave-mccowan has joined #openstack-nova01:27
*** andreas_s has quit IRC01:28
*** vladikr has joined #openstack-nova01:32
*** psachin has joined #openstack-nova01:36
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Handle network-changed event for a specific port  https://review.openstack.org/46578701:37
mriedemcfriesen: finally got back to updating that ^ still needs unit tests, but i'm seeing the code hitting in the live migration job now that the live migration tests in tempest are building a tenant network01:37
*** andreas_s has joined #openstack-nova01:37
*** rcernin has quit IRC01:43
*** yamamoto has joined #openstack-nova01:43
*** rcernin has joined #openstack-nova01:44
*** READ10 has quit IRC01:47
*** andreas_s has quit IRC01:47
*** yamamoto has quit IRC01:49
*** smatzek has quit IRC01:50
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: remove extraneous retry assignment in cleanup method  https://review.openstack.org/40919901:54
*** catintheroof has joined #openstack-nova01:55
*** salv-orlando has joined #openstack-nova01:55
*** andreas_s has joined #openstack-nova01:56
*** salv-orlando has quit IRC02:00
*** catintheroof has quit IRC02:00
*** Tom__ has quit IRC02:00
*** tbachman has quit IRC02:01
*** andreas_s has quit IRC02:02
Kevin_Zhenghttps://review.openstack.org/#/c/507769/02:02
Kevin_Zhengmriedem ^ what should I do about this? Should I add it in master02:03
Kevin_Zhengor stable/pike?02:03
Kevin_Zhengoh, just saw Tony's comment02:04
*** hongbin has joined #openstack-nova02:05
mriedemhmm, well, master will be kind of weird if we fix the bug in 17.0.002:06
mriedemwe'd have to remove the release note from master if it gets fixed there02:06
Kevin_Zhengso add a new one just in stable/pike?02:07
mriedemi think do it in master, and then if we get it fixed in master we'll remove the reno in the same patch02:07
mriedemi think reno can deal with deleted release notes02:08
Kevin_ZhengOK02:08
*** Tom__ has joined #openstack-nova02:08
*** Tom__ has quit IRC02:09
*** Tom__ has joined #openstack-nova02:09
*** Tom__ has quit IRC02:09
*** gcb has joined #openstack-nova02:16
*** thorst has joined #openstack-nova02:18
*** huanxie has quit IRC02:22
*** andreas_s has joined #openstack-nova02:22
*** thorst has quit IRC02:23
*** annp has joined #openstack-nova02:23
mriedemKevin_Zheng: http://lists.openstack.org/pipermail/openstack-operators/2017-October/014459.html02:24
Kevin_ZhengThanks alot02:25
openstackgerritGhanshyam Mann proposed openstack/nova master: [WIP]Implement query param schema for flavor index  https://review.openstack.org/51541302:25
*** andreas_s has quit IRC02:26
*** catintheroof has joined #openstack-nova02:28
*** yamahata has quit IRC02:29
*** andreas_s has joined #openstack-nova02:33
*** catintheroof has quit IRC02:33
*** fragatina has quit IRC02:40
*** andreas_s has quit IRC02:44
*** Tom__ has joined #openstack-nova02:45
*** yamamoto has joined #openstack-nova02:45
*** fragatina has joined #openstack-nova02:45
*** AlexeyAbashkin has joined #openstack-nova02:47
*** trozet has joined #openstack-nova02:47
*** fragatina has quit IRC02:50
*** yamamoto has quit IRC02:51
*** AlexeyAbashkin has quit IRC02:52
*** amodi has quit IRC02:53
*** andreas_s has joined #openstack-nova02:57
openstackgerritChen Hanxiao proposed openstack/nova master: libvirt: properly decode error message from qemu guest agent  https://review.openstack.org/51145903:05
*** andreas_s has quit IRC03:07
*** AlexeyAbashkin has joined #openstack-nova03:08
*** trozet has quit IRC03:11
*** andreas_s has joined #openstack-nova03:12
*** AlexeyAbashkin has quit IRC03:12
*** yikun has quit IRC03:12
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements  https://review.openstack.org/51103503:13
*** dave-mccowan has quit IRC03:14
*** yamamoto has joined #openstack-nova03:16
*** andreas_s has quit IRC03:18
*** andreas_s has joined #openstack-nova03:19
*** huanxie has joined #openstack-nova03:19
*** andreas_s has quit IRC03:24
openstackgerritYikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040603:28
openstackgerritYikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040603:29
*** nicolasbock has quit IRC03:30
*** andreas_s has joined #openstack-nova03:34
*** hongbin has quit IRC03:35
*** yamamoto has quit IRC03:36
*** andreas_s has quit IRC03:38
*** yamahata has joined #openstack-nova03:39
openstackgerritMatt Riedemann proposed openstack/nova master: Fix instance lookup in hide_server_addresses extension  https://review.openstack.org/46777203:42
*** markvoelker has quit IRC03:43
*** andreas_s has joined #openstack-nova03:47
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: Handle network-changed event for a specific port  https://review.openstack.org/46578703:48
*** tyrefors has quit IRC03:50
openstackgerritZhenyu Zheng proposed openstack/nova master: Remove incorrect comment about instance.locked  https://review.openstack.org/51530603:51
*** andreas_s has quit IRC03:52
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Avoid unnecessary lazy-loads in mutated_migration_context  https://review.openstack.org/51558103:53
*** gongysh has joined #openstack-nova03:53
*** yamamoto has joined #openstack-nova03:54
*** yamamoto has quit IRC03:54
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: see what else is doing useless migration context stuff  https://review.openstack.org/47149103:55
*** yamamoto has joined #openstack-nova03:55
*** salv-orlando has joined #openstack-nova03:56
*** fragatina has joined #openstack-nova03:57
*** fragatina has quit IRC03:58
*** udesale has joined #openstack-nova03:58
*** fragatina has joined #openstack-nova03:58
*** salv-orlando has quit IRC04:00
*** huanxie has quit IRC04:01
*** catintheroof has joined #openstack-nova04:01
*** psachin has quit IRC04:03
*** catintheroof has quit IRC04:05
openstackgerritMatt Riedemann proposed openstack/nova master: Handle InstanceNotFound when setting password via metadata  https://review.openstack.org/47293304:06
openstackgerritGhanshyam Mann proposed openstack/nova master: Implement query param schema for flavor index  https://review.openstack.org/51541304:08
*** mdnadeem has joined #openstack-nova04:08
*** yangyape_ has joined #openstack-nova04:09
*** yangyapeng has quit IRC04:11
*** vks1 has joined #openstack-nova04:14
*** mriedem has quit IRC04:15
*** bhagyashri_s has joined #openstack-nova04:15
*** pooja-jadhav has joined #openstack-nova04:15
*** fragatina has quit IRC04:16
*** Apoorva has joined #openstack-nova04:16
*** pooja_jadhav has quit IRC04:17
*** bhagyashris has quit IRC04:17
*** thorst has joined #openstack-nova04:19
*** annp has quit IRC04:20
*** claudiub|2 has joined #openstack-nova04:20
*** psachin has joined #openstack-nova04:21
*** thorst has quit IRC04:24
*** bhagyashri_s is now known as bhagyashris04:24
*** rmcallis has quit IRC04:27
*** annp has joined #openstack-nova04:28
*** janki has joined #openstack-nova04:36
*** sree has joined #openstack-nova04:37
*** logan- has quit IRC04:38
*** logan- has joined #openstack-nova04:42
*** gongysh has quit IRC04:42
*** bhagyashris has quit IRC04:46
*** Apoorva has quit IRC04:46
*** rmk has quit IRC04:50
*** cburgess has quit IRC04:51
*** rmcallis has joined #openstack-nova04:53
*** yikun_jiang has quit IRC04:54
*** yikun_jiang has joined #openstack-nova04:54
*** Tom__ has quit IRC04:55
*** Tom__ has joined #openstack-nova04:56
*** rmcallis has quit IRC04:58
*** gabor_antal_km has quit IRC04:59
*** rmcallis has joined #openstack-nova04:59
*** Tom__ has quit IRC05:00
*** cburgess has joined #openstack-nova05:03
*** vvargaszte has joined #openstack-nova05:03
*** rmk has joined #openstack-nova05:05
*** rmk has quit IRC05:05
*** rmk has joined #openstack-nova05:05
*** jaosorior has joined #openstack-nova05:05
*** huanxie has joined #openstack-nova05:08
*** tbachman has joined #openstack-nova05:08
*** slaweq has joined #openstack-nova05:11
*** vvargaszte has quit IRC05:14
*** psachin has quit IRC05:14
*** masuberu has joined #openstack-nova05:15
*** psachin has joined #openstack-nova05:16
*** slaweq has quit IRC05:16
*** lpetrut has joined #openstack-nova05:16
*** masber has quit IRC05:18
*** masber has joined #openstack-nova05:20
*** yamamoto has quit IRC05:21
*** masuberu has quit IRC05:23
*** salv-orlando has joined #openstack-nova05:25
*** gongysh has joined #openstack-nova05:25
*** tbachman has quit IRC05:26
*** trinaths has joined #openstack-nova05:34
*** trinaths has left #openstack-nova05:36
*** salv-orlando has quit IRC05:38
*** takashin has left #openstack-nova05:38
*** salv-orlando has joined #openstack-nova05:38
*** avolkov has joined #openstack-nova05:40
*** markvoelker has joined #openstack-nova05:43
*** BenderRodriguez has quit IRC05:47
*** ratailor has joined #openstack-nova06:03
*** lpetrut has quit IRC06:17
*** markvoelker has quit IRC06:18
*** thorst has joined #openstack-nova06:20
*** gouthamr has quit IRC06:21
*** spectr has joined #openstack-nova06:22
*** andreas_s has joined #openstack-nova06:24
*** ratailor has quit IRC06:24
*** thorst has quit IRC06:25
*** bhagyashris has joined #openstack-nova06:26
*** lpetrut has joined #openstack-nova06:27
*** lpetrut has quit IRC06:33
*** lpetrut has joined #openstack-nova06:34
*** sahid has joined #openstack-nova06:34
*** Tom___ has joined #openstack-nova06:34
*** gongysh has quit IRC06:36
*** ratailor has joined #openstack-nova06:37
*** Tom___ has quit IRC06:40
*** Tom___ has joined #openstack-nova06:40
*** Tom___ has quit IRC06:41
*** Tom___ has joined #openstack-nova06:41
*** tssurya_ has joined #openstack-nova06:43
*** tssurya_ has quit IRC06:43
*** lpetrut has quit IRC06:44
*** lajoskatona has joined #openstack-nova06:44
*** ratailor has quit IRC06:56
*** ratailor has joined #openstack-nova06:56
openstackgerritYikun Jiang proposed openstack/nova master: [WIP]Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040607:06
*** slaweq has joined #openstack-nova07:12
*** vvargaszte has joined #openstack-nova07:13
*** vvargaszte has quit IRC07:14
*** markvoelker has joined #openstack-nova07:14
*** slaweq has quit IRC07:16
*** armax has quit IRC07:21
*** tesseract has joined #openstack-nova07:22
*** armax has joined #openstack-nova07:22
*** armax has quit IRC07:22
*** armax has joined #openstack-nova07:23
*** armax has quit IRC07:23
*** armax has joined #openstack-nova07:24
*** armax has quit IRC07:24
*** armax has joined #openstack-nova07:24
*** armax has quit IRC07:25
*** armax has joined #openstack-nova07:25
*** armax has quit IRC07:25
*** armax has joined #openstack-nova07:26
*** armax has quit IRC07:26
*** slaweq has joined #openstack-nova07:26
*** armax has joined #openstack-nova07:27
*** armax has quit IRC07:27
*** salv-orlando has quit IRC07:30
*** salv-orlando has joined #openstack-nova07:31
*** tssurya has quit IRC07:31
*** tssurya has joined #openstack-nova07:32
*** thorst has joined #openstack-nova07:33
*** namnh has quit IRC07:34
*** salv-orlando has quit IRC07:35
*** yikun has joined #openstack-nova07:36
*** yikun_jiang has quit IRC07:37
*** rmart04 has joined #openstack-nova07:38
openstackgerritZhenyu Zheng proposed openstack/nova master: Mention API behavior change when over quota limit  https://review.openstack.org/51563107:38
*** thorst has quit IRC07:38
*** josecastroleon has joined #openstack-nova07:41
*** ratailor has quit IRC07:41
*** itlinux has quit IRC07:43
*** markvoelker has quit IRC07:48
*** trungnv has quit IRC07:49
*** jpena|off is now known as jpena07:49
*** ralonsoh has joined #openstack-nova07:50
*** salv-orlando has joined #openstack-nova07:52
*** ratailor has joined #openstack-nova07:54
kashyapHi melwitt: Thanks for sheperding this through -- https://review.openstack.org/#/c/514339/07:55
melwittkashyap: np, it was ... a learning experience07:56
*** AlexeyAbashkin has joined #openstack-nova07:56
melwitt(it took me a long time to figure out how to test it) :P07:56
kashyapmelwitt: :-)  Are the confusing bits from the commit message replaced?07:56
kashyapmelwitt: From the bug report, seems like you've tested it directly from `virsh` :-)07:57
melwittkashyap: yeah, mriedem updated the commit message to take out the part about ceph + writeback because I don't think that's related to the bug. that is, I don't think there's anything in nova that makes ceph automatically configure itself for writeback07:57
*** rcernin has quit IRC07:58
kashyapmelwitt: Yep, just noticed.  Thank you07:58
kashyapAlso feel free to edit away the commit message even if you didn't write if it's wrong / confusing :-)07:58
melwittkashyap: no, I was able to reproduce it in unit tests. the virsh stuff is from the downstream bug report, I thought it would more clearly illustrate what the problem was07:58
kashyapAh, right07:58
melwittin case ppl don't know what "cache mode" means, just to show it's part of the domain xml stuff07:59
melwittk, noted for the future :)07:59
kashyapYeah, true07:59
kashyapmelwitt: Also about the different cache modes, this is a nice page that explains what it means: https://rwmj.wordpress.com/2013/09/02/new-in-libguestfs-allow-cache-mode-to-be-selected/08:00
*** gcb has quit IRC08:00
melwittah, nice. thanks08:00
bauzasmelwitt: GO TO BED!08:00
kashyapBut MattR also copied some verbiage from somewhere in Nova conf as well.08:00
kashyapmelwitt: Yeah, I was wondering.  Wauw, isn't it 01:00 AM for you there?!08:01
kashyapSurprised to hear you answer to my ping here actually.08:01
melwittbauzas: I will, soon :) was stubbornly working on solving something08:01
bauzasmelwitt: Ted Mosby said a couple of times that nothing good can happen after 2am, so you only have 1 hour left08:01
melwittlol08:02
*** gcb has joined #openstack-nova08:03
*** slaweq has quit IRC08:04
*** slaweq has joined #openstack-nova08:05
melwittkashyap: oh, in case you didn't know, the reason we were moving so fast on that change is because newton eol was being held back on it08:05
kashyapmelwitt: Ah, I recall dansmith saying during a call last week08:05
kashyapmelwitt: Thank you for the unit test fixes.  I struggle a bit with it08:06
melwittnp. writing the tests is the most challenging part for me most of the time08:06
kashyapmelwitt: Any tips you have (write later, when you rested) to get better at it are welcome :-)08:07
melwittheh, k08:07
kashyapMaybe just: keep reading and tinkering more and write more of them :-)08:07
melwittyeah, that's most of it. gets better with practice08:08
*** trungnv has joined #openstack-nova08:09
melwittalright yall, seeya in some hours08:11
*** yamahata has quit IRC08:14
kashyapGet some sleep.08:14
openstackgerritZhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach interface  https://review.openstack.org/51219008:14
openstackgerritYikun Jiang proposed openstack/python-novaclient master: Use utils.prepare_query_string instead of duplicated code  https://review.openstack.org/51564008:19
openstackgerritMerged openstack/nova master: libvirt: Don't disregard cache mode for instance boot disks  https://review.openstack.org/51433908:21
*** lucas-afk is now known as lucasagomes08:26
*** mhickey has joined #openstack-nova08:31
openstackgerritJianghua Wang proposed openstack/nova master: vgpu: add enabled white list  https://review.openstack.org/51258008:33
openstackgerritJianghua Wang proposed openstack/nova master: vGPU: XenAPI: get vgpu stats from hypervisor  https://review.openstack.org/51296508:33
*** udesale has quit IRC08:35
*** Laurene has joined #openstack-nova08:37
*** gszasz has joined #openstack-nova08:38
*** Tom___ has quit IRC08:43
*** rmcallis has quit IRC08:44
*** huanxie has quit IRC08:44
*** markvoelker has joined #openstack-nova08:45
*** derekh has joined #openstack-nova08:45
*** rmcallis has joined #openstack-nova08:46
*** namnh has joined #openstack-nova08:51
*** udesale has joined #openstack-nova08:53
*** rmcallis has quit IRC08:53
*** sdague has joined #openstack-nova08:54
*** Tom__ has joined #openstack-nova08:54
*** jichen has quit IRC08:55
*** Tom__ has quit IRC08:57
*** Tom__ has joined #openstack-nova08:57
*** lpetrut has joined #openstack-nova09:09
openstackgerritChen Hanxiao proposed openstack/python-novaclient master: inject file: add description of injecting multiple files.  https://review.openstack.org/51565509:10
*** slaweq has quit IRC09:16
*** slaweq has joined #openstack-nova09:17
*** markvoelker has quit IRC09:18
*** slaweq has quit IRC09:22
*** slaweq has joined #openstack-nova09:22
*** Tom__ has quit IRC09:24
openstackgerritStephen Finucane proposed openstack/nova master: conf: Remove 'vendordata_driver' opt  https://review.openstack.org/39783509:27
openstackgerritStephen Finucane proposed openstack/nova master: conf: Validate '[api] vendordata_providers' options  https://review.openstack.org/51331809:28
*** Tom__ has joined #openstack-nova09:28
*** Tom__ has quit IRC09:28
*** Tom__ has joined #openstack-nova09:29
stephenfinmikal: Could you have a look at https://review.openstack.org/#/c/513318 and the preceding patch?09:29
*** huanxie has joined #openstack-nova09:29
*** Tom__ has quit IRC09:33
*** thorst has joined #openstack-nova09:34
*** Lirt has joined #openstack-nova09:35
*** gcb has quit IRC09:37
*** rmart04 has quit IRC09:37
*** thorst has quit IRC09:39
*** links has quit IRC09:42
*** Laurene has quit IRC09:42
*** avolkov has quit IRC09:43
*** avolkov has joined #openstack-nova09:44
*** ratailor is now known as rtailor09:45
*** fragatina has joined #openstack-nova09:48
*** maciejjozefczyk has joined #openstack-nova09:52
*** slaweq_ has joined #openstack-nova09:52
*** dpawlik has joined #openstack-nova09:52
*** cdent has joined #openstack-nova09:53
openstackgerritRadoslav Gerganov proposed openstack/nova master: VMware: fix memory stats  https://review.openstack.org/51566609:54
*** slaweq has quit IRC09:54
*** danpawlik has quit IRC09:55
*** maciejjo1 has quit IRC09:55
openstackgerritYikun Jiang proposed openstack/python-novaclient master: Use utils.prepare_query_string instead of duplicated code  https://review.openstack.org/51564010:02
*** gmann is now known as gmann_afk10:02
*** kaisers1 has quit IRC10:05
*** psachin has quit IRC10:05
openstackgerritMerged openstack/nova master: Complete dostring of live_migration related methods  https://review.openstack.org/49080710:07
openstackgerritRadoslav Gerganov proposed openstack/nova master: VMware: implement get_inventory() driver method  https://review.openstack.org/50617510:13
*** kaisers has joined #openstack-nova10:14
*** markvoelker has joined #openstack-nova10:15
*** mhickey has quit IRC10:17
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: resolve the error of VM_MISSING_PV_DRIVERS for PV VM  https://review.openstack.org/51490210:19
*** yamamoto has joined #openstack-nova10:24
*** phuongnh has quit IRC10:24
*** andreas_s has quit IRC10:26
*** andreas_s has joined #openstack-nova10:27
*** namnh has quit IRC10:36
*** andreas_s has quit IRC10:37
*** andreas_s has joined #openstack-nova10:39
*** sridharg has joined #openstack-nova10:40
jianghuawbauzas, could you help to look at this patch? https://review.openstack.org/#/c/33920410:43
*** yamamoto has quit IRC10:45
*** markvoelker has quit IRC10:49
*** rtailor has quit IRC10:49
*** rmcallis has joined #openstack-nova10:49
*** andreas_s has quit IRC10:50
*** rmcallis has quit IRC10:54
*** andreas_s has joined #openstack-nova10:55
*** trungnv has quit IRC10:57
*** andreas_s has quit IRC11:01
*** rtailor has joined #openstack-nova11:02
*** andreas_s has joined #openstack-nova11:02
*** robcresswell has quit IRC11:03
*** annp has quit IRC11:03
*** yamamoto has joined #openstack-nova11:05
*** lucasagomes is now known as lucas-hungry11:07
*** andreas_s has quit IRC11:12
*** andreas_s has joined #openstack-nova11:13
*** rtailor has quit IRC11:15
*** smatzek has joined #openstack-nova11:15
*** andreas_s has quit IRC11:15
*** andreas_s has joined #openstack-nova11:16
*** vladikr has quit IRC11:17
*** yamamoto has quit IRC11:21
openstackgerritMerged openstack/python-novaclient master: Use generic user for both zuul v2 and v3  https://review.openstack.org/51251511:30
*** hamzy has joined #openstack-nova11:30
*** sdague has quit IRC11:31
*** sdague has joined #openstack-nova11:32
*** rtailor has joined #openstack-nova11:34
*** baoli has joined #openstack-nova11:34
*** trinaths has joined #openstack-nova11:35
*** thorst has joined #openstack-nova11:35
*** litao__ has quit IRC11:36
*** sdague has quit IRC11:37
*** rtailor has quit IRC11:37
*** baoli has quit IRC11:37
*** ratailor has joined #openstack-nova11:37
*** sdague has joined #openstack-nova11:38
*** trinaths has left #openstack-nova11:38
*** sdague has quit IRC11:38
*** baoli has joined #openstack-nova11:38
*** thorst has quit IRC11:40
*** sambetts|afk is now known as sambetts11:41
openstackgerritRadoslav Gerganov proposed openstack/nova master: VMware: implement get_inventory() driver method  https://review.openstack.org/50617511:42
*** nicolasbock has joined #openstack-nova11:43
*** belmoreira has joined #openstack-nova11:45
*** thorst has joined #openstack-nova11:46
*** sdague has joined #openstack-nova11:46
*** markvoelker has joined #openstack-nova11:46
*** yamamoto has joined #openstack-nova11:50
*** jpena is now known as jpena|lunch11:58
*** dtantsur|afk is now known as dtantsur11:58
*** ratailor has quit IRC11:58
*** jmccarthy has joined #openstack-nova11:58
*** ratailor has joined #openstack-nova11:58
*** yamamoto has quit IRC11:59
*** huanxie has quit IRC12:01
jmccarthyAny folks notice an issue where on a xen compute, in horizon, you may get a working console, or working console logging (depending on the instance you spin up) - but not both ?12:01
*** dillaman has joined #openstack-nova12:03
*** liverpooler has joined #openstack-nova12:05
*** pooja_jadhav has joined #openstack-nova12:07
*** bhagyashri_s has joined #openstack-nova12:07
*** abhishek_k has joined #openstack-nova12:08
*** nsingh has joined #openstack-nova12:08
*** abhishekk has quit IRC12:09
*** niraj_singh has quit IRC12:09
*** bhagyashris has quit IRC12:10
*** pooja-jadhav has quit IRC12:10
*** vks1 has quit IRC12:11
*** jaypipes has joined #openstack-nova12:12
*** yamamoto has joined #openstack-nova12:14
*** lucas-hungry is now known as lucasagomes12:14
*** ratailor has quit IRC12:17
*** markvoelker has quit IRC12:20
jaypipesbauzas, stephenfin, gibi: series starting at https://review.openstack.org/#/c/509027/ should be relatively easy reviews. just cleanups in the resource_provider.py module.12:25
*** markvoelker has joined #openstack-nova12:27
gibijaypipes: opening...12:28
*** StevenK has quit IRC12:29
*** rm_work has quit IRC12:29
*** rm_work has joined #openstack-nova12:30
*** rm_work has joined #openstack-nova12:30
*** baoli has quit IRC12:32
*** baoli has joined #openstack-nova12:37
*** StevenK has joined #openstack-nova12:41
*** jpena|lunch is now known as jpena12:50
*** pchavva has joined #openstack-nova12:50
*** lyan has joined #openstack-nova12:57
*** mdbooth has quit IRC12:58
gibijaypipes: what is the reason you pass a whole RP object to get_all_by_resource_provider ? It only uses the id of that RP today so it would be enough to pass that id.12:58
jaypipesgibi: because I don't then have to reconstruct a ResourceProvider object for each allocation record.12:58
*** ansiwen has quit IRC12:58
jaypipesgibi: and that would entail more joins and/or queries to the DB12:59
*** marst has joined #openstack-nova13:01
bauzasjianghuaw: jaypipes: I had a comment in https://review.openstack.org/#/c/339204/813:01
*** edleafe is now known as figleaf13:02
*** jaypipes is now known as leakypipes13:02
*** vvargaszte has joined #openstack-nova13:02
leakypipesbauzas: nice catch :)13:03
bauzasoh man, friday13:04
*** bauzas is now known as bauwser13:04
*** catintheroof has joined #openstack-nova13:04
gibileakypipes: I'm not sure we are looking at the same patch. I try to understand TraitList.get_all_by_resource_provider() here https://review.openstack.org/#/c/509027/5/nova/objects/resource_provider.py@228913:04
gibileakypipes: and I don't see how this connects to the allocation records you refer to13:05
leakypipesgibi: lol. sorry, thought you were referring to the AllocationList.get_all_by_provider()13:05
bauwserleakypipes: honestly, it's a known problem, and we should maybe discuss about how to modify the RC to use bytes and not GB but meh13:05
bauwserchanging that should be a very huge modification unfortunately13:05
leakypipesgibi: I have no idea why that isn't get_by_provider_id()...13:06
leakypipesgibi: lemme fix.13:06
openstackgerritHironori Shiina proposed openstack/nova-specs master: Ironic: Resize and cold migration support  https://review.openstack.org/44915513:06
leakypipesgibi: might just be copy-pasta13:06
gibileakypipes: thanks13:07
leakypipesgibi: sorry about that!13:07
*** naichuans has quit IRC13:07
gibileakypipes: no problem13:08
leakypipesgibi: although...13:08
leakypipesgibi: based on the commit message13:08
*** udesale has quit IRC13:08
leakypipesgibi: looks like this was intentional to make the calling interfaces consistent13:09
leakypipesgibi: from the commit message:13:09
leakypipesIn following patches, I change similar method on List objects like UsageList.get_all_by_resource_provider_uuid() and AllocationList.get_all_by_resource_provider_uuid() to match this new pattern of get_all_by_resource_provider() and passing in a ResourceProvider object.13:09
*** baoli has quit IRC13:09
leakypipesgibi: those "following patches" were re-ordered and are actually already merged.13:09
gibileakypipes: that removes some of my confusion :) anyhow if there is pattern and it is intentional then I'm OK with it13:10
leakypipesgibi: so, long story short, I did it for consistency with the other calls13:10
gibileakypipes: make sense now, thanks for the explanation13:11
*** efried is now known as fried_rice13:14
*** andreas_s has quit IRC13:15
*** gibi is now known as pow_2_3013:17
*** mriedem has joined #openstack-nova13:18
* pow_2_30 joining to the Friday naming trends13:19
*** andreas_s has joined #openstack-nova13:19
*** mdbooth has joined #openstack-nova13:21
*** ansiwen has joined #openstack-nova13:21
*** vks1 has joined #openstack-nova13:22
*** andreas_s has quit IRC13:25
*** andreas_s has joined #openstack-nova13:25
*** hemna_ has joined #openstack-nova13:25
belmoreiramriedem, dansmith I continue to test how to migrate from newton to ocata with cellsV113:25
belmoreiraIf I have multiple nova_api(s) DBs/placements I will need to merge the allocation tables when moving to pike and cellsV213:26
belmoreiraThis is not easy to achieve because "allocations" table uses the "resource_provider_id" instead "resource_provider_uuid"13:26
jmccarthyQuestion about using libvirt + xen on xen compute, anyone familiar  with how to get changes to 'stick' when virsh editing the xml ? I'm  trying to add another serial device to file, for console logging for  example: http://paste.openstack.org/show/624831/13:26
belmoreiraThere is any way to recreate the "allocations" table from scratch when I'm in pike?13:26
jmccarthy(I have what is on the right, but I think I need what is on the left)13:26
mriedembelmoreira: would likely have to write a tool to migrate the entries out of the separate placement/api db's into the global one when you upgrade13:27
mriedemwe mentioned this as one of the trade offs the other day of doing placement per cell for now13:27
*** artom has quit IRC13:28
*** claudiub has joined #openstack-nova13:28
dansmithwhat mriedem said13:28
*** artom has joined #openstack-nova13:28
dansmithbelmoreira: the use of integer ids is for performance there13:28
*** hieulq has quit IRC13:29
*** tbachman has joined #openstack-nova13:29
mriedembauwser: what is your -1 for specifically on this? https://review.openstack.org/#/c/515530/13:30
*** dansmith is now known as superdan13:30
*** claudiub|2 has quit IRC13:31
bauwsermriedem: on a meeting13:31
*** sheel has joined #openstack-nova13:32
*** mhickey has joined #openstack-nova13:33
*** catintheroof has quit IRC13:34
fried_ricemriedem superdan Can we please move the ksa adapter series along a little bit?  It's been stagnating.  Here's one that involves placement https://review.openstack.org/#/c/492247/ -- sdague was +2 6 weeks ago and no actual changes since.13:34
*** janki has quit IRC13:37
sdaguefried_rice: it has a gerrit cannot merge on it atm13:37
fried_ricesdague Aaargh, missed that.13:37
fried_ricerebasing...13:37
* mriedem stops reviewing13:37
superdanalso, I'm not really the best person to look at that13:37
superdanprobably mriedem and sdague though13:37
mriedemfried_rice: you're just doing all of these separately right?13:38
mriedemfor some reason i thought they were all lined up behind the glance one, which looked scary13:38
fried_ricemriedem Yes13:38
fried_ricemriedem Oh, some of them are lined up behind the glance one.13:38
fried_riceBut this one isn't.13:38
*** vvargaszte has quit IRC13:40
*** esberglu has joined #openstack-nova13:40
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements  https://review.openstack.org/49314613:41
sdaguerealized that after going from Ubuntu Unity -> Gnome 3 in 17.10, I lost my mechanism of knowing people had pinged me on irc. Think I got a solution for that today. Which hopefully means noticing when mriedem pokes at me13:41
*** catintheroof has joined #openstack-nova13:42
*** mlavalle has joined #openstack-nova13:43
belmoreiramriedem, dansmith in newton when placement is enabled the resource_providers/allocations tables are populated. This doesn't happen for pike. Could this be achieved somehow? would be better than having a tool to merge the dbs13:43
mriedembelmoreira: once all computes are upgraded to pike, the compute resource tracker stops reporting allocations in the update_available_resource periodic task13:44
mriedemon purpose,13:44
mriedembecause in pike the scheduler creates allocations during create and move operations like migrate,13:44
mriedemand the ocata computes would overwrite the allocations created by the pike scheduler13:44
superdanwhat mriedem said again :)13:46
superdanbelmoreira: I think we should probably be on the hook to help with said merging tool because you won't be the only one that needs it13:47
*** abhishek_k has quit IRC13:48
openstackgerritEric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests  https://review.openstack.org/49224713:49
fried_ricesdague mriedem ^13:49
mriedemsuperdan: is there any specific reason that nova.objects.base.obj_to_primitive doesn't convert datetimes to primitives?13:49
*** spectr has quit IRC13:49
superdanmriedem: um13:49
belmoreiramriedem if in ocata the resource tracker still reports the allocations, means that in my upgrade procedure I move to the global placement just before upgrade to pike. In that case I would not need to merge the dbs.13:49
mriedembelmoreira: so you're going to update nova.conf on all of the computes to point at global placement, take down the control plane and wait for the periodic task to do the inventory and allocation population?13:51
mriedems/control plane/api13:51
mriedembelmoreira: to be clear, the resource tracker will continue to update allocations in placement as long as there is at least 1 <pike compute13:51
superdanoh _that_ obj_to_primitive13:52
mriedemit's just once all computes are >= pike we stop doing that13:52
mriedemsuperdan: yeah i expected that to turn the entire object and it's fields into primitives13:52
superdanmriedem: that is really obj_to_dict() for doing unholy things.. it doesn't serialize an object13:52
mriedemok - was trying to figure out why we needed this https://review.openstack.org/#/c/515539/1/nova/scheduler/utils.py@a8313:52
mriedemwhen we had already converted objects to primitives above13:52
mriedemguess it's not what i thought it was13:53
*** awaugama has joined #openstack-nova13:53
mriedemlike the bears in that cardinals game in the late 90s13:53
mriedemwith the dennis green post-game conference13:53
mriedemleakypipes: ^13:53
superdanbecause someone wants a dict that looks like the object, probably for compat13:53
*** dave-mccowan has joined #openstack-nova13:53
superdanI would confirm, but a83 is not a line number13:53
mriedemit's the left side of the diff13:54
*** pooja-jadhav has joined #openstack-nova13:54
belmoreiramriedem yes, and then upgrade control plane/compute nodes to pike, and do the cellsV2 mappings. All of this in downtime of course. maybe it will be more error prone and easier than the DB merging13:54
*** sree has quit IRC13:54
mriedembelmoreira: "less" error prone?13:54
superdanoh sure enough13:55
*** niraj_singh has joined #openstack-nova13:55
mriedemok i'll just return the to_primitive call with a note13:55
*** sree has joined #openstack-nova13:55
belmoreiras/more/less :)13:55
*** pooja_jadhav has quit IRC13:55
*** bhagyashris has joined #openstack-nova13:55
*** nsingh has quit IRC13:55
leakypipesmriedem: not sure why the jsonutils call is there :(13:56
*** owalsh has quit IRC13:56
*** bhagyashri_s has quit IRC13:56
*** arxcruz is now known as arxcruz|pto13:56
superdanbelmoreira: the merging should be easy I would think.. tbh that seems less concerning that running ocata computes for a period of time to build new placement data, but it's your call.. I assume you'll test it13:56
mriedemleakypipes: i meant the football reference!13:56
mriedemi need at least one football person in this channel13:56
mriedemclarkb:13:57
leakypipesmriedem: sorry, you lost me at hello on that one.13:57
superdanmriedem: I'm still a big confused, because that's jsonutils, not obj_to_primitive13:57
mriedemsuperdan: i removed the jsonutils.to_primitive becaues it's calling that on a request_spec dict, which i thought had already-serialized items in it,13:57
mriedembecause of the obj_to_primitive calls that happen above for the instance and flavor13:57
mriedemso i thought it was a redundant call and removed it13:58
mriedemleakypipes: https://www.youtube.com/watch?v=SWmQbk5h86w13:58
superdanmriedem: oh I see.. dear god13:58
superdanmriedem: those are dictified instance and flavor not a serialized instance13:58
mriedemlet'em off the hook jay13:58
leakypipesmriedem: :) ok, gotcha now.13:59
superdanI think what we've learned here is that football references have no place in a nerd hangout13:59
openstackgerritMatt Riedemann proposed openstack/nova master: Cleanup build_request_spec  https://review.openstack.org/51553913:59
*** owalsh has joined #openstack-nova13:59
*** sree has quit IRC14:00
leakypipessuperdan: a lesson learned. it's a game of inches. sometimes you just need to go for it on fourth and ten.14:01
belmoreirasuperdan if the data it's correctly recreated I would prefer to let the resource tracker do it. At the end should be faster than all the work required for the DB merging. Yes, I will test and let you know. Thanks14:01
*** gouthamr has joined #openstack-nova14:01
*** baoli has joined #openstack-nova14:01
mriedemleakypipes: pretty risky unless you're in the red zone under the 2 minute warning and behind by over 314:03
mriedemthen you have no choise14:03
mriedem*choice14:03
*** lyan has quit IRC14:03
*** Dinesh_Bhor has quit IRC14:04
*** vladikr has joined #openstack-nova14:04
leakypipesmriedem: right. though that's just a hail-mary pass to superdan at that point.14:04
* superdan runs screaming from the ball14:04
mriedembelmoreira: ok - the key thing being that you leave one compute at ocata until all of the other pike computes have reported their information14:05
mriedembelmoreira: and you'd need some tooling to verify that is done, like querying placement for all active instances to make sure they show up with allocations14:06
*** andreas_s has quit IRC14:06
belmoreiramriedem ok. thanks14:08
bauwsermriedem: https://review.openstack.org/#/c/515530/2/nova/conductor/manager.py@831 are you sure we can't have a rebuild where host=None ? I thought it was14:09
*** lyan has joined #openstack-nova14:09
mriedembauwser: not for "rebuild"14:09
bauwsermmmm14:09
bauwserokay, then nevermind my -1, I'll changeit14:09
*** spectr has joined #openstack-nova14:09
mriedembauwser: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L294814:09
mriedemrebuild wants to bypass the scheduler14:09
*** andreas_s has joined #openstack-nova14:10
bauwserthat was my only concern, I was wanting to make sure that we were rebuilding by using the right image, which is image_ref14:10
bauwserI mean, the target image14:10
mriedemsee the plethora of comments in the rebuild_intsance method i added recently about all of the fun conditionals and in what cases we get there from the voodoo in the api14:10
bauwseryeah14:10
mriedembauwser: yeah that's a long-standing bug14:10
mriedem"new image for rebuild!? sure, what the hell, we trust you!"14:10
bauwseryeah :(14:11
bauwserI thought we were checking the image even for a rebuild14:11
bauwserthe evacuate is a special case because we can pass a destination as a target on the CLI14:11
bauwserwhile rebuild is not14:11
mriedemhttps://bugs.launchpad.net/nova/+bug/166766714:12
openstackLaunchpad bug 1667667 in OpenStack Compute (nova) "Rebuilding instance ignores image's property hw_disk_bus" [Low,In progress] - Assigned to 赵明俊 (falseuser)14:12
bauwserI wonder what a true use ris14:12
bauwseruser is*14:12
*** amodi has joined #openstack-nova14:12
bauwserwait, you said we use instance.host right?14:12
mriedembauwser: for "rebuild"14:12
mriedemyes14:12
bauwserso, we're *always* rebuilding on the same host ?14:12
mriedemfor "rebuild" yes14:12
bauwserWAAAAAAAAT14:13
bauwsera world is failling down to me14:13
mriedemrebuild != evacuate14:13
bauwserthat I know14:13
bauwserI just thought we were just finding another host unless you allow the rebuild on the same host14:13
*** claudiub has quit IRC14:13
mriedemthat wasn't the bug, it was this one https://bugs.launchpad.net/nova/+bug/166493114:13
openstackmriedem: Error: malone bug 1664931 not found14:13
*** andreas_s has quit IRC14:14
*** andreas_s has joined #openstack-nova14:14
* bauwser has headache14:14
*** andreas_s has quit IRC14:14
*** hongbin has joined #openstack-nova14:15
*** andreas_s has joined #openstack-nova14:15
*** Tom___ has joined #openstack-nova14:16
bauwsermriedem: okay, looks like I just forgot14:16
bauwsermriedem: then, we need to tackle ^14:16
bauwserthe patch is still valid in my mind14:16
*** armax has joined #openstack-nova14:17
*** ratailor has joined #openstack-nova14:17
mriedemfried_rice: sdague: https://review.openstack.org/#/c/492247/14:17
fried_ricemriedem These get handled by passing them to KSA.14:19
fried_ricemriedem But I'll see if cfg.DeprecatedOpt has a way for me to fill out 'since' and 'reason'.14:19
mriedemfried_rice: the options themselves aren't called out as deprecated,14:19
mriedemor when they were deprecated14:19
*** andreas_s has quit IRC14:19
mriedemfried_rice: you'd mark the nova opts as deprecated14:19
mriedemin their definition14:19
mriedemas normal14:19
*** dave-mccowan has quit IRC14:20
fried_riceah, okay, will do.14:20
mriedembut, i'm not done with this review yet,14:20
mriedemso hold up14:20
* leakypipes grabs food14:21
openstackgerritBalazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data  https://review.openstack.org/45281814:22
openstackgerritBalazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2)  https://review.openstack.org/45281914:22
openstackgerritBalazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples  https://review.openstack.org/45282014:22
openstackgerritBalazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples  https://review.openstack.org/47586014:22
*** rmart04 has joined #openstack-nova14:22
openstackgerritMerged openstack/nova-specs master: Remove barbican from scope of ksa adapter work  https://review.openstack.org/51152414:23
*** jmccarthy has left #openstack-nova14:26
*** felipemonteiro_ has joined #openstack-nova14:26
openstackgerritJianghua Wang proposed openstack/nova master: rt: Implement XenAPI get_inventory() method  https://review.openstack.org/33920414:27
jianghuawbauzas, leakypipes: ^14:28
mriedemfried_rice: ok comments inline14:29
fried_ricemriedem Thanks14:29
*** baoli has quit IRC14:29
jianghuawbauzas, thanks for spotting the issue.14:29
*** felipemonteiro__ has joined #openstack-nova14:32
openstackgerritMerged openstack/nova master: Convert IVS VIF plugging / unplugging to privsep.  https://review.openstack.org/51519614:32
openstackgerritBalazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data  https://review.openstack.org/45281814:34
openstackgerritBalazs Gibizer proposed openstack/nova master: Factor out duplicated notification sample data (2)  https://review.openstack.org/45281914:34
openstackgerritBalazs Gibizer proposed openstack/nova master: Deduplicated instance.(un)pause notification samples  https://review.openstack.org/45282014:34
openstackgerritBalazs Gibizer proposed openstack/nova master: Deduplicate instance.power-off notification samples  https://review.openstack.org/47586014:34
*** baoli has joined #openstack-nova14:35
*** felipemonteiro_ has quit IRC14:36
*** spectr has quit IRC14:39
*** Lirt has quit IRC14:40
*** baoli has quit IRC14:42
openstackgerritMerged openstack/nova master: Make migration uuid hold allocations for migrating instances  https://review.openstack.org/50642014:42
bauwserjianghuaw: friday nick FWIW14:43
*** andreas_s has joined #openstack-nova14:45
*** baoli has joined #openstack-nova14:45
*** josecastroleon has quit IRC14:46
openstackgerritEric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests  https://review.openstack.org/49224714:47
fried_ricemriedem See if those responses make sense ^14:47
*** baoli has quit IRC14:48
openstackgerritMerged openstack/nova master: rp: Remove RP.get_traits() method  https://review.openstack.org/50902714:48
*** andreas_s has quit IRC14:51
*** andreas_s has joined #openstack-nova14:52
*** andreas_s has quit IRC14:57
*** Tom___ has quit IRC14:57
*** ijw has joined #openstack-nova15:01
*** ijw_ has joined #openstack-nova15:02
fried_riceleakypipes superdan https://review.openstack.org/#/c/499826/ please if you have a sec.  (I'm trying to win cdent's prize.)  (And the race to 1.11.)15:03
*** marst has quit IRC15:06
*** ijw has quit IRC15:06
*** marst has joined #openstack-nova15:06
*** mdnadeem has quit IRC15:06
*** rmart04 has quit IRC15:06
*** baoli has joined #openstack-nova15:07
jianghuawbauwser, thanks:-)15:07
*** belmoreira has quit IRC15:09
*** coreywright has quit IRC15:10
*** mdnadeem has joined #openstack-nova15:10
*** dave-mccowan has joined #openstack-nova15:11
leakypipesfried_rice: I'm trying to win the same prize :)15:11
fried_riceleakypipes Oh, if that de-orm stuff counts, you're gonna win.15:12
leakypipesfried_rice: damn it.15:12
leakypipesfried_rice: nah, the n-r-p series adds 1.1115:12
leakypipesit's ok, though. I can rebase easy enough.15:12
fried_riceleakypipes Yeah, we had like seven different 1.11 patches in flight.15:12
leakypipesyeah it's cool :)15:13
leakypipesI mean.. cool as in I know we did :)15:13
leakypipesnot that I relish rebasing15:13
fried_riceleakypipes It made me think there ought to be a way to automate it.  But that way lies madness.15:13
*** AlexeyAbashkin has quit IRC15:13
leakypipesfried_rice: indeed15:13
*** yamahata has joined #openstack-nova15:14
*** jmlowe_ has joined #openstack-nova15:14
mriedemfried_rice: you didn't update the placement api-ref https://review.openstack.org/#/c/499826/15:15
mriedemtime to -1?15:15
fried_ricemriedem I thought it was because that guy already documented the missing link15:15
*** hemna_ has quit IRC15:15
cdentle sigh. so much rebase.15:16
*** sree has joined #openstack-nova15:16
*** jmlowe has quit IRC15:16
mriedemhttps://developer.openstack.org/api-ref/placement/#id2 ?15:16
fried_ricemriedem Yeah, not.15:16
mriedemfried_rice: just roll it on top15:16
mriedembut know that i'm watching, always watching15:16
fried_ricemriedem Will do.15:16
leakypipesthat reminds me I need to update the n-r-p REST API patch to amend the devref docs15:17
fried_ricemriedem leakypipes I *was* thinking there should be some kind of "add a microversion checklist" internal doc for devs.15:17
mriedemfried_rice: there are docs on adding microversions,15:17
mriedemfor both compute and placement15:17
*** links has joined #openstack-nova15:19
mriedemfried_rice: this is the doc for compute microversions https://docs.openstack.org/nova/pike/contributor/microversions.html15:21
*** dave-mccowan has quit IRC15:21
mriedemfried_rice: maybe add something here? https://docs.openstack.org/nova/pike/contributor/microversions.html#other-necessary-changes15:21
fried_ricemriedem Remind me where the source for the api-ref docs is?15:21
mriedemand this for placement https://docs.openstack.org/nova/pike/contributor/placement.html#microversions15:21
mriedemnova/api-ref?15:22
mriedemnova/placement-api-ref15:22
*** armax_ has joined #openstack-nova15:22
*** salv-orlando has quit IRC15:22
bauwsermriedem, sdague: crazy thoughts, could we just get rid of block_device_mapping.device_name as an API param ?15:22
*** armax has quit IRC15:22
*** armax_ is now known as armax15:22
openstackgerritBalazs Gibizer proposed openstack/nova master: Deduplicate instance.interface_attach samples  https://review.openstack.org/51574015:23
*** salv-orlando has joined #openstack-nova15:23
mriedembauwser: i already tried15:23
bauwsermriedem, sdague: it's not like we can pretend it works15:23
bauwsermriedem: the fun part of that is OSC https://github.com/openstack/python-openstackclient/blob/e0d7119c6dcba5666f2a0916b9a6e347e2e2758c/openstackclient/compute/v2/server.py#L62115:23
mriedembauwser: https://review.openstack.org/#/c/452546/15:23
*** coreywright has joined #openstack-nova15:23
*** yamamoto has quit IRC15:24
* bauwser sighes15:24
*** slaweq_ has quit IRC15:25
*** salv-orlando has quit IRC15:27
*** andreas_s has joined #openstack-nova15:27
leakypipesfried_rice, mriedem: I'm just going to wait on updating the REST API n-r-p patch to update the placement-api-ref until fried_rice's patch lands, since I'm gonna need to change to 1.12 anyway.15:28
fried_riceack15:28
bauwsermriedem: not fully understanding the problem with device names that feodor is mentioning15:28
openstackgerritBalazs Gibizer proposed openstack/nova master: Deduplicate instance.live_migration notification samples  https://review.openstack.org/51574515:29
bauwsermriedem: oh they somehow want some way to identify which BDM to update15:29
bauwserdon't BDMs have UUIDs ?15:30
mriedembauwser: not yet15:30
mriedembauwser: but mdbooth is adding them in i think15:30
*** itlinux has joined #openstack-nova15:30
*** itlinux has quit IRC15:30
bauwsermriedem: so that would solve the problem IMHO15:31
*** andreas_s has quit IRC15:31
*** mdnadeem has quit IRC15:31
mdboothbauwser: Indeed I will add BDM uuids.15:33
mriedembauwser: idk, it15:33
*** awaugama has quit IRC15:33
mriedemit's been a long time since i had ftersin's bfv issue in my head15:33
mriedembut it was something for ec2 of course15:33
mdboothbauwser: I was thinking during our call earlier, btw, that device names in the context of the api do mean something, just not really what people think.15:33
*** rabel has joined #openstack-nova15:33
mdboothWhich looks like what I wrote in that review ages ago that I'd completely forgotten about.15:34
mdboothi.e. 'sda' means 'the first disk on a scsi bus'15:34
mdboothIt *doesn't* mean that your linux OS will create it as /dev/sda, though15:35
*** mwynne has quit IRC15:35
bauwsermdbooth: right, it's an identifier15:35
mdboothtags mean something specific15:35
bauwsermdbooth: but for the worst, we decided that this identifier should look like a device name, which is IMHO the worst terrible idea15:36
rabelHi there, can we merge https://review.openstack.org/#/c/494169/ now? I think it is really ready by now.15:36
mdboothuuids would also mean something specific, although I don't have any plans to expose them to the user explicitly15:36
bauwsermdbooth: looks to me it's a cinder problem15:36
mdboothbauwser: Yes, agreed.15:36
mdbooth... but not to cinder ...15:37
bauwsermdbooth: if you need something to tag your volumes, it's cinder, not nova15:37
mdboothHow's it a cinder thing?15:37
mdboothNah, that's totally a Nova thing15:37
*** andreas_s has joined #openstack-nova15:37
mdboothCinder just gives us a repository of bits. It's entirely Nova's domain how that's presented to the guest.15:37
bauwsermdbooth: what is the purpose of tagging that?15:38
bauwserI'm surely not getting the full picture, but I don't get why I need to keep information on how my volume is presented to the guest15:39
mdboothDevice tagging? It's so the guest OS can identify specific devices which were specified by the api.15:39
bauwsermdbooth: oh, but that's a totally different problem15:39
bauwsermdbooth: and surely device names don't solve it15:39
bauwsermdbooth: if you need some device tagging like we did for NICs, I understand that's a nova problem15:40
mdboothDevice tagging is a much, much better way to solve the same problem.15:40
bauwserI just don't understand why it blocks us to get rid of device names15:40
bauwserbecause device names wasn't helping to solve the problem you mention on the guest side15:40
bauwserit's even worst : you think it will help15:41
bauwserby 'you', I mean the application developer15:41
bauwserso for example, I'm a user15:41
*** sheel has quit IRC15:41
bauwserI'm using device names because I think it will give me a way to know which device I'm getting on the guest side15:42
bauwserguess what ? It doesn't work15:42
bauwserlike I said to you in our meeting, I played with it in Essex15:42
bauwserand Folsom15:42
bauwsertotally a mess15:42
openstackgerritEric Fried proposed openstack/nova master: Update placement api-ref: allocations link in 1.11  https://review.openstack.org/51574815:43
bauwserI learned hard that device names weren't a firm contract15:43
fried_ricemriedem leakypipes ^ I didn't bother to base it on the one in the gate; should I?15:43
leakypipesfried_rice: I don't personally mind if mriedem is cool with that15:43
mriedemadd a depends-on at least15:45
leakypipesfried_rice: +2 from me.15:45
leakypipesfried_rice: good point from mriedem on the depends-on15:45
*** andreas_s has quit IRC15:46
*** andreas_s has joined #openstack-nova15:47
openstackgerritEric Fried proposed openstack/nova master: Update placement api-ref: allocations link in 1.11  https://review.openstack.org/51574815:47
fried_riceleakypipes mriedem depends-on ^15:47
mdboothbauwser: Was just reading that review back. I've evicted that context from my mental cache ;)15:47
mdboothbauwser: Sounds like the issue was that there's an existing useful interaction with image-defined bdms15:48
*** jaosorior has quit IRC15:48
mdboothWithout more spelunking, though, I don't recall what that interaction is15:48
*** tssurya has quit IRC15:49
*** BenderRodriguez has joined #openstack-nova15:49
*** BenderRodriguez has quit IRC15:49
*** BenderRodriguez has joined #openstack-nova15:49
mdboothIf that were the case, though, bdm uuids wouldn't be a replacement.15:49
mdbooth...but device tags could be15:51
openstackgerritBalazs Gibizer proposed openstack/nova master: Deduplicate instance.reboot notification samples  https://review.openstack.org/51575115:51
*** derekh has quit IRC15:52
*** andreas_s has quit IRC15:52
*** andreas_s has joined #openstack-nova15:53
fried_ricesdague FYI, I think there's still something wrong with that cinder patch.  I should -W it.15:55
*** sree has quit IRC15:55
*** sree has joined #openstack-nova15:55
*** trinaths has joined #openstack-nova15:55
*** itlinux has joined #openstack-nova15:57
*** artom has quit IRC15:58
leakypipesrabel: reviewed.15:59
*** sree has quit IRC16:00
rabelleakypipes: thank you16:00
*** yamamoto has joined #openstack-nova16:01
*** andreas_s has quit IRC16:02
*** lpetrut has quit IRC16:03
*** Apoorva has joined #openstack-nova16:03
*** dave-mccowan has joined #openstack-nova16:04
*** andreas_s has joined #openstack-nova16:04
*** fried_rice has quit IRC16:05
*** ratailor has quit IRC16:06
cdentleakypipes: see my response on https://review.openstack.org/#/c/510626/ for why project_id and user_id was not added on /rp/u/allocations _now_16:09
*** sridharg has quit IRC16:10
*** lucasagomes is now known as lucas-afk16:13
*** andreas_s has quit IRC16:14
*** andreas_s has joined #openstack-nova16:16
*** hemna_ has joined #openstack-nova16:18
*** fried_rice has joined #openstack-nova16:18
*** ijw_ has quit IRC16:18
*** robcresswell has joined #openstack-nova16:19
jianghuawleakypipes, bauwser: I have a question about vGPU's inventory update. it invoking get_inventory() when compute_node is changed: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L80716:19
jianghuawBut for vGPU, we only report it via inventory no new fields saved in obj of compute_node.16:20
*** andreas_s has quit IRC16:21
*** artom has joined #openstack-nova16:21
jianghuawI see there is inventory caching in resource provider tree. and a new function update_inventory() is implemented.16:22
jianghuawBut I assume that's only for nest-RP. right?16:22
openstackgerritDavid Rabel proposed openstack/nova master: VMware: add support for graceful shutdown of instances  https://review.openstack.org/49416916:23
*** catintheroof has quit IRC16:23
*** salv-orlando has joined #openstack-nova16:23
*** jmlowe_ has quit IRC16:23
*** andreas_s has joined #openstack-nova16:23
jianghuawleakypipes, bauwser: I think our plan is to implement vGPU by associate the inventory on compute node as the first step. so not depending on the n-r-p.16:24
jianghuawthen how to trigger the inventory update without resource provider tree?16:25
*** dave-mccowan has quit IRC16:26
*** catintheroof has joined #openstack-nova16:27
bauwserjianghuaw: see my libvirt change16:27
bauwserjianghuaw: I'm hoping to push a new revision by tonight16:27
*** salv-orlando has quit IRC16:27
*** andreas_s has quit IRC16:28
jianghuawis this already included in the existing patch? bauwser16:29
*** andreas_s has joined #openstack-nova16:29
jianghuawor will be in the new revision?16:29
rabelleakypipes: is the new patchset ok?16:30
jianghuawbauwser, I didn't see that part in https://review.openstack.org/#/c/51476316:30
*** jamesden_ has joined #openstack-nova16:32
*** jamesdenton has quit IRC16:32
*** catintheroof has quit IRC16:35
jianghuawbauwser, I was thinking we should make it to invoke get_inventory regardless compute_node changed or not. caching inventory locally; and update inventory to placement if inventory changed.16:35
*** dtantsur is now known as dtantsur|afk16:36
*** catintheroof has joined #openstack-nova16:36
jianghuawbauwser, Good to know you've already considered it.16:36
*** shvepsy has quit IRC16:37
*** shvepsy has joined #openstack-nova16:37
*** links has quit IRC16:38
*** catintheroof has quit IRC16:39
*** rabel has quit IRC16:39
*** catintheroof has joined #openstack-nova16:39
*** andreas_s has quit IRC16:40
jianghuawleakypipes, bauwser, superdan: it's appreciated if you can have a look at this patch for get_inventory in XenAPI: https://review.openstack.org/#/c/339204/16:40
jianghuawhope it be an easy one:-)16:40
leakypipesjianghuaw: will do shortly. on phone right now.16:40
jianghuawleakypipes, thanks:-)16:41
*** sambetts is now known as sambetts|afk16:41
*** ttsiouts has quit IRC16:43
leakypipescdent: yes, that makes sense.16:45
bauwserjianghuaw: sorry, I was super busy prepping the new rev16:47
bauwserjianghuaw: so, basically, we have the same problem with libvirt16:47
bauwserjianghuaw: for example, we have a list of supported types16:47
bauwserjianghuaw: then, the operator selects a specific type16:48
bauwser(if you see my change, we only support one)16:48
bauwserjianghuaw: so, the inventory is saying N+M16:48
bauwserwhere N is the allocatable mdevs, and M is the already allocated ones16:48
bauwserif the operator modifies that, then it's creating a problem because when you create a mdev by a type, the other types for the same device are getting 0 allocable mdevs16:49
*** dave-mccowan has joined #openstack-nova16:50
*** andreas_s has joined #openstack-nova16:51
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: libvirt: Provide VGPU inventory for a single GPU type  https://review.openstack.org/51476316:51
bauwserjianghuaw: new revision ^16:51
jianghuawyes. I see. It can't create mdev for the other types once created a specific type of mdev.16:51
jianghuawlooking at it16:51
*** AlexeyAbashkin has joined #openstack-nova16:53
jianghuawbauwser, no. my problem is different: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L80716:53
jianghuawit will return if the compute_node resource is not changed.16:53
jianghuawbauwser, at the moment it only compare some resource fields of compute-node's: e.g. vcpu, memory.16:54
bauwserjianghuaw: so, what's your concern ?16:54
*** Guest40670 has quit IRC16:55
jianghuawthe vGPU resource is not saved in compute-node. so my concern is the vGPU inventory may be not be updated if the other resource is not changed.16:55
bauwsera-ja16:56
*** andreas_s has quit IRC16:56
jianghuawbauwser, as vGPU is only reported by get_inventory()16:56
*** AlexeyAbashkin has quit IRC16:57
bauwserjianghuaw: right, good point16:57
bauwserjianghuaw: so we should somehow signal those the old way16:57
*** andreas_s has joined #openstack-nova16:58
bauwsernot saying to add the VGPU resources in the Computenode object :)16:58
bauwserjust having a way to signal it thru update_available_resources16:58
openstackgerritEric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests  https://review.openstack.org/49224716:58
bauwseror other way, I dunno16:58
bauwserI need to think about it16:58
jianghuawI see. what I was thinking is to invoked always get_inventory().16:59
*** mhickey has quit IRC16:59
jianghuawbut I'm not sure if that's acceptable.16:59
*** ralonsoh has quit IRC17:00
jianghuawbauwser, here it defines update_inventory https://github.com/openstack/nova/blob/master/nova/compute/provider_tree.py#L23317:01
bauwserjianghuaw: one way to see that is that we could call get_inventory() first, pass it to _resource_change, keep it in memory and compare it at the next _resource_change run17:02
jianghuawbut it requires some way to determine how and when to get the new inventory.17:02
bauwserbecause _resource_change is just for making sure we don't update the DB every 60 secs17:02
*** dave-mccowan has quit IRC17:03
openstackgerritMerged openstack/nova master: rp: move RP._set_traits() to module scope  https://review.openstack.org/50902817:03
*** dave-mccowan has joined #openstack-nova17:03
bauwserjianghuaw: for Queens, I really would like my series to not be depending on n-r-p17:03
*** fragatina has quit IRC17:03
*** trinaths has left #openstack-nova17:03
jianghuawbauwser, the n-r-p seems in good progress. isn't it?17:04
jianghuawmaybe we can use n-r-p?17:04
*** Matias has joined #openstack-nova17:05
*** andreas_s has quit IRC17:07
jianghuawbauwser, anyway I also agree that passing it to _resource_change looks like a good solution.17:07
*** rmcallis has joined #openstack-nova17:07
bauwserjianghuaw: I can write that change17:07
jianghuawI'd like to see the viewpoint from leakypipes also.17:08
bauwserI need to dinner, but I'd be around by the next 2 hours17:08
jianghuawbauwser, yes you can go ahead with the change.17:08
bauwserjianghuaw: which TZ are you in ?17:08
jianghuawI'm in China.17:09
*** vladikr has quit IRC17:09
jianghuawso 1:09 am:-)17:09
jianghuawplease go ahead with your dinner. We can chat further on next Monday.17:09
jianghuaw:-)17:10
*** andreas_s has joined #openstack-nova17:13
bauwser++17:13
*** yamamoto has quit IRC17:13
bauwserjianghuaw: and go to bed17:13
bauwser!17:13
*** awaugama has joined #openstack-nova17:13
jianghuawbauwser, cheers. wish you a nice weekend:-)17:14
openstackgerritEric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs  https://review.openstack.org/51515117:16
openstackgerritEric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec}  https://review.openstack.org/51522317:16
jianghuawbauwser, when you come back, hope you have seconds to look at this patch for get_inventory in xenapi: https://review.openstack.org/#/c/33920417:18
*** jpena is now known as jpena|off17:19
jianghuawbauwser, also I have a patching to report vGPU resources from XenAPI: https://review.openstack.org/#/c/512965/17:19
*** andreas_s has quit IRC17:19
jianghuawI'm preparing another patch to create vGPU inventory.17:20
*** yamamoto has joined #openstack-nova17:21
*** fragatina has joined #openstack-nova17:21
*** aarefiev is now known as aarefiev_afk17:21
openstackgerritEd Leafe proposed openstack/nova master: Only filter/weigh hosts once if scheduling a single instance  https://review.openstack.org/51393117:24
openstackgerritEd Leafe proposed openstack/nova master: Add Selection objects  https://review.openstack.org/49923917:24
openstackgerritEd Leafe proposed openstack/nova master: Return Selection objects from the scheduler driver  https://review.openstack.org/49585417:24
openstackgerritEd Leafe proposed openstack/nova master: Change RPC for select_destinations()  https://review.openstack.org/51015917:24
openstackgerritEd Leafe proposed openstack/nova master: Move the claim_resources method to scheduler utils  https://review.openstack.org/51135717:24
openstackgerritEd Leafe proposed openstack/nova master: Make conductor pass and use host_lists  https://review.openstack.org/51135817:24
*** awaugama has quit IRC17:26
*** gszasz has quit IRC17:27
*** itlinux has quit IRC17:28
*** Swami has joined #openstack-nova17:29
*** sapcc-bot has quit IRC17:29
*** mkoderer_ has joined #openstack-nova17:29
*** sapcc-bot has joined #openstack-nova17:29
*** dave-mccowan has quit IRC17:29
*** jmlowe has joined #openstack-nova17:30
*** mkoderer_ has quit IRC17:31
jianghuawleakypipes, thanks for the +2.17:31
leakypipesjianghuaw: np17:32
leakypipesjianghuaw: now go to bed! :)17:32
jianghuaw:)17:33
*** awaugama has joined #openstack-nova17:37
*** lajoskatona has quit IRC17:38
*** tssurya has joined #openstack-nova17:40
openstackgerritMerged openstack/nova master: Include /resource_providers/uuid/allocations link  https://review.openstack.org/49982617:45
*** yamamoto has quit IRC17:49
*** penick has joined #openstack-nova17:50
openstackgerritEric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec}  https://review.openstack.org/51522317:50
*** yamahata has quit IRC17:52
*** yamamoto has joined #openstack-nova17:53
*** itlinux has joined #openstack-nova17:53
*** yamamoto has quit IRC17:59
*** rmart04 has joined #openstack-nova18:02
*** harlowja has quit IRC18:05
*** harlowja has joined #openstack-nova18:05
*** vks1 has quit IRC18:12
*** Apoorva has quit IRC18:15
*** Apoorva has joined #openstack-nova18:17
*** tssurya has quit IRC18:19
*** salv-orlando has joined #openstack-nova18:24
*** salv-orlando has quit IRC18:29
*** tssurya has joined #openstack-nova18:32
*** rtjure has quit IRC18:34
*** rtjure has joined #openstack-nova18:35
mriedemfigleaf: superdan: leakypipes: cdent: how would you guys all love to have a thrilling hangout to make sure we're on the same page about https://review.openstack.org/#/c/510159/ ?18:35
mriedemassuming cdent not so much given friday night fun time18:35
superdanyou mean now?18:35
cdenti’m around actually, but haven’t been following along today18:36
mriedemsuperdan: i'm game, i don't think this would be a long call18:36
mriedemelse it waits18:36
mriedemi think in at least one retrospective we said, 'when in doubt, hangout'18:37
mriedemand, 'if it's brown, flush it down'18:37
figleafmriedem: I can do it in the next 15 min; then I have to run out for a bit18:38
*** dave-mccowan has joined #openstack-nova18:38
* cdent would enjoy listening in18:38
mriedemfigleaf: as in you're free at 2pm?18:39
mriedemor out at 2pm?18:39
figleafmriedem: no, I'm free now. Gotta be somewhere at 218:39
*** rtjure has quit IRC18:39
mriedemhttps://hangouts.google.com/call/M3gJOjmdi0q0Ayha5KkYAAEE18:40
superdancdent: you're breathing.. heavily18:41
*** sahid has quit IRC18:43
*** dave-mccowan has quit IRC18:44
*** rtjure has joined #openstack-nova18:45
*** fragatina has quit IRC18:48
leakypipesmriedem: cool with me.18:48
*** rtjure has quit IRC18:50
*** smatzek has quit IRC18:52
figleafsuperdan: you have that effect on people18:55
superdanI'm going to pretend you didn't say that18:56
* cdent regrets not having a chance to make a dan I’m your father crack18:56
mriedemfigleaf: ok left a summary in the patch18:57
mriedemhttps://review.openstack.org/#/c/510159/18:57
mriedemthanks18:57
*** yamamoto has joined #openstack-nova18:59
*** yamamoto has quit IRC19:06
*** lpetrut has joined #openstack-nova19:08
*** awaugama has quit IRC19:08
*** sree has joined #openstack-nova19:11
*** avolkov has quit IRC19:14
*** sree has quit IRC19:16
*** andreas_s has joined #openstack-nova19:21
*** smatzek has joined #openstack-nova19:27
*** rmart04 has quit IRC19:27
*** Apoorva has quit IRC19:28
*** Apoorva has joined #openstack-nova19:29
*** catintheroof has quit IRC19:29
*** andreas_s has quit IRC19:31
*** andreas_s has joined #openstack-nova19:32
*** Apoorva has quit IRC19:33
*** tesseract has quit IRC19:33
openstackgerritJay Pipes proposed openstack/nova master: placement: add nested resource providers  https://review.openstack.org/37713819:34
openstackgerritJay Pipes proposed openstack/nova master: placement: allow filter providers in tree  https://review.openstack.org/37721519:34
openstackgerritJay Pipes proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480719:34
openstackgerritJay Pipes proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569319:34
openstackgerritEric Fried proposed openstack/nova master: ResourceRequest.to_querystring()  https://review.openstack.org/51581119:37
*** andreas_s has quit IRC19:37
*** dave-mccowan has joined #openstack-nova19:37
openstackgerritJay Pipes proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480719:37
openstackgerritJay Pipes proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569319:37
*** andreas_s has joined #openstack-nova19:38
*** catintheroof has joined #openstack-nova19:41
*** Apoorva has joined #openstack-nova19:43
fried_riceleakypipes Would you mind skimming the next couple patches in the series?  I can dig having a RequestGroup class, but I'd like to keep the encompassing thing as a class (rather than a plain list of RequestGroup) so it do things like merge all the resources and produce a querystring.19:45
fried_rices/so it do/so it can do/19:45
*** catintheroof has quit IRC19:45
*** sree has joined #openstack-nova19:46
leakypipesfried_rice: yup, I definitely will go through the remainder of the series. Probably won't be today, though...19:47
*** smatzek has quit IRC19:47
leakypipesfried_rice: you're high in my queue, though.19:48
fried_riceleakypipes Cool man.19:48
*** dave-mccowan has quit IRC19:49
*** sree has quit IRC19:51
*** pchavva has quit IRC19:51
*** andreas_s has quit IRC19:54
*** smatzek has joined #openstack-nova19:55
*** andreas_s has joined #openstack-nova19:56
*** rcernin has joined #openstack-nova19:57
*** sree has joined #openstack-nova19:58
*** andreas_s has quit IRC20:01
*** itlinux has quit IRC20:01
*** yamamoto has joined #openstack-nova20:02
*** andreas_s has joined #openstack-nova20:02
*** sree has quit IRC20:03
*** rmart04 has joined #openstack-nova20:03
*** rmart04 has quit IRC20:03
bauwserleakypipes: around ?20:04
leakypipesbauwser: yup!20:04
bauwserleakypipes: not sure you saw the discussion we had with jianghuaw20:04
bauwserleakypipes: about https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L80720:05
leakypipesbauwser: no, I didn't20:05
bauwserleakypipes: the problem is that if the compute node resources are not changing, then we don't call the inventory20:05
*** smatzek has quit IRC20:05
leakypipesbauwser: yes?20:06
bauwserleakypipes: which is a problem with the VGPU resources20:06
leakypipesbauwser: why?20:06
bauwsersince they're not in the compute node20:06
leakypipesbauwser: ah, yeah...20:07
bauwserleakypipes: I thought about that20:07
leakypipesbauwser: that line can be moved to after the call to get_inventory() eventually20:07
bauwserleakypipes: that's my point :p20:07
leakypipesyup20:07
bauwserI was asking you if you were okay with that :)20:07
*** yamamoto has quit IRC20:08
bauwserleakypipes: we could also persist the inventory20:08
bauwserleakypipes: so passing it to the _resource_change method too20:08
bauwserand so, not setting the inventory if that's not changing too :)20:09
bauwseranyway, lemme provide the chnage20:09
leakypipesbauwser: that's kind of what my nested resource provider series is doing.20:10
*** ijw has joined #openstack-nova20:11
*** penick has quit IRC20:11
leakypipesbauwser: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L60920:12
leakypipesbauwser: basically, that needs to come before the _resource_changed() thing in the RT.20:12
leakypipesbauwser: or we just get rid of the _resource_changed() thing entirely...20:13
bauwsermmmm20:13
bauwserleakypipes: what I honestly need is to look at your series :p20:14
*** jmlowe has quit IRC20:14
*** tssurya has quit IRC20:15
*** andreas_s has quit IRC20:15
*** ijw has quit IRC20:16
*** andreas_s has joined #openstack-nova20:17
*** hongbin has quit IRC20:20
*** tssurya has joined #openstack-nova20:21
*** salv-orlando has joined #openstack-nova20:25
*** yamahata has joined #openstack-nova20:25
fried_riceleakypipes Sure makes it trickier to test...20:26
leakypipesfried_rice: makes what trickier to test?20:27
*** hongbin has joined #openstack-nova20:27
fried_riceleakypipes The resource groups being objects instead of a big dict I can just build up and compare.  It's not a big deal.  Just prolly going to write some test-only methods on the objects.20:28
leakypipesfried_rice: ack.20:28
leakypipesfried_rice: well, I prefer if you don't add methods to the objects themselves. rather, add a comparator method to the test class.20:28
leakypipesassertRequestGroupsSame() or something like that...20:29
fried_riceleakypipes Yuh.20:29
*** salv-orlando has quit IRC20:29
*** andreas_s has quit IRC20:31
fried_riceleakypipes But then I have to build up RequestGroups for the 'expected' side.20:31
leakypipesfried_rice: correct.20:31
leakypipesfried_rice: which is explicit. and good.20:31
fried_riceleakypipes But reduces the test coverage, cause I'm using Thing to test Thing.20:32
fried_riceleakypipes Again, not a big deal, can do.20:32
leakypipesfried_rice: if Thing is just a plain-old-data object, that's good.20:32
*** andreas_s has joined #openstack-nova20:32
*** dave-mccowan has joined #openstack-nova20:33
*** ijw has joined #openstack-nova20:35
*** ijw has quit IRC20:35
*** salv-orlando has joined #openstack-nova20:35
*** ijw has joined #openstack-nova20:36
openstackgerritMerged openstack/nova master: Update placement api-ref: allocations link in 1.11  https://review.openstack.org/51574820:36
*** mdbooth has quit IRC20:37
*** ansiwen has quit IRC20:37
*** andreas_s has quit IRC20:37
*** dave-mccowan has quit IRC20:38
*** thorst has quit IRC20:38
*** andreas_s has joined #openstack-nova20:38
*** itlinux has joined #openstack-nova20:41
openstackgerritMichael Still proposed openstack/nova master: Move infiniband vif plugging to privsep.  https://review.openstack.org/51519720:42
openstackgerritMichael Still proposed openstack/nova master: Move midonet vif plugging to privsep.  https://review.openstack.org/51519820:42
openstackgerritMichael Still proposed openstack/nova master: Move plumgrid vif plugging to privsep.  https://review.openstack.org/51533620:42
openstackgerritMichael Still proposed openstack/nova master: Move control vif plugging to privsep.  https://review.openstack.org/51591620:42
*** andreas_s has quit IRC20:44
*** mdbooth has joined #openstack-nova20:44
openstackgerritMichael Still proposed openstack/nova master: Move plumgrid vif plugging to privsep.  https://review.openstack.org/51533620:44
openstackgerritMichael Still proposed openstack/nova master: Move contrail vif plugging to privsep.  https://review.openstack.org/51591620:44
*** ansiwen has joined #openstack-nova20:44
*** yamahata has quit IRC20:44
*** andreas_s has joined #openstack-nova20:44
*** pchavva has joined #openstack-nova20:45
*** felipemonteiro__ has quit IRC20:48
*** andreas_s has quit IRC20:50
*** andreas_s has joined #openstack-nova20:51
*** pchavva has quit IRC20:52
openstackgerritMerged openstack/nova master: [placement] Allow _set_allocations to delete allocations  https://review.openstack.org/50105120:53
mriedemfried_rice: comments in 16 and 18 https://review.openstack.org/#/c/492247/20:55
*** READ10 has joined #openstack-nova20:55
fried_rice...20:55
fried_ricemriedem Roger wilco, will update.  Thanks.20:56
mriedem|_o_|20:56
mriedem3 points if you do20:57
mriedemsuperdan knows what that 3 points is for20:57
cdentbeen a lot of football today20:57
mriedemheh20:57
mriedemthat reminds me20:57
mriedemvikings in london on sunday20:57
mriedemthat means i get football at 8:30, noon, 3:30 and 7:3020:58
cdentapparently when the nfl go to london _loads_ of people go nutbar and dress up for the game20:58
superdanobviously three points for a three pointer shot from midfield20:58
cdentwhich when I heard about it, completely surprised me20:58
superdanswish20:58
superdangoooooooal20:58
* superdan wonders if he's going in the right direction20:58
mriedemclose, field goal20:59
*** Apoorva_ has joined #openstack-nova20:59
mriedemcdent: yes, if you watch the game, it's all people dressed up in different stuff20:59
mriedembecause there is no home team, just ex-pats20:59
cdentweird20:59
mriedemi think the official home team is jacksonville or miami, both of whom are pretty bad every year, so you're welcome20:59
cdentis it ex-pats? I was under the impression it was crazy brits deciding they love american football and not knowing how to show it20:59
mriedemcould be worse,20:59
mriedemcould be the gd browns21:00
mriedemoh shit21:00
mriedemguess who the vikings play on sunday in london?21:00
mriedemthe f'ing browns!21:00
*** andreas_s has quit IRC21:01
*** hemna_ has quit IRC21:01
*** Apoorva has quit IRC21:02
*** andreas_s has joined #openstack-nova21:02
openstackgerritMerged openstack/nova master: Only filter/weigh hosts once if scheduling a single instance  https://review.openstack.org/51393121:03
bauwsermriedem: well, Barca-Juv was in NYC this summer :p21:03
mriedemno one knows what that is21:03
bauwsergdi21:03
bauwserman, soccer!21:03
*** pchavva has joined #openstack-nova21:04
bauwseryou know, the game that US folks try to play and at the end, they loose :p21:04
mriedemunless they are women21:04
cdentus women’s soccer rocs21:04
*** fragatina has joined #openstack-nova21:04
* cdent gets all nostalgic for high school21:04
bauwserthat's correct :)21:04
*** yamamoto has joined #openstack-nova21:05
cdenttickets to the london nfl games are a lot cheaper than I would have predicted21:06
mriedembecause they need to fill the seats to look good on t21:06
mriedem*tv21:06
cdentfried_rice: can you try a bit harder, only 50% of my pending patches are in merge conflict21:06
fried_ricecdent Somebody had to take the fall.21:07
*** itlinux has quit IRC21:07
cdentI think if leakypipes merges a couple more de-orms that should break the rest of the nova ones21:07
*** smatzek has joined #openstack-nova21:07
*** andreas_s has quit IRC21:08
*** pchavva has quit IRC21:09
*** andreas_s has joined #openstack-nova21:09
* cdent actually likes merge conflicts21:09
cdentthey’re a bit like mile markers on the highway21:09
*** yamamoto has quit IRC21:10
*** itlinux has joined #openstack-nova21:15
*** tssurya has quit IRC21:15
*** marst has quit IRC21:15
*** andreas_s has quit IRC21:18
*** andreas_s has joined #openstack-nova21:19
*** leakypipes has quit IRC21:23
*** andreas_s has quit IRC21:24
*** yamahata has joined #openstack-nova21:24
*** penick has joined #openstack-nova21:25
*** rcernin has quit IRC21:28
*** andreas_s has joined #openstack-nova21:29
*** sree has joined #openstack-nova21:32
*** esberglu has quit IRC21:34
*** READ10 has quit IRC21:35
*** sree has quit IRC21:37
*** amodi has quit IRC21:38
*** andreas_s has quit IRC21:39
*** jamesden_ is now known as jamesdenton21:41
*** andreas_s has joined #openstack-nova21:41
*** baoli has quit IRC21:42
*** itlinux has quit IRC21:44
*** salv-orlando has quit IRC21:50
*** salv-orlando has joined #openstack-nova21:50
*** salv-orlando has quit IRC21:55
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements  https://review.openstack.org/49314621:57
*** sapcc-bot has quit IRC21:58
*** sapcc-bot has joined #openstack-nova21:58
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements  https://review.openstack.org/51103522:00
*** andreas_s has quit IRC22:01
*** figleaf is now known as edleafe22:01
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements  https://review.openstack.org/51103522:01
*** salv-orlando has joined #openstack-nova22:03
*** ijw has quit IRC22:05
*** ijw has joined #openstack-nova22:05
*** burt has quit IRC22:06
*** yamamoto has joined #openstack-nova22:06
*** andreas_s has joined #openstack-nova22:06
*** smatzek has quit IRC22:09
*** smatzek has joined #openstack-nova22:10
*** smatzek has quit IRC22:11
*** yamamoto has quit IRC22:11
*** awaugama has joined #openstack-nova22:11
*** smatzek has joined #openstack-nova22:11
openstackgerritMerged openstack/nova master: rt: Implement XenAPI get_inventory() method  https://review.openstack.org/33920422:12
*** lyan has quit IRC22:12
*** dave-mccowan has joined #openstack-nova22:14
*** smatzek has quit IRC22:16
*** andreas_s has quit IRC22:16
*** awaugama has quit IRC22:17
*** andreas_s has joined #openstack-nova22:17
*** sree has joined #openstack-nova22:19
*** artom has quit IRC22:19
*** andreas_s has quit IRC22:22
*** sree has quit IRC22:23
*** thorst has joined #openstack-nova22:24
*** dave-mccowan has quit IRC22:24
*** salv-orlando has quit IRC22:27
*** andreas_s has joined #openstack-nova22:28
*** salv-orlando has joined #openstack-nova22:28
*** thorst has quit IRC22:29
rm_workDo you guys have a feel for how commonly deployments use the AZ extension?22:32
rm_workI'm curious if it's close to 100%, or much less22:32
mriedemi'd say pretty common22:33
*** itlinux has joined #openstack-nova22:33
openstackgerritEric Fried proposed openstack/nova master: Parse granular resources/traits from extra_specs  https://review.openstack.org/51515122:33
openstackgerritEric Fried proposed openstack/nova master: Granularize resources_from_{flavor|request_spec}  https://review.openstack.org/51522322:33
openstackgerritEric Fried proposed openstack/nova master: ResourceRequest.to_querystring()  https://review.openstack.org/51581122:33
mriedembut probably better input if you ask in #openstack-operators22:33
rm_workhmm, k22:33
*** salv-orlando has quit IRC22:35
*** salv-orlando has joined #openstack-nova22:36
*** lpetrut has quit IRC22:36
*** andreas_s has quit IRC22:38
*** salv-orlando has quit IRC22:40
bfifekashyap / melwitt; thanks for https://review.openstack.org/#/c/514339/. what i came here to sort out :-)22:41
fried_ricemriedem Okay, so here's how those deprecations work with ksa...22:45
fried_riceIf you were to access the deprecated opt directly (e.g. CONF.placement.os_region_name), you would get the deprecation message from the deprecated_reason.22:46
fried_riceBut you would never do that.22:46
*** itlinux has quit IRC22:46
fried_riceWhat actually happens is you call utils.get_ksa_adapter, which references that var from within ksa, where it keys off of the fact that we passed that guy as a deprecated opt.22:47
fried_ricewhereupon it emits the warning that looks like:   WARNING:oslo_config.cfg:Option "os_region_name" from group "placement" is deprecated. Use option "region-name" from group "placement".22:47
fried_riceSo... it's only useful for me to even put the deprecated_reason into the conf for developers' eyeballs to look at.  (Unless the deprecation shows up in the config sample - but it doesn't, does it?)22:48
mriedemit does show up in the conf sample22:48
mriedemwhich is why i asked for it22:48
mriedemotherwise you have to look at the others to see the link22:48
*** ijw has quit IRC22:48
*** ijw has joined #openstack-nova22:49
fried_ricemriedem Okay, cool.  Will fix.22:49
*** sdague has quit IRC22:50
*** andreas_s has joined #openstack-nova22:54
*** andreas_s has quit IRC22:58
*** yamamoto has joined #openstack-nova23:07
*** andreas_s has joined #openstack-nova23:08
openstackgerritEric Fried proposed openstack/nova master: Use ksa adapter for placement conf & requests  https://review.openstack.org/49224723:09
fried_ricemriedem Done, I think ^23:10
fried_ricemriedem Though I built the conf sample, and I couldn't get that stuff to show up in it...23:10
*** ansiwen[q] has quit IRC23:10
fried_riceI think the deprecation from ksa is doing some funkiness that overrides.23:10
*** yamahata has quit IRC23:10
fried_ricebut at least it's visible to the guy looking at the file.23:10
fried_riceI want to say I looked at all of this when I first started slinging this blueprint around, but clearly I've slept since then.23:11
mriedemok23:11
*** yamamoto has quit IRC23:12
bauwsermriedem: heh, related kaboom https://bugs.launchpad.net/nova/+bug/172152223:13
openstackLaunchpad bug 1721522 in OpenStack Compute (nova) "encrypted volumes: Cannot format device /dev/sdb which is still in use" [Undecided,Incomplete]23:13
bauwsermriedem: looks like the folk asked for sdb23:13
bauwseroh even better https://docs.openstack.org/cinder/pike/configuration/block-storage/volume-encryption.html23:14
mriedembecause we pass the user-supplied device to the cryptsetup command rather than taking what we calculated as the device ourselves?23:14
bauwseropenstack server add volume --device /dev/vdc TESTVM 'encrypted volume'23:14
mriedemopenstack server add volume --device /dev/vdc TESTVM 'encrypted volume'23:14
mriedemheh23:14
mriedemyeah23:14
bauwsermriedem: looks like23:15
*** ansiwen[q] has joined #openstack-nova23:15
mriedemprobably need a .. note:: that says "don't pass device"23:15
bauwser:)23:15
bauwserI'll wait for the reply23:15
bauwsermriedem: also FYI https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L62123:16
* bauwser <3 OSC23:16
bauwsereven if the user doesn't specify it, OSC forces it23:16
mriedemyeah you already showed me that23:16
mriedemi'd say that should all be deprecated in osc23:16
bauwserah yeah23:16
mriedemlooks like chenrui added a bunch of that23:17
mriedemhe's at huawei23:17
*** andreas_s has quit IRC23:17
bauwsercool23:17
mriedemalthough it also looks like that predated his changes https://github.com/openstack/python-openstackclient/commit/95c8661f86e74c9d5217869a740da11350f1f0eb23:18
*** cdent has quit IRC23:19
*** andreas_s has joined #openstack-nova23:19
mriedemhttps://github.com/openstack/python-openstackclient/commit/2c9d263611190996d64e35bc74a8575aeb25ed3e23:20
mriedemanyway, deprecate it23:20
mriedemKevin_Zheng: ^ :)23:20
bauwsermriedem: indeed23:20
bauwserthat change trampled your colleague23:20
*** hongbin has quit IRC23:21
bauwserwait, it's Saturday now here23:21
*** bauwser is now known as bauzas23:21
bauzasmriedem: before going to bed, I'd love your thoughts on https://bugs.launchpad.net/nova/+bug/172316523:22
openstackLaunchpad bug 1723165 in OpenStack Compute (nova) "Volume is not detached when deleted VM was in error state" [Undecided,New]23:22
bauzasthat's not a quota problem, just the fact we don't unattach the volumz23:22
*** ansiwen[q] has quit IRC23:22
*** fried_rice is now known as efried23:22
bauzasI tend to think it's legit23:23
Kevin_Zhengmriedem: will check latter, 4th Saturday of the month... still have to work23:23
*** andreas_s has quit IRC23:24
*** penick has quit IRC23:25
*** thorst has joined #openstack-nova23:27
mriedembauzas: sounds like a bug23:29
mriedemwe don't test image-defined bdms very well23:29
*** owalsh is now known as owalsh_pto23:29
mriedemerror scenarios anyway23:29
bauzastriaging it23:29
bauzasif it's something else, then meh23:29
*** andreas_s has joined #openstack-nova23:30
mriedembauzas: oh i see,23:31
mriedemso it goes to error state in the compute service,23:31
mriedembecause that's going to create some new volumes in cinder from the snapshot bdms23:31
mriedemcinder fails on the volume create because overquota23:31
bauzasright23:31
mriedemand we probably don't "detach" the volumes because we never attached them in the first place - because of overquota23:31
mriedemor maybe we attached 2 but didn't finish one of them in time, idk23:32
bauzaslooks like it's the instance which fails, not the volume creation23:33
mriedemwould probably be helpful for them to give us the information about the volumes after the failure23:33
mriedemlike their status and if they show an instance id23:33
bauzasbecause the volume is there23:33
mriedembut the instance failure would be due to _prep_block_devices failing to create the last volume23:33
mriedembecause cinder returns overquota23:33
mriedemthey started with 3 volumes,23:33
mriedemsnapshot23:33
mriedemset vol quota to 523:33
mriedemcreate new instance from the image snapshot which has 3 image-defined bdms in it,23:34
mriedemso nova is going to create 3 more volumes from the snapshot bdms,23:34
mriedem2 will get created, 1 will fail with overquota from cinder23:34
mriedemwhich makes _prep_block_devices fail and the instance goes to ERROR state on the compute23:34
bauzasright23:34
*** thorst has quit IRC23:38
*** andreas_s has quit IRC23:38
*** andreas_s has joined #openstack-nova23:44
*** Swami has quit IRC23:46
*** stvnoyes has quit IRC23:48
*** thorst has joined #openstack-nova23:49
*** thorst has quit IRC23:49
*** andreas_s has quit IRC23:49
*** oanson has quit IRC23:54
*** andreas_s has joined #openstack-nova23:54
*** oanson has joined #openstack-nova23:55
bauzasmriedem: last point, are we unquoting a shelved instance or not ?23:55
bauzasof course, an offloaded instance23:56
bauzasI think we shouldn't23:56
mriedemcan't talk about bugs anymore23:57
mriedemgo to be you crazy frenchman23:57
mriedem*bed23:57
bauzas:p23:58
bauzaswe have 18 open bugs and next week, I'll have a talk about bug triaging :p23:58
mriedemyeah i know why you've been on top of it,23:59
mriedemyou should have to give a talk about bug triaging every quarter23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!