Monday, 2017-11-13

*** sbezverk has joined #openstack-nova00:07
*** vladikr has joined #openstack-nova00:16
*** edmondsw has joined #openstack-nova00:17
*** edmondsw has quit IRC00:25
*** yingjun has joined #openstack-nova00:35
*** yingjun has quit IRC00:37
*** yingjun has joined #openstack-nova00:41
*** yingjun has quit IRC00:53
*** hieulq has joined #openstack-nova01:00
*** Sukhdev has joined #openstack-nova01:08
*** liverpooler has joined #openstack-nova01:10
*** tbachman has joined #openstack-nova01:10
*** zhenguo has joined #openstack-nova01:14
*** litao__ has joined #openstack-nova01:22
*** phuongnh has joined #openstack-nova01:26
openstackgerritYikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils  https://review.openstack.org/51887101:29
openstackgerritYikun Jiang proposed openstack/nova master: WIP: Add cross cell sort support for get_migrations  https://review.openstack.org/51727301:31
openstackgerritYikun Jiang proposed openstack/nova master: WIP: Add cross cell sort support for get_migrations  https://review.openstack.org/51727301:33
openstackgerritZhenyu Zheng proposed openstack/nova master: Mention API behavior change when over quota limit  https://review.openstack.org/51563101:57
*** armax has joined #openstack-nova01:58
*** fragatina has quit IRC01:58
*** fragatina has joined #openstack-nova01:59
*** liverpooler has quit IRC02:04
*** hongbin has joined #openstack-nova02:06
*** Sukhdev has quit IRC02:16
*** armax has quit IRC02:26
*** Sukhdev has joined #openstack-nova02:31
*** salv-orlando has joined #openstack-nova02:48
*** gcb has joined #openstack-nova02:51
*** salv-orl_ has quit IRC02:51
*** links has joined #openstack-nova02:53
*** hoonetorg has quit IRC02:58
*** Sukhdev has quit IRC03:07
openstackgerritAlex Xu proposed openstack/nova master: placement: avoid multiple join in _get_all_with_shared  https://review.openstack.org/51908103:09
*** trungnv has joined #openstack-nova03:11
*** hoonetorg has joined #openstack-nova03:11
*** cheneydc has joined #openstack-nova03:18
openstackgerritAlex Xu proposed openstack/nova master: placement: avoid multiple join in _get_all_with_shared  https://review.openstack.org/51908103:20
*** moshele has joined #openstack-nova03:39
*** TuanLA has joined #openstack-nova03:39
*** moshele has quit IRC03:41
*** sree has joined #openstack-nova03:47
*** sree has quit IRC03:48
*** sree_ has joined #openstack-nova03:48
*** sree_ is now known as Guest787803:48
*** namnh has joined #openstack-nova03:48
*** diga has joined #openstack-nova03:50
*** psachin has joined #openstack-nova03:56
*** yamamoto has joined #openstack-nova04:01
*** gbarros has joined #openstack-nova04:10
*** gbarros_ has quit IRC04:10
*** Dinesh_Bhor has joined #openstack-nova04:14
*** squid has joined #openstack-nova04:15
*** gbarros has quit IRC04:36
*** udesale__ has joined #openstack-nova04:41
*** phuongnh has quit IRC04:53
*** phuongnh has joined #openstack-nova04:54
*** suresh12 has joined #openstack-nova05:06
*** ratailor has joined #openstack-nova05:09
*** hshiina has joined #openstack-nova05:25
*** hongbin has quit IRC05:30
*** udesale has joined #openstack-nova05:32
*** udesale__ has quit IRC05:33
*** janki has joined #openstack-nova05:33
*** edmondsw has joined #openstack-nova05:41
*** udesale__ has joined #openstack-nova05:43
*** edmondsw has quit IRC05:45
*** udesale has quit IRC05:46
*** lennyb has quit IRC05:51
*** trungnv has quit IRC05:55
*** lennyb has joined #openstack-nova05:56
*** lennyb has quit IRC06:03
*** qsyqian_ has joined #openstack-nova06:05
*** lennyb has joined #openstack-nova06:05
*** suresh12 has quit IRC06:06
*** moshele has joined #openstack-nova06:08
*** swamireddy has quit IRC06:11
*** bswartz has quit IRC06:12
*** trozet has quit IRC06:13
*** mikal_ has joined #openstack-nova06:43
jianghuawalex_xu, do you know when OpenStack client will support placement traits?06:46
*** mikal has quit IRC06:46
alex_xujianghuaw: I don't know that, at least the server side doesn't finish yet06:47
jianghuawalex_xu, ah. thanks anyway:-)06:47
alex_xujianghuaw: is there anyone work on the placement support on Openstack Client?06:48
*** chialiang has joined #openstack-nova06:48
jianghuawalex_xu, I don't know that.06:49
alex_xujianghuaw: at least I don't know anyone work on that :)06:49
alex_xujianghuaw: btw, would you go to the bugsmash next week?06:49
*** trozet has joined #openstack-nova06:50
jianghuawalex_xu, no. I won't attend this time.06:50
jianghuawI guess you will be there. right?06:51
alex_xujianghuaw: yea, i will be there06:51
jianghuawWish you enjoy the meeting.06:52
*** sahid has joined #openstack-nova06:53
*** slaweq has joined #openstack-nova06:54
*** jaosorior has joined #openstack-nova06:56
*** slaweq has quit IRC06:59
openstackgerritNaichuan Sun proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569307:04
openstackgerritNaichuan Sun proposed openstack/nova master: placement: Modify scheduler and report API to accept parent uuid  https://review.openstack.org/51924307:04
*** sshwarts has joined #openstack-nova07:08
openstackgerritMerged openstack/nova master: Refactor test_allocation_candidates  https://review.openstack.org/51812407:09
openstackgerritMerged openstack/nova master: Test alloc candidates with same RC in cn & shared  https://review.openstack.org/51314907:09
*** Oku_OS-away is now known as Oku_OS07:12
*** spectr has joined #openstack-nova07:14
*** spectr has quit IRC07:24
*** qsyqian has joined #openstack-nova07:27
openstackgerritNaichuan Sun proposed openstack/nova master: (WIP)placement: Modify scheduler and report API to accept parent uuid  https://review.openstack.org/51924307:27
*** andreas_s has joined #openstack-nova07:29
*** hoonetorg has quit IRC07:30
*** erlon has joined #openstack-nova07:30
*** fragatina has quit IRC07:33
*** qsyqian__ has joined #openstack-nova07:35
*** qsyqian__ has left #openstack-nova07:35
*** qsyqian has quit IRC07:36
*** hoonetorg has joined #openstack-nova07:43
*** TuanLA has quit IRC07:43
*** trungnv has joined #openstack-nova07:44
*** belmoreira has joined #openstack-nova07:45
*** AlexeyAbashkin has joined #openstack-nova07:45
*** snasir has quit IRC07:45
*** qsyqian_ has quit IRC07:47
*** snasir has joined #openstack-nova07:47
*** rcernin has quit IRC07:51
*** slaweq has joined #openstack-nova07:52
*** Eran_Kuris has quit IRC07:53
*** slaweq has quit IRC07:56
*** tianhui has joined #openstack-nova07:58
*** lajoskatona has joined #openstack-nova08:01
*** slaweq has joined #openstack-nova08:08
*** Eran_Kuris has joined #openstack-nova08:09
*** slaweq has quit IRC08:10
*** pcaruana has joined #openstack-nova08:10
*** salv-orlando has quit IRC08:11
*** slaweq has joined #openstack-nova08:11
*** salv-orlando has joined #openstack-nova08:11
*** alexchadin has joined #openstack-nova08:13
*** salv-orlando has quit IRC08:15
*** ralonsoh has joined #openstack-nova08:19
*** tesseract has joined #openstack-nova08:27
*** moshele has quit IRC08:31
*** msno has joined #openstack-nova08:35
msnohi guyz.08:36
*** salv-orlando has joined #openstack-nova08:36
msnowhats is the best method to take backup of a boot from volume instance from a openstack instalation.. and restore it in another openstack installation08:37
*** danpawlik has joined #openstack-nova08:38
*** sree has joined #openstack-nova08:38
*** Guest7878 has quit IRC08:40
*** zenirc369 has joined #openstack-nova08:40
*** ragiman has joined #openstack-nova08:41
*** qsyqian_ has joined #openstack-nova08:43
*** qsyqian_ has quit IRC08:43
*** kukacz has quit IRC08:46
*** moshele has joined #openstack-nova08:50
*** jpena|off is now known as jpena08:51
*** dtantsur|afk is now known as dtantsur08:55
*** swamireddy has joined #openstack-nova08:55
*** maciejjozefczyk has joined #openstack-nova08:57
*** akekane has joined #openstack-nova08:57
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API  https://review.openstack.org/47661208:57
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API  https://review.openstack.org/48222608:58
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands  https://review.openstack.org/48740509:00
*** akekane is now known as abhishekk09:03
*** rcernin has joined #openstack-nova09:03
openstackgerritSpencer Yu proposed openstack/nova master: Use safer ast.literal_eval instead of eval  https://review.openstack.org/51926809:04
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Change Subnet.dhcp_server to contain multiple IPs  https://review.openstack.org/50910709:05
*** strigazi_ is now known as strigazi09:11
openstackgerritZhenyu Zheng proposed openstack/nova master: Add instance action record for attach/detach/swap volumes  https://review.openstack.org/51720509:14
*** kukacz has joined #openstack-nova09:17
openstackgerritlicanwei proposed openstack/nova master: cli 'nova-manage db sync' can't upgrage cell1  https://review.openstack.org/51927509:19
*** rodolof has joined #openstack-nova09:21
*** pooja-jadhav is now known as pooja_jadhav09:23
*** derekh has joined #openstack-nova09:24
openstackgerritLIU Yulong proposed openstack/nova master: Enable reset keypair while rebuilding instance  https://review.openstack.org/37912809:26
*** andreas_s has quit IRC09:33
*** rodolof has quit IRC09:34
*** lucas-afk is now known as lucasagomes09:34
*** diga has quit IRC09:39
*** slunkad has joined #openstack-nova09:42
openstackgerritYikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations  https://review.openstack.org/51727309:45
*** takashin has left #openstack-nova09:50
*** alexchadin has quit IRC09:51
*** qsyqian has joined #openstack-nova09:51
*** alexchadin has joined #openstack-nova09:53
*** mvk has quit IRC09:54
*** andreas_s has joined #openstack-nova09:56
*** cheneydc has quit IRC10:00
*** yamamoto has quit IRC10:02
*** s1061123 has joined #openstack-nova10:03
*** s1061123_ has quit IRC10:04
*** lpetrut has joined #openstack-nova10:04
*** rcernin has quit IRC10:06
*** gcb has quit IRC10:07
*** AlexeyAbashkin has quit IRC10:08
openstackgerritSpencer Yu proposed openstack/nova master: [WIP]Use defusedxml function instead of lxml.etree.parse  https://review.openstack.org/51929110:09
*** diga has joined #openstack-nova10:10
*** andreas_s has quit IRC10:12
*** namnh has quit IRC10:13
*** sree_ has joined #openstack-nova10:15
*** sree_ is now known as Guest8484310:15
*** sree has quit IRC10:18
*** mvk has joined #openstack-nova10:22
*** lpetrut_ has joined #openstack-nova10:22
*** zenirc369 has quit IRC10:23
*** andreas_s has joined #openstack-nova10:24
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/51912710:24
openstackgerritYikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations  https://review.openstack.org/51727310:24
*** lpetrut has quit IRC10:25
*** vipul has quit IRC10:27
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements  https://review.openstack.org/51916510:28
*** andreas_s has quit IRC10:28
*** andreas_s has joined #openstack-nova10:35
*** vivsoni has joined #openstack-nova10:37
*** andreas_s has quit IRC10:40
*** belmoreira has quit IRC10:42
*** udesale__ has quit IRC10:42
*** rmart04 has joined #openstack-nova10:44
*** Guest84843 has quit IRC10:45
*** vivsoni_ has joined #openstack-nova10:51
*** yamamoto has joined #openstack-nova10:52
*** gszasz has joined #openstack-nova10:53
*** vivsoni has quit IRC10:53
*** Guest29299 has quit IRC10:56
*** yangyapeng has joined #openstack-nova10:57
*** diga has quit IRC11:15
*** sileht has quit IRC11:18
*** yangyapeng has quit IRC11:19
*** yangyapeng has joined #openstack-nova11:19
*** abhishekk has quit IRC11:19
*** sdague has joined #openstack-nova11:21
*** sahid_ has joined #openstack-nova11:21
*** qsyqian has left #openstack-nova11:22
*** AlexeyAbashkin has joined #openstack-nova11:23
*** sileht has joined #openstack-nova11:23
*** yangyapeng has quit IRC11:24
openstackgerritLajos Katona proposed openstack/nova master: Extend ServerMovingTests with custom resources  https://review.openstack.org/49739911:24
*** phuongnh has quit IRC11:30
*** gszasz has quit IRC11:31
openstackgerritsahid proposed openstack/nova master: libvirt: disconnect volume from host during detach  https://review.openstack.org/51500811:35
*** andreas_s has joined #openstack-nova11:36
*** andrea___ has joined #openstack-nova11:41
*** andreas_s has quit IRC11:45
openstackgerritSaverio Proto proposed openstack/nova master: Correct log message when removing a security group from a port  https://review.openstack.org/51931311:46
*** yamamoto has quit IRC11:51
zioprotoHow do I tag this review as low hanging fruit ?11:51
zioprotoI mean this one https://bugs.launchpad.net/nova/+bug/173188911:54
openstackLaunchpad bug 1731889 in OpenStack Compute (nova) "Nova logs adding security group to port when is actually removing a security group from a port" [Undecided,In progress] - Assigned to Saverio Proto (zioproto)11:54
*** gszasz has joined #openstack-nova12:02
*** gszasz has quit IRC12:03
*** alexchadin has quit IRC12:03
*** alexchadin has joined #openstack-nova12:03
*** gszasz has joined #openstack-nova12:03
*** udesale has joined #openstack-nova12:06
*** yamamoto has joined #openstack-nova12:08
*** dtantsur is now known as dtantsur|bbl12:10
*** yassine has joined #openstack-nova12:13
*** yassine is now known as Guest6852812:14
*** belmoreira has joined #openstack-nova12:18
*** udesale has quit IRC12:25
*** smatzek has joined #openstack-nova12:26
openstackgerritsean mooney proposed openstack/nova master: add vif info to migration object  https://review.openstack.org/51542312:29
*** lucasagomes is now known as lucas-hungry12:31
*** ratailor has quit IRC12:32
*** chialiang has quit IRC12:33
gibizioproto: you can tag triaged but unassigned bugs as low hanging with the tag low-hanging-fruit. You cannot really tag a review as low hanging but I will go and look at your patch now12:35
*** Jack_Iv has joined #openstack-nova12:36
efriedgibi Greetings!12:39
zioprotogibi: thanks12:40
gibiefried: hi!12:41
gibizioproto: please fix the commit message then I will +2 your patch12:42
openstackgerritSaverio Proto proposed openstack/nova master: Correct log message when removing a security group  https://review.openstack.org/51931312:45
zioprotogibi: done !12:45
gibizioproto: thanks, +212:51
*** jpena is now known as jpena|lunch12:52
*** markvoelker has joined #openstack-nova12:53
*** gszasz has quit IRC12:57
*** moshele has quit IRC12:59
*** moshele has joined #openstack-nova12:59
*** sree has joined #openstack-nova13:01
*** kukacz has quit IRC13:02
*** kukacz has joined #openstack-nova13:03
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896413:06
*** alexchadin has quit IRC13:07
*** alexchadin has joined #openstack-nova13:08
*** alexchadin has quit IRC13:10
*** alexchadin has joined #openstack-nova13:11
*** udesale has joined #openstack-nova13:11
*** sree_ has joined #openstack-nova13:13
*** sree_ is now known as Guest8034413:13
*** gcb has joined #openstack-nova13:15
*** sree has quit IRC13:16
openstackgerritEric Fried proposed openstack/nova master: Test helper: validate provider summaries  https://review.openstack.org/51898213:16
efriedgibi ^ -- I had had some trouble using sets in similar situations in the past because some things aren't hashable.  But this seems to have worked out okay.  Thanks for the suggestion.13:18
gibiefried: cool, I will check that shortly13:19
efriedThanks!13:19
*** edmondsw has joined #openstack-nova13:19
gibiefried: do you know the reason of the functional test failures in https://review.openstack.org/#/c/385693/ ?13:19
efried...13:19
gibiefried: I guess it is 'Invalid microversion: Unacceptable version header: 1.12'13:19
*** gszasz has joined #openstack-nova13:20
efriedgibi Yeah, looks that way.13:20
*** edmondsw has quit IRC13:20
*** edmondsw has joined #openstack-nova13:20
efriedgibi We don't have 1.12 yet, right?13:21
gibiefried: yeah, as far as I see it is not on master13:21
gibithen I understand, thanks :)13:21
gibisometimes it is hard to follow what is merged and what is not from nrp13:22
efriedNow we need to figure out *WHICH* proposed 1.12 this is dependent on.  And it should have a Depends-On accordingly.13:22
*** ygl has joined #openstack-nova13:22
yglhi all13:23
gibithe patch needs to be able to set parent_provider_uuid during RP creation13:23
yglI want to know the code flow when we excute  nova boot command13:23
ygli have cloned the git for nova13:23
yglhow does the control reaches to nova.api.openstack.compute.servers from the nova api ?13:24
gibiefried: so I guess the patch needs this https://review.openstack.org/#/c/384807/13:24
*** yamamoto has quit IRC13:24
efriedgibi I was half a second behind you :)13:24
yglcan someone help me with the control flow for launching an instance13:25
*** pkoniszewski has quit IRC13:25
efriedygl jaypipes just put out a nice article explaining that flow.  Lemme find it for you...13:25
yglefried: sure thank you13:26
*** lucas-hungry is now known as lucasagomes13:26
gibiefried: I guess I have the advantages having my second caffe already13:26
efriedygl https://github.com/jaypipes/articles/blob/master/openstack/walkthrough-launch-instance-request.md13:26
yglefried: let me check it once13:26
efriededleafe- Will there be a scheduler meeting this morning?13:30
*** moshele has quit IRC13:31
*** moshele has joined #openstack-nova13:31
yglefried: thanks for the link. I have a question13:33
efriedygl I'll help if I can.  Jay's not on yet.13:33
efriedBut you clearly read way faster than I do.13:33
yglefried: after validating the request , it constructs a build request. Which code is responsible in invoking the build request function ?13:34
efriedygl The article links to https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L88013:35
*** shaner has quit IRC13:35
*** shaner has joined #openstack-nova13:35
efriedygl If you look down that function to L927, it looks like the build request is finally built there.13:35
*** bauzas has joined #openstack-nova13:38
*** gbarros has joined #openstack-nova13:41
*** takashin has joined #openstack-nova13:46
yglefried: my question is what invokes that  build function ?13:47
efriedygl https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L112113:49
efriedygl https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L162013:50
*** edmondsw_ has joined #openstack-nova13:53
yglefried: does this function nova.api.openstack.compute.servers.ServersController.create()     invoke build request function ?13:53
bauzasf*ck, my IRC bouncer died13:53
bauzasRIP13:53
efriedbauzas We still love you.13:53
*** edmondsw has quit IRC13:53
*** edmondsw_ is now known as edmondsw13:54
bauzasthat, and my internal DNS server :(13:54
efriedygl That seems like a reasonable assumption.13:54
*** cheneydc has joined #openstack-nova13:54
yglefried: i am searching for that  connection between the two events13:55
*** jpena|lunch is now known as jpena13:55
gibibauzas: welcome back!13:55
bauzasgibi: well, ty13:55
*** cheneydc has quit IRC13:55
efriedygl Yeah, that's tricky, and I'm not super well-versed on how that works.  Perhaps bauzas or stephenfin would know off the top.13:55
bauzasjust having a sickness too :p13:56
bauzassometimes, you love coming back to your house13:56
yglbauzas: Hi, can you help me with this https://github.com/jaypipes/articles/blob/master/openstack/walkthrough-launch-instance-request.md   please ?13:56
*** rmart04 has quit IRC13:57
yglbauzas: I am trying to understand what actually invokes the build request function ?13:57
efriedbauzas ygl is trying to figure out how we get from an API call to boot an instance, down to the create method in here: https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L162013:58
bauzasygl: have you seen the links ?N13:59
openstackgerritDavid Wahlstrom proposed openstack/nova master: Fix changes-since search filter  https://review.openstack.org/51935613:59
bauzashttps://github.com/jaypipes/articles/blob/master/openstack/walkthrough-launch-instance-request.md#construct-build-request13:59
bauzaslinking to https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L88013:59
efriedbauzas Yeah, we walked that back to nova.compute.api.API.create, but don't know how the call into the REST API gets there.14:00
*** hshiina has quit IRC14:00
yglbauzas: my question is after the http validation by "nova.api.openstack.compute.servers.ServersController.create()"  , what actually invookes the build request function ?14:01
bauzasah14:01
bauzassec14:01
yglbauzas: sure14:01
*** liverpooler has joined #openstack-nova14:01
bauzasit calls nova.compute.api.::create() AFAIR14:01
bauzasie. https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L158414:02
bauzasygl, efried: there, it is https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/compute/servers.py#L54214:03
bauzasif cellsv1, it can go to the cells API14:03
bauzasbut if not, it directly calls the above method14:03
efriedbauzas gibi Any interest in having a scheduler meeting in edleafe-'s absence?14:04
bauzasefried: sorry, I'm a bit sick14:04
efriedSorry to hear that.  Rest up!14:04
bauzashonestly, nothing to tell about the Sydney suumit14:04
*** gbarros has quit IRC14:05
gibiefried:If it just the two of us then I think we can skip the meeting14:05
efriedwfm14:05
yglefried: can you find out for me how the control flows after the POST /servers to the create server function ?14:05
efriedygl That sounds like wsgi stuff.  Fraid I'm not the guy there.14:06
efriedygl What is it you're actually trying to do here?14:06
bauzasygl: sec14:07
yglefried: i am just curious to find it out. I work on openstack14:07
bauzasygl: you wanna know what calls https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/compute/servers.py#L453 ?14:07
bauzasI mean, how is it routed ?14:07
yglbauzas:no, I am following the post https://github.com/jaypipes/articles/blob/master/openstack/walkthrough-launch-instance-request.md#construct-build-request14:07
yglbauzas: in that I want to know after the "Validate HTTP payload" section, which code actually calls the build reequest function14:08
*** mriedem has joined #openstack-nova14:08
*** dtantsur|bbl is now known as dtantsur14:09
bauzasygl: I replied to you on that part14:09
yglefried: bauzas if you find anything please mail the details to ygk.kmr@gmail.com14:09
bauzas(15:02:00) bauzas: ie. https://github.com/openstack/nova/blob/stable/pike/nova/compute/api.py#L158414:09
bauzas(15:03:06) bauzas: ygl, efried: there, it is https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/compute/servers.py#L54214:09
*** andrea___ has quit IRC14:09
yglbauzas: I understand you are pointing to the code responsible for creating a server. I am asking how does the control get to that code in the first place ?14:10
yglbauzas: hope u understand14:10
*** lyan has joined #openstack-nova14:10
bauzasygl: no sorry I don't get you14:11
yglefried: hope u understood my question14:13
yglbauzas: anyway thanks for your help bauzas14:13
efriedygl I'm not sure.  I think what you're asking is what handles the actual incoming HTTP request and invokes the code bauzas pointed to above?14:13
yglefried: exactly14:14
*** andreas_s has joined #openstack-nova14:14
efriedygl Okay, so that's wsgi magic that I don't understand.  There's some kind of declarative syntax with decorators registering hooks in the wsgi server or some craziness.  sdague is this in your wheelhouse?  mtreinish maybe?14:15
yglefried: if you find anything please let me know on my email at ygk.kmr@gmail.com14:16
yglefried: thanks so much for your time and help14:16
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Fix foreign key constraint error  https://review.openstack.org/51688014:16
efriedygl You're welcome.14:16
*** links has quit IRC14:18
efriedmriedem FYI, https://review.openstack.org/#/c/519034/ has passed that test six times in a row now.  Which of course proves nothing.14:18
bauzasygl: magic is there for routing https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/compute/routes.py14:19
bauzasygl, efried: in particular for your concern https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/compute/routes.py#L77714:19
*** edmondsw has quit IRC14:20
bauzasthat's how we map an entrypoint14:20
efriedbauzas Beautiful, thanks.14:20
*** edmondsw has joined #openstack-nova14:20
*** edmondsw has quit IRC14:21
*** edmondsw has joined #openstack-nova14:21
*** liverpooler has quit IRC14:22
*** liverpooler has joined #openstack-nova14:23
yglbauzas: thats awesome14:23
bauzasthat's just the routing logic14:24
bauzasnot the WSGI call itself14:24
*** yamamoto has joined #openstack-nova14:25
yglbauzas: ok14:26
yglbauzas: I think to know how the routing works, we have to learn about wsgi framework in python14:27
*** gongysh has joined #openstack-nova14:27
bauzasygl: that routing logic is very nova-specific14:27
*** gongysh has quit IRC14:27
yglbauzas: ok14:27
bauzasygl: you can find many other python frameworks that do that for you14:27
yglbauzas: hmm14:28
bauzaslike, placement is having a separate routing mechanism AFAIK14:28
*** Tom has joined #openstack-nova14:28
*** Tom is now known as Guest3644314:29
*** andreas_s has quit IRC14:29
bauzasyeah, it uses wsgify14:30
*** belmoreira has quit IRC14:30
*** udesale has quit IRC14:30
yglbauzas: thanks for your time14:31
bauzasyeah, placement is totally different https://github.com/openstack/nova/blob/stable/pike/nova/api/openstack/placement/handler.py14:31
*** eharney has joined #openstack-nova14:31
bauzasygl: so that really depends on your wishes14:31
yglbauzas: you are the first personto help me with the code flow of nova thanks for that14:32
*** belmoreira has joined #openstack-nova14:32
bauzasnp14:32
*** tssurya has quit IRC14:33
*** awaugama has joined #openstack-nova14:33
*** smatzek has quit IRC14:33
openstackgerritDavid Wahlstrom proposed openstack/nova master: Fix changes-since search filter  https://review.openstack.org/51935614:34
*** smatzek has joined #openstack-nova14:34
*** yamamoto has quit IRC14:34
*** ygl has quit IRC14:35
openstackgerritDavid Wahlstrom proposed openstack/nova master: Fix changes-since search filter  https://review.openstack.org/51935614:35
openstackgerritDavid Wahlstrom proposed openstack/nova master: Fix changes-since search filter  https://review.openstack.org/51935614:36
*** andreas_s has joined #openstack-nova14:37
*** smatzek has quit IRC14:38
*** edand has joined #openstack-nova14:39
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands  https://review.openstack.org/48740514:40
*** mvk has quit IRC14:41
*** janki has quit IRC14:41
sdagueefried: you good now, or are there more questions?14:43
efriedsdague I believe bauzas answered everything, thanks.14:43
sdagueok, great14:43
*** lbragstad has joined #openstack-nova14:44
*** amodi has joined #openstack-nova14:45
*** tssurya has joined #openstack-nova14:47
*** lbragstad has quit IRC14:48
jianghuawbauzas, dansmith, alex_xu: It's appreciated a lot if you can help to review these patches on vGPU: https://review.openstack.org/#/q/topic:bp/add-support-for-vgpu+(status:open)14:49
jianghuawWith these patches, the simple vGPU feature works well for XenAPI.14:49
bauzasjianghuaw: of course, will do14:50
jianghuawbauzas, thanks:-)14:51
bauzasjianghuaw: just a bit sick today, and still jetlagging from the summit, so don't expect full steam ahead until tomorrow hopefully :)14:51
jianghuawbauzas, ah. Sorry for that. Take care and hope you will be well soon.14:53
*** READ10 has joined #openstack-nova14:53
*** mriedem has quit IRC14:55
*** mvk has joined #openstack-nova14:55
*** armax has joined #openstack-nova14:56
openstackgerritBalazs Gibizer proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs  https://review.openstack.org/51938014:57
gibiefried, jaypipes: I found another / simpler case to reproduce bug 173107214:58
openstackbug 1731072 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters returns garbage with multiple aggregates" [Undecided,New] https://launchpad.net/bugs/173107214:58
*** mriedem has joined #openstack-nova14:58
*** edand has quit IRC14:58
efriedgibi Looking...14:59
efried(gibi FYI, Jay's out training today)14:59
*** lbragstad has joined #openstack-nova14:59
gibiefried: basically you don't need overlapping RCs to see the bug15:00
*** yamahata has joined #openstack-nova15:00
efriedgibi +1, nice.15:01
gibiefried: I realized that this could be a possible case when I read your regression test. Btw, that looks good so I'm going to +W it now15:02
*** mvk has quit IRC15:03
efriedgibi Thanks!15:03
gibiefried: thank your for the bug report and the regression test :)15:03
*** amodi has quit IRC15:03
*** takashin has left #openstack-nova15:04
*** hongbin has joined #openstack-nova15:05
*** gongysh has joined #openstack-nova15:05
*** sahid has quit IRC15:06
*** sahid_ has quit IRC15:06
*** sahid has joined #openstack-nova15:06
*** esberglu has joined #openstack-nova15:07
*** smatzek has joined #openstack-nova15:07
*** moshele has quit IRC15:07
*** smatzek has quit IRC15:07
*** smatzek has joined #openstack-nova15:07
*** gbarros has joined #openstack-nova15:08
*** Guest36443 has quit IRC15:08
*** msno has quit IRC15:08
*** mlavalle has joined #openstack-nova15:09
openstackgerritEric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests}  https://review.openstack.org/51409215:09
efriedgibi ^ rebased & fixed up that message, good catch.15:09
gibiefried: looking...15:10
efriedgibi Ahdang, missed an unused import.  One sec...15:10
openstackgerritEric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests}  https://review.openstack.org/51409215:11
efriedgibi Done.15:11
gibiefried: thanks for the update, +215:13
efriedThanks!15:14
*** Jack_Iv has quit IRC15:14
efriedgibi Don't know how much longer you're around, but if I can help tweak any of Jay's patches to get them moving, let me know.15:14
*** salv-orlando has quit IRC15:15
*** mvk has joined #openstack-nova15:15
*** salv-orlando has joined #openstack-nova15:15
*** amodi has joined #openstack-nova15:17
gibiefried: I think I still have an hour so you can hit me with a patch15:18
efriedgibi I was saying if you know of any of Jay's patches that need tweaks, I can get that done so we can keep them moving.15:19
efriedAt this point I guess everything he has is in merge conflict, so maybe I'll go start rebasing.15:19
*** salv-orlando has quit IRC15:20
efriedgibi Meanwhile, if you want some easy +Ws....15:20
*** Guest80344 has quit IRC15:21
efriedgibi https://review.openstack.org/#/c/516783/ and https://review.openstack.org/#/c/517626/15:21
gibiefried: ahh I underderstand now. I only see merge conflicts and patches waiting for others to look at15:21
*** sree has joined #openstack-nova15:21
gibiefried: looking...15:21
efriedgibi There's also one more bug-provin' patch for allocation candidates: https://review.openstack.org/#/c/518633/15:22
efriedgibi ...and the one you looked at earlier which I updated per your comments: https://review.openstack.org/#/c/518982/15:23
*** hemna_ has joined #openstack-nova15:23
*** sree has quit IRC15:26
gibiefried: yeah, I opened https://review.openstack.org/#/c/518633/ before but I think I need a fresh mind to walk throught he complexity there, so maybe tomorrow :)15:27
efriedokay15:27
gibiI looking that the test helper patch now15:27
gibithat looks good too15:32
*** gongysh has quit IRC15:33
openstackgerritBalazs Gibizer proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs  https://review.openstack.org/51938015:34
gibiI think I managed to make it even stranger ^^15:35
gibiI managed to get the same allocation candidate from placement twice15:35
*** liverpooler has quit IRC15:36
*** gouthamr_ has joined #openstack-nova15:41
*** gbarros has quit IRC15:41
*** tasker has joined #openstack-nova15:42
*** nicolasbock has joined #openstack-nova15:42
*** gouthamr_ is now known as gouthamr15:42
taskerwhen making a snapshot of a volume-backed instance, the nova driver will queisce the instance's volumes prior to the snapshot. it looks like if the instance fails a snapshot, the exception isn't caught and the instance and its volumes are never thawed: master/nova/compute/api.py#L273815:44
*** david-lyle has joined #openstack-nova15:44
taskeram I missing something? I'm still trying to trace through the code to see if the volumes are thawed after and exception. I can't find anything in launchpad regarding this either (could be that I'm not using the right search terms).15:45
mriedemtasker: which release?15:48
openstackgerritElod Illes proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase  https://review.openstack.org/49953915:50
openstackgerritElod Illes proposed openstack/nova master: factor out compute service start in ServerMovingTest  https://review.openstack.org/50303715:50
openstackgerritElod Illes proposed openstack/nova master: Change live_migrate tests to use fakedriver  https://review.openstack.org/50520215:50
openstackgerritElod Illes proposed openstack/nova master: Use FakeLiveMigrateDriver in notification test  https://review.openstack.org/51940515:50
taskerthe above is git master as of a few minutes ago.15:50
taskercommit a4fc1bcd15:51
taskerI have Mitaka in production where I noticed this problem and I see that function unchanged between Mitaka (commit 9825c80) and current master.15:52
*** slaweq has quit IRC15:52
*** dave-mccowan has joined #openstack-nova15:52
*** belmoreira has quit IRC15:53
*** andreas_s has quit IRC15:56
*** andreas_s has joined #openstack-nova15:57
*** tssurya has quit IRC15:57
*** andreas_s has quit IRC16:00
*** andreas_s has joined #openstack-nova16:00
*** belmoreira has joined #openstack-nova16:01
*** Apoorva has joined #openstack-nova16:01
taskerin my case, the snapshot failed due to OverLimit returned by the cinderclient. The exeception bubbles up, and I'm still not seeing anywhere that unquiesces / thaws the instance after the exception.16:01
*** jmlowe has joined #openstack-nova16:02
mriedemok i remember someone fixing the handling of the OverLimit from cinder, but would have to see if the unquiesce is ever run on failure16:05
mriedemthe overlimit used to cause a 500 response from the API16:05
*** alexchadin has quit IRC16:06
maciejjozefczykmriedem: We talked during summit about bug in calculating used resources in resource_tracker. The bug is there: https://bugs.launchpad.net/nova/+bug/172962116:07
openstackLaunchpad bug 1729621 in OpenStack Compute (nova) "Inconsistent value for vcpu_used" [Undecided,New]16:07
taskerthe traceback from this morning: http://paste.openstack.org/show/626180/16:07
maciejjozefczykI mentioned possible solutions (1. option imo seems to be the right one); could you take a look?16:08
*** nicolasbock has quit IRC16:09
*** liverpooler has joined #openstack-nova16:10
*** liverpooler has quit IRC16:15
*** salv-orlando has joined #openstack-nova16:16
mriedemmaciejjozefczyk: sure, thanks for pointing out the bu16:18
mriedem*bug16:18
*** tssurya has joined #openstack-nova16:20
mriedemmaciejjozefczyk: nice recreate :)16:20
*** salv-orlando has quit IRC16:21
*** Oku_OS is now known as Oku_OS-away16:22
*** andreas_s has quit IRC16:22
*** dinesh_ has joined #openstack-nova16:24
*** belmoreira has quit IRC16:25
*** andreas_s has joined #openstack-nova16:27
openstackgerritMerged openstack/nova master: Test allocation_candidates with only sharing RPs  https://review.openstack.org/51838216:28
taskermriedem: I'm not seeing so. the only time I see `unquiesce` called is from compute/api.py#L2807 after the volumes finish snapping. but there is no exception handling between quiesce and unquiesce. if an exception is raised, it goes right past the unuqiesce on its way out the stack.16:29
mriedemtasker: same here16:32
mriedemtasker: want to report a bug?16:32
openstackgerritMerged openstack/nova master: Update contributor microversion doc for compute  https://review.openstack.org/51762616:34
*** andreas_s has quit IRC16:36
efriedmriedem Do you want me to do anything with https://review.openstack.org/#/c/519034/ ?16:39
mriedemefried: not at this moment no16:40
mriedemefried: i'd like jaypipes to also know about this and look at it16:40
mriedemi'm playing catch up on internal stuff today16:40
efriedmriedem Okay.  Should I bother to keep rechecking it?  I'm convinced that it at least avoids the problem, though of course it's probably just masking the root cause.16:40
openstackgerritMerged openstack/nova master: placement: Contributor doc microversion checklist  https://review.openstack.org/51678316:42
mriedemefried: i'd like others more involved with placement code to look to see if they have any ideas on root cause16:42
mriedembecause i'm not sure why we'd be hitting this with a single scheduler CI job16:42
efriedrgr16:43
mriedemjohnthetubaguy: sdague: want to slam through this bit of spec accounting? https://review.openstack.org/#/c/516033/16:44
*** jpena is now known as jpena|brb16:44
mriedemstephenfin: you were +W on this before, just needed a rebase https://review.openstack.org/#/c/514782/16:44
*** psachin has quit IRC16:46
*** pcaruana has quit IRC16:49
*** lucasagomes is now known as lucas-afk16:53
*** dinesh_ has quit IRC16:53
dtantsurfolks, who's left the nova_cells meeting running? :)17:02
*** ricardoas has joined #openstack-nova17:03
efriedmriedem dansmith Do you have the power to #endmeeting for dtantsur ?17:03
dtantsurI suspect no17:04
dtantsursomebody unrelated has started it, sorry for noise here17:04
openstackgerritElod Illes proposed openstack/nova master: Transform instance-live_migration_pre notification  https://review.openstack.org/48207017:04
*** sapd_ has joined #openstack-nova17:04
*** sapd__ has quit IRC17:05
*** ragiman has quit IRC17:08
*** salv-orlando has joined #openstack-nova17:09
*** Guest68528 has quit IRC17:10
*** itlinux has joined #openstack-nova17:13
*** jmlowe has quit IRC17:17
*** itlinux has quit IRC17:18
*** fragatina has joined #openstack-nova17:20
*** Apoorva has quit IRC17:21
*** Apoorva has joined #openstack-nova17:21
*** ralonsoh has quit IRC17:22
*** sahid has quit IRC17:25
*** Apoorva has quit IRC17:27
*** jpena|brb is now known as jpena17:27
*** itlinux has joined #openstack-nova17:28
*** sshwarts has quit IRC17:30
openstackgerritMerged openstack/python-novaclient master: Updated from global requirements  https://review.openstack.org/51916517:31
*** itlinux has quit IRC17:32
*** fragatina has quit IRC17:32
*** moshele has joined #openstack-nova17:33
*** itlinux has joined #openstack-nova17:34
*** tesseract has quit IRC17:34
*** msno has joined #openstack-nova17:35
*** itlinux has quit IRC17:37
*** itlinux has joined #openstack-nova17:37
openstackgerritElod Illes proposed openstack/nova master: Functional test: evacuate with no compute  https://review.openstack.org/49848217:38
*** itlinux has quit IRC17:41
mriedemsdague: i'm +2 on the keypair reset during rebuild change now https://review.openstack.org/#/c/379128/17:42
taskermriedem: https://bugs.launchpad.net/nova/+bug/173198617:45
openstackLaunchpad bug 1731986 in OpenStack Compute (nova) "nova snapshot_volume_backed failure does not thaw filesystems" [Undecided,New]17:45
taskerI'm in the proccess of writing and testing a patch to get my production clusters moving. I"ll hopefully have a review for the patch this afternoon.17:46
*** itlinux has joined #openstack-nova17:46
mriedemtasker: cool, thanks17:46
*** Apoorva has joined #openstack-nova17:50
*** lpetrut_ has quit IRC17:54
*** moshele has quit IRC17:55
*** itlinux has quit IRC17:55
*** itlinux has joined #openstack-nova17:56
*** liverpooler has joined #openstack-nova17:57
*** itlinux has quit IRC17:59
*** itlinux has joined #openstack-nova18:00
*** itlinux has quit IRC18:03
openstackgerritMerged openstack/nova master: Updated from global requirements  https://review.openstack.org/51912718:03
*** itlinux has joined #openstack-nova18:04
sdaguemriedem: +A18:06
*** derekh has quit IRC18:06
sdaguetook me a second to understand the or on the json schema, but I think I get it now18:06
mriedemyeah the oneOf18:07
mriedemwe have that in the 'networks' entry in the server create schema too18:07
*** dtantsur is now known as dtantsur|afk18:09
*** fragatina has joined #openstack-nova18:09
*** ricardoas1 has joined #openstack-nova18:09
*** ricardoas has quit IRC18:12
*** msno has quit IRC18:13
*** ricardoas has joined #openstack-nova18:13
*** ricardoas1 has quit IRC18:14
*** msno has joined #openstack-nova18:17
*** mvk has quit IRC18:17
*** jpena is now known as jpena|off18:17
*** AlexeyAbashkin has quit IRC18:18
mriedemhmm, why is it that we don't dump config options when n-api starts up?18:19
mriedemi'm trying to fix the log formatting for placement-api in devstack, and the differences in the logs are a bit weird18:20
mriedemoh i see why18:20
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/placement/wsgi.py#L6018:21
openstackgerritSurya Seetharaman proposed openstack/nova master: instance_mapping/request_spec records exist even after the instances are archived  https://review.openstack.org/51503418:24
*** tssurya has left #openstack-nova18:26
*** slaweq has joined #openstack-nova18:36
openstackgerritMerged openstack/nova master: Fix missing versioned notification sample  https://review.openstack.org/51658218:38
*** rmart04 has joined #openstack-nova18:38
*** lpetrut_ has joined #openstack-nova18:47
*** sree has joined #openstack-nova18:48
*** smatzek has quit IRC18:52
*** smatzek has joined #openstack-nova18:52
*** rmart04 has quit IRC18:52
*** sree has quit IRC18:53
*** smatzek_ has joined #openstack-nova18:54
*** lpetrut_ has quit IRC18:56
*** smatzek has quit IRC18:56
*** gszasz has quit IRC18:57
*** Sukhdev has joined #openstack-nova18:57
*** tjones has joined #openstack-nova18:58
*** smatzek_ has quit IRC18:59
*** tjones_ has joined #openstack-nova19:01
*** gyee_ has joined #openstack-nova19:01
*** lpetrut_ has joined #openstack-nova19:02
*** slaweq has quit IRC19:03
*** tjones has quit IRC19:03
*** weshay is now known as weshay_bbiab19:03
*** tjones_ has quit IRC19:03
*** yamahata has quit IRC19:09
*** slaweq has joined #openstack-nova19:13
*** lpetrut_ has quit IRC19:13
*** lpetrut_ has joined #openstack-nova19:14
*** vivsoni__ has joined #openstack-nova19:14
*** moshele has joined #openstack-nova19:16
*** vivsoni_ has quit IRC19:17
*** jmlowe has joined #openstack-nova19:18
*** eharney has quit IRC19:22
*** artom_ has quit IRC19:28
*** eharney has joined #openstack-nova19:31
*** AlexeyAbashkin has joined #openstack-nova19:37
*** sree has joined #openstack-nova19:37
*** AlexeyAbashkin has quit IRC19:41
*** sree has quit IRC19:41
*** smatzek has joined #openstack-nova19:41
*** itlinux has quit IRC19:42
*** moshele has quit IRC19:43
*** xarlos has joined #openstack-nova19:48
xarlosHi all. I have just configured a number of nova node in separate region configs.19:49
*** esberglu has quit IRC19:50
*** esberglu has joined #openstack-nova19:50
xarlosHowever, when I run "openstack hypervisor list" I get 2 listed from one region in this region, and none over in another region. I'm a bit confused.19:50
xarlosI think I failed to add the region statement when I registered them using nova-manage.19:51
xarlosHow can I clear this out and get to re-add them? :-/19:51
*** weshay_bbiab is now known as weshay19:51
*** AlexeyAbashkin has joined #openstack-nova19:59
*** moshele has joined #openstack-nova20:01
*** AlexeyAbashkin has quit IRC20:06
*** AlexeyAbashkin has joined #openstack-nova20:06
openstackgerritMatt Riedemann proposed openstack/nova master: Log options at debug when starting API services under wsgi  https://review.openstack.org/51946220:07
openstackgerritEric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance on volume snapshot failure  https://review.openstack.org/51946420:12
mriedemtasker: we'll want a test for that20:12
taskerhope I got that submitted all right.20:12
mriedemwhen you get the time20:12
taskeroh, of course you will.  . )20:13
taskerlet me get some lunch.20:13
*** mikal_ is now known as mikal20:15
mriedemtasker: comments inline when you get back20:24
mriedemsmcginnis: any idea how graceful cinder is about deleting a snapshot that is being created? concurrent requests i mean.20:25
*** Alexey_Abashkin has joined #openstack-nova20:27
*** salv-orlando has quit IRC20:28
*** msno has quit IRC20:28
*** salv-orlando has joined #openstack-nova20:28
*** Alexey_Abashkin1 has joined #openstack-nova20:28
*** AlexeyAbashkin has quit IRC20:30
*** Alexey_Abashkin1 is now known as AlexeyAbashkin20:30
*** dklyle has joined #openstack-nova20:31
*** Alexey_Abashkin has quit IRC20:31
*** david-lyle has quit IRC20:31
*** salv-orlando has quit IRC20:33
taskermriedem: regarding your summary comment about splitting it up. after reviewing your comments I agree with you. how do you want me to proceed on that? resubmit with just the unqueisce and revisit the snapshot deletion later (after discussion about race) in another blueprint?20:35
*** awaugama has quit IRC20:35
mriedemtasker: i don't think we need a blueprint, it's just another patch related to the same bug20:36
mriedemtasker: but yeah split them up so quiesce is first and handled separately, we can backport that20:36
mriedemthen we'll see about the automatic cleanup of snapshots20:36
*** READ10 has quit IRC20:37
taskerok. I'll have that and a test (i hope) submitted in a little bit.20:37
*** eharney has quit IRC20:48
*** AlexeyAbashkin has quit IRC20:53
openstackgerritMerged openstack/nova master: Enable reset keypair while rebuilding instance  https://review.openstack.org/37912820:59
*** salv-orlando has joined #openstack-nova21:00
*** yamahata has joined #openstack-nova21:02
*** liverpooler has quit IRC21:07
*** Sukhdev has quit IRC21:12
*** moshele has quit IRC21:24
*** armax has quit IRC21:24
*** smatzek has quit IRC21:25
taskerthis url https://docs.openstack.org/nova/latest/reference/unit_tests.html is no longer valid. does anyone know where it ended up?21:26
mriedemtasker: https://docs.openstack.org/nova/latest/contributor/testing.html#unit-tests ?21:31
*** AlexeyAbashkin has joined #openstack-nova21:32
mriedemthat page linking to the hacking repo docs seems like the wrong thing to do...21:33
*** sree has joined #openstack-nova21:34
*** AlexeyAbashkin has quit IRC21:36
mriedemit was probably supposed to link to this https://github.com/openstack/nova/blob/master/HACKING.rst#creating-unit-tests21:37
*** amodi has quit IRC21:39
*** sree has quit IRC21:39
taskersorry -- got sidetracked because of /.21:40
taskerthe latter is where I ended up after some trolling.21:41
*** eharney has joined #openstack-nova21:45
*** redondo-mk_ has joined #openstack-nova21:46
*** tommylikehu_ has joined #openstack-nova21:46
*** vdrok_ has joined #openstack-nova21:46
*** fyxim_ has joined #openstack-nova21:46
*** icey_ has joined #openstack-nova21:46
*** johnsom_ has joined #openstack-nova21:46
*** patrickeast_ has joined #openstack-nova21:47
*** Hazelesque_ has joined #openstack-nova21:49
*** raorn_ has joined #openstack-nova21:49
*** liverpooler has joined #openstack-nova21:50
*** _gryf has joined #openstack-nova21:51
*** mwhahaha has quit IRC21:51
*** patrickeast has quit IRC21:51
*** ying_zuo has quit IRC21:51
*** icey has quit IRC21:51
*** johnsom has quit IRC21:51
*** fungi has quit IRC21:51
*** fyxim has quit IRC21:51
*** redondo-mk has quit IRC21:51
*** vdrok has quit IRC21:51
*** MasterofJOKers has quit IRC21:51
*** tommylikehu has quit IRC21:51
*** Hazelesque has quit IRC21:51
*** mgariepy has quit IRC21:51
*** gryf has quit IRC21:51
*** raorn has quit IRC21:51
*** redondo-mk_ is now known as redondo-mk21:51
*** patrickeast_ is now known as patrickeast21:51
*** icey_ is now known as icey21:51
*** tommylikehu_ is now known as tommylikehu21:51
*** fyxim_ is now known as fyxim21:51
*** vdrok_ is now known as vdrok21:51
*** johnsom_ is now known as johnsom21:51
mriedemi'll fix the link in our docs to point at nova/HACKING.rst, although that is pretty outdated21:52
mriedem1. use mock, not stubs or mox; 2. easiest to start with an existing test over the same function, copy it and tweak for what you need to test21:52
taskerthanks for the suggestion. I'm doing 2 now and just saw 1 in one of the other tests.21:52
mriedemthere might be an existing test for the OverLimit failure, and your change makes it fail if yo'ure not mocking out the unquiesce_instance call you added21:52
mriedemmtreinish: nova uses os-testr which uses stestr now right?21:52
mriedemso nova saying it's using testr isn't really accurate anymore21:52
*** MasterofJOKers has joined #openstack-nova21:52
mtreinishmriedem: actually nova is using stestr directly in most places now21:53
*** fungi has joined #openstack-nova21:53
mriedemah yeah stestr run '{posargs}'21:53
*** rmk has quit IRC21:54
*** dr_gogeta86 has quit IRC21:54
*** mgariepy has joined #openstack-nova21:55
*** dr_gogeta86 has joined #openstack-nova21:56
*** dr_gogeta86 has quit IRC21:56
*** dr_gogeta86 has joined #openstack-nova21:56
*** rmk has joined #openstack-nova21:56
*** rmk has quit IRC21:56
*** rmk has joined #openstack-nova21:56
*** mwhahaha has joined #openstack-nova21:56
mtreinishmriedem: if you're updating the nova docs, the user manual for stestr is: http://stestr.readthedocs.io/en/latest/MANUAL.html21:59
mriedemyup, just linking to the main index21:59
efriedpatchbot seems to be down22:04
*** rcernin has joined #openstack-nova22:09
*** mvk has joined #openstack-nova22:10
openstackgerritMatt Riedemann proposed openstack/nova master: doc: fix link to creating unit tests in contributor guide  https://review.openstack.org/51948222:15
mriedemefried: looks like it's working for me22:15
efriedmriedem Okay.  Maybe it just hates me.  I just rebased this whole series https://review.openstack.org/#/c/516778/ and nothing popped up.22:16
openstackgerritMichael Still proposed openstack/nova master: Move remaining uses of parted to privsep.  https://review.openstack.org/51948322:20
openstackgerritMichael Still proposed openstack/nova master: Convert users of tune2fs to privsep.  https://review.openstack.org/51948422:20
*** armax has joined #openstack-nova22:22
*** AlexeyAbashkin has joined #openstack-nova22:26
*** AlexeyAbashkin has quit IRC22:31
*** liverpooler has quit IRC22:34
*** sree has joined #openstack-nova22:34
*** esberglu_ has joined #openstack-nova22:35
*** slaweq has quit IRC22:36
*** esberglu has quit IRC22:39
*** sree has quit IRC22:42
*** esberglu_ has quit IRC22:43
*** esberglu has joined #openstack-nova22:44
*** lyan has quit IRC22:44
*** lpetrut_ has quit IRC22:44
*** esberglu has quit IRC22:48
squidhi, i seem to sporadically have nova snapshots failing, with rbd as the backend, it throws the error "ERROR oslo_messaging.rpc.server ImageNotAuthorized: Not authorized for image fc378659-9d6f-41d6-8c7f-a7d08c2bdb54"22:52
squidany idea what might be causing this?22:52
*** squid is now known as calebb22:52
calebbthis is using the faster rbd backend snapshots as well22:54
*** esberglu has joined #openstack-nova22:57
calebbsorry i'll put this in #openstack22:58
taskermost places I see ImageNotAuthorized being thrown are a synonym to HTTPForbidden. check the OpenStack user that's initiating the call. Also check the glance / rbd authentication and make sure that glance has proper access to the requisite pools.22:59
openstackgerritEric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs  https://review.openstack.org/51938022:59
efriedgibi Hey, I noticed that one of the other tests related to bug 1730730 started passing when incorporated into Jay's series, so I rebased yours on the same.23:00
openstackbug 1730730 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters returns garbage with only sharing providers" [Undecided,New] https://launchpad.net/bugs/173073023:00
efriedgibi The behavior changed - we're no longer getting the partial candidates (missing some resources).  But we are still getting the duplicates.  See above.23:01
calebbtasker: thanks, i'll look into those things more, but at first glance (heh) they seem correct23:05
openstackgerritEric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance on volume snapshot failure  https://review.openstack.org/51946423:06
*** xarlos has quit IRC23:06
taskerstill not seeing the test in my head yet. I've got one test at nova/tests/functional/regressions/test_bug_1554631.py that deals with cinder OverLimit but doesn't deal with the snapshot_volume_backed function. and then there's nova/tests/unit/compute/test_compute_api.py that has several tests of snapshot_volume_backed.23:08
*** imacdonn has joined #openstack-nova23:09
*** gouthamr has quit IRC23:09
taskeras best I can see it in my head, I want to mock the cinder_client. something like 1) cinder_client = mock({snapshot_volume.side_effect = cinderclient.exceptions.OverLimit}), 2) call snapshot_volume_backed with the mock cinder_client, 3) check that the proper exception was raised, and 4) check that the instance in unquiesecd / thawed.23:10
mriedemtasker: yes, i'd avoid the functional test you referenced, and just add a unit test23:11
taskerok.23:11
mriedemtest_bug_1554631 is dealing with the volume/snapshot proxy apis which are deprecated and not what you're trying to fix23:11
mriedemyou'll also need to mock out the quiesce_instance call so that it "passes"23:11
mriedemtasker: looks like you could hack something into test_snapshot_volume_backed_with_quiesce23:13
taskersorry .. first time using mock. so, this is a mock.patch(compute.api), altering quiesce_instance() and unquiesce_instance()?23:13
mriedemmake fake_volume_create_snapshot raise an exception23:13
mriedemi'm not sure that you'd need to mock anything in there23:14
*** esberglu has quit IRC23:15
*** mlavalle has quit IRC23:15
taskerI thought about tweaking compute/test_compute_api.py to fit my needs but thought that might be too much. instead, I've fretted all afternoon.  . /23:16
taskerI'll see what I can do with that.23:16
mriedemtasker: i'm thinking something like this http://paste.openstack.org/show/626204/23:17
taskeryeah .. that's right where I was heading.23:18
mriedemexcept self.compute_api.snapshot_volume_backed will raise that OverQuota failure, so you'd need to handle that as well23:18
taskerovers="snapshots"? what's 'overs'?23:19
mriedempart of the OverQuota error message23:19
mriedemit's a kwarg23:19
mriedemhttps://github.com/openstack/nova/blob/master/nova/exception.py#L105423:20
mriedemhttp://paste.openstack.org/show/626205/23:20
taskerand then use "tox" to test it?23:23
taskeror stestr?23:25
*** dikonoor has joined #openstack-nova23:28
mriedemtox23:32
mriedemtasker: you can just run that one test like so: tox -e py27 -- test_snapshot_volume_backed_with_quiesce_create_snap_fails23:32
mriedemand now i'm afk for awhile23:32
*** salv-orlando has quit IRC23:37
*** salv-orlando has joined #openstack-nova23:38
*** salv-orlando has quit IRC23:42
*** ying_zuo has joined #openstack-nova23:44
*** dikonoo has joined #openstack-nova23:45
*** gbarros has joined #openstack-nova23:46
openstackgerritEric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance on volume snapshot failure  https://review.openstack.org/51946423:46
taskermriedem: thanks for the help. got the test in place and it's passing. (never sure if that's a full good thing).23:47
*** dikonoor has quit IRC23:48
*** gcb has quit IRC23:49
*** gbarros has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!