Tuesday, 2017-11-14

*** jmlowe has quit IRC00:03
*** tbachman has quit IRC00:09
*** Sukhdev has joined #openstack-nova00:15
*** john5223_ has joined #openstack-nova00:16
*** hongbin has quit IRC00:23
*** gbarros has joined #openstack-nova00:27
*** edmondsw has quit IRC00:27
*** edmondsw has joined #openstack-nova00:28
*** edmondsw has quit IRC00:32
*** gbarros has quit IRC00:32
*** salv-orlando has joined #openstack-nova00:38
*** tbachman has joined #openstack-nova00:40
*** vladikr has quit IRC00:41
*** andreas_s has joined #openstack-nova00:42
*** qsyqian has joined #openstack-nova00:43
*** qsyqian has quit IRC00:43
*** salv-orlando has quit IRC00:43
*** andreas_s has quit IRC00:47
*** edmondsw has joined #openstack-nova00:51
*** sdague has quit IRC00:55
*** sree has joined #openstack-nova00:55
*** edmondsw has quit IRC00:55
*** Nil_ has quit IRC00:56
*** cheneydc has joined #openstack-nova00:57
*** TuanLA has joined #openstack-nova00:59
*** sree has quit IRC00:59
*** phuongnh has joined #openstack-nova01:06
*** ankit has joined #openstack-nova01:06
*** moshele has joined #openstack-nova01:13
*** yassine has joined #openstack-nova01:21
*** yassine is now known as Guest9581001:22
*** gongysh has joined #openstack-nova01:35
*** tetsuro has joined #openstack-nova01:38
*** salv-orlando has joined #openstack-nova01:39
openstackgerritYikun Jiang proposed openstack/nova master: Implement query param schema for migration index  https://review.openstack.org/51864401:40
*** sree has joined #openstack-nova01:42
*** gcb has joined #openstack-nova01:42
*** eharney has quit IRC01:42
*** salv-orlando has quit IRC01:44
*** Apoorva_ has joined #openstack-nova01:44
*** sree has quit IRC01:46
*** Apoorva has quit IRC01:48
*** Apoorva_ has quit IRC01:49
*** moshele has quit IRC01:50
*** mriedem has quit IRC01:54
*** moshele has joined #openstack-nova01:56
*** artom_ has joined #openstack-nova02:01
*** sbezverk has quit IRC02:03
*** moshele has quit IRC02:07
*** READ10 has joined #openstack-nova02:08
*** sbezverk has joined #openstack-nova02:09
*** Tom has joined #openstack-nova02:12
*** Tom is now known as Guest9579402:12
*** Guest95794 is now known as Tommy_02:12
*** Tommy_ is now known as Guest7441002:13
*** namnh has joined #openstack-nova02:13
*** takashin has joined #openstack-nova02:13
*** Guest74410 has quit IRC02:13
*** Tom-Tom has joined #openstack-nova02:13
openstackgerritlicanwei proposed openstack/nova master: cli 'nova-manage db sync' can't upgrade cell1  https://review.openstack.org/51927502:15
*** annp has joined #openstack-nova02:16
*** links has joined #openstack-nova02:17
*** vladikr has joined #openstack-nova02:21
*** sapd__ has joined #openstack-nova02:24
*** sapd_ has quit IRC02:24
*** bkopilov has quit IRC02:25
*** tetsuro has quit IRC02:29
*** vladikr has quit IRC02:30
*** yamahata has quit IRC02:30
*** Shunli has joined #openstack-nova02:31
*** sapcc-bot has quit IRC02:35
*** READ10 has quit IRC02:35
*** sapcc-bot has joined #openstack-nova02:35
*** salv-orlando has joined #openstack-nova02:40
openstackgerritEric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters()  https://review.openstack.org/51678202:43
openstackgerritEric Fried proposed openstack/nova master: required traits for no sharing providers  https://review.openstack.org/51702702:43
openstackgerritEric Fried proposed openstack/nova master: Add ProviderSummary.resource_class_names @property  https://review.openstack.org/51764602:43
openstackgerritEric Fried proposed openstack/nova master: handle traits with sharing providers  https://review.openstack.org/51711902:43
openstackgerritEric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs  https://review.openstack.org/51938002:43
openstackgerritYikun Jiang proposed openstack/nova master: Implement query param schema for migration index  https://review.openstack.org/51864402:43
*** salv-orlando has quit IRC02:44
*** gyee_ has quit IRC02:47
*** hongbin has joined #openstack-nova02:53
*** ankit has quit IRC02:55
*** READ10 has joined #openstack-nova02:55
*** sree has joined #openstack-nova03:02
*** fragatina has quit IRC03:03
*** fragatina has joined #openstack-nova03:03
*** sree has quit IRC03:06
*** fragatin_ has joined #openstack-nova03:07
*** fragatina has quit IRC03:07
*** fragatin_ has quit IRC03:11
openstackgerritYikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils  https://review.openstack.org/51887103:17
*** sapd_ has joined #openstack-nova03:17
*** sapd__ has quit IRC03:18
*** gbarros has joined #openstack-nova03:18
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040603:18
openstackgerritYikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations  https://review.openstack.org/51727303:18
*** itlinux has joined #openstack-nova03:23
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040603:24
*** fragatina has joined #openstack-nova03:25
*** Shunli has quit IRC03:27
*** takashin has quit IRC03:27
*** takashin has joined #openstack-nova03:28
*** hemna_ has quit IRC03:29
*** READ10 has quit IRC03:29
*** fragatina has quit IRC03:29
*** trungnv has quit IRC03:31
*** msno has joined #openstack-nova03:35
*** salv-orlando has joined #openstack-nova03:41
*** akekane has joined #openstack-nova03:41
*** akekane is now known as abhishekk03:41
*** trungnv has joined #openstack-nova03:43
*** salv-orlando has quit IRC03:45
*** gongysh has quit IRC03:46
*** bkopilov has joined #openstack-nova03:48
*** yamamoto has joined #openstack-nova03:52
*** lei-zh has joined #openstack-nova03:52
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2)  https://review.openstack.org/40895503:56
*** Apoorva has joined #openstack-nova03:56
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060803:57
*** vivsoni__ has quit IRC03:59
*** vivsoni has joined #openstack-nova03:59
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and changes-since for instance-actions  https://review.openstack.org/32632604:02
*** itlinux has quit IRC04:03
*** msno has quit IRC04:03
*** udesale has joined #openstack-nova04:04
*** itlinux has joined #openstack-nova04:04
*** itlinux has quit IRC04:09
*** mdnadeem has joined #openstack-nova04:12
*** lei-zh has quit IRC04:17
*** psachin has joined #openstack-nova04:18
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040604:18
*** dave-mccowan has quit IRC04:19
*** itlinux has joined #openstack-nova04:20
*** andreas_s has joined #openstack-nova04:25
*** andreas_s has quit IRC04:29
*** psachin has quit IRC04:38
*** salv-orlando has joined #openstack-nova04:41
*** hieulq has quit IRC04:43
*** TuanLA has quit IRC04:43
*** TuanLA has joined #openstack-nova04:44
*** hieulq has joined #openstack-nova04:44
*** salv-orlando has quit IRC04:46
*** psachin has joined #openstack-nova04:46
*** TuanLA has quit IRC04:47
*** itlinux has quit IRC04:52
*** gbarros has quit IRC04:55
*** hongbin has quit IRC05:01
*** msno has joined #openstack-nova05:04
*** tetsuro has joined #openstack-nova05:05
*** sapd__ has joined #openstack-nova05:09
*** sapd_ has quit IRC05:10
*** sree has joined #openstack-nova05:13
*** sree_ has joined #openstack-nova05:14
*** sree_ is now known as Guest2342305:14
*** tbachman_ has joined #openstack-nova05:16
*** sree has quit IRC05:17
*** tbachman has quit IRC05:18
*** tbachman_ is now known as tbachman05:18
openstackgerritTakashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2)  https://review.openstack.org/40896405:19
*** sbezverk has quit IRC05:20
*** Apoorva has quit IRC05:27
*** yamahata has joined #openstack-nova05:31
*** janki has joined #openstack-nova05:34
*** diga has joined #openstack-nova05:40
*** yangyapeng has joined #openstack-nova05:41
*** salv-orlando has joined #openstack-nova05:42
*** erlon has quit IRC05:45
*** salv-orlando has quit IRC05:47
*** moshele has joined #openstack-nova05:51
*** msno has quit IRC05:54
*** hshiina has joined #openstack-nova05:55
*** ratailor has joined #openstack-nova06:00
*** dikonoor has joined #openstack-nova06:01
*** lpetrut_ has joined #openstack-nova06:01
*** dikonoo has quit IRC06:02
*** sridharg has joined #openstack-nova06:02
*** janki has quit IRC06:05
*** tetsuro has quit IRC06:05
*** janki has joined #openstack-nova06:20
*** trinaths has joined #openstack-nova06:25
*** Guest23423 has quit IRC06:28
*** salv-orlando has joined #openstack-nova06:30
openstackgerritMerged openstack/nova master: Correct log message when removing a security group  https://review.openstack.org/51931306:44
*** yangyapeng has quit IRC06:46
*** yangyapeng has joined #openstack-nova06:47
*** armax has quit IRC06:50
*** armax has joined #openstack-nova06:51
*** sahid has joined #openstack-nova06:51
*** armax has quit IRC06:51
*** armax has joined #openstack-nova06:52
*** armax has quit IRC06:52
*** mtreinish has quit IRC06:55
*** mtreinish has joined #openstack-nova06:55
*** lpetrut_ has quit IRC07:00
*** rcernin has quit IRC07:02
*** belmoreira has joined #openstack-nova07:05
*** edand has joined #openstack-nova07:08
*** andreas_s has joined #openstack-nova07:11
*** Oku_OS-away is now known as Oku_OS07:12
*** hoonetorg has quit IRC07:15
*** fragatina has joined #openstack-nova07:15
*** hieulq has quit IRC07:16
*** namnh has quit IRC07:16
*** phuongnh has quit IRC07:16
*** annp has quit IRC07:16
*** annp has joined #openstack-nova07:16
*** phuongnh has joined #openstack-nova07:16
*** namnh has joined #openstack-nova07:16
*** hieulq has joined #openstack-nova07:16
openstackgerritYikun Jiang proposed openstack/nova master: Add migration_get_by_uuid in db api.  https://review.openstack.org/51142107:18
openstackgerritYikun Jiang proposed openstack/nova master: Add migration db and object pagination support.  https://review.openstack.org/51490407:18
openstackgerritYikun Jiang proposed openstack/nova master: Implement query param schema for migration index  https://review.openstack.org/51864407:18
openstackgerritYikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils  https://review.openstack.org/51887107:18
openstackgerritYikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations  https://review.openstack.org/51727307:18
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040607:18
*** sshwarts has joined #openstack-nova07:19
*** fragatina has quit IRC07:20
openstackgerritNguyen Van Trung proposed openstack/nova-specs master: Add linters test to run spec validation  https://review.openstack.org/51956107:20
*** xinliang has quit IRC07:21
openstackgerritYikun Jiang proposed openstack/nova master: Implement query param schema for migration index  https://review.openstack.org/51864407:22
*** belmoreira has quit IRC07:23
openstackgerritYikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils  https://review.openstack.org/51887107:24
openstackgerritYikun Jiang proposed openstack/nova master: Extract SortContext/SortWrapper of instance_list into utils  https://review.openstack.org/51887107:25
openstackgerritYikun Jiang proposed openstack/nova master: Add cross cell sort support for get_migrations  https://review.openstack.org/51727307:25
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040607:26
*** hoonetorg has joined #openstack-nova07:29
*** ratailor is now known as ratailor|Lu07:33
*** ratailor|Lu is now known as ratailor|Lunch07:33
*** xinliang has joined #openstack-nova07:34
*** salv-orlando has quit IRC07:36
*** salv-orlando has joined #openstack-nova07:36
*** Tom-Tom has quit IRC07:39
*** salv-orlando has quit IRC07:40
*** salv-orlando has joined #openstack-nova07:47
*** snasir has quit IRC07:47
*** snasir has joined #openstack-nova07:48
*** Tom-Tom has joined #openstack-nova07:51
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.54 - Enable reset keypair while rebuild  https://review.openstack.org/51957207:51
*** alexchadin has joined #openstack-nova07:54
*** abhishekk has quit IRC07:58
*** naichuans has quit IRC07:59
*** naichuans has joined #openstack-nova07:59
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.55 - Enable cold migration with target host  https://review.openstack.org/40670708:06
*** takashin has left #openstack-nova08:07
*** ralonsoh has joined #openstack-nova08:09
*** yamamoto has quit IRC08:09
*** pcaruana has joined #openstack-nova08:10
*** yangyapeng has quit IRC08:10
*** yamamoto has joined #openstack-nova08:12
*** yangyapeng has joined #openstack-nova08:12
*** yamamoto has quit IRC08:12
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040608:13
*** tesseract has joined #openstack-nova08:15
*** phuongnh has quit IRC08:15
*** liusheng has quit IRC08:16
*** Sukhdev has quit IRC08:16
*** phuongnh has joined #openstack-nova08:17
*** liusheng has joined #openstack-nova08:17
*** links has quit IRC08:17
openstackgerritNguyen Van Trung proposed openstack/nova-specs master: Add linters test to run spec validation  https://review.openstack.org/51956108:23
*** salv-orlando has quit IRC08:24
*** dikonoor has quit IRC08:25
*** dikonoor has joined #openstack-nova08:26
openstackgerritRodolfo Alonso Hernandez proposed openstack/nova master: Change 'InstancePCIRequest' spec field  https://review.openstack.org/44925708:26
*** links has joined #openstack-nova08:31
*** yingjun has joined #openstack-nova08:35
*** qsyqian has joined #openstack-nova08:39
*** yamamoto has joined #openstack-nova08:41
*** salv-orlando has joined #openstack-nova08:42
*** yamahata has quit IRC08:44
*** AlexeyAbashkin has joined #openstack-nova08:47
openstackgerritSaverio Proto proposed openstack/nova stable/pike: Correct log message when removing a security group  https://review.openstack.org/51958308:48
*** ratailor|Lunch is now known as ratailor08:48
*** yamamoto has quit IRC08:50
openstackgerritSaverio Proto proposed openstack/nova stable/pike: Correct log message when removing a security group  https://review.openstack.org/51958308:51
*** jpena|off is now known as jpena08:52
openstackgerritSaverio Proto proposed openstack/nova stable/ocata: Correct log message when removing a security group  https://review.openstack.org/51958508:53
*** trungnv has quit IRC08:53
*** priteau has joined #openstack-nova08:54
openstackgerritSaverio Proto proposed openstack/nova stable/newton: Correct log message when removing a security group  https://review.openstack.org/51958608:54
*** sapd__ has quit IRC08:56
*** sapd__ has joined #openstack-nova08:57
*** rmart04 has joined #openstack-nova09:02
*** Tom-Tom has quit IRC09:06
*** Tom-Tom has joined #openstack-nova09:06
openstackgerritLi Yingjun proposed openstack/nova master: Versioned notifications for service create and delete  https://review.openstack.org/51958809:07
*** links has quit IRC09:07
*** Tom-Tom has quit IRC09:10
*** Tom-Tom has joined #openstack-nova09:13
*** cheneydc has quit IRC09:13
*** cheneydc has joined #openstack-nova09:14
*** trungnv has joined #openstack-nova09:15
*** qsyqian has quit IRC09:15
*** salv-orlando has quit IRC09:20
*** markvoelker has quit IRC09:21
*** links has joined #openstack-nova09:21
*** salv-orlando has joined #openstack-nova09:22
*** cheneydc has quit IRC09:23
*** jianghuaw has quit IRC09:26
*** salv-orlando has quit IRC09:26
*** Tom-Tom has quit IRC09:26
*** akekane has joined #openstack-nova09:27
*** Tom-Tom has joined #openstack-nova09:27
*** akekane is now known as abhishekk09:27
*** qsyqian has joined #openstack-nova09:29
*** slaweq has joined #openstack-nova09:31
*** Tom-Tom has quit IRC09:31
*** trungnv has quit IRC09:32
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and changes-since for instance-actions  https://review.openstack.org/32632609:33
*** yingjun has quit IRC09:34
*** Tom-Tom has joined #openstack-nova09:35
*** derekh has joined #openstack-nova09:39
*** lucas-afk is now known as lucasagomes09:39
*** andreas__ has joined #openstack-nova09:41
*** andreas_s has quit IRC09:45
*** trinaths has left #openstack-nova09:53
*** Tom-Tom has quit IRC09:54
*** jianghuaw has joined #openstack-nova09:55
*** yangyapeng has quit IRC09:56
*** yangyapeng has joined #openstack-nova09:57
*** abhishekk has quit IRC09:57
*** jianghuaw has quit IRC09:57
*** jianghuaw has joined #openstack-nova09:58
*** yamamoto has joined #openstack-nova10:01
*** dikonoor has quit IRC10:01
*** dikonoor has joined #openstack-nova10:01
*** namnh has quit IRC10:04
*** annp has quit IRC10:04
*** diga has quit IRC10:05
*** yangyapeng has quit IRC10:05
*** salv-orlando has joined #openstack-nova10:08
*** salv-orlando has quit IRC10:11
*** salv-orlando has joined #openstack-nova10:11
*** tssurya has joined #openstack-nova10:14
*** felipemonteiro has joined #openstack-nova10:16
*** qsyqian has quit IRC10:17
openstackgerritBalazs Gibizer proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs  https://review.openstack.org/51960110:17
openstackgerritRajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive  https://review.openstack.org/49833410:17
*** Tom-Tom has joined #openstack-nova10:18
gibiefried: thanks for the rebase of my rp test patch it make sense to move that10:18
gibiefried, jaypipes: I discovered a debatable edge case with shared RPs in https://review.openstack.org/#/c/519601/10:19
gibiefried, jaypipes: it is all about indirectly sharing resources through a non sharing RP10:19
openstackgerritRajesh Tailor proposed openstack/nova master: Fix case-sensitivity for metadata keys  https://review.openstack.org/50488510:20
*** markvoelker has joined #openstack-nova10:21
*** Tom-Tom has quit IRC10:22
*** diga has joined #openstack-nova10:24
*** lpetrut_ has joined #openstack-nova10:25
*** ratailor has quit IRC10:26
*** ratailor_ has joined #openstack-nova10:26
openstackgerritBalazs Gibizer proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs  https://review.openstack.org/51960110:27
*** akekane has joined #openstack-nova10:27
*** akekane is now known as abhishekk10:27
*** sdague has joined #openstack-nova10:32
*** qsyqian has joined #openstack-nova10:33
*** yamamoto has quit IRC10:36
*** yamamoto has joined #openstack-nova10:36
*** qsyqian has quit IRC10:37
*** claudiub has joined #openstack-nova10:39
*** FL1SK has quit IRC10:41
*** alexchadin has quit IRC10:42
*** alexchadin has joined #openstack-nova10:42
*** yangyapeng has joined #openstack-nova10:42
*** yangyapeng has quit IRC10:51
*** andreas__ has quit IRC10:53
*** yangyapeng has joined #openstack-nova10:53
*** jianghuaw has quit IRC10:56
*** sridharg has quit IRC10:58
*** andreas_s has joined #openstack-nova10:58
*** udesale has quit IRC11:00
*** ratailor_ has quit IRC11:00
*** abhishekk has quit IRC11:02
*** andreas_s has quit IRC11:02
*** dikonoor has quit IRC11:02
*** alexchadin has quit IRC11:02
*** dikonoor has joined #openstack-nova11:03
*** andreas_s has joined #openstack-nova11:03
openstackgerritBalazs Gibizer proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs  https://review.openstack.org/51961711:06
*** andreas_s has quit IRC11:07
gibiefried, jaypipes: One more set of test case now for CN1 <- SS -> CN2 type of setup. Simple case works but a more complicated one mixes unconnected RPs: https://review.openstack.org/#/c/519617/11:08
*** andreas_s has joined #openstack-nova11:08
*** alexchadin has joined #openstack-nova11:10
*** gouthamr has joined #openstack-nova11:10
*** andreas_s has quit IRC11:12
*** andreas_s has joined #openstack-nova11:13
*** salv-orlando has quit IRC11:19
*** salv-orlando has joined #openstack-nova11:19
*** dtantsur|afk is now known as dtantsur11:20
*** qsyqian has joined #openstack-nova11:22
*** andreas_s has quit IRC11:22
*** jianghuaw has joined #openstack-nova11:26
*** andreas_s has joined #openstack-nova11:27
*** akekane has joined #openstack-nova11:27
jianghuawbauzas: Can we make this common patch be merged or still need further actions? https://review.openstack.org/#/c/512580/11:28
*** akekane has quit IRC11:28
*** qsyqian has quit IRC11:30
*** andreas_s has quit IRC11:32
moshelestephenfin: hi11:33
*** andreas_s has joined #openstack-nova11:35
*** gszasz has joined #openstack-nova11:35
mosheleramishra11:37
*** felipemonteiro has quit IRC11:38
*** qsyqian has joined #openstack-nova11:43
*** bhagyashri_s is now known as bhagyashris11:43
*** andreas_s has quit IRC11:43
*** andreas_s has joined #openstack-nova11:44
*** bkopilov has quit IRC11:44
openstackgerritJianghua Wang proposed openstack/nova master: vgpu: add enabled white list  https://review.openstack.org/51258011:51
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: get vGPU stats from hypervisor  https://review.openstack.org/51296511:51
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: provide vGPU inventory in compute node  https://review.openstack.org/51621711:51
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance  https://review.openstack.org/51689911:51
*** tbachman has quit IRC11:54
openstackgerritYikun Jiang proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040611:55
openstackgerritMerged openstack/nova master: Handle InstanceNotFound when setting password via metadata  https://review.openstack.org/47293311:58
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance  https://review.openstack.org/51689911:59
*** ratailor has joined #openstack-nova12:00
*** phuongnh has quit IRC12:01
*** alexchadin has quit IRC12:02
*** alexchadin has joined #openstack-nova12:03
*** nsingh has quit IRC12:05
*** gouthamr has quit IRC12:05
*** lucasagomes is now known as lucas-hungry12:06
*** niraj_singh has joined #openstack-nova12:06
*** udesale has joined #openstack-nova12:07
openstackgerritElod Illes proposed openstack/nova master: Deduplicate server_group samples  https://review.openstack.org/51962912:09
*** dikonoor has quit IRC12:09
*** yangyapeng has quit IRC12:10
openstackgerritMatthew Booth proposed openstack/nova stable/pike: libvirt: bandwidth param should be set in guest migrate  https://review.openstack.org/51963112:10
openstackgerritMatthew Booth proposed openstack/nova stable/pike: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks  https://review.openstack.org/51963212:10
*** yangyapeng has joined #openstack-nova12:10
*** smatzek has joined #openstack-nova12:10
*** yangyapeng has quit IRC12:18
*** gouthamr has joined #openstack-nova12:20
openstackgerritMatthew Booth proposed openstack/nova stable/ocata: libvirt: bandwidth param should be set in guest migrate  https://review.openstack.org/51963512:22
openstackgerritMatthew Booth proposed openstack/nova stable/ocata: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks  https://review.openstack.org/51963612:22
*** sbezverk has joined #openstack-nova12:24
*** qsyqian has quit IRC12:33
*** ratailor has quit IRC12:35
openstackgerritMerged openstack/nova master: block_device_mapping_v2.bus_type is missing from api-ref  https://review.openstack.org/49948812:37
openstackgerritMerged openstack/nova master: Fix test_get_volume_config method  https://review.openstack.org/48946712:37
*** ttsiouts has quit IRC12:37
openstackgerritMerged openstack/nova master: Fix wrapping of neutron forbidden error  https://review.openstack.org/50880212:37
*** tssurya has quit IRC12:40
*** sridharg has joined #openstack-nova12:41
*** ricardoas has quit IRC12:41
*** rcernin has joined #openstack-nova12:44
efriedgibi Thanks for the new tests, will look shortly.12:45
*** zhurong has joined #openstack-nova12:46
*** sean-k-mooney has joined #openstack-nova12:48
*** FL1SK has joined #openstack-nova12:50
*** belmoreira has joined #openstack-nova12:50
*** bkopilov has joined #openstack-nova12:53
*** gouthamr has quit IRC12:53
*** tssurya has joined #openstack-nova12:55
*** lucas-hungry is now known as lucasagomes12:55
*** links has quit IRC12:56
*** gszasz has quit IRC12:59
*** gouthamr has joined #openstack-nova13:02
openstackgerritEric Fried proposed openstack/nova master: placement: add nested resource providers  https://review.openstack.org/37713813:03
openstackgerritEric Fried proposed openstack/nova master: placement: allow filter providers in tree  https://review.openstack.org/37721513:03
openstackgerritEric Fried proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480713:03
openstackgerritEric Fried proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569313:03
openstackgerritEric Fried proposed openstack/nova master: Reformat _get_all_with_shared  https://review.openstack.org/51279913:03
efriedgibi ^ includes re-inserting that busted dependency in the middle.13:03
*** liverpooler has joined #openstack-nova13:04
*** gszasz has joined #openstack-nova13:04
*** tssurya has quit IRC13:05
openstackgerritEric Fried proposed openstack/nova master: placement: add nested resource providers  https://review.openstack.org/37713813:06
openstackgerritEric Fried proposed openstack/nova master: placement: allow filter providers in tree  https://review.openstack.org/37721513:06
openstackgerritEric Fried proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480713:06
openstackgerritEric Fried proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569313:06
openstackgerritEric Fried proposed openstack/nova master: Reformat _get_all_with_shared  https://review.openstack.org/51279913:06
efriedDang, missed a rename, fixed ^13:06
*** vladikr has joined #openstack-nova13:07
*** yangyapeng has joined #openstack-nova13:08
gibiefried: your https://review.openstack.org/#/c/514092 bounced back from the gate as it needs a rebase and a unit test fix13:08
*** andreas_s has quit IRC13:08
efriedgibi Thanks, on it.13:09
*** diga has quit IRC13:10
*** jpena is now known as jpena|lunch13:11
*** tbachman has joined #openstack-nova13:12
*** liverpooler has quit IRC13:12
openstackgerritEric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests}  https://review.openstack.org/51409213:12
*** jaypipes has joined #openstack-nova13:12
efriedgibi ^ hecho13:13
efriedjaypipes Welcome back!13:13
*** yangyapeng has quit IRC13:13
*** liverpooler has joined #openstack-nova13:13
*** amodi has joined #openstack-nova13:13
jaypipesefried: heh, thanks :)13:13
*** andreas_s has joined #openstack-nova13:13
alex_xujaypipes: good morning!13:13
jaypipesalex_xu: is it? :)13:13
efriedFriday jaypipes open patches: 13; merge conflicts: 12.  Tuesday jaypipes open patches: 13; merge conflicts: 113:14
efriedI'd say that's a good morning.13:14
jaypipesefried: oh, excellent :)13:14
alex_xusounds like all of us are wating for you :)13:14
jaypipesalex_xu: yeah, had a "lovely" new-hire training session up in Tampa yesterday ...13:14
alex_xujaypipes: efried, just want to show you this patch https://review.openstack.org/51908113:15
alex_xunew-hire training is always lovely13:15
*** dave-mccowan has joined #openstack-nova13:15
openstackgerritEric Fried proposed openstack/nova master: placement: AllocCands.get_by_{filters => requests}  https://review.openstack.org/51409213:16
alex_xujaypipes: efried I didn't some test last week on 1w rps and probably 70% loads on each rp, then I found that sql is faster than the current one. The current one will spend 1.7s in my env, the new sql just spend 0.7s13:16
alex_xus/didn't/did/...13:16
*** Tom-Tom has joined #openstack-nova13:16
*** edand has quit IRC13:17
efriedalex_xu It was on my list to look at.  I wanted to scrutinize the functional test a bit.13:17
jaypipesalex_xu: what is 1w rps?13:17
*** tssurya has joined #openstack-nova13:17
alex_xuefried: ok, thanks13:18
alex_xujaypipes: 10000 resource providers...13:18
jaypipesalex_xu: can you put your DB setup into a pastebin please? # rps, inventory records used per rc, number of allocations used per rp, etc13:21
*** edmondsw has joined #openstack-nova13:22
alex_xujaypipes: ok13:22
*** yangyapeng has joined #openstack-nova13:23
*** ttsiouts has joined #openstack-nova13:23
*** artom_ has quit IRC13:24
*** erlon has joined #openstack-nova13:25
*** zhurong has quit IRC13:26
alex_xujaypipes: here is https://pastebin.com/kPMtEcQb, i just copy the variables from my script13:26
*** yangyapeng has quit IRC13:27
jaypipesalex_xu: k, thank you sir :) I'll run benchmarks later today.13:27
*** andreas_s has quit IRC13:27
*** andreas_s has joined #openstack-nova13:28
alex_xujaypipes: cool13:29
*** gszasz has quit IRC13:30
alex_xujaypipes: also a non-shared version at https://review.openstack.org/#/c/516778/6/nova/objects/resource_provider.py@251813:30
jaypipesalex_xu: k13:31
efriedalex_xu I rebased your patch on top of the pending series - the one with all the extra tests in it - and it's failing some stuff.13:31
*** fragatina has joined #openstack-nova13:31
*** ralonsoh has quit IRC13:32
efriedalex_xu There are a number of cases where it's returning zero candidates.13:32
jaypipesalex_xu: sum(invs.resource_class_id) is not what you're looking for there. I believe you're looking for count(distinct invs.resource_class_id)13:32
*** edand has joined #openstack-nova13:32
*** tbachman has quit IRC13:32
*** tbachman has joined #openstack-nova13:33
alex_xujaypipes: oops, that is true13:35
alex_xujaypipes: but it shoudl works with count13:35
jaypipesalex_xu: yep.13:35
alex_xuefried: sorry, which patch?13:35
efriedhttps://review.openstack.org/#/c/519081/13:35
jaypipesalex_xu: I'll benchmark later today. I have a dentist appointment shortly and will set up benchmarks after that13:35
alex_xujaypipes: ok, no problem13:36
*** fragatina has quit IRC13:36
alex_xuefried: ok, I will try to debug them13:37
efriedalex_xu Note that some of the test cases are highlighting bugs, so the current 'expected' value is wrong - but the correct 'expected' value is in the comments, and it still ain't []13:37
alex_xuefried: got it, thanks13:38
*** gouthamr has quit IRC13:38
*** links has joined #openstack-nova13:38
*** salv-orlando has quit IRC13:40
*** salv-orlando has joined #openstack-nova13:41
sean-k-mooneyjaypipes: o/13:42
gibiefried: thanks for the fix on the get_by_requests refactor patch. I'm +2.13:43
sean-k-mooneyjaypipes: can i get you to weigh in on a matter of os-vif policy. specifcally https://review.openstack.org/#/c/484386/ and the extention of our public api.13:43
gibiefried: Do you agree to move https://review.openstack.org/#/c/518633/ top of Jay's series as that will decrease the amount of visible bugs in the patch?13:43
sean-k-mooneyjaypipes: i -2'd the previous itteration that added a shared implementation to os-vif.common13:44
sean-k-mooneyjaypipes: it has now been split but sahid dislikes the code duplication in tree this causes13:44
sean-k-mooneyas a counter proposal the only path i see forward to not extend the publci api and avoid duplication is to have a os-vif.internal and use an assertion to ensure that no one else can import it like this http://paste.openstack.org/show/626267/. toughts?13:45
*** andreas_s has quit IRC13:46
*** andreas_s has joined #openstack-nova13:48
*** yangyapeng has joined #openstack-nova13:50
efriedgibi I was just looking at that.  In general I'm in favor of moving any test patches on top of that series, as it does seem to be resolving *some* issues.13:51
efriedgibi As we were discussing above, I'm also in favor of putting things like refactors on top of that series because the extra tests will flush out more bugs.13:52
efried(refactors of the prod code)13:52
gibiefried: cool. If you move that there I can quickly re-review and +2 it :)13:52
*** edmondsw_ has joined #openstack-nova13:53
*** esberglu has joined #openstack-nova13:54
*** lyan has joined #openstack-nova13:54
*** gouthamr has joined #openstack-nova13:54
*** edmondsw has quit IRC13:55
*** szaher has quit IRC13:58
*** yangyapeng has quit IRC13:58
*** edmondsw_ is now known as edmondsw13:59
*** edmondsw has quit IRC13:59
*** lajoskatona has quit IRC13:59
*** mriedem has joined #openstack-nova13:59
*** andreas_s has quit IRC14:01
*** szaher has joined #openstack-nova14:02
*** jianghuaw_ has joined #openstack-nova14:03
*** rmart04 has quit IRC14:04
*** rmart04 has joined #openstack-nova14:04
*** andreas_s has joined #openstack-nova14:05
*** rmart04 has quit IRC14:05
*** tbachman has quit IRC14:08
*** jpena|lunch is now known as jpena14:08
*** awaugama has joined #openstack-nova14:09
*** alexchadin has quit IRC14:10
*** hshiina has quit IRC14:11
*** gszasz has joined #openstack-nova14:12
*** edmondsw has joined #openstack-nova14:12
*** edleafe- is now known as edleafe14:13
*** efried has quit IRC14:14
* edleafe returns to Novaland14:14
*** Oku_OS has quit IRC14:17
gibiedleafe: welcome back14:19
bauzasedleafe: hope you didn't get sick and your IRC bouncer is fine, unlike me14:20
* bauzas still struggling with redeploying another ZNC instance14:21
bauzasoh, and my corp phone died too14:21
*** Oku_OS has joined #openstack-nova14:22
edleafebauzas: znc was humming along nicely in my absence14:23
edleafedon't know if I can read back that much :)14:23
bauzashah14:23
*** hamzy_ has quit IRC14:24
*** ralonsoh has joined #openstack-nova14:24
*** smatzek has quit IRC14:25
sean-k-mooneyhas anyone stacked on centos 7.4 recently14:25
*** efried has joined #openstack-nova14:27
*** yangyapeng has joined #openstack-nova14:29
kashyapDo people do that often?  I thought most do it only with Debian / Ubuntu / Fedora14:30
openstackgerritEric Fried proposed openstack/nova master: Test allocation candidates: multiple aggregates  https://review.openstack.org/51863314:31
efriedgibi ^ That was... interesting.14:31
*** gbarros has joined #openstack-nova14:31
sean-k-mooneykashyap: stack with centos?14:36
*** tbachman has joined #openstack-nova14:36
bhagyashrismriedem: Hi, I have one doubt regarding the instance snapshot. When I create the instance snapshot using the nova image-create <server-id> <snapshot-name> the it only creates the plain image that means it only calls the image-create and not image-upload and the image remains in queued status so How can I create instance snapshot in active state.14:36
sean-k-mooneykashyap: i normally do all my dev on ubuntu but i need to use centos currently because reasons....14:36
*** amodi has quit IRC14:36
*** moshele has quit IRC14:36
kashyapsean-k-mooney: Yeah14:37
gibiefried: did you encountered you type of problems during the rebase?14:38
kashyapsean-k-mooney: Might be also want check on #openstack-qa channel14:38
sean-k-mooneykashyap: fedora is rather fragile as its a bit too bleading edge14:38
*** yangyapeng has quit IRC14:38
efriedgibi The test results changed rather dramatically.14:38
kashyapsean-k-mooney: Yeah, bled this morning, trying to shave a yak.14:38
efriedgibi The good news is that all the results now at least seem to have the proper resources in them.14:38
efriedgibi I think the problems are now limited to crossing aggregates.14:39
sean-k-mooneykashyap: im currently hitting a issue with nova that is proably unrelated to centos to be honest just have not seen it last time i stacked on ubuntu. devstack is not finding the nova compute agent in the cells db and devstack is failing because of this14:39
gibiefried: I feel that is actually a good news. From having multiple problems we managed to go done to one single issue14:40
efriedgibi Oh, definitely agree.14:41
efriedJust made for a tough rebase :)14:41
kashyapsean-k-mooney: I see, afraid I don't know the cause of it.14:42
mriedembhagyashris: something probably failed server-side, because nova-compute will upload the image data to glance14:42
*** markvoelker has quit IRC14:43
*** markvoelker has joined #openstack-nova14:43
sean-k-mooneykashyap: im restacking with reclone=true to make sure eveything is uptodate but basically im seeing  openstack --os-cloud devstack-admin --os-region RegionOne compute service list --host silpixa00385232 --service nova-compute -c ID -f value fail.14:44
*** Nil_ has joined #openstack-nova14:44
kashyapsean-k-mooney: In the past 'reclone=true' screwed me up.  Let me dig up the reason, I recall writing it down why it's "bad"14:44
kashyapIIRC, it messes up with Git remotes14:44
sean-k-mooneykashyap: hehe i have been using devstack for 4 years i know why it can be bad but in this case its safe enough as it will just do a git pull on all the repos in /opt/stack14:45
bhagyashrismriedem: but there is no optional parameter --file at the time of creation of instance snapshot so thats why the snapshot created at glance is in queued state14:45
kashyapsean-k-mooney: Ah, okay, you're well-scarred then.14:45
mriedembhagyashris: i think you might be misunderstanding what the nova image-create operation does14:46
mriedemit's not the same as glance image-create and image-upload14:46
*** mlavalle has joined #openstack-nova14:46
sean-k-mooneykashyap: enough so to be imune to the fact it will happliy destroy your system if you dont speak to it firmly form time to time yes14:46
kashyapsean-k-mooney: I use this little ugly script as a 'hook' to update all the repos -- http://paste.openstack.org/show/626273/14:47
kashyapsean-k-mooney: Heh, indeed14:47
*** Yingxin has quit IRC14:48
*** Yingxin has joined #openstack-nova14:48
sean-k-mooneykashyap: yes that is basically what reclone=true does in the git_clone fuction https://github.com/openstack-dev/devstack/blob/master/functions-common#L493-L566 but it also support gerrit references,branches and tags14:48
bhagyashrisbhagyashris: I will go through nova image-create code14:48
kashyapsean-k-mooney: Yeah, that's why I use a minimal script that uses `virt-builder` that sets up DevStack env from scratch, if I'm taking too much time to debug the darn thing.  (Should clean up the script) -- https://kashyapc.fedorapeople.org/virt/openstack/setup-devstack-vm.bash14:49
bhagyashrismriedem: I will go through nova image-create code14:49
kashyapsean-k-mooney: Ah, noted; okay I'll be a bit less fearful of it, and give it a whirl next time14:49
mriedembhagyashris: nova-api creates an image in glance and then casts to the nova-compute service to actually snapshot the disk and upload the file to glance for the snapshot image,14:50
mriedemso if the image was stuck in queued state forever, something probably failed on the nova-compute side14:50
*** lpetrut_ has quit IRC14:51
jianghuaw_bauzas, jaypipes: are you around?14:51
sean-k-mooneyreclone=true is safe, PIP_UPGRADE=ture is not and should be a last resort as it ignores the upper-constriants file14:51
*** lpetrut_ has joined #openstack-nova14:51
jianghuaw_bauzas, jaypipes: Have some questions on how to report nested resource providers and traits from drivers.14:52
bhagyashrismriedem: ohh ok. Thank you :)14:52
*** gbarros has quit IRC14:53
*** smatzek has joined #openstack-nova14:53
*** yamahata has joined #openstack-nova14:53
*** READ10 has joined #openstack-nova14:53
*** smatzek has quit IRC14:53
bauzasjianghuaw: over the phone, sorry14:53
*** smatzek has joined #openstack-nova14:53
jianghuaw_bauzas, ok. May chat with you later.14:54
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Handle InstanceNotFound when setting password via metadata  https://review.openstack.org/51965914:56
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: Unit tests must mock os_xenapi calls  https://review.openstack.org/49957315:00
*** rcernin has quit IRC15:00
*** mdnadeem has quit IRC15:01
jaypipesjianghuaw_: just got back. what's up?15:04
*** cfriesen has joined #openstack-nova15:04
jianghuaw_jaypipes, my problem is how to report the nested resource providers and traits from drivers to resource provider. Should we use the existing get_inventory()?15:05
jaypipessean-k-mooney: what is stephenfin's opinion?15:05
jianghuaw_jaypipes, or should we define new interfaces?15:06
jaypipesjianghuaw_: no, we will need to define a new update_inventory() interface to the virt driver API.15:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add FlavorPayload.description for versioned notifications  https://review.openstack.org/51478215:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add microversion to allow setting flavor description  https://review.openstack.org/51521315:06
sean-k-mooneyjaypipes: i think he as ok with either version. but stephenfin if you are around maybe you can comment15:07
jianghuaw_what's the data structure return by update_inventory()?15:07
*** eharney has joined #openstack-nova15:08
sean-k-mooneyjaypipes: there are two patches from rodolfo that are effect by this. https://review.openstack.org/#/c/487405/ and https://review.openstack.org/#/c/484386/15:08
jaypipesjianghuaw_: I was thinking a boolean. The update_inventory() would accept a ProviderTree object and the virt driver would update the providers in the ProviderTree appropriately, returning whether anything changed.15:08
jaypipessean-k-mooney: understood. I will try to get to those today.15:09
sean-k-mooneyjaypipes: thanks jay. and no worries it would be good to come to a dession but soon but i also want to make the right one so lets not rush.15:10
openstackgerritMatt Riedemann proposed openstack/nova master: Validate new image via scheduler during rebuild  https://review.openstack.org/51966215:10
jianghuaw_jaypipes, so everything is done in driver. resource tracker just trigger the update. right?15:10
efriedjaypipes So I'm clear, does ProviderTree include the resources, or just the provider hierarchy?15:12
openstackgerritIlya Shakhat proposed openstack/nova master: Initialize osprofiler in uWSGI application  https://review.openstack.org/51966415:12
sean-k-mooneyefried: i think the full tree with the resouces. at least that is what i had assumed at the PTG15:13
jianghuaw_jaypipes, do you have a rough plan on when will start to add the interface of update_inventory()?15:13
*** gouthamr has quit IRC15:13
jaypipesjianghuaw_: for now, yes, that's the plan. eventually, a generic device manager may also get called... but that's later on.15:13
efriedsean-k-mooney That would make sense if the method is called update_inventory15:13
jaypipesefried: no, inventory records are kept in the ProviderTree for each resource class the provider provides15:13
jianghuaw_jaypipes, just wonder if it's proper time to start n-rp work for vgpu in XenAPI.15:14
*** yangyapeng has joined #openstack-nova15:14
*** Tom-Tom_ has joined #openstack-nova15:15
openstackgerritXuanzhou Perry Dong proposed openstack/nova master: Check for volume size  https://review.openstack.org/51966615:16
*** gouthamr has joined #openstack-nova15:16
efriedjianghuaw_ If you do, you'll have to base it on the series in progress, starting at https://review.openstack.org/#/c/377138/15:16
*** psachin has quit IRC15:16
*** psachin has joined #openstack-nova15:17
*** Tom-Tom has quit IRC15:17
jianghuaw_efried, thanks. yes I have been looking at this series of patches.15:17
efriedjianghuaw_ But also note that we (jaypipes, alex_xu, me, etc.) haven't yet written the GET /allocation_candidates affordance for nrp.15:18
efriedWhich could make the scheduling results... unpredictable.15:18
*** armax has joined #openstack-nova15:19
*** yangyapeng has quit IRC15:19
*** amodi has joined #openstack-nova15:19
jianghuaw_efried, I see. I had some testing today. I understood n-rp has not been completed yet. But wonder if we can do things in parallel.15:19
sean-k-mooneyefried: is the numbered traits syntax for associating tratis and resouce requests that was discussed at the summit still going ahead for pike.15:20
sean-k-mooneysorry queens15:20
*** hongbin has joined #openstack-nova15:20
efriedjianghuaw_ To some extent, in the sense that more than one person can be proposing patches for the various pieces of functionality; but in this case, they should probably be proposed on that same series.  Which can get confusing for rebases.15:20
efriedsean-k-mooney Yes, and good progress has been made there.  At this point it's stalled waiting for the big refactor series starting at https://review.openstack.org/#/c/516778/15:21
sean-k-mooneyefried: good to hear is the requesting traits via flavours work integrated with this also15:21
jianghuaw_efried, understood.15:21
*** litao__ has quit IRC15:22
efriedsean-k-mooney Yes.  The code to parse granular resources & traits from flavor extra specs, pass to the scheduler, pass to GET /allocation_candidates, parse in placement from the querystring, and pass to the internal methods - all that is done.15:22
efriedsean-k-mooney The remaining piece is to make said internal methods actually Do The Right Thing with that information, which will bump the placement microversion; and then switch on the support from the scheduler side.15:23
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Validate new image via scheduler during rebuild  https://review.openstack.org/51967215:23
efriedsean-k-mooney You can see that stuff here: https://review.openstack.org/#/q/topic:bp/granular-resource-requests15:24
sean-k-mooneyefried: ah ok, so yes good progress is certenly apt. that will make my verified boot friend very happy to hear once i translate it for them.15:25
sean-k-mooneyjaypipes:  on that note im going to split all the stateful traits into seperate patches. i know currently we do not want to standardies stateful traits so until we come to a dession on how to model the state of capablities ill advise the use of CUSTOM_ traits15:27
jaypipesjianghuaw_: I'd appreciate another week to get more n-r-p stuff merged.15:30
jaypipessean-k-mooney: there's no such thing as a stateful trait... I'll respond to you on those patches.15:30
jianghuaw_jaypipes: cool. Thanks.15:31
sean-k-mooneyjaypipes: :) i know but without inventing another entity to tag ever resouce provider with and request every where we request a trait im inventing that term untill we have something better15:31
sean-k-mooneyjaypipes: but for now ill reduce the scope of those patches to just capabilities with no state implied as you suggesed in the patch reviews previously15:32
jaypipessean-k-mooney: whether or not a particular trait is applied to a specific resource provider is not relevant to what the trait represents.15:32
jaypipessean-k-mooney: that's all I'm saying.15:32
jaypipessean-k-mooney: if a node supports UEFI boot mode, then it supports UEFI boot mode. Whether or not that node is *booted* using UEFI boot mode is entirely a different thing.15:33
jianghuaw_jaypipes, I'd appreciate if you can have time to review these patches again: https://review.openstack.org/#/c/512965 https://review.openstack.org/#/c/516217/15:34
sean-k-mooneyjaypipes: yep understood traits solves the fomer. i had hoped it could be used to solve the later but if we want to use something else for that then that is fine too so long as we can eventually solve both15:34
*** bkopilov has quit IRC15:37
*** bkopilov has joined #openstack-nova15:38
*** bkopilov has quit IRC15:38
*** janki has quit IRC15:39
*** bkopilov has joined #openstack-nova15:39
crlbHello jaypipes, can I ask you about change #516796?15:41
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Validate new image via scheduler during rebuild  https://review.openstack.org/51968115:41
efriedsean-k-mooney What patches are we talking about?15:41
sean-k-mooneyefried: https://review.openstack.org/#/q/status:open+project:openstack/os-traits+branch:master+topic:verified_boot15:42
efriedsean-k-mooney Thanks.  We had a discussion along these lines with the ironic folks too.  Did you see the summary in the ML?15:43
sean-k-mooneyefried: also https://review.openstack.org/#/c/514737/ but im less concured about that one but it does better illistrate the type of configuration associated with the capablities that we would like to model eventurally15:43
sean-k-mooneyefried: no but i was aware that disscution was going to take place15:44
*** jmlowe has joined #openstack-nova15:44
efriedsean-k-mooney Here's the summary -- and there's a link to the video recording if you want to sit through the whole thing (and see costumes): http://lists.openstack.org/pipermail/openstack-dev/2017-November/124200.html15:45
sean-k-mooneyefried: oh cool thanks. ya i will try and let it play in the background to get up to speed. that said im not sure how much time i will have on this or any topic going forword15:46
*** dtantsur is now known as dtantsur|brb15:46
efriedunderstood15:46
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Validate new image via scheduler during rebuild  https://review.openstack.org/51968415:49
mriedemdansmith: bauzas: https://review.openstack.org/#/q/I11746d1ea996a0f18b7c54b4c9c21df58cc4714b15:49
mriedemtristanC: any other way you want to advertise this?15:50
*** artom_ has joined #openstack-nova15:50
tristanCmriedem: could we get +2 on the patches as well as the related change on stable/newton?15:51
*** Tom-Tom_ has quit IRC15:51
jianghuaw_mriedem, could you suggest what I should do to move forward these two patches? https://review.openstack.org/#/q/topic:vdiStream+(status:open+OR+status:merged)+project:+openstack/nova15:51
mriedemtristanC: that's why i pinged dan and sylvain15:52
mriedemthey are stable core15:52
mriedemand master branch core for that matter...15:52
*** moshele has joined #openstack-nova15:52
tristanCdoes the pre-OSSA update looks good to you?15:52
mriedemtristanC: the etherpad?15:53
tristanCyes, https://etherpad.openstack.org/p/ofe4voc7sg15:53
mriedemetherpad looks fine15:53
sean-k-mooneyhum... on the plus side my openstack --os-cloud devstack-admin --os-region RegionOne compute service list --host vhost-user --service nova-compute -c ID -f value issue also happens on ubuntu. on the negitive side it also happens on ubuntu ...15:53
mriedemsean-k-mooney: what issue?15:53
tristanCmriedem: thanks!15:54
mriedemjianghuaw_: do you mean regarding the blueprint?15:54
sean-k-mooneymriedem: devstack is failing for me with  "Didn't find service registered by hostname after 60 seconds" checking for the nova compute service to be registered15:54
jianghuaw_mriedem, yes.15:55
jaypipessean-k-mooney: apologies, keep getting ripped away :(15:55
mriedemsean-k-mooney: does the hostname match what's getting created via the discover_hosts CLI?15:55
mriedemdiscover_hosts CLI is what creates the host mappings in the cell in the api db15:55
sean-k-mooneymriedem: ill check the conductor console auth and scheduer are registered15:55
mriedemjianghuaw_: i wish you would have asked several weeks ago, before the spec freeze15:55
jaypipescrlb: yessir15:56
openstackgerritEric M Gonzalez (tasker) proposed openstack/nova master: unquiesce instance on volume snapshot failure  https://review.openstack.org/51946415:56
*** yangyapeng has joined #openstack-nova15:56
jianghuaw_mriedem, that's a shame. I thought I asked here to get reviewing on the patches.15:56
jianghuaw_mriedem, I thought that's spec-less BP.15:57
mriedemjianghuaw_: it is a specless bp, but i generally consider new bp approval freeze to be at the same time as the spec freeze, which was october 1915:58
mriedemnearly a month ago15:58
mriedemit's my fault for not being clear about that,15:58
*** ratailor has joined #openstack-nova15:58
mriedembut also, specless blueprints are supposed to be brought up in the weekly nova meeting to get discussion and approval15:58
jianghuaw_mriedem, sorry. That's my fault.15:58
tssuryadansmith : thanks for the review I will address the comments soon, and yes you are right about the integrity issue with regards to us ending up with a different list of uuids than what we actually deleted, the same problem also exists between the list of records inserted into the shadow tables and the list archived - we had a bug reported ; https://bugs.launchpad.net/nova/+bug/172726615:58
openstackLaunchpad bug 1727266 in OpenStack Compute (nova) "archive_deleted_instances is not atomic for insert/delete" [Undecided,In progress] - Assigned to Surya Seetharaman (tssurya)15:58
tssuryadansmith : maybe we need to first query for the list of records whose deleted flag is set; use that list to insert into the shadow tables, archive from the actual tables and also return the same list for deleting the instance_mappings and request specs ?15:59
mriedemjianghuaw_: https://docs.openstack.org/nova/pike/contributor/blueprints.html#specs "When a blueprint does not require a spec it still needs to be approved before the code which implements the blueprint is merged. Specless blueprints are discussed and potentially approved during the Open Discussion portion of the weekly nova IRC meeting. See trivial specifications for more details."15:59
*** janki has joined #openstack-nova15:59
dansmithtssurya: just about to jump on a call so I can't really process that in my head at the moment, so can you put it in the review for me to read when I circle back?16:00
*** links has quit IRC16:00
jianghuaw_mriedem, got it. Thanks.16:00
tssuryadansmith : yes of course16:00
crlbjaypipes I'm running tox locally and getting no errors. However, on the review, Zuul, Dell, and Xen, appear to give errors that I don't understand. Is there something else I should be doing?16:00
dansmithtssurya: thanks16:00
mriedemtristanC: +2s on https://review.openstack.org/#/q/I11746d1ea996a0f18b7c54b4c9c21df58cc4714b16:01
tristanCdansmith: thanks, appreciated the fast review!16:01
dansmithmriedem: tristanC I just hit the last one16:01
dansmithheh, yep16:01
mriedemdansmith: thanks16:01
mriedemi will assume bauzas is on the same call16:02
*** yangyapeng has quit IRC16:02
jaypipescrlb: how are you running tox locally?16:02
jaypipescrlb: do this: tox -epy27,pep816:02
jaypipescrlb: and you'll see the same errors.16:02
tristanCi'm waiting for vmt +2 on the ossa (https://review.openstack.org/519686) to send the advisory16:02
mriedemack16:04
*** itlinux has joined #openstack-nova16:04
bauzasmriedem: thanks for helping with https://review.openstack.org/#/c/519662/16:05
sean-k-mooneymriedem: so looking at the nova_api db the host_mappins is empty as is the compute_nodes table in the cell1 db however the devstack@n-cpu.service is running on the hsot according to systemctl16:05
bauzasand thanks for the tests16:05
mriedemtristanC: small typo in your patch16:06
*** Oku_OS is now known as Oku_OS-away16:08
*** salv-orlando has quit IRC16:09
sean-k-mooneymriedem: huh i just realised there is a giant Guru Meditation report dump in the nova-compute journalctl log. is there a partcalar part that i should read in that to figure out what failed16:10
mriedemi think that happens when you kill the service?16:11
mriedemi'd check for errors in the n-cpu logs about why the compute node record wasn't created16:11
mriedemare the conductor services running?16:12
*** yangyapeng has joined #openstack-nova16:12
jaypipessean-k-mooney: the guru part.16:12
bauzasmriedem: dansmith: FWIW, I'm having a big problem with my IRC bouncer so for the moment, I'm not getting a notify if someone asks me16:14
bauzasmriedem: but yeah, just saw your pings16:14
*** yangyapeng has quit IRC16:16
sean-k-mooneymriedem: according to openstack compute service list yes. that said on ubuntu i actully have a tracback and a libvirt issue. on centos it prints no  No Traceback! in one of the green tread imediatly after connecting to libvirt16:17
mriedemefried: remember that ksa adapter bug i pointed out to you on saturday? did that amount to anything?16:18
mriedemperson was having failures connecting to glance16:18
openstackgerritMatthew Booth proposed openstack/nova stable/pike: libvirt: bandwidth param should be set in guest migrate  https://review.openstack.org/51963116:18
openstackgerritMatthew Booth proposed openstack/nova stable/pike: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks  https://review.openstack.org/51963216:18
efriedmriedem I don't believe it was a ksa adapter thing.  I responded in the bug report.  I think they had either their conf or their catalog misconfigured.16:19
mriedemok you must have invalidated the bug?16:19
efriedmriedem I marked it as Incomplete16:19
mriedemoh ok16:19
efriedmriedem From what I could tell, they were running pike, so it would be before my ksa adapter code, FWIW.16:20
efriedI mean, still going through ksa adapters & sessions ultimately16:20
openstackgerritMatt Riedemann proposed openstack/nova master: doc: fix link to creating unit tests in contributor guide  https://review.openstack.org/51948216:23
mriedembauzas: don't forget the two changes below https://review.openstack.org/#/c/519684/16:23
bauzasdone16:24
mriedemthanks. dansmith ^ when you're off your call16:25
mriedemtristanC: changes are all approved, just need to approve the dependencies on the newton change16:25
mriedemi'll request releases on all stable branches once those are merged16:25
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: create vGPU for instance  https://review.openstack.org/51689916:26
mriedemand then we'll eol newton16:26
*** andreas_s has quit IRC16:29
*** salv-orlando has joined #openstack-nova16:31
*** prometheanfire has joined #openstack-nova16:32
prometheanfiremriedem: https://review.openstack.org/#/c/519672/ doesn't apply to 16.0.2 cleanly, are we expecting releases soon with the fix (for pike/ocata at least)?16:32
*** yangyapeng has joined #openstack-nova16:33
*** andreas_s has joined #openstack-nova16:33
mriedemprometheanfire: "(10:25:59 AM) mriedem: i'll request releases on all stable branches once those are merged"16:33
prometheanfirethanks, just rejoined the channel at 10:3316:34
mriedemdoh16:34
prometheanfire:P16:34
dansmithmriedem: got them sorry16:36
mriedemthanks, np16:36
mriedemwelcome back to the land of the (koala) free16:37
*** andreas_s has quit IRC16:38
*** gyee_ has joined #openstack-nova16:38
*** ratailor has quit IRC16:40
dansmithyou mean "welcome back to the land of internet"16:40
dansmithand yes, it's good to be back on the right side of the wet noodle16:40
*** hemna_ has joined #openstack-nova16:41
*** yangyapeng has quit IRC16:41
*** psachin has quit IRC16:42
*** artom_ is now known as artom16:43
mriedemtonyb: would you be against changing this release note on stable/pike to be 'fixes' or 'other' rather than 'features'? https://review.openstack.org/#/c/513717/4/releasenotes/notes/bug-1721179-87bc7b64215944c0.yaml16:43
*** jmlowe has quit IRC16:43
mriedemi don't want to alarm people reading stable patch release notes16:44
*** belmoreira has quit IRC16:44
sean-k-mooneyefried: just comming to the end of the video on Ironic-Nova traits discussion. given the audiunce and topic it makes sense that only the ironic case was discussed but everything discussed also need to work with just plain nova16:44
efriedsean-k-mooney Yup.16:45
efriedsean-k-mooney Somehow...16:45
*** READ10 has quit IRC16:45
sean-k-mooneyefried: so with nova i need to be able to request the vm to be placed on a hypervior with secure boot enabled on the host not the vm16:45
*** itlinux has quit IRC16:45
efriedsean-k-mooney Does enabling secure boot on the hypervisor entail bouncing the compute service?16:46
sean-k-mooneyefried: i expcitly do not want to enabled it. i want to find a hypervisor with it enabled16:47
sean-k-mooneyefried: the config map thing iss irrelevent in this case as i do dont want to change configuration16:47
sean-k-mooneyefried: but yes it would require a host reboot to chage secureboot and it would require the host os is signed and the signing key is sored in the firmware16:48
*** pcaruana has quit IRC16:48
efriedsean-k-mooney Okay, great.  What I'm getting at is: if you enable secure boot on a hypervisor, and you have to restart the host (or at least restart the compute service) then we can make the case that the virt driver should set the SECURE_BOOT_CAPABLE trait on that host's RP.16:48
efriedsean-k-mooney Then you can just make your flavor require the SECURE_BOOT_CAPABLE trait and you're good.16:49
sean-k-mooneyefried: nope that was specifically reject at teh ptg. that is what i proposed16:49
efriedsean-k-mooney But if secure boot was something you could just flip on and off at will, then jaypipes would freak out if you had the virt driver detect that setting and add/remove the trait on the fly.16:49
sean-k-mooneyefried: no in a nova compute case its done once when you deploy the compute node. or infrequeently as a maintence envent on the compute node by the operator16:50
efriedsean-k-mooney As far as I'm concerned, if you have to reboot the whole host, all bets are off as far as traits are concerned.  That's not a "dynamic trait".  You could be adding or removing all kinds of capabilities across that reboot.16:50
sean-k-mooneyefried: yep i could have change the cpus or ram or anything16:51
efriedsean-k-mooney That's MHO; jaypipes or dansmith may wish to take a firmer stance.16:51
sean-k-mooneyefried: but specifcally dicovering if secure boot was enable or even the boot mode was reject as something the nova compute agent can do at the PTG16:51
*** Tom-Tom has joined #openstack-nova16:51
openstackgerritMatthew Booth proposed openstack/nova stable/ocata: libvirt: bandwidth param should be set in guest migrate  https://review.openstack.org/51963516:52
openstackgerritMatthew Booth proposed openstack/nova stable/ocata: libvirt: Don't VIR_MIGRATE_NON_SHARED_INC without migrate_disks  https://review.openstack.org/51963616:52
efriedsean-k-mooney By compute "agent", do you mean the virt driver?16:52
sean-k-mooneyi mean nova compute agent e.g. devstack@n-cpu.service which includes the virt dirver16:53
efriedsean-k-mooney Hum, okay, that doesn't seem like the right thing.  If not the compute agent deciding what traits to set on the host RP, then who?16:53
sean-k-mooneyefried: see lines 548-558 https://etherpad.openstack.org/p/nova-ptg-queens16:54
sean-k-mooneyefried: the stading policy on https://docs.openstack.org/nova/latest/contributor/policies.html#metrics-gathering was sighted as the reson to not allow this16:54
*** vladikr has quit IRC16:55
mriedemgibi: dansmith: do you remember fixing a bug in the target_cell fixture stuff where it was swallowing exceptions?16:56
*** Tom-Tom has quit IRC16:56
dansmithI think so16:56
mriedemi thought that was fixed as part of the instance list series16:56
mriedemok i'll dig16:56
efriedsean-k-mooney Metrics seems like a poor analogy16:56
*** Vek has joined #openstack-nova16:57
gibimriedem: yes, it rings a bell16:57
mriedemhttps://github.com/openstack/nova/commit/af05d6208b4f95f1d9b882ed376552b75bb87506#diff-04a5f91f2963947e47ab25a8b291617a16:57
mriedemconsider the bell rung16:57
dansmithmriedem: https://review.openstack.org/#/c/506312/16:58
*** sapcc-bot has quit IRC16:58
dansmithheh16:58
*** sapcc-bot2 has joined #openstack-nova16:58
mriedemyup cool16:58
sean-k-mooneyefried: i agree. i really do think this should be something the compute agent/virt driver discovers hence my original proposal but the ask was to have an external enity other then nova set these traits on the compute node16:58
mriedempart of that is going to pike16:58
*** carthaca_ has joined #openstack-nova16:58
*** tpatzig_ has joined #openstack-nova16:58
*** dgonzalez_ has joined #openstack-nova16:58
efriedsean-k-mooney What external entity??16:58
efriedsean-k-mooney The operator??16:58
efriedsean-k-mooney I guess in the case of ironic they said it would be the ironic inspector and/or operator manually adding traits.16:59
sean-k-mooneyefried: anything that was not nova. i was planning to use a systemd script that invoked the openstack client as a workaround16:59
efriedsean-k-mooney That just seems like unnecessary work for something that could so easily be automated in the virt driver.17:00
sean-k-mooneyefried: yes in the ironic case it would be ironic itself, feed by the inspector17:00
*** tpatzig_ has quit IRC17:00
*** carthaca_ has quit IRC17:00
*** dgonzalez_ has quit IRC17:00
*** itlinux has joined #openstack-nova17:01
sean-k-mooneyefried: yes  jaypipes dansmith  strongly express a preference to not have the virt driver do this though. it was 4 oclock on fiday and everyone wanted to leave at that point so maybe in light of the ironic call there opipion has changed17:01
efriedsean-k-mooney Presumably it's not illegal for virt to set *any* traits on the host RP.  So now we've got multiple different sources for traits.  Who's the source of truth?  If the operator deletes a trait that was set by virt, does it stay gone, or does virt restore it next time the pt runs?17:02
*** slaweq has quit IRC17:02
*** jmlowe has joined #openstack-nova17:02
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Handle InstanceNotFound when setting password via metadata  https://review.openstack.org/51965917:02
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Fix CellDatabases fixture swallowing exceptions  https://review.openstack.org/51970217:02
sean-k-mooneyefried: i would assume that the virt driver would restore it as it can tell the differece between new hardware was added and the operator deleted it17:02
efriedright17:03
sean-k-mooneyefried: the virt driver would have to have a blacklist to support operators removing traits in this case17:03
efriedugh17:03
sean-k-mooneye.g. in the nova.conf17:03
*** jmlowe has quit IRC17:04
mriedemefried: replied to your question in https://review.openstack.org/#/c/515418/ about stable policy for fixing 500 errors17:04
efriedsean-k-mooney Is one idea that the operator sets host traits via nova.conf?17:04
sean-k-mooneyefried: im not sure you sould want to remove traits as an operator17:04
efriedmriedem Thanks, updated to +117:05
sean-k-mooneyefried: there was a proposal to allow the operator to add traits via nova.conf  but not to set them.17:05
efriedsean-k-mooney Sorry, I didn't follow that.  add but not set ?17:05
*** sahid has quit IRC17:05
sean-k-mooneye.g. so they could lable nic with things like hardware offload capable, which would be unioned with the set of traits discovered by the virt dirver17:06
sean-k-mooneyso append traits but override via config17:06
sean-k-mooneythis is all tided to your generic device manager work though so it will change as that evolves.17:07
mriedemhongbin: can you add the conflicts note to the commit message for this backport? https://review.openstack.org/#/c/515418/117:07
mriedemsee details inline17:07
*** vladikr has joined #openstack-nova17:09
*** eharney has quit IRC17:10
*** janki has quit IRC17:10
*** eharney has joined #openstack-nova17:11
*** udesale has quit IRC17:11
efriedsean-k-mooney Okay, yeah, I remember talking about a conf file-based black/white/trait-list for devices.  So the multiple-sources-for-traits thing is something we'll have to deal with one way or another.17:12
efriedsean-k-mooney But the point remains that there will be some traits the virt driver should set, and some that should be set "externally" (be it from conf, osc, other service, magic wand, whatever).17:13
sean-k-mooneyefried: yes mid term we should have resouce providers and traits created by neutron for bandwith based scheuling in rocky17:13
efriedsean-k-mooney And (I guess on a case by case basis) we'll have to decide which of those is appropriate for which.17:13
efriedsean-k-mooney So for the case of secure boot capability, I contend that one should be okay for the virt driver to detect.17:13
*** lpetrut_ has quit IRC17:13
efriedBecause it's something that's either on or off for the entire life of the n-cpu process; and it's something that the virt driver can easily detect.17:14
sean-k-mooneyefried: yes. i would agree. if we can rely on the presence to also indicate that its enabled we remove the need for states at least for the nova case17:14
*** clarkb has quit IRC17:14
*** yangyapeng has joined #openstack-nova17:14
sean-k-mooneyefried: for ironic that will not work however17:14
efriedsean-k-mooney This may be a case where the difference is made in one's choice of words.17:15
*** yamamoto has quit IRC17:15
*** yamahata has quit IRC17:15
sean-k-mooneywell ideally i should use the same trait to represent secure boot will be used regradless of if its ironic17:16
sean-k-mooneyor nova vms17:16
sean-k-mooneyor zun containers for that matter17:16
efriedsean-k-mooney The host is capable of hosting secure boot VMs.  If you say it like that, I think you can get away with it.17:16
efriedsean-k-mooney But if you say, "The host is capable of hosting secure boot VMs, but only if the secure boot feature is enabled," that's where you'll get into trouble.17:16
sean-k-mooneyefried: that not what im asking for. im asking for a host that iteslf is useing secure boot that can host my vm.17:17
efriedsean-k-mooney A host that was brought up without secure boot enablement is NOT CAPABLE OF HOSTING SECURE BOOT VMS.  Ergo it should not have the trait.17:17
sean-k-mooneythe contraint is on the host not the vm. the vm could be bios booting17:17
efriedYeah, I understand.17:17
sean-k-mooneysecure boot vms could imply that the vm is also useing uefi secure boot too17:18
efriedsean-k-mooney That's a sidetrack to the discussion.17:19
efriedsean-k-mooney What we're trying to get at here is that you want to be able to specify in your flavor: SECURE_BOOT_CAPABLE - and have your VM land on a host that's secure boot capable.17:19
crlbjaypipes tox -epy27,pep8 | tee ../nova-patched-tox.log17:19
crlb   py27: commands succeeded17:19
crlb   pep8: commands succeeded17:19
*** lucasagomes is now known as lucas-afk17:19
*** salv-orl_ has joined #openstack-nova17:20
sean-k-mooneyefried: or i specify SECURE_BOOT_CAPABLE and i land on a hypvervior(in the xen/kvm meaning)  that can excute the vm kernel using a uefi bootload with secureboot enabel in the vm17:20
sean-k-mooneywe have to be able to treet both seperatly17:21
*** yamamoto has joined #openstack-nova17:21
sean-k-mooneybut i think we are violently agreeing mostly :)17:21
efriedsean-k-mooney That's fine; so they're separate traits17:21
efriedsean-k-mooney What you *don't* want is to have the scheduler decide on a host, send the boot request, and then have virt punt because it can't do secure boot, resulting in retries, which are limited to the cell, etc. etc.17:21
sean-k-mooneyone one trait againts too different things e.g. traits against the host and traits againts the virtulisation context.17:22
sean-k-mooneyefried: yes that would be bad17:22
*** salv-orlando has quit IRC17:22
*** yangyapeng has quit IRC17:22
*** clarkb has joined #openstack-nova17:22
sean-k-mooney* that was ment to be or one trait.17:23
mriedembauzas: dansmith: sdague: i'm thinking we want these in for ocata and newton before eol too, since i'll be cutting a release today or tomorrow for that cve https://review.openstack.org/#/q/Icb418f2be575bb2ba82756fdeb67b24a2895074617:23
*** Apoorva has joined #openstack-nova17:23
mriedemfixes bug 167567617:23
openstackbug 1719730 in OpenStack Compute (nova) ocata "duplicate for #1675676 Reschedule after the late affinity check fails with "'NoneType' object is not iterable"" [High,In progress] https://launchpad.net/bugs/1719730 - Assigned to Matt Riedemann (mriedem)17:23
efriedsean-k-mooney Ah, so now we're talking about overloading the trait semantic to say, "not only do I want to make sure I wind up on a SECURE_BOOT_CAPABLE host, I also want this vm to be secure boot."17:23
efriedsean-k-mooney And *that* is the cardinal sin according to the PTB.17:24
*** sridharg has quit IRC17:24
efriedsean-k-mooney They would have you specify that second thing via some completely separate mechanism.17:24
efriedsean-k-mooney Perhaps image metadata; perhaps a different extra_spec; perhaps some other confy thing...17:24
sean-k-mooneyefried: the traith that you use for secure boot should not change based on the compute context you choose17:24
sean-k-mooneye.g. it should be the same for vm,baremetal and contianer17:25
sean-k-mooneyin the ironic case the compute context is the same as the host17:25
efriedsean-k-mooney I'm on board with that.17:25
sean-k-mooneyin the containter and vm case the are not17:25
sdaguemriedem: make it so17:26
sdaguei.e. +A17:26
*** yamamoto has quit IRC17:26
*** moshele has quit IRC17:26
mriedemthanks17:26
sean-k-mooneyefried: personally i would see these are two differnt traits request. one is find me a host with X and the second is find me a hypervisor capable of emulating Y and then we take the intersection of both17:26
openstackgerritElod Illes proposed openstack/nova master: Use FakeLiveMigrateDriver in notification test  https://review.openstack.org/51940517:30
openstackgerritEric Fried proposed openstack/nova master: Test helper: validate provider summaries  https://review.openstack.org/51898217:30
*** edand has quit IRC17:30
efriedgibi I rebased this on top of the series, and added affordance for traits too ^17:30
*** chyka has joined #openstack-nova17:33
*** sshwarts has quit IRC17:36
*** yamamoto has joined #openstack-nova17:36
*** bauzas_ has joined #openstack-nova17:36
*** fragatina has joined #openstack-nova17:37
*** fragatina has quit IRC17:37
*** fragatina has joined #openstack-nova17:38
*** bauzas_ has quit IRC17:39
*** yamamoto_ has joined #openstack-nova17:40
*** gyee has quit IRC17:40
*** yamamoto has quit IRC17:41
*** AlexeyAbashkin has quit IRC17:41
*** gbarros has joined #openstack-nova17:43
*** gyee has joined #openstack-nova17:44
*** Apoorva has quit IRC17:44
*** salv-orl_ has quit IRC17:44
*** Apoorva has joined #openstack-nova17:44
*** dtantsur|brb is now known as dtantsur17:45
*** bauzas_ has joined #openstack-nova17:45
*** bauzas has left #openstack-nova17:45
*** yamamoto_ has quit IRC17:45
*** bauzas_ has quit IRC17:45
*** bauzas_ has joined #openstack-nova17:46
*** bauzas_ is now known as bauzas17:46
*** fragatina has quit IRC17:48
*** Swami has joined #openstack-nova17:48
*** yangyapeng has joined #openstack-nova17:49
*** jdillaman has quit IRC17:50
bauzasyay, I got a new bouncer \o/17:50
*** salv-orlando has joined #openstack-nova17:52
*** yamamoto has joined #openstack-nova17:52
*** stelucz has joined #openstack-nova17:52
*** derekh has quit IRC17:54
*** salv-orlando has quit IRC17:54
*** salv-orlando has joined #openstack-nova17:55
*** yangyapeng has quit IRC17:57
hongbinmriedem: ack17:58
*** salv-orl_ has joined #openstack-nova17:58
*** fragatina has joined #openstack-nova17:58
*** abalutoiu has joined #openstack-nova17:58
*** yamahata has joined #openstack-nova17:59
*** Tom-Tom has joined #openstack-nova18:01
*** salv-orlando has quit IRC18:01
*** yamamoto has quit IRC18:03
*** fragatina has quit IRC18:04
mriedemalaski: didn't you at one point have a doc on your thoughts for the tasks api, or was that just a patch that never merged?18:04
mriedemi found a really old juno spec https://review.openstack.org/#/c/86938/18:05
mriedemoh maybe https://specs.openstack.org/openstack/nova-specs/specs/backlog/approved/instance-tasks.html18:06
*** Tom-Tom has quit IRC18:06
*** claudiub|2 has joined #openstack-nova18:08
*** claudiub has quit IRC18:11
mordredmriedem: questoin about scheduler hints ... the API ref https://developer.openstack.org/api-ref/compute/#create-server seems to indicate that os:scheduler_hints can be put as a key on the server dict in the request, or that OS-SCH-HNT:scheduler_hints can be used outside of the server dict.18:12
mordredmriedem: but there's an old guide https://docs.openstack.org/kilo/config-reference/content/section_compute-scheduler.html that shows using os:scheduler_hints at the top level ... and i just got a patch: https://review.openstack.org/#/c/519705/2/shade/openstackcloud.py to move using os:scheduler_hints to outside of the server dict18:12
mordredmriedem: is the story that it always goes into the top level of the payload and that either key works?18:13
mriedemi think the latter, i think it's a top-level key https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/scheduler_hints.py#L7518:16
mriedemand either works18:16
mriedemhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/scheduler_hints.py#L1818:16
sean-k-mooneyfor consitnecy sake shade and osc should proably pass scheduler hints the same way18:17
mriedemi don't think you can send it in the server body18:17
mriedemit's a top-level key18:17
mriedemthe server create api-ref in nova is just confusing18:17
mriedem"The dictionary of data to send to the scheduler. Alternatively, you can specify OS-SCH-HNT:scheduler_hints as the key in the request body."18:18
mriedemthat's just saying, you can use either key18:18
mriedemi don't know why we have 2 keys, i'm assuming v2 api extension fun18:18
mriedemgmann, sdague or oomichi might remember18:18
mriedemmordred: yeah e.g. https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#differenthostfilter18:20
mriedem"With the API, use the os:scheduler_hints key. For example:"18:20
mordredok. cool. so it just shows up weird in the api ref docs ...18:20
mordredsince it's in the same block as key_name and whatnot18:20
mriedemyeah, we should be clear that it's a top-level key18:20
mriedemyup18:20
mriedemi, or someone else, can amend the doc18:21
mordredcool. thanks!18:22
*** fragatina has joined #openstack-nova18:22
openstackgerritElod Illes proposed openstack/nova master: Transform instance-live_migration_pre notification  https://review.openstack.org/48207018:23
*** salv-orl_ has quit IRC18:24
mriedemthe example request shows it's top-level too18:24
mriedemhttps://developer.openstack.org/api-ref/compute/#create-server18:24
mriedemso that helps somewhat18:24
*** salv-orlando has joined #openstack-nova18:24
openstackgerritMatt Riedemann proposed openstack/nova master: api-ref: make a note about os:scheduler_hints being a top-level key  https://review.openstack.org/51971718:27
mriedemmordred: see if this floats your boat ^18:27
jaypipescrlb: I'll pull your patch and run locally and see what's up.18:28
*** salv-orlando has quit IRC18:28
mordredmriedem: yes! that's super helpful18:29
*** stelucz has quit IRC18:29
*** yamamoto has joined #openstack-nova18:29
*** stelucz has joined #openstack-nova18:29
mriedemcburgess: semi interesting live migration abort scenario for you18:30
cburgessOK shoot18:30
mriedemcburgess: today you can list in-progress live migrations for a given server18:30
mriedemhttps://github.com/openstack/nova/blob/16.0.0/nova/db/sqlalchemy/api.py#L478918:30
mriedemif it's in one of those 4 states ^18:30
mriedemhowever, you can only abort a running migration https://github.com/openstack/nova/blob/16.0.0/nova/compute/api.py#L395218:30
mriedempresumably because the migration transitions fast enough that it gets to the hypervisor and starts running18:31
mriedemhowever,18:31
*** stelucz has quit IRC18:31
mriedemwe have this max_concurrent_live_migrations config option in compute which defaults to 1,18:31
*** stelucz has joined #openstack-nova18:31
mriedemso you could be trying to move 10 instances off a host via live migration, and by default those are all going to queue up,18:31
mriedemlet's say you wanted to abort half of those (1 in 10 are running)18:31
mriedemthe abort would fail18:31
cburgessmriedem Give me a few... sorry had someone talking to me18:32
*** stelucz has quit IRC18:32
mriedemone solution is just bump up your max_concurrent_live_migrations value to 10, but then you hit issues with running a bunch of migrations at once18:32
*** stelucz has joined #openstack-nova18:32
mriedemnp, just looking for some ops feedback18:32
alaskimriedem: there was http://git.openstack.org/cgit/openstack/nova-specs/tree/specs/backlog/approved/instance-tasks.rst18:33
*** stelucz has quit IRC18:34
mriedemalaski: yup i found it later via google, i was mistakenly searching the nova docs18:34
alaskicool18:34
*** stelucz has joined #openstack-nova18:35
*** yamamoto has quit IRC18:35
*** stelucz has quit IRC18:35
*** prometheanfire has left #openstack-nova18:35
*** yamamoto has joined #openstack-nova18:36
*** tesseract has quit IRC18:37
*** yangyapeng has joined #openstack-nova18:37
openstackgerritHongbin Lu proposed openstack/nova stable/pike: Handle exception on adding secgroup  https://review.openstack.org/51541818:38
openstackgerritHongbin Lu proposed openstack/nova stable/ocata: Handle exception on adding secgroup  https://review.openstack.org/51542118:40
jaypipescrlb: https://pastebin.com/maKwN7pM -- failures are reproduceable for me. Only suggestion I have is do an rm -rf .tox/ and then retry the tox -epy27,pep8. Other than that... perhaps you forgot to git review and push your latest changes to gerrit?18:42
*** yangyapeng has quit IRC18:43
efriedcrlb If you run tox with -r it'll rebuild the venv.18:43
openstackgerritMerged openstack/nova stable/newton: Functional regression test for evacuate with a target  https://review.openstack.org/51611818:43
efriedeasier than rm -rf .tox18:43
openstackgerritHongbin Lu proposed openstack/nova stable/pike: Handle exception on adding secgroup  https://review.openstack.org/51541818:45
openstackgerritHongbin Lu proposed openstack/nova stable/pike: Handle exception on adding secgroup  https://review.openstack.org/51541818:46
*** stelucz has joined #openstack-nova18:46
*** READ10 has joined #openstack-nova18:47
openstackgerritHongbin Lu proposed openstack/nova stable/ocata: Handle exception on adding secgroup  https://review.openstack.org/51542118:48
*** snasir has quit IRC18:49
*** snasir has joined #openstack-nova18:50
*** gfhellma has joined #openstack-nova18:55
*** lpetrut_ has joined #openstack-nova18:55
*** yangyapeng has joined #openstack-nova18:56
*** jpena is now known as jpena|off18:59
*** moshele has joined #openstack-nova18:59
*** yangyapeng has quit IRC19:00
*** tjones has joined #openstack-nova19:01
*** tasker has quit IRC19:03
*** moshele has quit IRC19:10
*** yamamoto has quit IRC19:11
openstackgerritHongbin Lu proposed openstack/nova master: Handle not found error on taking snapshot  https://review.openstack.org/51107419:12
*** yangyapeng has joined #openstack-nova19:17
openstackgerritKen'ichi Ohmichi proposed openstack/nova master: Add error message on metadata API  https://review.openstack.org/51715219:17
crlbjaypipes: checked pastebin. The test_versions.py that you are running is not the latest, but patch set 2 updated it and dealt with the pep8 errors. If i try it review, I get: git review19:20
crlbCreating a git remote called "gerrit" that maps to:19:20
crlbssh://crlb@review.openstack.org:29418/openstack/nova.git19:20
crlbNo changes between HEAD and gerrit/master. Submitting for review would19:20
crlbbe pointless.19:20
*** dave-mccowan has quit IRC19:21
*** tjones has quit IRC19:21
mnasercrlb: did you commit anything on your local branch?19:22
mnaseralso, puppet fun, we suspect that we're seeing some weird timeout in puppet openstack intergration due to this change - https://github.com/openstack/puppet-nova/commit/df638e2526d2d957318519dfcfb9098cb772609519:22
mnaserwe go from multiple threads in a single process, to single thread in multiple processes19:23
*** AlexeyAbashkin has joined #openstack-nova19:23
mnaserbut it seems to have spawned some strange timeouts with floating ip assignment.  what's the nova team stance on this in terms of "best practice" ?19:23
*** yangyapeng has quit IRC19:25
efriedjaypipes Can I do stuff to this series? https://review.openstack.org/#/c/516778/19:25
*** Sukhdev has joined #openstack-nova19:26
mnaserlooks like devstack uses API_WORKERS for # of processes in uwsgi, and has an 'enable-threads' feature19:27
*** AlexeyAbashkin has quit IRC19:28
*** abalutoiu has quit IRC19:32
*** gbarros has quit IRC19:35
crlbjaypipes. I'm sorry, I didn't realize that subsequent git reviews would give you different change numbers. The 2nd and 3rd patch sets are on change #518119.19:36
*** READ10 has quit IRC19:43
*** owalsh has quit IRC19:43
*** owalsh has joined #openstack-nova19:44
*** dtantsur is now known as dtantsur|afk19:45
mriedemdansmith: i reckon i should put out a release note for that cve on the stable branches, so i guess i'll do that right quick19:45
mriedemand we can ram it through19:45
efriedcrlb To be sure you are modifying the same review, the Change-Id in the commit message needs to remain the same.  If you run `git commit` with the `--amend` flag, it'll make sure you're staying on the same change set.  Otherwise (without `--amend`) it'll create a new change on top of the previous one and you'll wind up with separate reviews.19:46
*** ralonsoh has quit IRC19:46
efriedcrlb At this point I believe you'll want to squash these changes together, assuming they're going after the same thing.19:48
*** itlinux has quit IRC19:54
*** Sukhdev has quit IRC20:01
*** gabor_antal has quit IRC20:06
*** gabor_antal has joined #openstack-nova20:06
*** gszasz has quit IRC20:10
openstackgerritMatt Riedemann proposed openstack/nova master: Add security release note for OSSA-2017-005  https://review.openstack.org/51973820:12
mriedemsdague: dansmith: ^ if this looks ok, let's get it in and i'll do backports20:12
*** yamamoto has joined #openstack-nova20:12
*** pcaruana has joined #openstack-nova20:12
*** dikonoor has joined #openstack-nova20:15
*** yangyapeng has joined #openstack-nova20:20
dansmithmriedem: I dunno if that's common for a cve or not (to mention the cve but not describe it)20:21
mriedemthat's what the link is for20:21
dansmithbut if it is, it's cool with me20:21
dansmithyeah, just seems sparse compared to what we'd normally do20:22
mriedemlet me find an old one20:22
mriedemhttps://docs.openstack.org/releasenotes/nova/newton.html#security-issues20:22
dansmithnormally -> for a normal bug20:22
mriedemhttps://docs.openstack.org/releasenotes/nova/newton.html#id1520:23
dansmithmriedem: even that example is more descriptive20:23
mriedemok i'll wordsmith this a bit20:23
*** Tom-Tom has joined #openstack-nova20:23
*** AlexeyAbashkin has joined #openstack-nova20:23
*** yamamoto has quit IRC20:23
dansmithI don't care that much, I would just expect it to say "this includes a fix for cve 123, which could result in instances rebuilt with images not normally allowed on their host" or something20:24
*** yangyapeng has quit IRC20:25
*** dikonoor has quit IRC20:26
openstackgerritMerged openstack/nova stable/pike: Correct log message when removing a security group  https://review.openstack.org/51958320:26
*** dikonoor has joined #openstack-nova20:26
openstackgerritMerged openstack/nova master: Validate new image via scheduler during rebuild  https://review.openstack.org/51966220:27
openstackgerritMerged openstack/nova stable/pike: Validate new image via scheduler during rebuild  https://review.openstack.org/51967220:27
openstackgerritMerged openstack/nova master: Add FlavorPayload.description for versioned notifications  https://review.openstack.org/51478220:27
openstackgerritMerged openstack/nova stable/pike: Pick ironic nodes without VCPU set  https://review.openstack.org/51367820:27
openstackgerritMerged openstack/nova stable/ocata: Set group_members when converting to legacy request spec  https://review.openstack.org/51786020:27
*** Tom-Tom has quit IRC20:27
*** yangyapeng has joined #openstack-nova20:27
openstackgerritMerged openstack/nova stable/ocata: Validate new image via scheduler during rebuild  https://review.openstack.org/51968120:27
*** AlexeyAbashkin has quit IRC20:28
*** eharney has quit IRC20:28
*** yangyapeng has quit IRC20:32
openstackgerritMatt Riedemann proposed openstack/nova master: Add security release note for OSSA-2017-005  https://review.openstack.org/51973820:32
mriedemdansmith: ^ added more detail20:32
dansmithmriedem: thanks20:33
mriedemjaypipes: melwitt: can you hit https://review.openstack.org/#/c/519738/ so i can start backports?20:34
dansmithmriedem: melwitt is out for a couple weeks, AFAIK20:34
mriedemorly20:34
*** tojuvone has quit IRC20:34
mriedemplural?20:34
dansmiththis week and part of next week I think20:35
mriedemok20:35
*** tojuvone has joined #openstack-nova20:35
dansmiththrough Nov 2020:35
mriedemi'll give my jay and sean pings 5 more minutes and then i say we just approve20:35
dansmithI can just fast approve. it's a reno.20:35
mriedemok20:35
mriedemthe fixes for newton are failing devstack, presumably because neutron is eol and things are just not going to work there anymore20:36
mriedemif only we had LTS support...20:37
dansmithum...20:37
mriedemyeah, fudge, devstack in newton can't find stable/newton the branch, so it pip installs from master20:37
mriedemfarq20:37
dansmithfor nova?20:38
mriedemno, devstack fails to setup20:38
mriedemhttp://logs.openstack.org/19/516119/1/gate/legacy-tempest-dsvm-neutron-full/f24b24b/logs/devstacklog.txt.gz#_2017-11-14_17_24_29_76820:38
mriedemb/c newton is eol20:38
dansmiththat's because neutron's branch is gone right?20:39
dansmithany one project deletes their branch and devstack stops working yes?20:39
mriedemyes20:39
mriedemwell, anything we need for our base install20:39
dansmithso that's what I meant by "for nova?" ... meaning "for which project?"20:40
mriedemi could remove neutron from ENABLED_SERVICES but then nova just won't work, unless nova-net20:40
mriedemwhich in newton works w/o cellsv1....20:40
mriedem:)20:40
mriedemi think20:40
dansmithor ask for the branch to be re-created based on the discussion at summit20:40
dansmithmordred said it was easy to just resurrect that20:40
mriedemit is, but then it would be EOL'ed next week ago20:41
mriedem*again20:41
dansmithor we start disabling jobs that don't work, per the discussion :)20:41
mordredwhatdididonow?20:41
mriedemin this case it's easier probably to just disable the job20:41
mriedemmordred: we have a cve fix for newton that can't pass the gate b/c dsvm jobs fail trying to install neutron,20:42
mriedembecause neutron newton is eol20:42
dansmithmordred: we're trying to backport a cve fix to nova's newton branch and can't because neutron has eol'd theirs20:42
mordredah. yah.20:42
tonybmriedem: s/features/fixes/ on that backport is fine by me.20:43
mriedemum, cinder newton must be eol too20:43
mriedemhttp://logs.openstack.org/19/516119/1/gate/legacy-tempest-dsvm-cells/9e11a37/logs/devstacklog.txt.gz#_2017-11-14_17_21_45_40020:43
tonybOh rats :(20:43
mriedemit is20:43
smcginnismriedem: Everyone is EOL on Newton I thought.20:43
mriedemso yeah, dsvm just won't work on netwon20:43
mriedemsmcginnis: except nova20:44
smcginnismriedem: You snooze you lose.20:44
tonybYeah everyone except nova, ironic and cycle-trainling20:44
mriedemtonyb: ok so looking at https://review.openstack.org/#/c/516119/20:44
dansmithmriedem: the question comes up if we should even release newton if we never ran a devstack job against it20:44
mriedemtonyb: i'd have to skip these jobs20:44
mriedemlegacy-tempest-dsvm-cellsFAILURE in 19m 44slegacy-tempest-dsvm-multinode-live-migrationFAILURE in 19m 43slegacy-tempest-dsvm-neutron-fullFAILURE in 18m 41s20:44
openstackgerritMerged openstack/nova stable/ocata: Correct log message when removing a security group  https://review.openstack.org/51958520:44
mriedemdansmith: well this patch passed dsvm on 10/30 https://review.openstack.org/#/c/516119/20:45
dansmithmriedem: but you can't get a dsvm job run on the actual cve fix anymore right?20:45
mriedemsomehow https://review.openstack.org/#/c/519684/ did run legacy-tempest-dsvm-neutron-full earlier today20:45
mriedem^ did20:46
tonybmriedem: Yeah we only have 2 options patch devstack to work with eol-tags or accept the risk and drop the dsvm tests20:46
* tonyb messed that one up sorry20:46
mriedemi could try patching devstack, but it might be awhile20:47
dansmithmriedem: hmm, how did that work?20:48
mriedemdansmith: no idea20:48
mriedemnot sure if there are mirrors involved20:48
tonybI can also try to see how bad it is but not until after I've dropped the kids at school20:48
mriedemok, so i'm goign to get the reno backported for pike and ocata, then get the release requests up for those branches and will deal with newton20:48
mriedems/school/pool/20:48
tonyb;P20:48
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Add security release note for OSSA-2017-005  https://review.openstack.org/51975220:50
tonybnewton is xenial right?20:50
* tonyb needs to build a fresh VM for testing the devstack change20:50
mriedemyes20:50
tonybcool20:50
openstackgerritMatt Riedemann proposed openstack/nova stable/ocata: Add security release note for OSSA-2017-005  https://review.openstack.org/51975320:51
*** gouthamr has quit IRC20:53
dansmithmriedem: tonyb: +2 on the reno backports20:55
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Pass requested_destination in filter_properties  https://review.openstack.org/51611920:55
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Validate new image via scheduler during rebuild  https://review.openstack.org/51968420:55
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Add security release note for OSSA-2017-005  https://review.openstack.org/51975520:55
*** smatzek has quit IRC20:59
tonyblooks like they're good to go on > newton21:00
mriedemyes21:00
mriedemi'll propose releases for pike and ocata once the reno is merged21:00
openstackgerritEric Fried proposed openstack/nova master: begin refactor AllocCandidates._get_by_filters()  https://review.openstack.org/51677821:00
openstackgerritEric Fried proposed openstack/nova master: build ProviderSummary objects in sep function  https://review.openstack.org/51677921:00
openstackgerritEric Fried proposed openstack/nova master: build alloc request resources for shared resources  https://review.openstack.org/51678021:00
openstackgerritEric Fried proposed openstack/nova master: create allocation request for single provider  https://review.openstack.org/51678121:00
openstackgerritEric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters()  https://review.openstack.org/51678221:00
openstackgerritEric Fried proposed openstack/nova master: required traits for no sharing providers  https://review.openstack.org/51702721:00
openstackgerritEric Fried proposed openstack/nova master: Add ProviderSummary.resource_class_names @property  https://review.openstack.org/51764621:00
openstackgerritEric Fried proposed openstack/nova master: handle traits with sharing providers  https://review.openstack.org/51711921:00
openstackgerritEric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs  https://review.openstack.org/51938021:00
openstackgerritEric Fried proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs  https://review.openstack.org/51961721:00
openstackgerritEric Fried proposed openstack/nova master: Test allocation candidates: multiple aggregates  https://review.openstack.org/51863321:00
openstackgerritEric Fried proposed openstack/nova master: Test helper: validate provider summaries  https://review.openstack.org/51898221:00
efriedjaypipes ^ Addressed most of the comments in this series.21:00
efriedjaypipes There are still bugs; but I think alex_xu might be willing to +2 the bottom one at this point.21:01
*** smatzek has joined #openstack-nova21:03
tonybmriedem: cool, I'll keep an eye out21:03
openstackgerritOpenStack Proposal Bot proposed openstack/os-vif stable/pike: Updated from global requirements  https://review.openstack.org/49314621:04
*** moshele has joined #openstack-nova21:05
*** amodi has quit IRC21:06
*** smatzek has quit IRC21:07
*** jdillaman has joined #openstack-nova21:12
efrieddansmith stephenfin When you get a chance, would you please put eyeballs back on https://review.openstack.org/#/c/377138/ -- at this point it's just in a sisyphean rebase cycle.21:15
*** salv-orlando has joined #openstack-nova21:18
moshelestephenfin: hi21:20
*** lyan has quit IRC21:21
oomichimriedem: scheduler-hints is one of gross API designs. Do we have more related patches except https://review.openstack.org/#/c/519717 ?21:22
*** gouthamr has joined #openstack-nova21:23
*** acormier has joined #openstack-nova21:23
mosheleramishra: hi21:24
*** slaweq has joined #openstack-nova21:25
*** AlexeyAbashkin has joined #openstack-nova21:25
mriedemoomichi: nope21:25
mriedemdansmith: here is my devstack newton-eol trickery https://review.openstack.org/51975821:26
mriedemthanks to google for providing bash substring tips21:26
dansmithmriedem: wow that's... special21:26
mriedemheh21:26
mriedemeol_tag=$(echo ${git_ref:7:${#git_ref}})-eol21:27
mriedemis the best piece of coding i've done in ages21:27
dansmithmriedem: heh21:27
efriedmriedem What's the 7-char prefix there?21:27
mriedemstable/21:28
dansmithstable/21:28
mriedemstrip that off21:28
efriedThen eol_tag=${git_ref#stable/}-eol would work too21:28
efriedYou know, if you're a shell guy rather than a python guy.21:28
mriedemso it doies21:29
mriedemi am not a shell guy21:29
*** AlexeyAbashkin has quit IRC21:29
efriedFurthermore, that syntax will work all the way back to ksh8821:29
efriedWhich is important.21:29
efriedIn case you're running this script on AIX21:29
mriedemfuck i wish21:29
mriedemupdated, thanks for the tip21:32
cburgessmriedem OK sorry... things got.. crazy here. I'm reading what your wrote hours ago now.21:32
efriedmriedem Sure thing.  But also x=foo is the same as x=$(echo foo)21:33
cburgessmriedem OK so... back to the live migration cancel thing, I think its probably reasonable to be able to cancel queued or running.21:34
*** jmlowe has joined #openstack-nova21:35
*** felipemonteiro has joined #openstack-nova21:35
*** lyan has joined #openstack-nova21:38
*** lpetrut_ has quit IRC21:41
*** rcernin has joined #openstack-nova21:44
mriedemcburgess: ack21:45
mriedemgood to know21:45
cburgessI agree there is a bit of race condition though.21:46
mriedemapparently our operators are annoyed that they queue up a bunch of live migrations and can't abort some of them before they hit the hypervisor21:46
*** oomichi is now known as oomichi_afk21:46
mriedemtonyb: ok redoing this newton series with the depends-on21:46
cburgessAs in you want the API to fast fail if the state is wrong, but that state can change by the time you hit the compute node.21:46
mriedemand had to slip another funtional test backport in the mix21:46
mriedemcburgess: yeah i think we'd just have to ignore it if we got to the compute and something changed,21:47
cburgessmriedem Yeah that makes sense. So I think queued and running are the 2 states that aren't really transitory. So just block action on the transitory states.21:47
mriedemalthough if it went from queued->running, we should be able to abort in the compute21:47
mriedemas normal21:47
cburgessmriedem Right thats my thought. Fast fail on the API, and then another check on compute and fail if you aren't in an allowed state on compute.21:47
*** MasterOfBugs has joined #openstack-nova21:47
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Pass requested_destination in filter_properties  https://review.openstack.org/51611921:47
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Validate new image via scheduler during rebuild  https://review.openstack.org/51968421:47
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Add security release note for OSSA-2017-005  https://review.openstack.org/51975521:47
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Fix non-parameterized service id in hypervisors sample tests  https://review.openstack.org/51976321:47
*** acormier has quit IRC21:48
*** acormier has joined #openstack-nova21:48
*** gouthamr has quit IRC21:49
* tonyb takes kids to school be back in a bit21:51
*** acormier has quit IRC21:53
*** artom has quit IRC21:53
*** pramodrj07 has joined #openstack-nova21:56
*** smatzek has joined #openstack-nova21:58
*** adreznec_ has joined #openstack-nova21:58
*** adreznec has quit IRC21:59
*** adreznec_ is now known as adreznec21:59
*** zigo has quit IRC21:59
*** MasterOfBugs has quit IRC22:00
*** zigo has joined #openstack-nova22:01
*** smatzek has quit IRC22:02
*** pcaruana has quit IRC22:02
*** pcaruana has joined #openstack-nova22:06
*** gfhellma_ has joined #openstack-nova22:06
*** pcaruana has quit IRC22:07
*** gfhellma has quit IRC22:08
openstackgerritMerged openstack/nova master: placement: AllocCands.get_by_{filters => requests}  https://review.openstack.org/51409222:09
*** threestrands has joined #openstack-nova22:13
*** pramodrj07 has quit IRC22:13
openstackgerritMerged openstack/nova master: Deduplicate server_group samples  https://review.openstack.org/51962922:16
*** jmlowe has quit IRC22:19
*** lpetrut_ has joined #openstack-nova22:20
openstackgerritMerged openstack/nova stable/pike: Add security release note for OSSA-2017-005  https://review.openstack.org/51975222:20
openstackgerritMerged openstack/nova stable/ocata: Add security release note for OSSA-2017-005  https://review.openstack.org/51975322:20
mriedemi think the devstack hack is working22:21
mriedemtempest is running on that patch now22:21
mriedemso the install was good22:21
*** threestrands has quit IRC22:21
openstackgerritEric Fried proposed openstack/nova master: placement: adds REST API for nested providers  https://review.openstack.org/38480722:24
openstackgerritEric Fried proposed openstack/nova master: placement: update client to set parent provider  https://review.openstack.org/38569322:24
openstackgerritEric Fried proposed openstack/nova master: Reformat _get_all_with_shared  https://review.openstack.org/51279922:24
tonybmriedem: \o/ I +2'd the devstack change22:24
efriedjaypipes Addressed the couple of comments remaining in here --^22:25
*** dikonoor has quit IRC22:25
mriedemtonyb: you don't think that devstack change needs to go on master first and backported?22:25
mriedemah i see your comment22:25
tonybmriedem: Yeah that thing22:26
*** yangyapeng has joined #openstack-nova22:26
*** dikonoor has joined #openstack-nova22:26
*** gouthamr has joined #openstack-nova22:26
* tonyb trusts mriedem will do the follow-up work (or just tell me to do it ;P)22:27
mriedemoh fo sho22:27
mriedembegin preparations for ocata and pike releases22:28
* mriedem likes to talk like a captain22:28
*** yangyapeng has quit IRC22:34
tonybmriedem: You're just missing a "make it so" or "engage!" in there somewhere22:37
tonybmriedem: perhaps you could take that as a challenge?22:37
mriedemi thought about it22:37
mriedemsdague said engage earlier today22:37
mriedemoh no he said the other22:38
mriedemmake it so22:38
*** Swami has quit IRC22:38
mriedemok pike release https://review.openstack.org/#/c/519799/ and ocata release https://review.openstack.org/#/c/519808/22:38
openstackgerritMatt Riedemann proposed openstack/nova stable/newton: Correct log message when removing a security group  https://review.openstack.org/51958622:40
mriedemdansmith: tonyb: want to bless this https://review.openstack.org/#/c/519763/ ?22:41
*** gbarros has joined #openstack-nova22:43
tonybmriedem: +2'd22:43
dansmithtonyb: there's one above it too22:44
dansmith(the important one)22:44
tonybdansmith: Yeah I'm looking that the zuul consoles for that series and the pike/ocata releases22:47
dansmithokay22:48
*** priteau has quit IRC22:48
*** priteau has joined #openstack-nova22:49
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements  https://review.openstack.org/51980622:49
*** eharney has joined #openstack-nova22:50
openstackgerritMerged openstack/nova master: Add error message on metadata API  https://review.openstack.org/51715222:51
*** awaugama has quit IRC22:52
mriedemthanks - at this hour, i'll just fast re-approve anything that was already approved earlier todya22:52
mriedemonce ci is happy22:52
*** priteau has quit IRC22:53
efriedjaypipes Taking on the latest merge conflict...22:54
mriedemtonyb: i think the devstack patch isn't actually doing the job22:57
mriedemhttp://logs.openstack.org/58/519758/3/check/legacy-tempest-dsvm-neutron-full/1676068/logs/devstacklog.txt.gz#_2017-11-14_21_45_19_88522:57
mriedemi'm not sure why the job passed though22:57
tonybergh moar debugging22:58
mriedemwell, i assume my regex compare in bash is wrong22:58
mriedemi can update to what efried suggested22:58
mriedemalthough22:59
mriedemhttp://logs.openstack.org/58/519758/3/check/legacy-tempest-dsvm-neutron-full/1676068/logs/pip2-freeze.txt.gz22:59
mriedemneutron==9.4.2.dev2122:59
*** lpetrut_ has quit IRC22:59
mriedemthat is newton for neutron22:59
efriedmriedem I only glanced at that line, just noticed you were using a regex when a simple glob compare would do.22:59
*** gfhellma_ has quit IRC23:00
tonybYeah /me is confused23:00
mriedemit clearly shows it not checking out the newton-eol tag though23:01
*** Apoorva_ has joined #openstack-nova23:01
*** gfhellma_ has joined #openstack-nova23:02
efriedmriedem It appears you need to whack the double quotes around the regex side.23:03
efriedmriedem Or change to the simpler form23:03
*** dikonoo has joined #openstack-nova23:03
yankcrimewebdev23:03
*** edmondsw has quit IRC23:04
*** Apoorva has quit IRC23:04
*** edmondsw has joined #openstack-nova23:04
efriedefried@efried-ThinkPad-W520:~$ [[ "stable/whatever" =~ stable/.* ]]; echo $?23:04
efried023:04
efriedefried@efried-ThinkPad-W520:~$ [[ "stable/whatever" =~ "stable/.*" ]]; echo $?23:04
efried123:04
*** Sukhdev has joined #openstack-nova23:04
*** erlon has quit IRC23:04
efriedthen there's23:05
efriedefried@efried-ThinkPad-W520:~$ [[ "stable/whatever" == stable/* ]]; echo $?23:05
efried023:05
mriedemyup, i copied something from d-g incorrectly23:05
efriedI believe they're trying to be helpful with =~ in bash and make it so you can include quotes more "easily" as match tokens in your actual regex.23:06
tonybmriedem: So http://logs.openstack.org/58/519758/3/check/legacy-tempest-dsvm-neutron-full/1676068/logs/devstacklog.txt.gz#_2017-11-14_21_45_19_89223:06
tonybshows that for reasons I don't grok you got newton-eol23:06
*** edmondsw_ has joined #openstack-nova23:07
mriedemyeah i don't either23:07
mriedembut i've updated the devstack patch23:07
*** dikonoor has quit IRC23:07
mriedemand added efried as co-author since he's fixed all my mistakes23:08
efried:)23:08
*** edmondsw has quit IRC23:08
*** imacdonn has quit IRC23:09
*** imacdonn has joined #openstack-nova23:09
openstackgerritMerged openstack/nova master: Add security release note for OSSA-2017-005  https://review.openstack.org/51973823:10
mriedemok newton stuff is all rechecked23:13
*** edmondsw_ has quit IRC23:13
mriedemthis is going to take an hour so i'm gonna be afk for a bit23:14
*** erlon has joined #openstack-nova23:14
tonybokay23:15
*** gyee_ has quit IRC23:23
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2)  https://review.openstack.org/43060823:31
*** takashin has joined #openstack-nova23:32
*** jaypipes has quit IRC23:32
*** felipemonteiro has quit IRC23:34
*** gbarros has quit IRC23:35
*** edmondsw has joined #openstack-nova23:36
*** eharney has quit IRC23:36
*** gyee_ has joined #openstack-nova23:36
*** gbarros has joined #openstack-nova23:36
*** edmondsw has quit IRC23:40
*** slaweq has quit IRC23:41
*** slaweq has joined #openstack-nova23:42
*** dave-mccowan has joined #openstack-nova23:42
*** slaweq has quit IRC23:46
openstackgerritEric Fried proposed openstack/nova master: begin refactor AllocCandidates._get_by_filters()  https://review.openstack.org/51677823:49
openstackgerritEric Fried proposed openstack/nova master: build ProviderSummary objects in sep function  https://review.openstack.org/51677923:49
openstackgerritEric Fried proposed openstack/nova master: build alloc request resources for shared resources  https://review.openstack.org/51678023:49
openstackgerritEric Fried proposed openstack/nova master: create allocation request for single provider  https://review.openstack.org/51678123:49
openstackgerritEric Fried proposed openstack/nova master: finish refactor AllocCandidates._get_by_filters()  https://review.openstack.org/51678223:49
openstackgerritEric Fried proposed openstack/nova master: required traits for no sharing providers  https://review.openstack.org/51702723:49
openstackgerritEric Fried proposed openstack/nova master: Add ProviderSummary.resource_class_names @property  https://review.openstack.org/51764623:49
openstackgerritEric Fried proposed openstack/nova master: handle traits with sharing providers  https://review.openstack.org/51711923:49
openstackgerritEric Fried proposed openstack/nova master: Test alloc_cands with non overlapping sharing RPs  https://review.openstack.org/51938023:49
openstackgerritEric Fried proposed openstack/nova master: Test alloc_cands with one RP shared between two RPs  https://review.openstack.org/51961723:49
openstackgerritEric Fried proposed openstack/nova master: Test allocation candidates: multiple aggregates  https://review.openstack.org/51863323:49
openstackgerritEric Fried proposed openstack/nova master: Test helper: validate provider summaries  https://review.openstack.org/51898223:49
efriedFor the record, I suspect a couple of the patches in the middle of this ^ will fail functional tests, because auto-merge.  I'll deal with that tomorrow.  (jaypipes ^ in case you're eavesdropping)23:50
*** lyan has quit IRC23:51
*** gouthamr has quit IRC23:52
*** claudiub|2 has quit IRC23:53
*** moshele has quit IRC23:56
*** Ankit has joined #openstack-nova23:58
*** yangyapeng has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!