Monday, 2018-01-08

*** ejat has joined #openstack-nova00:09
*** slaweq has joined #openstack-nova00:11
*** slaweq has quit IRC00:15
*** sree has joined #openstack-nova00:18
*** comstud has quit IRC00:19
*** claudiub has quit IRC00:20
*** masber has joined #openstack-nova00:21
*** comstud has joined #openstack-nova00:22
*** tbachman has quit IRC00:22
*** masber has quit IRC00:29
*** sree has quit IRC00:30
*** Apoorva has quit IRC00:40
*** tuanla____ has joined #openstack-nova00:40
*** sree has joined #openstack-nova00:42
*** jichen has joined #openstack-nova00:50
*** sree has quit IRC00:51
*** sree has joined #openstack-nova00:56
*** yassine has joined #openstack-nova00:56
*** yassine is now known as Guest2007600:57
*** ljjjustin has joined #openstack-nova01:01
*** hoangcx has joined #openstack-nova01:04
*** dave-mccowan has joined #openstack-nova01:06
*** phuongnh has joined #openstack-nova01:09
*** yangyapeng has joined #openstack-nova01:10
*** masber has joined #openstack-nova01:10
*** sree has quit IRC01:13
*** jichen_ has joined #openstack-nova01:17
*** jichen has quit IRC01:19
*** jichen_ is now known as jichen01:19
*** liusheng has joined #openstack-nova01:19
*** edmondsw has joined #openstack-nova01:21
*** edmondsw has quit IRC01:26
*** sree has joined #openstack-nova01:33
*** sree has quit IRC01:37
*** leakypipes has quit IRC01:39
*** Rambo has joined #openstack-nova01:53
Rambohello,everyone01:54
*** annp has joined #openstack-nova01:54
Rambo Can you help me to review it ?The link is https://review.openstack.org/#/c/531524/01:54
RamboAnother is :https://review.openstack.org/#/c/528740/01:54
RamboThank you very much01:54
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [DNM] add uuid in server migration  https://review.openstack.org/53163301:55
*** hongbin has joined #openstack-nova02:03
*** jafeha__ has joined #openstack-nova02:13
*** Tom-Tom has joined #openstack-nova02:13
*** jafeha has quit IRC02:16
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add index(updated_at) on migrations table.  https://review.openstack.org/53113202:17
alex_xu_yikun: sorry for reply late https://review.openstack.org/#/c/330406/78/api-ref/source/parameters.yaml@414802:21
*** liusheng has quit IRC02:25
*** liusheng has joined #openstack-nova02:26
*** Rambo__ has joined #openstack-nova02:35
*** Rambo has quit IRC02:36
*** zhurong has joined #openstack-nova02:46
yikunalex_xu_, ok, thanks, saw it, I will update and add the uuid on server migrations in this patch.02:54
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state  https://review.openstack.org/53111703:00
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table  https://review.openstack.org/53042903:00
*** sree has joined #openstack-nova03:07
*** hongbin has quit IRC03:09
*** dave-mccowan has quit IRC03:09
*** hongbin has joined #openstack-nova03:09
*** edmondsw has joined #openstack-nova03:09
*** hongbin has quit IRC03:10
*** hongbin has joined #openstack-nova03:10
*** hongbin has quit IRC03:10
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [DNM] add uuid in server migration  https://review.openstack.org/53163303:11
*** hongbin has joined #openstack-nova03:11
*** hongbin has quit IRC03:12
*** hongbin has joined #openstack-nova03:13
yikun^ I submit the separate one, just for convenient reviewing, and if all is ok, I will merge it into parent patch.03:13
*** edmondsw has quit IRC03:14
*** hongbin has quit IRC03:14
*** hongbin has joined #openstack-nova03:15
*** amodi has quit IRC03:32
*** abhishekk has joined #openstack-nova03:40
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add migration db and object pagination support.  https://review.openstack.org/51490403:54
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add cross cell sort support for get_migrations  https://review.openstack.org/51727303:54
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040603:54
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [DNM] add uuid in server migration  https://review.openstack.org/53163303:54
*** yamamoto has joined #openstack-nova03:58
*** Tom-Tom has quit IRC04:02
*** Tom-Tom has joined #openstack-nova04:03
*** yamamoto has quit IRC04:03
*** Tom-Tom has quit IRC04:07
*** pooja_jadhav has joined #openstack-nova04:11
*** hongbin has quit IRC04:19
*** moshele has joined #openstack-nova04:39
*** gcb has joined #openstack-nova04:41
gcbalex_xu_,  could you please help review https://review.openstack.org/528620   a simple adoption of oslo function04:43
alex_xu_gcb: will check it after lunch04:43
*** moshele has quit IRC04:44
*** sridharg has joined #openstack-nova04:44
gcbalex_xu_: thanks04:45
alex_xu_gcb: np04:45
*** zhurong has quit IRC04:52
*** udesale has joined #openstack-nova04:54
*** edmondsw has joined #openstack-nova04:58
*** edmondsw has quit IRC05:02
*** yamamoto has joined #openstack-nova05:04
*** moshele has joined #openstack-nova05:04
*** bhagyashri_s is now known as bhagyashris05:05
*** yamamoto has quit IRC05:12
*** pooja_jadhav has quit IRC05:15
*** yangyapeng has quit IRC05:16
*** yangyapeng has joined #openstack-nova05:17
*** moshele has quit IRC05:18
*** Tom-Tom has joined #openstack-nova05:21
*** pooja_jadhav has joined #openstack-nova05:25
*** Tom-Tom has quit IRC05:25
*** janki has joined #openstack-nova05:28
*** mikal has quit IRC05:33
*** psachin has joined #openstack-nova05:33
*** shaohe_feng has quit IRC05:38
*** shaohe_feng has joined #openstack-nova05:42
openstackgerritRajesh Tailor proposed openstack/nova master: Allow force-delete even if task_state is not None  https://review.openstack.org/53087905:44
*** zhurong has joined #openstack-nova05:52
openstackgerritKevin Zhao proposed openstack/nova master: Modify the test case of get_disk_mapping_rescue_with_config  https://review.openstack.org/49415605:56
*** Eran_Kuris has joined #openstack-nova05:58
*** Tom-Tom has joined #openstack-nova05:59
*** efried has quit IRC06:08
*** moshele has joined #openstack-nova06:09
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.58 - Instance actions list pagination  https://review.openstack.org/52860106:10
*** ratailor has joined #openstack-nova06:14
*** liusheng has quit IRC06:14
*** janki has quit IRC06:17
*** janki has joined #openstack-nova06:18
*** efried has joined #openstack-nova06:18
*** bkopilov has joined #openstack-nova06:29
openstackgerritAmeed Ashour proposed openstack/nova master: change instance_system_metadata column type  https://review.openstack.org/52690006:35
*** khappone has joined #openstack-nova06:35
openstackgerritKevin Zhao proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64  https://review.openstack.org/53096506:37
*** claudiub has joined #openstack-nova06:43
*** udesale__ has joined #openstack-nova06:45
*** edmondsw has joined #openstack-nova06:46
*** udesale has quit IRC06:48
*** edmondsw has quit IRC06:50
bhagyashrisianw: Hi, are you around ?06:52
*** udesale has joined #openstack-nova06:52
*** udesale__ has quit IRC06:54
*** liuyulong has joined #openstack-nova06:54
*** moshele has quit IRC07:03
*** moshele has joined #openstack-nova07:03
*** pcaruana has joined #openstack-nova07:04
*** moshele has quit IRC07:06
*** moshele has joined #openstack-nova07:12
*** Kevin_Zheng has quit IRC07:13
*** knikolla has quit IRC07:13
*** fyxim has quit IRC07:13
*** fyxim_ has joined #openstack-nova07:13
*** knikolla has joined #openstack-nova07:13
*** brad[] has quit IRC07:15
*** gaurangt has quit IRC07:15
*** Kevin_Zheng has joined #openstack-nova07:16
*** gaurangt has joined #openstack-nova07:18
*** tiendc has joined #openstack-nova07:20
*** liusheng has joined #openstack-nova07:22
openstackgerritMerged openstack/nova master: Use method validate_integer from oslo.utils  https://review.openstack.org/52862007:24
*** moshele has quit IRC07:25
*** moshele has joined #openstack-nova07:27
*** karthiks has joined #openstack-nova07:36
*** rabel_b1 has joined #openstack-nova07:46
openstackgerritSriharsha Basavapatna proposed openstack/os-vif master: Fix VF-rep lookup routine to use parent PF number  https://review.openstack.org/53167407:51
*** lajoskatona has joined #openstack-nova07:56
*** hrw has joined #openstack-nova07:59
*** sridharg has quit IRC07:59
*** sridharg has joined #openstack-nova08:00
hrwmorning08:03
*** jafeha__ has quit IRC08:04
*** sridharg has quit IRC08:08
*** sridharg has joined #openstack-nova08:08
*** tesseract has joined #openstack-nova08:09
*** ralonsoh has joined #openstack-nova08:09
*** namnh has joined #openstack-nova08:09
*** damien_r has joined #openstack-nova08:10
*** weshay has quit IRC08:19
*** trozet has quit IRC08:19
*** markmc has quit IRC08:19
*** lucas-afk has quit IRC08:19
*** sshwarts has joined #openstack-nova08:20
*** weshay has joined #openstack-nova08:20
*** lucasagomes has joined #openstack-nova08:20
*** trozet has joined #openstack-nova08:20
*** rabel__b1 has joined #openstack-nova08:23
*** markmc has joined #openstack-nova08:23
*** rabel_b1 has quit IRC08:26
*** Tom-Tom has quit IRC08:30
*** Tom-Tom has joined #openstack-nova08:30
*** Tom-Tom has quit IRC08:31
*** jafeha has joined #openstack-nova08:31
*** Tom-Tom has joined #openstack-nova08:31
*** edmondsw has joined #openstack-nova08:34
openstackgerritMr Rambo proposed openstack/nova master: Support volume-backed server rebuild  https://review.openstack.org/52874008:35
*** damien_r has quit IRC08:36
*** damien_r has joined #openstack-nova08:37
*** moshele has quit IRC08:37
*** moshele has joined #openstack-nova08:37
*** jpena has joined #openstack-nova08:38
*** edmondsw has quit IRC08:39
bauzasgood morning Nova08:44
*** sahid has joined #openstack-nova08:44
* bauzas waves back from holidays08:44
gibi_awaygood morning bauzas and Nova08:44
*** gibi_away is now known as gibi08:44
* gibi just back from vacation too08:45
* bauzas has a thought for operators today08:47
hrwspeadup zuul, speed up...08:48
*** rabel_b1 has joined #openstack-nova08:53
*** rabel__b1 has quit IRC08:55
*** ygl has joined #openstack-nova08:56
*** ygl has quit IRC09:01
*** rcernin has quit IRC09:07
*** fragatina has joined #openstack-nova09:08
*** fragatina has quit IRC09:08
bauzasjust in case people wanna give me a Christmas present, here is a series loving reviews https://review.openstack.org/#/c/514763/09:08
bauzas:)09:08
* bauzas working on a last patch for fixing some tech debt problems09:09
*** fragatina has joined #openstack-nova09:09
*** sbezverk has quit IRC09:11
* hrw curses at nova tests09:11
*** owalsh_ is now known as owalsh09:15
*** finucannot is now known as stephenfin09:16
*** ircuser-1 has joined #openstack-nova09:18
openstackgerritKevin Zhao proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64  https://review.openstack.org/53096509:19
*** danpawlik has joined #openstack-nova09:23
*** fragatina has quit IRC09:23
openstackgerritMr Rambo proposed openstack/nova master: Support volume-backed server rebuild  https://review.openstack.org/52874009:24
*** john51_ has joined #openstack-nova09:44
*** Tom-Tom_ has joined #openstack-nova09:45
*** udesale has quit IRC09:45
*** aloga has joined #openstack-nova09:45
*** udesale has joined #openstack-nova09:46
*** john51 has quit IRC09:46
*** derekh has joined #openstack-nova09:46
*** Tom-Tom has quit IRC09:48
*** ameeda has joined #openstack-nova09:50
ameedahello09:50
ameedacan you please review my code here https://review.openstack.org/#/c/528069/ ? and let me know if I have to consider force_delete and soft_delete09:51
*** rabel_b1 has quit IRC09:51
*** rabel_b1 has joined #openstack-nova09:51
*** sahid_ has joined #openstack-nova09:56
*** sahid has quit IRC09:56
*** sree has quit IRC10:02
*** gcb has quit IRC10:02
*** ljjjustin has quit IRC10:02
*** zhurong has quit IRC10:02
*** jichen has quit IRC10:03
*** hoangcx has quit IRC10:05
*** tinwood_ is now known as tinwood10:10
*** hoangcx has joined #openstack-nova10:11
*** cdent has joined #openstack-nova10:13
openstackgerritLajos Katona proposed openstack/nova master: WIP: Add nested resources to server moving tests  https://review.openstack.org/52772810:16
openstackgerritJie Li proposed openstack/nova master: Support volume-backed server rescue  https://review.openstack.org/53152410:17
*** Tom-Tom_ has quit IRC10:17
*** namnh has quit IRC10:18
*** Tom-Tom has joined #openstack-nova10:18
*** fragatina has joined #openstack-nova10:20
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2'  https://review.openstack.org/48438610:22
*** edmondsw has joined #openstack-nova10:22
*** Tom-Tom has quit IRC10:23
-openstackstatus- NOTICE: zuul has been restarted, all queues have been reset. please recheck your patches when appropriate10:25
*** edmondsw has quit IRC10:27
*** annp has quit IRC10:32
*** udesale has quit IRC10:34
*** udesale has joined #openstack-nova10:35
*** ygl has joined #openstack-nova10:37
*** ygl has quit IRC10:39
*** sahid_ has quit IRC10:40
*** sahid has joined #openstack-nova10:40
*** ameeda has quit IRC10:45
*** ameeda has joined #openstack-nova10:45
*** phuongnh has quit IRC10:46
openstackgerritchenpengzi proposed openstack/nova master: For a pre-generated example of the latest policy.yaml  https://review.openstack.org/53171310:48
*** sambetts|afk is now known as sambetts10:50
*** simondodsley has quit IRC10:50
*** simondodsley has joined #openstack-nova10:51
*** jamespage has quit IRC10:51
*** wolsen has quit IRC10:51
*** jamespage has joined #openstack-nova10:52
*** wolsen has joined #openstack-nova10:52
*** udesale has quit IRC10:54
*** moshele has quit IRC10:56
*** moshele has joined #openstack-nova10:57
*** abhishekk has quit IRC10:58
openstackgerritchenpengzi proposed openstack/nova master: For a pre-generated example of the latest policy.yaml  https://review.openstack.org/53171311:10
*** mvk has quit IRC11:20
*** hoangcx has quit IRC11:23
*** cdent has quit IRC11:31
*** zhurong has joined #openstack-nova11:35
*** smatzek has joined #openstack-nova11:40
*** smatzek has quit IRC11:40
*** smatzek has joined #openstack-nova11:40
openstackgerritchenpengzi proposed openstack/nova master: Add reference to policy sample  https://review.openstack.org/53171311:41
openstackgerritJianle He proposed openstack/nova-specs master: Back up volume-backed-instance  https://review.openstack.org/53021411:45
*** tuanla____ has quit IRC11:46
*** fragatina has quit IRC11:54
*** fragatina has joined #openstack-nova11:54
*** tiendc has quit IRC11:55
*** ratailor has quit IRC11:58
*** jistr is now known as jistr|mtg11:58
*** lucasagomes is now known as lucas-hungry12:00
*** sdague has joined #openstack-nova12:00
gibibauzas: left some questions / nits in https://review.openstack.org/#/c/514763/ Merry Christmas! ;)12:09
*** cdent has joined #openstack-nova12:09
*** dave-mccowan has joined #openstack-nova12:09
*** edmondsw has joined #openstack-nova12:10
*** gcb has joined #openstack-nova12:13
openstackgerritMerged openstack/nova master: Remove 'nova-manage host' and 'nova-manage agent'  https://review.openstack.org/52183712:14
*** edmondsw has quit IRC12:15
*** udesale has joined #openstack-nova12:16
ameedabauzas: can you please review my code here https://review.openstack.org/#/c/526900/12:20
*** liuyulong has quit IRC12:24
*** janki has quit IRC12:24
*** jpena is now known as jpena|lunch12:33
*** sree has joined #openstack-nova12:36
*** mvk has joined #openstack-nova12:37
*** sree has quit IRC12:41
hrwstephenfin: https://review.openstack.org/#/c/530965/ got +1 from zuul, has test coverage. can you +2 again?12:45
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/53173712:47
ameedaHello12:47
*** dave-mccowan has quit IRC12:47
ameedaI got this error when I run tox -e py2712:48
ameedaFutureWarning: fake is an invalid UUID. Using UUIDFields with invalid UUIDs is no longer supported, and will be removed in a future release. Please update your code to input valid UUIDs or accept ValueErrors for invalid UUIDs. See https://docs.openstack.org/oslo.versionedobjects/latest/reference/fields.html#oslo_versionedobjects.fields.UUIDField for further details12:48
ameedaany idea ?12:48
*** dave-mccowan has joined #openstack-nova12:49
sean-k-mooneyameeda: when using oslo versioned objects the validator for uuid fields check that the value is really a uuid. fake is not a uuid hence the error12:49
sean-k-mooneyameeda: is that from https://review.openstack.org/#/c/52690012:49
ameedasean-k-mooney: thanks for reply, no its from this https://review.openstack.org/#/c/528385/ when I move my code to _cleanup_volumes and modify the unit test for that12:51
ameedasean-k-mooney: here is my edit http://paste.openstack.org/show/640858/12:53
sean-k-mooneyoh ok you can use uuidgen on the commandline to generate a uuid for the tests for example e21d0851-3c56-4b9d-a133-a2c1ba59778a whcich you can use instead of fake to resolve the warning12:53
*** ktibi has joined #openstack-nova12:54
ameedasean-k-mooney: so I should use this uuid inside my code ? since the error appears in another file12:54
sean-k-mooneyonly if its cause by your code. if the warning is present without your patch you dont need to fix it.12:56
ktibiHi, do you think it's good if nova doesn't check if neutron have free IP before spawn instance ?12:56
ktibibecause I have a strange case where user spawn 200 vms with 50 free IP, and all my compute become disabled with "consecutive_build_service_disable_threshold"12:57
sean-k-mooneyameeda: oslo versioned objects uuid filed not emit this warning if invalid uuids are used but at present its only a warning to allow projects to fix there tests. in the future it will be changed to an error but only once most project have updated there tests12:57
*** sahid has quit IRC12:58
ameedasean-k-mooney: when I remove my code, the test success completely, and the error appears at another file where I add my code12:58
*** moshele has quit IRC12:59
*** sahid has joined #openstack-nova12:59
*** moshele has joined #openstack-nova12:59
sean-k-mooneyktibi: strictly speaking nova has no requirement that a vm will have an ip. it just requires that vms have mac adressses.12:59
*** rcernin has joined #openstack-nova13:00
ameedasean-k-mooney: if I do this http://paste.openstack.org/show/640870/ it will success ?13:00
sean-k-mooneyameeda: i would guess that uuids.instance on line 6 of http://paste.openstack.org/show/640858/ is the root of the warning13:00
*** zhurong has quit IRC13:01
*** cdent has quit IRC13:01
sean-k-mooneyameeda: try using e21d0851-3c56-4b9d-a133-a2c1ba59778a instead and see if it resolves the issue13:02
ameedasean-k-mooney: thanks alot, I will try that and let you know13:02
*** yasemin_ has quit IRC13:02
ameedasean-k-mooney: I have another issue with openstack overcloud image build in dib, can you help me with that ?13:03
sean-k-mooneyktibi: regarding your issue i dont think the compute nodes should become disabled just because a user ran our of ips in there subnet. was there any error reported in the n-cpu or n-sch logs?13:04
ktibisean-k-mooney so, with the default value for consecutive_build_service_disable_threshold, any user can disable all compute ?13:04
*** hieulq has quit IRC13:04
*** hieulq has joined #openstack-nova13:05
*** lucas-hungry is now known as lucasagomes13:05
sean-k-mooneyktibi: interesting looks like that is a new option in pike https://review.openstack.org/#/c/463597/13:06
openstackgerritBalazs Gibizer proposed openstack/nova stable/pike: Fix possible TypeError in VIF.fixed_ips  https://review.openstack.org/53174513:06
sean-k-mooneyktibi: it is intended to disable a compute node if there is an issue with the hypervisor like libvirt crashed or something like that. this would seam to be an edgecase13:06
ktibicompute node fail to spawn instance with error ==>Failed to allocate the network(s), not rescheduling13:07
bauzasgibi: thanks for the review, will upload a new change in 1 hour-ish13:07
*** moshele has quit IRC13:07
ktibisean-k-mooney user spawn 200 instances, so I have 20 fail on each compute, all my compte become disable !! very dangerous !!13:08
sean-k-mooneyktibi: as a work around you can set the config value to 0 to disable auto disable.13:08
ktibiI think this option need to be disable by default13:08
*** cdent has joined #openstack-nova13:09
sean-k-mooneyktibi: i actully tend to agree that this probably should not be enabled by default. that said i understand why you might want this13:09
openstackgerritBalazs Gibizer proposed openstack/nova stable/ocata: Fix possible TypeError in VIF.fixed_ips  https://review.openstack.org/53174613:10
*** Tom-Tom has joined #openstack-nova13:11
ameedasean-k-mooney: same error after change instance.uuids to e21d0851-3c56-4b9d-a133-a2c1ba59778a . see the error here http://paste.openstack.org/show/640881/13:11
sean-k-mooneystephenfin regarding https://review.openstack.org/#/c/463597/6 do you  recall why consecutive_build_service_disable_threshold is not disabled by default.13:12
*** sree has joined #openstack-nova13:13
*** lajoskatona has left #openstack-nova13:14
*** rcernin has quit IRC13:16
*** vladikr has joined #openstack-nova13:16
sean-k-mooneyameeda: so it looke like the varning changed form fake is an invalid UUID to fake_vol so im guessing the volume id is not set in the bdms object13:22
sean-k-mooneyameeda: you are extending https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute_mgr.py#L278-L30413:22
*** ratailor has joined #openstack-nova13:22
*** ratailor has quit IRC13:23
*** ygl has joined #openstack-nova13:24
*** pcaruana has quit IRC13:25
ameedasean-k-mooney: I try to do this http://paste.openstack.org/show/640891/, but it show me error said that instance doesn't has get_by_uuid attribute.13:25
*** liverpooler has joined #openstack-nova13:25
*** pcaruana has joined #openstack-nova13:25
ameedasean-k-mooney: what you guess me to do ? if I remove my changes, everything working fine13:27
*** cleong has joined #openstack-nova13:28
*** yamamoto has joined #openstack-nova13:28
ameedasean-k-mooney: when I do this http://paste.openstack.org/show/640894/ "note line 5" that will work fine.13:30
sean-k-mooneyameeda: am i have to run to a meeting sorry.13:30
*** jackie-truong has joined #openstack-nova13:30
ameedasean-k-mooney: no worries. thanks for your time :)13:30
stephenfinsean-k-mooney: If I recall correctly, it's something to do with lack of upcall support with a cells v2 deployment13:31
*** jpena|lunch is now known as jpena13:31
stephenfinor because it happened often enough to warrant enabling that feature by default13:31
stephenfinI don't really recall, tbh :/13:32
*** jistr|mtg is now known as jistr13:35
*** diga has joined #openstack-nova13:36
openstackgerritBalazs Gibizer proposed openstack/nova master: Transform missing delete notifications  https://review.openstack.org/41029713:41
yglsean-k-mooney: hi, I need some help on nova13:41
openstackgerritBalazs Gibizer proposed openstack/nova master: Send soft_delete from context manager  https://review.openstack.org/47645913:41
*** sree has quit IRC13:41
*** sree has joined #openstack-nova13:41
yglstephenfin: hi, i need some help on nova13:42
*** moshele has joined #openstack-nova13:45
*** sree has quit IRC13:46
ktibistephenfin sean-k-mooney I guess we have two solutions : 1/ disable by default this features 2/ change the detection which inscrease the trigger by detect only fail or error which does not concern quota or free IP13:47
*** READ10 has joined #openstack-nova13:47
stephenfinktibi: IMO, you'd be better waiting for dansmith and/or mriedem to pop up in an hour or two. I don't think you're the first person to have issues with this13:48
ktibibecause for now, I can disable all compute on a fresh install !! with a simple user. Create a network with 20 IP and spawn 90 instances !13:48
*** brault has joined #openstack-nova13:48
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt: Provide VGPU inventory for a single GPU type  https://review.openstack.org/51476313:50
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt: create vGPU for instance  https://review.openstack.org/52883213:50
openstackgerritSylvain Bauza proposed openstack/nova master: libvirt : Force a specificly static UUID for a mediated device  https://review.openstack.org/53175213:50
*** edmondsw has joined #openstack-nova13:51
*** bhagyashris has quit IRC13:52
hrwstephenfin: hello ;)13:53
*** jaypipes has joined #openstack-nova13:55
*** yamamoto has quit IRC13:56
efriedScheduler meeting in 4 minutes in #openstack-meeting-alt13:56
bauzasdamn, needs coffee then13:57
*** yamamoto has joined #openstack-nova13:57
*** takashin has joined #openstack-nova13:57
*** bhagyashris has joined #openstack-nova14:01
*** yamamoto has quit IRC14:01
*** Rambo__ has quit IRC14:01
*** esberglu has joined #openstack-nova14:03
*** fragatina has quit IRC14:11
*** fragatina has joined #openstack-nova14:11
*** yangyapeng has quit IRC14:11
*** stvnoyes has joined #openstack-nova14:12
*** lyan has joined #openstack-nova14:13
*** mriedem has joined #openstack-nova14:14
*** esberglu has quit IRC14:17
*** esberglu has joined #openstack-nova14:17
*** jmlowe has quit IRC14:19
*** smatzek has quit IRC14:21
*** esberglu has quit IRC14:22
*** eharney has joined #openstack-nova14:24
*** ygl has quit IRC14:28
*** lpetrut has joined #openstack-nova14:31
*** esberglu has joined #openstack-nova14:32
*** esberglu_ has joined #openstack-nova14:33
*** esberglu_ is now known as esberglu__14:34
*** esberglu has quit IRC14:37
*** burt has joined #openstack-nova14:38
*** yamamoto has joined #openstack-nova14:42
*** psachin has quit IRC14:45
*** yamamoto has quit IRC14:47
*** AlexeyAbashkin has joined #openstack-nova14:53
*** yasemin has joined #openstack-nova14:54
*** esberglu__ is now known as esberglu14:54
openstackgerritMerged openstack/nova master: Add index on token_hash and instance_uuid for console_auth_tokens  https://review.openstack.org/53147714:55
*** yamahata has joined #openstack-nova14:56
*** awaugama has joined #openstack-nova14:58
*** yangyapeng has joined #openstack-nova14:59
*** hongbin has joined #openstack-nova15:01
efriedcdent Yes, if update_provider_tree comes back with a provider removed, that means report client needs to delete that provider.15:01
cdentefried, jaypipes it would be great if we could do some of this discussion in email, so the results end up somewhere digestible. but if that's no good, we can carry on here (I'm in cafe land again, so don't want to hang out, now, but could another time)15:01
*** Guest8485 is now known as dansmith15:02
cdentdoesn't it mean instead that it is not used in this context? If we're including sharing providers in the ProviderTree, is there weirdness? I don't know, it's hard to think about in the abstract, and without whiteboards etc15:02
*** dansmith is now known as Guest6250115:02
mriedemyikun: https://review.openstack.org/#/c/531633/ looks ok once some nits are addressed and you can squash it into https://review.openstack.org/#/c/330406/15:03
*** sdague has quit IRC15:04
efriedcdent Yeah, that's a place we'll have to tread carefully.  If a virt decides it's no longer going to be associated with a sharing provider, it should remove itself from that aggregate... but should it also remove that provider?15:04
jaypipesefried: if the provider is gone, then yeah.15:05
jaypipesefried: but if the virt driver doesn't *own* that provider, then no.15:05
*** Guest62501 is now known as dansmith15:05
jaypipesefried: I think this is highly dependent on the virt driver.15:05
efriedjaypipes What does "own" mean?15:05
jaypipesefried: in the case of vCenter and PowerVM, the virt driver "owns" these shared pools of resources, right? so the virt driver can delete them.15:05
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_certs object  https://review.openstack.org/48940815:05
efriedjaypipes But how does the driver know it's the last one associated with the sharing provider?15:06
jaypipesefried: but for libvirt, it doesn't own any sharing providers. something else does and therefore it shouldn't delete sharing providers.15:06
jaypipesefried: that's up to you, baby.15:06
openstackgerritJackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API  https://review.openstack.org/48620415:06
efriedjaypipes Without talking to placement...15:06
jaypipesefried: powervm and vcenter, being virt drivers for clustered resource nodes, are going to have to handle that on their own.15:07
jaypipesefried: zookeeper maybe? I don't know :)15:07
cdentof just talk to the local third party agent which is talking to placement anyway, even though nova want "let" them15:07
cdents/want/won't/15:07
mriedemvcenter is no longer a clustered thing right? and powervm never was15:08
mriedemironic is our only 1:M virt driver15:08
efriedmriedem Clustered shared storage pool15:08
mriedemoh15:08
efriedThe quintessential shared provider case.15:08
mriedemhow would that not also affect libvirt?15:09
openstackgerritClaudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated  https://review.openstack.org/34221115:09
mriedemif you're using NFS or Ceph for local disk/15:09
mriedem?15:09
*** sbezverk has joined #openstack-nova15:09
efriedmriedem I think because those guys are going to manage the shared provider from some other control point.15:10
cdentmriedem: indeed. the assumption has been that "something else" is managing in that context, but I'm not sure we've really thought it all the way through15:10
efriedmriedem PowerVM (and apparently vCenter) are planning to manage the shared provider from virt.15:10
*** gouthamr has joined #openstack-nova15:11
mriedemoh15:12
*** AlexeyAbashkin has quit IRC15:13
mriedemwhy do we care about shared storage providers right now?15:13
mriedembecause of some design point being discussed in queens?15:13
efriedmriedem Good question.15:13
*** smatzek has joined #openstack-nova15:15
efriedWe've had some shared provider code in the codebase for a couple of releases, so we've been dragging it along and keeping it "working" as we've been tackling NRP et al.15:15
*** smatzek has quit IRC15:15
*** smatzek has joined #openstack-nova15:15
*** smatzek has quit IRC15:15
*** felipemonteiro has joined #openstack-nova15:15
efriedBut if we're looking for opportunities to limit scope, we did agree not to implement/declare shared provider support in Q.15:15
*** smatzek has joined #openstack-nova15:16
cdentI think it is coming up because it was a nodal point in the discussion about whether virt drivers can or should be able to talk to placement themselves15:16
mriedemwe don't need to intentionally make something not work in the future, but for places where we expect we'll need to change things later for shared providers to work, we should just leave TODOs  - dansmith did some of that with the migration allocation swap series15:16
efriedcdent Agree.  But the question remains: do we need to solve this in Q?15:16
*** Apoorva has joined #openstack-nova15:17
cdentI don't think we _have_ to, no15:17
cdentBut it often feels kike we push off design discussion too often15:17
mriedemedleafe: on https://review.openstack.org/#/c/531405/ - i pulled that down and made these changes http://paste.openstack.org/show/640953/ - if you don't think those are terrible, i could push those up15:17
mriedemmaybe CastAsCall isn't something we really want to use since it masks real api behavior that the user would see15:18
mriedemcdent: we also have a tendency to over design and not get anything done15:18
*** amodi has joined #openstack-nova15:19
cdentefried: I need to change locations. I hope we can continue touching on this over time, but agree in the short term that shared providers is not something we're going to finish this cycle15:19
mriedems/finish/even spend time on/15:19
efriedcdent Buzz me when you get back on, want to continue discussion.15:19
cdentmriedem: can you say that while simultaneously affirming that we merge more code than any other openstack project :)15:19
cdentefried: will do15:20
*** ktibi has quit IRC15:20
mriedemi don't know how much code we merge relative to other projects15:20
*** cdent has quit IRC15:20
efriedPerpetual challenge to strike the right balance.  I don't think it's a systemic problem in either direction; just needs to be managed on a case-by-case.15:21
mriedemi'm just commenting from the sidelines as i haven't been involved in coding or reviewing the NRP series,15:23
mriedemi'm just concerned that we're spending a lot of time designing the end thing right now and we'll miss the boat on getting anything functional in queens15:24
efriedmriedem Well, we've already landed a *lot* of functional stuff in queens.  And I think we're on track to get the rest done.  (That was specifically brought up and agreed in the sched meeting.)15:24
mriedemi'm going to try and wrap up the series of changes i've been pushing/reviewing for the last few weeks to get done this week b/c i'm out next week15:25
*** jmlowe has joined #openstack-nova15:25
mriedembauzas: are you back to help review stuff this week?15:26
*** yamamoto has joined #openstack-nova15:27
*** eharney has quit IRC15:29
*** SamYaple_ has quit IRC15:30
*** SamYaple has joined #openstack-nova15:30
lyarwoodmdbooth: https://review.openstack.org/#/c/531233/ - FYI the bugfix from before the break15:30
*** moshele has quit IRC15:30
mdboothlyarwood: Yes15:31
*** rmart04 has joined #openstack-nova15:31
mdboothlyarwood: IIRC I preferred to attach/detach encryptors in attach/detach volume?15:32
mdboothBecause those 2 things should always happen together15:32
*** yamamoto has quit IRC15:32
lyarwoodmdbooth: yeah I think the issue with that was wiring the request context into yet more places15:33
*** takashin has quit IRC15:33
mdboothlyarwood: Well lets wire away, because the alternative is a trickle of bugs15:34
mdboothIt's probably not that many15:34
*** diga has quit IRC15:34
mdboothHmm, I thought I had some notes on this.15:35
mdboothlyarwood: I literally just finished what I was doing earlier. Let me grab a coffee and look hard at this again.15:35
lyarwoodmdbooth: kk, the refactor is the patch below this btw15:35
mriedemdansmith: want to hit this backport again? https://review.openstack.org/#/c/530982/15:37
dansmithyou know I do15:37
hrwmriedem: hello15:37
hrwmriedem: https://review.openstack.org/#/c/530965/ got +1 from Zuul ;)15:38
mriedem+2 again15:39
hrwthanks mriedem15:41
hrwstephenfin: your turn then ;D15:41
*** ktibi has joined #openstack-nova15:42
stephenfinhrw: and +W here15:43
*** ameeda has quit IRC15:43
*** mlavalle has joined #openstack-nova15:43
stephenfinCheers for the quick follow-ups on that, hrw15:43
hrwstephenfin: ;)15:44
hrwstephenfin: like I said yesterday - it help keeping reviewers attention ;D15:44
* hrw bbl15:45
*** nicolasbock has joined #openstack-nova15:45
openstackgerritMerged openstack/nova master: Optionalize instance_uuid in console_auth_token_get_valid()  https://review.openstack.org/48170015:47
openstackgerritMerged openstack/nova master: Add ConsoleAuthToken object  https://review.openstack.org/32006315:47
*** tidwellr has joined #openstack-nova15:47
*** gcb has quit IRC15:48
*** cfriesen has quit IRC15:49
*** Tom-Tom has quit IRC15:52
*** yamamoto has joined #openstack-nova15:53
*** yamamoto has quit IRC15:53
*** Tom-Tom has joined #openstack-nova15:53
*** matrohon has joined #openstack-nova15:53
*** felipemonteiro has quit IRC15:54
*** felipemonteiro has joined #openstack-nova15:55
openstackgerritMatt Riedemann proposed openstack/nova master: Add regression test for resize failing during retries  https://review.openstack.org/53140515:55
openstackgerritMatt Riedemann proposed openstack/nova master: Fix race condition in retrying migrations  https://review.openstack.org/53102215:55
openstackgerritMatt Riedemann proposed openstack/nova master: Change compute RPC to use alternates for resize  https://review.openstack.org/52643615:55
mriedemedleafe: addressed my nits in the regression test patch, and fixed my -1 in the regression bug fix patch in the middle, rebased the series to master also ^15:55
matrohonmriedem: hi15:56
openstackgerritStephen Finucane proposed openstack/nova master: fixup! console: introduce the VeNCrypt RFB authentication scheme  https://review.openstack.org/53183315:56
openstackgerritStephen Finucane proposed openstack/nova master: console: Send bytes to sockets  https://review.openstack.org/53183415:56
stephenfinOops15:57
*** Tom-Tom has quit IRC15:57
*** SamYaple has quit IRC15:57
*** SamYaple has joined #openstack-nova15:57
mdboothHehe15:58
openstackgerritStephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication  https://review.openstack.org/34539715:58
openstackgerritStephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme  https://review.openstack.org/34539815:58
openstackgerritStephen Finucane proposed openstack/nova master: console: Provide an RFB security proxy implementation  https://review.openstack.org/34539915:58
*** SamYaple has quit IRC15:58
openstackgerritStephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy  https://review.openstack.org/50054415:58
openstackgerritStephen Finucane proposed openstack/nova master: console: Send bytes to sockets  https://review.openstack.org/53183415:58
mriedemmatrohon: hi15:58
*** SamYaple has joined #openstack-nova15:58
mriedemdansmith: i'm +2 on edleafe's fix for the cold migration + reschedule regression (and the test patch below it) https://review.openstack.org/#/c/531022/15:58
matrohonmriedem: I was trying to boot a VM without an IP, but I can't find a way to do so15:59
mriedemmatrohon: use at least microversion 2.37 to create the server and pass networks='none'16:00
mriedemsee the 'networks' parameter here https://developer.openstack.org/api-ref/compute/#create-server16:00
matrohonmriedem: great! I reported a related bug, but I'll try it the way you mention16:01
matrohonmriedem: However, I'm not sur my bug is pointless : https://bugs.launchpad.net/nova/+bug/174157516:01
openstackLaunchpad bug 1741575 in OpenStack Compute (nova) "creating a VM without IP (ip_allocation=None)" [Undecided,New]16:01
mriedemmatrohon: yeah https://bugs.launchpad.net/nova/+bug/1741575 is something else16:02
*** AlexeyAbashkin has joined #openstack-nova16:02
mdboothlyarwood: Ah, yes16:02
mdboothlyarwood: So, we call _connect_volume in _get_guest_xml, which is pretty unambigously a bug16:03
*** rmart04 has quit IRC16:03
mdboothBut it's a bug we rely on in a couple of places16:03
mdboothI have some notes I made before the break about how to unwind that16:03
mdboothApart from that, we'd need context in swap_volume16:05
matrohonmriedem: I briefly discussed with carl_baldwin a long time ago, how told me he didn't finished the job on the nova side. At least, he didn't submit anything related to the case where "ip_allocation=none".16:05
lyarwoodmdbooth: for the bugfix I'm now providing that16:05
mdboothlyarwood: Which... we do anyway. Doesn't look like we're handling encryptors there.16:05
*** chyka has joined #openstack-nova16:05
mdbooth_create_domain_setup_lxc()16:05
*** sridharg has quit IRC16:06
mdboothlyarwood: pre_live_migration() ?16:06
*** AlexeyAbashkin has quit IRC16:06
mdboothI don't immediately see where we're attaching encryptors there16:07
mdboothSo my vote would be:16:07
mdbooth1. unpick _connect_volume() in _get_guest_xml()16:08
mdbooth2. pass context to swap_volume()16:08
mdbooth3. Implement ajttach/detach encryptors in LibvirtDriver._connect/disconnect_volume16:08
lyarwoodurgh, 1 would make this a risk to backport16:09
mdboothThen we can be reasonably confident that we caught all the cases, and nobody will introduce any more in the future.16:09
*** cdent has joined #openstack-nova16:09
mdboothlyarwood: I don't think it's as bad as you think16:09
lyarwoodalso another reason not to do this for the bugfix would be the change in error handling16:09
lyarwoodwe often don't connect/disconnect in the same try block as attaching/detaching encryptors16:09
mdboothWell we should...16:10
lyarwoodyeah agreed, but that's not part of this bugfix16:10
mdboothThat's only going to simplify error handling, no?16:10
dansmithmriedem: okay I'm going through bauzas' gpu set and then will circle back to that16:10
lyarwoodmdbooth: yeah but the _get_guest_xml() cleanup and merging attach/detach encryptors into connect/disconnect volume just seems way over the top for a simple, easily backportable fix for swap_volume tbh16:11
mdboothlyarwood: I don't think a 'proper' fix is all that messy in this case. My concern is that if we apply 4 more bits of band-aid we won't ever fix it.16:11
cdentefried: i'm back, for a while16:12
mdboothWhat about pre_live_migration()?16:12
lyarwoodmdbooth: it's hardly band-aid16:12
mdboothAre we handling that somewhere else?16:12
efriedcdent I'm writing up a summary and adding it to the review (https://review.openstack.org/#/c/526539/)16:12
cdentefried++16:12
lyarwoodmdbooth: https://bugs.launchpad.net/nova/+bug/1633033 - sorry that took a little digging16:15
openstackLaunchpad bug 1633033 in OpenStack Compute (nova) "live migration with encrypted volume fails" [Undecided,In progress] - Assigned to Lee Yarwood (lyarwood)16:15
mdboothlyarwood: Ok, so looks like that's broken too, same root cause16:16
lyarwoodyup16:16
mriedemlyarwood: mdbooth: why don't you do the short-term backportable fix and then do the refactor on master which isn't backported?16:16
mriedemdon't refactor a bunch of code that you're going to backport16:16
mdboothLooking back over my notes, actually I think the _get_guest_xml fix is really easy16:16
lyarwoodmriedem: I'm trying to suggest that, I really don't want to play around with _get_guest_xml in backports16:17
mdboothlyarwood: The reason is that everywhere that calls _get_guest_xml either subsequently calls _create_domain_and_network, or doesn't pass block_device_info, so doesn't call _connect_volume16:17
mdboothWhich means that all you need to do is move _connect_volume from _get_guest_xml to _create_domain_and_network16:18
mdboothWhich is also totally intuitive16:18
mdboothI've audited ^^^, but feel free to do the same16:18
*** brad[] has joined #openstack-nova16:18
mdbooth_create_domain_and_network already has context, which also makes sense16:18
mdboothSo that change isn't going to be invasive at all16:19
matrohonmriedem: I'm not sure networks=none would help me. My VM needs a port, but a port without IP.16:19
mriedemmatrohon: yeah it won't16:19
mriedemnetworks=none means no ports16:19
mriedemi didn't know about ip_allocation='none'16:19
mdboothlyarwood: Whatever way you look at it, we need context in swap_volume anyway16:20
mdboothSo that part needs to be done anyway16:20
lyarwoodmdbooth: and is in the bugfix16:20
mdboothlyarwood: I don't see it in that review stack16:20
lyarwoodmdbooth: https://review.openstack.org/#/c/531233/3/nova/virt/libvirt/driver.py16:20
mdboothNP, now I do16:20
matrohonmriedem: ok, I can work on fixing 1741575, with the attached patch as a first step16:21
mdboothlyarwood: Ok, that bit's already done.16:21
*** armax has joined #openstack-nova16:21
mdboothWith those bits in place, moving the encryptor call into _connect/_disconnect is trivial16:21
mdboothAnd no harder to backport16:21
mdboothAnd also fixes pre_live_migration16:21
mdboothAnd anything else we missed16:22
mdboothDoes lxc have encryptors?16:22
matrohonmriedem: do you think I need something else than the bug report to start submitting code review?16:23
lyarwoodmdbooth: well, the frontend encryptors are host level so yeah, I can't see why not.16:23
lyarwoodmdbooth: not that they are tested anywhere.16:23
mdboothlyarwood: Ok, that's probably a bug too, then16:23
mdboothSo it's a 3 for 1 fix16:23
*** sshwarts has quit IRC16:24
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276616:24
lyarwoodmdbooth: right, I'll respin without moving _connect_volume out of _get_guest_xml16:24
mdboothI don't think you can do that16:24
lyarwoodright, context16:24
mdboothActually it's already there16:25
mdboothBut you'd have to remove the encryptor stuff from _create_domain_and_network16:25
mdboothWhich is just backwards16:25
mriedemmatrohon: no16:25
mdboothMight as well go the other way16:25
mriedembug fix is fine16:25
matrohonmriedem: ack, thanks16:25
mriedemmatrohon: but i looked at the patch and it doesn't really make sense to me, unless a port with ip_allocation='none' results in port.get('ip_allocation') == None?16:25
efriedjaypipes cdent What is the behavior when I try to delete a provider that has "stuff" associated with it?16:27
*** krtaylor has quit IRC16:27
efriedI think I've seen some cases where we automatically delete the "stuff" and some where we bounce.16:27
*** felipemonteiro has quit IRC16:27
*** krtaylor_ has joined #openstack-nova16:27
cdentfails, if there are allocations we bounce16:27
matrohonmriedem: port.get('ip_allocation') == None is the unexpected result, I'm currently trying to find the reason why. I probably need to fix that first on the neutron side16:27
cdentI think that's the only one, but let confirm16:27
efriedcdent I'm talking about inventory, aggregates, traits - but most especially aggregates at the moment.16:28
*** kumarmn has joined #openstack-nova16:29
jaypipesefried: we just delete.16:29
jaypipesefried: allocations are the only thing that prevents deletion (and child providers)16:29
mriedemmatrohon: if neutron needs changes to support this case, then things get sticky with regards to interoperability16:29
cdentefried: https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L81616:29
efriedjaypipes Okay.  So this is tricky.16:29
mriedembecause if you upgrade nova to handle this none scenario but neutron doesn't support it, things fail, and vice-versa16:29
*** kumarmn has left #openstack-nova16:29
efriedcdent Thanks, it's all right there!16:30
*** udesale has quit IRC16:30
edleafemriedem: just getting caught up (sitting in traffic is *so* productive!)16:31
edleafemriedem: your changes look fine16:31
edleafemriedem: some of the issues you asked about on the review were from the original test, which was supposed to test alternate host usage; hence the 4 computes and such16:32
matrohonmriedem: but ip_allocation16:33
edleafeI'm going to add that test to the resize patch16:33
matrohonmriedem: sorry16:33
efriedcdent jaypipes So this might be okay.  A virt that's "leaving" an aggregate should only delete the aggregate association from self, not delete it from the aggregate or delete the shared provider.  The sharing provider will still show up in the ProviderTree, so report client won't delete it.  Then the next time we pull the compute RP and its associations, that sharing provider will be absent (because no longer associated by a16:33
efriedggregate) so we'll... drop it from the local provider tree at that time, somehow.16:33
*** jistr is now known as jistr|off|mtg16:33
mriedemedleafe: add the test to the resize patch?16:33
mriedemedleafe: the test is already there since it comes before it in the series16:33
edleafemriedem: the regression test really doesn16:33
edleafedoesn't check that the alternate hosts stuff is working as expected16:34
edleafejust that it doesn't blow up :)16:34
cdentefried: I think that sounds right, but as your patient, I'm going to the bath, will bbl16:34
mriedemso you're going to modify the regresssion test to add to it in the resize patch16:34
efriedcdent Enjoy16:34
edleafemriedem: no, more or less copy parts to make a new functional test that's alternate host-specific16:35
ktibidansmith Hi do you know why consecutive_build_service_disable_threshold default value is 10 ?16:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040616:35
*** cdent has quit IRC16:35
ktibibecause I found a method for disable all compute service with a simple user :/16:35
matrohonmriedem: I'll keep on digging on the neutron side first, since not having the ip_allocation field set in port's attributes retrieved by a REST request, when it is explicitly set in the database is not really clean16:35
dansmithktibi: yes, because I set it to 10 after discussion in the room with a bunch of operators16:36
matrohonmriedem: don't you think?16:36
mriedemmatrohon: i agree that None != unset and there are differences in client side behavior potentially, yes16:36
dansmithktibi: what's the method? might be something we need to exclude from the disable logic if it's not really a fault16:36
mriedemmatrohon: but i don't really know how that's all used on the neutron side16:36
ktibiok, 10 is good but for now, you can fool nova for disable all compute16:37
openstackgerritMatthew Booth proposed openstack/nova master: Don't connect volumes in _get_guest_storage_config  https://review.openstack.org/53185216:37
jaypipesefried: yeah, that sounds about right to me, too.16:37
mdboothlyarwood: ^^^16:37
efriedjaypipes Dangit, that still leaves us with orphan-able shared providers.16:37
mdboothlyarwood: Lets see how that does against tempest, but that change would be extremely backportable16:37
mriedemktibi: perhaps you'd like to share how users can do that16:38
efried(aside from being asymmetrical)16:38
ktibidansmith if you spawn multi instances in a network with 0 free IP, nova fail to spawn and increase the trigger. if you deploy ~60 instances, you disable 6 computes16:38
dansmithktibi: what's the method?16:38
matrohonmriedem: I'll have a look, but AFAIK, routed networks is the only feature really using the ip_allocation field for now16:38
*** kmalloc has joined #openstack-nova16:38
ktibione user disable my 15 computes with spawn 200 instance on a /28 private network16:38
jaypipesefried: don't worry about that too much.16:39
dansmithktibi: if you only have 6 computes or are packing tight I guess, but remember it has to be consecutive, so a cloud with reasonable activity will not suffer from that16:39
jaypipesefried: let's focus on the nested providers handling.16:39
dansmithktibi: but if there's something we can catch about that specific case and not count it in the total, that would make sense16:39
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: libvirt: Use only existing mdevs if kernel race  https://review.openstack.org/53185316:39
*** gyee has joined #openstack-nova16:39
jaypipesefried: orphaned stuff can always be cleaned up by an external perioidic.16:39
mdboothlyarwood: The importance of ^^^ is that the above is where we currently do connect_volume/attach_encryptors separately somewhat deliberately. We fix that, then everything remaining is a bug.16:39
efriedjaypipes Ick.  But okay.  Guess that's not the worst thing in the world.16:40
mriedemktibi: what is the error you get in the compute? PortLimitExceeded?16:40
mriedemthe api should be checking the port quota based on the number of instances and selected network before doing scheduling16:40
bauzasdansmith: thanks for the reviews :)16:40
mriedemwhich is racy, but still it's a check that happens16:40
bauzasdansmith: I just added a new WIP change that will see the direction for the kernel race16:40
ktibimriedem ailed to allocate the network(s), not rescheduling16:40
*** Eran_Kuris has quit IRC16:41
mriedemktibi: yeah, but wondering what triggers that, a specific exception16:41
ktibinot quota check :/ just no more IP free in the pool16:41
mriedemdo you have a stacktrace you can put in a paste?16:41
ktibiyep wait plz16:41
openstackgerritStephen Finucane proposed openstack/nova master: Fix typo in release note  https://review.openstack.org/53185416:41
mriedemNoMoreFixedIps ?16:41
ktibiyes16:41
bauzasdansmith: I'll also add a follow-up that will try to find the existing mdev 'allocations' (ie. which mdev is used by which instance) at init_host()16:41
stephenfinjaypipes, mriedem: Could one of you push that reno typo fix through? https://review.openstack.org/53185416:41
mriedemktibi: can you report a bug? maybe we can build a whitelist of exception types that shouldn't be used to auto-disable a compute16:42
dansmithbauzas: not sure what kernel race you mean, but cool16:42
bauzasfun fact, I also discovered that the nvidia driver can't support the same physical GPU having more than 1 allocated mdev per guest16:42
jaypipesstephenfin: done16:42
lyarwoodmdbooth: back sorry16:42
stephenfinjaypipes: Cheers :)16:42
jaypipesnp16:42
bauzasdansmith: the fact that when calling sysfs, libvirtd doesn't get the update so it won't change the values of availableInstances and won't show up the newly created mdecs16:43
lyarwoodmdbooth: that's going to break iSCSI volumes16:43
ktibimriedem  https://thepasteb.in/p/zmh8qDG2ZYJIZ16:43
mdboothlyarwood: How?16:43
dansmithbauzas: oh I understand that bug.. is that why you're saying we can't/shouldn't do it in init_host()16:43
dansmith?16:43
dansmithbauzas: and what's the status of a fix for that issue?16:44
lyarwoodmdbooth: we need the volumes connected before we fetch the storage config16:44
bauzasdansmith: the reboot issue or the kernel issue ?16:44
lyarwoodmdbooth: because of this wonderful connection_info stashing bs https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/iscsi.py#L6716:44
bauzasdansmith: for the kernel, I have a race16:44
bauzasoops16:44
bauzasI have a change16:44
mdboothlyarwood: That would bizarre16:44
*** jpena is now known as jpena|brb16:44
dansmithbauzas: the libvirt-does-not-notice-sysfs-changes issue16:44
bauzasdansmith: last patch I just uploaded couple of mins ago16:45
ktibidansmith and I don't understand your comment, a cloud with "reasonable activity will not suffer from that" ! you think all openstack plateform have 50 instance creation/ min ?16:45
mdboothlyarwood: Ah, we do that everywhere16:45
bauzasdansmith: for the init_host thingy, I'll try to use statically generated UUIDs16:45
dansmithbauzas: why does this only effect bootstrapping and not our actual allocation for guests?16:45
mriedemktibi: hmm, that's less specific than i'd like16:45
mriedemktibi: i thought it was failing when nova created the port16:45
mriedembut it's failing when nova plugs the vif16:45
dansmithbauzas: aren't the uuids stored in the guest xml already?16:45
bauzasdansmith: if the guest XML is not recreated, yes16:46
mdboothlyarwood: So we need to ensure that in all cases we connect volumes before getting volume info, which makes sense16:46
bauzasbut I think I discovered a couple of places where it's dangerous to count on that16:46
bauzaslike hard reboot AFAIR16:46
dansmithktibi: no, I understand a smaller cloud could hit that, but presumably those clouds are a little less concerned about real users launching a DoS, but I'm not arguing that it should be fixed16:46
efriedjaypipes I added a summary on https://review.openstack.org/#/c/526539/16:46
dansmithbauzas: right but on init_host(), we could find all the previously-used uuids16:46
jaypipesefried: danke16:47
bauzasdansmith: yeah, we can try16:47
efriedjaypipes Is there anything else needed to get that patch going?16:47
dansmithbauzas: seems like the obvious thing to do, IMHO16:47
jaypipesefried: nope.16:47
bauzasdansmith: my point is, that run can last a while16:47
efriedjaypipes (All action items related to that discussion will happen in later/other patches)16:47
efriedjaypipes Cool.16:47
bauzasdansmith: anyway, let's try16:47
jaypipesefried: I just finishing up working on n-r-p in allocation candidates)16:47
efried++16:47
dansmithbauzas: if they aren't in the guest xml, then they weren't setup properly when we shut down the last time16:47
*** david-lyle has quit IRC16:47
dansmithbauzas: so if hard reboot blows the xml away, it was broken before reboot, thus init_host isn't making things worse16:48
*** david-lyle has joined #openstack-nova16:48
bauzasdansmith: that's also interesting to see that ovirt folks also had the approach of a deterministic UUID for the mdev16:48
*** pcaruana has quit IRC16:48
bauzasdansmith: FYI https://mpolednik.github.io/2017/05/21/vfio-mdev/16:48
*** yamahata has quit IRC16:48
dansmithbauzas: I think a deterministic uuid is a bad idea, personally16:48
ktibidansmith I have a private cloud plateform with ~1500 Vms, it's not very small for me :/ just a user create 200 instances at 4AM ^^16:48
dansmithktibi: again, I'm not arguing16:49
*** damien_r has quit IRC16:49
bauzasdansmith: I need to go to the doctor for 1 hour, but I'll work tonight16:49
mriedemktibi: can you find the related failure from the neutron logs?16:49
bauzaslet's wrap up that convo later16:49
mriedemktibi: all nova gets back from neutron is an event saying vif plugging failed16:49
dansmithbauzas: okay16:49
mriedemwhich doesn't tell us why it failed at all16:49
ktibidansmith yes no pb ;) just the issue can touch large cloud I think :/16:49
bauzasdansmith: anyway, the deterministic UUID thingy is separated from the other changes in my series, so if we see it's a non-sense, I'm fine dropping it16:50
dansmithbauzas: ack16:50
mdboothlyarwood: Ok, that's slightly more complex, but still not a showstopper. We need to pull host volume operations out of _create_domain_and_network, and explicitly call _connect_volume before getting guest xml if required.16:50
mdboothOr just move it all into _get_guest_storage_config after all16:50
ktibimriedem I'll try to get logs from neutron16:50
mdboothNot what I had in mind, but would still be a consolidation16:50
mriedemmdbooth: is this a WIP? https://review.openstack.org/#/c/531852/16:51
mriedemif so, can you WIPify it?16:51
mdboothmriedem: Yep, will do16:52
mriedemthanks16:52
lyarwoodmdbooth: yeah context down to _get_guest_storage_config and then merge the encryptor stuff into _connect/disconnect_volume16:52
*** david-lyle has quit IRC16:52
*** amodi has quit IRC16:52
mdboothlyarwood: And *remove* it from _create_domain_and_network16:52
* lyarwood nods16:52
mdboothWe can already be confident that nothing is relying on that to do volume connection, because it never has16:53
lyarwoodmdbooth: in one change?16:53
mdboothWas just thinking about that. I don't see why not.16:53
*** Tom-Tom has joined #openstack-nova16:53
*** yamamoto has joined #openstack-nova16:53
lyarwoodmdbooth: k, I'll reuse the refactor change16:53
mdboothYou might want the swap_volume patch first, though16:53
mdboothAnd lxc16:53
mdboothMy WIP above?16:54
lyarwoodah true16:54
lyarwoodmdbooth: no my original16:54
mdboothIf you're going to take it I'll just abandon that16:54
ktibimdbooth nothing in neutron-server.log :/ 0warning 0 error16:54
mdboothkk, cool16:54
ktibioups sorrty for mriedem16:55
mriedemjaypipes: interested if adding an index is worth it for this https://review.openstack.org/#/c/531132/3/nova/db/sqlalchemy/migrate_repo/versions/376_add_migrations_updated_at_index.py - it's adding an index for listing migrations and filtering on updated_at (--changes-since); the query could have other columns/filters in it, so not sure if the index really helps or not16:58
*** Tom-Tom has quit IRC16:59
jaypipesmriedem: soon as I'm done with two other series reviews, will review.16:59
mriedemalthough my guess is if you just did "nova migration-list --changes-since x" it would help16:59
*** slaweq has joined #openstack-nova17:00
*** yamamoto has quit IRC17:02
*** jmlowe has quit IRC17:02
openstackgerritMatt Riedemann proposed openstack/nova master: Add migration db and object pagination support.  https://review.openstack.org/51490417:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations  https://review.openstack.org/51727317:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040617:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add index(updated_at) on migrations table.  https://review.openstack.org/53113217:06
stephenfinralonsoh: Can we merge [1], given that [2] isn't working yet? [1] https://review.openstack.org/#/c/484386/ [2] https://review.openstack.org/#/c/530961/17:06
mriedemdtantsur: re: CI testing for ironic+bfv https://review.openstack.org/#/c/468353/ - is there at least an existing job that ironic uses for this? if so, we can add that to nova's experimental queue17:08
*** mvk has quit IRC17:09
dtantsurmriedem: yep ironic-tempest-dsvm-bfv17:09
*** slaweq has quit IRC17:11
dtantsurwanna me propose a patch?17:14
efriedjaypipes (and another core, maybe stephenfin or bauzas?) would you please add https://review.openstack.org/#/c/518633/ to your list?  The patch above that is already +W, and it'll be nice to have for your nrp test case (https://review.openstack.org/#/c/531443/)17:14
stephenfinefried: Won't get to it myself today, but if it's still there tomorrow then I'll take a shot17:14
efriedstephenfin Thanks17:14
mriedemdtantsur: sure17:15
mriedemefried: i'll take a look17:15
efriedmriedem Thanks.17:15
*** yamahata has joined #openstack-nova17:20
ralonsohstephenfin: sorry for the delay. [2] is working now17:20
ralonsohstephenfin: openstack-tox-functional-with-sudoSUCCESS in 4m 00s17:20
stephenfinralonsoh: Oh, congrats! Nice work17:21
ralonsohstephenfin: Am I missing something?17:21
ralonsohstephenfin: oooook!17:21
* stephenfin spent an hour on that Friday with no success17:21
ralonsohstephenfin: Sean's magic.... you know17:21
stephenfinOh, I know :)17:21
stephenfinCool. I'll review that tomorrow morning so17:21
ralonsohstephenfin: thanks!17:22
stephenfinnp17:22
*** jpena|brb is now known as jpena17:24
jaypipesefried: just finishing up a review on that, yes.17:25
*** itlinux_ has joined #openstack-nova17:27
jaypipesefried: done17:29
*** Apoorva has quit IRC17:29
EmilienMmriedem: hey matt, I remember we had a thread about how to handles patches like https://review.openstack.org/531055 - I don't recall the outcome, do you have the link of the thread?17:29
*** itlinux_ has quit IRC17:30
*** itlinux_ has joined #openstack-nova17:30
openstackgerritClaudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated  https://review.openstack.org/34221117:31
*** itlinux_ has quit IRC17:31
*** itlinux_ has joined #openstack-nova17:31
*** matrohon has quit IRC17:31
mriedemEmilienM: the eventual outcome was the first contact SIG17:31
EmilienMok17:31
mriedemhttps://wiki.openstack.org/wiki/First_Contact_SIG17:32
mriedemand http://superuser.openstack.org/articles/sig-first-contact-openstack/17:32
mriedemi guess point them at that?17:32
EmilienMmriedem: ok, thx17:33
mriedemshould probably build something into the first-time contributor comment that people get on their patch too17:33
EmilienMmwhahaha: ^17:33
EmilienMthe thing is I'm not sure this is a new contributor: https://review.openstack.org/#/q/owner:shangxiaobj%2540inspur.com+status:merged17:33
EmilienMthe person is doing http to https a lot and it waste so much CI resources imho17:34
*** david-lyle has joined #openstack-nova17:34
mriedemyeah they aren't,17:34
*** itlinux_ has quit IRC17:34
mriedemi'd probably ping huang zhipeng (howard)17:34
mriedemhe's in china and on the first contact sig group17:34
mriedemi think a bunch of these contributors from chinese companies actually hang out in a wechat group for openstack,17:35
*** tidwellr has quit IRC17:35
*** tidwellr_ has joined #openstack-nova17:35
mriedemso he sometimes proxies stuff to that group where people are actually listening (and speaking the same language)17:35
EmilienMmriedem: ok thx for the advises17:35
mriedemyw17:35
*** itlinux_ has joined #openstack-nova17:36
*** eharney has joined #openstack-nova17:37
*** itlinux_ has quit IRC17:37
*** itlinux_ has joined #openstack-nova17:38
*** itlinux_ has quit IRC17:42
*** itlinux_ has joined #openstack-nova17:42
jaypipestox -efast8 would be fast if it didn't try to reinstall all the global requirements each time I run it.17:42
*** itlinux_ has quit IRC17:43
mriedemit shouldn't try to re-install them17:43
mriedempip + wheels should have all of that cached17:43
*** yamamoto has joined #openstack-nova17:43
mriedemplus your existing venv would have them17:43
*** yamamoto has quit IRC17:43
*** felipemonteiro has joined #openstack-nova17:45
openstackgerritMerged openstack/os-vif master: Migrate from 'ip' commands to 'pyroute2'  https://review.openstack.org/48438617:45
*** amodi has joined #openstack-nova17:46
*** david-lyle has quit IRC17:47
*** itlinux_ has joined #openstack-nova17:49
*** itlinux_ has quit IRC17:49
*** itlinux has joined #openstack-nova17:50
mriedemefried: so i got looking at https://review.openstack.org/#/c/509892/ again,17:50
mriedemand didn't realize it until now but we never leverage the session client stuff in neutronclient17:50
mriedemhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L25117:50
mriedemoh nvm i guess that checks for a session kwarg https://github.com/openstack/python-neutronclient/blob/master/neutronclient/client.py#L38917:51
mriedemconfusing method name17:51
jaypipesmriedem: still takes 10+ seconds to run the "develop-inst-nodeps" part of the job :(17:52
*** lucasagomes is now known as lucas-afk17:52
jaypipesmriedem: which I presume is just comparing pip freeze outputs?17:53
mriedemno idea17:53
dtantsurjaypipes: also downloads upper-constraint, if it's a typical job17:54
* dtantsur disappears again17:54
jaypipes:)17:54
*** AlexeyAbashkin has joined #openstack-nova17:54
*** itlinux has quit IRC17:55
*** itlinux has joined #openstack-nova17:56
mriedemprobably an easy +W on efried's neutronclient change to use the ksa adapter stuff https://review.openstack.org/#/c/509892/17:56
*** Apoorva has joined #openstack-nova17:57
*** AlexeyAbashkin has quit IRC17:58
*** rabel_b1 has quit IRC17:58
dtantsurmriedem: oh, you guys haven't switched to in-tree zuul stuff, have you?17:58
mriedemdtantsur: started to17:59
mriedembut not much there yet17:59
mriedemactually nothing until https://review.openstack.org/#/c/514309/17:59
dtantsurI see. so any changes still go to project-config?17:59
mriedemdtantsur: yeah17:59
mriedemunless you want to build it on top of https://review.openstack.org/#/c/514309/17:59
mriedemmelwitt: you want to get https://review.openstack.org/#/c/514309/ since you've looked at the zuulv3 in-repo stuff before?17:59
dtantsurlemme see what is easier18:00
mriedemstvnoyes: an update on multiattach testing - i added some more tests over the weekend to https://review.openstack.org/#/c/266605/ - the list multiple attachments one and boot from volume one are passing ( https://review.openstack.org/#/c/531386/ ) - the snapshot one is failing, looks like due to some response validation in tempest that doesn't handle 2.5918:01
*** derekh has quit IRC18:01
stvnoyesmreidem- ok thanks for the update. I am running into a m-a attach failure when attaching to the second instance. debugging that now.18:02
mriedemstvnoyes: with libvirt 3.10?18:03
stvnoyesno, with 3.618:03
mriedemwhat version of qemu?18:03
stvnoyes2.818:04
mriedemhmm18:04
*** slaweq has joined #openstack-nova18:05
mriedemi'm getting things to work with lvm as the backend, and qemu 2.5 and libvirt 3.618:05
stvnoyesmay just be that I am missing a patch. I am running it down now18:05
stvnoyesthis had been working for me before18:05
*** ralonsoh has quit IRC18:05
dtantsurmriedem: https://review.openstack.org/#/c/531868/ should do it. do you remember if Depends-On project-config changes works?18:08
*** cdent has joined #openstack-nova18:08
mriedemyou can't depends-on a project-config change, no18:08
* dtantsur #sadpanda18:09
mriedemandreas is usually pretty quick to hit these though18:09
dtantsuryep18:10
mriedemdtantsur: does ironic-tempest-dsvm-ipa-wholedisk-agent_ipmitool-tinyipa-multinode also test the multitenant stuff?18:10
mriedem*multitenant network18:10
dtantsurmriedem: that's the correct name of that job, so yes18:10
mriedemoh maybe it was renamed and we just never noticd18:10
dtantsurI think so18:10
openstackgerritMatt Riedemann proposed openstack/nova master: Ironic: Get IP address for volume connector  https://review.openstack.org/46835318:14
jaypipesmriedem, jgriffith_: your thoughts on this? https://review.openstack.org/#/c/528740/18:15
mriedemjaypipes: we can't change that as a bug fix18:16
mriedemimo18:16
mriedemit's an api change18:16
jaypipesmriedem: oh, I agree... I don't think it's actually something we should do *at all*.18:16
mriedemhttps://blueprints.launchpad.net/nova/+spec/volume-backed-server-rebuild18:16
mriedemi've -2ed for now just due to procedure18:17
*** slaweq has quit IRC18:17
mriedemi'm sure people want rebuild of volume-backed instances, but i'm not interested in that rats nest atm18:17
*** ameeda has joined #openstack-nova18:17
*** READ10 has quit IRC18:17
*** jpena is now known as jpena|off18:18
cdentefried, jaypipes I've stubbed in https://blueprints.launchpad.net/nova/+spec/placement-aggregate-generation . Since it is microversion, officially we need a spec.18:19
ameedaHi , when I try to execute this command "mistral-db-manage --config-file /etc/mistral/mistral.conf populate", I got many errors as this http://paste.openstack.org/show/640994/18:19
*** jackie-truong has quit IRC18:19
*** dtantsur is now known as dtantsur|afk18:20
jaypipescdent: you want to handle the spec?18:20
cdentyeah, will do18:20
mriedemthat's rocky at this point right?18:20
jaypipesameeda: wrong channel... try #openstack-mistral18:20
*** slaweq has joined #openstack-nova18:21
ameedaThanks !18:21
* cdent looks at jaypipes, efried 18:21
jaypipesmriedem: which one?18:21
jaypipesmriedem: the placement agg gen?18:21
mriedemaggregates generation18:21
*** sahid has quit IRC18:21
mriedemor is that blocking something for queens?18:21
jaypipesmriedem: well, not *really* but it can be seen as more of a bug fix that enables drivers like vcenter and powervm18:22
*** mgoddard has joined #openstack-nova18:22
mriedemok, but we're not prioritizing sharing providers in rocky right?18:23
mriedem*queens18:23
cdentmriedem: it's discussed near here at today's meeting http://eavesdrop.openstack.org/meetings/nova_scheduler/2018/nova_scheduler.2018-01-08-14.00.log.html#l-12718:23
cdentit's not clear what the time table is18:24
mriedemit's a rhetorical question :)18:24
mriedemwe said in denver that we weren't focusing on sharing providers in queens18:24
mriedemand nested resource providers was the goal18:24
cdentsure, I'm not disputing that. I'm merely asking where management of aggregates fits in18:25
mriedemdo aggregates butt up against nested providers?18:25
cdentI'm very happy to not do the work, but in the meeting it was wanted. If we don't want it, cool.18:25
mriedem"butt up" is the technical term18:25
cdentquite18:25
mriedemwell, want is fine,18:25
mriedemi just don't want it to be a distraction for queens18:25
mriedemqueuing it up for rocky is cool18:25
mriedemreminds me i need to start an etherpad for various rocky ptg stuff, to include spill over from queens18:26
cdentI'm happy to let jaypipes and efried decide. I simply volunteered to do the implementation.18:26
jaypipesmriedem: rocky is fine18:27
*** moshele has joined #openstack-nova18:27
mriedemcdent: jaypipes: https://etherpad.openstack.org/p/nova-ptg-rocky18:27
cdentack18:28
mriedemnow i've forgotten what i wanted to put on there from friday :(18:28
mriedemoh yeah18:28
*** jackie-truong has joined #openstack-nova18:28
cdentmriedem: If we're punting that to rocky, I don't reckon we need to put it on the ptg agenda, we talked it to deaht already today. I'm sure we'll have plenty of stuff more interesting. So I'll kill it.18:29
mriedemi'll at least target the bp to rocky in launchpad so it's in the list18:30
jaypipesmriedem: the aggregate-affinity one would be good to add to the ptg agenda. I'll do that.18:30
mriedemyeah definitely while we have ironic people around18:31
*** slaweq has quit IRC18:31
*** slaweq has joined #openstack-nova18:34
*** beekneemech is now known as bnemec18:34
*** tesseract has quit IRC18:35
*** moshele has quit IRC18:36
*** corey_ has joined #openstack-nova18:39
*** cleong has quit IRC18:40
*** READ10 has joined #openstack-nova18:41
*** lpetrut has quit IRC18:41
*** yamamoto has joined #openstack-nova18:44
*** jafeha__ has joined #openstack-nova18:48
*** jafeha has quit IRC18:49
*** cdent has quit IRC18:49
*** yamamoto has quit IRC18:52
*** jmlowe has joined #openstack-nova18:53
*** fragatina has quit IRC18:55
*** fragatina has joined #openstack-nova18:55
*** Tom-Tom has joined #openstack-nova18:56
jaypipesoh shitbuckets.18:57
*** slaweq has quit IRC19:01
*** fragatina has quit IRC19:01
*** yamamoto has joined #openstack-nova19:01
*** slaweq has joined #openstack-nova19:02
openstackgerritJay Pipes proposed openstack/nova master: func tests for nested providers in alloc candidate  https://review.openstack.org/53144319:03
openstackgerritJay Pipes proposed openstack/nova master: add _has_provider_trees() utility function  https://review.openstack.org/53147419:03
openstackgerritJay Pipes proposed openstack/nova master: placement: _get_trees_matching_all()  https://review.openstack.org/53151219:03
*** slaweq has quit IRC19:06
*** slaweq has joined #openstack-nova19:09
jaypipesefried: for n-r-p traits handling, we agreed that the following is true, right? "if user requests traits X, Y, and Z and at least one provider within a tree has one of each of those traits associated with it, then collectively the tree meets the required traits constraint"19:10
jaypipesefried: or did we instead say "the providers **that end up providing the resources involved in the request** must collectively be associated with all of the required traits"?19:11
jaypipesedleafe, mriedem, dansmith: your thoughts welcome on ^^19:12
dansmithuntil we have the more expressive query language, neither is really what we want, right?19:12
dansmithand we kinda have to do the "any" instead of "all" until that point I thought19:13
jaypipesdansmith: let's say I have a compute node with 24 VCPU and 32768G RAM with two child providers representing two PFs. One PF has trait X and one has trait Y. The one with trait X has inventory available for 2 VFs. the PF has no more inventory of VFs. If I request 2 VCPU, 1024 MEMORY_MB and 1 SRIOV_NET_VF, along with required_traits=Y. should the compute node be returned? I would say "no"...19:16
dansmithwow 32T of ram?19:16
jaypipesheh19:16
jaypipesyou get my drift..19:16
dansmithit just means we have to tag everything with every trait right?19:17
dansmithlike you'd have to tag a compute node with "has-nvidia" so that you could ever get a gpu19:17
jaypipesdansmith: no, that's not quite what I'm getting at... I'm wondering whether the "collectively meets the required traits constraint" should only consider those (child) resource providers that would be providing the resources for the request. In the case described above, the child provider that has the required trait Y does not provide the inventory of SRIOV_NET_VF for the request. Instead, the child provider with trait X is providing that19:19
jaypipesinventory.19:19
*** harlowja has joined #openstack-nova19:19
dansmithwell, I think I get that, I'm just not sure how you're going to scope it to the right thing,19:19
jaypipesbut "collectively", the provider tree representing the compute node and all its child providers "meets the constraints"19:19
*** slaweq has quit IRC19:19
dansmithmeaning how placement is going to know that "has required trait X" applies to the vif and not the disk19:20
*** jackie-truong has quit IRC19:20
dansmithsince the query didn't scope it as such19:20
jaypipesdansmith: well, I can apply the filter on traits *after* already processing the filter for resource amounts.19:20
dansmithright,19:20
dansmithwhich will filter out disks without trait X yes?19:20
jaypipesright19:20
dansmithwhich means you don't get any disk, which isn't a useful thing if you're trying to boot an instance, no?19:21
jaypipeswell, that would just mean that this compute node would not be returned in the GET /allocation_candidates query since the required traits are not associated with the providers that would end up providing the resources for the request19:22
*** pramodrj07 has joined #openstack-nova19:22
dansmithexactly19:22
*** pramodrj07 has quit IRC19:22
dansmithwhich is what I was saying:19:22
dansmithyou'd have to tag everything with X to make it come out properly19:22
dansmithyour disk and cpu and gpu would all have to have X applied so that you could ask for things with trait X,19:23
dansmithbut that doesn't make sense, assuming X is a networky trait you're using to pick which VF/PF/whatever you're looking for19:23
jaypipesright19:23
dansmithokay now I'm confused that you agree19:23
jaypipesI think I've answered my own question :)19:23
dansmith....mmmokay :)19:24
jaypipesjust needed a willing sounding board.19:24
jaypipesor unwilling I suppose ;)19:24
dansmithheh19:24
mriedemjaypipes: i don't know the answer to that - it was one of the questions i asked when that change in the placement api merged, i.e. "what are the rules on this new query parameter?"19:26
mriedemspecifically the "in_tree" parameter19:26
jaypipesmriedem: this isn't about that parameter (that parameter doesn't exist for GET /allocation_candidates19:26
jaypipesmriedem: but I can see a similar problem/point with that19:27
*** slaweq has joined #openstack-nova19:28
*** rabel_b1 has joined #openstack-nova19:31
*** rabel__b1 has joined #openstack-nova19:32
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Collocate encryptor and volume driver calls  https://review.openstack.org/46024319:34
*** rabel_b1 has quit IRC19:36
edleafejaypipes: (catching up) I wasn't clear if the tree for that compute node would contain everything (i.e., both child PFs), or only the children needed to satisfy the request19:36
jaypipesedleafe: yes, tree would contain both PFs.19:37
edleafeah, ok19:38
edleafeJust the allocation_candidate would be "minimal"19:38
*** lpetrut has joined #openstack-nova19:41
*** felipemonteiro_ has joined #openstack-nova19:41
jaypipesedleafe: not sure I follow you..19:43
*** david-lyle has joined #openstack-nova19:43
*** felipemonteiro has quit IRC19:45
edleafejaypipes: I wasn't clear if the provider tree would only contain parts of the entire tree that were "relevant"19:45
edleafesince you were talking about meeting traits restraints19:46
* edleafe needs to read up more on provider tree stuff19:46
jaypipesedleafe: ah, so the provider_summaries will include all nodes in the tree, but the allocation_requests would only be the ones that were being consumed from.19:46
jaypipesedleafe: but what I was wondering about was how to winnow the set of provider trees to begin with...19:46
edleafebecause the SQL can't be that specific? I.e., match trait to the PF with the inventory?19:49
jaypipesedleafe: no, it's not really a SQL thing... more of a "what order do I apply this filter" thing... don't worry about it. I've got tests coming that show the idea. should be easier to read the tests.19:49
edleafejaypipes: ack19:51
*** yamamoto has quit IRC19:53
*** jmlowe has quit IRC19:59
*** sdague has joined #openstack-nova20:00
openstackgerritJay Pipes proposed openstack/nova master: add tests for _get_trees_matching_all() with trait  https://review.openstack.org/53189920:00
jaypipesedleafe, mriedem, dansmith, efried: ^^ try that test description on for size...20:01
*** Apoorva has quit IRC20:01
*** Apoorva has joined #openstack-nova20:02
*** jgriffith_ is now known as jgriffith20:03
*** yamamoto has joined #openstack-nova20:04
stvnoyesmriedem: (I figured my problem, I neglected to set MA on the disk) So I was able to create a VM with a vol and did a bfv. I then created a new vm and attached the first vm's boot disk to it (as a data disk). I then did a nova image-create for both vm's. It all worked without errors. Was this the test you were looking for?20:05
*** jackie-truong has joined #openstack-nova20:06
mriedemstvnoyes: yeah, that's what i have in https://review.openstack.org/266605 so far20:06
mriedemstvnoyes: here is another one: create a bootable multiattach volume, create server1 from that volume with delete_on_termination=True; then create another server (not bfv) and attach the volume to server2, then delete server120:07
mriedemassert that the volume is not deleted and still attached to server2, but server1 was deleted20:07
stvnoyeskk20:08
mriedemi'm going to add another test in here for resize with a multiattach volume attached20:08
mriedemand we likely also need a test for swap volume with a multiattach volume, but that's an admin-level test20:09
*** yamamoto has quit IRC20:09
*** tbachman has joined #openstack-nova20:10
mriedemsdague: got a pretty easy +W on efried's neutronclient changes for the ksa adapter https://review.openstack.org/#/c/509892/20:13
sdaguemriedem: looking20:14
edmondswmriedem sdague the powervm SEA and OVS patches shouldn't merge until we get the CI working, which is waiting on a global req change to merge (already has +W), but they are otherwise ready to start reviewing20:18
edmondswOVS: https://review.openstack.org/#/c/422512/20:18
edmondswSEA: https://review.openstack.org/#/c/523216/20:18
*** itlinux has quit IRC20:19
*** edmondsw has quit IRC20:26
*** itlinux has joined #openstack-nova20:29
*** jmlowe has joined #openstack-nova20:31
*** imacdonn has joined #openstack-nova20:38
*** penick has joined #openstack-nova20:38
* mriedem rechecks everything20:38
*** openstack has quit IRC20:38
*** openstack has joined #openstack-nova20:40
*** ChanServ sets mode: +o openstack20:40
stvnoyesit's 3:07 in my time zone20:40
mriedemstvnoyes: mayhap you'd like to recreate and fix this https://bugs.launchpad.net/nova/+bug/174147620:40
*** fragatina has joined #openstack-nova20:40
stvnoyesok I'll take a look20:41
*** awaugama has quit IRC20:42
*** READ10 has quit IRC20:43
openstackLaunchpad bug 1741476 in OpenStack Compute (nova) "Attaching read-only volumes fails" [Undecided,New]20:44
*** jmlowe has quit IRC20:45
efriedjaypipes Sorry, catching up.  In the example you gave, I think you should *not* get that host back.  We should construct trait presence as narrowly/strictly as possible in the nested scenario: i.e. the traits must exist in the set of providers we're actually *using*; it's not enough for some other (unused) provider in the tree to have that trait.20:49
efriedjaypipes And when you (as an op) want to be strict about which traits belong to which resource classes, you have to use granular.20:50
*** jmlowe has joined #openstack-nova20:50
jaypipesefried: k, that matches the assumptions in the patch with the test case.20:50
efriedexcellent.20:51
efriedjaypipes When you say, "check. test assertions (and commented out assertions) are correct and represent the bugs appropriately." -- are you asking for a code comment, or was this just acknowledging that you had looked at the test case and saw that it was good (in the Genesis sense)?20:52
jaypipesefried: no, I'm saying it was good. ++20:53
efriedjaypipes Roger, thanks.20:53
jaypipesefried: sometimes I mark reviews like that just to keep my place in the review.20:53
efriedsuresure.  Just making sure I understood correctly, since you *were* asking for comment updates elsewhere.20:53
jaypipesack20:54
*** ktibi has quit IRC20:58
*** liverpooler has quit IRC20:58
openstackgerritEric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI  https://review.openstack.org/52609420:59
*** openstackgerrit has quit IRC21:03
*** matrohon has joined #openstack-nova21:07
*** smatzek has quit IRC21:11
*** smatzek has joined #openstack-nova21:11
*** smatzek has quit IRC21:16
*** archit has joined #openstack-nova21:16
*** amodi has quit IRC21:16
*** archit is now known as amodi21:16
*** rcernin has joined #openstack-nova21:17
*** gouthamr has quit IRC21:22
*** jmlowe has quit IRC21:22
*** corey_ has quit IRC21:25
*** Anticimex has joined #openstack-nova21:27
*** r-daneel has joined #openstack-nova21:27
*** rabel__b1 has quit IRC21:28
*** david-lyle has quit IRC21:28
*** rabel_b1 has joined #openstack-nova21:28
*** alee has left #openstack-nova21:29
*** ameeda has quit IRC21:31
*** rcernin has quit IRC21:33
*** jackie-truong has quit IRC21:34
*** penick has quit IRC21:35
*** hemna_ has joined #openstack-nova21:37
*** rabel_b1 has quit IRC21:37
*** jmlowe has joined #openstack-nova21:37
*** gouthamr has joined #openstack-nova21:37
*** jmlowe has quit IRC21:39
*** yamamoto has joined #openstack-nova21:39
mriedem nicolasbock: you're with suse right? is this something you can confirm and if so, update the nova install guide for suse? https://bugs.launchpad.net/nova/+bug/174132921:40
openstackLaunchpad bug 1741329 in OpenStack Compute (nova) "Install and configure controller node for openSUSE and SUSE Linux Enterprise in nova" [Undecided,New]21:40
*** yamamoto has quit IRC21:47
*** slaweq has quit IRC21:50
mriedemlyarwood: hemna: added some notes to https://bugs.launchpad.net/nova/+bug/1741364 - but yeah, spot on, doesn't do anything with getting the ephemeral disk config when building the new guest xml21:52
openstackLaunchpad bug 1741364 in OpenStack Compute (nova) "ceph ephemeral info not updated during live migrate" [Medium,Confirmed]21:52
*** smatzek has joined #openstack-nova21:52
mriedemand cold migration would do that of course, or a hard reboot21:52
mriedembut those involve downtime21:52
*** itlinux has quit IRC21:52
*** eharney has quit IRC21:53
*** esberglu has quit IRC21:53
mriedemwould likely require something like https://github.com/openstack/nova/blob/74deea4d8f66a85e66ec79c72c9f257f562d5afd/nova/virt/libvirt/migration.py#L133 for non-volume disks21:54
*** smatzek has quit IRC21:56
flwang1mriedem: could you please help me understand the relationship between cell and sockets in cpu topo?21:57
mriedemflwang1: i can't help you there21:58
flwang1mriedem: who is the right person I should ask?21:58
mriedemprobably need to talk to stephenfin or sahid when they are around21:58
mriedemUK timezone21:58
flwang1mriedem: cool, thanks21:58
mriedemor cfriesen (canada21:58
flwang1mriedem: great, and happy new year!21:59
mriedemsame to you21:59
*** matrohon has quit IRC22:00
*** burt has quit IRC22:00
*** esberglu has joined #openstack-nova22:04
bauzasdansmith: still around ?22:06
*** rcernin has joined #openstack-nova22:06
bauzasdansmith: I'll upload a new PS tomorrow for https://review.openstack.org/#/c/528832/ based on your's and jaypipes's comments22:07
bauzasdansmith: but you had a main comment about how to recreate the existing mdevs with init_host()22:07
bauzasdansmith: basically the main concern I have is that we don't know if an existing mdev is used by an instance unless by looking at the guest XML22:20
dansmithbauzas: ...right, what's wrong with looking at the xml? that's what I was suggesting22:21
bauzasdansmith: the main point is that it could be a long verification22:21
dansmithbauzas: in what way?22:21
dansmithwe already iterate instances on startup22:22
dansmithand do lots of db stuff for each22:22
bauzasa-ha22:22
bauzasin the libvirt init_host() or the compute service one ?22:22
bauzaslemme see22:22
dansmithwe iterate instances in the compute manager init_host()22:23
dansmithand call init_instance() (or something like that) for each22:23
dansmithwe could call into the driver in there, or just have the driver's init_host iterate instances again, tbh22:23
dansmithjust listing all instances from libvirt and re-creating mdevs would be fine and not heavy, IMHO22:23
bauzasI see22:24
dansmithdan@falcon:~$ time (for i in $(seq 0 100); do virsh dumpxml 10 >/dev/null; done)22:25
dansmithreal0m1.006s22:25
dansmithon my quite slow machine22:25
bauzasi just wonder how to verify the xml22:25
dansmithI think it'll be fine :)22:25
bauzasheh thanks22:25
dansmithhow to verify what/22:25
bauzashow to verify the guest XML whether it has some mdevs22:25
dansmithit was right when we shut down, we're in init/startup, why not just restore them to the way they were? we can't have processed any compute-side deletes yet22:25
dansmithisn't it in the guest xml?22:25
bauzasit will be22:26
bauzasanyway, lemme see how to do that22:26
dansmithokay, I'm confused about your confusion,22:26
dansmithbut if I'm missing something, slap me with it22:26
*** lpetrut has quit IRC22:27
bauzasapologies if I'm confusing22:28
bauzasI'll work on that tomorrow morning so if I have better concerns, I'll tell you once you're up22:28
bauzasthanks22:28
dansmithokay22:29
*** penick has joined #openstack-nova22:36
*** dave-mccowan has quit IRC22:37
*** fragatina has quit IRC22:38
*** lyan has quit IRC22:40
*** armax has quit IRC22:40
*** kumarmn has joined #openstack-nova22:42
*** hongbin has quit IRC22:45
*** kumarmn has quit IRC22:46
*** itlinux has joined #openstack-nova22:51
rybridgesHave a question guys. Where do the logs for this file go? https://github.com/openstack/nova/blob/stable/ocata/nova/compute/manager.py22:51
rybridgesI do not see them in scheduler log, conductor log, or api log22:52
mriedemcompute22:52
*** openstackgerrit has joined #openstack-nova22:53
openstackgerritMatt Riedemann proposed openstack/nova master: unquiesce instance on volume snapshot failure  https://review.openstack.org/51946422:53
openstackgerritMatt Riedemann proposed openstack/nova master: Add the ability to get absolute limits from Cinder  https://review.openstack.org/52012222:53
openstackgerritMatt Riedemann proposed openstack/nova master: Check quota before creating volume snapshots  https://review.openstack.org/52015822:53
rybridgesoh its on the hypervisor22:54
rybridgesmriedem22:54
rybridgesnot on the api node22:54
*** kumarmn has joined #openstack-nova22:54
mriedemwell, nova/compute, "compute"22:54
mriedemso yeah22:54
rybridgesok22:54
mriedemthe directory structure is mostly laid out by service22:54
mriedemexcept nova/virt is also in compute22:54
*** david-lyle has joined #openstack-nova22:55
*** stvnoyes has quit IRC22:56
*** slaweq has joined #openstack-nova22:58
*** kumarmn has quit IRC22:59
*** slaweq has quit IRC23:00
*** john51_ has quit IRC23:01
*** gcb has joined #openstack-nova23:01
*** john51 has joined #openstack-nova23:04
*** chyka_ has joined #openstack-nova23:06
*** kumarmn has joined #openstack-nova23:09
*** chyka has quit IRC23:09
*** jaypipes has quit IRC23:12
*** david-lyle has quit IRC23:12
*** tidwellr_ has quit IRC23:12
*** david-lyle has joined #openstack-nova23:13
*** chyka_ has quit IRC23:13
*** chyka has joined #openstack-nova23:14
*** amodi has quit IRC23:15
*** kumarmn has quit IRC23:20
*** gcb has quit IRC23:20
*** kumarmn has joined #openstack-nova23:21
*** jobewan has joined #openstack-nova23:22
*** sambetts is now known as sambetts|afk23:22
*** mlavalle has quit IRC23:23
*** kumarmn has quit IRC23:29
*** chyka_ has joined #openstack-nova23:32
*** takashin has joined #openstack-nova23:33
*** chyka has quit IRC23:35
*** jobewan has quit IRC23:36
*** penick has quit IRC23:38
*** Guest20076 has quit IRC23:44
*** felipemonteiro_ has quit IRC23:46
*** kumarmn has joined #openstack-nova23:47
*** chyka_ has quit IRC23:48
*** chyka has joined #openstack-nova23:49
*** kumarmn has quit IRC23:52
*** kumarmn has joined #openstack-nova23:53
*** itlinux has quit IRC23:54
*** chyka_ has joined #openstack-nova23:55
*** chyka has quit IRC23:55
*** moshele has joined #openstack-nova23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!