Tuesday, 2018-01-09

*** claudiub has quit IRC00:00
*** Guest20076 has joined #openstack-nova00:02
*** tetsuro has joined #openstack-nova00:02
*** r-daneel has quit IRC00:05
*** jobewan has joined #openstack-nova00:05
*** david-lyle has quit IRC00:07
*** dklyle has joined #openstack-nova00:07
*** dklyle has quit IRC00:07
*** jmlowe has joined #openstack-nova00:09
*** kumarmn has quit IRC00:10
openstackgerritmelanie witt proposed openstack/nova stable/pike: libvirt: Re-initialise volumes, encryptors, and vifs on hard reboot  https://review.openstack.org/53140700:13
*** jobewan has quit IRC00:16
*** itlinux has joined #openstack-nova00:18
*** kumarmn has joined #openstack-nova00:28
*** sdague has quit IRC00:29
*** jmlowe has quit IRC00:31
*** jobewan has joined #openstack-nova00:35
*** edmondsw has joined #openstack-nova00:36
*** esberglu has quit IRC00:37
*** jobewan has quit IRC00:38
*** chyka_ has quit IRC00:38
*** jmlowe has joined #openstack-nova00:38
*** hiro-kobayashi has joined #openstack-nova00:38
*** moshele has quit IRC00:42
*** felipemonteiro_ has joined #openstack-nova00:44
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Add CLI to show instance usage audit logs  https://review.openstack.org/40941300:45
*** jichen has joined #openstack-nova00:45
*** tuanla____ has joined #openstack-nova00:47
*** kumarmn_ has joined #openstack-nova00:49
openstackgerritTakashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2)  https://review.openstack.org/45948300:50
*** kumarmn has quit IRC00:52
*** kumarmn_ has quit IRC00:56
*** Dinesh_Bhor has joined #openstack-nova00:57
*** kumarmn has joined #openstack-nova01:02
*** tidwellr has joined #openstack-nova01:06
*** phuongnh has joined #openstack-nova01:11
openstackgerritmelanie witt proposed openstack/nova stable/ocata: libvirt: Re-initialise volumes, encryptors, and vifs on hard reboot  https://review.openstack.org/53142201:11
*** felipemonteiro_ has quit IRC01:12
*** moshele has joined #openstack-nova01:13
*** markvoelker has joined #openstack-nova01:17
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Microversion 2.59 - List/Show all server migration types  https://review.openstack.org/43083901:20
*** zhurong has joined #openstack-nova01:21
*** hoangcx has joined #openstack-nova01:23
*** kumarmn has quit IRC01:24
*** phuongnh has quit IRC01:24
*** phuongnh has joined #openstack-nova01:25
*** armax has joined #openstack-nova01:25
openstackgerritZhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip  https://review.openstack.org/52550501:26
*** amodi has joined #openstack-nova01:31
*** mriedem1 has joined #openstack-nova01:40
*** mriedem has quit IRC01:42
*** liverpooler has joined #openstack-nova01:43
*** Tom-Tom has quit IRC01:43
*** Tom-Tom has joined #openstack-nova01:43
*** Dinesh_Bhor has quit IRC01:45
*** liverpooler has quit IRC01:46
*** jmlowe has quit IRC01:52
*** Tom-Tom has quit IRC01:53
*** mriedem has joined #openstack-nova01:56
*** mriedem1 has quit IRC01:58
*** felipemonteiro_ has joined #openstack-nova02:02
*** Dinesh_Bhor has joined #openstack-nova02:05
*** jmlowe has joined #openstack-nova02:07
*** Dinesh_Bhor has quit IRC02:07
*** Tom-Tom has joined #openstack-nova02:09
*** Tom-Tom has quit IRC02:09
*** Tom-Tom has joined #openstack-nova02:09
*** annp has joined #openstack-nova02:09
openstackgerritMatt Riedemann proposed openstack/nova master: Qualify the Placement 1.15 release note  https://review.openstack.org/53196302:13
*** namnh has joined #openstack-nova02:17
*** vivsoni has quit IRC02:19
*** vivsoni has joined #openstack-nova02:19
openstackgerritOpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements  https://review.openstack.org/53173702:22
*** jmlowe has quit IRC02:23
*** Dinesh_Bhor has joined #openstack-nova02:26
*** edmondsw has quit IRC02:30
*** Apoorva has quit IRC02:32
*** harlowja has quit IRC02:32
*** Dinesh_Bhor has quit IRC02:33
*** moshele has quit IRC02:34
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Fix 500 in test_resize_server_negative_invalid_state  https://review.openstack.org/53111702:34
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add index(instance_uuid, updated_at) on instance_actions table  https://review.openstack.org/53042902:34
*** jmlowe has joined #openstack-nova02:37
*** xinliang has quit IRC02:43
*** udesale has joined #openstack-nova02:46
openstackgerritlei zhang proposed openstack/nova master: Fix the incorrect git.openstack.org source URL  https://review.openstack.org/53197902:46
*** tidwellr has quit IRC02:49
*** jmlowe has quit IRC02:53
*** xinliang has joined #openstack-nova02:55
*** hongbin has joined #openstack-nova02:57
*** nicolasbock has quit IRC02:58
*** bkopilov has quit IRC03:04
*** markvoelker has quit IRC03:06
*** adreznec has quit IRC03:07
*** adreznec has joined #openstack-nova03:08
*** Tom-Tom has quit IRC03:09
*** Tom-Tom has joined #openstack-nova03:09
*** hoonetorg has quit IRC03:12
*** yamahata has quit IRC03:15
*** jmlowe has joined #openstack-nova03:16
*** adreznec has quit IRC03:16
*** adreznec has joined #openstack-nova03:21
*** hongbin has quit IRC03:24
*** hongbin has joined #openstack-nova03:25
*** takashin has quit IRC03:25
*** hoonetorg has joined #openstack-nova03:25
*** vladikr has quit IRC03:25
*** vladikr has joined #openstack-nova03:28
*** amodi has quit IRC03:31
openstackgerritMerged openstack/nova master: Fix OpenStack capitalization  https://review.openstack.org/53159303:36
*** jmlowe has quit IRC03:39
*** yamamoto has joined #openstack-nova03:40
*** Tom-Tom has quit IRC03:42
*** Tom-Tom has joined #openstack-nova03:42
*** jmlowe has joined #openstack-nova03:44
*** abhishekk has joined #openstack-nova03:44
*** Tom-Tom has quit IRC03:47
*** gyee has quit IRC03:48
*** zhurong has quit IRC03:55
*** takashin has joined #openstack-nova03:56
*** shaohe_feng has quit IRC03:58
*** shaohe_feng has joined #openstack-nova03:58
*** sridharg has joined #openstack-nova03:58
*** Dinesh_Bhor has joined #openstack-nova04:01
*** Apoorva has joined #openstack-nova04:15
*** esberglu has joined #openstack-nova04:16
*** esberglu has quit IRC04:17
*** jobewan has joined #openstack-nova04:20
*** jobewan has quit IRC04:21
openstackgerritMerged openstack/nova stable/ocata: Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker  https://review.openstack.org/53098104:22
*** hiro-kobayashi has quit IRC04:22
*** bkopilov has joined #openstack-nova04:23
openstackgerritMerged openstack/nova master: Use ksa adapter for neutron client  https://review.openstack.org/50989204:24
*** hongbin has quit IRC04:26
*** yangyapeng has quit IRC04:31
*** yangyapeng has joined #openstack-nova04:31
*** liuyulong has joined #openstack-nova04:32
*** felipemonteiro_ has quit IRC04:34
openstackgerritMatt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments  https://review.openstack.org/26758704:44
openstackgerritMatt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name  https://review.openstack.org/53124404:44
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api  https://review.openstack.org/27104704:44
mriedemildikov: ^ the api support should be plumbed in now; required quite a bit of refactor which touched a billion tests, but not complicated. just needs the new paths covered with unit tests.04:45
*** mriedem has quit IRC04:47
*** janki has joined #openstack-nova04:47
openstackgerritTetsuro Nakamura proposed openstack/nova master: Fix missing rps in allocation candidates  https://review.openstack.org/52240904:49
openstackgerritTetsuro Nakamura proposed openstack/nova master: placement: func tests for multiple shared RPs  https://review.openstack.org/49873704:49
*** Dinesh_Bhor has quit IRC04:50
*** Dinesh_Bhor has joined #openstack-nova04:51
openstackgerritTakashi NATSUME proposed openstack/nova master: Add an additional description for 'token_ttl'  https://review.openstack.org/53200704:52
*** Dinesh_Bhor has quit IRC04:52
*** Dinesh_Bhor has joined #openstack-nova04:55
*** markvoelker has joined #openstack-nova04:56
*** felipemonteiro_ has joined #openstack-nova05:01
*** vladikr has quit IRC05:03
*** jichen_ has joined #openstack-nova05:03
*** jichen has quit IRC05:04
*** psachin has joined #openstack-nova05:04
*** jichen_ is now known as jichen05:04
*** links has joined #openstack-nova05:07
openstackgerritSriharsha Basavapatna proposed openstack/os-vif master: Fix VF-rep lookup routine to use parent PF number  https://review.openstack.org/53167405:08
*** hiro-kobayashi has joined #openstack-nova05:18
*** ratailor has joined #openstack-nova05:19
*** Tom-Tom has joined #openstack-nova05:28
*** claudiub has joined #openstack-nova05:29
*** sree has joined #openstack-nova05:31
*** sree has quit IRC05:32
*** sree has joined #openstack-nova05:32
takashin05:33
*** rabel_b1 has joined #openstack-nova05:36
*** rabel_b1 has quit IRC05:49
*** Apoorva has quit IRC05:49
*** lajoskatona has joined #openstack-nova05:51
*** smatzek has joined #openstack-nova05:53
*** Tom-Tom has quit IRC05:53
*** hoonetorg has quit IRC05:55
*** xinliang has quit IRC05:57
*** smatzek has quit IRC05:57
*** hoonetorg has joined #openstack-nova05:59
*** tuanla____ has quit IRC06:00
*** Tom-Tom has joined #openstack-nova06:02
*** sandanar has joined #openstack-nova06:03
sandanarhi.. does anyone know what is the reason behind CONF.libvirt.volume_use_path always returns the default value and not the one passed in [libvirt] section of /etc/nova/nova.conf - https://bugs.launchpad.net/nova/+bug/1723928 this is causing multipath failures on the cinder side06:05
openstackLaunchpad bug 1723928 in os-brick "In case of volume_use_multipath=True, Nova unable to fetch CONF.libvirt.volume_use_multipath value from nova.conf" [Undecided,New]06:05
*** tuanla____ has joined #openstack-nova06:05
*** Dinesh_Bhor has quit IRC06:07
*** felipemonteiro_ has quit IRC06:08
*** tuanla____ has quit IRC06:09
*** xinliang has joined #openstack-nova06:09
*** Dinesh_Bhor has joined #openstack-nova06:10
*** yamahata has joined #openstack-nova06:13
*** gouthamr has quit IRC06:17
*** pmannidi has joined #openstack-nova06:18
*** sree has quit IRC06:23
*** sree has joined #openstack-nova06:24
*** sree has quit IRC06:28
*** goutham has joined #openstack-nova06:29
*** links has quit IRC06:35
*** moshele has joined #openstack-nova06:37
*** rcernin has quit IRC06:38
*** jichen_ has joined #openstack-nova06:45
*** rabel_b1 has joined #openstack-nova06:46
*** ameeda has joined #openstack-nova06:47
*** jichen has quit IRC06:47
*** jichen_ is now known as jichen06:47
*** zhurong has joined #openstack-nova06:50
*** links has joined #openstack-nova06:51
*** Eran_Kuris has joined #openstack-nova06:54
*** hoonetorg has quit IRC06:56
*** pcaruana has joined #openstack-nova06:56
*** gcb has joined #openstack-nova06:58
*** liuyulong has quit IRC07:02
*** links has quit IRC07:03
*** Dinesh_Bhor has quit IRC07:05
*** hoonetorg has joined #openstack-nova07:12
*** links has joined #openstack-nova07:14
*** Dinesh_Bhor has joined #openstack-nova07:15
*** Dinesh_Bhor has quit IRC07:27
*** felipemonteiro_ has joined #openstack-nova07:27
*** moshele has left #openstack-nova07:27
*** links has quit IRC07:27
*** moshele has joined #openstack-nova07:28
*** hoonetorg has quit IRC07:32
*** pmannidi has quit IRC07:34
*** felipemonteiro_ has quit IRC07:39
*** sree has joined #openstack-nova07:40
*** sree has quit IRC07:44
*** links has joined #openstack-nova07:45
*** udesale has quit IRC07:46
*** slaweq has joined #openstack-nova07:47
*** Dinesh_Bhor has joined #openstack-nova07:48
*** rhagarty has quit IRC07:49
openstackgerritchenpengzi proposed openstack/nova master: Add reference to policy sample  https://review.openstack.org/53171307:49
*** FL1SK has quit IRC07:50
*** slaweq has quit IRC07:52
*** rhagarty has joined #openstack-nova07:52
*** AlexeyAbashkin has joined #openstack-nova07:56
*** itlinux has quit IRC07:58
*** slaweq has joined #openstack-nova08:00
*** hoonetorg has joined #openstack-nova08:01
*** takashin has left #openstack-nova08:02
*** rmart04 has joined #openstack-nova08:05
*** armax has quit IRC08:08
*** hiro-kobayashi has quit IRC08:08
*** slaweq has quit IRC08:08
*** jangutter has joined #openstack-nova08:14
*** damien_r has joined #openstack-nova08:16
*** sahid has joined #openstack-nova08:18
*** tesseract has joined #openstack-nova08:20
*** alexchadin has joined #openstack-nova08:22
*** sree has joined #openstack-nova08:24
*** ralonsoh has joined #openstack-nova08:25
openstackgerritZhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip  https://review.openstack.org/52550508:26
*** sree has quit IRC08:28
*** jafeha__ is now known as jafeha08:29
*** psachin has quit IRC08:30
*** sree has joined #openstack-nova08:31
*** sree has quit IRC08:36
*** yamamoto_ has joined #openstack-nova08:36
*** matrohon has joined #openstack-nova08:37
*** namnh has quit IRC08:38
*** mdnadeem has joined #openstack-nova08:38
*** hieulq has quit IRC08:38
*** phuongnh has quit IRC08:38
*** annp has quit IRC08:38
*** hoangcx has quit IRC08:38
*** phuongnh has joined #openstack-nova08:38
*** namnh has joined #openstack-nova08:38
*** hieulq has joined #openstack-nova08:38
*** hoangcx has joined #openstack-nova08:39
*** annp has joined #openstack-nova08:39
*** yamamoto has quit IRC08:39
*** psachin has joined #openstack-nova08:40
hrwmorning08:41
hrwany idea why https://review.openstack.org/#/c/530965 has Zuul said "Verified:+1" when 'recheck' was called after +2+2+W?08:43
hrwand not +208:44
*** sree has joined #openstack-nova08:44
*** jpena|off is now known as jpena08:45
Roamer`hrw, it seems to have https://review.openstack.org/#/c/521400/ as a parent, and that has not merged yet (needs workflow)08:47
Roamer`so Zuul cannot pass 530965 to the gate08:48
hrwRoamer`: ? weird.08:49
hrwRoamer`: I made 530965 on top of origin/master and it lacks any Depends-on fields08:49
*** Dinesh_Bhor has quit IRC08:49
*** sree has quit IRC08:49
Roamer`hrw, sorry, I just realized I'm a bit confused, that is, Gerrit is a bit confused08:50
Roamer`if I copy the "Parent" commit ID of your commit to the clipboard, then paste it in Gerrit's "search" field, it gives me 521400 back, but it has a different commit ID, so that's not true08:51
Roamer`of course your commit has something that has already merged as a parent, sorry08:52
hrwRoamer`: no problem08:52
hrwRoamer`: probably change-id of 521400 == commit id of parent08:53
Roamer`nope, that's what I thought at first (had that happen many times at work), but it's not08:54
*** hiro-kobayashi has joined #openstack-nova08:54
*** priteau has joined #openstack-nova08:56
bauzasgood morning Novaers08:58
hrwelo bauzas09:01
*** cdent has joined #openstack-nova09:01
bauzasEHLO even09:01
bauzas(loving telnet)09:01
hrw;)09:02
hrwbauzas: 220 2.0.0 Ready to start TLS09:03
hrwand then we go into binary09:03
hrwand no one understand09:03
bauzasI could speak French, I would be sure that barely only 10-20% of people here could understand me09:07
*** Dinesh_Bhor has joined #openstack-nova09:08
hrwbauzas: merci, no.09:08
bauzasdammit09:08
hrwbauzas: year ago I took my daughter to Touluise. on second day each conversation with new people started from 'excuse mua, parle anglese?' (or sth like that)09:09
bauzasyeah I know, things would be more easier if we could exchange public keys verbally instead of using foreign languages09:11
*** harsha has joined #openstack-nova09:13
*** lucas-afk is now known as lucasagomes09:18
*** dtantsur|afk is now known as dtantsur09:20
openstackgerritHuan Xie proposed openstack/nova master: [WIP] XenAPI: Fix vm live migration problem with volume  https://review.openstack.org/53211809:21
*** flwang1 has quit IRC09:22
*** flwang has joined #openstack-nova09:24
*** sree has joined #openstack-nova09:30
*** hoonetorg has quit IRC09:32
*** derekh has joined #openstack-nova09:33
*** sree has quit IRC09:34
*** jistr|off|mtg is now known as jistr09:36
*** goutham has quit IRC09:36
*** Dinesh_Bhor has quit IRC09:38
openstackgerritStephen Finucane proposed openstack/os-vif master: Configure privsep binary  https://review.openstack.org/53135809:39
openstackgerritStephen Finucane proposed openstack/os-vif master: zuul: Enable functional tests in gate  https://review.openstack.org/53096109:39
stephenfinflwang: I'm around now if you've still got questions?09:40
*** sree has joined #openstack-nova09:41
*** tuanla____ has joined #openstack-nova09:44
*** sree has quit IRC09:45
stephenfinmelwitt: Ta-da! https://review.openstack.org/#/c/530950/09:46
* stephenfin thanks the Python 3 gods for letting his code work09:46
*** sree has joined #openstack-nova09:48
*** hoonetorg has joined #openstack-nova09:49
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64  https://review.openstack.org/53096509:49
*** FL1SK has joined #openstack-nova09:50
*** sree has quit IRC09:52
*** yamamoto_ has quit IRC09:52
claudiubefried: hello. The autospec patch merged in oslotest. :D09:55
hrwstephenfin: thx09:57
hrwstephenfin: I got used to openstack/kolla patches were zuul mails me "+2" and "merged" in same minute ;D09:57
stephenfinYeahhhhh, our test runs take a while :)09:58
*** hiro-kobayashi has quit IRC09:58
hrw;D09:58
*** jaosorior has joined #openstack-nova09:59
*** udesale has joined #openstack-nova09:59
openstackgerritStephen Finucane proposed openstack/nova master: Handle deprecation of inspect.getargspec  https://review.openstack.org/53077709:59
bauzasjianghuaw_: around ?10:01
*** lpetrut has joined #openstack-nova10:01
bauzasjianghuaw_: just a clarification with https://review.openstack.org/#/c/516899/34/nova/virt/xenapi/driver.py10:01
bauzasjianghuaw_: since you don't lookup the allocations (just verifying whether there are some VGPU ones), you don't verify how many RPs allocations are there, and just say "okay, only one", right?10:02
bauzasjianghuaw_: for example, say I have an allocations list having two allocations for two separate RPs, and each one having VGPU:2, then you just ask Xen to create only one (not 4), right?10:03
jianghuaw_Bauzas, yes xen only supports one vGPU per VM.10:06
bauzasthat, I know10:06
bauzasI was just wanting to make sure10:06
jianghuaw_bauzas, why it will pass down multiple allocations?10:07
bauzasjianghuaw_: it won't10:07
*** Tom-Tom has quit IRC10:07
bauzasjianghuaw_: just the fact that you'll need to modify your method once we use nested RPs10:07
bauzasbut at least, you could have one allocation for a RP, with a value more than 1, but okay10:08
bauzasjianghuaw_: FWIW, the nvidia driver for libvirt doesn't accept more than one vGPU per pGPU10:08
openstackgerritZhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip  https://review.openstack.org/52550510:09
jianghuaw_bauzas, ah, Thanks. we need change that method. I think naichuan already has one patch to mapping the RP-uuid from the allocation to the proper GPU group.10:09
bauzasjianghuaw_: but you can ask for 2 vGPUs if you have more than 1 pGPU for your host10:09
*** sree has joined #openstack-nova10:09
jianghuaw_no. still only one vGPU.10:10
*** tuanla____ has quit IRC10:10
bauzasjianghuaw_: WDYM ?10:10
jianghuaw_It don't support >1 vGPU for one VM.10:10
bauzasfor nvidia ?10:10
bauzasAFAIK, you can have 2 vGPUs with the nvidia driver *if* each of them are by a separate physical card10:11
*** ktibi has joined #openstack-nova10:11
jianghuaw_XenServer has the restriction in xapi.10:11
bauzasoh ok, I misunderstood10:11
jianghuaw_I guess nvidia can support but xen can't.10:11
bauzasno, nvidia driver can't10:11
bauzasjianghuaw_: http://images.nvidia.com/content/grid/pdf/GRID-vGPU-User-Guide.pdf section 1.3.210:12
bauzasit tells to use homogenous vGPU types, but it also means that you need to use separate physical devices, at least for libvirt10:12
jianghuaw_can it support multiple vGPU with the same vGPUtype?10:13
bauzaslike I said, you need to use separate physical devices10:14
bauzasthat's a driver limitation10:14
jianghuaw_bauzas, Got it. thanks for letting me know of it.10:15
*** yamamoto has joined #openstack-nova10:16
*** sambetts|afk is now known as sambetts10:16
jianghuaw_bauzas, do you have a link on the *driver limitation*?10:16
bauzasno, unfortunately10:16
bauzasthat's something someone told me10:17
bauzasawesome, heh ?10:17
bauzascode driven by trust10:17
bauzasand word of mouth10:17
jianghuaw_:-)10:18
*** mvk has joined #openstack-nova10:20
openstackgerritPeter Penchev proposed openstack/nova master: Add the Nova libvirt StorPool attachment driver.  https://review.openstack.org/14073310:20
*** sree has quit IRC10:23
*** ratailor_ has joined #openstack-nova10:24
*** jichen has quit IRC10:24
*** ratailor has quit IRC10:26
*** ratailor_ has quit IRC10:26
*** ratailor_ has joined #openstack-nova10:27
openstackgerritStephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme  https://review.openstack.org/34539810:35
openstackgerritStephen Finucane proposed openstack/nova master: console: Provide an RFB security proxy implementation  https://review.openstack.org/34539910:35
openstackgerritStephen Finucane proposed openstack/nova master: doc: Document TLS security setup for noVNC proxy  https://review.openstack.org/50054410:35
openstackgerritStephen Finucane proposed openstack/nova master: console: Send bytes to sockets  https://review.openstack.org/53183410:35
*** rmart04 has quit IRC10:36
*** janki has quit IRC10:38
*** Tom-Tom has joined #openstack-nova10:38
openstackgerritZhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip  https://review.openstack.org/52550510:39
*** sdague has joined #openstack-nova10:40
*** Tom-Tom has quit IRC10:42
*** avolkov has joined #openstack-nova10:43
*** priteau has quit IRC10:43
*** priteau has joined #openstack-nova10:44
*** hoonetorg has quit IRC10:46
harshaHi folks, quick question on some python unit tests; I need to run - 'tox -e pep8'; should i run this on the test machine in the directory/path where I have my changes ?10:47
tetsurostephenfin: thanks for reviewing https://review.openstack.org/#/c/531328/ :) I'm both okay with microversion or not.10:47
*** hoonetorg has joined #openstack-nova10:47
*** hemna_ has quit IRC10:48
*** priteau has quit IRC10:48
*** namnh has quit IRC10:48
tetsurostephenfin: Just FYI, I happend to find this blog https://techglimpse.com/why-does-openstack-report-hypervisor-type-as-qemu-when-libvirt_type-is-kvm/ . I don't know who wrote this, though.10:48
stephenfintetsuro: Oh yeah, to be fair, I honestly don't know what way it should be hence no -110:49
stephenfincdent: Fancy weighing in on https://review.openstack.org/#/c/531328/ ?10:49
stephenfinI know we fix some bugs without microversions, but maybe they're just for 5xx type errors10:50
sean-k-mooneytetsuro: well technicall kvm is not a hypervisor10:50
sean-k-mooneyit is kernel acclartion module that is used to acclerate qemu10:50
*** chyka has joined #openstack-nova10:51
*** janki has joined #openstack-nova10:51
*** abhishekk has quit IRC10:51
tetsurosean-k-mooney: hi, happy new year!10:51
sean-k-mooneytetsuro: same to you :) i trust you had a good vaction10:51
*** ygl has joined #openstack-nova10:52
*** ygl has left #openstack-nova10:52
*** kholkina has joined #openstack-nova10:52
tetsurosean-k-mooney: yup, I had a lot of mochi(rice cake) in new year days.10:52
*** yamahata has quit IRC10:53
cdentstephenfin: looking10:53
*** alexchadin has quit IRC10:53
rabel_b1do you know, what happened to https://docs.openstack.org/user-guide/cli-nova-launch-instance-from-volume.html ? i cannot seem to find it anywhere in the nova docs10:54
tetsuroIt is true that KVM is a kind of acceralator for QEMU, but in OpenStack document, it is one of the hypervisors. https://docs.openstack.org/mitaka/config-reference/compute/hypervisors.html10:54
lyarwoodmdbooth: https://review.openstack.org/#/c/460243 btw, merged both, pretty large change to backport but meh.10:55
*** chyka has quit IRC10:55
hrwtetsuro: kvm is in-kernel hypervisor with qemu used as interface to it. sth like that iirc10:57
mdboothlyarwood: Doesn't look that bad10:58
mdboothNot in driver.py, anyway10:58
*** alexchadin has joined #openstack-nova10:59
*** AlexeyAbashkin has quit IRC11:02
*** AlexeyAbashkin has joined #openstack-nova11:02
*** ratailor__ has joined #openstack-nova11:02
*** hoonetorg has quit IRC11:04
*** ratailor_ has quit IRC11:05
* cdent collides with sean-k-mooney 11:06
cdentyou're probalby right11:06
sean-k-mooneycdent: well when it comes to micro version is not really someting i spend much time thinking about normally so im not sure about that but im leaning towords the bump in this instance11:08
cdentyou've provided the critical point: a client may make decision based on the value11:08
*** priteau has joined #openstack-nova11:11
*** harsha has quit IRC11:11
*** janki has quit IRC11:13
*** janki has joined #openstack-nova11:13
*** priteau has quit IRC11:15
*** jchhatbar has joined #openstack-nova11:19
*** moshele has quit IRC11:19
*** tuanla____ has joined #openstack-nova11:20
*** moshele has joined #openstack-nova11:21
*** janki has quit IRC11:22
*** gmann__ has joined #openstack-nova11:23
*** udesale has quit IRC11:24
openstackgerritMerged openstack/nova master: Updated from global requirements  https://review.openstack.org/53173711:30
kashyaptetsuro: KVM runs part of the guest instructions directly on the baremetal CPU (taking advantage of CPU Virtualization extensions - Intel-VMX / AMD-SVM).  While QEMU provides rest of the PC-like components (n/w card, disk interface, etc)11:34
*** ratailor__ has quit IRC11:35
*** sree has joined #openstack-nova11:35
*** udesale has joined #openstack-nova11:36
*** bkopilov has quit IRC11:36
openstackgerritJie Li proposed openstack/nova master: Support volume-backed server rescue  https://review.openstack.org/53152411:36
tetsurohrw, kashyap: good to know. thanks for the information.11:37
tetsurosean-k-mooney, cdent: thank you for reviewing, let me wait for matt to leave comments here.11:38
*** priteau has joined #openstack-nova11:38
sandanarhi.. does anyone know what is the reason behind CONF.libvirt.volume_use_path always returns the default value and not the one passed in [libvirt] section of /etc/nova/nova.conf - https://bugs.launchpad.net/nova/+bug/1723928 this is causing multipath failures on the cinder side11:39
openstackLaunchpad bug 1723928 in os-brick "In case of volume_use_multipath=True, Nova unable to fetch CONF.libvirt.volume_use_multipath value from nova.conf" [Undecided,New]11:39
*** udesale has quit IRC11:39
*** udesale has joined #openstack-nova11:39
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination  https://review.openstack.org/51616811:40
*** sree has quit IRC11:40
lyarwoodkashyap: http://paste.openstack.org/show/641098/ - just noticed this on stable/pike https://review.openstack.org/#/c/531407/11:41
* kashyap clicks11:41
lyarwoodkashyap: load of migration failed: Operation not permitted11:41
kashyaplyarwood: That rings a bell, I recall seeing a bug for the VQ size11:42
* kashyap looks11:42
*** mvk has quit IRC11:45
*** kwathore has joined #openstack-nova11:45
kwathore@meriedm: This is very critical bug which we have observerd releated to multipath: https://bugs.launchpad.net/nova/+bug/172392811:48
openstackLaunchpad bug 1723928 in os-brick "In case of volume_use_multipath=True, Nova unable to fetch CONF.libvirt.volume_use_multipath value from nova.conf" [Undecided,New]11:48
*** gmann__ has quit IRC11:49
hrwhm. https://review.openstack.org/#/c/530965/ got rebased 2h ago and zuul still did not started11:50
*** gmann__ has joined #openstack-nova11:53
openstackgerritMerged openstack/nova stable/newton: Raise MarkerNotFound if BuildRequestList.get_by_filters doesn't find marker  https://review.openstack.org/53098211:55
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands  https://review.openstack.org/48740511:55
kashyaplyarwood: From the top off my head, I vaguely recall a couple of fixes from Virtio net devices from StefanH.  The bug links are eluding me11:56
*** sree has joined #openstack-nova11:56
kashyapI asked Stefan for the specific versions that fix these screwey virtio queue issues11:56
kashyapWill let ya know once I hear back from him11:57
lyarwoodkashyap: cool thanks11:57
openstackgerritMerged openstack/nova master: Add regression test for resize failing during retries  https://review.openstack.org/53140511:59
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache  https://review.openstack.org/47277312:00
*** sree has quit IRC12:00
hrwhttps://review.openstack.org/#/c/530965/ finally got +1 from Zuul. now just have to get second run of Zuul for +2 and merge ;d12:03
openstackgerritsahid proposed openstack/nova master: hardware: only take into account small pages  https://review.openstack.org/53216812:03
*** tuanla____ has quit IRC12:04
*** yamamoto has quit IRC12:06
*** avolkov has quit IRC12:06
*** yamamoto has joined #openstack-nova12:06
*** annp has quit IRC12:08
*** alexchadin has quit IRC12:14
*** alexchadin has joined #openstack-nova12:14
openstackgerritYikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.59 - Migrations list pagination  https://review.openstack.org/51616812:16
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add abstract OVSDB API  https://review.openstack.org/47661212:19
*** sree has joined #openstack-nova12:21
*** nicolasbock has joined #openstack-nova12:21
*** hareesh has joined #openstack-nova12:23
*** takedakn has joined #openstack-nova12:23
*** sree has quit IRC12:25
openstackgerritRodolfo Alonso Hernandez proposed openstack/os-vif master: Add native implementation OVSDB API  https://review.openstack.org/48222612:27
ildikovjohnthetubaguy: gibi: hi :) this tiny patch needs a second +2 if either of you have a few minutes: https://review.openstack.org/#/c/529695/12:28
ildikovjohnthetubaguy: gibi: thanks in advance :)12:29
*** moshele has quit IRC12:29
*** sree has joined #openstack-nova12:30
*** jpena is now known as jpena|lunch12:32
*** lucasagomes is now known as lucas-hungry12:33
*** hoonetorg has joined #openstack-nova12:34
*** hareesh has quit IRC12:34
*** sree has quit IRC12:35
*** sree has joined #openstack-nova12:38
openstackgerritLajos Katona proposed openstack/nova master: Deduplicate aggregate notification samples  https://review.openstack.org/53116212:38
gibiildikov: done :)12:39
*** avolkov has joined #openstack-nova12:43
openstackgerritLajos Katona proposed openstack/nova master: Deduplicate service status notification samples  https://review.openstack.org/53138112:44
ildikovgibi: thanks!! :)12:44
*** mvk has joined #openstack-nova12:47
*** sree has quit IRC12:48
*** sree has joined #openstack-nova12:49
*** smatzek has joined #openstack-nova12:56
*** zhurong_ has joined #openstack-nova12:56
*** tetsuro has quit IRC13:02
*** hoonetorg has quit IRC13:03
*** udesale has quit IRC13:06
sean-k-mooneystephenfin:  just looking at https://review.openstack.org/#/c/531358 looks like when you change your email to stephenfin instead of sfinucan you didnt update your global git user name. not sure if thats intentional but just taught i would point it out13:06
sean-k-mooney* global git email13:06
*** zhurong_ has quit IRC13:07
*** zhurong has quit IRC13:07
openstackgerritLajos Katona proposed openstack/nova master: Deduplicate aggregate notification samples  https://review.openstack.org/53116213:08
*** udesale has joined #openstack-nova13:08
*** dave-mccowan has joined #openstack-nova13:15
*** bkopilov has joined #openstack-nova13:17
*** rmart04 has joined #openstack-nova13:18
*** rabel__b1 has joined #openstack-nova13:21
*** dave-mccowan has quit IRC13:21
*** edmondsw has joined #openstack-nova13:21
*** alexchadin has quit IRC13:23
*** rabel_b1 has quit IRC13:24
*** alexchadin has joined #openstack-nova13:24
openstackgerritLajos Katona proposed openstack/nova master: Deduplicate service status notification samples  https://review.openstack.org/53138113:25
*** dave-mccowan has joined #openstack-nova13:26
mdboothCan anybody remind me about our stable backport window re https://review.openstack.org/#/c/530744/13:26
mdboothThat's an Ocata backport. Is it going to land?13:27
*** rabel_b1 has joined #openstack-nova13:27
mdbooths/going/eligible/13:27
mdboothstephenfin: ^^^ is your backport of my patch, btw13:27
*** yangyapeng has quit IRC13:27
lyarwoodmdbooth: looking13:28
efriedclaudiub Wow, congratulations!  That's been a long time coming.13:28
sean-k-mooneymdbooth: i think ocata is still supported for backports assuimg the patch would normally qualify.13:28
*** rabel__b1 has quit IRC13:29
sean-k-mooneymdbooth: the defult stable supprot is 12 months with the option to extend to 18 i think13:29
stephenfinsean-k-mooney: I've got both registered but need to configure 'user.email' on most repos13:29
lyarwoodmdbooth / sean-k-mooney ; by the book it would need to be a >=high impact bug13:29
stephenfinsean-k-mooney: stephenfin is only an alias anyway so either one works13:29
lyarwoodmdbooth: and I think this is valid still for ocata tbh13:29
*** rabel__b1 has joined #openstack-nova13:30
mdboothlyarwood: Yeah, bug doesn't have that metadata, but I'd say it should qualify13:30
sean-k-mooneystephenfin: ya i remember you telling me that just was not sure if you missed it or not13:30
lyarwoodmdbooth: yeah, had to read through the commit but yup IMHO it's fine, I'll review the pike version now13:30
mdboothlyarwood: Thanks13:31
*** lucas-hungry is now known as lucasagomes13:31
*** jpena|lunch is now known as jpena13:32
*** rabel_b1 has quit IRC13:32
sean-k-mooneystephenfin: lyarwood: since we are talking about backport i would like to backport this to pike and ocata too its trival enough but its a latent bug that has been present since os-vif was first created13:33
claudiubefried: yeay, gonna have to celebrate. :))13:33
claudiubthe patches on nova still need reviews though. :D13:33
sean-k-mooneystephenfin: lyarwood by the book would this qualify for backporting?13:33
stephenfinsean-k-mooney: "this" being?13:33
sean-k-mooneystephenfin: https://review.openstack.org/#/c/531465/13:33
*** vladikr has joined #openstack-nova13:34
*** Tom-Tom has joined #openstack-nova13:35
*** rabel_b1 has joined #openstack-nova13:36
*** rabel__b1 has quit IRC13:38
lyarwoodsean-k-mooney: yeah I'd say that would be valid for ocata, it's trivial but useful. I'm not sure if there are other considerations that need to be taken into account for libs however.13:39
sean-k-mooneylyarwood: in normal execution i think the edgecase that causes the interface not to be present happens very infrequently however in the gate it was causing random failures hence why it has been latent for so long13:41
openstackgerritZhenyu Zheng proposed openstack/nova master: Use neutron port_list when filtering instance by ip  https://review.openstack.org/52550513:45
*** phuongnh has quit IRC13:47
*** esberglu has joined #openstack-nova13:48
*** gmann__ has quit IRC13:50
*** AlexeyAbashkin has quit IRC13:52
kashyaplyarwood: So apparently there are different reasons for hitting that error you pointed out earlier.  (The bug URL I was looking for was, which has a slightly different error): https://bugzilla.redhat.com/show_bug.cgi?id=1378788 (Race condition during virtio-blk dataplane stop triggers "Virtqueue size exceeded")13:53
openstackbugzilla.redhat.com bug 1378788 in qemu-kvm-rhev "Race condition during virtio-blk dataplane stop triggers "Virtqueue size exceeded"" [High,Closed: errata] - Assigned to stefanha13:53
*** mriedem has joined #openstack-nova13:54
*** jchhatbar has quit IRC13:54
*** yangyapeng has joined #openstack-nova13:54
mriedemdtantsur: the devstack dependency for https://review.openstack.org/#/c/527289/ is now merged13:55
dtantsurmriedem: thanks, approved13:55
*** sree has quit IRC13:55
mriedemthanks13:55
lyarwoodkashyap: cool thanks, /me reads13:56
*** sree has joined #openstack-nova13:56
kashyaplyarwood: But we still don't have a root cause for the unique error you pointed out13:56
kashyapThe above bug was fixed in version QEMU 2.6 & above, though.13:57
lyarwoodkashyap: kk, this is with 2.8 FWIW13:57
lyarwoodkashyap: do we need a bug open somewhere for this in that case?13:57
kashyaplyarwood: Hmm, okay, Stefan just responded:13:57
kashyap"This issue probably requires debugging.  This kind of problem can occur if the vring memory is not up-to-date (e.g. requests were processed after migration paused the guest)."13:58
kashyaplyarwood: Do you see multiple hits for this?13:58
kashyaplyarwood: Yeah, an open bug helps definitely,13:58
*** takedakn has quit IRC13:58
kashyap...as others hitting it may have more reliable reproducers.13:59
lyarwoodkashyap: I've not looked, I'll check now, if we do then I'll create a LP for it13:59
*** AlexeyAbashkin has joined #openstack-nova14:00
*** sree has quit IRC14:00
*** alexchadin has quit IRC14:06
*** kholkina has quit IRC14:06
edmondswmriedem and sdague, the powervm OVS patch is fully ready for reviews now, passing CI14:07
edmondswhttps://review.openstack.org/#/c/422512/14:07
edmondswwe're working a CI issue for the SEA patch this morning, but as stated yesterday the code is ready for review14:07
edmondswwill update on the CI for SEA when we have that fixed14:07
mriedemi would expect efried to review that first14:09
efriedwill do14:09
lyarwoodkashyap: nvm we already have a LP from mriedem for this here - https://bugs.launchpad.net/nova/+bug/173762514:10
openstackLaunchpad bug 1737625 in OpenStack Compute (nova) "live migration failed with "Failed to load virtio-blk:virtio" (libvirt/qemu)" [Undecided,Confirmed]14:10
*** alexchadin has joined #openstack-nova14:10
kashyaplyarwood: Ah, thanks.14:11
*** rmart04 has quit IRC14:13
*** avolkov has quit IRC14:13
*** amodi has joined #openstack-nova14:13
*** moshele has joined #openstack-nova14:14
efriedmriedem Done14:19
*** jroll has quit IRC14:19
efried(OVS, that is)14:19
*** jroll has joined #openstack-nova14:19
*** jmlowe has quit IRC14:19
*** abhishekk has joined #openstack-nova14:20
*** READ10 has joined #openstack-nova14:23
*** moshele has quit IRC14:24
stephenfinmriedem: Our Python 3 woes have been resolved https://review.openstack.org/#/c/530950/14:28
*** psachin has quit IRC14:28
stephenfinmriedem: Fancy revisiting https://review.openstack.org/#/c/345399/ at some point this week?14:28
*** smatzek has quit IRC14:28
*** smatzek has joined #openstack-nova14:28
*** smatzek has quit IRC14:28
*** jmlowe has joined #openstack-nova14:30
*** rabel__b1 has joined #openstack-nova14:31
*** rabel_b1 has quit IRC14:32
*** cleong has joined #openstack-nova14:33
*** moshele has joined #openstack-nova14:34
*** jmlowe has quit IRC14:34
*** jmlowe has joined #openstack-nova14:35
*** jmlowe has quit IRC14:36
*** felipemonteiro_ has joined #openstack-nova14:36
*** yamamoto_ has joined #openstack-nova14:37
*** moshele has quit IRC14:38
ildikovmriedem: are you planning to do further tweaks on the multi-attach chain in Nova?14:40
*** yamamoto has quit IRC14:40
*** markvoelker has quit IRC14:40
*** eharney has joined #openstack-nova14:41
mriedemstephenfin: maybe14:42
mriedemildikov: maybe14:42
ildikovmriedem: ok, I started to look into the unit test failures, the first half is an easy fix, but won't touch the code for now then14:43
stephenfinmriedem: Good enough for me14:43
mriedemildikov: i posted it at 11pm and had fixed what i knew about, but haven't looked at the results yet this morning14:44
ildikovmriedem: http://logs.openstack.org/47/271047/48/check/openstack-tox-py27/991a4d8/testr_results.html.gz14:45
mriedemi'll look later, in the middle of something14:45
*** kaisers has quit IRC14:45
ildikovmriedem: I can fix these, upload and then we can agree who does what onwards, if that helps14:45
mriedemsure14:45
ildikovmriedem: ok, will do that then, tnx14:46
ildikovmriedem: I just wanted to ask to avoid overwriting each others' versions...14:46
mriedemyup14:47
*** kaisers has joined #openstack-nova14:51
mriedemmdbooth: clearly this has to be wrong right? https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L166914:53
mriedemand source_type not in ('lvm')14:53
* mdbooth looks14:53
mriedemi guess it does work as a substring match14:54
mriedemprobably by accident14:54
mdboothmriedem: I hadn't even spotted the 'strings are a list' thing...14:55
* mdbooth was still ponding the comment above14:55
*** avolkov has joined #openstack-nova14:55
openstackgerritAmeed Ashour proposed openstack/nova master: change instance_system_metadata column type  https://review.openstack.org/52690014:56
* mdbooth sent a long message: mdbooth_2018-01-09_14:56:23.txt <https://matrix.devlab.redhat.com/_matrix/media/v1/download/redhat.com/yUjvJDUFNKjpsnwVLtqVCaoN>14:56
*** alexchadin has quit IRC14:56
mdboothYeah, looks like it probably works accidentally14:56
mdbooth>>> 'foo' in ('foobar',)14:57
mdboothFalse14:57
mriedemyeah, just getting another set of eyes, just noticed it while looking at something else14:58
*** awaugama has joined #openstack-nova14:59
*** gouthamr has joined #openstack-nova15:00
*** liverpooler has joined #openstack-nova15:01
*** nicolasbock has quit IRC15:02
alex_xu_sdague: as I remember we forze the '/os-migrations' API, then we want to add links in the '/os-migrations' API to the '/servers/{uuid}/migrations', is it right? https://review.openstack.org/#/c/459483/15:02
mriedemalex_xu_: yes, but that was pretty short sighted15:03
mriedemas that change was specifically for the change to abort a running live migration for a given instance15:03
mriedemthere is still use in the os-migrations API15:03
*** sree has joined #openstack-nova15:03
*** vladikr has quit IRC15:03
mriedemfor example, it's the only one that you can use to list not in progress migrations15:03
openstackgerritLee Yarwood proposed openstack/nova master: rbd: flatten images when creating/unshelving an instance  https://review.openstack.org/45788615:06
*** diga has joined #openstack-nova15:06
*** lyan has joined #openstack-nova15:09
mriedemdansmith: i'm +2 on the migration paging/filtering series https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-pagination-and-change-since-for-migration-list15:11
mriedemthat includes the cross-cell lister15:11
*** smatzek has joined #openstack-nova15:11
*** smatzek has quit IRC15:11
dansmithmriedem: okay15:11
*** smatzek has joined #openstack-nova15:11
*** tidwellr has joined #openstack-nova15:12
*** markvoelker has joined #openstack-nova15:13
*** markvoelker has quit IRC15:16
*** hoonetorg has joined #openstack-nova15:16
*** sree has quit IRC15:17
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: don't attempt to live snapshot paused instances  https://review.openstack.org/53221415:19
mriedemsdague: does this look familiar? ^ i now remember why i added the PAUSED condition to the patch to enable libvirt live snapshot by default15:20
mriedemit doesn't work on older libvirt/qemu15:20
*** jmlowe has joined #openstack-nova15:20
*** jmlowe has quit IRC15:21
*** abhishekk has quit IRC15:21
*** jmlowe has joined #openstack-nova15:21
*** armax has joined #openstack-nova15:21
*** jmlowe has quit IRC15:22
*** jmlowe has joined #openstack-nova15:22
*** lajoskatona has quit IRC15:22
*** sree has joined #openstack-nova15:25
openstackgerritsahid proposed openstack/nova master: hardware: only take into account small pages  https://review.openstack.org/53216815:25
*** markvoelker has joined #openstack-nova15:25
*** rmart04 has joined #openstack-nova15:27
*** kumarmn has joined #openstack-nova15:27
*** sree has quit IRC15:29
mriedemstephenfin: simple reno update https://review.openstack.org/#/c/531963/15:29
mriedemi was reading the release notes last night and when you put them together, the context is lost on some of them15:30
kashyapmriedem: A quick aside: Follow up from your test that the 'shareable' disk flag "doesn't work when using raw images either http://paste.openstack.org/show/639185/"15:30
kashyapIt was a real bug apparently and fixed in libvirt 3.10 and above.  (All the messy dependent bugs are linked here: https://bugzilla.redhat.com/show_bug.cgi?id=1378242)  (libvirt patch series: "[PATCH v2 00/11] qemu: Fix <shareable/> disks for new qemu")15:30
openstackbugzilla.redhat.com bug 1378242 in libvirt "QEMU image file locking (libvirt)" [Unspecified,On_qa] - Assigned to pkrempa15:30
mriedemkashyap: ok just reading https://bugzilla.redhat.com/show_bug.cgi?id=1378242#c2115:31
openstackbugzilla.redhat.com bug 1378242 in libvirt "QEMU image file locking (libvirt)" [Unspecified,On_qa] - Assigned to pkrempa15:31
mriedemkashyap: but yeah, for now the change for multiattach in the libvirt driver only supports multiattach if qemu<2.10 or libvirt>=3.1015:32
kashyapmriedem: BTW, about that snapshots and paused instances; I already thought it was fixed earlier, maybe I'm hallucinating15:32
mriedemhttps://review.openstack.org/#/c/267587/83/nova/virt/libvirt/driver.py15:32
kashyapBut see the version dependancy you document in the commit message.15:32
kashyapmriedem: Noted (about the multi-attach change)15:33
*** Apoorva has joined #openstack-nova15:33
mriedemas for this test https://review.openstack.org/#/c/267587/83/nova/tests/unit/virt/libvirt/test_driver.py@19520 - i can't sort out the global mock nature that makes it fail when running the entire test module15:33
* kashyap needs to take train in 10 minutes to go home; if I go radio silent or don't respond, you know why.15:33
mriedemhttps://review.openstack.org/#/c/267587/83/nova/tests/unit/virt/libvirt/test_driver.py@19520 is a challenge for mdbooth15:33
mdboothmriedem: Have you done the bisect thing?15:35
mriedemmdbooth: nope15:35
* mdbooth always forgets the details15:35
mdboothI believe the instructions were originally written by sdague15:35
mriedemi thought that splitting the tests out into it's own class would help so they weren't running with the other tests in LibvirtConnTestCase but that didn't help15:35
*** sree has joined #openstack-nova15:36
*** links has quit IRC15:36
mdboothmriedem: This one: https://wiki.openstack.org/wiki/Testr#Reproducing_Failures15:36
mriedemoh cool, i'll try that15:37
mdboothThe output of that process is a minimal test ordering which causes the failure.15:37
mdboothThen you just squint at it for a bit.15:37
mriedemjohnthetubaguy: can you drop the -2 on this? https://review.openstack.org/#/c/140733/15:38
mriedemjohnthetubaguy: also, i plumbed in the multiattach API functional changes last night - https://review.openstack.org/#/c/271047/ - still need to cleanup some test fallout from some refactor that was needed, but it should be ok to start reviewing the flow15:38
johnthetubaguymriedem: done15:38
mriedemyou have to use a new microversion to bfv or attach with a multiattach volume,15:39
johnthetubaguymriedem: ah cool, I am chasing some ironic traits stuff today, but will try get to that soon15:39
mriedemand then we have min compute version checks and such15:39
johnthetubaguymriedem: all sounds sensible15:39
mriedemit got a bit gross because i had to change a volume_id param to a volume dict in one of the lower down methods15:39
mriedemto avoid multiple volume GET calls15:40
ildikovmriedem: johnthetubaguy: the functional tests run into a KeyError on the volume which should be an easy fix if I can finally find the spot where it actually goes wrong... :)15:41
*** ameeda has quit IRC15:41
*** hoonetorg has quit IRC15:41
mriedemildikov: it's probably a GET response from the CinderFixture15:41
ildikovmriedem: was it multiple GET calls?15:41
*** breton has joined #openstack-nova15:42
ildikovmriedem: the fakes returns a volume dict with 'multiattach'15:42
bretonhi15:42
ildikovmriedem: or I found another volume dict that contained it...15:42
*** sree has quit IRC15:42
mriedemildikov: https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L133215:42
mriedem^ doesn't contain multiattach=False15:42
mriedemnor do the ones below15:43
mriedemsame thing in CinderFixtureNewAttachFlow15:43
mriedemildikov: i could have made the API code a lot of easier on tests if i just did volume.get('multiattach') but that's a cop out since the volume response from cinder's API should always have that key set15:43
*** david-lyle has joined #openstack-nova15:44
bretonIs liberty affected by https://bugs.launchpad.net/nova/+bug/1664931? Is there any sense in porting https://review.openstack.org/#/c/519684/7 ?15:44
openstackLaunchpad bug 1664931 in OpenStack Compute (nova) pike "[OSSA-2017-005] nova rebuild ignores all image properties and scheduler filters (CVE-2017-16239)" [High,Fix committed] - Assigned to Matt Riedemann (mriedem)15:44
ildikovmriedem: the test calls this: https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/fakes.py#L61815:45
mriedembreton: the OSSA-2017-005 calls out the affected versions15:45
ildikovmriedem: which then goes here: https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/fakes.py#L56815:45
*** felipemonteiro__ has joined #openstack-nova15:45
mriedemildikov: i thought you were asking about functional tests15:45
mriedemhttps://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/fakes.py#L586 should have probably never been True15:46
bretonmriedem: so do i understand it right that all versions <=14.0.10 are affected?15:46
ildikovmriedem: I do15:46
ildikovmriedem: https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_volumes.py#L24715:47
ildikovmriedem: and just the old flow tests fail15:48
mriedembreton: https://github.com/openstack/nova/commit/d6ca1cc02ab58615a6bb1b337db34dd06525112e introduced the regression,15:48
bretonmriedem: i am unsure because in liberty request specs were not used for instance rebuild15:48
mriedemin 12.0.0 which was liberty15:48
ildikovmriedem: and I'm surely just blind and hate all the fake stuff...15:48
*** felipemonteiro_ has quit IRC15:49
mriedemildikov: oh i didn't realize the functional tests were using unit test stubs....15:49
mriedemthey should be using the CinderFixture, but that's not a change to make here15:49
ildikovI got surprised too :)15:50
bretonmriedem: understood, thanks15:50
*** diga has quit IRC15:50
mriedemildikov: https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_volumes.py#L36815:51
mriedemthe 2.49 test is using the CinderFixture as well as the fakes/stubs15:51
mriedemand the fixture is loaded after the stubs in the parent class setup15:52
mriedemso the fixture overrides the GET call15:52
mriedemand the fixture doesn't have multiattach in the response15:52
mriedemso just fix the fixtures since you have to do that anyway15:52
ildikovthe test seemed to call it explicitely15:52
ildikovanyway, will fix that15:52
mriedemthe test calling fakes.stub_volume_get and the actual api runtime code calling it via the fixture are different thigns15:53
mriedem*things15:53
ildikovor in other words it's a mess :)15:53
mriedemyeah, the functional tests shouldn't be using stubs from the unit tests, they should use the fixture long-term15:54
mriedemit's ultimately trading one set of stubs for another15:54
*** hoonetorg has joined #openstack-nova15:54
*** sree has joined #openstack-nova15:55
*** mlavalle has joined #openstack-nova15:56
*** slaweq has joined #openstack-nova15:56
*** mdnadeem has quit IRC15:57
smcginnismriedem: Are these Cinder or Nova tests you are referring to?15:57
mriedemnova15:57
*** tovin07 has joined #openstack-nova15:57
Roamer`johnthetubaguy, now that mriedem seems to be kinda sorta okay with the StorPool libvirt volume driver (thanks!) and it passed the Zuul checks (yay!), could you remove your procedural -2?  thanks in advance!15:57
smcginnisOK, good.15:57
mriedemRoamer`: he already did15:57
Roamer`mriedem, johnthetubaguy, ahhhhh, right... he did indeed... thanks!15:58
Roamer`(today is NOT my day for reading and parsing stuff)15:58
*** sree has quit IRC15:59
ildikovsmcginnis: got scared for a moment? :)16:02
*** felipemonteiro__ has quit IRC16:03
*** felipemonteiro__ has joined #openstack-nova16:03
*** yamahata has joined #openstack-nova16:03
*** janki has joined #openstack-nova16:03
*** sandanar has quit IRC16:03
smcginnisildikov: Yep. ;)16:04
smcginnisildikov: Our tests already need a lot of work. I was just hoping that it wasn't worse than I already knew.16:04
ildikovsmcginnis: I know that part :)16:05
ildikovsmcginnis: but you know no one is perfect, even Nova has it's flows :)16:05
ildikovs/it's/its/16:05
smcginnisildikov: Shh, you can't say that over here. :D16:05
*** rmart04 has quit IRC16:06
ildikovsmcginnis: they all know I'm just expressing my love :)16:06
*** markvoelker has quit IRC16:09
*** stvnoyes has joined #openstack-nova16:11
tovin07mriedem, can you take a quick look at this small fix (already had +2 from stephenfin): https://review.openstack.org/#/c/519664/16:11
*** jackie-truong has joined #openstack-nova16:11
stephenfinmriedem: Done (the release note)16:13
openstackgerritMerged openstack/nova master: Move aggregates from report client to ProviderTree  https://review.openstack.org/52168516:13
*** hongbin has joined #openstack-nova16:17
*** lpetrut has quit IRC16:18
bauzasis it me or the gate is in the weeds ?16:19
*** itlinux has joined #openstack-nova16:19
bauzasI'm still waiting a single change to be merged since this morning16:19
*** udesale has quit IRC16:20
*** harsha has joined #openstack-nova16:24
mriedemedleafe: comments on the alternate hosts patch for resize https://review.openstack.org/#/c/526436/2116:26
mriedembauzas: thankfully you can take this opportunity to review some patches16:27
hrwguys: where 'default' VM is defined? Nova decides what to include or does it just use defaults from libvirt?16:27
efriedbauzas Yeah, https://review.openstack.org/#/c/521685/ took 8.5h to merge this morning.16:27
hrwI mean things like networking, graphics, usb, storage. not amount of ram/vcpu/storage16:28
openstackgerritMerged openstack/nova master: Fix race condition in retrying migrations  https://review.openstack.org/53102216:29
*** tidwellr has quit IRC16:29
bauzasmriedem: yup, I'm just working on a new PS for the vGPU change, but I hope to look at reviewing changes by tomorrow16:30
*** Tom-Tom has quit IRC16:30
*** tidwellr has joined #openstack-nova16:32
stephenfinlyarwood: Have you got this the right way round? https://review.openstack.org/#/c/530744/16:32
stephenfinWait - O comes before P16:33
* stephenfin considers trying coffee16:33
lyarwood:D16:34
*** markvoelker has joined #openstack-nova16:37
mriedemtovin07: done16:37
edleafemriedem: thx. Found a bug in my own code, so I'm working on fixing it16:38
* edleafe loves functional tests16:38
cdentfunctional tests love you more16:39
*** yamamoto_ has quit IRC16:40
*** READ10 has quit IRC16:41
mriedemefried: powervm ci is going to use SEA rather than OVS for networking right?16:42
efriedFor the immediate future, yes.  esberglu ^16:42
mriedemso what networking is this running against? https://review.openstack.org/#/c/422512/16:42
mriedemif SEA isn't yet there16:42
efriedI forget that answer.  esberglu is on the way...16:43
mriedemConfigured mechanism driver names: ['openvswitch', 'linuxbridge']16:43
openstackgerritLee Yarwood proposed openstack/nova master: compute: Detach volumes on _rebuild_default_impl failure  https://review.openstack.org/44210516:43
mriedemso maybe just the defaults for ML2?16:43
lyarwoodstephenfin / mdbooth; if you have any review time left today https://review.openstack.org/#/c/460243/ has been respun to include the fix from https://review.openstack.org/#/c/531233/16:45
*** felipemonteiro_ has joined #openstack-nova16:45
esberglumriedem: That's just running the CI we've been using since last release with no networking implementation16:46
esbergluAbout to merge a patch that fixes SEA CI16:46
efriedesberglu IOW, neither network patch is yet running a CI that tests networking, but soon the SEA patch will run CI with SEA networking?16:48
efriedesberglu And... if we were to run the OVS patch once that is done, it would what, fail?16:48
*** felipemonteiro__ has quit IRC16:49
esbergluefried: No it would pass, but it would be testing SEA networking16:49
efriedesberglu How, without the SEA patch?16:49
esbergluefried: PowerVM is running SEA CI on all nova changes as of yesterday16:49
efriedesberglu How, without the SEA patch?16:49
esbergluIt is applying the SEA patch16:50
efriedahh16:50
esbergluHence the issue applying the SEA patch to the OVS and SEA changes, which we just fixed16:50
efriedthat's what we were *just* working on, yeah :)16:50
efriedpieces come together.16:50
efriedmriedem Does this answer your question?16:51
*** damien_r has quit IRC16:51
*** chyka has joined #openstack-nova16:52
mriedemhuh16:52
mriedemok16:52
mriedemtypically applying patches to the CI results for code that's not yet merged is a bit a of a no-no16:52
openstackgerritClaudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage  https://review.openstack.org/44750516:53
efriedmriedem We have a chicken/egg here16:54
*** kumarmn has left #openstack-nova16:55
mriedemwell, that egg wasn't necessary in pike was it?16:55
esberglumriedem: No we did this in pike as well16:55
mriedemor is the chicken the os-vif stuff added with the ovs change, which the SEA change relies on?16:55
mriedemoh fun16:55
*** smatzek has quit IRC16:56
*** itlinux has quit IRC16:56
*** smatzek has joined #openstack-nova16:57
efriedmriedem Yeah, the SEA change is on top of the OVS change.  Technically we would probably be able to wait to switch on the patching-and-SEA-networking part of the CI until after the OVS patch merges, but for the sake of getting both patches in the review pipeline as quickly as possible...16:57
*** smatzek_ has joined #openstack-nova16:59
*** smatzek_ has quit IRC17:00
*** smatzek_ has joined #openstack-nova17:00
*** gyee has joined #openstack-nova17:01
*** smatzek has quit IRC17:02
*** slaweq has quit IRC17:02
*** AlexeyAbashkin has quit IRC17:02
*** tbachman has quit IRC17:03
gibimriedem: have you planned to join to the notification subteam meeting?17:03
*** sridharg has quit IRC17:03
stephenfinclaudiub: Want to look at https://review.openstack.org/#/c/447505/ so I can sign off on it?17:04
*** vivsoni__ has joined #openstack-nova17:05
openstackgerritIldiko Vancsa proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api  https://review.openstack.org/27104717:05
*** armax has quit IRC17:05
*** karthiks has quit IRC17:05
*** janki has quit IRC17:06
*** mvk has quit IRC17:06
*** mdnadeem has joined #openstack-nova17:06
gibimriedem: as nobody joined, I've just closed the meeting, we can discuss thing separatly if neede17:07
*** alex_xu_ has quit IRC17:07
mriedemgibi: sorry missed your ping17:08
*** hongbin has quit IRC17:08
*** hongbin has joined #openstack-nova17:08
stephenfinlyarwood: Looked, but my head is gone. I'll hit it tomorrow morning17:08
*** alex_xu has joined #openstack-nova17:08
lyarwoodstephenfin: no issues17:08
*** jackie-truong has quit IRC17:12
*** felipemonteiro_ has quit IRC17:13
*** smatzek_ has quit IRC17:15
*** smatzek has joined #openstack-nova17:15
*** lucasagomes is now known as lucas-afk17:16
*** tovin07 has quit IRC17:16
*** moshele has joined #openstack-nova17:18
*** itlinux has joined #openstack-nova17:18
claudiubstephenfin: done. just fyi. the patch merged in oslotest, and it is included in oslotest 3.2.0. right now, I'm still waiting for the global-requirements bump for oslotest, and then for the OpenStack Bot requirements update to be proposed to nova and be merged, Then finally, that patch is mergeable. :)17:18
efriedbauzas You still working on series https://review.openstack.org/#/c/528832/ locally?  I see "Done" comments from ~8h ago but no new patch set.17:19
openstackgerritClaudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage  https://review.openstack.org/44750517:20
*** tbachman has joined #openstack-nova17:21
*** smatzek has quit IRC17:21
*** matrohon has quit IRC17:22
*** rabel__b1 has quit IRC17:22
*** penick has joined #openstack-nova17:23
*** david-lyle has quit IRC17:23
*** jaosorior has quit IRC17:25
*** david-lyle has joined #openstack-nova17:26
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: test to make sure volume_use_multipath is properly used  https://review.openstack.org/53227017:27
*** sree has joined #openstack-nova17:27
bauzasefried: yup, I'm in there17:27
efriedk.17:28
*** smatzek has joined #openstack-nova17:29
bauzasdansmith: around ? I have a thought17:29
bauzasdansmith: I'm just building a dictionary of assigned mdevs but looking up the guests by init_host17:29
bauzasdansmith: when I'm assigning a mdev to a guest, I'm also amending that dict17:30
*** smatzek has quit IRC17:30
*** smatzek has joined #openstack-nova17:30
efriedbauzas Re+W https://review.openstack.org/#/c/466051/ after rebase?17:30
bauzasdansmith: but for example, say we migrate the instance (or just destroy it), I should call the method recreating the dict17:30
bauzasdansmith: or we could have a mdev said to be assigned while the guest is destroyed17:31
*** harsha has quit IRC17:31
*** smatzek has quit IRC17:31
*** Apoorva has quit IRC17:31
bauzasdansmith: do you think it would be better to call that method by each method (like migrate, rebuild and destroy) or just use a periodic method ?17:32
*** smatzek has joined #openstack-nova17:32
*** tidwellr has quit IRC17:32
dansmithbauzas: um, you're not persisting that dict are you?17:32
bauzasif you don't understand my concern, no worries, I'll upload the series soon17:32
*** tidwellr has joined #openstack-nova17:32
bauzasdansmith: by persisting, you mean what ? using an attribute ?17:33
dansmithI mean... persisting it.. I'm not sure what you'd need to update periodically,17:33
dansmithbut maybe just upload and we can talk about it concretely17:33
bauzasnevermind, I'll upload17:33
bauzassure, just working on the tests now17:33
bauzasefried: +Wd17:34
efriedthx17:34
openstackgerritMerged openstack/nova master: Add an additional description for 'token_ttl'  https://review.openstack.org/53200717:35
dansmithmriedem: did you check that this is actually using multiple cells? https://review.openstack.org/#/c/517273/39/nova/tests/functional/compute/test_migration_list.py17:35
*** smatzek has quit IRC17:36
*** smatzek has joined #openstack-nova17:37
*** yamahata has quit IRC17:38
mriedemdansmith: i think he copied that from your instance list tests, but it doesn't look like it explicitly creates multiple cells17:38
mriedemhttps://github.com/openstack/nova/blob/master/nova/tests/functional/compute/test_instance_list.py#L2517:39
mriedemhe needs that17:39
mriedemgood point17:39
dansmithbut I set17:39
dansmithyeah :)17:39
mriedemremoved my +217:39
*** smatzek has quit IRC17:39
*** tbachman has quit IRC17:39
mriedemlay down the -117:39
dansmithI done did17:40
*** smatzek has joined #openstack-nova17:40
*** moshele has quit IRC17:40
*** yamamoto has joined #openstack-nova17:41
*** mdnadeem has quit IRC17:41
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: add tests to check multipath in iscsi/fc volume connectors  https://review.openstack.org/53227217:44
*** tbachman has joined #openstack-nova17:44
*** smatzek has quit IRC17:44
*** sree has quit IRC17:46
*** smatzek has joined #openstack-nova17:46
mriedemdansmith: per https://review.openstack.org/#/c/517273/39/nova/db/sqlalchemy/api.py@4410 did you want to hold up https://review.openstack.org/#/c/514904/ ?17:47
dansmithno I just wanted to make the comment to sound like I'm paying attention17:47
*** markvoelker has quit IRC17:47
mriedemheh, ok17:47
*** sree has joined #openstack-nova17:49
*** sahid has quit IRC17:49
*** yamamoto has quit IRC17:49
*** smatzek has quit IRC17:50
*** smatzek has joined #openstack-nova17:51
*** sree has quit IRC17:54
*** smatzek has quit IRC17:56
*** tesseract has quit IRC17:57
*** sree has joined #openstack-nova17:58
*** edmondsw has quit IRC17:58
*** smatzek has joined #openstack-nova17:58
*** derekh has quit IRC18:00
*** edmondsw has joined #openstack-nova18:01
*** Apoorva has joined #openstack-nova18:02
*** Apoorva has quit IRC18:02
*** smatzek has quit IRC18:03
*** smatzek has joined #openstack-nova18:03
*** edmondsw has quit IRC18:06
*** david-lyle has quit IRC18:06
*** penick has quit IRC18:10
*** satyar has joined #openstack-nova18:14
*** yamahata has joined #openstack-nova18:16
*** dtantsur is now known as dtantsur|afk18:17
*** ralonsoh has quit IRC18:21
*** avolkov has quit IRC18:21
*** dtruong has joined #openstack-nova18:24
*** satyar has quit IRC18:25
*** AlexeyAbashkin has joined #openstack-nova18:26
*** jpena is now known as jpena|off18:29
*** AlexeyAbashkin has quit IRC18:30
*** esberglu has quit IRC18:31
*** esberglu has joined #openstack-nova18:31
*** Apoorva has joined #openstack-nova18:32
*** Tom-Tom has joined #openstack-nova18:35
*** armax has joined #openstack-nova18:36
*** itlinux has quit IRC18:38
*** itlinux has joined #openstack-nova18:42
*** slaweq has joined #openstack-nova18:44
*** gouthamr has quit IRC18:46
*** slaweq has quit IRC18:46
*** itlinux has quit IRC18:46
*** gouthamr has joined #openstack-nova18:48
*** oanson has quit IRC18:48
*** itlinux has joined #openstack-nova18:49
*** moshele has joined #openstack-nova18:50
*** felipemonteiro has joined #openstack-nova18:51
*** itlinux has quit IRC18:52
*** itlinux has joined #openstack-nova18:54
*** tbachman has quit IRC18:55
*** itlinux has quit IRC18:55
*** moshele has quit IRC18:55
*** tbachman has joined #openstack-nova18:56
*** jmlowe has quit IRC18:56
*** amodi has quit IRC18:57
*** penick has joined #openstack-nova18:57
*** carthaca_ has joined #openstack-nova18:57
*** carthaca_ has quit IRC18:59
*** penick has quit IRC19:00
*** jackie-truong has joined #openstack-nova19:01
*** carthaca_ has joined #openstack-nova19:01
*** carthaca_ has quit IRC19:03
*** sree has quit IRC19:05
*** david-lyle has joined #openstack-nova19:10
*** moshele has joined #openstack-nova19:12
*** markvoelker has joined #openstack-nova19:13
*** markvoelker has quit IRC19:13
openstackgerritMark Goddard proposed openstack/nova master: WIP: Send traits to ironic on server boot  https://review.openstack.org/50811619:15
openstackgerritMark Goddard proposed openstack/nova master: Add get_traits() method to ComputeDriver  https://review.openstack.org/53228719:15
openstackgerritMark Goddard proposed openstack/nova master: Implement get_traits() for the ironic virt driver  https://review.openstack.org/53228819:15
openstackgerritMark Goddard proposed openstack/nova master: Add has_any_traits() to provider tree  https://review.openstack.org/53228919:15
openstackgerritMark Goddard proposed openstack/nova master: Call get_traits() in the resource tracker  https://review.openstack.org/53229019:15
*** fragatina has joined #openstack-nova19:17
*** itlinux has joined #openstack-nova19:18
*** fragatina has quit IRC19:18
*** vivsoni__ has quit IRC19:18
*** fragatina has joined #openstack-nova19:19
*** moshele has quit IRC19:21
*** jmlowe has joined #openstack-nova19:22
*** markvoelker has joined #openstack-nova19:23
*** sambetts is now known as sambetts|afk19:23
*** itlinux has quit IRC19:24
*** hoonetorg has quit IRC19:25
*** tbachman has quit IRC19:27
*** tbachman has joined #openstack-nova19:30
efriedmgoddard Let me know if you want to chat about ^19:31
*** priteau has quit IRC19:32
*** penick has joined #openstack-nova19:32
*** harlowja has joined #openstack-nova19:33
*** penick has quit IRC19:36
*** itlinux has joined #openstack-nova19:36
*** jmlowe has quit IRC19:40
*** harlowja_ has joined #openstack-nova19:41
*** itlinux has quit IRC19:41
*** markvoelker has quit IRC19:42
*** markvoelker has joined #openstack-nova19:43
*** harlowja has quit IRC19:43
*** jmlowe has joined #openstack-nova19:43
*** moshele has joined #openstack-nova19:44
*** cdent has quit IRC19:44
*** amodi has joined #openstack-nova19:46
*** matrohon has joined #openstack-nova19:47
*** markvoelker has quit IRC19:48
*** gouthamr has quit IRC19:53
*** harlowja_ has quit IRC19:55
*** harlowja has joined #openstack-nova19:55
*** jackie-truong has quit IRC19:59
*** gouthamr has joined #openstack-nova20:02
*** matrohon has quit IRC20:03
*** amodi has quit IRC20:03
*** damien_r has joined #openstack-nova20:05
*** amodi has joined #openstack-nova20:06
*** mvk has joined #openstack-nova20:11
*** yamamoto has joined #openstack-nova20:11
*** moshele has quit IRC20:12
mriedemwait wait wait,20:13
mriedemjohnthetubaguy has a minion?20:13
*** moshele has joined #openstack-nova20:15
*** fragatina has quit IRC20:15
openstackgerritMerged openstack/nova master: libvirt: Provide VGPU inventory for a single GPU type  https://review.openstack.org/51476320:15
*** slaweq has joined #openstack-nova20:17
rybridgesHey Guys! Have a really quick question. Related to this spec: https://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/quiesced-image-snapshots-with-qemu-guest-agent.html20:18
*** matrohon has joined #openstack-nova20:18
rybridgesIs that QEMU guest agent that is mentioned something that a user would install on their own instance? Or is that something that we (as operators) would install on the hypervisor itself?20:19
*** moshele has quit IRC20:19
mriedemrybridges: it's in the image20:20
mriedem‘hw_qemu_guest_agent=yes’ property and ‘hw_require_fsfreeze=yes’ property is set on the image metadata, and QEMU Guest Agent is installed and enabled in the instance20:20
mriedems/in the instance/in the image/20:20
mriedemthe image metadata is just telling nova that the image has the guest agent and requires fsfreeze20:21
mriedemprior to snapshot20:21
*** hoonetorg has joined #openstack-nova20:21
rybridgesok so the part i am confused about is "QEMU Guest Agent is installed and enabled in the instance"20:24
*** eharney has quit IRC20:24
rybridgesso this means we would bake the QEMU Guest Agent into the image itself20:24
rybridgessuch that when we boot an instance, the QEMU Guest Agent will automatically come up and be enabled20:24
openstackgerritIldiko Vancsa proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api  https://review.openstack.org/27104720:25
ildikovmriedem: ^^20:25
mriedemrybridges: yes20:26
*** eharney has joined #openstack-nova20:26
mriedemthat's my understanding, nova doesn't inject something into the image20:26
*** amodi has quit IRC20:26
openstackgerritEric Berglund proposed openstack/nova master: WIP: PowerVM Driver: vSCSI  https://review.openstack.org/52609420:26
*** imacdonn has quit IRC20:32
*** imacdonn has joined #openstack-nova20:32
*** markvoelker has joined #openstack-nova20:33
openstackgerritMatt Riedemann proposed openstack/nova master: Add cross cell sort support for get_migrations  https://review.openstack.org/51727320:33
openstackgerritMatt Riedemann proposed openstack/nova master: Add pagination and Changes-since filter support for os-migrations.  https://review.openstack.org/33040620:33
openstackgerritMatt Riedemann proposed openstack/nova master: Add index(updated_at) on migrations table.  https://review.openstack.org/53113220:33
mriedemdansmith: i addressed the 2 addressable comments in the migration multi-cell lister patch ^20:34
rybridgesok thanks mriedem20:38
mriedemrybridges: https://www.sebastien-han.fr/blog/2015/02/09/openstack-perform-consistent-snapshots-with-qemu-guest-agent/ ?20:38
mriedemold blog but probably still good20:38
*** cleong has quit IRC20:38
mriedemstvnoyes: finally got that snapshot test passing http://logs.openstack.org/86/531386/7/check/tempest-full/eca51c5/job-output.txt.gz#_2018-01-09_19_34_20_73160920:41
mriedembut failed in teardown20:41
mriedemhttp://logs.openstack.org/86/531386/7/check/tempest-full/eca51c5/job-output.txt.gz#_2018-01-09_20_01_02_05226820:41
mriedemhmm, failed to delete the volume,20:41
stvnoyesi never like it when problems happen in teardown...20:42
mriedembut the test is explicitly deleting the volume and cascading it's snapshot delete https://review.openstack.org/#/c/266605/24/tempest/api/compute/volumes/test_attach_volume.py@41720:42
mriedemsmcginnis: does the volume cascading delete stuff work?20:42
smcginnismriedem: Why do I feel like this is a trick question?20:42
mriedemmaybe i don't know what's possible, but,20:43
mriedemi create a volume-backed instance and create a snapshot of it, which also creates a snapshot of the volume,20:43
mriedemat the end of the test, i do a delete volume with cascade=True so i don't have to explicitly delete the volume snapshot20:43
mriedemassuming that's OK?20:44
*** jmlowe has quit IRC20:44
smcginnismriedem: So from Cinders perspective that's just a volume with a snapshot. So yeah, that should work if you pass cascade=True and it should delete any child snapshots on volume deletion.20:44
mriedemweird, don't even see the error in the c-api logs20:45
mriedemoh here we go20:45
mriedemdamn c-api log doesn't really tell me anything20:46
mriedemOH20:47
mriedemi see20:47
mriedemINFO cinder.api.openstack.wsgi [None req-57d5906a-2c27-4546-8fbd-21d355fd886d tempest-AttachVolumeMultiAttachTest-336010326 tempest-AttachVolumeMultiAttachTest-336010326] https://10.0.1.221/volume/v3/1e7533c90d794cf8a7463d9a7473244e/volumes/42c444d7-4b3a-42f0-a2d6-3fe652814e05?cascade=True returned with HTTP 20220:47
mriedemthat's the one i'm doing and it's a 20220:47
mriedemINFO cinder.api.openstack.wsgi [None req-4afc5bd6-64cd-444b-9d7f-51e87a67c0e4 tempest-AttachVolumeMultiAttachTest-336010326 tempest-AttachVolumeMultiAttachTest-336010326] https://10.0.1.221/volume/v3/1e7533c90d794cf8a7463d9a7473244e/volumes/42c444d7-4b3a-42f0-a2d6-3fe652814e05 returned with HTTP 40020:47
mriedemthat's the one that tempest teardown is doing becaues i'm not waiting for my call to complete20:48
mriedemdrats20:48
*** yamamoto has quit IRC20:48
smcginnisOh, so it's trying to delete the volume without cascade while your call is still cleaning up?20:48
mriedemyeah20:48
mriedemi just need to add a waiter20:48
mriedemeasy peasy20:49
mriedemildikov: i don't know why but your api update says it's in merge conflict20:49
*** yamamoto has joined #openstack-nova20:49
ildikovmriedem: maybe because the shared_targets patch didn't get through the gate due to zuul issues or smth?20:50
ildikovmriedem: I didn't want to rebase until that's merged...20:50
mriedemyeah that's fine, i'm going to update this tempest patch20:51
ildikovI only changed the top patch and downloaded the whole chain fresh before20:51
ildikovI will check on zuul and see where things are20:52
*** cfriesen has joined #openstack-nova20:53
*** armax has quit IRC20:53
*** yamamoto has quit IRC20:54
*** priteau has joined #openstack-nova20:55
*** vladikr has joined #openstack-nova20:56
mriedem5: (529695,5) Use volume shared_targets to lock during attach/detach (8h17m/++++~+~++++/rem:1h56m)20:57
*** belmoreira has joined #openstack-nova20:57
mriedem#5 in the gate so should be merged soonish20:57
mriedemit's only been there for 8.5 hours already..20:57
mriedemildikov: ok i guess i'll start working on adding tests for the new flows when the microversion is high enough and multiattach is True21:00
*** penick has joined #openstack-nova21:00
ildikovmriedem: ok, I'm not touching the chain then21:02
ildikovmriedem: the unit and functional tests are fixed in the latest version21:03
ildikovat least it worked for me...21:03
*** jmlowe has joined #openstack-nova21:06
*** liverpooler has quit IRC21:11
*** markvoelker has quit IRC21:13
*** markvoelker has joined #openstack-nova21:13
mriedemmdbooth: damn, i ran that isolated test thing, 178 tests in my worker list to comb through :(21:14
mriedemthe bisect analyzer couldn't figure it out21:14
*** archit has joined #openstack-nova21:15
mriedemalthough, i guess the idea is you can continue to wittle the results down with the smaller set of tests each time21:15
*** markvoelker has quit IRC21:17
*** ktibi has quit IRC21:18
openstackgerritMerged openstack/nova master: libvirt: use 'host-passthrough' as default on AArch64  https://review.openstack.org/53096521:23
*** smatzek has quit IRC21:24
*** smatzek has joined #openstack-nova21:24
*** smatzek has quit IRC21:24
*** smatzek has joined #openstack-nova21:24
*** smatzek has quit IRC21:24
*** smatzek has joined #openstack-nova21:25
*** smatzek has quit IRC21:30
openstackgerritMerged openstack/nova master: Use volume shared_targets to lock during attach/detach  https://review.openstack.org/52969521:33
*** armax has joined #openstack-nova21:34
openstackgerritHongbin Lu proposed openstack/nova master: placement: add API reference for create inventory  https://review.openstack.org/51134221:38
*** pcaruana has quit IRC21:38
*** tidwellr has quit IRC21:38
*** tidwellr has joined #openstack-nova21:39
*** slaweq has quit IRC21:39
*** david-lyle has quit IRC21:40
*** dave-mccowan has quit IRC21:40
*** eharney has quit IRC21:41
openstackgerritEd Leafe proposed openstack/nova master: Change compute RPC to use alternates for resize  https://review.openstack.org/52643621:42
edleafemriedem: ^^ addressed your concerns, and then some21:42
*** matrohon has quit IRC21:44
*** threestrands has joined #openstack-nova21:44
*** threestrands has quit IRC21:44
*** threestrands has joined #openstack-nova21:44
*** yamamoto has joined #openstack-nova21:52
*** dillaman has quit IRC21:53
*** yamamoto has quit IRC21:59
*** moshele has joined #openstack-nova21:59
*** AlexeyAbashkin has joined #openstack-nova22:00
*** yamahata has quit IRC22:02
*** moshele has quit IRC22:04
*** AlexeyAbashkin has quit IRC22:05
*** rcernin has joined #openstack-nova22:06
*** belmoreira has quit IRC22:10
openstackgerritMerged openstack/nova stable/pike: doc: Add configuration index page  https://review.openstack.org/53104222:14
*** fragatina has joined #openstack-nova22:15
openstackgerritMerged openstack/nova stable/pike: Fix NoneType error when [service_user] is misconfigured  https://review.openstack.org/52646822:16
openstackgerritMerged openstack/nova stable/pike: Add missing unit tests for FilterScheduler._get_all_host_states  https://review.openstack.org/52962522:26
*** artom_ has joined #openstack-nova22:26
*** markvoelker has joined #openstack-nova22:29
*** artom has quit IRC22:30
*** markvoelker has quit IRC22:30
*** gouthamr has quit IRC22:35
*** priteau has quit IRC22:40
*** penick has quit IRC22:43
openstackgerritmelanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens  https://review.openstack.org/32538122:43
openstackgerritmelanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations  https://review.openstack.org/32541422:43
openstackgerritmelanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation  https://review.openstack.org/33399022:43
*** lyan has quit IRC22:44
*** damien_r has quit IRC22:44
*** itlinux has joined #openstack-nova22:46
*** yamahata has joined #openstack-nova22:48
*** archit has quit IRC22:52
*** gouthamr has joined #openstack-nova22:53
SamYaplewhich scheduler filter is responsible for the cpu overallocation/ratio filtering?22:54
mriedemSamYaple: CoreFilter22:56
openstackgerritMatt Riedemann proposed openstack/nova master: [libvirt] Allow multiple volume attachments  https://review.openstack.org/26758722:56
openstackgerritMatt Riedemann proposed openstack/nova master: Pass multiattach flag to reserve_block_device_name  https://review.openstack.org/53124422:56
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: [api] Allow multi-attach in compute api  https://review.openstack.org/27104722:56
mriedemif you're ocata+, we filter VCPUs in placement when using the FilterScheduler, thus making the CoreFilter not necessary22:56
SamYaplemriedem: was that aroundin mitaka?22:56
*** _pewp_ has quit IRC22:56
mriedemwas what around mitaka?22:56
mriedemplacement was ocata22:56
SamYapleno sorry, itc lag22:57
mriedemCoreFilter has been around awhile yes22:57
SamYaplethe corefilter, thats been around since before mitaka, yes22:57
SamYaplecool22:57
SamYaplesorry just looking at https://github.com/openstack/nova/blob/mitaka-eol/nova/conf/scheduler.py#L12622:57
mriedemyeah the CoreFilter was never a default filter for some reason22:57
*** _pewp_ has joined #openstack-nova22:57
SamYapledidnt see it listed and we were removing the retryfilter and now its overcommitting vcpus22:57
*** moshele has joined #openstack-nova22:57
*** hongbin has quit IRC22:57
SamYaplewe added the corefilter intothe copied list and it started filtering likeit should22:58
SamYaplewas just tryingto trackdown the disconnect22:58
mriedemildikov: a rebase and https://review.openstack.org/#/c/271047/51/nova/tests/unit/api/openstack/compute/test_serversV21.py is as far as i got; was trying to get that libvirt test that was race failing to pass, but couldn't after over an hour22:58
mriedemrechecking the tempest test patch and calling it a day22:59
*** penick has joined #openstack-nova23:00
*** moshele has quit IRC23:00
mriedemdansmith: yes i hacked up that comment pretty bad :)23:00
ildikovmriedem: sounds good enough, thanks!23:00
dansmithmriedem: :P23:00
mriedemwill put a fix on top tomorrow23:00
ildikovmriedem: I will look into it tomorrow too23:01
*** tidwellr has quit IRC23:04
*** sdague has quit IRC23:04
openstackgerritMerged openstack/nova stable/pike: Fix an error in _get_host_states when deleting a compute node  https://review.openstack.org/52962623:09
*** markvoelker has joined #openstack-nova23:11
*** markvoelker has quit IRC23:11
*** stvnoyes has quit IRC23:19
*** AlexeyAbashkin has joined #openstack-nova23:22
*** AlexeyAbashkin has quit IRC23:27
*** kumarmn has joined #openstack-nova23:30
*** takashin has joined #openstack-nova23:31
*** awaugama has quit IRC23:33
*** sdague has joined #openstack-nova23:34
*** gmann has joined #openstack-nova23:35
*** kumarmn has quit IRC23:35
*** oomichi_ has joined #openstack-nova23:39
*** oomichi_ has quit IRC23:42
*** moshele has joined #openstack-nova23:43
*** markvoelker has joined #openstack-nova23:43
*** markvoelker has quit IRC23:43
*** moshele has quit IRC23:49
*** ianw has quit IRC23:50
*** ianw has joined #openstack-nova23:51
*** hshiina has joined #openstack-nova23:52

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!