*** sapd_ has joined #openstack-nova | 00:00 | |
*** _pewp_ has joined #openstack-nova | 00:01 | |
*** namnh has quit IRC | 00:03 | |
*** arvindn05 has joined #openstack-nova | 00:07 | |
*** namnh has joined #openstack-nova | 00:07 | |
*** salv-orlando has joined #openstack-nova | 00:09 | |
*** salv-orlando has quit IRC | 00:13 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 00:16 |
---|---|---|
openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 00:16 |
*** namnh has quit IRC | 00:19 | |
openstackgerrit | melanie witt proposed openstack/nova master: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/340614 | 00:20 |
*** namnh has joined #openstack-nova | 00:20 | |
*** chyka_ has joined #openstack-nova | 00:23 | |
*** namnh has quit IRC | 00:24 | |
*** liverpooler has quit IRC | 00:26 | |
*** chyka has quit IRC | 00:26 | |
*** hiro-kobayashi has joined #openstack-nova | 00:28 | |
*** namnh has joined #openstack-nova | 00:28 | |
*** namnh_ has joined #openstack-nova | 00:32 | |
*** felipemonteiro_ has quit IRC | 00:32 | |
*** namnh_ has quit IRC | 00:32 | |
*** dave-mccowan has quit IRC | 00:32 | |
*** namnh has quit IRC | 00:33 | |
*** yangyapeng has joined #openstack-nova | 00:51 | |
*** sdague has quit IRC | 00:52 | |
*** yangyapeng has quit IRC | 00:55 | |
*** Tom-Tom has joined #openstack-nova | 00:55 | |
*** Dinesh_Bhor has joined #openstack-nova | 00:57 | |
*** andreas_s has joined #openstack-nova | 01:01 | |
*** andreas_s has quit IRC | 01:05 | |
*** tiendc has joined #openstack-nova | 01:07 | |
*** melwitt has quit IRC | 01:10 | |
*** jroll has quit IRC | 01:10 | |
*** jroll has joined #openstack-nova | 01:11 | |
*** zhaochao has joined #openstack-nova | 01:11 | |
*** yangyapeng has joined #openstack-nova | 01:11 | |
*** gyee has quit IRC | 01:11 | |
*** yangyapeng has quit IRC | 01:16 | |
*** hieulq_ has joined #openstack-nova | 01:16 | |
*** yangyapeng has joined #openstack-nova | 01:18 | |
*** hieulq__ has quit IRC | 01:20 | |
*** Dinesh_Bhor has quit IRC | 01:21 | |
*** huanxie has quit IRC | 01:22 | |
*** gjayavelu has quit IRC | 01:22 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Check for leaked server resource allocations in post_test_hook https://review.openstack.org/538510 | 01:24 |
*** chyka_ has quit IRC | 01:28 | |
*** Swami has quit IRC | 01:29 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:29 | |
*** liverpooler has joined #openstack-nova | 01:30 | |
*** Dinesh_Bhor has quit IRC | 01:30 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:30 | |
*** Dinesh_Bhor has quit IRC | 01:33 | |
*** salv-orlando has joined #openstack-nova | 01:33 | |
Spazmotic | Morning Folks | 01:34 |
Spazmotic | Jeez mriedem you still commiting over there | 01:34 |
*** hongbin has joined #openstack-nova | 01:39 | |
*** salv-orlando has quit IRC | 01:39 | |
*** felipemonteiro_ has joined #openstack-nova | 01:40 | |
*** pramodrj07 has quit IRC | 01:43 | |
*** namnh has joined #openstack-nova | 01:43 | |
*** slaweq_ has joined #openstack-nova | 01:54 | |
*** melwitt has joined #openstack-nova | 01:56 | |
*** melwitt is now known as Guest94306 | 01:56 | |
*** Guest94306 is now known as jgwentworth | 01:58 | |
Spazmotic | no no no no | 01:58 |
Spazmotic | IF YOU HAVE A STRUCTURED SETTLEMENT BUT YOU NEED CASH NOWWWW | 01:59 |
*** slaweq_ has quit IRC | 01:59 | |
jgwentworth | 877 cash now | 01:59 |
Spazmotic | Why would you do that to people, core reviewers should have mortal fortitude! | 01:59 |
jgwentworth | heh | 02:00 |
*** jgwentworth is now known as melwitt | 02:01 | |
*** gcb has joined #openstack-nova | 02:04 | |
*** yamamoto has joined #openstack-nova | 02:05 | |
*** efried_hexchat has quit IRC | 02:06 | |
Spazmotic | melwitt, Any chance you're familiar with the XenAPI drivers? :) | 02:09 |
*** harlowja has quit IRC | 02:10 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:11 | |
*** pramodrj07 has joined #openstack-nova | 02:17 | |
*** moshele has joined #openstack-nova | 02:18 | |
*** pramodrj07 has quit IRC | 02:18 | |
*** felipemonteiro_ has quit IRC | 02:18 | |
*** pramodrj07 has joined #openstack-nova | 02:18 | |
*** Dinesh_Bhor has quit IRC | 02:18 | |
*** efried_hexchat has joined #openstack-nova | 02:19 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:20 | |
*** huanxie has joined #openstack-nova | 02:27 | |
*** slaweq_ has joined #openstack-nova | 02:29 | |
*** Pramod has joined #openstack-nova | 02:31 | |
*** pramodrj07 has quit IRC | 02:31 | |
*** Dinesh_Bhor has quit IRC | 02:34 | |
*** slaweq_ has quit IRC | 02:34 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:36 | |
*** Pramod has quit IRC | 02:37 | |
*** Pramod has joined #openstack-nova | 02:37 | |
*** Dinesh_Bhor has quit IRC | 02:39 | |
*** Pramod has quit IRC | 02:39 | |
*** pramodrj07 has joined #openstack-nova | 02:39 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:40 | |
*** Dinesh_Bhor has quit IRC | 02:46 | |
*** vladikr has quit IRC | 02:46 | |
*** hongbin has quit IRC | 02:46 | |
*** yamamoto_ has joined #openstack-nova | 02:47 | |
*** vladikr has joined #openstack-nova | 02:47 | |
*** hongbin has joined #openstack-nova | 02:47 | |
*** rmcall has joined #openstack-nova | 02:49 | |
*** yamamoto has quit IRC | 02:50 | |
*** edmondsw has joined #openstack-nova | 02:54 | |
*** flwang has quit IRC | 02:55 | |
*** vladikr has quit IRC | 02:55 | |
*** vladikr has joined #openstack-nova | 02:55 | |
*** dave-mccowan has joined #openstack-nova | 02:58 | |
*** edmondsw has quit IRC | 02:58 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:59 | |
*** zhurong has joined #openstack-nova | 03:03 | |
*** yamahata has quit IRC | 03:05 | |
*** armax has quit IRC | 03:08 | |
*** moshele has quit IRC | 03:12 | |
*** hiro-kobayashi has quit IRC | 03:18 | |
*** psachin has joined #openstack-nova | 03:25 | |
*** moshele has joined #openstack-nova | 03:31 | |
*** salv-orlando has joined #openstack-nova | 03:36 | |
*** yamamoto has joined #openstack-nova | 03:36 | |
*** slaweq_ has joined #openstack-nova | 03:37 | |
*** yamamoto_ has quit IRC | 03:39 | |
*** fragatina has quit IRC | 03:41 | |
*** salv-orlando has quit IRC | 03:41 | |
*** slaweq_ has quit IRC | 03:42 | |
*** hongbin has quit IRC | 03:44 | |
*** vladikr has quit IRC | 03:46 | |
*** vladikr has joined #openstack-nova | 03:47 | |
*** yamahata has joined #openstack-nova | 03:47 | |
*** Tom-Tom has quit IRC | 03:49 | |
*** fragatina has joined #openstack-nova | 03:49 | |
*** hoangcx has quit IRC | 03:50 | |
*** hoangcx has joined #openstack-nova | 03:50 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add the nova-multiattach job https://review.openstack.org/532689 | 03:51 |
*** tovin07 has quit IRC | 03:51 | |
*** dave-mccowan has quit IRC | 03:52 | |
*** tovin07 has joined #openstack-nova | 03:52 | |
*** fragatina has quit IRC | 03:53 | |
*** vladikr has quit IRC | 03:53 | |
*** moshele has quit IRC | 03:56 | |
*** abhishekk has joined #openstack-nova | 03:57 | |
*** slaweq_ has joined #openstack-nova | 03:58 | |
*** slaweq_ has quit IRC | 04:03 | |
*** Tom-Tom has joined #openstack-nova | 04:04 | |
*** sree has joined #openstack-nova | 04:04 | |
*** zhurong has quit IRC | 04:05 | |
*** Tom-Tom has quit IRC | 04:08 | |
openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: add Linux distribution guest only description for inject_xxx options https://review.openstack.org/528441 | 04:09 |
*** mylu has quit IRC | 04:09 | |
*** links has joined #openstack-nova | 04:10 | |
*** harlowja has joined #openstack-nova | 04:21 | |
*** mylu has joined #openstack-nova | 04:21 | |
*** mattoliverau has joined #openstack-nova | 04:23 | |
*** armax has joined #openstack-nova | 04:24 | |
mattoliverau | Hey nova cores. I have a doc patch I've pushed upstream to fix the nova placement-api port on OpenSuse/SLES which was incorrect. It' | 04:25 |
mattoliverau | It's been sitting there since december last year. So thought I'd do a ping here ;) | 04:25 |
mattoliverau | Only doc, so an easy review ;) | 04:26 |
mattoliverau | https://review.openstack.org/#/c/527846 | 04:26 |
*** harlowja has quit IRC | 04:26 | |
*** harlowja has joined #openstack-nova | 04:26 | |
*** harlowja has quit IRC | 04:27 | |
*** armax has quit IRC | 04:28 | |
*** gjayavelu has joined #openstack-nova | 04:29 | |
*** armax has joined #openstack-nova | 04:35 | |
*** salv-orlando has joined #openstack-nova | 04:37 | |
*** gjayavelu has quit IRC | 04:39 | |
*** salv-orlando has quit IRC | 04:42 | |
*** edmondsw has joined #openstack-nova | 04:42 | |
*** tssurya_ has joined #openstack-nova | 04:43 | |
*** andreas_s has joined #openstack-nova | 04:45 | |
*** edmondsw has quit IRC | 04:46 | |
*** moshele has joined #openstack-nova | 04:46 | |
*** tssurya_ has quit IRC | 04:47 | |
*** andreas_s has quit IRC | 04:49 | |
*** Dinesh_Bhor has quit IRC | 04:54 | |
*** Dinesh_Bhor has joined #openstack-nova | 04:57 | |
*** Dinesh_Bhor has quit IRC | 05:01 | |
*** Dinesh_Bhor has joined #openstack-nova | 05:03 | |
*** armax has quit IRC | 05:05 | |
*** mylu_ has joined #openstack-nova | 05:06 | |
*** Tom-Tom has joined #openstack-nova | 05:06 | |
*** armax has joined #openstack-nova | 05:06 | |
*** mylu has quit IRC | 05:08 | |
*** slaweq_ has joined #openstack-nova | 05:12 | |
*** ratailor has joined #openstack-nova | 05:13 | |
*** slaweq_ has quit IRC | 05:16 | |
mattoliverau | oh right, cool, there is another patch doing the same thing :) Nice. So long as it get's fixed then my employer will be happy, ta.. | 05:23 |
*** sridharg has joined #openstack-nova | 05:30 | |
*** pramodrj07 has quit IRC | 05:32 | |
*** pramodrj07 has joined #openstack-nova | 05:33 | |
*** gjayavelu has joined #openstack-nova | 05:33 | |
*** salv-orlando has joined #openstack-nova | 05:38 | |
*** fragatina has joined #openstack-nova | 05:39 | |
*** fragatin_ has joined #openstack-nova | 05:40 | |
*** mdnadeem has joined #openstack-nova | 05:40 | |
*** rmcall has quit IRC | 05:41 | |
*** zhurong has joined #openstack-nova | 05:42 | |
*** salv-orlando has quit IRC | 05:43 | |
*** fragatina has quit IRC | 05:43 | |
*** Pramod has joined #openstack-nova | 05:49 | |
*** esberglu_ has joined #openstack-nova | 05:51 | |
*** pramodrj07 has quit IRC | 05:52 | |
*** esberglu has quit IRC | 05:55 | |
*** salv-orlando has joined #openstack-nova | 05:59 | |
*** Dinesh_Bhor has quit IRC | 05:59 | |
*** slaweq has quit IRC | 06:00 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:00 | |
*** jappleii__ has quit IRC | 06:01 | |
*** trozet has quit IRC | 06:07 | |
*** Dinesh_Bhor has quit IRC | 06:08 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:11 | |
*** mylu_ has quit IRC | 06:16 | |
*** slaweq has joined #openstack-nova | 06:16 | |
*** slaweq_ has joined #openstack-nova | 06:17 | |
*** jaosorior has joined #openstack-nova | 06:21 | |
*** slaweq_ has quit IRC | 06:21 | |
*** slaweq has quit IRC | 06:21 | |
*** fragatin_ has quit IRC | 06:22 | |
*** Dinesh_Bhor has quit IRC | 06:24 | |
*** slaweq has joined #openstack-nova | 06:24 | |
*** edmondsw has joined #openstack-nova | 06:30 | |
*** janki has joined #openstack-nova | 06:31 | |
*** slaweq has quit IRC | 06:31 | |
*** AlexeyAbashkin has joined #openstack-nova | 06:33 | |
*** edmondsw has quit IRC | 06:34 | |
*** AlexeyAbashkin has quit IRC | 06:37 | |
*** Eran_Kuris has joined #openstack-nova | 06:40 | |
*** yamamoto_ has joined #openstack-nova | 06:43 | |
*** Dinesh_Bhor has joined #openstack-nova | 06:43 | |
*** fnordahl has quit IRC | 06:44 | |
*** fnordahl has joined #openstack-nova | 06:46 | |
*** yamamoto has quit IRC | 06:46 | |
*** Pramod has quit IRC | 06:48 | |
ratailor | Can anyone please review this https://review.openstack.org/#/c/530879/ | 06:48 |
ameeda | is this error caused by me ? "http://logs.openstack.org/00/526900/26/check/openstack-tox-functional/c777a93/testr_results.html.gz" | 06:49 |
ameeda | from this gerrit "https://review.openstack.org/#/c/526900/" | 06:49 |
ameeda | error "http://logs.openstack.org/14/340614/12/check/nova-tox-functional/1cd661e/testr_results.html.gz" | 06:49 |
*** esberglu has joined #openstack-nova | 06:55 | |
*** esberglu_ has quit IRC | 06:57 | |
*** zhurong has quit IRC | 06:58 | |
*** hiro-kobayashi has joined #openstack-nova | 06:59 | |
*** zhurong has joined #openstack-nova | 07:02 | |
*** wolsen has quit IRC | 07:09 | |
*** pcaruana has joined #openstack-nova | 07:10 | |
*** wolsen has joined #openstack-nova | 07:11 | |
*** andreas_s has joined #openstack-nova | 07:17 | |
openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | 07:23 |
*** annp has joined #openstack-nova | 07:27 | |
*** janki is now known as janki-afk | 07:30 | |
openstackgerrit | Chen Hanxiao proposed openstack/nova master: libvirt: remove TODO on validation of scsi model https://review.openstack.org/525055 | 07:30 |
*** sticker has joined #openstack-nova | 07:33 | |
*** salv-orlando has quit IRC | 07:36 | |
*** salv-orlando has joined #openstack-nova | 07:36 | |
*** janki-afk is now known as janki | 07:36 | |
*** slaweq has joined #openstack-nova | 07:39 | |
*** ragiman has joined #openstack-nova | 07:40 | |
*** salv-orlando has quit IRC | 07:41 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:41 | |
*** armax has quit IRC | 07:41 | |
sticker | Has anyone reported issues with virtlogd recreating the console.log as root:root during migration or resize when append="off" is set in the dom xml (kvm) | 07:42 |
sticker | when using KVM > 2.7.0 | 07:42 |
*** slaweq has quit IRC | 07:44 | |
*** AlexeyAbashkin has quit IRC | 07:46 | |
*** alexchadin has joined #openstack-nova | 07:49 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:50 | |
*** slaweq has joined #openstack-nova | 07:54 | |
*** sahid has joined #openstack-nova | 07:57 | |
*** slaweq has quit IRC | 07:58 | |
*** salv-orlando has joined #openstack-nova | 07:59 | |
*** josecastroleon has joined #openstack-nova | 08:00 | |
*** lajoskatona has joined #openstack-nova | 08:02 | |
*** gjayavelu has quit IRC | 08:04 | |
*** Dinesh_Bhor has quit IRC | 08:05 | |
*** tetsuro has joined #openstack-nova | 08:10 | |
tetsuro | #openstack-nova | 08:10 |
*** slaweq has joined #openstack-nova | 08:11 | |
*** damien_r has joined #openstack-nova | 08:15 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:16 | |
*** stakeda has quit IRC | 08:16 | |
*** tesseract has joined #openstack-nova | 08:17 | |
*** Dinesh_Bhor has quit IRC | 08:18 | |
*** edmondsw has joined #openstack-nova | 08:18 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:19 | |
*** Dinesh_Bhor has quit IRC | 08:19 | |
*** edmondsw has quit IRC | 08:23 | |
*** yasemin has quit IRC | 08:24 | |
*** ralonsoh has joined #openstack-nova | 08:25 | |
*** slaweq_ has joined #openstack-nova | 08:28 | |
*** ttsiouts has quit IRC | 08:29 | |
*** bkopilov has joined #openstack-nova | 08:29 | |
*** ttsiouts has joined #openstack-nova | 08:30 | |
*** slaweq_ has quit IRC | 08:32 | |
*** AlexeyAbashkin has quit IRC | 08:35 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:36 | |
*** yasemin has joined #openstack-nova | 08:37 | |
*** Dinesh_Bhor has quit IRC | 08:38 | |
*** AlexeyAbashkin has joined #openstack-nova | 08:38 | |
*** aloga has quit IRC | 08:40 | |
*** aloga has joined #openstack-nova | 08:40 | |
*** AlexeyAbashkin has quit IRC | 08:41 | |
*** AlexeyAbashkin has joined #openstack-nova | 08:42 | |
*** dklyle has joined #openstack-nova | 08:43 | |
*** david-lyle has quit IRC | 08:44 | |
*** Dinesh_Bhor has joined #openstack-nova | 08:45 | |
openstackgerrit | sahid proposed openstack/nova-specs master: update: introducing isolate emulthreads on host https://review.openstack.org/511188 | 08:48 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reproduce bug 1724172 in the functional test env https://review.openstack.org/512553 | 08:49 |
openstack | bug 1724172 in OpenStack Compute (nova) "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Undecided,In progress] https://launchpad.net/bugs/1724172 - Assigned to Balazs Gibizer (balazs-gibizer) | 08:49 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: cleanup evacuated instances not on hypervisor https://review.openstack.org/512623 | 08:49 |
*** yasemin has quit IRC | 08:50 | |
*** andreas_s has quit IRC | 08:50 | |
*** lennyb has quit IRC | 08:50 | |
*** andreas_s has joined #openstack-nova | 08:50 | |
*** jpena|off is now known as jpena | 08:50 | |
openstackgerrit | sahid proposed openstack/nova-specs master: virt: allow instances to be booted with trusted VFs https://review.openstack.org/485522 | 08:53 |
*** Dinesh_Bhor has quit IRC | 08:58 | |
*** priteau has joined #openstack-nova | 08:59 | |
*** slaweq_ has joined #openstack-nova | 09:00 | |
*** vivsoni has quit IRC | 09:00 | |
*** vivsoni_ has joined #openstack-nova | 09:00 | |
*** Dinesh_Bhor has joined #openstack-nova | 09:01 | |
*** damien_r has quit IRC | 09:02 | |
lyarwood | morning all | 09:03 |
*** amoralej|off is now known as amoralej | 09:04 | |
*** Dinesh_Bhor has quit IRC | 09:04 | |
*** slaweq_ has quit IRC | 09:04 | |
*** Dinesh_Bhor has joined #openstack-nova | 09:05 | |
*** damien_r has joined #openstack-nova | 09:07 | |
*** yamahata has quit IRC | 09:08 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: reno for notification-transformation-queens https://review.openstack.org/518018 | 09:14 |
*** salv-orlando has quit IRC | 09:17 | |
*** salv-orlando has joined #openstack-nova | 09:18 | |
*** salv-orlando has quit IRC | 09:23 | |
openstackgerrit | Alex Xu proposed openstack/nova master: Add server filters whitelist in server api-ref https://review.openstack.org/527042 | 09:24 |
*** mvk has quit IRC | 09:29 | |
*** janki has quit IRC | 09:30 | |
*** janki has joined #openstack-nova | 09:30 | |
*** andreas_s_ has joined #openstack-nova | 09:31 | |
*** lennyb has joined #openstack-nova | 09:34 | |
*** Dinesh_Bhor has quit IRC | 09:35 | |
*** andreas_s has quit IRC | 09:35 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: [WIP] Fix a bug https://review.openstack.org/539164 | 09:37 |
*** mgoddard_ has joined #openstack-nova | 09:38 | |
Spazmotic | gibi I heard rumor that you were decent with some XenAPI, If true you mind if I add you to a review to check out for me that has been looking for some cores for a couple weeks? | 09:40 |
gibi | Spazmotic: those rumors seems to be pretty off. Anyhow you can add me as reviewer but I cannot promis I will be able to get to it soon | 09:41 |
Spazmotic | Hehe as rumors go | 09:41 |
*** derekh has joined #openstack-nova | 09:42 | |
Spazmotic | I'll let it sit as it is now, sounds like you're pretty busy, so will just hope a reviewer gets to it in a ntural way :) | 09:42 |
*** takashin has left #openstack-nova | 09:44 | |
*** hiro-kobayashi has quit IRC | 09:45 | |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Integrate Mypy Type Checking https://review.openstack.org/538217 | 09:49 |
bauzas | huh, 18 hours from the top change to be merged in the gate | 09:49 |
bauzas | that's going to be a long long day | 09:50 |
Spazmotic | yikes | 09:50 |
Spazmotic | Gate still bogged down after the zuul restart? | 09:50 |
bauzas | huge delay at least | 09:50 |
*** itlinux has joined #openstack-nova | 09:50 | |
*** hoangcx has quit IRC | 09:51 | |
*** namnh has quit IRC | 09:51 | |
Spazmotic | Welp.. time for my morning begging session again. Will throw out this review if anyone gets some free cycles to look at it. https://review.openstack.org/#/c/533168/ | 09:51 |
Spazmotic | And imma go drink some coffee :) | 09:51 |
*** hoangcx has joined #openstack-nova | 09:51 | |
*** namnh has joined #openstack-nova | 09:51 | |
bauzas | well, looks like it's just a delay problem AFAICT http://status.openstack.org/openstack-health/#/ | 09:52 |
*** mvk has joined #openstack-nova | 09:58 | |
*** josecastroleon has quit IRC | 09:58 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Invalid query parameter could lead to HTTP 500 https://review.openstack.org/539164 | 09:59 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Add 'mypy' job https://review.openstack.org/539168 | 10:00 |
*** sambetts|afk is now known as sambetts | 10:01 | |
*** zhurong has quit IRC | 10:02 | |
*** itlinux has quit IRC | 10:02 | |
bauzas | Spazmotic: stupid question but does the XenServer CI covers your change ? https://review.openstack.org/#/c/533168/ | 10:02 |
mgoddard_ | alex_xu: hi, is there documentation for usage of traits as flavor extra specs? https://review.openstack.org/#/c/536085/9 | 10:05 |
*** edmondsw has joined #openstack-nova | 10:06 | |
*** itlinux has joined #openstack-nova | 10:07 | |
*** yamamoto has joined #openstack-nova | 10:08 | |
bauzas | mgoddard_: for the moment, see the relnote https://review.openstack.org/#/c/536085/9/releasenotes/notes/request-traits-in-nova-ffcb00f76229b6e9.yaml | 10:09 |
bauzas | some nova documentation could be made I agree | 10:09 |
*** edmondsw has quit IRC | 10:10 | |
*** kevinz has quit IRC | 10:10 | |
mgoddard_ | bauzas: that would be nice. I can't see anything about custom resource classes on flavors either. | 10:11 |
*** yamamoto_ has quit IRC | 10:11 | |
*** lpetrut has joined #openstack-nova | 10:12 | |
mgoddard_ | bauzas: something in here: https://docs.openstack.org/nova/latest/user/flavors.html? | 10:12 |
*** yamamoto has quit IRC | 10:12 | |
*** edmondsw has joined #openstack-nova | 10:12 | |
*** edmondsw has quit IRC | 10:12 | |
Spazmotic | sorry bauzas was grabbing coffee | 10:13 |
bauzas | Spazmotic: no excuses. | 10:14 |
Spazmotic | hehehehe | 10:14 |
Spazmotic | I was looking through the CIs tests the other day actaully i'm not too sure, it should if it has the standard suite with moving multiple volumes | 10:14 |
*** yamamoto has joined #openstack-nova | 10:14 | |
*** yamamoto has quit IRC | 10:14 | |
*** ratailor_ has joined #openstack-nova | 10:15 | |
bauzas | mgoddard_: we generally document in https://docs.openstack.org/nova/latest/user/placement.html for end-user and operator concerns | 10:15 |
*** ratailor has quit IRC | 10:17 | |
Spazmotic | alrhough the tests would be under the compute stuff, so i'm looking now at its tempest set | 10:18 |
mgoddard_ | bauzas: flavors don't exist in placement, do they? | 10:20 |
bauzas | mgoddard_: no, they don't, you're right | 10:20 |
mgoddard_ | ok, well thanks bauzas | 10:21 |
bauzas | mgoddard_: we just use flavors as a way to notify which specific resource classes and traits a user asks | 10:21 |
bauzas | in order to keep the Nova API stable | 10:22 |
bauzas | that's translated into traits and resource classes queries by the scheduler which calls out the Placement API | 10:22 |
Spazmotic | bauzas - Think it's a no. There are only like 3 migration tests in this suite | 10:23 |
Spazmotic | and are just tests for the cold migrate feature | 10:25 |
*** damien_r has quit IRC | 10:25 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't filter out sibling sets with one core https://review.openstack.org/537361 | 10:28 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure emulator threads are always calculated https://review.openstack.org/537363 | 10:28 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Always pass 'NUMACell.siblings' to _pack_instance_onto_cores' https://review.openstack.org/537364 | 10:28 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivialfix: cleanup _pack_instance_onto_cores() https://review.openstack.org/538698 | 10:28 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add unit tests for EmulatorThreadsTestCase https://review.openstack.org/538699 | 10:28 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Not use thread alloc policy for emulator thread https://review.openstack.org/538700 | 10:28 |
*** Tom-Tom has quit IRC | 10:28 | |
*** tssurya_ has joined #openstack-nova | 10:28 | |
*** sdague has joined #openstack-nova | 10:28 | |
*** sree has quit IRC | 10:29 | |
*** alexchadin has quit IRC | 10:30 | |
*** salv-orlando has joined #openstack-nova | 10:31 | |
*** damien_r has joined #openstack-nova | 10:31 | |
*** alexchadin has joined #openstack-nova | 10:31 | |
*** dave-mccowan has joined #openstack-nova | 10:32 | |
*** andreas_s has joined #openstack-nova | 10:33 | |
*** tssurya_ has quit IRC | 10:33 | |
*** bhagyashri_s has joined #openstack-nova | 10:34 | |
*** pooja-jadhav has joined #openstack-nova | 10:34 | |
*** andreas_s_ has quit IRC | 10:36 | |
*** pooja_jadhav has quit IRC | 10:37 | |
*** bhagyashris has quit IRC | 10:37 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 10:37 |
*** mvk has quit IRC | 10:39 | |
Spazmotic | thanks bauzas :D | 10:39 |
bauzas | Spazmotic: not a firm -1, just general advice for maintenability | 10:39 |
bauzas | I need to disappear now | 10:39 |
Spazmotic | Understandable, i'll get it fixed soon | 10:39 |
bauzas | cool | 10:40 |
*** lucas-afk is now known as lucasagomes | 10:41 | |
*** itlinux has quit IRC | 10:41 | |
Spazmotic | super appreciate it and great advice, thanks again bauzas. Doesn't sound harsh at all, great ideas. | 10:43 |
Spazmotic | Enjoy your disappearing | 10:44 |
*** itlinux has joined #openstack-nova | 10:46 | |
*** itlinux has quit IRC | 10:46 | |
*** alexchadin has quit IRC | 10:47 | |
*** mgoddard_ has quit IRC | 10:47 | |
*** slaweq_ has joined #openstack-nova | 10:48 | |
*** alexchadin has joined #openstack-nova | 10:49 | |
*** ratailor__ has joined #openstack-nova | 10:50 | |
*** AlexeyAbashkin has quit IRC | 10:50 | |
*** AlexeyAbashkin has joined #openstack-nova | 10:51 | |
*** mvk has joined #openstack-nova | 10:51 | |
*** ratailor_ has quit IRC | 10:52 | |
*** slaweq_ has quit IRC | 10:52 | |
*** slaweq_ has joined #openstack-nova | 10:54 | |
*** andreas_s_ has joined #openstack-nova | 10:55 | |
*** AlexeyAbashkin has quit IRC | 10:56 | |
*** andreas_s has quit IRC | 10:58 | |
*** yamamoto has joined #openstack-nova | 10:59 | |
*** abhishekk has quit IRC | 11:00 | |
*** slaweq_ has quit IRC | 11:02 | |
*** alexchadin has quit IRC | 11:02 | |
*** alexchadin has joined #openstack-nova | 11:03 | |
*** Tom-Tom has joined #openstack-nova | 11:03 | |
*** alexchadin has quit IRC | 11:03 | |
*** alexchadin has joined #openstack-nova | 11:03 | |
*** alexchadin has quit IRC | 11:04 | |
*** yamamoto has quit IRC | 11:04 | |
*** alexchadin has joined #openstack-nova | 11:04 | |
*** yamamoto has joined #openstack-nova | 11:04 | |
*** alexchadin has quit IRC | 11:04 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: VGPU: Modify the example of vgpu white_list set https://review.openstack.org/539183 | 11:05 |
*** namnh has quit IRC | 11:05 | |
*** alexchadin has joined #openstack-nova | 11:05 | |
*** alexchadin has quit IRC | 11:05 | |
*** alexchadin has joined #openstack-nova | 11:06 | |
*** damien_r has quit IRC | 11:06 | |
*** alexchadin has quit IRC | 11:06 | |
*** Tom-Tom has quit IRC | 11:07 | |
*** bkopilov has quit IRC | 11:08 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_vcpu_realtime_scheduler() https://review.openstack.org/527630 | 11:18 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_numa_memnode() https://review.openstack.org/529906 | 11:18 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631 | 11:18 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451 | 11:18 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049 | 11:18 |
*** jangutter has joined #openstack-nova | 11:19 | |
*** andreas_s_ has quit IRC | 11:19 | |
*** andreas_s has joined #openstack-nova | 11:20 | |
*** mvenesio has joined #openstack-nova | 11:20 | |
*** AlexeyAbashkin has joined #openstack-nova | 11:22 | |
*** trozet has joined #openstack-nova | 11:31 | |
*** salv-orlando has quit IRC | 11:32 | |
*** salv-orlando has joined #openstack-nova | 11:32 | |
*** Nil_ has quit IRC | 11:33 | |
*** yamamoto has quit IRC | 11:36 | |
*** salv-orlando has quit IRC | 11:37 | |
*** damien_r has joined #openstack-nova | 11:37 | |
*** damien_r has quit IRC | 11:38 | |
*** chyka has joined #openstack-nova | 11:40 | |
*** chyka has quit IRC | 11:45 | |
*** yamamoto has joined #openstack-nova | 11:46 | |
*** andreas_s has quit IRC | 11:47 | |
*** andreas_s has joined #openstack-nova | 11:47 | |
*** tbachman has quit IRC | 11:47 | |
*** Guest587 has quit IRC | 11:47 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Filter hypervisor_type by virt_type https://review.openstack.org/531347 | 11:48 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Fix hypervisor_type in /os-hypervisors/details https://review.openstack.org/531328 | 11:48 |
*** alexchadin has joined #openstack-nova | 11:49 | |
*** yamamoto has quit IRC | 11:51 | |
*** AlexeyAbashkin has quit IRC | 11:51 | |
*** AlexeyAbashkin has joined #openstack-nova | 11:52 | |
*** kevzha01 has joined #openstack-nova | 11:53 | |
*** itlinux has joined #openstack-nova | 11:54 | |
*** tiendc has quit IRC | 11:57 | |
*** tetsuro has left #openstack-nova | 11:59 | |
*** damien_r has joined #openstack-nova | 12:00 | |
*** itlinux has quit IRC | 12:00 | |
*** itlinux has joined #openstack-nova | 12:01 | |
*** sticker has quit IRC | 12:06 | |
*** gszasz has joined #openstack-nova | 12:08 | |
*** yasemin has joined #openstack-nova | 12:08 | |
*** edmondsw has joined #openstack-nova | 12:08 | |
*** yamamoto has joined #openstack-nova | 12:10 | |
*** zhurong has joined #openstack-nova | 12:13 | |
*** yamamoto has quit IRC | 12:14 | |
*** alexchadin has quit IRC | 12:17 | |
*** itlinux has quit IRC | 12:18 | |
*** alexchadin has joined #openstack-nova | 12:18 | |
*** itlinux has joined #openstack-nova | 12:19 | |
*** ratailor__ has quit IRC | 12:19 | |
*** sree has joined #openstack-nova | 12:19 | |
*** cdent has joined #openstack-nova | 12:21 | |
*** alexchadin has quit IRC | 12:22 | |
*** alexchadin has joined #openstack-nova | 12:22 | |
*** bkopilov has joined #openstack-nova | 12:25 | |
*** itlinux has quit IRC | 12:26 | |
*** liusheng has joined #openstack-nova | 12:26 | |
gibi | seem that the novnc package is broken on the gate: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Unable%20to%20correct%20problems%2C%20you%20have%20held%20broken%20packages%3A%5C%22 | 12:27 |
gibi | http://logs.openstack.org/53/512553/5/check/tempest-full/ac042d5/job-output.txt.gz#_2018-01-30_09_50_23_127790 | 12:27 |
gibi | infra knows about the problem | 12:28 |
*** Tom-Tom has joined #openstack-nova | 12:31 | |
cdent | infra is the all seeing eye | 12:32 |
*** damien_r has quit IRC | 12:34 | |
*** vladikr has joined #openstack-nova | 12:34 | |
*** damien_r has joined #openstack-nova | 12:35 | |
*** yamamoto has joined #openstack-nova | 12:35 | |
*** liusheng has quit IRC | 12:36 | |
*** liusheng has joined #openstack-nova | 12:36 | |
*** tbachman has joined #openstack-nova | 12:37 | |
*** tbachman has quit IRC | 12:40 | |
*** yamamoto_ has joined #openstack-nova | 12:40 | |
*** yamamoto_ has quit IRC | 12:43 | |
*** yamamoto has quit IRC | 12:43 | |
*** jpena is now known as jpena|lunch | 12:45 | |
*** janki has quit IRC | 12:46 | |
*** tobasco has quit IRC | 12:49 | |
*** links has quit IRC | 12:49 | |
*** edmondsw_ has joined #openstack-nova | 12:49 | |
*** tobasco has joined #openstack-nova | 12:50 | |
*** edmondsw has quit IRC | 12:51 | |
*** salv-orlando has joined #openstack-nova | 12:52 | |
*** gcb has quit IRC | 12:56 | |
*** slaweq_ has joined #openstack-nova | 12:58 | |
*** edmondsw_ has quit IRC | 12:58 | |
*** edmondsw has joined #openstack-nova | 13:00 | |
*** jaypipes has joined #openstack-nova | 13:03 | |
*** zhurong_ has joined #openstack-nova | 13:03 | |
*** Tom-Tom has quit IRC | 13:04 | |
*** slaweq_ has quit IRC | 13:05 | |
jaypipes | good morning supernovas | 13:06 |
*** sree has quit IRC | 13:08 | |
jaypipes | stephenfin: mornin, mate. | 13:09 |
gibi | jaypipes: good morning | 13:10 |
jaypipes | stephenfin: I'm presuming the many failures in functional test jobs in https://review.openstack.org/#/c/537361/ are actually not related to that patch.. | 13:10 |
jaypipes | gibi: mornin :) | 13:10 |
*** salv-orl_ has joined #openstack-nova | 13:13 | |
*** tbachman has joined #openstack-nova | 13:15 | |
*** salv-orlando has quit IRC | 13:16 | |
*** zhurong has quit IRC | 13:17 | |
gibi | jaypipes: the failures in ^^ are caused by a broken package: http://logs.openstack.org/61/537361/4/check/tempest-full/13f575b/job-output.txt.gz#_2018-01-30_11_20_19_108323 | 13:18 |
*** hemna_ has joined #openstack-nova | 13:18 | |
*** zhurong_ has quit IRC | 13:19 | |
*** zhurong has joined #openstack-nova | 13:19 | |
*** Guest587 has joined #openstack-nova | 13:20 | |
gibi | jaypipes: infra knows about it http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2018-01-30.log.html#t2018-01-30T12:36:43 | 13:20 |
*** zhurong has quit IRC | 13:20 | |
jaypipes | gibi: got it. thank you sir. | 13:20 |
*** alexchadin has quit IRC | 13:21 | |
*** Guest587 has quit IRC | 13:27 | |
*** yassine has joined #openstack-nova | 13:27 | |
*** yassine is now known as Guest59729 | 13:27 | |
*** amoralej is now known as amoralej|lunch | 13:28 | |
*** yangyapeng has quit IRC | 13:30 | |
*** yangyapeng has joined #openstack-nova | 13:30 | |
stephenfin | jaypipes: That would sounds correct, yes | 13:31 |
*** weshay|ruck|afk is now known as weshay|ruck | 13:31 | |
stephenfin | Wow, the gate is not happy | 13:31 |
stephenfin | jaypipes: Thanks for reviewing those too (y) | 13:33 |
*** moshele has quit IRC | 13:34 | |
*** sree has joined #openstack-nova | 13:35 | |
*** yangyapeng has quit IRC | 13:35 | |
*** dave-mccowan has quit IRC | 13:37 | |
*** slaweq has quit IRC | 13:37 | |
*** slaweq has joined #openstack-nova | 13:38 | |
jaypipes | stephenfin: no problemo. | 13:39 |
*** izombie has joined #openstack-nova | 13:39 | |
*** kevzha01 has quit IRC | 13:41 | |
*** sree has quit IRC | 13:41 | |
-openstackstatus- NOTICE: Our ubuntu-xenial images (used for e.g. unit tests and devstack) are currently failing to install any packages, restrain from *recheck* or *approve* until the issue has been investigated and fixed. | 13:43 | |
*** links has joined #openstack-nova | 13:43 | |
*** yamamoto has joined #openstack-nova | 13:44 | |
*** READ10 has joined #openstack-nova | 13:45 | |
*** jpena|lunch is now known as jpena | 13:46 | |
izombie | does running nova from virtual environment needs extra steps? few services aren't starting because nova-rootwrap is in virtualenv scope. | 13:46 |
Spazmotic | bauzas, was relaxing on the couch with the fiancee and think I realized what you wanted in your comments.. very elegant if my mind is correct here.. will commit it within the next few hours. | 13:47 |
*** yamamoto has quit IRC | 13:49 | |
*** janki has joined #openstack-nova | 13:49 | |
Spazmotic | I'm concerned with utilizing the current iS_booted method but i definately do understand the desire not to double up on methodws. My plans was to follow the commitg with a deprecation of that and use the new one.. but instead can just change its name | 13:51 |
*** alexchadin has joined #openstack-nova | 13:52 | |
*** Tom-Tom has joined #openstack-nova | 13:52 | |
*** alexchadin has quit IRC | 13:55 | |
*** izombie has quit IRC | 13:55 | |
*** alexchadin has joined #openstack-nova | 13:56 | |
*** psachin has quit IRC | 13:57 | |
*** brault has quit IRC | 13:57 | |
*** brault has joined #openstack-nova | 13:57 | |
*** sree has joined #openstack-nova | 13:58 | |
*** mlavalle has joined #openstack-nova | 13:59 | |
*** rgerganov has joined #openstack-nova | 14:00 | |
*** alexchadin has quit IRC | 14:00 | |
*** yangyapeng has joined #openstack-nova | 14:01 | |
*** diga has joined #openstack-nova | 14:01 | |
*** brault has quit IRC | 14:02 | |
*** sree_ has joined #openstack-nova | 14:02 | |
*** sree_ is now known as Guest41574 | 14:03 | |
*** rmcall has joined #openstack-nova | 14:03 | |
*** sree has quit IRC | 14:05 | |
ameeda | jaypipes: can you please check this https://review.openstack.org/#/c/526900/, it has a lot of zuul failures , I think that is something wrong with zuul ? | 14:06 |
*** abhishekk has joined #openstack-nova | 14:06 | |
bauzas | Spazmotic: okay, no worries | 14:07 |
Spazmotic | exciting, I love your logic.. wanna go steady? :p | 14:07 |
gibi | ameeda: gate is broken | 14:07 |
gibi | ameeda: infra is working on it | 14:08 |
*** diga has quit IRC | 14:08 | |
Spazmotic | Is there an infra channel btw? | 14:08 |
*** sahid has quit IRC | 14:10 | |
gibi | Spazmotic: #openstack-infra | 14:10 |
Spazmotic | Thank ya sir | 14:10 |
*** yamamoto has joined #openstack-nova | 14:11 | |
ameeda | gibi: thank you ! | 14:11 |
ameeda | gibi: can you please review this for me ? https://review.openstack.org/#/c/528385/ | 14:11 |
*** rmcall has quit IRC | 14:13 | |
*** yamamoto has quit IRC | 14:14 | |
*** sahid has joined #openstack-nova | 14:14 | |
*** yamamoto has joined #openstack-nova | 14:15 | |
*** yamamoto has quit IRC | 14:15 | |
Kvisle | is it normal for nova-compute to use the public endpoint of the placement api, and not the internal one? | 14:19 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: ProviderTree.new_child: parent is either uuid or name https://review.openstack.org/538264 | 14:24 |
cdent | Kvisle: that's the default (for historical reasons) but you can configure it. | 14:25 |
*** AlexeyAbashkin has quit IRC | 14:26 | |
*** AlexeyAbashkin has joined #openstack-nova | 14:27 | |
cdent | Kvisle: os_interface is the old way, valid_interfaces is the new way | 14:27 |
*** rmcall has joined #openstack-nova | 14:27 | |
bauzas | Spazmotic: also, I haven't commented on that, but you know that with Python you can't recursively call more than 30 times the same method by default, right ? | 14:27 |
ameeda | mriedem: please check my comment here https://review.openstack.org/#/c/528385/10 | 14:28 |
*** dklyle has quit IRC | 14:29 | |
Kvisle | cdent: thanks (starting queens I see) | 14:29 |
ameeda | mriedem: if you have questions please let me know | 14:29 |
*** alexchadin has joined #openstack-nova | 14:30 | |
*** munishmehan has joined #openstack-nova | 14:31 | |
bauzas | Spazmotic: oops, my bad, by default, it's 999 times | 14:32 |
bauzas | Spazmotic: http://paste.openstack.org/show/658017/ | 14:33 |
*** slaweq_ has joined #openstack-nova | 14:36 | |
*** lucasagomes is now known as lucas-hungry | 14:36 | |
efried | Kvisle: Yes; the old way is deprecated but will still work in Q. | 14:37 |
*** rmcall has quit IRC | 14:38 | |
*** abhishekk has quit IRC | 14:39 | |
*** amoralej|lunch is now known as amoralej | 14:39 | |
*** yamamoto has joined #openstack-nova | 14:40 | |
*** tssurya has quit IRC | 14:40 | |
openstackgerrit | Ruby Loo proposed openstack/os-traits master: Add code hosting URL https://review.openstack.org/539224 | 14:41 |
*** slaweq_ has quit IRC | 14:41 | |
*** yamamoto has quit IRC | 14:43 | |
*** vladikr has quit IRC | 14:44 | |
*** eharney has joined #openstack-nova | 14:44 | |
*** slaweq_ has joined #openstack-nova | 14:46 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform live_migration_post_dest notification https://review.openstack.org/469784 | 14:48 |
*** yamamoto has joined #openstack-nova | 14:48 | |
mriedem | ameeda: replied | 14:50 |
*** slaweq_ has quit IRC | 14:50 | |
*** burt has joined #openstack-nova | 14:51 | |
*** tssurya has joined #openstack-nova | 14:52 | |
efried | jaypipes: Looks like I've got a unit test tweak to make, but otherwise the update_provider_tree series is now done and ready for review. | 14:53 |
efried | jaypipes: Realizing of course that it waits for Rocky; but we could land it early if it's already had a looksee. | 14:53 |
*** Spaz-Work has joined #openstack-nova | 14:53 | |
rgerganov | efried, which part of the series is for Rocky? | 14:55 |
efried | rgerganov: Well, that depends whether the six currently-approved patches ever make it through the gate. | 14:55 |
*** jangutter has quit IRC | 14:55 | |
*** dave-mccowan has joined #openstack-nova | 14:55 | |
efried | https://review.openstack.org/#/c/533808/ is the current bottom of the whole series; it and the next five are approved and just waiting for zuul to stop being a dick. | 14:56 |
efried | Then starting with https://review.openstack.org/#/c/537648/ is what we would land early in Rocky. | 14:56 |
efried | rgerganov: Notably the piece that ties everything together and makes it so update_provider_tree is actually used. | 14:57 |
rgerganov | efried, so there is no chance to use this stuff in queens | 14:57 |
efried | Which is this one: https://review.openstack.org/#/c/520246/ | 14:57 |
mriedem | we won't be merging anything probably until https://review.openstack.org/#/c/537933/ can merge | 14:57 |
*** r-daneel has joined #openstack-nova | 14:57 | |
efried | rgerganov: No. Not sure there was a chance of that anyway, considering we're past FF. | 14:57 |
bauzas | hold your breath, starting to look at the 47 new bugs | 14:57 |
bauzas | since the gate is super late, I won't review changes unless it's prioritary | 14:58 |
mriedem | bauzas: did you put up a patch for the vgpu feature support matrix change? | 14:58 |
bauzas | mriedem: not yet | 14:58 |
bauzas | mriedem: I can do it super quickly | 14:58 |
bauzas | but I was distracted by the infra issues | 14:58 |
bauzas | mriedem: I guess you're also planning to write a prelude ? | 14:59 |
mriedem | yes | 14:59 |
bauzas | cool | 14:59 |
mriedem | probably not this week | 14:59 |
bauzas | since I wasn't really present during Queens, the floor is yours | 14:59 |
*** vladikr has joined #openstack-nova | 14:59 | |
mriedem | how gracious of you :) | 14:59 |
bauzas | I'm French | 14:59 |
bauzas | all French people are gracious and kind | 15:00 |
mriedem | ha | 15:00 |
ameeda | mriedem: replied | 15:00 |
*** kwathore has joined #openstack-nova | 15:01 | |
ameeda | bauzas: you're right :) | 15:01 |
*** jackie-truong has joined #openstack-nova | 15:01 | |
bauzas | I wish I would :) | 15:02 |
*** tidwellr has joined #openstack-nova | 15:04 | |
*** links has quit IRC | 15:05 | |
*** yamahata has joined #openstack-nova | 15:05 | |
*** alexchadin has quit IRC | 15:05 | |
*** Guest59729 has quit IRC | 15:06 | |
Spaz-Work | ugh I wish I saw this solution | 15:06 |
Spaz-Work | it's so much more elegant | 15:06 |
Spaz-Work | bauzas: can you clarity what the "unnecessary" comment was for? | 15:06 |
bauzas | Spaz-Work: you mean about the recursion limit ? | 15:09 |
bauzas | Spaz-Work: I was confused, I thought it was 30 times, so I was a bit concerned to see us looping over more than 30 devices | 15:09 |
jaypipes | efried: ack | 15:10 |
*** andreas_s has quit IRC | 15:10 | |
bauzas | but since it's 999 times by default, I think it's harmless unless the instance has crazy 999 volumes attached to it | 15:10 |
*** andreas_s has joined #openstack-nova | 15:11 | |
*** yamamoto has quit IRC | 15:12 | |
Spaz-Work | Ah I see.. I don't want to rewrite the method entirely too much and blow the scope of this commit.. but there's so man ythings in this driver that need attention paid to them | 15:12 |
Spaz-Work | like the Assert migrate only being called with block migrations in LM.. bleh.. another day another problem heh | 15:13 |
Spaz-Work | Thanks sir, i'll keep working.. am happy with your notes.. much sexy | 15:13 |
*** mdnadeem has quit IRC | 15:14 | |
*** amodi has joined #openstack-nova | 15:15 | |
*** hongbin has joined #openstack-nova | 15:16 | |
mriedem | gibi: looks like gordc needs a link to your versioned notification transformation burndown chart in the ML | 15:18 |
mriedem | found it http://burndown.peermore.com/nova-notification/ | 15:18 |
*** Guest59729 has joined #openstack-nova | 15:19 | |
*** Eran_Kuris has quit IRC | 15:20 | |
gibi | mriedem: thanks for distributing it :) | 15:23 |
mriedem | gibi: thanks for adding the versioned notification transformation stuff here https://wiki.openstack.org/wiki/GSoC2018#Internship_ideas - i was just about to do that :) | 15:24 |
gibi | mriedem: yeah, I was approached | 15:24 |
Spaz-Work | Regarding another commit, if i'm going to do a version check against something with microversions.. would openstack stnadards rather me import oslo.utils.versionutils or jenk the versions into a tuple to compare | 15:24 |
Spaz-Work | Prevent overhead or look better i guess i the option | 15:24 |
gibi | mriedem: Would like to sign up as a co-mentor? | 15:25 |
*** gszasz_ has joined #openstack-nova | 15:25 | |
mriedem | Spaz-Work: nova.compute.api.openstack.api_version_request | 15:25 |
mriedem | Spaz-Work: assuming it's something you're checking within the api code | 15:25 |
mriedem | *nova.api.openstack.api_version_request | 15:25 |
Spaz-Work | Ah awesome, thanks sir i'll pull that | 15:25 |
mriedem | gibi: nope :) i was also approached and that's why i was going to add the entry and then call for a mentor | 15:26 |
*** crushil has joined #openstack-nova | 15:26 | |
gibi | mriedem: sorry for steeling your idea :) | 15:26 |
*** gszasz has quit IRC | 15:26 | |
mriedem | i could add 'remove all the mox from tests since it's going to be a community goal for rocky' but i wouldn't wish that on an intern | 15:27 |
gibi | mriedem: yeah, especially the test_neturonv2 side of it | 15:28 |
*** lajoskatona has quit IRC | 15:28 | |
*** andreas_s has quit IRC | 15:29 | |
*** yamamoto has joined #openstack-nova | 15:30 | |
*** andreas_s has joined #openstack-nova | 15:30 | |
*** damien_r has quit IRC | 15:30 | |
*** gcb has joined #openstack-nova | 15:31 | |
openstackgerrit | Merged openstack/os-traits master: Add code hosting URL https://review.openstack.org/539224 | 15:31 |
*** eharney has quit IRC | 15:32 | |
*** armax has joined #openstack-nova | 15:33 | |
*** lucas-hungry is now known as lucasagomes | 15:34 | |
*** Guest59729 has quit IRC | 15:35 | |
*** damien_r has joined #openstack-nova | 15:35 | |
*** yassine has joined #openstack-nova | 15:36 | |
cfriesen | there's a novaclient patch up at https://review.openstack.org/#/c/520187/ that's sitting with a single +2 if any core feels like taking a look. Basically adding strict hostname matching. | 15:36 |
*** yassine is now known as Guest88696 | 15:36 | |
*** itlinux has joined #openstack-nova | 15:37 | |
cfriesen | mriedem: thanks, I'll pester the author. | 15:38 |
*** andreas_s has quit IRC | 15:40 | |
*** zhaochao has quit IRC | 15:41 | |
bkero- | mdbooth: ping, is your nova-compute-maintenance.py script maintained anywhere, or is it just a gist? | 15:41 |
*** itlinux has quit IRC | 15:42 | |
mriedem | dansmith: alex's patch to handle the old/new style allocation candidates in the scheduler report client merged, did you want to rebase https://review.openstack.org/#/c/531517/ ? | 15:42 |
dansmith | mriedem: I don't want to, no, but .. I will | 15:43 |
*** sahid has quit IRC | 15:44 | |
mdbooth | bkero-: It's not maintained. What's the interest in it? | 15:44 |
*** andreas_s has joined #openstack-nova | 15:45 | |
*** slaweq_ has joined #openstack-nova | 15:45 | |
*** pchavva has joined #openstack-nova | 15:46 | |
bkero- | mdbooth: using it to evacuate compute hosts for maintenance :) | 15:46 |
mdbooth | bkero-: Heh, that's what it's for :) | 15:47 |
bkero- | since host-evacuate-live leaves a bit to be desired | 15:47 |
*** felipemonteiro__ has joined #openstack-nova | 15:47 | |
bkero- | mdbooth: I've had to fix a few things, like add 'all_tenants' and make the auth work | 15:47 |
mdbooth | I was wondering if you wanted to incorporate it into another tool. | 15:47 |
bkero- | I'm incorporating it into ansible playbooks to do rolling maintenance | 15:47 |
*** eharney has joined #openstack-nova | 15:47 | |
* mdbooth feels like it ought to be in Nova's cli tools somewhere | 15:48 | |
bkero- | I think so too. Maybe that is too many batteries included though. | 15:49 |
mdbooth | It's much better than host-evacuate-live, for eg | 15:49 |
bkero- | I'm basically evacuating a host, doing maintenance (hint: kernel upgrade), then moving onto next host | 15:49 |
*** AlexeyAbashkin has quit IRC | 15:50 | |
bkero- | I started writing my own tool for this, then found your tool and it saved me a bunch of time. | 15:50 |
mriedem | efried: the consistent ksa endpoint stuff might be worth a cross-project goal at some point | 15:50 |
*** AlexeyAbashkin has joined #openstack-nova | 15:50 | |
*** slaweq_ has quit IRC | 15:50 | |
mriedem | standard config for services to talk to each other | 15:50 |
mriedem | seems more valuable to me than removing mox | 15:51 |
efried | mriedem: I agree. I think mordred might have been gonna push that. | 15:51 |
mriedem | he pushed standard paging links | 15:51 |
mordred | what'd I do? | 15:51 |
efried | TBH, I wouldn't be likely to have the bandwidth to push a cross-project goal like that. | 15:51 |
mordred | efried: bah. you have unlimited bandwidth | 15:52 |
mriedem | mordred: i told efried that https://specs.openstack.org/openstack/nova-specs/specs/queens/approved/use-ksa-adapter-for-endpoints.html would be a good cross-project goal | 15:52 |
mriedem | consistent config for inter-service communication | 15:52 |
mordred | mriedem: yes - I agree | 15:52 |
mriedem | nova's done it for all but cinder config, so there are examples, and it's tested in the gate | 15:53 |
mordred | ++ | 15:53 |
mriedem | *and castellan i guess | 15:53 |
efried | We figured out that castellan was n/a | 15:53 |
*** sahid has joined #openstack-nova | 15:53 | |
mriedem | i'll at least throw something into the cross-project goal etherpad of doom | 15:53 |
mordred | efried: also - sorry, I never got the os-service-types integration added to keystoneauth this past cycle | 15:53 |
efried | mordred: You were talking about taking it a step further IIRC, getting rid of "clients" altogether and just using the adapter (which we would spin up in a standard way) | 15:53 |
efried | mordred: Me neither :) | 15:54 |
efried | mordred: I started focusing more selfishly on placement stuff. | 15:54 |
mordred | efried: yah. honestly the use of the python client libs for inter-service communication just makes things harder - but I haven't actually gotten far enough along on my list of rocks to push up hill to start on that one yet - maybe post-rocky | 15:54 |
*** AlexeyAbashkin has quit IRC | 15:55 | |
*** AlexeyAbashkin has joined #openstack-nova | 15:55 | |
efried | mordred: I started to feel like that might be a bit too idealistic, really. The clients can add some project-specific value - though there's certainly consolidation/refactoring that could be done. | 15:56 |
mordred | efried: the work to align on what you've done in nova - with using keystoneauth to register the oslo.config options and to consume the options is great in either case ... and should allow us to later refactor to use not-client-lib easily without any operator impact, should we choose to | 15:56 |
efried | Yuh | 15:57 |
*** david-lyle has joined #openstack-nova | 15:57 | |
*** itlinux has joined #openstack-nova | 15:57 | |
mordred | efried: my experience is that they provide negative value as soon as you are a consumer of more than one service because each one 'adds value' in their own special way that you have to figure out - whereas the REST APIs themselves are ACTUALLY quite good and are surprisingly consistent already | 15:57 |
mriedem | mordred: efried: L463 https://etherpad.openstack.org/p/community-goals | 15:58 |
efried | mm | 15:58 |
*** felipemonteiro has joined #openstack-nova | 15:58 | |
*** slaweq_ has joined #openstack-nova | 15:58 | |
mordred | efried: like, I thought openstack's rest apis were worse than they are back when my only consumption of them was the client libs - but as soon as I switch to REST, I realized that the openstack developers had actually done a great job in making me some excellent apis | 15:58 |
efried | mriedem: ack | 15:59 |
*** gszasz_ has quit IRC | 15:59 | |
*** andreas_s has quit IRC | 15:59 | |
*** andreas_s has joined #openstack-nova | 16:01 | |
*** felipemonteiro__ has quit IRC | 16:01 | |
*** ragiman has quit IRC | 16:01 | |
*** alexchadin has joined #openstack-nova | 16:03 | |
*** slaweq_ has quit IRC | 16:04 | |
*** andreas_s has quit IRC | 16:05 | |
*** andreas_s has joined #openstack-nova | 16:06 | |
*** sree has joined #openstack-nova | 16:10 | |
*** gszasz_ has joined #openstack-nova | 16:12 | |
*** Guest41574 has quit IRC | 16:13 | |
*** gszasz_ has quit IRC | 16:14 | |
*** gszasz has joined #openstack-nova | 16:15 | |
*** Nil_ has joined #openstack-nova | 16:17 | |
openstackgerrit | Hongbin Lu proposed openstack/nova master: Handle RPC timeout on get_console_output https://review.openstack.org/525335 | 16:17 |
*** yamamoto has quit IRC | 16:17 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove unused tempest-dsvm-lxc-rc https://review.openstack.org/539244 | 16:19 |
*** yamamoto has joined #openstack-nova | 16:20 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Fix invalid UUIDs in test_compute.py https://review.openstack.org/531479 | 16:22 |
*** Tom-Tom has quit IRC | 16:24 | |
*** yamamoto has quit IRC | 16:25 | |
*** tidwellr has quit IRC | 16:30 | |
*** lyan has joined #openstack-nova | 16:32 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Fix invalid UUIDs https://review.openstack.org/539247 | 16:33 |
stephenfin | edleafe: I'd been working on something similar, thankfully with no overlap ^ | 16:33 |
*** tidwellr has joined #openstack-nova | 16:33 | |
*** david-lyle has quit IRC | 16:34 | |
edleafe | stephenfin: heh, I'm just about ready to push a fix for the rest. Bet there's overlap there | 16:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Don't use 'Test' prefix for non-TestCase classes https://review.openstack.org/539251 | 16:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Resolve "X is renamed to Y" warnings https://review.openstack.org/539252 | 16:35 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't modify objects directly https://review.openstack.org/539253 | 16:35 |
*** alexchadin has quit IRC | 16:35 | |
stephenfin | edleafe: Go for it. I'm guessing mine has issue anyway | 16:35 |
stephenfin | *issues | 16:36 |
mriedem | melwitt: i saw you posted backports for https://review.openstack.org/#/c/533371/ - i left some comments about impacts to the CachingScheduler, of which i'm not sure there are any, but it'd be nice to get a 2nd set of eyes on that part of it. | 16:36 |
stephenfin | ...as all code written on a Friday evening is likely to have | 16:36 |
Spaz-Work | really don't like this test... | 16:37 |
Spaz-Work | mock patching hurting my brain | 16:37 |
*** ispp has joined #openstack-nova | 16:37 | |
*** gszasz has quit IRC | 16:37 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Fix invalid UUIDs in remaining tests https://review.openstack.org/539254 | 16:37 |
edleafe | stephenfin: ^^ | 16:37 |
*** AlexeyAbashkin has quit IRC | 16:38 | |
* stephenfin reviews | 16:38 | |
mdbooth | stephenfin: https://review.openstack.org/#/c/539247/1/nova/tests/unit/virt/libvirt/test_vif.py does nova.network.model use o.v.o. ? | 16:38 |
stephenfin | mdbooth: It uses os-vif objects, which are o.v.o based | 16:39 |
mdbooth | stephenfin: I believe you, but... where? | 16:39 |
stephenfin | Wait, I have that confused | 16:39 |
dansmith | yeah, no | 16:39 |
dansmith | that stuff is not o.vo based | 16:40 |
mdbooth | Given that both you and edleafe have made the same changes, I assume they're required | 16:40 |
dansmith | nor versioned | 16:40 |
mdbooth | I just can't see where the dep comes in | 16:40 |
*** andreas_s has quit IRC | 16:40 | |
stephenfin | I never really thought to question the warnings, but there is something going on there with os-vif. Lemme root it out | 16:41 |
edleafe | mdbooth: did you see the warnings? They're listed in the bug | 16:41 |
stephenfin | mdbooth, dansmith: It's nova/network/os_vif_util.py | 16:42 |
stephenfin | We have code to convert nova's VIF/network/<other networking thingys> to os-vif equivalents | 16:42 |
stephenfin | which _are_ versioned | 16:42 |
*** awaugama has joined #openstack-nova | 16:43 | |
*** andreas_s has joined #openstack-nova | 16:44 | |
*** sahid has quit IRC | 16:46 | |
*** david-lyle has joined #openstack-nova | 16:47 | |
*** david-lyle has quit IRC | 16:48 | |
*** sahid has joined #openstack-nova | 16:48 | |
*** david-lyle has joined #openstack-nova | 16:49 | |
mdbooth | stephenfin: How would I reproduce these warnings? I just ran the tests in nova.tests.unit.virt.libvirt.test_vif, and I didn't get any uuid warnings | 16:51 |
mdbooth | Just warnings about deprecation of api extensions | 16:51 |
*** slaweq_ has joined #openstack-nova | 16:52 | |
dansmith | stephenfin: aye | 16:52 |
*** tidwellr has quit IRC | 16:52 | |
stephenfin | mdbooth: I think you've to trigger something to do with PYTHONWARNINGS. I was seeing them when I ran the testsuite with pytest | 16:53 |
stephenfin | mdbooth: They should be visible in any recent gate logs | 16:53 |
*** andreas_s has quit IRC | 16:53 | |
*** andreas_s has joined #openstack-nova | 16:54 | |
stephenfin | mdbooth: This is the warning that's being raised https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L346 | 16:54 |
dansmith | mriedem: do we have a bug for the need-a-limit thing? if not, I assume I should open one at this point because FF | 16:55 |
*** chyka has joined #openstack-nova | 16:55 | |
* stephenfin was reviewing edleafe's patch and thinking, "wow, it's uncanny how similar this is to mine" | 16:55 | |
* stephenfin was reviewing his own patch | 16:55 | |
* stephenfin needs to go home | 16:55 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: cover migration cases with functional tests https://review.openstack.org/493865 | 16:57 |
*** slaweq_ has quit IRC | 16:57 | |
*** tidwellr has joined #openstack-nova | 16:57 | |
*** gjayavelu has joined #openstack-nova | 16:57 | |
mriedem | dansmith: nope no bug but was considering it a bug fix anyway | 16:57 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a nova-caching-scheduler job to the experimental queue https://review.openstack.org/539260 | 16:57 |
*** sridharg has quit IRC | 16:57 | |
*** damien_r has quit IRC | 16:57 | |
mriedem | dansmith: feel free to open one though | 16:57 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: cover migration cases with functional tests https://review.openstack.org/493865 | 16:57 |
openstackgerrit | Dan Smith proposed openstack/nova master: Pass limit to /allocation_requests https://review.openstack.org/531517 | 17:00 |
dansmith | mriedem: ^ | 17:00 |
*** gcb has quit IRC | 17:00 | |
*** andreas_s has quit IRC | 17:00 | |
*** slaweq has quit IRC | 17:03 | |
*** slaweq has joined #openstack-nova | 17:03 | |
*** fragatina has joined #openstack-nova | 17:03 | |
*** slaweq_ has joined #openstack-nova | 17:03 | |
*** jackie-truong has quit IRC | 17:04 | |
*** slaweq_ has quit IRC | 17:07 | |
*** sree has quit IRC | 17:08 | |
*** fragatina has quit IRC | 17:08 | |
*** slaweq has quit IRC | 17:08 | |
*** mvk has quit IRC | 17:10 | |
*** fragatina has joined #openstack-nova | 17:10 | |
*** janki has quit IRC | 17:11 | |
*** Guest88696 has quit IRC | 17:11 | |
*** sree has joined #openstack-nova | 17:12 | |
openstackgerrit | Brooks Kaminski proposed openstack/nova master: XenAPI/Stops the migration of volume backed VHDS https://review.openstack.org/533168 | 17:13 |
*** felipemonteiro has quit IRC | 17:14 | |
*** felipemonteiro__ has joined #openstack-nova | 17:14 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Provide support matrix and doc for VGPU https://review.openstack.org/539266 | 17:15 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Fix invalid UUIDs in remaining tests https://review.openstack.org/539254 | 17:15 |
mriedem | gibi: sorry, forgot about the notification meeting | 17:15 |
bauzas | mriedem: jianghuaw: see the first rev for documenting the VGPU feature https://review.openstack.org/#/c/539266/ | 17:15 |
*** sree has quit IRC | 17:17 | |
Spaz-Work | Thanks for the ideas again bauzas, I think I hit the points you were concerned about | 17:18 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Integrate Mypy Type Checking https://review.openstack.org/538217 | 17:18 |
*** janki has joined #openstack-nova | 17:19 | |
*** janki has quit IRC | 17:19 | |
*** yamamoto has joined #openstack-nova | 17:21 | |
*** yamamoto has quit IRC | 17:27 | |
*** ralonsoh_ has joined #openstack-nova | 17:28 | |
*** damien_r has joined #openstack-nova | 17:29 | |
*** AlexeyAbashkin has joined #openstack-nova | 17:29 | |
gibi | mriedem: no worries, as you saw there was nothing to talk about | 17:30 |
*** Pramod has joined #openstack-nova | 17:31 | |
*** ralonsoh has quit IRC | 17:31 | |
*** damien_r has quit IRC | 17:34 | |
mriedem | bauzas: thanks, that's a nice start; comments inline | 17:34 |
bauzas | mriedem: I'm just passing a new rev now | 17:34 |
bauzas | will see your comments | 17:34 |
mriedem | passing, like a stone | 17:34 |
bauzas | mriedem: good points, will hold my rev and amend it with your comments | 17:35 |
bauzas | but that's somehow later tonight | 17:35 |
bauzas | bbrb | 17:35 |
*** markvoelker has joined #openstack-nova | 17:36 | |
mriedem | nova functional job timeout bump is getting promoted, #2 in the gate now | 17:37 |
*** prateek has joined #openstack-nova | 17:40 | |
*** brault has joined #openstack-nova | 17:40 | |
dansmith | bauzas: still looking for you to comment on this: https://review.openstack.org/#/c/532924/ | 17:43 |
*** tesseract has quit IRC | 17:46 | |
*** felipemonteiro has joined #openstack-nova | 17:49 | |
*** felipemonteiro__ has quit IRC | 17:51 | |
*** ralonsoh__ has joined #openstack-nova | 17:54 | |
*** ralonsoh_ has quit IRC | 17:58 | |
*** sahid has quit IRC | 17:58 | |
*** alexchadin has joined #openstack-nova | 17:58 | |
*** derekh has quit IRC | 17:59 | |
*** bpoulos has joined #openstack-nova | 18:01 | |
*** bpoulos has left #openstack-nova | 18:01 | |
*** damien_r has joined #openstack-nova | 18:03 | |
*** brault has quit IRC | 18:04 | |
*** Pramod has quit IRC | 18:05 | |
*** Pramod has joined #openstack-nova | 18:06 | |
*** Swami has joined #openstack-nova | 18:07 | |
*** damien_r has quit IRC | 18:08 | |
*** slaweq has joined #openstack-nova | 18:08 | |
*** slaweq has quit IRC | 18:13 | |
*** david-lyle has quit IRC | 18:13 | |
*** yamamoto has joined #openstack-nova | 18:23 | |
*** priteau has quit IRC | 18:24 | |
*** Tom-Tom has joined #openstack-nova | 18:24 | |
*** lpetrut has quit IRC | 18:25 | |
*** priteau has joined #openstack-nova | 18:25 | |
mriedem | efried: cdent: are you aware of anyone writing any docs about how required traits will be used with flavors? was thinking about writing a functional test for alex_xu's traits / extra specs / scheduler series, and realized we probably don't have anything documented outside of the spec (which might have changed by now); thinking something here https://docs.openstack.org/nova/latest/user/flavors.html is the best place | 18:25 |
*** prateek has quit IRC | 18:26 | |
cdent | mriedem: I am not aware of anything, but I'd guess I'm about a week out of date on what's extant. | 18:26 |
*** amodi has quit IRC | 18:26 | |
mriedem | alright i'll see if i can work through a functional test and then document the user pov | 18:27 |
*** alexchadin has quit IRC | 18:27 | |
*** Tom-Tom has quit IRC | 18:29 | |
*** priteau has quit IRC | 18:29 | |
*** yamamoto has quit IRC | 18:29 | |
melwitt | mriedem: ack, will take a look at the CachingScheduler | 18:33 |
*** gjayavelu has quit IRC | 18:33 | |
*** ralonsoh__ has quit IRC | 18:33 | |
*** slaweq has joined #openstack-nova | 18:33 | |
*** itlinux has quit IRC | 18:36 | |
*** alexchadin has joined #openstack-nova | 18:38 | |
*** slaweq has quit IRC | 18:38 | |
*** salv-orl_ has quit IRC | 18:39 | |
*** salv-orlando has joined #openstack-nova | 18:39 | |
*** alexchadin has quit IRC | 18:41 | |
*** salv-orlando has quit IRC | 18:44 | |
efried | mriedem: I assume you mean docs other than the spec | 18:44 |
mriedem | efried: yes. i expect specs as the last resort for usage docs | 18:45 |
efried | ++ | 18:45 |
*** AlexeyAbashkin has quit IRC | 18:46 | |
*** cdent has quit IRC | 18:52 | |
*** moshele has joined #openstack-nova | 18:53 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix nits in support traits changes https://review.openstack.org/537351 | 18:59 |
*** ircuser-1 has quit IRC | 19:00 | |
*** jpena is now known as jpena|off | 19:00 | |
*** amoralej is now known as amoralej|off | 19:06 | |
*** alexchadin has joined #openstack-nova | 19:09 | |
*** gjayavelu has joined #openstack-nova | 19:10 | |
*** alexchadin has quit IRC | 19:11 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Mention required traits in the flavors user docs https://review.openstack.org/539300 | 19:11 |
*** Pramod has quit IRC | 19:12 | |
*** slaweq has joined #openstack-nova | 19:12 | |
mgagne | mriedem: "i expect specs as the last resort for usage docs" so should I update them ? I'm now on the fence on that one because I think that once implementation is done, you "should" be able to delete the spec. if doc is missing, I think it's a tech debt. | 19:16 |
*** slaweq has quit IRC | 19:16 | |
mriedem | mgagne: specs shouldn't be deleted no, | 19:16 |
*** harlowja has joined #openstack-nova | 19:17 | |
mriedem | for specs that require user-facing docs changes, there is a doc impact section, and it's up to reviewers to make sure the feature is documented | 19:17 |
mgagne | mriedem: what I meant is: once implementation is done, why should you rely on the spec? they can get out of sync easily | 19:17 |
mriedem | if some major part of a design point in a spec changed during implementation, or something was added, then we amend specs | 19:17 |
mriedem | lots of reasons - the problem statement, the original design ideas, etc | 19:17 |
mriedem | it's an archive | 19:17 |
mgagne | mriedem: that's not my experience so far as a spec reader | 19:18 |
mriedem | first, i'm not saying you should have to rely on a spec as a usage doc, it's not meant to be that | 19:18 |
mgagne | mriedem: ok, maybe not literally deleted but a end user shouldn't rely on that kind of documents | 19:18 |
openstackgerrit | Merged openstack/nova master: Bumping functional test job timeouts https://review.openstack.org/537933 | 19:18 |
mriedem | if we're missing usage docs, that's a bug | 19:18 |
mgagne | mriedem: ok, we agree on that point | 19:18 |
*** fragatina has quit IRC | 19:19 | |
mgagne | mriedem: tyvm for your work btw =) | 19:23 |
*** yamamoto has joined #openstack-nova | 19:25 | |
*** lucasagomes is now known as lucas-afk | 19:26 | |
openstackgerrit | Merged openstack/nova master: Rollback instance.image_ref on failed rebuild https://review.openstack.org/538961 | 19:27 |
openstackgerrit | Merged openstack/nova master: Collapse duplicate error handling in rebuild_instance https://review.openstack.org/539001 | 19:27 |
*** Pramod has joined #openstack-nova | 19:28 | |
*** yamamoto has quit IRC | 19:31 | |
openstackgerrit | Merged openstack/nova stable/pike: Fix false positive server group functional tests https://review.openstack.org/536981 | 19:32 |
openstackgerrit | Eric Fried proposed openstack/nova master: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 19:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 19:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 19:33 |
efried | jaypipes: Fixed those tests; should all be ready to go now ^ | 19:33 |
efried | whoah, stuff is merging, neat. | 19:34 |
mgagne | mriedem: thanks for nova-caching-scheduler job, we do heavily rely on that driver. glad to see it won't get broken by accident before its removal. | 19:36 |
mriedem | mgagne: huawei public cloud is using it as well | 19:36 |
mriedem | so yeah i have to care about that one :) | 19:36 |
mgagne | mriedem: wasn't it them that made a presentation at the summit about it? | 19:36 |
mriedem | i don't remember one, but which summit? | 19:37 |
mriedem | it was added by rax | 19:37 |
mgagne | austin | 19:37 |
mgagne | was Intel | 19:37 |
mgagne | https://www.openstack.org/videos/austin-2016/dive-into-nova-scheduler-performance-where-is-the-bottleneck | 19:38 |
mriedem | yeah i remember that one | 19:38 |
mriedem | that was about a proposal for a different scheduler | 19:38 |
mgagne | difference of performance is like day and night (filter vs caching) | 19:38 |
mriedem | placement was pretty new still around that time so a lot of the outcome of that session (there was also a related design summit session) was "placement should handle a lot of these same issues" | 19:38 |
mriedem | i'm mostly interested, right now, in filter scheduler + placement vs caching | 19:39 |
mriedem | to see if that gap is much smaller | 19:39 |
mgagne | yes... because if placement is not as fast or close to be as fast, I would be like: "what's the point?" =) | 19:40 |
*** prometheanfire has joined #openstack-nova | 19:41 | |
prometheanfire | mriedem: it's getting to the point where we'll need an FFE for https://review.openstack.org/538070 (if horizon doesn't merge that dependant patch) | 19:41 |
*** damien_r has joined #openstack-nova | 19:41 | |
efried | jaypipes, mriedem: The final parts of update_provider_tree going to Rocky presents an opportunity to write that design up as a separate blueprint/spec. It was never outlined in any of the placement/NRP specs (right Jay?) and it really ought to be. If you agree, I can get started on that. | 19:42 |
*** alexchadin has joined #openstack-nova | 19:43 | |
efried | (If you don't agree, I'm going to write it anyway, for my own use, and you don't get to see it.) | 19:43 |
*** lpetrut has joined #openstack-nova | 19:43 | |
mriedem | prometheanfire: i'm not sure how much i want to pursue that this late given the impact it also has to some CLIs in OSC: http://lists.openstack.org/pipermail/openstack-dev/2018-January/126741.html | 19:44 |
prometheanfire | mriedem: that's kinda what I thought | 19:45 |
*** damien_r has quit IRC | 19:46 | |
mriedem | we'll just pick it up in rocky | 19:47 |
mriedem | nothing requires novaclient>=10.0.0 in queens | 19:47 |
prometheanfire | k | 19:48 |
*** cdent has joined #openstack-nova | 19:50 | |
*** david-lyle has joined #openstack-nova | 19:51 | |
*** pcaruana has quit IRC | 19:52 | |
*** cdent has quit IRC | 19:52 | |
prometheanfire | mriedem: k, gonna -2-W that for freeze then | 19:56 |
mriedem | prometheanfire: ok i left a comment in there that i'm cool with it | 19:58 |
openstackgerrit | Merged openstack/nova stable/pike: Set server status to ERROR if rebuild failed https://review.openstack.org/536897 | 20:01 |
*** sambetts is now known as sambetts|afk | 20:01 | |
*** alexchadin has quit IRC | 20:03 | |
*** tssurya_ has joined #openstack-nova | 20:04 | |
*** mvk has joined #openstack-nova | 20:04 | |
melwitt | more people are asking about https://review.openstack.org/340614 again, I've rewritten the commit message and added code comments to make it easier to review | 20:06 |
*** brault has joined #openstack-nova | 20:06 | |
mriedem | i saw you dropped the revert history of shame | 20:08 |
mriedem | also, "people are talking" is a classic fox news tactic | 20:08 |
mriedem | name your sources mel | 20:08 |
prometheanfire | top | 20:09 |
prometheanfire | men | 20:09 |
melwitt | yeah, I had thought the history was important but I got the feeling no one could understand the point of the patch because of it | 20:09 |
melwitt | even I was getting confused between merge conflicts | 20:09 |
prometheanfire | https://www.reactiongifs.us/wp-content/uploads/2013/10/top_men_indiana_jones.gif | 20:09 |
melwitt | ayoung is asking about it today in #openstack-cinder | 20:10 |
*** brault has quit IRC | 20:11 | |
*** gjayavelu has quit IRC | 20:11 | |
*** felipemonteiro has quit IRC | 20:15 | |
*** felipemonteiro__ has joined #openstack-nova | 20:15 | |
*** damien_r has joined #openstack-nova | 20:16 | |
*** slaweq has joined #openstack-nova | 20:17 | |
*** damien_r has quit IRC | 20:21 | |
*** huanxie has quit IRC | 20:23 | |
*** huanxie has joined #openstack-nova | 20:23 | |
mriedem | https://review.openstack.org/#/c/537933/ is finally merged, patches should flow much better through the gate now | 20:26 |
*** yamamoto has joined #openstack-nova | 20:27 | |
prometheanfire | mriedem: please have a piece of wood glued to your head :P | 20:27 |
cfriesen | melwitt: in the case of https://review.openstack.org/340614 why doesn't nova-compute do a more complete job of cleaning up at the time it sets the instance.host to None? | 20:28 |
mriedem | prometheanfire: ? | 20:28 |
prometheanfire | patches should flow much better through the gate now | 20:28 |
mriedem | cfriesen: like this? https://review.openstack.org/#/c/528385/ | 20:28 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional tests for traits-based scheduling https://review.openstack.org/539310 | 20:29 |
mriedem | alex_xu: efried: ^ | 20:29 |
mriedem | turned out it was pretty simple to write those | 20:29 |
cfriesen | mriedem: yep, and something similar for ports I guess. | 20:30 |
*** READ10 has quit IRC | 20:33 | |
*** yamamoto has quit IRC | 20:33 | |
openstackgerrit | Matthew Edmonds proposed openstack/nova master: remove unnecessary conf imports https://review.openstack.org/539314 | 20:34 |
melwitt | cfriesen: good question. looks like it tries to do something to cleanup volumes but it only does a volume delete if 'delete_on_termination' and doesn't do anything like detach volumes | 20:35 |
*** lpetrut has quit IRC | 20:35 | |
melwitt | so it seems like a better fix would be to properly handle cleanup in compute | 20:35 |
mriedem | melwitt: that's what ameeda's patch is trying to do | 20:37 |
mriedem | we do call _cleanup_allocated_networks when a build fails on the compute | 20:38 |
mriedem | which should cleanup ports | 20:38 |
melwitt | right | 20:38 |
mriedem | there could possibly be a bug there if we're using a stale network info cache | 20:39 |
mriedem | the _cleanup_volumes thing is definitely a gap in the compute cleanup code | 20:39 |
mriedem | if the volume is attached | 20:39 |
melwitt | yeah, seeing that | 20:39 |
*** lpetrut has joined #openstack-nova | 20:40 | |
melwitt | we're also missing a volume cleanup call for the InstanceNotFound block | 20:40 |
mriedem | well, | 20:40 |
mriedem | that means the instance was deleted concurrently | 20:40 |
mriedem | yeah? | 20:40 |
mriedem | which should go through the local delete in the API, or _shutdown_instance in the compute | 20:41 |
melwitt | yeah, concurrent | 20:41 |
melwitt | okay, just saw there's a cleanup ports call in there but no volumes call | 20:42 |
*** awaugama has quit IRC | 20:42 | |
openstackgerrit | Merged openstack/nova stable/pike: Make sure that functional test triggered on sample changes https://review.openstack.org/536934 | 20:42 |
openstackgerrit | Merged openstack/nova master: Fix a comment in a notification functional test https://review.openstack.org/536262 | 20:43 |
*** damien_r has joined #openstack-nova | 20:48 | |
*** damien_r has quit IRC | 20:48 | |
mriedem | woot ^ should be able to start rechecking pike changes now too | 20:49 |
efried | jaypipes: All other things being equal, is there a reason you prefer a DELETE API over PUT {} ? | 20:50 |
melwitt | mriedem: how? did that resolve the libvirt keepalive timeout fails? | 20:50 |
mriedem | no | 20:51 |
mriedem | melwitt: you're right - it doesn't, need to backport the functional job timeout bump patch | 20:51 |
mriedem | want to propose that? | 20:51 |
melwitt | I can, but I was referring to the permafail of the cells v1 job on pike and ocata because of the libvirt keepalive timeout issue | 20:52 |
*** jackie-truong has joined #openstack-nova | 20:52 | |
mriedem | melwitt: remember i removed the cellsv1 job from stable? | 20:52 |
melwitt | AFAIK we're still blocked on pike and ocata because of that | 20:52 |
melwitt | oh, I didn't know that. nevermind | 20:52 |
mriedem | https://review.openstack.org/#/c/538619/ | 20:52 |
mriedem | if we want that job back, i think we have to define it in-tree per-branch and make it non-voting on stable | 20:53 |
melwitt | cool ... wish we knew what the root cause was, but there were no real leads | 20:53 |
openstackgerrit | sean mooney proposed openstack/nova master: Change 'InstancePCIRequest' spec field https://review.openstack.org/449257 | 20:54 |
openstackgerrit | melanie witt proposed openstack/nova stable/pike: Bumping functional test job timeouts https://review.openstack.org/539319 | 20:56 |
mriedem | the python2.7 update on jan 18 and the fact we're not using pike uca packages is as close as i got to 'leads' | 20:56 |
* melwitt nods | 20:56 | |
mriedem | the latter is unique to master | 20:56 |
melwitt | I see. so we could try pulling pike uca for stable/pike but not for stable/ocata, right? I assume that wouldn't be okay because it's a mismatch | 20:57 |
melwitt | do we need the func test timeout bump for ocata too? | 20:58 |
melwitt | we don't have .zuul.yaml there | 20:59 |
mriedem | melwitt: yes on the last question, that needs to go on top of https://review.openstack.org/#/c/536936/ | 20:59 |
mriedem | as for the former question, i tried that in https://review.openstack.org/#/c/536798/ but my patch to not run cellsv1 in stable landed first so the job didn't run on that patch | 20:59 |
melwitt | ah, okay. thanks | 20:59 |
mriedem | we'd have to do some depends-on chicanery there | 20:59 |
melwitt | gotcha | 21:00 |
mriedem | cfriesen: so on the perf thing, you just found out that compute was using more cpu than before? | 21:00 |
mriedem | that was likely because in newton the computes started posting inventory information to placement from every RT update | 21:01 |
mriedem | but you said server creates were taking a lot longer | 21:01 |
openstackgerrit | melanie witt proposed openstack/nova stable/ocata: Bumping functional test job timeouts https://review.openstack.org/539320 | 21:03 |
cfriesen | mriedem: yeah, on same hardware instance creation on newton was 32 sec and pike was 230. but it's hard to break down exactly what's causing it since anything audit-driven will also show higher usage. | 21:05 |
cfriesen | mriedem: it should be noted this is on an all-in-one system, so the openstack services are constrained to only two CPUs, and those were pretty much pinned | 21:06 |
cfriesen | ie at 100% usage | 21:06 |
*** slaweq_ has joined #openstack-nova | 21:08 | |
mriedem | cfriesen: can't run osprofiler + rally or something to see at least where the majority of the time is being spent? | 21:09 |
*** felipemonteiro has joined #openstack-nova | 21:10 | |
cfriesen | mriedem: we've got traces from intel's vtune analyzer showing how much time is spent where, but just about everything shows increases. there's no single smoking gun. | 21:12 |
*** tssurya_ has quit IRC | 21:12 | |
*** pchavva has quit IRC | 21:13 | |
*** slaweq_ has quit IRC | 21:13 | |
*** felipemonteiro__ has quit IRC | 21:13 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Make the InstanceMapping marker UUID-like https://review.openstack.org/539323 | 21:14 |
mriedem | cfriesen: huh | 21:16 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make generation optional in ProviderTree https://review.openstack.org/539324 | 21:18 |
*** lpetrut has quit IRC | 21:19 | |
mriedem | melwitt: looks like you have real test failures in https://review.openstack.org/#/c/539013/ | 21:20 |
melwitt | mriedem: ah, thank you. I hadn't looked at the detail yet. I shall fix that up | 21:21 |
*** eharney_ has joined #openstack-nova | 21:21 | |
sean-k-mooney | cfriesen: dumb question but could it be related to meltdow/specter patches? | 21:21 |
*** tbachman has quit IRC | 21:22 | |
cfriesen | sean-k-mooney: not so dumb. :) but no, this was a load from before the meltdown/spectre patches were applied. | 21:23 |
*** eharney has quit IRC | 21:23 | |
*** eharney_ is now known as eharney | 21:23 | |
mriedem | cfriesen: and you've got the latest stable/pike release? | 21:25 |
*** tssurya_ has joined #openstack-nova | 21:26 | |
*** moshele has quit IRC | 21:26 | |
mriedem | like i was wondering if any of the RequestContext changes might be related https://github.com/openstack/nova/commits/stable/pike/nova/context.py | 21:26 |
mriedem | since the context is used everywhere | 21:26 |
cfriesen | mriedem: not the latest, no. originally from 16.0.2, with some stable/pike stuff since then. not sure exactly what, I've been busy with other stuff. | 21:27 |
mriedem | cfriesen: ok would be good to know if it's still the same issue after you've got the latest pike fixes applied | 21:28 |
mriedem | https://docs.openstack.org/releasenotes/nova/pike.html | 21:28 |
*** yamamoto has joined #openstack-nova | 21:29 | |
mriedem | full change log http://paste.openstack.org/show/658066/ | 21:30 |
cfriesen | don't see anything related to "context" in there, got any pointers? | 21:30 |
*** eharney has quit IRC | 21:30 | |
cfriesen | last stable/pike changes to nova/context.py were from October | 21:31 |
mriedem | nothing in that changelog jumps out at me as a perf related fix | 21:32 |
cfriesen | does the upstream CI environment do performance tests of common operations? | 21:34 |
*** yamamoto has quit IRC | 21:35 | |
*** awaugama has joined #openstack-nova | 21:35 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Remove compute nodes arg from ProviderTree init https://review.openstack.org/539330 | 21:35 |
mriedem | cfriesen: no | 21:38 |
mriedem | too much variance from node to node | 21:38 |
mriedem | not sure what can be pulled perf-trend wise from openstack-health | 21:39 |
*** eharney has joined #openstack-nova | 21:39 | |
mriedem | http://status.openstack.org/openstack-health/#/ | 21:39 |
mriedem | like, i don't know how to take that and see how long a simple tempest create server test has taken over the last 12 monhts | 21:40 |
*** threestrands has joined #openstack-nova | 21:40 | |
mriedem | *months | 21:40 |
mriedem | mtreinish can maybe help | 21:40 |
openstackgerrit | melanie witt proposed openstack/nova stable/ocata: Stop globally caching host states in scheduler HostManager https://review.openstack.org/539013 | 21:40 |
*** tssurya_ has quit IRC | 21:48 | |
*** tssurya_ has joined #openstack-nova | 21:48 | |
*** tssurya_ has quit IRC | 21:48 | |
mriedem | mmedvede: powerkvm ci seems pretty unhappy | 21:49 |
mriedem | is that a known issue? | 21:49 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Provide support matrix and doc for VGPU https://review.openstack.org/539266 | 21:51 |
*** mvenesio has quit IRC | 21:53 | |
*** mvenesio has joined #openstack-nova | 21:54 | |
*** slaweq has quit IRC | 21:55 | |
mriedem | dansmith: want to hit these backports? I didn't realize those weren't merged by now https://review.openstack.org/#/q/Ie70c77db753711e1449e99534d3b83669871943f+status:open | 21:56 |
mmedvede | mriedem: I do not see anything too far out of ordinary, which powerkvm ci unhappiness are you referring to? | 21:56 |
mmedvede | double checking now | 21:57 |
*** felipemonteiro has quit IRC | 21:57 | |
mriedem | mmedvede: https://review.openstack.org/#/c/538510/ | 21:57 |
mriedem | https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/nova/10/538510/3/check/tempest-dsvm-full-xenial/41f1c6d/ | 21:57 |
*** eharney has quit IRC | 21:57 | |
*** felipemonteiro has joined #openstack-nova | 21:57 | |
*** gjayavelu has joined #openstack-nova | 21:58 | |
*** mvenesio has quit IRC | 21:58 | |
*** mylu has joined #openstack-nova | 21:59 | |
edleafe | efried: PUT {} is not semantically the same as DELETE, even if in most cases the result is the same | 22:01 |
mriedem | cfriesen: speaking of perf, this is an easy fix for an RT perf issue if you're building several instances on the same compute host at once https://review.openstack.org/#/q/Ib588c31a4d2075f8730409d50c99dfb04180a9cd+status:open | 22:04 |
mriedem | our operations people were hitting perf issues with the big RT update lock | 22:04 |
dansmith | mriedem: got em | 22:09 |
efried | edleafe: Oh? How not? | 22:10 |
efried | edleafe: Oh, you mean in the general case, where None and {} aren't the same thing. | 22:10 |
prometheanfire | win 30 | 22:10 |
edleafe | efried: No. Sometimes you need to indicate if anything was in fact deleted. PUT {} can't do that; DELETE can | 22:11 |
*** edmondsw has quit IRC | 22:11 | |
efried | edleafe: It can? How? | 22:12 |
*** edmondsw has joined #openstack-nova | 22:12 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Pass the correct image to build_request_spec in conductor.rebuild_instance https://review.openstack.org/516404 | 22:12 |
*** tidwellr has quit IRC | 22:13 | |
*** priteau has joined #openstack-nova | 22:13 | |
*** salv-orlando has joined #openstack-nova | 22:14 | |
mmedvede | mriedem: that pkvmci failure seems to have been a fluke on that VM, one of a kind. Sorry for the false negative. | 22:14 |
edleafe | efried: In cases where that distinction is important, you can return a 404 if the thing you're trying to delete is not there | 22:14 |
sean-k-mooney | the ibm powerkvm ci is still broken currently correct? | 22:15 |
edleafe | efried: Like I said, it isn't usually necessary. When you want to delete something, you usually just want it gone. | 22:15 |
efried | edleafe: Okay, then I'm specifically talking about resource provider inventories, traits, allocations, and aggregates. | 22:15 |
efried | edleafe: I can provide a good argument for why we should favor PUT <empty> over DELETE (at least DELETE as currently implemented). I'm trying to figure out if there's an argument for the other side. | 22:16 |
edleafe | efried: for those cases, I simply prefer the grammar of DELETE | 22:16 |
mmedvede | sean-k-mooney: I am confused as to why you think so. It did have a few failures, but failure rate is within normal | 22:17 |
*** edmondsw has quit IRC | 22:17 | |
efried | edleafe: The grammar of the request (as opposed to the (lack of) response), right? | 22:17 |
edleafe | efried: That's what DELETE is designed to do. | 22:17 |
edleafe | efried: No, PUT {} is an awkward way of saying DELETE | 22:17 |
*** rcernin has quit IRC | 22:18 | |
efried | edleafe: Yeah, I get it. Is it "wrong" (in the annals of HTTP, or REST, or APIs, or whatever) for a DELETE API to return a payload? | 22:18 |
sean-k-mooney | efried: yes i belive it is not ment to have a payload generally | 22:20 |
edleafe | efried: Unless the response is 204. | 22:20 |
mmedvede | sean-k-mooney: am I missing something? Both http://ci-watch.tintri.com/project?project=nova and https://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/index.html do not indicate a systemic failure on nova patches | 22:21 |
mmedvede | for powerkvm ci | 22:21 |
sean-k-mooney | mmedvede: there was a message a week or two saying it was i was not sure if it was fixed or not | 22:21 |
edleafe | efried: Othewise, you can return either a description of the deleted resource (200) or a URL to check for success/failure on a 202. | 22:21 |
efried | edleafe: So it'd be acceptable for a DELETE to return 200 with a payload? | 22:22 |
edleafe | efried: it's required | 22:23 |
mriedem | sean-k-mooney: are you thinking of the zvm ci? | 22:23 |
mriedem | or zkvm i mean | 22:23 |
efried | edleafe: Sorry, I mean I get that it's cool for DELETE to respond 204 with no content; I'm asking whether there's any restriction - standard-wise or cultural - against a DELETE responding 200 with a payload. | 22:23 |
mriedem | mmedvede: i had seen some other pkvm ci failures in stable branches, but those might have been old/transient | 22:24 |
efried | and I think you've said that's acceptable. | 22:24 |
edleafe | efried: yes, it's acceptable, although it isn't very common | 22:24 |
sean-k-mooney | mriedem: yes i was https://www.mail-archive.com/openstack-dev@lists.openstack.org/msg115082.html | 22:26 |
mriedem | sean-k-mooney: mixing up one of the dozen ibm 3rd party CIs is grounds for pistols at dawn | 22:27 |
*** yamamoto has joined #openstack-nova | 22:27 | |
*** priteau has quit IRC | 22:27 | |
*** felipemonteiro__ has joined #openstack-nova | 22:27 | |
mmedvede | mriedem: yes, stable branches have high rate of failure unfortunately, I'll shift some time to look at those. | 22:28 |
sean-k-mooney | mriedem: haha well the grenade job is failing because of a ubuntu keyring missing on the powervm ci too but that could be intermitent | 22:28 |
mmedvede | sean-k-mooney: that is intermittent, there is a bug in ubuntu somewhere that we reported | 22:29 |
*** sapcc-bot has quit IRC | 22:29 | |
*** jackie-truong has quit IRC | 22:29 | |
mmedvede | it happens only last 10 minutes of any hour | 22:29 |
sean-k-mooney | mmedvede: ya the patch i noticed it on is for rocky anyway so im not going to waste ci time rechecking | 22:30 |
*** felipemonteiro has quit IRC | 22:31 | |
*** esberglu has quit IRC | 22:32 | |
sean-k-mooney | anyway i have fixed my unrelated ovs db socket somehow became a directory and broke everything issue with kolla so im going to head home for the evening | 22:32 |
efried | edleafe: btw, in case it wasn't obvious, this is pursuant to what we were discussing the other day. Without a response payload, we have to assume things about the effect of DELETE on provider generation. One possible solution is to use PUT <empty> where available, which it happens to be for all of these. Another is to implement DELETE with a response payload from which we can glean the new generation. | 22:32 |
*** sapcc-bot has joined #openstack-nova | 22:34 | |
edleafe | efried: Aren't we sending the generation along with the PUT/DELETE request? | 22:36 |
*** fragatina has joined #openstack-nova | 22:36 | |
efried | edleafe: With PUT, yes. Not with DELETE, which doesn't accept a payload. The latter is a definite (but separate) problem. | 22:37 |
efried | edleafe: But even the former only guarantees that we're deleting what we thought we were deleting. The lack of generation in the return is a problem for *subsequent* updates. | 22:37 |
*** fragatina has quit IRC | 22:37 | |
*** fragatina has joined #openstack-nova | 22:37 | |
efried | ...unless we continue to make assumptions about how placement does generations. Which IMO is wrong. | 22:38 |
edleafe | efried: So say I get the generation back from the PUT/DELETE. Right after that, other requests modify the resource. What good does getting back gen+1 from the request do me then? | 22:38 |
*** lyan has quit IRC | 22:39 | |
efried | edleafe: In that scenario, it doesn't save you anything, because your next update will 409 and you have to re-GET the provider and its associated stuff before you redrive your update. | 22:39 |
efried | edleafe: It's in the scenario where the resource provider *doesn't* change that it saves us. | 22:40 |
edleafe | efried: I still don't see that | 22:40 |
efried | edleafe: Because without it, we *have* to do that re-GET in order to glean the new generation. | 22:40 |
efried | (again, unless assumptions) | 22:40 |
edleafe | efried: Oh, you're still pretending that we don't know how generations work | 22:41 |
efried | Correct. | 22:41 |
edleafe | The name itself should be a giveaway | 22:41 |
efried | say wha? | 22:41 |
efried | Please tell me you're joking | 22:41 |
edleafe | no, I'm not | 22:41 |
efried | We're not going to assume API behavior based on the dictionary definition of an ambiguous English word with lots of synonyms. | 22:42 |
efried | even if any one of those definitions said "and we start at 0, and the next one is +1" - which they don't. | 22:42 |
edleafe | We adopted generations over other candidates, such as etags, precisely because we *could* make these assumptions | 22:43 |
edleafe | I understand that we have not documented that behavior well enough for outsiders | 22:43 |
efried | Or insiders, apparently. I think I qualify. | 22:43 |
edleafe | But within the placement dev team, it was clear | 22:43 |
edleafe | were you in the discussions about what to use? | 22:44 |
efried | Oh, by "outsiders" did you mean whoever wasn't in the design discussion? | 22:44 |
edleafe | yes | 22:44 |
* mriedem gets the bucket of cold water | 22:44 | |
efried | I thought you meant people who aren't developers of the placement API. | 22:44 |
edleafe | well, you have seemed to pick up on the way it works :_ | 22:45 |
*** hemna_ has quit IRC | 22:45 | |
efried | Yes, and I vociferously contend that we have not documented that behavior well enough. | 22:45 |
edleafe | and I will vociferously agree with that | 22:46 |
efried | In any case, based on last week's straw poll, I don't think there's consensus even among people who were in the room when it was designed. | 22:46 |
efried | ...as to whether the behavior should be an explicit, documented part of the API. | 22:46 |
edleafe | some of us weren't happy with the choice :( | 22:46 |
mriedem | you guys are talking about a decision made a couple of years ago right? | 22:46 |
mriedem | in a kind of 'shit or get off the pot' situation? | 22:46 |
edleafe | mriedem: well, about a year or so I think | 22:46 |
mriedem | not knowing what we'd be doing with these things several releases later | 22:47 |
efried | mriedem: We're not even arguing the decision to implement generation a certain way. I don't think anyone has a problem with that. | 22:47 |
edleafe | there was the opaque marker (etag) proponents, and the deterministic marker (generation) camp | 22:47 |
mriedem | a year would have been the ATL PTG and it seems older than that, at least BCN | 22:47 |
mriedem | so next step is....documenting how generations work | 22:48 |
mriedem | ? | 22:48 |
*** itlinux has joined #openstack-nova | 22:48 | |
efried | mriedem: Yeah - what's at issue is whether that implementation is supposed to be known by consumers of the API, or whether it's supposed to be opaque. | 22:48 |
mriedem | sorry, i haven't followed this debate the last several times it's come up, but what's the issue? that a client can get a generation that skips increments? | 22:49 |
mriedem | like t1 i get gen 1, t2 i get gen 3? | 22:49 |
efried | Not really. The issue is, can the consumer count on a) generation starts at 0 when you create a new provider; and b) generation increments by 1 when you successfully update something associated with a provider. | 22:50 |
efried | Point being, as currently implemented, yes they can, but do we want that to be explicitly part of the API, or do we want it to be opaque and you shouldn't introspect the generation? | 22:51 |
edleafe | mriedem: IOW, do we want to require that each call to modify a RP is first preceded by a GET to find the current generation? | 22:52 |
*** rcernin has joined #openstack-nova | 22:52 | |
*** itlinux has quit IRC | 22:52 | |
efried | no, not at all. | 22:52 |
efried | that would not be necessary at all. | 22:52 |
mriedem | if the generation the caller passes is in conflict, they get a 409, get the latest generation, merge the request and try again | 22:52 |
mriedem | why would the caller need to know that the generation increments by 1? | 22:53 |
edleafe | efried: how can they pass a generation if they can't assume previous+1? | 22:53 |
mriedem | efried: fwiw i think "can the consumer count on a) generation starts at 0 when you create a new provider; and b) generation increments by 1 when you successfully update something associated with a provider." is fine | 22:54 |
efried | edleafe: Because the response from any update includes the new generation. Since the update was atomic, you know that the payload in the response corresponds to that generation. | 22:54 |
*** sticker has joined #openstack-nova | 22:54 | |
efried | And I can keep my cache consistent with that information. | 22:54 |
*** burt has quit IRC | 22:55 | |
efried | And the problem arises any time there's an update from whose response I can't glean the new generation. Like DELETE inventory, allocations, traits (and someday maybe aggregates) | 22:55 |
efried | mriedem: Duly noted. I think your vote splits us clean down the middle. | 22:56 |
*** armax has quit IRC | 22:56 | |
mriedem | consider it a very limp vote | 22:56 |
efried | If I'm remembering right, we have mriedem cdent edleafe on one side, and efried dansmith jaypipes on the other. | 22:57 |
mriedem | well, i also agree that "you shouldn't introspect the generation" | 22:57 |
edleafe | and IIRC, it was jaypipes advocating for the gen+1 back in the day | 22:57 |
mriedem | like i said above, as a client, try the request, if it fails, fetch the latest thing, merge the result client side and try again | 22:58 |
*** andreas_s has joined #openstack-nova | 22:58 | |
edleafe | for the very reason that you *could* assume those things | 22:58 |
efried | edleafe: Not to put words in his mouth, but he may have been advocating the monotonic integer implementation without advocating that that implementation be transparent to the API consumer. | 22:58 |
edleafe | efried: that would have no advantage over something like etag | 22:58 |
mriedem | i sure hope this is blocking the most important thing that anyone is ever going to be working on...because it sures feels like it | 22:59 |
edleafe | it was that advantage that was the main argument | 22:59 |
edleafe | mriedem: it's just that we went through this a while ago, and now it's being dragged up again for the very reason it was chosen in the first place | 23:00 |
mriedem | fair | 23:01 |
mriedem | but, | 23:01 |
mriedem | it's 5:02 and i'm out of here suckas | 23:02 |
*** mriedem is now known as mriedem_afk | 23:02 | |
efried | later mriedem | 23:02 |
openstackgerrit | Merged openstack/nova master: Cleanup redundant want_version assignment. https://review.openstack.org/535801 | 23:02 |
openstackgerrit | Merged openstack/nova master: Add debug output for selected page size https://review.openstack.org/530662 | 23:02 |
*** andreas_s has quit IRC | 23:02 | |
*** munishmehan has quit IRC | 23:02 | |
openstackgerrit | Merged openstack/nova master: api-ref: Fix parameter type in server-migrations.inc https://review.openstack.org/536293 | 23:02 |
efried | edleafe, if the decision was made definitively after lots of discussion, how is it that there's such contention now, even among folks who were apparently part of the decision? | 23:03 |
*** dave-mccowan has quit IRC | 23:03 | |
efried | I would have expected those people to grumble about how it wasn't what they would have chosen, but it's what we decided on, and we'd have a path forward. | 23:03 |
edleafe | efried: that's hard for me to understand. Both cdent and I were arguing for etags, and now we're both saying "well, we got monotonically increasing integers, so let's use 'em!" | 23:05 |
*** brault has joined #openstack-nova | 23:05 | |
efried | And the folks who argued for monotonic ints are saying they should be opaque? | 23:05 |
edleafe | weird, huh? | 23:06 |
efried | fkinaye | 23:06 |
openstackgerrit | Merged openstack/nova master: Merge server create schema for availability zone extension https://review.openstack.org/451331 | 23:06 |
openstackgerrit | Merged openstack/nova master: Merge server create for availability zone extension https://review.openstack.org/502574 | 23:06 |
openstackgerrit | Merged openstack/nova master: [placement] Add functional tests for resource class API https://review.openstack.org/524506 | 23:07 |
*** damien_r has joined #openstack-nova | 23:08 | |
*** brault has quit IRC | 23:09 | |
*** yamamoto_ has joined #openstack-nova | 23:12 | |
*** sdague has quit IRC | 23:13 | |
*** damien_r has quit IRC | 23:13 | |
*** yamamoto has quit IRC | 23:15 | |
*** salv-orlando has quit IRC | 23:21 | |
*** salv-orlando has joined #openstack-nova | 23:22 | |
*** gjayavelu has quit IRC | 23:23 | |
*** Tom-Tom has joined #openstack-nova | 23:25 | |
*** salv-orlando has quit IRC | 23:26 | |
*** damien_r has joined #openstack-nova | 23:28 | |
*** Tom-Tom has quit IRC | 23:29 | |
*** gjayavelu has joined #openstack-nova | 23:30 | |
*** damien_r has quit IRC | 23:33 | |
*** slaweq has joined #openstack-nova | 23:40 | |
*** yamahata has quit IRC | 23:44 | |
*** slaweq has quit IRC | 23:45 | |
*** takashin has joined #openstack-nova | 23:46 | |
*** suresh12 has joined #openstack-nova | 23:47 | |
*** damien_r has joined #openstack-nova | 23:48 | |
*** stakeda has joined #openstack-nova | 23:49 | |
*** damien_r has quit IRC | 23:52 | |
*** rcernin has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!