Wednesday, 2018-01-31

*** hongbin has quit IRC00:18
*** awaugama has quit IRC00:19
*** zhurong has joined #openstack-nova00:21
*** salv-orlando has joined #openstack-nova00:22
*** salv-orlando has quit IRC00:27
*** kmalloc has quit IRC00:29
openstackgerritMerged openstack/nova master: [placement] Add sending global request ID in delete (3)  https://review.openstack.org/52655700:29
openstackgerritMerged openstack/nova master: Avoid suspending guest with attached vGPUs  https://review.openstack.org/53569300:29
*** yangyapeng has quit IRC00:31
openstackgerritTakashi NATSUME proposed openstack/nova master: Transform live_migration_post_dest notification  https://review.openstack.org/46978400:32
*** chyka has quit IRC00:34
openstackgerritMerged openstack/nova master: Handle TZ change in iso8601 >=0.1.12  https://review.openstack.org/53570000:36
*** zhurong has quit IRC00:37
*** Dinesh_Bhor has joined #openstack-nova00:37
*** hiro-kobayashi has joined #openstack-nova00:42
*** mlavalle has quit IRC00:42
*** markvoelker has quit IRC00:43
*** markvoelker has joined #openstack-nova00:44
openstackgerritTakashi NATSUME proposed openstack/nova master: [placement] Separate API schemas (resource_provider)  https://review.openstack.org/52862900:44
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove unnecessary arguments in notification methods  https://review.openstack.org/53559900:45
*** Dinesh_Bhor has quit IRC00:47
*** mlavalle has joined #openstack-nova00:48
*** markvoelker has quit IRC00:48
*** liusheng has quit IRC00:49
*** zhurong has joined #openstack-nova00:49
*** hshiina has joined #openstack-nova00:51
*** Dinesh_Bhor has joined #openstack-nova00:51
*** damien_r has joined #openstack-nova00:58
*** Dinesh_Bhor has quit IRC01:01
*** damien_r has quit IRC01:02
openstackgerritNakanishi Tomotaka proposed openstack/nova master: Use Placement API to check resource usage  https://review.openstack.org/52895301:03
*** gjayavelu has quit IRC01:03
*** r-daneel has quit IRC01:04
*** owalsh has quit IRC01:05
*** owalsh_ has joined #openstack-nova01:05
*** owalsh_ is now known as owalsh01:06
*** rcernin has joined #openstack-nova01:09
openstackgerritZhenyu Zheng proposed openstack/nova master: Invalid query parameter could lead to HTTP 500  https://review.openstack.org/53916401:13
*** dave-mccowan has joined #openstack-nova01:13
*** slaweq has joined #openstack-nova01:13
*** felipemonteiro__ has quit IRC01:14
*** hieulq_ has quit IRC01:15
*** slaweq has quit IRC01:18
*** gongysh has joined #openstack-nova01:19
*** zhaochao has joined #openstack-nova01:20
*** takashin has quit IRC01:20
*** yangyapeng has joined #openstack-nova01:21
*** hieulq_ has joined #openstack-nova01:27
*** tiendc has joined #openstack-nova01:29
*** damien_r has joined #openstack-nova01:30
*** markvoelker has joined #openstack-nova01:30
*** damien_r has quit IRC01:34
*** tbachman has joined #openstack-nova01:35
mriedem_afkwoot vgpu patch finally merged https://review.openstack.org/#/c/535693/01:35
mriedem_afkalex_xu: want to hit this release note for versioned notification transformation for queens? https://review.openstack.org/#/c/518018/01:37
*** mriedem_afk is now known as mriedem01:37
Spazmotichow are you awake even more than me01:42
mriedemit's 7:4501:43
Spazmotic..so it is01:43
Spazmoticsorry.. third shift.. sometimes my hours don't make sense01:43
mriedemexercise, vegetables and clean living01:43
SpazmoticThat's my lifestyle as well the past year.. I respect it:)01:44
SpazmoticNowadays I use my Racker picture on my badge as inspiration.. have lost 170lbs.  But still.. Third Shift hours and having a fiancee in Korea make my hours ridiculous hehe01:45
openstackgerritMatt Riedemann proposed openstack/nova master: Add get_traits() method to ComputeDriver  https://review.openstack.org/53229001:46
openstackgerritMatt Riedemann proposed openstack/nova master: Implement get_traits() for the ironic virt driver  https://review.openstack.org/53228801:46
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional tests for virt driver get_traits() method  https://review.openstack.org/53804701:46
openstackgerritMatt Riedemann proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits  https://review.openstack.org/53849801:46
bkero-That's a crazy schedule. That must have very little overlap.01:46
SpazmoticIt could be worse.. The good thing is that Korea daytime and third shift US are pretty lined up, but right now outside of DST the time diff is a little mor difficult.01:46
bkero-gotta get those remote working privs01:47
bkero-then korea01:47
mriedemefried: looks like the nrp series has a merge conflict starting here now https://review.openstack.org/#/c/521098/3001:48
*** yassine has joined #openstack-nova01:48
SpazmoticHaha I tried.. something about not having a presence in South Korea so they cannot have a remote worker there or something01:48
*** yassine is now known as Guest6182401:48
*** hoangcx has quit IRC01:48
bkero-Yeah, it's hard to ask for permission01:48
mriedemaustralia01:49
mriedemrax is there01:49
mriedemthen at least the tz is closer01:49
SpazmoticWell also HKG01:49
SpazmoticBut we are settling for bringing her here01:49
SpazmoticJust waiting on VISA stuff01:49
mriedemdon't tell trump01:49
Spazmoticdunno why i thought that was an anagram01:49
Spazmoticit's early01:49
SpazmoticYeah it's totes hush hush, just letting you openstack fellows know.. DON'T TELL TRUMP01:49
mriedemhe'd actually be in bed eating by now if it weren't for some speech he has to give tonight01:50
SpazmoticI'd imagine he's still doing that thing01:51
SpazmoticJust speech from bed with giant slippers01:51
SpazmoticGlow of his own TV show shining on his face or something, and some chicken in a bucket.01:51
SpazmoticSwinging a drumstick around01:51
*** salv-orlando has joined #openstack-nova01:53
*** Tom-Tom has joined #openstack-nova01:53
*** takashin has joined #openstack-nova01:54
mriedemalex_xu: looks like your allocation candidates + traits gabbi tests are intermittently failing http://logs.openstack.org/10/539310/1/check/nova-tox-functional/a6ba562/job-output.txt.gz#_2018-01-30_21_02_40_41470901:56
*** hoangcx has joined #openstack-nova01:56
*** fragatina has quit IRC01:56
*** salv-orlando has quit IRC01:57
*** fragatina has joined #openstack-nova01:58
mriedemhttps://bugs.launchpad.net/nova/+bug/174638802:00
openstackLaunchpad bug 1746388 in OpenStack Compute (nova) "allocation candidates with invalid traits negative functional tests are intermittently failing" [High,Confirmed]02:00
mriedemalex_xu: ah nevermind efried found the issue https://review.openstack.org/#/c/537351/3/nova/api/openstack/placement/util.py02:01
*** takashin has left #openstack-nova02:02
*** Dinesh_Bhor has joined #openstack-nova02:02
*** fragatina has quit IRC02:02
*** gongysh has quit IRC02:03
*** Dinesh_Bhor has quit IRC02:05
*** Dinesh_Bhor has joined #openstack-nova02:05
*** damien_r has joined #openstack-nova02:06
*** Dinesh_Bhor has quit IRC02:08
*** damien_r has quit IRC02:11
*** zhaochao has quit IRC02:11
*** Swami has quit IRC02:11
*** harlowja has quit IRC02:15
*** mriedem has quit IRC02:17
*** zhaochao has joined #openstack-nova02:24
*** liusheng has joined #openstack-nova02:34
*** rcernin has quit IRC02:35
*** Tom-Tom_ has joined #openstack-nova02:44
*** Tom-Tom has quit IRC02:45
openstackgerritHironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue  https://review.openstack.org/41648702:50
*** Spaz-Work has quit IRC02:53
*** Spaz-Work has joined #openstack-nova02:55
*** Dinesh_Bhor has joined #openstack-nova02:55
openstackgerritTetsuro Nakamura proposed openstack/nova master: Add unit tests for EmulatorThreadsTestCase  https://review.openstack.org/53869902:58
openstackgerritTetsuro Nakamura proposed openstack/nova master: Not use thread alloc policy for emulator thread  https://review.openstack.org/53870002:58
*** andreas_s has joined #openstack-nova02:59
*** andreas_s has quit IRC03:03
*** suresh12 has quit IRC03:04
*** suresh12 has joined #openstack-nova03:04
*** tbachman has quit IRC03:04
*** Pramod has quit IRC03:05
*** armax has joined #openstack-nova03:05
*** Dinesh_Bhor has quit IRC03:06
*** ttsiouts has quit IRC03:07
*** ttsiouts has joined #openstack-nova03:07
alex_xumrodden: got it, let me fix it03:08
alex_xumrodden: sorry, I should speak to mriedem03:09
*** suresh12 has quit IRC03:09
*** armax has quit IRC03:10
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Use util.validate_query_params in list_traits  https://review.openstack.org/53940703:12
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: [Placement] Invalid query parameter could lead to HTTP 500  https://review.openstack.org/53940803:12
*** armax has joined #openstack-nova03:16
openstackgerritJianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node  https://review.openstack.org/52334203:18
*** damien_r has joined #openstack-nova03:19
*** hongbin has joined #openstack-nova03:19
*** Tom-Tom_ has quit IRC03:20
*** mgagne has quit IRC03:22
*** melwitt has quit IRC03:23
*** mgagne has joined #openstack-nova03:24
*** mgagne is now known as Guest8724003:24
*** toan has quit IRC03:24
*** damien_r has quit IRC03:24
*** melwitt has joined #openstack-nova03:25
*** tbachman has joined #openstack-nova03:25
*** toan has joined #openstack-nova03:26
*** suresh12 has joined #openstack-nova03:29
*** suresh12 has quit IRC03:33
*** felipemonteiro has joined #openstack-nova03:39
*** liusheng has quit IRC03:40
*** liusheng has joined #openstack-nova03:40
*** felipemonteiro_ has joined #openstack-nova03:42
*** felipemonteiro has quit IRC03:45
*** felipemonteiro_ has quit IRC03:45
*** felipemonteiro__ has joined #openstack-nova03:45
*** sree has joined #openstack-nova03:45
*** zhurong has quit IRC03:46
*** felipemonteiro_ has joined #openstack-nova03:46
*** felipemonteiro__ has quit IRC03:50
*** salv-orlando has joined #openstack-nova03:54
openstackgerritEric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root  https://review.openstack.org/52109803:58
efriedWell, that didn't work.03:59
*** salv-orlando has quit IRC04:00
*** abhishekk has joined #openstack-nova04:01
*** hiro-kobayashi has quit IRC04:02
*** yamahata has joined #openstack-nova04:06
*** moshele has joined #openstack-nova04:08
*** felipemonteiro__ has joined #openstack-nova04:11
*** felipemonteiro_ has quit IRC04:11
*** fragatina has joined #openstack-nova04:11
*** moshele has quit IRC04:12
*** psachin has joined #openstack-nova04:12
*** moshele has joined #openstack-nova04:12
*** fragatina has quit IRC04:16
*** moshele has quit IRC04:18
*** mlavalle has quit IRC04:21
*** sridharg has joined #openstack-nova04:24
*** david-lyle has quit IRC04:26
*** felipemonteiro__ has quit IRC04:26
*** david-lyle has joined #openstack-nova04:27
*** dave-mccowan has quit IRC04:32
*** sridharg has quit IRC04:37
*** armax has quit IRC04:37
*** ircuser-1 has joined #openstack-nova04:44
*** slaweq has joined #openstack-nova04:45
*** suresh12 has joined #openstack-nova04:49
*** slaweq has quit IRC04:50
*** rcernin has joined #openstack-nova04:50
*** harlowja has joined #openstack-nova04:51
*** rcernin has quit IRC04:51
*** rcernin has joined #openstack-nova04:52
*** ratailor has joined #openstack-nova05:03
*** markvoelker has quit IRC05:06
*** links has joined #openstack-nova05:07
*** fragatina has joined #openstack-nova05:08
*** fragatina has quit IRC05:09
*** moshele has joined #openstack-nova05:10
*** jose-phi_ has joined #openstack-nova05:10
*** jaypipes has quit IRC05:10
*** jaypipes has joined #openstack-nova05:11
*** crushil has quit IRC05:11
*** crushil has joined #openstack-nova05:11
*** jose-phillips has quit IRC05:13
*** crushil has quit IRC05:16
*** slaweq has joined #openstack-nova05:19
openstackgerritMerged openstack/nova master: Add taskflow to requirements  https://review.openstack.org/53377905:19
*** salv-orlando has joined #openstack-nova05:20
*** slaweq has quit IRC05:24
*** mylu has quit IRC05:24
*** hongbin has quit IRC05:26
*** suresh12 has quit IRC05:32
*** suresh12 has joined #openstack-nova05:33
*** Tom-Tom has joined #openstack-nova05:34
*** suresh12 has quit IRC05:37
*** mdnadeem has joined #openstack-nova05:41
*** zhurong has joined #openstack-nova05:47
*** threestrands has quit IRC05:51
*** armax has joined #openstack-nova05:52
*** xinliang has quit IRC05:57
*** salv-orlando has quit IRC05:58
*** salv-orlando has joined #openstack-nova05:59
openstackgerritRajesh Tailor proposed openstack/nova master: Allow force-delete even if task_state is not None  https://review.openstack.org/53087906:00
*** threestrands has joined #openstack-nova06:01
*** threestrands has quit IRC06:01
*** threestrands has joined #openstack-nova06:01
*** jaypipes has quit IRC06:02
*** Eran_Kuris has joined #openstack-nova06:04
openstackgerritMerged openstack/nova master: Updated from global requirements  https://review.openstack.org/53847306:04
*** jaypipes has joined #openstack-nova06:04
*** brault has joined #openstack-nova06:06
*** xinliang has joined #openstack-nova06:09
*** brault has quit IRC06:10
*** trinaths has joined #openstack-nova06:18
*** xinliang has quit IRC06:21
*** xinliang has joined #openstack-nova06:22
*** lajoskatona has joined #openstack-nova06:23
*** Eran_Kuris has quit IRC06:27
*** liuzz has joined #openstack-nova06:30
*** lpetrut has joined #openstack-nova06:31
*** armax has quit IRC06:40
*** jaypipes has quit IRC06:43
*** jaypipes has joined #openstack-nova06:43
*** sree_ has joined #openstack-nova06:43
*** sree_ is now known as Guest3658506:44
*** sree has quit IRC06:45
*** suresh12 has joined #openstack-nova06:48
*** zhurong has quit IRC06:49
*** slaweq has joined #openstack-nova06:52
*** suresh12 has quit IRC06:53
*** lpetrut has quit IRC06:54
*** lpetrut has joined #openstack-nova06:54
*** slaweq has quit IRC06:56
*** jaypipes has quit IRC07:00
*** jaypipes has joined #openstack-nova07:00
*** harlowja has quit IRC07:01
*** itlinux has joined #openstack-nova07:02
*** zhenguo has joined #openstack-nova07:05
*** rcernin has quit IRC07:08
*** trinaths has quit IRC07:09
*** markvoelker has joined #openstack-nova07:11
*** salv-orlando has quit IRC07:12
*** itlinux has quit IRC07:15
openstackgerritRadoslav Gerganov proposed openstack/nova master: Insert the description of the change.  https://review.openstack.org/53943207:20
*** sridharg has joined #openstack-nova07:20
*** lpetrut has quit IRC07:21
*** jaosorior has quit IRC07:26
*** gongysh has joined #openstack-nova07:29
*** andreas_s has joined #openstack-nova07:30
*** lpetrut has joined #openstack-nova07:30
*** gongysh has quit IRC07:35
*** zhurong has joined #openstack-nova07:38
*** pooja-jadhav is now known as pooja_jadhav07:39
*** brault has joined #openstack-nova07:39
*** markvoelker has quit IRC07:42
*** jaosorior has joined #openstack-nova07:43
*** slaweq has joined #openstack-nova07:43
*** salv-orlando has joined #openstack-nova07:44
*** slaweq has quit IRC07:48
*** pcaruana has joined #openstack-nova07:51
*** AlexeyAbashkin has joined #openstack-nova07:51
*** AlexeyAbashkin has quit IRC07:51
*** AlexeyAbashkin has joined #openstack-nova07:52
*** lpetrut has quit IRC07:53
openstackgerritNakanishi Tomotaka proposed openstack/nova master: Use Placement API to check resource usage  https://review.openstack.org/52895307:59
*** salv-orl_ has joined #openstack-nova07:59
*** salv-orlando has quit IRC08:01
*** amoralej|off is now known as amoralej08:02
*** alexchadin has joined #openstack-nova08:05
*** sree has joined #openstack-nova08:08
*** slaweq has joined #openstack-nova08:08
*** Guest36585 has quit IRC08:11
*** slaweq has quit IRC08:13
*** vivsoni__ has joined #openstack-nova08:14
*** vivsoni_ has quit IRC08:14
*** trinaths has joined #openstack-nova08:15
openstackgerritMerged openstack/nova master: libvirt: QEMU native LUKS decryption for encrypted volumes  https://review.openstack.org/52395808:15
openstackgerritMerged openstack/nova master: Add release note for QEMU native LUKS decryption  https://review.openstack.org/53764208:15
*** rcernin has joined #openstack-nova08:16
*** ralonsoh has joined #openstack-nova08:16
openstackgerritAlex Xu proposed openstack/nova master: Fix nits in support traits changes  https://review.openstack.org/53735108:17
openstackgerritAlex Xu proposed openstack/nova master: Mention required traits in the flavors user docs  https://review.openstack.org/53930008:17
openstackgerritAlex Xu proposed openstack/nova master: Add functional tests for traits-based scheduling  https://review.openstack.org/53931008:17
*** slaweq has joined #openstack-nova08:18
*** slaweq_ has joined #openstack-nova08:19
*** tesseract has joined #openstack-nova08:20
*** itlinux has joined #openstack-nova08:20
*** kwathore has quit IRC08:21
openstackgerritMerged openstack/nova master: ProviderTree.new_child: parent is either uuid or name  https://review.openstack.org/53826408:21
*** kwathore has joined #openstack-nova08:22
*** slaweq has quit IRC08:22
*** ralonsoh has quit IRC08:23
*** sahid has joined #openstack-nova08:23
*** salv-orl_ has quit IRC08:24
*** ralonsoh has joined #openstack-nova08:26
*** rcernin has quit IRC08:26
*** ragiman has joined #openstack-nova08:27
*** lpetrut has joined #openstack-nova08:28
*** janki has joined #openstack-nova08:31
*** sinese has joined #openstack-nova08:37
*** markvoelker has joined #openstack-nova08:39
openstackgerritZhenyu Zheng proposed openstack/nova master: Invalid query parameter could lead to HTTP 500  https://review.openstack.org/53916408:39
*** lpetrut has quit IRC08:40
*** jpena|off is now known as jpena08:43
*** salv-orlando has joined #openstack-nova08:45
*** zhurong_ has joined #openstack-nova08:46
*** edmondsw has joined #openstack-nova08:50
*** namnh has joined #openstack-nova08:54
*** edmondsw has quit IRC08:54
*** janki is now known as janki|afk08:55
*** diga has joined #openstack-nova08:55
*** chyka has joined #openstack-nova08:59
*** tuanla____ has joined #openstack-nova09:01
*** rmart04 has joined #openstack-nova09:01
bauzasmorning Novaers09:03
* bauzas rolls eyes at the gate09:03
*** chyka has quit IRC09:04
*** rcernin has joined #openstack-nova09:05
*** yamahata has quit IRC09:06
openstackgerritZhenyu Zheng proposed openstack/nova master: Improve performance when list instances with IP filter  https://review.openstack.org/53946909:12
*** markvoelker has quit IRC09:12
SpazmoticMorning09:18
*** stakeda has quit IRC09:21
*** janki|afk is now known as janki09:21
*** hshiina has quit IRC09:22
*** rmart04 has quit IRC09:30
SpazmoticLast day of my weekend.. then just 4 days and work and finally 2 weeks in KOrea to relax09:36
*** diga has quit IRC09:39
*** derekh has joined #openstack-nova09:41
SpazmoticGoing to take the rest of the day off and avoid python.. have a good night all, will be afk :)09:44
openstackgerritblkart proposed openstack/nova-specs master: don't show description content in code-block  https://review.openstack.org/53947809:50
*** zhenguo has quit IRC09:53
bauzasjianghuaw: not sure you saw https://review.openstack.org/#/c/539266/209:54
jianghuawbauzas, yes. I saw it. Just have not got chance to check it due to having been occupied by a kolla deployment problem.10:01
jianghuawthanks for asking, surely will look at it before I leave office.10:01
openstackgerritRajesh Tailor proposed openstack/nova master: Allow force-delete even if task_state is not None  https://review.openstack.org/53087910:01
*** abhishekk has quit IRC10:02
bauzasjianghuaw: ideally, you could make a follow-up with the Xen notes10:04
jianghuawSure.10:05
*** lpetrut has joined #openstack-nova10:07
*** lpetrut_ has joined #openstack-nova10:09
*** markvoelker has joined #openstack-nova10:09
*** lpetrut has quit IRC10:12
*** annp has quit IRC10:14
*** namnh has quit IRC10:15
*** priteau has joined #openstack-nova10:19
*** zhurong has quit IRC10:19
*** sdague has joined #openstack-nova10:20
*** bhagyashri_s is now known as bhagyashris10:24
*** sambetts|afk is now known as sambetts10:27
*** maciejjozefczyk_ is now known as maciejjozefczyk10:27
*** Eran_Kuris has joined #openstack-nova10:28
amotokihi, i have a question on 'host' parameters in os-aggregates and os-migrateLive API.10:31
amotokiI am working on https://review.openstack.org/#/c/538472/ (in horizon).10:31
amotokiin nova API there are two types of "host". the one is from os-services and the other is from os-hypervisors.10:32
amotokiI checked the API reference but I am still not clear which is expected for "hosts" in os-aggregates and "host" in migrateLive (and migrate) action.10:33
amotokithanks in advance.10:34
*** jafeha__ has joined #openstack-nova10:35
*** jafeha has quit IRC10:35
bauzasamotoki: it refers to the os-services hostname10:35
amotokibauzas: thanks. is it true for both?10:36
bauzasamotoki: well, there is a confusion10:36
*** dtantsur|afk is now known as dtantsur10:36
bauzasamotoki: long story short, hypervisors provide their own hostnames, so we have a tuple (service hostname, hypervisor hostname) identifying a single node10:37
bauzasfor most of our virt drivers, a compute service only serves a single hypervisor10:37
*** gszasz has joined #openstack-nova10:37
bauzasso there is no real problem in adressing the host itself by its service name10:37
bauzasbut for ironic, that paradigm isn't true10:37
bauzassince a single compute service serves for all the ironic nodes10:38
amotokii think the same thing happens for vmware (vcenter) driver.10:38
bauzasno10:38
bauzasbecause nova sees the vCloud as a single node10:38
bauzashow it's managed within that cloud is beyond its view10:39
amotokidoes nova consider vCloud as a big host?10:39
bauzasexactly10:39
bauzasfrom a scheduling perspective10:39
bauzaswhich is what aggregates are for :)10:39
amotokiaggregates refer to service host name, so how can we distinguish individual hosts? is it determined based on aggregate metadata?10:41
*** markvoelker has quit IRC10:42
ameedaHello, what is the different between "self.volume_api.detach" and " self._detach_volumes" in nova manager ?10:42
*** Tom-Tom has quit IRC10:44
bauzasamotoki: sorry, was at the coffee machine10:45
amotokibauzas: no problem. thanks for your support10:45
*** josecastroleon has joined #openstack-nova10:46
bauzasamotoki: so, the answer is "that's not supported"10:46
bauzasamotoki: all the Aggregate API logic is based on services checks10:47
bauzasamotoki: that means that if you use ironic and want aggregates, you will only shard your cloud by the compute services, that's it, not by your ironic deployment10:47
*** zhurong_ has quit IRC10:48
bauzascall it a limitation10:48
bauzasfrom my perspective, it's just that ironic introduced a new paradigm (N hypervisors for a single service) without changing the Nova API, which is why it's broken10:48
*** lucas-afk is now known as lucasagomes10:48
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Encode libvirt domain XML in UTF-8  https://review.openstack.org/52216110:49
amotokibauzas: thanks for clarification. I see the current logic and it is good to know that :)10:50
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Fix typos in release notes  https://review.openstack.org/53949010:51
*** salv-orlando has quit IRC10:52
*** andreas_s has quit IRC10:52
*** salv-orlando has joined #openstack-nova10:52
*** belmoreira has joined #openstack-nova10:52
*** andreas_s has joined #openstack-nova10:56
*** salv-orlando has quit IRC10:57
*** Tom-Tom has joined #openstack-nova10:58
jianghuawbauzas, thanks for creating the documents for vGPU. The patch looks very good. I will add the part for XenAPI.10:59
bauzasjianghuaw: FWIW, I'm also currently working on providing a functional testcase that will use a fake libvirt driver with mdevs11:00
*** trinaths has quit IRC11:00
jianghuawbauzas, thanks for the heads-up.11:00
* bauzas just needs to understand what the hell the fakelibvirt module is doing11:01
jianghuawWhat's I can help on that>11:01
*** mvk has quit IRC11:01
bauzasthere are a couple of libvirt functional tests already, so I'll land that funct test battery into there11:02
bauzasyou could see if Xen got some11:02
jianghuawok. will check it.11:02
*** jmlowe has quit IRC11:02
bauzaslater, we could discuss with other folks if we would maybe have a single test battery that would check both drivers, I dunno yet11:02
*** Tom-Tom has quit IRC11:03
bauzaslike a base test class that would test what's supported by both drivers, and we would just inherit from it11:03
bauzasof course, the setup of that test class would be per-driver11:03
jianghuawsounds good.11:03
bauzasjianghuaw: so, nothing from your side yet I guess11:04
jianghuawok.11:04
bauzasjust maybe if you have time, try to see how to mock your Xen API the less invasive way11:04
jianghuawk11:05
bauzasideally, I wouldn't want to mock every single libvirt call like we do in the unittests, rather just pass a libvirt fixture that would setup my host like I want11:05
bauzashence the fakelibvirt module reading11:05
*** amorin has left #openstack-nova11:05
*** andreas_s has quit IRC11:06
*** andreas_s has joined #openstack-nova11:07
*** alexchadin has quit IRC11:09
*** AlexeyAbashkin has quit IRC11:09
*** tuanla____ has quit IRC11:11
*** andreas_s has quit IRC11:11
*** ratailor has quit IRC11:14
*** AlexeyAbashkin has joined #openstack-nova11:15
*** andreas_s has joined #openstack-nova11:17
*** sinese has quit IRC11:17
*** mdbooth has quit IRC11:21
*** ansiwen has quit IRC11:21
*** andreas_s has quit IRC11:22
*** suresh12 has joined #openstack-nova11:22
*** mdbooth has joined #openstack-nova11:24
*** ansiwen has joined #openstack-nova11:24
*** andreas_s has joined #openstack-nova11:27
*** alexchadin has joined #openstack-nova11:29
*** mvk has joined #openstack-nova11:30
*** alexchadin has quit IRC11:32
*** andreas_s has quit IRC11:36
*** kwathore_ has joined #openstack-nova11:37
*** vivsoni__ has quit IRC11:37
*** vivsoni__ has joined #openstack-nova11:37
*** markvoelker has joined #openstack-nova11:39
*** Eran_Kuris has quit IRC11:39
*** alexchadin has joined #openstack-nova11:39
*** kwathore has quit IRC11:40
*** andreas_s has joined #openstack-nova11:42
*** mdnadeem_ has joined #openstack-nova11:43
openstackgerritMerged openstack/nova master: Fix documentation nits in set_and_clear_allocations  https://review.openstack.org/53100111:44
*** alexchadin has quit IRC11:44
*** mdnadeem has quit IRC11:44
openstackgerritSurya Seetharaman proposed openstack/nova master: Marker reset option for nova-manage map_instances  https://review.openstack.org/53950111:44
*** moshele has left #openstack-nova11:44
*** moshele has joined #openstack-nova11:45
*** mdnadeem has joined #openstack-nova11:45
*** mdnadeem_ has quit IRC11:48
*** yamamoto_ has quit IRC11:48
*** alexchadin has joined #openstack-nova11:49
*** alexchadin has quit IRC11:52
*** salv-orlando has joined #openstack-nova11:53
*** alexchadin has joined #openstack-nova11:53
*** itlinux has quit IRC11:55
*** alexchadin has quit IRC11:56
*** salv-orlando has quit IRC11:57
*** alexchadin has joined #openstack-nova11:58
*** owalsh is now known as owalsh_afk12:01
*** liverpooler has quit IRC12:03
*** alexchadin has quit IRC12:05
*** alexchadin has joined #openstack-nova12:06
*** threestrands has quit IRC12:08
openstackgerritMark Goddard proposed openstack/nova master: Update docstring for get_traits virt driver method  https://review.openstack.org/53950512:08
openstackgerritMark Goddard proposed openstack/nova master: Add resource_class to fields in ironic node cache  https://review.openstack.org/53950612:08
openstackgerritMark Goddard proposed openstack/nova master: Remove unused method _parse_node_instance_info  https://review.openstack.org/53950712:08
openstackgerritMark Goddard proposed openstack/nova master: Include only required fields in ironic node cache  https://review.openstack.org/53950812:08
openstackgerritMark Goddard proposed openstack/nova master: Request only instance_uuid in ironic node list  https://review.openstack.org/53950912:08
*** dave-mccowan has joined #openstack-nova12:08
*** alexchadin has quit IRC12:09
*** janki has quit IRC12:10
*** alexchadin has joined #openstack-nova12:10
*** tetsuro has joined #openstack-nova12:11
*** takedakn has joined #openstack-nova12:11
*** hemna_ has joined #openstack-nova12:12
*** markvoelker has quit IRC12:12
*** suresh12 has quit IRC12:14
*** tetsuro has left #openstack-nova12:15
*** suresh12 has joined #openstack-nova12:16
*** tiendc has quit IRC12:17
*** lajoskatona has quit IRC12:20
*** suresh12 has quit IRC12:20
*** yamamoto has joined #openstack-nova12:22
*** yamamoto has quit IRC12:22
*** yamamoto has joined #openstack-nova12:23
*** suresh12 has joined #openstack-nova12:29
*** bhujay has joined #openstack-nova12:32
*** chyka has joined #openstack-nova12:35
*** lajoskatona has joined #openstack-nova12:37
openstackgerritMerged openstack/nova master: SchedulerReportClient.set_aggregates_for_provider  https://review.openstack.org/53380812:37
*** cdent has joined #openstack-nova12:39
*** chyka has quit IRC12:39
*** alexchadin has quit IRC12:41
*** alexchadin has joined #openstack-nova12:42
*** sauloaugusto has joined #openstack-nova12:44
*** suresh12 has quit IRC12:45
sauloaugustoHi , How can I deploy on openstack-nova for a error in database ?12:45
*** jpena is now known as jpena|lunch12:49
*** suresh12 has joined #openstack-nova12:50
openstackgerritMerged openstack/nova stable/ocata: Handle exception on adding secgroup  https://review.openstack.org/51542112:51
openstackgerritMerged openstack/nova stable/pike: Don't persist could-be-stale InstanceGroup fields in RequestSpec  https://review.openstack.org/52822512:51
openstackgerritMerged openstack/nova stable/ocata: Don't persist could-be-stale InstanceGroup fields in RequestSpec  https://review.openstack.org/52822612:51
*** rcernin has quit IRC12:58
*** takedakn has quit IRC12:59
openstackgerritLajos Katona proposed openstack/nova master: WIP: Add nested resources to server moving tests  https://review.openstack.org/52772813:02
openstackgerritChris Dent proposed openstack/nova master: Remove microversion fallback code from report client  https://review.openstack.org/52879413:03
openstackgerritAmeed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails  https://review.openstack.org/52838513:07
*** markvoelker has joined #openstack-nova13:09
*** hemna_ has quit IRC13:13
*** Tom-Tom has joined #openstack-nova13:16
*** Eran_Kuris has joined #openstack-nova13:18
*** hemna_ has joined #openstack-nova13:20
*** edmondsw has joined #openstack-nova13:22
*** mvenesio has joined #openstack-nova13:23
*** sahid has quit IRC13:25
*** Eran_Kuris has quit IRC13:26
*** Eran_Kuris has joined #openstack-nova13:26
*** liverpooler has joined #openstack-nova13:27
*** janki has joined #openstack-nova13:28
openstackgerritMerged openstack/nova stable/pike: Bumping functional test job timeouts  https://review.openstack.org/53931913:30
openstackgerritMerged openstack/nova master: Don't launch guestfs in a thread pool if guestfs.debug is enabled  https://review.openstack.org/52674813:30
openstackgerritMerged openstack/nova master: Don't log a warning for InstanceNotFound in detach_interface  https://review.openstack.org/53096913:30
openstackgerritMerged openstack/nova stable/ocata: Make sure that functional test triggered on sample changes  https://review.openstack.org/53693613:31
*** ralonsoh_ has joined #openstack-nova13:31
*** mvenesio has quit IRC13:34
*** mvenesio has joined #openstack-nova13:34
*** ralonsoh has quit IRC13:35
*** markvoelker has quit IRC13:37
*** alex_xu has quit IRC13:37
*** markvoelker has joined #openstack-nova13:37
*** sahid has joined #openstack-nova13:39
*** alex_xu has joined #openstack-nova13:39
*** sridharg has quit IRC13:41
openstackgerritMerged openstack/nova stable/ocata: Bumping functional test job timeouts  https://review.openstack.org/53932013:41
*** alexchadin has quit IRC13:41
openstackgerritDan Smith proposed openstack/nova master: Pass limit to /allocation_requests  https://review.openstack.org/53151713:42
*** salv-orlando has joined #openstack-nova13:42
*** blkart_ has quit IRC13:45
*** blkart_ has joined #openstack-nova13:45
*** yangyapeng has quit IRC13:45
*** pchavva has joined #openstack-nova13:45
*** tbachman has quit IRC13:46
*** gongysh has joined #openstack-nova13:49
*** yikun has quit IRC13:50
*** yikun has joined #openstack-nova13:51
*** jpena|lunch is now known as jpena13:51
*** sridharg has joined #openstack-nova13:55
*** ralonsoh__ has joined #openstack-nova13:57
zigoI got issue with Pike's console-log:14:01
zigo# nova console-log 92847293-3b4d-44cc-8cdd-6cb57e23b0cf14:01
zigoERROR (UnicodeEncodeError): 'ascii' codec can't encode characters in position 22096-22098: ordinal not in range(128)14:01
zigoWTF ? :)14:01
zigobauzas: ^14:01
*** ralonsoh_ has quit IRC14:01
*** itlinux has joined #openstack-nova14:02
*** sinese has joined #openstack-nova14:02
*** yamamoto has quit IRC14:04
*** jmlowe has joined #openstack-nova14:04
efriedzigo: Is there a stack trace?14:04
zigoedleafe: Let me check.14:04
*** pcaruana has quit IRC14:05
zigoedleafe: No stack trace in the logs.14:06
*** yamamoto has joined #openstack-nova14:06
*** mriedem has joined #openstack-nova14:06
*** andreas_s has quit IRC14:07
lyarwoodzigo: can you run the nova command again with --debug and pastebin the output?14:07
openstackgerritMatt Riedemann proposed openstack/nova stable/pike: Don't launch guestfs in a thread pool if guestfs.debug is enabled  https://review.openstack.org/53954114:07
openstackgerritMerged openstack/nova master: Fix the order of target host checks  https://review.openstack.org/52622514:07
zigolyarwood: http://paste.openstack.org/show/658151/14:08
openstackgerritMerged openstack/nova master: Fix missing 'if_notifications_enabled' decorator  https://review.openstack.org/53774514:08
jrollzigo: definitely a client issue, py2 or py3?14:09
*** yangyapeng has joined #openstack-nova14:09
zigojroll: py214:09
zigoI got the same issue with openstackclient14:09
jrollprobably just need a .decode('utf8') or something there14:10
zigoNote that this is Debian Unstable ...14:10
zigoBecause I can ... (tm)14:10
zigo:)14:10
zigoSo, something bleeding edge may be the cause.14:10
zigoTo be fixed never the less.14:10
jrollregardless, it's a unicode handling issue in the client, not a library issue14:11
lyarwoodyup, looks valid, can you create a bug?14:11
*** yamamoto has quit IRC14:11
bauzaszigo: strange thing14:11
zigosame stuff with openstackclient: http://paste.openstack.org/show/658154/14:11
zigoWill do.14:12
jaypipesefried: hey, sorry, was afk yesterday evening... you were asking me something about PUT vs DELETE?14:12
bauzaszigo: any trace we could look at ?14:13
bauzaslooks a novaclient issue to me14:13
zigobauzas: Yeah, just pasted 2 of them.14:13
bauzassince openstackclient uses novaclient, I guess it's from here14:13
*** tbachman_ has joined #openstack-nova14:13
efriedjaypipes: Yeah, basically is there any reason to prefer a {DELETE <URI> => 204 no content} API over its corresponding {PUT <URI> => 200 <payload>}14:13
zigojaypipes: Good hey mate !14:13
efriedjaypipes: Specifically for RP inventory, traits, etc.14:15
bauzaszigo: python 2 or 3 ?14:15
openstackgerritMerged openstack/nova master: Add get_traits() method to ComputeDriver  https://review.openstack.org/53229014:15
openstackgerritMerged openstack/nova master: libvirt: test to make sure volume_use_multipath is properly used  https://review.openstack.org/53227014:15
*** READ10 has joined #openstack-nova14:16
openstackgerritMerged openstack/nova master: libvirt: add tests to check multipath in iscsi/fc volume connectors  https://review.openstack.org/53227214:16
*** suresh12 has quit IRC14:16
*** amoralej is now known as amoralej|lunch14:18
zigobauzas: py214:18
ameedahello, I am try to find new bugs to resolve, I found this bug review https://review.openstack.org/#/c/212908/ . I think if I create new table with unique constraints then copy the data from old table to new one , so we clear the dirty data.14:20
*** pcaruana has joined #openstack-nova14:21
openstackgerritMarcin Juszkiewicz proposed openstack/nova master: [dnm] Make sure that we have USB Host controller for tablet  https://review.openstack.org/53800314:23
*** hrw has joined #openstack-nova14:23
hrwmorning14:24
mriedemameeda: nova hasn't used quota usages since pike14:25
mriedemameeda: https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/cells-count-resources-to-check-quota-in-api.html14:25
hrwmriedem: can you take a look at https://review.openstack.org/#/c/538003/ patch and tell is it acceptable?14:25
mriedemi marked the bug as won't fix14:25
ameedamriedem: Thank you!14:26
mriedemhrw: should probably have sahid look at that, he worked on the pointer model stuff in the libvirt driver14:26
ameedamriedem: can you please recheck this https://review.openstack.org/#/c/528385/14:26
hrwmriedem: will add him, thanks14:26
*** links has quit IRC14:27
*** ccamacho has joined #openstack-nova14:27
mriedemameeda: can you please decouple that patch from the one below it in the series?14:27
mriedembecause melwitt's patch https://review.openstack.org/#/c/340614/ is already dealing with the api change (the first patch in your series)14:28
ameedahow can I do that ?14:29
ccamachohey guys! quick question, Im working with the tripleo upgrades squad and Im trying to analyze the Nova database status prior an upgrade, mostly to run cleanup operation before running an upgrade in nova services.14:29
mriedemput them in separate branches14:29
ccamachodo you know briefly where can I find information about it?14:29
openstackgerritMatthew Edmonds proposed openstack/nova master: remove unnecessary conf imports  https://review.openstack.org/53931414:30
mriedemccamacho: find information about what specifically?14:30
*** lucasagomes is now known as lucas-hungry14:30
mriedemccamacho: there are a few nova dbs14:30
*** esberglu has joined #openstack-nova14:30
mriedemnova_api, nova_cell0, nova_cell1 (or just "nova")14:30
*** andreas_s has joined #openstack-nova14:31
ameedamriedem: I should remove this from my branch https://review.openstack.org/#/c/528069 ? or create new branch for this https://review.openstack.org/#/c/528385/ and resubmit the review with new change id ?14:31
ccamachomriedan hi, basically about what to check to clean the databases14:31
*** andreas_s has quit IRC14:31
mriedemccamacho: like how to archive anything that's already in it but deleted?14:31
mriedemnova-manage db archive_deleted_rows14:31
mriedemwill move soft deleted records into the shadow tables14:31
*** mdnadeem has quit IRC14:32
mriedemsoft deleted in this case means records where the deleted column != 014:32
*** andreas_s has joined #openstack-nova14:32
mriedemwe do'nt have a straight up db purge command14:32
openstackgerritMerged openstack/nova master: trivial: use cn instead of rp  https://review.openstack.org/52978614:32
openstackgerritMerged openstack/nova master: Remove the inherits parameter for the Resource object  https://review.openstack.org/52921814:32
mriedemccamacho: https://docs.openstack.org/nova/latest/cli/nova-manage.html#nova-database14:32
ccamachomrieden oki but that is the only cmd available to do it in a more or less automated way14:32
*** moshele has quit IRC14:33
ccamachomrieden thanks for the link14:33
ccamachomrieden are the shadow tables there for ever?14:33
mriedemthere has been a spec and code up before for a command to do similar to archive_deleted_rows but actually hard delete the records rather than move them14:33
mriedemccamacho: yeah14:33
mriedemso there is still bloat in the db for deleted stuff14:33
mriedemhttps://blueprints.launchpad.net/nova/+spec/purge-deleted-instances-cmd14:34
mriedemhttps://blueprints.launchpad.net/nova/+spec/purge-deleted-instances-cmd14:35
mriedemoops14:35
mriedemthis is the spec https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/purge-deleted-instances-cmd.html14:35
mriedemand a poc from someone at red hat https://review.openstack.org/#/c/330791/14:35
ccamachomrieden thanks, the idea is to write +- a procedure to verify and clean the DBs before the upgrade and be sure they are cleaned..  hopefully we can try to implement it after14:36
ccamachothanks man14:36
ameedamriedem: I should remove this from my branch https://review.openstack.org/#/c/528069 ? or create new branch for this https://review.openstack.org/#/c/528385/ and resubmit the review with new change id ?14:36
mriedemameeda: i think you should abandon https://review.openstack.org/#/c/52806914:36
mriedemameeda: to do that locally, rebase your series and drop that change from the local branch,14:37
mriedemgit rebase -i master14:37
mriedem<remove that commit>14:37
mriedemgit review14:37
ameedaOk let me check14:37
ameedaThanks14:37
mriedemccamacho: the man page doesn't list the option, but nova-manage db archive_deleted_rows [--max_rows <number>] [--verbose] has an option for running until complete14:38
*** yamamoto has joined #openstack-nova14:38
mriedemhttps://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L49414:38
ccamachomrieden ack thanks!14:39
efriedjaypipes: I opened some bugs on the subject.  https://bugs.launchpad.net/nova/+bug/1746075  https://bugs.launchpad.net/nova/+bug/1746373  https://bugs.launchpad.net/nova/+bug/174637414:39
openstackLaunchpad bug 1746075 in OpenStack Compute (nova) "Report client placement cache consistency is broken" [Undecided,New]14:39
openstackLaunchpad bug 1746373 in OpenStack Compute (nova) "Placement APIs with missing conflict detection" [Undecided,New]14:39
openstackLaunchpad bug 1746374 in OpenStack Compute (nova) "Report client _delete_inventory violates generation consistency" [Undecided,New]14:39
efriedAt a minimum, that last one needs to be fixed.14:39
efried...whenever we get to a point where there's actually a possibility of concurrency.14:40
mriedemameeda: it's all yours https://bugs.launchpad.net/nova/+bug/174653114:40
openstackLaunchpad bug 1746531 in OpenStack Compute (nova) "nova-manage db archive_deleted_rows man page does not mention --until-complete option" [Medium,Confirmed] - Assigned to Ameed Ashour (ameeda)14:40
jaypipesefried: well, DELETE <uri> and PUT <uri> have different semantics, no?14:40
jaypipesefried: I mean, PUT <uri> can do more than DELETE some object in a collection...14:40
jaypipesefried: you are getting gibi-like bug-happy.14:41
*** tbtest has joined #openstack-nova14:41
efriedjaypipes: Correct.  I'm saying PUT encompasses what DELETE does.  But in these particular cases, DELETE doesn't actually provide us with enough functionality to allow us to ensure consistency.14:41
jaypipesefried: how impactful are those bugs? do they need to be addressed for queens, in your opinion?14:41
*** eharney has joined #openstack-nova14:42
efriedjaypipes: Probably not, since we have that big ol' lock preventing concurrency in the first place.14:42
jaypipesefried: ack. can you add this to the list of discussion topics for Dublin?14:42
ameedamriedem: Thank you very much !!14:44
*** liverpooler has quit IRC14:44
*** yamahata has joined #openstack-nova14:45
openstackgerritAmeed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails  https://review.openstack.org/52838514:45
*** andreas_s has quit IRC14:46
ameedamriedem: patch uploaded https://review.openstack.org/#/c/528385/14:46
efriedjaypipes: https://etherpad.openstack.org/p/nova-ptg-rocky  L50-5914:46
jaypipesefried: danke14:47
efriedjaypipes: To put possibilities in your head, we could have a DELETE that accepts a payload and returns a payload.14:47
*** liverpooler has joined #openstack-nova14:47
*** yamamoto has quit IRC14:47
efriedor just use PUT :)14:47
*** yamamoto has joined #openstack-nova14:48
jaypipescdent might shit a brick, though.14:48
*** yamamoto has quit IRC14:48
*** pcaruana has quit IRC14:48
cdenti've laid so many bricks in the past few days I'm not sure I have any left14:48
mriedemif another core can look at this, i think we should get it in before rc1 https://review.openstack.org/#/c/522112/ beause backports with new config options are generally gross14:48
*** yamamoto has joined #openstack-nova14:49
jaypipescdent: poor guy. still under the weather?14:49
*** liverpooler has quit IRC14:49
jaypipesmriedem: on it.14:49
*** Eran_Kuris has quit IRC14:49
mriedem^ adds the ability for nova to do cinder api stuff, like neutron, without a user token, for things like periodic cleanup tasks14:49
*** liverpooler has joined #openstack-nova14:49
jaypipesmriedem: reading the bugs now...14:49
openstackgerritSen Yang proposed openstack/python-novaclient master: Implement hypervisor hostname exact pattern match  https://review.openstack.org/52018714:50
cdentjaypipes: I _am_ still under the weather, but the bricks I was talking about in this case is the number of conversations in the past few days about generations and provider tree and related stuff that are still up in the air14:50
jaypipescdent: heh, ok :)14:50
ameedamriedem: about assigned bug https://bugs.launchpad.net/nova/+bug/1746531 where I should add the description and what should I write ?14:50
openstackLaunchpad bug 1746531 in OpenStack Compute (nova) pike "nova-manage db archive_deleted_rows man page does not mention --until-complete option" [Medium,Confirmed]14:50
openstackgerritEric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root  https://review.openstack.org/52109814:50
openstackgerritEric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree()  https://review.openstack.org/52118714:50
openstackgerritEric Fried proposed openstack/nova master: SchedulerReportClient._delete_provider  https://review.openstack.org/53546314:50
openstackgerritEric Fried proposed openstack/nova master: ProviderTree.get_provider_uuids: Top-down ordering  https://review.openstack.org/53662414:50
openstackgerritEric Fried proposed openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set  https://review.openstack.org/53662514:50
openstackgerritEric Fried proposed openstack/nova master: New-style _set_inventory_for_provider  https://review.openstack.org/53764814:50
openstackgerritEric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree  https://review.openstack.org/53382114:50
openstackgerritEric Fried proposed openstack/nova master: Use update_provider_tree from resource tracker  https://review.openstack.org/52024614:50
openstackgerritEric Fried proposed openstack/nova master: Fix nits in update_provider_tree series  https://review.openstack.org/53126014:50
openstackgerritEric Fried proposed openstack/nova master: Move refresh time from report client to prov tree  https://review.openstack.org/53551714:50
jaypipescdent: I seem to have gracefully avoided all of those conversations...14:50
openstackgerritEric Fried proposed openstack/nova master: Make generation optional in ProviderTree  https://review.openstack.org/53932414:50
ameedais still gate broken ? https://review.openstack.org/#/c/526900/14:50
cdentjaypipes: they've been interesting and I think for the most part useful with regard to longer term considerations14:51
efriedgibi, jaypipes, mriedem: easy manual rebases on that series14:51
gibiefried: looking...14:51
*** tbachman_ has quit IRC14:51
cdentjaypipes but trying to parse them while still ill is ow14:51
mriedemmelwitt: i think the functional test failures in your patch https://review.openstack.org/#/c/340614/ are real14:51
* efried is still waiting for travel approval14:52
jaypipescdent: ack on that...14:52
jaypipesmriedem: hmm, delete_on_termination=True && boot_from_volume=True don't seem to be a good mix...14:53
jaypipesbut whatevs, I will try to keep an open mind.'14:53
* edleafe is still waiting, but has already booked flights, hotel, etc14:54
*** burt has joined #openstack-nova14:54
mriedemjaypipes: that's super old behavior14:54
*** liverpooler has quit IRC14:54
mriedemdelete the backing volume once i delete the instance14:54
bauzasmriedem: on https://review.openstack.org/#/c/522112/14:54
*** liverpooler has joined #openstack-nova14:55
ameedamriedem: should I follow https://docs.openstack.org/doc-contrib-guide/ ?14:56
*** tbtest has left #openstack-nova14:56
mriedemameeda: no, the nova-manage man pages are in the nova tree14:56
mriedemunder doc/source/cli14:56
mriedemit's just a restructured text file14:57
ameedagreat , what I should write there ?14:58
mriedemameeda: dude14:58
mriedemi'm not going to write the patch fo you14:58
mriedem*for14:58
gibijaypipes, mriedem: the first patch in efried's series needs a second core https://review.openstack.org/#/c/521098 the rest is +Wd14:58
ameedamriedem: sorry :$14:58
mriedemsee how existing entries document CLI options, take a stab at doing similar for the missing option, and then post it for review and get feedback14:58
ameedaThank you !!14:58
*** armax has joined #openstack-nova14:59
mriedemgibi: if it was a rebase you can just fast approve14:59
*** awaugama has joined #openstack-nova14:59
gibimriedem: it was a manual rebase, but yeah, I can fast approve it, sure.14:59
mriedemwe need some cores to look at this too https://review.openstack.org/#/c/537351/15:00
mriedemfixes nits in alex's traits series15:00
bauzasmriedem: are we considering https://review.openstack.org/#/c/537351/4 not impact by FF ?15:01
bauzasimpacted*15:01
*** amoralej|lunch is now known as amoralej15:01
mriedembauzas: it's docs and nit cleanups15:01
bauzasacceptable15:01
gibimriedem: fyi, this is can be merged now: https://review.openstack.org/#/c/533608 as the ocata backport has been merged as well15:04
mriedemgibi: yeah i thought that was already done15:05
efriedThanks gibi!15:06
*** crushil has joined #openstack-nova15:07
*** claudiub|3 has joined #openstack-nova15:10
*** alex_xu has quit IRC15:11
*** alex_xu has joined #openstack-nova15:13
*** pcaruana has joined #openstack-nova15:14
*** itlinux has quit IRC15:18
*** ispp has quit IRC15:19
gibiralonsoh__: hi! Do you plan to propose https://review.openstack.org/#/c/502306/14/specs/queens/approved/bandwidth-resource-provider.rst to rocky?15:21
*** david-lyle has quit IRC15:24
*** dklyle has joined #openstack-nova15:24
*** slaweq_ has quit IRC15:25
*** mlavalle has joined #openstack-nova15:25
tssuryamelwitt : I just wanted to confirm something, since quota calculation uses scatter_gather_all_cells, the whole process is a parallel process right when it comes to querying each cell DB ?15:26
dansmithtssurya: yeah15:26
tssuryamelwitt : so we don't have to worry much about the performance in Pike with regards to this aspect15:26
tssuryadansmith : thanks15:26
*** Guest87240 is now known as mgagne15:27
*** mgagne has joined #openstack-nova15:27
tssuryadansmith : also regarding the status of our solution for calculating quotas when a cell is down, we realized that in Pike no vm creation would take place at all if any of the cell is down since it would raise exception at this point : https://github.com/openstack/nova/blob/cb1e763df76e21b5382872c89dd169ecb152c420/nova/api/openstack/compute/servers.py#L49415:29
dansmithbauzas: can you please look at this? https://review.openstack.org/#/c/532924/15:29
*** eharney has quit IRC15:29
dansmithtssurya: ah yeah, we need to fix that15:30
*** lucas-hungry is now known as lucasagomes15:30
dansmithtssurya: I think we can pretty much remove that check now since the version we're checking for should be out of the support window15:31
tssuryadansmith : so I will submit a POC for this and nova list, but we can discuss more of this in the ptg after we find a solution to deal with differentiating deleted instances from living ones15:31
dansmithin the future when we need to do that sort of thing we'll need to decide what the plan is if a cell doesn't come back with that answer15:31
dansmithtssurya: I really don't think we're going to find such a solution without replicating more data up top, but.. yeah, sounds good15:32
tssuryabecause even for the quotas solution (which was to allow vm creation if a project doesn't have any instances in the cell that is down) it would change to not allowing vm creation if there are any instance_mappings in that cell :(15:33
dansmithyeah15:33
dansmiththat might not be a problem depending on how you distributed people (i.e. keep tenants to a subset of cells), but yeah fair enough15:34
ralonsoh__gibi, sean-k-mooney: I no longer work in OpenStack for the moment. Please, ask sean-k-mooney about the plans to propose it for the next release cycle15:34
tssuryadansmith : how I found this - # TODO(melwitt): Counting across cells for instances means we will miss  counting resources if a cell is down. In the future, we should query  placement for cores/ram and InstanceMappings for instances (once we are  deleting InstanceMappings when we delete instances).15:34
*** tidwellr has joined #openstack-nova15:34
tssuryahowever*15:34
*** links has joined #openstack-nova15:34
tssuryaso hopes up for the last part "once we are  deleting InstanceMappings when we delete instances"15:35
*** psachin has quit IRC15:35
dansmithtssurya: yeah so we could try to leverage placement here in some way, but it would be a rather inefficient merge of "does placement know about any of these instance mappings"15:35
sean-k-mooneyralonsoh__: propose which?15:35
ralonsoh__sean-k-mooney, gibi: https://review.openstack.org/#/c/502306/14/specs/queens/approved/bandwidth-resource-provider.rst15:35
dansmithtssurya: we can't delete instancemappings when we delete instances15:35
*** ispp has joined #openstack-nova15:36
*** esberglu_ has joined #openstack-nova15:36
tssuryadansmith: yea probably, but is there a way we could included a status for the mappings ?15:36
*** salv-orlando has quit IRC15:37
dansmithtssurya: that's what I meant about "replicating more data"15:37
dansmithwe said we weren't going to do that, so we'd have to discuss whether or not we're going to violate that design point or not15:37
tssuryadansmith: hmm okay,15:37
dansmithtssurya: maybe we could do something like delete the reqspec (if we don't already) when we delete an instance, and then not include instances with no requestspec that do have a mapping?15:38
*** yamamoto has quit IRC15:38
dansmithtssurya: I think bauzas was going to clean that up (delete reqspec on delete) but not sure if he ever did15:38
tssuryadansmith : we don't delete request_spec as of now,15:38
tssuryabut yes that would also work15:38
gibiralonsoh__: thanks for the info15:38
dansmiththat would be better IMHO15:38
tssuryaif we could delete specs when we delete the instances15:39
gibisean-k-mooney: do you plan to re-propose https://review.openstack.org/#/c/502306/14/specs/queens/approved/bandwidth-resource-provider.rst ?15:39
tssuryadansmith : no he didn't because we did something similar to instance_mappings clean up during archival15:39
tssuryaso now we purge mappings and specs in the same way15:40
dansmithyeah, okay, well, I think it'd make sense to do it that way, but we can discuss at the PTG15:40
tssuryadansmith : yes sounds good :)15:40
*** esberglu has quit IRC15:40
*** salv-orlando has joined #openstack-nova15:41
cdentbauzas: you happy to put your +W back on https://review.openstack.org/#/c/519462/ now that gate is a bit happier?15:42
bauzascdent: it requires a manual rebase15:43
bauzasthere is a merge conflict15:43
* cdent will do that15:43
*** felipemonteiro__ has joined #openstack-nova15:44
cfriesenjohnthetubaguy: you around?15:44
*** felipemonteiro_ has joined #openstack-nova15:45
openstackgerritChris Dent proposed openstack/nova master: Log options at debug when starting API services under wsgi  https://review.openstack.org/51946215:46
cdentbauzas: ^15:46
bauzascdent: fast-approved15:47
cdentthanks15:47
bauzasthanks, that's not that I was lazy, but I have other things on the gas15:48
*** yamamoto has joined #openstack-nova15:48
mriedemdansmith: tssurya: https://review.openstack.org/#/c/391060/15:48
*** esberglu_ is now known as esberglu15:48
bauzasdansmith: yup, I did15:48
bauzasbut it requires some cleanup15:49
dansmithbauzas: did what?15:49
mriedemthat patch i just linked15:49
*** felipemonteiro__ has quit IRC15:50
dansmithbauzas: I've been pinging you for two weeks to look at this, can you please look at it? https://review.openstack.org/#/c/532924/15:50
bauzasyup, that15:50
bauzasdansmith: on it15:50
bauzasdansmith: it was on an open tab15:50
*** bhujay has quit IRC15:50
dansmithbauzas: okay well, never heard a peep so I didn't know15:51
bauzasmy bad15:51
tssuryamriedem : thanks, so that means we do not agree to deleting the specs when deleting the instances right ?15:53
*** yamamoto has quit IRC15:53
hrwhttps://imgur.com/a/3b22r - graphical console on arm64 out of box (with https://review.openstack.org/#/c/538003/ applied) mriedem15:53
*** Tom-Tom has quit IRC15:54
*** Tom-Tom has joined #openstack-nova15:55
mriedemtssurya: well, i don't agree with the assertion that if the instance fails to be deleted, losing the request spec is ok15:55
mriedembecause we have fallback code all over the place from the newton transition to reqspecs for old instances15:55
mriedemas i said in that patch, a lot of that fallback code is best effort but shouldn't really be relied upon15:56
bauzasmaciejjozefczyk: dansmith: there could be a flip logic where some cloud could have computes nova.confs with allocation ratios equal to 0.015:56
bauzasmaciejjozefczyk: dansmith: in that case, when upgrading to Queens, I guess we should still make sure to correctly normalize the ratios the other way, nope ?15:56
*** slaweq has joined #openstack-nova15:56
maciejjozefczykbauzas: hey15:57
tssuryamriedem : right, makes sense15:57
melwittmriedem: ack15:58
*** Tom-Tom has quit IRC15:59
*** eharney has joined #openstack-nova16:00
*** jose-phi_ has quit IRC16:01
mriedemhrw: left some comments16:03
maciejjozefczykbauzas: I dont know, Its said that in Newton it should be moved to default values, and its Queens now.16:03
hrwmriedem: thx16:03
bauzasmaciejjozefczyk: yup, I'm just thinking about flipping the problem16:03
bauzasmaciejjozefczyk: say we have a pike compute, and a queens cloud16:04
bauzasmaciejjozefczyk: the old pike compute would store in its DB the unnormalized ratios, ie. 0.0, right?16:04
hrwmriedem: will reply16:04
maciejjozefczykbauzas: right16:05
bauzasmaciejjozefczyk: in that case, what works now that we normalize those ratios by the object layer16:05
bauzasmaciejjozefczyk: if we cut that logic and just takes what we get from the DB, then we need to be careful about those pike nodes16:05
bauzasmaciejjozefczyk: I'm trying to evaluate hard https://review.openstack.org/#/c/532924/6/nova/objects/compute_node.py@185 and its impact with a pike node16:06
*** crushil has quit IRC16:06
maciejjozefczykbauzas: you're right16:06
openstackgerritMatt Riedemann proposed openstack/nova master: Fix nits in support traits changes  https://review.openstack.org/53735116:07
openstackgerritMatt Riedemann proposed openstack/nova master: Mention required traits in the flavors user docs  https://review.openstack.org/53930016:07
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional tests for traits-based scheduling  https://review.openstack.org/53931016:07
mriedemefried: fixed that comment ^16:07
mriedemthanks16:07
mriedemefried: also, your two irc nicks in here is driving me nuts16:07
cfriesendesign question...now that we have objects.Service.get_minimum_version(), does the RPC version really serve any purpose anymore?16:07
efriedmriedem: sorry, was keeping the old one around for logs.  Guess there's no reason to keep it logged in, tho.16:08
*** efried_hexchat has quit IRC16:08
bauzasmaciejjozefczyk: wait, I'm not saying we have a problem yet16:08
*** tovin07 has quit IRC16:09
*** hoangcx has quit IRC16:09
*** belmoreira has quit IRC16:10
*** tovin07 has joined #openstack-nova16:10
*** hoangcx has joined #openstack-nova16:10
maciejjozefczykbauzas: In this particular case when pike compute has in db 0.0 _from_db_object() method will change 0.0 to default value from oslo.config16:12
maciejjozefczykL185 so the effect would be the same16:12
bauzasmaciejjozefczyk: right, I just left a comment16:13
bauzasmaciejjozefczyk: if people started to touch their nova.conf, whatever it's Pike or Queens, we take that conf value16:14
openstackgerritClaudiu Belu proposed openstack/nova master: hyper-v: Logs tips on PortBindingFailed  https://review.openstack.org/53958416:14
maciejjozefczykbauzas: The only thing for now is the topic on openstack-dev: What about aggregation groups and its metadatas?16:14
efriedjaypipes, cdent: Heads up, here's a really weird failure that may point to an intermittent placement bug.  But I have no idea how it happened, how to reproduce it, etc.16:15
efriedjaypipes, cdent: http://logs.openstack.org/17/535517/15/check/nova-tox-functional/b841731/testr_results.html.gz16:15
bauzasmaciejjozefczyk: can you please give me the link ?16:15
maciejjozefczykbauzas: https://bugs.launchpad.net/nova/+bug/1742747 and http://lists.openstack.org/pipermail/openstack-operators/2018-January/014748.html16:16
openstackLaunchpad bug 1742747 in OpenStack Compute (nova) "RT overrides default allocation_ratios for ram cpu and disk" [Undecided,In progress] - Assigned to Maciej Jozefczyk (maciej.jozefczyk)16:16
maciejjozefczykjaypipes: and mgagne was thing about that use-case16:16
bauzasmaciejjozefczyk: ah right, can we please punt that topic for now ?16:16
bauzasmaciejjozefczyk: I'm trying to identify whether your change will work on a rolling-upgrade :)16:17
maciejjozefczykbauzas: yea sure :)16:17
efriedjaypipes, cdent: If you look at time stamp 2018-01-30 20:31:43,675 you can see that we successfully created the CUSTOM_BANDWIDTH resource class.  Then the next log shows creating the inventory that uses it.  That also succeeds, which it wouldn't have if the resource class didn't exist.  And there's no subsequent removal of that resource class.  But the failure claims the resource class didn't come back in GET /resource_cla16:17
maciejjozefczykbauzas: I need to go anyway.16:17
maciejjozefczykbauzas: thanks for checkign it16:17
*** maciejjozefczyk is now known as maciejjozefczyk_16:17
bauzas++16:17
jaypipesefried: this is repeatable?'16:18
efriedjaypipes: No.  I haven't been able to repro it locally, and it also didn't repro in the py35 version of that same test for that same run on that same patch in zuul.16:18
*** belmoreira has joined #openstack-nova16:19
efriedjaypipes: That's what scares me the most16:19
jaypipesefried: clowns are what scare me most.16:19
cdentpuppet clowns16:20
*** janki has quit IRC16:22
openstackgerritMarcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for tablet  https://review.openstack.org/53800316:24
efriedcdent, jaypipes: So do I just pretend this didn't happen?  I can't think of a way to track it down without being able to reproduce it.16:24
hrwmriedem: please check16:24
*** moshele has joined #openstack-nova16:24
jaypipesefried: clowns are indeed slippery like that.16:24
cdentefried: if you're in the middle of doing other important stuff I'd say don't let it distract you for now16:25
jaypipesefried: I would forget it happened for now.16:25
*** cjvolzka has joined #openstack-nova16:25
jaypipescdent++16:25
efriedokeydokeythen.16:25
cdentI'm looking at the test now to see if anything leaps out16:25
*** tbachman has joined #openstack-nova16:25
*** cjvolzka has quit IRC16:25
* efried capers off in oversized shoes16:25
jaypipesefried: you need to rebase that anyway16:25
efriedjaypipes: Yeah, but I need to wait until the bottom of the series merges now.  Otherwise would need re-+Ws on those bottom five, and lose their headway in the gate.16:26
efriedjaypipes: I have it rebased locally.16:26
jaypipesack16:26
hrwmriedem: I hope that new commit message and replies to comments make it simpler to understand16:27
sean-k-mooneyralonsoh__: gibi ah ok i have asked one of the other teams at intel to contiue this item but we have not got confirmation they will. we would like to yes. we should know if intel can work on it by the ptg16:27
*** prometheanfire has left #openstack-nova16:28
gibisean-k-mooney: thanks for the info16:28
sean-k-mooneygibi: if you want to reporpose it then go ahead but it if not we will likely do it in the next week or two. my team however is nolonger resoced to work on it16:28
*** r-daneel has joined #openstack-nova16:29
efriedreporpoise (ftfy).  A marine mammal, again.16:30
gibisean-k-mooney: we are currently trying to understand the next steps with this feature. If we reach the point to have something solid before intel repropose then we will propose it16:30
openstackgerritDan Smith proposed openstack/nova master: Make service all-cells min version helper use scatter-gather  https://review.openstack.org/53959016:31
dansmithtssurya: mriedem ^16:31
*** munishmehan has joined #openstack-nova16:31
dansmithsee if you buy my logic in those comments :D16:31
sean-k-mooneygibi: well i think the main step would be to start modeling network backends a placement resouse providers of bandwith. we were intending to have neutron create those RPs but how we model numa will obviosly effect it.16:32
sean-k-mooneygibi: the reason for neutron doing it and not nova was so nova does not have know how to discover things like network bandwith for every neutron backend16:33
mriedemjaypipes: mdbooth: i'd prefer not to land https://review.openstack.org/#/c/462521/ at this point in queens16:33
gibisean-k-mooney: yeah, that part seems to be clear. The first real roadblock we hit was that which component will allocate from those RPs, nova or neutron16:33
sean-k-mooneynova16:34
jaypipesmriedem: ack. I'm still +2 on it. but you want to -W it?16:34
sean-k-mooneygibi: that said i wanted neutron to pass a request for bandwith as part of the neuton port16:34
gibiralonsoh__: btw, could you please just simply un-abandon (restore?) the spec patch so we can publish some comments there in the meantime?16:34
mriedemjaypipes: done16:34
jaypipesmriedem: done.16:35
*** zhaochao has quit IRC16:35
jaypipeslol, jinx16:35
gibisean-k-mooney: I also feel that nova should do the claim based on the request coming from the port from neutron16:35
gibisean-k-mooney: but it seems mriedem has a different view based on the ptg etherpad https://etherpad.openstack.org/p/nova-ptg-rocky L14516:36
*** stvnoyes has left #openstack-nova16:36
sean-k-mooneygibi: just looking now16:36
ralonsoh__gibi: sure16:36
gibiralonsoh__: thanks a lot16:36
sean-k-mooneygibi:  i dont think thats in conflict16:37
mriedemi will say that i've evacuated all of that spec from my brain16:37
mriedemincluding it's mish mash of dependencies16:37
sean-k-mooneygibi: for the multiple port binding spec we wanted to move the point of getting the port info form neutron to the conductor before calling placement16:37
gibisean-k-mooney: "neutron would update the allocations in Placement rather than nova doing that" this part seems conflicting to me16:38
*** gongysh has quit IRC16:38
gibisean-k-mooney: I'm not against moving the port creation to the conductor16:38
*** ralonsoh has joined #openstack-nova16:38
*** sinese has quit IRC16:39
sean-k-mooneygibi: moving the port bind/createion to the condoctor means we can skip a host if binding would fail early instead of after we have set up everything on the destination16:39
*** pcaruana has quit IRC16:39
sean-k-mooneygibi: this is of benifit most with multicells deployment where we cant retry like we used too16:40
cdentefried: nothing leaps out while reading through that test. I'm going to go with the old standby of "eventlet is probably messing with something somewhere"16:40
efriedcdent: Thanks for looking.  You like the test case in general tho?16:41
cdentseems legit16:41
gibisean-k-mooney: I might missing something here but for me binding a port and claiming the resources for that port happens independently16:41
*** ralonsoh__ has quit IRC16:41
*** andreas_s has joined #openstack-nova16:42
sean-k-mooneygibi: when you bind a port you set the host id so you have already claimed the resouce at this point so currently we find out if neutron can bind a node very late16:42
gibisean-k-mooney: so this means for me that claiming the port related resources has to happen before the bind16:43
sean-k-mooneygibi: the idea was create/get the neutron before placement is called to get extra requiremetn. then go through placement and scheduler steps and select a host. try to bind it and if it fails go to next candiate and when binding all ports succeds then call compute node to boot instance16:44
sean-k-mooneygibi: yes claiming has happend before binding today16:45
*** moshele has quit IRC16:45
*** tbachman_ has joined #openstack-nova16:45
*** tbachman has quit IRC16:46
*** tbachman_ is now known as tbachman16:46
gibisean-k-mooney: in the idea does the bind happen in the conductor?16:46
sean-k-mooneygibi: yes16:47
gibisean-k-mooney: OK that is the piece that I missed so far16:47
gibisean-k-mooney: thanks, I have to restart some thinking based on this information16:47
*** sinese has joined #openstack-nova16:48
sean-k-mooneybut again this is all up for debate. there could be better ways to do it but if we do the port creation and bindign in the conductor before we claim we can eliminate nodes the would fail before ever calling the compute node.16:49
sean-k-mooneyyou could have neutron do the claim in placement as part of the port bind on sucess if you wanted for example. or the condoctor could do it when you claim everything else16:50
*** tbachman_ has joined #openstack-nova16:50
tssuryadansmith : thank you I will have a look, should we probably do the same thing here as well or add an exception or something? -> https://github.com/openstack/nova/blob/stable/pike/nova/scheduler/host_manager.py#L60116:50
*** tbachman has quit IRC16:51
*** tbachman_ is now known as tbachman16:51
tssuryadansmith : also do we have a cells meeting today ? not that we have anything from our side (since we are discussing it here)16:51
dansmithtssurya: I'm (very) cool with canceling.. mriedem melwitt ?16:51
mriedemcancel16:51
melwitt+116:51
dansmithwoot16:51
tssuryacool16:52
*** hoangcx has quit IRC16:52
*** tovin07 has quit IRC16:52
dansmithtssurya: we should convert that to scatter/gather for performance, and make it not freak out on timeout/fail yeah16:52
dansmithtssurya: I can stack that on top of my patch from earlier16:52
dansmithtssurya: unless you already have one ready to go16:52
tssuryadansmith: yes sounds good16:52
*** sinese has quit IRC16:52
tssuryathank you16:52
tssuryanope I don't have one16:52
*** moshele has joined #openstack-nova16:53
dansmithokay, give me a bit16:53
* dansmith declares this a three-cup day16:53
gibisean-k-mooney: If the neutron claims then there is window of race condition. If nova claims in one step in the conductor then we can eliminate such race16:53
*** hoangcx has joined #openstack-nova16:53
*** tovin07 has joined #openstack-nova16:53
*** chyka has joined #openstack-nova16:54
gibisean-k-mooney: therefore I more like the idea to let nova do the claim based on the requests from the port16:55
gibisean-k-mooney: and I think we agree. :)16:55
mdboothmriedem: ack16:55
*** slaweq has quit IRC16:55
*** andreas_s has quit IRC16:56
* hrw -> comments16:57
openstackgerritMatt Riedemann proposed openstack/nova master: Pass limit to /allocation_requests  https://review.openstack.org/53151716:58
*** felipemonteiro_ has quit IRC16:58
*** felipemonteiro_ has joined #openstack-nova16:59
*** efried is now known as efried_rollin17:02
*** harlowja has joined #openstack-nova17:02
stephenfinbauzas: Could you hit these at some point, please :) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+topic:bug/1736759-stable/pike17:03
*** yamamoto has joined #openstack-nova17:03
*** slaweq has joined #openstack-nova17:03
* bauzas chills17:03
stephenfinmriedem: Assuming you're not completely burnt out yet, could you take a look at this backport https://review.openstack.org/#/c/530743/ ?17:04
mriedemstephenfin: i see that neither jaypipes or bauzas reviewed the patch on master,17:06
mriedemso i think i'd like to see that they are cool with that before we merge all the way back to ocata17:07
bauzasdansmith: FWIW, I think I found a possible issue with https://review.openstack.org/#/c/532924/17:07
bauzasdansmith: which would require the object to check the service version17:07
dansmithbauzas: I was assuming you were going to -2 that17:07
bauzas-2 that change because we're close to RC1 ?17:08
bauzasand defer to Rocky?17:08
bauzasbecause I don't disagree with that cleanup17:08
dansmithbauzas: no because of the use of the 0.0 as sentinels for the DB or whatever that hack was17:08
*** belmoreira has quit IRC17:08
dansmithokay, you're saying we're far enough past that that we can do this cleanup?17:08
bauzasdansmith: I think mid-term we can remove the sentinels17:09
dansmithI really didn't look closely other than to see it seemed to be missing the point of those being 017:09
dansmithokay17:09
bauzasdansmith: but the problem is with an upgrade17:09
stephenfinmriedem: I'm not sure I get you?17:09
mriedemgibi: if you're still around, can you re-approve https://review.openstack.org/#/c/539300/ and the one after it17:09
bauzasdansmith: so we could potentially require to keep a bit of backwards compatibility logic17:09
stephenfinOh, you want more than two pairs of eyes on it? Gotcha17:10
mriedemstephenfin: i'm not personally comfortable with disk over commit and allocation ratio stuff, i know jaypipes and bauzas are more knowledgeable about that17:10
bauzasdansmith: I'll discuss with maciejjozefczyk_ about the possible solutions17:10
mriedemstephenfin: yes17:10
stephenfinThat's fair. I can bug them (y)17:10
bauzasmaciejjozefczyk_: when you're up tomorrow, let's discuss and ping me17:10
bauzasI'm here17:10
bauzasno need to bug me17:11
bauzaswhat's the context ?17:11
bauzasbtw. if anyone has some fakelibvirt expertise and functional testing for libvirt, raise a hand, please17:11
bauzasit will prevent me to spend a couple of hours trying to understand the code17:11
*** slaweq has quit IRC17:11
stephenfinbauzas: :) I'm looking for eyes on this backport https://review.openstack.org/#/c/530743/17:11
mriedembauzas: https://review.openstack.org/#/c/538938/17:11
mriedemoops17:11
stephenfinThe stable/ocata backport too, but baby steps17:12
sean-k-mooneygibi: yep that why at least one of the spec is written to assume nova will do the claim. i also have not really looked at them since november so cant rememeber all the deatils.17:12
openstackgerritsahid proposed openstack/nova-specs master: libvirt: add support for virtio-net rx/tx queue sizes  https://review.openstack.org/53960517:12
stephenfinbauzas: I might be able to help17:12
stephenfinw/ fakelibvirt, that is. What's up?17:12
bauzasstephenfin: my goal is to provide a specific test module for vGPU testing17:12
*** vivsoni__ has quit IRC17:12
*** kwathore__ has joined #openstack-nova17:13
bauzasie. mocking the virt driver to have mdevs and do a couple of server actions17:13
*** vivsoni__ has joined #openstack-nova17:13
bauzaslike we have for NUMA or SR-IOV testing17:13
gibimriedem: done17:13
bauzasstephenfin: but let's punt that discussion to tomorrow, /me looking at your change17:13
stephenfinbauzas: Yup, that sounds fair. Have you looked at nova/tests/functional/libvirt/test_pci_sriov_servers.py ?17:13
bauzasI did17:14
stephenfinAh, cool17:14
bauzasI probably need to only identify the best entrypoints to mock only the pieces of libvirt I want17:14
*** moshele has quit IRC17:14
stephenfinYeah, we can discuss tomorrow AM so, but fakelibvirt is basically the hardware-dependent aspects of libvirt mocked out. How those parts are determined, I'm not so sure17:15
*** gszasz has quit IRC17:15
stephenfinvladikr would be the person to ask tomorrow, assuming he's about/has time17:15
*** brault has quit IRC17:15
bauzasno worries, I'll dig into the code anyway17:15
*** kwathore_ has quit IRC17:16
*** brault has joined #openstack-nova17:16
*** yamamoto has quit IRC17:16
dansmithtssurya: assume you don't yet have a bug for the host_manager issue right?17:18
openstackgerritMarcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet  https://review.openstack.org/53800317:18
*** sahid has quit IRC17:18
hrwmriedem, jaypipes: this version adds usb host controller ONLY if pointer device is 'usbtablet' so ps/2 mouse lovers are not touched17:18
*** ralonsoh_ has joined #openstack-nova17:21
*** links has quit IRC17:21
*** sree has quit IRC17:22
mriedemhrw: that needs tests17:22
*** yamahata has quit IRC17:22
*** sree has joined #openstack-nova17:23
tssuryadansmith : no17:23
tssuryado you want me to open one ?17:23
*** AlexeyAbashkin has quit IRC17:23
hrwmriedem: I am aware. Will ask someone to write one for me as I know how get functionality working but completely out of ideas when it comes to tests.17:24
dansmithtssurya: I was thinking maybe you already had bugs for both of these things when I asked on the first review, but then realized maybe not17:24
dansmithtssurya: I think it'd be good to have the bugs coming from cern as backport justification, if you don't mind17:24
*** ralonsoh has quit IRC17:24
hrwmriedem: having info are the idea and it's implementation ok is also helpful to me17:25
tssuryadansmith : yea sure, I can do open them17:25
tssuryayou want it to be two seperate bugs ?17:25
mriedemhrw: there should be at least one existing test in nova.tests.unit.virt.libvirt.test_driver that you could copy and modify17:25
dansmithtssurya: yeah they're separate issues I think17:25
hrwmriedem: ok17:25
*** lyan has joined #openstack-nova17:26
hrwmriedem: any other comments than unit testing?17:26
tssuryacool will do and btw I have done the same for the bdm querying as we had discussed, for nova list, so will post that and open a bug for that too17:26
dansmithtssurya: cool17:26
mriedemhrw: haven't looked17:27
hrwok17:27
mriedemdon't wait for me though17:27
hrwmriedem: do not plan to17:27
hrwmriedem: and thanks a lot for reviews17:27
openstackgerritElod Illes proposed openstack/nova master: Functional test: evacuate with no compute  https://review.openstack.org/49848217:27
bauzasmriedem: tssurya: I missed your discussion about ReqSpec deletions17:27
openstackgerritMatt Riedemann proposed openstack/nova master: Add a nova-caching-scheduler job to the experimental queue  https://review.openstack.org/53926017:28
bauzasmriedem: tssurya: I'll try to provide a new patchset this week, but no promises17:28
tssuryabauzas : you have checked the last comment from mriedem on PS9 ?17:29
bauzasnot really17:29
*** moshele has joined #openstack-nova17:31
*** Swami has joined #openstack-nova17:32
bauzastssurya: dansmith: mmm, honestly, given https://review.openstack.org/#/c/515034/ I think we can abandon https://review.openstack.org/#/c/391060/17:33
bauzasmriedem: ^17:33
bauzaspurging the spec records when we archive the deleted instances is enough17:33
dansmithbauzas: no it's not17:34
bauzaswhat are we missing then ?17:34
dansmithfor the case we were taking about above17:34
dansmithbecause we wanted to use the deleted-reqspec as the sentinel to not include the instance in a list of instances from a downed cell17:34
dansmithI want to talk about it in dublin17:34
dansmithso don't abandon yet17:34
tssuryabauzas : we are trying to find some way in which we can include information regarding the status of an instance : whether its deleted or not in the api DB17:34
bauzasokay17:34
*** sree has quit IRC17:34
bauzasdansmith: so the idea would be that if you don't find the related spec record for a specific instance UUID, then it implies that the instance is deleted, hence not needed to be shown from the instance mapping records ?17:37
bauzasso we wouldn't have stale content if the cell is down?17:38
openstackgerritMatt Riedemann proposed openstack/nova master: Check for leaked server resource allocations in post_test_hook  https://review.openstack.org/53851017:38
dansmithbauzas: yeah17:38
bauzasmmm, ok17:38
bauzasI see17:38
dansmithbauzas: we'd only be showing instance shells, but we don't want any to come back from the dead17:38
dansmithwe could have a deleted flag, but.. I really don't want to go down that road17:38
*** sridharg has quit IRC17:38
dansmithif we can help it17:38
bauzasthe main problem is that I'm not sure we can deterministacally destroy a spec record17:38
bauzasoh man17:39
bauzasdeterministically-something17:39
openstackgerritMatt Riedemann proposed openstack/nova master: Check for leaked server resource allocations in post_test_hook  https://review.openstack.org/53851017:42
dansmithbauzas: yeah I understand the potential issue there17:43
dansmithhence the need to discuss17:43
bauzascool17:43
bauzasokay, let's keep that open until Dublin then17:43
openstackgerritDan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells  https://review.openstack.org/53961717:43
bauzasdansmith: thanks for explaining me the need17:43
dansmithtssurya: ^ I'll update with the bug number when you get it17:44
*** kwathore__ has quit IRC17:44
*** vivsoni__ has quit IRC17:44
*** vivsoni__ has joined #openstack-nova17:44
*** kwathore__ has joined #openstack-nova17:45
*** tesseract has quit IRC17:45
hrwhm. I am reading _get_guest_pointer_model() again and again... It returns anything ONLY if that anything is usbtablet...17:46
hrwor I do not understand Python (which is highly possible)17:47
bauzasmriedem: before leaving, just left +1 on https://review.openstack.org/#/c/530743/ because I need to consider whether it's acceptable to have exceptions or not that are popped by the API, based on the compute version17:47
bauzaslike, say I'm upgrading half of my nodes, is that a problem if I'm getting a different disk calculation logic ?17:48
bauzaseither way, the master change is merged17:48
*** felipemonteiro_ has quit IRC17:48
bauzasso maybe it's just me overthinking17:48
bauzasanyway, need to disappear17:49
hrwfunction starts. then hw_pointer_model is read from image properties. if it is not set then check for use_usb_tablet option and if it is set then set pointer_model to usbtablet and issue a warning that configuration needs update. Then is a check is pointer_model a usbtablet. If it is not then function ends. It it is then check for is Vnc or (is spice but without spice agent) and then return usbtablet17:50
hrwthrough _get_guest_usb_tablet() function which checks for VMMode and creates structure for add_device() call17:50
*** rmcall has joined #openstack-nova17:50
*** rmcall has quit IRC17:51
*** rmcall has joined #openstack-nova17:51
hrwmriedem: added one more comment and ending a day17:52
*** lpetrut_ has quit IRC17:52
tssuryadansmith : https://bugs.launchpad.net/nova/+bug/1746558 , https://bugs.launchpad.net/nova/+bug/174656117:53
openstackLaunchpad bug 1746558 in OpenStack Compute (nova) "Make service all-cells min version helper use scatter-gather" [Undecided,New] - Assigned to Dan Smith (danms)17:53
*** tbachman has quit IRC17:53
openstackLaunchpad bug 1746561 in OpenStack Compute (nova) "Make host_manager use scatter-gather and ignore down cells" [Undecided,New] - Assigned to Dan Smith (danms)17:53
tssuryadansmith: thanks again!17:53
openstackgerritDan Smith proposed openstack/nova master: Make service all-cells min version helper use scatter-gather  https://review.openstack.org/53959017:53
openstackgerritDan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells  https://review.openstack.org/53961717:53
dansmithtssurya: they haven't started running tests yet, so ^17:54
dansmithtssurya: thanks!17:54
*** vivsoni__ has quit IRC17:55
*** vivsoni__ has joined #openstack-nova17:55
*** sree has joined #openstack-nova17:56
*** gjayavelu has joined #openstack-nova17:56
*** tbachman has joined #openstack-nova17:58
*** sree has quit IRC18:01
openstackgerritElod Illes proposed openstack/nova master: Functional test: cold migrate to compute down  https://review.openstack.org/49628018:01
*** yamahata has joined #openstack-nova18:03
*** ragiman has quit IRC18:07
*** moshele has quit IRC18:10
*** hongbin has joined #openstack-nova18:12
*** jpena is now known as jpena|away18:13
*** AlexeyAbashkin has joined #openstack-nova18:17
*** tbachman has quit IRC18:23
*** moshele has joined #openstack-nova18:24
*** gjayavelu has joined #openstack-nova18:27
mriedemesberglu: can you post a patch that adds powervm to the hpc feature support matrix page? https://docs.openstack.org/nova/latest/user/feature-classification.html#matrix-hpc18:27
*** sree has joined #openstack-nova18:28
mdboothdansmith: jaypipes Thanks. NP holding off for queens either.18:29
mriedemkashyap: re http://logs.openstack.org/66/539266/2/check/build-openstack-sphinx-docs/f7a1712/html/admin/virtual-gpu.html#how-to-know-a-gpu-type where it says, "Note that the current libvirt API doesn’t provide a way to access that information."18:30
mriedemis that true at least for libvirt 4.0.0?18:30
mriedemwhich is the latest release?18:30
mdboothdansmith: I responded to your comments and I'm expecting to make some changes. Given that it's not going to land in Queens it's hardly urgent, but just in case you wanted to respond while you still have context... I'm looking for further feedback on which changes are really required.18:30
*** tbachman has joined #openstack-nova18:30
*** vivsoni__ has quit IRC18:31
*** kwathore__ has quit IRC18:31
*** kwathore__ has joined #openstack-nova18:31
*** vivsoni has joined #openstack-nova18:31
*** mvenesio has quit IRC18:31
*** moshele has quit IRC18:32
mriedemefried_rollin: the in-tree powervm driver doesn't support gpu passthrough right?18:34
*** felipemonteiro has joined #openstack-nova18:36
*** sree has quit IRC18:36
*** dtantsur is now known as dtantsur|afk18:37
*** moshele has joined #openstack-nova18:39
*** tbachman has quit IRC18:43
*** mvenesio has joined #openstack-nova18:45
mriedemesberglu: nvm i've just about got this18:49
*** tbachman has joined #openstack-nova18:49
*** AlexeyAbashkin has quit IRC18:51
*** mvk has quit IRC18:52
*** harlowja has quit IRC18:52
openstackgerritMatt Riedemann proposed openstack/nova master: doc: update the GPU passthrough HPC feature entry  https://review.openstack.org/53963818:52
*** sree has joined #openstack-nova18:52
*** sree has quit IRC18:57
*** priteau has quit IRC18:57
*** david-lyle_ has joined #openstack-nova18:58
*** moshele has quit IRC19:00
*** dklyle has quit IRC19:01
mriedemartom: we don't throw exceptions in python!19:02
mriedem:P19:02
*** sauloaugusto has quit IRC19:02
artommriedem, eh?19:02
mriedemhttps://review.openstack.org/#/c/539266/2/doc/source/admin/virtual-gpu.rst@11619:02
artomI said something stupid, didn't I?19:03
*** lajoskatona has quit IRC19:03
artom"Libvirt will throw an exception"19:03
artomYep :(19:03
*** kwathore_ has joined #openstack-nova19:03
*** vivsoni has quit IRC19:03
*** vivsoni has joined #openstack-nova19:04
*** tidwellr has quit IRC19:04
*** lucasagomes is now known as lucas-afk19:04
*** tidwellr has joined #openstack-nova19:05
*** DinaBelova has quit IRC19:06
*** aignatov has quit IRC19:06
*** DinaBelova has joined #openstack-nova19:07
*** aignatov has joined #openstack-nova19:07
*** kwathore__ has quit IRC19:07
*** david-lyle_ is now known as dklyle19:08
artomOh wait, you mean we raise, not throw.19:09
artomYeah, that too.19:09
artomIt's not my fault they taught us Java :(19:09
*** edleafe has quit IRC19:09
*** edleafe has joined #openstack-nova19:10
*** suresh12 has joined #openstack-nova19:11
melwittwell, libvirt itself throws because it's C right :P19:13
dansmithC doesn't throw19:13
dansmithit returns -1 and sets ERRNO19:14
melwittoh -_- guess I was thinking of C++19:14
dansmith*gasp*19:14
* melwitt runs away in shame19:14
openstackgerritMatt Riedemann proposed openstack/nova master: doc: update the GPU passthrough HPC feature entry  https://review.openstack.org/53963819:15
openstackgerritMatt Riedemann proposed openstack/nova master: Provide support matrix and doc for VGPU  https://review.openstack.org/53926619:15
mriedemartom: i've tried to address your comments ^ but there were a lot of them...19:15
mriedemand i'm just helping a brotha out19:15
*** suresh12 has quit IRC19:15
*** amodi has joined #openstack-nova19:15
openstackgerritMatt Riedemann proposed openstack/nova master: doc: update the GPU passthrough HPC feature entry  https://review.openstack.org/53963819:17
openstackgerritMatt Riedemann proposed openstack/nova master: Provide support matrix and doc for VGPU  https://review.openstack.org/53926619:17
artommriedem, aha, cheers!19:17
*** sambetts is now known as sambetts|afk19:19
mriedemand because you overloaded me with comments, i screwed something up19:19
*** lpetrut_ has joined #openstack-nova19:20
*** suresh12 has joined #openstack-nova19:20
openstackgerritMatt Riedemann proposed openstack/nova master: Provide support matrix and doc for VGPU  https://review.openstack.org/53926619:20
artomYeah, I think rescue and resize got merged/switched/borked19:21
mriedemfixed in the latest revision19:22
mriedemi think it's ready for canadian-style scrutiny19:22
artomQuebec, *ahem*19:23
mriedemthat's not canada?19:23
mriedemfrench canada19:23
mriedembut still19:23
artomNot if we can help it ;)19:23
mriedemyou're like the texas of canada?19:23
mriedemle yeeha19:23
mriedem*yeehaw19:23
artomL'osti de takarnak19:23
artom*tabarnak19:23
artomDammit :(19:23
artommriedem, can I circle back to that doc later tonight? I promised daughter we'd assemble her new bed while she's in daycare :P19:24
*** jpena|away is now known as jpena|off19:24
artomI wasn't expecting Sylvain to react to the review until tomorrow morning :/19:25
*** amoralej is now known as amoralej|off19:25
mriedemjust throw some blankets and pillows on the ground19:25
mriedemdamn kids and their demands for beds19:26
mriedemwa wa feed me bathe me love me19:26
*** suresh12 has quit IRC19:26
*** DinaBelova has quit IRC19:29
*** aignatov has quit IRC19:29
*** ralonsoh_ has quit IRC19:30
dimsmriedem : wait for a few years... it turns into "leave me alone!"19:31
dims:)19:31
*** suresh12 has joined #openstack-nova19:31
mriedemi almost thought i was going to see tears yesterday morning about the pants that laura laid out19:34
mriedemso yeah i know what it's going to be like already19:34
mriedemonly *i* get to cry about the pants that laura lays out for me to wear!19:35
edleafemriedem: you wear pants?19:35
mriedemstill do yup19:35
mriedemand shave and get haircuts19:35
mriedemhasn't been a year of working at home yet19:35
dansmithmriedem: I was going to say.. my pants still get laid out for me for important pants-wearing occasions19:35
edleafethat's why I only have one pair. Prevents all the pants-related arguments19:36
dansmithbusiness in the front, party in the back?19:37
*** harlowja has joined #openstack-nova19:37
* edleafe wonders what kind of parties dansmith goes to19:37
dansmithnot the kind that require specific pant selection, that's for sure19:38
*** ccamacho has quit IRC19:38
*** sree has joined #openstack-nova19:39
*** amodi has quit IRC19:39
*** mriedem1 has joined #openstack-nova19:41
*** ccamacho has joined #openstack-nova19:41
*** gyee has joined #openstack-nova19:42
*** DinaBelova has joined #openstack-nova19:42
*** aignatov has joined #openstack-nova19:42
*** mriedem has quit IRC19:42
*** sree has quit IRC19:43
*** cdent has quit IRC19:53
*** calebb has quit IRC19:57
*** salv-orlando has quit IRC20:00
*** salv-orlando has joined #openstack-nova20:00
*** calebb has joined #openstack-nova20:01
openstackgerritAmeed Ashour proposed openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows man page  https://review.openstack.org/53965420:02
*** calebb is now known as squid20:02
*** squid is now known as calebb20:02
openstackgerritMatt Riedemann proposed openstack/nova master: doc: placement upgrade notes for queens  https://review.openstack.org/53965820:05
*** salv-orlando has quit IRC20:05
*** moshele has joined #openstack-nova20:06
*** sree has joined #openstack-nova20:07
mriedem1need a final +2 on the reno for versioned notifications new in queens https://review.openstack.org/#/c/518018/20:09
*** mriedem1 is now known as mriedem20:09
mriedemcfriesen: did your perf testing show any issues with the counting quotas stuff that was new in pike?20:11
*** sree has quit IRC20:11
*** aignatov has quit IRC20:17
*** DinaBelova has quit IRC20:17
*** DinaBelova has joined #openstack-nova20:17
*** aignatov has joined #openstack-nova20:18
*** felipemonteiro_ has joined #openstack-nova20:21
*** READ10 has quit IRC20:21
*** DinaBelova has quit IRC20:21
*** aignatov2 has joined #openstack-nova20:22
*** DinaBelova has joined #openstack-nova20:22
*** aignatov has quit IRC20:23
*** aignatov2 is now known as aignatov20:23
cfriesenmriedem: don't know if we've gotten that far.  I'm pretty sure it was on a mostly idle system so I wouldn't expect that to be a major factor.20:24
*** felipemonteiro has quit IRC20:24
*** vivsoni_ has joined #openstack-nova20:26
*** vivsoni has quit IRC20:26
*** kwathore__ has joined #openstack-nova20:27
*** tidwellr has quit IRC20:27
*** chyka has quit IRC20:29
*** kwathore_ has quit IRC20:29
*** chyka has joined #openstack-nova20:30
*** sree has joined #openstack-nova20:31
*** chyka_ has joined #openstack-nova20:33
*** chyka has quit IRC20:34
*** tssurya_ has joined #openstack-nova20:34
openstackgerritAmeed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails  https://review.openstack.org/52838520:35
*** sree has quit IRC20:36
*** links has joined #openstack-nova20:36
openstackgerritMatt Riedemann proposed openstack/nova master: Re-arrange cells docs for modern deployments  https://review.openstack.org/53967420:37
mriedemdansmith: melwitt: we had talked at one point a few weeks ago about re-arranging the cells docs to move the cells v2 setup stuff to the top since that's mostly what people care about now when upgrading to ocata ^20:38
mriedemtried to move that stuff around and still leave the historical manifesto and cells v1 stuff in there to still make sense20:38
melwittack20:39
*** DinaBelova has quit IRC20:39
*** aignatov has quit IRC20:39
*** DinaBelova has joined #openstack-nova20:40
*** aignatov has joined #openstack-nova20:40
*** derekh has quit IRC20:41
*** chyka_ has quit IRC20:42
*** chyka has joined #openstack-nova20:42
*** efried_rollin is now known as efried20:42
efriedmriedem: "the in-tree powervm driver doesn't support gpu passthrough right?" Not yeeeeeetttt....20:44
*** tidwellr has joined #openstack-nova20:45
*** chyka has quit IRC20:48
hrwdoes someone uses hw_pointer_model option? with something else than 'usbtablet' there?20:49
*** chyka has joined #openstack-nova20:49
hrwand if you do then does it work for you?20:49
*** eharney has quit IRC20:54
*** Tom-Tom has joined #openstack-nova20:55
*** moshele has quit IRC20:56
*** Tom-Tom has quit IRC21:00
*** lpetrut_ has quit IRC21:00
*** salv-orlando has joined #openstack-nova21:01
*** sree has joined #openstack-nova21:02
*** vivsoni__ has joined #openstack-nova21:04
*** vivsoni_ has quit IRC21:04
ameedamriedem: replied21:05
mriedemhrw: i thought it was end of day for you?21:05
*** pchavva has quit IRC21:06
*** salv-orlando has quit IRC21:06
*** sree has quit IRC21:06
openstackgerritMatt Riedemann proposed openstack/nova master: Re-arrange cells docs for modern deployments  https://review.openstack.org/53967421:07
*** liverpooler has quit IRC21:10
*** vivsoni__ has quit IRC21:12
*** vivsoni__ has joined #openstack-nova21:12
*** kwathore__ has quit IRC21:12
*** kwathore__ has joined #openstack-nova21:13
mriedemdansmith: can you hit this backport so i can get the one below it? https://review.openstack.org/#/c/527560/21:17
ameedamriedem: please check the patch there is important comment there https://review.openstack.org/#/c/50748621:17
dansmithmriedem: doneski21:18
*** mvk has joined #openstack-nova21:18
*** priteau has joined #openstack-nova21:19
*** kwathore_ has joined #openstack-nova21:22
*** vivsoni__ has quit IRC21:22
*** vivsoni__ has joined #openstack-nova21:22
mriedemameeda: i'm not sure what you want me to look at in that change21:23
*** suresh12 has quit IRC21:23
mriedemugh i guess we can't backport this fix now https://review.openstack.org/#/c/524755/4/nova/objects/host_mapping.py@15221:24
*** kwathore__ has quit IRC21:25
mriedemeven though nothing uses it over rpc?21:25
*** pchavva has joined #openstack-nova21:25
*** rmcall has quit IRC21:27
*** moshele has joined #openstack-nova21:27
dansmithmriedem: well like I said I don't think that needed to be a bump anyway21:27
dansmithmriedem: you could backport without the version bump and be fine I think.. seems scary, but should be alright21:28
openstackgerritClaudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated  https://review.openstack.org/34221121:28
*** sree has joined #openstack-nova21:31
mriedemefried: see what you think about my 'experimental' wording idea in https://review.openstack.org/#/c/539266/21:32
*** links has quit IRC21:32
mriedemdansmith: might not be necessary, i was just thinking about it b/c the cells faq page says you can use this to list hosts in a cell, but there are other options for doing that as well, so not super important21:32
*** sree has quit IRC21:35
ameedamriedem: Surya Seetharaman -> The same change of adding "--until-complete" is been done here I think ? : https://review.openstack.org/#/c/507486/29/doc/source/cli/nova-manage.rst21:36
ameedamriedem: I will upload new patch now21:37
mriedemameeda: your patch is much more targeted to just updating the man page21:37
openstackgerritAmeed Ashour proposed openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows.  https://review.openstack.org/53965421:38
ameedamriedem: I uploaded new patch.21:38
ameedamriedem: it seems that I shouldn't write tab when I add description ?21:39
efriedmriedem: Responded.  Thanks.21:41
openstackgerritAmeed Ashour proposed openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows.  https://review.openstack.org/53965421:41
mriedemameeda: everything should be spaces, not tabs21:41
*** ssurana has joined #openstack-nova21:41
*** ssurana has left #openstack-nova21:41
ameedamriedem: oh, ok I will upload new patch, sorry21:42
openstackgerritAmeed Ashour proposed openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows.  https://review.openstack.org/53965421:46
ameedamriedem: uploaded (Y)21:47
*** salv-orlando has joined #openstack-nova21:47
*** ccamacho has quit IRC21:48
ameedamriedem: Thank you!! now I need to get Ocata release and add the change for it ? I think that I has pike version right ?21:52
*** pchavva has quit IRC21:53
*** tssurya_ has quit IRC21:53
mriedemameeda: you're on the master branch, which is currently queens21:53
mriedemameeda: review process is generally 2 +2s to approve a patch21:53
mriedemameeda: so you might as well hold off until someone actually approves the change21:53
*** suresh12_ has joined #openstack-nova21:53
efriedmriedem: FYI, I seem to have a decent delay in receiving email from the mailing lists.  (By way of explaining why I appeared to say the same thing you had "already" said.)21:55
openstackgerritMatt Riedemann proposed openstack/nova master: Provide support matrix and doc for VGPU  https://review.openstack.org/53926621:55
mriedemefried: that is no excuse, you need to do better at your precognition of issues to come up in the ML in order to beat me to the punch21:56
efriedclearly21:57
mriedembetter call tom cruise21:57
efriedor that bald chick21:57
*** brault has quit IRC21:58
ameedamriedem: its okay, Thank you for your time and helps.21:59
ameedamriedem: please don't forget to review this for me https://review.openstack.org/#/c/528385/21:59
*** gjayavelu has quit IRC21:59
*** priteau has quit IRC22:00
*** vivsoni__ has quit IRC22:01
*** priteau has joined #openstack-nova22:01
*** kwathore__ has joined #openstack-nova22:01
*** vivsoni__ has joined #openstack-nova22:01
*** moshele has quit IRC22:01
mriedemameeda: at this point i dream about the opportunity to review that patch :)22:01
mriedemit is my destiny22:01
*** priteau has quit IRC22:03
*** priteau has joined #openstack-nova22:03
*** yamahata has quit IRC22:04
*** kwathore_ has quit IRC22:04
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_access_get_by_flavor_id db api method  https://review.openstack.org/53970022:05
*** gjayavelu has joined #openstack-nova22:05
ameedamriedem: lol, I appreciate that from you,I know that its hard to you to find time to check all reviews22:05
ameedamriedem: lastly I see +2 on one  of my patches ^_^, lol22:06
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_delete db api method  https://review.openstack.org/53970222:07
melwittmriedem: on this backport, we're only concerned about holding it from ocata because of the possible related network-vif-plugged event timeout, but not for pike? https://review.openstack.org/#/c/53142222:13
mriedemmelwitt: i am concerned for pike, but we have more time for pike22:13
mriedemso less concerned22:13
melwittokay22:14
*** awaugama has quit IRC22:14
mriedemi thought about dropping my +222:14
mriedembut i didn't think about it very hard22:14
melwittfair enough22:14
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_delete db api method  https://review.openstack.org/53970222:15
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_get db api method  https://review.openstack.org/53970622:15
*** sree has joined #openstack-nova22:15
Roamer`hm, has anybody reported problems with the "libvirt: QEMU native LUKS decryption for encrypted volumes" change recently?22:17
melwittnot that I know of. have you experienced problems with it?22:18
Roamer`the StorPool Cinder CI started failing each and every test run with the same problem: test_encrypted_cinder_volumes_luks fails and there is a nova-compute exception: Failed to detach volume 645fd643-89fc-4b3d-9ea5-59c764fc39a2 from /dev/vdb: AttributeError: 'NoneType' object has no attribute 'format_dom'22:18
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_delete db api method  https://review.openstack.org/53970222:19
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_get db api method  https://review.openstack.org/53970622:19
Roamer`just a minute, let me point you at a stack trace22:19
Roamer`http://logs.ci-openstack.storpool.com/18/539318/1/check/dsvm-tempest-storpool/c3daf58/logs/screen-n-cpu.txt.gz#_Jan_31_18_07_27_971552 and a couple of lines further down22:19
*** eharney has joined #openstack-nova22:20
*** sree has quit IRC22:20
Roamer`melwitt: ^^  - it looks like the LibvirtConfigGuestDiskEncryption is missing a "secret" (not initialized; maybe not passed somewhere?)22:20
Roamer`and this happens on every run22:20
melwittRoamer`: okay. could you please open a bug against nova with a link to the log and excerpt of the stack trace?22:21
Roamer`melwitt, sure, I'll open it right now22:21
melwittwe'll have lyarwood take a look at it22:21
melwittthank you22:22
*** salv-orl_ has joined #openstack-nova22:23
*** rmcall has joined #openstack-nova22:23
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_access_remove db api method  https://review.openstack.org/53970922:24
*** salv-orlando has quit IRC22:25
*** mvenesio has quit IRC22:27
*** mvenesio has joined #openstack-nova22:27
*** mvenesio has quit IRC22:31
*** edmondsw has quit IRC22:32
*** edmondsw has joined #openstack-nova22:33
Roamer`lyarwood, melwitt, https://bugs.launchpad.net/nova/+bug/174660922:34
openstackLaunchpad bug 1746609 in OpenStack Compute (nova) "test_boot_server_from_encrypted_volume_luks cannot detach an encrypted StorPool-backed volume" [Undecided,New]22:34
Roamer`it's a bit brief, but it has links to the logs...22:34
openstackgerritEric Fried proposed openstack/nova master: Avoid inventory DELETE API (no conflict detection)  https://review.openstack.org/53971222:34
efriedjaypipes: How about them apples ^22:34
efriedNote approx -400LOC net.22:35
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_access_add db api methods  https://review.openstack.org/53971422:35
melwittRoamer`: thanks. we'll use this to investigate what's going wrong22:35
openstackgerritEric Berglund proposed openstack/nova master: Use dict.get() when accessing capabilities dict  https://review.openstack.org/53971522:35
*** gjayavelu has quit IRC22:36
*** gjayavelu has joined #openstack-nova22:36
*** edmondsw has quit IRC22:37
mriedemRoamer`: is the storpool volume driver passing a secret in it's connection_info dict when using an encrypted volume type22:41
mriedemi'm not actually sure if that's required22:42
mriedemshould probably check lee's patches to see if he had to change anything in devstack for this stuff to work, like with the key manager across both nova and cinder22:42
*** suresh12_ has quit IRC22:42
*** salv-orl_ has quit IRC22:42
mriedemhttps://review.openstack.org/#/q/topic:bp/libvirt-qemu-native-luks+(status:open+OR+status:merged)22:43
*** salv-orlando has joined #openstack-nova22:43
*** felipemonteiro_ has quit IRC22:43
mriedemmelwitt: you know,22:43
mriedemnow that i think about it,22:43
*** felipemonteiro_ has joined #openstack-nova22:43
mriedemthe tempest test that tests encrypted volumes is marked 'slow' so i don't think it actually runs in a job in our check queue...22:43
mriedemi think there is a job that runs it in the experimental queue22:43
mriedemthis one https://github.com/openstack-infra/project-config/blob/master/zuul.d/projects.yaml#L1084122:44
*** priteau has quit IRC22:45
*** suresh12 has joined #openstack-nova22:45
mriedempasses here though http://logs.openstack.org/60/539260/2/experimental/legacy-tempest-dsvm-neutron-scenario-multinode-lvm-multibackend/77a82c8/job-output.txt.gz#_2018-01-31_20_59_15_16153822:46
*** sree has joined #openstack-nova22:46
*** salv-orlando has quit IRC22:47
melwitthm, okay22:48
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_access_get_by_flavor_id db api method  https://review.openstack.org/53972022:48
*** rmcall has quit IRC22:49
*** sree has quit IRC22:50
Roamer`mriedem, the StorPool driver does not generate any structures by itself, at your suggestion it inherits LibvirtVolumeDriver's get_config() method22:53
*** gjayavelu has quit IRC22:53
*** sree has joined #openstack-nova22:53
Roamer`and from what I can see of the libvirt LUKS patch, the secret should be stored by LibvirtBaseVolumeDriver's get_config()22:53
*** andreas_s has joined #openstack-nova22:54
mriedemu'data': {u'device_path': u'/dev/storpool/os--volume-645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'encrypted': True, u'volume': u'645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'qos_specs': None, u'client_id': 12, u'access_mode': u'rw'}22:54
mriedemhttps://review.openstack.org/#/c/523958/18/nova/virt/libvirt/driver.py@134222:54
mriedemlooks like the libvirt driver is expecting a connection_info['data']['volume_id'] entry22:55
melwittthere must be one, else we'd see a KeyError, right? is it None?22:56
Roamer`hm, ISTR that there was a "volume_id" one level up, on the same level as "data", but let me look again22:56
mriedemhttps://review.openstack.org/#/c/523958/18/nova/virt/libvirt/volume/volume.py22:56
mriedemmelwitt: the libvirt driver code is using .get() to avoid a keyerror22:57
melwittI see it now22:57
*** sree has quit IRC22:58
*** andreas_s has quit IRC22:58
melwittso is volume_id supposed to always be set in connect_info['data'] or is it valid not to have it?22:58
mriedemshrug,22:59
mriedemconnection_info is a wild west of whatever from the bazillion volume drivers in cinder22:59
mriedemi do know that in nova, when we attach, we shove 'serial' into the connection_info if it's not already there22:59
mriedemand serial == volume_id22:59
melwittsigh22:59
smcginnisI don't think the serial is always the volume_id.23:00
smcginnisRemoteFS based storage I think that's the case, but not others.23:00
mriedem{u'status': u'reserved', u'instance': u'9a7f0101-917d-43f2-ac18-0b7d77c14fda', u'attached_at': u'', u'attach_mode': None, u'driver_volume_type': u'storpool', u'detached_at': u'', u'volume_id': u'645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'serial': u'645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'data': {u'device_path': u'/dev/storpool/os--volume-645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'encrypted': True, u'volume': u'645fd643-89fc-4b3d23:00
mriedem5-59c764fc39a2', u'qos_specs': None, u'client_id': 12, u'access_mode': u'rw'}}23:00
mriedemsmcginnis: it's the volume_id if it's not already in the dict from cinder23:00
smcginnisAh, OK.23:01
mriedemhttps://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L42523:01
*** munishmehan has quit IRC23:01
mriedemb/c we shove it in there23:01
mriedemshove it real good23:01
smcginnisNah, just not the same as push it. Nice try.23:01
melwittoh, heh. smcginnis came here. I just asked the question in #openstack-cinder if it's valid not to have 'volume_id' in connection_info['data']23:01
mriedemso all of this new encryptor code from lyarwood should probably be falling back to looking for the serial in connection_info if connection_info['data'] doesn't have 'volume_id'23:01
*** burt has quit IRC23:01
smcginnisI do not think it's safe to assume that.23:02
melwittmdbooth ^23:02
*** gjayavelu has joined #openstack-nova23:02
* smcginnis is always lurking23:02
*** hemna_ has quit IRC23:02
*** slaweq has joined #openstack-nova23:04
*** tidwellr has quit IRC23:05
openstackgerritEric Berglund proposed openstack/nova master: Use dict.get() when accessing capabilities dict  https://review.openstack.org/53971523:05
*** tidwellr has joined #openstack-nova23:05
*** esberglu has quit IRC23:07
mriedemi don't really know how this is failing23:07
mriedemif there is no secret, it shouldn't be set in the conf23:08
*** felipemonteiro__ has joined #openstack-nova23:08
melwittoh, you mean find_secret should return None or something23:09
mriedemidk, i get lost following the damn xml conversion crap in the libvirt driver23:09
melwitter, sorry it wouldn't even call find_secret23:09
*** slaweq has quit IRC23:09
*** tidwellr has quit IRC23:09
*** slaweq has joined #openstack-nova23:11
mriedemmy guess is we don't get here https://review.openstack.org/#/c/464008/10/nova/virt/libvirt/config.py@114923:11
*** felipemonteiro_ has quit IRC23:12
melwittyeah, and we wouldn't because there's no secret in the config23:13
melwittif c.tag == 'secret': would be False23:13
melwittso since there was no volume_id, there's no secret in the config, so there's no secret to be parsed into the config object, then it blows up when it goes to format the domain later23:14
*** slaweq has quit IRC23:15
mriedemhttp://logs.ci-openstack.storpool.com/18/539318/1/check/dsvm-tempest-storpool/c3daf58/logs/screen-n-cpu.txt.gz#_Jan_31_18_07_21_99438523:15
mriedemthat's the secret xml23:15
mriedemsshhhh23:15
melwittlol23:16
melwittso there IS secret xml? sigh, I'm confused23:17
melwittback to not knowing how this is failing23:17
mriedemright i have no idea23:18
mriedembasically need to wait for lyarwood to wake up23:18
melwittyeah23:18
*** sree has joined #openstack-nova23:19
*** sdague has quit IRC23:20
*** sree has quit IRC23:23
*** mlavalle has quit IRC23:24
*** john51 has quit IRC23:26
*** lyan has quit IRC23:27
*** rcernin has joined #openstack-nova23:28
*** john51 has joined #openstack-nova23:33
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_destroy db api method  https://review.openstack.org/53972923:33
*** yamahata has joined #openstack-nova23:35
lyarwood*yawn*23:37
lyarwoodI really need to remove email from my phone23:37
lyarwood<volume>None</volume>23:37
lyarwoodthat's the issue btw23:37
melwittwell HI23:37
lyarwoodah, so you already found that above :)23:39
openstackgerritEric Fried proposed openstack/nova master: Test case: new standard resource class unusable  https://review.openstack.org/53973223:40
efriedmriedem (in the correct channel) FYI there's a test case demonstrating the aforementioned bug that has nothing to do with infra ^23:40
melwittlyarwood: we thought so but then got confused about how there's a <secret> element in the XML anyway23:41
melwittwe were thinking the non-existent connection_info['data']['volume_id'] would result in *no* 'secret' element in the XML, then blow up later when it tried to parse <secret> back23:41
melwittbut we see <secret> XML in the log. so then we knew we had to wait until you could look at it23:42
*** john51 has quit IRC23:43
*** salv-orlando has joined #openstack-nova23:43
*** sree has joined #openstack-nova23:44
*** john51 has joined #openstack-nova23:45
Roamer`sorry I disappeared like that, had to take care of something at home23:47
Roamer`but now it's a bit late here, so I guess I'll be off for the night; feel free to let me know if there's any way I can help with this secret problem23:47
*** salv-orlando has quit IRC23:47
*** armax has quit IRC23:49
openstackgerritMatt Riedemann proposed openstack/nova master: Remove old flavor_get_by_flavor_id db api method  https://review.openstack.org/53973323:49
mriedemlyarwood: seems odd that it would add encryption elements at all if there was no volume_id found in the connection_info, that's what i don't get23:49
*** sree has quit IRC23:49
*** rcernin has quit IRC23:50
lyarwoodmriedem: right that's the inital bug here - https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L132623:50
efriedmriedem: Okay, slightly weirder question.  I assume it's possible to upgrade the placement service without upgrading the compute service (cause that's a way to get to the condition I asked about before).  Does compute get restarted if that happens?23:50
lyarwoodmriedem: that needs to change to handle the case where volume_id isn't in connection_info as you've already discussed23:50
*** sdague has joined #openstack-nova23:53
mriedemlyarwood: ah yeah23:53
mriedemok23:53
mriedemeasy peasy23:54
mriedemefried: i have'nt read the bug, but yes placement gets upgraded before nova services23:54
mriedemand computes can be n-1 for rolling upgrades23:54
efriedight23:54
*** gjayavelu has quit IRC23:56
*** umbSublime has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!