*** hongbin has quit IRC | 00:18 | |
*** awaugama has quit IRC | 00:19 | |
*** zhurong has joined #openstack-nova | 00:21 | |
*** salv-orlando has joined #openstack-nova | 00:22 | |
*** salv-orlando has quit IRC | 00:27 | |
*** kmalloc has quit IRC | 00:29 | |
openstackgerrit | Merged openstack/nova master: [placement] Add sending global request ID in delete (3) https://review.openstack.org/526557 | 00:29 |
---|---|---|
openstackgerrit | Merged openstack/nova master: Avoid suspending guest with attached vGPUs https://review.openstack.org/535693 | 00:29 |
*** yangyapeng has quit IRC | 00:31 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Transform live_migration_post_dest notification https://review.openstack.org/469784 | 00:32 |
*** chyka has quit IRC | 00:34 | |
openstackgerrit | Merged openstack/nova master: Handle TZ change in iso8601 >=0.1.12 https://review.openstack.org/535700 | 00:36 |
*** zhurong has quit IRC | 00:37 | |
*** Dinesh_Bhor has joined #openstack-nova | 00:37 | |
*** hiro-kobayashi has joined #openstack-nova | 00:42 | |
*** mlavalle has quit IRC | 00:42 | |
*** markvoelker has quit IRC | 00:43 | |
*** markvoelker has joined #openstack-nova | 00:44 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Separate API schemas (resource_provider) https://review.openstack.org/528629 | 00:44 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unnecessary arguments in notification methods https://review.openstack.org/535599 | 00:45 |
*** Dinesh_Bhor has quit IRC | 00:47 | |
*** mlavalle has joined #openstack-nova | 00:48 | |
*** markvoelker has quit IRC | 00:48 | |
*** liusheng has quit IRC | 00:49 | |
*** zhurong has joined #openstack-nova | 00:49 | |
*** hshiina has joined #openstack-nova | 00:51 | |
*** Dinesh_Bhor has joined #openstack-nova | 00:51 | |
*** damien_r has joined #openstack-nova | 00:58 | |
*** Dinesh_Bhor has quit IRC | 01:01 | |
*** damien_r has quit IRC | 01:02 | |
openstackgerrit | Nakanishi Tomotaka proposed openstack/nova master: Use Placement API to check resource usage https://review.openstack.org/528953 | 01:03 |
*** gjayavelu has quit IRC | 01:03 | |
*** r-daneel has quit IRC | 01:04 | |
*** owalsh has quit IRC | 01:05 | |
*** owalsh_ has joined #openstack-nova | 01:05 | |
*** owalsh_ is now known as owalsh | 01:06 | |
*** rcernin has joined #openstack-nova | 01:09 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Invalid query parameter could lead to HTTP 500 https://review.openstack.org/539164 | 01:13 |
*** dave-mccowan has joined #openstack-nova | 01:13 | |
*** slaweq has joined #openstack-nova | 01:13 | |
*** felipemonteiro__ has quit IRC | 01:14 | |
*** hieulq_ has quit IRC | 01:15 | |
*** slaweq has quit IRC | 01:18 | |
*** gongysh has joined #openstack-nova | 01:19 | |
*** zhaochao has joined #openstack-nova | 01:20 | |
*** takashin has quit IRC | 01:20 | |
*** yangyapeng has joined #openstack-nova | 01:21 | |
*** hieulq_ has joined #openstack-nova | 01:27 | |
*** tiendc has joined #openstack-nova | 01:29 | |
*** damien_r has joined #openstack-nova | 01:30 | |
*** markvoelker has joined #openstack-nova | 01:30 | |
*** damien_r has quit IRC | 01:34 | |
*** tbachman has joined #openstack-nova | 01:35 | |
mriedem_afk | woot vgpu patch finally merged https://review.openstack.org/#/c/535693/ | 01:35 |
mriedem_afk | alex_xu: want to hit this release note for versioned notification transformation for queens? https://review.openstack.org/#/c/518018/ | 01:37 |
*** mriedem_afk is now known as mriedem | 01:37 | |
Spazmotic | how are you awake even more than me | 01:42 |
mriedem | it's 7:45 | 01:43 |
Spazmotic | ..so it is | 01:43 |
Spazmotic | sorry.. third shift.. sometimes my hours don't make sense | 01:43 |
mriedem | exercise, vegetables and clean living | 01:43 |
Spazmotic | That's my lifestyle as well the past year.. I respect it:) | 01:44 |
Spazmotic | Nowadays I use my Racker picture on my badge as inspiration.. have lost 170lbs. But still.. Third Shift hours and having a fiancee in Korea make my hours ridiculous hehe | 01:45 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532290 | 01:46 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 01:46 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | 01:46 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert driver supported capabilities to compute node provider traits https://review.openstack.org/538498 | 01:46 |
bkero- | That's a crazy schedule. That must have very little overlap. | 01:46 |
Spazmotic | It could be worse.. The good thing is that Korea daytime and third shift US are pretty lined up, but right now outside of DST the time diff is a little mor difficult. | 01:46 |
bkero- | gotta get those remote working privs | 01:47 |
bkero- | then korea | 01:47 |
mriedem | efried: looks like the nrp series has a merge conflict starting here now https://review.openstack.org/#/c/521098/30 | 01:48 |
*** yassine has joined #openstack-nova | 01:48 | |
Spazmotic | Haha I tried.. something about not having a presence in South Korea so they cannot have a remote worker there or something | 01:48 |
*** yassine is now known as Guest61824 | 01:48 | |
*** hoangcx has quit IRC | 01:48 | |
bkero- | Yeah, it's hard to ask for permission | 01:48 |
mriedem | australia | 01:49 |
mriedem | rax is there | 01:49 |
mriedem | then at least the tz is closer | 01:49 |
Spazmotic | Well also HKG | 01:49 |
Spazmotic | But we are settling for bringing her here | 01:49 |
Spazmotic | Just waiting on VISA stuff | 01:49 |
mriedem | don't tell trump | 01:49 |
Spazmotic | dunno why i thought that was an anagram | 01:49 |
Spazmotic | it's early | 01:49 |
Spazmotic | Yeah it's totes hush hush, just letting you openstack fellows know.. DON'T TELL TRUMP | 01:49 |
mriedem | he'd actually be in bed eating by now if it weren't for some speech he has to give tonight | 01:50 |
Spazmotic | I'd imagine he's still doing that thing | 01:51 |
Spazmotic | Just speech from bed with giant slippers | 01:51 |
Spazmotic | Glow of his own TV show shining on his face or something, and some chicken in a bucket. | 01:51 |
Spazmotic | Swinging a drumstick around | 01:51 |
*** salv-orlando has joined #openstack-nova | 01:53 | |
*** Tom-Tom has joined #openstack-nova | 01:53 | |
*** takashin has joined #openstack-nova | 01:54 | |
mriedem | alex_xu: looks like your allocation candidates + traits gabbi tests are intermittently failing http://logs.openstack.org/10/539310/1/check/nova-tox-functional/a6ba562/job-output.txt.gz#_2018-01-30_21_02_40_414709 | 01:56 |
*** hoangcx has joined #openstack-nova | 01:56 | |
*** fragatina has quit IRC | 01:56 | |
*** salv-orlando has quit IRC | 01:57 | |
*** fragatina has joined #openstack-nova | 01:58 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1746388 | 02:00 |
openstack | Launchpad bug 1746388 in OpenStack Compute (nova) "allocation candidates with invalid traits negative functional tests are intermittently failing" [High,Confirmed] | 02:00 |
mriedem | alex_xu: ah nevermind efried found the issue https://review.openstack.org/#/c/537351/3/nova/api/openstack/placement/util.py | 02:01 |
*** takashin has left #openstack-nova | 02:02 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:02 | |
*** fragatina has quit IRC | 02:02 | |
*** gongysh has quit IRC | 02:03 | |
*** Dinesh_Bhor has quit IRC | 02:05 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:05 | |
*** damien_r has joined #openstack-nova | 02:06 | |
*** Dinesh_Bhor has quit IRC | 02:08 | |
*** damien_r has quit IRC | 02:11 | |
*** zhaochao has quit IRC | 02:11 | |
*** Swami has quit IRC | 02:11 | |
*** harlowja has quit IRC | 02:15 | |
*** mriedem has quit IRC | 02:17 | |
*** zhaochao has joined #openstack-nova | 02:24 | |
*** liusheng has joined #openstack-nova | 02:34 | |
*** rcernin has quit IRC | 02:35 | |
*** Tom-Tom_ has joined #openstack-nova | 02:44 | |
*** Tom-Tom has quit IRC | 02:45 | |
openstackgerrit | Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 02:50 |
*** Spaz-Work has quit IRC | 02:53 | |
*** Spaz-Work has joined #openstack-nova | 02:55 | |
*** Dinesh_Bhor has joined #openstack-nova | 02:55 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add unit tests for EmulatorThreadsTestCase https://review.openstack.org/538699 | 02:58 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Not use thread alloc policy for emulator thread https://review.openstack.org/538700 | 02:58 |
*** andreas_s has joined #openstack-nova | 02:59 | |
*** andreas_s has quit IRC | 03:03 | |
*** suresh12 has quit IRC | 03:04 | |
*** suresh12 has joined #openstack-nova | 03:04 | |
*** tbachman has quit IRC | 03:04 | |
*** Pramod has quit IRC | 03:05 | |
*** armax has joined #openstack-nova | 03:05 | |
*** Dinesh_Bhor has quit IRC | 03:06 | |
*** ttsiouts has quit IRC | 03:07 | |
*** ttsiouts has joined #openstack-nova | 03:07 | |
alex_xu | mrodden: got it, let me fix it | 03:08 |
alex_xu | mrodden: sorry, I should speak to mriedem | 03:09 |
*** suresh12 has quit IRC | 03:09 | |
*** armax has quit IRC | 03:10 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Use util.validate_query_params in list_traits https://review.openstack.org/539407 | 03:12 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [Placement] Invalid query parameter could lead to HTTP 500 https://review.openstack.org/539408 | 03:12 |
*** armax has joined #openstack-nova | 03:16 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: provide VGPU_DISPLAY_HEAD inventory in compute node https://review.openstack.org/523342 | 03:18 |
*** damien_r has joined #openstack-nova | 03:19 | |
*** hongbin has joined #openstack-nova | 03:19 | |
*** Tom-Tom_ has quit IRC | 03:20 | |
*** mgagne has quit IRC | 03:22 | |
*** melwitt has quit IRC | 03:23 | |
*** mgagne has joined #openstack-nova | 03:24 | |
*** mgagne is now known as Guest87240 | 03:24 | |
*** toan has quit IRC | 03:24 | |
*** damien_r has quit IRC | 03:24 | |
*** melwitt has joined #openstack-nova | 03:25 | |
*** tbachman has joined #openstack-nova | 03:25 | |
*** toan has joined #openstack-nova | 03:26 | |
*** suresh12 has joined #openstack-nova | 03:29 | |
*** suresh12 has quit IRC | 03:33 | |
*** felipemonteiro has joined #openstack-nova | 03:39 | |
*** liusheng has quit IRC | 03:40 | |
*** liusheng has joined #openstack-nova | 03:40 | |
*** felipemonteiro_ has joined #openstack-nova | 03:42 | |
*** felipemonteiro has quit IRC | 03:45 | |
*** felipemonteiro_ has quit IRC | 03:45 | |
*** felipemonteiro__ has joined #openstack-nova | 03:45 | |
*** sree has joined #openstack-nova | 03:45 | |
*** zhurong has quit IRC | 03:46 | |
*** felipemonteiro_ has joined #openstack-nova | 03:46 | |
*** felipemonteiro__ has quit IRC | 03:50 | |
*** salv-orlando has joined #openstack-nova | 03:54 | |
openstackgerrit | Eric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | 03:58 |
efried | Well, that didn't work. | 03:59 |
*** salv-orlando has quit IRC | 04:00 | |
*** abhishekk has joined #openstack-nova | 04:01 | |
*** hiro-kobayashi has quit IRC | 04:02 | |
*** yamahata has joined #openstack-nova | 04:06 | |
*** moshele has joined #openstack-nova | 04:08 | |
*** felipemonteiro__ has joined #openstack-nova | 04:11 | |
*** felipemonteiro_ has quit IRC | 04:11 | |
*** fragatina has joined #openstack-nova | 04:11 | |
*** moshele has quit IRC | 04:12 | |
*** psachin has joined #openstack-nova | 04:12 | |
*** moshele has joined #openstack-nova | 04:12 | |
*** fragatina has quit IRC | 04:16 | |
*** moshele has quit IRC | 04:18 | |
*** mlavalle has quit IRC | 04:21 | |
*** sridharg has joined #openstack-nova | 04:24 | |
*** david-lyle has quit IRC | 04:26 | |
*** felipemonteiro__ has quit IRC | 04:26 | |
*** david-lyle has joined #openstack-nova | 04:27 | |
*** dave-mccowan has quit IRC | 04:32 | |
*** sridharg has quit IRC | 04:37 | |
*** armax has quit IRC | 04:37 | |
*** ircuser-1 has joined #openstack-nova | 04:44 | |
*** slaweq has joined #openstack-nova | 04:45 | |
*** suresh12 has joined #openstack-nova | 04:49 | |
*** slaweq has quit IRC | 04:50 | |
*** rcernin has joined #openstack-nova | 04:50 | |
*** harlowja has joined #openstack-nova | 04:51 | |
*** rcernin has quit IRC | 04:51 | |
*** rcernin has joined #openstack-nova | 04:52 | |
*** ratailor has joined #openstack-nova | 05:03 | |
*** markvoelker has quit IRC | 05:06 | |
*** links has joined #openstack-nova | 05:07 | |
*** fragatina has joined #openstack-nova | 05:08 | |
*** fragatina has quit IRC | 05:09 | |
*** moshele has joined #openstack-nova | 05:10 | |
*** jose-phi_ has joined #openstack-nova | 05:10 | |
*** jaypipes has quit IRC | 05:10 | |
*** jaypipes has joined #openstack-nova | 05:11 | |
*** crushil has quit IRC | 05:11 | |
*** crushil has joined #openstack-nova | 05:11 | |
*** jose-phillips has quit IRC | 05:13 | |
*** crushil has quit IRC | 05:16 | |
*** slaweq has joined #openstack-nova | 05:19 | |
openstackgerrit | Merged openstack/nova master: Add taskflow to requirements https://review.openstack.org/533779 | 05:19 |
*** salv-orlando has joined #openstack-nova | 05:20 | |
*** slaweq has quit IRC | 05:24 | |
*** mylu has quit IRC | 05:24 | |
*** hongbin has quit IRC | 05:26 | |
*** suresh12 has quit IRC | 05:32 | |
*** suresh12 has joined #openstack-nova | 05:33 | |
*** Tom-Tom has joined #openstack-nova | 05:34 | |
*** suresh12 has quit IRC | 05:37 | |
*** mdnadeem has joined #openstack-nova | 05:41 | |
*** zhurong has joined #openstack-nova | 05:47 | |
*** threestrands has quit IRC | 05:51 | |
*** armax has joined #openstack-nova | 05:52 | |
*** xinliang has quit IRC | 05:57 | |
*** salv-orlando has quit IRC | 05:58 | |
*** salv-orlando has joined #openstack-nova | 05:59 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova master: Allow force-delete even if task_state is not None https://review.openstack.org/530879 | 06:00 |
*** threestrands has joined #openstack-nova | 06:01 | |
*** threestrands has quit IRC | 06:01 | |
*** threestrands has joined #openstack-nova | 06:01 | |
*** jaypipes has quit IRC | 06:02 | |
*** Eran_Kuris has joined #openstack-nova | 06:04 | |
openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/538473 | 06:04 |
*** jaypipes has joined #openstack-nova | 06:04 | |
*** brault has joined #openstack-nova | 06:06 | |
*** xinliang has joined #openstack-nova | 06:09 | |
*** brault has quit IRC | 06:10 | |
*** trinaths has joined #openstack-nova | 06:18 | |
*** xinliang has quit IRC | 06:21 | |
*** xinliang has joined #openstack-nova | 06:22 | |
*** lajoskatona has joined #openstack-nova | 06:23 | |
*** Eran_Kuris has quit IRC | 06:27 | |
*** liuzz has joined #openstack-nova | 06:30 | |
*** lpetrut has joined #openstack-nova | 06:31 | |
*** armax has quit IRC | 06:40 | |
*** jaypipes has quit IRC | 06:43 | |
*** jaypipes has joined #openstack-nova | 06:43 | |
*** sree_ has joined #openstack-nova | 06:43 | |
*** sree_ is now known as Guest36585 | 06:44 | |
*** sree has quit IRC | 06:45 | |
*** suresh12 has joined #openstack-nova | 06:48 | |
*** zhurong has quit IRC | 06:49 | |
*** slaweq has joined #openstack-nova | 06:52 | |
*** suresh12 has quit IRC | 06:53 | |
*** lpetrut has quit IRC | 06:54 | |
*** lpetrut has joined #openstack-nova | 06:54 | |
*** slaweq has quit IRC | 06:56 | |
*** jaypipes has quit IRC | 07:00 | |
*** jaypipes has joined #openstack-nova | 07:00 | |
*** harlowja has quit IRC | 07:01 | |
*** itlinux has joined #openstack-nova | 07:02 | |
*** zhenguo has joined #openstack-nova | 07:05 | |
*** rcernin has quit IRC | 07:08 | |
*** trinaths has quit IRC | 07:09 | |
*** markvoelker has joined #openstack-nova | 07:11 | |
*** salv-orlando has quit IRC | 07:12 | |
*** itlinux has quit IRC | 07:15 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: Insert the description of the change. https://review.openstack.org/539432 | 07:20 |
*** sridharg has joined #openstack-nova | 07:20 | |
*** lpetrut has quit IRC | 07:21 | |
*** jaosorior has quit IRC | 07:26 | |
*** gongysh has joined #openstack-nova | 07:29 | |
*** andreas_s has joined #openstack-nova | 07:30 | |
*** lpetrut has joined #openstack-nova | 07:30 | |
*** gongysh has quit IRC | 07:35 | |
*** zhurong has joined #openstack-nova | 07:38 | |
*** pooja-jadhav is now known as pooja_jadhav | 07:39 | |
*** brault has joined #openstack-nova | 07:39 | |
*** markvoelker has quit IRC | 07:42 | |
*** jaosorior has joined #openstack-nova | 07:43 | |
*** slaweq has joined #openstack-nova | 07:43 | |
*** salv-orlando has joined #openstack-nova | 07:44 | |
*** slaweq has quit IRC | 07:48 | |
*** pcaruana has joined #openstack-nova | 07:51 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:51 | |
*** AlexeyAbashkin has quit IRC | 07:51 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:52 | |
*** lpetrut has quit IRC | 07:53 | |
openstackgerrit | Nakanishi Tomotaka proposed openstack/nova master: Use Placement API to check resource usage https://review.openstack.org/528953 | 07:59 |
*** salv-orl_ has joined #openstack-nova | 07:59 | |
*** salv-orlando has quit IRC | 08:01 | |
*** amoralej|off is now known as amoralej | 08:02 | |
*** alexchadin has joined #openstack-nova | 08:05 | |
*** sree has joined #openstack-nova | 08:08 | |
*** slaweq has joined #openstack-nova | 08:08 | |
*** Guest36585 has quit IRC | 08:11 | |
*** slaweq has quit IRC | 08:13 | |
*** vivsoni__ has joined #openstack-nova | 08:14 | |
*** vivsoni_ has quit IRC | 08:14 | |
*** trinaths has joined #openstack-nova | 08:15 | |
openstackgerrit | Merged openstack/nova master: libvirt: QEMU native LUKS decryption for encrypted volumes https://review.openstack.org/523958 | 08:15 |
openstackgerrit | Merged openstack/nova master: Add release note for QEMU native LUKS decryption https://review.openstack.org/537642 | 08:15 |
*** rcernin has joined #openstack-nova | 08:16 | |
*** ralonsoh has joined #openstack-nova | 08:16 | |
openstackgerrit | Alex Xu proposed openstack/nova master: Fix nits in support traits changes https://review.openstack.org/537351 | 08:17 |
openstackgerrit | Alex Xu proposed openstack/nova master: Mention required traits in the flavors user docs https://review.openstack.org/539300 | 08:17 |
openstackgerrit | Alex Xu proposed openstack/nova master: Add functional tests for traits-based scheduling https://review.openstack.org/539310 | 08:17 |
*** slaweq has joined #openstack-nova | 08:18 | |
*** slaweq_ has joined #openstack-nova | 08:19 | |
*** tesseract has joined #openstack-nova | 08:20 | |
*** itlinux has joined #openstack-nova | 08:20 | |
*** kwathore has quit IRC | 08:21 | |
openstackgerrit | Merged openstack/nova master: ProviderTree.new_child: parent is either uuid or name https://review.openstack.org/538264 | 08:21 |
*** kwathore has joined #openstack-nova | 08:22 | |
*** slaweq has quit IRC | 08:22 | |
*** ralonsoh has quit IRC | 08:23 | |
*** sahid has joined #openstack-nova | 08:23 | |
*** salv-orl_ has quit IRC | 08:24 | |
*** ralonsoh has joined #openstack-nova | 08:26 | |
*** rcernin has quit IRC | 08:26 | |
*** ragiman has joined #openstack-nova | 08:27 | |
*** lpetrut has joined #openstack-nova | 08:28 | |
*** janki has joined #openstack-nova | 08:31 | |
*** sinese has joined #openstack-nova | 08:37 | |
*** markvoelker has joined #openstack-nova | 08:39 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Invalid query parameter could lead to HTTP 500 https://review.openstack.org/539164 | 08:39 |
*** lpetrut has quit IRC | 08:40 | |
*** jpena|off is now known as jpena | 08:43 | |
*** salv-orlando has joined #openstack-nova | 08:45 | |
*** zhurong_ has joined #openstack-nova | 08:46 | |
*** edmondsw has joined #openstack-nova | 08:50 | |
*** namnh has joined #openstack-nova | 08:54 | |
*** edmondsw has quit IRC | 08:54 | |
*** janki is now known as janki|afk | 08:55 | |
*** diga has joined #openstack-nova | 08:55 | |
*** chyka has joined #openstack-nova | 08:59 | |
*** tuanla____ has joined #openstack-nova | 09:01 | |
*** rmart04 has joined #openstack-nova | 09:01 | |
bauzas | morning Novaers | 09:03 |
* bauzas rolls eyes at the gate | 09:03 | |
*** chyka has quit IRC | 09:04 | |
*** rcernin has joined #openstack-nova | 09:05 | |
*** yamahata has quit IRC | 09:06 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Improve performance when list instances with IP filter https://review.openstack.org/539469 | 09:12 |
*** markvoelker has quit IRC | 09:12 | |
Spazmotic | Morning | 09:18 |
*** stakeda has quit IRC | 09:21 | |
*** janki|afk is now known as janki | 09:21 | |
*** hshiina has quit IRC | 09:22 | |
*** rmart04 has quit IRC | 09:30 | |
Spazmotic | Last day of my weekend.. then just 4 days and work and finally 2 weeks in KOrea to relax | 09:36 |
*** diga has quit IRC | 09:39 | |
*** derekh has joined #openstack-nova | 09:41 | |
Spazmotic | Going to take the rest of the day off and avoid python.. have a good night all, will be afk :) | 09:44 |
openstackgerrit | blkart proposed openstack/nova-specs master: don't show description content in code-block https://review.openstack.org/539478 | 09:50 |
*** zhenguo has quit IRC | 09:53 | |
bauzas | jianghuaw: not sure you saw https://review.openstack.org/#/c/539266/2 | 09:54 |
jianghuaw | bauzas, yes. I saw it. Just have not got chance to check it due to having been occupied by a kolla deployment problem. | 10:01 |
jianghuaw | thanks for asking, surely will look at it before I leave office. | 10:01 |
openstackgerrit | Rajesh Tailor proposed openstack/nova master: Allow force-delete even if task_state is not None https://review.openstack.org/530879 | 10:01 |
*** abhishekk has quit IRC | 10:02 | |
bauzas | jianghuaw: ideally, you could make a follow-up with the Xen notes | 10:04 |
jianghuaw | Sure. | 10:05 |
*** lpetrut has joined #openstack-nova | 10:07 | |
*** lpetrut_ has joined #openstack-nova | 10:09 | |
*** markvoelker has joined #openstack-nova | 10:09 | |
*** lpetrut has quit IRC | 10:12 | |
*** annp has quit IRC | 10:14 | |
*** namnh has quit IRC | 10:15 | |
*** priteau has joined #openstack-nova | 10:19 | |
*** zhurong has quit IRC | 10:19 | |
*** sdague has joined #openstack-nova | 10:20 | |
*** bhagyashri_s is now known as bhagyashris | 10:24 | |
*** sambetts|afk is now known as sambetts | 10:27 | |
*** maciejjozefczyk_ is now known as maciejjozefczyk | 10:27 | |
*** Eran_Kuris has joined #openstack-nova | 10:28 | |
amotoki | hi, i have a question on 'host' parameters in os-aggregates and os-migrateLive API. | 10:31 |
amotoki | I am working on https://review.openstack.org/#/c/538472/ (in horizon). | 10:31 |
amotoki | in nova API there are two types of "host". the one is from os-services and the other is from os-hypervisors. | 10:32 |
amotoki | I checked the API reference but I am still not clear which is expected for "hosts" in os-aggregates and "host" in migrateLive (and migrate) action. | 10:33 |
amotoki | thanks in advance. | 10:34 |
*** jafeha__ has joined #openstack-nova | 10:35 | |
*** jafeha has quit IRC | 10:35 | |
bauzas | amotoki: it refers to the os-services hostname | 10:35 |
amotoki | bauzas: thanks. is it true for both? | 10:36 |
bauzas | amotoki: well, there is a confusion | 10:36 |
*** dtantsur|afk is now known as dtantsur | 10:36 | |
bauzas | amotoki: long story short, hypervisors provide their own hostnames, so we have a tuple (service hostname, hypervisor hostname) identifying a single node | 10:37 |
bauzas | for most of our virt drivers, a compute service only serves a single hypervisor | 10:37 |
*** gszasz has joined #openstack-nova | 10:37 | |
bauzas | so there is no real problem in adressing the host itself by its service name | 10:37 |
bauzas | but for ironic, that paradigm isn't true | 10:37 |
bauzas | since a single compute service serves for all the ironic nodes | 10:38 |
amotoki | i think the same thing happens for vmware (vcenter) driver. | 10:38 |
bauzas | no | 10:38 |
bauzas | because nova sees the vCloud as a single node | 10:38 |
bauzas | how it's managed within that cloud is beyond its view | 10:39 |
amotoki | does nova consider vCloud as a big host? | 10:39 |
bauzas | exactly | 10:39 |
bauzas | from a scheduling perspective | 10:39 |
bauzas | which is what aggregates are for :) | 10:39 |
amotoki | aggregates refer to service host name, so how can we distinguish individual hosts? is it determined based on aggregate metadata? | 10:41 |
*** markvoelker has quit IRC | 10:42 | |
ameeda | Hello, what is the different between "self.volume_api.detach" and " self._detach_volumes" in nova manager ? | 10:42 |
*** Tom-Tom has quit IRC | 10:44 | |
bauzas | amotoki: sorry, was at the coffee machine | 10:45 |
amotoki | bauzas: no problem. thanks for your support | 10:45 |
*** josecastroleon has joined #openstack-nova | 10:46 | |
bauzas | amotoki: so, the answer is "that's not supported" | 10:46 |
bauzas | amotoki: all the Aggregate API logic is based on services checks | 10:47 |
bauzas | amotoki: that means that if you use ironic and want aggregates, you will only shard your cloud by the compute services, that's it, not by your ironic deployment | 10:47 |
*** zhurong_ has quit IRC | 10:48 | |
bauzas | call it a limitation | 10:48 |
bauzas | from my perspective, it's just that ironic introduced a new paradigm (N hypervisors for a single service) without changing the Nova API, which is why it's broken | 10:48 |
*** lucas-afk is now known as lucasagomes | 10:48 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161 | 10:49 |
amotoki | bauzas: thanks for clarification. I see the current logic and it is good to know that :) | 10:50 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Fix typos in release notes https://review.openstack.org/539490 | 10:51 |
*** salv-orlando has quit IRC | 10:52 | |
*** andreas_s has quit IRC | 10:52 | |
*** salv-orlando has joined #openstack-nova | 10:52 | |
*** belmoreira has joined #openstack-nova | 10:52 | |
*** andreas_s has joined #openstack-nova | 10:56 | |
*** salv-orlando has quit IRC | 10:57 | |
*** Tom-Tom has joined #openstack-nova | 10:58 | |
jianghuaw | bauzas, thanks for creating the documents for vGPU. The patch looks very good. I will add the part for XenAPI. | 10:59 |
bauzas | jianghuaw: FWIW, I'm also currently working on providing a functional testcase that will use a fake libvirt driver with mdevs | 11:00 |
*** trinaths has quit IRC | 11:00 | |
jianghuaw | bauzas, thanks for the heads-up. | 11:00 |
* bauzas just needs to understand what the hell the fakelibvirt module is doing | 11:01 | |
jianghuaw | What's I can help on that> | 11:01 |
*** mvk has quit IRC | 11:01 | |
bauzas | there are a couple of libvirt functional tests already, so I'll land that funct test battery into there | 11:02 |
bauzas | you could see if Xen got some | 11:02 |
jianghuaw | ok. will check it. | 11:02 |
*** jmlowe has quit IRC | 11:02 | |
bauzas | later, we could discuss with other folks if we would maybe have a single test battery that would check both drivers, I dunno yet | 11:02 |
*** Tom-Tom has quit IRC | 11:03 | |
bauzas | like a base test class that would test what's supported by both drivers, and we would just inherit from it | 11:03 |
bauzas | of course, the setup of that test class would be per-driver | 11:03 |
jianghuaw | sounds good. | 11:03 |
bauzas | jianghuaw: so, nothing from your side yet I guess | 11:04 |
jianghuaw | ok. | 11:04 |
bauzas | just maybe if you have time, try to see how to mock your Xen API the less invasive way | 11:04 |
jianghuaw | k | 11:05 |
bauzas | ideally, I wouldn't want to mock every single libvirt call like we do in the unittests, rather just pass a libvirt fixture that would setup my host like I want | 11:05 |
bauzas | hence the fakelibvirt module reading | 11:05 |
*** amorin has left #openstack-nova | 11:05 | |
*** andreas_s has quit IRC | 11:06 | |
*** andreas_s has joined #openstack-nova | 11:07 | |
*** alexchadin has quit IRC | 11:09 | |
*** AlexeyAbashkin has quit IRC | 11:09 | |
*** tuanla____ has quit IRC | 11:11 | |
*** andreas_s has quit IRC | 11:11 | |
*** ratailor has quit IRC | 11:14 | |
*** AlexeyAbashkin has joined #openstack-nova | 11:15 | |
*** andreas_s has joined #openstack-nova | 11:17 | |
*** sinese has quit IRC | 11:17 | |
*** mdbooth has quit IRC | 11:21 | |
*** ansiwen has quit IRC | 11:21 | |
*** andreas_s has quit IRC | 11:22 | |
*** suresh12 has joined #openstack-nova | 11:22 | |
*** mdbooth has joined #openstack-nova | 11:24 | |
*** ansiwen has joined #openstack-nova | 11:24 | |
*** andreas_s has joined #openstack-nova | 11:27 | |
*** alexchadin has joined #openstack-nova | 11:29 | |
*** mvk has joined #openstack-nova | 11:30 | |
*** alexchadin has quit IRC | 11:32 | |
*** andreas_s has quit IRC | 11:36 | |
*** kwathore_ has joined #openstack-nova | 11:37 | |
*** vivsoni__ has quit IRC | 11:37 | |
*** vivsoni__ has joined #openstack-nova | 11:37 | |
*** markvoelker has joined #openstack-nova | 11:39 | |
*** Eran_Kuris has quit IRC | 11:39 | |
*** alexchadin has joined #openstack-nova | 11:39 | |
*** kwathore has quit IRC | 11:40 | |
*** andreas_s has joined #openstack-nova | 11:42 | |
*** mdnadeem_ has joined #openstack-nova | 11:43 | |
openstackgerrit | Merged openstack/nova master: Fix documentation nits in set_and_clear_allocations https://review.openstack.org/531001 | 11:44 |
*** alexchadin has quit IRC | 11:44 | |
*** mdnadeem has quit IRC | 11:44 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Marker reset option for nova-manage map_instances https://review.openstack.org/539501 | 11:44 |
*** moshele has left #openstack-nova | 11:44 | |
*** moshele has joined #openstack-nova | 11:45 | |
*** mdnadeem has joined #openstack-nova | 11:45 | |
*** mdnadeem_ has quit IRC | 11:48 | |
*** yamamoto_ has quit IRC | 11:48 | |
*** alexchadin has joined #openstack-nova | 11:49 | |
*** alexchadin has quit IRC | 11:52 | |
*** salv-orlando has joined #openstack-nova | 11:53 | |
*** alexchadin has joined #openstack-nova | 11:53 | |
*** itlinux has quit IRC | 11:55 | |
*** alexchadin has quit IRC | 11:56 | |
*** salv-orlando has quit IRC | 11:57 | |
*** alexchadin has joined #openstack-nova | 11:58 | |
*** owalsh is now known as owalsh_afk | 12:01 | |
*** liverpooler has quit IRC | 12:03 | |
*** alexchadin has quit IRC | 12:05 | |
*** alexchadin has joined #openstack-nova | 12:06 | |
*** threestrands has quit IRC | 12:08 | |
openstackgerrit | Mark Goddard proposed openstack/nova master: Update docstring for get_traits virt driver method https://review.openstack.org/539505 | 12:08 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Add resource_class to fields in ironic node cache https://review.openstack.org/539506 | 12:08 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Remove unused method _parse_node_instance_info https://review.openstack.org/539507 | 12:08 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Include only required fields in ironic node cache https://review.openstack.org/539508 | 12:08 |
openstackgerrit | Mark Goddard proposed openstack/nova master: Request only instance_uuid in ironic node list https://review.openstack.org/539509 | 12:08 |
*** dave-mccowan has joined #openstack-nova | 12:08 | |
*** alexchadin has quit IRC | 12:09 | |
*** janki has quit IRC | 12:10 | |
*** alexchadin has joined #openstack-nova | 12:10 | |
*** tetsuro has joined #openstack-nova | 12:11 | |
*** takedakn has joined #openstack-nova | 12:11 | |
*** hemna_ has joined #openstack-nova | 12:12 | |
*** markvoelker has quit IRC | 12:12 | |
*** suresh12 has quit IRC | 12:14 | |
*** tetsuro has left #openstack-nova | 12:15 | |
*** suresh12 has joined #openstack-nova | 12:16 | |
*** tiendc has quit IRC | 12:17 | |
*** lajoskatona has quit IRC | 12:20 | |
*** suresh12 has quit IRC | 12:20 | |
*** yamamoto has joined #openstack-nova | 12:22 | |
*** yamamoto has quit IRC | 12:22 | |
*** yamamoto has joined #openstack-nova | 12:23 | |
*** suresh12 has joined #openstack-nova | 12:29 | |
*** bhujay has joined #openstack-nova | 12:32 | |
*** chyka has joined #openstack-nova | 12:35 | |
*** lajoskatona has joined #openstack-nova | 12:37 | |
openstackgerrit | Merged openstack/nova master: SchedulerReportClient.set_aggregates_for_provider https://review.openstack.org/533808 | 12:37 |
*** cdent has joined #openstack-nova | 12:39 | |
*** chyka has quit IRC | 12:39 | |
*** alexchadin has quit IRC | 12:41 | |
*** alexchadin has joined #openstack-nova | 12:42 | |
*** sauloaugusto has joined #openstack-nova | 12:44 | |
*** suresh12 has quit IRC | 12:45 | |
sauloaugusto | Hi , How can I deploy on openstack-nova for a error in database ? | 12:45 |
*** jpena is now known as jpena|lunch | 12:49 | |
*** suresh12 has joined #openstack-nova | 12:50 | |
openstackgerrit | Merged openstack/nova stable/ocata: Handle exception on adding secgroup https://review.openstack.org/515421 | 12:51 |
openstackgerrit | Merged openstack/nova stable/pike: Don't persist could-be-stale InstanceGroup fields in RequestSpec https://review.openstack.org/528225 | 12:51 |
openstackgerrit | Merged openstack/nova stable/ocata: Don't persist could-be-stale InstanceGroup fields in RequestSpec https://review.openstack.org/528226 | 12:51 |
*** rcernin has quit IRC | 12:58 | |
*** takedakn has quit IRC | 12:59 | |
openstackgerrit | Lajos Katona proposed openstack/nova master: WIP: Add nested resources to server moving tests https://review.openstack.org/527728 | 13:02 |
openstackgerrit | Chris Dent proposed openstack/nova master: Remove microversion fallback code from report client https://review.openstack.org/528794 | 13:03 |
openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | 13:07 |
*** markvoelker has joined #openstack-nova | 13:09 | |
*** hemna_ has quit IRC | 13:13 | |
*** Tom-Tom has joined #openstack-nova | 13:16 | |
*** Eran_Kuris has joined #openstack-nova | 13:18 | |
*** hemna_ has joined #openstack-nova | 13:20 | |
*** edmondsw has joined #openstack-nova | 13:22 | |
*** mvenesio has joined #openstack-nova | 13:23 | |
*** sahid has quit IRC | 13:25 | |
*** Eran_Kuris has quit IRC | 13:26 | |
*** Eran_Kuris has joined #openstack-nova | 13:26 | |
*** liverpooler has joined #openstack-nova | 13:27 | |
*** janki has joined #openstack-nova | 13:28 | |
openstackgerrit | Merged openstack/nova stable/pike: Bumping functional test job timeouts https://review.openstack.org/539319 | 13:30 |
openstackgerrit | Merged openstack/nova master: Don't launch guestfs in a thread pool if guestfs.debug is enabled https://review.openstack.org/526748 | 13:30 |
openstackgerrit | Merged openstack/nova master: Don't log a warning for InstanceNotFound in detach_interface https://review.openstack.org/530969 | 13:30 |
openstackgerrit | Merged openstack/nova stable/ocata: Make sure that functional test triggered on sample changes https://review.openstack.org/536936 | 13:31 |
*** ralonsoh_ has joined #openstack-nova | 13:31 | |
*** mvenesio has quit IRC | 13:34 | |
*** mvenesio has joined #openstack-nova | 13:34 | |
*** ralonsoh has quit IRC | 13:35 | |
*** markvoelker has quit IRC | 13:37 | |
*** alex_xu has quit IRC | 13:37 | |
*** markvoelker has joined #openstack-nova | 13:37 | |
*** sahid has joined #openstack-nova | 13:39 | |
*** alex_xu has joined #openstack-nova | 13:39 | |
*** sridharg has quit IRC | 13:41 | |
openstackgerrit | Merged openstack/nova stable/ocata: Bumping functional test job timeouts https://review.openstack.org/539320 | 13:41 |
*** alexchadin has quit IRC | 13:41 | |
openstackgerrit | Dan Smith proposed openstack/nova master: Pass limit to /allocation_requests https://review.openstack.org/531517 | 13:42 |
*** salv-orlando has joined #openstack-nova | 13:42 | |
*** blkart_ has quit IRC | 13:45 | |
*** blkart_ has joined #openstack-nova | 13:45 | |
*** yangyapeng has quit IRC | 13:45 | |
*** pchavva has joined #openstack-nova | 13:45 | |
*** tbachman has quit IRC | 13:46 | |
*** gongysh has joined #openstack-nova | 13:49 | |
*** yikun has quit IRC | 13:50 | |
*** yikun has joined #openstack-nova | 13:51 | |
*** jpena|lunch is now known as jpena | 13:51 | |
*** sridharg has joined #openstack-nova | 13:55 | |
*** ralonsoh__ has joined #openstack-nova | 13:57 | |
zigo | I got issue with Pike's console-log: | 14:01 |
zigo | # nova console-log 92847293-3b4d-44cc-8cdd-6cb57e23b0cf | 14:01 |
zigo | ERROR (UnicodeEncodeError): 'ascii' codec can't encode characters in position 22096-22098: ordinal not in range(128) | 14:01 |
zigo | WTF ? :) | 14:01 |
zigo | bauzas: ^ | 14:01 |
*** ralonsoh_ has quit IRC | 14:01 | |
*** itlinux has joined #openstack-nova | 14:02 | |
*** sinese has joined #openstack-nova | 14:02 | |
*** yamamoto has quit IRC | 14:04 | |
*** jmlowe has joined #openstack-nova | 14:04 | |
efried | zigo: Is there a stack trace? | 14:04 |
zigo | edleafe: Let me check. | 14:04 |
*** pcaruana has quit IRC | 14:05 | |
zigo | edleafe: No stack trace in the logs. | 14:06 |
*** yamamoto has joined #openstack-nova | 14:06 | |
*** mriedem has joined #openstack-nova | 14:06 | |
*** andreas_s has quit IRC | 14:07 | |
lyarwood | zigo: can you run the nova command again with --debug and pastebin the output? | 14:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Don't launch guestfs in a thread pool if guestfs.debug is enabled https://review.openstack.org/539541 | 14:07 |
openstackgerrit | Merged openstack/nova master: Fix the order of target host checks https://review.openstack.org/526225 | 14:07 |
zigo | lyarwood: http://paste.openstack.org/show/658151/ | 14:08 |
openstackgerrit | Merged openstack/nova master: Fix missing 'if_notifications_enabled' decorator https://review.openstack.org/537745 | 14:08 |
jroll | zigo: definitely a client issue, py2 or py3? | 14:09 |
*** yangyapeng has joined #openstack-nova | 14:09 | |
zigo | jroll: py2 | 14:09 |
zigo | I got the same issue with openstackclient | 14:09 |
jroll | probably just need a .decode('utf8') or something there | 14:10 |
zigo | Note that this is Debian Unstable ... | 14:10 |
zigo | Because I can ... (tm) | 14:10 |
zigo | :) | 14:10 |
zigo | So, something bleeding edge may be the cause. | 14:10 |
zigo | To be fixed never the less. | 14:10 |
jroll | regardless, it's a unicode handling issue in the client, not a library issue | 14:11 |
lyarwood | yup, looks valid, can you create a bug? | 14:11 |
*** yamamoto has quit IRC | 14:11 | |
bauzas | zigo: strange thing | 14:11 |
zigo | same stuff with openstackclient: http://paste.openstack.org/show/658154/ | 14:11 |
zigo | Will do. | 14:12 |
jaypipes | efried: hey, sorry, was afk yesterday evening... you were asking me something about PUT vs DELETE? | 14:12 |
bauzas | zigo: any trace we could look at ? | 14:13 |
bauzas | looks a novaclient issue to me | 14:13 |
zigo | bauzas: Yeah, just pasted 2 of them. | 14:13 |
bauzas | since openstackclient uses novaclient, I guess it's from here | 14:13 |
*** tbachman_ has joined #openstack-nova | 14:13 | |
efried | jaypipes: Yeah, basically is there any reason to prefer a {DELETE <URI> => 204 no content} API over its corresponding {PUT <URI> => 200 <payload>} | 14:13 |
zigo | jaypipes: Good hey mate ! | 14:13 |
efried | jaypipes: Specifically for RP inventory, traits, etc. | 14:15 |
bauzas | zigo: python 2 or 3 ? | 14:15 |
openstackgerrit | Merged openstack/nova master: Add get_traits() method to ComputeDriver https://review.openstack.org/532290 | 14:15 |
openstackgerrit | Merged openstack/nova master: libvirt: test to make sure volume_use_multipath is properly used https://review.openstack.org/532270 | 14:15 |
*** READ10 has joined #openstack-nova | 14:16 | |
openstackgerrit | Merged openstack/nova master: libvirt: add tests to check multipath in iscsi/fc volume connectors https://review.openstack.org/532272 | 14:16 |
*** suresh12 has quit IRC | 14:16 | |
*** amoralej is now known as amoralej|lunch | 14:18 | |
zigo | bauzas: py2 | 14:18 |
ameeda | hello, I am try to find new bugs to resolve, I found this bug review https://review.openstack.org/#/c/212908/ . I think if I create new table with unique constraints then copy the data from old table to new one , so we clear the dirty data. | 14:20 |
*** pcaruana has joined #openstack-nova | 14:21 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: [dnm] Make sure that we have USB Host controller for tablet https://review.openstack.org/538003 | 14:23 |
*** hrw has joined #openstack-nova | 14:23 | |
hrw | morning | 14:24 |
mriedem | ameeda: nova hasn't used quota usages since pike | 14:25 |
mriedem | ameeda: https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/cells-count-resources-to-check-quota-in-api.html | 14:25 |
hrw | mriedem: can you take a look at https://review.openstack.org/#/c/538003/ patch and tell is it acceptable? | 14:25 |
mriedem | i marked the bug as won't fix | 14:25 |
ameeda | mriedem: Thank you! | 14:26 |
mriedem | hrw: should probably have sahid look at that, he worked on the pointer model stuff in the libvirt driver | 14:26 |
ameeda | mriedem: can you please recheck this https://review.openstack.org/#/c/528385/ | 14:26 |
hrw | mriedem: will add him, thanks | 14:26 |
*** links has quit IRC | 14:27 | |
*** ccamacho has joined #openstack-nova | 14:27 | |
mriedem | ameeda: can you please decouple that patch from the one below it in the series? | 14:27 |
mriedem | because melwitt's patch https://review.openstack.org/#/c/340614/ is already dealing with the api change (the first patch in your series) | 14:28 |
ameeda | how can I do that ? | 14:29 |
ccamacho | hey guys! quick question, Im working with the tripleo upgrades squad and Im trying to analyze the Nova database status prior an upgrade, mostly to run cleanup operation before running an upgrade in nova services. | 14:29 |
mriedem | put them in separate branches | 14:29 |
ccamacho | do you know briefly where can I find information about it? | 14:29 |
openstackgerrit | Matthew Edmonds proposed openstack/nova master: remove unnecessary conf imports https://review.openstack.org/539314 | 14:30 |
mriedem | ccamacho: find information about what specifically? | 14:30 |
*** lucasagomes is now known as lucas-hungry | 14:30 | |
mriedem | ccamacho: there are a few nova dbs | 14:30 |
*** esberglu has joined #openstack-nova | 14:30 | |
mriedem | nova_api, nova_cell0, nova_cell1 (or just "nova") | 14:30 |
*** andreas_s has joined #openstack-nova | 14:31 | |
ameeda | mriedem: I should remove this from my branch https://review.openstack.org/#/c/528069 ? or create new branch for this https://review.openstack.org/#/c/528385/ and resubmit the review with new change id ? | 14:31 |
ccamacho | mriedan hi, basically about what to check to clean the databases | 14:31 |
*** andreas_s has quit IRC | 14:31 | |
mriedem | ccamacho: like how to archive anything that's already in it but deleted? | 14:31 |
mriedem | nova-manage db archive_deleted_rows | 14:31 |
mriedem | will move soft deleted records into the shadow tables | 14:31 |
*** mdnadeem has quit IRC | 14:32 | |
mriedem | soft deleted in this case means records where the deleted column != 0 | 14:32 |
*** andreas_s has joined #openstack-nova | 14:32 | |
mriedem | we do'nt have a straight up db purge command | 14:32 |
openstackgerrit | Merged openstack/nova master: trivial: use cn instead of rp https://review.openstack.org/529786 | 14:32 |
openstackgerrit | Merged openstack/nova master: Remove the inherits parameter for the Resource object https://review.openstack.org/529218 | 14:32 |
mriedem | ccamacho: https://docs.openstack.org/nova/latest/cli/nova-manage.html#nova-database | 14:32 |
ccamacho | mrieden oki but that is the only cmd available to do it in a more or less automated way | 14:32 |
*** moshele has quit IRC | 14:33 | |
ccamacho | mrieden thanks for the link | 14:33 |
ccamacho | mrieden are the shadow tables there for ever? | 14:33 |
mriedem | there has been a spec and code up before for a command to do similar to archive_deleted_rows but actually hard delete the records rather than move them | 14:33 |
mriedem | ccamacho: yeah | 14:33 |
mriedem | so there is still bloat in the db for deleted stuff | 14:33 |
mriedem | https://blueprints.launchpad.net/nova/+spec/purge-deleted-instances-cmd | 14:34 |
mriedem | https://blueprints.launchpad.net/nova/+spec/purge-deleted-instances-cmd | 14:35 |
mriedem | oops | 14:35 |
mriedem | this is the spec https://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved/purge-deleted-instances-cmd.html | 14:35 |
mriedem | and a poc from someone at red hat https://review.openstack.org/#/c/330791/ | 14:35 |
ccamacho | mrieden thanks, the idea is to write +- a procedure to verify and clean the DBs before the upgrade and be sure they are cleaned.. hopefully we can try to implement it after | 14:36 |
ccamacho | thanks man | 14:36 |
ameeda | mriedem: I should remove this from my branch https://review.openstack.org/#/c/528069 ? or create new branch for this https://review.openstack.org/#/c/528385/ and resubmit the review with new change id ? | 14:36 |
mriedem | ameeda: i think you should abandon https://review.openstack.org/#/c/528069 | 14:36 |
mriedem | ameeda: to do that locally, rebase your series and drop that change from the local branch, | 14:37 |
mriedem | git rebase -i master | 14:37 |
mriedem | <remove that commit> | 14:37 |
mriedem | git review | 14:37 |
ameeda | Ok let me check | 14:37 |
ameeda | Thanks | 14:37 |
mriedem | ccamacho: the man page doesn't list the option, but nova-manage db archive_deleted_rows [--max_rows <number>] [--verbose] has an option for running until complete | 14:38 |
*** yamamoto has joined #openstack-nova | 14:38 | |
mriedem | https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L494 | 14:38 |
ccamacho | mrieden ack thanks! | 14:39 |
efried | jaypipes: I opened some bugs on the subject. https://bugs.launchpad.net/nova/+bug/1746075 https://bugs.launchpad.net/nova/+bug/1746373 https://bugs.launchpad.net/nova/+bug/1746374 | 14:39 |
openstack | Launchpad bug 1746075 in OpenStack Compute (nova) "Report client placement cache consistency is broken" [Undecided,New] | 14:39 |
openstack | Launchpad bug 1746373 in OpenStack Compute (nova) "Placement APIs with missing conflict detection" [Undecided,New] | 14:39 |
openstack | Launchpad bug 1746374 in OpenStack Compute (nova) "Report client _delete_inventory violates generation consistency" [Undecided,New] | 14:39 |
efried | At a minimum, that last one needs to be fixed. | 14:39 |
efried | ...whenever we get to a point where there's actually a possibility of concurrency. | 14:40 |
mriedem | ameeda: it's all yours https://bugs.launchpad.net/nova/+bug/1746531 | 14:40 |
openstack | Launchpad bug 1746531 in OpenStack Compute (nova) "nova-manage db archive_deleted_rows man page does not mention --until-complete option" [Medium,Confirmed] - Assigned to Ameed Ashour (ameeda) | 14:40 |
jaypipes | efried: well, DELETE <uri> and PUT <uri> have different semantics, no? | 14:40 |
jaypipes | efried: I mean, PUT <uri> can do more than DELETE some object in a collection... | 14:40 |
jaypipes | efried: you are getting gibi-like bug-happy. | 14:41 |
*** tbtest has joined #openstack-nova | 14:41 | |
efried | jaypipes: Correct. I'm saying PUT encompasses what DELETE does. But in these particular cases, DELETE doesn't actually provide us with enough functionality to allow us to ensure consistency. | 14:41 |
jaypipes | efried: how impactful are those bugs? do they need to be addressed for queens, in your opinion? | 14:41 |
*** eharney has joined #openstack-nova | 14:42 | |
efried | jaypipes: Probably not, since we have that big ol' lock preventing concurrency in the first place. | 14:42 |
jaypipes | efried: ack. can you add this to the list of discussion topics for Dublin? | 14:42 |
ameeda | mriedem: Thank you very much !! | 14:44 |
*** liverpooler has quit IRC | 14:44 | |
*** yamahata has joined #openstack-nova | 14:45 | |
openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | 14:45 |
*** andreas_s has quit IRC | 14:46 | |
ameeda | mriedem: patch uploaded https://review.openstack.org/#/c/528385/ | 14:46 |
efried | jaypipes: https://etherpad.openstack.org/p/nova-ptg-rocky L50-59 | 14:46 |
jaypipes | efried: danke | 14:47 |
efried | jaypipes: To put possibilities in your head, we could have a DELETE that accepts a payload and returns a payload. | 14:47 |
*** liverpooler has joined #openstack-nova | 14:47 | |
*** yamamoto has quit IRC | 14:47 | |
efried | or just use PUT :) | 14:47 |
*** yamamoto has joined #openstack-nova | 14:48 | |
jaypipes | cdent might shit a brick, though. | 14:48 |
*** yamamoto has quit IRC | 14:48 | |
*** pcaruana has quit IRC | 14:48 | |
cdent | i've laid so many bricks in the past few days I'm not sure I have any left | 14:48 |
mriedem | if another core can look at this, i think we should get it in before rc1 https://review.openstack.org/#/c/522112/ beause backports with new config options are generally gross | 14:48 |
*** yamamoto has joined #openstack-nova | 14:49 | |
jaypipes | cdent: poor guy. still under the weather? | 14:49 |
*** liverpooler has quit IRC | 14:49 | |
jaypipes | mriedem: on it. | 14:49 |
*** Eran_Kuris has quit IRC | 14:49 | |
mriedem | ^ adds the ability for nova to do cinder api stuff, like neutron, without a user token, for things like periodic cleanup tasks | 14:49 |
*** liverpooler has joined #openstack-nova | 14:49 | |
jaypipes | mriedem: reading the bugs now... | 14:49 |
openstackgerrit | Sen Yang proposed openstack/python-novaclient master: Implement hypervisor hostname exact pattern match https://review.openstack.org/520187 | 14:50 |
cdent | jaypipes: I _am_ still under the weather, but the bricks I was talking about in this case is the number of conversations in the past few days about generations and provider tree and related stuff that are still up in the air | 14:50 |
jaypipes | cdent: heh, ok :) | 14:50 |
ameeda | mriedem: about assigned bug https://bugs.launchpad.net/nova/+bug/1746531 where I should add the description and what should I write ? | 14:50 |
openstack | Launchpad bug 1746531 in OpenStack Compute (nova) pike "nova-manage db archive_deleted_rows man page does not mention --until-complete option" [Medium,Confirmed] | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient._delete_provider https://review.openstack.org/535463 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: ProviderTree.get_provider_uuids: Top-down ordering https://review.openstack.org/536624 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set https://review.openstack.org/536625 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: New-style _set_inventory_for_provider https://review.openstack.org/537648 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 14:50 |
jaypipes | cdent: I seem to have gracefully avoided all of those conversations... | 14:50 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make generation optional in ProviderTree https://review.openstack.org/539324 | 14:50 |
ameeda | is still gate broken ? https://review.openstack.org/#/c/526900/ | 14:50 |
cdent | jaypipes: they've been interesting and I think for the most part useful with regard to longer term considerations | 14:51 |
efried | gibi, jaypipes, mriedem: easy manual rebases on that series | 14:51 |
gibi | efried: looking... | 14:51 |
*** tbachman_ has quit IRC | 14:51 | |
cdent | jaypipes but trying to parse them while still ill is ow | 14:51 |
mriedem | melwitt: i think the functional test failures in your patch https://review.openstack.org/#/c/340614/ are real | 14:51 |
* efried is still waiting for travel approval | 14:52 | |
jaypipes | cdent: ack on that... | 14:52 |
jaypipes | mriedem: hmm, delete_on_termination=True && boot_from_volume=True don't seem to be a good mix... | 14:53 |
jaypipes | but whatevs, I will try to keep an open mind.' | 14:53 |
* edleafe is still waiting, but has already booked flights, hotel, etc | 14:54 | |
*** burt has joined #openstack-nova | 14:54 | |
mriedem | jaypipes: that's super old behavior | 14:54 |
*** liverpooler has quit IRC | 14:54 | |
mriedem | delete the backing volume once i delete the instance | 14:54 |
bauzas | mriedem: on https://review.openstack.org/#/c/522112/ | 14:54 |
*** liverpooler has joined #openstack-nova | 14:55 | |
ameeda | mriedem: should I follow https://docs.openstack.org/doc-contrib-guide/ ? | 14:56 |
*** tbtest has left #openstack-nova | 14:56 | |
mriedem | ameeda: no, the nova-manage man pages are in the nova tree | 14:56 |
mriedem | under doc/source/cli | 14:56 |
mriedem | it's just a restructured text file | 14:57 |
ameeda | great , what I should write there ? | 14:58 |
mriedem | ameeda: dude | 14:58 |
mriedem | i'm not going to write the patch fo you | 14:58 |
mriedem | *for | 14:58 |
gibi | jaypipes, mriedem: the first patch in efried's series needs a second core https://review.openstack.org/#/c/521098 the rest is +Wd | 14:58 |
ameeda | mriedem: sorry :$ | 14:58 |
mriedem | see how existing entries document CLI options, take a stab at doing similar for the missing option, and then post it for review and get feedback | 14:58 |
ameeda | Thank you !! | 14:58 |
*** armax has joined #openstack-nova | 14:59 | |
mriedem | gibi: if it was a rebase you can just fast approve | 14:59 |
*** awaugama has joined #openstack-nova | 14:59 | |
gibi | mriedem: it was a manual rebase, but yeah, I can fast approve it, sure. | 14:59 |
mriedem | we need some cores to look at this too https://review.openstack.org/#/c/537351/ | 15:00 |
mriedem | fixes nits in alex's traits series | 15:00 |
bauzas | mriedem: are we considering https://review.openstack.org/#/c/537351/4 not impact by FF ? | 15:01 |
bauzas | impacted* | 15:01 |
*** amoralej|lunch is now known as amoralej | 15:01 | |
mriedem | bauzas: it's docs and nit cleanups | 15:01 |
bauzas | acceptable | 15:01 |
gibi | mriedem: fyi, this is can be merged now: https://review.openstack.org/#/c/533608 as the ocata backport has been merged as well | 15:04 |
mriedem | gibi: yeah i thought that was already done | 15:05 |
efried | Thanks gibi! | 15:06 |
*** crushil has joined #openstack-nova | 15:07 | |
*** claudiub|3 has joined #openstack-nova | 15:10 | |
*** alex_xu has quit IRC | 15:11 | |
*** alex_xu has joined #openstack-nova | 15:13 | |
*** pcaruana has joined #openstack-nova | 15:14 | |
*** itlinux has quit IRC | 15:18 | |
*** ispp has quit IRC | 15:19 | |
gibi | ralonsoh__: hi! Do you plan to propose https://review.openstack.org/#/c/502306/14/specs/queens/approved/bandwidth-resource-provider.rst to rocky? | 15:21 |
*** david-lyle has quit IRC | 15:24 | |
*** dklyle has joined #openstack-nova | 15:24 | |
*** slaweq_ has quit IRC | 15:25 | |
*** mlavalle has joined #openstack-nova | 15:25 | |
tssurya | melwitt : I just wanted to confirm something, since quota calculation uses scatter_gather_all_cells, the whole process is a parallel process right when it comes to querying each cell DB ? | 15:26 |
dansmith | tssurya: yeah | 15:26 |
tssurya | melwitt : so we don't have to worry much about the performance in Pike with regards to this aspect | 15:26 |
tssurya | dansmith : thanks | 15:26 |
*** Guest87240 is now known as mgagne | 15:27 | |
*** mgagne has joined #openstack-nova | 15:27 | |
tssurya | dansmith : also regarding the status of our solution for calculating quotas when a cell is down, we realized that in Pike no vm creation would take place at all if any of the cell is down since it would raise exception at this point : https://github.com/openstack/nova/blob/cb1e763df76e21b5382872c89dd169ecb152c420/nova/api/openstack/compute/servers.py#L494 | 15:29 |
dansmith | bauzas: can you please look at this? https://review.openstack.org/#/c/532924/ | 15:29 |
*** eharney has quit IRC | 15:29 | |
dansmith | tssurya: ah yeah, we need to fix that | 15:30 |
*** lucas-hungry is now known as lucasagomes | 15:30 | |
dansmith | tssurya: I think we can pretty much remove that check now since the version we're checking for should be out of the support window | 15:31 |
tssurya | dansmith : so I will submit a POC for this and nova list, but we can discuss more of this in the ptg after we find a solution to deal with differentiating deleted instances from living ones | 15:31 |
dansmith | in the future when we need to do that sort of thing we'll need to decide what the plan is if a cell doesn't come back with that answer | 15:31 |
dansmith | tssurya: I really don't think we're going to find such a solution without replicating more data up top, but.. yeah, sounds good | 15:32 |
tssurya | because even for the quotas solution (which was to allow vm creation if a project doesn't have any instances in the cell that is down) it would change to not allowing vm creation if there are any instance_mappings in that cell :( | 15:33 |
dansmith | yeah | 15:33 |
dansmith | that might not be a problem depending on how you distributed people (i.e. keep tenants to a subset of cells), but yeah fair enough | 15:34 |
ralonsoh__ | gibi, sean-k-mooney: I no longer work in OpenStack for the moment. Please, ask sean-k-mooney about the plans to propose it for the next release cycle | 15:34 |
tssurya | dansmith : how I found this - # TODO(melwitt): Counting across cells for instances means we will miss counting resources if a cell is down. In the future, we should query placement for cores/ram and InstanceMappings for instances (once we are deleting InstanceMappings when we delete instances). | 15:34 |
*** tidwellr has joined #openstack-nova | 15:34 | |
tssurya | however* | 15:34 |
*** links has joined #openstack-nova | 15:34 | |
tssurya | so hopes up for the last part "once we are deleting InstanceMappings when we delete instances" | 15:35 |
*** psachin has quit IRC | 15:35 | |
dansmith | tssurya: yeah so we could try to leverage placement here in some way, but it would be a rather inefficient merge of "does placement know about any of these instance mappings" | 15:35 |
sean-k-mooney | ralonsoh__: propose which? | 15:35 |
ralonsoh__ | sean-k-mooney, gibi: https://review.openstack.org/#/c/502306/14/specs/queens/approved/bandwidth-resource-provider.rst | 15:35 |
dansmith | tssurya: we can't delete instancemappings when we delete instances | 15:35 |
*** ispp has joined #openstack-nova | 15:36 | |
*** esberglu_ has joined #openstack-nova | 15:36 | |
tssurya | dansmith: yea probably, but is there a way we could included a status for the mappings ? | 15:36 |
*** salv-orlando has quit IRC | 15:37 | |
dansmith | tssurya: that's what I meant about "replicating more data" | 15:37 |
dansmith | we said we weren't going to do that, so we'd have to discuss whether or not we're going to violate that design point or not | 15:37 |
tssurya | dansmith: hmm okay, | 15:37 |
dansmith | tssurya: maybe we could do something like delete the reqspec (if we don't already) when we delete an instance, and then not include instances with no requestspec that do have a mapping? | 15:38 |
*** yamamoto has quit IRC | 15:38 | |
dansmith | tssurya: I think bauzas was going to clean that up (delete reqspec on delete) but not sure if he ever did | 15:38 |
tssurya | dansmith : we don't delete request_spec as of now, | 15:38 |
tssurya | but yes that would also work | 15:38 |
gibi | ralonsoh__: thanks for the info | 15:38 |
dansmith | that would be better IMHO | 15:38 |
tssurya | if we could delete specs when we delete the instances | 15:39 |
gibi | sean-k-mooney: do you plan to re-propose https://review.openstack.org/#/c/502306/14/specs/queens/approved/bandwidth-resource-provider.rst ? | 15:39 |
tssurya | dansmith : no he didn't because we did something similar to instance_mappings clean up during archival | 15:39 |
tssurya | so now we purge mappings and specs in the same way | 15:40 |
dansmith | yeah, okay, well, I think it'd make sense to do it that way, but we can discuss at the PTG | 15:40 |
tssurya | dansmith : yes sounds good :) | 15:40 |
*** esberglu has quit IRC | 15:40 | |
*** salv-orlando has joined #openstack-nova | 15:41 | |
cdent | bauzas: you happy to put your +W back on https://review.openstack.org/#/c/519462/ now that gate is a bit happier? | 15:42 |
bauzas | cdent: it requires a manual rebase | 15:43 |
bauzas | there is a merge conflict | 15:43 |
* cdent will do that | 15:43 | |
*** felipemonteiro__ has joined #openstack-nova | 15:44 | |
cfriesen | johnthetubaguy: you around? | 15:44 |
*** felipemonteiro_ has joined #openstack-nova | 15:45 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Log options at debug when starting API services under wsgi https://review.openstack.org/519462 | 15:46 |
cdent | bauzas: ^ | 15:46 |
bauzas | cdent: fast-approved | 15:47 |
cdent | thanks | 15:47 |
bauzas | thanks, that's not that I was lazy, but I have other things on the gas | 15:48 |
*** yamamoto has joined #openstack-nova | 15:48 | |
mriedem | dansmith: tssurya: https://review.openstack.org/#/c/391060/ | 15:48 |
*** esberglu_ is now known as esberglu | 15:48 | |
bauzas | dansmith: yup, I did | 15:48 |
bauzas | but it requires some cleanup | 15:49 |
dansmith | bauzas: did what? | 15:49 |
mriedem | that patch i just linked | 15:49 |
*** felipemonteiro__ has quit IRC | 15:50 | |
dansmith | bauzas: I've been pinging you for two weeks to look at this, can you please look at it? https://review.openstack.org/#/c/532924/ | 15:50 |
bauzas | yup, that | 15:50 |
bauzas | dansmith: on it | 15:50 |
bauzas | dansmith: it was on an open tab | 15:50 |
*** bhujay has quit IRC | 15:50 | |
dansmith | bauzas: okay well, never heard a peep so I didn't know | 15:51 |
bauzas | my bad | 15:51 |
tssurya | mriedem : thanks, so that means we do not agree to deleting the specs when deleting the instances right ? | 15:53 |
*** yamamoto has quit IRC | 15:53 | |
hrw | https://imgur.com/a/3b22r - graphical console on arm64 out of box (with https://review.openstack.org/#/c/538003/ applied) mriedem | 15:53 |
*** Tom-Tom has quit IRC | 15:54 | |
*** Tom-Tom has joined #openstack-nova | 15:55 | |
mriedem | tssurya: well, i don't agree with the assertion that if the instance fails to be deleted, losing the request spec is ok | 15:55 |
mriedem | because we have fallback code all over the place from the newton transition to reqspecs for old instances | 15:55 |
mriedem | as i said in that patch, a lot of that fallback code is best effort but shouldn't really be relied upon | 15:56 |
bauzas | maciejjozefczyk: dansmith: there could be a flip logic where some cloud could have computes nova.confs with allocation ratios equal to 0.0 | 15:56 |
bauzas | maciejjozefczyk: dansmith: in that case, when upgrading to Queens, I guess we should still make sure to correctly normalize the ratios the other way, nope ? | 15:56 |
*** slaweq has joined #openstack-nova | 15:56 | |
maciejjozefczyk | bauzas: hey | 15:57 |
tssurya | mriedem : right, makes sense | 15:57 |
melwitt | mriedem: ack | 15:58 |
*** Tom-Tom has quit IRC | 15:59 | |
*** eharney has joined #openstack-nova | 16:00 | |
*** jose-phi_ has quit IRC | 16:01 | |
mriedem | hrw: left some comments | 16:03 |
maciejjozefczyk | bauzas: I dont know, Its said that in Newton it should be moved to default values, and its Queens now. | 16:03 |
hrw | mriedem: thx | 16:03 |
bauzas | maciejjozefczyk: yup, I'm just thinking about flipping the problem | 16:03 |
bauzas | maciejjozefczyk: say we have a pike compute, and a queens cloud | 16:04 |
bauzas | maciejjozefczyk: the old pike compute would store in its DB the unnormalized ratios, ie. 0.0, right? | 16:04 |
hrw | mriedem: will reply | 16:04 |
maciejjozefczyk | bauzas: right | 16:05 |
bauzas | maciejjozefczyk: in that case, what works now that we normalize those ratios by the object layer | 16:05 |
bauzas | maciejjozefczyk: if we cut that logic and just takes what we get from the DB, then we need to be careful about those pike nodes | 16:05 |
bauzas | maciejjozefczyk: I'm trying to evaluate hard https://review.openstack.org/#/c/532924/6/nova/objects/compute_node.py@185 and its impact with a pike node | 16:06 |
*** crushil has quit IRC | 16:06 | |
maciejjozefczyk | bauzas: you're right | 16:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix nits in support traits changes https://review.openstack.org/537351 | 16:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Mention required traits in the flavors user docs https://review.openstack.org/539300 | 16:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional tests for traits-based scheduling https://review.openstack.org/539310 | 16:07 |
mriedem | efried: fixed that comment ^ | 16:07 |
mriedem | thanks | 16:07 |
mriedem | efried: also, your two irc nicks in here is driving me nuts | 16:07 |
cfriesen | design question...now that we have objects.Service.get_minimum_version(), does the RPC version really serve any purpose anymore? | 16:07 |
efried | mriedem: sorry, was keeping the old one around for logs. Guess there's no reason to keep it logged in, tho. | 16:08 |
*** efried_hexchat has quit IRC | 16:08 | |
bauzas | maciejjozefczyk: wait, I'm not saying we have a problem yet | 16:08 |
*** tovin07 has quit IRC | 16:09 | |
*** hoangcx has quit IRC | 16:09 | |
*** belmoreira has quit IRC | 16:10 | |
*** tovin07 has joined #openstack-nova | 16:10 | |
*** hoangcx has joined #openstack-nova | 16:10 | |
maciejjozefczyk | bauzas: In this particular case when pike compute has in db 0.0 _from_db_object() method will change 0.0 to default value from oslo.config | 16:12 |
maciejjozefczyk | L185 so the effect would be the same | 16:12 |
bauzas | maciejjozefczyk: right, I just left a comment | 16:13 |
bauzas | maciejjozefczyk: if people started to touch their nova.conf, whatever it's Pike or Queens, we take that conf value | 16:14 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: Logs tips on PortBindingFailed https://review.openstack.org/539584 | 16:14 |
maciejjozefczyk | bauzas: The only thing for now is the topic on openstack-dev: What about aggregation groups and its metadatas? | 16:14 |
efried | jaypipes, cdent: Heads up, here's a really weird failure that may point to an intermittent placement bug. But I have no idea how it happened, how to reproduce it, etc. | 16:15 |
efried | jaypipes, cdent: http://logs.openstack.org/17/535517/15/check/nova-tox-functional/b841731/testr_results.html.gz | 16:15 |
bauzas | maciejjozefczyk: can you please give me the link ? | 16:15 |
maciejjozefczyk | bauzas: https://bugs.launchpad.net/nova/+bug/1742747 and http://lists.openstack.org/pipermail/openstack-operators/2018-January/014748.html | 16:16 |
openstack | Launchpad bug 1742747 in OpenStack Compute (nova) "RT overrides default allocation_ratios for ram cpu and disk" [Undecided,In progress] - Assigned to Maciej Jozefczyk (maciej.jozefczyk) | 16:16 |
maciejjozefczyk | jaypipes: and mgagne was thing about that use-case | 16:16 |
bauzas | maciejjozefczyk: ah right, can we please punt that topic for now ? | 16:16 |
bauzas | maciejjozefczyk: I'm trying to identify whether your change will work on a rolling-upgrade :) | 16:17 |
maciejjozefczyk | bauzas: yea sure :) | 16:17 |
efried | jaypipes, cdent: If you look at time stamp 2018-01-30 20:31:43,675 you can see that we successfully created the CUSTOM_BANDWIDTH resource class. Then the next log shows creating the inventory that uses it. That also succeeds, which it wouldn't have if the resource class didn't exist. And there's no subsequent removal of that resource class. But the failure claims the resource class didn't come back in GET /resource_cla | 16:17 |
maciejjozefczyk | bauzas: I need to go anyway. | 16:17 |
maciejjozefczyk | bauzas: thanks for checkign it | 16:17 |
*** maciejjozefczyk is now known as maciejjozefczyk_ | 16:17 | |
bauzas | ++ | 16:17 |
jaypipes | efried: this is repeatable?' | 16:18 |
efried | jaypipes: No. I haven't been able to repro it locally, and it also didn't repro in the py35 version of that same test for that same run on that same patch in zuul. | 16:18 |
*** belmoreira has joined #openstack-nova | 16:19 | |
efried | jaypipes: That's what scares me the most | 16:19 |
jaypipes | efried: clowns are what scare me most. | 16:19 |
cdent | puppet clowns | 16:20 |
*** janki has quit IRC | 16:22 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for tablet https://review.openstack.org/538003 | 16:24 |
efried | cdent, jaypipes: So do I just pretend this didn't happen? I can't think of a way to track it down without being able to reproduce it. | 16:24 |
hrw | mriedem: please check | 16:24 |
*** moshele has joined #openstack-nova | 16:24 | |
jaypipes | efried: clowns are indeed slippery like that. | 16:24 |
cdent | efried: if you're in the middle of doing other important stuff I'd say don't let it distract you for now | 16:25 |
jaypipes | efried: I would forget it happened for now. | 16:25 |
*** cjvolzka has joined #openstack-nova | 16:25 | |
jaypipes | cdent++ | 16:25 |
efried | okeydokeythen. | 16:25 |
cdent | I'm looking at the test now to see if anything leaps out | 16:25 |
*** tbachman has joined #openstack-nova | 16:25 | |
*** cjvolzka has quit IRC | 16:25 | |
* efried capers off in oversized shoes | 16:25 | |
jaypipes | efried: you need to rebase that anyway | 16:25 |
efried | jaypipes: Yeah, but I need to wait until the bottom of the series merges now. Otherwise would need re-+Ws on those bottom five, and lose their headway in the gate. | 16:26 |
efried | jaypipes: I have it rebased locally. | 16:26 |
jaypipes | ack | 16:26 |
hrw | mriedem: I hope that new commit message and replies to comments make it simpler to understand | 16:27 |
sean-k-mooney | ralonsoh__: gibi ah ok i have asked one of the other teams at intel to contiue this item but we have not got confirmation they will. we would like to yes. we should know if intel can work on it by the ptg | 16:27 |
*** prometheanfire has left #openstack-nova | 16:28 | |
gibi | sean-k-mooney: thanks for the info | 16:28 |
sean-k-mooney | gibi: if you want to reporpose it then go ahead but it if not we will likely do it in the next week or two. my team however is nolonger resoced to work on it | 16:28 |
*** r-daneel has joined #openstack-nova | 16:29 | |
efried | reporpoise (ftfy). A marine mammal, again. | 16:30 |
gibi | sean-k-mooney: we are currently trying to understand the next steps with this feature. If we reach the point to have something solid before intel repropose then we will propose it | 16:30 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make service all-cells min version helper use scatter-gather https://review.openstack.org/539590 | 16:31 |
dansmith | tssurya: mriedem ^ | 16:31 |
*** munishmehan has joined #openstack-nova | 16:31 | |
dansmith | see if you buy my logic in those comments :D | 16:31 |
sean-k-mooney | gibi: well i think the main step would be to start modeling network backends a placement resouse providers of bandwith. we were intending to have neutron create those RPs but how we model numa will obviosly effect it. | 16:32 |
sean-k-mooney | gibi: the reason for neutron doing it and not nova was so nova does not have know how to discover things like network bandwith for every neutron backend | 16:33 |
mriedem | jaypipes: mdbooth: i'd prefer not to land https://review.openstack.org/#/c/462521/ at this point in queens | 16:33 |
gibi | sean-k-mooney: yeah, that part seems to be clear. The first real roadblock we hit was that which component will allocate from those RPs, nova or neutron | 16:33 |
sean-k-mooney | nova | 16:34 |
jaypipes | mriedem: ack. I'm still +2 on it. but you want to -W it? | 16:34 |
sean-k-mooney | gibi: that said i wanted neutron to pass a request for bandwith as part of the neuton port | 16:34 |
gibi | ralonsoh__: btw, could you please just simply un-abandon (restore?) the spec patch so we can publish some comments there in the meantime? | 16:34 |
mriedem | jaypipes: done | 16:34 |
jaypipes | mriedem: done. | 16:35 |
*** zhaochao has quit IRC | 16:35 | |
jaypipes | lol, jinx | 16:35 |
gibi | sean-k-mooney: I also feel that nova should do the claim based on the request coming from the port from neutron | 16:35 |
gibi | sean-k-mooney: but it seems mriedem has a different view based on the ptg etherpad https://etherpad.openstack.org/p/nova-ptg-rocky L145 | 16:36 |
*** stvnoyes has left #openstack-nova | 16:36 | |
sean-k-mooney | gibi: just looking now | 16:36 |
ralonsoh__ | gibi: sure | 16:36 |
gibi | ralonsoh__: thanks a lot | 16:36 |
sean-k-mooney | gibi: i dont think thats in conflict | 16:37 |
mriedem | i will say that i've evacuated all of that spec from my brain | 16:37 |
mriedem | including it's mish mash of dependencies | 16:37 |
sean-k-mooney | gibi: for the multiple port binding spec we wanted to move the point of getting the port info form neutron to the conductor before calling placement | 16:37 |
gibi | sean-k-mooney: "neutron would update the allocations in Placement rather than nova doing that" this part seems conflicting to me | 16:38 |
*** gongysh has quit IRC | 16:38 | |
gibi | sean-k-mooney: I'm not against moving the port creation to the conductor | 16:38 |
*** ralonsoh has joined #openstack-nova | 16:38 | |
*** sinese has quit IRC | 16:39 | |
sean-k-mooney | gibi: moving the port bind/createion to the condoctor means we can skip a host if binding would fail early instead of after we have set up everything on the destination | 16:39 |
*** pcaruana has quit IRC | 16:39 | |
sean-k-mooney | gibi: this is of benifit most with multicells deployment where we cant retry like we used too | 16:40 |
cdent | efried: nothing leaps out while reading through that test. I'm going to go with the old standby of "eventlet is probably messing with something somewhere" | 16:40 |
efried | cdent: Thanks for looking. You like the test case in general tho? | 16:41 |
cdent | seems legit | 16:41 |
gibi | sean-k-mooney: I might missing something here but for me binding a port and claiming the resources for that port happens independently | 16:41 |
*** ralonsoh__ has quit IRC | 16:41 | |
*** andreas_s has joined #openstack-nova | 16:42 | |
sean-k-mooney | gibi: when you bind a port you set the host id so you have already claimed the resouce at this point so currently we find out if neutron can bind a node very late | 16:42 |
gibi | sean-k-mooney: so this means for me that claiming the port related resources has to happen before the bind | 16:43 |
sean-k-mooney | gibi: the idea was create/get the neutron before placement is called to get extra requiremetn. then go through placement and scheduler steps and select a host. try to bind it and if it fails go to next candiate and when binding all ports succeds then call compute node to boot instance | 16:44 |
sean-k-mooney | gibi: yes claiming has happend before binding today | 16:45 |
*** moshele has quit IRC | 16:45 | |
*** tbachman_ has joined #openstack-nova | 16:45 | |
*** tbachman has quit IRC | 16:46 | |
*** tbachman_ is now known as tbachman | 16:46 | |
gibi | sean-k-mooney: in the idea does the bind happen in the conductor? | 16:46 |
sean-k-mooney | gibi: yes | 16:47 |
gibi | sean-k-mooney: OK that is the piece that I missed so far | 16:47 |
gibi | sean-k-mooney: thanks, I have to restart some thinking based on this information | 16:47 |
*** sinese has joined #openstack-nova | 16:48 | |
sean-k-mooney | but again this is all up for debate. there could be better ways to do it but if we do the port creation and bindign in the conductor before we claim we can eliminate nodes the would fail before ever calling the compute node. | 16:49 |
sean-k-mooney | you could have neutron do the claim in placement as part of the port bind on sucess if you wanted for example. or the condoctor could do it when you claim everything else | 16:50 |
*** tbachman_ has joined #openstack-nova | 16:50 | |
tssurya | dansmith : thank you I will have a look, should we probably do the same thing here as well or add an exception or something? -> https://github.com/openstack/nova/blob/stable/pike/nova/scheduler/host_manager.py#L601 | 16:50 |
*** tbachman has quit IRC | 16:51 | |
*** tbachman_ is now known as tbachman | 16:51 | |
tssurya | dansmith : also do we have a cells meeting today ? not that we have anything from our side (since we are discussing it here) | 16:51 |
dansmith | tssurya: I'm (very) cool with canceling.. mriedem melwitt ? | 16:51 |
mriedem | cancel | 16:51 |
melwitt | +1 | 16:51 |
dansmith | woot | 16:51 |
tssurya | cool | 16:52 |
*** hoangcx has quit IRC | 16:52 | |
*** tovin07 has quit IRC | 16:52 | |
dansmith | tssurya: we should convert that to scatter/gather for performance, and make it not freak out on timeout/fail yeah | 16:52 |
dansmith | tssurya: I can stack that on top of my patch from earlier | 16:52 |
dansmith | tssurya: unless you already have one ready to go | 16:52 |
tssurya | dansmith: yes sounds good | 16:52 |
*** sinese has quit IRC | 16:52 | |
tssurya | thank you | 16:52 |
tssurya | nope I don't have one | 16:52 |
*** moshele has joined #openstack-nova | 16:53 | |
dansmith | okay, give me a bit | 16:53 |
* dansmith declares this a three-cup day | 16:53 | |
gibi | sean-k-mooney: If the neutron claims then there is window of race condition. If nova claims in one step in the conductor then we can eliminate such race | 16:53 |
*** hoangcx has joined #openstack-nova | 16:53 | |
*** tovin07 has joined #openstack-nova | 16:53 | |
*** chyka has joined #openstack-nova | 16:54 | |
gibi | sean-k-mooney: therefore I more like the idea to let nova do the claim based on the requests from the port | 16:55 |
gibi | sean-k-mooney: and I think we agree. :) | 16:55 |
mdbooth | mriedem: ack | 16:55 |
*** slaweq has quit IRC | 16:55 | |
*** andreas_s has quit IRC | 16:56 | |
* hrw -> comments | 16:57 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass limit to /allocation_requests https://review.openstack.org/531517 | 16:58 |
*** felipemonteiro_ has quit IRC | 16:58 | |
*** felipemonteiro_ has joined #openstack-nova | 16:59 | |
*** efried is now known as efried_rollin | 17:02 | |
*** harlowja has joined #openstack-nova | 17:02 | |
stephenfin | bauzas: Could you hit these at some point, please :) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+topic:bug/1736759-stable/pike | 17:03 |
*** yamamoto has joined #openstack-nova | 17:03 | |
*** slaweq has joined #openstack-nova | 17:03 | |
* bauzas chills | 17:03 | |
stephenfin | mriedem: Assuming you're not completely burnt out yet, could you take a look at this backport https://review.openstack.org/#/c/530743/ ? | 17:04 |
mriedem | stephenfin: i see that neither jaypipes or bauzas reviewed the patch on master, | 17:06 |
mriedem | so i think i'd like to see that they are cool with that before we merge all the way back to ocata | 17:07 |
bauzas | dansmith: FWIW, I think I found a possible issue with https://review.openstack.org/#/c/532924/ | 17:07 |
bauzas | dansmith: which would require the object to check the service version | 17:07 |
dansmith | bauzas: I was assuming you were going to -2 that | 17:07 |
bauzas | -2 that change because we're close to RC1 ? | 17:08 |
bauzas | and defer to Rocky? | 17:08 |
bauzas | because I don't disagree with that cleanup | 17:08 |
dansmith | bauzas: no because of the use of the 0.0 as sentinels for the DB or whatever that hack was | 17:08 |
*** belmoreira has quit IRC | 17:08 | |
dansmith | okay, you're saying we're far enough past that that we can do this cleanup? | 17:08 |
bauzas | dansmith: I think mid-term we can remove the sentinels | 17:09 |
dansmith | I really didn't look closely other than to see it seemed to be missing the point of those being 0 | 17:09 |
dansmith | okay | 17:09 |
bauzas | dansmith: but the problem is with an upgrade | 17:09 |
stephenfin | mriedem: I'm not sure I get you? | 17:09 |
mriedem | gibi: if you're still around, can you re-approve https://review.openstack.org/#/c/539300/ and the one after it | 17:09 |
bauzas | dansmith: so we could potentially require to keep a bit of backwards compatibility logic | 17:09 |
stephenfin | Oh, you want more than two pairs of eyes on it? Gotcha | 17:10 |
mriedem | stephenfin: i'm not personally comfortable with disk over commit and allocation ratio stuff, i know jaypipes and bauzas are more knowledgeable about that | 17:10 |
bauzas | dansmith: I'll discuss with maciejjozefczyk_ about the possible solutions | 17:10 |
mriedem | stephenfin: yes | 17:10 |
stephenfin | That's fair. I can bug them (y) | 17:10 |
bauzas | maciejjozefczyk_: when you're up tomorrow, let's discuss and ping me | 17:10 |
bauzas | I'm here | 17:10 |
bauzas | no need to bug me | 17:11 |
bauzas | what's the context ? | 17:11 |
bauzas | btw. if anyone has some fakelibvirt expertise and functional testing for libvirt, raise a hand, please | 17:11 |
bauzas | it will prevent me to spend a couple of hours trying to understand the code | 17:11 |
*** slaweq has quit IRC | 17:11 | |
stephenfin | bauzas: :) I'm looking for eyes on this backport https://review.openstack.org/#/c/530743/ | 17:11 |
mriedem | bauzas: https://review.openstack.org/#/c/538938/ | 17:11 |
mriedem | oops | 17:11 |
stephenfin | The stable/ocata backport too, but baby steps | 17:12 |
sean-k-mooney | gibi: yep that why at least one of the spec is written to assume nova will do the claim. i also have not really looked at them since november so cant rememeber all the deatils. | 17:12 |
openstackgerrit | sahid proposed openstack/nova-specs master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/539605 | 17:12 |
stephenfin | bauzas: I might be able to help | 17:12 |
stephenfin | w/ fakelibvirt, that is. What's up? | 17:12 |
bauzas | stephenfin: my goal is to provide a specific test module for vGPU testing | 17:12 |
*** vivsoni__ has quit IRC | 17:12 | |
*** kwathore__ has joined #openstack-nova | 17:13 | |
bauzas | ie. mocking the virt driver to have mdevs and do a couple of server actions | 17:13 |
*** vivsoni__ has joined #openstack-nova | 17:13 | |
bauzas | like we have for NUMA or SR-IOV testing | 17:13 |
gibi | mriedem: done | 17:13 |
bauzas | stephenfin: but let's punt that discussion to tomorrow, /me looking at your change | 17:13 |
stephenfin | bauzas: Yup, that sounds fair. Have you looked at nova/tests/functional/libvirt/test_pci_sriov_servers.py ? | 17:13 |
bauzas | I did | 17:14 |
stephenfin | Ah, cool | 17:14 |
bauzas | I probably need to only identify the best entrypoints to mock only the pieces of libvirt I want | 17:14 |
*** moshele has quit IRC | 17:14 | |
stephenfin | Yeah, we can discuss tomorrow AM so, but fakelibvirt is basically the hardware-dependent aspects of libvirt mocked out. How those parts are determined, I'm not so sure | 17:15 |
*** gszasz has quit IRC | 17:15 | |
stephenfin | vladikr would be the person to ask tomorrow, assuming he's about/has time | 17:15 |
*** brault has quit IRC | 17:15 | |
bauzas | no worries, I'll dig into the code anyway | 17:15 |
*** kwathore_ has quit IRC | 17:16 | |
*** brault has joined #openstack-nova | 17:16 | |
*** yamamoto has quit IRC | 17:16 | |
dansmith | tssurya: assume you don't yet have a bug for the host_manager issue right? | 17:18 |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | 17:18 |
*** sahid has quit IRC | 17:18 | |
hrw | mriedem, jaypipes: this version adds usb host controller ONLY if pointer device is 'usbtablet' so ps/2 mouse lovers are not touched | 17:18 |
*** ralonsoh_ has joined #openstack-nova | 17:21 | |
*** links has quit IRC | 17:21 | |
*** sree has quit IRC | 17:22 | |
mriedem | hrw: that needs tests | 17:22 |
*** yamahata has quit IRC | 17:22 | |
*** sree has joined #openstack-nova | 17:23 | |
tssurya | dansmith : no | 17:23 |
tssurya | do you want me to open one ? | 17:23 |
*** AlexeyAbashkin has quit IRC | 17:23 | |
hrw | mriedem: I am aware. Will ask someone to write one for me as I know how get functionality working but completely out of ideas when it comes to tests. | 17:24 |
dansmith | tssurya: I was thinking maybe you already had bugs for both of these things when I asked on the first review, but then realized maybe not | 17:24 |
dansmith | tssurya: I think it'd be good to have the bugs coming from cern as backport justification, if you don't mind | 17:24 |
*** ralonsoh has quit IRC | 17:24 | |
hrw | mriedem: having info are the idea and it's implementation ok is also helpful to me | 17:25 |
tssurya | dansmith : yea sure, I can do open them | 17:25 |
tssurya | you want it to be two seperate bugs ? | 17:25 |
mriedem | hrw: there should be at least one existing test in nova.tests.unit.virt.libvirt.test_driver that you could copy and modify | 17:25 |
dansmith | tssurya: yeah they're separate issues I think | 17:25 |
hrw | mriedem: ok | 17:25 |
*** lyan has joined #openstack-nova | 17:26 | |
hrw | mriedem: any other comments than unit testing? | 17:26 |
tssurya | cool will do and btw I have done the same for the bdm querying as we had discussed, for nova list, so will post that and open a bug for that too | 17:26 |
dansmith | tssurya: cool | 17:26 |
mriedem | hrw: haven't looked | 17:27 |
hrw | ok | 17:27 |
mriedem | don't wait for me though | 17:27 |
hrw | mriedem: do not plan to | 17:27 |
hrw | mriedem: and thanks a lot for reviews | 17:27 |
openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | 17:27 |
bauzas | mriedem: tssurya: I missed your discussion about ReqSpec deletions | 17:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add a nova-caching-scheduler job to the experimental queue https://review.openstack.org/539260 | 17:28 |
bauzas | mriedem: tssurya: I'll try to provide a new patchset this week, but no promises | 17:28 |
tssurya | bauzas : you have checked the last comment from mriedem on PS9 ? | 17:29 |
bauzas | not really | 17:29 |
*** moshele has joined #openstack-nova | 17:31 | |
*** Swami has joined #openstack-nova | 17:32 | |
bauzas | tssurya: dansmith: mmm, honestly, given https://review.openstack.org/#/c/515034/ I think we can abandon https://review.openstack.org/#/c/391060/ | 17:33 |
bauzas | mriedem: ^ | 17:33 |
bauzas | purging the spec records when we archive the deleted instances is enough | 17:33 |
dansmith | bauzas: no it's not | 17:34 |
bauzas | what are we missing then ? | 17:34 |
dansmith | for the case we were taking about above | 17:34 |
dansmith | because we wanted to use the deleted-reqspec as the sentinel to not include the instance in a list of instances from a downed cell | 17:34 |
dansmith | I want to talk about it in dublin | 17:34 |
dansmith | so don't abandon yet | 17:34 |
tssurya | bauzas : we are trying to find some way in which we can include information regarding the status of an instance : whether its deleted or not in the api DB | 17:34 |
bauzas | okay | 17:34 |
*** sree has quit IRC | 17:34 | |
bauzas | dansmith: so the idea would be that if you don't find the related spec record for a specific instance UUID, then it implies that the instance is deleted, hence not needed to be shown from the instance mapping records ? | 17:37 |
bauzas | so we wouldn't have stale content if the cell is down? | 17:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Check for leaked server resource allocations in post_test_hook https://review.openstack.org/538510 | 17:38 |
dansmith | bauzas: yeah | 17:38 |
bauzas | mmm, ok | 17:38 |
bauzas | I see | 17:38 |
dansmith | bauzas: we'd only be showing instance shells, but we don't want any to come back from the dead | 17:38 |
dansmith | we could have a deleted flag, but.. I really don't want to go down that road | 17:38 |
*** sridharg has quit IRC | 17:38 | |
dansmith | if we can help it | 17:38 |
bauzas | the main problem is that I'm not sure we can deterministacally destroy a spec record | 17:38 |
bauzas | oh man | 17:39 |
bauzas | deterministically-something | 17:39 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Check for leaked server resource allocations in post_test_hook https://review.openstack.org/538510 | 17:42 |
dansmith | bauzas: yeah I understand the potential issue there | 17:43 |
dansmith | hence the need to discuss | 17:43 |
bauzas | cool | 17:43 |
bauzas | okay, let's keep that open until Dublin then | 17:43 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617 | 17:43 |
bauzas | dansmith: thanks for explaining me the need | 17:43 |
dansmith | tssurya: ^ I'll update with the bug number when you get it | 17:44 |
*** kwathore__ has quit IRC | 17:44 | |
*** vivsoni__ has quit IRC | 17:44 | |
*** vivsoni__ has joined #openstack-nova | 17:44 | |
*** kwathore__ has joined #openstack-nova | 17:45 | |
*** tesseract has quit IRC | 17:45 | |
hrw | hm. I am reading _get_guest_pointer_model() again and again... It returns anything ONLY if that anything is usbtablet... | 17:46 |
hrw | or I do not understand Python (which is highly possible) | 17:47 |
bauzas | mriedem: before leaving, just left +1 on https://review.openstack.org/#/c/530743/ because I need to consider whether it's acceptable to have exceptions or not that are popped by the API, based on the compute version | 17:47 |
bauzas | like, say I'm upgrading half of my nodes, is that a problem if I'm getting a different disk calculation logic ? | 17:48 |
bauzas | either way, the master change is merged | 17:48 |
*** felipemonteiro_ has quit IRC | 17:48 | |
bauzas | so maybe it's just me overthinking | 17:48 |
bauzas | anyway, need to disappear | 17:49 |
hrw | function starts. then hw_pointer_model is read from image properties. if it is not set then check for use_usb_tablet option and if it is set then set pointer_model to usbtablet and issue a warning that configuration needs update. Then is a check is pointer_model a usbtablet. If it is not then function ends. It it is then check for is Vnc or (is spice but without spice agent) and then return usbtablet | 17:50 |
hrw | through _get_guest_usb_tablet() function which checks for VMMode and creates structure for add_device() call | 17:50 |
*** rmcall has joined #openstack-nova | 17:50 | |
*** rmcall has quit IRC | 17:51 | |
*** rmcall has joined #openstack-nova | 17:51 | |
hrw | mriedem: added one more comment and ending a day | 17:52 |
*** lpetrut_ has quit IRC | 17:52 | |
tssurya | dansmith : https://bugs.launchpad.net/nova/+bug/1746558 , https://bugs.launchpad.net/nova/+bug/1746561 | 17:53 |
openstack | Launchpad bug 1746558 in OpenStack Compute (nova) "Make service all-cells min version helper use scatter-gather" [Undecided,New] - Assigned to Dan Smith (danms) | 17:53 |
*** tbachman has quit IRC | 17:53 | |
openstack | Launchpad bug 1746561 in OpenStack Compute (nova) "Make host_manager use scatter-gather and ignore down cells" [Undecided,New] - Assigned to Dan Smith (danms) | 17:53 |
tssurya | dansmith: thanks again! | 17:53 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make service all-cells min version helper use scatter-gather https://review.openstack.org/539590 | 17:53 |
openstackgerrit | Dan Smith proposed openstack/nova master: Make host_manager use scatter-gather and ignore down cells https://review.openstack.org/539617 | 17:53 |
dansmith | tssurya: they haven't started running tests yet, so ^ | 17:54 |
dansmith | tssurya: thanks! | 17:54 |
*** vivsoni__ has quit IRC | 17:55 | |
*** vivsoni__ has joined #openstack-nova | 17:55 | |
*** sree has joined #openstack-nova | 17:56 | |
*** gjayavelu has joined #openstack-nova | 17:56 | |
*** tbachman has joined #openstack-nova | 17:58 | |
*** sree has quit IRC | 18:01 | |
openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: cold migrate to compute down https://review.openstack.org/496280 | 18:01 |
*** yamahata has joined #openstack-nova | 18:03 | |
*** ragiman has quit IRC | 18:07 | |
*** moshele has quit IRC | 18:10 | |
*** hongbin has joined #openstack-nova | 18:12 | |
*** jpena is now known as jpena|away | 18:13 | |
*** AlexeyAbashkin has joined #openstack-nova | 18:17 | |
*** tbachman has quit IRC | 18:23 | |
*** moshele has joined #openstack-nova | 18:24 | |
*** gjayavelu has joined #openstack-nova | 18:27 | |
mriedem | esberglu: can you post a patch that adds powervm to the hpc feature support matrix page? https://docs.openstack.org/nova/latest/user/feature-classification.html#matrix-hpc | 18:27 |
*** sree has joined #openstack-nova | 18:28 | |
mdbooth | dansmith: jaypipes Thanks. NP holding off for queens either. | 18:29 |
mriedem | kashyap: re http://logs.openstack.org/66/539266/2/check/build-openstack-sphinx-docs/f7a1712/html/admin/virtual-gpu.html#how-to-know-a-gpu-type where it says, "Note that the current libvirt API doesn’t provide a way to access that information." | 18:30 |
mriedem | is that true at least for libvirt 4.0.0? | 18:30 |
mriedem | which is the latest release? | 18:30 |
mdbooth | dansmith: I responded to your comments and I'm expecting to make some changes. Given that it's not going to land in Queens it's hardly urgent, but just in case you wanted to respond while you still have context... I'm looking for further feedback on which changes are really required. | 18:30 |
*** tbachman has joined #openstack-nova | 18:30 | |
*** vivsoni__ has quit IRC | 18:31 | |
*** kwathore__ has quit IRC | 18:31 | |
*** kwathore__ has joined #openstack-nova | 18:31 | |
*** vivsoni has joined #openstack-nova | 18:31 | |
*** mvenesio has quit IRC | 18:31 | |
*** moshele has quit IRC | 18:32 | |
mriedem | efried_rollin: the in-tree powervm driver doesn't support gpu passthrough right? | 18:34 |
*** felipemonteiro has joined #openstack-nova | 18:36 | |
*** sree has quit IRC | 18:36 | |
*** dtantsur is now known as dtantsur|afk | 18:37 | |
*** moshele has joined #openstack-nova | 18:39 | |
*** tbachman has quit IRC | 18:43 | |
*** mvenesio has joined #openstack-nova | 18:45 | |
mriedem | esberglu: nvm i've just about got this | 18:49 |
*** tbachman has joined #openstack-nova | 18:49 | |
*** AlexeyAbashkin has quit IRC | 18:51 | |
*** mvk has quit IRC | 18:52 | |
*** harlowja has quit IRC | 18:52 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: update the GPU passthrough HPC feature entry https://review.openstack.org/539638 | 18:52 |
*** sree has joined #openstack-nova | 18:52 | |
*** sree has quit IRC | 18:57 | |
*** priteau has quit IRC | 18:57 | |
*** david-lyle_ has joined #openstack-nova | 18:58 | |
*** moshele has quit IRC | 19:00 | |
*** dklyle has quit IRC | 19:01 | |
mriedem | artom: we don't throw exceptions in python! | 19:02 |
mriedem | :P | 19:02 |
*** sauloaugusto has quit IRC | 19:02 | |
artom | mriedem, eh? | 19:02 |
mriedem | https://review.openstack.org/#/c/539266/2/doc/source/admin/virtual-gpu.rst@116 | 19:02 |
artom | I said something stupid, didn't I? | 19:03 |
*** lajoskatona has quit IRC | 19:03 | |
artom | "Libvirt will throw an exception" | 19:03 |
artom | Yep :( | 19:03 |
*** kwathore_ has joined #openstack-nova | 19:03 | |
*** vivsoni has quit IRC | 19:03 | |
*** vivsoni has joined #openstack-nova | 19:04 | |
*** tidwellr has quit IRC | 19:04 | |
*** lucasagomes is now known as lucas-afk | 19:04 | |
*** tidwellr has joined #openstack-nova | 19:05 | |
*** DinaBelova has quit IRC | 19:06 | |
*** aignatov has quit IRC | 19:06 | |
*** DinaBelova has joined #openstack-nova | 19:07 | |
*** aignatov has joined #openstack-nova | 19:07 | |
*** kwathore__ has quit IRC | 19:07 | |
*** david-lyle_ is now known as dklyle | 19:08 | |
artom | Oh wait, you mean we raise, not throw. | 19:09 |
artom | Yeah, that too. | 19:09 |
artom | It's not my fault they taught us Java :( | 19:09 |
*** edleafe has quit IRC | 19:09 | |
*** edleafe has joined #openstack-nova | 19:10 | |
*** suresh12 has joined #openstack-nova | 19:11 | |
melwitt | well, libvirt itself throws because it's C right :P | 19:13 |
dansmith | C doesn't throw | 19:13 |
dansmith | it returns -1 and sets ERRNO | 19:14 |
melwitt | oh -_- guess I was thinking of C++ | 19:14 |
dansmith | *gasp* | 19:14 |
* melwitt runs away in shame | 19:14 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: update the GPU passthrough HPC feature entry https://review.openstack.org/539638 | 19:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide support matrix and doc for VGPU https://review.openstack.org/539266 | 19:15 |
mriedem | artom: i've tried to address your comments ^ but there were a lot of them... | 19:15 |
mriedem | and i'm just helping a brotha out | 19:15 |
*** suresh12 has quit IRC | 19:15 | |
*** amodi has joined #openstack-nova | 19:15 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: update the GPU passthrough HPC feature entry https://review.openstack.org/539638 | 19:17 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide support matrix and doc for VGPU https://review.openstack.org/539266 | 19:17 |
artom | mriedem, aha, cheers! | 19:17 |
*** sambetts is now known as sambetts|afk | 19:19 | |
mriedem | and because you overloaded me with comments, i screwed something up | 19:19 |
*** lpetrut_ has joined #openstack-nova | 19:20 | |
*** suresh12 has joined #openstack-nova | 19:20 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide support matrix and doc for VGPU https://review.openstack.org/539266 | 19:20 |
artom | Yeah, I think rescue and resize got merged/switched/borked | 19:21 |
mriedem | fixed in the latest revision | 19:22 |
mriedem | i think it's ready for canadian-style scrutiny | 19:22 |
artom | Quebec, *ahem* | 19:23 |
mriedem | that's not canada? | 19:23 |
mriedem | french canada | 19:23 |
mriedem | but still | 19:23 |
artom | Not if we can help it ;) | 19:23 |
mriedem | you're like the texas of canada? | 19:23 |
mriedem | le yeeha | 19:23 |
mriedem | *yeehaw | 19:23 |
artom | L'osti de takarnak | 19:23 |
artom | *tabarnak | 19:23 |
artom | Dammit :( | 19:23 |
artom | mriedem, can I circle back to that doc later tonight? I promised daughter we'd assemble her new bed while she's in daycare :P | 19:24 |
*** jpena|away is now known as jpena|off | 19:24 | |
artom | I wasn't expecting Sylvain to react to the review until tomorrow morning :/ | 19:25 |
*** amoralej is now known as amoralej|off | 19:25 | |
mriedem | just throw some blankets and pillows on the ground | 19:25 |
mriedem | damn kids and their demands for beds | 19:26 |
mriedem | wa wa feed me bathe me love me | 19:26 |
*** suresh12 has quit IRC | 19:26 | |
*** DinaBelova has quit IRC | 19:29 | |
*** aignatov has quit IRC | 19:29 | |
*** ralonsoh_ has quit IRC | 19:30 | |
dims | mriedem : wait for a few years... it turns into "leave me alone!" | 19:31 |
dims | :) | 19:31 |
*** suresh12 has joined #openstack-nova | 19:31 | |
mriedem | i almost thought i was going to see tears yesterday morning about the pants that laura laid out | 19:34 |
mriedem | so yeah i know what it's going to be like already | 19:34 |
mriedem | only *i* get to cry about the pants that laura lays out for me to wear! | 19:35 |
edleafe | mriedem: you wear pants? | 19:35 |
mriedem | still do yup | 19:35 |
mriedem | and shave and get haircuts | 19:35 |
mriedem | hasn't been a year of working at home yet | 19:35 |
dansmith | mriedem: I was going to say.. my pants still get laid out for me for important pants-wearing occasions | 19:35 |
edleafe | that's why I only have one pair. Prevents all the pants-related arguments | 19:36 |
dansmith | business in the front, party in the back? | 19:37 |
*** harlowja has joined #openstack-nova | 19:37 | |
* edleafe wonders what kind of parties dansmith goes to | 19:37 | |
dansmith | not the kind that require specific pant selection, that's for sure | 19:38 |
*** ccamacho has quit IRC | 19:38 | |
*** sree has joined #openstack-nova | 19:39 | |
*** amodi has quit IRC | 19:39 | |
*** mriedem1 has joined #openstack-nova | 19:41 | |
*** ccamacho has joined #openstack-nova | 19:41 | |
*** gyee has joined #openstack-nova | 19:42 | |
*** DinaBelova has joined #openstack-nova | 19:42 | |
*** aignatov has joined #openstack-nova | 19:42 | |
*** mriedem has quit IRC | 19:42 | |
*** sree has quit IRC | 19:43 | |
*** cdent has quit IRC | 19:53 | |
*** calebb has quit IRC | 19:57 | |
*** salv-orlando has quit IRC | 20:00 | |
*** salv-orlando has joined #openstack-nova | 20:00 | |
*** calebb has joined #openstack-nova | 20:01 | |
openstackgerrit | Ameed Ashour proposed openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows man page https://review.openstack.org/539654 | 20:02 |
*** calebb is now known as squid | 20:02 | |
*** squid is now known as calebb | 20:02 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: placement upgrade notes for queens https://review.openstack.org/539658 | 20:05 |
*** salv-orlando has quit IRC | 20:05 | |
*** moshele has joined #openstack-nova | 20:06 | |
*** sree has joined #openstack-nova | 20:07 | |
mriedem1 | need a final +2 on the reno for versioned notifications new in queens https://review.openstack.org/#/c/518018/ | 20:09 |
*** mriedem1 is now known as mriedem | 20:09 | |
mriedem | cfriesen: did your perf testing show any issues with the counting quotas stuff that was new in pike? | 20:11 |
*** sree has quit IRC | 20:11 | |
*** aignatov has quit IRC | 20:17 | |
*** DinaBelova has quit IRC | 20:17 | |
*** DinaBelova has joined #openstack-nova | 20:17 | |
*** aignatov has joined #openstack-nova | 20:18 | |
*** felipemonteiro_ has joined #openstack-nova | 20:21 | |
*** READ10 has quit IRC | 20:21 | |
*** DinaBelova has quit IRC | 20:21 | |
*** aignatov2 has joined #openstack-nova | 20:22 | |
*** DinaBelova has joined #openstack-nova | 20:22 | |
*** aignatov has quit IRC | 20:23 | |
*** aignatov2 is now known as aignatov | 20:23 | |
cfriesen | mriedem: don't know if we've gotten that far. I'm pretty sure it was on a mostly idle system so I wouldn't expect that to be a major factor. | 20:24 |
*** felipemonteiro has quit IRC | 20:24 | |
*** vivsoni_ has joined #openstack-nova | 20:26 | |
*** vivsoni has quit IRC | 20:26 | |
*** kwathore__ has joined #openstack-nova | 20:27 | |
*** tidwellr has quit IRC | 20:27 | |
*** chyka has quit IRC | 20:29 | |
*** kwathore_ has quit IRC | 20:29 | |
*** chyka has joined #openstack-nova | 20:30 | |
*** sree has joined #openstack-nova | 20:31 | |
*** chyka_ has joined #openstack-nova | 20:33 | |
*** chyka has quit IRC | 20:34 | |
*** tssurya_ has joined #openstack-nova | 20:34 | |
openstackgerrit | Ameed Ashour proposed openstack/nova master: detach instance volumes when VM creation fails https://review.openstack.org/528385 | 20:35 |
*** sree has quit IRC | 20:36 | |
*** links has joined #openstack-nova | 20:36 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Re-arrange cells docs for modern deployments https://review.openstack.org/539674 | 20:37 |
mriedem | dansmith: melwitt: we had talked at one point a few weeks ago about re-arranging the cells docs to move the cells v2 setup stuff to the top since that's mostly what people care about now when upgrading to ocata ^ | 20:38 |
mriedem | tried to move that stuff around and still leave the historical manifesto and cells v1 stuff in there to still make sense | 20:38 |
melwitt | ack | 20:39 |
*** DinaBelova has quit IRC | 20:39 | |
*** aignatov has quit IRC | 20:39 | |
*** DinaBelova has joined #openstack-nova | 20:40 | |
*** aignatov has joined #openstack-nova | 20:40 | |
*** derekh has quit IRC | 20:41 | |
*** chyka_ has quit IRC | 20:42 | |
*** chyka has joined #openstack-nova | 20:42 | |
*** efried_rollin is now known as efried | 20:42 | |
efried | mriedem: "the in-tree powervm driver doesn't support gpu passthrough right?" Not yeeeeeetttt.... | 20:44 |
*** tidwellr has joined #openstack-nova | 20:45 | |
*** chyka has quit IRC | 20:48 | |
hrw | does someone uses hw_pointer_model option? with something else than 'usbtablet' there? | 20:49 |
*** chyka has joined #openstack-nova | 20:49 | |
hrw | and if you do then does it work for you? | 20:49 |
*** eharney has quit IRC | 20:54 | |
*** Tom-Tom has joined #openstack-nova | 20:55 | |
*** moshele has quit IRC | 20:56 | |
*** Tom-Tom has quit IRC | 21:00 | |
*** lpetrut_ has quit IRC | 21:00 | |
*** salv-orlando has joined #openstack-nova | 21:01 | |
*** sree has joined #openstack-nova | 21:02 | |
*** vivsoni__ has joined #openstack-nova | 21:04 | |
*** vivsoni_ has quit IRC | 21:04 | |
ameeda | mriedem: replied | 21:05 |
mriedem | hrw: i thought it was end of day for you? | 21:05 |
*** pchavva has quit IRC | 21:06 | |
*** salv-orlando has quit IRC | 21:06 | |
*** sree has quit IRC | 21:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Re-arrange cells docs for modern deployments https://review.openstack.org/539674 | 21:07 |
*** liverpooler has quit IRC | 21:10 | |
*** vivsoni__ has quit IRC | 21:12 | |
*** vivsoni__ has joined #openstack-nova | 21:12 | |
*** kwathore__ has quit IRC | 21:12 | |
*** kwathore__ has joined #openstack-nova | 21:13 | |
mriedem | dansmith: can you hit this backport so i can get the one below it? https://review.openstack.org/#/c/527560/ | 21:17 |
ameeda | mriedem: please check the patch there is important comment there https://review.openstack.org/#/c/507486 | 21:17 |
dansmith | mriedem: doneski | 21:18 |
*** mvk has joined #openstack-nova | 21:18 | |
*** priteau has joined #openstack-nova | 21:19 | |
*** kwathore_ has joined #openstack-nova | 21:22 | |
*** vivsoni__ has quit IRC | 21:22 | |
*** vivsoni__ has joined #openstack-nova | 21:22 | |
mriedem | ameeda: i'm not sure what you want me to look at in that change | 21:23 |
*** suresh12 has quit IRC | 21:23 | |
mriedem | ugh i guess we can't backport this fix now https://review.openstack.org/#/c/524755/4/nova/objects/host_mapping.py@152 | 21:24 |
*** kwathore__ has quit IRC | 21:25 | |
mriedem | even though nothing uses it over rpc? | 21:25 |
*** pchavva has joined #openstack-nova | 21:25 | |
*** rmcall has quit IRC | 21:27 | |
*** moshele has joined #openstack-nova | 21:27 | |
dansmith | mriedem: well like I said I don't think that needed to be a bump anyway | 21:27 |
dansmith | mriedem: you could backport without the version bump and be fine I think.. seems scary, but should be alright | 21:28 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 21:28 |
*** sree has joined #openstack-nova | 21:31 | |
mriedem | efried: see what you think about my 'experimental' wording idea in https://review.openstack.org/#/c/539266/ | 21:32 |
*** links has quit IRC | 21:32 | |
mriedem | dansmith: might not be necessary, i was just thinking about it b/c the cells faq page says you can use this to list hosts in a cell, but there are other options for doing that as well, so not super important | 21:32 |
*** sree has quit IRC | 21:35 | |
ameeda | mriedem: Surya Seetharaman -> The same change of adding "--until-complete" is been done here I think ? : https://review.openstack.org/#/c/507486/29/doc/source/cli/nova-manage.rst | 21:36 |
ameeda | mriedem: I will upload new patch now | 21:37 |
mriedem | ameeda: your patch is much more targeted to just updating the man page | 21:37 |
openstackgerrit | Ameed Ashour proposed openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539654 | 21:38 |
ameeda | mriedem: I uploaded new patch. | 21:38 |
ameeda | mriedem: it seems that I shouldn't write tab when I add description ? | 21:39 |
efried | mriedem: Responded. Thanks. | 21:41 |
openstackgerrit | Ameed Ashour proposed openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539654 | 21:41 |
mriedem | ameeda: everything should be spaces, not tabs | 21:41 |
*** ssurana has joined #openstack-nova | 21:41 | |
*** ssurana has left #openstack-nova | 21:41 | |
ameeda | mriedem: oh, ok I will upload new patch, sorry | 21:42 |
openstackgerrit | Ameed Ashour proposed openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539654 | 21:46 |
ameeda | mriedem: uploaded (Y) | 21:47 |
*** salv-orlando has joined #openstack-nova | 21:47 | |
*** ccamacho has quit IRC | 21:48 | |
ameeda | mriedem: Thank you!! now I need to get Ocata release and add the change for it ? I think that I has pike version right ? | 21:52 |
*** pchavva has quit IRC | 21:53 | |
*** tssurya_ has quit IRC | 21:53 | |
mriedem | ameeda: you're on the master branch, which is currently queens | 21:53 |
mriedem | ameeda: review process is generally 2 +2s to approve a patch | 21:53 |
mriedem | ameeda: so you might as well hold off until someone actually approves the change | 21:53 |
*** suresh12_ has joined #openstack-nova | 21:53 | |
efried | mriedem: FYI, I seem to have a decent delay in receiving email from the mailing lists. (By way of explaining why I appeared to say the same thing you had "already" said.) | 21:55 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide support matrix and doc for VGPU https://review.openstack.org/539266 | 21:55 |
mriedem | efried: that is no excuse, you need to do better at your precognition of issues to come up in the ML in order to beat me to the punch | 21:56 |
efried | clearly | 21:57 |
mriedem | better call tom cruise | 21:57 |
efried | or that bald chick | 21:57 |
*** brault has quit IRC | 21:58 | |
ameeda | mriedem: its okay, Thank you for your time and helps. | 21:59 |
ameeda | mriedem: please don't forget to review this for me https://review.openstack.org/#/c/528385/ | 21:59 |
*** gjayavelu has quit IRC | 21:59 | |
*** priteau has quit IRC | 22:00 | |
*** vivsoni__ has quit IRC | 22:01 | |
*** priteau has joined #openstack-nova | 22:01 | |
*** kwathore__ has joined #openstack-nova | 22:01 | |
*** vivsoni__ has joined #openstack-nova | 22:01 | |
*** moshele has quit IRC | 22:01 | |
mriedem | ameeda: at this point i dream about the opportunity to review that patch :) | 22:01 |
mriedem | it is my destiny | 22:01 |
*** priteau has quit IRC | 22:03 | |
*** priteau has joined #openstack-nova | 22:03 | |
*** yamahata has quit IRC | 22:04 | |
*** kwathore_ has quit IRC | 22:04 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_access_get_by_flavor_id db api method https://review.openstack.org/539700 | 22:05 |
*** gjayavelu has joined #openstack-nova | 22:05 | |
ameeda | mriedem: lol, I appreciate that from you,I know that its hard to you to find time to check all reviews | 22:05 |
ameeda | mriedem: lastly I see +2 on one of my patches ^_^, lol | 22:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_delete db api method https://review.openstack.org/539702 | 22:07 |
melwitt | mriedem: on this backport, we're only concerned about holding it from ocata because of the possible related network-vif-plugged event timeout, but not for pike? https://review.openstack.org/#/c/531422 | 22:13 |
mriedem | melwitt: i am concerned for pike, but we have more time for pike | 22:13 |
mriedem | so less concerned | 22:13 |
melwitt | okay | 22:14 |
*** awaugama has quit IRC | 22:14 | |
mriedem | i thought about dropping my +2 | 22:14 |
mriedem | but i didn't think about it very hard | 22:14 |
melwitt | fair enough | 22:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_delete db api method https://review.openstack.org/539702 | 22:15 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_get db api method https://review.openstack.org/539706 | 22:15 |
*** sree has joined #openstack-nova | 22:15 | |
Roamer` | hm, has anybody reported problems with the "libvirt: QEMU native LUKS decryption for encrypted volumes" change recently? | 22:17 |
melwitt | not that I know of. have you experienced problems with it? | 22:18 |
Roamer` | the StorPool Cinder CI started failing each and every test run with the same problem: test_encrypted_cinder_volumes_luks fails and there is a nova-compute exception: Failed to detach volume 645fd643-89fc-4b3d-9ea5-59c764fc39a2 from /dev/vdb: AttributeError: 'NoneType' object has no attribute 'format_dom' | 22:18 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_delete db api method https://review.openstack.org/539702 | 22:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_extra_specs_get db api method https://review.openstack.org/539706 | 22:19 |
Roamer` | just a minute, let me point you at a stack trace | 22:19 |
Roamer` | http://logs.ci-openstack.storpool.com/18/539318/1/check/dsvm-tempest-storpool/c3daf58/logs/screen-n-cpu.txt.gz#_Jan_31_18_07_27_971552 and a couple of lines further down | 22:19 |
*** eharney has joined #openstack-nova | 22:20 | |
*** sree has quit IRC | 22:20 | |
Roamer` | melwitt: ^^ - it looks like the LibvirtConfigGuestDiskEncryption is missing a "secret" (not initialized; maybe not passed somewhere?) | 22:20 |
Roamer` | and this happens on every run | 22:20 |
melwitt | Roamer`: okay. could you please open a bug against nova with a link to the log and excerpt of the stack trace? | 22:21 |
Roamer` | melwitt, sure, I'll open it right now | 22:21 |
melwitt | we'll have lyarwood take a look at it | 22:21 |
melwitt | thank you | 22:22 |
*** salv-orl_ has joined #openstack-nova | 22:23 | |
*** rmcall has joined #openstack-nova | 22:23 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_access_remove db api method https://review.openstack.org/539709 | 22:24 |
*** salv-orlando has quit IRC | 22:25 | |
*** mvenesio has quit IRC | 22:27 | |
*** mvenesio has joined #openstack-nova | 22:27 | |
*** mvenesio has quit IRC | 22:31 | |
*** edmondsw has quit IRC | 22:32 | |
*** edmondsw has joined #openstack-nova | 22:33 | |
Roamer` | lyarwood, melwitt, https://bugs.launchpad.net/nova/+bug/1746609 | 22:34 |
openstack | Launchpad bug 1746609 in OpenStack Compute (nova) "test_boot_server_from_encrypted_volume_luks cannot detach an encrypted StorPool-backed volume" [Undecided,New] | 22:34 |
Roamer` | it's a bit brief, but it has links to the logs... | 22:34 |
openstackgerrit | Eric Fried proposed openstack/nova master: Avoid inventory DELETE API (no conflict detection) https://review.openstack.org/539712 | 22:34 |
efried | jaypipes: How about them apples ^ | 22:34 |
efried | Note approx -400LOC net. | 22:35 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_access_add db api methods https://review.openstack.org/539714 | 22:35 |
melwitt | Roamer`: thanks. we'll use this to investigate what's going wrong | 22:35 |
openstackgerrit | Eric Berglund proposed openstack/nova master: Use dict.get() when accessing capabilities dict https://review.openstack.org/539715 | 22:35 |
*** gjayavelu has quit IRC | 22:36 | |
*** gjayavelu has joined #openstack-nova | 22:36 | |
*** edmondsw has quit IRC | 22:37 | |
mriedem | Roamer`: is the storpool volume driver passing a secret in it's connection_info dict when using an encrypted volume type | 22:41 |
mriedem | i'm not actually sure if that's required | 22:42 |
mriedem | should probably check lee's patches to see if he had to change anything in devstack for this stuff to work, like with the key manager across both nova and cinder | 22:42 |
*** suresh12_ has quit IRC | 22:42 | |
*** salv-orl_ has quit IRC | 22:42 | |
mriedem | https://review.openstack.org/#/q/topic:bp/libvirt-qemu-native-luks+(status:open+OR+status:merged) | 22:43 |
*** salv-orlando has joined #openstack-nova | 22:43 | |
*** felipemonteiro_ has quit IRC | 22:43 | |
mriedem | melwitt: you know, | 22:43 |
mriedem | now that i think about it, | 22:43 |
*** felipemonteiro_ has joined #openstack-nova | 22:43 | |
mriedem | the tempest test that tests encrypted volumes is marked 'slow' so i don't think it actually runs in a job in our check queue... | 22:43 |
mriedem | i think there is a job that runs it in the experimental queue | 22:43 |
mriedem | this one https://github.com/openstack-infra/project-config/blob/master/zuul.d/projects.yaml#L10841 | 22:44 |
*** priteau has quit IRC | 22:45 | |
*** suresh12 has joined #openstack-nova | 22:45 | |
mriedem | passes here though http://logs.openstack.org/60/539260/2/experimental/legacy-tempest-dsvm-neutron-scenario-multinode-lvm-multibackend/77a82c8/job-output.txt.gz#_2018-01-31_20_59_15_161538 | 22:46 |
*** sree has joined #openstack-nova | 22:46 | |
*** salv-orlando has quit IRC | 22:47 | |
melwitt | hm, okay | 22:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_access_get_by_flavor_id db api method https://review.openstack.org/539720 | 22:48 |
*** rmcall has quit IRC | 22:49 | |
*** sree has quit IRC | 22:50 | |
Roamer` | mriedem, the StorPool driver does not generate any structures by itself, at your suggestion it inherits LibvirtVolumeDriver's get_config() method | 22:53 |
*** gjayavelu has quit IRC | 22:53 | |
*** sree has joined #openstack-nova | 22:53 | |
Roamer` | and from what I can see of the libvirt LUKS patch, the secret should be stored by LibvirtBaseVolumeDriver's get_config() | 22:53 |
*** andreas_s has joined #openstack-nova | 22:54 | |
mriedem | u'data': {u'device_path': u'/dev/storpool/os--volume-645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'encrypted': True, u'volume': u'645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'qos_specs': None, u'client_id': 12, u'access_mode': u'rw'} | 22:54 |
mriedem | https://review.openstack.org/#/c/523958/18/nova/virt/libvirt/driver.py@1342 | 22:54 |
mriedem | looks like the libvirt driver is expecting a connection_info['data']['volume_id'] entry | 22:55 |
melwitt | there must be one, else we'd see a KeyError, right? is it None? | 22:56 |
Roamer` | hm, ISTR that there was a "volume_id" one level up, on the same level as "data", but let me look again | 22:56 |
mriedem | https://review.openstack.org/#/c/523958/18/nova/virt/libvirt/volume/volume.py | 22:56 |
mriedem | melwitt: the libvirt driver code is using .get() to avoid a keyerror | 22:57 |
melwitt | I see it now | 22:57 |
*** sree has quit IRC | 22:58 | |
*** andreas_s has quit IRC | 22:58 | |
melwitt | so is volume_id supposed to always be set in connect_info['data'] or is it valid not to have it? | 22:58 |
mriedem | shrug, | 22:59 |
mriedem | connection_info is a wild west of whatever from the bazillion volume drivers in cinder | 22:59 |
mriedem | i do know that in nova, when we attach, we shove 'serial' into the connection_info if it's not already there | 22:59 |
mriedem | and serial == volume_id | 22:59 |
melwitt | sigh | 22:59 |
smcginnis | I don't think the serial is always the volume_id. | 23:00 |
smcginnis | RemoteFS based storage I think that's the case, but not others. | 23:00 |
mriedem | {u'status': u'reserved', u'instance': u'9a7f0101-917d-43f2-ac18-0b7d77c14fda', u'attached_at': u'', u'attach_mode': None, u'driver_volume_type': u'storpool', u'detached_at': u'', u'volume_id': u'645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'serial': u'645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'data': {u'device_path': u'/dev/storpool/os--volume-645fd643-89fc-4b3d-9ea5-59c764fc39a2', u'encrypted': True, u'volume': u'645fd643-89fc-4b3d | 23:00 |
mriedem | 5-59c764fc39a2', u'qos_specs': None, u'client_id': 12, u'access_mode': u'rw'}} | 23:00 |
mriedem | smcginnis: it's the volume_id if it's not already in the dict from cinder | 23:00 |
smcginnis | Ah, OK. | 23:01 |
mriedem | https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L425 | 23:01 |
*** munishmehan has quit IRC | 23:01 | |
mriedem | b/c we shove it in there | 23:01 |
mriedem | shove it real good | 23:01 |
smcginnis | Nah, just not the same as push it. Nice try. | 23:01 |
melwitt | oh, heh. smcginnis came here. I just asked the question in #openstack-cinder if it's valid not to have 'volume_id' in connection_info['data'] | 23:01 |
mriedem | so all of this new encryptor code from lyarwood should probably be falling back to looking for the serial in connection_info if connection_info['data'] doesn't have 'volume_id' | 23:01 |
*** burt has quit IRC | 23:01 | |
smcginnis | I do not think it's safe to assume that. | 23:02 |
melwitt | mdbooth ^ | 23:02 |
*** gjayavelu has joined #openstack-nova | 23:02 | |
* smcginnis is always lurking | 23:02 | |
*** hemna_ has quit IRC | 23:02 | |
*** slaweq has joined #openstack-nova | 23:04 | |
*** tidwellr has quit IRC | 23:05 | |
openstackgerrit | Eric Berglund proposed openstack/nova master: Use dict.get() when accessing capabilities dict https://review.openstack.org/539715 | 23:05 |
*** tidwellr has joined #openstack-nova | 23:05 | |
*** esberglu has quit IRC | 23:07 | |
mriedem | i don't really know how this is failing | 23:07 |
mriedem | if there is no secret, it shouldn't be set in the conf | 23:08 |
*** felipemonteiro__ has joined #openstack-nova | 23:08 | |
melwitt | oh, you mean find_secret should return None or something | 23:09 |
mriedem | idk, i get lost following the damn xml conversion crap in the libvirt driver | 23:09 |
melwitt | er, sorry it wouldn't even call find_secret | 23:09 |
*** slaweq has quit IRC | 23:09 | |
*** tidwellr has quit IRC | 23:09 | |
*** slaweq has joined #openstack-nova | 23:11 | |
mriedem | my guess is we don't get here https://review.openstack.org/#/c/464008/10/nova/virt/libvirt/config.py@1149 | 23:11 |
*** felipemonteiro_ has quit IRC | 23:12 | |
melwitt | yeah, and we wouldn't because there's no secret in the config | 23:13 |
melwitt | if c.tag == 'secret': would be False | 23:13 |
melwitt | so since there was no volume_id, there's no secret in the config, so there's no secret to be parsed into the config object, then it blows up when it goes to format the domain later | 23:14 |
*** slaweq has quit IRC | 23:15 | |
mriedem | http://logs.ci-openstack.storpool.com/18/539318/1/check/dsvm-tempest-storpool/c3daf58/logs/screen-n-cpu.txt.gz#_Jan_31_18_07_21_994385 | 23:15 |
mriedem | that's the secret xml | 23:15 |
mriedem | sshhhh | 23:15 |
melwitt | lol | 23:16 |
melwitt | so there IS secret xml? sigh, I'm confused | 23:17 |
melwitt | back to not knowing how this is failing | 23:17 |
mriedem | right i have no idea | 23:18 |
mriedem | basically need to wait for lyarwood to wake up | 23:18 |
melwitt | yeah | 23:18 |
*** sree has joined #openstack-nova | 23:19 | |
*** sdague has quit IRC | 23:20 | |
*** sree has quit IRC | 23:23 | |
*** mlavalle has quit IRC | 23:24 | |
*** john51 has quit IRC | 23:26 | |
*** lyan has quit IRC | 23:27 | |
*** rcernin has joined #openstack-nova | 23:28 | |
*** john51 has joined #openstack-nova | 23:33 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_destroy db api method https://review.openstack.org/539729 | 23:33 |
*** yamahata has joined #openstack-nova | 23:35 | |
lyarwood | *yawn* | 23:37 |
lyarwood | I really need to remove email from my phone | 23:37 |
lyarwood | <volume>None</volume> | 23:37 |
lyarwood | that's the issue btw | 23:37 |
melwitt | well HI | 23:37 |
lyarwood | ah, so you already found that above :) | 23:39 |
openstackgerrit | Eric Fried proposed openstack/nova master: Test case: new standard resource class unusable https://review.openstack.org/539732 | 23:40 |
efried | mriedem (in the correct channel) FYI there's a test case demonstrating the aforementioned bug that has nothing to do with infra ^ | 23:40 |
melwitt | lyarwood: we thought so but then got confused about how there's a <secret> element in the XML anyway | 23:41 |
melwitt | we were thinking the non-existent connection_info['data']['volume_id'] would result in *no* 'secret' element in the XML, then blow up later when it tried to parse <secret> back | 23:41 |
melwitt | but we see <secret> XML in the log. so then we knew we had to wait until you could look at it | 23:42 |
*** john51 has quit IRC | 23:43 | |
*** salv-orlando has joined #openstack-nova | 23:43 | |
*** sree has joined #openstack-nova | 23:44 | |
*** john51 has joined #openstack-nova | 23:45 | |
Roamer` | sorry I disappeared like that, had to take care of something at home | 23:47 |
Roamer` | but now it's a bit late here, so I guess I'll be off for the night; feel free to let me know if there's any way I can help with this secret problem | 23:47 |
*** salv-orlando has quit IRC | 23:47 | |
*** armax has quit IRC | 23:49 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old flavor_get_by_flavor_id db api method https://review.openstack.org/539733 | 23:49 |
mriedem | lyarwood: seems odd that it would add encryption elements at all if there was no volume_id found in the connection_info, that's what i don't get | 23:49 |
*** sree has quit IRC | 23:49 | |
*** rcernin has quit IRC | 23:50 | |
lyarwood | mriedem: right that's the inital bug here - https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1326 | 23:50 |
efried | mriedem: Okay, slightly weirder question. I assume it's possible to upgrade the placement service without upgrading the compute service (cause that's a way to get to the condition I asked about before). Does compute get restarted if that happens? | 23:50 |
lyarwood | mriedem: that needs to change to handle the case where volume_id isn't in connection_info as you've already discussed | 23:50 |
*** sdague has joined #openstack-nova | 23:53 | |
mriedem | lyarwood: ah yeah | 23:53 |
mriedem | ok | 23:53 |
mriedem | easy peasy | 23:54 |
mriedem | efried: i have'nt read the bug, but yes placement gets upgraded before nova services | 23:54 |
mriedem | and computes can be n-1 for rolling upgrades | 23:54 |
efried | ight | 23:54 |
*** gjayavelu has quit IRC | 23:56 | |
*** umbSublime has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!