Roamer` | mriedem, lyarwood, if you guys think that it might be a good idea to modify our Cinder driver to put the volume_id in the connection info, we could do that too... but people in -cinder seemed to think that it's not necessarily expected | 00:00 |
---|---|---|
mriedem | Roamer`: no it's a nova problem | 00:00 |
mriedem | i'll see if i can post something quick | 00:00 |
lyarwood | thanks mriedem, just trying to understand why we then fail attempting to format the encryption dom that shouldn't even be there in this case tbh | 00:02 |
*** hshiina has joined #openstack-nova | 00:03 | |
Roamer` | mriedem, thanks. Unfortunately I'm really tired right now, but if you do manage to come up with something, I'll test it seven or eight hours from now | 00:03 |
*** gjayavelu has joined #openstack-nova | 00:04 | |
openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Ensure resource classes correctly https://review.openstack.org/539738 | 00:07 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Look all over hell for that damn volume_id https://review.openstack.org/539739 | 00:07 |
mriedem | Roamer`: do we need a cinder patch to test that out with your CI? ^ | 00:07 |
*** rcernin has joined #openstack-nova | 00:08 | |
*** felipemonteiro__ has quit IRC | 00:11 | |
*** tbachman_ has joined #openstack-nova | 00:12 | |
*** hongbin has quit IRC | 00:12 | |
*** tbachman has quit IRC | 00:14 | |
*** tbachman_ is now known as tbachman | 00:14 | |
*** sree has joined #openstack-nova | 00:15 | |
efried | mriedem: I'm out for the evening. In case I forget to mention it tomorrow, I need to leave the nova meeting like ten minutes in (I'm on the hook for school runs). | 00:16 |
mriedem | efried: ok, it's tomorrow afternoon though | 00:17 |
efried | yuh | 00:17 |
*** r-daneel has quit IRC | 00:18 | |
*** sree has quit IRC | 00:20 | |
*** chyka has quit IRC | 00:30 | |
*** kwathore_ has joined #openstack-nova | 00:35 | |
*** vivsoni__ has quit IRC | 00:35 | |
*** vivsoni__ has joined #openstack-nova | 00:35 | |
*** yangyapeng has quit IRC | 00:36 | |
*** zhurong has joined #openstack-nova | 00:37 | |
*** kwathore__ has quit IRC | 00:38 | |
*** hiro-kobayashi has joined #openstack-nova | 00:46 | |
Spazmotic | Morning | 00:47 |
melwitt | mriedem: is this correct in the cinder fixtures? or should it be volume['attach_status'] being set? https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1394 | 00:50 |
*** sree has joined #openstack-nova | 00:53 | |
*** Tom-Tom has joined #openstack-nova | 00:56 | |
*** zhaochao has joined #openstack-nova | 00:58 | |
melwitt | I think it's supposed to be 'attach_status' if the values are 'attached' or 'detached' | 00:58 |
*** gyee has quit IRC | 00:58 | |
*** psachin has joined #openstack-nova | 01:00 | |
mriedem | melwitt: you're right i think, status would be 'in-use' if it's attached | 01:00 |
mriedem | and 'available' if it's not attached | 01:00 |
*** Tom-Tom has quit IRC | 01:00 | |
*** sree has quit IRC | 01:01 | |
mriedem | https://developer.openstack.org/api-ref/block-storage/v3/#volumes-volumes | 01:01 |
melwitt | k, thanks for the sanity check. I can propose a fix for that. I'm meddling with my CellDatabases fixture improvements again | 01:01 |
*** tiendc has joined #openstack-nova | 01:01 | |
*** jistr has quit IRC | 01:01 | |
*** jistr has joined #openstack-nova | 01:02 | |
*** armax has joined #openstack-nova | 01:07 | |
*** gus has quit IRC | 01:07 | |
*** gjayavelu has quit IRC | 01:07 | |
*** Swami has quit IRC | 01:08 | |
*** gus has joined #openstack-nova | 01:08 | |
openstackgerrit | melanie witt proposed openstack/nova master: Query all cells for service version in _validate_bdm https://review.openstack.org/539755 | 01:08 |
*** lbragstad has quit IRC | 01:10 | |
*** sree has joined #openstack-nova | 01:13 | |
*** armax has quit IRC | 01:13 | |
*** stakeda has joined #openstack-nova | 01:15 | |
openstackgerrit | jichenjc proposed openstack/nova-specs master: add z/VM Driver in Rocky https://review.openstack.org/536186 | 01:17 |
openstackgerrit | melanie witt proposed openstack/nova master: Use 'attach_status' for attachment status in Cinder fixtures https://review.openstack.org/539758 | 01:18 |
*** gjayavelu has joined #openstack-nova | 01:18 | |
*** sree has quit IRC | 01:18 | |
*** yangyapeng has joined #openstack-nova | 01:19 | |
*** armax has joined #openstack-nova | 01:20 | |
*** umbSublime has joined #openstack-nova | 01:24 | |
*** umbSublime has quit IRC | 01:24 | |
*** umbSublime has joined #openstack-nova | 01:24 | |
*** sree has joined #openstack-nova | 01:24 | |
*** namnh has joined #openstack-nova | 01:28 | |
*** sree has quit IRC | 01:29 | |
*** suresh12 has quit IRC | 01:31 | |
*** lbragstad has joined #openstack-nova | 01:31 | |
*** gjayavelu has quit IRC | 01:38 | |
*** gongysh has joined #openstack-nova | 01:40 | |
openstackgerrit | Victor Morales proposed openstack/os-traits master: Update Usage information https://review.openstack.org/539761 | 01:43 |
*** salv-orlando has joined #openstack-nova | 01:44 | |
*** tuanla____ has joined #openstack-nova | 01:46 | |
*** salv-orlando has quit IRC | 01:49 | |
*** Guest61824 has quit IRC | 01:49 | |
*** sree has joined #openstack-nova | 01:49 | |
*** chyka has joined #openstack-nova | 01:53 | |
*** sree has quit IRC | 01:53 | |
*** chyka has quit IRC | 01:58 | |
*** hongbin has joined #openstack-nova | 01:59 | |
*** felipemonteiro has joined #openstack-nova | 02:00 | |
*** yassine has joined #openstack-nova | 02:03 | |
*** yassine is now known as Guest3579 | 02:04 | |
*** Tom-Tom has joined #openstack-nova | 02:05 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_numa_memnode() https://review.openstack.org/529906 | 02:09 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631 | 02:09 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451 | 02:09 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049 | 02:09 |
*** tetsuro has joined #openstack-nova | 02:13 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: fix native luks encryption failure to find volume_id https://review.openstack.org/539739 | 02:15 |
*** gcb has joined #openstack-nova | 02:16 | |
*** threestrands has joined #openstack-nova | 02:27 | |
*** threestrands has quit IRC | 02:27 | |
*** threestrands has joined #openstack-nova | 02:27 | |
*** felipemonteiro has quit IRC | 02:29 | |
*** andreas_s has joined #openstack-nova | 02:34 | |
*** annp has joined #openstack-nova | 02:34 | |
openstackgerrit | melanie witt proposed openstack/nova master: Use 'attach_status' for attachment status in Cinder fixtures https://review.openstack.org/539758 | 02:35 |
*** yamamoto has joined #openstack-nova | 02:37 | |
*** andreas_s has quit IRC | 02:38 | |
*** priteau has joined #openstack-nova | 02:57 | |
*** priteau has quit IRC | 02:58 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: trivial: Fix few policy doc https://review.openstack.org/539780 | 03:04 |
*** r-daneel has joined #openstack-nova | 03:10 | |
*** r-daneel has quit IRC | 03:15 | |
*** vivsoni__ has quit IRC | 03:17 | |
*** hoangcx has quit IRC | 03:18 | |
*** tovin07 has quit IRC | 03:18 | |
*** tovin07 has joined #openstack-nova | 03:18 | |
*** hoangcx has joined #openstack-nova | 03:18 | |
*** tiendc has quit IRC | 03:19 | |
*** tuanla____ has quit IRC | 03:19 | |
*** sree has joined #openstack-nova | 03:19 | |
*** tuanla____ has joined #openstack-nova | 03:20 | |
*** tiendc has joined #openstack-nova | 03:20 | |
*** sree has quit IRC | 03:20 | |
*** sree has joined #openstack-nova | 03:20 | |
*** suresh12 has joined #openstack-nova | 03:22 | |
*** vivsoni has joined #openstack-nova | 03:22 | |
jianghuaw | Spazmotic, see my comments in https://review.openstack.org/#/c/538415 | 03:25 |
*** suresh12 has quit IRC | 03:26 | |
Spaz-Work | jianghuaw: thanks for the update and the extra info on that bug report | 03:36 |
Spaz-Work | I'll be adjusting the checking tonight sir | 03:36 |
Spaz-Work | I'm curious the best way to go about that since we're guarunteed a micro version here.. I am debating between converting to a tuple and comparing or importing the oslo versioning method to handle the comparison | 03:36 |
Spaz-Work | Riedman also showed me an openstack method I need to look into that may work for it more elegantly.. but yeah.. just havn't been at a computer. Will commit it within a few hours :) | 03:37 |
jianghuaw | Spaz-Work, looks good. thanks. | 03:37 |
Spaz-Work | jianghuaw: I would like to changei t from a full skip to just swallowing the VDI_NOT_IN_MAP exception IF the platform version >= 2.1.0 | 03:38 |
Spaz-Work | That way we can avoid the skip for lower versions | 03:38 |
Spaz-Work | And then very likely an immediate follow-up commit when I get home from Korea to get the code-block out of --block-migrate specifics, unless you guys want to handle it while i'm away | 03:38 |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161 | 03:40 |
jianghuaw | Spaz-Work, Actually I prefer to skip the whole check and leave the work spreading the check out of block migration block. But I'd +1 also if you go with swallowing the exception. | 03:42 |
jianghuaw | Spaz-Work, May I know your vacation plan? | 03:42 |
*** eharney has quit IRC | 03:42 | |
Spaz-Work | Any reason why you'd prefer a full skip? Just to avoid the extra code when we need to redesign anyway? | 03:43 |
Spaz-Work | Sure sir. Flying into Incheon on the 6th your time zone and will spend a Week in Seoul, and then a week in Daegu | 03:43 |
Spaz-Work | And some smaller cities along the way in the mountains and such. | 03:43 |
Spaz-Work | Spending 2 weeks with my finace while we wait for Visa | 03:43 |
jianghuaw | the reason is: at the moment it's only invoked for block migration. And the exception is of block. | 03:44 |
*** sdague has quit IRC | 03:45 | |
*** salv-orlando has joined #openstack-nova | 03:45 | |
Spaz-Work | Hrm.. True enough, I guess I was seeing it from our angle, we call --block-migration no matter what because we don't use aggregates | 03:45 |
Spaz-Work | the flag has an interesting side effect of skipping the host aggregate lookup heh | 03:45 |
*** dave-mccowan has quit IRC | 03:48 | |
*** salv-orlando has quit IRC | 03:50 | |
jianghuaw | Spaz-Work, thanks for the sharing. Wish you'll have a happy vacation. | 03:52 |
jianghuaw | I'm happy to leave the work on "get the code-block out of --block-migrate specifics" and wait for you return from the vacation:-) | 03:52 |
Spaz-Work | Sounds good. Would you like to see the exception changed at that time since it will open it up outside of the block-migration ? | 03:53 |
jianghuaw | sure. | 03:54 |
*** abhishekk has joined #openstack-nova | 03:56 | |
*** Spaz-Work has quit IRC | 04:00 | |
*** Spaz-Work has joined #openstack-nova | 04:00 | |
openstackgerrit | lei zhang proposed openstack/nova master: Zuul: Remove project name https://review.openstack.org/539801 | 04:07 |
*** lpetrut_ has joined #openstack-nova | 04:09 | |
*** harlowja has quit IRC | 04:12 | |
*** suresh12 has joined #openstack-nova | 04:13 | |
Spaz-Work | . | 04:14 |
*** gongysh has quit IRC | 04:16 | |
*** crushil has joined #openstack-nova | 04:20 | |
*** hieulq_ has quit IRC | 04:30 | |
*** lpetrut_ has quit IRC | 04:31 | |
*** links has joined #openstack-nova | 04:32 | |
*** hieulq_ has joined #openstack-nova | 04:32 | |
*** vladikr has quit IRC | 04:35 | |
*** vladikr has joined #openstack-nova | 04:35 | |
*** lpetrut_ has joined #openstack-nova | 04:40 | |
*** harlowja has joined #openstack-nova | 04:41 | |
*** lpetrut__ has joined #openstack-nova | 04:41 | |
*** lpetrut_ has quit IRC | 04:44 | |
*** ratailor has joined #openstack-nova | 04:45 | |
*** hongbin has quit IRC | 04:47 | |
*** lpetrut__ has quit IRC | 04:55 | |
*** zhurong has quit IRC | 04:55 | |
*** markvoelker has quit IRC | 04:57 | |
*** ankkumar has joined #openstack-nova | 05:05 | |
*** moshele has joined #openstack-nova | 05:11 | |
*** chyka has joined #openstack-nova | 05:15 | |
*** bhujay has joined #openstack-nova | 05:18 | |
*** chyka has quit IRC | 05:20 | |
ankkumar | Hello | 05:23 |
ankkumar | we created vm with nova and we are putting our physical interface to virtual bridge | 05:23 |
*** lpetrut__ has joined #openstack-nova | 05:23 | |
*** trinaths has joined #openstack-nova | 05:24 | |
ankkumar | Also inside the vm we installed openvswitch and assigning ip to bridge but it is not able to ping or it is not reachable. | 05:24 |
ankkumar | Is there any way we can make ip pingable? | 05:24 |
ankkumar | Or what is the way to add the virtual port through nova? | 05:25 |
Spaz-Work | Hi ankkumar, this channel is generally about Nova Development. Someone may have the answer for you here but you may have better luck in #openstack | 05:25 |
*** suresh12 has quit IRC | 05:26 | |
ankkumar | Spaz-Work, ok | 05:26 |
*** sree has quit IRC | 05:31 | |
Spaz-Work | can see another failure condition this block migration if statement opened up.. | 05:32 |
Spaz-Work | It only checks to ensure aggregation in the destination check if it's NOT a block migration but then pulls by aggregate in the block migration if statement.. heh | 05:33 |
*** felipemonteiro has joined #openstack-nova | 05:33 | |
*** trinaths has quit IRC | 05:33 | |
Spaz-Work | Not completely sure why these XenAPI drivers pull by aggregate instead of just pulling the resident | 05:33 |
*** crushil has quit IRC | 05:35 | |
*** sree has joined #openstack-nova | 05:40 | |
*** vladikr has quit IRC | 05:42 | |
Spaz-Work | n/m actaully read that wrong hehe.. am dum | 05:43 |
*** kwathore_ has quit IRC | 05:45 | |
*** salv-orlando has joined #openstack-nova | 05:46 | |
*** moshele has quit IRC | 05:47 | |
*** threestrands has quit IRC | 05:48 | |
*** lpetrut__ has quit IRC | 05:50 | |
*** salv-orlando has quit IRC | 05:50 | |
*** gongysh has joined #openstack-nova | 05:54 | |
*** gongysh has quit IRC | 05:56 | |
*** takedakn has joined #openstack-nova | 05:58 | |
*** trinaths has joined #openstack-nova | 05:59 | |
*** mdnadeem has joined #openstack-nova | 06:00 | |
*** kwathore has joined #openstack-nova | 06:00 | |
*** zhurong has joined #openstack-nova | 06:02 | |
*** takedakn has quit IRC | 06:03 | |
*** gongysh has joined #openstack-nova | 06:04 | |
*** janki has joined #openstack-nova | 06:10 | |
*** sridharg has joined #openstack-nova | 06:11 | |
*** harlowja has quit IRC | 06:12 | |
openstackgerrit | Tuan Luong-Anh proposed openstack/nova master: Fix some reST field lists in docstrings https://review.openstack.org/538809 | 06:13 |
*** felipemonteiro has quit IRC | 06:15 | |
*** liuzz_ has joined #openstack-nova | 06:15 | |
*** liuzz has quit IRC | 06:15 | |
*** gjayavelu has joined #openstack-nova | 06:22 | |
*** sree has quit IRC | 06:24 | |
*** liuzz_ has quit IRC | 06:32 | |
*** liuzz has joined #openstack-nova | 06:32 | |
*** liuzz has quit IRC | 06:34 | |
openstackgerrit | Merged openstack/nova master: [placement] Separate API schemas (resource_provider) https://review.openstack.org/528629 | 06:41 |
openstackgerrit | Merged openstack/nova stable/pike: libvirt: Re-initialise volumes, encryptors, and vifs on hard reboot https://review.openstack.org/531407 | 06:42 |
openstackgerrit | Merged openstack/nova master: Implement get_traits() for the ironic virt driver https://review.openstack.org/532288 | 06:42 |
openstackgerrit | Merged openstack/nova master: Add functional tests for virt driver get_traits() method https://review.openstack.org/538047 | 06:42 |
openstackgerrit | Merged openstack/nova master: placement: enable required traits from the flavor extra specs https://review.openstack.org/536085 | 06:42 |
openstackgerrit | Merged openstack/nova stable/pike: tests: Use correct response type in tests https://review.openstack.org/538938 | 06:44 |
*** belmoreira has joined #openstack-nova | 06:44 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Encode libvirt domain XML in UTF-8 https://review.openstack.org/522161 | 06:45 |
*** brault has joined #openstack-nova | 06:49 | |
*** lpetrut__ has joined #openstack-nova | 06:51 | |
*** markvoelker has joined #openstack-nova | 06:58 | |
*** suresh12 has joined #openstack-nova | 07:03 | |
*** suresh12 has quit IRC | 07:08 | |
*** liuzz has joined #openstack-nova | 07:11 | |
*** zhurong has quit IRC | 07:14 | |
*** andreas_s has joined #openstack-nova | 07:15 | |
*** andreas_s has quit IRC | 07:16 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:18 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/539841 | 07:20 |
*** purplerbot has quit IRC | 07:22 | |
*** purplerbot has joined #openstack-nova | 07:22 | |
*** purplerbot has quit IRC | 07:22 | |
*** purplerbot has joined #openstack-nova | 07:23 | |
*** rcernin has quit IRC | 07:23 | |
*** purplerbot has quit IRC | 07:23 | |
*** purplerbot has joined #openstack-nova | 07:23 | |
*** zhurong has joined #openstack-nova | 07:23 | |
*** purplerbot has quit IRC | 07:24 | |
*** purplerbot has joined #openstack-nova | 07:24 | |
*** purplerbot has quit IRC | 07:25 | |
*** purplerbot has joined #openstack-nova | 07:25 | |
*** purplerbot has quit IRC | 07:25 | |
*** purplerbot has joined #openstack-nova | 07:25 | |
*** purplerbot has quit IRC | 07:25 | |
*** purplerbot has joined #openstack-nova | 07:25 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | 07:26 |
*** sahid has joined #openstack-nova | 07:31 | |
*** markvoelker has quit IRC | 07:32 | |
*** hoangcx has quit IRC | 07:33 | |
*** annp has quit IRC | 07:33 | |
*** tuanla____ has quit IRC | 07:33 | |
*** namnh has quit IRC | 07:33 | |
*** hoangcx has joined #openstack-nova | 07:33 | |
*** annp has joined #openstack-nova | 07:33 | |
*** tuanla____ has joined #openstack-nova | 07:33 | |
*** namnh has joined #openstack-nova | 07:33 | |
*** gszasz has joined #openstack-nova | 07:35 | |
*** AlexeyAbashkin has quit IRC | 07:37 | |
ameeda | Hello. I try to alter table in sqlite as following http://paste.openstack.org/show/658280/ , but I got functional test failure | 07:42 |
ameeda | I got this error 'instances' not in {'instance_system_metadata': 11, 'instance_actions_events': 2, 'block_device_mapping': 1, 'instance_info_caches': 1, 'instance_actions': 2, 'instance_extra': 1, 'security_group_instance_association': 1} | 07:42 |
*** claudiub has joined #openstack-nova | 07:44 | |
*** suresh12 has joined #openstack-nova | 07:45 | |
*** salv-orlando has joined #openstack-nova | 07:46 | |
*** claudiub|3 has quit IRC | 07:47 | |
*** sree has joined #openstack-nova | 07:47 | |
*** pcaruana has joined #openstack-nova | 07:47 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Improve performance when list instances with IP filter https://review.openstack.org/539469 | 07:47 |
maciejjozefczyk_ | bauzas: pong :) | 07:49 |
*** slaweq has joined #openstack-nova | 07:50 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:50 | |
*** salv-orlando has quit IRC | 07:51 | |
*** sree has quit IRC | 07:51 | |
*** brault has quit IRC | 07:54 | |
*** brault has joined #openstack-nova | 07:55 | |
openstackgerrit | Merged openstack/nova stable/pike: Handle images with no data https://review.openstack.org/538939 | 07:58 |
*** lajoskatona has joined #openstack-nova | 08:01 | |
*** moshele has joined #openstack-nova | 08:02 | |
hrw | mriedem: asked and left. no one replied anyway | 08:02 |
*** bhujay has quit IRC | 08:05 | |
*** amoralej|off is now known as amoralej | 08:09 | |
hrw | die i440fx, die | 08:25 |
*** yangyapeng has quit IRC | 08:25 | |
*** yangyapeng has joined #openstack-nova | 08:26 | |
*** markvoelker has joined #openstack-nova | 08:29 | |
*** masahisa has joined #openstack-nova | 08:30 | |
*** itlinux has joined #openstack-nova | 08:30 | |
*** yangyapeng has quit IRC | 08:31 | |
*** liuzz_ has joined #openstack-nova | 08:31 | |
*** liuzz has quit IRC | 08:32 | |
*** ccamacho has joined #openstack-nova | 08:32 | |
openstackgerrit | sahid proposed openstack/nova-specs master: virt: allow instances to be booted with trusted VFs https://review.openstack.org/485522 | 08:33 |
*** bhujay has joined #openstack-nova | 08:33 | |
openstackgerrit | sahid proposed openstack/nova-specs master: update: introducing isolate emulthreads on host https://review.openstack.org/511188 | 08:36 |
*** jpena|off is now known as jpena | 08:40 | |
*** gongysh has quit IRC | 08:43 | |
*** ragiman has joined #openstack-nova | 08:44 | |
*** suresh12 has quit IRC | 08:45 | |
*** ralonsoh has joined #openstack-nova | 08:47 | |
*** salv-orlando has joined #openstack-nova | 08:47 | |
openstackgerrit | Brooks Kaminski proposed openstack/nova master: XenAPI: XCP2.1+ Swallow VDI_NOT_IN_MAP Exception https://review.openstack.org/538415 | 08:48 |
Spaz-Work | jianghuaw: I did go with a swallow here.. I updated the commit message for my reasoning. | 08:49 |
Spaz-Work | Will get a post on the bug report here in a few too | 08:49 |
jianghuaw | good. Will review it a little later. | 08:50 |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: return non-None value for cpuset_reserved https://review.openstack.org/539865 | 08:50 |
*** gongysh has joined #openstack-nova | 08:50 | |
Spaz-Work | No rush, just wanted to let you know :) | 08:51 |
*** salv-orlando has quit IRC | 08:52 | |
bauzas | maciejjozefczyk_: hola, was afk | 08:52 |
bauzas | good morning folks, btw. | 08:52 |
Spaz-Work | Morning sir | 08:53 |
tetsuro | morning | 08:53 |
*** itlinux has quit IRC | 08:53 | |
jianghuaw | bauzas, good morning:-) | 08:55 |
*** Guest3579 has quit IRC | 08:55 | |
maciejjozefczyk_ | bauzas: hey | 08:57 |
maciejjozefczyk_ | bauzas: reading your comments | 08:58 |
*** trinaths has quit IRC | 08:58 | |
openstackgerrit | Merged openstack/nova master: Fix bug case by none token context https://review.openstack.org/522112 | 08:58 |
openstackgerrit | Merged openstack/nova master: report client: get_provider_tree_and_ensure_root https://review.openstack.org/521098 | 08:58 |
*** namnh_ has joined #openstack-nova | 08:58 | |
openstackgerrit | Merged openstack/nova master: ComputeDriver.update_provider_tree() https://review.openstack.org/521187 | 08:58 |
bauzas | oh, btw. for folks not in European hours, "good morning" means "good [afternoon,night]" also :p | 08:59 |
bauzas | maciejjozefczyk_: do you understand the possible problem ? | 08:59 |
openstackgerrit | Merged openstack/nova master: reno for notification-transformation-queens https://review.openstack.org/518018 | 08:59 |
bauzas | it will work for Pike computes if the operator didn't modified the nova.conf | 08:59 |
*** Guest3579 has joined #openstack-nova | 08:59 | |
bauzas | but if the operator modified the compute nova.conf for Pike, then we would possibly change the ratio into the conf opt value of any other service calling it | 09:00 |
maciejjozefczyk_ | bauzas: yes I see your point | 09:01 |
*** namnh has quit IRC | 09:02 | |
maciejjozefczyk_ | Maybe we should do distinguish between serviceand compute calling that method? | 09:02 |
ameeda | bauzas: I right sqlite migration script to alter column type as following http://paste.openstack.org/show/658286/, but when I run functional test I got this errors http://logs.openstack.org/00/526900/27/check/nova-tox-functional/f6ce415/testr_results.html.gz | 09:02 |
bauzas | maciejjozefczyk_: my thoughts is maybe we could just look at the ComputeNode object version | 09:02 |
ameeda | sorry "I write*" | 09:03 |
*** markvoelker has quit IRC | 09:03 | |
ameeda | bauzas: can you help me with that ? | 09:04 |
maciejjozefczyk_ | hmm bauzas could be good | 09:04 |
maciejjozefczyk_ | leave the logic for pike, move new one if object is newest one | 09:04 |
*** maciejjozefczyk_ is now known as maciejjozefczyk | 09:06 | |
bauzas | maciejjozefczyk: sec, looking at code | 09:09 |
bauzas | ie. where we are accessing ratios | 09:09 |
*** trinaths has joined #openstack-nova | 09:09 | |
bauzas | AFAIR, we only get or set ratios either in compute service or within the scheduler | 09:09 |
*** hiro-kobayashi has quit IRC | 09:10 | |
*** salv-orlando has joined #openstack-nova | 09:10 | |
bauzas | so, the big problem is only for the scheduler | 09:10 |
maciejjozefczyk | bauzas: I think too thats its only in compute-node or scheduler | 09:10 |
maciejjozefczyk | bauzas: right | 09:10 |
bauzas | of course, let's find a solution that would work for any service | 09:10 |
bauzas | because if we just fix that only for the scheduler, if after some time, someone lookups ratios in the nova-api worker for example, it couldn't owrk | 09:11 |
maciejjozefczyk | bauzas: yes, it should be complex | 09:11 |
bauzas | okay, so it's confirmed | 09:11 |
jianghuaw | Spaz-Work, thanks for updating the patch with well defined commit messages. It looks very reasonable. I totally agreed with you:-) | 09:12 |
bauzas | we load ComputeNode objects in the scheduler HostManager to correctly set the HostStates | 09:12 |
Spaz-Work | jianghuaw: Thanks sir. Definately nerve-wracking commit since it's nasty, wanted to make sure I was clear ;) | 09:12 |
*** blkart_ has quit IRC | 09:13 | |
*** blkart_ has joined #openstack-nova | 09:14 | |
jianghuaw | The commit message did help me to understand why the fix goes with that way:-) | 09:14 |
bauzas | maciejjozefczyk: so, after looking at the object code, I think checking the object version won't work | 09:15 |
bauzas | because if we call the object from the scheduler side, it will get the latest version, then calling the remotable method for getting the primitives, then transforming the primitives if necessary and then hydrating the object from the primitive | 09:16 |
bauzas | but when we hydrate the primitive, we're already having a computenode object version that is the latest | 09:17 |
maciejjozefczyk | bauzas: the stupid solution is duplicating the fields, right?:) | 09:18 |
bauzas | what do you mean ? | 09:18 |
*** pcaruana has quit IRC | 09:19 | |
*** pcaruana has joined #openstack-nova | 09:19 | |
maciejjozefczyk | like adding ram_allocation_ratio_v2 for Rocky and do magic in filtering primitives? If I understand it correctly | 09:20 |
bauzas | oh please no | 09:21 |
maciejjozefczyk | but yes, its not a solution, its workaround | 09:21 |
maciejjozefczyk | :D | 09:21 |
*** derekh has joined #openstack-nova | 09:21 | |
maciejjozefczyk | bauzas: yes, just kidding | 09:21 |
*** gjayavelu has quit IRC | 09:22 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | 09:25 |
*** zhurong has quit IRC | 09:25 | |
kashyap | mriedem: About the question you asked me in the scroll, I asked the libvirt upstream folks, and this was the response: | 09:27 |
maciejjozefczyk | bauzas: So maybe some if logic from scheduler side? If the object is in version X, and we know that its from Rocky, then we'll not do thing from https://review.openstack.org/#/c/532924/6/nova/objects/compute_node.py L185, | 09:28 |
kashyap | mriedem: That "note" you pointed out from the OpenStack docs was never the case, so that statement wasn't ever true | 09:28 |
maciejjozefczyk | bauzas: I'm looking for better solution but I havent found any | 09:28 |
kashyap | mriedem: One can use `virsh nodedev-dumpxml` on the parent device and it will return a dump of the 'sysfs' attributes. | 09:28 |
bauzas | maciejjozefczyk: one possible outcome could be to transform in obj_make_compatible the primitive we got from the compute | 09:29 |
bauzas | maciejjozefczyk: ie. say that if the primitive is having a target version older than me, and if ratio is 0.0, set the value to what we want | 09:30 |
maciejjozefczyk | bauzas: Yes, obj_make_compatible is right place for that | 09:32 |
*** zhurong has joined #openstack-nova | 09:33 | |
bauzas | maciejjozefczyk: so, when calling _from_db_object, we would get normalized values whatever the compute service version is | 09:34 |
maciejjozefczyk | bauzas: So the commit messag needs to be changed, to show that we introduce default values | 09:35 |
maciejjozefczyk | bauzas: and what about min config values? | 09:36 |
*** yamahata has quit IRC | 09:36 | |
maciejjozefczyk | bauzas: do you agree that in rocky the min should be 0.1 at least? | 09:36 |
bauzas | 0.0 can be a trick for operatoes | 09:37 |
bauzas | like, say in my inventory, I don't want to count that resource for that specific compute | 09:37 |
bauzas | oh wait | 09:37 |
bauzas | it's the contrary | 09:37 |
bauzas | if I don't care about that resource class, then just have a ratio equal to 99999.99 | 09:38 |
bauzas | but if I want to stop allocating that compute, I could use a ratio of 0.0 | 09:38 |
bauzas | so I dunno | 09:38 |
*** stakeda has quit IRC | 09:38 | |
bauzas | from a logical perspective, 0.1 makes sense | 09:38 |
lyarwood | Roamer`: re https://review.openstack.org/#/c/539742/ - looks like we are failing to cherry pick the nova patch in the StorPool job - http://logs.ci-openstack.storpool.com/42/539742/1/check/dsvm-tempest-storpool/f0a700e/console.html#_2018-02-01_06_49_47_306 | 09:39 |
bauzas | but from an operator perspective, I could say 'if I have a flavor that requires some disk but I want to not allocate that host if disk, then put it to 0.0' | 09:39 |
lyarwood | Roamer`: I'll try again using the change id but would you be able to manually test the fix from https://review.openstack.org/#/c/539739/ | 09:39 |
bauzas | I understand that can be sneaky | 09:39 |
*** trinaths has quit IRC | 09:40 | |
maciejjozefczyk | bauzas: from placement side it makes now calculations ratio*resources=limit_on_host (something like that) | 09:40 |
maciejjozefczyk | so if we gonna place there 0 - you know what happend :) | 09:40 |
maciejjozefczyk | so maybe the logic should be also changed from placement side to not raise capacity check exception | 09:41 |
bauzas | yeah I know, but maybe some people would *want* to get capacity exceptions | 09:42 |
bauzas | I'm not kidding | 09:42 |
*** Tom-Tom has quit IRC | 09:42 | |
hrw | http://marcin.juszkiewicz.com.pl/2018/02/01/everyone-loves-90s-pc-hardware/ | 09:42 |
*** Tom-Tom has joined #openstack-nova | 09:42 | |
openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | 09:43 |
openstackgerrit | Ameed Ashour proposed openstack/nova master: change instance_system_metadata column type https://review.openstack.org/526900 | 09:44 |
maciejjozefczyk | bauzas: For that 'I dont what to allocate on that compute' as operator I would just use host-disable | 09:45 |
maciejjozefczyk | rather than some trics around allocation_ratios | 09:45 |
bauzas | I agree | 09:45 |
bauzas | but host disabling is a whole thing for any kind of resource | 09:45 |
bauzas | in the past, we had CoreFilter, RAMFilter and DiskFilter | 09:46 |
bauzas | where you could disallow a host based on some sneaky crazy calculation | 09:46 |
maciejjozefczyk | bauzas: right | 09:46 |
bauzas | now, this is placement for the god sake | 09:46 |
bauzas | so, some people could argue that they would want to just exclude a specific host if and only if some flavor is asking for some resource | 09:47 |
bauzas | tricking the ratio for that resource class is one way of achieving that | 09:47 |
*** aloga has quit IRC | 09:47 | |
*** Tom-Tom has quit IRC | 09:47 | |
bauzas | I know that asking 0 vCPUs is crazy | 09:48 |
bauzas | like asking for 0 GB of RAM | 09:48 |
bauzas | but asking for a diskless instance can be understandable | 09:48 |
maciejjozefczyk | bauzas: you're right, I agree | 09:48 |
*** josecastroleon has quit IRC | 09:48 | |
bauzas | tbh, if I was you, I'd decouple the normalization thing from the minimum ratio modification | 09:49 |
Roamer` | lyarwood, I actually restarted the job as soon as it managed to fail, it has been running some Tempest tests, it should be done in less than an hour now, then we'll know; the failing test is almost the last one to run :/ | 09:49 |
maciejjozefczyk | bauzas: eg. this host is for only 'volume' vms | 09:49 |
*** josecastroleon has joined #openstack-nova | 09:49 | |
Roamer` | lyarwood, and yeah, I did some internal clean-up of the Jenkins job to make it fail much earlier if it fails to cherry-pick the changes (and review.o.o has been a bit flaky yesterday and today, at least from that Hetzner-based host) | 09:50 |
bauzas | maciejjozefczyk: well, I was thinking more about the long-standing issue we have with calculating disk spaces, in particular for BFV instances | 09:50 |
bauzas | sometimes, you hack like how you can | 09:50 |
bauzas | once we have the full monty with shared resource providers, that problem will be solved | 09:51 |
bauzas | but that's like 4 cycles we're working on that | 09:51 |
maciejjozefczyk | ok, to summarize about that change: do backport compatibility in obj_make_compatible() like we discussed, remove minimum from config files, then we gonna think twice about it, agree? | 09:54 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: refactors and cleans up test_rbd.py https://review.openstack.org/538022 | 09:54 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | 09:54 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 09:54 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 09:54 |
*** ispp has quit IRC | 09:54 | |
kashyap | mriedem: We should just rewrite it: saying that "libvirt supports enumerating the information about the supported types for a given device via `virsh nodedev-dumpxml` (or the equivalent API)" | 09:54 |
bauzas | maciejjozefczyk: I'd say just touch the default value in the conf opt, that's it | 09:56 |
bauzas | leave as it what is is now | 09:56 |
bauzas | (speaking of the min) | 09:56 |
bauzas | maciejjozefczyk: for the obj_make_compatible() hack, I think you need to check the object versions | 09:57 |
bauzas | and see if you need a new one | 09:57 |
bauzas | which could be tricky if that's only for signaling | 09:57 |
openstackgerrit | Ameed Ashour proposed openstack/nova stable/ocata: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539878 | 09:57 |
* bauzas git blames | 09:57 | |
*** priteau has joined #openstack-nova | 09:57 | |
bauzas | maciejjozefczyk: hah, you're doomed | 09:58 |
maciejjozefczyk | bauzas: :) | 09:59 |
bauzas | ComputeNode version 1.17 (adding the mapped field) was merged in Pike | 09:59 |
bauzas | https://github.com/openstack/nova/commit/0ce4dff4 | 09:59 |
bauzas | so you can't rely on it for checking the release version | 09:59 |
*** markvoelker has joined #openstack-nova | 10:00 | |
maciejjozefczyk | bauzas: damn..., anyway going to meeting | 10:01 |
bauzas | maciejjozefczyk: let's punt that discussion until this afternoon | 10:02 |
bauzas | I need to do other things and other people could double-check my idea | 10:02 |
openstackgerrit | Merged openstack/nova master: trivial: Fix typos in release notes https://review.openstack.org/539490 | 10:02 |
*** ispp has joined #openstack-nova | 10:04 | |
openstackgerrit | Ameed Ashour proposed openstack/nova stable/pike: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539880 | 10:04 |
*** john51_ has joined #openstack-nova | 10:07 | |
*** john51 has quit IRC | 10:09 | |
*** salv-orlando has quit IRC | 10:11 | |
*** salv-orlando has joined #openstack-nova | 10:11 | |
*** john51_ has quit IRC | 10:13 | |
*** abhishekk has quit IRC | 10:13 | |
*** john51 has joined #openstack-nova | 10:13 | |
*** alexchadin has joined #openstack-nova | 10:14 | |
Roamer` | lyarwood, melwitt, mriedem's quick fix did help - our CI successfully ran on an os-brick change: http://logs.ci-openstack.storpool.com/73/539773/1/check/dsvm-tempest-storpool/0ca4a8e/console.html Once it's done a couple more runs, I'll drop a note in the bug and on the change itself. Thanks a lot for the analysis and the quick fix, and sorry I had to go to bed and couldn't run it last night! | 10:15 |
openstackgerrit | Merged openstack/os-traits master: Update Usage information https://review.openstack.org/539761 | 10:15 |
*** salv-orlando has quit IRC | 10:16 | |
*** belmoreira has quit IRC | 10:23 | |
*** gongysh has quit IRC | 10:25 | |
*** damien_r has joined #openstack-nova | 10:26 | |
*** belmoreira has joined #openstack-nova | 10:26 | |
*** jchhatbar has joined #openstack-nova | 10:28 | |
*** AlexeyAbashkin has quit IRC | 10:28 | |
*** janki has quit IRC | 10:29 | |
*** damien_r has quit IRC | 10:29 | |
*** gongysh has joined #openstack-nova | 10:30 | |
*** priteau has quit IRC | 10:30 | |
*** sridharg has quit IRC | 10:30 | |
lyarwood | Roamer`: cool, np, did you manually pull the change in somewhere? | 10:33 |
*** markvoelker has quit IRC | 10:33 | |
*** zhurong has quit IRC | 10:34 | |
*** jchhatbar is now known as janki | 10:34 | |
*** gongysh has quit IRC | 10:35 | |
Roamer` | lyarwood, actually yes, I should've mentioned last night that our CI system is kind of used to cherry-picking unmerged patches from Gerrit when it needs to | 10:35 |
Roamer` | lyarwood, sorry I put it a bit too obscurely: yes, the Jenkins job cherry-picks a manually supplied list of patches before running devstack | 10:36 |
lyarwood | Roamer`: kk np, can you post an example passing run in the nova fix? | 10:36 |
*** damien_r has joined #openstack-nova | 10:36 | |
*** tuanla____ has quit IRC | 10:37 | |
Roamer` | lyarwood, yes, I will, I just wonder whether it wouldn't be better to give it one more chance, wait for an hour or so for another run... although maybe not, I guess the fix ix good enough for us at least, so I'll do it right now | 10:37 |
lyarwood | Roamer`: yeah I don't mind waiting, a direct link to a passing run or a generic link showing multiple job results would be good either way to prove that this is working :) | 10:38 |
maciejjozefczyk | bauzas: ok | 10:39 |
*** chyka has joined #openstack-nova | 10:39 | |
bauzas | maciejjozefczyk: I need to go but see my last comment | 10:40 |
bauzas | maciejjozefczyk: maybe all of this is unnecessary | 10:40 |
bauzas | just change the default and keep the backwards-compat code | 10:40 |
maciejjozefczyk | bauzas: jest checking | 10:40 |
bauzas | with the 0.0 thing | 10:40 |
maciejjozefczyk | bauzas: okey | 10:40 |
bauzas | so later in Rocky, we can just kill the whole thing | 10:40 |
bauzas | bbiab | 10:41 |
*** sambetts|afk is now known as sambetts | 10:41 | |
*** damien_r has quit IRC | 10:41 | |
maciejjozefczyk | bauzas: yes, that could be easier to do in next release | 10:41 |
*** Guest3579 has quit IRC | 10:43 | |
tetsuro | stephen: are you around? | 10:44 |
*** yassine has joined #openstack-nova | 10:44 | |
*** yassine is now known as Guest99280 | 10:44 | |
*** chyka has quit IRC | 10:44 | |
tetsuro | stephen: sorry, nothing. | 10:45 |
stephenfin | tetsuro: Looking for me? | 10:46 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Test LM with encrypted volumes https://review.openstack.org/536350 | 10:47 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest https://review.openstack.org/528104 | 10:48 |
*** trinaths has joined #openstack-nova | 10:49 | |
*** damien_r has joined #openstack-nova | 10:50 | |
*** AlexeyAbashkin has joined #openstack-nova | 10:53 | |
tetsuro | if emulator_threads_isolated: if object_numa_cell.cpuset_reserved: emupcpus.extend(object_numa_cell.cpuset_reserved) does work. | 10:53 |
tetsuro | if emulator_threads_isolated and object_numa_cell.cpuset_reserved: emupcpus.extend(object_numa_cell.cpuset_reserved) doesn’t work. | 10:53 |
*** damien_r has quit IRC | 10:53 | |
tetsuro | stephen: This is okay, but I don’t understand why… python 101? | 10:54 |
*** jtwatson64 has joined #openstack-nova | 10:55 | |
*** lucas-afk is now known as lucasagomes | 10:56 | |
*** abhishekk has joined #openstack-nova | 10:56 | |
*** annp has quit IRC | 10:57 | |
hrw | how to run one test from all nova tests? | 10:59 |
*** kwathore has quit IRC | 10:59 | |
*** priteau has joined #openstack-nova | 11:00 | |
*** kwathore has joined #openstack-nova | 11:00 | |
stephenfin | tetsuro: That's how oslo.versionedobjects work, unfortunately. If you don't set an attribute to _something_, then it's totally unset | 11:00 |
Spaz-Work | hrw: tox -e py27 -- nova.tests.unit.path.to.module.then.func | 11:00 |
hrw | thanks Spaz-Work | 11:00 |
stephenfin | tetsuro: 'if emulator_threads_isolated and 'cpuset_reserved' in object_numa_cell and object_numa_cell.cpuset_reserved' would work | 11:00 |
stephenfin | but that's getting a little ridiculous :) Hmm, lemme have another look at that | 11:01 |
hrw | "tox -e py27 -- nova.tests.unit.virt.libvirt.test_get_guest_config_aarch64" then d: | 11:01 |
*** damien_r has joined #openstack-nova | 11:01 | |
Spaz-Work | That's correct. Remember to include Classes | 11:01 |
*** vivsoni_ has joined #openstack-nova | 11:02 | |
*** owalsh_afk is now known as owalsh | 11:03 | |
stephenfin | Yeah, you need to include the class, so 'tox -e py27 nova.tests.unit.virt.libvirt.LibvirtConnTestCase.test_get_guest_config_aarch64' | 11:03 |
*** damien_r has quit IRC | 11:03 | |
*** priteau has quit IRC | 11:04 | |
stephenfin | pytest lets you use filenames. Not testr, unfortunately | 11:04 |
hrw | nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_get_guest_config_aarch64 | 11:04 |
stephenfin | Whoops, yeah :) | 11:04 |
*** vivsoni has quit IRC | 11:04 | |
hrw | now it fails but atleast in proper test ;D | 11:04 |
*** priteau has joined #openstack-nova | 11:04 | |
*** jmlowe_ has joined #openstack-nova | 11:06 | |
*** damien_r has joined #openstack-nova | 11:07 | |
hrw | passed. but I do not like the code :D | 11:07 |
hrw | test_get_guest_config*ppc* tests are not good ones to learn from | 11:07 |
*** alaski_ has joined #openstack-nova | 11:08 | |
*** mtreinish_ has joined #openstack-nova | 11:08 | |
*** damien_r has quit IRC | 11:08 | |
tetsuro | stephenfin: Okay thanks… and I think we can just assume 'cpuset_reserved' is in object_numa_cell when users specify emulator_threads_isolated and tha code path reaches here? | 11:08 |
*** rabel_ has joined #openstack-nova | 11:08 | |
stephenfin | tetsuro: You mean we can assume that _if_ we use your patch, right? | 11:09 |
*** priteau has quit IRC | 11:09 | |
stephenfin | Because at the moment, we're assuming that it's present even if it's not guaranteed to be | 11:09 |
stephenfin | e.g. in the multiple instance NUMA cell case | 11:09 |
*** jmlowe has quit IRC | 11:10 | |
*** damien_r has joined #openstack-nova | 11:10 | |
*** mtreinish has quit IRC | 11:11 | |
*** alaski has quit IRC | 11:11 | |
*** ameade has quit IRC | 11:11 | |
*** sdake has quit IRC | 11:11 | |
*** DuncanT has quit IRC | 11:11 | |
*** rabel has quit IRC | 11:11 | |
*** ianw has quit IRC | 11:11 | |
*** TheJulia has quit IRC | 11:11 | |
*** ildikov has quit IRC | 11:11 | |
*** Dave has quit IRC | 11:11 | |
*** mtreinish_ is now known as mtreinish | 11:11 | |
*** damien_r has quit IRC | 11:11 | |
*** Dave__ has joined #openstack-nova | 11:11 | |
*** sdake has joined #openstack-nova | 11:11 | |
*** sdake has quit IRC | 11:11 | |
*** sdake has joined #openstack-nova | 11:11 | |
*** ameade has joined #openstack-nova | 11:12 | |
*** salv-orlando has joined #openstack-nova | 11:12 | |
*** homeski has quit IRC | 11:12 | |
*** ildikov has joined #openstack-nova | 11:12 | |
*** DuncanT has joined #openstack-nova | 11:12 | |
*** priteau has joined #openstack-nova | 11:12 | |
*** ianw has joined #openstack-nova | 11:12 | |
*** homeski has joined #openstack-nova | 11:12 | |
*** TheJulia has joined #openstack-nova | 11:12 | |
*** damien_r has joined #openstack-nova | 11:13 | |
*** sdague has joined #openstack-nova | 11:15 | |
*** salv-orlando has quit IRC | 11:17 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | 11:17 |
hrw | stephenfin, mriedem, sahid: can you review ^^? test code is included | 11:17 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'move-nova-cmds-to-cliff' spec https://review.openstack.org/433603 | 11:18 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: trivial: Resolve Python 3 issues https://review.openstack.org/539907 | 11:18 |
hrw | I think that this version is as simple as it can be | 11:24 |
*** gcb has quit IRC | 11:25 | |
*** gcb has joined #openstack-nova | 11:25 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: add check before adding cpus to cpuset_reserved https://review.openstack.org/539865 | 11:26 |
tetsuro | stephenfun: Hm? getting lost… Anyway I’ve updated the patch. Let’s talk here^ | 11:28 |
*** abhishekk has quit IRC | 11:30 | |
*** markvoelker has joined #openstack-nova | 11:30 | |
openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: add check before adding cpus to cpuset_reserved https://review.openstack.org/539865 | 11:30 |
*** tiendc has quit IRC | 11:30 | |
tetsuro | Today, I’m going home… good night. | 11:31 |
*** tetsuro has left #openstack-nova | 11:32 | |
stephenfin | o/ | 11:32 |
*** namnh_ has quit IRC | 11:32 | |
*** Dave__ is now known as Dave | 11:32 | |
*** AlexeyAbashkin has quit IRC | 11:33 | |
*** mvenesio has joined #openstack-nova | 11:33 | |
openstackgerrit | Hironori Shiina proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487 | 11:33 |
*** AlexeyAbashkin has joined #openstack-nova | 11:33 | |
*** salv-orlando has joined #openstack-nova | 11:38 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | 11:38 |
*** Eran_Kuris has joined #openstack-nova | 11:43 | |
*** sree has joined #openstack-nova | 11:45 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 11:46 |
*** alexchadin has quit IRC | 11:50 | |
*** alexchadin has joined #openstack-nova | 11:51 | |
*** amoralej is now known as amoralej|off | 11:52 | |
*** jtwatson64 has quit IRC | 11:54 | |
yikun | https://review.openstack.org/#/c/522161/ | 11:56 |
yikun | ^ Creating a VM with a non-ASCII name(such as chinese name) results in an error. | 11:56 |
yikun | This patch is are submited by @jiangpf, but it seems stuck beacuse the testcase problem. | 11:56 |
yikun | I try to complete it by mocking a emulate method, but I'm not sure this way is okay or not | 11:56 |
*** aloga has joined #openstack-nova | 11:57 | |
yikun | so, if anyone have time, could take a look on it. | 11:57 |
stephenfin | yikun: Sure, I'll take a look after lunch | 11:58 |
yikun | stephenfin, thanks :) | 11:59 |
*** jpena is now known as jpena|lunch | 12:00 | |
*** tetsuro has joined #openstack-nova | 12:01 | |
*** markvoelker has quit IRC | 12:04 | |
*** ttsiouts has quit IRC | 12:12 | |
*** ankkumar has quit IRC | 12:12 | |
*** josecastroleon has quit IRC | 12:12 | |
*** ttsiouts has joined #openstack-nova | 12:12 | |
*** trinaths has quit IRC | 12:13 | |
*** dave-mccowan has joined #openstack-nova | 12:14 | |
*** josecastroleon has joined #openstack-nova | 12:14 | |
*** cdent has joined #openstack-nova | 12:18 | |
*** dtantsur|afk is now known as dtantsur | 12:18 | |
*** tetsuro has left #openstack-nova | 12:20 | |
*** pchavva has joined #openstack-nova | 12:21 | |
*** mvk has quit IRC | 12:22 | |
*** salv-orlando has quit IRC | 12:25 | |
*** salv-orlando has joined #openstack-nova | 12:25 | |
ameeda | please check this out https://review.openstack.org/#/c/526900/ . please notice the last comment | 12:27 |
*** links has quit IRC | 12:28 | |
*** salv-orlando has quit IRC | 12:30 | |
*** masahisa has quit IRC | 12:32 | |
*** damien_r has quit IRC | 12:32 | |
*** damien_r has joined #openstack-nova | 12:32 | |
*** robcresswell has left #openstack-nova | 12:35 | |
*** AlexeyAbashkin has quit IRC | 12:35 | |
*** links has joined #openstack-nova | 12:39 | |
*** Eran_Kuris has quit IRC | 12:42 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 12:48 |
*** pchavva has quit IRC | 12:50 | |
*** sridharg has joined #openstack-nova | 12:53 | |
*** jpena|lunch is now known as jpena|off | 12:56 | |
*** gszasz has quit IRC | 12:59 | |
*** markvoelker has joined #openstack-nova | 13:01 | |
*** gszasz has joined #openstack-nova | 13:01 | |
*** links has quit IRC | 13:03 | |
*** mvk has joined #openstack-nova | 13:04 | |
*** zhaochao has quit IRC | 13:05 | |
*** zhaochao has joined #openstack-nova | 13:06 | |
*** weshay|ruck is now known as weshay | 13:06 | |
*** jpena|off is now known as jpena | 13:07 | |
*** sree has quit IRC | 13:08 | |
*** sree has joined #openstack-nova | 13:09 | |
*** alexchadin has quit IRC | 13:12 | |
*** rmcall has joined #openstack-nova | 13:12 | |
*** AlexeyAbashkin has joined #openstack-nova | 13:13 | |
*** sree has quit IRC | 13:14 | |
*** edmondsw has joined #openstack-nova | 13:15 | |
*** hemna_ has joined #openstack-nova | 13:15 | |
*** yangyapeng has joined #openstack-nova | 13:19 | |
*** alexchadin has joined #openstack-nova | 13:21 | |
*** salv-orlando has joined #openstack-nova | 13:26 | |
*** liverpooler has joined #openstack-nova | 13:26 | |
*** psachin has quit IRC | 13:29 | |
*** salv-orlando has quit IRC | 13:30 | |
*** markvoelker has quit IRC | 13:33 | |
*** markvoelker has joined #openstack-nova | 13:33 | |
*** dklyle has quit IRC | 13:34 | |
*** david-lyle has joined #openstack-nova | 13:34 | |
*** gszasz has quit IRC | 13:38 | |
*** janki has quit IRC | 13:39 | |
*** david-lyle has quit IRC | 13:40 | |
*** ratailor has quit IRC | 13:40 | |
*** yikun_ has joined #openstack-nova | 13:41 | |
*** vladikr has joined #openstack-nova | 13:41 | |
bhujay | hi all with suse compute node can we use rbd as backend ? although pike release doc says no , i was checking the ceph-ansible upsteram has some commits related to suse . Hence asking this | 13:46 |
hrw | you know what is worst in code reviews? | 13:46 |
hrw | all those moments when you adapt code to everyone's comments to get good acceptable version and then someone arrive and asks for another changes ;d | 13:46 |
*** hemna_ has quit IRC | 13:47 | |
bhujay | sorry , asked in wrong channel | 13:47 |
bauzas | hrw: is that a problem ? I don't think so | 13:48 |
bauzas | code reviews FTW | 13:48 |
hrw | bauzas: it is not. just amusing sometimes | 13:48 |
Spaz-Work | It's definately humbling.. that's the word i'd choose | 13:49 |
hrw | stephenfin: replied to your comments | 13:49 |
hrw | Spaz-Work: I would not | 13:50 |
*** gszasz has joined #openstack-nova | 13:50 | |
*** Spaz-Work has quit IRC | 13:51 | |
efried | edleafe: yt? | 13:53 |
*** yamamoto has quit IRC | 13:55 | |
*** rmcall has quit IRC | 13:55 | |
*** abhishekk has joined #openstack-nova | 13:57 | |
*** crushil has joined #openstack-nova | 13:59 | |
mriedem | melwitt: i guess https://review.openstack.org/#/c/539739/ fixes the storpool encrypted luks issue | 13:59 |
lyarwood | https://review.openstack.org/#/c/538103/ - any cores able to review this, logging required to move https://bugs.launchpad.net/neutron/+bug/1744361 forward | 13:59 |
openstack | Launchpad bug 1744361 in neutron "test_server_security_groups failed to reboot with "Domain not found: no domain with matching uuid" because of missing vif event from linuxbridge agent" [Undecided,Confirmed] | 13:59 |
lyarwood | mriedem: morning, yeah appears it does, thanks again :) | 13:59 |
gibi | lyarwood: looking | 14:00 |
hrw | mriedem: good morning | 14:00 |
*** hemna_ has joined #openstack-nova | 14:00 | |
*** rmcall has joined #openstack-nova | 14:02 | |
openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: evacuate with no compute https://review.openstack.org/498482 | 14:02 |
ameeda | can you please check this out https://review.openstack.org/#/c/526900/ . please notice the last comment | 14:02 |
*** alexchadin has quit IRC | 14:02 | |
*** hshiina is now known as hshiina|afk | 14:02 | |
hrw | mriedem: 7th version of https://review.openstack.org/#/c/538003/ is closer to perfection than yesterday ones were. please take a look once you have time | 14:03 |
edleafe | efried: ?? | 14:03 |
efried | edleafe: Was wondering if you would be willing to jump on a short call this afternoon to give an overview of the alt hosts feature. | 14:04 |
Roamer` | mriedem, good morning, and thanks and sorry again for bailing out last night three minutes before you got the patch ready | 14:04 |
edleafe | efried: depends on the time. Meetings and such, y'know | 14:05 |
cdent | edleafe, efried: would something written be better (or at least a written summary of the call) so that other people can benefit? | 14:05 |
edleafe | cdent: sure. | 14:05 |
edleafe | Anything in particular to cover? | 14:05 |
edleafe | Or just a general overview | 14:05 |
ameeda | mriedem: good morning :) what do you think about this bug https://bugs.launchpad.net/nova/+bug/1489304 ? | 14:06 |
openstack | Launchpad bug 1489304 in OpenStack Compute (nova) "Lack of volume status checks when detaching volume in rebuild." [Medium,Confirmed] | 14:06 |
*** moshele has quit IRC | 14:06 | |
efried | edleafe: Product building on nova, wants to assess the impact of the feature, if/how it can use it, etc. | 14:06 |
edleafe | efried: cdent: OK, maybe a blog post on a general overview of alt hosts would be in order | 14:09 |
efried | Sounds good to me. | 14:10 |
*** jhesketh has quit IRC | 14:12 | |
*** jhesketh has joined #openstack-nova | 14:13 | |
* mriedem is busy | 14:14 | |
*** yamahata has joined #openstack-nova | 14:16 | |
*** yamamoto has joined #openstack-nova | 14:17 | |
mriedem | stephenfin: i'm not sure it's good to update release notes for ones that have already been tagged https://review.openstack.org/#/c/539490/ | 14:22 |
stephenfin | mriedem: I built it locally and it displayed as expected | 14:22 |
stephenfin | i.e. no "new" release notes | 14:23 |
mriedem | ok, those used to get duplicated | 14:23 |
stephenfin | Yeah, I think it's branches that still cause issues | 14:23 |
stephenfin | although even that may be fixed now | 14:23 |
*** beagles is now known as beagles_mtg | 14:27 | |
*** alex_xu has quit IRC | 14:27 | |
*** slaweq has quit IRC | 14:27 | |
*** slaweq has joined #openstack-nova | 14:28 | |
*** ccamacho1 has joined #openstack-nova | 14:29 | |
bauzas | mriedem: AFAIR, you can do that -ie. relnotes that have been tagged for a milestone | 14:29 |
bauzas | you can even modify an existing relnote from a stable branch, which was something not working for Newton :p | 14:30 |
*** alex_xu has joined #openstack-nova | 14:30 | |
bauzas | (if you remember the prelude issue we had) | 14:30 |
*** ccamacho has quit IRC | 14:31 | |
*** lucasagomes is now known as lucas-hungry | 14:32 | |
*** slaweq has quit IRC | 14:33 | |
*** hemna_ has quit IRC | 14:33 | |
*** awaugama has joined #openstack-nova | 14:34 | |
edleafe | gibi: Responded to your comments on https://review.openstack.org/#/c/539254/ | 14:35 |
*** mriedem is now known as mriedem_afk | 14:35 | |
*** hshiina|afk has quit IRC | 14:35 | |
*** esberglu has joined #openstack-nova | 14:35 | |
*** swamireddy has quit IRC | 14:37 | |
bauzas | artom: mriedem_afk: oh man, just noticed a long chat on https://review.openstack.org/#/c/539266 | 14:37 |
*** eharney has joined #openstack-nova | 14:37 | |
*** ccamacho1 has quit IRC | 14:37 | |
bauzas | I need to digest all the comments for working on a new rev | 14:37 |
*** ccamacho has joined #openstack-nova | 14:37 | |
*** bhujay has quit IRC | 14:40 | |
*** amodi has joined #openstack-nova | 14:41 | |
gibi | edleafe: thanks. you are right, let's fix just the real warnings first. | 14:42 |
gibi | edleafe: I guess the same reasoning holds for https://review.openstack.org/#/c/531479 as well | 14:42 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova master: test_compute_mgr: fix couple of unit tests https://review.openstack.org/539973 | 14:42 |
edleafe | gibi: yeah, I just saw the comments on the other one first | 14:42 |
edleafe | gibi: should I file a TODO bug? | 14:42 |
*** mvenesio has quit IRC | 14:43 | |
edleafe | with the caveat that it won't be done until Rocky? | 14:43 |
gibi | edleafe: yeah, why not. It can be a low hanging fruit for some newcommer | 14:43 |
*** efried has quit IRC | 14:43 | |
*** efried has joined #openstack-nova | 14:43 | |
edleafe | ok, will do | 14:43 |
*** sree has joined #openstack-nova | 14:44 | |
gibi | edleafe: thanks. I +Wd both patches | 14:45 |
edleafe | gibi: cool. Writing the bug now | 14:46 |
*** hongbin has joined #openstack-nova | 14:46 | |
*** itlinux has joined #openstack-nova | 14:46 | |
*** r-daneel has joined #openstack-nova | 14:47 | |
*** nikhil has joined #openstack-nova | 14:47 | |
artom | bauzas, most were just awkward English nits | 14:47 |
bauzas | 60 comments, man | 14:48 |
bauzas | my whole Gerrit web page is needing a long scroll :p | 14:48 |
*** mgoddard_ has joined #openstack-nova | 14:49 | |
*** AlexeyAbashkin has quit IRC | 14:50 | |
*** pchavva has joined #openstack-nova | 14:50 | |
*** AlexeyAbashkin has joined #openstack-nova | 14:51 | |
*** slaweq has joined #openstack-nova | 14:53 | |
*** itlinux has quit IRC | 14:55 | |
*** mlavalle has joined #openstack-nova | 14:55 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have USB Host controller for USB tablet https://review.openstack.org/538003 | 14:56 |
*** hemna_ has joined #openstack-nova | 14:56 | |
hrw | pep8 in comments this time | 14:56 |
mriedem_afk | artom: i hope you're just being extra harsh because it's me and sylvain on https://review.openstack.org/#/c/539266 | 14:58 |
*** mriedem_afk is now known as mriedem | 14:58 | |
mriedem | at some point, any docs is better than perfect docs | 14:58 |
*** itlinux has joined #openstack-nova | 14:59 | |
stephenfin | mriedem: I respectfully ``disagree`` :) | 14:59 |
*** abhishekk has quit IRC | 15:00 | |
* bauzas just needs to take a bit of time and look at all the comments, that's it :) | 15:00 | |
mriedem | stephenfin: heh you would | 15:00 |
bauzas | if I can pass a new rev, no problem | 15:00 |
stephenfin | bauzas: Nice doc. Fancy writing up the real-time doc that I've been meaning to get around to for ages, while you're at it? | 15:00 |
*** lei-zh has joined #openstack-nova | 15:00 | |
stephenfin | ;) | 15:00 |
kashyap | mriedem: That's a good principle: "for documentation, _anything_ (that is not misinfo) is better than nothing" | 15:00 |
*** itlinux has quit IRC | 15:00 | |
kashyap | But I'm with stephenfin on writing | 15:00 |
mriedem | https://docs.openstack.org/nova/latest/contributor/documentation.html#review-guidelines | 15:01 |
*** moshele has joined #openstack-nova | 15:01 | |
kashyap | mriedem: Aside: I hope you saw my comments in the scrollback on your question about: http://logs.openstack.org/66/539266/2/check/build-openstack-sphinx-docs/f7a1712/html/admin/virtual-gpu.html#how-to-know-a-gpu-type | 15:01 |
kashyap | ? | 15:01 |
bauzas | mriedem: stephenfin: artom: honestly, I'm fine with comments, given I'm not a English expert | 15:02 |
bauzas | it's just I don't want to have that change merged after Queens | 15:02 |
mriedem | kashyap: i just did now - i had just removed the part of the docs about the libvirt api to find types | 15:02 |
kashyap | bauzas: Yeah, FWIW, I also welcome all nit-picks from native speakers and take no offense. | 15:02 |
kashyap | mriedem: Cool. The official API is: virNodeDeviceGetXMLDesc() -- have to look up the Python binding name. | 15:03 |
kashyap | (To use in place of that command in the doc.) | 15:03 |
*** itlinux has joined #openstack-nova | 15:03 | |
mriedem | kashyap: so i guess "Note that the current libvirt API doesn’t provide a way to access that information." was wrong | 15:04 |
kashyap | Yes | 15:04 |
* kashyap bbiab; need to bike home | 15:04 | |
edleafe | gibi: Done: https://bugs.launchpad.net/nova/+bug/1746747 | 15:04 |
openstack | Launchpad bug 1746747 in OpenStack Compute (nova) "Clean up UUID usage in tests" [Low,Confirmed] | 15:04 |
mriedem | bauzas: maybe you want to see if "virsh nodedev-dumpxml" works for you | 15:05 |
edleafe | gibi: would be interested in your opinion on a related patch: https://review.openstack.org/#/c/539323/ | 15:05 |
*** Sandy619 has joined #openstack-nova | 15:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: mark the max microversions for queens https://review.openstack.org/539978 | 15:06 |
Spazmotic | Was hoping to get more code work done before Korea but looks like that's not going to happen | 15:07 |
gibi | edleafe: thanks for the bug | 15:07 |
Spazmotic | Current commits will have to sit for a couple of weeks | 15:07 |
gibi | edleafe: opened the related patch | 15:07 |
*** mdnadeem has quit IRC | 15:08 | |
*** tidwellr has joined #openstack-nova | 15:10 | |
artom | bauzas, mriedem, English is easier to wrap my head around than code, so nits come faster and easier | 15:12 |
artom | For what it's worth, group projects back in uni were torture for me | 15:12 |
bauzas | artom: no worries ;) | 15:12 |
artom | I had to force myself not to rewrite others prose | 15:12 |
*** sree has quit IRC | 15:13 | |
artom | In my defense, some were terrible writers | 15:13 |
bauzas | once French language will rule the world, I'll bite all of you, folks | 15:13 |
artom | Sauf que je parle Français aussi | 15:13 |
artom | Donc tu vas juste mordre mriedem | 15:13 |
bauzas | artom: attention, je serai intransigeant sur la grammaire | 15:13 |
artom | Tu va me lésser aucune chanse? | 15:14 |
*** Sandy619 has quit IRC | 15:14 | |
bauzas | quoted for posterity | 15:15 |
mriedem | hrw: comments inline | 15:15 |
mriedem | hrw: there is a libvirt version thing you have to deal with | 15:15 |
mriedem | stephenfin: something to think about for rocky, but we should look at bumping minimum required libvirt/qemu again, haven't done that since ocata i think | 15:17 |
hrw | 1.2.9? sounds like version from year when i440fx got created | 15:17 |
stephenfin | Good call. I think kashyap did that investigation last time, but I can pick up the mantle if he doesn't want to | 15:17 |
stephenfin | I'll add it to the PTG agenda as a reminder | 15:17 |
mriedem | i just did | 15:18 |
mriedem | L178 | 15:18 |
stephenfin | Heh, good stuff :) | 15:18 |
mriedem | i guess the last bump was pike https://review.openstack.org/#/c/432700/ | 15:18 |
*** lpetrut__ has quit IRC | 15:18 | |
hrw | mriedem: I checked. ps2mouse (kernel driver) can be compiled on other archs. is it useful? no idea. | 15:19 |
*** zhaochao has quit IRC | 15:19 | |
*** Sandy619 has joined #openstack-nova | 15:19 | |
hrw | mriedem: the idea of 'lets just add usb host' was also based on sahid's comment. | 15:20 |
mriedem | hrw: the only time that _get_guest_pointer_model returns anything is if we use usbtablet | 15:20 |
mriedem | so seems if you just moved that into the conditional block "if pointer_model:" it would be good enough | 15:20 |
hrw | 10:03 <sahid> but pointer model can have different value yes | 15:20 |
hrw | mriedem: and you already said to me that sahid dealt with pointer_model in past so I assume that he knows what he is saying | 15:21 |
*** sridharg has quit IRC | 15:22 | |
mriedem | i only see sahid's comments in the patch, not irc | 15:22 |
mriedem | so https://review.openstack.org/#/c/538003/2/nova/virt/libvirt/driver.py@5036 | 15:22 |
*** lyan has joined #openstack-nova | 15:22 | |
hrw | mriedem: and that's what I did in 5th patch | 15:23 |
*** sree has joined #openstack-nova | 15:24 | |
Spazmotic | Hehe my commit went from working on someone elses with large overhaul.. to my possibility of a XCP version check.. to now just a single line to eat an exception. | 15:24 |
Spazmotic | The power of code review. | 15:24 |
*** Sandy619 has quit IRC | 15:24 | |
*** artom has quit IRC | 15:25 | |
*** salv-orlando has joined #openstack-nova | 15:26 | |
Spazmotic | Speaking of code reduction, I resubmitted my commit with the changes you suggested bauzas, if you get a chance sometime this week to take a look. You're still on the review so no rush :) | 15:27 |
Spazmotic | Have a good night novaers.. time for me to hit the hay | 15:27 |
*** tbachman has quit IRC | 15:28 | |
hrw | I do wonder how much time it will take when I submit patch which adds usb-keyboard ;D | 15:28 |
*** artom has joined #openstack-nova | 15:29 | |
mriedem | mgoddard: johnthetubaguy: how much of this stuff is required for queens? https://review.openstack.org/#/q/topic:bug/1746209+(status:open+OR+status:merged) | 15:29 |
mriedem | i see the ironic driver traits patches are merged | 15:29 |
hrw | hm. | 15:29 |
hrw | mriedem: I think that I will have to rewrite that patch again anyway. | 15:30 |
*** Eran_Kuris has joined #openstack-nova | 15:30 | |
hrw | mriedem: I just realized that as I need a keyboard in VM (usb one to make sure it works on all archs) I may need to add a check "if video requested and not x86 then add usb host controller and usb keyboard" | 15:31 |
*** salv-orlando has quit IRC | 15:31 | |
hrw | mriedem: and then it does not really matter is it usbtablet or ps2mouse or other mambojambo | 15:32 |
*** ociuhandu has joined #openstack-nova | 15:33 | |
*** ociuhandu has quit IRC | 15:33 | |
mgoddard_ | mriedem: none of that is required for queens. https://review.openstack.org/539506 is a speculative bugfix, so might be nice to get that one in | 15:33 |
*** slaweq_ has joined #openstack-nova | 15:34 | |
jroll | +1 to that | 15:36 |
*** sree has quit IRC | 15:36 | |
*** itlinux has quit IRC | 15:36 | |
*** sree has joined #openstack-nova | 15:37 | |
*** lucas-hungry is now known as lucasagomes | 15:38 | |
gibi | edleafe: see my suggestion inline https://review.openstack.org/#/c/539323/1/nova/cmd/manage.py@115 | 15:38 |
*** slaweq_ has quit IRC | 15:38 | |
jroll | mriedem: agree with mgoddard_ there, though they all look fairly safe to me, I'd just land them in queens personally | 15:39 |
*** Sandy619 has joined #openstack-nova | 15:40 | |
kashyap | mriedem: stephenfin: Back here. About the bumping mi libvirt / QEMU, we can work it out. Should also send out an email to operators list as a heads-up | 15:41 |
*** sree has quit IRC | 15:41 | |
stephenfin | kashyap: I'm assuming we use min(version in Ubuntu 16.04, version in RHEL 7.4, etc.) ? | 15:42 |
stephenfin | Or is it little more nuanced than that? :) | 15:42 |
*** david-lyle has joined #openstack-nova | 15:43 | |
hrw | stephenfin: ubuntu 16.04 or canonical cloud archive for 16.04? | 15:43 |
kashyap | stephenfin: Not that straightforward :-) | 15:43 |
kashyap | stephenfin: But yes, the lowest common denominator across distros upstream cares about | 15:43 |
hrw | for aarch64 sensible version is 3.6.0 and nothing lower | 15:43 |
mgoddard_ | mriedem, jroll: while we're on ironic virt driver bugs, I think https://bugs.launchpad.net/nova/+bug/1710141 has crept back in. Should we target this for queens? | 15:44 |
openstack | Launchpad bug 1710141 in OpenStack Compute (nova) ocata "Continual warnings in n-cpu logs about being unable to delete inventory for an ironic node with an instance on it" [Undecided,New] | 15:44 |
mriedem | alex_xu: gibi: replied in https://review.openstack.org/#/c/539658/ - see what you think, it's nuanced for sure | 15:44 |
*** Sandy619 has quit IRC | 15:45 | |
edleafe | gibi: sure, that would work. I considered doing a shift of 8 instead of 1 for the same reason, but I thought an explicit shift-unshift difference would be less likely to be confusing. IOW, a real entry is shifted for creating a marker, and unshifted to return to the original value | 15:45 |
mriedem | kashyap: stephenfin: there has already been a "next version" in the driver since pike, so we'd use that, | 15:45 |
mriedem | the question is what the next version would be after that | 15:45 |
jroll | mgoddard_: that looks complicated :| | 15:45 |
mriedem | which is likely whatever our min is for supported distros today | 15:45 |
stephenfin | mriedem: Yup, that's the version I'm referring to | 15:45 |
kashyap | mriedem: Ah, right. We're looking for the one _after_ | 15:45 |
mgoddard_ | jroll: I think we just need to report inventory for nodes with instances | 15:46 |
*** beagles_mtg is now known as beagles | 15:46 | |
*** salv-orlando has joined #openstack-nova | 15:46 | |
jroll | mgoddard_: we should be already, is the thing | 15:47 |
mgoddard_ | jroll: nope https://github.com/openstack/nova/blob/d25feca/nova/virt/ironic/driver.py#L758 | 15:47 |
jroll | mgoddard_: right, tracking it down, because that's the real bug like you say | 15:47 |
*** belmoreira has quit IRC | 15:47 | |
mgoddard_ | jroll: I think we didn't then briefly we did, then we didn't again :) | 15:47 |
jroll | mgoddard_: yeah we broke that. sigh. | 15:48 |
mgoddard_ | I think this fixed it briefly: https://github.com/openstack/nova/commit/c92337bdf80fea4c0a8ebb433bacec4cc07f7a94 | 15:48 |
mgoddard_ | jroll: then this broke it again: https://github.com/openstack/nova/commit/d25feca90ec4bad6ec9ececedced63b9f00b4c87 | 15:49 |
gibi | edleafe: I don't know why shifting by 1 is more explict that shifting by 8. In the other hand you can keep shift and un_shift function so that the client code will be explict but simply calls shift from un_shift to make the implementation simpler | 15:49 |
mgoddard_ | jroll: there's also the matter of this TODO: https://github.com/openstack/nova/blob/d25feca/nova/virt/ironic/driver.py#L753 | 15:49 |
*** yikun_ has quit IRC | 15:50 | |
*** lei-zh has quit IRC | 15:51 | |
*** Sandy619 has joined #openstack-nova | 15:52 | |
edleafe | gibi: the explicitness is that as written, shift(shift(uuid)) will not return the original value. IOW, you have to be explicit that you are encoding/decoding | 15:53 |
jroll | mgoddard_: hm, I'm not sure the best way to handle this, though completing that todo may just solve it forever :) | 15:54 |
*** armax has quit IRC | 15:55 | |
mgoddard_ | jroll: +1, but seems late in the cycle for that change | 15:55 |
*** elmaciej has joined #openstack-nova | 15:56 | |
*** tbachman has joined #openstack-nova | 15:56 | |
jroll | mgoddard_: agree, though if it's just spurious logs, I think it's fine to wait | 15:56 |
gibi | mriedem: see my answer in https://review.openstack.org/#/c/539658/1/doc/source/user/placement.rst@279 | 15:57 |
*** claudiub|2 has joined #openstack-nova | 15:57 | |
gibi | edleafe: this is why I suggest to keep shift and un_shift for the caller. So on the caller side it is explicitly encode/decode the marker. But the implementation can be like un_shift(uuid): return shift(uuid) and shift(uuid) can also be written in a single line | 15:58 |
gibi | mriedem: I would go for less options to avoid some later confusions | 15:59 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: trivial: Resolve Python 3 issues https://review.openstack.org/539907 | 16:00 |
*** claudiub has quit IRC | 16:00 | |
*** ratailor has joined #openstack-nova | 16:00 | |
*** Sandy619 has quit IRC | 16:00 | |
edleafe | gibi: ok, that's fair. Not sure why a one-line function is desireable, though | 16:00 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Pass limit to /allocation_requests https://review.openstack.org/531517 | 16:00 |
mgoddard_ | jroll: yeah I guess so | 16:02 |
*** aloga has quit IRC | 16:03 | |
gibi | edleafe: it is not the one linenes that really matters, but the simple reverse has a smaller cyclomatic complexity as well | 16:05 |
*** aloga has joined #openstack-nova | 16:05 | |
*** aloga has quit IRC | 16:06 | |
*** aloga has joined #openstack-nova | 16:06 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Ensure resource classes correctly https://review.openstack.org/539738 | 16:07 |
*** Sandy619 has joined #openstack-nova | 16:07 | |
melwitt | mriedem: ack, will review | 16:07 |
efried | jaypipes: The above fixes a bug I *do* think we need resolved in Q. | 16:08 |
*** felipemonteiro has joined #openstack-nova | 16:08 | |
efried | edleafe, cdent: may also interest y'all. | 16:08 |
*** rmcall has quit IRC | 16:08 | |
edleafe | efried: ack. In meeting hell today. | 16:09 |
efried | no worries | 16:09 |
*** felipemonteiro_ has joined #openstack-nova | 16:09 | |
*** tbachman has quit IRC | 16:11 | |
*** Sandy619 has quit IRC | 16:12 | |
*** READ10 has joined #openstack-nova | 16:12 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Avoid inventory DELETE API (no conflict detection) https://review.openstack.org/539712 | 16:12 |
*** slaweq has quit IRC | 16:13 | |
*** felipemonteiro has quit IRC | 16:14 | |
*** lucasagomes has quit IRC | 16:15 | |
*** hemna_ has quit IRC | 16:16 | |
*** lucasagomes has joined #openstack-nova | 16:18 | |
mriedem | stephenfin: you know zuulv3 things, care to take a look at the nova-multiattach job? https://review.openstack.org/#/c/532689/ | 16:19 |
mriedem | dependent patches are approved | 16:19 |
stephenfin | Sure thing | 16:19 |
mriedem | thanks; will be good to not regress that stuff | 16:19 |
*** tbachman has joined #openstack-nova | 16:20 | |
*** tbachman_ has joined #openstack-nova | 16:22 | |
*** lajoskatona has left #openstack-nova | 16:23 | |
*** tbachman has quit IRC | 16:25 | |
*** tbachman_ is now known as tbachman | 16:25 | |
*** ragiman has quit IRC | 16:28 | |
*** felipemonteiro_ has quit IRC | 16:30 | |
*** Sandy619 has joined #openstack-nova | 16:34 | |
*** chyka has joined #openstack-nova | 16:34 | |
*** crushil has quit IRC | 16:35 | |
mriedem | ameeda: easy docs bug to fix in cinder https://bugs.launchpad.net/cinder/+bug/1711267 | 16:36 |
openstack | Launchpad bug 1711267 in Cinder "Boot from volume in cinder" [Undecided,New] | 16:36 |
mriedem | has some broken links | 16:36 |
*** elmaciej has quit IRC | 16:38 | |
*** yamahata has quit IRC | 16:38 | |
*** Sandy619 has quit IRC | 16:39 | |
*** Sandy619_opensta has joined #openstack-nova | 16:39 | |
*** gyee has joined #openstack-nova | 16:45 | |
*** pcaruana has quit IRC | 16:45 | |
*** mchlumsky has joined #openstack-nova | 16:47 | |
stephenfin | mriedem: Comments left | 16:51 |
*** ttsiouts has quit IRC | 16:52 | |
*** ttsiouts has joined #openstack-nova | 16:52 | |
*** READ10 has quit IRC | 16:52 | |
mriedem | stephenfin: replied; i'm not sure i follow your confusion though | 16:59 |
*** janki has joined #openstack-nova | 17:00 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have usable input for graphical console https://review.openstack.org/538003 | 17:00 |
hrw | mriedem, stephenfin: rewroted. now it adds usb host controller if there is none and adds usb keyboard if there is no keyboard. and does it on !(x86(-64), ppc64, s390x) architectures | 17:01 |
jaypipes | efried: IBM PowerKVM CI failure. I'll wait until that is resolved. | 17:02 |
* jaypipes scampers off into the woods... | 17:02 | |
efried | jaypipes: PowerKVM? Non-voting, right? I've been steadfastly ignoring that guy. | 17:03 |
jaypipes | efried: I was joking with you. | 17:03 |
efried | jaypipes: PowerVM failures are due to the fact that esberglu is rebuilding some CI systems, I think. | 17:03 |
jaypipes | efried: clearly, you do not share my brand of humour. | 17:03 |
hrw | jaypipes: https://review.openstack.org/538003 ^^ ;D | 17:04 |
efried | jaypipes: Sorry, the gate has me grumpy about CI holding up patches. | 17:04 |
efried | jaypipes: Just for that, I'm going to put you down as the approver for this blueprint I'm writing up. | 17:05 |
mmedvede | PowerKVM is voting, but it is not blocking, i.e. it can not prevent a patch with +2+w from merging | 17:05 |
esberglu | efried: Huh? I'm not doing anything with prod CI, just staging | 17:05 |
esberglu | Oh this is PowerKVM we're talking | 17:05 |
efried | esberglu: Okay, so I should be able to recheck powervm failures? | 17:06 |
efried | esberglu: Seeing OOT failures pretty frequently. | 17:06 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: trivial: Resolve Python 3 issues https://review.openstack.org/539907 | 17:07 |
jaypipes | hrw: I thought mriedem was a no go on that getting in Queens? | 17:07 |
jaypipes | efried: :P | 17:07 |
hrw | jaypipes: how that holds you from reviewing? | 17:08 |
esberglu | efried: Yeah recheck. Only 1 issue hitting OOT, was gonna have someone from REST take a look this afternoon | 17:08 |
efried | ight | 17:08 |
*** ratailor has quit IRC | 17:09 | |
hrw | jaypipes: for me it may land in Rocky cycle as well as in Queens. I just have spare time now as what I wanted to have in nova/Queens got merged. | 17:09 |
*** moshele has quit IRC | 17:09 | |
mriedem | the usbhost controller for aarch64 is a bug | 17:09 |
*** mvk has quit IRC | 17:09 | |
mriedem | working around a limitation in libvirt for non-x86 | 17:09 |
*** harlowja has joined #openstack-nova | 17:09 | |
hrw | jaypipes: just prefer to have it reviewed when I still remember what is it all about | 17:09 |
mriedem | so that's fine | 17:09 |
efried | stephenfin: I think if we get up to PS4, you have to remove "trivial". | 17:09 |
stephenfin | Hahaha | 17:10 |
hrw | mriedem: is not a bug. but also not a feature | 17:10 |
stephenfin | efried: Touche :) | 17:10 |
esberglu | efried: And I would say pretty frequently is a stretch :) | 17:10 |
esberglu | OOT has failed like 6 times in the last 2 days (and at least 1 was a bad patch) | 17:10 |
efried | esberglu: Okay; first three I looked at just now. | 17:10 |
hrw | libvirt devs are very curious about changing defaults so I made patch for nova to do what needs to be done | 17:10 |
jaypipes | hrw: https://wattsupwiththat.files.wordpress.com/2015/09/not_a_bug_but_a_feature.jpg | 17:11 |
stephenfin | mriedem: So QEMU broke something and then libvirt managed to fix it? | 17:11 |
*** lpetrut has joined #openstack-nova | 17:11 | |
stephenfin | Meaning libvirt 3.10+ and any version of QEMU (including 2.10?) would work? | 17:11 |
hrw | https://www.redhat.com/archives/libvir-list/2018-February/msg00043.html is thread on libvirt ML if someone want | 17:11 |
stephenfin | But not libvirt < 3.10 and QEMU >= 2.10? | 17:12 |
hrw | stephenfin: nevermind which version they change situation I may still end with nova on aarch64 with older libvirt/qemu combo so https://review.openstack.org/538003 is a way | 17:13 |
stephenfin | hrw: Um, come again? | 17:13 |
stephenfin | hrw: I was referring to https://review.openstack.org/#/c/532689/, btw | 17:14 |
*** Eran_Kuris has quit IRC | 17:14 | |
hrw | stephenfin: ah | 17:14 |
hrw | sorry, too late for me probably | 17:14 |
*** READ10 has joined #openstack-nova | 17:14 | |
*** READ10 has quit IRC | 17:14 | |
*** READ10 has joined #openstack-nova | 17:14 | |
hrw | multiattach is qemu 2.10+ yes | 17:15 |
hrw | or sth | 17:15 |
* hrw shuts | 17:15 | |
*** sahid has quit IRC | 17:18 | |
*** artom has quit IRC | 17:22 | |
cfriesen | mriedem: release note has been added as per your request for https://review.openstack.org/#/c/520187/ | 17:24 |
mriedem | cfriesen: ok but i'm not looking at that until after queens | 17:25 |
mriedem | stephenfin: you can do multiattach if (1) qemu<2.10 or (2) libvirt>=3.10 (regardless of qemu version) | 17:25 |
mriedem | libvirt 3.10 does a thing to make it work with qemu 2.10+ | 17:26 |
mriedem | for shared disks | 17:26 |
*** moshele has joined #openstack-nova | 17:26 | |
mriedem | stephenfin: https://bugzilla.redhat.com/show_bug.cgi?id=1378242 | 17:26 |
openstack | bugzilla.redhat.com bug 1378242 in libvirt "QEMU image file locking (libvirt)" [Unspecified,Verified] - Assigned to pkrempa | 17:26 |
stephenfin | mriedem: Right, figured out the source of my confusion. It was this https://review.openstack.org/#/c/532214/ | 17:27 |
*** yamahata has joined #openstack-nova | 17:27 | |
mriedem | totally unrealted | 17:27 |
mriedem | ^ is because the job runs without pike uca | 17:27 |
stephenfin | Yup, I know that now. The fact that it talked about libvirt and QEMU versions but with opposite expectations threw me | 17:27 |
*** derekh has quit IRC | 17:27 | |
*** ccamacho has quit IRC | 17:28 | |
jaypipes | hrw: reviewed. | 17:28 |
melwitt | mriedem: wanted to bring this to your attention, I think we're not using the newer cinder api when creating instances with multi-cell https://review.openstack.org/#/c/539755/ | 17:28 |
melwitt | so another set of eyes would be helpful there | 17:29 |
stephenfin | mriedem: One last question (mirrored from the review): do we want to suggest the behavior on libvirt < 3.10? Is the behaviour of QEMU < 2.10 considered broken or something? | 17:29 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Migrate "launch instance" user guide docs https://review.openstack.org/540048 | 17:30 |
hrw | jaypipes: thx. updating code and replying | 17:30 |
mriedem | stephenfin: i'm having a hard time parsing "suggest the behavior" | 17:30 |
*** psachin has joined #openstack-nova | 17:31 | |
mriedem | stephenfin: the libvirt driver will report the capability as not being supported if those version constraints aren't satisfied | 17:31 |
mriedem | stephenfin: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L599 | 17:31 |
stephenfin | I don't even know what I was trying to say there | 17:32 |
mriedem | melwitt: yes agree, i had noticed that while adding the multiattach support to the api and looking at the version checks; that version check was added in pike before dan's multi-cell in api stuff landed; i just forgot to push a patch for it | 17:32 |
mriedem | stephenfin: just tell me you love me | 17:32 |
jaypipes | hrw: cool. my comments make sense ok? | 17:33 |
hrw | yes | 17:33 |
stephenfin | A +2 is the most you're getting at this time of evening, Mr Riedemann | 17:33 |
jaypipes | coolio. | 17:33 |
stephenfin | That's done now. Sorry about the confusion | 17:33 |
* stephenfin heads home | 17:33 | |
jaypipes | stephenfin: he prefers Ms. Riedemann. | 17:33 |
melwitt | lyarwood: I have a feeling that https://bugs.launchpad.net/neutron/+bug/1744361 might be because we don't wait for the unplug event before we plug. my plan for today is to put up a DNM patch in a project where the job is failing with depends-on the logging and see if I can get it to fail in the same way. then I'll test a patch that waits for unplug events | 17:34 |
openstack | Launchpad bug 1744361 in neutron "test_server_security_groups failed to reboot with "Domain not found: no domain with matching uuid" because of missing vif event from linuxbridge agent" [Undecided,Confirmed] | 17:34 |
mriedem | melwitt: +2 | 17:34 |
melwitt | mriedem: ah, cool. thanks | 17:34 |
mriedem | i prefer herr riedemann btw | 17:34 |
mriedem | it is a german name | 17:34 |
hrw | print(cfg.to_xml()) in test ftw | 17:35 |
*** amodi has quit IRC | 17:35 | |
hrw | jaypipes: Fraü? | 17:35 |
*** moshele has quit IRC | 17:38 | |
*** alaski_ is now known as alaski | 17:38 | |
openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Move resource provider objects into placement hierarchy https://review.openstack.org/540049 | 17:38 |
*** tidwellr_ has joined #openstack-nova | 17:39 | |
*** tidwellr has quit IRC | 17:39 | |
*** AlexeyAbashkin has quit IRC | 17:40 | |
hrw | jaypipes: first version of patch was using model. Then libvirt guys told me about defaults | 17:40 |
*** AlexeyAbashkin has joined #openstack-nova | 17:41 | |
*** sambetts is now known as sambett|afk | 17:41 | |
hrw | ugh. I looked at tests and they look funny in some moments | 17:44 |
*** burt has joined #openstack-nova | 17:45 | |
*** AlexeyAbashkin has quit IRC | 17:45 | |
jaypipes | hrw: gotcha | 17:47 |
*** artom has joined #openstack-nova | 17:47 | |
*** Swami has joined #openstack-nova | 17:47 | |
jaypipes | efried: reviewed. | 17:47 |
efried | jaypipes: thx | 17:47 |
*** lyan has quit IRC | 17:51 | |
*** psachin has quit IRC | 17:52 | |
*** amodi has joined #openstack-nova | 17:54 | |
*** hemna_ has joined #openstack-nova | 17:58 | |
*** slaweq has joined #openstack-nova | 18:00 | |
*** munishmehan has joined #openstack-nova | 18:00 | |
openstackgerrit | Surya Seetharaman proposed openstack/nova master: Extending delete_cell --force to delete instance_mappings https://review.openstack.org/540073 | 18:01 |
efried | stephenfin: Remind me how to sphinx build a single document? | 18:01 |
openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Make sure that we have usable input for graphical console https://review.openstack.org/538003 | 18:03 |
hrw | jaypipes: your suggestions are in. Also test changed to test aarch64 with graphics | 18:03 |
hrw | probably should add new test so one will check base aarch64 no gfx + new for aarch64 with gfx | 18:03 |
jaypipes | hrw: lol, did you set the keymap to en-ie just for stephenfin? ;) | 18:04 |
*** slaweq has quit IRC | 18:04 | |
hrw | jaypipes: copy/pasted from other test | 18:04 |
jaypipes | hrw: was a good choice! :) | 18:04 |
hrw | jaypipes: test_get_guest_config_with_vnc() settings | 18:04 |
hrw | and I dislike all those cfg.devices[X] checks as they look like the order is set in stone | 18:05 |
jaypipes | hrw: +2 from me :) | 18:05 |
*** janki has quit IRC | 18:06 | |
hrw | jaypipes: thanks! | 18:06 |
hrw | now to convince mriedem or sahid... | 18:06 |
*** chyka has quit IRC | 18:07 | |
jaypipes | hrw: nie ma problemu | 18:07 |
*** chyka has joined #openstack-nova | 18:07 | |
*** jpena is now known as jpena|off | 18:07 | |
*** mgoddard_ has quit IRC | 18:07 | |
hrw | jaypipes: added comment about tests | 18:08 |
hrw | tomorrow I am off, then fosdem so I could forgot | 18:08 |
hrw | jaypipes: speaking of patience... My first patch to kolla had 50 revisions | 18:09 |
hrw | jaypipes: I merged 20-30 patches before that one went in | 18:09 |
jaypipes | hrw: heh, that's just a "middle-aged patch" ;) | 18:10 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Make the InstanceMapping marker UUID-like https://review.openstack.org/539323 | 18:11 |
edleafe | gibi: ^^ maybe you'll like this better (my original approach) | 18:11 |
hrw | jaypipes: helped me learning project code a lot ;D | 18:11 |
hrw | jaypipes: that nova patch is first time I used tests in openstack | 18:11 |
hrw | in my previous nova patches Kevin_Zheng wrote tests | 18:11 |
jaypipes | ah | 18:12 |
jaypipes | hrw: just be glad you didn't need to touch the functional API tests... | 18:12 |
hrw | jaypipes: not my area of expertize | 18:13 |
*** david-lyle has quit IRC | 18:16 | |
*** armax has joined #openstack-nova | 18:16 | |
*** tssurya has left #openstack-nova | 18:17 | |
*** yamamoto has quit IRC | 18:17 | |
*** openstackgerrit has quit IRC | 18:18 | |
*** moshele has joined #openstack-nova | 18:21 | |
*** suresh12 has joined #openstack-nova | 18:24 | |
hrw | see you Monday (or FOSDEM) | 18:24 |
*** suresh12 has quit IRC | 18:29 | |
*** harlowja has quit IRC | 18:29 | |
*** slaweq has joined #openstack-nova | 18:32 | |
*** suresh12 has joined #openstack-nova | 18:34 | |
*** moshele has quit IRC | 18:35 | |
*** sdague has quit IRC | 18:36 | |
*** slaweq has quit IRC | 18:38 | |
*** gjayavelu has joined #openstack-nova | 18:40 | |
*** salv-orlando has quit IRC | 18:41 | |
*** salv-orlando has joined #openstack-nova | 18:41 | |
*** dtantsur is now known as dtantsur|afk | 18:45 | |
*** salv-orlando has quit IRC | 18:45 | |
*** suresh12 has quit IRC | 18:46 | |
*** Swanson has joined #openstack-nova | 18:48 | |
*** ttsiouts_ has joined #openstack-nova | 18:50 | |
*** edleafe has quit IRC | 18:50 | |
*** sdague has joined #openstack-nova | 18:51 | |
*** slaweq has joined #openstack-nova | 18:52 | |
*** slaweq has quit IRC | 18:56 | |
*** tidwellr_ has quit IRC | 18:58 | |
*** moshele has joined #openstack-nova | 18:59 | |
*** lpetrut has quit IRC | 19:02 | |
*** tidwellr has joined #openstack-nova | 19:02 | |
*** liverpooler has quit IRC | 19:03 | |
*** ralonsoh has quit IRC | 19:04 | |
*** edleafe has joined #openstack-nova | 19:05 | |
*** liverpooler has joined #openstack-nova | 19:05 | |
*** edleafe has quit IRC | 19:07 | |
*** harlowja has joined #openstack-nova | 19:09 | |
*** AlexeyAbashkin has joined #openstack-nova | 19:11 | |
*** harlowja_ has joined #openstack-nova | 19:11 | |
*** edleafe has joined #openstack-nova | 19:12 | |
*** harlowja has quit IRC | 19:14 | |
*** READ10 has quit IRC | 19:15 | |
*** yamamoto has joined #openstack-nova | 19:18 | |
*** eandersson_ is now known as eandersson | 19:19 | |
*** moshele has quit IRC | 19:19 | |
*** armax_ has joined #openstack-nova | 19:23 | |
*** armax has quit IRC | 19:23 | |
*** armax_ is now known as armax | 19:23 | |
*** david-lyle has joined #openstack-nova | 19:24 | |
*** nikhil has quit IRC | 19:26 | |
*** awaugama has quit IRC | 19:27 | |
*** openstackgerrit has joined #openstack-nova | 19:28 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Migrate "launch instance" user guide docs https://review.openstack.org/540048 | 19:28 |
*** yamamoto has quit IRC | 19:29 | |
*** liverpooler has quit IRC | 19:33 | |
*** liverpooler has joined #openstack-nova | 19:34 | |
smcginnis | mriedem: Can you confirm: https://review.openstack.org/#/c/540105/1/upper-constraints.txt | 19:37 |
smcginnis | Line 185 | 19:37 |
mriedem | smcginnis: yeah we don't, and i thought we actually couldn't do that w/o fixing horizon? | 19:38 |
mriedem | https://review.openstack.org/#/c/538472/ | 19:38 |
mriedem | i think the horizon tests will fail if you don't have that | 19:38 |
smcginnis | mriedem: I don't have all the details, just wanted to make sure there wasn't at least a major bump. | 19:38 |
smcginnis | mriedem: Makes sense, thanks for checking on it. | 19:38 |
mriedem | np | 19:39 |
*** slaweq has joined #openstack-nova | 19:42 | |
mriedem | mmedvede: some ppc64 assertions being made in https://review.openstack.org/#/c/538003/ | 19:42 |
*** awaugama has joined #openstack-nova | 19:42 | |
*** slaweq_ has joined #openstack-nova | 19:42 | |
mmedvede | mriedem: thanks, taking a look | 19:44 |
*** slaweq has quit IRC | 19:46 | |
*** awaugama has quit IRC | 19:46 | |
*** slaweq_ has quit IRC | 19:47 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Update Provider Tree https://review.openstack.org/540111 | 19:47 |
efried | jaypipes, mriedem: ^ | 19:47 |
*** awaugama has joined #openstack-nova | 19:48 | |
efried | This is a Rocky spec for the work that's basically already been done. Figured we should have something written down. | 19:48 |
cdent | efried: good idea | 19:49 |
hrw | mriedem: thanks for review. will take care next week | 19:50 |
efried | jaypipes: I should really put your name on it somewhere, since the actual design was mostly your brainchild. | 19:52 |
*** munishmehan has quit IRC | 19:54 | |
*** lucasagomes is now known as lucas-afk | 19:55 | |
*** AlexeyAbashkin has quit IRC | 19:55 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 19:55 |
jaypipes | efried: lol, I don't care about that :) as long as we make forward progress, I'm happy. | 19:57 |
efried | jaypipes: People in the know, know. | 19:58 |
efried | ya know? | 19:59 |
jaypipes | heh | 20:00 |
*** felipemonteiro has joined #openstack-nova | 20:00 | |
*** tidwellr_ has joined #openstack-nova | 20:02 | |
*** tidwellr has quit IRC | 20:02 | |
*** tbachman has quit IRC | 20:02 | |
*** cdent has quit IRC | 20:04 | |
*** gszasz has quit IRC | 20:07 | |
*** slaweq has joined #openstack-nova | 20:08 | |
*** slaweq_ has joined #openstack-nova | 20:09 | |
*** slaweq_ has quit IRC | 20:14 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Cleanup launch instance and manage IPs docs https://review.openstack.org/540121 | 20:14 |
mriedem | this needs another +2 https://review.openstack.org/#/c/531517/ | 20:17 |
*** awaugama has quit IRC | 20:22 | |
*** hoangcx has quit IRC | 20:24 | |
*** hemna_ has quit IRC | 20:25 | |
*** eharney has quit IRC | 20:29 | |
dansmith | yes, yes it does | 20:29 |
*** arvindn05 has quit IRC | 20:33 | |
*** tbachman has joined #openstack-nova | 20:34 | |
*** tbachman_ has joined #openstack-nova | 20:36 | |
*** tbachman has quit IRC | 20:38 | |
*** tbachman_ is now known as tbachman | 20:38 | |
*** arvindn05 has joined #openstack-nova | 20:39 | |
*** hoangcx has joined #openstack-nova | 20:39 | |
*** slaweq_ has joined #openstack-nova | 20:41 | |
*** slaweq has quit IRC | 20:41 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Update Provider Tree https://review.openstack.org/540111 | 20:44 |
*** slaweq_ has quit IRC | 20:45 | |
melwitt | mriedem: do you know what causes neutron to send events? is it reacting to os-vif calls or? | 20:47 |
melwitt | I updated the bug with my latest findings on the timeout waiting for network-vif-plugged | 20:47 |
dansmith | melwitt: it's when neutron does things | 20:47 |
mriedem | melwitt: the neutron agent sends info to the server via rpc | 20:47 |
mriedem | the neutron agent is polling for changes, as far as i understand | 20:47 |
melwitt | okay, that makes sense. I'm looking in the agent logs trying to piece things together | 20:48 |
mriedem | the server then gets the rpc message from the agent(s) and turns those into rest api calls (server external events) to nova | 20:48 |
*** slaweq has joined #openstack-nova | 20:48 | |
dansmith | mriedem: I dunno that it's polly, | 20:48 |
dansmith | er, polling | 20:48 |
melwitt | because what's happening is, when we start the reboot, while we're tearing down the libvirt domain, BEFORE we unplug the vif, we are getting a network-vif-plugged event from neutron | 20:48 |
melwitt | and it's not from the initial boot because we have one from that too, earlier in the log | 20:48 |
dansmith | I think it's like when you ask it to do a vif plug, it does it, and then sends an RPC to neutron server to send it out | 20:48 |
*** hoangcx has quit IRC | 20:49 | |
melwitt | and I'm wondering, why is it sending us network-vif-plugged if we haven't even tried to plug anything yet | 20:49 |
dansmith | melwitt: network-changed comes a lot, are you sure it was vif-pluged? | 20:49 |
melwitt | I'm sure | 20:49 |
melwitt | we do get network-changed FIRST though, right before we initiate the reboot in compute | 20:49 |
melwitt | then we get network-vif-plugged | 20:50 |
dansmith | well, it might be that they do it any time they refresh a vif into a bridge and thus send it sometimes when we're not asking for it | 20:50 |
melwitt | which makes no sense | 20:50 |
dansmith | like not always just in response to our asking for it | 20:50 |
*** baoli has joined #openstack-nova | 20:50 | |
melwitt | vif-plugged you mean? | 20:50 |
melwitt | yeah, I figured there might be some reasons it sends it randomly. but, it's also not sending us one after we plug the vif after the reboot | 20:51 |
*** tovin07 has quit IRC | 20:51 | |
melwitt | I was thinking the next step is to learn how it decides to send them and find what's missing there | 20:52 |
dansmith | did we unplug first? | 20:52 |
*** baoli has quit IRC | 20:52 | |
melwitt | yes. we unplugged but did not wait for an unplug event | 20:52 |
melwitt | which I wonder if that's a problem | 20:52 |
*** tovin07 has joined #openstack-nova | 20:53 | |
*** takashin has joined #openstack-nova | 20:53 | |
*** tssurya has joined #openstack-nova | 20:53 | |
dansmith | well, no, not waiting for the event shouldn't make it not send the corresponding plug | 20:53 |
dansmith | because unless it's for an instance that doesn't exist, the api doesn't tell the person sending the event that we weren't waiting for it | 20:54 |
melwitt | yeah. agreed, just that's the only thing I could think of as a potential reason why | 20:54 |
melwitt | you know what though, looking at this again | 20:54 |
melwitt | the vif shows up as active=False for both the unplug and the plug | 20:55 |
melwitt | I wonder if that's a problem | 20:55 |
melwitt | well, actually it's *supposed* to be active=False before we plug | 20:56 |
melwitt | based on our event waiting logic | 20:56 |
melwitt | *our plug event waiting logic | 20:56 |
melwitt | we only register to wait for vifs that have active=False. so that checks out | 20:56 |
melwitt | active=True when the reboot begain, then it changed to active=False somewhere between the libvirt destroy and the unplug | 20:58 |
melwitt | *began | 20:58 |
*** takashin has quit IRC | 20:58 | |
mriedem | nova meeting time | 21:00 |
melwitt | ah thanks | 21:00 |
*** takashin has joined #openstack-nova | 21:00 | |
*** tovin07 has quit IRC | 21:01 | |
*** priteau has quit IRC | 21:03 | |
*** hoangcx has joined #openstack-nova | 21:03 | |
*** tovin07 has joined #openstack-nova | 21:04 | |
*** liverpooler has quit IRC | 21:05 | |
openstackgerrit | Merged openstack/nova master: SchedulerReportClient._delete_provider https://review.openstack.org/535463 | 21:05 |
*** yamahata has quit IRC | 21:06 | |
*** tidwellr_ has quit IRC | 21:10 | |
*** tovin07 has quit IRC | 21:13 | |
*** tovin07 has joined #openstack-nova | 21:17 | |
*** tidwellr has joined #openstack-nova | 21:17 | |
*** eharney has joined #openstack-nova | 21:17 | |
*** takashin has left #openstack-nova | 21:17 | |
*** jpena|off is now known as jpena | 21:18 | |
openstackgerrit | Merged openstack/nova master: ProviderTree.get_provider_uuids: Top-down ordering https://review.openstack.org/536624 | 21:18 |
openstackgerrit | Merged openstack/nova master: set_{aggregates|traits}_for_provider: tolerate set https://review.openstack.org/536625 | 21:19 |
*** takashin has joined #openstack-nova | 21:20 | |
*** awaugama has joined #openstack-nova | 21:21 | |
mriedem | efried: there all your things are merged | 21:22 |
*** tovin07 has quit IRC | 21:23 | |
*** slaweq has quit IRC | 21:24 | |
*** hoangcx has quit IRC | 21:25 | |
openstackgerrit | Merged openstack/nova master: Fix nits in support traits changes https://review.openstack.org/537351 | 21:25 |
openstackgerrit | Merged openstack/nova master: Mention required traits in the flavors user docs https://review.openstack.org/539300 | 21:25 |
mriedem | sdague: if you're around, this is a simple docs migration that we missed in pike https://review.openstack.org/#/c/540048/ - content is unchanged except for fixing links; the patch on top cleans up some of the content to modernize it | 21:26 |
openstackgerrit | Merged openstack/nova master: add "--until-complete" option for nova-manage db archive_deleted_rows. https://review.openstack.org/539654 | 21:26 |
edleafe | efried: I told you to bribe the people in infra! | 21:26 |
openstackgerrit | Merged openstack/nova master: Use util.validate_query_params in list_traits https://review.openstack.org/539407 | 21:26 |
*** vladikr has quit IRC | 21:26 | |
openstackgerrit | Merged openstack/nova master: Deduplicate aggregate notification samples https://review.openstack.org/531162 | 21:26 |
openstackgerrit | Merged openstack/nova master: Deduplicate service status notification samples https://review.openstack.org/534335 | 21:26 |
openstackgerrit | Merged openstack/nova master: Log options at debug when starting API services under wsgi https://review.openstack.org/519462 | 21:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Regenerate context during targeting https://review.openstack.org/540145 | 21:28 |
*** hoangcx has joined #openstack-nova | 21:29 | |
*** pchavva has quit IRC | 21:30 | |
*** traskat has joined #openstack-nova | 21:30 | |
traskat | hey, i have a question about nova and ceph. how can cinder volume gets resized to the flavor disk size if the VM image gets cloned by cinder? | 21:31 |
sdague | mriedem: done | 21:31 |
*** hoangcx has quit IRC | 21:33 | |
mriedem | sdague: cool thanks | 21:34 |
mriedem | wow this is a super latent bug, and goes to show no one uses the IsolatedHostsFilter https://bugs.launchpad.net/nova/+bug/1746483 | 21:34 |
openstack | Launchpad bug 1746483 in OpenStack Compute (nova) "Not able to boot from Volume / Volume snapshot when using isolated_images" [Medium,Triaged] | 21:34 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Provide support matrix and doc for VGPU https://review.openstack.org/539266 | 21:34 |
mriedem | the IsolatedHostsFilter assumes the request spec has a valid image id in it, which isn't the case for boot from volume when you don't provide an image id | 21:35 |
*** takashin has left #openstack-nova | 21:37 | |
*** takashin has joined #openstack-nova | 21:38 | |
openstackgerrit | Merged openstack/nova master: De-duplicate _numa_get_flavor_XXX_map_list https://review.openstack.org/385074 | 21:38 |
openstackgerrit | Merged openstack/nova stable/pike: Add 'delete_host' command in 'nova-manage cell_v2' https://review.openstack.org/513717 | 21:38 |
*** tovin07 has joined #openstack-nova | 21:39 | |
*** vladikr has joined #openstack-nova | 21:39 | |
*** slaweq has joined #openstack-nova | 21:47 | |
*** hoangcx has joined #openstack-nova | 21:48 | |
*** salv-orlando has joined #openstack-nova | 21:51 | |
*** slaweq has quit IRC | 21:51 | |
*** jpena is now known as jpena|off | 21:52 | |
tssurya | mriedem: regarding the scatter_cells bug thanks for backporting it to pike, we have upgraded to ocata today, so far so good (will keep you posted if we find anything major/interesting) | 21:54 |
mriedem | tssurya: which one? | 21:57 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Ensure the JSON-Schema covers the legacy v2 API https://review.openstack.org/540154 | 21:57 |
tssurya | mriedem : https://bugs.launchpad.net/nova/+bug/1746509 | 21:57 |
openstack | Launchpad bug 1722404 in OpenStack Compute (nova) ocata "duplicate for #1746509 Database transactions can fail with "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" because of scatter_gather_cells" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem) | 21:57 |
tssurya | the one you mentioned in the meeting | 21:57 |
mriedem | ah that's not scatter/gather | 21:58 |
mriedem | and the ocata backport isn't ready yet, unit tests are failing, i haven't dug into how to fix those yet | 21:59 |
*** tovin07 has quit IRC | 21:59 | |
*** hoangcx has quit IRC | 21:59 | |
mgagne | mriedem: I don't use IsolatedHostsFilter because you would need to redeploy your config to add new hosts/images, that's suboptimal. | 21:59 |
*** threestrands has joined #openstack-nova | 21:59 | |
*** threestrands has quit IRC | 22:00 | |
*** threestrands has joined #openstack-nova | 22:00 | |
mgagne | but good point about image_ref not being available with BFV, I'm not sure how we didn't catch that one in a similar filter we wrote | 22:00 |
*** slaweq has joined #openstack-nova | 22:01 | |
mriedem | the request spec is also not good at telling anything if it's boot from volume or not | 22:02 |
mriedem | it doesn't even have the original bdms requested in it | 22:03 |
mgagne | I would have to dig into it a bit | 22:03 |
mriedem | so you'd basically have to assume that if the request spec doesn't have an image, it's volume-backed | 22:03 |
mriedem | maybe bauzas has thoughts on that one | 22:04 |
*** slaweq has quit IRC | 22:06 | |
*** mvk has joined #openstack-nova | 22:07 | |
mriedem | rgerganov: can you take a look at this? (or someone from vmware?) https://bugs.launchpad.net/nova/+bug/1744182 | 22:07 |
openstack | Launchpad bug 1744182 in OpenStack Compute (nova) "can not create instance when using vmware nova driver" [Undecided,New] | 22:07 |
melwitt | mriedem: commented on the review, I think yielding the copy of the context won't help because the callers aren't using the yielded context | 22:09 |
melwitt | I'm not sure if there's any clever thing we can do instead of having to fix all the callers in ocata | 22:10 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional tests for traits-based scheduling https://review.openstack.org/539310 | 22:11 |
mriedem | oh right... | 22:12 |
mriedem | guh | 22:12 |
melwitt | yeah :( | 22:12 |
*** hoangcx has joined #openstack-nova | 22:13 | |
*** tovin07 has joined #openstack-nova | 22:14 | |
melwitt | mriedem: looks like you've already documented the lack of neutron event in certain situations https://github.com/openstack/nova/blob/stable/ocata/nova/virt/libvirt/driver.py#L7508-L7512 | 22:14 |
mriedem | that's the 2nd time i've looked at that today for different reasons | 22:15 |
mriedem | i don't remember writing that though | 22:16 |
mriedem | might have been blacked out | 22:16 |
melwitt | yeah. ugh, it's my fault I even told lyarwood not to pass vifs_already_plugged=True :( | 22:16 |
melwitt | suck | 22:17 |
*** tovin07 has quit IRC | 22:17 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional tests for traits-based scheduling https://review.openstack.org/539310 | 22:19 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: placement upgrade notes for queens https://review.openstack.org/539658 | 22:19 |
mriedem | alex_xu: gibi: had to rebase that approved functional test ^ | 22:19 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in post https://review.openstack.org/526823 | 22:20 |
mriedem | time to leave, i've got single parenting duty tonight | 22:20 |
*** mriedem is now known as mriedem_parent | 22:20 | |
*** awaugama has quit IRC | 22:20 | |
*** tssurya has quit IRC | 22:21 | |
*** hongbin has quit IRC | 22:23 | |
*** tbachman has quit IRC | 22:25 | |
*** salv-orl_ has joined #openstack-nova | 22:28 | |
*** felipemonteiro_ has joined #openstack-nova | 22:28 | |
*** dave-mccowan has quit IRC | 22:30 | |
openstackgerrit | melanie witt proposed openstack/nova master: Don't wait for vif plug events during _hard_reboot https://review.openstack.org/540168 | 22:30 |
*** salv-orlando has quit IRC | 22:31 | |
*** hoangcx has quit IRC | 22:32 | |
*** felipemonteiro has quit IRC | 22:32 | |
openstackgerrit | Eric Fried proposed openstack/nova master: New-style _set_inventory_for_provider https://review.openstack.org/537648 | 22:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821 | 22:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: Use update_provider_tree from resource tracker https://review.openstack.org/520246 | 22:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: Fix nits in update_provider_tree series https://review.openstack.org/531260 | 22:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: Move refresh time from report client to prov tree https://review.openstack.org/535517 | 22:33 |
openstackgerrit | Eric Fried proposed openstack/nova master: Make generation optional in ProviderTree https://review.openstack.org/539324 | 22:33 |
efried | jaypipes: ^ rebased and now tagged under bp update-provider-tree | 22:34 |
*** tovin07 has joined #openstack-nova | 22:35 | |
*** vladikr has quit IRC | 22:40 | |
jaypipes | efried: cool, thanks. will review shortly. | 22:42 |
jaypipes | after dinner... | 22:42 |
efried | thx | 22:42 |
*** tidwellr has quit IRC | 22:43 | |
*** tbachman has joined #openstack-nova | 22:46 | |
*** hoangcx has joined #openstack-nova | 22:46 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | 22:47 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | 22:48 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Move body examples to an isolated directory https://review.openstack.org/529998 | 22:48 |
*** salv-orl_ has quit IRC | 22:49 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add functional tests for traits API https://review.openstack.org/524094 | 22:49 |
*** salv-orlando has joined #openstack-nova | 22:49 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers.inc https://review.openstack.org/528201 | 22:49 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers.inc https://review.openstack.org/529520 | 22:50 |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameter order in rebuild https://review.openstack.org/529718 | 22:50 |
*** tbachman has quit IRC | 22:50 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (1) https://review.openstack.org/531258 | 22:51 |
*** tbachman has joined #openstack-nova | 22:52 | |
*** burt has quit IRC | 22:53 | |
*** salv-orlando has quit IRC | 22:53 | |
*** edmondsw has quit IRC | 22:56 | |
*** eharney has quit IRC | 22:56 | |
*** yamahata has joined #openstack-nova | 22:58 | |
*** gyee has quit IRC | 22:59 | |
*** priteau has joined #openstack-nova | 23:03 | |
*** priteau_ has joined #openstack-nova | 23:07 | |
*** priteau has quit IRC | 23:08 | |
*** priteau_ has quit IRC | 23:11 | |
*** felipemonteiro_ has quit IRC | 23:18 | |
openstackgerrit | Eric Fried proposed openstack/nova-specs master: Granular Resource Request Syntax (Rocky) https://review.openstack.org/540179 | 23:22 |
efried | mriedem_parent, jaypipes: Re-proposed ^ | 23:22 |
efried | dansmith too - this was your favorite spec | 23:23 |
*** esberglu has quit IRC | 23:24 | |
*** tbachman has quit IRC | 23:25 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: [placement] Add sending global request ID in put (2) https://review.openstack.org/531266 | 23:32 |
*** r-daneel has quit IRC | 23:35 | |
*** esberglu has joined #openstack-nova | 23:36 | |
*** stakeda has joined #openstack-nova | 23:36 | |
*** masahisa has joined #openstack-nova | 23:40 | |
*** hshiina|afk has joined #openstack-nova | 23:42 | |
*** efried has quit IRC | 23:43 | |
*** esberglu_ has joined #openstack-nova | 23:45 | |
*** esberglu has quit IRC | 23:47 | |
*** sdague has quit IRC | 23:48 | |
*** tbachman has joined #openstack-nova | 23:50 | |
*** salv-orlando has joined #openstack-nova | 23:50 | |
*** yikun_ has joined #openstack-nova | 23:51 | |
*** esberglu_ has quit IRC | 23:51 | |
*** salv-orlando has quit IRC | 23:54 | |
openstackgerrit | Merged openstack/nova master: conf: Validate '[api] vendordata_providers' options https://review.openstack.org/513318 | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!