*** xyang_ has joined #openstack-nova | 00:04 | |
*** gyee has quit IRC | 00:04 | |
*** rajinir_ has joined #openstack-nova | 00:04 | |
*** khappone has joined #openstack-nova | 00:04 | |
*** jroll has joined #openstack-nova | 00:05 | |
*** jroll has quit IRC | 00:06 | |
*** Tom-Tom has joined #openstack-nova | 00:06 | |
*** jroll has joined #openstack-nova | 00:06 | |
*** breton_ has joined #openstack-nova | 00:07 | |
*** obre has joined #openstack-nova | 00:07 | |
*** edmondsw has joined #openstack-nova | 00:09 | |
*** dims has joined #openstack-nova | 00:10 | |
*** leifz- has joined #openstack-nova | 00:10 | |
*** mgagne_ has joined #openstack-nova | 00:10 | |
*** adreznec_ has joined #openstack-nova | 00:11 | |
*** Tom-Tom has quit IRC | 00:11 | |
*** dims_ has quit IRC | 00:12 | |
*** rajinir has quit IRC | 00:12 | |
*** dulek has quit IRC | 00:12 | |
*** xyang has quit IRC | 00:12 | |
*** eric-young has quit IRC | 00:12 | |
*** adreznec has quit IRC | 00:12 | |
*** khappone_ has quit IRC | 00:12 | |
*** obre_ has quit IRC | 00:12 | |
*** mgagne has quit IRC | 00:12 | |
*** leifz has quit IRC | 00:12 | |
*** breton has quit IRC | 00:12 | |
*** jlvillal has quit IRC | 00:12 | |
*** yassine has quit IRC | 00:12 | |
*** Anticimex has quit IRC | 00:12 | |
*** logan- has quit IRC | 00:12 | |
*** sdake has quit IRC | 00:12 | |
*** d34dh0r53 has quit IRC | 00:12 | |
*** krtaylor has quit IRC | 00:12 | |
*** rabel has quit IRC | 00:12 | |
*** knikolla has quit IRC | 00:12 | |
*** sc has quit IRC | 00:12 | |
*** rgerganov has quit IRC | 00:12 | |
*** slagle has quit IRC | 00:12 | |
*** bhagyashris has quit IRC | 00:12 | |
*** markmcclain has quit IRC | 00:12 | |
*** owalsh has quit IRC | 00:12 | |
*** ejat has quit IRC | 00:12 | |
*** rybridges has quit IRC | 00:12 | |
*** bauzas has quit IRC | 00:12 | |
*** dosaboy_ has quit IRC | 00:12 | |
*** slunkad has quit IRC | 00:12 | |
*** raginbajin has quit IRC | 00:12 | |
*** rmk has quit IRC | 00:12 | |
*** suresh12 has quit IRC | 00:12 | |
*** david-lyle has quit IRC | 00:12 | |
*** mriedem has quit IRC | 00:12 | |
*** hshiina|afk has quit IRC | 00:12 | |
*** tianhui has quit IRC | 00:12 | |
*** yikun_jiang has quit IRC | 00:12 | |
*** EmilienM has quit IRC | 00:12 | |
*** elod has quit IRC | 00:12 | |
*** migi has quit IRC | 00:12 | |
*** inara has quit IRC | 00:12 | |
*** ekhugen has quit IRC | 00:12 | |
*** SamYaple has quit IRC | 00:12 | |
*** antonym has quit IRC | 00:12 | |
*** blkart has quit IRC | 00:12 | |
*** hemna has quit IRC | 00:12 | |
*** ChanServ has quit IRC | 00:12 | |
*** rajinir_ is now known as rajinir | 00:12 | |
*** leifz- is now known as leifz | 00:12 | |
*** xyang_ is now known as xyang | 00:12 | |
*** adreznec_ is now known as adreznec | 00:12 | |
*** odyssey4me has quit IRC | 00:12 | |
*** odyssey4me has joined #openstack-nova | 00:12 | |
*** dulek has joined #openstack-nova | 00:13 | |
*** edmondsw has quit IRC | 00:13 | |
*** suresh12 has joined #openstack-nova | 00:13 | |
*** david-lyle has joined #openstack-nova | 00:13 | |
*** mriedem has joined #openstack-nova | 00:13 | |
*** hshiina|afk has joined #openstack-nova | 00:13 | |
*** rgerganov has joined #openstack-nova | 00:13 | |
*** tianhui has joined #openstack-nova | 00:13 | |
*** yikun_jiang has joined #openstack-nova | 00:13 | |
*** EmilienM has joined #openstack-nova | 00:13 | |
*** slagle has joined #openstack-nova | 00:13 | |
*** bhagyashris has joined #openstack-nova | 00:13 | |
*** markmcclain has joined #openstack-nova | 00:13 | |
*** elod has joined #openstack-nova | 00:13 | |
*** owalsh has joined #openstack-nova | 00:13 | |
*** ejat has joined #openstack-nova | 00:13 | |
*** migi has joined #openstack-nova | 00:13 | |
*** inara has joined #openstack-nova | 00:13 | |
*** ekhugen has joined #openstack-nova | 00:13 | |
*** rybridges has joined #openstack-nova | 00:13 | |
*** SamYaple has joined #openstack-nova | 00:13 | |
*** bauzas has joined #openstack-nova | 00:13 | |
*** ChanServ has joined #openstack-nova | 00:13 | |
*** rmk has joined #openstack-nova | 00:13 | |
*** raginbajin has joined #openstack-nova | 00:13 | |
*** hemna has joined #openstack-nova | 00:13 | |
*** blkart has joined #openstack-nova | 00:13 | |
*** antonym has joined #openstack-nova | 00:13 | |
*** slunkad has joined #openstack-nova | 00:13 | |
*** dosaboy_ has joined #openstack-nova | 00:13 | |
*** barjavel.freenode.net sets mode: +o ChanServ | 00:13 | |
*** sq4ind has quit IRC | 00:14 | |
*** bandini has quit IRC | 00:14 | |
*** ericyoung has joined #openstack-nova | 00:15 | |
*** jroll is now known as Guest43960 | 00:16 | |
*** bandini has joined #openstack-nova | 00:16 | |
*** salv-orlando has joined #openstack-nova | 00:17 | |
*** sq4ind has joined #openstack-nova | 00:17 | |
*** jmlowe_ has quit IRC | 00:18 | |
openstackgerrit | Merged openstack/nova master: Use ksa session for cinder microversion check https://review.openstack.org/557508 | 00:19 |
---|---|---|
openstackgerrit | Merged openstack/nova stable/pike: docs: Disable smartquotes https://review.openstack.org/554189 | 00:19 |
*** salv-orlando has quit IRC | 00:21 | |
*** sean-k-mooney[m] has quit IRC | 00:23 | |
*** yangyapeng has joined #openstack-nova | 00:23 | |
*** yangyapeng has quit IRC | 00:27 | |
*** hemna_ has quit IRC | 00:32 | |
*** andreas_s has joined #openstack-nova | 00:35 | |
*** esberglu has joined #openstack-nova | 00:35 | |
*** Tom-Tom has joined #openstack-nova | 00:37 | |
*** zhurong has joined #openstack-nova | 00:38 | |
*** andreas_s has quit IRC | 00:39 | |
*** esberglu has quit IRC | 00:40 | |
*** Guest43960 has quit IRC | 00:40 | |
*** hshiina|afk is now known as hshiina | 00:41 | |
*** jichen has joined #openstack-nova | 00:41 | |
*** Tom-Tom has quit IRC | 00:41 | |
*** yamamoto has joined #openstack-nova | 00:43 | |
*** jmlowe has joined #openstack-nova | 00:48 | |
*** yamamoto has quit IRC | 00:49 | |
*** yangyapeng has joined #openstack-nova | 00:56 | |
*** fragatina has quit IRC | 01:00 | |
*** yangyapeng has quit IRC | 01:00 | |
*** jroll has joined #openstack-nova | 01:01 | |
*** fragatina has joined #openstack-nova | 01:03 | |
*** tiendc has joined #openstack-nova | 01:05 | |
*** gouthamr has joined #openstack-nova | 01:06 | |
*** fragatina has quit IRC | 01:07 | |
Spaz-Home | Whew new shoes.. short workout.. let's do some nova | 01:08 |
*** cheran has quit IRC | 01:09 | |
*** hongbin has joined #openstack-nova | 01:13 | |
*** salv-orlando has joined #openstack-nova | 01:17 | |
*** yangyapeng has joined #openstack-nova | 01:21 | |
*** harlowja has quit IRC | 01:21 | |
*** salv-orlando has quit IRC | 01:22 | |
*** Tom-Tom has joined #openstack-nova | 01:26 | |
*** mriedem has quit IRC | 01:27 | |
*** Tom-Tom has quit IRC | 01:27 | |
*** Tom-Tom has joined #openstack-nova | 01:27 | |
*** sean-k-mooney[m] has joined #openstack-nova | 01:28 | |
*** jlvillal has joined #openstack-nova | 01:28 | |
*** yassine has joined #openstack-nova | 01:28 | |
*** Anticimex has joined #openstack-nova | 01:28 | |
*** logan- has joined #openstack-nova | 01:28 | |
*** sc has joined #openstack-nova | 01:28 | |
*** sdake has joined #openstack-nova | 01:28 | |
*** d34dh0r53 has joined #openstack-nova | 01:28 | |
*** krtaylor has joined #openstack-nova | 01:28 | |
*** rabel has joined #openstack-nova | 01:28 | |
*** knikolla has joined #openstack-nova | 01:28 | |
*** sean-k-mooney[m] has quit IRC | 01:28 | |
*** sean-k-mooney[m] has joined #openstack-nova | 01:28 | |
*** hamzy has joined #openstack-nova | 01:28 | |
*** itlinux has joined #openstack-nova | 01:30 | |
*** bandini has quit IRC | 01:30 | |
*** adreznec has quit IRC | 01:30 | |
*** sean-k-mooney[m] has quit IRC | 01:32 | |
*** gjayavelu has quit IRC | 01:32 | |
*** zhaochao has joined #openstack-nova | 01:32 | |
*** adreznec has joined #openstack-nova | 01:33 | |
*** bandini has joined #openstack-nova | 01:33 | |
*** sdague has quit IRC | 01:33 | |
*** weshay has quit IRC | 01:35 | |
*** weshay has joined #openstack-nova | 01:36 | |
*** andreas_s has joined #openstack-nova | 01:38 | |
*** yingjun has joined #openstack-nova | 01:44 | |
*** yamamoto has joined #openstack-nova | 01:45 | |
*** armaan has quit IRC | 01:45 | |
*** armaan has joined #openstack-nova | 01:46 | |
*** andreas_s has quit IRC | 01:46 | |
*** suresh12 has quit IRC | 01:49 | |
*** gongysh has joined #openstack-nova | 01:50 | |
*** yamamoto has quit IRC | 01:51 | |
*** itlinux has quit IRC | 01:54 | |
*** zhurong has quit IRC | 01:55 | |
*** danpawlik has joined #openstack-nova | 01:56 | |
*** edmondsw has joined #openstack-nova | 01:57 | |
*** sean-k-mooney[m] has joined #openstack-nova | 01:58 | |
*** fragatina has joined #openstack-nova | 02:01 | |
*** danpawlik has quit IRC | 02:01 | |
*** edmondsw has quit IRC | 02:01 | |
*** gongysh has quit IRC | 02:05 | |
*** fragatina has quit IRC | 02:05 | |
*** gongysh has joined #openstack-nova | 02:06 | |
*** AlexeyAbashkin has joined #openstack-nova | 02:07 | |
*** moshele has joined #openstack-nova | 02:07 | |
*** itlinux has joined #openstack-nova | 02:09 | |
*** jdillaman has quit IRC | 02:10 | |
*** AlexeyAbashkin has quit IRC | 02:11 | |
*** fragatina has joined #openstack-nova | 02:12 | |
*** fragatina has quit IRC | 02:13 | |
*** fragatina has joined #openstack-nova | 02:14 | |
*** itlinux has quit IRC | 02:16 | |
*** gouthamr has quit IRC | 02:17 | |
*** salv-orlando has joined #openstack-nova | 02:18 | |
*** gouthamr has joined #openstack-nova | 02:22 | |
*** salv-orlando has quit IRC | 02:23 | |
*** moshele has quit IRC | 02:25 | |
*** itlinux has joined #openstack-nova | 02:29 | |
*** itlinux has quit IRC | 02:30 | |
*** danpawlik has joined #openstack-nova | 02:32 | |
*** hoangcx has quit IRC | 02:34 | |
openstackgerrit | Merged openstack/nova stable/pike: add check before adding cpus to cpuset_reserved https://review.openstack.org/557622 | 02:34 |
openstackgerrit | Merged openstack/nova stable/queens: Use ksa session for cinder microversion check https://review.openstack.org/557837 | 02:34 |
*** hoangcx has joined #openstack-nova | 02:35 | |
*** danpawlik has quit IRC | 02:37 | |
*** gouthamr has quit IRC | 02:43 | |
*** yamamoto has joined #openstack-nova | 02:47 | |
*** amodi has quit IRC | 02:48 | |
*** yamamoto has quit IRC | 02:52 | |
*** david-lyle has quit IRC | 02:53 | |
*** danpawlik has joined #openstack-nova | 02:55 | |
*** suresh12 has joined #openstack-nova | 02:59 | |
*** danpawlik has quit IRC | 03:00 | |
*** suresh12 has quit IRC | 03:03 | |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/537897 | 03:04 |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_certs object https://review.openstack.org/489408 | 03:04 |
openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 03:04 |
openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 03:04 |
*** gouthamr has joined #openstack-nova | 03:06 | |
*** danpawlik has joined #openstack-nova | 03:07 | |
*** yassine has quit IRC | 03:07 | |
*** AlexeyAbashkin has joined #openstack-nova | 03:08 | |
*** david-lyle has joined #openstack-nova | 03:08 | |
*** yassine has joined #openstack-nova | 03:08 | |
*** danpawlik has quit IRC | 03:12 | |
*** AlexeyAbashkin has quit IRC | 03:12 | |
*** yamamoto has joined #openstack-nova | 03:13 | |
*** gouthamr has quit IRC | 03:13 | |
*** tuanla____ has joined #openstack-nova | 03:16 | |
*** salv-orlando has joined #openstack-nova | 03:19 | |
*** gongysh has quit IRC | 03:21 | |
*** salv-orlando has quit IRC | 03:23 | |
*** dave-mccowan has quit IRC | 03:23 | |
*** Tom-Tom has quit IRC | 03:27 | |
*** Tom-Tom has joined #openstack-nova | 03:27 | |
*** Tom-Tom has quit IRC | 03:32 | |
*** tbachman has joined #openstack-nova | 03:38 | |
*** Rambo has joined #openstack-nova | 03:40 | |
*** edmondsw has joined #openstack-nova | 03:45 | |
*** hongbin has quit IRC | 03:45 | |
*** danpawlik has joined #openstack-nova | 03:46 | |
*** edmondsw has quit IRC | 03:50 | |
*** Zames has joined #openstack-nova | 03:50 | |
*** danpawlik has quit IRC | 03:50 | |
*** harlowja has joined #openstack-nova | 03:51 | |
*** hoangcx has quit IRC | 03:51 | |
*** tuanla____ has quit IRC | 03:51 | |
*** tuanla____ has joined #openstack-nova | 03:52 | |
*** hoangcx has joined #openstack-nova | 03:52 | |
*** Zames has quit IRC | 03:55 | |
*** suresh12 has joined #openstack-nova | 03:56 | |
*** hongbin has joined #openstack-nova | 03:57 | |
*** hongbin has quit IRC | 04:00 | |
*** Zames has joined #openstack-nova | 04:02 | |
*** Zames has quit IRC | 04:02 | |
*** fragatina has quit IRC | 04:02 | |
*** Zames has joined #openstack-nova | 04:03 | |
*** germs has quit IRC | 04:03 | |
*** sapd__ has quit IRC | 04:03 | |
*** germs has joined #openstack-nova | 04:04 | |
*** germs has quit IRC | 04:04 | |
*** germs has joined #openstack-nova | 04:04 | |
*** sapd__ has joined #openstack-nova | 04:04 | |
*** yangyapeng has quit IRC | 04:08 | |
*** sapd_ has joined #openstack-nova | 04:11 | |
*** sapd__ has quit IRC | 04:11 | |
*** namnh has joined #openstack-nova | 04:13 | |
*** yingjun has quit IRC | 04:13 | |
*** Zames has quit IRC | 04:13 | |
*** danpawlik has joined #openstack-nova | 04:18 | |
*** salv-orlando has joined #openstack-nova | 04:20 | |
*** Tom-Tom has joined #openstack-nova | 04:22 | |
*** tbachman has quit IRC | 04:23 | |
*** danpawlik has quit IRC | 04:23 | |
*** salv-orlando has quit IRC | 04:24 | |
*** bhujay has joined #openstack-nova | 04:27 | |
*** germs has quit IRC | 04:30 | |
*** jichen has quit IRC | 04:31 | |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 04:33 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 04:33 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 04:33 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 04:33 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 04:33 |
*** yangyapeng has joined #openstack-nova | 04:33 | |
Spaz-Home | How you doing this evening novaers | 04:34 |
*** yangyapeng has quit IRC | 04:38 | |
*** sree has joined #openstack-nova | 04:40 | |
*** fragatina has joined #openstack-nova | 04:50 | |
*** markvoelker has quit IRC | 04:52 | |
*** Kumar__ has joined #openstack-nova | 04:53 | |
*** danpawlik has joined #openstack-nova | 04:55 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in tests/unit/test_utils.py https://review.openstack.org/557883 | 04:58 |
*** danpawlik has quit IRC | 04:59 | |
*** claudiub has joined #openstack-nova | 05:06 | |
*** psachin` has joined #openstack-nova | 05:09 | |
*** salv-orlando has joined #openstack-nova | 05:20 | |
*** harlowja has quit IRC | 05:21 | |
*** salv-orlando has quit IRC | 05:25 | |
*** suresh12 has quit IRC | 05:26 | |
*** danpawlik has joined #openstack-nova | 05:29 | |
*** danpawlik has quit IRC | 05:33 | |
*** sree_ has joined #openstack-nova | 05:34 | |
*** sree_ is now known as Guest23838 | 05:34 | |
*** sree has quit IRC | 05:36 | |
openstackgerrit | Leopard Ma proposed openstack/nova master: fix paused instance not support shelve https://review.openstack.org/541660 | 05:39 |
*** zzzeek has quit IRC | 05:39 | |
*** hoangcx has quit IRC | 05:41 | |
*** tuanla____ has quit IRC | 05:41 | |
*** tuanla____ has joined #openstack-nova | 05:42 | |
*** hoangcx has joined #openstack-nova | 05:42 | |
*** yingjun has joined #openstack-nova | 05:45 | |
*** zzzeek has joined #openstack-nova | 05:50 | |
*** zzzeek has quit IRC | 05:51 | |
openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove ec2 in service and cmd https://review.openstack.org/556778 | 05:51 |
openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150 | 05:51 |
openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove db ec2 https://review.openstack.org/557572 | 05:51 |
*** zzzeek has joined #openstack-nova | 05:52 | |
*** armaan has quit IRC | 05:52 | |
*** armaan has joined #openstack-nova | 05:53 | |
*** markvoelker has joined #openstack-nova | 05:53 | |
*** salv-orlando has joined #openstack-nova | 05:55 | |
*** bhujay has quit IRC | 05:57 | |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: deprecate the config for image handler class path https://review.openstack.org/497201 | 05:58 |
openstackgerrit | Jianghua Wang proposed openstack/nova master: XenAPI: define a new image handler to use vdi streaming https://review.openstack.org/486475 | 05:58 |
*** danpawlik has joined #openstack-nova | 06:00 | |
*** bhujay has joined #openstack-nova | 06:03 | |
*** danpawlik has quit IRC | 06:04 | |
*** Zames has joined #openstack-nova | 06:13 | |
*** kholkina has joined #openstack-nova | 06:16 | |
*** Zames has quit IRC | 06:17 | |
*** Guest23838 has quit IRC | 06:17 | |
*** sree has joined #openstack-nova | 06:17 | |
*** danpawlik has joined #openstack-nova | 06:24 | |
*** sree has quit IRC | 06:28 | |
*** germs has joined #openstack-nova | 06:30 | |
*** germs has quit IRC | 06:30 | |
*** germs has joined #openstack-nova | 06:30 | |
*** moshele has joined #openstack-nova | 06:33 | |
*** sree has joined #openstack-nova | 06:34 | |
*** germs has quit IRC | 06:35 | |
*** mikal has quit IRC | 06:35 | |
*** mikal has joined #openstack-nova | 06:37 | |
*** moshele has quit IRC | 06:38 | |
*** sahid has joined #openstack-nova | 06:38 | |
*** sree has quit IRC | 06:38 | |
*** yamahata has joined #openstack-nova | 06:39 | |
openstackgerrit | jichenjc proposed openstack/nova master: Remove a outdated warning https://review.openstack.org/557898 | 06:43 |
*** xinliang has quit IRC | 06:47 | |
*** alexchadin has joined #openstack-nova | 06:48 | |
*** sree has joined #openstack-nova | 06:51 | |
*** sree has quit IRC | 06:55 | |
*** salv-orlando has quit IRC | 06:57 | |
*** salv-orlando has joined #openstack-nova | 06:57 | |
*** yangyapeng has joined #openstack-nova | 06:58 | |
*** andreas_s has joined #openstack-nova | 06:59 | |
*** yangyapeng has quit IRC | 06:59 | |
openstackgerrit | Danfly proposed openstack/nova master: update availablity_zone in the instances table after live-migration https://review.openstack.org/491226 | 07:00 |
*** xinliang has joined #openstack-nova | 07:01 | |
*** sree has joined #openstack-nova | 07:01 | |
*** salv-orlando has quit IRC | 07:01 | |
*** yangyapeng has joined #openstack-nova | 07:02 | |
*** andreas_s has quit IRC | 07:04 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 07:05 |
*** sree has quit IRC | 07:05 | |
*** damien_r has joined #openstack-nova | 07:09 | |
*** alexchadin has quit IRC | 07:09 | |
*** alexchadin has joined #openstack-nova | 07:09 | |
*** voelzmo has joined #openstack-nova | 07:11 | |
*** voelzmo has quit IRC | 07:16 | |
*** psachin` has quit IRC | 07:16 | |
*** yamahata has quit IRC | 07:16 | |
*** tesseract has joined #openstack-nova | 07:17 | |
*** edmondsw has joined #openstack-nova | 07:21 | |
*** salv-orlando has joined #openstack-nova | 07:23 | |
*** edmondsw has quit IRC | 07:25 | |
*** zhurong has joined #openstack-nova | 07:28 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unnecessary code encoding specification https://review.openstack.org/557903 | 07:29 |
*** _ix has joined #openstack-nova | 07:29 | |
*** namnh_ has joined #openstack-nova | 07:32 | |
*** Rambo has quit IRC | 07:33 | |
*** tetsuro has quit IRC | 07:33 | |
*** namnh has quit IRC | 07:35 | |
*** mvk has quit IRC | 07:36 | |
*** namnh has joined #openstack-nova | 07:36 | |
*** takashin has left #openstack-nova | 07:37 | |
*** namnh_ has quit IRC | 07:37 | |
*** mvk has joined #openstack-nova | 07:41 | |
*** elmaciej has quit IRC | 07:41 | |
*** alexchadin has quit IRC | 07:41 | |
*** Kumar__ has quit IRC | 07:47 | |
openstackgerrit | sahid proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 07:49 |
openstackgerrit | sahid proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 07:49 |
openstackgerrit | sahid proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 07:51 |
openstackgerrit | sahid proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 07:51 |
*** tuanla____ has quit IRC | 07:52 | |
*** tuanla____ has joined #openstack-nova | 07:52 | |
*** sree has joined #openstack-nova | 07:56 | |
*** AlexeyAbashkin has joined #openstack-nova | 07:59 | |
*** Zames has joined #openstack-nova | 07:59 | |
*** Zames has quit IRC | 08:02 | |
openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove ec2 in service and cmd https://review.openstack.org/556778 | 08:10 |
openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150 | 08:10 |
openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove db ec2 https://review.openstack.org/557572 | 08:10 |
*** avolkov has joined #openstack-nova | 08:11 | |
*** mvk has quit IRC | 08:13 | |
*** hoangcx has quit IRC | 08:14 | |
*** namnh has quit IRC | 08:14 | |
*** jichen has joined #openstack-nova | 08:14 | |
*** namnh has joined #openstack-nova | 08:15 | |
*** hoangcx has joined #openstack-nova | 08:15 | |
*** bhujay has quit IRC | 08:16 | |
*** mvk has joined #openstack-nova | 08:17 | |
openstackgerrit | Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795 | 08:21 |
*** Tom-Tom_ has joined #openstack-nova | 08:25 | |
*** Tom-Tom has quit IRC | 08:27 | |
jianghuaw_ | bauzas, hi | 08:32 |
bauzas | hi | 08:32 |
jianghuaw_ | Could you help to have a look at this patch to define traits for maximum display heads? | 08:32 |
jianghuaw_ | https://review.openstack.org/#/c/553277/ | 08:32 |
jianghuaw_ | I will start to work on populating traits to resource providers for Xen. | 08:33 |
jichen | hi sahid: thanks for the review and upload , regarding this comment <You forgot to remove this.> , actually it's used , so the patch https://review.openstack.org/#/c/523387 should be ok now (I think your -1 is on this comment) | 08:36 |
Kevin_Zheng | gibi, Hi, is there still a BP to add more versioned notifications?like for instance update etc. | 08:37 |
sahid | jichen: are you refering get_conn()? | 08:38 |
jichen | sahid: yes, that's I am talking about | 08:38 |
*** bhujay has joined #openstack-nova | 08:39 | |
sahid | i see, but no no we should not use it | 08:39 |
jichen | sahid: ok, I can modify it | 08:39 |
jichen | that's the only reason for -1, right? | 08:39 |
bauzas | oh shit, forgot sahid's spec review :( | 08:39 |
bauzas | sahid: I'll look at your spec today :) | 08:40 |
bauzas | jianghuaw_: sure, I'll try | 08:40 |
sahid | yes, basically have self._reqh = ConnetorRequestHanlder(..) | 08:40 |
jianghuaw_ | bauzas, Thanks. | 08:40 |
sahid | jichen: ^ makes sense? | 08:40 |
*** xinliang has quit IRC | 08:40 | |
sahid | also please check the UT, I did not have updated them | 08:40 |
jichen | sahid: I will run UT locally and upload another patch, thanks a lot! | 08:41 |
openstackgerrit | Merged openstack/nova master: remove a comment about ec2 https://review.openstack.org/555615 | 08:41 |
sahid | jichen: baiscally i don't have strong opinion, you can passan instane of ConnectorRequestHandler to Hypervisor | 08:41 |
sahid | or make Hypeervisor to create it | 08:42 |
*** namnh_ has joined #openstack-nova | 08:42 | |
jichen | yes, I can do that, should not be a big issue :) | 08:42 |
*** namnh has quit IRC | 08:42 | |
sahid | jichen: did you see the comments on the next patch? | 08:42 |
sahid | bauzas: ok no worries | 08:43 |
*** vivsoni_ has joined #openstack-nova | 08:43 | |
jichen | yes, I will figure it out next week as have some private things to handle and have to leave in 30 min , really appreciate your help~ | 08:43 |
bauzas | sahid: the spec is still under review, right? | 08:43 |
*** vivsoni has quit IRC | 08:43 | |
sahid | jichen: no problem, thanks for your patience :) | 08:43 |
sahid | bauzas: yes, jaypipes +2ed it | 08:44 |
jichen | sahid: thank you and have a nice weekend | 08:44 |
sahid | jichen: you too | 08:44 |
*** hshiina has quit IRC | 08:46 | |
*** moshele has joined #openstack-nova | 08:48 | |
*** xinliang has joined #openstack-nova | 08:53 | |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387 | 08:56 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658 | 08:56 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240 | 08:56 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340 | 08:56 |
openstackgerrit | jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344 | 08:56 |
*** voelzmo has joined #openstack-nova | 08:56 | |
*** voelzmo has quit IRC | 08:57 | |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 08:59 |
*** jichen has quit IRC | 09:01 | |
*** edmondsw has joined #openstack-nova | 09:10 | |
*** xinliang has quit IRC | 09:11 | |
openstackgerrit | Jianghua Wang proposed openstack/nova-specs master: Update the vGPU spec https://review.openstack.org/557912 | 09:12 |
bauzas | heh, just saw that only a very few countries work today, including France :) | 09:12 |
openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 09:13 |
*** edmondsw has quit IRC | 09:14 | |
bauzas | jianghuaw_: +2d https://review.openstack.org/#/c/557912/1 | 09:14 |
bauzas | good point | 09:14 |
bauzas | we agreed on using traits for display heads, and not being consumable resourcesd | 09:14 |
jianghuaw_ | bauzas, cool. Thanks:-) | 09:15 |
bauzas | jianghuaw_: that's not in a series, right? | 09:15 |
bauzas | even if in the same topic | 09:15 |
jianghuaw_ | not in a series. | 09:15 |
bauzas | okay | 09:15 |
bauzas | I just want to have that merged sooner than later | 09:15 |
jianghuaw_ | ++ | 09:16 |
*** yikun_jiang is now known as yikun | 09:19 | |
*** roedie has quit IRC | 09:21 | |
*** xinliang has joined #openstack-nova | 09:23 | |
*** esberglu has joined #openstack-nova | 09:24 | |
*** namnh has joined #openstack-nova | 09:27 | |
*** esberglu has quit IRC | 09:29 | |
*** namnh_ has quit IRC | 09:29 | |
*** yingjun has quit IRC | 09:32 | |
*** bhujay has quit IRC | 09:36 | |
*** Roamer` has quit IRC | 09:41 | |
*** Roamer` has joined #openstack-nova | 09:41 | |
*** moshele has quit IRC | 09:45 | |
*** sree has quit IRC | 09:56 | |
*** sree has joined #openstack-nova | 09:57 | |
*** voelzmo has joined #openstack-nova | 09:58 | |
*** sdague has joined #openstack-nova | 10:01 | |
*** voelzmo has quit IRC | 10:04 | |
*** tuanla____ has quit IRC | 10:04 | |
*** voelzmo has joined #openstack-nova | 10:04 | |
*** tuanla____ has joined #openstack-nova | 10:05 | |
jianghuaw_ | bauzas, I will be in vacation in the whole next week. If there is anything need talk relative to XenServer, please involve naichuans or bobball. | 10:07 |
*** cdent has joined #openstack-nova | 10:07 | |
*** yingjun has joined #openstack-nova | 10:09 | |
*** namnh has quit IRC | 10:10 | |
*** vivsoni_ has quit IRC | 10:11 | |
*** vivsoni has joined #openstack-nova | 10:11 | |
openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 10:11 |
*** Tom-Tom_ has quit IRC | 10:12 | |
*** Tom-Tom has joined #openstack-nova | 10:12 | |
*** hoangcx has quit IRC | 10:15 | |
*** hoangcx has joined #openstack-nova | 10:16 | |
*** Tom-Tom has quit IRC | 10:17 | |
*** Tom-Tom has joined #openstack-nova | 10:17 | |
*** tuanla____ has quit IRC | 10:21 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 10:21 |
openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 10:21 |
openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857 | 10:21 |
*** jfding has joined #openstack-nova | 10:22 | |
*** Tom-Tom has quit IRC | 10:22 | |
*** hoangcx has quit IRC | 10:23 | |
*** tiendc has quit IRC | 10:23 | |
*** liverpooler has joined #openstack-nova | 10:24 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 10:29 |
*** zhurong has quit IRC | 10:30 | |
*** AlexeyAbashkin has quit IRC | 10:30 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 10:30 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Add to contributor docs about handler testing https://review.openstack.org/557355 | 10:32 |
*** armaan has quit IRC | 10:34 | |
*** armaan has joined #openstack-nova | 10:35 | |
*** _ix has quit IRC | 10:37 | |
*** AlexeyAbashkin has joined #openstack-nova | 10:43 | |
*** yingjun has quit IRC | 10:49 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 10:52 |
*** sapd_ has quit IRC | 10:52 | |
*** sapd_ has joined #openstack-nova | 10:53 | |
*** andreas_s has joined #openstack-nova | 10:55 | |
*** andreas_s has quit IRC | 11:00 | |
dims | hey cdent, bauzas : is this the only method where we sanitize a end-user provider name to a host name? http://git.openstack.org/cgit/openstack/nova/tree/nova/utils.py#n543 | 11:02 |
dims | cdent : bauzas : has it changed a lot over time? | 11:03 |
*** vivsoni_ has joined #openstack-nova | 11:04 | |
*** vivsoni has quit IRC | 11:04 | |
cdent | dims: sorry, I don't know much about that file nor how/where it is used. Looks like that method last changed in 2015 | 11:04 |
dims | looks like no one has touched it for at least 2 years ... https://github.com/openstack/nova/blame/master/nova/utils.py | 11:04 |
dims | right | 11:04 |
dims | good thing! | 11:04 |
dims | for context, am looking at https://github.com/kubernetes/kubernetes/pull/61890#issuecomment-377282182 | 11:04 |
*** liverpooler has quit IRC | 11:05 | |
cdent | is that instance hostnames? | 11:07 |
cdent | because there's no uniqueness guarantee on those | 11:07 |
*** yingjun has joined #openstack-nova | 11:08 | |
*** moshele has joined #openstack-nova | 11:12 | |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db https://review.openstack.org/556472 | 11:16 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter allocation candidates by forbidden traits in db https://review.openstack.org/556660 | 11:16 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Parse forbidden traits in query strings https://review.openstack.org/556819 | 11:16 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Support forbidden traits in API https://review.openstack.org/556820 | 11:16 |
dims | cdent : y just looking for possibilities | 11:16 |
* cdent nods | 11:16 | |
dims | cdent : oops - found a bug under python3 - see output at bottom of http://paste.openstack.org/show/718009/ | 11:16 |
dims | extra ü | 11:17 |
dims | but that's a digression, basically i am looking for is "given a sanitized host name, is there a way for me to query nova api to get the real vm (or list of vms since no guarantee)" | 11:18 |
* cdent doesn't do nova | 11:19 | |
*** moshele has quit IRC | 11:20 | |
cdent | I certainy hope there's a way | 11:20 |
dims | ack thanks. will look deeper :) | 11:21 |
cdent | If we assume that hostname and instance name are the same thing, listing servers can be filtered by name: https://developer.openstack.org/api-ref/compute/#list-servers (with regex too apparently) | 11:22 |
cdent | but whether that corresponds to this sanitized thing, dunno dims | 11:23 |
* cdent is very low on coffee today | 11:23 | |
*** sree has quit IRC | 11:23 | |
dims | i have a feeling we don't save that sanitized host name anywhere ... mriedem would know, will bug him | 11:24 |
cdent | it appears like the santiization is done during server create and applies to the eventual hostname on the instance objects | 11:25 |
cdent | (I'm in nova/compute/api.py ) | 11:26 |
*** voelzmo has quit IRC | 11:26 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/nova-specs master: Disallow rotation parameter 0 for 'createBackup' API https://review.openstack.org/511825 | 11:27 |
* cdent locates food and coffee | 11:27 | |
*** cdent has quit IRC | 11:29 | |
*** nicolasbock has joined #openstack-nova | 11:31 | |
*** sahid has quit IRC | 11:33 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384 | 11:35 |
*** cdent has joined #openstack-nova | 11:43 | |
openstackgerrit | Merged openstack/nova master: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/497457 | 11:44 |
*** yingjun has quit IRC | 11:47 | |
*** yassine has quit IRC | 11:49 | |
*** yassine has joined #openstack-nova | 11:54 | |
*** kholkina has quit IRC | 12:03 | |
*** kholkina has joined #openstack-nova | 12:04 | |
*** kholkina has quit IRC | 12:06 | |
*** kholkina has joined #openstack-nova | 12:07 | |
*** alexchadin has joined #openstack-nova | 12:10 | |
*** sahid has joined #openstack-nova | 12:18 | |
*** odyssey4me has quit IRC | 12:19 | |
*** odyssey4me has joined #openstack-nova | 12:19 | |
*** markvoelker has quit IRC | 12:20 | |
*** markvoelker has joined #openstack-nova | 12:20 | |
*** markvoelker has quit IRC | 12:23 | |
*** markvoelker has joined #openstack-nova | 12:25 | |
bhagyashris | jaypipes: Hi, | 12:28 |
*** markvoelker has quit IRC | 12:29 | |
*** gongysh has joined #openstack-nova | 12:33 | |
*** gongysh has quit IRC | 12:33 | |
*** markvoelker has joined #openstack-nova | 12:34 | |
*** diga has joined #openstack-nova | 12:36 | |
*** voelzmo has joined #openstack-nova | 12:37 | |
*** gongysh has joined #openstack-nova | 12:37 | |
*** edmondsw has joined #openstack-nova | 12:41 | |
*** liusheng has quit IRC | 12:44 | |
*** liusheng has joined #openstack-nova | 12:44 | |
*** voelzmo has quit IRC | 12:47 | |
openstackgerrit | Claudiu Belu proposed openstack/nova master: tests: autospecs all the mock.patch usages https://review.openstack.org/470775 | 12:50 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: WIP: replace spec with autospec https://review.openstack.org/557299 | 12:51 |
openstackgerrit | Claudiu Belu proposed openstack/nova master: hyper-v: autospec classes before they are instantiated https://review.openstack.org/342211 | 12:52 |
bauzas | dims: sorry, was afk for sports thingy | 12:55 |
*** lyan has joined #openstack-nova | 12:55 | |
bauzas | has cdent answered your question ? | 12:55 |
*** lyan is now known as Guest19514 | 12:55 | |
*** salv-orlando has quit IRC | 12:56 | |
*** salv-orlando has joined #openstack-nova | 12:57 | |
*** salv-orlando has quit IRC | 12:59 | |
*** salv-orlando has joined #openstack-nova | 12:59 | |
*** cdent has quit IRC | 13:01 | |
dims | bauzas : yes, he nudged me forward. so i am at the point where i have an instance name = | 13:05 |
dims | "Ãœmlauts rule!" | 13:05 |
jaypipes | bhagyashris: good morning | 13:05 |
*** jaypipes is now known as leakypipes | 13:05 | |
*** mriedem has joined #openstack-nova | 13:05 | |
dims | curl http://169.254.169.254/latest/meta-data/hostname gives me "mlauts-rule.novalocal" | 13:06 |
bhagyashris | jaypipes: Good morning :) for it's evening ;) | 13:06 |
dims | bauzas : and the "openstack server show" does not have the sanitized host name "mlauts-rule.novalocal" | 13:06 |
dims | bauzas : do we store that somewhere? | 13:06 |
bhagyashris | jaypipes: I want to discuss regarding the shared resource provider and nested resource provider thing. | 13:06 |
*** cdent has joined #openstack-nova | 13:07 | |
* dims waves to leakypipes | 13:07 | |
bhagyashris | jaypipes: I saw the blueprint #link: https://blueprints.launchpad.net/nova/+spec/nested-resource-provider and that is marked as implemented. | 13:07 |
bauzas | dims: are you talking of a i18n'd hostname ? | 13:07 |
bauzas | for the guest ? | 13:07 |
dims | yes | 13:07 |
bauzas | leakypipes: isn't Good Friday for you? | 13:07 |
dims | i believe we use sanitized_hostname in utils.py | 13:07 |
bauzas | and dims as well ? | 13:07 |
dims | bauzas : yep :) | 13:08 |
bauzas | so AFAIR, there are two different things | 13:08 |
leakypipes | dims: morning :) | 13:08 |
bauzas | the display name and the instance hostname | 13:08 |
bauzas | dims: leakypipes: isn't that day off for most of the folks in the US ? | 13:08 |
leakypipes | bauzas: is it? not sure... I don't religion | 13:08 |
bhagyashris | jaypipes: I have tested one scenario which is mentioned in #link: http://paste.openstack.org/show/718016/ and observed that the shared resource provider DISK_GB is not consumed when I boot the instance. (Ideally it should take DISK_GB from shared resource provider and VCPU and MEMORY_MB from compute node resource provider). | 13:08 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/557930 | 13:09 |
bauzas | or, maybe just a company holiday | 13:09 |
bauzas | snaaaaaap | 13:09 |
bauzas | now I see mriedem too | 13:09 |
bhagyashris | jaypipes: I have followed the steps which are mentioned in provided link if I am wrong at any place please correct me. | 13:09 |
bauzas | me who was thinking the nova channel be quiet today afternoon :p | 13:09 |
mriedem | is this the one day of the year that red hat people in the US are on mandatory vacation but france isn't? | 13:09 |
bauzas | leakypipes: and I don't do religion either, but in my country, our religious holidays are off | 13:10 |
mriedem | it's black friday right? | 13:10 |
bauzas | so maybe it's the source of my confusion | 13:10 |
leakypipes | bhagyashris: k, I will look into it later, ok? I need to get some coffee and food (sorry) | 13:10 |
mriedem | oh no... | 13:10 |
dims | bauzas : y, i can use the metadata url to get the hostname and i want to find the correct vm corresponding to that hostname | 13:10 |
mriedem | heh | 13:10 |
mriedem | good friday? | 13:10 |
bauzas | mriedem: yeah, indeed, most of the Red Hat world is shutdown except France | 13:10 |
mriedem | something something christian friday | 13:10 |
efried | oh yeah... | 13:10 |
*** efried is now known as fried_bunny | 13:10 | |
bauzas | take it as an evidence that France is ruling the company | 13:10 |
bhagyashris | leakypipes: ok | 13:11 |
bauzas | dims: I see your point | 13:11 |
dims | bauzas : kubernetes cloud provider scenario | 13:11 |
bauzas | mostly for cloud-init reasons where you wanna set the correct hostname on the guest itself | 13:11 |
bauzas | gotcha | 13:12 |
openstackgerrit | sahid proposed openstack/nova stable/queens: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/557930 | 13:13 |
kashyap | alex_xu_: mriedem: When you get a moment, I think, this is ready: https://review.openstack.org/#/c/534384/21 | 13:13 |
bauzas | dims: so, back to your concern | 13:13 |
bauzas | dims: you wanna make sure that we sanitize hostnames ? | 13:14 |
kashyap | But it's a holiday for Matt, so feel free to disregard it until you get back | 13:14 |
*** naichuans has quit IRC | 13:14 | |
dims | bauzas : we are doing that already, so given a sanitized hostname i can't find the vm by instance name | 13:15 |
sahid | mriedem: hum.. you have already cherry-picked https://review.openstack.org/#/c/497457/ | 13:15 |
bauzas | dims: ah I see | 13:15 |
mriedem | sahid: not supposed to go to stable? | 13:15 |
sahid | i did not noticed that, and cherry-picked it again | 13:15 |
dims | bauzas : "Ãœmlauts rule!" becomes "mlauts-rule.novalocal" | 13:15 |
sahid | mriedem: it is | 13:15 |
mriedem | sahid: oh, that's fine | 13:15 |
sahid | ok | 13:15 |
mriedem | kashyap: at this point i think i want to wait for dan to review that again | 13:15 |
kashyap | Sure, I'm not hurrying | 13:16 |
kashyap | But it is still important for upstream backports; just that the sooner we ship this, the better it is for users. | 13:16 |
*** edleafe is now known as figleaf | 13:17 | |
kashyap | If it could wait this long; it can wait until dansmith gets back on Tue or whenever. | 13:17 |
mriedem | bauzas: can you go through these other pike backports that have a +2? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/pike+label:Code-Review=2 melwitt wants to do a release | 13:17 |
bauzas | mriedem: it's doable for a Friday task | 13:17 |
bauzas | dims: okay, and then per that hostname, you'd like to find the instance ? | 13:18 |
dims | bauzas : yep | 13:18 |
bauzas | well | 13:18 |
bauzas | if that's sanitized, how nova could find up which VM it is ? | 13:18 |
* bauzas looks at the API | 13:19 | |
dims | bauzas : unless we are storing the sanitized host name somewhere and i can search on it using the nova API | 13:19 |
bauzas | dims: I just want to make I correctly understand your wishes | 13:19 |
bauzas | dims: you're looking up the hostname from the guest, right? | 13:20 |
bauzas | dims: then, you try to find which instance it is based on that key ? | 13:20 |
bauzas | because the guest gets the sanitized hostanem | 13:20 |
sahid | lyarwood: if you have a moment to ack that one https://review.openstack.org/#/c/550080/ | 13:20 |
dims | yep bauzas | 13:21 |
*** jfding has quit IRC | 13:21 | |
bauzas | dims: then I need to look at the metadata API | 13:21 |
bauzas | because I wouldn't recommend finding our siblings based on a sanitized key | 13:22 |
dims | bauzas : yep thanks! | 13:23 |
openstackgerrit | Claudiu Belu proposed openstack/nova-specs master: Adds spec for instance live resize https://review.openstack.org/141219 | 13:23 |
*** diga has quit IRC | 13:23 | |
bauzas | dims: which exact metadata key are you using for searching your instance ? | 13:24 |
bauzas | I guess the 'hostname' one | 13:25 |
dims | bauzas : that and local-hostname and public-hostname are all sanitized | 13:26 |
bauzas | https://docs.openstack.org/nova/latest/user/config-drive.html#openstack-metadata-format | 13:26 |
dims | bauzas : am staring at output from "openstack server show" and the various metadata keys | 13:26 |
bauzas | AFAIR, nova show <hostname> takes the display_name | 13:27 |
dims | bauzas : http://169.254.169.254//openstack/2012-08-10/meta_data.json shows the ("name": "\u00dcmlauts rule!") | 13:28 |
dims | bauzas : the ec2 metadata format does not have anything else i could use | 13:29 |
*** burt has joined #openstack-nova | 13:29 | |
bauzas | dims: what I don't know is which API resource is calling openstack server show | 13:29 |
bauzas | because the only GET /servers/<server> takes an UUID AFAIK | 13:30 |
bauzas | https://developer.openstack.org/api-ref/compute/#show-server-details | 13:30 |
*** diga has joined #openstack-nova | 13:30 | |
bauzas | so I guess it's calling the list command https://developer.openstack.org/api-ref/compute/#list-servers | 13:30 |
bauzas | wait, looking at the code | 13:31 |
*** dave-mccowan has joined #openstack-nova | 13:32 | |
bauzas | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L434 | 13:32 |
dims | bauzas : gotcha. thanks for the pointer, i will go look further and get back if i need something else | 13:33 |
bauzas | dims: I can look at the OCS code | 13:34 |
bauzas | OSC | 13:34 |
*** esberglu has joined #openstack-nova | 13:34 | |
*** david-lyle has quit IRC | 13:34 | |
dims | bauzas : no worries, i can do that | 13:35 |
cdent | fried_bunny: if you're cruising through my stuff at the moment, hold off on the forbidden traits, I'm fixing the pep8 issue right now, should be fixed in mere moments | 13:35 |
fried_bunny | cdent: Okay, was just commenting on that. Bizarre one - did we just instate that rule or something? | 13:35 |
fried_bunny | I've never seen pep complain about redef of a var before. | 13:35 |
cdent | I've had a few new things show up lately, so I'm guessing flake8 had an update recently | 13:36 |
fried_bunny | my IDE complains about it | 13:36 |
fried_bunny | Mm. And/or possibly we moved to using py3 for pep now? | 13:36 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter resource providers by forbidden traits in db https://review.openstack.org/556472 | 13:36 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Filter allocation candidates by forbidden traits in db https://review.openstack.org/556660 | 13:36 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Parse forbidden traits in query strings https://review.openstack.org/556819 | 13:36 |
openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Support forbidden traits in API https://review.openstack.org/556820 | 13:36 |
cdent | there go | 13:36 |
bauzas | dims: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L1964 | 13:37 |
*** dave-mccowan has quit IRC | 13:37 | |
dims | bauzas : perfect! you have been very helpful | 13:38 |
bauzas | looks like it calls list | 13:38 |
*** jroll has quit IRC | 13:38 | |
bauzas | but I could be wrong | 13:38 |
fried_bunny | cdent: All done, looking clean. | 13:39 |
dims | bauzas : will run it in debug and find the urls it is hitting | 13:39 |
*** jroll has joined #openstack-nova | 13:39 | |
bauzas | dims: if that's calling the GET /servers directly for a list command, then look at the API doc https://developer.openstack.org/api-ref/compute/#list-servers | 13:39 |
bauzas | dims: for 'hostname', it says " Filter the server list result by the host name of server. This parameter is only valid when specified by administrators. If non-admin users specify this parameter, it is ignored." | 13:39 |
bauzas | dims: I guess you're keystone-admin'd | 13:40 |
bauzas | ? | 13:40 |
dims | bauzas : yep | 13:40 |
bauzas | k, wanted to make sure | 13:40 |
*** dave-mccowan has joined #openstack-nova | 13:40 | |
bauzas | but then, it takes the real instance hostname, not the sanitized one | 13:40 |
bauzas | hence the 404 | 13:40 |
bauzas | what you could do is to query on the private IP | 13:41 |
dims | good point | 13:41 |
*** pooja_jadhav has quit IRC | 13:42 | |
bauzas | dims: there is also a 'name' param that support regexes | 13:42 |
bauzas | anyway, /me goes reviewing things now | 13:42 |
dims | thanks much bauzas ! | 13:44 |
*** alexchadin has quit IRC | 13:47 | |
*** moshele has joined #openstack-nova | 13:47 | |
*** moshele has quit IRC | 13:49 | |
*** mlavalle has joined #openstack-nova | 13:49 | |
figleaf | fried_bunny: you win the good casual friday nick contest! | 13:49 |
fried_bunny | figleaf: Thanks. It was a tossup between that and good_fried_ay, but I wanted people to still be able to find me. | 13:50 |
fried_bunny | figleaf: Also this one expresses subtle disdain for the various institutions that make this day different from any other. | 13:50 |
bauzas | oh shit | 13:51 |
* fried_bunny throws colored egg at bauwzer | 13:51 | |
bauzas | tss tss | 13:51 |
*** bauzas is now known as bauwser | 13:51 | |
figleaf | fried_bunny: true, true. It's the imagery that I like | 13:51 |
cdent | the french police are coming to arrest bauwser for working on an official holiday | 13:51 |
bauwser | with a 's' please | 13:51 |
figleaf | fried_bunny: moreso than a figleaf | 13:51 |
bauwser | cdent: it"s not a holiday here | 13:51 |
bauwser | so I'm sane | 13:51 |
* cdent is not sane | 13:52 | |
fried_bunny | zorry bauwzer | 13:52 |
bauwser | YES, NOT ALL CELEBRATIONS ARE DAY OFF IN FRANCE | 13:52 |
* dims feels good to hangout with his peeps | 13:52 | |
fried_bunny | Only French ones. | 13:52 |
bauwser | well, actually, it's untrue | 13:52 |
bauwser | part of our country is off today | 13:52 |
cdent | I got so much crap from a german colleague yesterday because I was unaware that today was commonly a holiday in europe | 13:52 |
cdent | part? that's bound to be confusing | 13:52 |
bauwser | only the Alsace region ;) | 13:53 |
bauwser | we're a very centralized country except for Alsace :) | 13:53 |
cdent | that explains it: this person is in the german part near there | 13:53 |
*** READ10 has joined #openstack-nova | 13:53 | |
bauwser | well, I live 100 kms away from Swiss | 13:54 |
bauwser | should I take that day off then ? | 13:54 |
dims | bauwser : ask long ask you can ski :) | 13:54 |
bauwser | after all, it's near | 13:54 |
*** jogo has quit IRC | 13:54 | |
bauwser | dims: planned for Monday \o/ | 13:54 |
bauwser | because Monday will be off for me | 13:54 |
dims | haha | 13:54 |
bauwser | last chances for a decent skiing session | 13:55 |
bauwser | fried_bunny: https://review.openstack.org/#/c/557065/ so I guess you're asking me to use a specific YAML file just for that ? :( | 13:58 |
bauwser | fried_bunny: have you seen my counter proposal ? | 13:58 |
bauwser | honestly, given the lack of consensus around a conf option (which I didn't expected at the beginning), I feel I'm about to make the pre-creation of a mediated device a prerequisite for supporting multiple types | 13:59 |
bauwser | if config management systems feel like it's difficult, then we could spec up again on a common format | 14:00 |
fried_bunny | bauwser: Yes, a YAML file which, for now, will contain *some* kind of specification from which you can glean which PCI addresses correspond to allowable devices (so, a whitelist) and which type (eventually types) they support. This will expand as needed to incorporate anything libvirt-device-related. | 14:00 |
bauwser | fried_bunny: out of oslo.config then | 14:01 |
fried_bunny | bauwser: Absolutely. | 14:01 |
fried_bunny | As I stated, oslo_config for JSON/python dicts is ick. | 14:01 |
fried_bunny | bauwser: So if by counter-proposal, you mean the other oslo_config-based JSON format you suggested - yes, I saw it, and it doesn't change my mind :) | 14:01 |
bauwser | fried_bunny: okay, let's wait for a couple of other folks to chime in on the spec (and in particular, leave dansmith voice on your counter proposal), and see what we agree on | 14:02 |
fried_bunny | bauwser: Sounds like a plan. | 14:02 |
bauwser | if we can't settle down on a consensus around a format, I'll abandon my spec and make pre-creations of mediated devices a necessary prerequisite for multiple types support | 14:02 |
bauwser | that would suck for many operators, but we could engage a conversation about the best formatting for them at the Summit | 14:03 |
* bauwser got accepted for YVR btw. \o/ | 14:03 | |
*** yangyapeng has quit IRC | 14:03 | |
fried_bunny | bauwser: Part of my dislike for doing this in conf options is based on my exerience trying to understand pci_passthrough_whitelist. It took me weeks of trial and error to figure out the punctuation/formatting to make it work. And I never got to a point where I actually *understood* what I was doing - just to a point where I had something that worked for my use case. | 14:04 |
fried_bunny | I'll grant you that's an extreme case... but what you're proposing is going to get to that point of complexity very quickly anyway. | 14:04 |
bauwser | fried_bunny: I agree | 14:04 |
fried_bunny | bauwser: We did begin discussions of this YAML thing in Denver, so it's not completely out of left field. | 14:05 |
bauwser | you know, proposing that spec with that proposal is like when you have a terrible kid but you still love it | 14:05 |
*** danpawlik has quit IRC | 14:05 | |
bauwser | because it's your kid | 14:05 |
fried_bunny | I know *exactly* what you mean. | 14:06 |
bauwser | so I'm not like super excited by any solution to a problem that is unrelated to nova | 14:06 |
leakypipes | fried_bunny: a YAML file eh? sounds suspiciously like my provider-config-file proposal. | 14:06 |
bauwser | leakypipes: context is https://review.openstack.org/#/c/557065/ | 14:06 |
bauwser | leakypipes: I mentioned your spec :) | 14:06 |
fried_bunny | leakypipes: Well, IIRC you were the one who said YAML in Denver for device spec files. So I call no coincidence. | 14:07 |
bauwser | that's also in the gerrit comments, with appropriate credits ;) | 14:07 |
fried_bunny | leakypipes: I'm glad to give you the affirmation that IMO it's an excellent idea. | 14:08 |
bauwser | fried_bunny: unrelated, using unregistered IRC nicks is dangerous :p | 14:08 |
fried_bunny | bauwser: Like actually dangerous? Cause the only one I have registered is efried... | 14:08 |
*** bauwser is now known as fried_rice | 14:08 | |
*** fried_rice is now known as bauwser | 14:08 | |
fried_bunny | Oh, *that* kind of dangerous? Meh, I can live with that. | 14:08 |
bauwser | ok, so fried_rice is registered, good. | 14:08 |
fried_bunny | oh, is it, cool. | 14:09 |
fried_bunny | It might not be registered to me, actually. | 14:09 |
fried_bunny | shrug | 14:09 |
fried_bunny | Anyone pretending to be me... deserves what they get :D | 14:09 |
bauwser | indeed, it's not registered to your main account | 14:10 |
*** READ10 has quit IRC | 14:10 | |
*** andreas_s has joined #openstack-nova | 14:11 | |
bauwser | but fried_chicken isn't ;) | 14:11 |
*** kholkina has quit IRC | 14:11 | |
bauwser | oops, I meant fried_bunny | 14:11 |
*** yingjun has joined #openstack-nova | 14:11 | |
fried_bunny | bauwser: fried_bunny is just for today. Maybe through Monday (that's still an Easter thing, right?) | 14:12 |
bauwser | Easter for us is on Monday | 14:12 |
bauwser | Good Friday has nothing to do with egs | 14:13 |
bauwser | eggs | 14:13 |
*** andreas_s has quit IRC | 14:16 | |
fried_bunny | claudiub: in case you're still around, just posted some comments on https://review.openstack.org/#/c/141219/ which should be easy to rev. | 14:18 |
fried_bunny | bauwser: Oh, you see, in the US, the entire month preceding Easter Monday gets completely overrun with bunnies and eggs and garish plastic grass and hideous pastel colors. It's how we capitalist pigs roll. | 14:20 |
bauwser | haha | 14:22 |
*** ediardo has quit IRC | 14:24 | |
leakypipes | bhagyashris: you do not want to specify parent_provider_uuid for your compute node. | 14:25 |
leakypipes | bhagyashris: the shared storage pool is not the parent of the compute node. | 14:26 |
leakypipes | bhagyashris: the relationship between the shared storage pool and the compute node is via the aggregate, not via a parent-child relationship. | 14:26 |
leakypipes | bhagyashris: I'm not sure that we support "re-parenting", so you may need to delete the resource provider records in your placement DB entirely and start over. | 14:27 |
bhagyashris | leakypipes: ok. through aggregate also i have tried and tested but still it's not taking DISK_GB from shared resource provider | 14:27 |
*** suresh12 has joined #openstack-nova | 14:27 | |
leakypipes | bhagyashris: alternately, you could just execute an UPDATE statement directly in the placement DB to fix the provider records up. | 14:27 |
leakypipes | bhagyashris: UPDATE resource_providers SET parent_provider_id = NULL, root_provider_id = $INTERNAL_ID_OF_COMPUTE_NODE WHERE id = $INTERNAL_ID_OF_COMPUTE_NODE; | 14:28 |
leakypipes | bhagyashris: allocations definitely do not yet work when nested providers are present. there may be a bug regarding sharing resource providers, but let's eliminate the nested scenario for starters, ok? | 14:29 |
*** jogo has joined #openstack-nova | 14:30 | |
bhagyashris | leakypipes: you mean to say I will need to update the compute node resource provider | 14:33 |
*** yangyapeng has joined #openstack-nova | 14:33 | |
leakypipes | bhagyashris: correct. | 14:34 |
*** salv-orlando has quit IRC | 14:34 | |
*** salv-orlando has joined #openstack-nova | 14:35 | |
bhagyashris | leakypipes: and on current master the shared resource provider provider is not implemented completely i mean to say that is not taken into account when user rquest to boot the instance | 14:35 |
leakypipes | bhagyashris: yes, it should be. | 14:36 |
leakypipes | bhagyashris: or at least, if the *only* provider of DISK_GB is the shared storage pool (and the compute node doesn't itself have local disk), then everything should work... | 14:36 |
leakypipes | bhagyashris: there is currently a bug where if both the local compute node and a shared pool have DISK_GB resources, that we will always pick the local compute node. | 14:37 |
*** weshay is now known as weshay_mod | 14:37 | |
leakypipes | bhagyashris: tetsuro has been fixing that bug in this patch: https://review.openstack.org/#/c/533396/ | 14:38 |
bhagyashris | leakypipes: aI have debug the code as well and observed that the when user request the boot server then only the compute node resource provider allocation_candidates are return so from that it seems like the shared resource provider is not taken into account while scheduling. | 14:38 |
*** suresh12 has quit IRC | 14:39 | |
*** salv-orlando has quit IRC | 14:39 | |
*** suresh12 has joined #openstack-nova | 14:40 | |
leakypipes | bhagyashris: when both the compute node and the shared pool have inventory of DISK_GB, right? | 14:40 |
leakypipes | bhagyashris: and I'm saying that that is a known bug. | 14:40 |
leakypipes | bhagyashris: being addressed in https://review.openstack.org/#/c/533396/ | 14:40 |
bhagyashris | leakypipes: yes | 14:40 |
bhagyashris | leakypipes: ok. this patch will help me to success my test scenario :) | 14:41 |
*** sree has joined #openstack-nova | 14:41 | |
*** germs has joined #openstack-nova | 14:42 | |
*** germs has quit IRC | 14:42 | |
*** germs has joined #openstack-nova | 14:42 | |
leakypipes | bhagyashris: would be awesome if you were able to apply that patch locally and see if that resolves your issues. | 14:42 |
leakypipes | bhagyashris: :) | 14:42 |
claudiub | fried_bunny: done, thanks. :) | 14:42 |
*** germs has quit IRC | 14:42 | |
*** germs has joined #openstack-nova | 14:43 | |
*** germs has quit IRC | 14:43 | |
*** germs has joined #openstack-nova | 14:43 | |
*** r-daneel has joined #openstack-nova | 14:43 | |
leakypipes | stephenfin, mriedem, dansmith, fried_bunny, melwitt: reviews on the three bottom patches of the patches here from tetsuro would be appreciated: https://review.openstack.org/#/c/533396/ | 14:43 |
fried_bunny | leakypipes: ack | 14:43 |
leakypipes | danke | 14:44 |
leakypipes | fried_bunny: 10-4 good bunny. | 14:44 |
fried_bunny | leakypipes: I'm +1 on the bottom one already FYI | 14:44 |
leakypipes | cool, thanks | 14:45 |
fried_bunny | claudiub: have you posted the rev yet? | 14:45 |
claudiub | amending | 14:45 |
bhagyashris | leakypipes: for testing i will not need to update any shared resource provider entry. I will just need to add all the resource provider under one aggregate and set the traits right? | 14:45 |
claudiub | there was an unclear question | 14:45 |
claudiub | i hope i answered right. can you check? | 14:46 |
leakypipes | bhagyashris: the traits are already set properly, AFAICT | 14:47 |
*** suresh12 has quit IRC | 14:48 | |
leakypipes | bhagyashris: the only thing you'll need to do is change the parent_provider_id and root_provider_id on the compute node resource provider record and then remove the inventory on the compute node for the DISK_GB resource class. | 14:48 |
cdent | kashyap: stein, not solar, sadly | 14:48 |
leakypipes | cdent: sadly would have been a better name. | 14:49 |
cdent | i wanted shellhaus | 14:49 |
cdent | seemed so spot on | 14:49 |
leakypipes | shellout... | 14:49 |
openstackgerrit | Claudiu Belu proposed openstack/nova-specs master: Adds spec for instance live resize https://review.openstack.org/141219 | 14:50 |
cdent | leakypipes, fried_bunny, figleaf, bauwser : I've just published the latest placement update. It's freakin' huge man. We're probably going to need to do some rationalization. | 14:51 |
bhagyashris | leakypipes: ok just confirming: the parent_provider_id will be nulland root_provider_id will be the shared resource provider right? | 14:53 |
leakypipes | cdent: ack | 14:53 |
leakypipes | bhagyashris: no. root_provider_id should be the same value as id column (for the compute node resource provider). | 14:54 |
leakypipes | bhagyashris: and parent_provider_id should be NULL, yes | 14:54 |
*** READ10 has joined #openstack-nova | 14:55 | |
figleaf | cdent: I'll add that as a discussion item for Monday's scheduler meeting | 14:56 |
figleaf | Or are most people off on Monday? (I'm not) | 14:56 |
cdent | rad | 14:57 |
cdent | oh, yeah. I'm supposed to be | 14:57 |
cdent | but meh | 14:57 |
*** tesseract has quit IRC | 14:57 | |
bhagyashris | leakypipes: ok thank you for your inputs I will test this by applying this patch but as i am working in IST time so it's almost End of the day so i will check and will let you know once testing done | 14:57 |
bhagyashris | leakypipes: thank you :) | 14:57 |
leakypipes | bhagyashris: no problem at all. thanks much for your testing help! | 14:57 |
*** tesseract has joined #openstack-nova | 14:57 | |
*** yingjun has quit IRC | 15:00 | |
*** david-lyle has joined #openstack-nova | 15:00 | |
*** r-daneel_ has joined #openstack-nova | 15:02 | |
*** yingjun has joined #openstack-nova | 15:02 | |
*** r-daneel has quit IRC | 15:04 | |
*** r-daneel_ is now known as r-daneel | 15:04 | |
mriedem | leakypipes: musing in https://review.openstack.org/#/c/553122/ | 15:06 |
mriedem | will hold for fried_bunny | 15:06 |
*** sree has quit IRC | 15:09 | |
leakypipes | fried_bunny: did you catch melwitt's question to you on https://review.openstack.org/#/c/533821/? | 15:11 |
*** claudiub|2 has joined #openstack-nova | 15:15 | |
*** claudiub has quit IRC | 15:17 | |
leakypipes | mriedem: left some notes for you on that | 15:19 |
*** salv-orlando has joined #openstack-nova | 15:22 | |
*** david-lyle has quit IRC | 15:24 | |
*** tbachman has joined #openstack-nova | 15:25 | |
*** sree has joined #openstack-nova | 15:26 | |
*** alexchadin has joined #openstack-nova | 15:27 | |
*** imacdonn has quit IRC | 15:27 | |
*** imacdonn has joined #openstack-nova | 15:27 | |
*** tbachman has quit IRC | 15:28 | |
fried_bunny | sorry guys, was afk for a few. Catching up. | 15:30 |
fried_bunny | mriedem: Ack | 15:31 |
*** suresh12 has joined #openstack-nova | 15:31 | |
fried_bunny | leakypipes: Yes, was planning to dig into that today. | 15:31 |
leakypipes | fried_bunny: cool, np. just checking to see if you had | 15:33 |
fried_bunny | yuh, thanks. | 15:33 |
leakypipes | cdent: understatement of the year in your placement update: "There's also been a _lot_ of discussion around NUMA handling" | 15:34 |
fried_bunny | leakypipes: I've slowed myself way down by picking up lots of extra reviews - probably too many, need to scale back some. | 15:34 |
leakypipes | fried_bunny: learn, you will, young paduan. | 15:34 |
*** sree has quit IRC | 15:37 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | 15:37 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 15:37 |
*** alexchadin has quit IRC | 15:38 | |
*** suresh12 has quit IRC | 15:38 | |
*** itlinux has joined #openstack-nova | 15:39 | |
openstackgerrit | Merged openstack/nova-specs master: Update the vGPU spec https://review.openstack.org/557912 | 15:39 |
*** sahid has quit IRC | 15:41 | |
*** damien_r has quit IRC | 15:43 | |
*** felipemonteiro__ has joined #openstack-nova | 15:43 | |
*** _ix has joined #openstack-nova | 15:44 | |
*** diga has quit IRC | 15:45 | |
*** gongysh has quit IRC | 15:47 | |
*** suresh12 has joined #openstack-nova | 15:48 | |
*** suresh12 has quit IRC | 15:53 | |
*** suresh12 has joined #openstack-nova | 15:54 | |
*** yangyapeng has quit IRC | 15:56 | |
*** zhaochao has quit IRC | 15:58 | |
*** suresh12 has quit IRC | 15:58 | |
*** vladikr has joined #openstack-nova | 16:01 | |
*** tesseract has quit IRC | 16:02 | |
*** itlinux has quit IRC | 16:03 | |
*** yamamoto has quit IRC | 16:04 | |
*** yamamoto has joined #openstack-nova | 16:04 | |
*** david-lyle has joined #openstack-nova | 16:05 | |
*** david-lyle has quit IRC | 16:08 | |
*** avolkov has quit IRC | 16:09 | |
*** _ix_ has joined #openstack-nova | 16:10 | |
*** vladikr has quit IRC | 16:12 | |
*** _ix has quit IRC | 16:13 | |
*** yassine has quit IRC | 16:14 | |
*** yingjun has quit IRC | 16:14 | |
openstackgerrit | Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795 | 16:15 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add the 'generation' column to the consumers table https://review.openstack.org/557958 | 16:16 |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add handlers for consumer_generation https://review.openstack.org/557959 | 16:16 |
figleaf | leakypipes: fried_bunny: cdent: ^^ First crack at consumer generations. More to come | 16:17 |
fried_bunny | figleaf: ack | 16:17 |
leakypipes | figleaf: nice, thank you sir. | 16:17 |
cdent | figleaf: I'm going to ignore that until next week please and thank you | 16:18 |
fried_bunny | claudiub|2: Still around? | 16:19 |
*** damien_r has joined #openstack-nova | 16:21 | |
figleaf | cdent: ignore away | 16:23 |
figleaf | :) | 16:23 |
*** yingjun has joined #openstack-nova | 16:23 | |
*** suresh12 has joined #openstack-nova | 16:25 | |
claudiub|2 | fried_bunny: i am now | 16:26 |
cdent | That's it for me today. Happy Easter if that's your thing, happy weekend otherwise. | 16:28 |
claudiub|2 | the autospec stuff? | 16:28 |
claudiub|2 | i''l take a look | 16:28 |
*** cdent has quit IRC | 16:28 | |
*** damien_r has quit IRC | 16:30 | |
*** suresh12 has quit IRC | 16:30 | |
*** AlexeyAbashkin has quit IRC | 16:31 | |
*** sree has joined #openstack-nova | 16:36 | |
*** alexchadin has joined #openstack-nova | 16:39 | |
*** alexchadin has quit IRC | 16:40 | |
*** sree has quit IRC | 16:41 | |
*** yingjun has quit IRC | 16:46 | |
openstackgerrit | Ed Leafe proposed openstack/nova master: Add handlers for consumer_generation https://review.openstack.org/557959 | 16:48 |
*** tbachman has joined #openstack-nova | 16:55 | |
fried_bunny | claudiub|2: Thank you sir. | 16:56 |
fried_bunny | claudiub|2: The failures are really weird. The leading '<' is stripped from the mock repr in the KeyError. Not sure if that's significant. | 16:57 |
openstackgerrit | Roman Dobosz proposed openstack/nova master: Added weight for aggregate soft (anti) affinity. https://review.openstack.org/556762 | 16:58 |
*** sree has joined #openstack-nova | 16:59 | |
*** sree has quit IRC | 17:04 | |
*** itlinux has joined #openstack-nova | 17:06 | |
*** yamahata has joined #openstack-nova | 17:10 | |
openstackgerrit | Merged openstack/nova stable/pike: Only attempt a rebuild claim for an evacuation to a new host https://review.openstack.org/550555 | 17:12 |
openstackgerrit | Merged openstack/nova master: Fix comments in get_all_with_shared() https://review.openstack.org/533195 | 17:12 |
openstackgerrit | Merged openstack/nova stable/pike: Add --by-service to discover_hosts https://review.openstack.org/554603 | 17:13 |
openstackgerrit | Merged openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | 17:13 |
fried_bunny | claudiub|2, edmondsw: It's specifically this part that breaks us: | 17:16 |
fried_bunny | https://review.openstack.org/#/c/447505/44/nova/test.py | 17:16 |
fried_bunny | When I comment out *just* that fixture, we're fine. | 17:16 |
fried_bunny | Which isn't surprising; that's the only part that could have possibly affected us OOT. | 17:16 |
fried_bunny | So - what IS that thing? | 17:16 |
claudiub|2 | you mean what is that fixture? | 17:20 |
fried_bunny | yeah | 17:20 |
claudiub|2 | it adds the autospec argument to mock.Mock and mock.MagicMock | 17:20 |
*** hemna_ has joined #openstack-nova | 17:20 | |
claudiub|2 | which is even more strange, because I don't see how it could have affected this | 17:21 |
*** salv-orlando has quit IRC | 17:22 | |
fried_bunny | claudiub|2: Well, we're inheriting nova.test.TestCase, so that's how we're picking up the change. That much is clear. | 17:22 |
claudiub|2 | since I don't see autospecs being used anywhere | 17:22 |
*** salv-orlando has joined #openstack-nova | 17:23 | |
fried_bunny | claudiub|2: By "it adds the autospec argument" do you mean that it just makes it available, not that it actually sets it to anything? | 17:23 |
claudiub|2 | yep | 17:24 |
claudiub|2 | if autospec is not specifically given, it is noop | 17:24 |
claudiub|2 | question, do you split by underscore somewhere? | 17:24 |
fried_bunny | oh, I'm sure we must | 17:25 |
claudiub|2 | oh | 17:25 |
claudiub|2 | that might be it | 17:25 |
claudiub|2 | yeah, I think I know what's happening | 17:25 |
fried_bunny | ...not seeing it though. | 17:25 |
fried_bunny | okay, do tell. Cause I'm stumped. Mystified. Stupefied. | 17:25 |
*** salv-orlando has quit IRC | 17:27 | |
claudiub|2 | so, you're using a lot of thing.uuid, or thing.name and so on. so, if that property is not set on the mock, something like this is printed: str(mock_thing.foo) -> <_AutospecMock name='mock.foo' id='139796718268752'> | 17:27 |
claudiub|2 | the mock class with autospec is called _AutospecMock | 17:28 |
claudiub|2 | ... and since you're splitting the wrappers by _, it's split in 2 places | 17:28 |
claudiub|2 | because your wrappers are called wrapper_<_AutospecMock name=...> | 17:29 |
fried_bunny | claudiub|2: What if I don't see any splits anywhere? | 17:29 |
fried_bunny | ...by underscore | 17:29 |
claudiub|2 | you sure? I think I saw one | 17:30 |
claudiub|2 | yeh | 17:30 |
claudiub|2 | there is | 17:30 |
claudiub|2 | pypowervm/utils/transaction.py L 744 | 17:31 |
claudiub|2 | you're doing a rsplit | 17:31 |
claudiub|2 | ehm, why rsplit? and not lsplit? | 17:31 |
claudiub|2 | ehm, rsplit is just split. :)) | 17:33 |
fried_bunny | oy vay, my search was broken. I see it now. | 17:33 |
fried_bunny | claudiub|2: I don't think so... | 17:33 |
fried_bunny | claudiub|2: | 17:33 |
fried_bunny | In [2]: 'one_two_three'.rsplit('_', 1) | 17:33 |
fried_bunny | Out[2]: ['one_two', 'three'] | 17:33 |
fried_bunny | In [3]: 'one_two_three'.split('_', 1) | 17:33 |
fried_bunny | Out[3]: ['one', 'two_three'] | 17:33 |
openstackgerrit | Merged openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | 17:34 |
fried_bunny | claudiub|2: It matters when limiting the split | 17:34 |
openstackgerrit | Merged openstack/nova master: Documentation for tenant isolation with placement https://review.openstack.org/557490 | 17:34 |
claudiub|2 | right, anyways, the thing is, the underscore matters apparently | 17:34 |
claudiub|2 | I renamed _AutospecMock to AutospecMock and it worked | 17:34 |
fried_bunny | claudiub|2: And it's because IRL the label part can have underscores, and we want to preserve them. | 17:34 |
fried_bunny | claudiub|2: ...and the UUID doesn't have underscores. Unless it's a str(mock)ification, apparently :P | 17:35 |
claudiub|2 | indeed. :) | 17:36 |
claudiub|2 | well, ok, there are 2 solutions to the problem | 17:36 |
claudiub|2 | one is a bit of a PINTA, so I'll just submit the easier one, but it'll require a new oslotest release | 17:37 |
fried_bunny | claudiub|2: The other one is for us to go set our UUIDs in our mocks? | 17:37 |
fried_bunny | rather than letting them mock themselves | 17:37 |
*** r-daneel_ has joined #openstack-nova | 17:37 | |
claudiub|2 | the easier solution is to rename _AutospecMock and _AutospecMagicMock in oslotest, basically remove that _. I've put that _ there so it would discourage people for using them directly, but meh. | 17:38 |
claudiub|2 | and the other one is as you say | 17:38 |
*** r-daneel has quit IRC | 17:38 | |
*** r-daneel_ is now known as r-daneel | 17:38 | |
*** suresh12 has joined #openstack-nova | 17:38 | |
*** dave-mccowan has quit IRC | 17:39 | |
*** dave-mccowan has joined #openstack-nova | 17:39 | |
fried_bunny | claudiub|2: Okay, please add me to that review. | 17:40 |
fried_bunny | ...and I'll go see if I can find those UUIDs... | 17:40 |
*** itlinux has quit IRC | 17:41 | |
claudiub|2 | fried_bunny: added: https://review.openstack.org/#/c/557974/ | 17:43 |
claudiub|2 | can you run the UT with this patch applied? | 17:43 |
fried_bunny | uhm, I think by cloning the project into my tox env... | 17:43 |
fried_bunny | stand by | 17:43 |
claudiub|2 | yeah. it seems to work for me. Want to double check. | 17:44 |
fried_bunny | claudiub|2: Are you running tox on nova-powervm? | 17:44 |
claudiub|2 | I ran an individual test: python -m unittest nova_powervm.tests.virt.powervm.disk.test_ssp.TestSSPDiskAdapter.test_connect_disk | 17:45 |
fried_bunny | ight | 17:45 |
claudiub|2 | this was one of the failures | 17:45 |
fried_bunny | I'll run the whole suite, sec. | 17:45 |
claudiub|2 | yeap, please do | 17:45 |
fried_bunny | claudiub|2: Is this a LP bug thing, or no? | 17:46 |
openstackgerrit | Merged openstack/nova stable/pike: Re-use existing ComputeNode on ironic rebalance https://review.openstack.org/527423 | 17:46 |
openstackgerrit | Merged openstack/nova stable/pike: Do not set allocation.id in AllocationList.create_all() https://review.openstack.org/530794 | 17:46 |
openstackgerrit | Merged openstack/nova stable/pike: Don't launch guestfs in a thread pool if guestfs.debug is enabled https://review.openstack.org/539541 | 17:46 |
openstackgerrit | Merged openstack/nova stable/pike: unquiesce instance on volume snapshot failure https://review.openstack.org/545966 | 17:46 |
fried_bunny | claudiub|2, edmondsw: Confirmed, that delta fixes us completely. | 17:46 |
claudiub|2 | I'll amend the commit message and add a Related-Bug: #the_mock_autospec_LP_bug_id | 17:46 |
fried_bunny | roger that. | 17:47 |
claudiub|2 | ok, then i'll amend the commit message | 17:47 |
claudiub|2 | gonna push for it to merge, and ask for a new oslotest release next week. they don't release at the end of the week. | 17:47 |
claudiub|2 | sorry for the trouble. :) | 17:48 |
fried_bunny | claudiub|2: No worries; that was pretty unanticipatable. Thank you very much for the help. | 17:49 |
*** gyee has joined #openstack-nova | 17:49 | |
*** AlexeyAbashkin has joined #openstack-nova | 17:49 | |
*** fragatina has quit IRC | 17:49 | |
*** AlexeyAbashkin has quit IRC | 17:53 | |
*** vivek__ has joined #openstack-nova | 17:54 | |
*** hongbin has joined #openstack-nova | 17:55 | |
claudiub|2 | updated commit message | 17:55 |
edmondsw | claudiub|2 good catch and thanks | 17:56 |
*** EmilienM has quit IRC | 17:58 | |
*** suresh12 has quit IRC | 17:59 | |
*** AlexeyAbashkin has joined #openstack-nova | 18:06 | |
*** r-daneel_ has joined #openstack-nova | 18:09 | |
*** r-daneel has quit IRC | 18:10 | |
*** r-daneel_ is now known as r-daneel | 18:10 | |
*** AlexeyAbashkin has quit IRC | 18:10 | |
*** fragatina has joined #openstack-nova | 18:10 | |
fried_bunny | claudiub|2: Finding those mocked attrs wasn't as hard as I thought. | 18:13 |
fried_bunny | Eric Fried proposed openstack/nova-powervm master: Specify UUIDs in VIOS mocks for FeedTasks https://review.openstack.org/557975 | 18:13 |
fried_bunny | If you want to pull your patch, I think I'd be okay with that. (edmondsw, thoughts?) | 18:14 |
*** _ix_ has quit IRC | 18:15 | |
edmondsw | might still be a good idea to keep claudiub's patch so that this weirdness doesn't crop up in other places | 18:15 |
fried_bunny | I'm fine with that too. Weighed against the desire to keep those classes private, though - that's up to claudiub|2 I guess. | 18:16 |
mriedem | why are nova-powervm repo changes showing up in the nova channel? | 18:16 |
fried_bunny | mriedem: Because triggered by a nova change | 18:16 |
mriedem | ? | 18:16 |
mriedem | https://review.openstack.org/#/c/557975/ isn't nova | 18:16 |
fried_bunny | mriedem: Oh, that wasn't a bot, that was a copy/paste by me. | 18:16 |
mriedem | ah | 18:16 |
fried_bunny | thought you were going crazy | 18:16 |
fried_bunny | mriedem: We were discussing here because the trigger was https://review.openstack.org/#/c/447505/ | 18:17 |
mriedem | yar | 18:17 |
mriedem | i noticed an alarming amount of claudiub|2 in the channel | 18:18 |
claudiub|2 | fried_bunny: edmondsw: this should also work, as a temporary hack: https://review.openstack.org/557976 | 18:18 |
fried_bunny | claudiub|2: Cool, that's useful to know. Thanks. | 18:18 |
fried_bunny | claudiub|2: If https://review.openstack.org/557975 doesn't fix us, we'll use that. | 18:19 |
claudiub|2 | gotcha. :) | 18:19 |
*** felipemonteiro_ has joined #openstack-nova | 18:19 | |
claudiub|2 | mriedem: yeah, usually when there's a fire somewhere. :D | 18:20 |
claudiub|2 | because you know, a lot of fire leads to getting fired. ha. | 18:20 |
mriedem | it is that time of the quarter | 18:21 |
*** READ10 has quit IRC | 18:22 | |
*** felipemonteiro__ has quit IRC | 18:24 | |
*** yamamoto_ has joined #openstack-nova | 18:24 | |
*** yamamoto has quit IRC | 18:27 | |
*** gjayavelu has joined #openstack-nova | 18:28 | |
*** salv-orlando has joined #openstack-nova | 18:30 | |
*** itlinux has joined #openstack-nova | 18:31 | |
stephenfin | melwitt: RE: bug 1750672, I already fixed that with https://review.openstack.org/#/c/556894/2 | 18:35 |
openstack | bug 1750672 in OpenStack Compute (nova) "failure to generate Nova's doc in Python 3.6" [Medium,Confirmed] https://launchpad.net/bugs/1750672 | 18:35 |
openstackgerrit | Merged openstack/nova stable/pike: Return 400 when compute host is not found https://review.openstack.org/550707 | 18:37 |
*** avolkov has joined #openstack-nova | 18:39 | |
*** felipemonteiro__ has joined #openstack-nova | 18:46 | |
*** bauwser is now known as bauzas | 18:46 | |
*** vivek__ has quit IRC | 18:47 | |
*** felipemonteiro_ has quit IRC | 18:49 | |
*** felipemonteiro__ has quit IRC | 18:50 | |
*** felipemonteiro__ has joined #openstack-nova | 18:51 | |
*** r-daneel has quit IRC | 18:55 | |
fried_bunny | melwitt: On vacation, yah? | 18:57 |
mriedem | yes, mandatory pto | 18:58 |
*** gjayavelu has quit IRC | 19:02 | |
fried_bunny | leakypipes: I answered here https://review.openstack.org/#/c/533821/ -- in your estimation was there something more she was expecting to see in the tests? | 19:03 |
*** r-daneel has joined #openstack-nova | 19:03 | |
*** _ix has joined #openstack-nova | 19:04 | |
*** felipemonteiro_ has joined #openstack-nova | 19:07 | |
*** Sukhdev has joined #openstack-nova | 19:08 | |
openstackgerrit | Merged openstack/nova stable/pike: Always deallocate networking before reschedule if using Neutron https://review.openstack.org/555907 | 19:11 |
*** felipemonteiro__ has quit IRC | 19:11 | |
*** itlinux has quit IRC | 19:17 | |
fried_bunny | leakypipes: Likewise https://review.openstack.org/#/c/520246/ | 19:20 |
*** Sukhdev has quit IRC | 19:21 | |
*** Sukhdev has joined #openstack-nova | 19:23 | |
*** yamamoto_ has quit IRC | 19:23 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove unnecessary code encoding specification https://review.openstack.org/557903 | 19:27 |
*** yamamoto has joined #openstack-nova | 19:33 | |
*** yamamoto has quit IRC | 19:38 | |
*** felipemonteiro_ has quit IRC | 19:38 | |
*** sree has joined #openstack-nova | 19:38 | |
*** felipemonteiro__ has joined #openstack-nova | 19:38 | |
*** fragatina has quit IRC | 19:43 | |
*** sree has quit IRC | 19:43 | |
*** vivsoni_ has quit IRC | 19:44 | |
*** vivsoni has joined #openstack-nova | 19:44 | |
*** yamamoto has joined #openstack-nova | 19:48 | |
*** Sukhdev has quit IRC | 19:50 | |
*** yamamoto has quit IRC | 19:52 | |
leakypipes | fried_bunny: yeah, I'm just not sure :( | 19:53 |
*** itlinux has joined #openstack-nova | 19:55 | |
*** david-lyle has joined #openstack-nova | 19:56 | |
*** _ix has quit IRC | 19:59 | |
*** r-daneel has quit IRC | 19:59 | |
*** itlinux has quit IRC | 20:02 | |
*** yamamoto has joined #openstack-nova | 20:03 | |
fried_bunny | mriedem: If you were waiting for my nod on https://review.openstack.org/#/c/553122/ it's done. | 20:05 |
mriedem | ack | 20:06 |
*** sree has joined #openstack-nova | 20:07 | |
*** yamamoto has quit IRC | 20:07 | |
*** r-daneel has joined #openstack-nova | 20:08 | |
*** yamamoto has joined #openstack-nova | 20:09 | |
*** _ix has joined #openstack-nova | 20:10 | |
*** sree has quit IRC | 20:11 | |
openstackgerrit | Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795 | 20:13 |
*** yamamoto has quit IRC | 20:13 | |
mriedem | gah, trying to mock context managers, my old nemesis | 20:16 |
*** edmondsw has quit IRC | 20:17 | |
*** yamamoto has joined #openstack-nova | 20:18 | |
openstackgerrit | Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795 | 20:20 |
*** Guest19514 has quit IRC | 20:20 | |
*** felipemonteiro__ has quit IRC | 20:23 | |
*** yamamoto has quit IRC | 20:23 | |
*** mordred has quit IRC | 20:26 | |
*** gjayavelu has joined #openstack-nova | 20:26 | |
*** mordred has joined #openstack-nova | 20:27 | |
fried_bunny | mriedem: Ditto https://review.openstack.org/#/c/533396/ | 20:29 |
fried_bunny | mriedem: I can help with that if you like. Or were you just grumbling? | 20:30 |
mriedem | i think i've got a way around it | 20:30 |
*** vladikr has joined #openstack-nova | 20:32 | |
*** armaan has quit IRC | 20:33 | |
*** yamamoto has joined #openstack-nova | 20:33 | |
*** armaan has joined #openstack-nova | 20:33 | |
*** yamamoto has quit IRC | 20:38 | |
mriedem | ugh | 20:39 |
mriedem | with mock.patch.object(self.compute, 'virtapi') as fake_virtapi: | 20:39 |
mriedem | fake_virtapi.return_value.wait_for_instance_event.side_effect = exc | 20:39 |
mriedem | i must be blind | 20:39 |
mriedem | that is not hitting | 20:39 |
mriedem | or | 20:42 |
mriedem | with mock.patch.object(self.compute.virtapi, | 20:42 |
mriedem | 'wait_for_instance_event') as wait_for_event: | 20:42 |
mriedem | wait_for_event.return_value.__enter__.return_value.side_effect = exc | 20:42 |
*** r-daneel has quit IRC | 20:43 | |
fried_bunny | mriedem: Is self.compute.virtapi a method or a property? | 20:43 |
mriedem | it's an attribute | 20:43 |
fried_bunny | mriedem: Then take out .return_value | 20:43 |
mriedem | with a wait_for_instance_event method | 20:43 |
fried_bunny | (in the first paste) | 20:44 |
*** r-daneel has joined #openstack-nova | 20:45 | |
*** mchlumsky has quit IRC | 20:45 | |
mriedem | i don't think the first one will work, | 20:46 |
mriedem | wait_for_instance_event is a context manager, | 20:46 |
mriedem | so need to mock the __enter__ | 20:46 |
fried_bunny | okay, but fake_virtapi.return_value will never hit, because it's not self.compute.virtapi().wait_for_instance_event - just self.compute.virtapi.wait_for_instance_event, right? | 20:47 |
fried_bunny | so that's a start... | 20:47 |
mriedem | right | 20:48 |
*** yamamoto has joined #openstack-nova | 20:48 | |
fried_bunny | mriedem: Is it FakeVirtAPI you're actually using here? | 20:48 |
mriedem | no | 20:48 |
fried_bunny | ComputeVirtAPI? | 20:48 |
mriedem | also, trying to model this after https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute_api.py#L1749 | 20:49 |
mriedem | yeah it's ComputeVirtAPI in this case | 20:49 |
*** yamamoto has quit IRC | 20:49 | |
*** yamamoto has joined #openstack-nova | 20:49 | |
*** yamamoto has quit IRC | 20:49 | |
mriedem | i don't think using FakeVirtAPI will help, since that also defines wait_for_instance_event as a context manager | 20:49 |
mriedem | it's just a noop | 20:50 |
openstackgerrit | Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795 | 20:50 |
fried_bunny | mriedem: No, was just going to suggest the possibility of using a mock.patch('....ComputeVirtAPI') instead of a mock.patch.object. | 20:50 |
fried_bunny | mriedem: But okay, I think I see the problem. | 20:50 |
fried_bunny | Try this: | 20:50 |
fried_bunny | with mock.patch.object(self.compute.virtapi, 'wait_for_instance_event') as wait_for_event: | 20:51 |
fried_bunny | wait_for_event.return_value.__enter__.side_effect = exc | 20:51 |
fried_bunny | you had a different mistake in each attempt. | 20:51 |
mriedem | i just tried that, | 20:51 |
mriedem | believe me, i've tried about every iteration of this | 20:51 |
mriedem | anyway, trying something else here | 20:52 |
fried_bunny | mriedem: I'm not sure that mocking wait_for_instance_event as if it were a context manager is going to do what you expect. | 20:54 |
fried_bunny | (well, clearly not) | 20:54 |
fried_bunny | because it's using the decorator instead of being a real context manager. | 20:54 |
fried_bunny | You could try | 20:55 |
fried_bunny | with mock.patch('nova.compute.manager.ComputeVirtAPI#wait_for_instance_event') as w4ie: | 20:55 |
fried_bunny | w4ie.side_effect = exc | 20:55 |
fried_bunny | s/#/./ | 20:55 |
mriedem | as far as i can tell, what i'm doing is basically the same as https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute_api.py#L1749 | 20:55 |
mriedem | just a different context manager | 20:55 |
fried_bunny | ahh | 20:56 |
*** felipemonteiro__ has joined #openstack-nova | 20:56 | |
*** salv-orlando has quit IRC | 20:56 | |
mriedem | but wait a sec, i might have something else screwed up here | 20:56 |
fried_bunny | I don't actually know whether side_effect does the right thing for yield. Though I guess it should... | 20:56 |
*** salv-orlando has joined #openstack-nova | 20:57 | |
*** Sukhdev has joined #openstack-nova | 20:59 | |
*** salv-orlando has quit IRC | 21:00 | |
mriedem | got it | 21:03 |
mriedem | it wasn't even the mock, it was the thing i was using as the exc | 21:03 |
mriedem | i knew it would be dumb | 21:03 |
fried_bunny | mriedem: Good, because I just tried it out in mini form and it's all working like it's sposedta | 21:03 |
*** r-daneel has quit IRC | 21:05 | |
*** AlexeyAbashkin has joined #openstack-nova | 21:05 | |
*** mvk has quit IRC | 21:07 | |
*** r-daneel has joined #openstack-nova | 21:09 | |
*** AlexeyAbashkin has quit IRC | 21:09 | |
*** yassine has joined #openstack-nova | 21:14 | |
*** edmondsw has joined #openstack-nova | 21:14 | |
*** sree has joined #openstack-nova | 21:14 | |
*** salv-orlando has joined #openstack-nova | 21:15 | |
*** armaan has quit IRC | 21:17 | |
*** armaan has joined #openstack-nova | 21:18 | |
imacdonn | mriedem: around ? | 21:18 |
*** sree has quit IRC | 21:18 | |
*** edmondsw has quit IRC | 21:19 | |
*** yamahata has quit IRC | 21:20 | |
*** yamahata has joined #openstack-nova | 21:20 | |
mriedem | depends | 21:24 |
*** felipemonteiro__ has quit IRC | 21:24 | |
imacdonn | mriedem: heh ... looking at https://review.openstack.org/#/c/554759/ | 21:24 |
imacdonn | mriedem: I think that's the wrong fix ... I think the right fix is to remove the check entirely | 21:25 |
mriedem | ? | 21:26 |
mriedem | placement is required to start nova-compute | 21:26 |
imacdonn | mriedem: see Sylvain's comment on https://bugs.launchpad.net/nova/+bug/1751692 | 21:26 |
openstack | Launchpad bug 1751692 in OpenStack Compute (nova) "os_region_name an unnecessary required option for placement " [Low,Triaged] - Assigned to Digambar (digambarpatil15) | 21:26 |
mriedem | since ocata | 21:26 |
imacdonn | Isn't the recommendation to only specify region_name if you need to override what keystone offers ? | 21:26 |
*** itlinux has joined #openstack-nova | 21:26 | |
mriedem | i don't think region_name gets a default | 21:27 |
imacdonn | and it doesn't *need* a default | 21:27 |
*** itlinux has quit IRC | 21:27 | |
mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#placement.os_region_name | 21:27 |
*** harlowja has joined #openstack-nova | 21:28 | |
imacdonn | the check was originally put there for people upgrading from newton to ocata, to catch the case where they didn't notice that placement must be configured (where it was not required before) | 21:28 |
imacdonn | but we're way past that now .. if you don't have placement configured, it'll be very obvious | 21:29 |
mriedem | well, | 21:29 |
mriedem | if you're using the FilterScheduler yeah, but not if you're using the CachingScheduler which doesn't use placement | 21:29 |
mriedem | but we do want the computes putting inventory information into placement so we can eventually migrate CachingScheduler users | 21:30 |
mriedem | idk, maybe it's ok to remove at this point, | 21:30 |
*** r-daneel has quit IRC | 21:30 | |
mriedem | we don't fail to start nova-compute if you're using neutron but dont have [neutron] creds configured | 21:30 |
mriedem | but that's required also | 21:30 |
imacdonn | I forget how it failed for me when I had no [placement] config, but it was pretty obvious | 21:30 |
openstackgerrit | Merged openstack/nova master: remove unnecessary short cut in placement https://review.openstack.org/553122 | 21:31 |
imacdonn | yeah | 21:31 |
imacdonn | I think it was a safety check that maybe made sense at the time, but it's not needed now | 21:31 |
*** r-daneel has joined #openstack-nova | 21:31 | |
imacdonn | ... and, if such a check really is needed, it should check some config option that's actually required | 21:32 |
mriedem | maybe you can convince fried_bunny to update https://review.openstack.org/#/c/557086/ to do what you want | 21:32 |
imacdonn | region_name is not required to be set, other than by this check | 21:32 |
*** felipemonteiro__ has joined #openstack-nova | 21:33 | |
fried_bunny | I was wondering about that. | 21:33 |
imacdonn | that does look related .... I think if we remove the check, that test would be removed with it | 21:33 |
fried_bunny | agree with that. | 21:34 |
fried_bunny | But yeah, I was wondering why we were checking for region_name, since I didn't think it was required. | 21:34 |
imacdonn | yeah, so... we could either update your change, or abandon it and do a new one ... either way, it should "Closes-Bug: 1751692" | 21:36 |
openstack | bug 1751692 in OpenStack Compute (nova) "os_region_name an unnecessary required option for placement " [Low,Triaged] https://launchpad.net/bugs/1751692 - Assigned to Digambar (digambarpatil15) | 21:36 |
fried_bunny | imacdonn: Any idea what *would* be a required opt in the [placement] section? | 21:36 |
mriedem | watch out | 21:37 |
fried_bunny | mriedem: Would it be the worst thing for us to change that check to actually go grab the version document from placement as a (better) way of assuring that it's configured? | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Teardown networking when rolling back live migration even if shared disk https://review.openstack.org/555481 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: DRY up test_rollback_live_migration_set_migration_status https://review.openstack.org/555489 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Avoid unnecessary port update during live migration https://review.openstack.org/556332 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | 21:38 |
* imacdonn ducks | 21:38 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 21:38 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001 | 21:38 |
*** avolkov has quit IRC | 21:38 | |
mriedem | fried_bunny: imacdonn: idk, definitely not something i care to think about when i'm about 10 minutes from a 4 day break | 21:39 |
mriedem | i'm sure dansmith would like to make this is first thing monday morning | 21:39 |
mriedem | *his | 21:39 |
imacdonn | mriedem fried_bunny dansmith: it can wait (from my perspective) ... I was mostly treating it as "low-hanging fruit" | 21:40 |
*** gjayavelu has quit IRC | 21:42 | |
fried_bunny | imacdonn: Are you interested in writing some code for this? | 21:42 |
imacdonn | fried_bunny: I was interested in a simple patch to remove the check and associated unit-test... beyond that, probably not really (have bigger fish to fry) | 21:43 |
fried_bunny | imacdonn: The fix wouldn't be much more than that. | 21:44 |
imacdonn | heheh ... or bunnies to fry, as the case may be ;) | 21:44 |
fried_bunny | imacdonn: Instead of just removing the check, replace it with something like: | 21:44 |
fried_bunny | try: | 21:44 |
fried_bunny | self.reportclient.get('/') | 21:44 |
fried_bunny | except: | 21:44 |
fried_bunny | raise exception.PlacementNotConfigured() | 21:44 |
imacdonn | I can give that a go ... I actually want to see what happens if placement is not configured and there's no check first, though | 21:46 |
fried_bunny | coolcool. Feel free to add me (efried) to the review if you do decide to spin something up. | 21:47 |
imacdonn | fried_bunny mriedem http://paste.openstack.org/show/718043/ | 21:48 |
imacdonn | that's what I get if there's no [placement] section in my compute's nova.conf | 21:48 |
*** mriedem is now known as mriedem_afk | 21:49 | |
imacdonn | looks pretty obvious to me | 21:49 |
fried_bunny | imacdonn: ...and you removed that region_name check? | 21:49 |
imacdonn | although maybe with different scheduler config, it'd be less-so | 21:49 |
*** yamamoto has joined #openstack-nova | 21:50 | |
imacdonn | yeah, I commented out the check | 21:50 |
fried_bunny | imacdonn: I amend my suggested code change above. It should be more like: | 21:52 |
fried_bunny | if self.reportclient.get('/') is None: | 21:52 |
fried_bunny | raise... | 21:52 |
fried_bunny | Then you'll get that auth warning as well as the PlacementNotConfigured exception. | 21:53 |
*** yamamoto has quit IRC | 21:56 | |
imacdonn | hmm, doesn't seem to be working ... still experimenting | 21:57 |
fried_bunny | oh | 21:58 |
fried_bunny | imacdonn: You don't need auth to get the version document. So if placement is actually running and there's a service catalog entry for it, that will succeed. | 21:59 |
*** _ix_ has joined #openstack-nova | 21:59 | |
imacdonn | well, it's getting the MissingAuthPlugin, so it doesn't actually get to raise the PlacementNotConfigured | 21:59 |
fried_bunny | Right. | 21:59 |
fried_bunny | I assume you have the service running and there's an entry for it in the service catalog? | 21:59 |
*** _ix has quit IRC | 21:59 | |
fried_bunny | ...but no [placement] section in your conf. | 21:59 |
imacdonn | right | 22:00 |
*** yassine has quit IRC | 22:00 | |
fried_bunny | The version document doesn't require authentication, and we'll get the endpoint from the service catalog, so get('/') will actually work. And then you'll blow up later when you try to hit a real URI. | 22:00 |
fried_bunny | And I contend that's actually the behavior we want. | 22:00 |
fried_bunny | If you shut down your placement service and try again, I think you'll get the PlacementNotConfigured error. | 22:00 |
imacdonn | that's not really what this check was intended for, though | 22:01 |
imacdonn | (originally, at least) | 22:01 |
fried_bunny | well, it was to make sure you had "configured" placement. It didn't previously do anything to ensure you'd configured it *right*. Heck, it wasn't even checking a thing that you had to have, clearly. | 22:02 |
*** burt has quit IRC | 22:02 | |
imacdonn | in my interpretation, it was to check that you had the compute service configured to use placement, not to check that placement is functional | 22:03 |
*** felipemonteiro__ has quit IRC | 22:03 | |
fried_bunny | okay, I can buy that interpretation. In which case maybe auth stuff not being empty is more appropriate to check for in here. | 22:04 |
fried_bunny | because correct me if I'm wrong, but you *can't* get by without e.g. [placement]auth_type ? | 22:05 |
imacdonn | I thought so, but Matt said something about different scheduler options, so I lost confidence for a bit | 22:05 |
fried_bunny | shit, if there's a scheduler option that doesn't use placement, then why are we enforcing that you have it set up when you're not using that scheduler option. | 22:06 |
imacdonn | "mriedem> but we do want the computes putting inventory information into placement so we can eventually migrate CachingScheduler users" | 22:06 |
fried_bunny | Whatever, this is probably a better thing to discuss on Monday or Tuesday when people who were around for the inception of this check are back from worshipping egg-laying rabbits. | 22:06 |
imacdonn | you mean chocolate-egg-laying rabbits, of course | 22:07 |
imacdonn | try: | 22:12 |
imacdonn | if self.reportclient.get('/') is None: | 22:12 |
imacdonn | log.error('placement is not working - I should raise ' | 22:12 |
imacdonn | 'some sort of exception here') | 22:12 |
imacdonn | except keystone_exception.MissingAuthPlugin: | 22:12 |
imacdonn | raise exception.PlacementNotConfigured() | 22:12 |
imacdonn | (maybe - "thinking out loud") | 22:12 |
*** fragatina has joined #openstack-nova | 22:15 | |
*** fragatina has quit IRC | 22:15 | |
*** fragatina has joined #openstack-nova | 22:16 | |
fried_bunny | imacdonn: MissingAuthPlugin will never happen there. | 22:16 |
imacdonn | it does, if the placement config is missing | 22:16 |
fried_bunny | It gets swallowed by @safe_connect | 22:16 |
fried_bunny | No, you get a warning about it, but the exception doesn't get raised. | 22:16 |
imacdonn | I tried it | 22:17 |
imacdonn | I mean - I tried the code above, with no placement config, and it did what I expected | 22:17 |
fried_bunny | that pastebin you showed me had the warning right above an unrelated exception. Did you see something different another way? | 22:17 |
imacdonn | I think that unrelated warning was caused by something that the scheduler happened to do that time ... I don't usually see that warning on startup | 22:18 |
fried_bunny | The warning was coming from the report client trying to bootstrap the compute node inventory. | 22:19 |
fried_bunny | through placement | 22:19 |
fried_bunny | which hits @safe_connect, which catches MissingAuthPlugin and prints that warning.... and then does nothing. Like, implicitly returns None. Which is why you got that NoneType blah blah error. | 22:20 |
imacdonn | http://paste.openstack.org/show/718047/ | 22:20 |
imacdonn | that's with code pasted above, and missing config | 22:21 |
*** mlavalle has quit IRC | 22:21 | |
*** Sukhdev has quit IRC | 22:21 | |
fried_bunny | imacdonn: Are you running on master? | 22:22 |
imacdonn | no, this is queens | 22:22 |
fried_bunny | if you curl the base placement URI, do you get the version document or a 401? | 22:23 |
*** salv-orlando has quit IRC | 22:23 | |
imacdonn | {"versions": [{"min_version": "1.0", "max_version": "1.17", "id": "v1.0"}]} | 22:23 |
*** salv-orlando has joined #openstack-nova | 22:24 | |
fried_bunny | oh - .get isn't wrapped by safe_connect. Let me see where that MissingAuthPlugin business is coming from. | 22:24 |
fried_bunny | though it would be easier for you to find out - by removing the try/except and seeing what .get raises all by itself. | 22:25 |
imacdonn | can do | 22:25 |
fried_bunny | _create_client | 22:25 |
fried_bunny | get_ksa_adapter | 22:25 |
fried_bunny | ...something in ksa loading... | 22:25 |
fried_bunny | is my guess. | 22:25 |
fried_bunny | load_auth_from_conf_options | 22:26 |
imacdonn | http://paste.openstack.org/show/718048/ | 22:26 |
*** salv-orlando has quit IRC | 22:28 | |
fried_bunny | oh, interesting - we actually let you load up the ksa adapter; and it fails on the request. But still, that's weird; you shouldn't need auth to get the version document. | 22:29 |
fried_bunny | What happens when you shut down the placement service? | 22:30 |
imacdonn | ConnectFailure | 22:30 |
imacdonn | from ksa trying to do a GET request | 22:31 |
fried_bunny | mm | 22:32 |
fried_bunny | Well, I'm not happy that you're getting MissingAuthPlugin for /. But it's what you'll get for anything else you try, so that's not the end of the world. | 22:33 |
imacdonn | I guess that the client doesn't know that auth is not required to get the version | 22:34 |
*** Sukhdev has joined #openstack-nova | 22:34 | |
fried_bunny | mordred will not be happy about that. Or maybe it's my fault. | 22:34 |
fried_bunny | anyway, it's sounding like to cover bases we may want to do something like .get('/resource_providers?name=bogus'), which *should* require auth, and catch both MissingAuthPlugin and ConnectFailure and convert those to PlacementNotConfigured. | 22:35 |
fried_bunny | imacdonn: If that's more than you want to take on, or if you want to write part of it and then hand it off, put something somewhere and flag me on it. | 22:37 |
*** hongbin has quit IRC | 22:38 | |
imacdonn | fried_bunny: that doesn't seem too bad ... have to think through unit test implications too, though | 22:39 |
fried_bunny | I'd be fine just mocking .get. One case to raise MissingAuthPlugin, one to raise ConnectError. Done. | 22:40 |
fried_bunny | (and of course one to make it return successfully) | 22:40 |
imacdonn | yeah, that makes sense | 22:40 |
fried_bunny | (which is probably already covered elsewhere) | 22:40 |
imacdonn | I'll fiddle with that a bit ... and maybe we can discuss further with the others next week | 22:41 |
fried_bunny | Sounds great. | 22:41 |
*** swamireddy has quit IRC | 22:41 | |
imacdonn | thanks! :) | 22:41 |
*** andreas_s has joined #openstack-nova | 22:42 | |
imacdonn | just '/resource_providers' should work? That seems to require auth, and provides a meaningful result | 22:46 |
*** andreas_s has quit IRC | 22:48 | |
*** yamamoto has joined #openstack-nova | 22:52 | |
fried_bunny | imacdonn: If you had a lot of resource providers, it could be slowish. Adding the ?name=bogus should make it very quick (even if you have a provider named 'bogus') | 22:53 |
fried_bunny | I *think* that returns a result with an empty payload (as opposed to a 404). | 22:54 |
imacdonn | will try it | 22:54 |
imacdonn | re. the ConnectError ... IMO it's OK to just let that go ... it should be plenty-obvious what need to be done | 22:55 |
* figleaf is worn out debuggin his mess | 22:56 | |
*** figleaf is now known as edleafe | 22:57 | |
fried_bunny | imacdonn: wfm | 22:57 |
*** yamamoto has quit IRC | 22:57 | |
imacdonn | try: | 22:58 |
imacdonn | LOG.info(self.reportclient.get('/resource_providers?name=justcheckin')) | 22:58 |
imacdonn | except keystone_exception.MissingAuthPlugin: | 22:58 |
imacdonn | raise exception.PlacementNotConfigured() | 22:58 |
fried_bunny | imacdonn: Though the message about placement being required would still be useful there. | 22:58 |
imacdonn | confirm that that still gets a 200 ... logging is just to determine that | 22:58 |
imacdonn | thing is, the actual message that gets logged is "PlacementNotConfigured: This compute is not configured to talk to the placement service. Configure the [placement] section of nova.conf and restart the service." | 22:59 |
*** andreas_s has joined #openstack-nova | 22:59 | |
imacdonn | IMO, the placement service being down is not the same thing | 22:59 |
*** sdague has quit IRC | 22:59 | |
*** r-daneel has quit IRC | 23:00 | |
fried_bunny | fair and true. | 23:01 |
fried_bunny | imacdonn: I was thinking of the message that @safe_connect spews as being the useful one. | 23:01 |
fried_bunny | imacdonn: this one: 'Placement is optional in Newton, but required in Ocata. ' | 23:02 |
fried_bunny | 'Please enable the placement service before upgrading.' | 23:02 |
fried_bunny | though that's probably pretty obsolete at this point. | 23:02 |
imacdonn | yeah | 23:03 |
*** edmondsw has joined #openstack-nova | 23:03 | |
*** andreas_s has quit IRC | 23:04 | |
*** mriedem_afk has quit IRC | 23:06 | |
*** edmondsw has quit IRC | 23:08 | |
imacdonn | eep .... 27 unit tests fail with the code-change... this is going to be fun :) | 23:13 |
fried_bunny | imacdonn: In how many test classes? You should be able to mock the reportclient.get in their respective setUp()s. | 23:14 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow scheduling only to enabled cells (Filter Scheduler) https://review.openstack.org/550527 | 23:16 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add --enable and --disable options to nova-manage update_cell https://review.openstack.org/555416 | 23:16 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Update the cells FAQs and scheduler maintenance docs. https://review.openstack.org/556459 | 23:16 |
imacdonn | at least 6 different classes :/ | 23:19 |
*** salv-orlando has joined #openstack-nova | 23:24 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: test live_migration_wait_for_vif_plug=True https://review.openstack.org/558006 | 23:26 |
*** salv-orlando has quit IRC | 23:29 | |
*** vladikr has quit IRC | 23:30 | |
*** vladikr has joined #openstack-nova | 23:30 | |
*** lbragstad has quit IRC | 23:41 | |
*** swamireddy has joined #openstack-nova | 23:45 | |
*** hemna_ has quit IRC | 23:48 | |
*** yangyapeng has joined #openstack-nova | 23:49 | |
*** Swanson has quit IRC | 23:53 | |
fried_bunny | leakypipes: still around? | 23:53 |
*** yamamoto has joined #openstack-nova | 23:53 | |
*** yamamoto has quit IRC | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!