| *** salv-orlando has joined #openstack-nova | 00:00 | |
| *** salv-orlando has quit IRC | 00:05 | |
| *** esberglu has quit IRC | 00:14 | |
| *** gyee has quit IRC | 00:18 | |
| *** fragatina has quit IRC | 00:25 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Return anchor providers in a_r and p_s https://review.openstack.org/558014 | 00:27 |
|---|---|---|
| fried_bunny | leakypipes: tetsuro: ^ | 00:27 |
| *** harlowja has quit IRC | 00:28 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | 00:28 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 00:28 |
| *** itlinux has joined #openstack-nova | 00:31 | |
| *** claudiub|2 has quit IRC | 00:32 | |
| *** _ix_ has quit IRC | 00:34 | |
| *** Sukhdev has quit IRC | 00:38 | |
| *** tetsuro has joined #openstack-nova | 00:39 | |
| *** andreas_s has joined #openstack-nova | 00:41 | |
| *** markvoelker has quit IRC | 00:41 | |
| tetsuro | @fried_bunny: Thank you! Let me look into that on Monday. | 00:45 |
| tetsuro | It's already Saturday here. I should go to see the cherry blossoms today :) | 00:45 |
| *** andreas_s has quit IRC | 00:46 | |
| *** yamamoto has joined #openstack-nova | 00:46 | |
| *** fragatina has joined #openstack-nova | 00:49 | |
| *** yangyapeng has quit IRC | 00:50 | |
| *** armaan has quit IRC | 00:51 | |
| *** yangyapeng has joined #openstack-nova | 00:51 | |
| *** odyssey4me has quit IRC | 00:51 | |
| *** odyssey4me has joined #openstack-nova | 00:51 | |
| *** edmondsw has joined #openstack-nova | 00:51 | |
| *** yamamoto has quit IRC | 00:52 | |
| openstackgerrit | Merged openstack/nova stable/pike: compute: Cleans up allocations after failed resize https://review.openstack.org/548584 | 00:53 |
| *** fragatina has quit IRC | 00:54 | |
| *** yangyapeng has quit IRC | 00:55 | |
| *** edmondsw has quit IRC | 00:56 | |
| *** tetsuro has quit IRC | 00:58 | |
| Spaz-Home | Cherry blossumes starting to bloom in Korea | 01:07 |
| Spaz-Home | I wish I could head into the mountains | 01:07 |
| *** Sukhdev has joined #openstack-nova | 01:14 | |
| *** owalsh_ has joined #openstack-nova | 01:16 | |
| *** owalsh has quit IRC | 01:20 | |
| *** owalsh_ is now known as owalsh | 01:20 | |
| *** yangyapeng has joined #openstack-nova | 01:21 | |
| *** yangyapeng has quit IRC | 01:25 | |
| *** Sukhdev has quit IRC | 01:30 | |
| *** itlinux has quit IRC | 01:35 | |
| *** Zames has joined #openstack-nova | 01:39 | |
| *** andreas_s has joined #openstack-nova | 01:39 | |
| *** Zames has quit IRC | 01:43 | |
| *** yamamoto has joined #openstack-nova | 01:46 | |
| *** Spaz-Work has joined #openstack-nova | 01:51 | |
| *** Spazmotic has quit IRC | 01:51 | |
| *** andreas_s has quit IRC | 01:54 | |
| *** yangyapeng has joined #openstack-nova | 01:58 | |
| *** yangyapeng has quit IRC | 02:03 | |
| *** itlinux has joined #openstack-nova | 02:09 | |
| *** Zames has joined #openstack-nova | 02:10 | |
| *** Zames has quit IRC | 02:13 | |
| *** yamahata has quit IRC | 02:32 | |
| *** fragatin_ has joined #openstack-nova | 02:39 | |
| *** yamamoto has quit IRC | 02:40 | |
| *** arvindn05 has joined #openstack-nova | 02:42 | |
| *** germs has quit IRC | 02:42 | |
| *** markvoelker has joined #openstack-nova | 02:42 | |
| *** germs has joined #openstack-nova | 02:43 | |
| *** germs has quit IRC | 02:43 | |
| *** germs has joined #openstack-nova | 02:43 | |
| *** yamamoto has joined #openstack-nova | 02:51 | |
| *** fragatin_ has quit IRC | 02:59 | |
| *** andreas_s has joined #openstack-nova | 03:01 | |
| *** sree has joined #openstack-nova | 03:03 | |
| *** harlowja has joined #openstack-nova | 03:05 | |
| *** andreas_s has quit IRC | 03:07 | |
| *** sree has quit IRC | 03:08 | |
| *** markvoelker has quit IRC | 03:16 | |
| *** dave-mccowan has quit IRC | 03:24 | |
| *** zhurong has joined #openstack-nova | 03:24 | |
| *** yangyapeng has joined #openstack-nova | 03:27 | |
| *** yangyapeng has quit IRC | 03:28 | |
| *** yangyapeng has joined #openstack-nova | 03:33 | |
| *** yangyapeng has quit IRC | 03:34 | |
| *** harlowja has quit IRC | 03:40 | |
| *** germs has quit IRC | 04:02 | |
| *** germs has joined #openstack-nova | 04:03 | |
| *** germs has quit IRC | 04:03 | |
| *** germs has joined #openstack-nova | 04:03 | |
| *** AlexeyAbashkin has joined #openstack-nova | 04:05 | |
| *** AlexeyAbashkin has quit IRC | 04:10 | |
| *** markvoelker has joined #openstack-nova | 04:13 | |
| *** nicolasbock has quit IRC | 04:21 | |
| *** itlinux has quit IRC | 04:34 | |
| *** fragatina has joined #openstack-nova | 04:38 | |
| *** andreas_s has joined #openstack-nova | 04:41 | |
| *** andreas_s has quit IRC | 04:46 | |
| *** markvoelker has quit IRC | 04:47 | |
| *** zhurong has quit IRC | 04:54 | |
| *** Zames has joined #openstack-nova | 05:06 | |
| *** Zames has quit IRC | 05:09 | |
| *** Kevin_Zheng has quit IRC | 05:25 | |
| *** moshele has joined #openstack-nova | 05:34 | |
| *** andreas_s has joined #openstack-nova | 05:41 | |
| *** Kumar has joined #openstack-nova | 05:43 | |
| *** markvoelker has joined #openstack-nova | 05:44 | |
| Kumar | hello | 05:44 |
| Kumar | I am finding difficulty on running guru meditation report while selinux mode set as enforcing | 05:45 |
| Kumar | here is the trace: | 05:46 |
| Kumar | nova-api: return self._proc.ppid() | 05:46 |
| Kumar | nova-api: File "/usr/lib64/python2.7/site-packages/psutil/_pslinux.py", line 1092, in wrapper | 05:46 |
| Kumar | nova-api: raise AccessDenied(self.pid, self._name) | 05:46 |
| Kumar | nova-api: AccessDenied: psutil.AccessDenied (pid=1) | 05:46 |
| Kumar | nova-api: Unable to run Guru Meditation Report! | 05:46 |
| Kumar | any solution? | 05:46 |
| *** andreas_s has quit IRC | 05:46 | |
| *** yamamoto has quit IRC | 05:59 | |
| *** moshele has quit IRC | 06:17 | |
| *** markvoelker has quit IRC | 06:18 | |
| *** psachin` has joined #openstack-nova | 06:22 | |
| *** vivsoni has quit IRC | 06:23 | |
| *** vivsoni has joined #openstack-nova | 06:23 | |
| *** licanwei has quit IRC | 06:23 | |
| *** vivsoni_ has joined #openstack-nova | 06:25 | |
| *** vivsoni has quit IRC | 06:25 | |
| *** Kumar has quit IRC | 06:35 | |
| *** Kumar has joined #openstack-nova | 06:36 | |
| *** Kumar has quit IRC | 06:41 | |
| *** vivsoni_ has quit IRC | 06:48 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 06:49 |
| *** yamamoto has joined #openstack-nova | 07:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 07:01 |
| *** yamamoto has quit IRC | 07:06 | |
| *** tesseract has joined #openstack-nova | 07:11 | |
| *** armaan has joined #openstack-nova | 07:11 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145 | 07:27 |
| *** fragatina has quit IRC | 07:35 | |
| *** avolkov has joined #openstack-nova | 07:38 | |
| *** zhurong has joined #openstack-nova | 07:44 | |
| *** yamamoto has joined #openstack-nova | 08:02 | |
| *** yamamoto has quit IRC | 08:08 | |
| *** markvoelker has joined #openstack-nova | 08:14 | |
| *** armaan has quit IRC | 08:24 | |
| *** andreas_s has joined #openstack-nova | 08:31 | |
| *** andreas_s has quit IRC | 08:35 | |
| *** edmondsw has joined #openstack-nova | 08:38 | |
| *** zhurong has quit IRC | 08:44 | |
| *** markvoelker has quit IRC | 08:48 | |
| *** yamamoto has joined #openstack-nova | 09:04 | |
| *** yamamoto has quit IRC | 09:09 | |
| *** kukacz has quit IRC | 09:13 | |
| *** kukacz has joined #openstack-nova | 09:14 | |
| *** yangyapeng has joined #openstack-nova | 09:32 | |
| *** psachin` has quit IRC | 09:39 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: [placement] Add test for provider summaries https://review.openstack.org/558044 | 09:42 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add unrequested resources to provider_summaries https://review.openstack.org/558045 | 09:42 |
| *** tetsuro has joined #openstack-nova | 09:43 | |
| *** markvoelker has joined #openstack-nova | 09:45 | |
| *** tetsuro has left #openstack-nova | 09:51 | |
| *** edmondsw has quit IRC | 09:52 | |
| *** yingjun has joined #openstack-nova | 09:59 | |
| *** yamamoto has joined #openstack-nova | 10:05 | |
| *** yamamoto has quit IRC | 10:11 | |
| *** hoonetorg has quit IRC | 10:14 | |
| *** markvoelker has quit IRC | 10:18 | |
| *** hoonetorg has joined #openstack-nova | 10:31 | |
| *** yangyapeng has quit IRC | 10:32 | |
| *** yangyapeng has joined #openstack-nova | 10:33 | |
| *** yingjun has quit IRC | 10:38 | |
| *** yassine has joined #openstack-nova | 10:41 | |
| *** yangyapeng has quit IRC | 10:41 | |
| *** andreas_s has joined #openstack-nova | 10:42 | |
| *** andreas_s has quit IRC | 10:49 | |
| *** edmondsw has joined #openstack-nova | 10:57 | |
| *** edmondsw has quit IRC | 11:01 | |
| *** yamamoto has joined #openstack-nova | 11:07 | |
| *** yamamoto has quit IRC | 11:13 | |
| *** Zames has joined #openstack-nova | 11:22 | |
| *** Zames has quit IRC | 11:22 | |
| *** yamamoto has joined #openstack-nova | 11:30 | |
| *** tinwood has quit IRC | 11:35 | |
| *** tinwood has joined #openstack-nova | 11:36 | |
| *** markvoelker has joined #openstack-nova | 12:15 | |
| *** dave-mccowan has joined #openstack-nova | 12:42 | |
| *** odyssey4me has quit IRC | 12:44 | |
| *** odyssey4me has joined #openstack-nova | 12:44 | |
| *** edmondsw has joined #openstack-nova | 12:45 | |
| *** dave-mccowan has quit IRC | 12:45 | |
| *** markvoelker has quit IRC | 12:49 | |
| *** edmondsw has quit IRC | 12:49 | |
| *** vladikr has quit IRC | 12:55 | |
| *** yamamoto has quit IRC | 13:27 | |
| *** tbachman has quit IRC | 13:28 | |
| *** yamamoto has joined #openstack-nova | 13:29 | |
| *** tbachman has joined #openstack-nova | 13:29 | |
| *** yamamoto has quit IRC | 13:34 | |
| *** Tom-Tom has joined #openstack-nova | 13:36 | |
| *** yingjun has joined #openstack-nova | 13:37 | |
| *** yingjun has quit IRC | 13:38 | |
| *** yingjun has joined #openstack-nova | 13:39 | |
| *** dave-mccowan has joined #openstack-nova | 13:40 | |
| *** Tom-Tom has quit IRC | 13:40 | |
| *** yamamoto has joined #openstack-nova | 13:44 | |
| *** yangyapeng has joined #openstack-nova | 13:46 | |
| *** yamamoto has quit IRC | 13:49 | |
| *** Spaz-Work has quit IRC | 13:49 | |
| *** Spaz-Work has joined #openstack-nova | 13:52 | |
| *** yingjun has quit IRC | 13:54 | |
| *** yamamoto has joined #openstack-nova | 13:59 | |
| *** yangyapeng has quit IRC | 13:59 | |
| *** yangyapeng has joined #openstack-nova | 14:02 | |
| *** yassine has quit IRC | 14:02 | |
| *** yangyapeng has quit IRC | 14:03 | |
| *** yamamoto has quit IRC | 14:04 | |
| *** yamamoto has joined #openstack-nova | 14:14 | |
| *** dave-mccowan has quit IRC | 14:15 | |
| *** yamamoto has quit IRC | 14:19 | |
| *** imacdonn has quit IRC | 14:28 | |
| *** yamamoto has joined #openstack-nova | 14:29 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix cancel_all_events event name parsing https://review.openstack.org/558059 | 14:30 |
| *** edmondsw has joined #openstack-nova | 14:33 | |
| *** yamamoto has quit IRC | 14:34 | |
| *** edmondsw has quit IRC | 14:38 | |
| *** Kumar has joined #openstack-nova | 14:40 | |
| *** yamamoto has joined #openstack-nova | 14:44 | |
| *** moshele has joined #openstack-nova | 14:46 | |
| *** markvoelker has joined #openstack-nova | 14:46 | |
| *** yamamoto has quit IRC | 14:49 | |
| *** germs has quit IRC | 14:56 | |
| *** germs has joined #openstack-nova | 14:57 | |
| *** andreas_s has joined #openstack-nova | 14:57 | |
| *** yamamoto has joined #openstack-nova | 14:59 | |
| *** andreas_s has quit IRC | 15:02 | |
| *** yamamoto has quit IRC | 15:04 | |
| *** moshele has quit IRC | 15:09 | |
| *** r-daneel has joined #openstack-nova | 15:14 | |
| *** yamamoto has joined #openstack-nova | 15:14 | |
| *** yamamoto has quit IRC | 15:19 | |
| *** markvoelker has quit IRC | 15:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | 15:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | 15:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | 15:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | 15:25 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | 15:25 |
| *** yamamoto has joined #openstack-nova | 15:29 | |
| *** yamamoto has quit IRC | 15:34 | |
| *** lbragstad has joined #openstack-nova | 15:35 | |
| *** yamamoto has joined #openstack-nova | 15:44 | |
| *** yamamoto has quit IRC | 15:49 | |
| *** yamamoto has joined #openstack-nova | 15:59 | |
| *** yikun_jiang has joined #openstack-nova | 16:02 | |
| *** yikun has quit IRC | 16:03 | |
| *** yamamoto has quit IRC | 16:04 | |
| *** liusheng has quit IRC | 16:05 | |
| *** liusheng has joined #openstack-nova | 16:05 | |
| *** lbragstad has quit IRC | 16:10 | |
| *** liusheng has quit IRC | 16:12 | |
| *** liusheng has joined #openstack-nova | 16:12 | |
| *** yamamoto has joined #openstack-nova | 16:14 | |
| *** markvoelker has joined #openstack-nova | 16:17 | |
| *** tesseract has quit IRC | 16:17 | |
| *** mvk has joined #openstack-nova | 16:19 | |
| fried_bunny | cdent: here's one for ya: https://bugs.launchpad.net/nova/+bug/1760322 | 16:20 |
| openstack | Launchpad bug 1760322 in OpenStack Compute (nova) "Traits not synced if first retrieval fails" [Undecided,New] | 16:20 |
| *** edmondsw has joined #openstack-nova | 16:22 | |
| *** yamamoto has quit IRC | 16:22 | |
| *** yikun_jiang has quit IRC | 16:23 | |
| *** yikun_jiang has joined #openstack-nova | 16:23 | |
| *** edmondsw has quit IRC | 16:26 | |
| *** Yikun has joined #openstack-nova | 16:27 | |
| *** hongbin has joined #openstack-nova | 16:29 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test case: traits don't sync if first access fails https://review.openstack.org/558066 | 16:29 |
| fried_bunny | cdent: There's the test case ^ | 16:29 |
| *** yikun_jiang has quit IRC | 16:29 | |
| *** tbachman has quit IRC | 16:33 | |
| *** r-daneel has quit IRC | 16:40 | |
| *** armaan has joined #openstack-nova | 16:41 | |
| openstackgerrit | Merged openstack/nova master: Fix allocation_candidates not to ignore shared RPs https://review.openstack.org/533396 | 16:44 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Don't declare traits synced if they ain't https://review.openstack.org/558068 | 16:48 |
| fried_bunny | cdent: And a (wrong) fix ^ | 16:48 |
| fried_bunny | leakypipes: I'm sure you know how to do this right (see commit message) | 16:48 |
| *** markvoelker has quit IRC | 16:49 | |
| *** Kumar__ has joined #openstack-nova | 16:51 | |
| *** Kumar has quit IRC | 16:55 | |
| *** hongbin has quit IRC | 17:01 | |
| *** voelzmo has joined #openstack-nova | 17:12 | |
| *** voelzmo has quit IRC | 17:15 | |
| *** fragatina has joined #openstack-nova | 17:15 | |
| *** yamamoto has joined #openstack-nova | 17:18 | |
| *** voelzmo has joined #openstack-nova | 17:20 | |
| *** yamamoto has quit IRC | 17:24 | |
| *** voelzmo has quit IRC | 17:26 | |
| *** imacdonn has joined #openstack-nova | 17:33 | |
| *** voelzmo has joined #openstack-nova | 17:34 | |
| *** voelzmo has quit IRC | 17:39 | |
| *** voelzmo has joined #openstack-nova | 17:40 | |
| *** andreas_s has joined #openstack-nova | 17:41 | |
| *** voelzmo has quit IRC | 17:45 | |
| *** andreas_s has quit IRC | 17:45 | |
| *** markvoelker has joined #openstack-nova | 17:46 | |
| *** Kumar__ has quit IRC | 17:59 | |
| *** armaan has quit IRC | 18:01 | |
| *** itlinux has joined #openstack-nova | 18:01 | |
| *** armaan has joined #openstack-nova | 18:01 | |
| *** yamamoto has joined #openstack-nova | 18:20 | |
| *** markvoelker has quit IRC | 18:21 | |
| *** avolkov has quit IRC | 18:21 | |
| *** yamamoto has quit IRC | 18:26 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: vSCSI volume driver https://review.openstack.org/526094 | 18:27 |
| openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add test for provider summaries https://review.openstack.org/558044 | 18:29 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add unrequested resources to provider_summaries https://review.openstack.org/558045 | 18:29 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | 18:29 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Support relay RP for allocation candidates https://review.openstack.org/533437 | 18:29 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Return anchor providers in a_r and p_s https://review.openstack.org/558014 | 18:29 |
| imacdonn | fried_bunny: you around ? | 18:33 |
| fried_bunny | imacdonn: Yeaux | 18:33 |
| fried_bunny | you admining my placement hacking? | 18:34 |
| fried_bunny | heh, admiring | 18:34 |
| fried_bunny | Not sure what admining is. But it sounds profitable. | 18:34 |
| imacdonn | admining is a thankless task ... if it has sys- as a prefix, at least | 18:34 |
| fried_bunny | oh, as in "doing admin things". I read it as "ad mining" | 18:35 |
| fried_bunny | I agree admin-ing doesn't sound as profitable | 18:35 |
| imacdonn | and it may actually be a real word! https://english.stackexchange.com/questions/115422/administrating-vs-admining | 18:36 |
| imacdonn | er anyway, I was poking at the unit tests for this placement-is-configured check thing | 18:36 |
| imacdonn | all the tests that create a compute service as a fixture are failing | 18:37 |
| fried_bunny | (article declaims NOT a real word - slang only) | 18:37 |
| imacdonn | I don't know much about fixtures | 18:37 |
| fried_bunny | Have you posted anything on gerrit yet that I can have a gander at? | 18:37 |
| imacdonn | negative .. wanted to get it to pass tox first | 18:38 |
| imacdonn | simple test case where it fails.... http://paste.openstack.org/show/718086/ | 18:38 |
| imacdonn | I don't know how to mock things in a fixture, if that even makes sense | 18:38 |
| fried_bunny | yeah, okay; it must be getting mocked out *somewhere* or a shit ton of the other tests would be failing previously. I wonder if we're just mocking out the report client everywhere. | 18:41 |
| fried_bunny | How many failures are you seeing when you run the world? | 18:42 |
| imacdonn | there are like 26 other tests that fail .. I just picked that one because it's really simple | 18:42 |
| fried_bunny | How many different files/classes are the failures in? | 18:43 |
| imacdonn | at least 6 | 18:43 |
| *** hongbin has joined #openstack-nova | 18:43 | |
| imacdonn | you just sparked a thought, though ... now looking for mentions of reportclient under tests/ | 18:44 |
| imacdonn | like ... nova/tests/unit/compute/test_compute_mgr.py: @mock.patch.object(self.compute, 'reportclient') | 18:44 |
| imacdonn | not sure if any use fixtures, though | 18:44 |
| fried_bunny | They wouldn't need to, if they all mock the reportclient. A fixture is basically a way to make a complicated mock/mock.patch. | 18:45 |
| fried_bunny | Do all of the failures have self.start_service('compute') in the stack trace? | 18:45 |
| imacdonn | certainly the majority of them do | 18:46 |
| imacdonn | the nova.tests.unit.api.openstack.compute.test_services.ServicesTestV253 are a bit different | 18:47 |
| fried_bunny | Well, just to try things out, find nova.test.TestCase.start_service | 18:48 |
| imacdonn | actually scratch that .. it just looks different in the trace due to multi-line | 18:48 |
| fried_bunny | and under the name == 'compute' conditional, add: | 18:48 |
| fried_bunny | self.useFixture(nova_fixtures.PlacementFixture()) | 18:50 |
| imacdonn | I thought about something like that ... but I also don't know where the fixture gets its config from | 18:50 |
| fried_bunny | It uses the conf patcher :) | 18:50 |
| fried_bunny | ...which is instantiated further down the line. | 18:51 |
| imacdonn | ok, but where does that get its config from :) | 18:51 |
| fried_bunny | It's *possible* it gets layered. | 18:52 |
| fried_bunny | Which is kinda cool. | 18:52 |
| *** itlinux has quit IRC | 18:52 | |
| fried_bunny | I think you make conf changes in tests via self.flags | 18:52 |
| imacdonn | but that wouldn't be the config for the fixture (?) | 18:54 |
| imacdonn | seems like it'd have to be passed through start_service() somehow | 18:56 |
| fried_bunny | It is, because the fixture is basically mocking conf entirely. I think. | 18:56 |
| fried_bunny | If you look at nova.tests.unit.conf_fixture.ConfFixture, it's setting a veritable plethora of things. | 18:57 |
| imacdonn | yes, but in that case, the fixture itself is the code being tested | 18:58 |
| fried_bunny | eh? | 18:58 |
| fried_bunny | You mean in the case you're trying to write? | 18:59 |
| imacdonn | in that case "self" is a fixture ... in the other cases, they create fixtures, but "self" is not the fixture. so "self.conf" wouldn't help .. I think | 18:59 |
| fried_bunny | (no, cause you took out the conf checking) | 18:59 |
| *** moshele has joined #openstack-nova | 18:59 | |
| fried_bunny | Okay, let's back up. Why do you think you care about conf for this test? | 19:00 |
| imacdonn | because the compute service fixture needs to have the auth_method (etc.) set, otherwise it'll throw that MissingPlugin | 19:00 |
| imacdonn | MissingAuthPlugin* | 19:01 |
| fried_bunny | Will it? Even with the PlacementFixture in place? | 19:01 |
| imacdonn | I think so .. it's not failing because the service is not there .. it's failing because of that MissingAuthPlugin | 19:02 |
| imacdonn | I assume we need to fix both | 19:02 |
| fried_bunny | It's only getting that far because you're not mocking out the service. | 19:02 |
| imacdonn | I guess I'm looking at it the other way around | 19:03 |
| imacdonn | from my perspective, it's not getting far enough to actually try to use the service, because ksa is kicking back that MissingAuthPlugin, because it's not configured | 19:04 |
| fried_bunny | okay, I think I see what you're getting at. But actually, I suspect MissingAuthPlugin is only happening *after* (and *because*) ksa already retrieved the version document. | 19:05 |
| fried_bunny | Humor me and try that useFixture I mentioned above. You don't have to run the whole world with it - just try one suite | 19:07 |
| imacdonn | huh .. interesting .. I guess I don't know enough about how ksa works | 19:07 |
| fried_bunny | nobody does. | 19:07 |
| fried_bunny | nobody. | 19:07 |
| imacdonn | I already humo[u]red .. and it seems to work | 19:07 |
| imacdonn | heh | 19:07 |
| fried_bunny | excellent. Now, I don't think that's what we want to do here anyway; it's a bit of a big hammer. But it's good to know we're looking under the right rock. | 19:08 |
| imacdonn | it does seem like the right thing to do (to have the tests need the placement service to be there) | 19:09 |
| fried_bunny | or, actually... maybe it's not so bad. Let me take a closer look at that fixture. | 19:09 |
| imacdonn | trying a full set of tests now .. just did that one simple one before | 19:09 |
| imacdonn | so now failing on 6 .. better than 27 | 19:10 |
| *** tbachman has joined #openstack-nova | 19:10 | |
| fried_bunny | show | 19:12 |
| imacdonn | http://paste.openstack.org/show/718087/ | 19:15 |
| *** spotz has quit IRC | 19:16 | |
| *** armaan has quit IRC | 19:16 | |
| imacdonn | in start_service(), the conditional is ... if name == 'compute' and self.USES_DB: | 19:17 |
| fried_bunny | ah | 19:17 |
| *** armaan has joined #openstack-nova | 19:17 | |
| imacdonn | not sure what self.USES_DB is .... may need to move my fixture to aseparate conditional | 19:17 |
| *** markvoelker has joined #openstack-nova | 19:17 | |
| imacdonn | that fixed one of the 6, at least | 19:18 |
| fried_bunny | The rest are in test_compute_mgr - you can just use that same line to instantiate the fixture in the setUp of that guy | 19:18 |
| imacdonn | but not the second :) | 19:18 |
| imacdonn | ok | 19:19 |
| fried_bunny | ...which is bypassing start_service cause it actually wants to test the stuff the service fixture mocks out | 19:19 |
| *** moshele has quit IRC | 19:21 | |
| imacdonn | yeah, that makes sense | 19:21 |
| *** yamamoto has joined #openstack-nova | 19:22 | |
| imacdonn | ok, now down to 1 failing under test_compute_mgr .. I suspect that there's a specific test for the old-style config check | 19:22 |
| imacdonn | actually no, it's failing differently | 19:22 |
| imacdonn | http://paste.openstack.org/show/718088/ - haven't studied yet | 19:22 |
| fried_bunny | well, that's the exact test case you're gonna want to tweak for your change. | 19:24 |
| imacdonn | oh yeah, duh... I was kinda right the first time | 19:24 |
| fried_bunny | and that exception is happening waaaay later than you want to let that sucker go. | 19:24 |
| imacdonn | I was focused on the exception, and not the test it came from | 19:25 |
| fried_bunny | That's the point at which you want to mock that .get to do horrible things and then assert that you raise PlacementNotConfigured. | 19:25 |
| fried_bunny | Now | 19:25 |
| imacdonn | right | 19:25 |
| fried_bunny | you may wish to put the fixture into an instance var in your setUp | 19:25 |
| fried_bunny | so that you can shove your mock side effect right into that guy. | 19:25 |
| *** itlinux has joined #openstack-nova | 19:26 | |
| fried_bunny | Or you could just @mock.patch('....SchedulerReportClient.get') on your test method. | 19:26 |
| fried_bunny | but | 19:26 |
| fried_bunny | I'm not sure the latter will work because the PlacementFixture is monkey patching that guy. | 19:26 |
| fried_bunny | Still might work | 19:26 |
| *** armaan has quit IRC | 19:27 | |
| fried_bunny | actually probably will, because otherwise those other tests doing same would be failing. Unless they're all doing mock.patch.object. Which actually - do whatever they're doing, and it should work. | 19:27 |
| *** armaan has joined #openstack-nova | 19:27 | |
| *** itlinux has quit IRC | 19:27 | |
| *** yamamoto has quit IRC | 19:27 | |
| imacdonn | k, looking into that ... mock stuff is far from intuitive for me, so usually need to plagiarise ;) | 19:28 |
| *** lyan has joined #openstack-nova | 19:29 | |
| *** lyan is now known as Guest52181 | 19:29 | |
| fried_bunny | using the right bit of the fixture is the proper way to do it, but it can be a pain to figure out what that is. | 19:30 |
| fried_bunny | In this case you should just be able to decorate your test method with | 19:31 |
| fried_bunny | @mock.patch('nova.scheduler.client.report.SchedulerReportClient.get') | 19:31 |
| fried_bunny | def test_whatever(self, mock_get): | 19:31 |
| fried_bunny | mock_get.side_effect = ...MissingAuthPlugin | 19:31 |
| fried_bunny | self.assertRaises(PlacementNotConfigured, self.init_host) | 19:31 |
| fried_bunny | kind of thing. | 19:31 |
| fried_bunny | a mock.patch.object would be a lil more elegant I guess. For that you might have to use a context manager. | 19:32 |
| *** fragatina has quit IRC | 19:34 | |
| *** hamzy has quit IRC | 19:43 | |
| *** itlinux has joined #openstack-nova | 19:44 | |
| imacdonn | k, I guess I have it working with mock.patch | 19:49 |
| *** markvoelker has quit IRC | 19:51 | |
| *** Zames has joined #openstack-nova | 19:52 | |
| *** Zames has quit IRC | 19:55 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Return anchor providers in a_r and p_s https://review.openstack.org/558014 | 19:56 |
| fried_bunny | good deal. | 19:57 |
| fried_bunny | You 'bout ready to post that puppy? | 19:57 |
| imacdonn | have one more test to fix (not looked at it yet) .. and also pondering what to do with test_init_host_placement_ensures_default_config_is_unset | 19:57 |
| *** edmondsw has joined #openstack-nova | 19:58 | |
| fried_bunny | kill it. | 19:58 |
| imacdonn | it's related, but ... sort of different | 19:58 |
| *** itlinux has quit IRC | 19:58 | |
| imacdonn | you think I should just whack it in this change, or separately? | 19:58 |
| fried_bunny | looking... | 19:58 |
| fried_bunny | oh, kill it. | 19:59 |
| fried_bunny | in fact... | 19:59 |
| imacdonn | wondering if it has/had any other purpose | 19:59 |
| fried_bunny | https://review.openstack.org/#/c/557086/ -- I thought that was touching that test case, but no. | 20:00 |
| imacdonn | yeah, I was also surprised that https://review.openstack.org/#/c/554759/ didn't at least touch it | 20:00 |
| imacdonn | so Im going to nuke it, on the assumption that its only purpose was to ensure the validity of the following test | 20:01 |
| *** edmondsw has quit IRC | 20:02 | |
| fried_bunny | probably just overlooked tbh | 20:04 |
| imacdonn | yeah | 20:05 |
| fried_bunny | on that note, you can look around and remove all the places we set placement.[os_]region_name now. | 20:05 |
| fried_bunny | ...in the test suites. | 20:05 |
| imacdonn | not actually seeing any (others) | 20:07 |
| imacdonn | well, there's this... nova/tests/unit/conf_fixture.py: self.conf.set_default('region_name', 'RegionOne', group='placement') | 20:08 |
| fried_bunny | yup, don't need that anymore. | 20:13 |
| imacdonn | agreed ... removed it already, and running all tests again | 20:14 |
| imacdonn | d'you think we need comments at all the places where we made the placement fixtures, explaining why ? | 20:15 |
| fried_bunny | It sure wouldn't hurt. | 20:15 |
| imacdonn | right ... all tests are passing now ... I think I'll grab lunch, then work up some comments and a commit message | 20:19 |
| fried_bunny | nice | 20:19 |
| imacdonn | thanks very much for your help and patience! | 20:20 |
| fried_bunny | imacdonn: Thank you very much for taking this on. | 20:22 |
| imacdonn | np! | 20:22 |
| fried_bunny | ooo, your first nova patch? | 20:23 |
| *** yamamoto has joined #openstack-nova | 20:23 | |
| imacdonn | probably, yeah | 20:27 |
| imacdonn | have done a few cinder/os-brick ones | 20:28 |
| *** yamamoto has quit IRC | 20:29 | |
| *** sapd__ has joined #openstack-nova | 20:31 | |
| *** sapd_ has quit IRC | 20:31 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot https://review.openstack.org/543023 | 20:38 |
| *** markvoelker has joined #openstack-nova | 20:48 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | 21:02 |
| *** edmondsw has joined #openstack-nova | 21:03 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Fix unit tests to work with new oslo.config https://review.openstack.org/558084 | 21:03 |
| fried_bunny | dhellmann ^ | 21:03 |
| *** edmondsw has quit IRC | 21:07 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: DiskAdapter parent class https://review.openstack.org/549053 | 21:08 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 21:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Add unrequested resources to provider_summaries https://review.openstack.org/558045 | 21:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | 21:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Support relay RP for allocation candidates https://review.openstack.org/533437 | 21:20 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Return anchor providers in a_r and p_s https://review.openstack.org/558014 | 21:20 |
| *** markvoelker has quit IRC | 21:21 | |
| *** yamamoto has joined #openstack-nova | 21:25 | |
| fried_bunny | imacdonn: Aha, I knew that sounded familiar: https://review.openstack.org/#/c/554759/1/nova/tests/unit/compute/test_compute_mgr.py@3708 | 21:28 |
| *** yamamoto has quit IRC | 21:31 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove deprecated [placement] opts https://review.openstack.org/557086 | 21:33 |
| *** Tom-Tom has joined #openstack-nova | 21:37 | |
| *** andreas_s has joined #openstack-nova | 21:41 | |
| *** Tom-Tom has quit IRC | 21:41 | |
| imacdonn | frickler: ahh, so I guess you decided to leave it alone that time ;) | 21:42 |
| imacdonn | oops that was meant for fried_bunny ... grr, bad tab-completion | 21:42 |
| *** andreas_s_ has joined #openstack-nova | 21:42 | |
| *** Guest52181 has quit IRC | 21:43 | |
| imacdonn | zoiks ... nova could use some pep8 love ;) | 21:44 |
| *** andreas_s has quit IRC | 21:46 | |
| *** cz2 has quit IRC | 21:48 | |
| *** andreas_s_ has quit IRC | 21:49 | |
| fried_bunny | imacdonn: Yeah, well, I was taking over someone else's patch, and kind of in a hurry, didn't want to get too involved. | 21:59 |
| fried_bunny | What about pep8? | 21:59 |
| imacdonn | I thought I'd have to pass pep8 with my change, but when I run it, I barfs on a ton of other stuff | 22:00 |
| fried_bunny | How are you running it? | 22:00 |
| imacdonn | just pep8 on the files I touched | 22:00 |
| imacdonn | Trying to do it under tox instead now | 22:00 |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 22:02 |
| *** cz2 has joined #openstack-nova | 22:03 | |
| fried_bunny | imacdonn: FYI, I use this: | 22:04 |
| fried_bunny | efried@efried-ThinkPad-W520:~/Neo/nova$ type pep | 22:04 |
| fried_bunny | pep is a function | 22:04 |
| fried_bunny | pep () | 22:04 |
| fried_bunny | { | 22:04 |
| fried_bunny | ( . .tox/pep8/bin/activate || return; | 22:04 |
| fried_bunny | num=${1:-1}; | 22:04 |
| fried_bunny | echo "Running flake8 on files changed in the last $num commit(s)"; | 22:04 |
| fried_bunny | git diff --name-only HEAD~$num | grep '\.py$' | xargs flake8 ) | 22:04 |
| fried_bunny | } | 22:04 |
| imacdonn | ah, neat .. I'll steal that - thanks ;) | 22:04 |
| imacdonn | ./nova/tests/unit/compute/test_compute_mgr.py:21:1: H306 imports not in alphabetical order (keystoneauth1.exceptions, cinderclient.exceptions) | 22:06 |
| imacdonn | wow .. pickyyyyy | 22:06 |
| *** hamzy has joined #openstack-nova | 22:16 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: WIP: Resize https://review.openstack.org/553583 | 22:18 |
| *** markvoelker has joined #openstack-nova | 22:18 | |
| *** yamamoto has joined #openstack-nova | 22:27 | |
| *** yamamoto has quit IRC | 22:33 | |
| openstackgerrit | iain MacDonnell proposed openstack/nova master: Update check to ensure compute is using placement https://review.openstack.org/558089 | 22:34 |
| *** yangyapeng has joined #openstack-nova | 22:34 | |
| *** yangyapeng has quit IRC | 22:38 | |
| *** leakypipes is now known as jaypipes | 22:42 | |
| *** idlemind has quit IRC | 22:47 | |
| *** idlemind has joined #openstack-nova | 22:49 | |
| *** edmondsw has joined #openstack-nova | 22:51 | |
| *** markvoelker has quit IRC | 22:51 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: update_provider_tree devref and docstring updates https://review.openstack.org/553476 | 22:52 |
| *** edmondsw has quit IRC | 22:56 | |
| *** hemna_ has joined #openstack-nova | 22:59 | |
| *** hemna_ has quit IRC | 23:00 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove deprecated [placement] opts https://review.openstack.org/557086 | 23:02 |
| fried_bunny | Well, that's quite enough for today. | 23:12 |
| * fried_bunny waves | 23:12 | |
| *** yamamoto has joined #openstack-nova | 23:29 | |
| *** yamamoto has quit IRC | 23:33 | |
| *** hongbin has quit IRC | 23:34 | |
| *** markvoelker has joined #openstack-nova | 23:48 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!