Monday, 2018-04-09

*** elmaciej has joined #openstack-nova00:06
*** danpawlik has quit IRC00:07
*** edmondsw has joined #openstack-nova00:09
*** edmondsw has quit IRC00:14
*** elmaciej has quit IRC00:20
*** odyssey4me has quit IRC00:23
*** odyssey4me has joined #openstack-nova00:23
*** danpawlik has joined #openstack-nova00:38
*** tbachman has joined #openstack-nova00:43
*** danpawlik has quit IRC00:47
*** danpawlik has joined #openstack-nova00:48
*** danpawlik has quit IRC00:57
*** hemna_ has joined #openstack-nova01:01
openstackgerritjichenjc proposed openstack/nova stable/queens: Avoid showing password in log  https://review.openstack.org/55960301:05
*** hemna_ has quit IRC01:05
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API.  https://review.openstack.org/55415901:06
*** zhaochao has joined #openstack-nova01:09
*** suresh12 has joined #openstack-nova01:11
*** Zames has joined #openstack-nova01:16
*** salv-orlando has quit IRC01:16
*** suresh12 has quit IRC01:16
*** salv-orlando has joined #openstack-nova01:16
*** Zames has quit IRC01:18
*** QianYu has joined #openstack-nova01:26
*** hongbin has joined #openstack-nova01:27
*** danpawlik has joined #openstack-nova01:28
*** vladikr has joined #openstack-nova01:31
*** Guest35063 has quit IRC01:37
*** danpawlik has quit IRC01:37
openstackgerritjichenjc proposed openstack/nova master: Avoid live migrate to same host  https://review.openstack.org/54268901:37
openstackgerritjichenjc proposed openstack/nova master: Avoid raise InstanceNotRunning exception  https://review.openstack.org/54115201:38
*** blkart has quit IRC01:45
*** ssurana has joined #openstack-nova01:46
*** AlexeyAbashkin has joined #openstack-nova01:50
*** tonyb has joined #openstack-nova01:50
*** blkart has joined #openstack-nova01:51
*** Guest35063 has joined #openstack-nova01:53
*** AlexeyAbashkin has quit IRC01:54
*** tiendc has joined #openstack-nova01:54
*** edmondsw has joined #openstack-nova01:57
*** alex_xu has joined #openstack-nova01:58
*** vladikr has quit IRC02:01
*** stakeda has quit IRC02:01
*** edmondsw has quit IRC02:02
*** vladikr has joined #openstack-nova02:02
*** stakeda has joined #openstack-nova02:04
*** danpawlik has joined #openstack-nova02:08
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API  https://review.openstack.org/55714502:10
*** edleafe- has joined #openstack-nova02:10
*** ssurana1 has joined #openstack-nova02:10
*** edleafe has quit IRC02:10
*** edleafe- is now known as edleafe02:10
*** slaweq has joined #openstack-nova02:10
*** ssurana has quit IRC02:14
*** slaweq has quit IRC02:15
*** danpawlik has quit IRC02:22
*** sapd_ has joined #openstack-nova02:23
*** suresh12 has joined #openstack-nova02:26
*** sapd has quit IRC02:26
*** markvoelker has quit IRC02:28
*** markvoelker has joined #openstack-nova02:29
*** markvoelker has quit IRC02:34
*** mikal_ has quit IRC02:36
*** mikal has joined #openstack-nova02:36
*** QianYu has quit IRC02:37
*** tetsuro has joined #openstack-nova02:38
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations`  https://review.openstack.org/52171702:44
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API.  https://review.openstack.org/55415902:46
*** AlexeyAbashkin has joined #openstack-nova02:50
*** danpawlik has joined #openstack-nova02:53
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/api/openstack/compute/test_hosts.py  https://review.openstack.org/55926602:55
*** AlexeyAbashkin has quit IRC02:55
openstackgerritjichenjc proposed openstack/nova master: make metadata doc up to date  https://review.openstack.org/55961302:56
*** suresh12 has quit IRC02:57
*** danpawlik has quit IRC03:02
*** QianYu has joined #openstack-nova03:02
*** danpawlik has joined #openstack-nova03:03
*** mdnadeem has joined #openstack-nova03:05
*** imacdonn has joined #openstack-nova03:08
*** suresh12 has joined #openstack-nova03:09
*** danpawlik has quit IRC03:12
*** danpawlik has joined #openstack-nova03:13
*** QianYu has quit IRC03:19
*** suresh12 has quit IRC03:19
*** sree has joined #openstack-nova03:19
*** QianYu has joined #openstack-nova03:21
*** danpawlik has quit IRC03:22
*** suresh12 has joined #openstack-nova03:23
*** vipul has quit IRC03:29
*** Kevin_Zheng has joined #openstack-nova03:30
*** vipul has joined #openstack-nova03:41
*** edmondsw has joined #openstack-nova03:45
*** annp has joined #openstack-nova03:46
*** edmondsw has quit IRC03:50
*** danpawlik has joined #openstack-nova03:53
*** vipul has quit IRC03:53
*** janki has joined #openstack-nova03:53
*** vipul has joined #openstack-nova03:54
*** tiendc has quit IRC03:57
*** tiendc has joined #openstack-nova03:58
*** danpawlik has quit IRC04:02
*** mdnadeem has quit IRC04:04
*** hongbin has quit IRC04:05
*** Dinesh_Bhor has joined #openstack-nova04:07
*** Zames has joined #openstack-nova04:09
*** Zames has quit IRC04:12
*** udesale has joined #openstack-nova04:17
*** psachin has joined #openstack-nova04:20
*** vladikr has quit IRC04:21
*** vladikr has joined #openstack-nova04:22
openstackgerritTetsuro Nakamura proposed openstack/nova master: Support shared and nested allocation candidates  https://review.openstack.org/55651404:24
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return all nested providers in tree  https://review.openstack.org/55948004:24
openstackgerritTetsuro Nakamura proposed openstack/nova master: Return resource providers without inventories  https://review.openstack.org/55955404:24
openstackgerritTetsuro Nakamura proposed openstack/nova master: Consult the dictionary for root provider ids  https://review.openstack.org/55955504:24
*** links has joined #openstack-nova04:25
*** andreas_s has joined #openstack-nova04:30
*** jchhatbar has joined #openstack-nova04:30
*** danpawlik has joined #openstack-nova04:33
*** janki has quit IRC04:33
*** abhishekk has joined #openstack-nova04:35
*** andreas_s has quit IRC04:35
*** fragatina has quit IRC04:35
*** ssurana1 has quit IRC04:40
*** ssurana has joined #openstack-nova04:41
*** danpawlik has quit IRC04:42
*** fragatina has joined #openstack-nova04:42
*** dikonoor has joined #openstack-nova04:47
*** tianhui_ has joined #openstack-nova04:48
*** Zames has joined #openstack-nova04:48
*** tianhui has quit IRC04:50
*** Zames has quit IRC04:55
*** Dinesh__Bhor has joined #openstack-nova04:56
*** Dinesh_Bhor has quit IRC04:57
*** artom has quit IRC05:02
*** artom has joined #openstack-nova05:02
*** hemna_ has joined #openstack-nova05:03
*** phuongnh has joined #openstack-nova05:03
*** hemna_ has quit IRC05:08
*** ratailor has joined #openstack-nova05:09
*** danpawlik has joined #openstack-nova05:13
*** danpawlik has quit IRC05:22
*** danpawlik has joined #openstack-nova05:23
*** vivsoni has joined #openstack-nova05:26
*** suresh12 has quit IRC05:28
*** suresh12 has joined #openstack-nova05:28
*** trinaths has joined #openstack-nova05:30
*** udesale_ has joined #openstack-nova05:30
*** sar has quit IRC05:32
*** udesale has quit IRC05:33
*** edmondsw has joined #openstack-nova05:33
*** edmondsw has quit IRC05:38
*** suresh12 has quit IRC05:39
*** suresh12 has joined #openstack-nova05:39
*** suresh12 has quit IRC05:44
*** zhurong has joined #openstack-nova05:44
*** sridharg has joined #openstack-nova05:47
*** danpawlik has quit IRC05:52
*** lajoskatona has joined #openstack-nova05:57
*** takedakn has joined #openstack-nova05:58
*** vipul has quit IRC06:07
*** takedakn has quit IRC06:08
*** shaohe_feng has quit IRC06:09
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (1)  https://review.openstack.org/55870406:12
*** slaweq has joined #openstack-nova06:12
*** shaohe_feng has joined #openstack-nova06:13
*** vipul has joined #openstack-nova06:14
*** slaweq has quit IRC06:17
*** lpetrut has joined #openstack-nova06:18
*** sar has joined #openstack-nova06:19
openstackgerritTetsuro Nakamura proposed openstack/nova master: Improve getting nested providers with capacity  https://review.openstack.org/55963806:22
*** danpawlik has joined #openstack-nova06:23
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (2)  https://review.openstack.org/55899306:28
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (3)  https://review.openstack.org/55925806:28
*** namnh has joined #openstack-nova06:29
*** armaan has joined #openstack-nova06:32
*** andreas_s has joined #openstack-nova06:33
*** pcaruana has joined #openstack-nova06:35
*** sahid has joined #openstack-nova06:39
*** ejat_ is now known as ejat06:39
*** ejat has quit IRC06:39
*** ejat has joined #openstack-nova06:39
*** armaan has quit IRC06:41
*** armaan has joined #openstack-nova06:41
*** andreas_s has quit IRC06:42
*** oanson has quit IRC06:42
*** oanson has joined #openstack-nova06:44
*** namnh has quit IRC06:46
*** udesale__ has joined #openstack-nova06:46
*** namnh has joined #openstack-nova06:46
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in test_user_data.py  https://review.openstack.org/55926406:47
*** belmoreira has joined #openstack-nova06:49
*** udesale_ has quit IRC06:49
*** ralonsoh has joined #openstack-nova06:54
*** slaweq has joined #openstack-nova06:56
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_instance_actions.py  https://review.openstack.org/55926906:58
*** rodolof has joined #openstack-nova07:08
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix the request context in ServiceFixture  https://review.openstack.org/55816007:09
*** tianhui_ has quit IRC07:09
openstackgerritTakashi NATSUME proposed openstack/nova master: Replace mox stubs with stub_out in test_extended_volumes.py  https://review.openstack.org/55868507:09
*** Dinesh__Bhor has quit IRC07:09
*** yikun_ has joined #openstack-nova07:11
*** Dinesh__Bhor has joined #openstack-nova07:11
*** tianhui has joined #openstack-nova07:12
*** zhurong has quit IRC07:13
*** kholkina has joined #openstack-nova07:14
*** tesseract has joined #openstack-nova07:14
*** namnh has quit IRC07:14
*** tiendc has quit IRC07:14
*** tiendc has joined #openstack-nova07:14
*** namnh has joined #openstack-nova07:14
*** vipul has quit IRC07:16
*** rcernin has quit IRC07:16
*** vipul has joined #openstack-nova07:17
*** trinaths has quit IRC07:20
*** edmondsw has joined #openstack-nova07:21
*** zz9pzza has quit IRC07:22
*** lpetrut has quit IRC07:25
*** andreas_s has joined #openstack-nova07:26
*** edmondsw has quit IRC07:26
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_server_password.py  https://review.openstack.org/55964907:29
*** jistr is now known as jistr|dentist07:34
*** aloga has quit IRC07:34
*** aloga has joined #openstack-nova07:34
*** amoralej|off is now known as amoralej07:37
*** damien_r has joined #openstack-nova07:39
*** tssurya has joined #openstack-nova07:39
*** ccamacho has joined #openstack-nova07:41
openstackgerritRoman Dobosz proposed openstack/nova master: Added weight for aggregate soft (anti) affinity.  https://review.openstack.org/55676207:41
openstackgerritRoman Dobosz proposed openstack/nova master: Add nodes to group hosts to be checked against aggregation  https://review.openstack.org/55965107:41
*** yikun has joined #openstack-nova07:44
*** damien_r has quit IRC07:50
*** jpena|off is now known as jpena07:50
*** damien_r has joined #openstack-nova07:51
*** lpetrut has joined #openstack-nova07:51
*** zz9pzza has joined #openstack-nova07:52
*** lucas-afk is now known as lucasagomes07:56
bauzasgood morning Stackers07:57
*** hoonetorg has quit IRC07:59
*** trinaths has joined #openstack-nova08:01
*** lpetrut has quit IRC08:02
tssuryagood morning bauzas08:08
openstackgerritZhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status  https://review.openstack.org/53672208:11
*** hoonetorg has joined #openstack-nova08:12
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create  https://review.openstack.org/52104108:12
*** suresh12 has joined #openstack-nova08:16
*** danpawlik has quit IRC08:19
*** suresh12 has quit IRC08:21
tetsurogood morning08:24
*** derekh has joined #openstack-nova08:32
*** elmaciej has joined #openstack-nova08:32
*** avolkov has joined #openstack-nova08:33
*** mdnadeem has joined #openstack-nova08:33
*** dikonoor has quit IRC08:36
*** cdent has joined #openstack-nova08:39
openstackgerritYikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API.  https://review.openstack.org/55415908:40
*** elmaciej has quit IRC08:42
*** danpawlik has joined #openstack-nova08:44
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver  https://review.openstack.org/52338708:47
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver  https://review.openstack.org/52765808:47
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add snapshot function  https://review.openstack.org/53424008:47
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add power actions  https://review.openstack.org/54334008:47
openstackgerritjichenjc proposed openstack/nova master: z/VM Driver: add get console output  https://review.openstack.org/54334408:47
*** danpawlik has quit IRC08:54
*** sambetts|afk is now known as sambetts08:55
lyarwoodMorning all - https://review.openstack.org/#/c/544238/ +2'd by Matt last week, any additional core reviews would be appreciated.08:57
*** trinaths has quit IRC08:58
*** Sasikiran has joined #openstack-nova09:00
SasikiranHi All, Is there any steps to recover a vm in error state ("Unexpected vif_type=baremetal", "code": 500, "details": "  File \"/usr/lib/python2.7/dist-packages/nova/compute/manager.py\", line 375, in decorated_function )09:00
*** jogo has quit IRC09:01
*** jistr|dentist is now known as jistr09:02
*** alex_xu has quit IRC09:03
*** Sasikiran has quit IRC09:03
*** hemna_ has joined #openstack-nova09:05
*** alex_xu has joined #openstack-nova09:08
*** hemna_ has quit IRC09:09
*** edmondsw has joined #openstack-nova09:10
*** dikonoor has joined #openstack-nova09:10
*** edmondsw has quit IRC09:14
*** jogo has joined #openstack-nova09:20
*** armaan has quit IRC09:24
openstackgerritTakashi NATSUME proposed openstack/nova master: Remove mox in unit/api/*/test_server_metadata.py  https://review.openstack.org/55967309:25
*** rabel has left #openstack-nova09:25
*** ygl has joined #openstack-nova09:30
*** armaan has joined #openstack-nova09:30
*** ygl has left #openstack-nova09:31
*** Dinesh__Bhor has quit IRC09:31
*** gyankum has joined #openstack-nova09:34
*** armaan has quit IRC09:35
*** takashin has left #openstack-nova09:36
*** ragiman has joined #openstack-nova09:37
openstackgerritNaichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration  https://review.openstack.org/55415409:38
*** andreas_s has quit IRC09:40
*** lpetrut has joined #openstack-nova09:42
*** tianhui has quit IRC09:44
*** tianhui_ has joined #openstack-nova09:45
*** dikonoor has quit IRC09:48
*** yikun_ has quit IRC09:50
*** ssurana has quit IRC09:55
*** jchhatbar has quit IRC09:55
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky"  https://review.openstack.org/55878309:58
*** tiendc has quit IRC09:58
*** namnh has quit IRC09:58
openstackgerritKashyap Chamarthy proposed openstack/nova master: [RFC] Pick next minimum libvirt / QEMU versions for "Stein"  https://review.openstack.org/55817109:58
*** mgoddard has joined #openstack-nova09:58
*** tiendc has joined #openstack-nova09:58
*** namnh has joined #openstack-nova09:58
*** maciejjozefczyk has joined #openstack-nova10:01
*** namnh has quit IRC10:08
*** stakeda has quit IRC10:08
*** dikonoor has joined #openstack-nova10:10
*** QianYu has quit IRC10:12
*** andreas_s has joined #openstack-nova10:16
*** sridharg has quit IRC10:20
*** gyankum has quit IRC10:27
*** slaweq has quit IRC10:32
*** nicolasbock has joined #openstack-nova10:34
*** slaweq has joined #openstack-nova10:35
openstackgerritMichael Still proposed openstack/nova master: Move xenapi disk resizing to privsep.  https://review.openstack.org/55224210:38
openstackgerritMichael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck.  https://review.openstack.org/55407810:38
openstackgerritMichael Still proposed openstack/nova master: Move xenapi partition copies to privsep.  https://review.openstack.org/55360510:38
openstackgerritMichael Still proposed openstack/nova master: Move image conversion to privsep.  https://review.openstack.org/55443710:38
openstackgerritMichael Still proposed openstack/nova master: We don't need utils.trycmd any more.  https://review.openstack.org/55443910:38
openstackgerritMichael Still proposed openstack/nova master: We no longer need rootwrap.  https://review.openstack.org/55443810:38
*** elmaciej has joined #openstack-nova10:39
*** lpetrut has quit IRC10:40
*** sree has quit IRC10:43
*** tbachman has quit IRC10:46
*** dikonoor has quit IRC10:49
*** lpetrut has joined #openstack-nova10:52
openstackgerritKashyap Chamarthy proposed openstack/nova stable/queens: libvirt: Allow to specify granular CPU feature flags  https://review.openstack.org/55970010:53
openstackgerritKashyap Chamarthy proposed openstack/nova stable/pike: libvirt: Allow to specify granular CPU feature flags  https://review.openstack.org/55970210:53
*** abhishekk has quit IRC10:54
*** dikonoor has joined #openstack-nova10:57
*** edmondsw has joined #openstack-nova10:58
*** trinaths has joined #openstack-nova10:59
kashyapjohnthetubaguy: As agreed on the list, bumped the NEXT_MIN versions to whats on Debian Stretch: https://review.openstack.org/55878311:00
*** edmondsw has quit IRC11:03
*** lpetrut has quit IRC11:04
*** lucasagomes is now known as lucas-hungry11:05
*** armaan has joined #openstack-nova11:05
*** phuongnh has quit IRC11:06
*** xinliang has quit IRC11:16
*** fragatina has quit IRC11:17
*** tetsuro has left #openstack-nova11:20
*** udesale__ has quit IRC11:20
*** vladikr has quit IRC11:21
*** vladikr has joined #openstack-nova11:22
*** xinliang has joined #openstack-nova11:27
*** sridharg has joined #openstack-nova11:29
*** sridharg has quit IRC11:29
*** sridharg has joined #openstack-nova11:30
*** elod has quit IRC11:36
*** elod has joined #openstack-nova11:38
*** trinaths has quit IRC11:41
*** jpena is now known as jpena|lunch11:42
*** gyankum has joined #openstack-nova11:45
*** artom has quit IRC11:46
*** tiendc has quit IRC11:46
*** lajoskatona has quit IRC11:46
openstackgerritMerged openstack/nova master: conf: Remove 'db_driver' config opt  https://review.openstack.org/50848711:46
*** psachin has quit IRC11:53
*** lajoskatona has joined #openstack-nova11:55
*** lucas-hungry is now known as lucasagomes11:56
*** edmondsw has joined #openstack-nova12:04
*** gyankum has quit IRC12:04
*** tbachman has joined #openstack-nova12:04
*** tbachman_ has joined #openstack-nova12:07
*** tbachman has quit IRC12:09
*** tbachman_ is now known as tbachman12:09
*** takashin has joined #openstack-nova12:11
*** psachin has joined #openstack-nova12:14
*** sree_ has joined #openstack-nova12:14
*** sree_ is now known as Guest8735412:14
*** suresh12 has joined #openstack-nova12:17
*** sdague has joined #openstack-nova12:17
*** Guest87354 has quit IRC12:19
*** suresh12 has quit IRC12:21
*** Eran_Kuris has quit IRC12:26
*** udesale has joined #openstack-nova12:28
*** udesale has quit IRC12:31
*** udesale has joined #openstack-nova12:32
*** jpena|lunch is now known as jpena12:32
*** nicolasbock has quit IRC12:33
*** armaan has quit IRC12:36
*** armaan has joined #openstack-nova12:36
*** nicolasbock has joined #openstack-nova12:37
*** odyssey4me has quit IRC12:38
*** odyssey4me has joined #openstack-nova12:38
*** Eran_Kuris has joined #openstack-nova12:39
*** ratailor has quit IRC12:39
*** dave-mccowan has joined #openstack-nova12:40
openstackgerritsahid proposed openstack/nova master: network: update pci request spec to handle trusted tags  https://review.openstack.org/45882012:41
openstackgerritsahid proposed openstack/nova master: libvirt: configure trust mode for vfs  https://review.openstack.org/45851412:41
*** liverpooler has joined #openstack-nova12:42
*** dpawlik has joined #openstack-nova12:43
openstackgerritMerged openstack/nova-specs master: update: isolate guests emulthreads on CONF.cpu_shared_set  https://review.openstack.org/51118812:44
*** dave-mcc_ has joined #openstack-nova12:44
*** dave-mccowan has quit IRC12:45
*** pcaruana has quit IRC12:46
*** gouthamr has joined #openstack-nova12:49
efriedlyarwood: I theeeenk there's a bug in your test cases.12:51
*** gouthamr has quit IRC12:52
*** ktibi has joined #openstack-nova12:52
ktibiHi nova, Anyone have already see this issue : when I add a second NIC on my instance, instance hang on reboot, just after random: crng init done :/12:52
*** _ix has joined #openstack-nova12:53
lyarwoodefried: do I need to reset the mock_get_encryption mock?12:55
efriedlyarwood: I'm commenting it up.  But 1) .side_effects isn't a thing (it's spelled .side_effect); and 2) when you have .side_effect set, .return_value is ignored.12:56
efriedlyarwood: I confirmed by removing those two .side_effects lines (the test still passes)12:56
lyarwoodgah, nice catch12:57
*** pchavva has joined #openstack-nova12:57
efriedlyarwood: Okay, commented.  Care to fix the formatting since you're respinning anyway?  :)12:59
lyarwoodefried: sure if you could elaborate a little on why the current style is an issue13:01
*** lyan has joined #openstack-nova13:01
*** lajoskatona has left #openstack-nova13:01
efriedlyarwood: What I would do is set the side_effect to [{}, {}] and make sure you *don't* raise.13:01
*** lyan is now known as Guest6430413:01
*** AlexeyAbashkin has joined #openstack-nova13:01
*** dikonoo has joined #openstack-nova13:02
lyarwoodefried: right, sorry I was asking about L1553 in driver.py13:02
efriedlyarwood: Oh, because a) backslashes are icky, and b) having the second line of the condition at the same indent level as the interior of the condition is icky.13:02
*** gouthamr has joined #openstack-nova13:02
efriedFor the latter, we have a pep rule... disabled in the nova project.  (Couldn't tell you why)13:02
*** sree has joined #openstack-nova13:02
lyarwoodefried: kk, right I didn't know there was a pep rule for that, I'll sort that out now as well.13:02
lyarwoodefried: thanks :)13:03
efriedlyarwood: Thank you13:03
*** mriedem has joined #openstack-nova13:03
*** psachin has quit IRC13:04
*** READ10 has joined #openstack-nova13:05
*** dikonoor has quit IRC13:06
*** _ix has quit IRC13:07
*** AlexeyAbashkin has quit IRC13:10
*** AlexeyAbashkin has joined #openstack-nova13:10
*** pcaruana has joined #openstack-nova13:11
*** udesale has quit IRC13:12
*** udesale has joined #openstack-nova13:13
openstackgerritMerged openstack/nova-specs master: Fix typos in NUMA-aware live migration  https://review.openstack.org/55884213:13
*** gouthamr has quit IRC13:15
*** AlexeyAbashkin has quit IRC13:17
*** gouthamr has joined #openstack-nova13:17
*** Zames has joined #openstack-nova13:17
*** AlexeyAbashkin has joined #openstack-nova13:17
sean-k-mooneyo/13:18
sean-k-mooneyfinucannot: are you about?13:19
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt  https://review.openstack.org/54423813:20
lyarwoodefried: ^ sorry was interrupted, the [{}, {}] case is tested by all of the other swap_volume tests FWIW13:21
lyarwoodefried: but I can add it if you really want it in there13:21
efriedlyarwood: I figured it was; it would just be a way to make sure your mocks are doing the right thing.13:22
*** Zames has quit IRC13:22
efriedlyarwood: Not necessary to add it here.13:22
*** tetsuro has joined #openstack-nova13:22
*** tblakes has joined #openstack-nova13:22
*** janki has joined #openstack-nova13:22
efriedlyarwood: Just sayin, if it had been in there, with .side_effects, it wouldn't have worked as expected, and after some head scratching, you would have found the other bug that everybody missed :)13:22
tblakesmriedem: Does https://review.openstack.org/#/c/555812/ still require the patch you suggested? The review comments at https://review.openstack.org/#/c/559169/ seem to indicate not. If it doesn't require the patch, is https://review.openstack.org/#/c/559158/ then ready to be cherry-picked in to stable/queens?13:24
lyarwoodefried: yeah true, I'd need to move this into a seperate method to make testing a little easier, otherwise I'll end up mocking all of swap_volume again.13:25
efriedlyarwood: Yeah, I figured that was probably the case.  It's fine this way.13:25
*** gouthamr has quit IRC13:26
*** lbragstad has joined #openstack-nova13:27
efriedlyarwood: +2 (with some optional formatting nits)13:29
kholkinaHi! Could you please explain why free_ram_mb + memory_mb_used != memory_mb? How does it calculated?13:30
kholkinaI mean values in 'nova hypervisor-show'13:31
lyarwoodefried: thanks, can't say I agree with the nit but if others also call it out I'll respin :)13:31
*** david-lyle has quit IRC13:31
* lyarwood didn't see the test nits13:31
lyarwoodurgh sorry that's not good13:32
efriedlyarwood: Yeah, I'm sure there's a reason we've got those peps switched off - it must be because the ptb don't care.13:32
efriedlyarwood: FYI, this excerpt from tox.ini explains to some extent:13:33
efried# Most of the whitespace related rules (E12* and E131) are excluded13:33
efried# because while they are often useful guidelines, strict adherence to13:33
efried# them ends up causing some really odd code formatting and forced13:33
efried# extra line breaks. Updating code to enforce these will be a hard sell.13:33
*** markvoelker has joined #openstack-nova13:34
efriedIf I may paraphrase: "Follow these rules unless it results in really odd code formatting or forced extra line breaks"13:34
efried...which is of course difficult without OCD reviewers (or being OCD yourself)13:34
efried...which is why the peps exist.13:34
*** AlexeyAbashkin has quit IRC13:34
*** markvoelker_ has joined #openstack-nova13:36
*** AlexeyAbashkin has joined #openstack-nova13:37
*** belmoreira has quit IRC13:38
*** rodolof has quit IRC13:39
*** rodolof has joined #openstack-nova13:39
*** markvoelker has quit IRC13:39
*** esberglu has joined #openstack-nova13:39
*** idlemind has joined #openstack-nova13:40
efriedmikal: yt?13:41
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt  https://review.openstack.org/54423813:42
mriedemtblakes: if jgwentworth says she can't reproduce the problem on master then i guess it's not an issue, especially if we can't recreate with a test13:42
*** dikonoo has quit IRC13:42
*** mvk has quit IRC13:42
*** sree has quit IRC13:42
*** dikonoo has joined #openstack-nova13:42
*** leakypipes has joined #openstack-nova13:42
*** sree has joined #openstack-nova13:43
*** leakypipes has quit IRC13:43
efriedmriedem: Quick re-approval for lyarwood: https://review.openstack.org/#/c/544238/13:44
tblakesmriedem: Thanks! I'll abandon https://review.openstack.org/#/c/559169/ and recheck https://review.openstack.org/#/c/559158/.13:44
*** dikonoor has joined #openstack-nova13:45
openstackgerritRaoul Hidalgo Charman proposed openstack/nova master: Expose shutdown retry interval as config setting  https://review.openstack.org/55248313:45
*** jaypipes has joined #openstack-nova13:46
*** QianYu has joined #openstack-nova13:46
*** sree has quit IRC13:47
*** amodi has joined #openstack-nova13:49
*** dikonoo has quit IRC13:49
*** jchhatbar has joined #openstack-nova13:50
*** yikun has quit IRC13:50
*** QianYu has quit IRC13:50
*** yikun has joined #openstack-nova13:50
*** QianYu has joined #openstack-nova13:50
dansmithmriedem: were you going to look at this? https://review.openstack.org/#/c/558059/13:52
*** burt has joined #openstack-nova13:52
*** janki has quit IRC13:52
*** r-daneel has joined #openstack-nova13:54
*** QianYu has quit IRC13:54
mriedemdansmith: yes, i now have an excellent sized queue after starting about 20 minutes ago13:55
edleafeScheduler subteam meeting in 4 minutes in #openstack-meeting-alt13:56
*** awaugama has joined #openstack-nova13:57
dansmithmriedem: you're welcome13:59
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix comments at the 'save' method of objects.Instance  https://review.openstack.org/55974314:00
*** felipemonteiro has joined #openstack-nova14:00
jaypipes4/join #openstack-meeting-alt14:01
jaypipesffs14:01
*** tblakes has quit IRC14:02
*** liverpooler has quit IRC14:02
*** markvoelker_ has quit IRC14:03
*** liverpooler has joined #openstack-nova14:04
*** dikonoo has joined #openstack-nova14:04
*** bnemec has joined #openstack-nova14:05
*** Eran_Kuris has quit IRC14:06
*** dougshelley66 has joined #openstack-nova14:06
*** eharney has joined #openstack-nova14:08
*** dikonoor has quit IRC14:09
*** felipemonteiro_ has joined #openstack-nova14:09
*** felipemonteiro has quit IRC14:12
mriedemefried: lyarwood: +W14:13
openstackgerritKashyap Chamarthy proposed openstack/nova master: [RFC] Pick next minimum libvirt / QEMU versions for "Stein"  https://review.openstack.org/55817114:13
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky"  https://review.openstack.org/55878314:13
openstackgerritJay Pipes proposed openstack/nova-specs master: mirror nova host aggregates to placement API  https://review.openstack.org/54505714:14
jaypipesmriedem: ^ done.14:14
*** mlavalle has joined #openstack-nova14:16
*** r-daneel_ has joined #openstack-nova14:16
*** dikonoor has joined #openstack-nova14:18
*** r-daneel has quit IRC14:18
*** r-daneel_ is now known as r-daneel14:18
*** dikonoor has quit IRC14:18
*** dikonoor has joined #openstack-nova14:19
*** dpawlik has quit IRC14:19
*** dikonoo has quit IRC14:19
*** krtaylor has quit IRC14:19
*** takashin_ has joined #openstack-nova14:20
*** rodolof has quit IRC14:20
openstackgerritMatt Riedemann proposed openstack/nova-specs master: mirror nova host aggregates to placement API  https://review.openstack.org/54505714:20
*** artom has joined #openstack-nova14:20
mriedemjaypipes: tweaked the alternative section, but +214:20
mriedemthanks14:20
*** mvk has joined #openstack-nova14:21
*** rodolof has joined #openstack-nova14:21
*** jroll has quit IRC14:22
*** takashin has quit IRC14:22
*** jroll has joined #openstack-nova14:23
*** artom_ has joined #openstack-nova14:23
jaypipesmriedem: thx14:23
*** liverpooler has quit IRC14:24
*** liverpooler has joined #openstack-nova14:26
*** artom has quit IRC14:26
*** r-daneel has quit IRC14:27
*** armaan has quit IRC14:28
openstackgerritDan Smith proposed openstack/nova master: Avoid dumping stack on BuildAbortException  https://review.openstack.org/55975114:29
dansmithmriedem: ^14:29
*** gouthamr has joined #openstack-nova14:29
openstackgerritChris Dent proposed openstack/nova master: Optional separate database for placement API  https://review.openstack.org/36276614:29
openstackgerritChris Dent proposed openstack/nova master: Isolate placement database config  https://review.openstack.org/54143514:29
openstackgerritChris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process  https://review.openstack.org/55385714:29
*** belmoreira has joined #openstack-nova14:30
*** sar has quit IRC14:30
*** gouthamr has quit IRC14:31
kashyapalex_xu: Hi, when you're around -- maybe you'd know the answer to my question on `enabled_pef_events`:14:32
kashyapalex_xu: As it stands, seems like Nova accepts far beyond three events (cmt, mbmt, mbml).  Isn't it?14:32
kashyapalex_xu: Because the source for that config attributes shows it accepts a string list -- so all values that are supported by libvirt are accepted by Nova14:33
*** kholkina has quit IRC14:33
kashyap(At least that's what the doc says)14:33
* kashyap looks at actual source to see what it supports14:33
*** _ix has joined #openstack-nova14:34
*** r-daneel has joined #openstack-nova14:35
kashyapalex_xu: Disregard me, answered my question -- yes, it supports broader set of events besides those tree14:36
kashyaps/tree/three/14:36
mriedemesberglu: why is https://review.openstack.org/#/c/554688/ in the runways etherpad?14:37
mriedemit's not tied to a blueprint, but is just powervm driver specific,14:37
mriedemif it's not a bp, please just include it in the powervm driver section of the other priority review etherpad https://etherpad.openstack.org/p/rocky-nova-priorities-tracking14:38
esberglumriedem: Will do14:38
mriedemthanks14:38
openstackgerritChris Dent proposed openstack/nova master: Use nova.db.api directly  https://review.openstack.org/54326214:45
mriedemsahid: bauzas: this spec tracking is really odd https://review.openstack.org/#/c/511188/ - that's for rocky, for a blueprint which is closed14:46
mriedemwhy isn't there a "overhead-pin-set" spec for rocky?14:47
bauzasmriedem: shit, you're right14:48
bauzasmriedem: the URL is wrong14:48
mriedemand the name of the spec is wrong14:49
openstackgerritEric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk  https://review.openstack.org/54930014:49
bauzasI haven't looked at the related BP, my bad14:49
mriedemsahid: can you fix that up please?14:49
bauzasI think sahid didn't changed the spec when we asked him to create that BP14:49
mriedemfinucannot: you can remove the -2 on https://review.openstack.org/#/c/510897/ - the spec is approved14:50
bauzasmriedem: thanks for that btw.14:50
bauzashonestly, I should also look at the BP14:50
*** dklyle has joined #openstack-nova14:51
*** sar has joined #openstack-nova14:51
*** dikonoor has quit IRC14:52
*** dikonoor has joined #openstack-nova14:53
*** AlexeyAbashkin has quit IRC14:54
*** namnh has joined #openstack-nova14:55
*** tbachman has quit IRC14:56
sahidmriedem: at the beginning it was just an update of the already approved spec, that is why we did not have really noticed the issue14:58
*** dougshel_ has joined #openstack-nova14:58
*** sapd has joined #openstack-nova14:59
bauzassahid: ping me when you're done with the new change and I'll +214:59
*** takashin_ has left #openstack-nova14:59
bauzasfor renaming I mean14:59
*** takashin has joined #openstack-nova14:59
sahidyes i will14:59
*** tetsuro has quit IRC15:00
*** dikonoo has joined #openstack-nova15:00
*** takashin has left #openstack-nova15:01
*** chyka has joined #openstack-nova15:01
*** dougshelley66 has quit IRC15:02
*** armaan has joined #openstack-nova15:03
*** dikonoor has quit IRC15:04
*** dikonoor has joined #openstack-nova15:04
*** dikonoo has quit IRC15:06
*** rodolof has quit IRC15:07
mriedemdansmith: replied in https://review.openstack.org/#/c/558059/15:11
*** gouthamr has joined #openstack-nova15:13
*** Zames has joined #openstack-nova15:16
jaypipescdent: ok, everyone gone15:17
cdentroger15:17
openstackgerritMerged openstack/nova master: Support extending attached ScaleIO volumes  https://review.openstack.org/55467915:18
*** sree has joined #openstack-nova15:19
*** felipemonteiro_ has quit IRC15:19
*** xinliang has quit IRC15:19
*** felipemonteiro_ has joined #openstack-nova15:19
mriedemjaypipes: efried: -1 on tetsuro's spec https://review.openstack.org/#/c/559466/ - the bp link is wrong for one, but i'm also wondering if this is just to enable out of tree filters/weighters, or if he actually wants to add a vGPU weighter to nova15:20
mriedemi'd be supportive of that if so15:20
mriedemquestion inline about the slippery slope of including provider trees in the response also15:20
mriedembauzas: you would probably be interested in that idea ^15:21
*** xinliang has joined #openstack-nova15:21
mriedemjgwentworth: dansmith: i guess we were supposed to be actively brainstorming for the forum https://etherpad.openstack.org/p/YVR-nova-brainstorming15:24
*** armaan_ has joined #openstack-nova15:25
*** armaan has quit IRC15:25
mriedemefried: jaypipes: cdent: edleafe: i'm sure there are placement things that could be at the forum15:25
mriedeme.g. cinder talking about maybe leveraging it in their scheduler15:26
*** slaweq has quit IRC15:26
cdentmriedem: yes, it's on y list15:26
* efried doesn't really know what the forum is.15:26
cdentgot a couple things, including the cinder thing15:26
mriedemefried: design sessions at the summit15:26
*** slaweq has joined #openstack-nova15:26
bauzasmriedem: ack, I'll look15:26
bauzas-ETOOMANYPLACEMENTSPECS15:27
bauzasshould we stop feeding the placement mogwaï after midnight ?15:27
*** tbachman has joined #openstack-nova15:28
*** chyka has quit IRC15:28
openstackgerritEd Leafe proposed openstack/nova-specs master: Add Generation to Consumers  https://review.openstack.org/55697115:28
*** andreas_s has quit IRC15:28
efriedbauzas: It's water that makes 'em multiply.  Feeding after midnight turns 'em evil.15:29
edleafeefried: ^^ addressed your concerns15:29
*** andreas_s has joined #openstack-nova15:29
* efried clicks...15:29
*** Eran_Kuris has joined #openstack-nova15:30
bauzasefried: ha, right. So, people, stop hydrating your specs15:30
*** slaweq has quit IRC15:30
* efried <== '80s nerd15:31
jaypipesmriedem: it's not to enable anything in particular.  it's just to remove a restriction in the returned results of allocation candidates' provider_summaries section that wasn't necessary to restrict.15:31
bauzasand don't give'em a review after midnight or they'll turn into something bad15:31
bauzasefried: technically, growing mogwais is good15:31
*** purplerbot has quit IRC15:31
bauzasif you respect the 3 rules15:32
*** purplerbot has joined #openstack-nova15:32
* bauzas was born on 198015:32
bauzasjaypipes: what's up with the placement channel ? can I rejoin it ?15:33
cdentbauzas: yes, it's ready15:33
* bauzas was kicked for the first time since he's on IRC15:33
bauzas:'(15:33
jaypipesbauzas: I warned you to leave the channel :)15:34
*** germs has joined #openstack-nova15:34
*** germs has quit IRC15:34
*** germs has joined #openstack-nova15:34
bauzasjaypipes: well, you kick after the first warning, I hope your pugs behave correctly :p15:34
*** germs has quit IRC15:35
*** germs has joined #openstack-nova15:36
*** germs has quit IRC15:36
*** germs has joined #openstack-nova15:36
*** links has quit IRC15:37
*** andreas_s has quit IRC15:38
*** andreas_s has joined #openstack-nova15:38
openstackgerritEric Fried proposed openstack/nova-specs master: Return all resources in provider_summaries spec  https://review.openstack.org/55946615:39
efriedmriedem, jaypipes: I went ahead and made those edits ^15:39
efriedtetsuro ^15:39
*** dikonoo has joined #openstack-nova15:39
*** jpena is now known as jpena|brb15:41
bauzasefried: see my comment on the spec15:42
bauzasefried: about interop15:42
*** andreas_s has quit IRC15:43
bauzasefried: if people wanna add some query related to inventories, they should add it to Placement, not by a filter15:43
efriedbauzas:  Responding.15:43
bauzasefried: because the Placement logic needs to be interoperable for the same query15:43
*** dikonoor has quit IRC15:43
mriedemi just don't want to spend time making this change if nothing is going to leverage it in-tree right now15:44
*** gyee has joined #openstack-nova15:45
bauzasif we accept to pass back the inventories, then you'll be sure that one day or later, people will just use placement for basic checks, and will do python filtering for their specific calls15:45
mriedemif out of tree filters/weighters want to get full provider tree and inventory information, they can query placement directly15:45
bauzasand then, we're done with claims15:45
bauzaswhat mriedem said15:45
*** andreas_s has joined #openstack-nova15:48
jaypipeswhat?15:48
efriedjaypipes: Help me out here.  What's the reason we want to include non-requested resources and other-RPs-in-same-tree in provider summaries?15:49
*** namnh has quit IRC15:49
edleafefilters/weighers?15:49
jaypipesefried: so that filters like the NUMATopologyFilter and ComputeCapabilitiesFilter can use the inventory usage and trait information.15:50
mriedemif you need to filter on a resource class, that should be part of the requested resource in the query which puts it in the response, right?15:50
mriedemthis spec doesn't say anything about returning a full view of the resource provider traits either, only what was requested15:51
mriedemor do you already get the full set of traits back in provider summaries?15:51
efriedmriedem: As I tried to explain, we have no syntax to talk about resource classes we're *not* requesting.15:51
jaypipesmriedem: not if you want to know that a sibling NUMA node is "more packed" than another.15:51
efriedyeah, and that.15:51
*** nicolasbock has left #openstack-nova15:52
mriedemsure i get the weighing thing here15:52
mriedemi'm basically -1 until something in-tree is going to leverage this15:53
mriedembecause provider 'summary' is not going to be a summary anymore, it's going to be a full blown view of the provider, it sounds like anyway15:53
efriedmriedem: That's really what was intended from the start, I believe.  It was an artifact of the impl that it wound up being a subset.15:53
jaypipesmriedem: we already return all the rp traits, not just the ones requested. https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/objects/resource_provider.py#L342615:54
efriedmriedem: Surely you're not suggesting that "something in-tree is going to leverage this" is necessary in the Rocky timeframe?15:54
mriedemefried: why would that be shocking?15:54
jaypipesmriedem: summary only referred to the aggregation of usage counts.15:54
efriedmriedem: Because especially with placement stuff, we've got a long history of implementing enablement before implementing the thing that exploits it.15:55
mriedemefried: if a thing were queued up to exploit this, then it's a different story15:55
efriedmriedem: So you want a bp/spec for how NUMATopologyFilter is going to leverage this before you'll approve it?15:55
*** sree has quit IRC15:56
mriedemdepending on what that thing is, we might want to instead of just *always* returning the full inventory including the tree, maybe it's a parameter on the API to return something in addition to what we get today, based on config in nova which is based on which filters/weighters you're enabling15:56
efriedmriedem: Or is it enough to add more words to the use case paragraph?15:56
*** ragiman has quit IRC15:56
*** ktibi has quit IRC15:56
*** gouthamr has quit IRC15:56
*** sree has joined #openstack-nova15:56
* efried notes this would be a great topic for the #openstack-placement channel15:56
mriedemefried: i just think this is getting the cart before the hose15:56
mriedem*horse15:57
mriedemand not something we should be spending time on given all of the other stuff that is actually planned to be used in this release15:57
*** mrjk has joined #openstack-nova15:57
jaypipesmriedem: as I mentioned on the spec, I see this more of correcting an earlier mistake of not returning all resource class inventories/usage summaries in the provider_summaries section when we should have been doing that from the start.15:57
*** yikun has quit IRC15:57
efried++15:57
*** yikun has joined #openstack-nova15:57
efriedAlso, the code is already done15:58
*** belmoreira has quit IRC15:58
mriedemwe never told anyone they should fully implement something before the bp is approved15:58
mriedemcode being done doesn't mean anything to me15:58
efriedfrom the perspective of spending time on it.15:58
mriedemvolume multiattach was 'done' in havana15:58
efriedAlready has one core reviewer ready to +2, just holding up on spec approval.15:59
mriedemand there is absolutely no unnecessary performance penalty on scheduling by returning full provider trees and inventory for all providers in a given request, even though we have nothing lined up to leverage it?16:00
mriedemeven if i get back 1000 of these things now?16:00
*** sree has quit IRC16:01
efriedFor the back-end retrieval, no.  As far as wire traffic, in the common case we have today, there will be *almost* no difference in the payloads anyway.16:01
efriedcfriesen_: You feel like writing something up about how NUMATopologyFilter will exploit provider_summary data?16:02
*** ssurana has joined #openstack-nova16:03
*** dpawlik has joined #openstack-nova16:03
*** dpawlik has quit IRC16:04
*** Eran_Kuris has quit IRC16:04
*** dpawlik has joined #openstack-nova16:04
*** lpetrut has joined #openstack-nova16:05
edleafeCan anyone with more sqla-fu explain why the migration [0] and the model here [1] are not in sync?16:06
edleafe[0] https://review.openstack.org/#/c/557958/4/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/059_add_consumer_generation.py16:06
edleafe[1] https://review.openstack.org/#/c/557958/4/nova/db/sqlalchemy/api_models.py16:06
efriedjaypipes: ^  I couldn't tell at a glance either edleafe16:06
*** andreas_s has quit IRC16:06
openstackgerritEric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option  https://review.openstack.org/55468816:07
*** ssurana has quit IRC16:07
*** andreas_s has joined #openstack-nova16:07
*** fragatina has joined #openstack-nova16:09
*** jchhatbar has quit IRC16:10
jaypipesedleafe: maybe try removing all of the server_default stuff.16:11
efriedesberglu: As takashin mentioned, ^ needs a reno16:11
esbergluefried: Yep, posted a comment saying the same16:11
jaypipesedleafe: perhaps it's a thing where the difference between sqlalchemy-migrate and sqlalchemy's models are weird.16:11
efriedesberglu: Oh, see it now.16:11
*** lpetrut has quit IRC16:11
esbergluDidn't see it before16:11
*** lpetrut has joined #openstack-nova16:12
*** artom_ is now known as artom16:12
*** dpawlik_ has joined #openstack-nova16:12
*** dpawlik has quit IRC16:12
*** dpawlik_ has quit IRC16:13
*** dpawlik has joined #openstack-nova16:13
*** Zames has quit IRC16:15
*** Zames_ has joined #openstack-nova16:15
*** zhaochao has quit IRC16:15
*** amodi has quit IRC16:16
*** madhaviy has joined #openstack-nova16:17
*** felipemonteiro_ has quit IRC16:17
*** dpawlik_ has joined #openstack-nova16:18
*** damien_r has quit IRC16:18
*** AlexeyAbashkin has joined #openstack-nova16:18
*** lucasagomes is now known as lucas-afk16:19
*** andreas_s has quit IRC16:20
*** lpetrut has quit IRC16:20
edleafejaypipes: I'll give it a try16:21
*** dpawlik has quit IRC16:21
*** dpawlik has joined #openstack-nova16:22
*** dpawlik_ has quit IRC16:22
jaypipesedleafe: step 2: yell at jaypipes about even mentioning server_default. ;)16:22
*** jpena|brb is now known as jpena16:24
edleafejaypipes: only if the test passes now :)16:25
jaypipeshehe16:25
*** andreas_s has joined #openstack-nova16:26
*** sambetts is now known as sambetts|afk16:26
*** dpawlik_ has joined #openstack-nova16:27
*** dpawlik_ has quit IRC16:27
edleafejaypipes: you're lucky. The test failed16:27
jaypipeshehe16:27
*** dpawlik_ has joined #openstack-nova16:27
edleafejaypipes: sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) Cannot add a NOT NULL column with default value NULL [SQL: u'\nALTER TABLE consumers ADD generation INTEGER NOT NULL'] (Background on this error at: http://sqlalche.me/e/e3q8)16:27
*** dpawlik has quit IRC16:27
jaypipesahhh16:28
*** germs has quit IRC16:28
*** germs has joined #openstack-nova16:28
*** germs has quit IRC16:28
*** germs has joined #openstack-nova16:28
*** germs has quit IRC16:28
*** germs has joined #openstack-nova16:28
*** germs has quit IRC16:28
*** germs has joined #openstack-nova16:28
jaypipesedleafe: this is ringing a bell... I think dansmith ran into a similar issue in the past.16:29
jaypipesedleafe: I think it's a sqlite-ism16:30
jaypipesedleafe: one sec16:30
dansmithdoesn't ring for me16:30
cdentmriedem: I added a couple of placement-related things to http://forumtopics.openstack.org/16:30
cdentjust sos you're aware16:30
*** liverpooler has quit IRC16:31
*** germs has quit IRC16:31
jaypipesedleafe: sqlite doesn't support full alter table.16:31
jaypipesedleafe: so you will need to do a funky script for sqlite :(16:31
*** hongbin has joined #openstack-nova16:32
edleafeorly?16:32
jaypipesedleafe: I can try to give it a shot if you'd like, but wouldn't be able to get to it until tomorrow likely16:32
jaypipesedleafe: yeah, lemme grab an example16:32
edleafeok, let me do some googling16:32
*** germs has joined #openstack-nova16:33
*** germs has quit IRC16:33
*** germs has joined #openstack-nova16:33
*** lpetrut has joined #openstack-nova16:33
edleafeso it's not the server_default stuff; it's changing the nullable for the project_id and user_id fields that sqlite doesn't support16:35
*** germs has quit IRC16:35
*** andreas_s has quit IRC16:35
*** yamamoto has joined #openstack-nova16:37
jaypipesedleafe: no16:37
*** yamamoto has quit IRC16:38
jaypipesedleafe: it's the addition of the generation column to the consumers table as a NOT NULL field that fails.16:38
jaypipesedleafe: because that create_column() ends up being translated to an ALTER TABLE consumers ADD COLUMN generation NOT NULL16:38
jaypipesedleafe: and SQLite's ALTER TABLE ... ADD COLUMN doesn't support a DEFAULT clause :(16:39
jaypipesedleafe: so you need to do a CREATE TABLE consumers_new with the new schema, then do a SELECT into the new table, then do a DROP TABLE consumers; RENAME TABLE consumers_new TO consumers16:39
jaypipesedleafe: like I said, it's a pain in the ass.16:39
jaypipesedleafe: and I'm wondering if we need to do it for SQLite anyway since it's dev-only DB.16:40
edleafefrom the sqlite docs: "Only the RENAME TABLE and ADD COLUMN variants of the ALTER TABLE command are supported. Other kinds of ALTER TABLE operations such as DROP COLUMN, ALTER COLUMN, ADD CONSTRAINT, and so forth are omitted."16:40
*** andreas_s has joined #openstack-nova16:40
jaypipesedleafe: yes, but the DEFAULT clause of ADD COLUMN isn't supported, IIRC16:40
edleafejaypipes: sure, but neither would the ALTER COLUMN calls for those other two fields, right?16:41
jaypipesso you can't do: ALTER TABLE consumers ADD COLUMN generation INTEGER NOT NULL DEFAULT 016:41
openstackgerritChris Dent proposed openstack/nova master: Use nova.db.api directly  https://review.openstack.org/54326216:41
jaypipesedleafe: yes, likely. it's probably that those errors haven't (yet) come up due to the failure of the consumers.generation thing first.16:41
edleafejaypipes: ok, I'll give it a shot. It would be *so* much easier in SQL than sqla.16:42
*** elmaciej has quit IRC16:42
edleafejaypipes: although I did lift the nullable change from nova/db/sqlalchemy/migrate_repo/versions/267_instance_uuid_non_nullable.py16:42
jaypipesedleafe: so you'll need to add a file in the migrate_repo called 059_add_consumer_generation.sql I believe.16:42
edleafeand that made it in16:43
jaypipesedleafe: and then guard the 059_add_consumer_generation.py file with the whole dialect != 'sqlite' thing16:43
jaypipesedleafe: alternately, you could just execute raw sql statements like is done here: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/044_placement_add_projects_users.py#L63-L7716:44
edleafejaypipes: so the .sql file will be executed automatically? Or do I call it from the .py?16:44
jaypipesedleafe: pretty sure it would get executed automatically, but lemme check16:45
edleafeah, I like that better16:45
*** udesale has quit IRC16:46
*** mikal has quit IRC16:46
*** mikal has joined #openstack-nova16:47
jaypipesedleafe: so apparently ALTER TABLE ... ADD COLUMN in SQLite *does* support the DEFAULT clause.16:48
jaypipesedleafe: so I'm not sure why it's not being generated here.16:48
*** tesseract has quit IRC16:48
*** armaan_ has quit IRC16:49
*** andreas_s has quit IRC16:49
*** armaan has joined #openstack-nova16:50
*** jgwentworth is now known as melwitt16:51
-openstackstatus- NOTICE: zuul was restarted to update to the latest code; please recheck any changes uploaded within the past 10 minutes16:52
*** sahid has quit IRC16:53
*** dpawlik_ has quit IRC16:53
*** krtaylor has joined #openstack-nova16:54
*** armaan has quit IRC16:54
*** andreas_s has joined #openstack-nova16:54
jaypipesedleafe: ok, I'm a bit stumped... may need to reach out to zzzeek_ on this one. can you try setting default="0" instead of default=0 in both the migration and models?16:57
jaypipesedleafe: from the error message it kinda seems like the difference that oslo.db's test_models_in_sync thing is seeing has to do with '0' vs. a sqlalchemy.sql.elements.TextClause objectTextClause16:58
openstackgerritSurya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service.  https://review.openstack.org/55492016:58
*** derekh has quit IRC16:59
*** hemna_ has joined #openstack-nova17:02
dansmithmriedem: I think we already have a place where we need placement configured for nova-api17:02
dansmithalthough I think we're not actually doing the thing that would require it17:02
dansmithwhich is local delete nuking allocations17:02
*** ralonsoh has quit IRC17:02
*** AlexeyAbashkin has quit IRC17:02
*** mgoddard has quit IRC17:03
*** david-lyle has joined #openstack-nova17:04
edleafejaypipes: no dice on default="0"17:04
edleafejaypipes: same error17:04
jaypipes:(17:05
*** germs has joined #openstack-nova17:06
*** germs has quit IRC17:06
*** germs has joined #openstack-nova17:06
*** dklyle has quit IRC17:07
*** AlexeyAbashkin has joined #openstack-nova17:09
*** andreas_s has quit IRC17:09
*** germs has quit IRC17:09
*** germs has joined #openstack-nova17:10
*** germs has quit IRC17:10
*** germs has joined #openstack-nova17:10
*** suresh12 has joined #openstack-nova17:11
*** germs has quit IRC17:12
mriedemdansmith: yeah that's a latent bug, which i've had sitting in my todo list,17:12
mriedemi'll tackle it at 3pm on friday :)17:12
dansmiththat's fine, just don't expect me to be around for it :)17:12
mriedemyou said you'd always be there for me17:13
mriedemavolkov: some easy changes to make in https://review.openstack.org/#/c/511183/ - just got feedback from dtroyer too17:14
mriedemalthough i know it's late in the day for you17:14
*** yamamoto has joined #openstack-nova17:16
*** jpena is now known as jpena|away17:18
*** madhaviy has quit IRC17:18
*** ssurana has joined #openstack-nova17:19
*** gjayavelu has joined #openstack-nova17:19
mriedemdansmith: when you get a sec, there is a mini debate in my patch to wait for vif plugged events before starting live migration that could use your input https://review.openstack.org/#/c/558001/ - some of it around whether or not we should even fail if we timeout, which thinking back on sahid's recent patch for linuxbridge, that doesn't fail on timout, it just logs a warning and continues17:23
openstackgerritMerged openstack/nova-specs master: mirror nova host aggregates to placement API  https://review.openstack.org/54505717:23
dansmithmriedem: no, I made him fail if it times out17:23
mriedemyeah i see that now https://github.com/openstack/nova/blob/e2d5dc4e2c5f69fcbcb04c29b2ed469725122787/nova/virt/libvirt/driver.py#L742917:24
mriedemso it's totally unconditional based on the CONF.vif_plugging_is_fatal option17:24
*** felipemonteiro has joined #openstack-nova17:24
dansmithif we're expecting an event and don't get it, we should fail just about anything, IMHO, except if we're waiting during delete or something17:24
mriedemthat was basically my reply in my patch17:25
mriedemif i set this, i expect an event17:25
mriedemfail if it doesn't happen17:25
dansmithtotes17:25
*** amodi has joined #openstack-nova17:25
*** gouthamr has joined #openstack-nova17:27
*** andreas_s has joined #openstack-nova17:28
*** sapd has quit IRC17:32
*** andreas_s has quit IRC17:32
*** r-daneel has quit IRC17:33
mriedemdansmith: on https://review.openstack.org/#/c/558059/4/nova/compute/manager.py@368 did you want to update that and add yourself as co-author?17:33
mriedemotherwise the change lgtm17:33
mriedemill leave it up to efried and jaypipes to love up on it otherwise17:33
dansmithmriedem: I don't care, but if you want blame-sharing I'll be glad to17:35
*** gouthamr has quit IRC17:35
mriedemupdated that comment, event.key is probably ok17:35
mriedemso just drop the wip if you don't want co-blame17:36
dansmithdone17:36
*** mdnadeem has quit IRC17:38
*** tssurya has quit IRC17:39
efriedmriedem, dansmith: +2.  Who's gonna be the second +2?17:41
mriedemi only mentioned two people to love up on it17:42
*** felipemonteiro_ has joined #openstack-nova17:42
*** mgoddard has joined #openstack-nova17:42
*** READ10 has quit IRC17:43
*** mvk has quit IRC17:44
*** felipemonteiro has quit IRC17:46
*** yikun has quit IRC17:46
*** yikun has joined #openstack-nova17:46
zzzeek_jaypipes: server_default in SQLAlchemy for a DEFAULT clause17:50
*** eharney has quit IRC17:50
*** yikun has quit IRC17:50
dansmithah, now that does sound familiar17:50
*** yikun has joined #openstack-nova17:50
*** dklyle has joined #openstack-nova17:52
*** david-lyle has quit IRC17:53
*** fragatina has quit IRC17:53
*** eharney has joined #openstack-nova17:56
*** yamamoto has quit IRC17:57
*** liverpooler has joined #openstack-nova17:58
*** andreas_s has joined #openstack-nova18:00
*** AlexeyAbashkin has quit IRC18:01
*** amoralej is now known as amoralej|off18:03
*** sridharg has quit IRC18:07
edleafezzzeek_: Hey, can you take a look at a migration issue I'm having?18:09
jaypipeszzzeek_: we've tried adding and removing server_default with no luck...18:09
edleafejaypipes: I tried the recreate, import, drop, rename dance, but it seems to have a problem with the autoincrement18:10
mriedemdansmith: just need a simple unit test add to https://review.openstack.org/#/c/539590/ and i'm +218:11
mriedemi know that's an older series18:11
dansmithoh yeah, forgot about that18:14
*** andreas_s has quit IRC18:15
*** hanish_ has joined #openstack-nova18:15
hanish_hi all, i am trying to launch vm, but i am facing timed  out error in nova conductor, can someone help me on thos18:16
esberglumriedem: Should I put the new powervm conf group in the features category or upgrade category in the release note?18:20
esbergluAll the other conf related stuff is in upgrade, but I haven't found any adding new group, just moving existing groups18:20
esbergluFeature seems more accurate to me18:20
*** lpetrut has quit IRC18:22
*** Zames_ has quit IRC18:23
openstackgerritMerged openstack/nova master: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt  https://review.openstack.org/54423818:24
*** pchavva has quit IRC18:25
mriedemesberglu: let me check to see what this is actually doing18:27
*** jpena|away is now known as jpena|off18:27
*** READ10 has joined #openstack-nova18:27
esberglumriedem: Allows a user to specify how much of a physical proc to assign each vCPU18:28
*** Zames has joined #openstack-nova18:28
*** slaweq has joined #openstack-nova18:28
*** AlexeyAbashkin has joined #openstack-nova18:28
*** mvk has joined #openstack-nova18:29
mriedemyeah, don't worry, i've got the fine toothed comb out now18:29
*** avolkov has quit IRC18:31
*** Zames has quit IRC18:33
openstackgerritMerged openstack/nova master: Avoid dumping stack on BuildAbortException  https://review.openstack.org/55975118:33
mriedemesberglu: comments inline18:34
mriedemesberglu: what's with the flavor extra spec mention?18:35
mriedemis that something yet to be added?18:35
esberglumriedem: Added that flavor extra spec mention after comments from edmondsw18:40
*** cdent has quit IRC18:40
edmondswwhat commit?18:40
esbergluedmondsw: https://review.openstack.org/#/c/554688/3/nova/conf/powervm.py@3018:41
*** tianhui_ has quit IRC18:41
*** tianhui has joined #openstack-nova18:41
mriedemi'm ok with blaming things on edmondsw18:42
edmondswworks for me :)18:42
edmondswyeah, we shouldn't mention that if it's only an OOT thing18:43
mriedemi don't even see it in the out of tree driver18:43
edmondswI didn't realize that was only OOT18:43
edmondswlooking...18:43
openstackgerritMatt Riedemann proposed openstack/nova master: Log a warning and add nova-status check for old API service versions  https://review.openstack.org/55750618:44
mriedemhttps://github.com/openstack/nova-powervm/search?utf8=%E2%9C%93&q=proc_unit_factor&type=18:44
zzzeek_jaypipes edleafe I can look later, though Im not sure SQLite even supports ALTER TABLE for a server default if that's your target DB18:44
mriedemi found https://github.com/openstack/nova-powervm/commit/4bad1ec1654b757c70100fbcc6f51505719d79d9 - and this setting is in the pypowervm lib18:44
*** mgoddard has quit IRC18:44
esbergluproc_units_factor not proc_unit_factor18:45
zzzeek_jaypipes edleafe oh but if this is nova / sqlalchemy-migrate then that's another wrinkle18:45
edleafezzzeek_: it's in one of the functional tests18:46
edmondswmriedem esberglu misnamed: https://github.com/openstack/nova-powervm/blob/1dc302b7198ad749dc14cc69cf8f2e45e929d132/nova_powervm/virt/powervm/vm.py#L248-L25018:46
zzzeek_edleafe: add me to the review and ill try to look later18:46
edleafezzzeek_: k - thanks18:46
mriedemedmondsw: esberglu: ok, so...18:46
mriedemyou're upstreaming a thing from the out of tree driver,18:47
edmondswand those are in nova as well as nova-powervm18:47
edmondswno18:47
mriedemfor a flavor extra spec that's not part of the same series18:47
edmondswis is already in nova18:47
mriedemok powervm:proc_units is in nova yeah i see18:47
*** dikonoo has quit IRC18:47
mriedemok can we unclusterfudge the commit message on this along with the config option help and such?18:47
*** cdent has joined #openstack-nova18:47
edmondswhttps://github.com/openstack/nova/blob/master/nova/virt/powervm/vm.py#L379-L38118:47
edmondswyeah, we'll get the right extraspec(s) mentioned18:48
edmondswgood catch, tx18:48
mriedemthe default matches what's in the out of tree driver,18:48
mriedembut not what you'd get today with the in-tree driver18:48
mriedemi don't know how you want to resolve that18:48
mriedemi'm inclined to not care about the out of tree default18:48
edmondswmriedem that's part of the reason for this change18:48
edmondswthe default in the nova driver was not great... and we definitely want it to be consistent18:49
edmondswit was always meant to be 0.1 by default18:49
mriedemwhy not change the default in the library?18:49
edmondswmriedem because pypowervm is used by folks, whereas the powervm driver in nova isn't yet18:51
mriedemif folks are using the out of tree driver, they are getting the out of tree default config opt value, not what's in the library18:51
mriedemyeah?18:51
mriedembut lowly in-tree driver is18:52
edmondswI mean folks are using pypowervm directly, not only via the oot driver18:52
mriedemfolks == powervm?18:53
mriedem*powervc18:53
edmondswnot powervc... it uses nova-powervm18:53
edmondswbut others18:53
mriedemoVirt on Power18:53
mriedemgot it :)18:53
edmondswnon-OpenStack folks18:53
edmondswbasically, this is a goof, we release changing the default in nova is lousy, but it was just the best solution in this case18:54
edmondsws/release/realize/18:54
mriedemok, so you don't want to change the default in the library, i get it. then esberglu it's an upgrade release note, not feature18:54
edmondswyep18:54
*** dpawlik has joined #openstack-nova18:54
mriedemwell, it's honestly probably both18:55
mriedemboth a new option (feature) and an upgrade since the default for that new option changes the default18:56
mriedemon an existing extra spec18:56
mriedemjust do both in a single reno file18:56
esberglumriedem: Sounds good18:56
esbergluedmondsw: tx for the help, I didn't have as much context, just wanted to fix CI :)18:56
edmondswanytime :)18:58
*** tssurya has joined #openstack-nova19:04
*** dpawlik has quit IRC19:05
*** AlexeyAbashkin has quit IRC19:09
*** hanish_ has quit IRC19:10
mriedemhuh, it probably surprises no one that when we shelve offload a server, we null out the host but not it's AZ value19:11
mriedemthis is the time where cfriesen_ is supposed to ask if anyone uses shelve19:12
*** suresh12 has quit IRC19:14
*** suresh12 has joined #openstack-nova19:14
mriedemjmlowe_: hey i'm trying to recreate https://bugs.launchpad.net/nova/+bug/1759924/ on a single node devstack system19:16
openstackLaunchpad bug 1759924 in OpenStack Compute (nova) "Port device owner isn't updated with new host availability zone during unshelve" [Medium,Triaged] - Assigned to Matt Riedemann (mriedem)19:16
mriedemjmlowe_: and things are find until i shelve, rename the az from az1 to az2, and then try to unshelve the instance19:16
mriedemit blows up because the AZ filter is looking for az1 which is now gone19:17
jmlowe_yes19:17
mriedemoh in yours you unshelved to a different az/host19:17
jmlowe_unshelve will put it anywhere if the original spec doesn't have an az19:17
jmlowe_correct19:17
mriedemoh yeah, i created this instance with az1 specifically, so it's in the request spec, yeah i'll fix that and retry19:17
*** yamamoto has joined #openstack-nova19:18
mriedemthis kind of seems like a bug of it's own, but not sure what we'd do about it19:18
*** claudiub has quit IRC19:18
*** suresh12 has quit IRC19:19
mriedemwe'd have to update any shelved instances in an az if we rename that az19:19
*** claudiub has joined #openstack-nova19:19
jmlowe_if nothing else, where ever an instance is unshelved it needs to update the device_owner because it is there and that is truth19:20
mriedemjmlowe_: yeah i'm trying to get to that part19:20
mriedemjmlowe_: while you've got az renames on the brain, maybe you'd like to reply to http://lists.openstack.org/pipermail/openstack-operators/2018-March/015029.html with your thoughts19:21
jmlowe_oh, I effectively did that by putting all my computes into rackwise az19:22
jmlowe_to get migration to work again I wound up editing the specs19:22
mriedemi bet updating json blobs in the db is super fun19:22
*** READ10 has quit IRC19:22
mriedemjmlowe_: ack confirmed http://paste.openstack.org/show/718769/19:28
*** yamamoto has quit IRC19:33
*** armaan has joined #openstack-nova19:34
openstackgerritSurya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service.  https://review.openstack.org/55492019:36
jmlowe_mriedem: it was all the fun you might imagine it to be and then some19:36
jmlowe_if you could never change the az name because you could never change the spec then az's really become a nightmare for operators and should be avoided at all costs, probably not what people really want19:38
*** mriedem has quit IRC19:41
*** mriedem has joined #openstack-nova19:45
*** cdent has quit IRC19:45
mriedemjmlowe_: what if, for starters, as mentioned in that ML thread, we just didn't allow az renames while there were (alive) instances in those AZs?19:45
mriedemso operators can't shoot themselves in the foot that way?19:45
*** yamahata has quit IRC19:47
*** Roamer` has quit IRC19:48
*** Roamer` has joined #openstack-nova19:48
jmlowe_Lets say you start with the default "nova", specs wind up with nova in it, how to you create any AZ if you didn't plan on it from the beginning?  Do you have to get this right before any people start using your cloud and make sure your guesses never having run a cloud before were correct for all time?19:49
mriedemis nova put into the request spec?19:49
mriedemhttps://github.com/openstack/nova/blob/master/nova/compute/api.py#L89519:50
mriedem'nova' shouldn't be in the request spec unless the user specifically requested --availability-zone nova19:50
jmlowe_Maybe not anymore, but my "no free hosts" live migration problems were because nova az was in the specs19:51
jmlowe_Fixes you didn't know you needed but always wanted19:51
mriedemhmm, i'm not saying users couldn't wedge themselves,19:51
mriedemthe server create API does say to not specify 'nova' here https://developer.openstack.org/api-ref/compute/#id1019:51
jmlowe_I think I would make more mistakes with renames disallowed than I would with it allowed19:52
mriedemhuh, this inconsistency in the CLI for non-admins isn't good either http://paste.openstack.org/show/718771/19:53
jmlowe_it's kind of bad data modeling to have it all based on name and not id19:53
mriedemjmlowe_: yeah that's jaypipes' point in the ML thread,19:53
mriedembut is also a bigger hairier change19:53
jmlowe_I really don't have any answers over here, just the ability to create more problems for myself19:54
mriedemheh, fair enough19:54
jmlowe_I'm looking at the possibility of going all in on host aggregates to keep certain customers on hardware they bought sometime later this summer19:55
openstackgerritMerged openstack/nova master: Fix comments at the 'save' method of objects.Instance  https://review.openstack.org/55974319:56
jmlowe_none of this is going to get easier for me19:56
jmlowe_I've observed that cli behavior before19:57
mriedemhttps://bugs.launchpad.net/python-openstackclient/+bug/176253419:57
openstackLaunchpad bug 1762534 in python-openstackclient "openstack availability zone list shows default 'nova' AZ to non-admin users" [Undecided,New]19:57
mriedemi'll have to dig into that later19:57
*** pchavva has joined #openstack-nova20:02
*** yamamoto has joined #openstack-nova20:09
openstackgerritMerged openstack/nova master: Fix cancel_all_events event name parsing  https://review.openstack.org/55805920:09
*** yamamoto has quit IRC20:18
openstackgerritMatt Riedemann proposed openstack/nova master: Update port device_owner when unshelving  https://review.openstack.org/55982820:18
mriedemjmlowe_: ^20:18
*** yamamoto has joined #openstack-nova20:19
jmlowe_That looks pretty good20:20
*** yamamoto has quit IRC20:22
*** suresh12 has joined #openstack-nova20:22
*** yikun has quit IRC20:24
*** yikun has joined #openstack-nova20:24
*** yikun has quit IRC20:25
*** yikun has joined #openstack-nova20:25
*** suresh12 has quit IRC20:26
*** esberglu has quit IRC20:27
*** esberglu has joined #openstack-nova20:28
mriedemoh it doesn't fix the bug in the single node devstack case...20:29
mriedembecause on shelve offload, we don't clear the port binding host id, so the conditional on unshelve isn't true20:29
jmlowe_really? looks like it should work20:29
mriedemit would work in a >1 compute env :)20:29
jmlowe_oh, that's what somebody was on about when I first reported it20:29
jmlowe_clearing the port on shelve20:29
mriedemthat was me :)20:29
mriedemand that's the todo i left in the code20:30
jmlowe_how convenient20:30
*** esberglu_ has joined #openstack-nova20:30
*** esbergl__ has joined #openstack-nova20:31
*** esbergl__ is now known as esberglu__20:32
mriedemi wanted to avoid fixing the shelve / clear case in the same patch since that gets slightly more complicated, and not really needed to fix this bug20:32
mriedemunless your production env is 1 compute host...20:32
mriedemmaybe it's a mainframe20:33
*** esberglu has quit IRC20:33
*** vladikr has quit IRC20:34
*** esberglu_ has quit IRC20:34
*** vladikr has joined #openstack-nova20:35
*** salv-orlando has quit IRC20:36
*** pcaruana has quit IRC20:36
*** salv-orlando has joined #openstack-nova20:36
*** esberglu__ is now known as esberglu20:37
*** yikun has quit IRC20:45
*** yikun has joined #openstack-nova20:46
*** vladikr has quit IRC20:47
*** vladikr has joined #openstack-nova20:47
*** fragatina has joined #openstack-nova20:47
*** fragatina has quit IRC20:48
*** fragatina has joined #openstack-nova20:49
*** pchavva has quit IRC20:52
openstackgerritJay Pipes proposed openstack/nova master: mirror nova host aggregate members to placement  https://review.openstack.org/55359720:53
*** yamamoto has joined #openstack-nova20:54
*** liverpooler has quit IRC20:55
*** yamamoto has quit IRC20:58
*** r-daneel has joined #openstack-nova21:00
*** slaweq has quit IRC21:01
*** slaweq has joined #openstack-nova21:02
*** harlowja has joined #openstack-nova21:03
*** yikun has quit IRC21:06
*** yikun has joined #openstack-nova21:06
*** slaweq has quit IRC21:06
*** tblakes has joined #openstack-nova21:10
*** awaugama has quit IRC21:11
*** eharney has quit IRC21:12
tblakesdansmith: Could you please take a look at https://review.openstack.org/#/c/559158/ if you have a chance. It's gotten a +2 from Matt Riedemann but still needs to get a +1 on workflow. It's a cherry pick from master to stable/queens.21:12
*** arvindn05 has quit IRC21:13
*** dpawlik has joined #openstack-nova21:14
*** r-daneel has quit IRC21:15
*** artom has quit IRC21:15
*** tssurya has quit IRC21:16
*** r-daneel has joined #openstack-nova21:16
*** dpawlik has quit IRC21:18
*** dougshel_ has quit IRC21:20
*** gouthamr has joined #openstack-nova21:20
*** edmondsw has quit IRC21:22
*** edmondsw has joined #openstack-nova21:24
*** edmondsw has quit IRC21:29
*** abalutoiu__ has quit IRC21:29
*** tblakes has quit IRC21:30
*** Guest64304 has quit IRC21:34
imacdonndansmith: if you have a moment, could you evaluate https://review.openstack.org/#/c/558089/ , please?21:51
*** dougshelley66 has joined #openstack-nova21:57
openstackgerritEric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option  https://review.openstack.org/55468822:00
dansmithimacdonn: mriedem: sorry, I just can't get on board with that22:04
imacdonndansmith: OK.... do you have another idea ?22:04
dansmithimacdonn: I don't think it's something we need to do at all, TBH, but if we're going to, we should make it useful22:05
imacdonnefried: heads-up22:05
dansmithimacdonn: we're going to hork out the resource provider a couple seconds later, so do that early or something22:05
dansmithbut really,22:05
dansmithwe should be fine to just log the problem, explain the issue and whatever22:06
imacdonndansmith: my original idea was to do away with the check completely ... but mriedem was concerned about the case where the scheduler doesn't require placement, but we want to force it anyway, for reporting purposes22:06
dansmithimacdonn: okay I'm not sure why the current config-based check doesn't support that scenario22:07
imacdonndansmith: the issue is that the current check uses an option that's not required .. so it barfs on a perfectly valid config22:07
imacdonndansmith: I suppose an alternative would be to check for auth_type instead of region_name22:08
dansmithimacdonn: ah, right, well, then no check at startup like I was saying I guess22:08
imacdonndansmith: if auth_type is always going to be required .............22:08
dansmithimacdonn: catch it when we go to fetch our RP record the first time, log the bejeezus out of it22:08
efriedIMO it would be nice to fail early with a nice message rather than let it fail "naturally" somewhere down the line.22:09
imacdonndansmith: I believe that there's a case where there would be no request for RP (depending on scheduler config)22:09
efriedright, and in ^ that case, "down the line" could be way later.22:09
dansmithefried: we don't check all of config on startup, but also, isn't this a thing that could be fixed at runtime in the service catalog22:09
dansmith?22:09
dansmithimacdonn: efried: no, the RP setup will happen just a few seconds after startup, when listing the nodes and running the resource tracker stuff22:10
efriedFor this code path, you have to fix it by editing conf.22:10
efriedwhich I hear is going to be able to be picked up dynamically across the board soon anyway, so...22:11
dansmithefried: it already can be22:11
dansmithefried: if you mark these things as reloadable and they are,22:11
dansmiththen done deal22:11
efriedcool cool.22:11
efrieddansmith: So you're advocating removing the check entirely and letting it fail organically down the line22:11
dansmithefried: if we can't do a legit check then yeah22:12
efriedJust so you're aware, @safe_connect has the potential to make that somewhat... unclean.22:12
efriedWait, how is this check not legit?22:12
dansmith"why the fsck are my computes requesting /foo/?bogus" would be high on my list22:12
dansmithefried: I mean a legit check without spamming the logs in placement22:12
dansmitha legit config-only check22:12
efriedone entry on startup is hardly spamming, but okay.  auth_type it is, I guess.22:13
dansmithI just restarted 1000 computes22:13
imacdonncan we say (with reasonable confidence) that auth_type will always be a required option? TBH, I'm not sure why it doesn't default to 'password'22:13
dansmiththat's a lot of spam22:13
efriedThis I cannot answer.22:14
dansmithif I didn't, and I'm auditing logs, I find some /?bogus queries to placement and wonder who the fsck is on my network22:14
*** rcernin has joined #openstack-nova22:14
dansmithand then realize it's ... mah compute nodes22:14
dansmithI don't want to be on that customer call22:14
efriedimacdonn: In other places we go to load the auth from conf and error if it comes back None.22:15
*** r-daneel has quit IRC22:15
dansmithwe call pre_start_hook before we even listen to RPC, and that calls update_available_resource, which will pull our RPs from placement22:15
efriedWhich in this case might look a little bit like publicizing (bits of) SchedulerReportClient._create_client.22:15
*** r-daneel has joined #openstack-nova22:16
efriedNope, forget that.22:17
efriedSo we could check for auth_type, and if not set, log a helpful warning, but not raise, and then let the failure happen organically down the line.22:18
*** mlavalle has quit IRC22:18
efriedthat's future-proof in the case where auth_type becomes not required.22:18
dansmithso, we'd get the first failure before we even listen to RPC, run our first periodic, etc22:18
imacdonndansmith: so are you still advocating just removing the check entirely? I'd be cool with that, but mriedem may not be22:24
dansmithimacdonn: if we can't do the check reliably based just what is in config, then yeah I think we should remove it22:25
dansmithimacdonn: I also think that we're doing legit talking to placement so early in service startup, that we could mangle up some of that code to make it fail really hard if you really wanted to22:25
dansmithbut I also think that heavy logging of what we found when we reliably found it is completely legit22:26
imacdonndansmith: I guess my perception is that we want to fail hard, not just log something and continue anyway ..... perhaps because people only check logs if something is obviously not working (e.g. nova-compute service not coming up)22:27
dansmithimacdonn: if compute can't report to placement, then things won't work22:27
*** esberglu has quit IRC22:27
dansmithimacdonn: we do a similar thing because we're dependent on conductor.. we check at startup and log in a loop that we can't do anything22:28
*** esberglu has joined #openstack-nova22:28
imacdonndansmith: I've been led to believe that there's a scheduler config where it would work OK for the most part, but not report into placement22:28
dansmithwe have to do that late because we need RPC to be up before we can reliably know if conductor is up, just like this situation22:28
dansmithimacdonn: if you're using cachingscheduler then you can avoid hitting placement in the scheduler22:28
dansmithimacdonn: and you could argue that computes being misconfigured for placement would be "okay" in that situation22:28
dansmithimacdonn: however, going forward, we *have* to migrate those people to having data in placement so we can get rid of that situation22:29
imacdonndansmith: right, I believe that that's the case that mriedem was concerned about22:29
*** esberglu_ has joined #openstack-nova22:29
dansmithso that's a reason to hard fail, but again, if we can't reliably detect that except at runtime, then..we don't have much choice22:29
dansmithimacdonn: what about this.. make the compute service self-disable if we fail to update our RPs in placement?22:30
imacdonnI guess we can use auth_type ... It just feels a bit like making the same mistake a second time22:30
dansmithwe do that now for transient issues we find out about late, like libvirt stopping22:30
dansmithwe self-disable so that no new builds will come to us,22:30
dansmithwhich is a big fat "I need help" to the operator22:30
imacdonninteresting22:30
dansmithand there's a reason field22:30
dansmithself.disable(reason="you dun fscked up")22:30
imacdonnheh22:31
imacdonnI think I like that idea better22:31
*** r-daneel has quit IRC22:32
dansmithwe also self-disable if too many builds fail for unknown reasons22:32
*** r-daneel has joined #openstack-nova22:32
imacdonnunit-testing for that could be "fun" ...22:32
dansmithnah, 's easy22:32
dansmithhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1701-L170922:32
*** esberglu has quit IRC22:33
dansmithimacdonn: https://review.openstack.org/#/c/463597/22:34
*** esberglu_ has quit IRC22:34
dansmithlots of test examples in there22:34
mriedemjust rely on auth_type https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/176148722:34
mriedemwe are doing that for neutron and cinder too22:34
dansmithif that's legit, then sure22:34
*** felipemonteiro_ has quit IRC22:36
mriedemlet me also state, for the record, that i don't care too much about this and said so awhile back http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-03-30.log.html#t2018-03-30T21:39:0622:36
mriedemi definitely didn't think about the compute restart storm22:37
* dansmith -> &22:38
mriedemand now i must attend to 1st grade homework22:38
*** mriedem is now known as mriedem_afk22:38
imacdonnefried: any objection to using auth_type ?22:38
efriedimacdonn: No.  If they ever make that non-optional, I suspect many unintended side effects will result.22:39
efrieds/non-//22:39
imacdonnyeah, and it seems like it'd probably become non-optional for neutron at the same time22:39
efriedOh, it would be a ksa thing, so it would become optional for the world22:41
imacdonnright, that's what I meant22:41
imacdonnso if we do the same for placement as we do for neutron, such a change would break both at the same type22:42
efriedmore or less.  more or less.22:43
*** gouthamr has quit IRC22:43
*** gouthamr has joined #openstack-nova22:44
*** sdague has quit IRC22:45
*** hongbin has quit IRC22:45
imacdonnOK, I'll work on a new PS with that22:45
imacdonndansmith: thanks for the review22:46
*** dave-mcc_ has quit IRC22:49
*** esberglu has joined #openstack-nova22:50
openstackgerritEric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option  https://review.openstack.org/55468823:00
*** yamahata has joined #openstack-nova23:01
*** slaweq has joined #openstack-nova23:02
*** _ix has quit IRC23:03
openstackgerritMerged openstack/nova stable/queens: Add __repr__ for NovaException  https://review.openstack.org/55915823:04
*** patriciadomin has quit IRC23:04
*** ssurana has quit IRC23:04
*** patriciadomin has joined #openstack-nova23:05
*** r-daneel has quit IRC23:07
*** slaweq has quit IRC23:07
*** jaypipes has quit IRC23:08
*** lbragstad has quit IRC23:17
*** yamamoto has joined #openstack-nova23:22
*** gouthamr has quit IRC23:23
*** yamamoto has quit IRC23:26
*** yikun has quit IRC23:29
*** yikun has joined #openstack-nova23:29
*** lbragstad has joined #openstack-nova23:36
*** sapcc-bot has quit IRC23:39
*** sapcc-bot has joined #openstack-nova23:39
*** lbragstad has quit IRC23:47
*** mdurrant has quit IRC23:52
*** takashin has joined #openstack-nova23:52
*** yamamoto has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!