| *** stakeda has joined #openstack-nova | 00:02 | |
| *** logan- has quit IRC | 00:02 | |
| *** logan- has joined #openstack-nova | 00:02 | |
| *** _ix has joined #openstack-nova | 00:03 | |
| *** yamamoto has quit IRC | 00:03 | |
| *** gyee has quit IRC | 00:11 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:16 | |
| *** ssurana has joined #openstack-nova | 00:17 | |
| *** zhurong has joined #openstack-nova | 00:20 | |
| *** jackie-truong has joined #openstack-nova | 00:23 | |
| *** odyssey4me has quit IRC | 00:34 | |
| *** odyssey4me has joined #openstack-nova | 00:34 | |
| *** _ix has quit IRC | 00:41 | |
| *** artom has joined #openstack-nova | 00:48 | |
| *** germs has joined #openstack-nova | 00:56 | |
| *** germs has quit IRC | 00:56 | |
| *** germs has joined #openstack-nova | 00:56 | |
| *** mriedem_afk has quit IRC | 01:00 | |
| *** QianYu has joined #openstack-nova | 01:01 | |
| *** slaweq has joined #openstack-nova | 01:03 | |
| *** tiendc has joined #openstack-nova | 01:04 | |
| *** gjayavelu has quit IRC | 01:04 | |
| *** slaweq has quit IRC | 01:08 | |
| *** Zames has joined #openstack-nova | 01:09 | |
| *** Zames has quit IRC | 01:10 | |
| *** ssurana has quit IRC | 01:11 | |
| *** zhaochao has joined #openstack-nova | 01:12 | |
| *** salv-orl_ has joined #openstack-nova | 01:15 | |
| *** salv-orlando has quit IRC | 01:18 | |
| *** jichen has joined #openstack-nova | 01:18 | |
| openstackgerrit | Merged openstack/nova master: Replace mox stubs with stub_out in test_extended_volumes.py https://review.openstack.org/558685 | 01:21 |
|---|---|---|
| *** janki has joined #openstack-nova | 01:27 | |
| *** claudiub has quit IRC | 01:31 | |
| *** hongbin has joined #openstack-nova | 01:33 | |
| *** QianYu has quit IRC | 01:34 | |
| *** QianYu has joined #openstack-nova | 01:36 | |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove ec2 in service and cmd https://review.openstack.org/556778 | 01:39 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150 | 01:39 |
| openstackgerrit | jichenjc proposed openstack/nova master: WIP: remove db ec2 https://review.openstack.org/557572 | 01:39 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 01:39 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 01:39 |
| *** jchhatbar has joined #openstack-nova | 01:40 | |
| openstackgerrit | jichenjc proposed openstack/nova master: make metadata doc up to date https://review.openstack.org/559613 | 01:41 |
| *** janki has quit IRC | 01:43 | |
| *** dougshelley66 has quit IRC | 01:43 | |
| *** dougshelley66 has joined #openstack-nova | 01:49 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242 | 01:50 |
| openstackgerrit | Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078 | 01:50 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605 | 01:50 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | 01:50 |
| openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | 01:50 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 01:50 |
| *** bkopilov has quit IRC | 01:52 | |
| *** yamahata has quit IRC | 01:53 | |
| *** mdnadeem has joined #openstack-nova | 01:57 | |
| *** dougshelley66 has quit IRC | 01:59 | |
| naichuans | Hi, efried: do we have the scheduler of to get NRP working through GET /allocation_candidates? | 02:03 |
| alex_xu | kashyap: yea, I think it supports boarder option, but at least for our team, we only use cmt | 02:05 |
| *** namnh has joined #openstack-nova | 02:08 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in test_virt_drivers.py https://review.openstack.org/559878 | 02:08 |
| *** sapcc-bot1 has joined #openstack-nova | 02:09 | |
| *** salv-orlando has joined #openstack-nova | 02:10 | |
| *** dave-mccowan has joined #openstack-nova | 02:12 | |
| *** salv-orl_ has quit IRC | 02:13 | |
| *** mdnadeem has quit IRC | 02:13 | |
| *** sapcc-bot has quit IRC | 02:14 | |
| *** naichuans_ has joined #openstack-nova | 02:14 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (1) https://review.openstack.org/558704 | 02:16 |
| *** naichuans_ has quit IRC | 02:21 | |
| *** germs has quit IRC | 02:22 | |
| *** germs has joined #openstack-nova | 02:22 | |
| *** germs has quit IRC | 02:22 | |
| *** germs has joined #openstack-nova | 02:22 | |
| *** ssurana has joined #openstack-nova | 02:23 | |
| *** germs has quit IRC | 02:23 | |
| *** naichuans_ has joined #openstack-nova | 02:27 | |
| *** naichuans_ has quit IRC | 02:29 | |
| *** naichuans_ has joined #openstack-nova | 02:30 | |
| *** andreas_s has joined #openstack-nova | 02:32 | |
| *** r-daneel has joined #openstack-nova | 02:36 | |
| *** andreas_s has quit IRC | 02:37 | |
| *** amodi has quit IRC | 02:40 | |
| *** yamamoto has joined #openstack-nova | 02:41 | |
| *** QianYu has quit IRC | 02:43 | |
| *** yamamoto has quit IRC | 02:45 | |
| *** QianYu has joined #openstack-nova | 02:47 | |
| *** dave-mccowan has quit IRC | 02:48 | |
| *** artom has quit IRC | 02:50 | |
| *** psachin has joined #openstack-nova | 02:52 | |
| *** jackie-truong has quit IRC | 02:57 | |
| *** slaweq has joined #openstack-nova | 03:04 | |
| *** imacdonn has quit IRC | 03:08 | |
| *** imacdonn has joined #openstack-nova | 03:08 | |
| *** slaweq has quit IRC | 03:09 | |
| *** harlowja has quit IRC | 03:16 | |
| *** vladikr has quit IRC | 03:17 | |
| *** vladikr has joined #openstack-nova | 03:17 | |
| *** bkopilov has joined #openstack-nova | 03:19 | |
| *** takashin has quit IRC | 03:24 | |
| *** armaan has quit IRC | 03:26 | |
| *** vladikr has quit IRC | 03:27 | |
| *** vladikr has joined #openstack-nova | 03:27 | |
| *** sree has joined #openstack-nova | 03:30 | |
| *** phuongnh has joined #openstack-nova | 03:36 | |
| *** zhurong has quit IRC | 03:41 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 03:43 |
| *** naichuans_ has quit IRC | 03:45 | |
| *** naichuans_ has joined #openstack-nova | 03:45 | |
| *** naichuans has quit IRC | 03:47 | |
| *** jogo has quit IRC | 03:47 | |
| *** esberglu has quit IRC | 03:49 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (2) https://review.openstack.org/558993 | 03:51 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (3) https://review.openstack.org/559258 | 03:53 |
| *** takashin has joined #openstack-nova | 03:53 | |
| *** hongbin has quit IRC | 03:57 | |
| *** harlowja has joined #openstack-nova | 03:57 | |
| *** ratailor has joined #openstack-nova | 03:58 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159 | 04:00 |
| *** sridharg has joined #openstack-nova | 04:00 | |
| *** hiro-kobayashi has joined #openstack-nova | 04:03 | |
| *** pcaruana has joined #openstack-nova | 04:06 | |
| *** gjayavelu has joined #openstack-nova | 04:07 | |
| *** udesale has joined #openstack-nova | 04:09 | |
| *** liuzz has quit IRC | 04:11 | |
| *** strigazi has quit IRC | 04:11 | |
| *** gjayavelu has quit IRC | 04:12 | |
| *** strigazi has joined #openstack-nova | 04:14 | |
| *** pcaruana has quit IRC | 04:16 | |
| *** suresh12 has joined #openstack-nova | 04:18 | |
| *** suresh12 has quit IRC | 04:18 | |
| *** suresh12 has joined #openstack-nova | 04:18 | |
| *** trinaths has joined #openstack-nova | 04:20 | |
| *** QianYu has quit IRC | 04:20 | |
| *** jichen_ has joined #openstack-nova | 04:21 | |
| *** madhaviy has joined #openstack-nova | 04:22 | |
| *** jichen has quit IRC | 04:22 | |
| *** jichen_ is now known as jichen | 04:22 | |
| *** jogo has joined #openstack-nova | 04:22 | |
| *** germs has joined #openstack-nova | 04:23 | |
| *** germs has quit IRC | 04:23 | |
| *** germs has joined #openstack-nova | 04:23 | |
| *** annp has quit IRC | 04:25 | |
| *** liuzz has joined #openstack-nova | 04:25 | |
| *** annp has joined #openstack-nova | 04:25 | |
| *** QianYu has joined #openstack-nova | 04:26 | |
| *** QianYu has quit IRC | 04:28 | |
| *** germs has quit IRC | 04:29 | |
| *** madhaviy has quit IRC | 04:33 | |
| *** vks1 has joined #openstack-nova | 04:35 | |
| *** ssurana has quit IRC | 04:39 | |
| *** sree has quit IRC | 04:45 | |
| *** ssurana has joined #openstack-nova | 04:45 | |
| *** sree has joined #openstack-nova | 04:53 | |
| *** lpetrut has joined #openstack-nova | 04:54 | |
| *** sree has quit IRC | 04:55 | |
| *** ratailor_ has joined #openstack-nova | 04:59 | |
| *** Dinesh_Bhor has quit IRC | 05:00 | |
| *** ratailor has quit IRC | 05:02 | |
| *** claudiub has joined #openstack-nova | 05:04 | |
| *** suresh12 has quit IRC | 05:04 | |
| *** naichuans_ is now known as naichuans | 05:05 | |
| *** yamamoto has joined #openstack-nova | 05:08 | |
| *** dikonoor has joined #openstack-nova | 05:08 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:09 | |
| *** vks1 has quit IRC | 05:10 | |
| *** yamahata has joined #openstack-nova | 05:10 | |
| *** links has joined #openstack-nova | 05:11 | |
| *** yamamoto has quit IRC | 05:12 | |
| *** strigazi_ has joined #openstack-nova | 05:13 | |
| *** strigazi has quit IRC | 05:17 | |
| *** sree has joined #openstack-nova | 05:21 | |
| *** licanwei has joined #openstack-nova | 05:22 | |
| *** madhaviy has joined #openstack-nova | 05:23 | |
| *** ccamacho has quit IRC | 05:29 | |
| *** fragatina has quit IRC | 05:31 | |
| *** sar has quit IRC | 05:33 | |
| *** lpetrut has quit IRC | 05:37 | |
| *** dikonoor has quit IRC | 05:37 | |
| *** dikonoor has joined #openstack-nova | 05:37 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451 | 05:39 |
| *** suresh12 has joined #openstack-nova | 05:42 | |
| *** Eran_Kuris has joined #openstack-nova | 05:45 | |
| *** germs has joined #openstack-nova | 05:47 | |
| *** germs has quit IRC | 05:47 | |
| *** germs has joined #openstack-nova | 05:47 | |
| *** suresh12 has quit IRC | 05:47 | |
| *** lpetrut has joined #openstack-nova | 05:47 | |
| *** germs has quit IRC | 05:51 | |
| *** fragatina has joined #openstack-nova | 05:57 | |
| *** fragatin_ has joined #openstack-nova | 05:58 | |
| *** takedakn has joined #openstack-nova | 05:58 | |
| *** bingqianglin has joined #openstack-nova | 05:59 | |
| *** belmoreira has joined #openstack-nova | 06:00 | |
| *** fragatina has quit IRC | 06:01 | |
| *** rodolof has joined #openstack-nova | 06:02 | |
| *** fragatin_ has quit IRC | 06:02 | |
| *** takedakn has quit IRC | 06:03 | |
| openstackgerrit | jichenjc proposed openstack/nova master: remove ec2 in service and cmd https://review.openstack.org/556778 | 06:03 |
| openstackgerrit | jichenjc proposed openstack/nova master: remove ec2 object definitions https://review.openstack.org/557150 | 06:03 |
| openstackgerrit | jichenjc proposed openstack/nova master: remove ec2 db functions https://review.openstack.org/557572 | 06:03 |
| *** jaosorior has quit IRC | 06:04 | |
| *** rubasov has quit IRC | 06:08 | |
| *** sar has joined #openstack-nova | 06:12 | |
| *** dpawlik has joined #openstack-nova | 06:13 | |
| *** rubasov has joined #openstack-nova | 06:16 | |
| *** dpawlik has quit IRC | 06:17 | |
| *** namnh has quit IRC | 06:18 | |
| *** lpetrut has quit IRC | 06:19 | |
| *** dpawlik has joined #openstack-nova | 06:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 06:25 |
| *** QianYu has joined #openstack-nova | 06:25 | |
| *** madhaviy has quit IRC | 06:26 | |
| *** madhaviy has joined #openstack-nova | 06:26 | |
| *** andreas_s has joined #openstack-nova | 06:29 | |
| *** Dinesh_Bhor has quit IRC | 06:30 | |
| *** armaan has joined #openstack-nova | 06:30 | |
| *** QianYu has quit IRC | 06:31 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:32 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:32 | |
| *** QianYu has joined #openstack-nova | 06:32 | |
| *** ssurana has quit IRC | 06:36 | |
| *** kholkina has joined #openstack-nova | 06:37 | |
| *** jaosorior has joined #openstack-nova | 06:37 | |
| *** yamamoto has joined #openstack-nova | 06:37 | |
| *** pcaruana has joined #openstack-nova | 06:40 | |
| *** harlowja has quit IRC | 06:40 | |
| *** rcernin has quit IRC | 06:41 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451 | 06:45 |
| *** fragatina has joined #openstack-nova | 06:47 | |
| *** ragiman has joined #openstack-nova | 06:47 | |
| *** sahid has joined #openstack-nova | 06:47 | |
| *** slaweq has joined #openstack-nova | 06:47 | |
| *** salv-orlando has quit IRC | 06:48 | |
| *** salv-orlando has joined #openstack-nova | 06:48 | |
| *** ratailor__ has joined #openstack-nova | 06:49 | |
| *** sahid_ has joined #openstack-nova | 06:49 | |
| *** AlexeyAbashkin has quit IRC | 06:49 | |
| *** pooja_jadhav has joined #openstack-nova | 06:49 | |
| *** AlexeyAbashkin has joined #openstack-nova | 06:50 | |
| *** ratailor_ has quit IRC | 06:51 | |
| *** alexchadin has joined #openstack-nova | 06:52 | |
| *** ccamacho has joined #openstack-nova | 06:52 | |
| *** slaweq has quit IRC | 06:53 | |
| *** ccamacho has quit IRC | 06:53 | |
| *** salv-orlando has quit IRC | 06:53 | |
| *** ralonsoh has joined #openstack-nova | 06:53 | |
| *** lpetrut has joined #openstack-nova | 06:53 | |
| *** sahid_ has quit IRC | 06:53 | |
| *** sahid has quit IRC | 06:53 | |
| *** sahid has joined #openstack-nova | 06:53 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 06:54 |
| *** AlexeyAbashkin has quit IRC | 06:54 | |
| *** slaweq has joined #openstack-nova | 06:56 | |
| *** fragatina has quit IRC | 06:56 | |
| *** avolkov has joined #openstack-nova | 06:57 | |
| *** QianYu has quit IRC | 07:02 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:02 | |
| *** QianYu has joined #openstack-nova | 07:03 | |
| *** lpetrut has quit IRC | 07:03 | |
| *** maciejjozefczyk has quit IRC | 07:07 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:09 | |
| *** lajoskatona has joined #openstack-nova | 07:09 | |
| *** yamamoto has quit IRC | 07:12 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466 | 07:13 |
| *** yamamoto has joined #openstack-nova | 07:14 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171 | 07:14 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783 | 07:14 |
| *** yamamoto has quit IRC | 07:14 | |
| *** yamamoto has joined #openstack-nova | 07:15 | |
| *** tesseract has joined #openstack-nova | 07:19 | |
| *** yamamoto has quit IRC | 07:19 | |
| kashyap | zigo: If you want to re-ACK this -- https://review.openstack.org/#/c/558171/ | 07:22 |
| *** salv-orlando has joined #openstack-nova | 07:23 | |
| *** jaosorior has quit IRC | 07:23 | |
| bauzas | good morning nova | 07:26 |
| *** tssurya has joined #openstack-nova | 07:26 | |
| *** jaosorior has joined #openstack-nova | 07:27 | |
| *** dikonoo has joined #openstack-nova | 07:30 | |
| *** dikonoor has quit IRC | 07:30 | |
| *** fragatina has joined #openstack-nova | 07:30 | |
| *** takashin has left #openstack-nova | 07:30 | |
| *** jhesketh_ has joined #openstack-nova | 07:31 | |
| *** Tom-Tom has joined #openstack-nova | 07:33 | |
| *** bingqianglin has quit IRC | 07:33 | |
| *** amoralej|off is now known as amoralej | 07:35 | |
| *** swamireddy has quit IRC | 07:37 | |
| *** jhesketh has quit IRC | 07:37 | |
| *** mgoddard has joined #openstack-nova | 07:37 | |
| *** damien_r has joined #openstack-nova | 07:38 | |
| *** hoonetorg has quit IRC | 07:38 | |
| *** Dinesh_Bhor has quit IRC | 07:40 | |
| *** belmoreira has quit IRC | 07:43 | |
| *** rodolof has quit IRC | 07:45 | |
| *** rodolof has joined #openstack-nova | 07:45 | |
| *** jpena|off is now known as jpena | 07:45 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:46 | |
| *** germs has joined #openstack-nova | 07:48 | |
| *** germs has quit IRC | 07:48 | |
| *** germs has joined #openstack-nova | 07:48 | |
| *** madhaviy has quit IRC | 07:50 | |
| *** hoonetorg has joined #openstack-nova | 07:52 | |
| *** germs has quit IRC | 07:53 | |
| *** AlexeyAbashkin has quit IRC | 07:53 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:56 | |
| *** mgoddard has quit IRC | 07:56 | |
| *** cdent has joined #openstack-nova | 07:59 | |
| *** madhaviy has joined #openstack-nova | 08:01 | |
| *** ktibi has joined #openstack-nova | 08:01 | |
| *** hemna_ has quit IRC | 08:04 | |
| *** lucas-afk is now known as lucasagomes | 08:05 | |
| *** mdnadeem has joined #openstack-nova | 08:05 | |
| *** lpetrut has joined #openstack-nova | 08:16 | |
| *** suresh12 has joined #openstack-nova | 08:19 | |
| *** hiro-kobayashi has quit IRC | 08:22 | |
| *** suresh12 has quit IRC | 08:23 | |
| *** priteau has joined #openstack-nova | 08:27 | |
| *** mvk has quit IRC | 08:28 | |
| *** speller has joined #openstack-nova | 08:29 | |
| *** circ-user-vGM1f has joined #openstack-nova | 08:30 | |
| *** speller has left #openstack-nova | 08:30 | |
| *** mgoddard has joined #openstack-nova | 08:30 | |
| *** cdent has quit IRC | 08:32 | |
| *** circ-user-vGM1f has quit IRC | 08:34 | |
| *** circ-user-4FHml has joined #openstack-nova | 08:34 | |
| *** asdf__ has joined #openstack-nova | 08:35 | |
| *** circ-user-4FHml has quit IRC | 08:35 | |
| *** circ-user-s7EKK has joined #openstack-nova | 08:35 | |
| *** circ-user-s7EKK is now known as speller_ | 08:36 | |
| *** speller_ has joined #openstack-nova | 08:36 | |
| *** speller_ has joined #openstack-nova | 08:37 | |
| *** asdf__ has quit IRC | 08:37 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242 | 08:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078 | 08:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605 | 08:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | 08:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | 08:45 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 08:45 |
| zigo | kashyap: I did it but there are still ci failures. | 08:46 |
| *** ccamacho has joined #openstack-nova | 08:46 | |
| *** tiendc has quit IRC | 08:48 | |
| *** tiendc has joined #openstack-nova | 08:49 | |
| kashyap | zigo: Let me look; this shouldn't certainly cause CI failures | 08:50 |
| kashyap | Hmm, I see "IBM PowerKVM CI" failing | 08:51 |
| *** hiro-kobayashi has joined #openstack-nova | 08:53 | |
| *** mvk has joined #openstack-nova | 08:58 | |
| *** sshwarts has joined #openstack-nova | 09:00 | |
| *** cdent has joined #openstack-nova | 09:00 | |
| *** owalsh_ has joined #openstack-nova | 09:02 | |
| *** owalsh has quit IRC | 09:03 | |
| *** belmoreira has joined #openstack-nova | 09:03 | |
| *** pcaruana has quit IRC | 09:04 | |
| *** mdbooth has joined #openstack-nova | 09:06 | |
| *** mdnadeem_ has joined #openstack-nova | 09:12 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451 | 09:14 |
| *** yamamoto has joined #openstack-nova | 09:15 | |
| *** mdnadeem has quit IRC | 09:15 | |
| *** links has quit IRC | 09:18 | |
| *** dikonoo has quit IRC | 09:20 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154 | 09:28 |
| *** derekh has joined #openstack-nova | 09:30 | |
| *** Dinesh_Bhor has quit IRC | 09:31 | |
| *** Zames_ has joined #openstack-nova | 09:33 | |
| *** mvk has quit IRC | 09:33 | |
| *** links has joined #openstack-nova | 09:33 | |
| *** owalsh_ is now known as owalsh | 09:34 | |
| *** Zames_ has quit IRC | 09:37 | |
| *** yamamoto has quit IRC | 09:41 | |
| *** yamamoto has joined #openstack-nova | 09:41 | |
| *** dosaboy has quit IRC | 09:42 | |
| *** dosaboy has joined #openstack-nova | 09:45 | |
| *** mvk has joined #openstack-nova | 09:46 | |
| *** dosaboy has quit IRC | 09:48 | |
| *** dosaboy has joined #openstack-nova | 09:49 | |
| *** germs has joined #openstack-nova | 09:49 | |
| *** germs has quit IRC | 09:49 | |
| *** germs has joined #openstack-nova | 09:49 | |
| *** dosaboy has quit IRC | 09:49 | |
| *** Tom-Tom has quit IRC | 09:50 | |
| *** dosaboy has joined #openstack-nova | 09:50 | |
| *** armaan has quit IRC | 09:50 | |
| *** Tom-Tom has joined #openstack-nova | 09:51 | |
| *** armaan has joined #openstack-nova | 09:51 | |
| *** dosaboy has quit IRC | 09:51 | |
| *** alexchadin has quit IRC | 09:52 | |
| *** QianYu has quit IRC | 09:52 | |
| *** hiro-kobayashi has quit IRC | 09:52 | |
| *** QianYu has joined #openstack-nova | 09:52 | |
| *** Tom-Tom has quit IRC | 09:52 | |
| *** germs has quit IRC | 09:53 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 09:53 |
| *** maciejjozefczyk has quit IRC | 09:54 | |
| *** trinaths has quit IRC | 09:55 | |
| *** dosaboy has joined #openstack-nova | 09:56 | |
| *** maciejjozefczyk has joined #openstack-nova | 09:56 | |
| *** Shilpa has joined #openstack-nova | 09:59 | |
| *** salv-orl_ has joined #openstack-nova | 09:59 | |
| *** salv-orl_ has quit IRC | 10:01 | |
| *** strigazi_ is now known as strigazi | 10:01 | |
| *** salv-orl_ has joined #openstack-nova | 10:01 | |
| *** sree has quit IRC | 10:01 | |
| *** kaisers1 has quit IRC | 10:02 | |
| *** armaan has quit IRC | 10:02 | |
| *** QianYu has quit IRC | 10:02 | |
| *** salv-orlando has quit IRC | 10:02 | |
| *** armaan has joined #openstack-nova | 10:02 | |
| *** kaisers1 has joined #openstack-nova | 10:03 | |
| *** dpawlik has quit IRC | 10:04 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313 | 10:05 |
| *** madhaviy has quit IRC | 10:05 | |
| *** jichen has quit IRC | 10:05 | |
| *** salv-orl_ has quit IRC | 10:06 | |
| *** dpawlik has joined #openstack-nova | 10:07 | |
| *** damien_r has quit IRC | 10:07 | |
| *** damien_r has joined #openstack-nova | 10:07 | |
| *** sdague has joined #openstack-nova | 10:15 | |
| *** swamireddy has joined #openstack-nova | 10:16 | |
| *** madhaviy has joined #openstack-nova | 10:17 | |
| *** yamamoto has quit IRC | 10:17 | |
| *** swamireddy has quit IRC | 10:21 | |
| *** stakeda has quit IRC | 10:21 | |
| *** yamamoto has joined #openstack-nova | 10:21 | |
| Tahvok | Should horizon respect the live migration when host aggregates are enabled? Because when I live migrate an instance, it still gives me an option to choose to live migrate an instance to a host not part of the host aggregate | 10:25 |
| *** yamamoto has quit IRC | 10:27 | |
| *** yamamoto has joined #openstack-nova | 10:27 | |
| *** cdent has quit IRC | 10:27 | |
| *** licanwei has left #openstack-nova | 10:31 | |
| *** madhaviy has quit IRC | 10:31 | |
| *** tbachman has quit IRC | 10:45 | |
| *** udesale has quit IRC | 10:45 | |
| *** dougshelley66 has joined #openstack-nova | 10:46 | |
| openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717 | 10:46 |
| *** tbachman has joined #openstack-nova | 10:46 | |
| *** tbachman has quit IRC | 10:51 | |
| *** bkopilov has quit IRC | 10:51 | |
| openstackgerrit | Petersingh Anburaj proposed openstack/nova master: Making consistent used of GiB and MiB in Doc https://review.openstack.org/559985 | 10:52 |
| *** yamamoto has quit IRC | 10:58 | |
| *** strigazi is now known as strigaz_ | 10:59 | |
| *** strigaz_ is now known as strigazi_ | 10:59 | |
| *** strigazi_ is now known as strigazi | 10:59 | |
| *** yamamoto has joined #openstack-nova | 11:00 | |
| *** vladikr has quit IRC | 11:00 | |
| *** vladikr has joined #openstack-nova | 11:01 | |
| *** yamamoto has quit IRC | 11:01 | |
| *** salv-orlando has joined #openstack-nova | 11:02 | |
| *** sambetts|afk is now known as sambetts | 11:04 | |
| *** cdent has joined #openstack-nova | 11:04 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/559987 | 11:05 |
| *** salv-orlando has quit IRC | 11:06 | |
| *** dougshelley66 has quit IRC | 11:13 | |
| *** lucasagomes is now known as lucas-hungry | 11:17 | |
| *** mdbooth has quit IRC | 11:18 | |
| *** madhaviy has joined #openstack-nova | 11:18 | |
| *** vladikr has quit IRC | 11:21 | |
| *** sshwarts has quit IRC | 11:24 | |
| *** links has quit IRC | 11:26 | |
| *** mdbooth has joined #openstack-nova | 11:27 | |
| *** jchhatbar has quit IRC | 11:27 | |
| *** alexchadin has joined #openstack-nova | 11:31 | |
| *** phuongnh has quit IRC | 11:35 | |
| *** artom has joined #openstack-nova | 11:38 | |
| *** links has joined #openstack-nova | 11:39 | |
| *** tiendc has quit IRC | 11:39 | |
| *** markvoelker has joined #openstack-nova | 11:40 | |
| *** dougshelley66 has joined #openstack-nova | 11:41 | |
| *** jpena is now known as jpena|lunch | 11:45 | |
| *** sidx64 has joined #openstack-nova | 11:50 | |
| *** zhurong has joined #openstack-nova | 11:53 | |
| *** odyssey4me has quit IRC | 12:00 | |
| *** odyssey4me has joined #openstack-nova | 12:00 | |
| *** madhaviy has quit IRC | 12:02 | |
| *** salv-orlando has joined #openstack-nova | 12:02 | |
| *** madhaviy has joined #openstack-nova | 12:03 | |
| *** weshay_pto is now known as weshay | 12:03 | |
| *** dpawlik has quit IRC | 12:04 | |
| *** openstackgerrit has quit IRC | 12:04 | |
| *** artom has quit IRC | 12:05 | |
| *** salv-orlando has quit IRC | 12:07 | |
| *** tbachman has joined #openstack-nova | 12:09 | |
| *** lucas-hungry is now known as lucasagomes | 12:11 | |
| *** janki has joined #openstack-nova | 12:11 | |
| *** tbachman_ has joined #openstack-nova | 12:11 | |
| *** tbachman has quit IRC | 12:14 | |
| *** tbachman_ is now known as tbachman | 12:14 | |
| *** dpawlik has joined #openstack-nova | 12:16 | |
| *** edmondsw has joined #openstack-nova | 12:17 | |
| *** dave-mccowan has joined #openstack-nova | 12:19 | |
| *** openstackgerrit has joined #openstack-nova | 12:19 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/osc-placement master: Initialize 'result' variable in functional.base https://review.openstack.org/560004 | 12:19 |
| *** jchhatbar has joined #openstack-nova | 12:19 | |
| *** bkopilov has joined #openstack-nova | 12:20 | |
| *** amoralej is now known as amoralej|lunch | 12:20 | |
| *** janki has quit IRC | 12:22 | |
| *** gouthamr has joined #openstack-nova | 12:23 | |
| *** mdnadeem_ has quit IRC | 12:24 | |
| *** Eran_Kuris has quit IRC | 12:26 | |
| *** edmondsw has quit IRC | 12:28 | |
| efried | naichuans: No, not yet. Keep an eye on blueprint nested-resource-providers-allocation-candidates | 12:28 |
| efried | spec: https://review.openstack.org/#/c/556873/ | 12:28 |
| efried | code: https://review.openstack.org/#/q/topic:bp/nested-resource-providers-allocation-candidates+(status:open+OR+status:merged) | 12:28 |
| *** tbachman has quit IRC | 12:35 | |
| *** yamamoto has joined #openstack-nova | 12:35 | |
| *** vladikr has joined #openstack-nova | 12:36 | |
| *** mdnadeem_ has joined #openstack-nova | 12:36 | |
| *** sidx64_ has joined #openstack-nova | 12:38 | |
| *** psachin has quit IRC | 12:38 | |
| *** tbachman has joined #openstack-nova | 12:39 | |
| *** sidx64_ has quit IRC | 12:39 | |
| *** sidx64 has quit IRC | 12:39 | |
| *** pchavva has joined #openstack-nova | 12:39 | |
| *** Eran_Kuris has joined #openstack-nova | 12:40 | |
| *** yamamoto has quit IRC | 12:41 | |
| *** gouthamr has quit IRC | 12:43 | |
| *** gouthamr has joined #openstack-nova | 12:44 | |
| *** yamamoto has joined #openstack-nova | 12:44 | |
| *** pcaruana has joined #openstack-nova | 12:44 | |
| *** gouthamr has quit IRC | 12:45 | |
| *** sidx64 has joined #openstack-nova | 12:46 | |
| efried | claudiub: Does autospec work for method signatures? | 12:49 |
| *** jaosorior has quit IRC | 12:50 | |
| *** edmondsw has joined #openstack-nova | 12:51 | |
| efried | yes, yes it does. | 12:51 |
| *** mriedem has joined #openstack-nova | 12:52 | |
| claudiub | sorry, I didn't see it in time. :) | 12:53 |
| claudiub | and yes, it does, that was the whole point of it. :) | 12:53 |
| *** jpena|lunch is now known as jpena | 12:53 | |
| *** salv-orlando has joined #openstack-nova | 12:53 | |
| *** lyan has joined #openstack-nova | 12:53 | |
| *** lyan is now known as Guest8476 | 12:53 | |
| claudiub | efried: although arguably there is still one case in which it doesn't get applied, one case I've missed in the original implementation: https://review.openstack.org/#/c/557923/ | 12:54 |
| efried | claudiub: Knew it worked that way for objects, wasn't sure about methods. | 12:54 |
| *** zhurong has quit IRC | 12:54 | |
| *** sidx64 has quit IRC | 12:55 | |
| *** logan- has quit IRC | 12:55 | |
| *** logan- has joined #openstack-nova | 12:56 | |
| claudiub | efried: also, keep in mind that this has a +2, so it might merge soon. Hopefully it won't affect nova_powervm: https://review.openstack.org/#/c/470775/ | 12:56 |
| efried | claudiub: If you have a moment, I'm hitting a place where the autospec doesn't seem to be working as expected... | 12:57 |
| claudiub | sure, what's up | 12:57 |
| efried | looking at this patch: https://review.openstack.org/#/c/552242/ | 12:57 |
| *** yamamoto has quit IRC | 12:57 | |
| efried | Look at the signature of e2fsck here https://review.openstack.org/#/c/552242/12/nova/privsep/fs.py | 12:58 |
| efried | accepts (image, flags='-fp') | 12:58 |
| claudiub | sure | 12:58 |
| efried | Then look at the first usage here: https://review.openstack.org/#/c/552242/12/nova/virt/xenapi/vm_utils.py | 12:58 |
| *** READ10 has joined #openstack-nova | 12:59 | |
| efried | note extra kwarg check_exit_code | 12:59 |
| efried | So I thinks to myself, I thinks, "Okay, let's autospec here: https://review.openstack.org/#/c/552242/12/nova/tests/unit/virt/xenapi/test_vm_utils.py" | 12:59 |
| efried | ...but when I do that, the test still passes. | 12:59 |
| *** zhurong has joined #openstack-nova | 12:59 | |
| efried | i.e. the autospec doesn't seem to be catching that extra kwarg. | 13:00 |
| claudiub | i might be blind, but where are you autospecing it? | 13:00 |
| efried | It's probably me being blind. | 13:00 |
| efried | @mock.patch('...', autospec=True) | 13:01 |
| efried | is that a legit way to do that? | 13:01 |
| claudiub | i might be really blind as a bat then. but yeah, there's a reason why it passes | 13:02 |
| *** alexchadin has quit IRC | 13:02 | |
| *** madhaviy has quit IRC | 13:02 | |
| *** swamireddy has joined #openstack-nova | 13:03 | |
| *** madhaviy has joined #openstack-nova | 13:03 | |
| claudiub | or, wait, that only aplies to object methods. hm. anyways, there is an issue with mock.patch autospec, which i've addressed in oslotest. what happened was that mock.patch's autospec didn't consume the self / cls argument of object / class methods | 13:03 |
| efried | I remember that issue. But in this case there are no classes involved, are there? | 13:04 |
| claudiub | it should be the case now, since it's just a function. | 13:04 |
| efried | it's possible my venv has an old oslotest, lemme check... | 13:04 |
| claudiub | can you check if the mock.patch autospec works as expected with this patch on top? https://review.openstack.org/#/c/470775/ | 13:04 |
| *** salv-orl_ has joined #openstack-nova | 13:04 | |
| efried | finucannot: you around this week? | 13:04 |
| *** salv-orlando has quit IRC | 13:05 | |
| efried | claudiub: okay. | 13:05 |
| *** sidx64 has joined #openstack-nova | 13:05 | |
| finucannot | efried: Yes, but I'm focused on getting the numa-aware-vswitch PoC out the door | 13:05 |
| * finucannot sucks at multitasking | 13:05 | |
| *** finucannot is now known as stephenfin | 13:05 | |
| stephenfin | oops | 13:05 |
| claudiub | that patch basically enforces the oslotest's mock.patch behaviour. | 13:05 |
| *** udesale has joined #openstack-nova | 13:06 | |
| *** yamamoto has joined #openstack-nova | 13:07 | |
| mriedem | jianghuaw_: does the citrix xenserver CI have any multinode job to test live migration for this series? https://review.openstack.org/#/c/489451/ | 13:07 |
| *** zhurong has quit IRC | 13:13 | |
| *** armaan has quit IRC | 13:13 | |
| *** udesale has quit IRC | 13:13 | |
| *** udesale has joined #openstack-nova | 13:13 | |
| efried | claudiub: Okay, first I upgraded oslotest in my venv (3.2.0 => 3.4.1). Then I patched in https://review.openstack.org/#/c/557923/ (which presumably also means I'm getting as-yet-unreleased oslotest whatever). Then I merged in https://review.openstack.org/#/c/470775/ with the patch in question. | 13:15 |
| efried | claudiub: None of this yielded the expected failure. | 13:15 |
| claudiub | interesting | 13:16 |
| claudiub | i'll take a look today as well | 13:16 |
| *** yamamoto has quit IRC | 13:16 | |
| claudiub | but later on, I have a meeting soon, so I have to prepare for that. :) | 13:16 |
| claudiub | but thanks for catching it. :) | 13:17 |
| madhaviy | mriedem: I am checking fix proposed for LP bug https://bugs.launchpad.net/nova/+bug/1698010, by stephenfin , is there any other way to avoid using dhcp_domain from nova.conf during config_drive metadata creation | 13:18 |
| openstack | Launchpad bug 1698010 in OpenStack Compute (nova) "neutron-based instances should not use the nova-network 'dhcp_domain' option" [High,In progress] - Assigned to Stephen Finucane (stephenfinucane) | 13:18 |
| efried | claudiub: Ahcrap, I think I know what's happening. | 13:19 |
| efried | The method in question is decorated with a thing that accepts *a, **k | 13:19 |
| claudiub | oh, I see. | 13:19 |
| claudiub | interesting. :) | 13:20 |
| efried | sure would be nice to be able to get around that somehow. But that sounds like black magic to me. | 13:20 |
| *** yamamoto has joined #openstack-nova | 13:20 | |
| claudiub | also, just an fyi, there are still a few other cases in which autospec is not working properly, for example sqlalchemy tends to have decorators which inject arguments in to the call. can't really autospec that. :) | 13:21 |
| *** sidx64 has quit IRC | 13:22 | |
| claudiub | well, autospecs are almost useless for methods which have *args / **kwargs | 13:22 |
| *** yamamoto has quit IRC | 13:23 | |
| claudiub | not entirely, but still. | 13:23 |
| *** sahid has quit IRC | 13:24 | |
| *** esberglu has joined #openstack-nova | 13:26 | |
| mriedem | madhaviy: i don't remember the details of that, but i do remember that the proposed patch wasn't going to work per garyk's comments. i also seem to remember an openstack-dev ML thread about this, but don't recall those details either. i would have to go back and dig into all of this and load it up into my head, which i'm not going to do right now (busy with other stuff), so unless you can summarize it's going to have to wait. | 13:26 |
| mriedem | i don't see any links to ML discussion in the patches though | 13:29 |
| *** sidx64 has joined #openstack-nova | 13:30 | |
| mriedem | this reminds me, i think it's very weird that the use_neutron config option is deprecated https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.use_neutron even though it's in our install guide and is required while we still have nova-network around | 13:31 |
| mriedem | if anyone is going through their logs and sees a deprecation warning for using use_neutron, there isn't anything they can do about it | 13:31 |
| mriedem | i think oslo.service or one of the oslo libraries even has a flag where you can force services to not start if they are using deprecated options, so you can flush those out in pre-prod | 13:32 |
| *** dklyle has quit IRC | 13:33 | |
| mriedem | in other words, wouldn't it make more sense to *not* deprecate options required to run nova with neutron, until at least we've removed nova-network? | 13:33 |
| mriedem | stephenfin: thoughts? ^ | 13:33 |
| *** damien_r has quit IRC | 13:34 | |
| *** alexchadin has joined #openstack-nova | 13:34 | |
| stephenfin | mriedem: You can filter out those warnings if you want. The intention is "this warning currently exists but is going away soon". The reason it's going away is given in the message | 13:35 |
| stephenfin | *this option currently exists | 13:35 |
| openstackgerrit | Raoul Hidalgo Charman proposed openstack/nova master: Expose shutdown retry interval as config setting https://review.openstack.org/552483 | 13:36 |
| efried | claudiub: Yeah, I recognize that; what I'm asking for in this case is a way to signal that I want to get around the decorator and autospec the actual method underneath it. | 13:37 |
| *** tbachman has quit IRC | 13:38 | |
| cdent | efried: not really possible, your method has been redefined | 13:38 |
| *** dpawlik has quit IRC | 13:39 | |
| efried | cdent: Yeah, hence "black magic" | 13:39 |
| cdent | the original form is sort of gone | 13:39 |
| cdent | that would be darker than black | 13:39 |
| *** ratailor__ has quit IRC | 13:39 | |
| *** ratailor has joined #openstack-nova | 13:40 | |
| *** ratailor has quit IRC | 13:40 | |
| lpetrut | efried: you may be able to retrieve the decorated methods, we do it in a few cases to avoid lock decorators within unit tests: https://github.com/openstack/os-win/blob/e0d7032dfb042f56fd02a52796b186cd8d67d240/os_win/_utils.py#L82 | 13:41 |
| mriedem | madhaviy: here is that ML thread http://lists.openstack.org/pipermail/openstack-dev/2017-September/121762.html | 13:41 |
| efried | lpetrut: ooooo | 13:41 |
| *** cristicalin has joined #openstack-nova | 13:42 | |
| *** lbragstad has joined #openstack-nova | 13:42 | |
| *** damien_r has joined #openstack-nova | 13:42 | |
| cdent | efried, lpetrut: too dark | 13:42 |
| efried | ima try it anyway | 13:43 |
| efried | cdent: hold my soul | 13:43 |
| cdent | efried: wouldn't it be better to extract the thing you want to test to an undecorated thing? | 13:43 |
| efried | cdent: I tried that first. Because it's already extracted thusly. But the decorator itself makes the test suite freak out. (It's the privsep entrypoint) | 13:44 |
| cdent | it's all a bit smelly to me (not your soul (but maybe?)) | 13:44 |
| cdent | but we already know how I feel about complexity in tests... | 13:44 |
| efried | I'm trying to soften the blows I keep on dishing out to mikal | 13:44 |
| * cdent goes back to sleep | 13:44 | |
| efried | cdent: FYI: https://review.openstack.org/#/c/552242/ | 13:45 |
| *** cristicalin has quit IRC | 13:47 | |
| mriedem | madhaviy: there is also a thread in the operators ML with some other options | 13:47 |
| *** armaan has joined #openstack-nova | 13:47 | |
| *** cristicalin has joined #openstack-nova | 13:47 | |
| *** awestin1 has quit IRC | 13:48 | |
| *** awestin1 has joined #openstack-nova | 13:49 | |
| *** mlavalle has joined #openstack-nova | 13:49 | |
| *** madhaviy has quit IRC | 13:49 | |
| *** hongbin has joined #openstack-nova | 13:50 | |
| *** serverascode has quit IRC | 13:50 | |
| *** serverascode has joined #openstack-nova | 13:50 | |
| *** madhaviy has joined #openstack-nova | 13:51 | |
| *** kholkina has quit IRC | 13:51 | |
| claudiub | efried: yeah, as lpetrut said, we're getting the undecorated method is some unit tests in os-win, but that would only be needed for decorators which has some sort of special behaviour (adds / injects new arguments). even if we do autospec the undecorated methods, there are still plenty of cases in which the methods expects some sort of key-value argument, something like: | 13:51 |
| madhaviy | mriedem: thanks. But I do not see any conclusion out of this discussion. Can we get back dhcp_domain conf option (not to deprecate) | 13:51 |
| claudiub | if kwargs.get("something"): then do something | 13:51 |
| *** yamamoto has joined #openstack-nova | 13:51 | |
| claudiub | I've seen this in some oslo libs. | 13:51 |
| *** cdent has left #openstack-nova | 13:52 | |
| *** kholkina has joined #openstack-nova | 13:52 | |
| mriedem | madhaviy: it definitely sounds like the option shouldn't be deprecated | 13:52 |
| mriedem | at least until we know what we're going to do with it | 13:53 |
| mriedem | i thought there was general agreement to use the dns_domain from the neutron network if there was one, and fallback to using the nova dhcp_domain option otherwise, but someone in the ops list punched some holes in that idea, but i'm not sure how valid those holes are, or if they are specific to that person's deployment | 13:53 |
| efried | claudiub: Yeah, I understand that. That's not the case here, though - there are no arbitrary args. In this case, in the course of the review (over many iterations) I saw with my eyeballs that the invocation was wrong, and wanted a way to enforce it via autospec. But the decorator kills doing that directly. Now I'm hacking at it trying to figure out how I would actually use the undecorated method to do what I want. | 13:53 |
| mriedem | madhaviy: if there were going to be a nova/neutron forum session at the summit, i'd put that in the agenda since ops would be in the room | 13:54 |
| *** yamamoto has quit IRC | 13:54 | |
| mriedem | melwitt: ^ | 13:54 |
| *** gregwork has quit IRC | 13:54 | |
| *** gregwork has joined #openstack-nova | 13:54 | |
| madhaviy | mriedem: sure. | 13:55 |
| claudiub | efried: well, instead of autospec=True, you can pass-in a function that has the signature you want to enforce? | 13:55 |
| efried | claudiub: As a side_effect to the mock, you mean? | 13:55 |
| claudiub | something like: @mock.patch('something', autospec=some_function_with_exactly_what_I_want) | 13:56 |
| *** yikun has quit IRC | 13:56 | |
| claudiub | I dunno if that works though. | 13:56 |
| *** yikun has joined #openstack-nova | 13:56 | |
| efried | That sort of defeats the purpose, which is to vet whether my (actual) method is being called with the args I expect. If my test is wrong (in that it uses the wrong args) and then I make some_function_with_exactly_what_I_want have those same (wrong) args, then I'm just as effed. | 13:56 |
| *** betherly has quit IRC | 13:56 | |
| *** betherly has joined #openstack-nova | 13:57 | |
| claudiub | yeah, a bit, but at least you'll have tests that don't have autospecs with *args / **kwargs in their method signatures. | 13:59 |
| mriedem | madhaviy: melwitt: added https://etherpad.openstack.org/p/YVR-nova-brainstorming | 14:00 |
| mriedem | mlavalle: ^ | 14:00 |
| *** eharney has joined #openstack-nova | 14:00 | |
| *** awaugama has joined #openstack-nova | 14:01 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559700 | 14:01 |
| mlavalle | mriedem: cool, thanks! | 14:02 |
| *** r-daneel has quit IRC | 14:02 | |
| *** yamamoto has joined #openstack-nova | 14:02 | |
| mriedem | dansmith: ^ rev'ed kashyap's backport if you want to hit that | 14:02 |
| *** sahid has joined #openstack-nova | 14:03 | |
| kashyap | mriedem: Ah, thanks. Was duking around fixing the compat code | 14:03 |
| kashyap | (After removing the version stuff) | 14:03 |
| kashyap | s/removing/bumping/ | 14:03 |
| dansmith | mriedem: done thanks | 14:03 |
| *** DuncanT has quit IRC | 14:04 | |
| madhaviy | mriedem: thanks! | 14:04 |
| *** DuncanT has joined #openstack-nova | 14:04 | |
| kashyap | mriedem: For the 'pike' change, abandoning it, and doing a fresh cherry-pick from 'queens' is the correct way? | 14:05 |
| mriedem | kashyap: the change id is the same so you don't need to abandon | 14:05 |
| *** yamamoto has quit IRC | 14:05 | |
| mriedem | just re-do the cherry pick locally | 14:05 |
| kashyap | Ah, right | 14:05 |
| *** chohoor has joined #openstack-nova | 14:05 | |
| *** chohoor has left #openstack-nova | 14:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559700 | 14:07 |
| *** ildikov has quit IRC | 14:08 | |
| *** ildikov has joined #openstack-nova | 14:09 | |
| *** amodi has joined #openstack-nova | 14:09 | |
| *** yamamoto has joined #openstack-nova | 14:10 | |
| *** jaypipes has joined #openstack-nova | 14:10 | |
| *** patrickeast has quit IRC | 14:11 | |
| *** patrickeast has joined #openstack-nova | 14:11 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 14:12 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924 | 14:12 |
| *** yamamoto has quit IRC | 14:13 | |
| *** links has quit IRC | 14:13 | |
| *** tomhambleton_ has quit IRC | 14:14 | |
| *** tomhambleton_ has joined #openstack-nova | 14:14 | |
| mriedem | seems the messages here should just say 'placement is required' right? https://github.com/openstack/nova/blob/6d4958b5c225a602d22069b920cbf1a37b652c58/nova/scheduler/client/report.py#L87 | 14:15 |
| *** mnaser has quit IRC | 14:15 | |
| *** mnaser has joined #openstack-nova | 14:16 | |
| jaypipes | mriedem: ack | 14:16 |
| *** kholkina has quit IRC | 14:17 | |
| *** markvoelker_ has joined #openstack-nova | 14:18 | |
| *** rodolof has quit IRC | 14:18 | |
| *** andrewbogott has quit IRC | 14:19 | |
| *** gouthamr has joined #openstack-nova | 14:19 | |
| *** andrewbogott has joined #openstack-nova | 14:19 | |
| *** csatari has quit IRC | 14:19 | |
| *** csatari has joined #openstack-nova | 14:19 | |
| kashyap | Hmm, unrelated: "suddenly" I start seeing this import error when running unit tests: http://paste.openstack.org/show/718823/ | 14:19 |
| mriedem | ok i'll make that change. was looking at https://review.openstack.org/#/c/554920/ which will add a requirement to configure placement for nova-api, | 14:19 |
| *** rodolof has joined #openstack-nova | 14:19 | |
| mriedem | so jaypipes - ^ will likely add the placement requirement before the mirroring patch does anyway | 14:19 |
| *** karlamrhein has quit IRC | 14:20 | |
| mriedem | kashyap: tox -r -e | 14:20 |
| *** karlamrhein has joined #openstack-nova | 14:20 | |
| kashyap | Darn, thanks | 14:20 |
| *** markvoelker has quit IRC | 14:21 | |
| efried | kashyap: If you want to not wait forever, you can start upgrading packages manually in your venv... | 14:21 |
| efried | ...but -r is certainly safest. | 14:21 |
| *** samueldmq has quit IRC | 14:21 | |
| *** sergek_ has quit IRC | 14:21 | |
| *** sergek_ has joined #openstack-nova | 14:22 | |
| *** samueldmq has joined #openstack-nova | 14:22 | |
| *** zul has quit IRC | 14:22 | |
| jaypipes | mriedem: ack | 14:22 |
| *** r-daneel has joined #openstack-nova | 14:22 | |
| kashyap | efried: Yeah, I hear ya. The manual imports might result in "find the next dep" rabbit hole. So just went with the "nuclear" | 14:22 |
| *** zul has joined #openstack-nova | 14:22 | |
| efried | just so | 14:22 |
| *** andrewbogott has quit IRC | 14:24 | |
| *** andrewbogott has joined #openstack-nova | 14:24 | |
| *** eharney has quit IRC | 14:24 | |
| *** redondo-mk has quit IRC | 14:24 | |
| *** redondo-mk has joined #openstack-nova | 14:25 | |
| *** tommylikehu has quit IRC | 14:26 | |
| *** tommylikehu has joined #openstack-nova | 14:26 | |
| *** sidx64 has quit IRC | 14:27 | |
| *** zhuli has quit IRC | 14:28 | |
| *** zhuli has joined #openstack-nova | 14:28 | |
| *** dikonoor has joined #openstack-nova | 14:28 | |
| *** knikolla has quit IRC | 14:30 | |
| *** knikolla has joined #openstack-nova | 14:30 | |
| *** sidx64 has joined #openstack-nova | 14:31 | |
| *** r-daneel has quit IRC | 14:32 | |
| *** coreycb has quit IRC | 14:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update wording in @safe_connect placement warnings https://review.openstack.org/560039 | 14:34 |
| *** coreycb has joined #openstack-nova | 14:34 | |
| *** r-daneel has joined #openstack-nova | 14:35 | |
| bauzas | efried: jaypipes: stephenfin: sean-k-mooney: cfriesen_: thanks all for the reviews of https://review.openstack.org/#/c/552924/6/specs/rocky/approved/numa-topology-with-rps.rst | 14:35 |
| bauzas | efried: jaypipes: stephenfin: sean-k-mooney: cfriesen_: now we have a new revision based on your comments https://review.openstack.org/#/c/552924/ | 14:36 |
| openstackgerrit | Merged openstack/nova master: Remove mox in unit/api/*/test_instance_actions.py https://review.openstack.org/559269 | 14:36 |
| *** jamespage has quit IRC | 14:36 | |
| *** jamespage has joined #openstack-nova | 14:36 | |
| *** felipemonteiro has joined #openstack-nova | 14:36 | |
| *** markvoelker has joined #openstack-nova | 14:36 | |
| *** lpetrut_ has joined #openstack-nova | 14:38 | |
| *** lpetrut_ has quit IRC | 14:38 | |
| jaypipes | bauzas: k, reviewing now | 14:38 |
| *** eharney has joined #openstack-nova | 14:38 | |
| *** markvoelker_ has quit IRC | 14:39 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP] Delete orphaned req_spec/inst_mapp records of archived instances https://review.openstack.org/560042 | 14:39 |
| *** gouthamr has quit IRC | 14:40 | |
| *** lpetrut has quit IRC | 14:41 | |
| *** yamamoto has joined #openstack-nova | 14:41 | |
| *** yamamoto has quit IRC | 14:41 | |
| *** markvoelker_ has joined #openstack-nova | 14:42 | |
| *** markvoelker has quit IRC | 14:44 | |
| *** ragiman has quit IRC | 14:45 | |
| *** markvoelker has joined #openstack-nova | 14:46 | |
| *** dklyle has joined #openstack-nova | 14:46 | |
| *** yamamoto has joined #openstack-nova | 14:47 | |
| *** andreas_s has quit IRC | 14:47 | |
| *** felipemonteiro_ has joined #openstack-nova | 14:47 | |
| *** alexchadin has quit IRC | 14:47 | |
| *** andreas_s has joined #openstack-nova | 14:47 | |
| *** markvoelker_ has quit IRC | 14:49 | |
| *** markvoelker_ has joined #openstack-nova | 14:49 | |
| *** fragatina has quit IRC | 14:50 | |
| *** fragatina has joined #openstack-nova | 14:50 | |
| *** felipemonteiro has quit IRC | 14:51 | |
| *** markvoelker has quit IRC | 14:53 | |
| *** mvk has quit IRC | 14:53 | |
| *** QianYu has joined #openstack-nova | 14:54 | |
| *** artom has joined #openstack-nova | 14:55 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 14:55 |
| *** markvoelker has joined #openstack-nova | 14:56 | |
| *** andreas_s has quit IRC | 14:56 | |
| *** markvoelker_ has quit IRC | 14:58 | |
| *** Eran_Kuris has quit IRC | 14:58 | |
| *** yamamoto has quit IRC | 15:01 | |
| openstackgerrit | Merged openstack/nova master: Remove mox in test_user_data.py https://review.openstack.org/559264 | 15:01 |
| openstackgerrit | Merged openstack/nova master: Remove mox in unit/api/*/test_server_metadata.py https://review.openstack.org/559673 | 15:01 |
| *** yamamoto has joined #openstack-nova | 15:01 | |
| openstackgerrit | Merged openstack/nova master: Remove mox in unit/api/*/test_server_password.py https://review.openstack.org/559649 | 15:02 |
| *** QianYu has quit IRC | 15:02 | |
| *** lajoskatona has quit IRC | 15:02 | |
| *** sar has quit IRC | 15:03 | |
| efried | Spec cores (jaypipes dansmith because this spec is near and dear to your hearts) can we get https://review.openstack.org/#/c/556971/ approved now? Code is shaping up. | 15:04 |
| dansmith | efried: wake me when jaypipes is +2 on it | 15:04 |
| efried | ack | 15:05 |
| *** markvoelker_ has joined #openstack-nova | 15:05 | |
| efried | edleafe: You gonna rebase the rest of the consumer generation series to pick up that fix? | 15:08 |
| *** markvoelker_ has quit IRC | 15:08 | |
| edleafe | efried: already done (locally). Need to figure out one last bit before I push a new rev | 15:09 |
| *** markvoelker has quit IRC | 15:09 | |
| efried | coo | 15:09 |
| *** markvoelker has joined #openstack-nova | 15:10 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262 | 15:10 |
| *** markvoelker_ has joined #openstack-nova | 15:10 | |
| *** markvoelker has quit IRC | 15:15 | |
| *** QianYu has joined #openstack-nova | 15:15 | |
| *** belmoreira has quit IRC | 15:17 | |
| *** QianYu has quit IRC | 15:17 | |
| jaypipes | dansmith: I'm +2 on the spec now. | 15:18 |
| *** yamamoto has quit IRC | 15:19 | |
| dansmith | well, that was a short nap | 15:19 |
| *** yamamoto has joined #openstack-nova | 15:19 | |
| mriedem | lyarwood: at the ptg we talked about adding an online data migration to look for and remove duplicate bdm entries in the db, to eventually clear the way to adding a unique constraint on instance uuid and volume id in the bdm table - is that still on your radar, or something i can start hacking on? | 15:20 |
| *** rodolof has quit IRC | 15:20 | |
| mriedem | L575 https://etherpad.openstack.org/p/nova-ptg-rocky | 15:20 |
| *** takedakn has joined #openstack-nova | 15:21 | |
| lyarwood | mriedem: yeah, only just got around to starting yesterday when I hit https://bugs.launchpad.net/cinder/+bug/1762687 | 15:21 |
| openstack | Launchpad bug 1762687 in OpenStack Compute (nova) "Concurrent requests to attach the same non-multiattach volume to multiple instances can succeed" [Undecided,New] - Assigned to Lee Yarwood (lyarwood) | 15:21 |
| mriedem | or was it a unique constraint on device name? now i'm confused | 15:21 |
| lyarwood | mriedem: https://blueprints.launchpad.net/nova/+spec/remove-and-block-duplicate-bdms created that a while ago, wanted to catch up with melwitt or you about getting it approved etc this week | 15:22 |
| *** salv-orl_ has quit IRC | 15:22 | |
| dansmith | efried: the first bullet under "if there is no record" mentions stuff about user_id and project_id, but I'm missing why that's related | 15:22 |
| mriedem | lyarwood: we don't need a blueprint for a bug fix | 15:22 |
| lyarwood | mriedem: right, even if it's across two cycles? | 15:22 |
| *** salv-orlando has joined #openstack-nova | 15:23 | |
| mriedem | lyarwood: as for that new concurrent requests bug, i know what that's about, and why it's only since queens | 15:23 |
| mriedem | lyarwood: sure | 15:23 |
| lyarwood | mriedem: kk, I'll nuke the bp then | 15:23 |
| *** jaypipes has quit IRC | 15:23 | |
| efried | edleafe: --^ | 15:24 |
| *** ccamacho has quit IRC | 15:24 | |
| efried | dansmith: It's because of the goofiness we implemented wrt user and project IDs earlier, plus having no endpoints that manage consumers directly. | 15:24 |
| *** amoralej|lunch is now known as amoralej | 15:25 | |
| efried | dansmith: At earlier microversions, proj/user IDs were optional, so we wanted to not create the consumer record if they weren't specified. | 15:25 |
| *** r-daneel_ has joined #openstack-nova | 15:25 | |
| efried | dansmith: But now we *always* want to set/maintain the generation, even at older microversions, so we *have* to create the consumer record. | 15:25 |
| efried | dansmith: So we had to make proj/user ID fields nullable so that, at older microversions where they weren't required/specified, we could still create that record. | 15:26 |
| *** r-daneel has quit IRC | 15:26 | |
| efried | I think I've got that right - edleafe help me out here ^ | 15:26 |
| *** r-daneel_ is now known as r-daneel | 15:26 | |
| *** yamamoto has quit IRC | 15:26 | |
| dansmith | hmm, okay, that is.. odd, | 15:27 |
| efried | it is indeed. | 15:27 |
| dansmith | so we didn't initially have a consumer record and then added it for user/proj? | 15:27 |
| *** salv-orlando has quit IRC | 15:27 | |
| efried | I think that's the case, yes. | 15:27 |
| dansmith | I guess it seems weird that we didn't just start creating those records with null fields at that point | 15:27 |
| efried | yeah. That would have been a thing to do. | 15:28 |
| efried | Somewhere I tagged the IRC discussion edleafe and I had about this. | 15:28 |
| mriedem | lyarwood: details https://bugs.launchpad.net/nova/+bug/1762687/comments/3 | 15:28 |
| openstack | Launchpad bug 1762687 in OpenStack Compute (nova) "Concurrent requests to attach the same non-multiattach volume to multiple instances can succeed" [Undecided,New] - Assigned to Lee Yarwood (lyarwood) | 15:28 |
| efried | possibly in a spec comment. | 15:28 |
| dansmith | efried: so ... is it unreasonable to say that expecting the reader of the spec to have that context is.. unreasonable? | 15:28 |
| *** rodolof has joined #openstack-nova | 15:28 | |
| efried | dansmith: Here's that IRC convo: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-04-04.log.html#t2018-04-04T13:35:30 | 15:28 |
| dansmith | because reading it from the top, I get stopped at that point with zero idea where it's going | 15:28 |
| *** salv-orlando has joined #openstack-nova | 15:28 | |
| efried | dansmith: That's not unreasonable. But trying to explain all that context probably would be. How about a vague "for historical reasons" sentence? | 15:29 |
| efried | or I suppose we could link that eavesdrop in | 15:29 |
| dansmith | well, | 15:29 |
| dansmith | I kinda think the context is worthwhile in here | 15:30 |
| dansmith | more than an irc link | 15:30 |
| efried | Or perhaps this is an implementation detail that doesn't need to be in the spec at all. Since I *think* the interface isn't changing. (edleafe said it was changing a teeny bit; I never understood how) | 15:30 |
| lyarwood | mriedem: I think you've missed that this is with two different instances, not one. | 15:30 |
| *** yamamoto has joined #openstack-nova | 15:31 | |
| *** dpawlik has joined #openstack-nova | 15:31 | |
| *** gyee has joined #openstack-nova | 15:31 | |
| mriedem | oh.... | 15:31 |
| mriedem | yes, dear | 15:31 |
| *** AlexeyAbashkin has quit IRC | 15:33 | |
| *** jchhatbar has quit IRC | 15:33 | |
| *** madhaviy has quit IRC | 15:34 | |
| dansmith | efried: edleafe: comments in there.. if you're really concernedand want to do those in a follow-in that's fine, but I think it's probably fine to just roll them in here | 15:35 |
| dansmith | and I can fast approve if jaybird isn't around at that point | 15:35 |
| *** dpawlik has quit IRC | 15:35 | |
| kashyap | When anyone gets a moment later, I'm duking around a potentially stupid unit test mistake: http://paste.openstack.org/show/718840/. Corrections / snide remarks / rotten tomatoes welcome. | 15:36 |
| * kashyap bbia | 15:36 | |
| kashyap | s/bbia/bbiab/ | 15:36 |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 15:36 |
| *** armaan has quit IRC | 15:38 | |
| *** psachin has joined #openstack-nova | 15:38 | |
| *** armaan has joined #openstack-nova | 15:38 | |
| *** rodolof has quit IRC | 15:40 | |
| *** tssurya has quit IRC | 15:41 | |
| mriedem | lyarwood: i don't have great solutions off the top of my head | 15:41 |
| *** udesale has quit IRC | 15:41 | |
| dansmith | kashyap: L26 isn't a tuple | 15:41 |
| mriedem | was thinking if we had a bdm.multiattach column that maybe that could somehow be used, but not really... | 15:41 |
| *** udesale has joined #openstack-nova | 15:42 | |
| dansmith | kashyap: so I think you're doing "(mock_getver,).return_value = " | 15:42 |
| dansmith | kashyap: (foo,bar) and (foo,) are tuples.. (foo) is not | 15:42 |
| mriedem | lyarwood: we have this... https://github.com/openstack/nova/blob/master/nova/objects/block_device.py#L327 but that doesn't alleviate the race | 15:42 |
| dansmith | kashyap: and of course, you should be removing test.nested | 15:43 |
| *** yamamoto has quit IRC | 15:43 | |
| *** yamamoto has joined #openstack-nova | 15:44 | |
| *** takedakn has quit IRC | 15:46 | |
| *** AlexeyAbashkin has joined #openstack-nova | 15:47 | |
| edleafe | dansmith: yeah, I'll push a new rev of that spec shortly | 15:47 |
| dansmith | edleafe: ack thanks | 15:47 |
| lyarwood | mriedem: yeah we can still race on our side, then again so could c-api when it's creating the attachment | 15:47 |
| lyarwood | *attachments | 15:48 |
| mriedem | so i can't remember what we said at the ptg the bdm unique constraint would be on, since it can't be volume_id and instance_uuid, since that would break multiattach | 15:48 |
| mriedem | oh, nvm, | 15:48 |
| mriedem | that would be ok | 15:48 |
| dansmith | what if people want multiple attachments to the same vm and instance?? | 15:49 |
| dansmith | s/??/?/ | 15:49 |
| lyarwood | to the same volume and instance you mean? | 15:49 |
| dansmith | heh yeah | 15:49 |
| lyarwood | like during LM | 15:49 |
| dansmith | or just for some sort of fictitious multipathing sort of thing | 15:50 |
| dansmith | like they want multiple VFs on the same physnet today | 15:50 |
| mriedem | via the cinder api, you can create multiple volume attachments to the same instance and volume | 15:50 |
| mriedem | nova uses that for migrations | 15:50 |
| lyarwood | we wouldn't model that using attachments, that's all within a single attachment and the connection_info it provides | 15:50 |
| *** zhaochao has quit IRC | 15:50 | |
| mriedem | only one attachment should be 'active' at any time | 15:51 |
| mriedem | like what we're doing with the neutron port binding stuff | 15:51 |
| mriedem | active = the attachment has a host connector and connection to the backend storage | 15:51 |
| *** germs has joined #openstack-nova | 15:51 | |
| *** germs has quit IRC | 15:51 | |
| *** germs has joined #openstack-nova | 15:51 | |
| dansmith | lyarwood: I dunno, if we have multiple paths to the host from the volume provider, we'd need different attachments because of differing addresses right? | 15:52 |
| *** cristicalin has quit IRC | 15:52 | |
| dansmith | I'm just playing devil's advocate here to make sure we don't regret a decision later | 15:53 |
| dansmith | removing a constraint is easy I guess | 15:53 |
| mriedem | i don't even have a decision/solution for this race problem right now | 15:53 |
| dansmith | although I'm not sure if mriedem is saying current live migration behavior would break there | 15:53 |
| lyarwood | dansmith: hehe yeah I understand | 15:53 |
| mriedem | the solution to fix the race with attaching the same volume to the same instance concurrently is a unique constraint on the bdms table over the volume_id and instance_uuid columns | 15:54 |
| mriedem | but that doesn't fix lyarwood's new bug | 15:54 |
| mriedem | you can't put a unique constraint on just the volume_id column since that would break multiattach | 15:55 |
| mriedem | you almost need a conditional constraint, where volume_id must be unique if multiattach=False | 15:55 |
| mriedem | but there is no such thing as a conditional unique constraint is there? | 15:55 |
| mriedem | and jaypibbles ran off | 15:56 |
| dansmith | mriedem: I think you need an active=$id column to do that | 15:56 |
| dansmith | that's why we have deleted=$id I think | 15:56 |
| *** germs has quit IRC | 15:56 | |
| mriedem | https://en.wikipedia.org/wiki/Check_constraint | 15:56 |
| dansmith | hmm | 15:57 |
| dansmith | I wonder what the performance of that is | 15:57 |
| mriedem | i've always seen these in sqla-migrate but never played with one | 15:57 |
| mriedem | zzzeek_: how terrible are check constraints? | 15:58 |
| dansmith | wait, | 15:58 |
| zzzeek_ | mriedem: most mysql / mariadb variants ignore them | 15:58 |
| lyarwood | http://docs.sqlalchemy.org/en/latest/core/constraints.html#check-constraint | 15:58 |
| lyarwood | Note that some databases do not actively support check constraints such as MySQL. | 15:58 |
| zzzeek_ | mriedem: which is why you never see thme :) | 15:58 |
| dansmith | you have to do your own uniqueness checking in the contraint then | 15:58 |
| lyarwood | ^ yeah what zzzeek_ said | 15:58 |
| mriedem | gdi | 15:58 |
| zzzeek_ | lyarwood: mariadb 10.2 does now. oddly enough this creates more problems :) | 15:58 |
| dansmith | mriedem: I'm sure DB2 supports them and is just hanging out by the punch bowl waiting for someone to care | 15:59 |
| mriedem | i <3 DB2 | 15:59 |
| dansmith | I know you do | 15:59 |
| mriedem | i heard ms azure rolled out a dbaas service and i noticed it didn't include db2 | 16:00 |
| mriedem | i was hurt | 16:00 |
| dansmith | and shocked, I'm sure | 16:00 |
| mriedem | it does include pg | 16:00 |
| *** edmondsw has quit IRC | 16:00 | |
| *** suresh12 has joined #openstack-nova | 16:00 | |
| *** edmondsw has joined #openstack-nova | 16:01 | |
| mriedem | ok so if we had an 'active' column on the bdms table, we could set that to true when we do something like set the connection_info on it | 16:02 |
| mriedem | which means it's attached | 16:02 |
| *** ktibi_ has joined #openstack-nova | 16:02 | |
| mriedem | but still, | 16:02 |
| mriedem | you could have >1 bdm on the same volume which are both 'active' | 16:02 |
| mriedem | if that volume is multiattach=true | 16:02 |
| mriedem | wonder if there is something that can be done on the cinder side, i.e. a rule saying, you can't have >1 attachment record to the same volume for different instances if the volume is multiattach=false | 16:04 |
| *** ktibi has quit IRC | 16:04 | |
| *** mgoddard has quit IRC | 16:04 | |
| *** lyarwood has quit IRC | 16:05 | |
| mriedem | or if that's already the rule they have in place | 16:05 |
| *** yamamoto has quit IRC | 16:10 | |
| *** yamamoto has joined #openstack-nova | 16:10 | |
| *** suresh12 has quit IRC | 16:12 | |
| mriedem | lee bugged out, but i might have a fix on the cinder side | 16:14 |
| smcginnis | mriedem: I think we can't due to things like migration. | 16:14 |
| mriedem | glory hallelujah | 16:14 |
| *** lyarwood has joined #openstack-nova | 16:14 | |
| mriedem | smcginnis: i'll poke you with the patch when it's up, and i'll hope lee can apply and see if it solves his issue | 16:15 |
| smcginnis | mriedem: OK, sounds like a plan. | 16:15 |
| *** evin has joined #openstack-nova | 16:16 | |
| *** suresh12 has joined #openstack-nova | 16:17 | |
| *** lucasagomes is now known as lucas-afk | 16:18 | |
| *** sridharg has quit IRC | 16:19 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: rbd: flatten images when creating/unshelving an instance https://review.openstack.org/457886 | 16:19 |
| melwitt | mriedem: thanks for adding the neutron stuff to the forum ideas etherpad | 16:21 |
| mriedem | np | 16:21 |
| *** speller_ has quit IRC | 16:22 | |
| mriedem | lyarwood: does that also fix bug 1732428? | 16:22 |
| openstack | bug 1732428 in OpenStack Compute (nova) "Unshelving a VM breaks instance metadata when using qcow2 backed images" [Medium,In progress] https://launchpad.net/bugs/1732428 - Assigned to Matt Riedemann (mriedem) | 16:22 |
| * lyarwood reads | 16:23 | |
| lyarwood | mriedem: no, flatten is specific to the rbd imagebackend | 16:24 |
| *** suresh12 has quit IRC | 16:24 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688 | 16:24 |
| *** hemna_ has joined #openstack-nova | 16:25 | |
| jgriffith | lyarwood: I added a note to https://bugs.launchpad.net/cinder/+bug/1762687 | 16:26 |
| openstack | Launchpad bug 1762687 in Cinder "Concurrent requests to attach the same non-multiattach volume to multiple instances can succeed" [High,New] | 16:26 |
| lyarwood | thanks ./me looks | 16:26 |
| jgriffith | I think the race is the condition check in _reserve_volume on the cidner side | 16:26 |
| jgriffith | mriedem: ^^ | 16:26 |
| *** felipemonteiro_ has quit IRC | 16:27 | |
| mriedem | jgriffith: just about got something here | 16:27 |
| *** felipemonteiro_ has joined #openstack-nova | 16:27 | |
| jgriffith | mriedem: oh... so I guess that means I was wrong? | 16:27 |
| mriedem | haven't read the comment yet, | 16:27 |
| mriedem | just fixing tests | 16:27 |
| jgriffith | Oh... LOL | 16:28 |
| jgriffith | mriedem: so what you're saying is "there's a chance" :) | 16:28 |
| smcginnis | :) | 16:28 |
| jgriffith | if this were slack I'd insert stupid gif here | 16:28 |
| *** damien_r has quit IRC | 16:29 | |
| smcginnis | I think that's the whole reason why folks like slack over irc. :) | 16:30 |
| melwitt | dansmith: this is the patch we talked briefly about on friday at the ptg about flattening rbd images if not CONF.use_cow_images. I had asked the room if there was any usefulness in someone configuring that way and you had said some people would to get better performance https://review.openstack.org/#/c/457886 | 16:31 |
| mriedem | lyarwood: can you test this out? https://review.openstack.org/560074 | 16:31 |
| lyarwood | mriedem: sure can | 16:31 |
| *** yamamoto has quit IRC | 16:33 | |
| mriedem | dansmith: melwitt: just fyi, i'll be out for a few hours this afternoon | 16:33 |
| melwitt | k | 16:33 |
| dansmith | melwitt: okay, was there more to that question? | 16:33 |
| *** yamamoto has joined #openstack-nova | 16:34 | |
| *** madhaviy has joined #openstack-nova | 16:35 | |
| melwitt | dansmith: lyarwood rebased it a little while ago and it reminded me that I had been meaning to ask if you could review it. I added the bit about using the CONF.use_cow_images config option as a toggle for flattening | 16:36 |
| dansmith | okay | 16:36 |
| *** mdbooth has quit IRC | 16:39 | |
| lyarwood | mriedem: that appears to be enough but I'm just spamming requests from the cli again | 16:40 |
| *** mgoddard has joined #openstack-nova | 16:41 | |
| mriedem | lyarwood: ok i'm updating it per jgriffith's comment | 16:43 |
| *** vladikr has quit IRC | 16:43 | |
| jgriffith | lyarwood: so just the refresh was enough? | 16:43 |
| lyarwood | mriedem: that's a different issue though right? That's allowing concurrent attach requests for multiattach volumes that are reserved? | 16:44 |
| * lyarwood might be missing something | 16:44 | |
| jgriffith | lyarwood: if so that's great, and we can consider that if adding reserve to the status check has consequences (I still think it might) | 16:44 |
| lyarwood | jgriffith: yeah as above I can't see how adding reserved helps with this non-multiattach race tbh | 16:46 |
| *** psachin has quit IRC | 16:46 | |
| lyarwood | jgriffith: we only expect available or downloading in that case right? | 16:46 |
| mriedem | yeah | 16:46 |
| jgriffith | lyarwood: yes | 16:47 |
| mriedem | and yes i think adding 'reserved' would only be for racing to attach the same multiattach volume to separate instances | 16:47 |
| jgriffith | mriedem: +1 | 16:47 |
| lyarwood | kk | 16:47 |
| lyarwood | just checking, thanks | 16:47 |
| mriedem | so if just the volume refresh fixes it, then i could remove the 'reserved' part of this patch, and that can be done later if it's a problem | 16:47 |
| *** cristicalin has joined #openstack-nova | 16:48 | |
| *** udesale has quit IRC | 16:49 | |
| *** fragatina has quit IRC | 16:49 | |
| *** sambetts is now known as sambetts|afk | 16:50 | |
| lyarwood | mriedem: yup I'd drop it for now tbh but it's really up to the cinder folks | 16:52 |
| *** felipemonteiro__ has joined #openstack-nova | 16:53 | |
| mriedem | lyarwood: if it fixes your issue for non-multiattach volumes then i'm happy to simplify the patch | 16:53 |
| mriedem | i need some time to write a test anyway | 16:53 |
| *** felipemonteiro_ has quit IRC | 16:57 | |
| *** AlexeyAbashkin has quit IRC | 16:59 | |
| *** yamamoto has quit IRC | 17:00 | |
| *** dikonoor has quit IRC | 17:00 | |
| *** derekh has quit IRC | 17:02 | |
| *** ssurana has joined #openstack-nova | 17:02 | |
| *** andreas_s has joined #openstack-nova | 17:03 | |
| *** AlexeyAbashkin has joined #openstack-nova | 17:07 | |
| *** dpawlik has joined #openstack-nova | 17:08 | |
| *** yamamoto has joined #openstack-nova | 17:08 | |
| cfriesen_ | mriedem: did you ever get any further with https://bugs.launchpad.net/nova/+bug/1696125 ? I think we're seeing it too, though it showed up in the guise of a stalled heat stack deletion. | 17:08 |
| openstack | Launchpad bug 1696125 in OpenStack Compute (nova) "Detach interface failed - timeout waiting to detach tap device in linuxbridge job (pike)" [High,In progress] - Assigned to Matt Riedemann (mriedem) | 17:08 |
| *** mdnadeem_ has quit IRC | 17:10 | |
| *** david-lyle has joined #openstack-nova | 17:10 | |
| openstackgerrit | Sam Yaple proposed openstack/nova stable/pike: Fix wrapping of neutron forbidden error https://review.openstack.org/560087 | 17:11 |
| openstackgerrit | Sam Yaple proposed openstack/nova stable/ocata: Fix wrapping of neutron forbidden error https://review.openstack.org/560088 | 17:11 |
| *** AlexeyAbashkin has quit IRC | 17:12 | |
| cfriesen_ | mriedem: and we're not using linuxbridge | 17:12 |
| *** dpawlik has quit IRC | 17:12 | |
| *** itlinux has joined #openstack-nova | 17:14 | |
| *** dklyle has quit IRC | 17:14 | |
| *** fragatina has joined #openstack-nova | 17:15 | |
| *** yamamoto has quit IRC | 17:15 | |
| *** yamamoto has joined #openstack-nova | 17:15 | |
| mriedem | cfriesen_: no, slipped out of mind since we're not hitting it in the gate anymore | 17:16 |
| *** tesseract has quit IRC | 17:16 | |
| *** andreas_s has quit IRC | 17:16 | |
| mriedem | SamYaple: you have to first backport that to stable/queens | 17:17 |
| *** annp has quit IRC | 17:17 | |
| mriedem | oh wait | 17:17 |
| SamYaple | mriedem: its in stable queens | 17:17 |
| SamYaple | i checked | 17:17 |
| mriedem | yeah :) | 17:17 |
| *** fragatina has quit IRC | 17:17 | |
| mriedem | nvm | 17:17 |
| *** annp has joined #openstack-nova | 17:18 | |
| *** fragatina has joined #openstack-nova | 17:18 | |
| *** ssurana has left #openstack-nova | 17:18 | |
| *** artom_ has joined #openstack-nova | 17:19 | |
| SamYaple | yea it got me too. its just a 5 month old branch, when queens was still master | 17:20 |
| SamYaple | 5 month old patch* | 17:20 |
| kashyap | dansmith: Just read the scroll. Thanks for the explanation | 17:21 |
| *** cristicalin has quit IRC | 17:21 | |
| *** artom has quit IRC | 17:21 | |
| *** andreas_s has joined #openstack-nova | 17:21 | |
| kashyap | dansmith: And yes, I did realize I had to remove 'test.nested'. Just didn't commit to it in the paste-bin. /me tinkers a bit | 17:21 |
| *** artom__ has joined #openstack-nova | 17:22 | |
| *** sidx64 has quit IRC | 17:23 | |
| *** sean-k-mooney has quit IRC | 17:24 | |
| *** nicolasbock has joined #openstack-nova | 17:24 | |
| *** artom_ has quit IRC | 17:24 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Test case: ResourceClass.normalize_name with ß https://review.openstack.org/560092 | 17:26 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Make ResourceClass.normalize_name handle sharp S https://review.openstack.org/560093 | 17:26 |
| *** awaugama has quit IRC | 17:27 | |
| *** gjayavelu has joined #openstack-nova | 17:27 | |
| *** awaugama has joined #openstack-nova | 17:28 | |
| melwitt | efried: how did you find that? ^ | 17:30 |
| efried | melwitt: Nice one, right? | 17:30 |
| melwitt | yeah o.O | 17:30 |
| efried | I actually found it while working on https://review.openstack.org/#/c/556628/ which I'm now going to abandon (because reasons I'm posting here is a minute) | 17:30 |
| *** dpawlik has joined #openstack-nova | 17:31 | |
| efried | (but mostly because jaypipes is right) | 17:31 |
| *** artom__ is now known as artom | 17:32 | |
| mriedem | we might have a new dbdeadlock http://logs.openstack.org/14/554314/1/gate/tempest-full-py3/1aa1216/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Apr_10_13_49_39_294710 | 17:33 |
| *** openstackgerrit has quit IRC | 17:34 | |
| *** ralonsoh has quit IRC | 17:34 | |
| *** r-daneel_ has joined #openstack-nova | 17:35 | |
| *** andreas_s has quit IRC | 17:36 | |
| *** r-daneel has quit IRC | 17:36 | |
| *** r-daneel_ is now known as r-daneel | 17:36 | |
| artom | (null) | 17:38 |
| *** tbachman has joined #openstack-nova | 17:39 | |
| *** jpena is now known as jpena|off | 17:40 | |
| *** suresh12 has joined #openstack-nova | 17:48 | |
| *** tbachman has quit IRC | 17:49 | |
| *** jaosorior has joined #openstack-nova | 17:50 | |
| *** germs has joined #openstack-nova | 17:52 | |
| *** germs has quit IRC | 17:52 | |
| *** germs has joined #openstack-nova | 17:52 | |
| *** david-lyle has quit IRC | 17:53 | |
| *** dpawlik has quit IRC | 17:53 | |
| *** dklyle has joined #openstack-nova | 17:54 | |
| *** germs has quit IRC | 17:56 | |
| *** tbachman has joined #openstack-nova | 17:57 | |
| *** openstackgerrit has joined #openstack-nova | 18:01 | |
| openstackgerrit | Eric Fried proposed openstack/os-traits master: normalize_name helper https://review.openstack.org/560107 | 18:01 |
| *** dougshel_ has joined #openstack-nova | 18:02 | |
| *** amoralej is now known as amoralej|off | 18:03 | |
| *** dikonoor has joined #openstack-nova | 18:04 | |
| *** dougshelley66 has quit IRC | 18:05 | |
| *** madhaviy has quit IRC | 18:06 | |
| *** tbachman has quit IRC | 18:08 | |
| *** tbachman has joined #openstack-nova | 18:09 | |
| *** germs has joined #openstack-nova | 18:12 | |
| *** germs has quit IRC | 18:12 | |
| *** germs has joined #openstack-nova | 18:12 | |
| *** gouthamr has joined #openstack-nova | 18:13 | |
| openstackgerrit | Ed Leafe proposed openstack/nova-specs master: Add Generation to Consumers https://review.openstack.org/556971 | 18:15 |
| *** r-daneel_ has joined #openstack-nova | 18:16 | |
| edleafe | dansmith: ^^ Addressed your comments | 18:17 |
| *** r-daneel has quit IRC | 18:17 | |
| *** r-daneel_ is now known as r-daneel | 18:17 | |
| efried | edleafe: Thanks, that lgtm | 18:18 |
| *** gouthamr has quit IRC | 18:19 | |
| *** dpawlik has joined #openstack-nova | 18:19 | |
| *** dpawlik has quit IRC | 18:20 | |
| *** dpawlik has joined #openstack-nova | 18:21 | |
| simondodsley | anyone help with https://review.openstack.org/#/c/558530 that breaks pep8 with a C901 'LibvirtConfigGuestDisk.format_dom' is too complex (40) error? My Python skills are not up to re-coding that module with confidence | 18:22 |
| openstackgerrit | Jimmy McCrory proposed openstack/nova master: Pass user context detaching volume on exceptions https://review.openstack.org/560115 | 18:22 |
| openstackgerrit | Eric Fried proposed openstack/os-traits master: normalize_name helper https://review.openstack.org/560107 | 18:22 |
| dansmith | efried: well, I still wanted more detail on the userid history thing, but I guess I'm the only one | 18:22 |
| efried | dansmith: Oh, yeah, edleafe did you want to address that? | 18:23 |
| efried | I would volunteer to write it up, but I'm not 100% sure I understand it well enough to articulate it. | 18:23 |
| *** harlowja has joined #openstack-nova | 18:25 | |
| melwitt | simondodsley: I think that just means the code you added pushed the format_dom method length over the limit for "complexity". so you just need to break some of the code in format_dom into a private helper method and call it from format_dom | 18:25 |
| *** fragatina has quit IRC | 18:26 | |
| *** fragatina has joined #openstack-nova | 18:27 | |
| simondodsley | melwitt: Yeah - I get what the error is, but the whole section of that module is repeating if statements. I'm not sure I want to modify code that I didn't add for my first attempt at messing with core Nova code :) | 18:28 |
| *** vladikr has joined #openstack-nova | 18:31 | |
| edleafe | dansmith: I didn't work on the user_id changes, so my knowledge of the whys and wherefores is limited | 18:32 |
| melwitt | simondodsley: oh, I see. I think what I would do is add a refactor patch to stack under your patch that adds a method like "iotune = self._get_iotune()" and puts all of the iotune.append stuff in there. then your additions would go in _get_iotune | 18:33 |
| efried | edleafe: Is http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-04-10.log.html#t2018-04-10T15:24:58 roughly correct to your understanding? | 18:34 |
| melwitt | that said, it looks like you need some review on your spec https://review.openstack.org/#/c/340168 (I will take a look) | 18:34 |
| openstackgerrit | Merged openstack/nova-specs master: Add Generation to Consumers https://review.openstack.org/556971 | 18:35 |
| edleafe | efried: yeah, that's pretty much it | 18:36 |
| *** AlexeyAbashkin has joined #openstack-nova | 18:36 | |
| efried | I can have a crack at an edit. | 18:36 |
| efried | Because when dansmith is happy, everyone's happy. | 18:36 |
| efried | Or maybe it's the inverse. | 18:37 |
| edleafe | efried: wasn't there some discussion about trying to backfill those values, using the consumer_uuid to find the project/user for that VM | 18:37 |
| efried | oh, sheesh, I don't remember any of that. | 18:37 |
| edleafe | but that that wouldn't work for non-VM consumers | 18:37 |
| *** mgoddard has quit IRC | 18:37 | |
| *** gouthamr has joined #openstack-nova | 18:38 | |
| edleafe | yeah, that was a while ago, well before the consumer generation stuff | 18:39 |
| eandersson | cfriesen_, do you think the numa migration (not live) issues are fixed in newer releases? | 18:43 |
| *** gouthamr has quit IRC | 18:43 | |
| eandersson | I haven't had time to build a non-mitaka lab yet to run the same tests | 18:44 |
| *** mvk has joined #openstack-nova | 18:47 | |
| *** jaosorior has quit IRC | 18:48 | |
| *** amodi has quit IRC | 18:48 | |
| *** germs has quit IRC | 18:49 | |
| *** germs has joined #openstack-nova | 18:51 | |
| *** germs has quit IRC | 18:51 | |
| *** germs has joined #openstack-nova | 18:51 | |
| *** salv-orlando has quit IRC | 18:57 | |
| *** salv-orlando has joined #openstack-nova | 18:58 | |
| *** germs has quit IRC | 18:58 | |
| *** salv-orlando has quit IRC | 19:02 | |
| *** openstackgerrit has quit IRC | 19:04 | |
| *** dougshel_ has quit IRC | 19:06 | |
| *** damien_r has joined #openstack-nova | 19:07 | |
| cfriesen_ | eandersson: I don't regularly run migration/evacuate/resize tests on upstream master, so I can't say for sure. I'm also confused why it's not working for you. Did you ever get a chance to test with debug logging enabled to figure out why the claim logs weren't coming out? | 19:08 |
| cfriesen_ | eandersson: generally I'd expect more recent versions to do a better job of resource tracking | 19:08 |
| eandersson | I think I pasted you anything relavent | 19:08 |
| eandersson | Yea - I'll try to set up a lab with pike or newer this week | 19:08 |
| eandersson | need to do some research for our upgrade path anyway | 19:09 |
| *** damien_r has quit IRC | 19:10 | |
| *** avolkov has quit IRC | 19:15 | |
| *** tbachman has quit IRC | 19:19 | |
| *** jafeha has joined #openstack-nova | 19:26 | |
| *** jafeha__ has quit IRC | 19:28 | |
| *** jafeha__ has joined #openstack-nova | 19:28 | |
| *** jafeha has quit IRC | 19:29 | |
| cfriesen_ | dansmith: in https://git.openstack.org/cgit/openstack/nova/commit/?id=804215017f38300ac429e4401ce9c23f0c8ff3c6 you have a comment suggesting that failing to detach a volume is expected and reasonable. Was there a fix to keep heat from waiting forever if this happens when deleting a stack? | 19:30 |
| *** jackie-truong has joined #openstack-nova | 19:32 | |
| *** dougshelley66 has joined #openstack-nova | 19:33 | |
| *** jafeha__ has quit IRC | 19:35 | |
| *** jafeha has joined #openstack-nova | 19:35 | |
| *** markvoelker_ has quit IRC | 19:41 | |
| *** markvoelker has joined #openstack-nova | 19:41 | |
| *** amodi has joined #openstack-nova | 19:42 | |
| *** awaugama has quit IRC | 19:43 | |
| *** markvoelker has quit IRC | 19:45 | |
| *** andreas_s has joined #openstack-nova | 19:48 | |
| *** jackie-truong has quit IRC | 19:52 | |
| *** andreas_s has quit IRC | 19:53 | |
| *** openstackgerrit has joined #openstack-nova | 19:53 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add columns for generation to consumers https://review.openstack.org/557958 | 19:53 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add handlers for consumer_generation https://review.openstack.org/557959 | 19:53 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add a microversion for consumer generation https://review.openstack.org/558958 | 19:53 |
| *** sidx64 has joined #openstack-nova | 19:53 | |
| edleafe | efried: ^^ new revs for consumer generation. Still have a couple of functional tests failing in the last patch, but otherwise they're ready for review | 19:53 |
| efried | edleafe: ack | 19:54 |
| *** markvoelker has joined #openstack-nova | 19:54 | |
| *** tbachman has joined #openstack-nova | 19:54 | |
| dansmith | cfriesen_: that is about the instance not releasing the disk, it still raises | 19:54 |
| dansmith | cfriesen_: but no, if heat is going to try to detach things before it deletes an instance, then it's going to keep waiting | 19:55 |
| dansmith | if it's doing a stack delete, then it should just kill the instance and not wait for volume detach which is never going to happen | 19:55 |
| *** gjayavelu has quit IRC | 19:56 | |
| *** salv-orlando has joined #openstack-nova | 19:58 | |
| cfriesen_ | dansmith: apparently heat has no way of knowing that the detach failed from nova's perspective, so currently it waits around forever. And I suspect the volume was a separate heat resource and it was trying to tear it down cleanly. (Looks like a stack update could also result in volume detach, which would be subject to the same problem.) | 19:58 |
| *** READ10 has quit IRC | 19:59 | |
| dansmith | cfriesen_: I think we log an instance action for it, no? | 20:00 |
| dansmith | but regardless, | 20:00 |
| dansmith | at a minimum it should time out and then try shutting the instance down before doing the detach (or just delete it while it's off) | 20:00 |
| dansmith | actually just deleting it while it's running should work I would think | 20:00 |
| *** pcaruana has quit IRC | 20:01 | |
| cfriesen_ | dansmith: delete the instance? what about the stack update case where we just want to detach and replace the volume? | 20:01 |
| dansmith | you said stack delet | 20:01 |
| dansmith | and that's where we hit the issue as well | 20:01 |
| dansmith | but, if you're doing an update, then power off and detach | 20:01 |
| *** jackie-truong has joined #openstack-nova | 20:02 | |
| dansmith | the deal is the instance didn't let go of the volume, so there's really nothing else to do other than shut it down, or tell the instance to get over itself | 20:02 |
| cfriesen_ | dansmith: fair enough. you mentioned an instance action, where would that get logged? | 20:02 |
| dansmith | in instance actions | 20:02 |
| *** salv-orlando has quit IRC | 20:03 | |
| cfriesen_ | I mean where in the detach volume exception path would we report the failure to detach as an instance action? | 20:04 |
| dansmith | I'm not positive we do, I'm just saying I think we would | 20:04 |
| dansmith | I can look, but so can you :) | 20:04 |
| cfriesen_ | yep..was hoping you knew off the top of your head. Looking. | 20:05 |
| dansmith | nope | 20:07 |
| *** salv-orlando has joined #openstack-nova | 20:07 | |
| dansmith | ah yeah, | 20:08 |
| dansmith | cfriesen_: @wrap_instance_event on compute manager detach_volume | 20:08 |
| cfriesen_ | dansmith: looks like ComputeManager.detach_volume() has wrap_instance_fault and wrap_instance_event decorators | 20:08 |
| dansmith | I think that decorator ends up with it | 20:09 |
| dansmith | yeah | 20:09 |
| efried | dansmith: You wanna finish up the paperwork on the bp here https://blueprints.launchpad.net/nova/+spec/add-consumer-generation | 20:09 |
| cfriesen_ | dansmith: So heat should maybe poll those for updates as well as looking for the state change on the volume? | 20:09 |
| dansmith | efried: I hate paperwork | 20:10 |
| dansmith | cfriesen_: I'm guessin' that'd be smart :) | 20:10 |
| efried | dansmith: :* | 20:11 |
| cfriesen_ | time to go check the captured database logs and see if the appropriate info was there. | 20:12 |
| *** AlexeyAbashkin has quit IRC | 20:16 | |
| *** AlexeyAbashkin has joined #openstack-nova | 20:17 | |
| *** markvoelker_ has joined #openstack-nova | 20:17 | |
| *** dpawlik has quit IRC | 20:17 | |
| *** dpawlik has joined #openstack-nova | 20:17 | |
| openstackgerrit | Merged openstack/nova stable/queens: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559700 | 20:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/559702 | 20:18 |
| *** markvoelker has quit IRC | 20:21 | |
| *** tssurya has joined #openstack-nova | 20:21 | |
| *** dpawlik has quit IRC | 20:22 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920 | 20:24 |
| *** AlexeyAbashkin has quit IRC | 20:25 | |
| *** sidx64_ has joined #openstack-nova | 20:27 | |
| *** liuzz has quit IRC | 20:27 | |
| openstackgerrit | Merged openstack/nova master: Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171 | 20:29 |
| *** sidx64 has quit IRC | 20:29 | |
| *** artom has quit IRC | 20:29 | |
| openstackgerrit | Merged openstack/nova master: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/505771 | 20:30 |
| cfriesen_ | dansmith: I see relevent entries in "instance_actions_events" and "instance_faults", but I don't know of any API to get either of those. Would the fault entry show up when doing a GET | 20:31 |
| cfriesen_ | GET | 20:31 |
| cfriesen_ | /servers/{server_id} | 20:31 |
| cfriesen_ | whoops, paste error | 20:32 |
| dansmith | cfriesen_: the instance actions api | 20:32 |
| *** sree has joined #openstack-nova | 20:32 | |
| mriedem | GET /os-instance-actions | 20:32 |
| mriedem | the fault is stored on the server | 20:32 |
| mriedem | https://developer.openstack.org/api-ref/compute/#servers-actions-servers-os-instance-actions | 20:32 |
| dansmith | cfriesen_: https://developer.openstack.org/api-ref/compute/#list-actions-for-server | 20:32 |
| *** evin has quit IRC | 20:32 | |
| dansmith | yeah | 20:32 |
| mriedem | https://developer.openstack.org/api-guide/compute/faults.html | 20:32 |
| mriedem | ^ might be stale | 20:32 |
| mriedem | most things in the compute api guide are old | 20:33 |
| mriedem | e.g. https://developer.openstack.org/api-guide/compute/faults.html#instance-faults | 20:33 |
| mriedem | "However, there is currently no API to retrieve this information." | 20:33 |
| mriedem | that's totally bogus | 20:33 |
| *** ktibi_ has quit IRC | 20:33 | |
| mriedem | GET /server/{id} has a 'fault' key in the response | 20:34 |
| mriedem | "A fault object. Only displayed in the failed response. Default keys are code, created, and message (response code, created time, and message respectively). In addition, the key details (stack trace) is available if you have the administrator privilege." | 20:34 |
| *** sree has quit IRC | 20:36 | |
| cfriesen_ | thanks, looks like heat should be able to get the necessary info | 20:38 |
| openstackgerrit | Merged openstack/nova master: Don't persist RequestSpec.retry https://review.openstack.org/559447 | 20:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560142 | 20:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Don't persist RequestSpec.retry https://review.openstack.org/560143 | 20:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560145 | 20:44 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Don't persist RequestSpec.retry https://review.openstack.org/560146 | 20:44 |
| *** ssurana1 has joined #openstack-nova | 20:48 | |
| *** ssurana1 has left #openstack-nova | 20:52 | |
| *** dikonoor has quit IRC | 20:52 | |
| *** dikonoor has joined #openstack-nova | 20:54 | |
| *** sidx64 has joined #openstack-nova | 20:56 | |
| *** felipemonteiro__ has quit IRC | 20:56 | |
| *** sidx64_ has quit IRC | 20:58 | |
| *** priteau has quit IRC | 20:59 | |
| *** priteau has joined #openstack-nova | 21:00 | |
| *** slaweq has quit IRC | 21:02 | |
| *** slaweq has joined #openstack-nova | 21:02 | |
| *** priteau has quit IRC | 21:04 | |
| *** slaweq has quit IRC | 21:07 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 21:10 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:10 |
| *** sidx64 has quit IRC | 21:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560145 | 21:15 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Don't persist RequestSpec.retry https://review.openstack.org/560146 | 21:15 |
| jackie-truong | I have a patch that adds documentation for the certificate validation feature. Should that be linked with the current nova-validate-certificates patches? I'll still include the bp link in the commit message | 21:16 |
| *** dikonoor has quit IRC | 21:16 | |
| cfriesen_ | mriedem: dansmith: have you ever seen anything like this? http://paste.openstack.org/show/718865/ It seems like we ask nova to detach, but libvirt doesn't recognize the device. | 21:17 |
| mriedem | yes | 21:17 |
| mriedem | cfriesen_: you should be talking to lyarwood and melwitt | 21:17 |
| cfriesen_ | cool, will do | 21:17 |
| mriedem | they've been in the bowels of that code a few times | 21:17 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 21:17 |
| mriedem | cfriesen_: which branch are you on? do you have all the latest fixes? | 21:18 |
| cfriesen_ | this would be Pike, I'd have to check if it was totally up to date | 21:19 |
| cfriesen_ | gotta run, parent-teacher interview | 21:19 |
| *** cfriesen_ is now known as cfriesen_away | 21:20 | |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949 | 21:20 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204 | 21:20 |
| openstackgerrit | Jackie Truong proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158 | 21:20 |
| *** mchlumsky has quit IRC | 21:21 | |
| mriedem | cfriesen_away: i was thinking of https://review.openstack.org/#/c/488545/ but that's in pike GA | 21:22 |
| *** sree has joined #openstack-nova | 21:24 | |
| *** mchlumsky has joined #openstack-nova | 21:24 | |
| *** pchavva has quit IRC | 21:26 | |
| *** mchlumsky has quit IRC | 21:27 | |
| *** sree has quit IRC | 21:29 | |
| *** jafeha__ has joined #openstack-nova | 21:30 | |
| *** jackie-truong has quit IRC | 21:30 | |
| *** eharney has quit IRC | 21:30 | |
| *** tssurya has quit IRC | 21:31 | |
| *** jafeha has quit IRC | 21:31 | |
| *** gjayavelu has joined #openstack-nova | 21:34 | |
| *** suresh12 has quit IRC | 21:39 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Add regression test for persisted RequestSpec.retry from failed resize https://review.openstack.org/560162 | 21:41 |
| *** suresh12 has joined #openstack-nova | 21:41 | |
| *** edmondsw has quit IRC | 21:42 | |
| *** edmondsw has joined #openstack-nova | 21:42 | |
| *** edmondsw has quit IRC | 21:43 | |
| *** esberglu has quit IRC | 21:52 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | 21:53 |
| *** yamamoto has quit IRC | 21:54 | |
| *** yamamoto has joined #openstack-nova | 21:54 | |
| *** germs has joined #openstack-nova | 21:56 | |
| *** germs has quit IRC | 21:56 | |
| *** germs has joined #openstack-nova | 21:56 | |
| *** burt has quit IRC | 21:57 | |
| *** arvindn05 has joined #openstack-nova | 21:57 | |
| *** priteau has joined #openstack-nova | 21:58 | |
| arvindn05 | dansmith: can you please review the changes made per your suggestions? https://review.openstack.org/#/c/557795/ - Update ImageMetaProp object to expose traits | 21:59 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add a microversion for consumer generation https://review.openstack.org/558958 | 22:04 |
| *** priteau has quit IRC | 22:08 | |
| *** edmondsw has joined #openstack-nova | 22:09 | |
| *** edmondsw has quit IRC | 22:10 | |
| *** sdague has quit IRC | 22:12 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242 | 22:15 |
| openstackgerrit | Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078 | 22:15 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605 | 22:15 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | 22:15 |
| openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | 22:15 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 22:15 |
| *** itlinux has quit IRC | 22:15 | |
| *** tssurya has joined #openstack-nova | 22:17 | |
| *** wolverineav has joined #openstack-nova | 22:19 | |
| *** dougshel_ has joined #openstack-nova | 22:21 | |
| *** tssurya has quit IRC | 22:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Don't persist RequestSpec.retry https://review.openstack.org/560167 | 22:23 |
| *** rcernin has joined #openstack-nova | 22:23 | |
| *** dougshelley66 has quit IRC | 22:24 | |
| *** Guest8476 has quit IRC | 22:32 | |
| *** yamamoto has quit IRC | 22:35 | |
| *** yamamoto has joined #openstack-nova | 22:39 | |
| *** yamamoto has quit IRC | 22:40 | |
| *** lbragstad has quit IRC | 22:42 | |
| *** hongbin has quit IRC | 22:42 | |
| *** yamahata has quit IRC | 22:45 | |
| *** dave-mccowan has quit IRC | 22:49 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242 | 22:55 |
| openstackgerrit | Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078 | 22:55 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605 | 22:55 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437 | 22:55 |
| openstackgerrit | Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439 | 22:55 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 22:55 |
| *** r-daneel has quit IRC | 22:59 | |
| *** r-daneel has joined #openstack-nova | 22:59 | |
| *** fragatina has quit IRC | 22:59 | |
| *** fragatina has joined #openstack-nova | 23:02 | |
| *** slaweq has joined #openstack-nova | 23:03 | |
| *** slaweq has quit IRC | 23:08 | |
| *** lbragstad has joined #openstack-nova | 23:09 | |
| *** r-daneel has quit IRC | 23:14 | |
| *** sdague has joined #openstack-nova | 23:16 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add history behind nullable project_id and user_id https://review.openstack.org/560174 | 23:17 |
| efried | dansmith, edleafe, jaypipes: ^^ | 23:18 |
| efried | mikal: +2! | 23:19 |
| efried | mikal: Thanks for putting up with me. | 23:19 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add handlers for consumer_generation https://review.openstack.org/557959 | 23:20 |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add a microversion for consumer generation https://review.openstack.org/558958 | 23:20 |
| edleafe | efried: ^^ answered *some* of your concerns. The remainder can be discussed tomorrow. | 23:21 |
| efried | edleafe: Roger that. I gotta bail. | 23:21 |
| * edleafe heads out for a glass of wine. | 23:21 | |
| * efried heads out to choke some folk. | 23:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: cleanup docs about instance faults https://review.openstack.org/560178 | 23:34 |
| mriedem | cfriesen_away: ^ that one is for you | 23:34 |
| *** yamamoto has joined #openstack-nova | 23:40 | |
| *** mlavalle has quit IRC | 23:46 | |
| *** takashin has joined #openstack-nova | 23:46 | |
| *** yamamoto has quit IRC | 23:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: cleanup docs about instance faults https://review.openstack.org/560178 | 23:48 |
| mriedem | alex_xu: gmann: Kevin_Zheng: ^ I just realized that we don't have 'fault' as a server blacklisted query parameter or sort key | 23:49 |
| mriedem | but it is a joined table | 23:49 |
| mriedem | looking at https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L298 | 23:50 |
| Kevin_Zheng | mriedem: got it, will check it the first thing when got to office | 23:51 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1762870 | 23:54 |
| openstack | Launchpad bug 1762870 in OpenStack Compute (nova) "server fault is not blacklisted for filtering/sorting" [Medium,Triaged] | 23:54 |
| *** amodi has quit IRC | 23:59 | |
| *** cfriesen_away is now known as cfriesen | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!