*** _alastor_ has quit IRC | 00:02 | |
*** wolverineav has quit IRC | 00:04 | |
*** tetsuro has joined #openstack-nova | 00:04 | |
*** wolverineav has joined #openstack-nova | 00:08 | |
*** slaweq has joined #openstack-nova | 00:16 | |
*** threestrands has joined #openstack-nova | 00:22 | |
*** mriedem_away has quit IRC | 00:23 | |
*** slaweq has quit IRC | 00:24 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Give drop_move_claim() correct docstring https://review.openstack.org/620170 | 00:35 |
---|---|---|
*** bhagyashris has joined #openstack-nova | 00:54 | |
*** _alastor_ has joined #openstack-nova | 00:54 | |
*** _alastor_ has quit IRC | 00:59 | |
openstackgerrit | Vladyslav Drok proposed openstack/nova stable/pike: [pike-only] Fix resize_instance rpcapi call https://review.openstack.org/603439 | 01:01 |
openstackgerrit | Vladyslav Drok proposed openstack/nova stable/pike: [pike-only] Fix resize_instance rpcapi call https://review.openstack.org/603439 | 01:06 |
*** slaweq has joined #openstack-nova | 01:16 | |
*** slaweq has quit IRC | 01:24 | |
*** threestrands has quit IRC | 01:28 | |
*** threestrands has joined #openstack-nova | 01:32 | |
*** naichuans has quit IRC | 01:32 | |
*** wolverin_ has joined #openstack-nova | 01:41 | |
*** wolverin_ has quit IRC | 01:42 | |
*** wolverineav has quit IRC | 01:42 | |
*** wolverineav has joined #openstack-nova | 01:42 | |
*** Dinesh_Bhor has joined #openstack-nova | 01:50 | |
*** hongbin has joined #openstack-nova | 01:55 | |
*** slaweq has joined #openstack-nova | 02:13 | |
*** wolverineav has quit IRC | 02:16 | |
*** wolverineav has joined #openstack-nova | 02:16 | |
*** wolverineav has quit IRC | 02:16 | |
*** k_mouza has joined #openstack-nova | 02:17 | |
*** wolverineav has joined #openstack-nova | 02:17 | |
*** takashin has joined #openstack-nova | 02:19 | |
*** bzhao__ has joined #openstack-nova | 02:20 | |
*** wolverineav has quit IRC | 02:21 | |
*** mrsoul has joined #openstack-nova | 02:23 | |
*** slaweq has quit IRC | 02:24 | |
*** k_mouza has quit IRC | 02:24 | |
*** mschuppert has quit IRC | 02:27 | |
*** bzhao__ has quit IRC | 02:27 | |
*** _alastor_ has joined #openstack-nova | 02:34 | |
*** bzhao__ has joined #openstack-nova | 02:34 | |
*** _alastor_ has quit IRC | 02:38 | |
*** psachin has joined #openstack-nova | 02:40 | |
*** mhen has quit IRC | 02:43 | |
*** mhen has joined #openstack-nova | 02:47 | |
*** whoami-rajat has joined #openstack-nova | 02:50 | |
*** Dinesh_Bhor has quit IRC | 03:02 | |
*** Dinesh_Bhor has joined #openstack-nova | 03:13 | |
*** slaweq has joined #openstack-nova | 03:16 | |
*** artom has quit IRC | 03:21 | |
*** artom has joined #openstack-nova | 03:24 | |
*** slaweq has quit IRC | 03:24 | |
*** sridharg has joined #openstack-nova | 03:33 | |
*** mvkr has quit IRC | 03:47 | |
*** udesale has joined #openstack-nova | 03:54 | |
*** hongbin has quit IRC | 04:06 | |
*** Dinesh_Bhor has quit IRC | 04:10 | |
*** slaweq has joined #openstack-nova | 04:11 | |
*** jarodwl has quit IRC | 04:17 | |
*** slaweq has quit IRC | 04:24 | |
*** udesale has quit IRC | 04:31 | |
*** Dinesh_Bhor has joined #openstack-nova | 04:31 | |
*** ivve has joined #openstack-nova | 04:31 | |
*** janki has joined #openstack-nova | 04:49 | |
*** bhagyashris has quit IRC | 05:00 | |
*** bhagyashris has joined #openstack-nova | 05:00 | |
*** ratailor has joined #openstack-nova | 05:39 | |
*** moshele has joined #openstack-nova | 05:45 | |
openstackgerrit | Merged openstack/nova master: Add missing ws seperator between words https://review.openstack.org/618491 | 05:48 |
*** moshele has quit IRC | 06:06 | |
*** slaweq has joined #openstack-nova | 06:11 | |
*** cfriesen has quit IRC | 06:16 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove Placement API reference https://review.openstack.org/614437 | 06:21 |
*** slaweq has quit IRC | 06:24 | |
*** ccamacho has quit IRC | 06:30 | |
*** _alastor_ has joined #openstack-nova | 06:35 | |
*** _alastor_ has quit IRC | 06:40 | |
*** Luzi has joined #openstack-nova | 06:45 | |
*** moshele has joined #openstack-nova | 06:46 | |
*** dpawlik has joined #openstack-nova | 06:47 | |
*** moshele has quit IRC | 06:51 | |
*** adrianc has joined #openstack-nova | 06:52 | |
*** dpawlik has quit IRC | 06:54 | |
*** rcernin has quit IRC | 06:58 | |
*** moshele has joined #openstack-nova | 06:59 | |
*** mschuppert has joined #openstack-nova | 07:08 | |
*** adrianc has quit IRC | 07:08 | |
*** adrianc has joined #openstack-nova | 07:09 | |
*** moshele has quit IRC | 07:18 | |
*** dpawlik has joined #openstack-nova | 07:23 | |
*** pcaruana has joined #openstack-nova | 07:23 | |
*** dpawlik has quit IRC | 07:38 | |
*** slaweq has joined #openstack-nova | 07:42 | |
*** dpawlik has joined #openstack-nova | 07:44 | |
*** threestrands has quit IRC | 07:44 | |
*** ccamacho has joined #openstack-nova | 07:56 | |
*** moshele has joined #openstack-nova | 08:02 | |
*** sahid has joined #openstack-nova | 08:02 | |
*** maciejjozefczyk has joined #openstack-nova | 08:07 | |
*** hshiina has quit IRC | 08:10 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Change the default values of XXX_allocation_ratio https://review.openstack.org/602803 | 08:12 |
*** tssurya has joined #openstack-nova | 08:13 | |
*** lpetrut has joined #openstack-nova | 08:21 | |
*** priteau has joined #openstack-nova | 08:23 | |
*** ralonsoh has joined #openstack-nova | 08:29 | |
*** k_mouza has joined #openstack-nova | 08:32 | |
*** k_mouza has quit IRC | 08:37 | |
*** maciejjozefczyk has quit IRC | 08:46 | |
*** maciejjozefczyk has joined #openstack-nova | 08:47 | |
*** tssurya has quit IRC | 08:49 | |
*** cdent has joined #openstack-nova | 09:01 | |
*** tssurya has joined #openstack-nova | 09:01 | |
*** xek has joined #openstack-nova | 09:01 | |
*** tobberydberg has joined #openstack-nova | 09:02 | |
*** udesale has joined #openstack-nova | 09:09 | |
*** jackivanov has joined #openstack-nova | 09:16 | |
*** k_mouza has joined #openstack-nova | 09:20 | |
*** ccamacho has quit IRC | 09:20 | |
*** ccamacho has joined #openstack-nova | 09:30 | |
*** derekh has joined #openstack-nova | 09:40 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | 09:41 |
openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Delete the placement code https://review.openstack.org/618215 | 09:41 |
*** xek has quit IRC | 09:44 | |
*** bhagyashris has quit IRC | 09:44 | |
*** xek has joined #openstack-nova | 09:48 | |
*** ondrejme has joined #openstack-nova | 09:53 | |
*** takashin has left #openstack-nova | 10:04 | |
*** xek has quit IRC | 10:18 | |
*** xek has joined #openstack-nova | 10:23 | |
openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | 10:25 |
openstackgerrit | Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215 | 10:25 |
*** erlon has joined #openstack-nova | 10:26 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Remove useless sample and add the lack of tests in v266 https://review.openstack.org/614671 | 10:29 |
*** moshele has quit IRC | 10:33 | |
*** udesale has quit IRC | 10:33 | |
*** udesale has joined #openstack-nova | 10:34 | |
*** moshele has joined #openstack-nova | 10:34 | |
*** _alastor_ has joined #openstack-nova | 10:36 | |
*** udesale has quit IRC | 10:39 | |
*** k_mouza has quit IRC | 10:41 | |
*** _alastor_ has quit IRC | 10:41 | |
*** k_mouza has joined #openstack-nova | 10:41 | |
*** adrianc has quit IRC | 10:42 | |
*** moshele has quit IRC | 10:48 | |
*** jlvillal has joined #openstack-nova | 10:58 | |
*** moshele has joined #openstack-nova | 10:58 | |
*** sean-k-mooney has quit IRC | 11:04 | |
*** udesale has joined #openstack-nova | 11:06 | |
*** adrianc has joined #openstack-nova | 11:07 | |
*** sean-k-mooney has joined #openstack-nova | 11:08 | |
*** dosaboy has quit IRC | 11:24 | |
*** dosaboy has joined #openstack-nova | 11:31 | |
*** tbachman has quit IRC | 11:32 | |
*** sambetts_ is now known as sambetts|afk | 11:32 | |
*** udesale has quit IRC | 11:38 | |
*** xek has quit IRC | 11:40 | |
*** udesale has joined #openstack-nova | 11:45 | |
*** udesale has quit IRC | 11:45 | |
*** udesale has joined #openstack-nova | 11:46 | |
openstackgerrit | Merged openstack/nova stable/rocky: Make supports_direct_io work on 4096b sector size https://review.openstack.org/619251 | 11:52 |
*** udesale has quit IRC | 11:52 | |
*** udesale has joined #openstack-nova | 11:53 | |
*** ratailor has quit IRC | 11:53 | |
*** janki has quit IRC | 11:59 | |
*** xek has joined #openstack-nova | 12:11 | |
*** ccamacho has quit IRC | 12:12 | |
*** tetsuro has quit IRC | 12:13 | |
*** Dinesh_Bhor has quit IRC | 12:13 | |
*** udesale has quit IRC | 12:20 | |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Change the default values of XXX_allocation_ratio https://review.openstack.org/602803 | 12:29 |
openstackgerrit | Yikun Jiang proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804 | 12:29 |
*** Luzi has quit IRC | 12:32 | |
*** udesale has joined #openstack-nova | 12:32 | |
*** udesale has quit IRC | 12:32 | |
*** udesale has joined #openstack-nova | 12:34 | |
*** ccamacho has joined #openstack-nova | 12:41 | |
*** k_mouza has quit IRC | 12:45 | |
*** k_mouza has joined #openstack-nova | 12:46 | |
*** Luzi has joined #openstack-nova | 12:47 | |
*** erlon has quit IRC | 12:48 | |
*** udesale has quit IRC | 12:54 | |
*** takamatsu has quit IRC | 12:58 | |
*** erlon has joined #openstack-nova | 12:59 | |
*** ccamacho has quit IRC | 13:04 | |
*** ccamacho has joined #openstack-nova | 13:04 | |
*** amab has joined #openstack-nova | 13:11 | |
amab | I've changed the default console from vnc to spice, but I get the error is this link: https://paste.ubuntu.com/p/MF6mFQBJ88/ | 13:12 |
*** tbachman has joined #openstack-nova | 13:13 | |
*** takamatsu has joined #openstack-nova | 13:21 | |
*** k_mouza has quit IRC | 13:24 | |
*** _alastor_ has joined #openstack-nova | 13:31 | |
*** takamatsu has quit IRC | 13:37 | |
*** k_mouza has joined #openstack-nova | 13:37 | |
*** k_mouza_ has joined #openstack-nova | 13:38 | |
*** moshele has quit IRC | 13:40 | |
*** k_mouza has quit IRC | 13:42 | |
*** takamatsu has joined #openstack-nova | 13:43 | |
*** jhesketh_ has joined #openstack-nova | 13:44 | |
*** whoami-rajat has quit IRC | 13:49 | |
*** jhesketh has quit IRC | 13:50 | |
*** hughsaunders has quit IRC | 13:50 | |
mnaser | https://review.openstack.org/#/c/619351/ stable/rocky fix merged, stable/queens up (sorry for my daily bugging alert :]) | 13:53 |
*** davidsha has joined #openstack-nova | 13:53 | |
*** udesale has joined #openstack-nova | 13:56 | |
*** Dinesh_Bhor has joined #openstack-nova | 14:04 | |
*** Dinesh_Bhor has quit IRC | 14:05 | |
*** udesale has quit IRC | 14:05 | |
*** udesale has joined #openstack-nova | 14:05 | |
*** mriedem has joined #openstack-nova | 14:18 | |
*** eharney has joined #openstack-nova | 14:19 | |
*** mchlumsky has joined #openstack-nova | 14:23 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Default zero disk flavor to RULE_ADMIN_API in Stein https://review.openstack.org/603910 | 14:24 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Refactor handling of PCIe root ports https://review.openstack.org/620327 | 14:28 |
*** cdent has quit IRC | 14:29 | |
*** xek has quit IRC | 14:30 | |
*** tbachman has quit IRC | 14:31 | |
*** _alastor_ has quit IRC | 14:33 | |
dansmith | mriedem: http://logs.openstack.org/04/620104/1/check/neutron-grenade/832c98f/logs/grenade.sh.txt.gz#_2018-11-26_19_52_27_042 | 14:33 |
dansmith | mriedem: looks reasonable I think | 14:33 |
*** xek has joined #openstack-nova | 14:34 | |
mriedem | so the placement api check failed as expected | 14:35 |
dansmith | yep, didn't explode and "unable to discover endpoint" is reasonably clear I think | 14:36 |
*** mordred has joined #openstack-nova | 14:36 | |
*** xek_ has joined #openstack-nova | 14:43 | |
*** xek has quit IRC | 14:46 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Refactor handling of PCIe root ports https://review.openstack.org/620327 | 14:49 |
*** adrianc has quit IRC | 14:49 | |
*** adrianc has joined #openstack-nova | 14:57 | |
*** awaugama has joined #openstack-nova | 14:59 | |
*** edmondsw has joined #openstack-nova | 14:59 | |
*** awaugama has joined #openstack-nova | 15:01 | |
*** mlavalle has joined #openstack-nova | 15:02 | |
*** tbachman has joined #openstack-nova | 15:02 | |
*** tbachman_ has joined #openstack-nova | 15:04 | |
*** dpawlik has quit IRC | 15:04 | |
*** tbachman has quit IRC | 15:07 | |
*** tbachman_ has quit IRC | 15:09 | |
*** lpetrut has quit IRC | 15:18 | |
*** eharney has quit IRC | 15:19 | |
mriedem | is mdbooth out? | 15:21 |
kashyap | mriedem: He's actually in; I was wondering why isn't he here too | 15:22 |
kashyap | mriedem: BTW, while I have your attention, are things like these useful? -- https://review.openstack.org/#/c/620327/ | 15:22 |
*** mdbooth has joined #openstack-nova | 15:22 | |
kashyap | The original code was hurting my head, so I _had_ to spin that code out into a separate function, and simplify the crap | 15:22 |
* mdbooth waves | 15:23 | |
mdbooth | Weird, didn't get reconnected | 15:23 |
artom | kashyap, for what it's worth, I approve | 15:23 |
artom | That original 'if' is... evil | 15:23 |
kashyap | artom: Thanks, at least one other person finds it useful, then. | 15:23 |
kashyap | artom: Yeah, fucking awful. I was feeling stupid having to re-read it multiple times. | 15:23 |
artom | No, I'm staring at it now and my brain is complaining already | 15:24 |
kashyap | I held my nose, and cleaned up the excrements | 15:24 |
mdbooth | kashyap: What code's this? | 15:24 |
kashyap | mdbooth: Okay, now you're Cced :D it is this: https://review.openstack.org/#/c/620327/ | 15:24 |
kashyap | mdbooth: BTW, mriedem was pinging you for something else, perhaps. | 15:24 |
mriedem | mdbooth: fyi, some nits in https://review.openstack.org/#/c/591733/ which might be worth a follow up | 15:24 |
mdbooth | mriedem: Looking | 15:25 |
kashyap | artom: Since you did click, please go the next step and review. And if need be, complain if you need a test, etc | 15:25 |
artom | kashyap, yep, doing that now | 15:25 |
artom | (reviewing, not complainig) | 15:25 |
kashyap | Thanks! | 15:25 |
mdbooth | mriedem: Awesome, thanks! | 15:26 |
*** eharney has joined #openstack-nova | 15:26 | |
kashyap | artom: That TODO item | 15:26 |
kashyap | (Err hit send too soon) | 15:27 |
artom | I call that PCRS | 15:27 |
artom | Premature Carriage Return Syndrome | 15:27 |
*** tbachman has joined #openstack-nova | 15:27 | |
kashyap | artom: ... is part of a larger work item that needs cleaning up of assumptions about machine types in Nova. And coordinating w/ relevant libvirt work | 15:27 |
kashyap | artom: Heh | 15:28 |
*** tbachman has quit IRC | 15:35 | |
mriedem | mdbooth: what's the difference between the 'disk' and 'disk.local' entries in the block_device_info disk 'mapping' entry? | 15:38 |
mdbooth | mriedem: 'disk' is the root disk | 15:38 |
mdbooth | 'disk.local' is legacy, and no longer generated | 15:38 |
mdbooth | But it used to be the single ephemeral disk | 15:38 |
mriedem | unless... | 15:38 |
mdbooth | Now we have disk.eph0, disk.eph1, etc | 15:39 |
mriedem | if we have code for it, we must support it somehow... | 15:39 |
mriedem | is it for bdmv1? | 15:39 |
mriedem | or just really old bdm records in the db? | 15:39 |
mdbooth | It's a long time since I've checked the details on this, but I recall convincing myself in the past the current code can't generate this | 15:39 |
mdbooth | Yeah, it's old BDM records | 15:39 |
*** Cardoe has joined #openstack-nova | 15:41 | |
*** Cardoe is now known as Cardoe_ | 15:49 | |
*** Cardoe_ is now known as Cardoe | 15:49 | |
*** dpawlik has joined #openstack-nova | 15:50 | |
*** Luzi has quit IRC | 15:51 | |
*** udesale has quit IRC | 15:56 | |
*** udesale has joined #openstack-nova | 15:57 | |
*** udesale has quit IRC | 15:58 | |
*** ttsiouts has joined #openstack-nova | 15:58 | |
*** dansmith has quit IRC | 16:02 | |
*** dansmith has joined #openstack-nova | 16:02 | |
*** munimeha1 has joined #openstack-nova | 16:06 | |
mriedem | mdbooth: comments inline https://review.openstack.org/#/c/578846/ | 16:10 |
*** _alastor_ has joined #openstack-nova | 16:11 | |
mriedem | dansmith: efried: mdbooth: i'd like to move forward with getting this evacuate-related bug fixed https://review.openstack.org/#/c/606122/ - i think the open question was do we use dansmith's more generic solution https://review.openstack.org/#/c/575190/ or keep my "tactical" fix for backports and then rebase dan's on top to replace my specific fix with the generic one | 16:14 |
mriedem | because that's holding up getting us to do evacuate testing with both rbd and lvm backends https://review.openstack.org/#/c/604400/ | 16:15 |
dansmith | mriedem: if you'll do the rebase of mine and cleanup of this spot after we merge yours that's fine | 16:18 |
dansmith | I would backport my generic solution too, but if you don't want to that's fine | 16:18 |
mdbooth | mriedem: ^^^ wfm. | 16:20 |
*** artom has quit IRC | 16:22 | |
*** artom has joined #openstack-nova | 16:22 | |
*** eharney has quit IRC | 16:23 | |
mriedem | dansmith: ack will do | 16:23 |
efried | I'll need to reread everything to refresh my memory of what's going on here. | 16:29 |
*** lpetrut has joined #openstack-nova | 16:30 | |
efried | so wait, which are we doing? just dan's thing, master & backports; or matt's thing for backports and dan's thing for master? | 16:33 |
dansmith | we're doing whichever of those mriedem wants | 16:35 |
dansmith | which I think is the latter | 16:35 |
mriedem | the latter | 16:35 |
efried | okay, so my job is to +2 mriedem's patch (done) and then wait for mdbooth to be satisfied with dansmith's patch before reviewing it. | 16:36 |
dansmith | efried: I think the -1 on mine isn't actually a thing | 16:37 |
*** cfriesen has joined #openstack-nova | 16:38 | |
efried | yeah, but I'm drowning, so looking for any excuse to defer | 16:39 |
mdbooth | dansmith: It's not a thing? | 16:41 |
dansmith | mdbooth: the security groups thing? | 16:41 |
mdbooth | dansmith: Yeah. IIRC I would have been happy with a command saying: # We broke this, but we don't care because it's not a thing any more. | 16:42 |
mdbooth | s/comment | 16:42 |
dansmith | I don't understand why it's a thing at all anyway.. if the instance is deleted, we're not going to do anything with the security groups we do fetch out of the db (if there are any anyway), | 16:43 |
dansmith | and, in any case where we did load the instance with a deleted=yes context, | 16:43 |
dansmith | we'd have gotten the same | 16:43 |
dansmith | so the only case where we'd do something different is where we had an instance, which wasn't deleted when we started, but was deleted underneath us and we go to lazy-load security groups.. if we were to go on and save that instance later, it'd fail and I can't think of anything else we'd do with it that would trigger some different behavior than we have now | 16:44 |
dansmith | which I think was also mriedem's reply | 16:45 |
mriedem | i was specifically worried about instance.services but mel said it was something else there | 16:47 |
mriedem | i.e. the bug she was working on | 16:47 |
mdbooth | dansmith: I think think so. I think the bug is that if you've got an instance which isn't deleted and you lazy load security groups, you get deleted security groups. I don't think you need to delete the instance in between or anything. | 16:47 |
mdbooth | s/think think/don't think/ | 16:47 |
mdbooth | dansmith: But we only care about that if we care about nova security groups, which IIUC are nova-network only. | 16:48 |
mriedem | they are nova-net only | 16:49 |
dansmith | mdbooth: ah, right, I remember you clarifying this again post initial review | 16:50 |
dansmith | they're n-net only, and don't work with cellsv1, right? so we really shouldn't have any supported cases where they're there anymore | 16:50 |
mriedem | so, | 16:51 |
mriedem | SecurityGroup.get_by_instance calls db api security_group_get_by_instance which hard-codes read_deleted="no" | 16:51 |
mriedem | *SecurityGroupList.get_by_instance | 16:51 |
mriedem | so isn't the hard-coding in the DB API preventing that | 16:51 |
dansmith | oh does it? | 16:52 |
* dansmith looks | 16:52 | |
mdbooth | mriedem: Looks like I missed that. That's convenient :) | 16:53 |
dansmith | sure does | 16:53 |
*** jangutter has joined #openstack-nova | 16:55 | |
*** Cardoe has quit IRC | 16:56 | |
sean-k-mooney | speaking of things in nova net the function that enables trusted vfs was added to the nova net module | 16:57 |
dansmith | recorded for posterity | 16:57 |
*** Cardoe has joined #openstack-nova | 16:57 | |
sean-k-mooney | it proably should be moved to an sriov plugin in os-vif | 16:57 |
sean-k-mooney | specifically https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/nova/network/linux_net.py#L1773 should be moved | 16:59 |
*** gyee has joined #openstack-nova | 16:59 | |
sean-k-mooney | mriedem: by the way i havent forgot about looking into can we remove NeutronLinuxBridgeInterfaceDriver too but i havent got around to it yet either | 17:00 |
mriedem | ken'ichi says it's ok https://review.openstack.org/#/c/616995/ | 17:01 |
mdbooth | mriedem: Going back a patch, I was wondering about adding an 'intent' to driver.cleanup and/or driver.destroy, i.e. driver.destroy(reason=MIGRATION|DELETE). We currently have destroy_disks, but the problem with this is that we second guess it in ComputeManager, which makes it basically useless. | 17:01 |
*** lpetrut has quit IRC | 17:01 | |
mdbooth | What we want the driver to do is, for delete: delete everything. For migrate/evacuate: delete everything local to this hypervisor. | 17:02 |
mdbooth | I think the definition of 'local to the hypervisor' is more cleanly defined internally by the hypervisor. | 17:03 |
slaweq | hi nova cores, can You take alook at https://review.openstack.org/#/c/619061/ - it should fix neutron-tempest-postgres-full periodic job in gate so it's quite important for us :) | 17:03 |
slaweq | thx in advance | 17:03 |
sean-k-mooney | mriedem: oh ok cool i think there is more in that file we are not using that we could remove too | 17:03 |
* mdbooth should send an email about that instead, really. | 17:03 | |
mriedem | mdbooth: i don't expect you'll get much in the way of replies on that in the ML | 17:03 |
mriedem | people, like me, will likely say they don't want to think about it | 17:04 |
mdbooth | mriedem: It's a source of a class of real bugs, thoough | 17:04 |
mriedem | mdbooth: so having said that, i assume you aren't proposing to change your current fix to incorporate that right? | 17:04 |
mriedem | mdbooth: oh i don't doubt it | 17:04 |
mdbooth | mriedem: Hell, no | 17:04 |
mdbooth | mriedem: I was thinking about lyarwood's original proposal to fix an extra thing in my patch | 17:04 |
mriedem | there is definitely a russian roulette of disk deletion in compute/virt | 17:04 |
mdbooth | I looked harder at that, and I don't think we can fix it like that | 17:05 |
*** ttsiouts has quit IRC | 17:06 | |
*** ttsiouts has joined #openstack-nova | 17:07 | |
openstackgerrit | Jack Ding proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | 17:07 |
*** lpetrut has joined #openstack-nova | 17:10 | |
*** ttsiouts has quit IRC | 17:11 | |
openstackgerrit | Jack Ding proposed openstack/nova-specs master: [WIP] Flavor Extra Spec and Image Properties Validation https://review.openstack.org/618542 | 17:12 |
*** dpawlik has quit IRC | 17:13 | |
*** dpawlik has joined #openstack-nova | 17:14 | |
mdbooth | mriedem: Practically speaking, what would be the most practical way to go about making that sort of change? Just post a patch? Problem is it wouldn't be a small amount of work, so I'd be cautious of that without some level of buy in beforehand. BP? | 17:14 |
* mdbooth notices the time and runs away | 17:16 | |
*** cdent has joined #openstack-nova | 17:16 | |
mriedem | bp doesn't give you much in the way of details, spec allows you to really write the details down and get review on it without getting too far into implementation, but idk | 17:17 |
mriedem | gonna be a hard sell to get people to want to spend time/brain power on this | 17:17 |
*** dpawlik has quit IRC | 17:18 | |
*** psachin has quit IRC | 17:21 | |
*** derekh has quit IRC | 17:23 | |
*** adrianc has quit IRC | 17:24 | |
*** k_mouza has joined #openstack-nova | 17:29 | |
*** Sundar has joined #openstack-nova | 17:29 | |
*** dpawlik has joined #openstack-nova | 17:29 | |
*** moshele has joined #openstack-nova | 17:30 | |
*** sahid has quit IRC | 17:30 | |
*** jmlowe has quit IRC | 17:32 | |
*** k_mouza_ has quit IRC | 17:33 | |
*** NostawRm has joined #openstack-nova | 17:33 | |
*** jmlowe has joined #openstack-nova | 17:33 | |
*** jmlowe has quit IRC | 17:34 | |
*** dpawlik has quit IRC | 17:34 | |
*** tbachman has joined #openstack-nova | 17:37 | |
*** davidsha has quit IRC | 17:37 | |
sean-k-mooney | mdbooth: blueprints tend to be more for tracking then design if you want input you will want a spec or at least a etherpad + hangout if you have a quorum of people that are interested | 17:38 |
*** k_mouza has quit IRC | 17:38 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix InstanceNotFound during _destroy_evacuated_instances https://review.openstack.org/606122 | 17:44 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor TestEvacuateDeleteServerRestartOriginalCompute https://review.openstack.org/608705 | 17:44 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Always read-deleted=yes on lazy-load https://review.openstack.org/575190 | 17:44 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Run evacuate tests with local/lvm and shared/rbd storage https://review.openstack.org/604400 | 17:44 |
mriedem | dansmith: rebasearoo | 17:44 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Run against mriedem's evacuate test https://review.openstack.org/604423 | 17:45 |
openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: Re-propose numa-aware-live-migration spec https://review.openstack.org/599587 | 17:49 |
artom | mriedem, ^^ I think I got everything, when you have a moment | 17:49 |
mriedem | ok | 17:51 |
artom | (Oh and the docstring patch as well) | 17:52 |
artom | But that's not as important | 17:52 |
bauzas | mriedem: artom: I'll try to look at this spec tomorrow | 17:52 |
artom | woot | 17:52 |
artom | Cheers bauzas! | 17:53 |
*** imacdonn has quit IRC | 17:54 | |
bauzas | artom: before cheering me, wait for my comments :) | 17:55 |
*** imacdonn has joined #openstack-nova | 17:55 | |
artom | I have 100% confidence they'll be constructive and useful. | 17:55 |
artom | Why no, my nose isn't brown, whydja ask? ;) | 17:55 |
*** jmlowe has joined #openstack-nova | 18:05 | |
*** bnemec has quit IRC | 18:06 | |
*** bnemec has joined #openstack-nova | 18:06 | |
*** sridharg has quit IRC | 18:09 | |
*** moshele has quit IRC | 18:16 | |
*** gary_perkins has quit IRC | 18:17 | |
*** gary_perkins has joined #openstack-nova | 18:18 | |
*** burt has joined #openstack-nova | 18:18 | |
*** jangutter has quit IRC | 18:19 | |
*** Sundar has quit IRC | 18:21 | |
*** moshele has joined #openstack-nova | 18:23 | |
*** wolverineav has joined #openstack-nova | 18:24 | |
*** lpetrut has quit IRC | 18:33 | |
*** dpawlik has joined #openstack-nova | 18:37 | |
*** dpawlik has quit IRC | 18:42 | |
*** adrianc has joined #openstack-nova | 18:48 | |
*** tssurya has quit IRC | 18:50 | |
*** dpawlik has joined #openstack-nova | 18:53 | |
*** eharney has joined #openstack-nova | 18:54 | |
*** dpawlik has quit IRC | 18:57 | |
*** wolverin_ has joined #openstack-nova | 19:03 | |
*** wolverineav has quit IRC | 19:05 | |
mriedem | artom: dansmith: there you go https://review.openstack.org/#/c/599587/ | 19:06 |
*** ralonsoh has quit IRC | 19:07 | |
*** erlon has quit IRC | 19:17 | |
*** moshele has quit IRC | 19:24 | |
*** hughsaunders has joined #openstack-nova | 19:35 | |
*** dpawlik has joined #openstack-nova | 19:38 | |
artom | mriedem, thank you! | 19:40 |
*** wolverin_ has quit IRC | 19:41 | |
mriedem | belmoreira: hey, remember talking in berlin about a problem where if you have a lot of disabled computes for an upgrade, but with max_placement_results set low, you could get novalidhost because placement returns all disabled computes? you were going to open a bug for that but i never saw one. | 19:41 |
*** wolverineav has joined #openstack-nova | 19:41 | |
*** wolverineav has quit IRC | 19:42 | |
mriedem | i remember dansmith and i kicked around some ideas about that in berlin, but my memory is getting hazy | 19:42 |
*** wolverineav has joined #openstack-nova | 19:42 | |
mriedem | need another core on this concurrent i/o disk semaphore thing in runways https://review.openstack.org/#/c/609180/ | 19:45 |
mriedem | it's pretty simple | 19:45 |
*** jmlowe has quit IRC | 19:48 | |
*** jmlowe has joined #openstack-nova | 19:50 | |
*** wolverineav has quit IRC | 19:53 | |
*** adrianc has quit IRC | 19:59 | |
*** _hemna has quit IRC | 20:04 | |
*** Sundar has joined #openstack-nova | 20:08 | |
*** lennyb_ has joined #openstack-nova | 20:17 | |
*** lennyb has quit IRC | 20:20 | |
cdent | Are hooks still a thing that are being used in nova, or is it more that they haven't been cleared away yet? | 20:21 |
*** awaugama has quit IRC | 20:21 | |
mriedem | don't build on them if you can help it | 20:22 |
mriedem | rely on notifications if possible | 20:22 |
mriedem | hooks are use at your own risk (we can break them and not care to fix them), and the last time someone complained about the interface breaking on one of the hooks, upstream got real serious about just yanking them | 20:23 |
mriedem | kind of one of those squeeky wheel kinds of things - best not to talk about it | 20:23 |
cdent | yeah, I was wondering if the yanking was still an option | 20:23 |
mriedem | if we had a good reason to | 20:24 |
cdent | because the race I'm watching just showed up with a trace from one of them, but it appears it is more likely a coincidence | 20:24 |
mriedem | and someone that cared enough | 20:24 |
*** wolverineav has joined #openstack-nova | 20:24 | |
* cdent would like to care but already cares too much | 20:25 | |
cdent | my running theory at this point is a totally unsurprising "it's probably eventlet" | 20:25 |
mriedem | no one was ever fired for blaming eventlet | 20:28 |
mriedem | GET /jaypipes | 20:32 |
mriedem | https://review.openstack.org/#/c/603352/7 | 20:32 |
*** wolverineav has quit IRC | 20:33 | |
*** wolverineav has joined #openstack-nova | 20:34 | |
mriedem | i imagine jay is fighting with code using hooks within oath | 20:36 |
mriedem | hooks that call off to some chef thing | 20:36 |
*** imacdonn has quit IRC | 20:37 | |
*** imacdonn has joined #openstack-nova | 20:37 | |
*** slaweq_ has joined #openstack-nova | 20:44 | |
*** eharney has quit IRC | 20:45 | |
*** jmlowe has quit IRC | 20:45 | |
openstackgerrit | Eric Fried proposed openstack/nova master: SIGHUP n-cpu to clear provider tree cache https://review.openstack.org/615646 | 20:49 |
openstackgerrit | Eric Fried proposed openstack/nova master: Reduce calls to placement from _ensure https://review.openstack.org/615677 | 20:49 |
openstackgerrit | Eric Fried proposed openstack/nova master: Consolidate inventory refresh https://review.openstack.org/615695 | 20:49 |
openstackgerrit | Eric Fried proposed openstack/nova master: Commonize _update code path https://review.openstack.org/615705 | 20:49 |
openstackgerrit | Eric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient https://review.openstack.org/617042 | 20:49 |
openstackgerrit | Eric Fried proposed openstack/nova master: Rip out the SchedulerClient https://review.openstack.org/617049 | 20:49 |
efried | blayum | 20:49 |
cdent | huzzah | 20:50 |
artom | So eventlets are the reverse IBM? No one got fired for either buying IBM, or blaming eventlets? | 20:54 |
mriedem | that was the joke yes | 20:59 |
* artom looks up to see it flying high above :( | 21:01 | |
tbachman | <delayed boom-splash> | 21:02 |
*** slaweq_ has quit IRC | 21:03 | |
*** flwang has joined #openstack-nova | 21:03 | |
flwang | could anybody please help me understand that if i can swift from v2 endpoint to v2.1 endpoint directly? | 21:07 |
flwang | 'directly' means change the endpoint url in keystone catalyst directly, thanks a lot | 21:07 |
mriedem | flwang: https://docs.openstack.org/nova/latest/reference/stable-api.html and https://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/api-relax-validation.html might help, but i think you also have to do something with the api-paste.ini | 21:11 |
mriedem | since that is config, it will require a change on upgrade to use v2.1 | 21:11 |
mriedem | i'm thinking about this from liberty https://github.com/openstack/nova/commit/4a18f7d3bafcdbede48500aac389e0a770b8e6a8#diff-c29e518f0f69a48dc80705f43cf9a3b4 | 21:13 |
flwang | mriedem: thanks for reply, we have enabled it based on my testing, the v2.1 endpoint works | 21:14 |
flwang | but i'm not sure how can we migrate the catalyst in keystone | 21:14 |
flwang | catalog | 21:14 |
mriedem | you can't just make the compute endpoint point at v2.1 rather than v2? | 21:15 |
flwang | because when you initialize a nova client, the code will talk to keystone catalog to get the endpoint | 21:16 |
flwang | and currently, we're using /v2/ in the endpint | 21:17 |
flwang | not v1 | 21:17 |
flwang | for example, for horizon | 21:17 |
flwang | it's doing that | 21:17 |
*** swamireddy has joined #openstack-nova | 21:17 | |
*** swamireddy has quit IRC | 21:17 | |
*** swamireddy has joined #openstack-nova | 21:17 | |
flwang | and as a result, there are some features we can't enable without upgrading the endpint | 21:17 |
flwang | mriedem: i just checked, we have done the correct work for nova (api-paste.ini) | 21:20 |
*** imacdonn has quit IRC | 21:20 | |
flwang | and as I mentioned above, the endpoint is working correctly. im just not sure if we can change the keystone catalog now | 21:21 |
mriedem | the client just asks for the compute endpoint, right? which is an alias to some URL | 21:21 |
*** ivve has quit IRC | 21:21 | |
mriedem | the client shouldn't care if it's v1 or v2 or v2.1 really unless they have version-specific requests | 21:21 |
flwang | mriedem: yes, that's my understanding | 21:23 |
flwang | i think, as admin, it should be safe to switch the endpoint, but just wanna get more ideas at here | 21:23 |
*** imacdonn has joined #openstack-nova | 21:24 | |
*** _hemna has joined #openstack-nova | 21:24 | |
mriedem | well it's been awhile since i've talked to any operators that went through this and the old kilo/liberty release notes are pretty sparse, | 21:25 |
mriedem | but the api-paste.ini was the big thing i knew of that hit people, like when oath upgraded, | 21:25 |
mriedem | but jpenick is out, and jaypipes insn't here | 21:25 |
mriedem | *isn't | 21:25 |
mriedem | jroll: were you around for the oath upgrade to ocata? | 21:25 |
mriedem | and compute api v2.1? | 21:25 |
mriedem | flwang: otherwise #openstack-operators is probably best | 21:26 |
Sundar | cdent: Please ping me when you have the time. Thanks. | 21:27 |
*** skatsaounis has quit IRC | 21:28 | |
*** eharney has joined #openstack-nova | 21:28 | |
flwang | mriedem: got it, thank you so much | 21:28 |
cdent | Sundar: I'll try, but currently very busy. If it's something for which email will work: cdent@anticdent.org | 21:29 |
*** wolverineav has quit IRC | 21:32 | |
*** jmlowe has joined #openstack-nova | 21:32 | |
*** wolverineav has joined #openstack-nova | 21:34 | |
*** xek_ has quit IRC | 21:35 | |
*** wolverineav has quit IRC | 21:38 | |
*** wolverineav has joined #openstack-nova | 21:38 | |
*** pcaruana has quit IRC | 21:46 | |
*** priteau has quit IRC | 21:47 | |
*** dpawlik has quit IRC | 21:54 | |
*** dpawlik has joined #openstack-nova | 21:55 | |
*** dpawlik has quit IRC | 22:00 | |
*** slaweq has quit IRC | 22:03 | |
*** slaweq has joined #openstack-nova | 22:19 | |
*** slaweq has quit IRC | 22:24 | |
*** wolverineav has quit IRC | 22:36 | |
*** wolverineav has joined #openstack-nova | 22:37 | |
*** wolverineav has quit IRC | 22:39 | |
*** wolverin_ has joined #openstack-nova | 22:39 | |
*** munimeha1 has quit IRC | 22:45 | |
*** wolverin_ has quit IRC | 22:49 | |
*** wolverineav has joined #openstack-nova | 22:50 | |
*** swamireddy has quit IRC | 22:50 | |
*** eharney has quit IRC | 22:54 | |
*** priteau has joined #openstack-nova | 22:54 | |
*** rcernin has joined #openstack-nova | 22:57 | |
*** priteau has quit IRC | 22:58 | |
*** wolverineav has quit IRC | 22:59 | |
*** wolverineav has joined #openstack-nova | 23:02 | |
*** wolverin_ has joined #openstack-nova | 23:12 | |
*** wolverin_ has quit IRC | 23:15 | |
*** wolverin_ has joined #openstack-nova | 23:15 | |
*** wolverineav has quit IRC | 23:15 | |
*** Sundar has quit IRC | 23:16 | |
*** slaweq has joined #openstack-nova | 23:29 | |
*** slaweq has quit IRC | 23:33 | |
*** mriedem has quit IRC | 23:46 | |
*** jhesketh_ is now known as jhesketh | 23:51 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!