| openstackgerrit | Merged openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733 | 00:05 |
|---|---|---|
| openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | 00:05 |
| *** jaosorior has quit IRC | 00:05 | |
| *** hoonetorg has quit IRC | 00:09 | |
| *** tetsuro has joined #openstack-nova | 00:11 | |
| *** hoonetorg has joined #openstack-nova | 00:22 | |
| *** erlon has joined #openstack-nova | 00:32 | |
| *** mlavalle has quit IRC | 00:37 | |
| *** k_mouza has joined #openstack-nova | 00:42 | |
| *** brinzhang has joined #openstack-nova | 00:43 | |
| *** sean-k-mooney has quit IRC | 00:44 | |
| *** bhagyashris has joined #openstack-nova | 00:56 | |
| *** sean-k-mooney has joined #openstack-nova | 00:58 | |
| *** wolverin_ has quit IRC | 00:59 | |
| *** wolverineav has joined #openstack-nova | 01:00 | |
| *** wolverineav has quit IRC | 01:02 | |
| *** wolverineav has joined #openstack-nova | 01:02 | |
| *** amab has quit IRC | 01:04 | |
| *** k_mouza has quit IRC | 01:06 | |
| *** k_mouza has joined #openstack-nova | 01:09 | |
| *** annp has joined #openstack-nova | 01:14 | |
| *** k_mouza has quit IRC | 01:28 | |
| *** erlon has quit IRC | 01:54 | |
| *** cfriesen has quit IRC | 02:00 | |
| *** mschuppert has quit IRC | 02:25 | |
| *** mrsoul has quit IRC | 02:25 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:33 | |
| *** hongbin has joined #openstack-nova | 02:36 | |
| *** psachin has joined #openstack-nova | 02:41 | |
| *** mhen has quit IRC | 02:42 | |
| *** mhen has joined #openstack-nova | 02:45 | |
| *** ileixe has joined #openstack-nova | 03:03 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | 03:11 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215 | 03:11 |
| *** wolverineav has quit IRC | 03:12 | |
| *** wolverineav has joined #openstack-nova | 03:17 | |
| *** wolverineav has quit IRC | 03:24 | |
| *** cdent has quit IRC | 03:28 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove Placement API reference https://review.openstack.org/614437 | 03:38 |
| *** diga has joined #openstack-nova | 03:47 | |
| *** wolverineav has joined #openstack-nova | 03:53 | |
| *** wolverineav has quit IRC | 03:59 | |
| *** hoangcx has joined #openstack-nova | 04:11 | |
| *** hongbin_ has joined #openstack-nova | 04:23 | |
| *** hongbin has quit IRC | 04:24 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: Testing nova gate on Bionic (Ubuntu LTS 18.04) https://review.openstack.org/620454 | 04:36 |
| *** hongbin has joined #openstack-nova | 04:37 | |
| *** hongbin_ has quit IRC | 04:38 | |
| *** hongbin has quit IRC | 04:40 | |
| *** artom has quit IRC | 04:42 | |
| *** artom has joined #openstack-nova | 04:46 | |
| *** janki has joined #openstack-nova | 04:48 | |
| *** diga has quit IRC | 04:49 | |
| *** lpetrut has joined #openstack-nova | 04:51 | |
| *** udesale has joined #openstack-nova | 04:54 | |
| *** pcaruana has joined #openstack-nova | 05:09 | |
| *** sridharg has joined #openstack-nova | 05:26 | |
| *** lpetrut has quit IRC | 05:28 | |
| *** imacdonn has quit IRC | 05:30 | |
| *** imacdonn has joined #openstack-nova | 05:30 | |
| *** k_mouza has joined #openstack-nova | 05:36 | |
| *** imacdonn has quit IRC | 05:38 | |
| *** imacdonn has joined #openstack-nova | 05:38 | |
| *** k_mouza has quit IRC | 05:40 | |
| *** brinzhang has quit IRC | 05:45 | |
| *** cfriesen has joined #openstack-nova | 05:45 | |
| *** brinzhang has joined #openstack-nova | 05:46 | |
| *** ratailor has joined #openstack-nova | 06:00 | |
| gmann | nova api office hour | 06:00 |
| gmann | #startmeeting nova api | 06:00 |
| openstack | Meeting started Wed Nov 28 06:00:33 2018 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot. | 06:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 06:00 |
| *** openstack changes topic to " (Meeting topic: nova api)" | 06:00 | |
| openstack | The meeting name has been set to 'nova_api' | 06:00 |
| *** ileixe has quit IRC | 06:00 | |
| gmann | PING List: gmann, alex_xu | 06:00 |
| gmann | who all here today | 06:00 |
| gmann | we are starting office hour after long time... | 06:01 |
| *** ileixe has joined #openstack-nova | 06:01 | |
| gmann | seems alex_xu not here. i will do some bug triage during this office hour. | 06:04 |
| gmann | some update- i have updated the subteam tracking etherpad with latest updates - Section API- https://etherpad.openstack.org/p/stein-nova-subteam-tracking | 06:05 |
| *** gyee has quit IRC | 06:20 | |
| *** moshele has joined #openstack-nova | 06:21 | |
| *** moshele has quit IRC | 06:26 | |
| *** jarodwl has joined #openstack-nova | 06:35 | |
| *** jaosorior has joined #openstack-nova | 06:36 | |
| *** ileixe has quit IRC | 06:41 | |
| *** ileixe has joined #openstack-nova | 06:41 | |
| *** udesale has quit IRC | 06:43 | |
| *** udesale has joined #openstack-nova | 06:44 | |
| openstackgerrit | jichenjc proposed openstack/nova master: Validate security group in API layer https://review.openstack.org/620473 | 06:45 |
| *** udesale has quit IRC | 06:45 | |
| *** udesale has joined #openstack-nova | 06:46 | |
| *** psachin has quit IRC | 06:47 | |
| *** brinzh has joined #openstack-nova | 06:52 | |
| *** brinzhang has quit IRC | 06:56 | |
| gmann | did 2 bug triage and 3rd in progress. will send the updates on ML. ending the office hour | 06:56 |
| gmann | #endmeeting | 06:56 |
| *** openstack changes topic to "Current runways: io-semaphore-for-concurrent-disk-ops / reshape-provider-tree / initial-allocation-ratios -- This channel is for Nova development. For support of Nova deployments, please use #openstack." | 06:56 | |
| openstack | Meeting ended Wed Nov 28 06:56:38 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 06:56 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-11-28-06.00.html | 06:56 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-11-28-06.00.txt | 06:56 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/nova_api/2018/nova_api.2018-11-28-06.00.log.html | 06:56 |
| *** udesale has quit IRC | 06:57 | |
| *** rcernin has quit IRC | 06:57 | |
| *** Luzi has joined #openstack-nova | 07:00 | |
| *** wolverineav has joined #openstack-nova | 07:01 | |
| *** slaweq has joined #openstack-nova | 07:04 | |
| *** wolverineav has quit IRC | 07:06 | |
| *** dpawlik has joined #openstack-nova | 07:16 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Per-instance serial number https://review.openstack.org/619953 | 07:17 |
| *** dpawlik has quit IRC | 07:20 | |
| *** cfriesen has quit IRC | 07:22 | |
| *** dpawlik has joined #openstack-nova | 07:24 | |
| *** adrianc has joined #openstack-nova | 07:30 | |
| *** adrianc has quit IRC | 07:32 | |
| *** adrianc has joined #openstack-nova | 07:33 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | 07:40 |
| openstackgerrit | Vieri proposed openstack/python-novaclient master: add python 3.6 unit test job https://review.openstack.org/620509 | 07:41 |
| *** alex_xu has quit IRC | 07:50 | |
| *** udesale has joined #openstack-nova | 07:53 | |
| *** alex_xu has joined #openstack-nova | 07:55 | |
| kashyap | artom: Thanks for the review. | 07:58 |
| *** udesale has quit IRC | 07:58 | |
| alex_xu | gmann: from this https://docs.openstack.org/nova/rocky/user/block-device-mapping.html#block-device-mapping-v2, we don't have deleted_on_termination param for bdmv2. Also we don't have that param for bdmv2 in nova cli. but I can pass that param by the API directly, does it support from the beginning or we leak something? | 07:59 |
| kashyap | alex_xu: Hi, when you get a moment, mind having a look at this: https://review.openstack.org/#/c/620327 | 08:02 |
| alex_xu | kashyap: got it, will try | 08:04 |
| gmann | alex_xu: humm, checking | 08:04 |
| kashyap | alex_xu: Thanks | 08:04 |
| *** skatsaounis has joined #openstack-nova | 08:04 | |
| alex_xu | kashyap: np | 08:05 |
| alex_xu | gmann: thanks | 08:06 |
| alex_xu | gmann: actually, I'm reviewing this spec https://review.openstack.org/#/c/580336 | 08:07 |
| *** sahid has joined #openstack-nova | 08:07 | |
| gmann | alex_xu: delete_on_termination is bdmv1 attribute which is allowed for bdmv2 also | 08:09 |
| gmann | alex_xu: you can see that in doc you mentioned also under Block device mapping v1 (aka legacy)ΒΆ section | 08:09 |
| *** udesale has joined #openstack-nova | 08:11 | |
| alex_xu | gmann: so v2 inhertis all the attributes from v1, right? | 08:14 |
| gmann | alex_xu: yeah, https://github.com/openstack/nova/blob/62245235bc15da6abcdfd3df1c24bd856d69fbb4/nova/api/openstack/compute/schemas/servers.py#L90 | 08:15 |
| alex_xu | gmann: it is strange that we don't have delete_on_termination on the CLI | 08:18 |
| gmann | alex_xu: humm it is error ? | 08:18 |
| alex_xu | gmann: i don't know | 08:19 |
| *** jangutter has joined #openstack-nova | 08:21 | |
| *** xek_ has joined #openstack-nova | 08:22 | |
| gmann | alex_xu: i can see it is supported in CLI - https://github.com/openstack/python-novaclient/blob/58b3ac457aa817da28c757b4845bc39e565139dd/novaclient/v2/shell.py#L138 | 08:24 |
| *** ralonsoh has joined #openstack-nova | 08:33 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Change the default values of XXX_allocation_ratio https://review.openstack.org/602803 | 08:36 |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804 | 08:36 |
| *** tssurya has joined #openstack-nova | 08:41 | |
| *** sridharg has quit IRC | 08:57 | |
| *** tetsuro has quit IRC | 09:03 | |
| *** sridharg has joined #openstack-nova | 09:10 | |
| *** owalsh_ is now known as owalsh | 09:12 | |
| *** k_mouza has joined #openstack-nova | 09:13 | |
| *** eandersson has quit IRC | 09:13 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969 | 09:22 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969 | 09:23 |
| *** whoami-rajat has joined #openstack-nova | 09:28 | |
| *** bhagyashris has quit IRC | 09:45 | |
| *** ttsiouts has joined #openstack-nova | 09:59 | |
| *** ttsiouts has quit IRC | 10:02 | |
| *** ttsiouts has joined #openstack-nova | 10:03 | |
| *** ttsiouts has quit IRC | 10:03 | |
| *** ttsiouts has joined #openstack-nova | 10:03 | |
| *** ttsiouts has quit IRC | 10:06 | |
| *** ttsiouts has joined #openstack-nova | 10:07 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804 | 10:09 |
| *** tobias-urdin has quit IRC | 10:10 | |
| *** artom has quit IRC | 10:11 | |
| *** cdent has joined #openstack-nova | 10:11 | |
| *** ttsiouts has quit IRC | 10:12 | |
| *** derekh has joined #openstack-nova | 10:12 | |
| *** ttsiouts has joined #openstack-nova | 10:13 | |
| *** ttsiouts has quit IRC | 10:14 | |
| *** ttsiouts has joined #openstack-nova | 10:15 | |
| *** tobias-urdin has joined #openstack-nova | 10:15 | |
| *** k_mouza has quit IRC | 10:18 | |
| *** ttsiouts has quit IRC | 10:18 | |
| *** k_mouza has joined #openstack-nova | 10:18 | |
| *** ttsiouts has joined #openstack-nova | 10:19 | |
| *** ttsiouts has quit IRC | 10:21 | |
| *** ttsiouts has joined #openstack-nova | 10:22 | |
| *** k_mouza has quit IRC | 10:22 | |
| *** ttsiouts has quit IRC | 10:22 | |
| *** erlon has joined #openstack-nova | 10:29 | |
| *** noonedeadpunk has joined #openstack-nova | 10:31 | |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Add ratio online data migration when load compute node https://review.openstack.org/613499 | 10:33 |
| openstackgerrit | Yikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration script https://review.openstack.org/609995 | 10:33 |
| *** jarodwl has quit IRC | 10:33 | |
| *** jarodwl has joined #openstack-nova | 10:34 | |
| *** jistr is now known as jistr|mtg | 10:34 | |
| noonedeadpunk | Hi everyone. | 10:36 |
| *** wolverineav has joined #openstack-nova | 10:37 | |
| *** k_mouza has joined #openstack-nova | 10:38 | |
| noonedeadpunk | I've faced with a problem (not sure if it's a bug or not), when nova in Q generates config, which is not compatible with libvirt 4 (which is a default for ubuntu). So VM creation results in error "'serial' is deprecated, please use the corresponding option of '-device' instead" | 10:39 |
| *** k_mouza has quit IRC | 10:41 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | 10:41 |
| *** adrianc has quit IRC | 10:41 | |
| *** k_mouza has joined #openstack-nova | 10:42 | |
| *** wolverineav has quit IRC | 10:42 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Delete the placement code https://review.openstack.org/618215 | 10:42 |
| *** davidsha has joined #openstack-nova | 10:48 | |
| *** skatsaounis has left #openstack-nova | 10:48 | |
| *** ygk_12345 has joined #openstack-nova | 10:58 | |
| *** adrianc has joined #openstack-nova | 11:05 | |
| *** ttsiouts has joined #openstack-nova | 11:13 | |
| *** ttsiouts has quit IRC | 11:18 | |
| *** ygk_12345 has quit IRC | 11:18 | |
| *** chason has quit IRC | 11:31 | |
| openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot https://review.openstack.org/580336 | 11:33 |
| *** chason has joined #openstack-nova | 11:36 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/rocky: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620571 | 11:39 |
| *** Dinesh_Bhor has quit IRC | 11:42 | |
| *** dave-mccowan has joined #openstack-nova | 11:44 | |
| *** tbachman has quit IRC | 11:45 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/queens: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620578 | 11:47 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/pike: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620579 | 11:53 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/rocky: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620571 | 12:01 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/pike: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620579 | 12:02 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/queens: Migrate nova v2.0 legacy job to zuulv3 https://review.openstack.org/620578 | 12:02 |
| *** moshele has joined #openstack-nova | 12:06 | |
| *** ttsiouts has joined #openstack-nova | 12:11 | |
| *** ttsiouts has quit IRC | 12:12 | |
| *** ttsiouts has joined #openstack-nova | 12:13 | |
| *** sridharg has quit IRC | 12:14 | |
| *** sridharg has joined #openstack-nova | 12:14 | |
| *** ttsiouts has quit IRC | 12:17 | |
| *** janki has quit IRC | 12:20 | |
| *** sridharg has quit IRC | 12:24 | |
| *** ratailor has quit IRC | 12:26 | |
| *** artom has joined #openstack-nova | 12:29 | |
| *** jaypipes has joined #openstack-nova | 12:31 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/pike: DNM: For testing only https://review.openstack.org/620592 | 12:32 |
| *** brinzh has quit IRC | 12:34 | |
| *** takamatsu has quit IRC | 12:37 | |
| *** ttsiouts has joined #openstack-nova | 12:38 | |
| *** takamatsu has joined #openstack-nova | 12:43 | |
| jroll | flwang: at oath we eventually changed the catalog, it was fine | 12:49 |
| *** beagles is now known as beagles_mtgs | 12:55 | |
| *** ttsiouts has quit IRC | 12:56 | |
| *** moshele has quit IRC | 12:56 | |
| *** ttsiouts has joined #openstack-nova | 12:56 | |
| *** k_mouza has quit IRC | 13:02 | |
| *** artom has quit IRC | 13:03 | |
| *** ttsiouts has quit IRC | 13:12 | |
| *** munimeha1 has joined #openstack-nova | 13:13 | |
| *** ttsiouts has joined #openstack-nova | 13:13 | |
| *** artom has joined #openstack-nova | 13:16 | |
| *** ttsiouts has quit IRC | 13:18 | |
| *** munimeha1 has quit IRC | 13:19 | |
| *** jistr|mtg is now known as jistr | 13:21 | |
| *** k_mouza has joined #openstack-nova | 13:28 | |
| *** takamatsu has quit IRC | 13:29 | |
| *** takamatsu has joined #openstack-nova | 13:30 | |
| *** tbachman has joined #openstack-nova | 13:33 | |
| *** ttsiouts has joined #openstack-nova | 13:33 | |
| *** moshele has joined #openstack-nova | 13:37 | |
| *** diga has joined #openstack-nova | 13:42 | |
| *** Dinesh_Bhor has joined #openstack-nova | 13:43 | |
| *** takamatsu has quit IRC | 13:44 | |
| *** takamatsu has joined #openstack-nova | 13:48 | |
| *** jarodwl has quit IRC | 13:49 | |
| *** jarodwl has joined #openstack-nova | 13:50 | |
| *** janki has joined #openstack-nova | 13:55 | |
| *** eharney has joined #openstack-nova | 13:56 | |
| *** diga has quit IRC | 13:56 | |
| *** moshele has quit IRC | 14:04 | |
| *** ttsiouts has quit IRC | 14:08 | |
| *** ttsiouts has joined #openstack-nova | 14:09 | |
| *** Dinesh_Bhor has quit IRC | 14:10 | |
| *** janki has quit IRC | 14:11 | |
| *** ttsiouts_ has joined #openstack-nova | 14:11 | |
| *** janki has joined #openstack-nova | 14:12 | |
| *** ttsiouts has quit IRC | 14:13 | |
| *** wolverineav has joined #openstack-nova | 14:14 | |
| *** wolverineav has quit IRC | 14:19 | |
| *** mriedem has joined #openstack-nova | 14:23 | |
| *** ttsiouts_ has quit IRC | 14:23 | |
| *** ttsiouts has joined #openstack-nova | 14:24 | |
| *** udesale has quit IRC | 14:24 | |
| *** udesale has joined #openstack-nova | 14:25 | |
| *** adrianc has quit IRC | 14:27 | |
| *** ttsiouts has quit IRC | 14:28 | |
| mriedem | couple of easy patches here that need another core https://review.openstack.org/#/c/620165/ https://review.openstack.org/#/c/620170/ | 14:34 |
| *** ttsiouts has joined #openstack-nova | 14:39 | |
| gmann | mriedem: melwitt nova-next job does not run in queens but seems like it supposed to run there - https://github.com/openstack/nova/blob/master/.zuul.yaml#L140 | 14:42 |
| gmann | reason is- job migration patch got merged in rocky - https://review.openstack.org/#/c/541474/ | 14:42 |
| gmann | and it was mistakenly added in stable/queens check and gate pipeline list here - https://review.openstack.org/#/c/604134/ | 14:43 |
| gmann | nova-next job definition is not present in stable/queens but listed in check and gate pipeline. | 14:43 |
| *** dklyle has quit IRC | 14:47 | |
| gmann | to run it on queens, we need to backport these 2 in queens - https://review.openstack.org/#/c/541474/ https://review.openstack.org/#/c/513160/ | 14:47 |
| *** Sundar has joined #openstack-nova | 14:49 | |
| *** sridharg has joined #openstack-nova | 14:49 | |
| Sundar | efried: Please ping me when you have the time. | 14:50 |
| efried | Sundar: I'm here. What's up? | 14:50 |
| *** jackding has joined #openstack-nova | 14:51 | |
| Sundar | efried: Are you aligned with the decision to drop os-acc? I am trying to make sure we have a quorum of Nova developers. | 14:52 |
| *** adrianc has joined #openstack-nova | 14:53 | |
| gmann | stephenfin: what is use of bug-tag in openstackdocstheme? - https://review.openstack.org/#/c/619434/2 | 14:53 |
| gmann | i did not find where it was linked on doc/buglink | 14:54 |
| artom | gmann, he's on PTO | 14:54 |
| gmann | artom: ohk. thanks. added him in review. | 14:54 |
| Sundar | jaypipes: Please let me know when you have some time to follow up from last week. | 14:55 |
| jaypipes | Sundar: I am here. | 14:57 |
| Sundar | jaypipes: I am trying to reconcile your views with what everybody else is saying. You wanted to see os-acc as a small library that works by itself. Whereas others don;t see a need for os-acc at all :) #link http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-11-20.log.html#t2018-11-20T17:47:21 | 14:58 |
| jaypipes | Sundar: correct. | 15:00 |
| *** cfriesen has joined #openstack-nova | 15:00 | |
| Sundar | jaypipes: Could I understand your motivation? Nova virt drivers will do the actual attachment for accelerators, as with networking. All device-specific actions should be in Cyborg. | 15:00 |
| Sundar | DO you agree? | 15:00 |
| efried | Sundar: It seems reasonable, if nova only needs to talk to the cyborg API, to nix os-acc. | 15:00 |
| jaypipes | Sundar: I was under the impression os-acc would function similarly to os-vif, where os-vif provides the data models that are used to understand what and how network interfaces are brought up on the host. | 15:01 |
| efried | Sundar: My impression of os-acc was that it would be the clearinghouse for platform- and virt-specific plugins to do discovery and attachment. | 15:01 |
| efried | yeah, what jaypipes said. | 15:01 |
| Sundar | jaypipes: Yes, that's how we started. As the discussion progressed, and the spec was reviewed, it became clear that most of the work would be done by Cyborg APIs. | 15:02 |
| jaypipes | Sundar: which I completely disagree with. | 15:02 |
| jaypipes | Sundar: I have continued to maintain I see very little use in a Cyborg REST API at the moment. | 15:02 |
| mriedem | gmann: yes https://review.openstack.org/#/c/604134/1/.zuul.yaml is a bad backport | 15:03 |
| jaypipes | Sundar: let me tell you why. | 15:03 |
| mriedem | gmann: the commit message in https://review.openstack.org/#/c/541474/ sounds like we don't need it in queens | 15:04 |
| mriedem | the queens comment in https://github.com/openstack/nova/blob/master/.zuul.yaml#L140 might be wrong | 15:04 |
| jaypipes | Sundar: focusing on the REST API in Cyborg right now means you are constrained by versioning in a way that just focusing on iterating a workable object/data model would not constrain you. | 15:04 |
| Sundar | jaypipes: Without Cyborg APIs, how would one initiate device configuration, whether it is for a GPU, FPGA, ...? | 15:04 |
| mriedem | gmann: https://review.openstack.org/#/c/396186/ isn't in queens | 15:04 |
| jaypipes | Sundar: IMHO, a REST API is just a giant distraction right now for Cyborg. | 15:04 |
| efried | jaypipes: The way I see it, we need a way to follow the thread of an ARQ from [set of resources and traits] to [actual accelerator instance plugged into a VM]. | 15:05 |
| jaypipes | Sundar: what does Cyborg do "under the covers" in its drivers? | 15:05 |
| jaypipes | Sundar: *that* is what I think os-acc should be doing. | 15:05 |
| dansmith | bauzas: gonna circle back on https://review.openstack.org/#/c/599587 right? | 15:06 |
| efried | jaypipes: Nova is going to be driving that workflow, but cyborg needs to be the one to make some of those transitions (like, "I landed on a host; pick me a specific device and configure it") and needs to be made aware of the ones Nova makes (like, "I plugged accelerator X into VM Y"). | 15:06 |
| gmann | mriedem: ok. then we can remove the nova-next from queen pipeline list also + that job comment fix. i observed it while backporting the nova v2 job. | 15:06 |
| Sundar | jaypipes: Are you saying that os-acc should have its own device-specific drivers and run the show by itself? Or that it should call into Cyborg drivers, without involving any REST API? | 15:06 |
| bauzas | dansmith: yup, I'm just reviewing it | 15:06 |
| *** mlavalle has joined #openstack-nova | 15:06 | |
| efried | jaypipes: *some* kind of API seems like the appropriate way to do that. | 15:06 |
| dansmith | bauzas: awesome, thanks | 15:06 |
| jaypipes | Sundar: that is correct. | 15:06 |
| mriedem | gmann: yeah it's either that or backport the devstack and nova change | 15:07 |
| jaypipes | Sundar: I've said a number of times that I wish Cyborg would just accept that Nova is its sole consumer right now, stop working on some "stand-alone Cyborg" thing and just function like a Nova virt driver for right now. That way, you can iterate more quickly, actually get something that works (as opposed to just abstract, non-working things) and go from ther | 15:07 |
| *** sridharg has quit IRC | 15:07 | |
| gmann | mriedem: i can give backport try also if you think it is worth to run on queens. | 15:08 |
| *** sridharg has joined #openstack-nova | 15:08 | |
| mriedem | gmann: i backported the devstack change, you can backport https://review.openstack.org/#/c/513160/ if you want | 15:09 |
| mriedem | it has merge conflicts | 15:09 |
| mriedem | i'm guessing the nova-next/devstack testing just missed the queens GA | 15:09 |
| mriedem | but the feature itself is in nova in queens | 15:09 |
| mriedem | so it would probably be good to test it... | 15:09 |
| Sundar | jaypipes: There are are several use cases for accelerators without direct Nova involvement. For example, we may want to set up OVS offload in an accelerator in a host, but that doesn't involve assigning to a VM. | 15:09 |
| jaypipes | Sundar: there might be, yes. I' | 15:10 |
| jaypipes | m saying I don't care about those use cases and I feel they are a giant distraction from getting anything working in Nova/Cyborg at the moment. | 15:10 |
| gmann | mriedem: +1. will do tomorrow. | 15:11 |
| mriedem | gmann: thanks | 15:11 |
| sean-k-mooney | Sundar: "use cases for accelerators without direct Nova involvement" are by definition out side the scope of the nova/cyborge interaction sepc | 15:11 |
| efried | jaypipes: Are you suggesting maintaining ARQ data in nova databases and manipulating them via OVOs within the nova code? | 15:11 |
| jaypipes | Sundar: let me put this in the most direct way possible... I do not think it's appropriate to call a REST API to set up a local device on a host. | 15:12 |
| mriedem | sounds like you want a thing that's like PlacementDirect | 15:12 |
| mriedem | API interface is the same, but it doesn't go over http | 15:13 |
| Sundar | jaypipes: As efried said above, manipulating devices from a virt driver means the device data is in Nova db. Is that what you are advocating? | 15:13 |
| Sundar | sean-k-mooney: We were talking about stand-alone Cyborg | 15:14 |
| jaypipes | Sundar: I would rather just get the small amount of code that is Cyborg's accelerators/drivers/ module (https://github.com/openstack/cyborg/blob/master/cyborg/accelerator/drivers/fpga/intel/driver.py), pull it into some library called "os-acc" and call it directly. | 15:15 |
| *** dpawlik has quit IRC | 15:16 | |
| jaypipes | Sundar: especially since it's basically just shelling out to some unknown /usr/bin/fpgaconf program which I assume is some Intel-specific binary | 15:16 |
| jaypipes | Sundar: which is essentially what os-vif is, BTW... it just shells out to Linux binaries like "ip" or "ovsctl" etc. | 15:17 |
| jaypipes | Sundar: which is why I say I'd like an os-vif for accelerators... | 15:18 |
| *** mgariepy has quit IRC | 15:18 | |
| *** mgariepy has joined #openstack-nova | 15:19 | |
| Sundar | jaypipes: That means all the PCI details (#PFs, #VFs, etc.) and other data for programming devices etc. are all in Nova db. | 15:21 |
| *** ivve has joined #openstack-nova | 15:21 | |
| jaypipes | Sundar: which is exactly where they already are. | 15:21 |
| jaypipes | Sundar: because Nova is the thing that owns compute node resources. | 15:21 |
| efried | jaypipes: Please tell me you're not suggesting using/augmenting the existing database schemata | 15:22 |
| Sundar | jaypipes: I thought there was a desire to pull all that complexity into a separate project. What do you see as the role for Cyborg in your model? | 15:23 |
| sean-k-mooney | efried: that is a diffent topic | 15:23 |
| sean-k-mooney | you could be we can do better | 15:23 |
| efried | sean-k-mooney: It is exactly the topic. | 15:23 |
| jaypipes | Sundar: on a sidenote, could you tell me where I can find the source code for fpgaconf? I can't seem to locate it.. | 15:23 |
| jaypipes | efried: no, I'm not. I'm just saying that's where we *already* store this information. | 15:24 |
| efried | sean-k-mooney: We know we want the existing pci subsystem to diaf. Trying to retrofit it for cyborg purposes will just make it live on, like something from Walking Dead. | 15:24 |
| sean-k-mooney | efried: you can passthough gpugs and fpgas with nova pci pathough today | 15:24 |
| sean-k-mooney | efried: we just cant program fpgas | 15:24 |
| efried | Also, we know we want to separate eventually, so the tighter the integration with nova databases, the more painful that will be. | 15:25 |
| artom | sean-k-mooney, yo, check downstream IRC, I'd like to skip our meeting since very few are around | 15:25 |
| efried | As with placement, we should at the very least make it a separate database. | 15:25 |
| jaypipes | Sundar: there is definitely a desire to standardize and clean up the mess that is the PCI device management code (and CPU pinning, NUMA topology, etc) code in Nova. I have never had a desire to create a new REST service to manage this data, however. | 15:25 |
| efried | but cyborg is already a separate project, and already has existing use cases for operation and tracking/programming of devices independent of nova | 15:26 |
| Sundar | jaypipes: While OPAE SDK has been released i github, I am not sure that all tools like fpgaconf got open sourced. I'll check and get back. | 15:26 |
| efried | so why wouldn't we just put the new database there to begin with? | 15:26 |
| jaypipes | Sundar: thx | 15:26 |
| jaypipes | efried: perhaps there is. I'm trying to say that I think it's premature to do RESTful stuff versus cleaning up the device management and plugging/assignment code in nova. | 15:28 |
| jaypipes | efried: I'm straining to think of a use case where I'd want programmatic listing and showing of device details across all my compute infrastructure. Other than just knowing what devices are there and what resources they provide (which is already taken care of by the placement service), I'm wondering what the use is of a REST API over this data. | 15:29 |
| *** sridharg has quit IRC | 15:30 | |
| Sundar | jaypipes: if you were to apply that to networking, would you not want to see the details of the NICs, and manage their diversity in a structured way? | 15:31 |
| *** sridharg has joined #openstack-nova | 15:32 | |
| jaypipes | Sundar: if you're talking about capabilities of NICs or bandwidth of physnets on NICs, we already have that in the placement DB. | 15:32 |
| jangutter | Sundar: commenting as an engineer working for a NIC vendor, customers broadly fall into two categories: "Make everything look the same" and "handle this node specially". | 15:33 |
| jangutter | Sundar: it would be nice to be able to say "provide me with a networking resource capable of _x_", but broadly, most requests to us have been to make things more uniform, not less. | 15:34 |
| Sundar | jaypipes: jangutter: My point is, just as we have Neutron for networking etc., the diversity of accelerators is best handled by a separate project, rather than fold all in Nova. Esp. since there are use cases that don;t involve Nova, even if you don't agree with it. | 15:35 |
| mriedem | as a casual observer, it sounds like the dilemma is doing something quick and dirty to get something done without a cyborg REST API, vs make a perfect external system that nova can leverage, which would likely delay this even longer | 15:36 |
| *** beagles_mtgs is now known as beagles | 15:37 | |
| mriedem | and if the former is done, how complicated is the extraction/decoupling later | 15:37 |
| dansmith | not sure it's a dilemma, | 15:37 |
| mriedem | and i think what was mentioned last week, | 15:37 |
| dansmith | as I think only jaypipes is the one that feels it should go that way | 15:37 |
| dansmith | (AFAICT at least) | 15:37 |
| mriedem | was someone could already be doing a PoC for the former to see how it looks so we have an informed decision to make | 15:37 |
| mriedem | as the latter is much more work i'd think | 15:38 |
| dansmith | mriedem: yup, I think we probably all agree on that point | 15:38 |
| dansmith | well, except maybe Sundar :) | 15:38 |
| * jaypipes wonders why there is a need for a REST API in order to execute /usr/bin/fpgaconf with some CLI options. | 15:39 | |
| Sundar | mriedem: dansmith: I am working on a POC, a simple one focusing only on the Nova - Cyborg calls. It needs official clearance within my company before I can share it | 15:39 |
| mriedem | the point of the rest api was so that the data and drivers live within cyborg, not nova, and nova hits those drivers over the API | 15:39 |
| mriedem | if we could put a shim in like PlacementDirect, great | 15:40 |
| dansmith | Sundar: yeah that's not going to work very well for collab, but.. good luck :/ | 15:40 |
| jangutter | Sundar: I don't think that anybody disputes that it's better to have a separate entity to handle out-of-Nova scope things. The trick is that Nova already has a way to pass PCI devices to instances. There's also existing code in os-vif that gets called "on plug events". | 15:40 |
| mriedem | we talked about all of this last week when we said we didn't need an os-acc library and could just use python-cyborgclient | 15:40 |
| sean-k-mooney | dansmith: well i have some leaning towrad a libary solution too | 15:40 |
| mriedem | and i was also confused why we needed to hit a rest api to get to the cyborg drivers, i.e. why it wasn't more like os-brick | 15:40 |
| dansmith | I'm fine with the programming part being in a library instead of an agent if we want | 15:41 |
| dansmith | mriedem: it's quite a bit more complicated than just manipulating standard system things to connect to an iscsi target | 15:41 |
| mriedem | right that was explained last week | 15:41 |
| mriedem | probably about this time :) | 15:41 |
| dansmith | but I don't think the tracking of devices, workflow to program, clean, etc these devices belongs in nova | 15:42 |
| mriedem | i don't really think we should build on that existing stuff within nova either, | 15:42 |
| mriedem | b/c once something is built on it, it makes it harder to clean it up later (it already is taking forever) | 15:42 |
| mriedem | and that pci code went in in juno | 15:42 |
| *** udesale has quit IRC | 15:43 | |
| artom | Just... pay a bunch of interns, and stick a CORBA thing in front. | 15:43 |
| *** udesale has joined #openstack-nova | 15:43 | |
| jaypipes | artom: lol | 15:43 |
| jangutter | artom: don't joke, xml will come out. | 15:43 |
| mriedem | i was going to add, "says the guy that isn't working on cleaning any of it up" | 15:43 |
| mriedem | for myself | 15:43 |
| sean-k-mooney | artom: just no... | 15:43 |
| mriedem | if we're talking xml, CIM model model this all so nicely! | 15:44 |
| mriedem | *would model | 15:44 |
| artom | If no one can agree on what to do, maybe if we all agree on what *not* to do, and then do that... | 15:44 |
| *** panda|rover is now known as panda|pto | 15:45 | |
| sean-k-mooney | i think at this point we would all like to see a POC rather then talk in abstract terms about it in a loop | 15:46 |
| dansmith | yup | 15:46 |
| * artom goes off to find interns. | 15:46 | |
| jangutter | we're falling into the trap of agreeing on stuff: which means it won't happen. | 15:46 |
| jaypipes | Sundar: what's the likelihood of your PoC being available this year? | 15:46 |
| jaypipes | Sundar: I understand you need permission from legal? | 15:46 |
| Sundar | I'd like some agreement on the general direction of the POC. At the PTG, there was alignment on defining REST calls, and I wrote that up in a spec that is being reviewed. The discussion here seems more philosophical. I suggest that the POC should focus on clarifying the spec. | 15:48 |
| artom | Sundar, I think at some point you'll have to accept that work might get wasted :( | 15:49 |
| dansmith | Sundar: while everything is just words in a document, the discussion can get pretty philosophical pretty quick, as you have no doubt noticed | 15:49 |
| artom | I've been observing this discussion from afar since... Dublin? | 15:49 |
| sean-k-mooney | Sundar: can we do a simple poc of booting a vm with just a fixed fuction pci device | 15:49 |
| Sundar | jaypipes: Yes, it requires legal clearance. I may get a requirement to follow a process, or likely multiple processes. I am hoping that, confining it to upstream code and no real devices will make it go faster | 15:49 |
| artom | Bite the bullet, write some code, share it | 15:50 |
| artom | If the code gets scrapped and needs to be rewritte, so be it | 15:50 |
| sean-k-mooney | Sundar: the intel fpga stuff may but nova and cyborg working together dont | 15:50 |
| jaypipes | Sundar: that's generally not what PoCs are, but ok :) My suggestion is to demo Nova actually being able to /usr/bin/fpgaconf some device. If you want to go through the trouble of getting all the REST API stuff done in order for Nova to shell out to /usr/bin/fpgaconf, go for it. :) | 15:50 |
| jmlowe | If anybody remembers my slow placement api problem from a couple of days ago, it seems that NAT in the 4.15 kernel that ships with ubuntu 18.04 is problematic at scale | 15:53 |
| cdent | jmlowe: I am a) relieved to hear that, b) sorry for your luck | 15:54 |
| cdent | can you define "at scale"? | 15:55 |
| mriedem | cern runs centos right? | 15:56 |
| mriedem | tssurya: ^ | 15:56 |
| jmlowe | I have a quick question about versioned notifications, if a notification has been transitioned to versioned and the setting is for legacy does that mean the notification will never be emitted? | 15:56 |
| mriedem | jmlowe: what is the value of this option https://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format | 15:57 |
| mriedem | in your nova.conf | 15:57 |
| jmlowe | cdent: I was falling over at ~280, threshold is probably significantly lower, ubuntu 16.04 didn't cause problems | 15:57 |
| gibi | jmlowe: if you configured nova to emit legacy notifications only then nova only emts the legacy ones | 15:57 |
| gibi | jmlowe: we did not removed the legacy notifications, and we did not plan to remove them | 15:58 |
| *** awaugama has joined #openstack-nova | 15:58 | |
| jmlowe | I have unversioned, was looking at rocky release notes and saw that instance exits has been transitioned and that's the one event I really need to consume with ceilometer/panko which doesn't do versioned yet | 15:59 |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | 15:59 |
| mriedem | jmlowe: just leave as unversioned then, | 15:59 |
| mriedem | as gibi said, we haven't removed the unversioned notifications | 15:59 |
| gibi | jmlowe: if https://docs.openstack.org/nova/latest/configuration/config.html#notifications.notification_format is configured to both or unversioned then nova still sends the old instance.exists | 16:00 |
| mriedem | most, if not all, openstack projects that consume notifications from nova are still using unversoined notifications | 16:00 |
| mriedem | dansmith: i'm +2 on the volume-backed rebuild spec now https://review.openstack.org/#/c/532407/ | 16:01 |
| jmlowe | ok, perfect, thanks, needed a sanity check to make sure before I happily upgraded myself into a sisyphean custom patch cycle | 16:02 |
| *** davidsha has quit IRC | 16:02 | |
| jmlowe | mriedem: my exploding rabbit queues say otherwise | 16:03 |
| jmlowe | mriedem: versioned notifications for ceilometer are still tagged as a wishlist bug | 16:04 |
| mriedem | jmlowe: umm | 16:06 |
| mriedem | if you're using unversioned, there should be no difference | 16:07 |
| Sundar | jaypipes: I found the source for fpgaconf.c : https://github.com/OPAE/opae-sdk/tree/master/tools/base/fpgaconf | 16:07 |
| jmlowe | mriedem: that was learned the hard way | 16:07 |
| mriedem | jmlowe: can you expand? did you upgrade and the format option was using 'both'? | 16:07 |
| mriedem | i remember godaddy saying in boston that the instance.exists notifications in particular hammer their MQ | 16:08 |
| sean-k-mooney | Sundar: could we do a poc usign a FakeDriver the simulates a fake device and uses that to test this end to end and there for remove the hardware depency | 16:09 |
| sean-k-mooney | we have asked this in the past | 16:10 |
| sean-k-mooney | it woudl be useful for ci if nothing else | 16:10 |
| jmlowe | Now on queens, upgraded in place starting from liberty, didn't really pay attention, just assumed everything would work, the versioned notifications queue grew without bound until I finally got smart an capped nova with legacy notifications | 16:10 |
| mriedem | ok, so it was sending both then | 16:11 |
| jmlowe | whatever the default is | 16:12 |
| mriedem | it's 'both' | 16:12 |
| mriedem | gibi: i almost wonder if we should change the default to unversioned... | 16:12 |
| mriedem | i know we want people to use versioned, but there aren't any projects working on that | 16:12 |
| mriedem | or, | 16:12 |
| mriedem | maybe we should start a 'performance / scale considerations' doc in nova for stuff like this | 16:13 |
| mriedem | "rabbit got you down? check your notifications settings." | 16:13 |
| gibi | mriedem: does changing the default in a bugfix is safe from config compatibility perspective? | 16:14 |
| jmlowe | That may thwart my ambitions to be a obscenely high paid consultant | 16:15 |
| bauzas | mriedem: artom: there ? I have a concern on https://review.openstack.org/#/c/599587/ | 16:15 |
| *** Luzi has quit IRC | 16:15 | |
| bauzas | most of my comments are nits but the last one is important | 16:15 |
| bauzas | artom: mriedem: https://review.openstack.org/#/c/599587/8/specs/stein/approved/numa-aware-live-migration.rst@327 | 16:15 |
| *** tbachman has quit IRC | 16:16 | |
| bauzas | the question is : once we implement this, we will change how we will accept live migrations | 16:16 |
| bauzas | should we signal it ? | 16:16 |
| sean-k-mooney | bauzas: how do you mean | 16:16 |
| bauzas | or just drop a release note saying "by Stein, NUMA-aware live migrations will be unaccepted" | 16:16 |
| artom | bauzas, we could make it configurable, sort like what stephenfin is proposing with https://review.openstack.org/#/c/611088/ | 16:17 |
| mriedem | didn't this already come up in https://review.openstack.org/#/c/611088/ | 16:17 |
| mriedem | yeah | 16:17 |
| *** ttsiouts has quit IRC | 16:17 | |
| artom | bauzas, but... why? Why would anyone want to live migrate in the middle of an upgrade with mixed computes? | 16:17 |
| *** sridharg has quit IRC | 16:17 | |
| artom | Live migrate *knowing* that things will mostly likely go south | 16:17 |
| sean-k-mooney | artom: it not that uncommon | 16:18 |
| *** ttsiouts has joined #openstack-nova | 16:18 | |
| bauzas | artom: it's a possibility yes | 16:18 |
| bauzas | that's even a common pattern | 16:18 |
| sean-k-mooney | in that case they are likely specifyign the host as they are freeing up old host to upgrade | 16:18 |
| *** sridharg has joined #openstack-nova | 16:18 | |
| bauzas | operators do a lot of migrations when they upgrade | 16:18 |
| dansmith | artom: live migration during an upgrade is the primary mechanism that most people use | 16:18 |
| dansmith | artom: *lots* of people refuse to upgrade a compute node until they've moved everything off of it | 16:19 |
| bauzas | tbh, I'm fine with dropping a release note saying there will be an impact | 16:19 |
| artom | dansmith, fair enough | 16:19 |
| bauzas | given worloads should move from old to new | 16:19 |
| bauzas | and not from new to old | 16:19 |
| sean-k-mooney | bauzas: we could do what we did for multiple port bindings and just fall back to the old behavior | 16:19 |
| *** marvin_mhg has joined #openstack-nova | 16:20 | |
| bauzas | oh shit, the problem is with old to new | 16:20 |
| bauzas | not the contrary, my bad | 16:20 |
| *** marvin_mhg has quit IRC | 16:20 | |
| artom | I just don't see how we can realistically handle that | 16:20 |
| bauzas | so, yeah, we could shoot operators in the foot | 16:20 |
| bauzas | artom: we could make a flag during the upgrade | 16:20 |
| artom | Keep the old code paths intact while somehow adding claims and all the new XML stuff | 16:21 |
| bauzas | and say 'if you need so, it's on you, folks" | 16:21 |
| *** marvin_mhg has joined #openstack-nova | 16:21 | |
| sean-k-mooney | artom: for old to new we can fallback to the old behvior | 16:21 |
| bauzas | new to old isn't a problem | 16:21 |
| bauzas | new to new isn't a problem | 16:21 |
| artom | sean-k-mooney, can we? How do we even implement that? | 16:21 |
| bauzas | old to new is the problem | 16:21 |
| sean-k-mooney | e.g. claim nothing and tell people to migrate again after migrate to fix everything | 16:22 |
| bauzas | so yeah, we somehow need to keep the broken behaviour | 16:22 |
| artom | It's going to be way ugly with a whole bunch of conditionals all over the place | 16:22 |
| bauzas | artom: I know, it's freaking ugly | 16:22 |
| bauzas | but I don't see operators be happy with what you propose :p | 16:22 |
| artom | Unless we do the new stuff in entirely new RPC calls/casts | 16:22 |
| *** ttsiouts has quit IRC | 16:22 | |
| gibi | mriedem, jmlowe: I reported https://bugs.launchpad.net/nova/+bug/1805659 | 16:22 |
| openstack | Launchpad bug 1805659 in OpenStack Compute (nova) "nova notifications hammering the message bus" [Undecided,New] | 16:22 |
| sean-k-mooney | artom: its what we did for multiple port bindings. we check if a field exitsing in the migrate data if not we do the old stuff if its there we do the new way | 16:22 |
| artom | bauzas, yeah, probably true | 16:23 |
| dansmith | artom: that's how we do things gracefully | 16:23 |
| bauzas | couldn't you drop the move claim if the RPC argument is not there ? | 16:23 |
| dansmith | artom: i.e. pass a flag, and if it's missing, assume it's an old compute and do the old thing | 16:23 |
| artom | dansmith, what is? New RPC version? | 16:23 |
| dansmith | you can't see the rpc version on the receiving end | 16:23 |
| dansmith | you need a flag | 16:23 |
| bauzas | what dansmith said and me :) | 16:23 |
| dansmith | do_the_new_thing=True | 16:23 |
| bauzas | that's what we generally do | 16:23 |
| artom | dansmith, I don't disagree, but it's going to be a mess | 16:23 |
| bauzas | artom: I can point you some code I wrote that does the signaling | 16:23 |
| dansmith | artom: it's how you have to do it | 16:24 |
| dansmith | it's how everything we do that involves old/new services works | 16:24 |
| bauzas | artom: sure, but we somehow need to know that the live migration comes from an old compute hence us releasing the check | 16:24 |
| *** dpawlik has joined #openstack-nova | 16:24 | |
| bauzas | and not doing the claim | 16:24 |
| mriedem | if you have an old dest compute, the migrate_data won't have the numa stuff from the claim right? | 16:25 |
| *** marvin_mhg has quit IRC | 16:25 | |
| mriedem | so the source (if new) can't rely on it | 16:25 |
| artom | mriedem, other way around, new dest, old source | 16:25 |
| artom | So source won't send the updated XML, but dest will have claimed for it | 16:25 |
| *** moshele has joined #openstack-nova | 16:25 | |
| artom | So we need to do conditional claiming based on source compute version | 16:25 |
| mriedem | i think that's what the file-backed memory live migration does... | 16:26 |
| bauzas | you could make the migrate_data parameter a sentinel | 16:26 |
| mriedem | it checks the compute service version for the source from the dest | 16:26 |
| *** gaoyan has joined #openstack-nova | 16:26 | |
| artom | Alright, lemme update the spec | 16:26 |
| bauzas | artom: just change this | 16:27 |
| *** gyee has joined #openstack-nova | 16:27 | |
| bauzas | other things were nits | 16:27 |
| bauzas | just for documenting the spec | 16:27 |
| artom | Alright if I keep it kinda high-level? So "conditional claim", but without specifying what that condition will look like (flag, version checking, etc)? | 16:27 |
| bauzas | later when we review | 16:27 |
| dansmith | artom: you can't check the version | 16:27 |
| mriedem | artom: this is the code i'm thinking of https://github.com/openstack/nova/blob/62245235bc15da6abcdfd3df1c24bd856d69fbb4/nova/virt/libvirt/driver.py#L6636 | 16:27 |
| artom | dansmith, I guess not on the compute, eh? | 16:27 |
| artom | Only conductor, so it has to be flag | 16:27 |
| bauzas | mriedem: we don't want to fail | 16:28 |
| *** gaoyan has quit IRC | 16:28 | |
| dansmith | artom: I'm not sure what you mean | 16:28 |
| bauzas | mriedem: we want to blindly accept the migration and not claim | 16:28 |
| mriedem | bauzas: you don't want to claim on the dest if the source isn't going to use it | 16:28 |
| mriedem | right? | 16:28 |
| *** ttsiouts has joined #openstack-nova | 16:28 | |
| bauzas | that's right | 16:28 |
| artom | dansmith, can the dest compute check the source compute version? | 16:28 |
| artom | And do the new thing only if the source compute is hew? | 16:28 |
| artom | *new | 16:28 |
| dansmith | artom: don't do it that way | 16:28 |
| mriedem | my point is, ^ is how the dest checks the source compute version today - that pattern could be re-used, not the specific failure thing | 16:28 |
| dansmith | artom: because version pinning might mean you have a new compute, but it didn't send something new | 16:29 |
| artom | dansmith, oh right | 16:29 |
| artom | Wait up though | 16:29 |
| bauzas | artom: https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L93 | 16:29 |
| bauzas | artom: that's one example of a flag (the _sentinel value) | 16:30 |
| dansmith | the file-backed stuff chooses not to migrate at all if the target isn't going to support it I think, but in your case you have to allow it, you just need to do the old thing | 16:30 |
| mriedem | if the source isnt going to suppor it | 16:30 |
| mriedem | *support | 16:30 |
| bauzas | shit, I need to bail out | 16:30 |
| bauzas | I just dropped my poop and then I leave | 16:30 |
| bauzas | excellent | 16:30 |
| dansmith | bauzas: um... | 16:31 |
| artom | You panda | 16:31 |
| artom | Eats poops and leaves | 16:31 |
| artom | No wait, it's "shoots" | 16:31 |
| mriedem | dansmith: i think the point is, from the dest, if the source is old, we don't claim on the dest and we don't put the numa things in migrate_data, | 16:31 |
| artom | Dammit >< | 16:31 |
| bauzas | context is https://www.meetup.com/fr-FR/Groupe-dutilisateurs-Python-Grenoble/events/256520367/ | 16:31 |
| mriedem | because and old source isn't going to use those anyway, and also wouldn't know to rollback the claim or whatever | 16:31 |
| bauzas | for once we have a meetup that talks OpenStack here... | 16:31 |
| dansmith | mriedem: it really needs to work both ways, whether the source is old or new | 16:32 |
| mriedem | if the dest is old, | 16:32 |
| mriedem | and the source is new, | 16:32 |
| mriedem | migrate_data won't have the new numa field in it, | 16:32 |
| artom | If the source is new it's fine, dest will just ignore the new field | 16:32 |
| mriedem | and the new source node just won't do any of the new stuff | 16:32 |
| *** sridharg has quit IRC | 16:32 | |
| artom | (Which reminds me, it means we need to do claims on the dest) | 16:32 |
| artom | (And cleanup) | 16:33 |
| mriedem | reminds you? the spec already says the claims happen on the dest | 16:33 |
| mriedem | they have to happen on the dest | 16:33 |
| dansmith | the spec should probably have the old/new src/dst truth table in it if it doesn't already | 16:33 |
| artom | I mean, in the code | 16:33 |
| mriedem | ++ on that | 16:33 |
| artom | Any of the new stuff we do needs to be in code that runs on the dest | 16:33 |
| mriedem | artom: i'm not sure what you're saying | 16:33 |
| mriedem | yes the claim needs to happen on the dest | 16:33 |
| mriedem | like the spec says :) | 16:33 |
| artom | Does it? I thought I left it at "implementation detail" | 16:34 |
| *** sridharg has joined #openstack-nova | 16:34 | |
| mriedem | oy | 16:34 |
| *** udesale has quit IRC | 16:34 | |
| mriedem | "Any of the new stuff we do needs to be in code that runs on the dest" is also not accurate | 16:34 |
| jaypipes | Sundar: ty sir! | 16:34 |
| artom | Well, yeah | 16:34 |
| mriedem | obviously there will be new code on the source to generate the xml, using data from the dest, to send the xml to the dest | 16:34 |
| artom | Creating claims and cleaning them | 16:34 |
| artom | Has to be done on the dest | 16:34 |
| bauzas | I'm fine with leaving details for the implementation | 16:34 |
| bauzas | I just want to make sure we all agree on the behaviour for upgrades | 16:35 |
| mriedem | create yes, i'm not entirely sure about clean (drop_move_claim), but sure | 16:35 |
| *** sridharg has quit IRC | 16:35 | |
| bauzas | which is, whatever we write, in case a live migration happens from a Rocky node to a Stein node, we will just blindly accept the migration and not do the claim | 16:35 |
| mriedem | as noted in my review comments, rollback doesn't always cleanup on the dest | 16:35 |
| mriedem | today anyway | 16:35 |
| bauzas | artom: ^ | 16:35 |
| *** sridharg has joined #openstack-nova | 16:35 | |
| dansmith | bauzas: I thought you dropped poop and left? | 16:35 |
| dansmith | I must have misunderstood :) | 16:36 |
| artom | OK, I think I need to go back to the spec after a bit of thinking | 16:36 |
| artom | dansmith, he's relishing his poop | 16:36 |
| bauzas | dansmith: hah, I just feel I need to discuss a bit more | 16:36 |
| * dansmith is so confused | 16:36 | |
| mriedem | artom: probably easiest to just start with a mixed compute upgrade table or something, | 16:36 |
| mriedem | with (1) old source, old dest - what happens? (2) old source, new dest, what happens, (3) new source, old dest, (4) new source, new dest | 16:37 |
| dansmith | a truth table, like I said | 16:37 |
| bauzas | +1 | 16:37 |
| artom | Yeah, sounds like a good idea | 16:37 |
| bauzas | the rest can be left for implementation | 16:37 |
| bauzas | anyway, I'm just flushing my stuff now | 16:37 |
| bauzas | see ya | 16:37 |
| mriedem | if we do that, i'm not entirely sure how much we need https://review.openstack.org/#/c/611088/ now | 16:38 |
| artom | mriedem, you're assuming the NUMA live migration code lands in Stein :) | 16:39 |
| artom | I know I'm an all-star, but common | 16:39 |
| *** ttsiouts has quit IRC | 16:39 | |
| *** ttsiouts has joined #openstack-nova | 16:40 | |
| *** ttsiouts has quit IRC | 16:41 | |
| artom | Pheeding first though, I'm phamished | 16:41 |
| cdent | does first come before or after phirst? | 16:41 |
| artom | Aww man, I missed the "phirst" opportunity :( | 16:42 |
| *** dpawlik has quit IRC | 16:42 | |
| artom | Phirst the thirts, than the phamine | 16:42 |
| artom | *thirst | 16:42 |
| * artom gives up | 16:42 | |
| *** tssurya has quit IRC | 16:45 | |
| *** moshele has quit IRC | 16:47 | |
| *** sridharg has quit IRC | 16:48 | |
| *** tbachman has joined #openstack-nova | 16:50 | |
| *** lbragstad has quit IRC | 17:02 | |
| *** dpawlik has joined #openstack-nova | 17:03 | |
| *** pcaruana has quit IRC | 17:03 | |
| *** lbragstad has joined #openstack-nova | 17:05 | |
| *** dpawlik has quit IRC | 17:07 | |
| *** jangutter has quit IRC | 17:09 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient https://review.openstack.org/617042 | 17:13 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Rip out the SchedulerClient https://review.openstack.org/617049 | 17:13 |
| mriedem | cdent: i think https://bugs.launchpad.net/nova/+bug/1805408 might be a duplicate, see inline | 17:14 |
| openstack | Launchpad bug 1805408 in OpenStack Compute (nova) "ServerGroupTestV21.test_boot_servers_with_anti_affinity and related tests can race" [Undecided,New] | 17:14 |
| *** KeithMnemonic has quit IRC | 17:14 | |
| *** sahid has quit IRC | 17:17 | |
| cdent | mriedem: yeah, I think you're right. It just shows up somewhat differently in the context of the placement extraction, but i think that's just noise | 17:22 |
| cdent | i've marked it | 17:22 |
| *** jackivanov has quit IRC | 17:28 | |
| mriedem | so i'm pretty sure we've said we can't change 404s to be 400s just because it's a better fit without a microversion, right? | 17:29 |
| cdent | mriedem: generally true, but fudging is often exercised | 17:29 |
| cdent | the fear is someone branching on the status code, which you can easily imagine in that particular case | 17:30 |
| mriedem | yeah, this seems pretty obvious what i'm looking at, | 17:30 |
| mriedem | trying to disable a non-nova-compute service results in HostMappingNotFound which results in a 404 | 17:30 |
| mriedem | you can't disable non-nova-compute services, so really it's a bad request | 17:30 |
| mriedem | i want to provide a better error message than 'host mapping not found' since that's not the problem really | 17:31 |
| mriedem | but also wondering if i should change the response code at the same time to be a 400 | 17:31 |
| cdent | it should only ever be a 404 if the actual URL is a 404, not something within | 17:31 |
| cdent | so yeah, this sounds kind of 400 ish | 17:32 |
| dansmith | wait, what? | 17:36 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1805164 | 17:36 |
| openstack | Launchpad bug 1805164 in OpenStack Compute (nova) rocky "Confusing error message when trying to disable non-nova-compute service" [Low,Triaged] | 17:36 |
| dansmith | disabling a non-compute service is still a 404 right? since the url to a non-compute service wouldn't exist? | 17:36 |
| mriedem | the service id isn't in the URL for older microversoins | 17:37 |
| mriedem | e.g. PUT /os-services/disable | 17:37 |
| mriedem | the host/binary is in the body | 17:37 |
| dansmith | ah yeah, was just pulling up the ref | 17:37 |
| dansmith | yeah, okay | 17:37 |
| mriedem | and anyway, we return 400 if you try doing PUT /os-services/{service_id} with a non-compute service with microversion >= 2.53 | 17:37 |
| mriedem | so this would be consistent with that | 17:37 |
| dansmith | yn | 17:38 |
| dansmith | um | 17:38 |
| dansmith | can you GET the service by id? | 17:38 |
| dansmith | for non-computes? | 17:38 |
| dansmith | api-ref doesn't show that you can, but I wonder if it's a missing doc | 17:39 |
| mriedem | you can GET /os-services | 17:39 |
| mriedem | not a specific service | 17:39 |
| dansmith | but you can PUT it? | 17:39 |
| dansmith | weird | 17:39 |
| mriedem | there was lots of weird to be dealt with in https://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/service-hyper-uuid-in-api.html | 17:40 |
| dansmith | point being PUT /os-services/id where id is not a compute is kinda 404ish right? if you can't update non-compute services? | 17:40 |
| dansmith | if you can't GET them it's hard to say either way | 17:40 |
| mriedem | shrug | 17:40 |
| mriedem | you can definitely GET them via list, but not directly via show right | 17:40 |
| dansmith | yeah I mean get by id | 17:41 |
| *** janki has quit IRC | 17:41 | |
| *** adrianc has quit IRC | 17:43 | |
| *** moshele has joined #openstack-nova | 17:47 | |
| *** abhishekk has joined #openstack-nova | 17:53 | |
| mriedem | here it comes | 17:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide a useful error message when trying to update non-compute services https://review.openstack.org/620667 | 17:54 |
| mriedem | for all your ridicule | 17:54 |
| dansmith | mriedem: I commented on the rebuild spec.. I can fix my own nits but had a legit question | 17:57 |
| dansmith | if you can answer I'll fix my nits and approve | 17:57 |
| *** k_mouza_ has joined #openstack-nova | 17:57 | |
| *** Sundar has quit IRC | 17:58 | |
| mriedem | melwitt: i've triaged at least 2 more bugs about the rocky install guide missing the mention of installing nova-consoleauth b/c it's still needed, i've duplicated them against https://bugs.launchpad.net/nova/+bug/1793255 but not sure what your plans were for putting some kind of note in the install guides about, "hey, you might still need to install nova-consoleauth, see the workaround option for details" | 17:59 |
| openstack | Launchpad bug 1793255 in OpenStack Compute (nova) rocky "nova-consoleauth missing from Rocky install guide; unable to use VNC" [High,In progress] - Assigned to melanie witt (melwitt) | 17:59 |
| mriedem | dansmith: before i look, let me guess: what do we do about running it through the scheduler? | 18:00 |
| dansmith | no | 18:00 |
| *** k_mouza has quit IRC | 18:01 | |
| *** k_mouza_ has quit IRC | 18:01 | |
| mriedem | dansmith: replies inline | 18:05 |
| dansmith | mriedem: thanks, replied | 18:10 |
| dansmith | mriedem: so I can fix my mechanical nits, but it seems like both our meatier comments deserve some actual new words. agree? | 18:10 |
| mriedem | i replied again to make sure i'm following you | 18:11 |
| mriedem | if we're on the same page, i'll update it | 18:12 |
| dansmith | oh, so, re-reading I may have missed something | 18:13 |
| dansmith | the procedure says "delete the existing volume attachment", | 18:13 |
| dansmith | which I thought meant "the BDM" but that's not the case -- that means the attachment on the cinder side right? | 18:13 |
| *** rtjure has joined #openstack-nova | 18:13 | |
| mriedem | correct | 18:13 |
| dansmith | I was worried we might lost the linkage to the volume if we failed to create a temporary BDM at the right spot, and/or fail to allow re-replacing that | 18:13 |
| dansmith | but this makes more sense | 18:13 |
| mriedem | and it's what we already do today for rebuild | 18:14 |
| dansmith | okay fair enough | 18:14 |
| dansmith | for non-root you mean | 18:14 |
| mriedem | the rollback procedure wasn't called out | 18:14 |
| mriedem | yes | 18:14 |
| mriedem | well, | 18:14 |
| mriedem | you can rebuild a volume-backed server today too, | 18:14 |
| mriedem | as long as the image doesn't change | 18:14 |
| dansmith | yeah | 18:14 |
| mriedem | we detach all the bdms, destroy the guest, spawn the guest and attach the volumes again | 18:14 |
| dansmith | okay I'm with you, I was just projecting too much bdm in there | 18:14 |
| mriedem | the last part 'completes' the attachment by giving cinder the host connector | 18:14 |
| dansmith | detach or delete/ | 18:15 |
| mriedem | detach | 18:15 |
| mriedem | the bdms are fixed | 18:15 |
| mriedem | the volume attachment record is transitory | 18:15 |
| dansmith | right, so we still have the linkage between the instance and the volume it should be attached to yes? | 18:15 |
| mriedem | so we'll update the bdm.attachment_id during the rebuild | 18:15 |
| mriedem | yes | 18:15 |
| dansmith | right, okay, gotcha | 18:15 |
| mriedem | we do that dance to keep the volume 'ours' | 18:15 |
| dansmith | yeah | 18:15 |
| *** abhishekk has quit IRC | 18:18 | |
| mriedem | dansmith: do you agree that if the image changes, we should run it through the scheduler as we do for image-backed servers? | 18:21 |
| dansmith | mriedem: yeah I said that didn't I?\ | 18:21 |
| mriedem | you said...something, | 18:21 |
| mriedem | i was trying to confirm | 18:22 |
| dansmith | I said "same policy-enforcment as the image-backed ones" | 18:22 |
| mriedem | but ok i'll update the spec with more wordz | 18:22 |
| dansmith | I ain't speakin' no jive | 18:22 |
| mriedem | you said conflictory | 18:22 |
| mriedem | my nose started bleeding | 18:22 |
| dansmith | haha, okay I was speakin' jive | 18:22 |
| dansmith | haha | 18:22 |
| *** wolverineav has joined #openstack-nova | 18:23 | |
| *** ralonsoh has quit IRC | 18:25 | |
| *** moshele has quit IRC | 18:26 | |
| *** wolverineav has quit IRC | 18:50 | |
| openstackgerrit | Merged openstack/nova master: Give drop_move_claim() correct docstring https://review.openstack.org/620170 | 18:50 |
| *** wolverineav has joined #openstack-nova | 18:51 | |
| mriedem | dansmith: having thought about this over lunch, i'm not really sure if we can/should try to update the host connector back into the attachments if rebuild fails - the volume would be in 'error' status, so i'm not sure if we should mess with it. rebuilding the server again later would just delete the empty volume attachment and start over with a new one | 18:58 |
| dansmith | mriedem: okay I didn't think we would, because we'd be putting attachment info back in that is no longer valid (i.e. couldn't be deleted again when you retry) right? | 18:59 |
| mriedem | we can delete it again when we retry | 19:00 |
| mriedem | it's just a CRUD operation on the volume attachment record | 19:00 |
| *** dklyle has joined #openstack-nova | 19:03 | |
| *** whoami-rajat has quit IRC | 19:07 | |
| *** lbragstad has quit IRC | 19:08 | |
| *** lbragstad has joined #openstack-nova | 19:12 | |
| *** lbragstad has quit IRC | 19:12 | |
| *** lbragstad has joined #openstack-nova | 19:14 | |
| *** lbragstad has quit IRC | 19:14 | |
| *** erlon has quit IRC | 19:15 | |
| *** lbragstad has joined #openstack-nova | 19:16 | |
| *** lbragstad has quit IRC | 19:16 | |
| *** cdent has quit IRC | 19:17 | |
| *** k_mouza has joined #openstack-nova | 19:21 | |
| *** mdbooth_ has joined #openstack-nova | 19:26 | |
| *** dklyle has quit IRC | 19:27 | |
| *** mdbooth has quit IRC | 19:29 | |
| *** erlon has joined #openstack-nova | 19:30 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | 19:40 |
| mriedem | dansmith: updated ^ i'll wait to +2 | 19:40 |
| *** erlon has quit IRC | 19:52 | |
| *** eharney has quit IRC | 19:59 | |
| *** wolverineav has quit IRC | 20:05 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Restore nova-consoleauth to install docs https://review.openstack.org/605154 | 20:06 |
| *** wolverineav has joined #openstack-nova | 20:07 | |
| *** eharney has joined #openstack-nova | 20:11 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Restore nova-consoleauth to install docs https://review.openstack.org/605154 | 20:14 |
| *** wolverineav has quit IRC | 20:16 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Restore nova-consoleauth to install docs https://review.openstack.org/605154 | 20:22 |
| *** lbragstad has joined #openstack-nova | 20:30 | |
| mnaser | simple backport needing some votes - https://review.openstack.org/#/c/619351/ (stable/rocky already merged) | 20:30 |
| *** openstackgerrit has quit IRC | 20:36 | |
| *** awaugama has quit IRC | 20:43 | |
| *** k_mouza has quit IRC | 20:44 | |
| melwitt | mriedem: by default, people shouldn't have to install nova-consoleauth on a fresh install _unless_ they've enabled the [workarounds]enable_consoleauth option. I added a comment to the review | 20:48 |
| *** wolverineav has joined #openstack-nova | 20:48 | |
| melwitt | I'm going to compare when those bugs were opened vs when the change that made nova-consoleauth optional merged to stable/rocky | 20:49 |
| mriedem | both were opened this month | 20:50 |
| mriedem | the duplicates | 20:50 |
| melwitt | ok. I had tested that nova-consoleauth is no longer needed via this devstack change https://review.openstack.org/607070 back when I worked on the patch that made it optional | 20:52 |
| melwitt | going to look at the duplicates now | 20:52 |
| *** tbachman has quit IRC | 21:02 | |
| *** wolverineav has quit IRC | 21:02 | |
| *** k_mouza has joined #openstack-nova | 21:04 | |
| *** wolverineav has joined #openstack-nova | 21:06 | |
| *** openstackgerrit has joined #openstack-nova | 21:14 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Mention size limit on user data in docs https://review.openstack.org/620700 | 21:14 |
| flwang | mriedem: does nova support configuring the volume type when booting? | 21:15 |
| mriedem | flwang: with microversion 2.67 in stein yes https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id60 | 21:15 |
| flwang | is it a big feature? possible to do cherrypick? to old nova version? | 21:16 |
| flwang | mriedem: any chance you know the commit link? | 21:20 |
| *** eharney has quit IRC | 21:20 | |
| *** wolverineav has quit IRC | 21:22 | |
| *** wolverineav has joined #openstack-nova | 21:23 | |
| *** wolverineav has quit IRC | 21:23 | |
| *** wolverineav has joined #openstack-nova | 21:23 | |
| mriedem | flwang: you're asking me if we can backport an API feature change? | 21:23 |
| mriedem | you've been around openstack long enough to know that is a blatant violation of stable branch policy | 21:24 |
| *** tbachman has joined #openstack-nova | 21:24 | |
| mriedem | whatever you want to fork in your product though...go ahead :) | 21:24 |
| *** mchlumsky has quit IRC | 21:25 | |
| *** tbachman_ has joined #openstack-nova | 21:27 | |
| *** tbachman has quit IRC | 21:29 | |
| *** tbachman_ is now known as tbachman | 21:29 | |
| flwang | mriedem: no, i'm just lazy, so just ask if it's a big one, so that we can backport it in our private repo | 21:29 |
| flwang | now i have got all the commits | 21:30 |
| flwang | it's big one, seems no chance to backport :( | 21:30 |
| efried | jaypipes: Responded on https://review.openstack.org/#/c/617042/ - lmk if that doesn't make sense. | 21:30 |
| efried | jaypipes: btw, if it's specifically the use of the @property decorator you object to, I can change it to _get_report_client() for consistency with _get_resource_tracker(). I just wanted to take the opportunity to save some horizontal space, since we're already having trouble fitting things like https://review.openstack.org/#/c/617042/6/nova/compute/manager.py@a766 | 21:32 |
| jaypipes | efried: answered. yeah, we can remove all that now and just set reportclient once. | 21:35 |
| efried | jaypipes: Okay, cool. fup? | 21:35 |
| jaypipes | yup. lemme re-vote (though I still think it would be cool to have those two patches separate) | 21:36 |
| *** lbragstad has quit IRC | 21:37 | |
| jaypipes | efried: +2 | 21:37 |
| *** lbragstad has joined #openstack-nova | 21:37 | |
| efried | jaypipes: Thanks! Re removing that flushing of the RT, I'm slightly leery of trying to do that change myself - how will we know it didn't break things? Though perhaps we could instead just self.reportclient.clear_cache() now that that's a thing. | 21:38 |
| mriedem | heh, finally got an official bug for the regression in ocata where aggregate allocation ratios are no longer honored https://bugs.launchpad.net/nova/+bug/1804125 | 21:38 |
| openstack | Launchpad bug 1804125 in OpenStack Compute (nova) "Nova placement disregards nova aggregate metadata" [Medium,Triaged] | 21:38 |
| jaypipes | efried: maybe. just try it? :) I'm telling you I added that code comment back when the RT was still being converted by me to pass nodename for all the methods and track multiple compute nodes (instead of having multiple instances of the RT) | 21:39 |
| openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706 | 21:40 |
| efried | jaypipes: um, afaict, we only get ComputeHostNotFound from get_node_uuid (in resource_tracker.py) - and I can't see where that guy is used at all. So that whole exception path may be completely unreachable. | 21:49 |
| *** rcernin has joined #openstack-nova | 21:50 | |
| *** takashin has joined #openstack-nova | 21:50 | |
| openstackgerrit | Merged openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | 21:51 |
| jaypipes | efried: not a bit unlikely :) | 21:57 |
| flwang | mriedem: jaypipes: is there a config option in nova.conf to set the default volume type? | 22:02 |
| *** rcernin has quit IRC | 22:03 | |
| jaypipes | flwang: sorry, I have node idea :( mriedem probably is your best bet. (I didn't even think we *supported* volume types actually..) | 22:04 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use a static resource tracker in the compute manager https://review.openstack.org/620711 | 22:04 |
| efried | jaypipes: Let's see how the gate feels about that ^ | 22:04 |
| flwang | jaypipes: nova supports it in master(stein) | 22:04 |
| mriedem | flwang: no, cinder has a config for the default volume type | 22:05 |
| mriedem | nova only passes the volume type through, otherwise nova creates volumes w/o any volume type and you get the default from cinder | 22:06 |
| jaypipes | efried: lol nice commit message. | 22:07 |
| efried | :P | 22:07 |
| flwang | mriedem: that makes sense, thank you very much | 22:07 |
| efried | jaypipes: btw, I'm hoping you can review that whole series at some point. You're the A-1 expert in these code paths, I think. | 22:07 |
| efried | jaypipes: This is to solve the whole thing about CERN's traffic problems. | 22:08 |
| efried | ...that we put off in queens with that resource_provider_association_refresh conf var | 22:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Nova the aggregate allocation ratio restriction in scheduler docs https://review.openstack.org/620713 | 22:09 |
| jaypipes | efried: ack. | 22:11 |
| jaypipes | efried: working on em.... | 22:11 |
| efried | thx | 22:11 |
| *** rcernin has joined #openstack-nova | 22:12 | |
| mriedem | i have -1ed | 22:14 |
| mriedem | pull that get_node_uuid removal out | 22:15 |
| *** xek_ has quit IRC | 22:19 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Turn off rp association refresh in nova-next https://review.openstack.org/616033 | 22:20 |
| mriedem | zzzeek: could use your input on this postgresql issue if you have a sec https://review.openstack.org/#/c/619061/1 | 22:21 |
| mriedem | i threw in a thing that works, but i'm not sure it's the right way | 22:21 |
| efried | mriedem: so do it, just do it separately? | 22:21 |
| mriedem | efried: yes, outside of that series | 22:21 |
| efried | ack | 22:22 |
| mriedem | you could throw it in topic branch remove-migration-allocation-compat to line it all up nicely | 22:22 |
| mriedem | https://review.openstack.org/#/q/topic:remove-migration-allocation-compat+(status:open+OR+status:merged) | 22:22 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use a static resource tracker in the compute manager https://review.openstack.org/620711 | 22:23 |
| *** artom has quit IRC | 22:26 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove get_node_uuid https://review.openstack.org/620715 | 22:27 |
| efried | mriedem: there ya go. Don't say I never did anything for ya. | 22:28 |
| *** artom has joined #openstack-nova | 22:28 | |
| efried | speaking of which, what's the interest rate on shiny nickels? | 22:29 |
| *** artom has quit IRC | 22:29 | |
| mriedem | it's low | 22:29 |
| mriedem | it's always in my backpack though | 22:29 |
| mriedem | you just need to remind me in person sometime | 22:29 |
| *** artom has joined #openstack-nova | 22:29 | |
| mriedem | or give me your address and i'll ship it down | 22:29 |
| mriedem | maybe in a xmas card?! | 22:29 |
| efried | That would be awesome. What's a stamp these days, 40-odd cents? And you're not supposed to mail cash. Oh, and f xmas. | 22:30 |
| efried | I'll put it on the etherpad for Denver | 22:30 |
| mriedem | good idea | 22:31 |
| mriedem | i'll write you a check for $.05 | 22:31 |
| efried | IT HAS TO BE SHINY | 22:32 |
| efried | put glitter or something | 22:32 |
| mriedem | we do have glitter | 22:33 |
| mriedem | pens, glue, you name it | 22:33 |
| mriedem | i will richard shermans this check up for you | 22:33 |
| mriedem | ha, wrong guy | 22:33 |
| mriedem | simmons | 22:33 |
| mriedem | simmons | 22:33 |
| mriedem | jaypipes: you may enjoy that slip ^ | 22:34 |
| mriedem | FOOTBAW | 22:34 |
| jaypipes | haha | 22:35 |
| *** derekh has quit IRC | 22:43 | |
| *** derekh has joined #openstack-nova | 22:44 | |
| *** derekh has quit IRC | 22:44 | |
| *** slaweq has quit IRC | 22:46 | |
| *** tbachman has quit IRC | 22:46 | |
| *** tbachman has joined #openstack-nova | 22:46 | |
| *** mlavalle has quit IRC | 22:50 | |
| *** tbachman has quit IRC | 22:51 | |
| *** slaweq has joined #openstack-nova | 22:54 | |
| *** mlavalle has joined #openstack-nova | 22:55 | |
| mriedem | mordred: we should only need the endpoint type (volumev3) and interface (public) to look up a service catalog entry right? we don't need the service name for that, | 22:59 |
| *** slaweq has quit IRC | 22:59 | |
| mordred | that is correct | 22:59 |
| mriedem | unless you have multiple endpoints pointed at the same type and interface but with different names or something? | 22:59 |
| mriedem | trying to sort out what i can do for https://bugs.launchpad.net/nova/+bug/1803627 | 22:59 |
| openstack | Launchpad bug 1803627 in OpenStack Compute (nova) "Nova requires you to name your volumev3 service cinderv3" [Undecided,New] | 22:59 |
| jaypipes | efried: I'm quite concerned about https://review.openstack.org/#/c/615677/ | 23:00 |
| mordred | the only time service name is ever useful for anything is if a cloud has gotten itself into a bad place and has more than one endpoint with the same service type like rackspace public cloud did during their transition from legacy to openstack | 23:00 |
| mordred | mriedem: looking | 23:00 |
| *** wolverineav has quit IRC | 23:01 | |
| mordred | mriedem: oh - I can help work on that patch tomorrow (it's too late today) | 23:01 |
| mriedem | np thanks | 23:01 |
| efried | jaypipes: Looking | 23:01 |
| mriedem | i'm going to post something quick | 23:01 |
| *** wolverineav has joined #openstack-nova | 23:02 | |
| efried | mriedem, mordred: We ought to be able to fix that by exploiting some of the fancy schmancy discovery code in ksa, nah? | 23:02 |
| mordred | I mean - efried will probably beat me to it - but getting rid of that catalog_info parameter at least is a step in teh right direction | 23:02 |
| mordred | efried: yup! | 23:02 |
| sorrison | mriedem: re cinder catalog in nova.conf yes the only way we can get it to work is by setting endpoint_template | 23:02 |
| efried | You ought to be able to a) name your service any of the list of valid things, and b) search for the endpoint using any of that same list of valid things. | 23:02 |
| mordred | yup. and you should absolutely be able to omit service_name which should default to None | 23:03 |
| jaypipes | efried: unless I'm totally bonkers... but AFAIK, when Ironic is in the mix, that ProviderTree can contain thousands of root providers. | 23:03 |
| *** wolverineav has quit IRC | 23:03 | |
| efried | and yeah, long-standing TODO to get rid of all that bizarro client construction gorp | 23:03 |
| *** wolverineav has joined #openstack-nova | 23:03 | |
| mordred | and you should not only be able to omit service-type- you should really always omit service-type because using different service types is CRAZY - but you should be able to configure it anyway | 23:04 |
| mordred | efried: I started looking at all that before the summit, then had thanksgiving | 23:04 |
| mordred | I'd love to make a patch for y'all with a strawman of ripping a ton of gorp out | 23:04 |
| efried | I'll be happy to review same, but I'm not likely to have time to code it up myself, alas. | 23:05 |
| efried | I'm up to here | 23:05 |
| mordred | cool. well - you did the last one - so it's my turn this time I think | 23:06 |
| mriedem | efried: remember you had https://review.openstack.org/#/c/508345/ | 23:06 |
| mriedem | but very out of date by now | 23:06 |
| efried | oo, indeed | 23:06 |
| mordred | mriedem: yeah - I'll likely start by seeing if I can update that :) | 23:06 |
| * mordred loves deleting things | 23:07 | |
| efried | jaypipes: Hum, I see your point. I did have it rigged at some point to just invalidate the tree of the failing provider. That turned out to be nontrivial and hacky, which is why I went the "invalidate everything" route. But yeah, I may have to restore that logic :( | 23:08 |
| *** k_mouza has quit IRC | 23:15 | |
| *** mlavalle has quit IRC | 23:15 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make [cinder]/catalog_info no longer require a service_name https://review.openstack.org/620738 | 23:16 |
| mriedem | sorrison: see how ^ floats your boat | 23:16 |
| sorrison | mriedm: looks very buoyant, thanks! | 23:17 |
| *** N3l1x has quit IRC | 23:17 | |
| sorrison | Does anyone about any big openstack installs that connect to rabbitMQ with SSL, we've been having a lot of fun with https://bugs.launchpad.net/oslo.messaging/+bug/1800957/ so far it seems use of SSL for rabbit is very low | 23:20 |
| openstack | Launchpad bug 1800957 in oslo.messaging "Upgrading to pike version causes rabbit timeouts with ssl" [Undecided,Incomplete] - Assigned to Ken Giusti (kgiusti) | 23:20 |
| mriedem | sorrison: i seem to remember klindgren saying something similar a long time ago | 23:28 |
| mriedem | so maybe SpamapS has an idea? | 23:28 |
| *** tbachman has joined #openstack-nova | 23:29 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make [cinder]/catalog_info no longer require a service_name https://review.openstack.org/620738 | 23:33 |
| mriedem | cfriesen: jackding: fyi hpet related https://bugs.launchpad.net/nova/+bug/1805087 | 23:37 |
| openstack | Launchpad bug 1805087 in OpenStack Compute (nova) "libvirt+KVM: High CPU usage on Windows 10 (1803) guests" [Undecided,New] | 23:37 |
| *** erlon has joined #openstack-nova | 23:38 | |
| mriedem | turns out it's not just windriver OS images that need hpet | 23:38 |
| SpamapS | sorrison: mriedem yes GoDaddy does use TLS for RabbitMQ. I don't work there anymore though. | 23:42 |
| *** wolverineav has quit IRC | 23:42 | |
| SpamapS | With cells v1, and cells of up to 1000 hv's. | 23:42 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Note the aggregate allocation ratio restriction in scheduler docs https://review.openstack.org/620713 | 23:43 |
| sorrison | SpamapS: thanks. I'll send klindgren an email and get some more info off him | 23:43 |
| SpamapS | For cells v2 the TLS should still be in use, but the cells v2 deployment wasn't quite scaled out when I was there. | 23:43 |
| SpamapS | sorrison: out of curiosity, what issue are you seeing? | 23:44 |
| *** wolverineav has joined #openstack-nova | 23:44 | |
| sorrison | SpamapS: See https://bugs.launchpad.net/oslo.messaging/+bug/1800957/ basically timeouts waiting for replies | 23:45 |
| openstack | Launchpad bug 1800957 in oslo.messaging "Upgrading to pike version causes rabbit timeouts with ssl" [Undecided,Incomplete] - Assigned to Ken Giusti (kgiusti) | 23:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide a useful error message when trying to update non-compute services https://review.openstack.org/620667 | 23:45 |
| sorrison | SpamapS: been having a lot of fun as we didn't see this in testing and I'm still unsure why it happens, but I at least have found a reliable set of versions that work (basically the ocata versions) | 23:46 |
| SpamapS | sorrison: Yeah the big deploy at GoDaddy was still running Liberty when I left about 6 weeks ago. | 23:47 |
| SpamapS | the smaller deployment was Pike with cells v2. | 23:48 |
| SpamapS | RabbitMQ is basically the most hated thing on the OpenStack team at GoDaddy, so, I'm not sure anybody will give you a nuanced answer. ;) | 23:48 |
| sorrison | yeah I am aware of klindgren hate for rabbit, it's been stable for us over the last couple years up until pike upgrade | 23:49 |
| sorrison | we (nectar) have cellsv1, 13 cells ~1000 hypervisors | 23:50 |
| *** wolverineav has quit IRC | 23:51 | |
| *** slaweq has joined #openstack-nova | 23:54 | |
| *** tbachman has quit IRC | 23:55 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!