Wednesday, 2019-01-23

*** wolverineav has joined #openstack-nova00:00
*** tosky has quit IRC00:01
*** mmethot has joined #openstack-nova00:02
*** mriedem has quit IRC00:02
*** wolverineav has quit IRC00:05
*** wolverineav has joined #openstack-nova00:05
*** efried has joined #openstack-nova00:05
*** macza_ has quit IRC00:07
*** macza has joined #openstack-nova00:07
*** hongbin has quit IRC00:08
*** tetsuro has joined #openstack-nova00:17
*** dklyle has joined #openstack-nova00:21
openstackgerritMerged openstack/nova master: Convert port to str when validate console port  https://review.openstack.org/62685300:21
*** artom has joined #openstack-nova00:23
*** spsurya has quit IRC00:26
*** david-lyle has joined #openstack-nova00:27
*** mmethot has quit IRC00:29
*** dklyle has quit IRC00:30
*** mmethot has joined #openstack-nova00:30
*** _alastor_ has joined #openstack-nova00:46
*** TxGirlGeek has joined #openstack-nova00:47
*** mlavalle has quit IRC00:50
*** ileixe has joined #openstack-nova00:50
*** _alastor_ has quit IRC00:51
*** bhagyashris_ has joined #openstack-nova00:51
*** macza has quit IRC00:51
*** ileixe has quit IRC00:52
*** ileixe has joined #openstack-nova00:53
*** _fragatina has quit IRC01:00
*** _fragatina has joined #openstack-nova01:01
*** TxGirlGeek has quit IRC01:03
*** _fragatina has quit IRC01:05
*** _fragatina has joined #openstack-nova01:13
*** _alastor_ has joined #openstack-nova01:14
*** david-lyle has quit IRC01:14
*** vishwanathj has joined #openstack-nova01:17
*** liuyulong has quit IRC01:18
*** _alastor_ has quit IRC01:19
*** mmethot has quit IRC01:19
*** mmethot has joined #openstack-nova01:20
*** wolverineav has quit IRC01:23
*** tetsuro has quit IRC01:27
*** Kevin_Zheng has joined #openstack-nova01:32
*** lbragstad has quit IRC01:52
*** Dinesh_Bhor has joined #openstack-nova01:55
*** tetsuro has joined #openstack-nova01:56
*** Dinesh_Bhor has quit IRC02:00
*** tetsuro has quit IRC02:03
*** Dinesh_Bhor has joined #openstack-nova02:03
openstackgerritMerged openstack/nova master: Move simple execute call to processutils.  https://review.openstack.org/62152702:09
*** wolverineav has joined #openstack-nova02:12
*** _fragatina has quit IRC02:24
*** _fragatina has joined #openstack-nova02:25
*** hongbin has joined #openstack-nova02:25
*** _fragatina has quit IRC02:29
*** lbragstad has joined #openstack-nova02:33
*** vishwanathj has quit IRC02:34
*** psachin has joined #openstack-nova02:47
*** tiendc has joined #openstack-nova02:49
*** mmethot has quit IRC02:49
*** Dinesh_Bhor has quit IRC03:04
*** Dinesh_Bhor has joined #openstack-nova03:07
openstackgerrityenai proposed openstack/nova master: Disconnect volume when encryption is failed  https://review.openstack.org/63259803:09
*** tetsuro has joined #openstack-nova03:13
*** tkajinam_ has joined #openstack-nova03:13
*** tkajinam has quit IRC03:16
*** _fragatina has joined #openstack-nova03:19
*** _fragatina has quit IRC03:20
*** _fragatina has joined #openstack-nova03:20
*** _fragatina has quit IRC03:20
*** vishwanathj has joined #openstack-nova03:20
*** _fragatina has joined #openstack-nova03:20
*** _fragatina has quit IRC03:28
*** _fragatina has joined #openstack-nova03:29
*** awalende has joined #openstack-nova03:41
*** awalende has quit IRC03:45
*** khomesh24 is now known as khomesh|afk03:46
openstackgerritzhufl proposed openstack/nova master: Add missing ws seperator between words  https://review.openstack.org/63260603:46
*** wolverineav has quit IRC03:52
*** Dinesh_Bhor has quit IRC03:58
*** _fragatina has quit IRC03:59
*** udesale has joined #openstack-nova04:06
*** imacdonn_ has quit IRC04:12
*** hongbin has quit IRC04:18
*** ileixe has quit IRC04:22
*** cfriesen has quit IRC04:28
*** whoami-rajat has joined #openstack-nova04:35
*** _fragatina has joined #openstack-nova04:49
*** wolverineav has joined #openstack-nova04:50
*** _fragatina has quit IRC04:53
*** _fragatina has joined #openstack-nova04:53
*** _fragatina has quit IRC04:54
*** wolverineav has quit IRC04:54
*** _fragatina has joined #openstack-nova04:54
*** ileixe has joined #openstack-nova04:55
*** _fragatina has quit IRC04:56
*** _fragatina has joined #openstack-nova04:57
*** tkajinam_ is now known as tkajinam04:57
*** Dinesh_Bhor has joined #openstack-nova04:58
*** _fragatina has quit IRC04:59
*** _fragatina has joined #openstack-nova05:00
*** _fragatina has quit IRC05:03
*** mmethot has joined #openstack-nova05:03
*** _fragatina has joined #openstack-nova05:03
*** mmethot has quit IRC05:03
*** mmethot has joined #openstack-nova05:04
*** _fragatina has quit IRC05:06
*** mmethot has quit IRC05:06
*** _fragatina has joined #openstack-nova05:06
*** mmethot has joined #openstack-nova05:07
openstackgerritYongli He proposed openstack/nova master: Add server subresouce toplogy API  https://review.openstack.org/62147605:08
*** _fragatina has quit IRC05:08
*** _fragatina has joined #openstack-nova05:09
*** sridharg has joined #openstack-nova05:11
*** _fragatina has quit IRC05:13
*** _fragatina has joined #openstack-nova05:13
*** sapd1 has joined #openstack-nova05:21
*** dave-mccowan has quit IRC05:22
*** _fragatina has quit IRC05:25
*** _fragatina has joined #openstack-nova05:26
*** _fragatina has quit IRC05:28
*** _fragatina has joined #openstack-nova05:28
*** _fragatina has quit IRC05:29
*** _fragatina has joined #openstack-nova05:29
*** _fragatina has quit IRC05:30
*** _fragatina has joined #openstack-nova05:31
*** udesale has quit IRC05:32
*** _fragatina has quit IRC05:32
*** _fragatina has joined #openstack-nova05:33
*** licanwei has joined #openstack-nova05:33
*** udesale has joined #openstack-nova05:36
*** ratailor has joined #openstack-nova05:41
*** wolverineav has joined #openstack-nova05:51
openstackgerrityenai proposed openstack/nova master: Disconnect volume when encryption is failed  https://review.openstack.org/63259806:01
*** sunnaichuan_ has joined #openstack-nova06:04
*** ociuhandu has joined #openstack-nova06:05
*** ociuhandu_ has quit IRC06:06
*** spsurya has joined #openstack-nova06:08
*** wolverineav has quit IRC06:09
*** mmethot has quit IRC06:11
*** mmethot has joined #openstack-nova06:12
*** mmethot has quit IRC06:15
*** mmethot has joined #openstack-nova06:16
*** sapd1 has quit IRC06:23
*** _fragatina has quit IRC06:25
*** _fragatina has joined #openstack-nova06:25
*** wolverineav has joined #openstack-nova06:25
*** udesale has quit IRC06:28
*** udesale has joined #openstack-nova06:29
*** _fragatina has quit IRC06:29
*** _fragatina has joined #openstack-nova06:30
*** udesale has quit IRC06:30
*** udesale has joined #openstack-nova06:31
*** wolverineav has quit IRC06:32
*** udesale has quit IRC06:33
*** wolverineav has joined #openstack-nova06:42
openstackgerritzhufl proposed openstack/nova master: Add missing ws seperator between words  https://review.openstack.org/63260606:43
openstackgerritDakshina Ilangovan proposed openstack/nova-specs master: Nova changes to support Local Resource Management that uses Resource Management Daemon  https://review.openstack.org/63081706:44
*** wolverineav has quit IRC06:57
*** _fragatina has quit IRC06:58
*** _fragatina has joined #openstack-nova06:58
*** Luzi has joined #openstack-nova06:59
*** _fragatina has quit IRC06:59
*** _fragatina has joined #openstack-nova06:59
*** _fragatina has quit IRC07:00
*** _fragatina has joined #openstack-nova07:00
*** lbragstad has quit IRC07:06
*** _fragatina has quit IRC07:10
*** _fragatina has joined #openstack-nova07:11
*** moshele has joined #openstack-nova07:12
*** ociuhandu has quit IRC07:13
*** slaweq has joined #openstack-nova07:18
*** _fragatina has quit IRC07:27
*** _fragatina has joined #openstack-nova07:27
*** vishwanathj has quit IRC07:28
*** _fragatina has quit IRC07:28
*** _fragatina has joined #openstack-nova07:28
*** moshele has quit IRC07:29
*** _fragatina has quit IRC07:30
*** udesale has joined #openstack-nova07:30
*** _fragatina has joined #openstack-nova07:31
openstackgerritzhufl proposed openstack/nova master: Add missing ws seperator between words  https://review.openstack.org/63260607:40
*** awalende has joined #openstack-nova08:00
*** rcernin has quit IRC08:04
*** _fragatina has quit IRC08:06
*** _fragatina has joined #openstack-nova08:06
*** tkajinam has quit IRC08:10
*** tssurya has joined #openstack-nova08:17
*** _fragatina has quit IRC08:23
*** _fragatina has joined #openstack-nova08:23
*** rpittau has joined #openstack-nova08:28
*** panda|off is now known as panda08:28
*** Dinesh_Bhor has quit IRC08:31
*** khomesh|afk is now known as khomesh08:33
*** Dinesh_Bhor has joined #openstack-nova08:34
*** ralonsoh has joined #openstack-nova08:35
*** _fragatina has quit IRC08:38
*** _fragatina has joined #openstack-nova08:39
*** wolverineav has joined #openstack-nova08:40
*** helenafm has joined #openstack-nova08:40
*** ratailor_ has joined #openstack-nova08:42
*** wolverineav has quit IRC08:44
* kashyap goes to find what is 'openstack-tox-cover' job08:45
*** ratailor has quit IRC08:45
*** markvoelker has joined #openstack-nova08:47
*** maciejjozefczyk has quit IRC08:48
*** ccamacho has joined #openstack-nova08:49
*** maciejjozefczyk has joined #openstack-nova08:50
*** tosky has joined #openstack-nova08:50
*** rpittau has quit IRC08:51
*** rpittau has joined #openstack-nova08:52
*** markvoelker has quit IRC08:53
*** xek_ has joined #openstack-nova08:54
*** khomesh is now known as khomesh|afk08:57
openstackgerritZhenyu Zheng proposed openstack/nova master: Per-instance serial number  https://review.openstack.org/61995308:58
*** _fragatina has quit IRC09:01
*** _fragatina has joined #openstack-nova09:02
openstackgerrityenai proposed openstack/nova master: Ignore VolumeAttachmentNotFound exception in compute.manager  https://review.openstack.org/63265709:03
*** _fragatina has quit IRC09:03
*** gameon has joined #openstack-nova09:03
*** _fragatina has joined #openstack-nova09:04
gameonDoes anyone run AMD & Intel in their OpenStack environments together? Is it inadvisable?09:04
*** _fragatina has quit IRC09:05
*** _fragatina has joined #openstack-nova09:05
*** jaosorior has quit IRC09:05
*** _fragatina has quit IRC09:06
*** _fragatina has joined #openstack-nova09:06
*** rpittau has quit IRC09:07
*** jaosorior has joined #openstack-nova09:08
*** rpittau has joined #openstack-nova09:08
*** _fragatina has quit IRC09:10
*** _fragatina has joined #openstack-nova09:10
*** tetsuro has quit IRC09:11
*** _fragatina has quit IRC09:12
kashyapgameon: I'm not an operator, but as long as you ensure to schedule your guests in a "pool of AMD hosts" vs. "pool of Intel hosts", it should be fine?09:12
kashyapTo allow live migration compatibility09:12
*** _fragatina has joined #openstack-nova09:12
gameonkashyap: Thank you - I understand live migration wouldn't work, but the AMD pricing seems very keen these days!09:13
kashyapE.g. also check out: https://docs.openstack.org/nova/rocky/user/aggregates.html09:13
*** moshele has joined #openstack-nova09:13
kashyapgameon: Heh, yeah.  Also recall that last year we had a string of hardware CVEs09:13
kashyapSo ... that makes things "interesting".09:13
kashyapgameon: FWIW, I gave a talk at the recently concluded Berlin Summit on that: https://www.openstack.org/summit/berlin-2018/summit-schedule/events/22105/effective-virtual-cpu-configuration-in-nova09:14
kashyapThe slides are fairly self contained, and should give a sense of what's involved09:15
kashyap(For Operators, particularly this section is relevant: "x86: Updating to patched vCPU models")09:15
gameonThank you very much, that's really helpful. I was at the Summit but didn't catch your talk :)09:17
kashyapgameon: Also Nova has this thing called "host aggregates", that lets the scheduler make more sensible decisions based on certain properties.09:17
kashyapgameon: Yeah, no worries.  There's too much input at these events, and human attention is limited :-)09:18
*** priteau has joined #openstack-nova09:18
*** ociuhandu has joined #openstack-nova09:21
*** rpittau has quit IRC09:22
*** rpittau has joined #openstack-nova09:22
*** dtantsur|afk is now known as dtantsur09:23
*** maciejjozefczyk has quit IRC09:24
*** _fragatina has quit IRC09:25
*** _fragatina has joined #openstack-nova09:25
*** awalende has quit IRC09:26
*** _fragatina has quit IRC09:26
*** _fragatina has joined #openstack-nova09:26
*** ttsiouts has joined #openstack-nova09:26
*** jangutter has quit IRC09:27
*** awalende has joined #openstack-nova09:29
*** derekh has joined #openstack-nova09:31
*** maciejjozefczyk has joined #openstack-nova09:32
*** awalende has quit IRC09:33
*** awalende has joined #openstack-nova09:35
*** ratailor_ has quit IRC09:41
*** jangutter has joined #openstack-nova09:42
*** bhagyashris_ has quit IRC09:43
*** ratailor has joined #openstack-nova09:45
*** ttsiouts has quit IRC09:47
*** ttsiouts has joined #openstack-nova09:48
*** markvoelker has joined #openstack-nova09:49
*** ttsiouts_ has joined #openstack-nova09:49
*** ttsiouts has quit IRC09:50
*** rpittau has quit IRC09:52
*** rpittau has joined #openstack-nova09:53
*** awalende has quit IRC09:54
*** awalende has joined #openstack-nova09:55
kashyapmdbooth: Hi, when you get a moment, I'm stumped with this unit test failure (after MIN{LIBVIRT_QEMU}_VERSION bump): http://logs.openstack.org/07/632507/2/check/openstack-tox-py27/6f87de4/testr_results.html.gz09:56
* mdbooth looks09:57
kashyap(See the first one: test_get_guest_config_ppc64_through_image_meta_spice_enabled)09:57
*** awalende has quit IRC09:57
kashyap[...]09:57
kashyap    raise mismatch_error09:57
kashyaptesttools.matchers._impl.MismatchError: '<nova.virt.libvirt.config.LibvirtConfigMemoryBalloon object at 0x7f10ac940150>' is not an instance of LibvirtConfigGuestVideo09:57
kashyap[...]09:57
*** awalende has joined #openstack-nova09:57
openstackgerritcaoxufeng proposed openstack/nova master: oslo.config==6.8.0 requires rfc3986>=1.2.0 and requirements project had made rfc3986==1.2.0 in upper-constraints.txt,so modify it .  https://review.openstack.org/63239109:57
mdboothkashyap: Looking at your patch09:58
*** awalende has quit IRC10:00
*** awalende has joined #openstack-nova10:01
mdboothkashyap: Ok, I can reproduce the failure locally10:02
kashyapNod10:03
kashyap(There's a typo in the commit message: 1.3.1 --> 3.0.0)10:03
kashyap(But that's besides the point.)10:04
mdboothkashyap: Ok, to start off with this is just a bad test.10:05
mdboothself._test_get_guest_config_ppc64(8)10:05
*** awalende has quit IRC10:06
mdbooth8 is an uncommented bare constant, the best kind of constant10:06
mdboothIt appears to describe the expected location of the video device in the ordered list of devices generates by _get_guest_config10:07
mdboothI can't imagine why that's a good idea10:07
*** rpittau has quit IRC10:07
kashyapYeah, there's many of those undocumented constants :-(10:07
*** rpittau has joined #openstack-nova10:07
kashyapThere are in total 33 failures, though.  Still ploughing through10:08
mdboothSo my expectation is that if we go dig in _get_guest_config, something in there is guarding the creation of devices based on libvirt or qemu version number10:08
mdboothWhich breaks this test, which expects its device to be at exactly position 810:08
mdboothIt's a stupid test, but unfortunately you have to fix it now10:08
kashyapYeah, I have that open, and looking at it10:08
* mdbooth has already been crucified on that hill10:09
kashyapHad the same thing last year -- spent weeks fixing all kinds of unit test failures due to the bump10:09
kashyapmdbooth: Thanks for the hint10:10
mdboothIt's almost as bad as the 'code diff' tests we used to write, but fortunately seem to be going out of fashion now.10:10
*** Dinesh_Bhor has quit IRC10:15
*** _alastor_ has joined #openstack-nova10:18
*** erlon_ has joined #openstack-nova10:18
*** Dinesh_Bhor has joined #openstack-nova10:20
*** Dinesh_Bhor has quit IRC10:21
*** markvoelker has quit IRC10:22
*** rpittau has quit IRC10:22
*** rpittau has joined #openstack-nova10:22
kashyapmdbooth: So if I changed the position from 8 --> 7 "it succeeds":10:23
kashyap-        self._test_get_guest_config_ppc64(8)10:23
kashyap+        self._test_get_guest_config_ppc64(7)10:23
*** awalende has joined #openstack-nova10:23
kashyapThat "solution" makes me feel physically stupid.10:23
*** _alastor_ has quit IRC10:24
mdboothkashyap: If you do that: https://goo.gl/images/6ehtJv10:24
kashyap:D10:25
mdboothkashyap: Although it might be the pragmatic thing to do. The problem is that the correct thing to do here is to determine what the test was actually trying to test, and rewrite it so that it tests it.10:26
mdboothThat would require mental effort from the reviewer which you may find hard to come by.10:26
kashyapYeah, I will freely admit that I'm "still in the process of grokking it all"10:26
mdboothFrom experience, I can say that nobody likes reviewing long series of test fixes.10:26
kashyapmdbooth: Yeah, I don't think anyone gives a damn thing about it10:27
*** awalende has quit IRC10:27
kashyapmdbooth: I will for now do the "pragmatic thing" (I feel really dirty doing it)10:27
mdboothAt least write a comment containing an apology and blaming somebody else ;)10:27
kashyapBecause I hate that I don't understand the root cause entirely.  I probably will if I spend my whole day duking around various files10:27
*** awalende has joined #openstack-nova10:27
kashyapmdbooth: Yeah, good point.10:27
kashyap"Leave the trace for the poor sucker who comes later."10:27
*** awalende_ has joined #openstack-nova10:29
*** wolverineav has joined #openstack-nova10:30
*** awalende has quit IRC10:32
*** wolverineav has quit IRC10:34
*** pcaruana has joined #openstack-nova10:37
*** rpittau has quit IRC10:37
*** _fragatina has quit IRC10:38
*** _fragatina has joined #openstack-nova10:38
*** rpittau has joined #openstack-nova10:40
openstackgerritcaoxufeng proposed openstack/nova master: oslo.config==6.8.0 requires rfc3986>=1.2.0 and requirements project had made rfc3986==1.2.0 in upper-constraints.txt,so modify it .  https://review.openstack.org/63239110:42
*** cdent has joined #openstack-nova10:45
*** khomesh|afk is now known as khomesh10:52
*** rpittau has quit IRC10:52
*** rpittau has joined #openstack-nova10:53
*** andreaf has quit IRC10:54
*** mmethot has quit IRC10:54
*** mmethot has joined #openstack-nova10:55
*** andreaf has joined #openstack-nova10:56
*** udesale has quit IRC10:57
*** moshele has quit IRC10:57
*** ileixe has quit IRC10:59
*** ttsiouts_ has quit IRC11:01
*** ttsiouts has joined #openstack-nova11:02
*** ttsiouts has quit IRC11:06
*** rpittau has quit IRC11:08
*** rpittau has joined #openstack-nova11:11
*** yan0s has joined #openstack-nova11:15
*** _fragatina has quit IRC11:18
*** _fragatina has joined #openstack-nova11:19
*** markvoelker has joined #openstack-nova11:20
*** _fragatina has quit IRC11:21
*** _fragatina has joined #openstack-nova11:21
*** _fragatina has quit IRC11:23
*** _fragatina has joined #openstack-nova11:24
*** _fragatina has quit IRC11:25
*** _fragatina has joined #openstack-nova11:25
*** _fragatina has quit IRC11:28
*** ttsiouts has joined #openstack-nova11:28
*** _fragatina has joined #openstack-nova11:28
*** khomesh is now known as khomesh|gone11:32
*** Dinesh_Bhor has joined #openstack-nova11:35
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec  https://review.openstack.org/57020111:39
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: Add instance hard delete  https://review.openstack.org/57020211:39
openstackgerritTheodoros Tsioutsias proposed openstack/nova master: [WIP] Enable rebuild for instances in cell0  https://review.openstack.org/57020311:39
*** Dinesh_Bhor has quit IRC11:40
*** moshele has joined #openstack-nova11:40
*** _fragatina has quit IRC11:45
*** _fragatina has joined #openstack-nova11:45
*** _fragatina has quit IRC11:47
*** _fragatina has joined #openstack-nova11:48
*** markvoelker has quit IRC11:52
*** tiendc has quit IRC11:53
*** sum12 has quit IRC11:59
*** mmethot has quit IRC12:02
*** _fragatina has quit IRC12:06
*** _fragatina has joined #openstack-nova12:07
*** ratailor has quit IRC12:08
*** _fragatina has quit IRC12:09
*** _fragatina has joined #openstack-nova12:09
*** mmethot has joined #openstack-nova12:10
*** dpawlik has joined #openstack-nova12:11
*** _fragatina has quit IRC12:14
*** _fragatina has joined #openstack-nova12:14
*** _fragatina has quit IRC12:18
*** _fragatina has joined #openstack-nova12:19
*** _alastor_ has joined #openstack-nova12:21
*** _alastor_ has quit IRC12:25
*** panda is now known as panda|launch12:32
*** cdent has quit IRC12:34
*** _fragatina has quit IRC12:34
*** _fragatina has joined #openstack-nova12:35
*** _fragatina has quit IRC12:37
*** _fragatina has joined #openstack-nova12:37
*** mmethot has quit IRC12:38
*** _fragatina has quit IRC12:38
*** _fragatina has joined #openstack-nova12:38
*** mmethot has joined #openstack-nova12:40
*** psachin has quit IRC12:40
kashyapmdbooth: Tiny progress!12:47
kashyapI at least see a "pattern" that some of these tests seem to fail only when I update FAKE_QEMU_VERSION12:48
kashyapIf that is unchanged, then the test succeeds.12:48
*** markvoelker has joined #openstack-nova12:49
mdboothkashyap: But you need to change it...12:50
kashyapYes, yes.  I was isolating the problem12:50
kashyapmdbooth: For example, see this small PDB session w/ & without my patch for guest.devices: http://paste.openstack.org/show/743172/12:50
kashyapThis is a different test that also fails due to:12:51
kashyap    self.assertEqual(2, len(guest.devices))12:51
kashyap  [...]12:51
kashyap   testtools.matchers._impl.MismatchError: 2 != 112:51
kashyapThe fakelibvirt.py is "misbehaving" due to the version change.12:52
* kashyap --> coffee; my head is aching12:52
*** mmethot has quit IRC12:52
*** panda|launch is now known as panda12:53
* mdbooth looks to see what part of libvirt xml generation are dependent on qemu version12:53
*** ttsiouts has quit IRC12:53
*** cdent has joined #openstack-nova12:54
*** ttsiouts has joined #openstack-nova12:54
*** _fragatina has quit IRC12:54
*** _fragatina has joined #openstack-nova12:55
*** priteau has quit IRC12:55
*** mmethot has joined #openstack-nova12:57
*** ttsiouts has quit IRC12:58
*** ttsiouts has joined #openstack-nova12:59
mdboothkashyap: There are way too many version checks for me to audit quickly. Honestly I'm not sure it's worth it, though. Could you not just change the test to scan the list of the devices for the one it's looking for?12:59
*** _fragatina has quit IRC13:05
kashyapI think I've got a lead; will update once done.13:05
kashyapmdbooth: Please disregard me for now.13:05
*** _fragatina has joined #openstack-nova13:06
mdboothkashyap: If I wanted to track it down quickly, I'd modify the unit test to spit out the device list, compare the generated devices with and without the bumped version number, then go find the guard in that code.13:07
* mdbooth expects we're not outputting a controller or something like that.13:08
kashyapmdbooth: I don't know how to get the device list.13:08
*** pchavva has joined #openstack-nova13:08
kashyapThat's why I went the PDB route with and without my patch13:08
*** sunnaichuan_ has quit IRC13:09
kashyapAnd got that: dir(guest.devices[0]) output at the bottom: http://paste.openstack.org/raw/743168/13:09
mdboothkashyap: Right, so you've worked out what device was removed?13:09
kashyap'port' seems to be missing on the second iteration13:10
kashyapmdbooth: And ... weirdly enough, see this comment from migi on the review:13:10
kashyaphttps://review.openstack.org/#/c/632507/2/nova/virt/libvirt/driver.py13:10
*** artom has quit IRC13:10
kashyapHe says updating MIN_QEMU_VIRTLOGD from 2.7.0 --> 2.9.0 "fixes" it.13:11
kashyapBut...that constant will also be removed, as the new MIN satisfies the condition.13:11
kashyapIf you're on something else, ignore it.  Don't split your attention13:11
*** markvoelker has quit IRC13:22
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Convert port to str when validate console port  https://review.openstack.org/63272013:29
*** tbachman has joined #openstack-nova13:39
*** dave-mccowan has joined #openstack-nova13:43
kashyapHaha, I was wondering why on _earth_ a particular console code behaviour is the way it is ... and the code comment points to a RHT Bugzilla.13:51
kashyapI click it ... and it points to a bug I filed  in Jan-2012! -- https://bugzilla.redhat.com/show_bug.cgi?id=78146713:51
openstackbugzilla.redhat.com bug 781467 in libvirt "RFE: virsh: 'console' support for non-PTY (unix, tcp)" [Medium,New] - Assigned to libvirt-maint13:51
*** mriedem has joined #openstack-nova13:56
*** moshele has quit IRC13:57
*** tbachman has quit IRC14:00
*** panda is now known as panda|brb14:03
*** wolverineav has joined #openstack-nova14:06
*** _fragatina has quit IRC14:07
*** panda|brb is now known as panda14:08
*** mriedem has quit IRC14:10
*** wolverineav has quit IRC14:10
*** ralonsoh has quit IRC14:11
*** _fragatina has joined #openstack-nova14:12
*** _fragatina has quit IRC14:12
*** awaugama has quit IRC14:12
openstackgerritMaciej Jozefczyk proposed openstack/nova master: Add fill_virtual_interface_list online_data_migration script  https://review.openstack.org/61416714:12
openstackgerritMaciej Jozefczyk proposed openstack/nova master: Force refresh instance info_cache during heal  https://review.openstack.org/59160714:12
*** _fragatina has joined #openstack-nova14:12
jaypipesbelmoreira: good afternoon, sir. just wondering if you'd found any time to test out that single-query-per-cell instance info fetcher patch (https://review.openstack.org/#/c/623558/)? no worries if not, I know you're super busy14:13
*** ralonsoh has joined #openstack-nova14:15
*** lbragstad has joined #openstack-nova14:19
*** pchavva has left #openstack-nova14:20
*** artom has joined #openstack-nova14:21
kashyapIt is so cathartic to "remove" code...14:28
kashyapReminds me of the quote from UNIX hero, Douglas Mcilroy: https://en.wikipedia.org/wiki/Douglas_McIlroy#Views_on_computing14:28
cdentkashyap: quite: https://review.openstack.org/#/c/618215/14:31
* kashyap clicks14:31
kashyapAlso as Elements of Style says: "Omit needless words"14:31
kashyapcdent: Whoa ... /me bows14:31
kashyapIt is nearing merging14:31
cdentthat's the smaller of two. the one to remove the placement tests (already merged) was more lines (but much of it yaml)14:32
kashyapThat `diff stat` ... nice work.  I guess the new repo is shaping up nice and well14:33
* kashyap wasn't keeping up with that area (only so much human attention).14:33
cdentyeah, external placement is what runs in the intergrated gate now14:34
*** eharney has joined #openstack-nova14:34
kashyapNaice14:35
*** artom has quit IRC14:37
*** cdent has quit IRC14:41
*** dpawlik has quit IRC14:47
openstackgerritEric Fried proposed openstack/nova master: ksa auth conf and client for cyborg access  https://review.openstack.org/63124214:50
*** awaugama has joined #openstack-nova14:51
*** xek_ is now known as xek14:58
*** _fragatina has quit IRC15:02
*** _fragatina has joined #openstack-nova15:03
*** mlavalle has joined #openstack-nova15:03
*** cfriesen has joined #openstack-nova15:04
*** efried has quit IRC15:08
openstackgerritKashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein"  https://review.openstack.org/63250715:09
*** hongbin has joined #openstack-nova15:11
*** ttsiouts has quit IRC15:13
*** cdent has joined #openstack-nova15:14
*** ttsiouts has joined #openstack-nova15:14
*** KeithMnemonic has joined #openstack-nova15:15
*** dklyle has joined #openstack-nova15:17
*** ttsiouts has quit IRC15:19
*** udesale has joined #openstack-nova15:22
*** awalende_ has quit IRC15:25
*** awalende has joined #openstack-nova15:25
*** Luzi has quit IRC15:30
*** awalende has quit IRC15:30
*** efried has joined #openstack-nova15:30
*** ttsiouts has joined #openstack-nova15:35
*** mchlumsky has joined #openstack-nova15:37
*** mchlumsky has quit IRC15:41
*** mchlumsky has joined #openstack-nova15:42
*** mmethot_ has joined #openstack-nova15:45
*** TxGirlGeek has joined #openstack-nova15:46
efriedcdent, melwitt: I probably won't make the nova IRC meeting tomorrow; will be on the road again. Not much worth reporting from the n-sch meeting.15:46
cdent15:47
*** mmethot_ has quit IRC15:47
sean-k-mooneycdent: do you keep that tick copy pasted or is there a keyboard sort cut for it15:47
*** tbachman has joined #openstack-nova15:47
*** mmethot_ has joined #openstack-nova15:48
cdenti've got my keyboard setup to allow inputting unicode codepoints and have that one memorize opt/alt+271415:48
*** mmethot has quit IRC15:49
*** igordc has joined #openstack-nova15:52
*** helenafm has quit IRC15:54
*** _fragatina has quit IRC15:55
*** _fragatina has joined #openstack-nova15:56
melwittefried: ack15:59
*** jmlowe has joined #openstack-nova15:59
*** jmlowe has quit IRC16:00
*** _alastor_ has joined #openstack-nova16:00
*** tbachman has quit IRC16:01
*** prometheanfire has joined #openstack-nova16:02
prometheanfirenew libvirt-python (5.0.0) has been proposed to upperconstaints, just an fyi16:02
*** dklyle has quit IRC16:02
*** artom has joined #openstack-nova16:03
*** efried has quit IRC16:03
*** jmlowe has joined #openstack-nova16:06
*** udesale has quit IRC16:10
kashyapprometheanfire: Got the change URL handy?16:11
kashyapThe next min libvirt version for "Train" release is 4.0.0.16:11
kashyapIIRC, we should stick to matching libvirt-python binding.16:12
* kashyap on a call; bbiab16:12
prometheanfirehttps://www.libvirt.org/news.html ?16:14
prometheanfirekashyap: iirc libvirt-python maintains backwards compat16:14
kashyapprometheanfire: Oh, certainly it does16:15
kashyapBut, I'm forgetting some "fine print" that a libvirt dev told on IRC some months ago16:15
kashyapWhen proposing a higher libvirt-python version, I'd appreciate people noting rationale in the commit message, too.16:16
prometheanfireLOL16:16
prometheanfirehttps://github.com/libvirt/libvirt-python/compare/v4.10.0...v5.0.016:16
prometheanfireone change16:16
kashyapprometheanfire: You should compare 4.0.0, not 4.10.0.16:17
kashyaphttps://github.com/libvirt/libvirt-python/compare/v4.0.0...v5.0.016:17
kashyapMany many changes in there.16:17
prometheanfirelibvirt-python is already on 4.10.016:18
prometheanfirefor master16:18
*** gyee has joined #openstack-nova16:23
*** dklyle has joined #openstack-nova16:24
*** efoley has joined #openstack-nova16:25
*** efoley has left #openstack-nova16:26
*** _fragatina has quit IRC16:29
*** _fragatina has joined #openstack-nova16:29
*** tbachman has joined #openstack-nova16:30
*** gameon has quit IRC16:36
*** avolkov has quit IRC16:39
*** macza has joined #openstack-nova16:41
*** mmethot_ has quit IRC16:50
*** mmethot_ has joined #openstack-nova16:50
*** mmethot_ has quit IRC16:51
*** mmethot_ has joined #openstack-nova16:52
*** dklyle has quit IRC16:55
*** _fragatina has quit IRC16:56
*** dklyle has joined #openstack-nova16:56
*** _fragatina has joined #openstack-nova16:56
*** igordc has quit IRC16:56
*** rpittau has quit IRC16:58
*** _fragatina has quit IRC16:58
*** _fragatina has joined #openstack-nova16:59
*** tssurya has quit IRC17:00
*** wolverineav has joined #openstack-nova17:00
*** dklyle has quit IRC17:01
*** dklyle has joined #openstack-nova17:01
*** ttsiouts has quit IRC17:01
*** ttsiouts has joined #openstack-nova17:02
*** igordc has joined #openstack-nova17:04
*** wolverineav has quit IRC17:04
*** ttsiouts has quit IRC17:07
kashyapSure.  I said v4.4.0 because that's the version we are targetting for "Train".  If there is a review change, post it there.  /me needs to be AFK soon.17:07
openstackgerritStephen Finucane proposed openstack/nova master: Make 'plugin' a required argument for '_get_vif_instance'  https://review.openstack.org/60827917:11
openstackgerritStephen Finucane proposed openstack/nova master: Remove get_config_vhostuser  https://review.openstack.org/56547117:11
*** dklyle has quit IRC17:13
belmoreirajaypipes: by the end of week we expect to test the "cherry-pick" of efried patch for placement requests (tssurya is working on it). After, we will do yours (we need to check how much different is your approach comparing with what we currently have and how difficult it is to have it in rocky)17:18
jaypipesbelmoreira: cool :) thanks!17:18
openstackgerritJack Ding proposed openstack/nova master: Flavor extra spec and image properties validation  https://review.openstack.org/62070617:21
*** awalende has joined #openstack-nova17:26
*** awalende has quit IRC17:31
*** TxGirlGeek has quit IRC17:35
*** TxGirlGeek has joined #openstack-nova17:37
*** dklyle has joined #openstack-nova17:39
*** sridharg has quit IRC17:40
*** moshele has joined #openstack-nova17:47
*** dklyle has quit IRC17:48
*** yan0s has quit IRC17:51
*** canori01 has joined #openstack-nova17:51
canori01hey guys, if I need to send nova notifications to multiple rabbit queues, is there more two it than just adding the notification topic?  I am running both ceilometer and designate so I have "notification_topics = notifications,notifications_designate" in my config...but while the notifications queue gets the messages, notifications_designate doesn't get anything17:53
*** moshele has quit IRC17:54
*** _fragatina has quit IRC17:54
*** dtantsur is now known as dtantsur|afk17:55
*** _fragatina has joined #openstack-nova17:55
*** tbachman has quit IRC17:55
*** _fragatina has quit IRC17:57
*** _fragatina has joined #openstack-nova17:58
*** jmlowe has quit IRC17:58
*** tbachman has joined #openstack-nova17:59
*** jmlowe has joined #openstack-nova18:00
*** derekh has quit IRC18:00
*** _fragatina has quit IRC18:05
*** _fragatina has joined #openstack-nova18:06
*** mmethot_ has quit IRC18:06
*** mmethot_ has joined #openstack-nova18:08
*** ralonsoh has quit IRC18:11
*** _fragatina has quit IRC18:12
*** mmethot_ has quit IRC18:12
*** _fragatina has joined #openstack-nova18:13
*** eharney has quit IRC18:16
*** _fragatina has quit IRC18:20
*** _fragatina has joined #openstack-nova18:20
*** eharney has joined #openstack-nova18:22
*** dklyle has joined #openstack-nova18:24
*** dklyle has quit IRC18:29
*** TxGirlGeek has quit IRC18:29
*** TxGirlGeek has joined #openstack-nova18:36
*** wolverineav has joined #openstack-nova18:37
*** wolverineav has quit IRC18:38
*** wolverineav has joined #openstack-nova18:38
*** _fragatina has quit IRC18:38
*** _fragatina has joined #openstack-nova18:39
*** _fragatina_ has joined #openstack-nova18:39
*** _fragatina has quit IRC18:39
*** dklyle has joined #openstack-nova18:48
*** _fragatina_ has quit IRC18:48
*** ociuhandu has quit IRC18:49
*** _fragatina has joined #openstack-nova18:49
*** _fragatina has quit IRC18:49
stephenfincanori01: Maybe try again tomorrow earlier in UTC when gibi is about?18:49
* stephenfin doesn't know of the top of his head18:49
*** _fragatina has joined #openstack-nova18:50
*** dklyle has quit IRC18:54
*** mugsie has quit IRC18:55
*** mugsie has joined #openstack-nova18:57
*** tbachman has quit IRC19:09
*** tbachman has joined #openstack-nova19:10
*** wolverineav has quit IRC19:26
*** wolverineav has joined #openstack-nova19:28
*** wolverineav has quit IRC19:28
*** wolverineav has joined #openstack-nova19:29
*** _fragatina has quit IRC19:29
*** TxGirlGeek has quit IRC19:29
*** _fragatina has joined #openstack-nova19:29
*** _fragatina has quit IRC19:33
*** _fragatina has joined #openstack-nova19:34
*** _fragatina has quit IRC19:39
*** _fragatina has joined #openstack-nova19:40
*** _fragatina has quit IRC19:40
*** _fragatina has joined #openstack-nova19:41
*** dpawlik has joined #openstack-nova19:41
*** wolverineav has quit IRC19:45
*** TxGirlGeek has joined #openstack-nova19:46
*** wolverineav has joined #openstack-nova19:49
*** xek has quit IRC19:50
*** dklyle has joined #openstack-nova19:50
*** xek has joined #openstack-nova19:50
*** dklyle has quit IRC19:53
*** wolverineav has quit IRC19:54
*** spsurya has quit IRC19:55
*** erlon_ has quit IRC20:02
*** _fragatina has quit IRC20:05
*** _fragatina has joined #openstack-nova20:06
*** _fragatina has quit IRC20:06
*** _fragatina has joined #openstack-nova20:07
*** _fragatina has quit IRC20:14
openstackgerritHang Yang proposed openstack/nova master: Fix port dns_name reset  https://review.openstack.org/63168420:18
*** dpawlik has quit IRC20:19
*** dklyle has joined #openstack-nova20:20
*** wolverineav has joined #openstack-nova20:24
*** mmethot has joined #openstack-nova20:25
*** wolverineav has quit IRC20:28
*** dklyle has quit IRC20:29
*** jmlowe has quit IRC20:31
*** jmlowe has joined #openstack-nova20:33
*** wolverineav has joined #openstack-nova20:35
*** dklyle has joined #openstack-nova20:49
*** mriedem has joined #openstack-nova20:56
*** awaugama has quit IRC20:58
*** Kimmo_ has quit IRC20:58
*** zul has quit IRC20:59
*** eharney has quit IRC21:04
*** dklyle has quit IRC21:10
edleafegs21:21
*** awalende has joined #openstack-nova21:22
*** dklyle has joined #openstack-nova21:22
*** awalende has quit IRC21:26
*** dklyle has quit IRC21:28
*** tinwood has quit IRC21:29
*** tinwood has joined #openstack-nova21:30
*** xek has quit IRC21:35
*** _fragatina has joined #openstack-nova21:39
*** dklyle has joined #openstack-nova21:42
*** whoami-rajat has quit IRC21:45
*** tinwood has quit IRC21:52
*** tinwood has joined #openstack-nova21:54
*** eharney has joined #openstack-nova22:00
*** dklyle has quit IRC22:01
*** rcernin has joined #openstack-nova22:03
openstackgerritJack Ding proposed openstack/nova master: Flavor extra spec and image properties validation  https://review.openstack.org/62070622:05
*** Shilpa has joined #openstack-nova22:09
*** ShilpaSD has quit IRC22:12
*** jmlowe has quit IRC22:21
*** jmlowe has joined #openstack-nova22:23
*** dave-mccowan has quit IRC22:25
*** tinwood has quit IRC22:34
*** wolverineav has quit IRC22:38
*** cdent has quit IRC22:39
*** tinwood has joined #openstack-nova22:41
*** wolverineav has joined #openstack-nova22:48
*** tkajinam has joined #openstack-nova22:59
*** mchlumsky has quit IRC23:04
*** mlavalle has quit IRC23:15
*** mmethot has quit IRC23:19
*** jmlowe has quit IRC23:19
*** mmethot has joined #openstack-nova23:21
*** wolverineav has quit IRC23:22
*** wolverineav has joined #openstack-nova23:26
*** mmethot has quit IRC23:26
*** mmethot has joined #openstack-nova23:27
*** wolverineav has quit IRC23:30
*** mmethot has quit IRC23:34
*** dklyle has joined #openstack-nova23:34
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: implement reshaper for vgpu  https://review.openstack.org/59920823:35
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for libvirt vgpu reshape  https://review.openstack.org/63155923:35
mriedemartom: bauzas: jaypipes: consider the libvirt reshaper patch reshaped ^23:35
mriedemactually i removed _get_vgpu_total so need to remove some test stuff with it23:36
mriedemnot sure why bauzas didn't just remove _get_vgpu_total23:36
*** mmethot has joined #openstack-nova23:36
*** wolverineav has joined #openstack-nova23:37
*** dklyle has quit IRC23:40
*** tosky has quit IRC23:43
*** mmethot has quit IRC23:47
*** mriedem has quit IRC23:48
*** mmethot has joined #openstack-nova23:48
*** mmethot has quit IRC23:49
*** mmethot has joined #openstack-nova23:49
*** dklyle has joined #openstack-nova23:54
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: implement reshaper for vgpu  https://review.openstack.org/59920823:54
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for libvirt vgpu reshape  https://review.openstack.org/63155923:54
*** mmethot has quit IRC23:55
*** mmethot has joined #openstack-nova23:55
*** mmethot has quit IRC23:57
*** mmethot has joined #openstack-nova23:58
*** mmethot has quit IRC23:58
*** mmethot has joined #openstack-nova23:59
*** mmethot has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!