| *** owalsh_ has joined #openstack-nova | 00:01 | |
| *** owalsh has quit IRC | 00:02 | |
| *** owalsh has joined #openstack-nova | 00:05 | |
| *** owalsh_ has quit IRC | 00:06 | |
| *** igordc has quit IRC | 00:07 | |
| *** mchlumsky_ has quit IRC | 00:08 | |
| *** mchlumsky_ has joined #openstack-nova | 00:09 | |
| *** owalsh_ has joined #openstack-nova | 00:09 | |
| *** artom has joined #openstack-nova | 00:09 | |
| *** owalsh has quit IRC | 00:10 | |
| *** owalsh has joined #openstack-nova | 00:13 | |
| *** hamzy has joined #openstack-nova | 00:14 | |
| *** owalsh_ has quit IRC | 00:14 | |
| *** gyee has quit IRC | 00:15 | |
| openstackgerrit | Tony Breeds proposed openstack/nova master: Uncap jsonschema https://review.openstack.org/651943 | 00:16 |
|---|---|---|
| openstackgerrit | Tony Breeds proposed openstack/nova master: Add pep8 to test-requirements https://review.openstack.org/651944 | 00:16 |
| *** tetsuro has joined #openstack-nova | 00:17 | |
| tonyb | efried, stephenfin: ^^ the first is unrelated to your hacking work but is required | 00:17 |
| tonyb | efried, stephenfin: the second just makes it explict and clear why we're adding pep8 | 00:17 |
| *** owalsh_ has joined #openstack-nova | 00:18 | |
| *** mlavalle has quit IRC | 00:18 | |
| *** owalsh has quit IRC | 00:19 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add --instance option to heal_allocations https://review.openstack.org/651945 | 00:20 |
| mriedem | ceryx: eandersson: ^ | 00:20 |
| mriedem | if you want to just work on that one problem instance | 00:20 |
| mriedem | zzzeek: we figured it out | 00:20 |
| *** owalsh has joined #openstack-nova | 00:21 | |
| *** lbragstad has quit IRC | 00:23 | |
| *** owalsh_ has quit IRC | 00:23 | |
| *** owalsh_ has joined #openstack-nova | 00:26 | |
| *** owalsh has quit IRC | 00:27 | |
| *** owalsh has joined #openstack-nova | 00:31 | |
| *** amodi has quit IRC | 00:32 | |
| *** owalsh_ has quit IRC | 00:32 | |
| *** owalsh_ has joined #openstack-nova | 00:35 | |
| *** owalsh has quit IRC | 00:36 | |
| *** yedongcan has joined #openstack-nova | 00:37 | |
| *** owalsh has joined #openstack-nova | 00:39 | |
| *** owalsh_ has quit IRC | 00:40 | |
| openstackgerrit | Merged openstack/python-novaclient stable/stein: Revert "Fix crashing console-log" https://review.openstack.org/650363 | 00:40 |
| mriedem | efried: i just realized that this is always True https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L403 | 00:41 |
| mriedem | because Flavor.extra_specs is always loaded | 00:41 |
| mriedem | it doesn't mean extra_specs is not empty | 00:41 |
| mriedem | and that's extremely important because for a volume-backed server, we could otherwise be trying to PUT allocations with DISK_GB=0 | 00:42 |
| mriedem | which is a no-no | 00:42 |
| *** owalsh_ has joined #openstack-nova | 00:43 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Warn for duplicate host mappings during discover_hosts https://review.openstack.org/651947 | 00:43 |
| *** owalsh has quit IRC | 00:44 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.openstack.org/651948 | 00:45 |
| *** owalsh has joined #openstack-nova | 00:47 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.openstack.org/651948 | 00:47 |
| *** owalsh_ has quit IRC | 00:48 | |
| eandersson | We removed the dups in the allocation table and re-ran the script and it worked | 00:49 |
| eandersson | but that would have been neat | 00:51 |
| *** owalsh_ has joined #openstack-nova | 00:51 | |
| mriedem | eandersson: ok so now you just have the 2 allocations records for the one instance consumer against the same compute node resource provider that you'd expect for that instance? | 00:51 |
| eandersson | Yea | 00:52 |
| mriedem | i.e. instance.node matches the compute_nodes table record matches the rp | 00:52 |
| mriedem | ok cool | 00:52 |
| mriedem | so i'm still guessing the multiple allocations against multiple providers was a result of failed migrations where the allocations - created by the scheduler - weren't cleaned up properly | 00:52 |
| *** owalsh has quit IRC | 00:52 | |
| eandersson | and the actual allocation was never added I think | 00:52 |
| eandersson | So it failed to clean up, but also failed to add the last allocation | 00:53 |
| mriedem | eandersson: i.e. https://review.openstack.org/#/c/647566/ | 00:53 |
| *** brinzhang has joined #openstack-nova | 00:53 | |
| mriedem | i'm not sure what you mean by 'last allocation' | 00:53 |
| eandersson | as the compute it ended up on was not actually in the allocation table | 00:53 |
| eandersson | but my colleague can provide more detailed information tomorrow | 00:54 |
| mriedem | unless i'm missing something i don't think that can happen | 00:54 |
| mriedem | the scheduler will create the allocations - if that fails, you'd get novalidhost most likely | 00:54 |
| mriedem | that or we'd be rescheduling to another host | 00:54 |
| mriedem | but we could have definitely been leaking allocations somehow when we fail ala https://bugs.launchpad.net/nova/+bug/1821594 | 00:55 |
| openstack | Launchpad bug 1821594 in OpenStack Compute (nova) stein "Error in confirm_migration leaves stale allocations and 'confirming' migration state" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | 00:55 |
| mriedem | would be good to nail down if you could figure out what actually failed though to see if we have another leak | 00:55 |
| mriedem | i still need to get the fix for that backported to rocky | 00:55 |
| mriedem | gotta go - time to blow snow | 00:57 |
| *** mriedem is now known as mriedem_afk | 00:57 | |
| *** owalsh has joined #openstack-nova | 00:57 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311 | 00:57 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581 | 00:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017 | 00:58 |
| *** owalsh_ has quit IRC | 00:58 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018 | 00:58 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019 | 00:59 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020 | 00:59 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027 | 01:00 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031 | 01:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299 | 01:01 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344 | 01:01 |
| eandersson | mriedem_afk, you are right - I assumed the compute service id in cli would match resource_provider_id | 01:02 |
| eandersson | So the above bug would explain it | 01:02 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | 01:02 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | 01:03 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | 01:03 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | 01:04 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | 01:04 |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.openstack.org/641200 | 01:05 |
| *** ricolin has joined #openstack-nova | 01:05 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add minimum value in max_concurrent_live_migrations https://review.openstack.org/648302 | 01:05 |
| openstackgerrit | melanie witt proposed openstack/nova master: Warn for duplicate host mappings during discover_hosts https://review.openstack.org/651947 | 01:06 |
| *** hongbin has joined #openstack-nova | 01:08 | |
| *** whoami-rajat has joined #openstack-nova | 01:09 | |
| openstackgerrit | Merged openstack/os-vif master: docs: Use sphinx.ext.autodoc for VIF types https://review.openstack.org/638404 | 01:14 |
| openstackgerrit | Merged openstack/os-vif master: docs: Use sphinx.ext.autodoc for profile, datapath offload types https://review.openstack.org/638405 | 01:23 |
| *** owalsh_ has joined #openstack-nova | 01:29 | |
| *** owalsh has quit IRC | 01:30 | |
| *** sapd1_x has joined #openstack-nova | 01:31 | |
| *** awalende has joined #openstack-nova | 01:36 | |
| *** awalende has quit IRC | 01:41 | |
| *** mriedem_afk is now known as mriedem | 01:42 | |
| mriedem | eandersson: ah yeah the _id is the table primary key id, it's the uuid you care about | 01:42 |
| tetsuro | mriedem: would you mind if I use ListUUIDField for in_tree in https://review.openstack.org/#/c/649534/6/nova/objects/request_spec.py | 01:45 |
| tetsuro | instead of UUIDField | 01:45 |
| mriedem | tetsuro: eh | 01:48 |
| mriedem | i don't love trying to future-proof that | 01:48 |
| mriedem | tetsuro: for what use case? user specifies a host and there are >1 nodes and you want to filter allocation candidates by all nodes? | 01:48 |
| mriedem | that would be 1000 for CERN | 01:49 |
| mriedem | *could | 01:49 |
| tetsuro | Not sure what happens on the performance | 01:51 |
| mriedem | i tend to think that's not a case we need to care about too much right now, until someone says they really need it | 01:52 |
| tetsuro | But I remember Surya said in the spec that he's not curious to have that for ironic cases | 01:52 |
| mriedem | i think in most cases that someone is forcing a server to a specific baremetal node, they are specifying the node | 01:52 |
| mriedem | right | 01:53 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Add host and hypervisor_hostname flag to create server https://review.openstack.org/645458 | 01:53 |
| mriedem | the only times i've heard of someone use the JsonFilter query hint for example is to force to a specific baremetal node | 01:53 |
| mriedem | via the hypervisor_hostname parameter | 01:53 |
| tetsuro | in which case the found node ==1 | 01:54 |
| yaawang | mriedem: Hi, I have posted a new spec https://review.openstack.org/#/c/651681/. This spec will use the flavor extra spec and image metadata to datermine whether to use auto converge and post copy. | 01:54 |
| tetsuro | mriedem: okay, I'll leave this field as is i.e. UUIDField instead of ListUUIDField. | 01:55 |
| mriedem | yaawang: yeah i saw but haven't dug into it yet. i agree that might be a better option, but there are cases to consider like what happens if the image or extra spec says to use auto_converge or post-copy but the host is unable to provide those? do we fail the server create? do we ignore? | 01:56 |
| mriedem | for SLA reasons i think we'd have to fail | 01:56 |
| mriedem | tetsuro: ack | 01:56 |
| *** markvoelker has joined #openstack-nova | 02:00 | |
| mriedem | yaawang: ok i left some thoughts on the spec, | 02:00 |
| mriedem | but traits might be the way to go here | 02:01 |
| *** tiendc has joined #openstack-nova | 02:02 | |
| yaawang | Yes, we need to check libvirt supports auto converge or post copy before live migration. I think end user prefer to use auto converge or post copy during live migration, but the end user hopes to be able to successfully carry out live migartion. | 02:04 |
| yaawang | Trait is a good idea, or schedule instances to the host which support auto converge or post copy. | 02:06 |
| mriedem | right, so i linked to the tpm spec because that case is very similar | 02:07 |
| mriedem | so read up on that and see if it could fit the same issue you're trying to solve | 02:07 |
| *** mriedem has quit IRC | 02:29 | |
| *** boxiang has quit IRC | 02:31 | |
| *** markvoelker has quit IRC | 02:35 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Move create of ComputeAPI object in websocketproxy https://review.openstack.org/649375 | 02:51 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add in_tree field to RequestGroup object https://review.openstack.org/649534 | 02:52 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add get_compute_nodes_by_host_or_node() https://review.openstack.org/650877 | 02:52 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree https://review.openstack.org/650878 | 02:52 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement https://review.openstack.org/649535 | 02:52 |
| *** irclogbot_0 has quit IRC | 03:01 | |
| *** irclogbot_2 has joined #openstack-nova | 03:02 | |
| *** alex_xu has quit IRC | 03:05 | |
| *** alex_xu has joined #openstack-nova | 03:10 | |
| *** ak92514 has quit IRC | 03:14 | |
| *** rcernin has quit IRC | 03:15 | |
| *** psachin has joined #openstack-nova | 03:20 | |
| *** nicolasbock has quit IRC | 03:25 | |
| *** boxiang has joined #openstack-nova | 03:26 | |
| yaawang | mriemem: Okay, i'll update the spec. | 03:26 |
| *** rcernin has joined #openstack-nova | 03:27 | |
| *** markvoelker has joined #openstack-nova | 03:32 | |
| *** owalsh has joined #openstack-nova | 03:40 | |
| *** owalsh_ has quit IRC | 03:40 | |
| *** efried has quit IRC | 03:43 | |
| *** efried has joined #openstack-nova | 03:44 | |
| *** owalsh_ has joined #openstack-nova | 03:48 | |
| *** owalsh has quit IRC | 03:49 | |
| *** belmoreira has joined #openstack-nova | 03:57 | |
| *** rcernin has quit IRC | 03:57 | |
| *** rcernin has joined #openstack-nova | 04:01 | |
| *** imacdonn_ has quit IRC | 04:04 | |
| *** markvoelker has quit IRC | 04:04 | |
| *** imacdonn_ has joined #openstack-nova | 04:04 | |
| *** udesale has joined #openstack-nova | 04:13 | |
| *** hongbin has quit IRC | 04:16 | |
| *** owalsh has joined #openstack-nova | 04:21 | |
| *** owalsh_ has quit IRC | 04:22 | |
| *** _d34dh0r53_ has joined #openstack-nova | 04:24 | |
| *** belmoreira has quit IRC | 04:32 | |
| *** sapd1_x has quit IRC | 04:59 | |
| *** tkajinam has quit IRC | 05:00 | |
| *** sapd1_x has joined #openstack-nova | 05:01 | |
| *** markvoelker has joined #openstack-nova | 05:02 | |
| *** tkajinam has joined #openstack-nova | 05:07 | |
| *** sidx64 has joined #openstack-nova | 05:21 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.openstack.org/649963 | 05:24 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: [WIP] Fix live migration break group policy simultaneously https://review.openstack.org/651969 | 05:24 |
| *** Luzi has joined #openstack-nova | 05:24 | |
| *** cfriesen has quit IRC | 05:30 | |
| *** markvoelker has quit IRC | 05:34 | |
| *** cfriesen has joined #openstack-nova | 05:37 | |
| *** ricolin has quit IRC | 05:39 | |
| *** cfriesen has quit IRC | 05:42 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/649326 | 05:48 |
| *** psachin has quit IRC | 05:49 | |
| *** sapd1_x has quit IRC | 05:52 | |
| *** baclawski has joined #openstack-nova | 05:57 | |
| *** baclawski has quit IRC | 06:02 | |
| *** lpetrut has joined #openstack-nova | 06:02 | |
| *** psachin has joined #openstack-nova | 06:05 | |
| *** sapd1_x has joined #openstack-nova | 06:07 | |
| boxiang | hi, does anyone know when/whether the requested_destination of request_spec will be save into db(persistent)? After I cold migrate the instance, I find it's null. Need help : ) | 06:13 |
| *** sapd1_x has quit IRC | 06:21 | |
| *** sapd1_x has joined #openstack-nova | 06:28 | |
| *** markvoelker has joined #openstack-nova | 06:31 | |
| *** bhagyashris has joined #openstack-nova | 06:35 | |
| *** sidx64_ has joined #openstack-nova | 06:39 | |
| *** sidx64 has quit IRC | 06:39 | |
| *** pcaruana has joined #openstack-nova | 06:41 | |
| *** ivve has joined #openstack-nova | 06:42 | |
| *** sidx64_ has quit IRC | 06:44 | |
| *** sapd1_x has quit IRC | 06:51 | |
| *** sapd1_x has joined #openstack-nova | 06:55 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove unused FP device creation and deletion methods. https://review.openstack.org/635433 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | 06:58 |
| openstackgerrit | Michael Still proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | 06:58 |
| *** luksky has joined #openstack-nova | 06:58 | |
| *** slaweq has joined #openstack-nova | 06:58 | |
| *** tiendc has quit IRC | 07:00 | |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from connection tests. https://review.openstack.org/642557 | 07:04 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from snapshot tests. https://review.openstack.org/642558 | 07:04 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.openstack.org/643894 | 07:04 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.openstack.org/643895 | 07:04 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.openstack.org/643896 | 07:04 |
| openstackgerrit | Michael Still proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.openstack.org/644793 | 07:04 |
| *** hamzy has quit IRC | 07:05 | |
| *** markvoelker has quit IRC | 07:05 | |
| *** hamzy has joined #openstack-nova | 07:05 | |
| *** whoami-rajat has quit IRC | 07:05 | |
| *** whoami-rajat has joined #openstack-nova | 07:06 | |
| *** mnaser has quit IRC | 07:06 | |
| *** mnaser has joined #openstack-nova | 07:06 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.openstack.org/649963 | 07:06 |
| *** egonzalez has quit IRC | 07:07 | |
| *** egonzalez has joined #openstack-nova | 07:08 | |
| *** rpittau|afk is now known as rpittau | 07:08 | |
| alex_xu | kashyap: I replied https://review.openstack.org/#/c/642030/, let me know whether i understand correctly | 07:09 |
| alex_xu | boxiang: I guess it is here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L361 | 07:13 |
| *** awalende has joined #openstack-nova | 07:15 | |
| *** baclawski has joined #openstack-nova | 07:16 | |
| kashyap | alex_xu: Will do | 07:17 |
| alex_xu | kashyap: thanks | 07:17 |
| kashyap | alex_xu: On your question ... you're right: we're mentioning it as an "extra" flag because a certain named CPU model may not contain some important CPU flags, e.g IvyBridge does not contain 'pcid'. | 07:20 |
| *** sidx64 has joined #openstack-nova | 07:20 | |
| *** sapd1_x has quit IRC | 07:20 | |
| kashyap | (But the *host* itself is capable of it, and QEMU can recognize it. So we supply it explicitly) | 07:21 |
| kashyap | I will answer on the review, so you can respond at your own pace :-) | 07:22 |
| *** mdbooth has joined #openstack-nova | 07:22 | |
| *** baclawski has quit IRC | 07:23 | |
| *** mdbooth_ has quit IRC | 07:25 | |
| alex_xu | kashyap: for the use-case of config extra_flag, we want the IvyBridge + pcid, not just ensure pcid in the model of IvyBridge, right? | 07:27 |
| kashyap | Exactly. We're specifying '+ pcid' because it is not included in the libvirt's "idea of IvyBridge", but host is capable of PCID | 07:28 |
| *** boxiang has quit IRC | 07:29 | |
| alex_xu | kashyap: also, there won't have any model incompatible with pcid? | 07:29 |
| kashyap | alex_xu: To refresh your memory: | 07:29 |
| *** boxiang has joined #openstack-nova | 07:30 | |
| kashyap | (1) Intel Haswell, Broadwell, Skylake libvirt/QEMU models include 'pcid' by default. | 07:30 |
| *** sapd1_x has joined #openstack-nova | 07:30 | |
| kashyap | (2) The libvirt / QEMU CPU models "Nehalem", "Westmere", "SandyBridge", and "IvyBridge" will _not_ expose the 'PCID' capability by default, even if the host CPUs by the same name include it. I.e. 'PCID' needs to be explicitly specified when using the said virtual CPU models. | 07:30 |
| alex_xu | kashyap: nice refresh, that is interesting :) | 07:31 |
| kashyap | alex_xu: Okay, was wondering if what I wrote above was useful :-) | 07:31 |
| alex_xu | kashyap: so I guess the problem is that paragraph makes me confusing on what you want to check. | 07:32 |
| kashyap | alex_xu: I wrote that documentation in Nova's documentation. | 07:32 |
| kashyap | (And here too: https://kashyapc.fedorapeople.org/Reducing-OpenStack-Guest-Perf-Impact-from-Meltdown.txt) | 07:32 |
| kashyap | alex_xu: Actually, I didn't write that original paragraph in the spec, Jack Ding wrote it | 07:32 |
| kashyap | alex_xu: Let me think a bit more on to rephrase it to be more clear. | 07:32 |
| alex_xu | kashyap: ah, sorry, I thought it was removed from the original spec | 07:33 |
| kashyap | It was not | 07:33 |
| alex_xu | kashyap: yea, thanks, good to be clear what is checked we want | 07:33 |
| kashyap | alex_xu: As a general point: for most operators, using 'host-model' should suffice, because that will auto-add necessary CPU flags for Meltdown/Spectre | 07:36 |
| *** sapd1_x has quit IRC | 07:42 | |
| *** tosky has joined #openstack-nova | 07:43 | |
| *** phasespace has joined #openstack-nova | 07:46 | |
| alex_xu | kashyap: thanks, good to know | 07:47 |
| *** tssurya has joined #openstack-nova | 07:49 | |
| *** ccamacho has joined #openstack-nova | 07:53 | |
| *** sidx64 has quit IRC | 07:53 | |
| *** ivve has quit IRC | 07:56 | |
| *** ttsiouts has joined #openstack-nova | 07:58 | |
| *** takashin has left #openstack-nova | 08:01 | |
| *** ricolin has joined #openstack-nova | 08:01 | |
| *** dtantsur|afk is now known as dtantsur | 08:01 | |
| *** markvoelker has joined #openstack-nova | 08:02 | |
| *** awalende has quit IRC | 08:05 | |
| *** awalende has joined #openstack-nova | 08:05 | |
| *** awalende has quit IRC | 08:06 | |
| *** awalende has joined #openstack-nova | 08:06 | |
| *** ivve has joined #openstack-nova | 08:11 | |
| *** luksky has quit IRC | 08:12 | |
| *** ttsiouts has quit IRC | 08:12 | |
| *** ttsiouts has joined #openstack-nova | 08:13 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add get_compute_nodes_by_host_or_node() https://review.openstack.org/650877 | 08:20 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree https://review.openstack.org/650878 | 08:20 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement https://review.openstack.org/649535 | 08:20 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Add host and hypervisor_hostname flag to create server https://review.openstack.org/645458 | 08:23 |
| *** awalende has quit IRC | 08:27 | |
| *** awalende has joined #openstack-nova | 08:28 | |
| *** markvoelker has quit IRC | 08:34 | |
| *** derekh has joined #openstack-nova | 08:39 | |
| *** ralonsoh has joined #openstack-nova | 08:40 | |
| *** tetsuro has quit IRC | 08:45 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.openstack.org/649963 | 08:48 |
| *** sidx64 has joined #openstack-nova | 08:59 | |
| *** dtantsur is now known as dtantsur|brb | 08:59 | |
| *** ivve has quit IRC | 09:10 | |
| *** luksky has joined #openstack-nova | 09:13 | |
| *** sidx64 has quit IRC | 09:13 | |
| *** janki has joined #openstack-nova | 09:15 | |
| *** sidx64 has joined #openstack-nova | 09:16 | |
| *** ivve has joined #openstack-nova | 09:21 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Add host and hypervisor_hostname flag to create server https://review.openstack.org/645458 | 09:22 |
| alex_xu | boxiang: I think we can persistent the destination_host | 09:25 |
| alex_xu | boxiang: since we reset it when do other migration, this is the rebuild https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1034 | 09:26 |
| kashyap | gibi: lyarwood: I hope I answered your questions on the Secure Boot spec: https://review.openstack.org/#/c/506720/ | 09:27 |
| kashyap | Thanks for the review and questions! | 09:27 |
| boxiang | alex_xu: let me take a look | 09:27 |
| openstackgerrit | ya.wang proposed openstack/nova-specs master: Expose auto converge and post copy https://review.openstack.org/651681 | 09:29 |
| *** rcernin has quit IRC | 09:30 | |
| *** markvoelker has joined #openstack-nova | 09:31 | |
| boxiang | alex_xu:Yeah, I see other migration will call reset_forced_destinations. I will make some changes later. | 09:33 |
| *** ricolin has quit IRC | 09:33 | |
| alex_xu | boxiang: cool | 09:36 |
| alex_xu | boxiang: I think I can +2 after you update | 09:36 |
| *** davidsha has joined #openstack-nova | 09:36 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Bump to hacking 1.1.0 https://review.openstack.org/651553 | 09:36 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve E731 issues https://review.openstack.org/651554 | 09:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W503 issues https://review.openstack.org/651555 | 09:37 |
| *** cdent has joined #openstack-nova | 09:42 | |
| *** bhagyashris has quit IRC | 09:53 | |
| *** sidx64 has quit IRC | 09:54 | |
| *** sidx64 has joined #openstack-nova | 09:56 | |
| *** markvoelker has quit IRC | 10:04 | |
| *** sidx64 has quit IRC | 10:09 | |
| *** sidx64 has joined #openstack-nova | 10:10 | |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/rocky: Add test for console-log and docs for bug 1746534 https://review.openstack.org/652033 | 10:28 |
| openstack | bug 1746534 in python-novaclient "encoding error when doing console-log" [High,Fix released] https://launchpad.net/bugs/1746534 - Assigned to Thomas Goirand (thomas-goirand) | 10:28 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/rocky: Add test for console-log and docs for bug 1746534 https://review.openstack.org/652033 | 10:28 |
| openstackgerrit | Stephen Finucane proposed openstack/python-novaclient stable/rocky: Add test for console-log and docs for bug 1746534 https://review.openstack.org/652033 | 10:29 |
| openstack | bug 1746534 in python-novaclient "encoding error when doing console-log" [High,Fix released] https://launchpad.net/bugs/1746534 - Assigned to Thomas Goirand (thomas-goirand) | 10:29 |
| *** pcaruana has quit IRC | 10:31 | |
| openstackgerrit | Merged openstack/nova-specs master: add spec for image metadata prefiltering https://review.openstack.org/647578 | 10:33 |
| *** nicolasbock has joined #openstack-nova | 10:43 | |
| *** ociuhandu has joined #openstack-nova | 10:53 | |
| *** ociuhandu has quit IRC | 10:53 | |
| *** tbachman has quit IRC | 10:53 | |
| *** markvoelker has joined #openstack-nova | 11:02 | |
| *** udesale has quit IRC | 11:05 | |
| *** sidx64 has quit IRC | 11:08 | |
| *** bbowen has joined #openstack-nova | 11:18 | |
| sean-k-mooney | stephenfin: jaypipes do ye have time to review the sriov migration patches again. https://review.openstack.org/#/c/620115/34 https://review.openstack.org/#/c/629589/ jay the first one has not change since you reviewed it last and the second is now rebased thanks to adrianc | 11:20 |
| *** ivve has quit IRC | 11:21 | |
| *** mvkr has joined #openstack-nova | 11:23 | |
| *** ivve has joined #openstack-nova | 11:30 | |
| *** maciejjozefczyk has left #openstack-nova | 11:31 | |
| *** jaosorior has quit IRC | 11:33 | |
| *** markvoelker has quit IRC | 11:35 | |
| *** pcaruana has joined #openstack-nova | 11:36 | |
| *** Luzi has quit IRC | 11:39 | |
| *** sidx64 has joined #openstack-nova | 11:42 | |
| *** sidx64 has quit IRC | 11:43 | |
| *** brinzhang has quit IRC | 11:56 | |
| *** sidx64 has joined #openstack-nova | 12:00 | |
| *** tbachman has joined #openstack-nova | 12:05 | |
| *** sidx64 has quit IRC | 12:07 | |
| *** psachin has quit IRC | 12:11 | |
| *** sidx64 has joined #openstack-nova | 12:13 | |
| *** ricolin has joined #openstack-nova | 12:25 | |
| *** ricolin has quit IRC | 12:29 | |
| *** sidx64 has quit IRC | 12:45 | |
| *** NostawRm has quit IRC | 12:46 | |
| jaypipes | sean-k-mooney: yes, will do this morning. | 12:46 |
| sean-k-mooney | :) | 12:47 |
| sean-k-mooney | i had addressed you comments in a previous revision and adrianc rebased it on his latest patch so that should be the only delta form what you saw before. if there is anythin else a miss let me know :) | 12:48 |
| *** dtantsur|brb is now known as dtantsur | 12:51 | |
| *** awalende has quit IRC | 12:52 | |
| *** awalende has joined #openstack-nova | 12:52 | |
| *** mriedem has joined #openstack-nova | 12:55 | |
| *** awalende has quit IRC | 12:57 | |
| *** awalende has joined #openstack-nova | 12:57 | |
| openstackgerrit | Merged openstack/nova stable/stein: Fix incomplete instance data returned after build failure https://review.openstack.org/647902 | 13:01 |
| *** awalende has quit IRC | 13:02 | |
| stephenfin | Can someone remind me: do we still translate exceptions? | 13:02 |
| sean-k-mooney | no not anymore | 13:03 |
| sean-k-mooney | at least i dont think we do | 13:03 |
| *** altlogbot_2 has joined #openstack-nova | 13:04 | |
| sean-k-mooney | stephenfin: looking at https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#choosing-a-marker-function | 13:05 |
| sean-k-mooney | maybe we do i had tought we decided to stop translating them however | 13:05 |
| *** dave-mccowan has joined #openstack-nova | 13:05 | |
| sean-k-mooney | stephenfin: ah https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#log-translation | 13:05 |
| sean-k-mooney | so ya as of pike we dont translate any logs | 13:06 |
| jaypipes | stephenfin, sean-k-mooney: not sure how I failed to notice this before, but the compute API's GET /servers/{id}/detail endpoint does not return the DNS name of the instance. What is the canonical way of getting an instance's hostname? | 13:13 |
| sean-k-mooney | jaypipes: the neutorn port will have it if you have designate deployed | 13:14 |
| sean-k-mooney | if you are not using designate and are relying on the nova config option i guess it would be in the instance metadata somewhere | 13:14 |
| *** dave-mccowan has quit IRC | 13:17 | |
| sean-k-mooney | jaypipes: https://developer.openstack.org/api-ref/network/v2/index.html#id52 | 13:17 |
| jaypipes | sean-k-mooney: that's what I would have thought... | 13:17 |
| jaypipes | this cluster is on Ocata with nova-network :( | 13:18 |
| sean-k-mooney | oh then the cloud init metadata is your best bet. we have an api endpoint for that right? | 13:18 |
| *** awaugama has joined #openstack-nova | 13:19 | |
| jaypipes | sean-k-mooney: a colleague is trying to get this information via the openstacksdk. :( | 13:19 |
| sean-k-mooney | ah that could be tricky. stephenfin you did a deep dive on the metadata stuff recently for the doc any ideas? | 13:20 |
| sean-k-mooney | jaypipes: stephenfin might be iun a 1:1 with our manger at the moment so there might be a delay | 13:20 |
| *** betherly has joined #openstack-nova | 13:20 | |
| *** sapd1_x has joined #openstack-nova | 13:20 | |
| *** lbragstad has joined #openstack-nova | 13:21 | |
| sean-k-mooney | looks like its not in os-interface either | 13:22 |
| stephenfin | sean-k-mooney, jaypipes: That's exposed via the metadata service, yes | 13:22 |
| sean-k-mooney | stephenfin: any idea how you would query it outside of the vm | 13:23 |
| mriedem | jaypipes: what's in the OS-EXT-SRV-ATTR:hostname param? | 13:23 |
| *** awalende has joined #openstack-nova | 13:23 | |
| sean-k-mooney | mriedem: i think that is just the name specifed when you created the vm without the rest of the fqdn. but honestly not sure with nova-net | 13:24 |
| stephenfin | sean-k-mooney: Oh, outside it? That I don't know | 13:24 |
| stephenfin | sean-k-mooney: fwiw, we (wrongly) use the nova-net domain stuff to generate a FQDN for the metadata service and other stuff | 13:24 |
| sean-k-mooney | stephenfin: is /servers/{server_id}/metadata/{key} the same thing https://developer.openstack.org/api-ref/compute/?expanded=show-metadata-item-details-detail#list-all-metadata | 13:24 |
| mriedem | no | 13:25 |
| stephenfin | I tried fixing it at some point but gave up because there was a risk of breaking stuff | 13:25 |
| mriedem | that's user-supplied metadata | 13:25 |
| sean-k-mooney | stephenfin: if you deploying with nova-net then we correctly do that :) | 13:25 |
| mriedem | this is the meta api hostname code https://github.com/openstack/nova/blob/03322bb517925a9f5a04ebdb41c3fd31e7962440/nova/api/metadata/base.py#L530 | 13:25 |
| *** tkajinam_ has joined #openstack-nova | 13:25 | |
| jaypipes | mriedem: there isn't one. | 13:25 |
| stephenfin | sean-k-mooney: https://review.openstack.org/#/c/480616/ | 13:25 |
| sean-k-mooney | mriedem: ah ok so we dont have a way to get the the cloud init metadata via the rest api then? | 13:26 |
| *** tkajinam has quit IRC | 13:27 | |
| mriedem | i'm not aware of something obvious no | 13:27 |
| sean-k-mooney | stephenfin: oh i tought you ment it was wrong becasue we should be using the designate one. not it was borked even for nova-net | 13:27 |
| stephenfin | sean-k-mooney: Nah, it's fine for nova-net so long as you don't unset 'dhcp_domain'. I was talking about the designate one | 13:28 |
| *** awalende has quit IRC | 13:28 | |
| stephenfin | Which I tried to do in an earlier revision but garyk pointed out that it would break stuff | 13:28 |
| jaypipes | was OS-EXT-SRV-ATTR:hostname added in a microversion? I don't see it listed in the compute API reference. | 13:29 |
| mriedem | no it's always been there, hence the prefix | 13:29 |
| sean-k-mooney | jaypipes: i assume you/oath/nova-net dont have rdns ptr record to allow looking up the dns name from an ip? | 13:29 |
| mriedem | https://developer.openstack.org/api-ref/compute/?expanded=show-server-details-detail#show-server-details | 13:29 |
| jaypipes | mriedem: you mean OS-EXT-SRV-ATTR:hypervisor_hostname or OS-EXT-SRV-ATTR:host ? | 13:30 |
| mriedem | neither | 13:30 |
| mriedem | i mean OS-EXT-SRV-ATTR:hostname | 13:30 |
| stephenfin | jaypipes: I see it in api-ref/source/servers.inc | 13:30 |
| stephenfin | whatever that gets generated into | 13:30 |
| jaypipes | ah, yeah. 2.3 | 13:30 |
| jaypipes | sorry mriedem | 13:30 |
| mriedem | oh so it was exposed later | 13:30 |
| stephenfin | jaypipes, mriedem: For later, do you think this is ready to go https://review.openstack.org/#/c/480616/ ? | 13:30 |
| jaypipes | By default, it appears in the response for administrative users only. | 13:30 |
| mriedem | super fun that we kept the prefix... | 13:30 |
| jaypipes | that might be the issue.. | 13:31 |
| mriedem | stephenfin: with all of those failing tests? | 13:31 |
| stephenfin | Unrelated failures | 13:31 |
| jaypipes | stephenfin: I can look at it in a bit. | 13:31 |
| mriedem | jaypipes: we could certainly make a specific policy rule for that | 13:31 |
| stephenfin | ta | 13:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Undeprecate the 'dhcp_domain' option https://review.openstack.org/480616 | 13:32 |
| mriedem | stephenfin: i would have to load that context back into my head, because i remember the session in sydney about this and we were going to try and use the dns_network info from neutron if it was available, and change the behavior on the option to avoid backward compat issues | 13:32 |
| *** altlogbot_2 has quit IRC | 13:32 | |
| mriedem | https://etherpad.openstack.org/p/YVR18-novaneutron-ops-cross-project-session | 13:33 |
| stephenfin | mriedem: Ideally yes, but it seems that's probably an RFE more than a bugfix https://review.openstack.org/#/c/480616/6/nova/api/metadata/base.py@549 | 13:33 |
| sean-k-mooney | yes i rememebr that being the direction | 13:33 |
| *** altlogbot_0 has joined #openstack-nova | 13:33 | |
| sean-k-mooney | we coudl do both. stephenfin fix corrects the edgecase wehre the config value is set to None | 13:34 |
| mriedem | stephenfin: that change isn't what was proposed in that forum session | 13:34 |
| sean-k-mooney | the reading it form neutron is realitvly simple change on top | 13:34 |
| mriedem | because gary is right - if the neutron network doesn't have dns then it's broken | 13:34 |
| *** d34dh0r53 has quit IRC | 13:35 | |
| stephenfin | mriedem: It is not. It's a stopgap because I think the change in the forum session probably needs a spec | 13:35 |
| stephenfin | so I need to undeprecate it so people can keep doing what they're doing until I've time to write that spec | 13:35 |
| stephenfin | that's my thinking anyway | 13:35 |
| *** boxiang has quit IRC | 13:37 | |
| sean-k-mooney | so im not sure if this is a spec or speclesss blueprint but keeping it simply i woudl personally just use teh neutron value if set and fall back to the nova config value if not | 13:37 |
| *** boxiang has joined #openstack-nova | 13:37 | |
| stephenfin | sean-k-mooney: Other way round, surely, to avoid breaking the upgrade path | 13:38 |
| *** phasespace has quit IRC | 13:38 | |
| sean-k-mooney | that is what i woudl expect as an enduser but with that said the OS-EXT-SRV-ATTR:hostname field should not contain the FQDN | 13:38 |
| *** altlogbot_0 has quit IRC | 13:38 | |
| stephenfin | Aye. Possible (microversion) change there | 13:38 |
| sean-k-mooney | stephenfin: no i mean if we want to expose an FQDN call it FQDN | 13:39 |
| sean-k-mooney | we shoudl not expose an FQDN in a hostname field | 13:39 |
| sean-k-mooney | so microver for a new file din server-details | 13:39 |
| *** altlogbot_2 has joined #openstack-nova | 13:39 | |
| sean-k-mooney | possibelwithout the OS-EXT-SRV-ATTR: prefix and proably not admin onle | 13:40 |
| sean-k-mooney | that definetly would need a spec actully | 13:40 |
| mriedem | stephenfin: comments in your patch | 13:42 |
| *** eharney has joined #openstack-nova | 13:42 | |
| stephenfin | ta | 13:43 |
| sean-k-mooney | oh the hostname is already an FQDN in some cases... of couse it is. | 13:44 |
| *** gaoyan has joined #openstack-nova | 13:47 | |
| *** mlavalle has joined #openstack-nova | 13:48 | |
| *** yedongcan has left #openstack-nova | 13:49 | |
| *** slaweq has quit IRC | 14:00 | |
| *** altlogbot_2 has quit IRC | 14:00 | |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Add get_compute_nodes_by_host_or_node() https://review.openstack.org/650877 | 14:01 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Pass target host to RequestGroup.in_tree https://review.openstack.org/650878 | 14:01 |
| openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Query `in_tree` to placement https://review.openstack.org/649535 | 14:01 |
| *** cfriesen has joined #openstack-nova | 14:02 | |
| *** slaweq has joined #openstack-nova | 14:02 | |
| cdent | dansmith: os-traits release: https://review.openstack.org/652079 | 14:05 |
| dansmith | sweet, thanks | 14:05 |
| cdent | I'll start exploring the tox-siblings stuff next week | 14:05 |
| dansmith | cdent: what in there makes it independent vs. whatever it is now? | 14:06 |
| cdent | simply that it is in the _independent dir | 14:06 |
| cdent | dansmith: I had the same question. I figured there must be a yaml file somewhere that declares what cycle something follows, but apparently it is per release | 14:07 |
| dansmith | ah | 14:07 |
| dansmith | but... it was before? | 14:07 |
| dansmith | or 0.1.0 was before | 14:08 |
| *** amodi has joined #openstack-nova | 14:08 | |
| *** gaoyan has quit IRC | 14:09 | |
| cdent | there's was a 0.1.0 which was the very first release | 14:09 |
| cdent | then it moved to being in cycles, so there are yaml files in deliverables/$CYCLE | 14:10 |
| cdent | and now it moves back to _independent | 14:10 |
| dansmith | gotcha okay | 14:10 |
| dansmith | I guess it's the unix "everything is a file" philosophy :) | 14:10 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Undeprecate and rename the 'dhcp_domain' option https://review.openstack.org/480616 | 14:11 |
| *** lpetrut has quit IRC | 14:11 | |
| *** gaoyan has joined #openstack-nova | 14:12 | |
| stephenfin | mriedem: I had to move that option in order to add it to the metadata file, so I also took the opportunity to rename it (since nova-net should be going away this cycle). Not entirely happy with the name so open to suggestions | 14:16 |
| mriedem | stephenfin: why not just leave the option name as dhcp_domain? | 14:21 |
| mriedem | couple more comments | 14:23 |
| mriedem | i'm not sure what you mean by "its been repurposed" | 14:24 |
| *** dpawlik has quit IRC | 14:24 | |
| stephenfin | mriedem: It seemed odd, given that it's not really anything specific to DHCP as used here | 14:26 |
| kashyap | stephenfin: Bike-shedding: if the new name is "domain", beware that Nova frequently uses that term in context of "libvirt domains" | 14:26 |
| melwitt | dansmith: could you take a look at the question I asked on the discover_hosts collision patch warn? I'm getting confused about whether I should return 0 if strict=False https://review.openstack.org/651947 and then also tssurya pointed out that map_instances skips DBDuplicateEntry | 14:26 |
| stephenfin | kashyap: Yeah, it also easy interpret as the domain of the metadata service or something. Not a fan | 14:26 |
| *** altlogbot_2 has joined #openstack-nova | 14:26 | |
| stephenfin | Eh, I haven't got a better idea so back to dhcp_domain it is | 14:27 |
| kashyap | stephenfin: fqdn_name? | 14:28 |
| mriedem | just leave it dhcp_domain | 14:28 |
| kashyap | Yeah | 14:28 |
| kashyap | (Also: the 'n' in 'fqdn' is name) | 14:28 |
| *** altlogbot_2 has quit IRC | 14:29 | |
| artom | RAS syndrome! | 14:29 |
| *** altlogbot_3 has joined #openstack-nova | 14:30 | |
| dansmith | melwitt: done | 14:32 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Undeprecate and move the 'dhcp_domain' option https://review.openstack.org/480616 | 14:32 |
| melwitt | dansmith: ty | 14:32 |
| stephenfin | mriedem: back to dhcp_domain it is ^ | 14:33 |
| *** altlogbot_3 has quit IRC | 14:33 | |
| melwitt | I was thinking about it in the inverse, keep running under zero is returned, not keep running until nonzero is returned. no wonder I was confused xD | 14:37 |
| melwitt | *until | 14:43 |
| mriedem | i also commented because everyone loves a good bike shed, not sure how my comments align with others | 14:43 |
| dansmith | melwitt: well, I'm just going based on the existing behavior, not necessarily the right behavior | 14:44 |
| melwitt | I see, yeah | 14:44 |
| dansmith | mriedem: my preference is to just highlight the error and stop processing records, not skip and continue | 14:45 |
| dansmith | which is why I think we should bail, | 14:45 |
| dansmith | but I think the existing return code behavior means we return 1 until we find nothing else to do, then return 0 | 14:46 |
| dansmith | and in that case, if we bail, we should return 1 so that something knows that there may be more stuff to do | 14:46 |
| mriedem | the existing return code behavior depends on the --strict option | 14:47 |
| dansmith | ...right | 14:48 |
| mriedem | if you don't specify --strict it returns 0 unless something blows up | 14:48 |
| dansmith | ...right, are you saying you want to preserve the non-strict nonzero behavior on error? | 14:48 |
| *** altlogbot_1 has joined #openstack-nova | 14:49 | |
| dansmith | I thought she was specifically asking about what to do if --strict was passed | 14:49 |
| melwitt | wait, I thought we return 0 until there's nothing more to do, and then return 1 when there's nothing to do? | 14:49 |
| mriedem | if i'm running this on a cron or something and not specifying --strict, i don't want it to error out if it got a duplicate entry error because it either did the job or there wasn't anything to do, so i don't care | 14:49 |
| dansmith | mriedem: but the job may very well be unfinished | 14:49 |
| dansmith | melwitt: not currently, AFAICT | 14:50 |
| mriedem | if we just blow up and stop processing sure | 14:50 |
| dansmith | melwitt: [07:46:16] <dansmith>but I think the existing return code behavior means we return 1 until we find nothing else to do, then return 0 | 14:50 |
| tssurya | dansmith: what I meant was to *not* stop if we found duplicates, I don't want my periodic job stopping and complaining that it already found a host was already mapped and now it doesn't want to proceed | 14:50 |
| tssurya | but it could also just be me :) | 14:50 |
| *** shilpasd has quit IRC | 14:50 | |
| mriedem | tssurya: i think you and i are saying the same thing | 14:50 |
| kashyap | alex_xu: When you're about, the more I think about this, the more I'm not sure if we should do this: https://review.openstack.org/#/c/642030/ | 14:50 |
| kashyap | alex_xu: I'll think more and write on the change next week. | 14:51 |
| tssurya | mriedem: yea just replied to your comment | 14:51 |
| tssurya | (on the patchset) | 14:51 |
| dansmith | tssurya: okay, I just don't see the point of having two threads which are clearly fighting continue to fight, processing all the records in the db | 14:51 |
| *** altlogbot_1 has quit IRC | 14:51 | |
| dansmith | in the case of there only being a few new nodes, it's not a problem, | 14:52 |
| mriedem | stephenfin: more comments | 14:52 |
| *** altlogbot_3 has joined #openstack-nova | 14:53 | |
| dansmith | but if you're turning on several thousand and running this in parallel for each node you added (which I think was the original assertion), you could have thousands of threads, running across many controller nodes, processing every record, and all but one are losing | 14:53 |
| stephenfin | efried: I've made a horrible mistake trying to bump hacking | 14:53 |
| stephenfin | FML | 14:53 |
| stephenfin | Oh, wait | 14:53 |
| *** stephenfin is now known as finucannot | 14:53 | |
| efried | stephenfin: It's educational at worst | 14:53 |
| *** efried is now known as fried_rice | 14:53 | |
| finucannot | Running tox -e pep8 and it just keeps on scrolling... | 14:53 |
| finucannot | I've no idea how this wasn't picked up locally before either. Very strange | 14:54 |
| fried_rice | finucannot: I've got 1314 lines of it | 14:54 |
| tssurya | dansmith: fair enough | 14:54 |
| finucannot | Hopefully most of them are W504 (which can be disabled because it's W503 or W504, choose one) | 14:54 |
| finucannot | Still, ugh | 14:54 |
| fried_rice | finucannot: I put how many of each in my last comment. | 14:55 |
| fried_rice | 1055 of them are W504 | 14:55 |
| tssurya | dansmith: yeah you have a valid point, its just that the behaviour of the command seemed weird when its all about discovering hosts | 14:55 |
| *** altlogbot_3 has quit IRC | 14:55 | |
| dansmith | tbh, I think what melwitt has is probably what I would want.. we retain the existing behavior of returning nonzero for the duplicate case, we just get a nice message about why | 14:59 |
| *** altlogbot_2 has joined #openstack-nova | 14:59 | |
| dansmith | no behavioral change at all, just easier for the humans | 14:59 |
| dansmith | we can change the behavior too, but that means deployment people likely have to change their stuff | 14:59 |
| *** _alastor_ has quit IRC | 15:00 | |
| tssurya | yea return code wise no behaviour change, just that now the command stops because it found an already discovered host :D | 15:01 |
| melwitt | yeah, that's what I was thinking with return 1, was today it traces and returns nonzero, so keep the behavior, just warn about it instead of tracing | 15:01 |
| tssurya | but I guess I am okay with it considering we run it as a periodic task | 15:01 |
| dansmith | tssurya: it stopped before | 15:01 |
| melwitt | I hadn't been thinking about the backwards (from the way my brain works) way that it currently returns values | 15:01 |
| dansmith | tssurya: cern runs it as a periodic? | 15:01 |
| tssurya | dansmith: no | 15:01 |
| dansmith | tssurya: okay good :D | 15:01 |
| tssurya | I meant in general :) | 15:01 |
| dansmith | gotcha | 15:01 |
| dansmith | melwitt: yeah, I think the return codes are a bit wonky, but what you have is an improvement for humans | 15:02 |
| melwitt | tssurya: yeah, today the command stops because it raises an exception all the way up | 15:02 |
| *** boxiang has quit IRC | 15:03 | |
| *** boxiang has joined #openstack-nova | 15:03 | |
| dansmith | melwitt: does this also continue to raise an exception for the periodic? | 15:03 |
| dansmith | melwitt: because I thought we were going to catch and log a warning for the periodic case to avoid the trace in the logs | 15:03 |
| melwitt | it would raise HostMappingExists yeah. I missed the point about catching and logging for periodic only | 15:04 |
| dansmith | or did you want to do that in a separate patch | 15:04 |
| dansmith | ? | 15:04 |
| *** igordc has joined #openstack-nova | 15:04 | |
| dansmith | don't you think that's better than a trace? LOG.warning('This should only be enabled when ...') | 15:05 |
| tssurya | melwitt, dansmith: yeah ok thanks I am aboard the plan then | 15:05 |
| melwitt | dansmith: yeah I think that's better, I just missed it and need to add it. what do you mean about "this should only be enabled when" though? | 15:06 |
| tssurya | melwitt: let's also add something in the nova-manage docs like a fat note | 15:06 |
| dansmith | like "this should only be enabled on a single scheduler" or something | 15:06 |
| melwitt | dansmith: I'm concerned about mschuppert's comment here though https://bugzilla.redhat.com/show_bug.cgi?id=1698630#c7 does this mean he expects it to return zero in the dupe case? | 15:06 |
| openstack | bugzilla.redhat.com bug 1698630 in openstack-tripleo-heat-templates "deployment fails running nova_cellv2_discover_hosts process with a duplicate key" [High,New] - Assigned to owalsh | 15:06 |
| melwitt | dansmith: ack got it | 15:07 |
| melwitt | tssurya: I think that docstring gets put in the docs right? let me check actually | 15:07 |
| dansmith | melwitt: I dunno what of that you think is related to his expectation of the return value | 15:08 |
| dansmith | melwitt: but if he's expecting something that isn't in line with the current behavior, he's probably expecting the wrong thing :) | 15:08 |
| melwitt | "With the proposed change to nova to just report a warning we'll not fail in that case." | 15:08 |
| dansmith | *my* concern about that comment is that he's talking about running this *on* the computes | 15:08 |
| owalsh | dansmith: on one compute | 15:09 |
| dansmith | melwitt: oh is he talking about your proposed change/ | 15:09 |
| dansmith | owalsh: doesn't matter.. any compute :) | 15:09 |
| owalsh | melwitt: he's assuming rc==0, yes | 15:09 |
| melwitt | I assumed so. I had linked it on the BZ | 15:09 |
| owalsh | dansmith: yea... not how I did it initially but reasons... | 15:09 |
| dansmith | owalsh: that's unfortunate.. giving computes credentials to the api DB just to run this thing the controllers should do.. do those creds persist on the compute? | 15:10 |
| dansmith | melwitt: okay I hadn't read it that way.. so he's just misunderstanding what your patch is doing you mean'? | 15:10 |
| melwitt | I'm concerned that he is, yeah | 15:11 |
| melwitt | tssurya: you're right, I need to add to the docs separately, the docstrings don't go in there automatically http://logs.openstack.org/47/651947/2/check/openstack-tox-docs/d6d7085/html/cli/nova-manage.html | 15:11 |
| dansmith | melwitt: but he's quoting from owalsh who says they'll use a retry loop, which is fine yeah? | 15:11 |
| *** tosky has quit IRC | 15:11 | |
| *** tosky has joined #openstack-nova | 15:12 | |
| melwitt | yeah, I guess so. I was hyperfocusing on the reply and not the quote | 15:12 |
| owalsh | dansmith: not sure where the creds are coming from now actually... previously when I moved this to the computes I embedded them in the script and unlink the script as soon as it was run to avoid leaving creds around | 15:13 |
| dansmith | owalsh: okay | 15:13 |
| owalsh | dansmith: but it's been rewritten since, I'll take a look | 15:13 |
| *** eharney has quit IRC | 15:13 | |
| dansmith | owalsh: "talking to the api database" is something we generally expect a compute not to ever do.. I guess in this case you're using it as the admin node since you're just taking action on that one, | 15:15 |
| dansmith | but in ansible lingo, I would "delegate" the discovery task to one of the controller nodes | 15:16 |
| owalsh | dansmith: yea, the reasons for this were that the controller nodes were being excluded from tripleo scale outs to speed things up, so it had to be on a compute... there isn't anything else | 15:16 |
| dansmith | right, because tripleo/heat reasons yeah? If it was pure ansible delegating a single admin command to one controller node after you're done would be easy, but I know that heat probably makes that hard | 15:17 |
| owalsh | might be possible now that tripleo == heat generating ansible playbook, but not sure if it would backport | 15:18 |
| *** ccamacho has quit IRC | 15:20 | |
| *** ivve has quit IRC | 15:20 | |
| *** luksky has quit IRC | 15:24 | |
| fried_rice | finucannot: a little sphinx help? | 15:27 |
| finucannot | shoot | 15:27 |
| fried_rice | finucannot: I'm in a spec | 15:27 |
| *** tbachman has quit IRC | 15:27 | |
| fried_rice | I want to make a link that gets referenced from a couple of places | 15:28 |
| fried_rice | so it's like | 15:28 |
| fried_rice | .. `some text`: https://... | 15:28 |
| fried_rice | but in another place I want to use different text | 15:28 |
| finucannot | :ref:`the text you want <the-anchor-name>` | 15:28 |
| fried_rice | I tried `different text <some text>`_ | 15:28 |
| finucannot | .. _the-anchor-name: https://... | 15:28 |
| finucannot | Oh/ | 15:28 |
| *** HuaChangWang has joined #openstack-nova | 15:28 | |
| fried_rice | yeah, I tried :ref:`different text <some text>` | 15:28 |
| finucannot | *? | 15:29 |
| fried_rice | it didn't work | 15:29 |
| finucannot | Hmm | 15:29 |
| * finucannot checks | 15:29 | |
| fried_rice | sorry, yes | 15:29 |
| fried_rice | .. _`some text`: https:// | 15:29 |
| fried_rice | forgot the _ originally | 15:29 |
| fried_rice | The `some text`_ link works fine | 15:29 |
| fried_rice | it's the "different text" I can't suss. | 15:29 |
| *** Sundar has joined #openstack-nova | 15:30 | |
| *** cdent has quit IRC | 15:32 | |
| finucannot | fried_rice: Ah, yeah, ref is for internal cross-referencing. My bad. | 15:35 |
| finucannot | fried_rice: It's ugly, but I think the only way is to do something like this | 15:35 |
| finucannot | `some text`_ and `some other text`_ | 15:35 |
| finucannot | .. _some text: https://... | 15:35 |
| finucannot | .. _`some other text`: `some text`_ | 15:36 |
| finucannot | which doesn't really help :/ | 15:36 |
| *** slaweq has quit IRC | 15:37 | |
| *** _alastor_ has joined #openstack-nova | 15:37 | |
| *** slaweq_ has joined #openstack-nova | 15:37 | |
| fried_rice | finucannot: It helps a little I guess. Point being to only specify the https://... in one place. | 15:37 |
| finucannot | fried_rice: Wait, no, got it. `some other text <some text_>`_ | 15:37 |
| finucannot | You need the first underscore to covert that to reference, otherwise it's taken literally | 15:38 |
| finucannot | i.e. you'll end up at '/some text' | 15:38 |
| fried_rice | yeah, that was the result I was getting. Trying.... | 15:38 |
| finucannot | Or from earlier, `the text you want <the-anchor-name_>`_ | 15:39 |
| fried_rice | finucannot: \o/ works! finuCAN! | 15:39 |
| finucannot | Side note: 'sphinx-quickstart' in 2.0 has much less options and is now generating non-crufty conf.py files. Hurrah! | 15:40 |
| fried_rice | what's that? | 15:40 |
| finucannot | It's a tool Sphinx provides to bootstrap a new documentation project | 15:40 |
| finucannot | tox has a similar one (tox-quickstart) inspired by Sphinx | 15:41 |
| fried_rice | ah, cool | 15:41 |
| *** slaweq__ has joined #openstack-nova | 15:44 | |
| *** slaweq_ has quit IRC | 15:46 | |
| *** gaoyan has quit IRC | 15:48 | |
| zigo | mriedem: I proposed the same kind of change on python-novaclient too, but it looks like nobody was paying much attention to Python 3 at the time, and my patch got rejected there, when it was accepted in osc. I use exclusively osc anyway, so I didn't insist much ! :) | 15:50 |
| zigo | Probably more out of lazyness, sorry for that. | 15:51 |
| *** slaweq__ has quit IRC | 15:51 | |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add instance hard delete https://review.openstack.org/570202 | 15:52 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201 | 15:52 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203 | 15:52 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Updates to image-metadata-prefiltering spec https://review.openstack.org/652101 | 15:53 |
| fried_rice | sean-k-mooney, dansmith, jaypipes, alex_xu, finucannot: ^ | 15:54 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Updates to image-metadata-prefiltering spec https://review.openstack.org/652101 | 15:55 |
| *** gaoyan has joined #openstack-nova | 15:57 | |
| *** derekh has quit IRC | 15:58 | |
| *** gaoyan has quit IRC | 15:58 | |
| *** psachin has joined #openstack-nova | 16:01 | |
| *** jangutter has quit IRC | 16:04 | |
| *** janki has quit IRC | 16:05 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Bump to hacking 1.1.0 https://review.openstack.org/651553 | 16:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve E731 issues https://review.openstack.org/651554 | 16:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W503 issues https://review.openstack.org/651555 | 16:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name) https://review.openstack.org/652103 | 16:06 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.openstack.org/652104 | 16:06 |
| finucannot | fried_rice: done | 16:07 |
| * finucannot -> home | 16:07 | |
| finucannot | *pub | 16:08 |
| *** finucannot is now known as stephenfin | 16:08 | |
| *** jmlowe has quit IRC | 16:11 | |
| *** dtantsur is now known as dtantsur|afk | 16:12 | |
| *** HuaChangWang has quit IRC | 16:13 | |
| *** eharney has joined #openstack-nova | 16:15 | |
| *** gyee has joined #openstack-nova | 16:15 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Updates to image-metadata-prefiltering spec https://review.openstack.org/652101 | 16:17 |
| *** davidsha has quit IRC | 16:23 | |
| *** sapd1_x has quit IRC | 16:23 | |
| *** rpittau is now known as rpittau|afk | 16:24 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP/PoC: Introduces the openstacksdk to nova https://review.openstack.org/643664 | 16:34 |
| openstackgerrit | melanie witt proposed openstack/nova master: Warn for duplicate host mappings during discover_hosts https://review.openstack.org/651947 | 16:34 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Updates to image-metadata-prefiltering spec https://review.openstack.org/652101 | 16:37 |
| *** tosky has quit IRC | 16:38 | |
| *** mlavalle has quit IRC | 16:46 | |
| *** tssurya has quit IRC | 16:51 | |
| *** spatel has joined #openstack-nova | 16:53 | |
| *** awalende has joined #openstack-nova | 16:53 | |
| spatel | sean-k-mooney: hey!!! | 16:53 |
| spatel | How are you doing sean!! | 16:53 |
| spatel | Does Google cloud provide SR-IOV function if anyone aware of it? | 16:55 |
| *** awalende has quit IRC | 16:57 | |
| *** tbachman has joined #openstack-nova | 16:57 | |
| *** mlavalle has joined #openstack-nova | 17:04 | |
| *** ralonsoh has quit IRC | 17:05 | |
| *** mlavalle has quit IRC | 17:11 | |
| sean-k-mooney | spatel: am im not sure. i have not looked at gce much | 17:11 |
| spatel | I don't think they provide SR-IOV because i am not seeing anywhere mentioned | 17:12 |
| sean-k-mooney | spatel: i konw aws whas some offerenings that have gpus and fpgas so they might but not sure where google stands in that regard | 17:12 |
| artom | It can be googled in 2 seconds, FWIW... https://stackoverflow.com/questions/33114144/does-google-compute-engine-offer-sr-iov-single-root-i-o-virtualization | 17:12 |
| artom | ... and has nothing to do with OpenStack? | 17:12 |
| spatel | Google using DPDK style enhance networking... if i am not wrong | 17:12 |
| sean-k-mooney | artom: spatel has recently (last 6 months) moved form aws to runign an sriov based openstack cloud | 17:13 |
| sean-k-mooney | artom: im guessing spatel you are interested in comparing it to a few other options | 17:13 |
| * artom goes to be a curmudgeon elsewhere | 17:14 | |
| melwitt | fried_rice: we've been talking about SchedulerReportClient whether it's heavy to construct, if you might have anything to add https://review.openstack.org/#/c/638073/24/nova/quota.py@1154 | 17:16 |
| spatel | sean-k-mooney: artom we are using aws in many place and costing is killing us so looking for other cloud provide like Google or tencent etc.. | 17:19 |
| spatel | We have requirement of high performance networking so exploring options related SR-IOV | 17:20 |
| spatel | artom: i did read that post already but not sure if Google change something recently and someone aware here so i post question here | 17:21 |
| spatel | That post is 4 year old also :( | 17:21 |
| *** cdent has joined #openstack-nova | 17:25 | |
| cdent | fried_rice: what you know of the state of https://bugs.launchpad.net/nova/+bug/1724633 . Still alive? | 17:25 |
| openstack | Launchpad bug 1724633 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters hits incorrectly when traits are split across the main RP and aggregates" [Medium,Confirmed] | 17:25 |
| *** ivve has joined #openstack-nova | 17:27 | |
| *** cfriesen has quit IRC | 17:28 | |
| *** mlavalle has joined #openstack-nova | 17:37 | |
| *** spatel has quit IRC | 17:37 | |
| *** cfriesen has joined #openstack-nova | 17:42 | |
| *** ttsiouts has quit IRC | 17:56 | |
| *** ttsiouts has joined #openstack-nova | 17:57 | |
| *** cfriesen has quit IRC | 17:58 | |
| *** spatel has joined #openstack-nova | 18:01 | |
| *** ttsiouts has quit IRC | 18:01 | |
| *** dave-mccowan has joined #openstack-nova | 18:06 | |
| *** imacdonn_ is now known as imacdonn | 18:08 | |
| *** irclogbot_2 has quit IRC | 18:08 | |
| *** irclogbot_2 has joined #openstack-nova | 18:11 | |
| mriedem | who would have know that our actions api is not completely solid https://bugs.launchpad.net/nova/+bug/1824420 | 18:13 |
| openstack | Launchpad bug 1824420 in OpenStack Compute (nova) "Live migration succeeds but instance-action-list still has unexpected Error status" [Undecided,Triaged] | 18:13 |
| mriedem | *known | 18:13 |
| *** bbowen has quit IRC | 18:16 | |
| *** tosky has joined #openstack-nova | 18:18 | |
| eandersson | mriedem, if you have some time can you take a stab at backporting that patch? If not I can probably do it. | 18:28 |
| eandersson | The allocation leak from resize/cold migration | 18:29 |
| mriedem | oh yeah sec | 18:29 |
| mriedem | eandersson: btw did you figure out where you had migration failures leaking allocations? | 18:33 |
| eandersson | Yea - we are doing a lot of migration testing, and those are causing it. | 18:34 |
| eandersson | Another person on our team are performing them. | 18:34 |
| mriedem | what's actually failing in confirm resize? | 18:34 |
| eandersson | Yes, we believe so. | 18:34 |
| eandersson | He thought it was someone else, as the uuid logged didn't match his VMs. | 18:34 |
| eandersson | But the uuids are actually migration uuids. | 18:34 |
| mriedem | ok, good to know - confirm resize shouldn't really be failing like that, so you've got some other issue | 18:35 |
| mriedem | but yeah fixing that leak is something we need (on rocky for you) | 18:35 |
| *** cdent has quit IRC | 18:38 | |
| *** psachin has quit IRC | 18:46 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Error out migration when confirm_resize fails https://review.openstack.org/652127 | 18:58 |
| mriedem | eandersson: ^ is the first half of that backport, i have to run to a school thing for my kid but with get the other patch when i'm back | 18:58 |
| mriedem | *will | 18:58 |
| *** rchurch has joined #openstack-nova | 18:59 | |
| *** lajoskatona has joined #openstack-nova | 19:01 | |
| *** rchurch_ has quit IRC | 19:01 | |
| lajoskatona | mriedem: Hi, regarding https://review.openstack.org/640600 & https://review.openstack.org/640601 do you have special reason to keep the workflow -1 on them? | 19:04 |
| *** whoami-rajat has quit IRC | 19:09 | |
| *** lajoskatona has quit IRC | 19:20 | |
| *** boxiang has quit IRC | 19:21 | |
| *** boxiang has joined #openstack-nova | 19:21 | |
| *** boxiang has quit IRC | 19:22 | |
| openstackgerrit | Merged openstack/nova master: Add --dry-run option to heal_allocations CLI https://review.openstack.org/651932 | 19:22 |
| *** mdbooth_ has joined #openstack-nova | 19:23 | |
| *** phasespace has joined #openstack-nova | 19:23 | |
| *** mdbooth has quit IRC | 19:26 | |
| *** spatel has quit IRC | 19:30 | |
| *** sidx64 has joined #openstack-nova | 19:32 | |
| eandersson | Thanks a lot mriedem | 19:54 |
| *** luksky has joined #openstack-nova | 20:07 | |
| *** cfriesen has joined #openstack-nova | 20:11 | |
| *** tjgresha_nope has quit IRC | 20:12 | |
| *** tjgresha has joined #openstack-nova | 20:13 | |
| fried_rice | melwitt: ack, looking. Generally speaking, the heavy part is building the ksa adapter, which can be heavy or not so heavy depending how the admin set up the conf options. | 20:16 |
| fried_rice | openstack: cdent: I don't know anything about bug 1724633 off the top, would have to try to repro. lmk if you need that. | 20:18 |
| openstack | bug 1724633 in OpenStack Compute (nova) "AllocationCandidates.get_by_filters hits incorrectly when traits are split across the main RP and aggregates" [Medium,Confirmed] https://launchpad.net/bugs/1724633 | 20:18 |
| sean-k-mooney | o/ | 20:20 |
| sean-k-mooney | i have some good news and bad news | 20:20 |
| *** sidx64 has quit IRC | 20:20 | |
| sean-k-mooney | which would people like to hear frist :P | 20:21 |
| sean-k-mooney | ill send an email to the list but we nolonger need nested virt to test hugepages,numa,cpu pinning or dpdk in the gate | 20:24 |
| sean-k-mooney | i also found we apparently have a deadlock in the nova compute agent if we run it on python 3.7 | 20:24 |
| sean-k-mooney | mriedem: ^ | 20:25 |
| *** pcaruana has quit IRC | 20:26 | |
| sean-k-mooney | im going to try and port my thidparty jobs upstream before teh summit but we should be able to replace the intel nfv ci with upstream gate jobs | 20:26 |
| mriedem | we aren't testing on py37 so... | 20:26 |
| mriedem | meh? | 20:26 |
| sean-k-mooney | for now i guess | 20:29 |
| sean-k-mooney | we seam to lockup the compute agent when we go to spawn an instance under py3.7 | 20:29 |
| sean-k-mooney | no errors or warnings | 20:29 |
| sean-k-mooney | but anyway if we use fedora 29 + the virt preveiw repo we can get libvirt 5.2 and a new enough qemu that allows cpu pinnign to work without kvm | 20:30 |
| fried_rice | melwitt: responded | 20:30 |
| sean-k-mooney | so i shoudl be able to pull together a gate job that will fully test cpu pinning and hugepages | 20:31 |
| mriedem | fedora 29 + virt preview with bleeding edge libvirt/qemu sounds super stable | 20:31 |
| sean-k-mooney | ya i hate useing fedroa for ci or dev | 20:31 |
| openstackgerrit | Julia Kreger proposed openstack/nova master: [ironic] ignore conflict upon cleaning up node https://review.openstack.org/643484 | 20:31 |
| mriedem | i guess if it's just a smaller set of tests in a non-voting job, sure | 20:31 |
| mriedem | better than 0 coverage | 20:31 |
| sean-k-mooney | we jsut need the new libvirt really | 20:32 |
| sean-k-mooney | i have a devstack plugin that can compile it form source | 20:32 |
| sean-k-mooney | and qemu | 20:32 |
| fried_rice | tjgresha: this conversation may interest you ^ | 20:32 |
| sean-k-mooney | so i caould also use that do it with ubuntu or centos | 20:32 |
| fried_rice | sean-k-mooney: I think there's work in progress to resurrect nfv CI, so if you think we don't need it at all, that'd be a good thing to know. | 20:32 |
| sean-k-mooney | https://github.com/openstack/devstack-plugin-libvirt-qemu | 20:33 |
| sean-k-mooney | yes i heard | 20:34 |
| *** mlavalle has quit IRC | 20:34 | |
| sean-k-mooney | we currently dont have vm with multiple numa nodes in the gate | 20:34 |
| sean-k-mooney | which is onething the nfv ci had | 20:34 |
| sean-k-mooney | we coudl maybe ask operators to donate such a nodeset | 20:35 |
| mriedem | that's what the openlab request from artom was fore | 20:35 |
| mriedem | *for | 20:35 |
| mriedem | but that would definitely be a periodic queue kind of thing | 20:35 |
| mriedem | or on-demand at best | 20:36 |
| artom | And also, if we get nested virt, do we need multiple physical NUMA nodes? | 20:36 |
| artom | mriedem, yeah, but better than nothing | 20:36 |
| *** mlavalle has joined #openstack-nova | 20:37 | |
| * artom still doesn't comprehend how Intel CI was able to run on every patch. How many machines did they have? | 20:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Error out migration when confirm_resize fails https://review.openstack.org/652127 | 20:37 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Delete allocations even if _confirm_resize raises https://review.openstack.org/652146 | 20:37 |
| mriedem | eandersson: ^ that should do it | 20:37 |
| *** zbr has quit IRC | 20:37 | |
| sean-k-mooney | artom: about 10 | 20:37 |
| sean-k-mooney | we started wtih 3 | 20:38 |
| sean-k-mooney | then grew to 5 | 20:38 |
| artom | sean-k-mooney, ah, that makes more sense | 20:38 |
| mriedem | speaking of ci, the ibm zkvm ci should be shutdown | 20:38 |
| artom | So clearly the 1 or 2 machines we might get from openlab won't handle it ;) | 20:38 |
| mriedem | fails immediately | 20:38 |
| sean-k-mooney | artom: actully it coudl depending on how you set it up | 20:38 |
| artom | sean-k-mooney, remind me why need multiple physical NUMA nodes? I recall having this conversation with you before... | 20:38 |
| artom | Can't the all be nested virt multinode? | 20:39 |
| artom | *they all | 20:39 |
| sean-k-mooney | we coudl if i was allowed to change the libvirt dirver code but everytime i suggest it people complain | 20:39 |
| artom | Eh? | 20:40 |
| sean-k-mooney | in the libvirt driver we implemented it in such a way as to always map virtual numa nodes to different phyical numa nodes | 20:40 |
| sean-k-mooney | but we never ever said that was guarenteed | 20:40 |
| sean-k-mooney | but it was someing people observed and started to depend on | 20:41 |
| artom | Oh right, that was the thing. If this was pure libvirt/kvm we could | 20:41 |
| artom | But because our dsvm will be servers in an openstack cloud | 20:41 |
| sean-k-mooney | yes and we could in nova | 20:41 |
| artom | We're limited by that thing | 20:41 |
| sean-k-mooney | this is purly a nova limitation | 20:41 |
| sean-k-mooney | we coudl cange the code however | 20:42 |
| artom | Seems like a lot of work :) | 20:42 |
| sean-k-mooney | if you use multipl virtual numa nodes on hyperv i dont think they give the same guarentee | 20:42 |
| melwitt | fried_rice: thanks | 20:42 |
| artom | No reason we can't push the openlab thing as far as it'll go first | 20:42 |
| mriedem | cfriesen: how much does this matter to you guys? https://bugs.launchpad.net/nova/+bug/1824420 | 20:43 |
| openstack | Launchpad bug 1824420 in OpenStack Compute (nova) "Live migration succeeds but instance-action-list still has unexpected Error status" [Undecided,Triaged] | 20:43 |
| sean-k-mooney | artom: you know after i get a gate job working i might actully put up a patch to make the numa maping configurable | 20:43 |
| sean-k-mooney | i at least want to see how invaisge it woudl be to allow it. i thnk it would be a very minor change but that code is ... | 20:44 |
| artom | Doesn't feel very minor, but you probably know that code better than I do | 20:44 |
| sean-k-mooney | its a slight tweek to how we iterate over the posible permutaion in the hardware.py module when we fit an instance to the host | 20:45 |
| * artom is a big fan of not doing work that's not strictly necessary ;) | 20:46 | |
| sean-k-mooney | currently wehn we alocate a instance numa node to a host cell we dont consider that cell again for subsequent guest numa nodes | 20:46 |
| mriedem | melwitt: dansmith: please to be reviewing these backports https://review.openstack.org/#/q/topic:bug/1669054+branch:stable/queens | 20:54 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Error out migration when confirm_resize fails https://review.openstack.org/652150 | 20:56 |
| dansmith | feel like I've reviewed these so many times | 20:56 |
| openstackgerrit | François Palin proposed openstack/nova master: nova diagnostics command is not working with all interfaces https://review.openstack.org/648123 | 20:57 |
| *** mlavalle has quit IRC | 20:58 | |
| *** mlavalle has joined #openstack-nova | 20:58 | |
| *** fried_rice is now known as efried_schoolrun | 20:58 | |
| dansmith | mriedem: shall I slam these? | 20:59 |
| melwitt | I can review too | 21:03 |
| dansmith | they're ready for +W | 21:03 |
| melwitt | coolio | 21:04 |
| mriedem | dansmith: because we have 5 stable branches now :) | 21:04 |
| dansmith | mriedem: I know.. I was being fuh shee zus | 21:05 |
| mriedem | i'm very sensitive | 21:05 |
| sean-k-mooney | artom: by the way the 2 server from openlab shoudl be enough to handel nova if we can get 12-14 vms running jobs in paralles and can keep the job under 2.5-3 hours | 21:06 |
| melwitt | conflict city | 21:06 |
| sean-k-mooney | anyway enjoy ye're weekend o/ | 21:06 |
| mriedem | oh i forgot i'd backported https://review.openstack.org/#/c/648691/ | 21:07 |
| mriedem | oh nvm you're talking about something else | 21:08 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Delete allocations even if _confirm_resize raises https://review.openstack.org/652153 | 21:10 |
| *** awaugama has quit IRC | 21:14 | |
| melwitt | mriedem: I noticed remnants of unused retry code in the test https://review.openstack.org/#/c/649363/1/nova/tests/unit/objects/test_request_spec.py did you want to just leave it or? | 21:18 |
| mriedem | oh yeah... | 21:20 |
| mriedem | replied; i could remove it, but then have to redo my pike and ocata cherry picks | 21:21 |
| mriedem | i'm fine either way | 21:21 |
| melwitt | ok, I guess I choose path of least work and leave it | 21:21 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Error out migration when confirm_resize fails https://review.openstack.org/652127 | 21:22 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Delete allocations even if _confirm_resize raises https://review.openstack.org/652146 | 21:22 |
| mriedem | that's what i like to hear | 21:24 |
| melwitt | I was thinking if it was an easy inline edit, that would be cool. but meh if you have to redo other stuff | 21:24 |
| mriedem | i'm sure i'll never have to touch this request spec code again in these old stable branches... | 21:25 |
| melwitt | right exactly | 21:25 |
| melwitt | request spec is solid | 21:25 |
| *** efried_schoolrun is now known as efried | 21:29 | |
| *** Sundar has quit IRC | 21:31 | |
| *** lbragstad has quit IRC | 21:37 | |
| *** betherly has quit IRC | 21:45 | |
| mriedem | eandersson: let me just say it's good you went to rocky rather than pike because trying to get that allocation leak fix back to pike is a huge pain in the ass, so i'm just going to not work on that for pike unless someone comes along and really needs it | 21:48 |
| *** lbragstad has joined #openstack-nova | 21:51 | |
| eandersson | I wish we could go to stein tbh, but we still rely on some vendor drivers | 22:03 |
| *** itlinux has joined #openstack-nova | 22:06 | |
| *** dave-mccowan has quit IRC | 23:00 | |
| *** hongbin has joined #openstack-nova | 23:06 | |
| *** tosky has quit IRC | 23:11 | |
| *** luksky has quit IRC | 23:19 | |
| openstackgerrit | Merged openstack/nova stable/stein: Error out migration when confirm_resize fails https://review.openstack.org/649421 | 23:20 |
| openstackgerrit | Merged openstack/nova stable/stein: Delete allocations even if _confirm_resize raises https://review.openstack.org/650437 | 23:20 |
| openstackgerrit | Merged openstack/nova stable/queens: Add functional regression test for bug 1669054 https://review.openstack.org/649362 | 23:20 |
| openstack | bug 1669054 in OpenStack Compute (nova) queens "RequestSpec.ignore_hosts from resize is reused in subsequent evacuate" [Medium,In progress] https://launchpad.net/bugs/1669054 - Assigned to Matt Riedemann (mriedem) | 23:20 |
| openstackgerrit | Merged openstack/nova stable/queens: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/649363 | 23:20 |
| *** nicolasbock has quit IRC | 23:30 | |
| *** hongbin has quit IRC | 23:34 | |
| *** igordc has quit IRC | 23:38 | |
| cfriesen | mriedem: sorry, was having computer issues. I think that would be lowish priority. makes it a bit harder to write automated stuff if there are spurious error events. | 23:39 |
| *** KH-Jared has quit IRC | 23:50 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert "Wait for network-vif-plugged on resize revert" https://review.openstack.org/639396 | 23:59 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM: extra logs] Revert resize: wait for external events in compute manager https://review.openstack.org/644881 | 23:59 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: extra logging in neutron api for revert resize https://review.openstack.org/652174 | 23:59 |
| artom | Oh, if you want to change the subject you can't just edit them in `git rebase -i` | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!