Monday, 2019-05-20

*** hemna has quit IRC00:21
*** brinzhang has joined #openstack-nova00:54
*** ileixe has joined #openstack-nova00:55
*** dannins has joined #openstack-nova01:26
*** cburgess has quit IRC01:46
*** ykarel has joined #openstack-nova02:01
*** ricolin has joined #openstack-nova02:14
*** threestrands has joined #openstack-nova02:34
*** hemna has joined #openstack-nova03:07
*** whoami-rajat has joined #openstack-nova03:11
*** psachin has joined #openstack-nova03:30
*** hemna has quit IRC03:37
*** guozijn has joined #openstack-nova03:56
*** dave-mccowan has quit IRC03:58
*** udesale has joined #openstack-nova04:01
*** ykarel has quit IRC04:04
*** ykarel has joined #openstack-nova04:22
*** janki has joined #openstack-nova04:38
*** sorrison has quit IRC05:00
*** ivve has quit IRC05:09
*** psachin has quit IRC05:16
*** guozijn has quit IRC05:24
*** ratailor has joined #openstack-nova05:24
*** imacdonn has quit IRC05:26
*** ileixe has quit IRC05:30
*** ileixe has joined #openstack-nova05:30
*** lpetrut has joined #openstack-nova05:40
*** imacdonn has joined #openstack-nova05:40
*** udesale has quit IRC05:42
*** udesale has joined #openstack-nova05:42
*** Luzi has joined #openstack-nova05:45
*** gnuoy has quit IRC05:45
*** hemna has joined #openstack-nova05:46
*** hemna has quit IRC05:51
*** guozijn has joined #openstack-nova05:55
*** ileixe has quit IRC06:02
*** ileixe has joined #openstack-nova06:03
*** ivve has joined #openstack-nova06:12
*** hemna has joined #openstack-nova06:22
*** luksky has joined #openstack-nova06:23
*** maciejjozefczyk has joined #openstack-nova06:27
*** dpawlik has joined #openstack-nova06:38
*** slaweq has joined #openstack-nova06:39
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552006:39
*** guozijn_ has joined #openstack-nova06:41
*** guozijn has quit IRC06:44
*** guozijn_ is now known as guozijn06:44
*** coreycb has quit IRC06:47
*** Kevin_Zheng has quit IRC06:47
*** jbryce has quit IRC06:47
*** TheJulia has quit IRC06:47
*** vdrok has quit IRC06:47
*** seyeongkim has quit IRC06:47
*** icey has quit IRC06:47
*** seyeongkim has joined #openstack-nova06:47
*** icey has joined #openstack-nova06:47
*** TheJulia has joined #openstack-nova06:47
*** coreycb has joined #openstack-nova06:47
*** vdrok has joined #openstack-nova06:47
*** jbryce has joined #openstack-nova06:47
*** lxkong has quit IRC06:47
*** geekinutah has quit IRC06:48
*** johnsom has quit IRC06:48
*** guilhermesp has quit IRC06:48
*** lxkong has joined #openstack-nova06:48
*** mnasiadka has quit IRC06:48
*** ajo has quit IRC06:48
*** adrianreza has quit IRC06:48
*** geekinutah has joined #openstack-nova06:48
*** guilhermesp has joined #openstack-nova06:48
*** johnsom has joined #openstack-nova06:48
*** mnasiadka has joined #openstack-nova06:48
*** ajo has joined #openstack-nova06:48
*** adrianreza has joined #openstack-nova06:48
*** hemna has quit IRC06:56
*** ralonsoh has joined #openstack-nova06:57
*** udesale has quit IRC07:00
*** udesale has joined #openstack-nova07:00
*** lpetrut has quit IRC07:04
*** rcernin has quit IRC07:08
*** zigo has joined #openstack-nova07:08
*** tesseract has joined #openstack-nova07:13
*** ircuser-1 has joined #openstack-nova07:13
*** rpittau|afk is now known as rpittau07:18
*** udesale has quit IRC07:20
*** udesale has joined #openstack-nova07:21
*** threestrands has quit IRC07:23
*** pcaruana has joined #openstack-nova07:23
*** udesale has quit IRC07:26
*** udesale has joined #openstack-nova07:27
*** hemna has joined #openstack-nova07:28
*** helenafm has joined #openstack-nova07:28
*** tssurya has joined #openstack-nova07:33
*** ykarel is now known as ykarel|lunch07:35
*** dtantsur|afk is now known as dtantsur07:35
*** psachin has joined #openstack-nova07:43
*** jaosorior has joined #openstack-nova07:44
*** xek_ has joined #openstack-nova07:44
*** trondham has left #openstack-nova07:47
kashyapefried: aspiers: Some great sleuthing, both of you there: https://review.opendev.org/#/c/655268/07:51
*** hemna has quit IRC08:02
*** mvkr has quit IRC08:11
*** tkajinam has quit IRC08:17
*** jangutter has joined #openstack-nova08:18
*** hemna has joined #openstack-nova08:30
*** ykarel|lunch is now known as ykarel08:31
*** brinzhang has quit IRC08:32
*** brinzhang has joined #openstack-nova08:33
*** derekh has joined #openstack-nova08:37
*** sorrison has joined #openstack-nova08:40
*** panda|rover|off is now known as panda|rover08:41
openstackgerritRui Zang proposed openstack/nova-specs master: support virtual persistent memory  https://review.opendev.org/60159608:46
openstackgerritRui Zang proposed openstack/nova-specs master: Virtual persistent memory libvirt driver implementation  https://review.opendev.org/62289308:46
*** mdbooth has joined #openstack-nova08:50
*** davidsha has joined #openstack-nova08:59
*** hemna has quit IRC09:04
*** phasespace has joined #openstack-nova09:11
*** ricolin has quit IRC09:19
*** jaosorior has quit IRC09:19
*** lei-zh has joined #openstack-nova09:23
*** lei-zh has quit IRC09:25
*** lei-zh has joined #openstack-nova09:25
*** lei-zh has quit IRC09:28
*** lei-zh has joined #openstack-nova09:28
*** s10 has joined #openstack-nova09:29
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'instance_update_from_api'  https://review.opendev.org/65130209:29
openstackgerritStephen Finucane proposed openstack/nova master: Stop handling 'update_cells' on 'BandwidthUsage.create'  https://review.opendev.org/65130309:29
openstackgerritStephen Finucane proposed openstack/nova master: Stop handling cells v1 for instance naming  https://review.opendev.org/65130409:29
openstackgerritStephen Finucane proposed openstack/nova master: Remove cells code  https://review.opendev.org/65130609:29
openstackgerritStephen Finucane proposed openstack/nova master: Remove conductor_api and _last_host_check from manager.py  https://review.opendev.org/65105909:29
*** lpetrut has joined #openstack-nova09:30
*** ccamacho has quit IRC09:33
*** hemna has joined #openstack-nova09:33
*** ccamacho has joined #openstack-nova09:34
openstackgerritHamdy Khader proposed openstack/nova master: [WIP] OVS DPDK port representors support  https://review.opendev.org/65878509:36
openstackgerritHamdy Khader proposed openstack/os-vif master: [WIP] OVS DPDK port representors support  https://review.opendev.org/65878609:38
stephenfinlyarwood: If you're about, fancy sending this three line patch to the gate? https://review.opendev.org/#/c/659833/09:40
*** cdent has joined #openstack-nova09:46
*** lei-zh has quit IRC09:46
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552009:47
*** ttsiouts has joined #openstack-nova09:54
lyarwoodstephenfin: ack09:55
*** rcernin has joined #openstack-nova10:03
*** maciejjozefczyk has quit IRC10:04
*** maciejjozefczyk has joined #openstack-nova10:05
*** hemna has quit IRC10:06
openstackgerritStephen Finucane proposed openstack/nova-specs master: Add 'flavor-extra-spec-image-property-validation-extended' spec  https://review.opendev.org/63873410:07
*** guozijn has quit IRC10:08
*** ivve has quit IRC10:09
*** sridharg has joined #openstack-nova10:14
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize  https://review.opendev.org/57141010:15
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E731 (do not assign a lambda expression, use a def)  https://review.opendev.org/65155410:18
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator)  https://review.opendev.org/65155510:18
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name)  https://review.opendev.org/65210310:18
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence)  https://review.opendev.org/65210410:18
*** maciejjozefczyk has quit IRC10:18
*** maciejjozefczyk has joined #openstack-nova10:19
*** ccamacho has quit IRC10:22
*** ttsiouts has quit IRC10:23
*** ccamacho has joined #openstack-nova10:26
openstackgerritStephen Finucane proposed openstack/nova-specs master: Add 'flavor-extra-spec-image-property-validation-extended' spec  https://review.opendev.org/63873410:26
*** phasespace has quit IRC10:26
*** maciejjozefczyk_ has joined #openstack-nova10:30
*** sridharg has quit IRC10:30
*** maciejjozefczyk has quit IRC10:31
*** yikun has quit IRC10:32
*** hemna has joined #openstack-nova10:36
*** panda|rover is now known as panda|lunch10:52
*** panda|lunch is now known as panda|rover|eat10:53
openstackgerritMatthew Booth proposed openstack/nova stable/rocky: Fix retry of instance_update_and_get_original  https://review.opendev.org/65931810:57
*** rcernin has quit IRC10:57
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support for changing deleted_on_termination after boot  https://review.opendev.org/58033610:57
openstackgerritBrin Zhang proposed openstack/nova-specs master: Support delete_on_termination in volume attach api  https://review.opendev.org/61294910:57
openstackgerritMatthew Booth proposed openstack/nova stable/queens: Fix retry of instance_update_and_get_original  https://review.opendev.org/65932010:58
*** ykarel is now known as ykarel|afk11:00
*** hemna has quit IRC11:10
openstackgerritBoxiang Zhu proposed openstack/nova master: Fix failure to boot instances with qcow2 format images  https://review.opendev.org/64027111:11
*** jamesdenton has joined #openstack-nova11:11
*** udesale has quit IRC11:16
openstackgerritguangchao.pan proposed openstack/nova master: Add a name for the automatically created volume  https://review.opendev.org/66009611:34
openstackgerritMerged openstack/os-resource-classes master: Dropping the py35 testing  https://review.opendev.org/65465311:40
*** hemna has joined #openstack-nova11:40
*** maciejjozefczyk has joined #openstack-nova11:48
*** maciejjozefczyk_ has quit IRC11:51
openstackgerritMerged openstack/os-traits master: Replace git.openstack.org URLs with opendev.org URLs  https://review.opendev.org/65506611:51
*** panda|rover|eat is now known as panda|rover11:57
*** tetsuro has joined #openstack-nova12:02
*** dave-mccowan has joined #openstack-nova12:04
*** ykarel|afk is now known as ykarel12:05
*** brinzhang has quit IRC12:09
*** ratailor_ has joined #openstack-nova12:13
*** hemna has quit IRC12:14
*** ykarel_ has joined #openstack-nova12:16
*** ratailor has quit IRC12:16
*** ykarel has quit IRC12:18
*** ab-a has joined #openstack-nova12:23
*** derekh has quit IRC12:25
*** janki has quit IRC12:29
*** luksky has quit IRC12:42
openstackgerritMerged openstack/nova master: api-ref: mention default project filtering when listing servers  https://review.opendev.org/65987312:43
*** hemna has joined #openstack-nova12:45
*** ccamacho has quit IRC12:45
*** dave-mccowan has quit IRC12:48
sean-k-mooneydansmith: this is proably a little early for you but if you are about can i get your input on something related to bug #181378912:48
openstackbug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,In progress] https://launchpad.net/bugs/1813789 - Assigned to Artom Lifshitz (notartom)12:48
sean-k-mooneydansmith: artom is away for a few days on PTO so i have been asked to take a look at ^12:49
*** jmlowe has quit IRC12:49
*** mriedem has joined #openstack-nova12:51
sean-k-mooneydansmith: one thing that came up when talking to artom last week was the idea of buffering the last 100 unhandeled events such that if we race on setting up the litener for the event we have an opertunity to recover.12:52
ralonsohstephenfin, ping https://review.opendev.org/#/c/658780/. Thank you in advance!12:53
stephenfinralonsoh: I can't review stable patches but lyarwood might be able to help you out if you say nice things about Wales^H^H^H England12:55
sean-k-mooneystephenfin: ah your homeland :P12:56
ralonsohstephenfin, thanks! for sure I'll say nice things about Wales!12:56
ralonsohhehehehe12:56
stephenfinsean-k-mooney: https://media1.giphy.com/media/l4lQZA7mIIjdK/giphy.gif12:57
sean-k-mooneyi mean you did leave your self open want is a good friend to do :)12:58
*** udesale has joined #openstack-nova13:01
*** derekh has joined #openstack-nova13:04
Luzihi, for the image encryption weekly meeting, it would be nice to have someone from nova attending. If you are interested please help find a meeting time: https://doodle.com/poll/wtg9ha3e5dvym6yt :)13:04
*** Guest84310 has joined #openstack-nova13:05
*** Guest84310 is now known as redrobot13:06
*** janki has joined #openstack-nova13:08
sean-k-mooneylyarwood: mdbooth  i dont know if ^ is something ye are interested in given ye're image backend knowladge13:11
*** ratailor_ has quit IRC13:13
lyarwoodsean-k-mooney: ack thanks13:13
lyarwoodLuzi: added my name13:13
Luzilyarwood, thank you :)13:13
mdboothLuzi: What's the agenda?13:15
*** ykarel__ has joined #openstack-nova13:17
Luzimdbooth, did you attend the forum session for image encryption at the summit?13:18
mdboothLuzi: No.13:18
mdboothLuzi: Is there a link to what was discussed?13:18
Luziwe want to bring image encryption to openstack, therefore coordination between projects who need to decrypt or encrypt images is needed.13:18
Luzihttps://etherpad.openstack.org/p/Foundations-for-Image-Encryption13:19
mdboothLuzi: Reading, thanks.13:19
*** hemna has quit IRC13:19
*** ykarel_ has quit IRC13:19
sean-k-mooneyLuzi: ye are creating a popup team to tackel this in a cross project way correct and this is the weekly meeting for that team or atleast the activity to make image encryption work with openstack13:20
*** psachin has quit IRC13:20
Luzisean-k-mooney, yes basically13:21
mdboothLuzi: Do you have a document describing the use case anywhere?13:21
mdboothLuzi: i.e. what problem is encryption solving?13:22
Luzionly some not yet updated specs - because i need to wait for a barbican spec as reference13:22
Luzihttps://review.opendev.org/#/c/608696/4/specs/stein/approved/image-encryption.rst13:23
mdboothLuzi: From the spec: "when a user uploads an image containing13:24
mdboothprivate data or confidential information - the image data should not be13:24
mdboothaccessible for unauthorized entities."13:24
mdboothWho are the unauthorized entities? Specifically, why not rely on glance permissions here?13:25
*** jroll has quit IRC13:25
*** jmlowe has joined #openstack-nova13:26
*** jroll has joined #openstack-nova13:26
*** luksky has joined #openstack-nova13:27
Luzi unauthorized entitiescould be anyone who get access to the image data outside of glance13:29
mdboothLuzi: Like who?13:29
mdboothThe problem is, this stuff ends up unencrypted on the compute host.13:29
*** lei-zh has joined #openstack-nova13:30
mdboothI'm worried we might sell this as a problem to a rogue administrator.13:30
mdboothThat's a seriously hard problem, and I can't believe we're planning to address it.13:30
*** tbachman has joined #openstack-nova13:32
mdboothSpecifically, our implementation of LVM disk encryption provides no data security whatsoever.13:32
mdboothIf it's a model we plan to copy, I'd be against it on the basis of complexity with no advantages.13:32
*** pcaruana has quit IRC13:33
*** ykarel__ is now known as ykarel13:33
*** tbachman_ has joined #openstack-nova13:34
openstackgerritLee Yarwood proposed openstack/nova master: Restore connection_info after live migration rollback  https://review.opendev.org/55134913:35
openstackgerritLee Yarwood proposed openstack/nova master: compute: Use source_bdms to reset attachment_ids during LM rollback  https://review.opendev.org/65280013:35
openstackgerritLee Yarwood proposed openstack/nova master: compute: refactor volume bdm rollback error handling  https://review.opendev.org/65650013:35
*** tbachman has quit IRC13:37
*** tbachman_ is now known as tbachman13:37
dansmithsean-k-mooney: I'm really opposed to that13:40
sean-k-mooneymdbooth: the goal of that work is to ensure that the image is never decrypted in a persitent way on the compute node13:40
dansmithsean-k-mooney: what I want is for us to wait for events before they are triggered, or not wait for them at all13:40
sean-k-mooneydansmith: because its just hiding the root issue13:40
dansmithsean-k-mooney: I think that attach-detach-attach would fool that buffering approach13:40
dansmithsean-k-mooney: yes13:40
sean-k-mooneydansmith: right i get that i was just wondering if we wanted to be a bit mor defensive untill we figure out how to do that13:41
dansmithI'd rather not wait at all13:41
*** lbragstad has joined #openstack-nova13:41
sean-k-mooneydansmith: it may or may not the idea was to store event that were recived but not expected and when you wait for a new event check if you have already recived it13:42
sean-k-mooneydansmith: well not waiting is also an option13:42
*** lbragstad has left #openstack-nova13:42
sean-k-mooneydansmith: its what artom has already done here https://review.opendev.org/#/c/639396/1613:42
sean-k-mooneydansmith: anyway im going to spend some time trancing through this today to see if i can find a way to determin if we can wait or not but presently im not sure we can do that without a new rpc call from the dest to the compute to start it waiting13:44
sean-k-mooneyand im not sure that is worth it13:45
dansmithI'd rather that than buffering, but...ack13:45
*** eharney has joined #openstack-nova13:46
sean-k-mooneywell its certenly an option i just did not want to jump to that if there was something less invasive.13:46
sean-k-mooneyanyway thank for the input ill pause the buffering investigation so for now13:46
openstackgerritLee Yarwood proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment  https://review.opendev.org/57279013:48
openstackgerritLee Yarwood proposed openstack/nova master: Keep attach_mode as top-level field in _translate_attachment_ref  https://review.opendev.org/57441313:48
cdentplacement meeting in #openstack-meeting-alt in 10 minutes13:50
mriedemsean-k-mooney: i'm not in favor of https://review.opendev.org/#/c/639396/ since it breaks a thing in the gate13:52
mriedemhence the patch on top13:52
*** lei-zh has quit IRC13:52
mriedemhttps://review.opendev.org/#/c/639396/5//COMMIT_MSG@2513:53
*** lpetrut has quit IRC13:53
sean-k-mooneymriedem: ya i am aware of why you made the original change13:54
sean-k-mooneywhich is why im trying to figure out how to wait reliably13:54
*** hemna has joined #openstack-nova13:54
sean-k-mooneythe patch on top still wait to late in some cases13:54
sean-k-mooneyif we take bufferign off the table my next idea is a pre_revert_at_source rpc function what will start the source node waithing for the vif-plugged event before we start the revert13:56
sean-k-mooneythat feel heavy wait but it shoudl resolve the issue of missing the event13:56
sean-k-mooney *heavyweight13:57
mriedemumm, isn't the issue just that we're not waiting for the unplugged even on the dest when we unplug vifs before casting to the source?13:58
mriedemi'm kind of in the middle of changing all of my internal domain and email shit b/c of this embargo so can't really dig into this right now, but pretty sure i've gone over this (with dansmith and artom) already in detail once or twice13:58
cdentblargh, that sounds painful13:59
mriedemthings are not fun right now no13:59
sean-k-mooneymriedem: ack.14:02
sean-k-mooneyas far as i can tell for the logs we are still reciving the event before we start waiting14:05
sean-k-mooneyrecive the vif-plugged  event here http://logs.openstack.org/81/644881/15/check/nova-multinode/628c731/logs/subnode-2/screen-n-cpu.txt.gz#_Apr_29_15_18_02_574298 but starte to wait for it 2 seconds later here http://logs.openstack.org/81/644881/15/check/nova-multinode/628c731/logs/subnode-2/screen-n-cpu.txt.gz#_Apr_29_15_18_04_00237014:05
sean-k-mooneyif we fix that i think that will resolve the issue14:06
*** janki has quit IRC14:10
*** s10 has quit IRC14:11
*** tbachman has quit IRC14:13
*** lpetrut has joined #openstack-nova14:15
*** mrch_ has joined #openstack-nova14:15
*** nicolasbock has joined #openstack-nova14:15
mriedemsean-k-mooney: i believe i pointed out the issue here https://review.opendev.org/#/c/639396/3/nova/compute/manager.py@418414:17
mriedemwhich is what artom's final patch in the series is doing https://review.opendev.org/#/c/644881/15/nova/compute/manager.py14:17
mriedemwaiting for the event before doing migrate_instance_finish14:18
sean-k-mooneymriedem thanks im looking at the code now but ill read your comment to make sure im on the same page14:18
*** cdent has quit IRC14:18
*** dpawlik has quit IRC14:19
mriedemdid the bug get punted to you at this point or are you just trying to get caught up and review the series?14:19
sean-k-mooneymriedem: artom is on PTO for a few days so both14:19
sean-k-mooneyim trying to get caught up to review and determin if the current fix is correct and if not fix it14:20
sean-k-mooneywe think that this issue happens when you are using hybrid_plug e.g. the iptables firewall driver which we use downstream but not upstream so one of the things that i need to test is modifying the gate job temporally to repoduce this upstream without code change to confrim14:22
*** cmart has joined #openstack-nova14:24
*** cdent has joined #openstack-nova14:26
*** lpetrut has quit IRC14:26
*** mlavalle has joined #openstack-nova14:27
*** hemna has quit IRC14:28
*** cmart has quit IRC14:32
*** tbachman has joined #openstack-nova14:41
*** mriedem is now known as mriedem_away14:53
*** pcaruana has joined #openstack-nova14:53
*** tbachman has quit IRC14:54
*** gyee has joined #openstack-nova14:57
*** sapd1_x has joined #openstack-nova15:00
*** tbachman has joined #openstack-nova15:02
*** hemna has joined #openstack-nova15:04
*** ykarel is now known as ykarel|away15:05
*** Luzi has quit IRC15:09
aarentsHi, If need some more review on change that fix please (only +1 for now) https://review.opendev.org/#/c/659054/15:12
openstackgerritStephen Finucane proposed openstack/nova master: Remove conductor_api and _last_host_check from manager.py  https://review.opendev.org/65105915:12
openstackgerritStephen Finucane proposed openstack/nova master: Remove 'etc/nova/cells.json'  https://review.opendev.org/66014615:12
openstackgerritStephen Finucane proposed openstack/nova master: docs: Remove references to nova-consoleauth  https://review.opendev.org/65296515:13
openstackgerritStephen Finucane proposed openstack/nova master: tests: Stop starting consoleauth in functional tests  https://review.opendev.org/65296615:13
openstackgerritStephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens  https://review.opendev.org/65296715:13
openstackgerritStephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check  https://review.opendev.org/65296815:13
openstackgerritStephen Finucane proposed openstack/nova master: Remove nova-consoleauth  https://review.opendev.org/65296915:13
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict  https://review.opendev.org/65297015:13
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rework nova console diagram  https://review.opendev.org/66014715:13
aarentswith less typo:  I need some more review on that fix please (only +1 for now) https://review.opendev.org/#/c/659054/ thks !15:13
efriedaarents: Looks like you have a merge conflict to resolve.15:14
efriedadrianc: are you around to make minor tweaks to https://review.opendev.org/#/c/643024/ if needed?15:16
sean-k-mooneyoh passing size when the image is deleted. the logic still seam right but i dont know that code well enough to review it so ill contiue to abstane form that review15:16
adriancefried: yes15:17
aarentssean-k-mooney: ok no prob, efried: exact, will check that15:18
efriedadrianc: commented.15:21
sean-k-mooneyaarents: for what its worth if mdbooth thinks its ok then that is a +1.5 when it comes to the image cache so once you rebase against master it shoudl be easier to get review form the cores15:21
adriancefried: thx, will address shortly (meeting ...)15:21
efriedadrianc: A little background: First off, if you're reraising the original exception, you want to just say15:22
efried  raise15:22
efriedrather than15:22
efried  raise e15:22
efriedbecause the former preserves the original stack trace and exception context.15:22
efriedBut it's also theoretically possible for intervening calls (like LOG.*) to mess with the exception context15:22
sean-k-mooneyefried: i like your deffintion of spelling :)15:22
efriedadrianc: so oslo provides a save_and_reraise_exception context manager that saves off the exception context while you do whatever, then makes sure to restore it properly before reraising.15:23
efriedsean-k-mooney: I have no words for you.15:23
* sean-k-mooney sigh of course i mispelled definition15:23
sean-k-mooneyefried: i was refering to to your comment on adrianc patch15:24
efriedand misspelled15:24
efriedyeah, I know :)15:24
tssuryamriedem, dansmith: could you both circle back to https://review.opendev.org/#/c/636132/ whenever you get some time ? thanks in advance!15:24
sean-k-mooneyya i avoid that word for irony reasons15:24
dansmithtssurya: yeah, sorry15:25
efriedI was trying to come up with some way to respond to sean-k-mooney commenting on anything to do with spelling, and I just came up blank. Totally speechless.15:25
tssuryadansmith: no need to be sorry :) I understand you must be busy with lots of other stuff15:25
tssuryathis spec is a little too specific after all15:26
*** lei-zh has joined #openstack-nova15:31
aspiersefried: I've switched the SEV capability patch we discussed on Friday to instead set an instance variable and then provide the trait in u_p_t(). I'm now wondering where I should put the functional tests: in nova.tests.functional.test_servers.TraitsTrackingTests, or nova.tests.functional.test_report_cpu_traits.LibvirtReportTraitsTests15:33
aspiersThe latter seems more appropriate, I guess15:34
efriedaspiers: looking...15:34
aspiersbut the former already has tests closer to what I need (I wrote them, in fact)15:34
*** jmlowe has quit IRC15:36
*** jmlowe has joined #openstack-nova15:37
efriedaspiers: Is FakeLibvirtDriver in the way here?15:38
*** lei-zh has quit IRC15:38
efriedI still don't fully understand how that thing works.15:38
*** hemna has quit IRC15:39
efriedObviously we want your tests to run through the real libvirt driver's upt15:39
efriedso as long as that's happening, it doesn't matter from a code point of view.15:39
efriedbut15:39
efriedtest_servers is way too effin big already.15:39
aspiersefried: Ideally it should test not just that a) it provides the SEV trait on detection, but also b) it replaces it if the admin removes it, and that it removes it if c) the host isn't SEV-capable but an admin provides it or d) if the host *becomes* SEV-incapable15:39
aspiersi.e. the same scenarios I tested when doing the cap-to-trait thing before15:39
*** ykarel|away has quit IRC15:40
aspiersbut this time with the trait coming from a different bit of code15:40
efried...And these are testing that libvirt reports traits, so LibvirtReportTraitsTests seems appropriate just based on the name.15:40
aspiersYeah, name-wise that wins for sure15:40
efriedaspiers: I understand. I wouldn't be averse to a patch that moves those tests :)15:40
aspiersbut yeah, you're right this needs to test the real libvirt driver15:41
efriedany patch that refactors test_servers.whatever into more-appropriately-named-smaller-module would be a win imo.15:41
aspiersMoves which tests?15:41
efriedaspiers: The ones you did about capability traits15:41
aspiersTo where? They're not libvirt-specific15:41
efriedahem, I guess those should... right15:41
efried...be in a module about drivers setting traits.15:41
*** helenafm has quit IRC15:42
efriedbah15:42
aspiersHow about this:15:42
efried++ (/me predicts future)15:42
aspiersI find some co-conspirators from Red Hat, and stage a coup where the PTL gets overthrown.  Oh good, +1 from you already15:43
efriedyeah, I walked into that15:44
aspiersWhat I was actually gonna suggest is, I'll stick them in LibvirtReportTraitsTests, but if that means duplicating code already in test_servers.py, then I'll extract it out into a shared utils library15:44
aspierswhich might already exist15:44
efried++15:44
aspiersor might not15:44
efriedDoesn't have to be shared utils per se, just a separate module that tests trait-y things but not libvirt-specific.15:45
aspiersright15:45
efriedThen the libvirty one can inherit from that.15:45
efriedDo the refactor in a new patch underneath, if you please.15:45
efriedIf it's straightforward enough, I might be able to ninja approve it.15:45
aspiersOK15:46
efriedyeah, test_servers is nearly 7kloc. That's too much15:47
aspiersagreed15:47
aspiersefried: should I first just extract TraitsTrackingTests to a separate file?15:48
*** slaweq has quit IRC15:48
efriedyeah, and TraitsBasedSchedulingTest with it15:49
aspiersor that and ProviderTreeTests?15:49
aspierssomething like test_server_traits.py?15:49
bnemecefried: Worth noting that the save_and_reraise context was to work around a bug in eventlet that I believe has since been fixed.15:49
aspiersor test_server_provider_tree.py15:49
bnemecI'm not sure you still have to worry about log calls and such messing with the exception context.15:49
efriedbnemec: oh, I didn't know that. It makes sense to me that intervening code could still muck with the exception context.15:50
efriedbnemec: or is well-behaved code supposed to not do that15:50
bnemecIt was _probably_ eventlet doing something naughty.15:51
bnemecI'm sure it could still happen, but it's probably not common anymore.15:51
bnemec(my overuse of probably is pretty representative of my confidence in this ;-)15:53
efriedbnemec: So you're not yet recommending that we go through and rip out all our uses of that context manager?15:53
efriedadrianc: in any case, 'raise' rather than 'raise e' is appropriate15:53
bnemecI guess I'm not aware of anyone running into a bug that required save_and_reraise since the eventlet fix though.15:53
bnemecefried: No, I don't think it hurts anything to have it there.15:54
efriedaspiers: test_servers_provider_tree seems like a winner.15:54
aspiersok15:54
bnemecAnd +1 to the raise vs. raise e point.15:54
*** dpawlik has joined #openstack-nova15:55
*** ricolin has joined #openstack-nova15:55
* aspiers wonders is there really a good reason to have a copyright header in every damn file15:55
efriedRecent guidance is just to include the license. But legally, since you're porting code from A to B, you should preserve A's copyright and license header. Sorry.15:58
efriedIt is stupid. I've actually spent hours with lawyers on this.15:59
aspiersHaha my sympathies16:00
*** maciejjozefczyk has quit IRC16:02
*** ykarel|away has joined #openstack-nova16:03
cdentFIGHT THE POWER16:03
*** wwriverrat has joined #openstack-nova16:05
*** sapd1_x has quit IRC16:06
aspiers:)16:10
openstackgerritAdam Spiers proposed openstack/nova master: Extract provider tree functional tests into new file.  https://review.opendev.org/66015716:10
*** rpittau is now known as rpittau|afk16:10
aspiersefried: ^^^16:11
efriedon it16:11
*** hemna has joined #openstack-nova16:11
aspiersWhy the hell did I finish the commit title with a period16:13
aspiersI never do that16:13
efriedarght, /me retracts +2!16:16
efriedwhatever16:16
aspiers;)16:16
efriedfix it or not. It's only your reputation at stake, permanently and indelibly etched into git16:16
aspiersROFL16:16
aspiersI see plenty of other trailing '.' in the commit history, thankfully16:17
aspiersI'll just be joining a distinguished group of disgraced engineers16:17
aspiersHmm, "Disgraced Engineer" sounds like a job title16:17
aspiersMaybe that's in my career track16:18
aspiersCrap, now I have no way to re-submit the SEV trait change without rebasing all the other SEV stuff on top of this16:18
aspiersor without rebasing this on top of the other SEV stuff16:19
aspiersThis appears to be a flaw in the Gerrit model16:19
efriedaspiers: Rebasing the whole series should be as easy as rebasing one patch.16:20
efriedaspiers: except it looks like you may not have been done rebasing the series on itself.16:20
aspiersFrom the CLI perspective maybe, but it creates a load of CI churn and also resets existing +1 / +216:20
aspiersAnd it's hard enough to get those precious votes already16:21
efriedrebasing doesn't reset votes.16:21
efriedunless it involves actual code changes16:21
aspiersDoesn't that depend on the patch-id remaining constant? ... right16:21
efriedChange-Id has to stay constant.16:21
*** ricolin has quit IRC16:22
aspiersI mean the git patch-id16:22
efriedI don't know what that is. You mean the commit hash?16:22
aspiersnope16:22
aspiershttps://git-scm.com/docs/git-patch-id16:22
efriedah16:22
aspiersIt's how git does clever stuff during rebase, for instance16:22
efriedyes, in spirit.16:22
sean-k-mooney aspiers if its a commit message only change i thik it keeps previous votes16:22
efriedsean-k-mooney: Pretty sure not ^16:23
aspierssean-k-mooney: it's not commit message only16:23
aspiersin this case16:23
aspiers(We moved on from the trailing "." discussion to something more serious)16:23
efriedIn this case you don't have any votes yet on the patch that's consuming the refactor, right?16:23
efriedbecause you're having to address some annoying core's -116:23
*** ivve has joined #openstack-nova16:24
sean-k-mooneyaspiers: we dont actully enforce the no trail . in the hacking checks if i rememebr16:24
aspiershttps://review.opendev.org/#/c/638680/ depends on https://review.opendev.org/#/c/633855/ which depends on https://review.opendev.org/#/c/655268/16:24
sean-k-mooneyso sinc its not enforced by the ci or atleast was not always enforced it is likely not consitent16:24
aspiersNow I need https://review.opendev.org/#/c/638680/ to *also* depend on this test_servers.py refactoring16:25
efriedoh, I see, you want to make a downward-facing tree16:25
aspierssean-k-mooney: like I said there are tons of trailing "." already in the history. That was just a joke ...16:25
efriedyeah, don't bother with that16:25
efriedjust put the refactor on the bottom of the pile.16:25
aspiersThe top of the pile?16:25
aspiers655268 already has lots of + votes16:26
efried"bottom" from the perspective of the 'Related changes' list on the top right of the gerrit panel.16:26
aspiersIs that list ordered?16:26
efriedright, and if you rebase that onto the refactor, you'll preserve those votes.16:26
*** itlinux_ has quit IRC16:26
efriedaspiers: Yes, "first" is at the bottom16:26
efriedetc16:27
aspiersHrm16:28
aspiersYeah, this is *definitely* a flaw in the Gerrit model if it doesn't support doing this properly16:28
aspiersA good model should definitely not force artificial dependencies between changes like this16:29
*** dave-mccowan has joined #openstack-nova16:29
aspiersWe're assuming here that Gerrit can only handle a linear sequence of dependencies16:30
aspiersOr maybe you know that for a fact16:30
aspiersEither way, it should be able to handle trees16:30
efriedsay wha?16:30
efriedoh16:30
efriedyou can do upward-facing trees (again, upward from the perspective of Related Changes)16:31
efriedThat is, you can have both B and C depend on A but not on each other.16:31
efriedgerrit will show B and C in arbitrary order, but both will always be above A16:31
aspiersYes, but this is the opposite way up16:31
aspiersA depending on both B and C16:31
efriedRight, that's what you can't have.16:31
aspiersbut B and C are independent16:31
efriedIt's possible that Depends-On would work in-repo16:32
efriedbut I'm not sure about that.16:32
efriedAnd frankly it's not worth it in this case.16:32
aspiersI don't think it would16:32
aspiersa merge commit would be required16:32
efriedyeah, based on my vague notions of how depends-on works, I think you're right that it wouldn't work.16:33
openstackgerritKashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Add missing certain missing traits  https://review.opendev.org/66016816:33
efriedso anyway, moving on...16:33
aspiersbefore submitting to Gerrit, the only way to get the local tree in the right shape would be to merge B and C, then base A on top of that merge commit16:33
aspierswhich is actually how I do it in git-explode16:33
kashyapaspiers: efried: First pass --^.  Surely I got some things wrong; but thought I'll "put it out there" :D16:33
kashyapErr, what a grammatical blunder in the summary16:34
openstackgerritKashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Add certain missing traits  https://review.opendev.org/66016816:34
kashyap[NB: This is WIP, as the commit message notes.  If the layout is amenable to those who care, then I can split it, if need be.]16:36
* kashyap bbiab; library is closing16:37
openstackgerritAdam Spiers proposed openstack/nova master: Extract provider tree functional tests into new file.  https://review.opendev.org/66015716:38
aspiersefried: I've had a better idea - rebased this refactor ^^^ on the highest review in the dependency tree I can get away with16:39
aspiersefried: thereby avoiding any CI churn on earlier changes16:39
efriedyup, that works too.16:39
*** udesale has quit IRC16:40
*** hemna has quit IRC16:44
*** slaweq has joined #openstack-nova16:45
*** jangutter has quit IRC16:50
*** davidsha has quit IRC16:53
*** ykarel|away has quit IRC16:59
*** cdent has quit IRC17:03
*** luksky has quit IRC17:06
*** slaweq has quit IRC17:07
*** dtantsur is now known as dtantsur|afk17:08
*** derekh has quit IRC17:11
*** dpawlik has quit IRC17:11
adriancefried: was held up in some b2b meeting will upload PS in a few min.17:14
*** ykarel|away has joined #openstack-nova17:14
*** hemna has joined #openstack-nova17:15
adriancalso saw that no need to use save_and_reraise exception ctx17:15
*** ttsiouts has joined #openstack-nova17:15
efriedadrianc: I would feel better if you did that anyway :)17:17
adriancsure17:18
efrieduntil we have hard evidence that it's really not needed, since it doesn't hurt anything...17:18
*** amodi has quit IRC17:18
efriedback in a reboot...17:19
*** efried has quit IRC17:19
*** ttsiouts has quit IRC17:20
*** tssurya has quit IRC17:21
*** efried has joined #openstack-nova17:22
*** lpetrut has joined #openstack-nova17:23
*** lpetrut has quit IRC17:27
*** slaweq has joined #openstack-nova17:29
*** ralonsoh has quit IRC17:31
openstackgerritAdrian Chiris proposed openstack/nova master: Allow driver to properly unplug VIFs on destination on confirm resize  https://review.opendev.org/64302417:36
*** eharney has quit IRC17:40
*** slaweq has quit IRC17:43
*** hemna has quit IRC17:49
*** tesseract has quit IRC17:51
*** markvoelker has joined #openstack-nova17:57
openstackgerritKashyap Chamarthy proposed openstack/os-traits master: hw: cpu: Add certain missing traits  https://review.opendev.org/66016818:02
*** ykarel|away has quit IRC18:04
*** xek_ has quit IRC18:06
*** xek_ has joined #openstack-nova18:06
*** cmart has joined #openstack-nova18:07
*** hemna has joined #openstack-nova18:15
*** xek_ has quit IRC18:24
*** eharney has joined #openstack-nova18:27
*** mrch_ has quit IRC18:35
*** hemna has quit IRC18:48
*** amodi has joined #openstack-nova19:00
efriedkashyap, mriedem_away, bauzas: Would y'all please look at https://review.opendev.org/#/c/651681/ some time soon?19:07
mriedem_awaydansmith has my power of attorney while i'm in dev jail19:09
mriedem_away/dev/jail19:09
efriednice19:09
dansmithheh19:09
*** hemna has joined #openstack-nova19:22
*** derekh has joined #openstack-nova19:26
*** derekh has quit IRC19:26
*** jmlowe has quit IRC19:30
*** tbachman has quit IRC19:30
*** markvoelker has quit IRC19:41
*** slaweq has joined #openstack-nova19:42
*** toabctl has quit IRC19:43
*** toabctl has joined #openstack-nova19:46
*** bbowen has quit IRC19:47
*** whoami-rajat has quit IRC20:19
*** hemna has quit IRC20:33
openstackgerritMerged openstack/nova master: Enable n-novnc in nova-multi-cell job  https://review.opendev.org/65571120:34
*** luksky has joined #openstack-nova20:42
*** ttsiouts has joined #openstack-nova20:55
*** tbachman has joined #openstack-nova21:03
*** tjgresha has joined #openstack-nova21:03
*** hemna has joined #openstack-nova21:05
*** tjgresha has quit IRC21:05
*** itlinux has joined #openstack-nova21:14
*** jmlowe has joined #openstack-nova21:33
*** ttsiouts has quit IRC21:34
*** igordc has joined #openstack-nova21:37
*** hemna has quit IRC21:38
*** pcaruana has quit IRC21:40
*** igordc has quit IRC21:40
*** mriedem_away has quit IRC21:42
*** igordc has joined #openstack-nova21:44
*** itlinux has quit IRC21:49
*** ttsiouts has joined #openstack-nova21:49
*** ttsiouts has quit IRC21:54
*** slaweq has quit IRC21:57
*** cmart has quit IRC22:06
*** hemna has joined #openstack-nova22:07
*** slaweq has joined #openstack-nova22:09
*** tbachman has quit IRC22:11
*** tbachman has joined #openstack-nova22:12
*** slaweq has quit IRC22:13
*** mlavalle has quit IRC22:16
*** tbachman has quit IRC22:23
*** ttsiouts has joined #openstack-nova22:23
*** bbowen has joined #openstack-nova22:27
*** slaweq has joined #openstack-nova22:40
*** hemna has quit IRC22:42
*** slaweq has quit IRC22:44
*** hemna has joined #openstack-nova22:46
*** luksky has quit IRC22:55
*** tkajinam has joined #openstack-nova22:59
*** hemna has quit IRC23:09
*** tetsuro has quit IRC23:11
*** itlinux has joined #openstack-nova23:18
*** efried has quit IRC23:22
*** rcernin has joined #openstack-nova23:22
*** efried has joined #openstack-nova23:23
*** itlinux has quit IRC23:35
*** ttsiouts has quit IRC23:35
*** itlinux has joined #openstack-nova23:48
*** ttsiouts has joined #openstack-nova23:50
*** gyee has quit IRC23:51
*** igordc has quit IRC23:55
*** bbowen has quit IRC23:58
*** bbowen has joined #openstack-nova23:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!