*** panda|rover has quit IRC | 00:10 | |
*** panda has joined #openstack-nova | 00:11 | |
*** tbachman has joined #openstack-nova | 00:40 | |
*** markvoelker has joined #openstack-nova | 00:41 | |
*** markvoelker has quit IRC | 00:45 | |
*** ttsiouts has quit IRC | 01:00 | |
*** brinzhang has joined #openstack-nova | 01:02 | |
*** ttsiouts has joined #openstack-nova | 01:15 | |
tonyb | I have a couple of ironic nodes in my OpenStack, how can I see which traits they provide ... and if they don't provide useful ones add them? | 01:19 |
---|---|---|
*** ttsiouts has quit IRC | 01:20 | |
*** frankwang has joined #openstack-nova | 01:21 | |
*** frankwang has quit IRC | 01:42 | |
*** ttsiouts has joined #openstack-nova | 01:49 | |
*** frankwang has joined #openstack-nova | 01:53 | |
*** ttsiouts has quit IRC | 01:54 | |
*** lei-zh has joined #openstack-nova | 02:00 | |
*** whoami-rajat has joined #openstack-nova | 02:00 | |
*** nicolasbock has quit IRC | 02:16 | |
*** ttsiouts has joined #openstack-nova | 02:27 | |
*** ykarel|away has joined #openstack-nova | 02:29 | |
*** lei-zh has quit IRC | 02:32 | |
*** lei-zh has joined #openstack-nova | 02:33 | |
*** _alastor_ has joined #openstack-nova | 02:36 | |
*** ricolin has joined #openstack-nova | 02:44 | |
*** ykarel|away is now known as ykarel | 02:44 | |
*** tbachman has quit IRC | 02:45 | |
*** tbachman has joined #openstack-nova | 02:46 | |
*** _alastor_ has quit IRC | 02:50 | |
*** tbachman has quit IRC | 02:51 | |
*** wwriverrat has quit IRC | 02:51 | |
*** dave-mccowan has quit IRC | 02:55 | |
*** frankwang has quit IRC | 02:56 | |
*** tbachman has joined #openstack-nova | 02:57 | |
*** tbachman has quit IRC | 02:58 | |
*** hemna has joined #openstack-nova | 02:59 | |
*** hongbin has joined #openstack-nova | 03:00 | |
*** ttsiouts has quit IRC | 03:01 | |
*** hemna has quit IRC | 03:03 | |
*** tkajinam has quit IRC | 03:03 | |
*** tkajinam has joined #openstack-nova | 03:04 | |
*** wwriverrat has joined #openstack-nova | 03:04 | |
*** frankwang has joined #openstack-nova | 03:06 | |
*** hemna has joined #openstack-nova | 03:07 | |
*** kaisers has quit IRC | 03:17 | |
*** tkajinam has quit IRC | 03:20 | |
*** hemna has quit IRC | 03:26 | |
*** tkajinam has joined #openstack-nova | 03:28 | |
*** psachin has joined #openstack-nova | 03:29 | |
*** udesale has joined #openstack-nova | 03:47 | |
*** tbachman has joined #openstack-nova | 03:50 | |
*** ttsiouts has joined #openstack-nova | 04:03 | |
*** lei-zh has quit IRC | 04:06 | |
*** hongbin has quit IRC | 04:21 | |
*** markvoelker has joined #openstack-nova | 04:35 | |
*** ttsiouts has quit IRC | 04:36 | |
*** janki has joined #openstack-nova | 04:37 | |
*** markvoelker has quit IRC | 04:39 | |
*** tbachman has quit IRC | 04:44 | |
*** ratailor has joined #openstack-nova | 04:46 | |
*** itlinux has quit IRC | 04:46 | |
*** tbachman has joined #openstack-nova | 04:49 | |
*** slaweq has joined #openstack-nova | 04:49 | |
*** slaweq has quit IRC | 04:59 | |
*** pcaruana has joined #openstack-nova | 05:02 | |
*** ykarel is now known as ykarel|away | 05:03 | |
*** ykarel|away has quit IRC | 05:08 | |
*** pcaruana has quit IRC | 05:11 | |
*** slaweq has joined #openstack-nova | 05:16 | |
*** slaweq has quit IRC | 05:20 | |
*** ykarel|away has joined #openstack-nova | 05:20 | |
*** lei-zh has joined #openstack-nova | 05:27 | |
*** ykarel|away is now known as ykarel | 05:28 | |
*** ivve has quit IRC | 05:34 | |
*** ttsiouts has joined #openstack-nova | 05:39 | |
*** imacdonn has quit IRC | 05:40 | |
*** imacdonn has joined #openstack-nova | 05:41 | |
*** ykarel_ has joined #openstack-nova | 05:42 | |
*** Luzi has joined #openstack-nova | 05:43 | |
*** udesale has quit IRC | 05:44 | |
*** ykarel has quit IRC | 05:44 | |
*** udesale has joined #openstack-nova | 05:44 | |
*** ykarel__ has joined #openstack-nova | 06:01 | |
*** ykarel_ has quit IRC | 06:03 | |
*** ykarel__ is now known as ykarel | 06:04 | |
*** zbr_ has quit IRC | 06:05 | |
*** slaweq has joined #openstack-nova | 06:12 | |
*** ttsiouts has quit IRC | 06:12 | |
*** lpetrut has joined #openstack-nova | 06:15 | |
*** tbachman has quit IRC | 06:15 | |
*** jistr is now known as jistr|mtg | 06:20 | |
openstackgerrit | Wangliangyu proposed openstack/nova master: Replace colon with comma in route comment https://review.opendev.org/660256 | 06:32 |
*** kaisers has joined #openstack-nova | 06:34 | |
*** markvoelker has joined #openstack-nova | 06:36 | |
*** maciejjozefczyk has joined #openstack-nova | 06:42 | |
*** ivve has joined #openstack-nova | 06:43 | |
*** ccamacho has joined #openstack-nova | 06:56 | |
*** luksky has joined #openstack-nova | 07:00 | |
*** dpawlik has joined #openstack-nova | 07:03 | |
*** trident has quit IRC | 07:03 | |
*** trident has joined #openstack-nova | 07:05 | |
*** tesseract has joined #openstack-nova | 07:06 | |
*** markvoelker has quit IRC | 07:09 | |
*** rcernin has quit IRC | 07:19 | |
*** ralonsoh has joined #openstack-nova | 07:19 | |
*** tssurya has joined #openstack-nova | 07:20 | |
*** pcaruana has joined #openstack-nova | 07:21 | |
*** helenafm has joined #openstack-nova | 07:24 | |
*** ttsiouts has joined #openstack-nova | 07:27 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server https://review.opendev.org/645520 | 07:30 |
*** ykarel is now known as ykarel|lunch | 07:35 | |
*** udesale has quit IRC | 07:35 | |
*** udesale has joined #openstack-nova | 07:36 | |
*** pcaruana has quit IRC | 07:39 | |
*** yikun_ has joined #openstack-nova | 07:40 | |
*** rpittau|afk is now known as rpittau | 07:41 | |
*** jangutter has joined #openstack-nova | 07:44 | |
kashyap | efried: Will look. Actually, Ya Wang did ping me on a few things in that PostCopy / Auto-Converge spec | 07:47 |
kashyap | yaawang: Hi, what do you mean "applicatoins sensitive to performance reduced"? | 07:50 |
openstackgerrit | ya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.opendev.org/660271 | 07:53 |
yaawang | kashyap: Hi, for example: some scientific computing applications may be more sensitive to memory access latency. | 08:05 |
*** markvoelker has joined #openstack-nova | 08:06 | |
*** luksky has quit IRC | 08:11 | |
*** tkajinam has quit IRC | 08:12 | |
*** dtantsur|afk is now known as dtantsur | 08:20 | |
*** priteau has joined #openstack-nova | 08:20 | |
kashyap | yaawang: Ah, noted. | 08:23 |
kashyap | efried: yaawang: I just reviewed it. The idea itself is sound. I had some small comments on phrasing -- they can be addressed as a follow-on, or in this if there's a strong need to respin. | 08:23 |
*** guozijn has joined #openstack-nova | 08:24 | |
openstackgerrit | ya.wang proposed openstack/nova-specs master: Re-propose the spec to allow specifying a list of CPU models https://review.opendev.org/660271 | 08:24 |
*** priteau has quit IRC | 08:24 | |
*** betherly has joined #openstack-nova | 08:25 | |
openstackgerrit | Alexandre arents proposed openstack/nova master: Fix live-migration when glance image deleted https://review.opendev.org/659054 | 08:25 |
openstackgerrit | Merged openstack/nova master: Fix failure to boot instances with qcow2 format images https://review.opendev.org/640271 | 08:28 |
openstackgerrit | Merged openstack/nova stable/ocata: Do not dump all instances in the scheduler https://review.opendev.org/659833 | 08:28 |
*** priteau has joined #openstack-nova | 08:29 | |
*** ykarel|lunch is now known as ykarel | 08:30 | |
*** xek has joined #openstack-nova | 08:36 | |
*** xek has quit IRC | 08:38 | |
*** markvoelker has quit IRC | 08:39 | |
*** derekh has joined #openstack-nova | 08:43 | |
*** luksky has joined #openstack-nova | 08:46 | |
*** jistr|mtg is now known as jistr | 08:46 | |
*** ttsiouts has quit IRC | 08:48 | |
*** xek has joined #openstack-nova | 08:48 | |
*** davidsha has joined #openstack-nova | 08:48 | |
openstackgerrit | Hamdy Khader proposed openstack/nova master: OVS DPDK port representors support https://review.opendev.org/658785 | 08:53 |
*** tetsuro has joined #openstack-nova | 09:01 | |
*** awalende has joined #openstack-nova | 09:05 | |
*** dtantsur is now known as dtantsur|brb | 09:06 | |
*** phasespace has joined #openstack-nova | 09:12 | |
*** openstackstatus has quit IRC | 09:13 | |
*** openstackstatus has joined #openstack-nova | 09:15 | |
*** ChanServ sets mode: +v openstackstatus | 09:15 | |
*** yan0s has joined #openstack-nova | 09:15 | |
*** bhagyashris has joined #openstack-nova | 09:16 | |
*** ttsiouts has joined #openstack-nova | 09:18 | |
mdbooth | johnthetubaguy: If you're around, any chance you might prod this over the line? https://review.opendev.org/#/c/659317/ | 09:19 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: fixtures: Return a mocked class instead of method within fake_imagebackend https://review.opendev.org/619804 | 09:24 |
lyarwood | stephenfin: https://review.opendev.org/#/c/551349/ - would you mind taking a look at this if you have time today | 09:25 |
lyarwood | mdbooth: ^ there's additional stuff on top of that I could use your take on btw - https://review.opendev.org/#/q/topic:live-migration-volume-bdm-rollback-rework+(status:open+OR+status:merged) | 09:26 |
stephenfin | lyarwood: Sure. Fixing some issues with pbr/taskflow at the moment but it's next in the queue after that | 09:26 |
lyarwood | thanks | 09:26 |
*** guozijn_ has joined #openstack-nova | 09:27 | |
lyarwood | stephenfin / mdbooth ; https://review.opendev.org/#/c/572790/ - could also use reviews if you have time. | 09:28 |
*** cdent has joined #openstack-nova | 09:29 | |
*** guozijn has quit IRC | 09:31 | |
*** guozijn_ is now known as guozijn | 09:31 | |
*** bhagyashris has quit IRC | 09:33 | |
mdbooth | lyarwood: Ack | 09:34 |
*** lei-zh has quit IRC | 09:35 | |
*** markvoelker has joined #openstack-nova | 09:35 | |
*** guozijn has quit IRC | 09:46 | |
*** ttsiouts has quit IRC | 09:50 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Stop logging traceback when skipping quiesce https://review.opendev.org/660325 | 09:53 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Stop logging traceback when skipping quiesce https://review.opendev.org/660327 | 09:54 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Stop logging traceback when skipping quiesce https://review.opendev.org/660328 | 09:54 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Fix target used in nova.policy.check_is_admin https://review.opendev.org/660330 | 09:55 |
stephenfin | lyarwood: Can I get a reno for https://review.opendev.org/#/c/572790/ please? | 10:06 |
stephenfin | Actually, that's mriedem's. nvm. He'll see it soon enough | 10:06 |
*** aarents has quit IRC | 10:07 | |
*** dpawlik has quit IRC | 10:09 | |
*** markvoelker has quit IRC | 10:09 | |
*** dpawlik has joined #openstack-nova | 10:09 | |
*** mmethot has quit IRC | 10:11 | |
lyarwood | stephenfin: I will if he can't | 10:19 |
*** boxiang has joined #openstack-nova | 10:20 | |
*** boxiang has quit IRC | 10:21 | |
*** boxiang has joined #openstack-nova | 10:22 | |
*** boxiang has quit IRC | 10:24 | |
*** boxiang has joined #openstack-nova | 10:25 | |
*** dtantsur|brb is now known as dtantsur | 10:30 | |
*** boxiang has quit IRC | 10:30 | |
cdent | bauzas: Have you got a new version of https://review.opendev.org/#/c/552924/ coming? | 10:33 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: refactor volume bdm rollback error handling https://review.opendev.org/656500 | 10:45 |
*** ileixe has quit IRC | 10:46 | |
*** udesale has quit IRC | 10:46 | |
*** bbowen has quit IRC | 10:51 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova-consoleauth https://review.opendev.org/652969 | 10:55 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970 | 10:55 |
openstackgerrit | Merged openstack/nova master: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/571410 | 10:56 |
*** awalende has quit IRC | 10:58 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970 | 10:58 |
*** awalende has joined #openstack-nova | 10:59 | |
*** mmethot has joined #openstack-nova | 11:01 | |
*** ttsiouts has joined #openstack-nova | 11:02 | |
openstackgerrit | Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786 | 11:05 |
*** markvoelker has joined #openstack-nova | 11:06 | |
*** panda is now known as panda|rover|eat | 11:13 | |
*** nicolasbock has joined #openstack-nova | 11:15 | |
*** ccstone has quit IRC | 11:22 | |
openstackgerrit | Hamdy Khader proposed openstack/nova master: OVS DPDK port representors support https://review.opendev.org/658785 | 11:24 |
openstackgerrit | Merged openstack/nova master: Fix guestfs.set_backend_settings call https://review.opendev.org/524748 | 11:26 |
*** dave-mccowan has joined #openstack-nova | 11:27 | |
*** ttsiouts has quit IRC | 11:36 | |
*** markvoelker has quit IRC | 11:39 | |
openstackgerrit | Hamdy Khader proposed openstack/nova master: OVS DPDK port representors support https://review.opendev.org/658785 | 11:42 |
openstackgerrit | Merged openstack/nova master: Replace colon with comma in route comment https://review.opendev.org/660256 | 11:44 |
*** awalende has quit IRC | 11:44 | |
*** awalende has joined #openstack-nova | 11:45 | |
openstackgerrit | Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786 | 11:46 |
*** aarents has joined #openstack-nova | 11:52 | |
*** awalende has quit IRC | 11:52 | |
*** awalende has joined #openstack-nova | 11:54 | |
*** brinzh has joined #openstack-nova | 11:54 | |
*** janki has quit IRC | 11:54 | |
*** brinzhang has quit IRC | 11:56 | |
*** bbowen has joined #openstack-nova | 11:57 | |
*** ttsiouts has joined #openstack-nova | 12:06 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660361 | 12:07 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660362 | 12:07 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/660363 | 12:08 |
*** ratailor has quit IRC | 12:09 | |
*** ttsiouts has quit IRC | 12:10 | |
*** ttsiouts has joined #openstack-nova | 12:12 | |
*** udesale has joined #openstack-nova | 12:16 | |
*** tetsuro has quit IRC | 12:26 | |
openstackgerrit | Merged openstack/nova master: Restore connection_info after live migration rollback https://review.opendev.org/551349 | 12:27 |
*** panda|rover|eat is now known as panda|rover | 12:27 | |
*** francoisp has joined #openstack-nova | 12:31 | |
*** ttsiouts has quit IRC | 12:32 | |
*** psachin has quit IRC | 12:34 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Restore connection_info after live migration rollback https://review.opendev.org/660370 | 12:36 |
*** priteau has quit IRC | 12:36 | |
*** priteau has joined #openstack-nova | 12:41 | |
*** boxiang_ has joined #openstack-nova | 12:42 | |
*** asettle has joined #openstack-nova | 12:43 | |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Restore connection_info after live migration rollback https://review.opendev.org/660375 | 12:44 |
openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Add uuid filter to nova list https://review.opendev.org/660376 | 12:46 |
*** brinzh has quit IRC | 12:48 | |
*** priteau has quit IRC | 12:51 | |
*** tobias-urdin has quit IRC | 13:03 | |
*** tbachman has joined #openstack-nova | 13:04 | |
alex_xu | sean-k-mooney: good morning, do you want to have look at this https://review.opendev.org/#/c/658716/1/specs/train/approved/show-server-numa-topology.rst@110 ? | 13:05 |
alex_xu | i guess core and threads should be removed also. | 13:05 |
efried | thanks for that, kashyap | 13:06 |
alex_xu | since numa_cell.cpu_topology only valid for dedicated cpu policy, and I guess cores and threads is empty all the time | 13:06 |
sean-k-mooney | alex_xu im just waiting for someome form the gas company to call but i can take a look in an hour or so | 13:07 |
*** mriedem has joined #openstack-nova | 13:07 | |
alex_xu | sean-k-mooney: thanks, not hurry | 13:07 |
*** cgoncalves has quit IRC | 13:08 | |
*** eharney has quit IRC | 13:11 | |
sean-k-mooney | alex_xu: im ok with the api reporting the number of sockets, cores per socket and threads per core. | 13:11 |
*** janki has joined #openstack-nova | 13:11 | |
sean-k-mooney | im not sure it shoudl be reported at the numa node level however | 13:11 |
sean-k-mooney | given that its vm wide | 13:11 |
alex_xu | sean-k-mooney: yea, at least not in the numa cell | 13:11 |
sean-k-mooney | i would add cpu_topology:{sockets:1,cores:10, threads:2} as a sibling but not childe of nodes | 13:12 |
alex_xu | whether we have separated file for sockets, cores and threads, that should be a question for yonglihe and chris | 13:13 |
sean-k-mooney | that said i have not really given that much tought | 13:13 |
*** READ10 has joined #openstack-nova | 13:13 | |
alex_xu | sean-k-mooney: I will tell yonglihe, let him check with starlingx whether need sockets, cores and threads | 13:14 |
openstackgerrit | Merged openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268 | 13:15 |
*** zhongjun2_ has quit IRC | 13:15 | |
alex_xu | sean-k-mooney: actually, we won't have different hugepage size for cells | 13:16 |
alex_xu | i'm not sure this one also | 13:17 |
sean-k-mooney | correct we wont | 13:18 |
sean-k-mooney | we store the info in the db percell | 13:18 |
alex_xu | yes | 13:18 |
sean-k-mooney | but that is just so we did not have to pass it in as a peramater when calulating the assignment | 13:19 |
sean-k-mooney | but as you said the pagesize will be the same for all cells in the instance | 13:19 |
sean-k-mooney | libvirt can technically support different page sizes per cell and even multipl page sizes in the same numa cell but we have no plans to ever support that in nova so we dont really need to worry about it | 13:21 |
alex_xu | yea, can't see a usecase for that | 13:21 |
alex_xu | if they need that, then put it out of cell also, sounds correct choice | 13:22 |
sean-k-mooney | yes i think so to. | 13:22 |
*** cgoncalves has joined #openstack-nova | 13:23 | |
sean-k-mooney | i would prefer to have the vm wide things at the top level and the cell specific things at the node level. whcih i think is your preference too. | 13:23 |
alex_xu | yes. our db structure is really confuse me in the beginning | 13:24 |
alex_xu | sean-k-mooney: thanks, I think yonglihe can move forward now | 13:25 |
*** ttsiouts has joined #openstack-nova | 13:34 | |
*** tbachman_ has joined #openstack-nova | 13:35 | |
*** tbachman has quit IRC | 13:35 | |
*** tbachman_ is now known as tbachman | 13:35 | |
*** tbachman_ has joined #openstack-nova | 13:39 | |
*** tbachman has quit IRC | 13:40 | |
*** tbachman_ is now known as tbachman | 13:40 | |
*** itlinux has joined #openstack-nova | 13:43 | |
*** bbobrov has quit IRC | 13:47 | |
efried | kashyap: If you'll ack https://review.opendev.org/#/c/633855/ I'll approve it. | 13:52 |
* kashyap clicks | 13:52 | |
efried | tia | 13:53 |
boxiang_ | alex_xu: hi alex, is it necessary for me to add the approved blueprint to runways again? https://review.opendev.org/#/c/645520/ | 13:53 |
mriedem | boxiang_: yes | 13:53 |
mriedem | just queue it back up | 13:53 |
alex_xu | yea | 13:53 |
boxiang_ | ok, thanks :) | 13:54 |
*** mlavalle has joined #openstack-nova | 13:54 | |
alex_xu | boxiang_: another patch I have is want to remove something https://review.opendev.org/659243, if that makes sense, probably can save some of your code | 13:54 |
alex_xu | but still waiting for review | 13:54 |
*** jchhatbar has joined #openstack-nova | 13:57 | |
*** ttsiouts has quit IRC | 13:57 | |
*** jangutter_ has joined #openstack-nova | 13:57 | |
*** mrjk_ has joined #openstack-nova | 13:57 | |
*** mmethot_ has joined #openstack-nova | 13:57 | |
*** cdent_ has joined #openstack-nova | 13:57 | |
*** NewBruce3 has joined #openstack-nova | 13:58 | |
boxiang_ | alex_xu: got it. I will read it later. | 13:59 |
*** mriedem1 has joined #openstack-nova | 13:59 | |
mriedem1 | alex_xu: that removal change of yours would make this not work i think https://review.opendev.org/#/c/650376/ | 13:59 |
*** adrianc_ has joined #openstack-nova | 13:59 | |
alex_xu | mriedem1: emm...let me check that patch | 14:00 |
*** gary_perkins_ has joined #openstack-nova | 14:00 | |
mriedem1 | i'm trying to use requested_destination in the rebuild + new image scenario, rather than force_hosts/force_nodes | 14:00 |
mriedem1 | which requires a hack in the host manager code | 14:00 |
*** lifeless_ has joined #openstack-nova | 14:01 | |
mriedem1 | i haven't gone over https://review.opendev.org/#/c/645520/ but i would expect it to use requested_destination as well | 14:01 |
*** Anticime1 has joined #openstack-nova | 14:01 | |
efried | mriedem1 fwiw I've been having similar concerns, which is why I have been procrastinating on that patch. | 14:01 |
*** cmart has joined #openstack-nova | 14:02 | |
alex_xu | mriedem1: ok, i can have look at it tomorrow, it sounds a complex thing I don't want to go through before sleep | 14:02 |
*** tbachman_ has joined #openstack-nova | 14:02 | |
mriedem1 | yup understood, i'd comment on the review but | 14:02 |
alex_xu | efried: nice instinct~ | 14:03 |
boxiang_ | one question.if my patch is something different from the approved spec. Can I update the spec again? | 14:04 |
mriedem1 | efried: the sriov bp in the top runway slot is expired by a few days https://etherpad.openstack.org/p/nova-runways-train | 14:04 |
mriedem1 | boxiang_: you can amend the spec yes | 14:04 |
*** phasespace has quit IRC | 14:05 | |
mriedem1 | sean-k-mooney: adrianc: was a patch ever pushed to update these docs for sriov live migration? https://docs.openstack.org/neutron/latest/admin/config-sriov.html#known-limitations | 14:05 |
sean-k-mooney | mriedem1: no but its on my todolist for today. im currently updating the osc evacuate command patch | 14:06 |
*** janki has quit IRC | 14:06 | |
*** mriedem has quit IRC | 14:06 | |
*** derekh has quit IRC | 14:06 | |
*** jangutter has quit IRC | 14:06 | |
*** jamesdenton has quit IRC | 14:06 | |
*** zer0c00l has quit IRC | 14:06 | |
*** adrianc has quit IRC | 14:06 | |
*** markmcclain has quit IRC | 14:06 | |
*** lifeless has quit IRC | 14:06 | |
*** kashyap has quit IRC | 14:06 | |
*** dosaboy has quit IRC | 14:06 | |
*** NewBruce has quit IRC | 14:06 | |
*** tbachman has quit IRC | 14:06 | |
*** udesale has quit IRC | 14:06 | |
*** mmethot has quit IRC | 14:06 | |
*** cdent has quit IRC | 14:06 | |
*** ralonsoh has quit IRC | 14:06 | |
*** toabctl has quit IRC | 14:06 | |
*** mrjk has quit IRC | 14:06 | |
*** aspiers has quit IRC | 14:06 | |
*** johnthetubaguy has quit IRC | 14:06 | |
*** smcginnis has quit IRC | 14:06 | |
*** gary_perkins has quit IRC | 14:06 | |
*** Anticimex has quit IRC | 14:06 | |
*** edmondsw_ has quit IRC | 14:06 | |
*** redkrieg has quit IRC | 14:06 | |
*** cdent_ is now known as cdent | 14:06 | |
*** tbachman_ is now known as tbachman | 14:06 | |
sean-k-mooney | mriedem1: you can kick the sriov bp out of the runway and replace it with something else | 14:06 |
*** rpittau is now known as rpittau|afk | 14:06 | |
*** udesale has joined #openstack-nova | 14:07 | |
mriedem1 | sean-k-mooney: note that https://review.opendev.org/#/c/647733/ is next in the queue but is in merge conflict | 14:07 |
*** yankcrime has quit IRC | 14:07 | |
*** awalende has quit IRC | 14:07 | |
*** mriedem1 is now known as mriedem | 14:07 | |
sean-k-mooney | oh i guess i need to rebase that too | 14:07 |
mriedem | brb | 14:07 |
boxiang_ | mriedem1: ok. i see | 14:07 |
*** mriedem has quit IRC | 14:07 | |
sean-k-mooney | ok ill do that then the docs patch | 14:07 |
*** mriedem has joined #openstack-nova | 14:08 | |
efried | sean-k-mooney: I'll put it in the slot. | 14:08 |
*** Luzi has quit IRC | 14:09 | |
*** awalende has joined #openstack-nova | 14:11 | |
*** aspiers has joined #openstack-nova | 14:11 | |
sean-k-mooney | looks like teh confligt was just in the nova object version file so i should have a rebased version up shortly | 14:11 |
*** eharney has joined #openstack-nova | 14:12 | |
*** ralonsoh has joined #openstack-nova | 14:12 | |
efried | aspiers: bottom SEV patches are merging, if you want to get those other rebases working. | 14:12 |
*** itlinux has quit IRC | 14:13 | |
dansmith | efried: are you holding off on the ironic power state one for ironic side review or something? AFAICT, of the nova people who have looked at it, all are either +vote or out at the moment | 14:14 |
efried | dansmith: Yes, giving SMEs and people with prior reviews a chance to re-ack. | 14:15 |
efried | Is there some hurry to merge the spec? | 14:15 |
*** awalende has quit IRC | 14:15 | |
efried | dansmith: whoops, I actually asked jroll and melwitt to re-look, but I did it in the -placement channel by accident. | 14:15 |
dansmith | efried: we've been kinda dragging our feet with it and tssurya has been her usual overly polite self.. we discussed in a couple small groups at ptg about it so I just don't want her to continue to have to wait | 14:16 |
dansmith | efried: okay | 14:16 |
jroll | I'm +1 on it | 14:16 |
efried | dansmith: afaict the code patch isn't being held up by the bp approval https://review.opendev.org/#/c/645611/ | 14:16 |
sean-k-mooney | i have to admit i kind of like running the nova unit tests on my desktop/server | 14:16 |
*** boxiang_ has quit IRC | 14:17 | |
dansmith | efried: ... | 14:17 |
openstackgerrit | sean mooney proposed openstack/nova master: extend libvirt video model support https://review.opendev.org/647733 | 14:17 |
*** tbachman has quit IRC | 14:22 | |
sean-k-mooney | i will redeploy with ^ later today but the unit and functional test pass locally | 14:23 |
sean-k-mooney | has anyone used rtox https://pypi.org/project/rtox/ by the way | 14:23 |
*** lpetrut has quit IRC | 14:27 | |
*** _erlon_ has joined #openstack-nova | 14:27 | |
*** ykarel is now known as ykarel|afk | 14:27 | |
mriedem | low-hanging-fruit bug if someone wants it https://bugs.launchpad.net/nova/+bug/1829877 | 14:31 |
openstack | Launchpad bug 1829877 in OpenStack Compute (nova) "avoid lazy-lodaing instance.flavor during cold migration" [Low,Confirmed] | 14:31 |
mriedem | ooo typo | 14:31 |
dansmith | efried: tomorrow, the top patch set will have been up for 14 days.. presumably that's plenty of time time for anyone to have voiced their opinion, right? | 14:33 |
efried | dansmith: "top patch set" of what? | 14:34 |
dansmith | efried: the latest revision of the ironic power state change. Just trying to figure out what "a few days" means in terms of when we should set reminders to make sure that it gets merged and doesn't get ignored again | 14:34 |
efried | dansmith: Give it a couple hours for melwitt to come on the scene and pick up the IRC nag I left for her. I expect we can merge it by lunchtime. | 14:35 |
dansmith | alright | 14:36 |
efried | tssurya: Meanwhile, you should feel pretty confident this is going to go substantially as it stands, if you have the time and desire to crank on the code some :) | 14:38 |
*** liuyulong has joined #openstack-nova | 14:39 | |
*** luksky has quit IRC | 14:49 | |
*** tbachman has joined #openstack-nova | 14:55 | |
*** yankcrime has joined #openstack-nova | 14:56 | |
mriedem | hmm, scatter_gather_all_cells seems to make us lose the request_id on the context we're using | 14:57 |
*** bbowen_ has joined #openstack-nova | 14:58 | |
mriedem | which makes debugging not so nice | 14:59 |
*** bbowen has quit IRC | 15:01 | |
*** jchhatbar is now known as janki | 15:02 | |
mriedem | the RequestContext.from_dict(context.to_dict()) stuff must overwrite the thread local context | 15:04 |
*** cfriesen has joined #openstack-nova | 15:05 | |
mriedem | which messes up the logging, even though those copies should be using the same request id | 15:05 |
dansmith | mriedem: is it just that the threads we spawn to do the scatter don't get the thread-local set to their new context? | 15:06 |
*** hamzy has quit IRC | 15:07 | |
mriedem | RequestContext __init__ defaults overwrite=True so i'd think each one is updated | 15:10 |
mriedem | i'm tracing a cold migration in these logs http://logs.openstack.org/56/656656/12/check/nova-multi-cell/6a403ba/controller/logs/screen-n-super-cond.txt.gz#_May_16_19_46_23_815726 with req-bde576dc-5de2-4113-982d-025c65b97e8d which is the request starting in the API | 15:10 |
mriedem | but after that we hit the scatter/gather and lose the request id | 15:11 |
mriedem | after that it's using req-66d8138a-530a-4dec-b1cd-9c22e4402dd1 | 15:11 |
*** yan0s has quit IRC | 15:13 | |
*** awalende has joined #openstack-nova | 15:15 | |
*** kashyap` has joined #openstack-nova | 15:17 | |
*** awalende has quit IRC | 15:19 | |
aspiers | efried: yup thanks | 15:19 |
*** priteau has joined #openstack-nova | 15:24 | |
kashyap` | efried: This was re-proposed (despite me abandoning it): https://review.opendev.org/#/c/660271/ ("Re-propose the spec to allow specifying a list of CPU models") | 15:31 |
efried | I noticed that | 15:31 |
efried | haven't looked yet | 15:31 |
kashyap` | efried: Don't. After technical discussions w/ the libvirt / QEMU CPU modelling maintainers, we've concluded it's not a good idea | 15:32 |
kashyap` | At least not in its present form. | 15:32 |
efried | kashyap`: lmk if you want me to -2 bomb the sucker. | 15:32 |
kashyap` | efried: Hehe, please do. | 15:32 |
mriedem | cfriesen: ^ | 15:32 |
efried | kashyap`: save me finding the one you originally abandoned, got it at your fingertips? | 15:33 |
mriedem | unrelated, it seems odd that we'd fail to stop a libvirt cirros guest after a minute http://logs.openstack.org/56/656656/12/check/nova-multi-cell/6a403ba/compute1/logs/screen-n-cpu.txt.gz#_May_16_19_47_26_017509 | 15:33 |
kashyap` | (It was approved previously during Stein-time; but I didn't pay sufficient attention to it.) | 15:33 |
efried | nm, see the link in the comment. | 15:33 |
kashyap` | mriedem: Noticed it only today? | 15:33 |
mriedem | noticed yes, but http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Instance%20failed%20to%20shutdown%20in%2060%20seconds.%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d | 15:34 |
efried | kashyap`: I did one better, I abandoned it. | 15:34 |
mriedem | if we're burning up to a minute waiting to gracefully kill cirros guests in the gate that could explain in part why some jobs/tests are really slow | 15:35 |
kashyap` | efried: Thanks! | 15:35 |
*** hamzy has joined #openstack-nova | 15:35 | |
kashyap` | mriedem: "Needs more investigation." (I'm on mobile data in the library; will check tomm early.) | 15:38 |
mdbooth | efried: https://review.opendev.org/#/admin/groups/540,members Everybody on that list works for RH except Claudiu, John, and Matt. I don't know Claudiu, and I understand mriedem has some administrative difficulties right now :/ | 15:40 |
mdbooth | efried: So the project is entirely dependent on johnthetubaguy to land stable patches. | 15:41 |
mriedem | no it's not | 15:41 |
mriedem | https://review.opendev.org/#/admin/groups/530,members | 15:41 |
mriedem | there is an #openstack-stable channel | 15:41 |
mriedem | and people like mtreinish | 15:41 |
mriedem | i'd also say smcginnis but he's in the same boat as me | 15:42 |
kashyap` | mriedem: Aren't you referring to release managers group? | 15:42 |
mdbooth | Ok. John and Matt Treinish | 15:42 |
kashyap` | I think mdbooth is referring to "stable-core" | 15:42 |
mriedem | nova-stable-maint's parent group is stable-maint-core | 15:42 |
mdbooth | kashyap`: Yeah, mriedem was referring to stable-maint-core, who I understand can ack everything | 15:42 |
mriedem | Alan Pevecalan.pevec@redhat.comChuck Shortchucks@redhat.comFlavio Percocofpercoco@redhat.com so much for that | 15:43 |
mdbooth | mriedem: Yeah, it's a bit RH loaded :/ | 15:43 |
mriedem | at some point can RH just extend me a job offer and i can switch sides here and start approving all RH stuff? | 15:43 |
mdbooth | mriedem: You won't be allowed under trifecta rules ;) | 15:43 |
cfriesen | kashyap: what was the objection by the libvirt/qemu folks? As you recall, the weakness in the current model is that you can only specify a model on the node, and it affects all guests on that node. | 15:44 |
aspiers | mriedem: not if another Linux distro nabs you first ;-) | 15:44 |
mriedem | so pressure the foundation to figure out wtf is going on with huawei developers to be able to work on open source | 15:44 |
kashyap` | cfriesen: I don't know if that's a "weakness" per-se. But the objection was the we'd need more data; and it is finicky, error-prone. | 15:45 |
kashyap` | cfriesen: They also asked: Do you have data on why _not_ use the default 'host-model' -- that has the important double-advantage in that, it auto-adds the relevant flags | 15:45 |
*** helenafm has quit IRC | 15:45 | |
*** ykarel|afk is now known as ykarel|away | 15:45 | |
cfriesen | kashyap`: host-model can be an issue if you happen to land on a brand new compute node that has more advanced hardware than most of the other nodes | 15:46 |
cfriesen | kashyap`: makes it hard to live migrate | 15:46 |
kashyap` | cfriesen: Not quite -- 'host-model' explicitly makes sure that you _can_ live-migrate across disparate hosts. That's one of the reasons why Nova defaults to it | 15:47 |
sean-k-mooney | cfriesen: yes that is true but its kind of a know issue | 15:47 |
cfriesen | sean-k-mooney: yeah, but the whole point of the CPU model feature was to fix that known issue. :) | 15:47 |
*** kashyap` is now known as kashyap | 15:47 | |
sean-k-mooney | kashyap`: what he is raising is if you have 10 skylake servers and 90 ivybridge servers then if you land on the skylake ones you will only be able to migrate to the skylake ones | 15:48 |
cfriesen | as it stands, I think you'd need to set up host aggregates for the different hardware generations, or something like that. | 15:48 |
mriedem | fwiw i've had a non-RH core nom in mind for stable | 15:48 |
sean-k-mooney | so you would set cpu_mode=custom cpu_mode=ivybridge to mitigate against that | 15:48 |
* kashyap needs to be AFK; will read scroll once back | 15:48 | |
mdbooth | mriedem: Do say! | 15:48 |
mriedem | ill never tell! | 15:48 |
mriedem | i can start that conversation again with the nova stable maint team | 15:49 |
*** ivve has quit IRC | 15:49 | |
*** ykarel|away has quit IRC | 15:51 | |
*** janki has quit IRC | 15:55 | |
*** macza has joined #openstack-nova | 15:55 | |
*** macza has quit IRC | 15:56 | |
*** macza has joined #openstack-nova | 15:56 | |
*** ccamacho has quit IRC | 15:57 | |
*** smcginnis has joined #openstack-nova | 15:58 | |
sean-k-mooney | cfriesen: that is one apprch yes all though if i ever get arround to it i really want to play with the idea of a boaring host weigher that use traits as a proxy for how intersting a host is and selects the one with the least traits | 16:01 |
sean-k-mooney | e.g. the most boaring hosts | 16:01 |
cfriesen | boaring? like wild pigs? :) | 16:01 |
sean-k-mooney | which woudl mean if you did not ask for a trait specificaly the weigher would prefer selecting the oldest host | 16:01 |
cfriesen | sean-k-mooney: yeah, that's not a bad idea | 16:01 |
* mdbooth assumed boring | 16:02 | |
cfriesen | me too | 16:02 |
sean-k-mooney | yes its a weigher that digs holes :) | 16:02 |
*** wwriverrat has quit IRC | 16:02 | |
cfriesen | sean-k-mooney: you'd still have the problem though that if you happened to land on a "newer" node due to resource pressure you'd be stuck on that hardware for live migration | 16:03 |
sean-k-mooney | ya that is true but i acutlly want it for other reasons like avoiding my host that have gpus when you did not ask for them that sort of thing | 16:04 |
cfriesen | it just seems unnecessarily restrictive to say that all guests on a node must have the same virtual CPU | 16:04 |
sean-k-mooney | well that is what nova has always done to this point but ya im aware of the new spec too | 16:04 |
sean-k-mooney | personally i just use host-passthough and say screw it ill use host aggrates to seperate things if i need too | 16:05 |
sean-k-mooney | actully i used ot use AZs at intel for that and ould have one AZ per generation but that was just so i could select the generation simplely when lanuching a vm | 16:06 |
mtreinish | mriedem: do I need to review something? | 16:06 |
mdbooth | mtreinish: https://review.opendev.org/#/c/659317/ please? | 16:06 |
*** luksky has joined #openstack-nova | 16:06 | |
*** panda|rover has quit IRC | 16:09 | |
*** panda has joined #openstack-nova | 16:10 | |
sean-k-mooney | efried: thanks for reviewing the video models stuff ill adress your commets after dinner | 16:15 |
*** gyee has joined #openstack-nova | 16:15 | |
*** igordc has joined #openstack-nova | 16:20 | |
mriedem | kashyap: https://bugs.launchpad.net/nova/+bug/1829896 for that guest not stopping thing, i checked the libvirtd logs and the power off requests all return with 0 | 16:20 |
openstack | Launchpad bug 1829896 in OpenStack Compute (nova) "libvirt: "Instance failed to shutdown in 60 seconds." in the gate" [Undecided,New] | 16:20 |
mriedem | not urgent but is concerning | 16:20 |
sean-k-mooney | i wonder if the qemu monitor process had hung? | 16:22 |
sean-k-mooney | i would expect a non 0 return in that case but i dont know if that is the case | 16:22 |
*** mgoddard has quit IRC | 16:25 | |
*** ricolin has quit IRC | 16:27 | |
*** mgoddard has joined #openstack-nova | 16:28 | |
*** davidsha has quit IRC | 16:37 | |
ganso | mriedem: hi Matt! Just a heads up in case you haven't seen it and have some free time to look at: https://review.opendev.org/#/c/659338 Thanks in advance! =) | 16:41 |
kashyap | sean-k-mooney: Yeah, I'd expect this to return non-zero here, in of a hung QEMU mithe case of hung QEMU: 2019-05-16 19:47:19.996+0000: 10502: debug : virThreadJobClear:121 : Thread 10502 (virNetServerHandleJob) finished job remoteDispatchDomainShutdown with ret=0 | 16:41 |
*** mgoddard has quit IRC | 16:42 | |
*** mgoddard has joined #openstack-nova | 16:43 | |
kashyap | mriedem: It seems to fail with the "MigrationsAdmin" test (but your bug descriptino says: 'snapshot'), whose purpose is "Add os-migration tests for Nova v2 API" (added in 2014). | 16:46 |
*** tssurya has quit IRC | 16:47 | |
mriedem | kashyap: if you look at the logstash results it's on pretty much everything | 16:48 |
*** dtantsur is now known as dtantsur|afk | 16:48 | |
mriedem | migrate_disk_and_power_off in a cold migration / resize will also power off the guest | 16:48 |
mriedem | which is where i noticed it while debugging a cold migration test today | 16:49 |
*** whoami-rajat has quit IRC | 16:49 | |
kashyap | Hmm. So it is the actual guest | 16:52 |
kashyap | Damned if I could put a finger on why. Let me ask the libvirt folks, if they can think of anything | 16:53 |
*** udesale has quit IRC | 16:53 | |
kashyap | Wish I could reproduce the issue. Damn sure it won't if I try locally | 16:53 |
kashyap | One dev asks: | 16:54 |
kashyap | < aw> kashyap: is it the VM or the guest OS? I've had fedora fail to shutdown in a timely way for all sorts of reasons, some that I still haven't figured out | 16:54 |
mriedem | don't know, but these test vms in the gate runs are just cirros images | 16:55 |
kashyap | (I've told it's CirrOS; and it's the VM, aka. QEMU process) | 16:55 |
*** itlinux has joined #openstack-nova | 16:58 | |
*** ivve has joined #openstack-nova | 16:59 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/ocata: Fix incompatible version handling in BuildRequest https://review.opendev.org/660456 | 17:01 |
kashyap | Can anyone please remind, where is the guest boot log from the serial console here: http://logs.openstack.org/56/656656/12/check/nova-multi-cell/6a403ba/compute1/logs/ | 17:02 |
* kashyap --> make some dinner; be back later | 17:02 | |
*** dpawlik has quit IRC | 17:08 | |
sean-k-mooney | i think i just spent an hour debuging a unit test failure because teh unit tests in osc are wrong an i coppied them to create my own... | 17:09 |
*** tbachman has quit IRC | 17:10 | |
*** tbachman has joined #openstack-nova | 17:11 | |
*** igordc has quit IRC | 17:12 | |
*** igordc has joined #openstack-nova | 17:13 | |
*** jangutter_ has quit IRC | 17:14 | |
sean-k-mooney | nope i am wrong it was 2 hours but now they pass | 17:15 |
*** whoami-rajat has joined #openstack-nova | 17:15 | |
*** dpawlik has joined #openstack-nova | 17:20 | |
*** itlinux has quit IRC | 17:22 | |
*** dpawlik has quit IRC | 17:24 | |
*** eharney has quit IRC | 17:27 | |
sean-k-mooney | aspiers: mriedem i just updated https://review.opendev.org/#/c/643578/ if there are any other changes you would like let me know with a comment :) | 17:30 |
aspiers | sean-k-mooney: ok will take a look thanks! | 17:30 |
*** ralonsoh has quit IRC | 17:37 | |
*** ykarel|away has joined #openstack-nova | 17:37 | |
*** priteau has quit IRC | 17:42 | |
*** cdent has quit IRC | 17:43 | |
*** itlinux has joined #openstack-nova | 17:44 | |
*** igordc has quit IRC | 17:46 | |
aspiers | efried / anyone got any thoughts on whether it still makes sense to use nova.virt.libvirt.utils.file_open for mocking file opens? | 17:53 |
openstackgerrit | Merged openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.opendev.org/633855 | 17:53 |
openstackgerrit | Merged openstack/nova master: Extract provider tree functional tests into new file. https://review.opendev.org/660157 | 17:53 |
aspiers | \o/ first real SEV patch lands in nova! | 17:54 |
aspiers | file_open() was added in 2011 by Soren with the original framework for testing the libvirt driver | 17:55 |
aspiers | https://opendev.org/openstack/nova/commit/bb622e6d7c921894fd0e7697a0003630989d4f35 | 17:55 |
aspiers | he wrote "I hope eventually to make it similar to fakelibvirt in style (e.g. keep track of files created and deleted and attempts to open a file that it doesn't know about, you'll get proper exceptions with proper errnos set and whatnot)." | 17:56 |
aspiers | meanwhile, a ton of other tests just use mock.mock_open() | 17:57 |
aspiers | sean-k-mooney: any thoughts? | 17:57 |
efried | aspiers: The reason it exists is so that fake_libvirt_utils can mock it | 18:00 |
efried | and fake_libvirt_utils is dying in a fire. | 18:00 |
efried | https://review.opendev.org/#/c/642558/8 | 18:00 |
efried | IMO there's no reason for it to exist; we should just use mock_open | 18:00 |
aspiers | efried: my point was that a whole bunch of stuff needs to (and does) mock open, not just that | 18:00 |
aspiers | and it seems we have two different ways of doing it right now | 18:00 |
efried | yup | 18:01 |
efried | If you want to do the cleanup to kill file_open, I would support that. | 18:01 |
efried | meanwhile, definitely don't do anything that relies of fake_libvirt_utils.file_open | 18:01 |
aspiers | file_open seems much less popular right now than mock_open | 18:01 |
efried | and save yourself having more cleanup by avoiding mocking file_open - just mock open. | 18:01 |
efried | yeah. | 18:02 |
efried | Nice intention, but clearly nobody in the last eight years has cared enough to make it go. | 18:02 |
aspiers | having said that, Soren's original intention does make sense ... right | 18:02 |
efried | Just be wary of side effects. I had a situation recently where mocking open at the test method level was too broad and effed up, like, a dynamic import or something. | 18:02 |
aspiers | but file_open is actually also defined in nova/virt/libvirt/utils.py | 18:03 |
efried | so I had to do the | 18:03 |
efried | orig_open = builtins.open | 18:03 |
efried | def fake_open(f, ...): | 18:03 |
efried | if f == 'thing_i_care_about': | 18:03 |
efried | do_the_mock_thing | 18:03 |
efried | else: | 18:03 |
efried | return orig_open(f, ...) | 18:03 |
efried | thing. | 18:03 |
aspiers | isn't that what mock_open is supposed to help avoid? | 18:04 |
efried | yes, it's defined in fake_libvirt_utils because it was defined in libvirt.utils and apparently whoever set that up didn't know how to mock (or maybe mock wasn't properly powerful back then, dunno). | 18:04 |
efried | aforementioned series is getting rid of fake_libvirt_utils and just mocking the utils directly. | 18:05 |
aspiers | ah | 18:05 |
aspiers | makes sense, since a bunch of stuff is doing @mock.patch('nova.virt.libvirt.utils.file_open', ... | 18:05 |
aspiers | I'll stare at that review until I understand it | 18:05 |
efried | aspiers: re "isn't that what mock_open is supposed to help avoid?" -- not that I know of. Is there a way to make the mock automatically trigger conditionally based on the inputs? | 18:06 |
aspiers | I *think* there is, IIRC | 18:07 |
aspiers | I may have even done it recently, but would have to check | 18:07 |
efried | I thought mock_open was just good for abstracting the context manager awkwardness and providing an easy way to specify "output". | 18:07 |
efried | I don't see any conditionally-use-the-real-open mentioned in https://docs.python.org/3.3/library/unittest.mock.html#mock-open | 18:08 |
aspiers | Yeah I'm probably thinking of something else | 18:10 |
aspiers | mock is very powerful, but I find the API pretty damn confusing | 18:11 |
aspiers | I don't think it's the best designed API in the world | 18:11 |
aspiers | rspec is quite a bit easier to use | 18:11 |
*** READ10 has quit IRC | 18:12 | |
aspiers | efried: maybe I was just thinking of side_effect, which would presumably at least avoid the need for orig_open | 18:13 |
efried | aspiers: We should totally use mox | 18:13 |
efried | I don't see how side_effect would avoid needing orig_open | 18:14 |
aspiers | Ah, yeah maybe not | 18:14 |
*** panda has quit IRC | 18:14 | |
efried | side_effect lets you replace the generic no-op method with a method of your own design. | 18:15 |
* aspiers crawls back in a corner and puts a dunce hat on | 18:15 | |
efried | that method would still have to have a condition to orig_open if that was a thing you needed. | 18:15 |
*** panda has joined #openstack-nova | 18:15 | |
efried | no need for that, this is good discussion. | 18:15 |
aspiers | ;) | 18:15 |
efried | helps clarify it in my mind if nothing else | 18:15 |
aspiers | I was thinking that inside the side_effect context, the built-in open would still be available | 18:15 |
efried | ah. Yeah, no. | 18:16 |
aspiers | but maybe it's not | 18:16 |
efried | you would recurse into your mock. | 18:16 |
aspiers | Right | 18:16 |
efried | and then other kinds of curse | 18:16 |
aspiers | That's necessary to support re-entrancy cases, I guess | 18:16 |
efried | also because it was the simplest to implement :) | 18:16 |
aspiers | I guess you were already well aware of https://governance.openstack.org/tc/goals/rocky/mox_removal.html | 18:18 |
*** jmlowe has quit IRC | 18:18 | |
*** igordc has joined #openstack-nova | 18:18 | |
aspiers | I never tried mox, so it's a shame if that's nicer to work with, but I guess consistency trumps niceness | 18:18 |
efried | aspiers: I was totally kidding. We've been working on removing mox for years now. | 18:20 |
efried | I find it very difficult to understand, but that's probably mostly because I'm not used to it. | 18:20 |
*** eharney has joined #openstack-nova | 18:21 | |
efried | weird method-chain-y way of setting things up | 18:21 |
efried | method chaining and pep8 don't mix very well | 18:21 |
*** xek_ has joined #openstack-nova | 18:21 | |
aspiers | Oh right :) | 18:22 |
*** xek has quit IRC | 18:24 | |
*** cfriesen has quit IRC | 18:28 | |
*** cfriesen has joined #openstack-nova | 18:28 | |
*** xek__ has joined #openstack-nova | 18:30 | |
mriedem | sean-k-mooney: i've noticed that the ksa only client stuff we're doing with port bindings in the nova/network/neutronv2/api.py stuff is not propagating the request id into the neutron requests which makes correlating the nova and neutron logs tricky | 18:31 |
*** xek_ has quit IRC | 18:33 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1829914 | 18:36 |
openstack | Launchpad bug 1829914 in OpenStack Compute (nova) "nova context request_id is not propagated for port binding operations in neutron" [Medium,Triaged] | 18:36 |
aspiers | efried: since you mentioned the idea of partial patching with pass-through to the original function in the cases which don't match specific parameters, what's the rationale for doing that? | 18:36 |
aspiers | efried: for example I see it here: https://opendev.org/openstack/nova/src/branch/master/nova/tests/unit/virt/libvirt/test_driver.py#L18199 | 18:36 |
aspiers | but if a test ends up hitting code which tests for file existence on the test system, shouldn't the test bomb out rather than accidentally succeed just because the original function luckily returns the right thing to make the test pass? | 18:37 |
aspiers | AFAICS that would apply for both os.path.exists and file.open | 18:38 |
aspiers | e.g. I want to mock the result of os.path.exists('/sys/module/kvm_amd/parameters/sev'), but if the code happens to also run os.path.exists('something/else') then that should be mocked too | 18:39 |
*** itlinux has quit IRC | 18:40 | |
aspiers | I suppose assert_called_once_with() will take care of that | 18:44 |
aspiers | ohhhh, it needs to be able to find stuff like placement-policy.yaml | 18:48 |
*** xek has joined #openstack-nova | 18:49 | |
*** xek__ has quit IRC | 18:50 | |
aspiers | OK, so I need to reuse patch_exists() which is currently in TestGuestConfigSysinfoSerialOS | 18:52 |
aspiers | maybe I can move it to nova.test.TestCase | 18:53 |
mriedem | sean-k-mooney: it looks like the cross-cell resize revert cold migration flow is failing because when reverting on the dest host, we first delete the active dest host port binding and then on the source host, we update the port's binding:host_id to point at the source host, but that fails in neutron with a not found error i think because it's complaining that the dest host port binding is already gone | 18:55 |
mriedem | which seems weird, i'm not sure why it would care | 18:55 |
mriedem | but we might have the same issue for live migration rollbacks which we don't test in the gate | 18:55 |
mriedem | i.e. i think we might need https://review.opendev.org/#/c/594139/ | 18:57 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Use SDK instead of ironicclient for add/remove instance info from node https://review.opendev.org/659691 | 19:01 |
*** gyee has quit IRC | 19:07 | |
efried | aspiers: Looks like you figured it out, but yeah, sometimes the code you're calling goes off and does things outside of the purview of the thing you're testing, and sometimes those things hit the thing you're mocking, if you're mocking something low-level like open or file existence, so you only want to use your mock in the code paths that you care about, and otherwise leave them unaffected. | 19:08 |
openstackgerrit | Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786 | 19:08 |
aspiers | efried: yeah, it hadn't occurred to me that os.path.exists() might be called on files which are actually inside the virtualenv, like placement-policy.yaml | 19:15 |
aspiers | efried: but when I blanket-mocked it, placement blew up in my face :) | 19:16 |
aspiers | efried: so I'm moving patch_exists() to nova.test.TestCase for reuse | 19:16 |
efried | ight | 19:19 |
*** gyee has joined #openstack-nova | 19:19 | |
sean-k-mooney | mriedem: ill take a look. once we have activated the dest binding it should have atomicly delete teh source binding so that makes sense | 19:21 |
*** maciejjozefczyk has quit IRC | 19:26 | |
mriedem | i thought activating the dest binding just makes the source binding automatically inactive, but not deleted | 19:26 |
*** Sundar has joined #openstack-nova | 19:26 | |
openstackgerrit | Adam Spiers proposed openstack/nova master: Move patch_exists() to nova.test.TestCase for reuse https://review.opendev.org/660500 | 19:26 |
aspiers | efried: ^^^^ | 19:26 |
*** whoami-rajat has quit IRC | 19:29 | |
sean-k-mooney | mriedem: actully looking at the spec https://specs.openstack.org/openstack/neutron-specs/specs/ocata/portbinding_information_for_nova.html#usage-by-nova you are correct but i had a feeling it was different for some reason | 19:30 |
mriedem | looking at the ml2 plugin code that also looks correct, | 19:30 |
mriedem | originally i had also assumed the deleting the active binding would automatically re-activate the inactive binding, but that's not the case | 19:30 |
mriedem | it just deletes the active port binding resource and i think that eventually makes the vif_type=unbound | 19:31 |
mriedem | which is why i have https://review.opendev.org/#/c/594139/ | 19:31 |
openstackgerrit | Merged openstack/nova stable/stein: Fix retry of instance_update_and_get_original https://review.opendev.org/659317 | 19:32 |
sean-k-mooney | yes if there is no active port binding having it revert to vif_type=unbound make sense | 19:32 |
mriedem | my guess is there might be a bug in neutron when (1) delete the active binding and then (2) change the port's binding:host_id to a new host (for the inactive binding), it must try to do some cleanup of the old binding and fails b/c it doesn't exist anymore | 19:32 |
sean-k-mooney | well thats the think i dont think its valide to just update teh inactive binding | 19:32 |
sean-k-mooney | that part of why the other live migration issue was happening | 19:33 |
sean-k-mooney | the neutron port bidning api seems to only work if you interact with it exactly as they expect with no auto recovery if we delete or update things | 19:34 |
sean-k-mooney | the spec didnt say we were allowed to interact with it in thos other ways so its fair but likely it could be made more robust | 19:34 |
mriedem | yeah maybe, i'd accept that if i opened a neutron bug and that was the response | 19:34 |
mriedem | or if mlavalle said that was the case | 19:35 |
*** ykarel|away has quit IRC | 19:36 | |
sean-k-mooney | i also would not expect much push back if we specified the set of addtion behavior we intuitivly expect to work and proposed them as an extention | 19:36 |
mriedem | i don't really care about making those edge cases work, | 19:36 |
mriedem | i'd just like clarity on the api, since it's not documented in the api-ref | 19:36 |
mriedem | so maybe that's the neutron bug is just lack of docs | 19:37 |
sean-k-mooney | right i more or less keep going back to the spec to determin what the expected behavior is | 19:37 |
sean-k-mooney | my guess is what happening is becasue of https://specs.openstack.org/openstack/neutron-specs/specs/ocata/portbinding_information_for_nova.html#effects-on-existing-apis | 19:37 |
sean-k-mooney | Update Port with host_id will still re-trigger port binding for a host. The difference will be update_port() will only action on the active binding. | 19:38 |
mriedem | "The difference will be update_port() will only action on the active binding." | 19:38 |
mriedem | yeah | 19:38 |
mriedem | and if the active binding doesn't exist.... | 19:38 |
mlavalle | mriedem: has the src inactive binding benn deleted when you try to go back? | 19:38 |
mriedem | mlavalle: no | 19:38 |
mriedem | well, not as far as i know anyway | 19:38 |
mriedem | nova isn't explicitly deleting the inactive source host binding | 19:39 |
sean-k-mooney | the correfct thing to do based on the spec would be to reactivate the souce binding | 19:39 |
mlavalle | in that case, I think that whn going back, activate tje source binding | 19:39 |
sean-k-mooney | rather then update it | 19:39 |
sean-k-mooney | which is what mriedem is doing in https://review.opendev.org/#/c/594139/ correct | 19:39 |
sean-k-mooney | ya in setup_networks_on_host | 19:40 |
mriedem | ok yeah that's what i'll try (when i can push up the change) | 19:41 |
sean-k-mooney | mriedem: that is what you are already doing in https://review.opendev.org/#/c/594139/1/nova/network/neutronv2/api.py@423 | 19:42 |
sean-k-mooney | instance.host should be the souce host | 19:42 |
mriedem | sean-k-mooney: that's not a patch in my cross-cell series though | 19:42 |
mriedem | it's just a related thing | 19:42 |
sean-k-mooney | oh ok | 19:42 |
mriedem | and ^ isn't merged anyway | 19:43 |
sean-k-mooney | i wonder if we call _update_port_binding_for_instance in teh revert flow | 19:44 |
sean-k-mooney | that might be why https://review.opendev.org/#/c/653506/ was fixign your cross cell issue | 19:45 |
mriedem | i'm not using https://review.opendev.org/#/c/653506/ in the cross-cell series | 19:45 |
mriedem | what fixed the cross-cell issue was i needed to activate the dest host bindings before calling migrate_instance_finish https://review.opendev.org/#/c/634832/29/nova/compute/manager.py@4625 | 19:45 |
mriedem | same as live migration in _post_live_migration | 19:46 |
sean-k-mooney | actully i missed something the cross cell migration/resize is a cold migration. you choose to use the the multiple port binding flow for cross cell migrations? | 19:47 |
mriedem | yes | 19:48 |
sean-k-mooney | ah ok | 19:48 |
mriedem | because we want to validate early that we can create the port binding on the dest host in the target cell | 19:48 |
sean-k-mooney | then yes that makes sense that you would have to also add that | 19:48 |
sean-k-mooney | yep cross cell is proably even more imporant then live migration in that its likely more expensive to try again | 19:49 |
*** logan- has quit IRC | 19:55 | |
sean-k-mooney | i think the answer is no but does the super conductor ever call the cell conductor or does it always interact directly with a compute node. that a general cellsv2 question not related to your patches | 19:55 |
sean-k-mooney | i just realised i dont think i have ever seen code in the conductor call another conductor but i have nerver actully looked either | 19:56 |
mriedem | it calls the compute | 20:00 |
sean-k-mooney | and the compute talks to its local cell conductor as needed | 20:00 |
mriedem | yes | 20:13 |
*** bbowen_ has quit IRC | 20:18 | |
sean-k-mooney | mriedem: thanks for the correction/comments on https://review.opendev.org/#/c/643578 ill fix that up tomorrow | 20:32 |
sean-k-mooney | mriedem: are you ok with the verb 'resurrect' by the way | 20:33 |
mriedem | from the forum session etherpad there is a note that mordred wants to talk about naming | 20:34 |
mriedem | https://etherpad.openstack.org/p/DEN-osc-compute-api-gaps | 20:34 |
openstackgerrit | Eric Fried proposed openstack/nova master: Support old & new versions of svm and avx traits https://review.opendev.org/660515 | 20:35 |
sean-k-mooney | ill ping him and dean to review once i fix up the last few bits | 20:35 |
mriedem | dansmith may or may not have strong feelings about how evacuate gets named in osc | 20:36 |
sean-k-mooney | ill also proably submit a patch to try and swap over the nova live migration job to uses it but im not 100% certin a depens-on will work. i could add it to the requred project which should work but no sure we want to do that in general | 20:37 |
mriedem | you could test it with a dnm/wip patch until it's released in osc | 20:37 |
sean-k-mooney | ya i can try that | 20:38 |
sean-k-mooney | its more i dont think we want to use osc in the gate form mater in general | 20:38 |
sean-k-mooney | so i can juse a dnm patch that does for testing | 20:38 |
sean-k-mooney | then drop the source install bit after its released | 20:38 |
sean-k-mooney | i just dont want to adde the python-openstackclient as a required project in the final version of the gate job patch but as you siad tis fine for a dnm or wip patch | 20:39 |
mriedem | we already use osc in the gate | 20:40 |
mriedem | for devstack and grenade | 20:40 |
mriedem | using the things we want users to use in our testing is a good thing | 20:40 |
dansmith | mriedem: I dunno.. I definitely want a different name for it, but don't think we should change the API.. having it be named something different in osc seems confusing, especially since it will be a new operation that isn't one of the other three evacuates we have | 20:43 |
mriedem | new operation? | 20:44 |
mriedem | it would just be the osc version of https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-evacuate | 20:44 |
*** hamzy has quit IRC | 20:45 | |
sean-k-mooney | mriedem: oh im not saying we shoulding use osc in the gate i was saying we proably want to stick to released versions in the gate rather then adding to reqiured porjects which get translated in to LIBS_FORM_GIT which will install it form master | 20:46 |
mriedem | sean-k-mooney: yes agree | 20:46 |
sean-k-mooney | dansmith: my current patch just delegated internall to the nova evacuate command so its the same one that we know and hate | 20:47 |
sean-k-mooney | dansmith: origially i was calling the osc version "openstack server recreate" but aspiers asked me to change it to "openstack server resurrect" | 20:48 |
sean-k-mooney | which is what the current patch uses | 20:48 |
dansmith | sean-k-mooney: right and I'm saying having the command name be something new may not help with the confusion | 20:49 |
sean-k-mooney | dansmith: that is vaild | 20:49 |
dansmith | because now it will be "resurrect in osc, which is evacuate in novaclient, which is not host-evacuate or host-evacuate-live" | 20:49 |
*** xek has quit IRC | 20:49 | |
sean-k-mooney | at least for osc we currently dont have the host versions | 20:49 |
*** dave-mccowan has quit IRC | 20:50 | |
sean-k-mooney | we did talk about that in the fourm session however but bauzas is not a fan of adding them to osc and well i dont care one way or another | 20:50 |
mriedem | and then i had to yell at both of you, it was great fun | 20:50 |
sean-k-mooney | :) | 20:51 |
sean-k-mooney | anyway ill add the docs and a release not and fix all the spelling mistakes tomorrow then let the patch sit for a few days for peopel to think about | 20:52 |
*** dave-mccowan has joined #openstack-nova | 20:57 | |
mriedem | fwiw in osc the sub-command is scoped to the source which might avoid some confusion | 20:57 |
mriedem | i.e. nova evacuate vs openstack server evacuate | 20:57 |
mriedem | so that should lessen confusion over what evacuate means per resource | 20:57 |
mriedem | if we did a whole host evacuate in osc, it would likely be "openstack compute service evacuate" | 20:58 |
mriedem | since there is a 'compute service' resource | 20:58 |
sean-k-mooney | is ironic the only case where there is not a 1:1 correspondece between compute services and hypervisors | 20:59 |
mriedem | yes | 20:59 |
sean-k-mooney | in the ironic case you would jsut use teh server version | 20:59 |
sean-k-mooney | ok i was wondering if vmware worked similarly | 21:00 |
mriedem | it used to back before i think kilo or liberty | 21:00 |
mriedem | 1 nova-compute service host could manage M vcenters | 21:00 |
mriedem | much hilarity ensued | 21:01 |
sean-k-mooney | im sure cdent has fond memories | 21:01 |
mriedem | this was pre-cdent in nova or vmware | 21:01 |
mriedem | but coincidentally had dire consequences for evacuate | 21:01 |
mriedem | i.e. nova deleting all vms in your vcenter | 21:02 |
mriedem | oops! | 21:02 |
sean-k-mooney | i can imagine | 21:02 |
dansmith | mriedem: you mean the scoping actually makes "evacuate" less bad right? | 21:04 |
sean-k-mooney | the only thing that is unintutive about evacuate (ignoring the host versions) is the fact for ephmereal root volumes you loose the data | 21:06 |
sean-k-mooney | if evacuated only worked for instacnes with shared storage it actully would be a good name for what it does | 21:07 |
sean-k-mooney | we brefliy discussed the idea of one command that always preservs your data and a second that always recreates the vm with the same image and flavor but again that might be more confusing | 21:08 |
sean-k-mooney | anway night all o/ | 21:09 |
dansmith | that is not the only thing | 21:09 |
dansmith | but we've been over it a hundred times | 21:10 |
mriedem | dansmith: yes | 21:10 |
dansmith | I think keeping evacuate and relying on the scoping to disambiguate is the best plan at the moment | 21:10 |
*** logan- has joined #openstack-nova | 21:16 | |
* aspiers agrees it is not the only thing unintuitive about it | 21:16 | |
sean-k-mooney | ill rephase while i wait for mincraft to load. the only thing where i have gone that must be a bug is the differecne between what we do for instance on shared storage vs non shared storage | 21:18 |
*** bbowen_ has joined #openstack-nova | 21:27 | |
*** slaweq has quit IRC | 21:27 | |
*** maciejjozefczyk has joined #openstack-nova | 21:38 | |
*** _alastor_ has joined #openstack-nova | 21:39 | |
*** dave-mccowan has quit IRC | 21:40 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 21:42 |
*** maciejjozefczyk has quit IRC | 21:44 | |
*** _alastor_ has quit IRC | 21:46 | |
*** itlinux has joined #openstack-nova | 21:49 | |
*** mriedem has quit IRC | 21:51 | |
*** itlinux has quit IRC | 21:54 | |
*** bbobrov has joined #openstack-nova | 21:56 | |
*** cmart has quit IRC | 21:58 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 22:01 |
dansmith | efried: any luck raising melwitt for that ironic power state spec? | 22:01 |
efried | nope | 22:03 |
dansmith | aight, I'm about to end my day, so I'll leave it up on my screen to check in the morning | 22:03 |
efried | cool beans | 22:03 |
efried | dansmith: FYI I'm +2 all the way on cellsv1 removal, in case you want to hit those... | 22:04 |
efried | ...for some loose definition of "want", | 22:04 |
dansmith | efried: probably should wait a few weeks until all the inactive former cellsv1 people have had a chance to look | 22:04 |
*** rcernin has joined #openstack-nova | 22:05 | |
*** _alastor_ has joined #openstack-nova | 22:05 | |
efried | Vek: ^ | 22:06 |
*** tesseract has quit IRC | 22:07 | |
*** _alastor_ has quit IRC | 22:10 | |
efried | bauzas: Would you please ack https://review.opendev.org/#/c/651681/ (since you had an earlier -1 on it)? | 22:11 |
*** ttsiouts has joined #openstack-nova | 22:15 | |
*** itlinux has joined #openstack-nova | 22:26 | |
*** _alastor_ has joined #openstack-nova | 22:39 | |
*** rcernin has quit IRC | 22:40 | |
*** ttsiouts has quit IRC | 22:40 | |
*** rcernin has joined #openstack-nova | 22:41 | |
*** itlinux has quit IRC | 22:43 | |
*** tjgresha has joined #openstack-nova | 22:51 | |
openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Integrating with unified limits https://review.opendev.org/615180 | 22:53 |
efried | o/ | 22:53 |
*** prometheanfire has joined #openstack-nova | 22:53 | |
prometheanfire | http://logs.openstack.org/54/660254/2/check/cross-nova-functional/a0617a9/testr_results.html.gz | 22:53 |
prometheanfire | failures for the new fasteners fasteners===0.15 | 22:54 |
*** ttsiouts has joined #openstack-nova | 22:56 | |
*** tkajinam has joined #openstack-nova | 22:59 | |
*** ttsiouts has quit IRC | 23:01 | |
*** Sundar has quit IRC | 23:02 | |
*** ttsiouts has joined #openstack-nova | 23:05 | |
*** rchurch_ has quit IRC | 23:11 | |
*** _erlon_ has quit IRC | 23:17 | |
*** luksky has quit IRC | 23:26 | |
*** mlavalle has quit IRC | 23:36 | |
*** macza has quit IRC | 23:39 | |
*** macza has joined #openstack-nova | 23:40 | |
*** itlinux has joined #openstack-nova | 23:45 | |
*** itlinux_ has joined #openstack-nova | 23:47 | |
*** macza has quit IRC | 23:47 | |
*** itlinux has quit IRC | 23:49 | |
*** tbachman has quit IRC | 23:57 | |
*** itlinux_ has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!