| *** rchurch has joined #openstack-nova | 00:01 | |
| *** gyee has quit IRC | 00:10 | |
| *** hamzy has joined #openstack-nova | 00:10 | |
| *** altlogbot_2 has quit IRC | 00:10 | |
| *** altlogbot_0 has joined #openstack-nova | 00:12 | |
| *** frankwang has quit IRC | 00:14 | |
| *** frankwang has joined #openstack-nova | 00:17 | |
| *** rcernin has quit IRC | 00:21 | |
| *** rcernin has joined #openstack-nova | 00:21 | |
| *** tbachman has joined #openstack-nova | 00:22 | |
| *** ttsiouts has quit IRC | 00:28 | |
| *** frankwang is now known as frank | 00:32 | |
| *** frank is now known as frank_1 | 00:32 | |
| *** igordc has quit IRC | 00:36 | |
| *** _alastor_ has quit IRC | 00:37 | |
| *** brinzhang has joined #openstack-nova | 00:43 | |
| *** ttsiouts has joined #openstack-nova | 00:44 | |
| *** jamesdenton has joined #openstack-nova | 00:44 | |
| *** ttsiouts has quit IRC | 00:49 | |
| openstackgerrit | Guo Jingyu proposed openstack/nova master: Skip existing VMs when hosts apply force_config_drive https://review.opendev.org/659703 | 01:09 |
|---|---|---|
| *** _alastor_ has joined #openstack-nova | 01:17 | |
| *** betherly has quit IRC | 01:17 | |
| *** ttsiouts has joined #openstack-nova | 01:17 | |
| *** rcernin has quit IRC | 01:22 | |
| *** ttsiouts has quit IRC | 01:22 | |
| *** rcernin has joined #openstack-nova | 01:22 | |
| *** _alastor_ has quit IRC | 01:23 | |
| *** _alastor_ has joined #openstack-nova | 01:31 | |
| *** _alastor_ has quit IRC | 01:45 | |
| *** ttsiouts has joined #openstack-nova | 01:48 | |
| *** tbachman has quit IRC | 02:06 | |
| *** awalende has joined #openstack-nova | 02:09 | |
| *** awalende has quit IRC | 02:13 | |
| *** bbowen_ has quit IRC | 02:16 | |
| *** bbowen_ has joined #openstack-nova | 02:16 | |
| *** ttsiouts has quit IRC | 02:22 | |
| *** ykarel|away has joined #openstack-nova | 02:24 | |
| *** tbachman has joined #openstack-nova | 02:26 | |
| *** tbachman has quit IRC | 02:30 | |
| *** cfriesen has quit IRC | 02:34 | |
| *** ricolin has joined #openstack-nova | 02:44 | |
| *** nicolasbock has quit IRC | 02:45 | |
| *** bbowen_ has quit IRC | 02:53 | |
| *** boxiang has joined #openstack-nova | 03:02 | |
| *** tbachman has joined #openstack-nova | 03:04 | |
| openstackgerrit | Merged openstack/nova-specs master: Support server power state update through external event https://review.opendev.org/636132 | 03:05 |
| *** frank_1 has quit IRC | 03:11 | |
| *** frank_1 has joined #openstack-nova | 03:12 | |
| *** boxiang has quit IRC | 03:15 | |
| *** _alastor_ has joined #openstack-nova | 03:19 | |
| *** whoami-rajat has joined #openstack-nova | 03:20 | |
| *** _alastor_ has quit IRC | 03:28 | |
| *** _alastor_ has joined #openstack-nova | 03:28 | |
| openstackgerrit | Merged openstack/nova stable/stein: Fix assert methods in unit tests https://review.opendev.org/657708 | 03:31 |
| *** ttsiouts has joined #openstack-nova | 03:31 | |
| *** _alastor_ has quit IRC | 03:37 | |
| *** _alastor_ has joined #openstack-nova | 03:37 | |
| *** psachin has joined #openstack-nova | 03:38 | |
| *** _alastor_ has quit IRC | 03:46 | |
| *** tbachman_ has joined #openstack-nova | 03:53 | |
| *** tbachman has quit IRC | 03:53 | |
| *** tbachman has joined #openstack-nova | 03:55 | |
| *** itlinux has joined #openstack-nova | 03:55 | |
| *** tbachman_ has quit IRC | 03:57 | |
| *** ykarel|away is now known as ykarel | 03:58 | |
| *** ttsiouts has quit IRC | 04:05 | |
| *** tbachman has quit IRC | 04:11 | |
| *** udesale has joined #openstack-nova | 04:11 | |
| *** markvoelker has joined #openstack-nova | 04:14 | |
| *** markvoelker has quit IRC | 04:18 | |
| *** ivve has quit IRC | 04:26 | |
| *** slaweq has joined #openstack-nova | 04:40 | |
| *** _alastor_ has joined #openstack-nova | 04:49 | |
| *** ykarel has quit IRC | 04:53 | |
| *** _alastor_ has quit IRC | 04:57 | |
| *** _alastor_ has joined #openstack-nova | 04:58 | |
| *** itlinux has quit IRC | 05:06 | |
| *** _alastor_ has quit IRC | 05:07 | |
| *** ykarel has joined #openstack-nova | 05:11 | |
| *** ttsiouts has joined #openstack-nova | 05:11 | |
| openstackgerrit | Abhishek Kekane proposed openstack/nova-specs master: Support multiple store of Glance https://review.opendev.org/641210 | 05:18 |
| *** dpawlik has joined #openstack-nova | 05:18 | |
| *** ratailor has joined #openstack-nova | 05:20 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Update "add host and hypervisor_hostname flag to create server" spec https://review.opendev.org/660560 | 05:21 |
| *** ajo has quit IRC | 05:27 | |
| *** jrosser has quit IRC | 05:29 | |
| *** rm_work has quit IRC | 05:31 | |
| *** dustinc has quit IRC | 05:31 | |
| *** ajo has joined #openstack-nova | 05:33 | |
| *** jrosser has joined #openstack-nova | 05:34 | |
| *** dustinc has joined #openstack-nova | 05:34 | |
| *** rm_work has joined #openstack-nova | 05:34 | |
| *** ivve has joined #openstack-nova | 05:39 | |
| *** lpetrut has joined #openstack-nova | 05:40 | |
| *** imacdonn has quit IRC | 05:41 | |
| *** imacdonn has joined #openstack-nova | 05:41 | |
| *** boxiang has joined #openstack-nova | 05:43 | |
| *** guozijn has joined #openstack-nova | 05:44 | |
| *** ttsiouts has quit IRC | 05:45 | |
| boxiang | alex_xu: hi alex, if it's convenient of you, please take a look at this updated spec https://review.opendev.org/#/c/660560/1 | 05:47 |
| boxiang | you can find some comments here https://review.opendev.org/#/c/645520/19/nova/compute/api.py@981 | 05:47 |
| boxiang | thank you :) | 05:47 |
| boxiang | if others here, welcome :) | 05:48 |
| *** ivve has quit IRC | 05:54 | |
| *** Luzi has joined #openstack-nova | 06:00 | |
| *** guozijn_ has joined #openstack-nova | 06:05 | |
| *** guozijn has quit IRC | 06:07 | |
| *** guozijn_ is now known as guozijn | 06:08 | |
| *** ttsiouts has joined #openstack-nova | 06:14 | |
| *** markvoelker has joined #openstack-nova | 06:15 | |
| *** ttsiouts has quit IRC | 06:18 | |
| *** tetsuro has joined #openstack-nova | 06:18 | |
| *** dpawlik has quit IRC | 06:27 | |
| *** janki has joined #openstack-nova | 06:27 | |
| *** dtantsur|afk is now known as dtantsur | 06:28 | |
| *** Luzi_ has joined #openstack-nova | 06:33 | |
| *** liuyulong has quit IRC | 06:38 | |
| *** Luzi_ has quit IRC | 06:41 | |
| *** liuyulong has joined #openstack-nova | 06:47 | |
| *** markvoelker has quit IRC | 06:49 | |
| *** ttsiouts has joined #openstack-nova | 06:53 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:55 | |
| *** frank_wang has joined #openstack-nova | 06:56 | |
| *** frank_1 has quit IRC | 07:00 | |
| *** ralonsoh has joined #openstack-nova | 07:02 | |
| *** ralonsoh has quit IRC | 07:03 | |
| *** ralonsoh has joined #openstack-nova | 07:03 | |
| *** _alastor_ has joined #openstack-nova | 07:04 | |
| *** tssurya has joined #openstack-nova | 07:12 | |
| *** _alastor_ has quit IRC | 07:12 | |
| *** _alastor_ has joined #openstack-nova | 07:13 | |
| *** boxiang has quit IRC | 07:16 | |
| *** awalende has joined #openstack-nova | 07:17 | |
| *** pcaruana has joined #openstack-nova | 07:17 | |
| *** tesseract has joined #openstack-nova | 07:18 | |
| openstackgerrit | Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.opendev.org/658716 | 07:19 |
| *** rpittau|afk is now known as rpittau | 07:19 | |
| *** _alastor_ has quit IRC | 07:21 | |
| openstackgerrit | zhaixiaojun proposed openstack/nova master: Update description of valid whitelist for non-admin user https://review.opendev.org/642403 | 07:24 |
| *** ttsiouts has quit IRC | 07:26 | |
| *** guozijn_ has joined #openstack-nova | 07:27 | |
| *** guozijn has quit IRC | 07:27 | |
| *** guozijn_ is now known as guozijn | 07:27 | |
| *** luksky has joined #openstack-nova | 07:29 | |
| *** helenafm has joined #openstack-nova | 07:32 | |
| *** guozijn has quit IRC | 07:32 | |
| *** boxiang_ has joined #openstack-nova | 07:32 | |
| *** guozijn has joined #openstack-nova | 07:42 | |
| *** luksky has quit IRC | 07:42 | |
| *** markvoelker has joined #openstack-nova | 07:46 | |
| *** ttsiouts has joined #openstack-nova | 07:46 | |
| *** ykarel is now known as ykarel|lunch | 07:52 | |
| *** jangutter has joined #openstack-nova | 07:56 | |
| *** luksky has joined #openstack-nova | 07:57 | |
| *** ociuhandu has quit IRC | 08:00 | |
| *** ociuhandu has joined #openstack-nova | 08:02 | |
| *** jangutter has quit IRC | 08:03 | |
| *** dpawlik has joined #openstack-nova | 08:08 | |
| *** jangutter has joined #openstack-nova | 08:08 | |
| *** guozijn_ has joined #openstack-nova | 08:11 | |
| *** jangutter has quit IRC | 08:13 | |
| *** guozijn has quit IRC | 08:14 | |
| *** guozijn_ is now known as guozijn | 08:14 | |
| *** mdbooth has quit IRC | 08:18 | |
| *** markvoelker has quit IRC | 08:18 | |
| *** jangutter has joined #openstack-nova | 08:20 | |
| *** tkajinam has quit IRC | 08:21 | |
| *** ccamacho has joined #openstack-nova | 08:23 | |
| *** ykarel|lunch is now known as ykarel | 08:38 | |
| *** mdbooth has joined #openstack-nova | 08:44 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/572790 | 08:47 |
| lyarwood | stephenfin: ^ updated the releasenote, can't seem to build it locally but that appears to be an issue with f29 | 08:47 |
| *** luksky has quit IRC | 08:48 | |
| *** tetsuro has quit IRC | 08:49 | |
| *** sapd1_x has joined #openstack-nova | 08:50 | |
| *** panda is now known as panda|rover | 08:50 | |
| *** derekh has joined #openstack-nova | 08:51 | |
| *** priteau has joined #openstack-nova | 08:55 | |
| *** ttsiouts has quit IRC | 08:57 | |
| stephenfin | lyarwood: Ta. It reads rather oddly though. Can you take one more swing at it (comments left)? | 09:02 |
| *** davidsha has joined #openstack-nova | 09:02 | |
| lyarwood | stephenfin: yeah of course | 09:04 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/572790 | 09:07 |
| lyarwood | stephenfin: words-- ^ there you go. | 09:07 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Block swap volume on volumes with >1 rw attachment https://review.opendev.org/572790 | 09:09 |
| stephenfin | Thanks | 09:09 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Keep attach_mode as top-level field in _translate_attachment_ref https://review.opendev.org/574413 | 09:09 |
| lyarwood | haha fs, sorry | 09:10 |
| *** rcernin has quit IRC | 09:10 | |
| *** markvoelker has joined #openstack-nova | 09:15 | |
| *** _alastor_ has joined #openstack-nova | 09:18 | |
| *** luksky has joined #openstack-nova | 09:22 | |
| *** _alastor_ has quit IRC | 09:27 | |
| *** bhagyashris has joined #openstack-nova | 09:28 | |
| *** bhagyashris has quit IRC | 09:29 | |
| *** cdent has joined #openstack-nova | 09:39 | |
| *** ricolin has quit IRC | 09:40 | |
| *** lifeless_ is now known as lifeless | 09:46 | |
| *** markvoelker has quit IRC | 09:49 | |
| openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Update "add host and hypervisor_hostname flag to create server" spec https://review.opendev.org/660560 | 09:50 |
| stephenfin | bauzas: Wanna help remove nearly 13,000 lines of dead code? :) https://review.opendev.org/#/q/topic:bp/remove-cells-v1+status:open (ignore the ones in merge conflict, obviously) | 09:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop handling 'InstanceUnknownCell' exception https://review.opendev.org/651307 | 10:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unnecessary wrapper https://review.opendev.org/651308 | 10:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove cell APIs https://review.opendev.org/651309 | 10:01 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove cells v1 options, group https://review.opendev.org/651310 | 10:01 |
| *** ttsiouts has joined #openstack-nova | 10:05 | |
| openstackgerrit | Merged openstack/nova stable/stein: Add regression test for bug 1825034 https://review.opendev.org/657420 | 10:08 |
| openstack | bug 1825034 in OpenStack Compute (nova) stein "listing deleted servers from the API fails after running fill_virtual_interface_list online data migration" [High,In progress] https://launchpad.net/bugs/1825034 - Assigned to Matt Riedemann (mriedem) | 10:08 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311 | 10:09 |
| *** boxiang_ has quit IRC | 10:11 | |
| *** guozijn has quit IRC | 10:29 | |
| *** gibi_off is now known as gibi | 10:32 | |
| *** ttsiouts has quit IRC | 10:34 | |
| *** sridharg has joined #openstack-nova | 10:37 | |
| *** markvoelker has joined #openstack-nova | 10:46 | |
| *** luksky has quit IRC | 10:47 | |
| *** _alastor_ has joined #openstack-nova | 10:47 | |
| * gibi is back from pto | 10:52 | |
| *** _alastor_ has quit IRC | 10:55 | |
| *** _alastor_ has joined #openstack-nova | 10:56 | |
| *** toabctl has joined #openstack-nova | 10:58 | |
| *** nicolasbock has joined #openstack-nova | 11:06 | |
| *** _alastor_ has quit IRC | 11:09 | |
| *** _alastor_ has joined #openstack-nova | 11:10 | |
| *** ykarel is now known as ykarel|afk | 11:12 | |
| cdent | welcome back gibi | 11:13 |
| gibi | cdent: thanks | 11:13 |
| *** panda|rover is now known as panda|rover|eat | 11:16 | |
| *** guozijn has joined #openstack-nova | 11:17 | |
| *** luksky has joined #openstack-nova | 11:18 | |
| *** _alastor_ has quit IRC | 11:18 | |
| *** markvoelker has quit IRC | 11:18 | |
| *** udesale has quit IRC | 11:30 | |
| *** udesale has joined #openstack-nova | 11:31 | |
| *** ttsiouts has joined #openstack-nova | 11:41 | |
| *** _erlon_ has joined #openstack-nova | 11:45 | |
| *** maciejjozefczyk has quit IRC | 11:51 | |
| openstackgerrit | Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786 | 12:01 |
| *** panda|rover|eat is now known as panda|rover | 12:06 | |
| *** johnthetubaguy has joined #openstack-nova | 12:06 | |
| *** eharney has quit IRC | 12:10 | |
| *** ttsiouts has quit IRC | 12:11 | |
| *** itlinux has joined #openstack-nova | 12:12 | |
| *** itlinux has quit IRC | 12:12 | |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/nova master: [Docs] Fix minor typo https://review.opendev.org/660696 | 12:12 |
| *** markvoelker has joined #openstack-nova | 12:16 | |
| *** ykarel|afk is now known as ykarel | 12:18 | |
| *** bbowen has joined #openstack-nova | 12:22 | |
| sean-k-mooney | stephenfin: bauzas can ye add https://review.opendev.org/#/c/653506/ to your review queue | 12:25 |
| bauzas | mmm ok | 12:25 |
| *** psachin has quit IRC | 12:27 | |
| *** markvoelker has quit IRC | 12:29 | |
| sean-k-mooney | alex_xu: not sure if you usually review networking/libvirt livemigrtaion stuff but https://review.opendev.org/#/c/653506/ might be in your area too. | 12:31 |
| *** yonglihe has quit IRC | 12:32 | |
| * sean-k-mooney misses jaypipes | 12:32 | |
| *** janki has quit IRC | 12:35 | |
| *** abhi89 has joined #openstack-nova | 12:45 | |
| abhi89 | HI.. i am getting this error in my logs.. | 12:46 |
| abhi89 | The [cinder] section of your nova configuration file must be configured for authentication with the block-storage service endpoint.: InstanceNotFound: Instance 50C28C76-6E6B-4BF0-8291-FBD8C176B9B2 could not be found. | 12:46 |
| abhi89 | it is coming from | 12:46 |
| abhi89 | File "/usr/lib/python2.7/dist-packages/nova/volume/cinder.py", line 78, in _load_auth_plugin | 12:46 |
| abhi89 | 2019-05-06 08:58:32.792 123932 ERROR nova.compute.manager [instance: 50c28c76-6e6b-4bf0-8291-fbd8c176b9b2] raise cinder_exception.Unauthorized(401, message=err_msg) | 12:46 |
| openstackgerrit | Silvan Kaiser proposed openstack/nova stable/stein: Exec systemd-run without --user flag in Quobyte driver https://review.opendev.org/660705 | 12:47 |
| *** itlinux has joined #openstack-nova | 12:47 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova stable/stein: Added mount fstype based validation of Quobyte mounts https://review.opendev.org/660706 | 12:48 |
| abhi89 | this is very rare.. can anyone help me here to understand do we really need to add 'auth' in [cinder] section of nova.conf..? because without this also deploys work fine | 12:48 |
| efried | abhi89: What release are you on? | 12:54 |
| abhi89 | efried: stein | 12:54 |
| *** ricolin has joined #openstack-nova | 12:55 | |
| efried | abhi89: Do you have a message about "Unknown auth type"? | 12:55 |
| efried | (from line 77) | 12:56 |
| alex_xu | sean-k-mooney: not too much, but have involve lm for the lm with numa patche, anyway I will put that to my review list, give a try | 12:56 |
| abhi89 | efried: yes.. Unauthorized: Unknown auth type: None (HTTP 401) | 12:56 |
| sean-k-mooney | alex_xu: no worries | 12:56 |
| efried | abhi89: Do you have service_auth set up? | 12:57 |
| *** itlinux has quit IRC | 12:57 | |
| abhi89 | efried: service_auth? where? | 12:58 |
| efried | abhi89: https://docs.openstack.org/nova/stein/configuration/config.html#service-user | 13:00 |
| *** mlavalle has joined #openstack-nova | 13:00 | |
| efried | You're saying the symptom is rare, which leads me to suspect it's happening over long-running operations when your user token is expiring. That's what service auth was designed for. If you configure this, it wraps your user token in a service token so that when your user token expires, subsequent operations in that thread will still succeed (using the service token). | 13:01 |
| efried | The way it's manifesting is odd, though. That code path should only be happening under admin context. | 13:02 |
| *** tbachman has joined #openstack-nova | 13:03 | |
| abhi89 | efried: hmm.. let me try adding service_auth section to nova.conf.. thanks for the info.. | 13:05 |
| *** tbachman_ has joined #openstack-nova | 13:05 | |
| efried | abhi89: That's probably not it. | 13:05 |
| efried | it's probably I3c35bba43fee81baebe8261f546c1424ce3a3383 | 13:05 |
| *** brinzhang has quit IRC | 13:06 | |
| efried | abhi89: https://review.opendev.org/#/c/522112/ | 13:06 |
| efried | read the commit message and the bugs tagged there... | 13:06 |
| *** igordc has joined #openstack-nova | 13:06 | |
| efried | if you've got a situation similar to what's described, then you *do* need to set up admin auth for cinder to resolve it. | 13:06 |
| *** tbachman has quit IRC | 13:08 | |
| *** tbachman_ is now known as tbachman | 13:08 | |
| efried | stephenfin, cdent: What's the thing that has to be in place for Depends-On to work? Something tox something sibling? Specifically, is that currently set up to work from nova to os-traits? | 13:09 |
| cdent | it is not set up for os-traits unless add a required-project of openstack/os-traits | 13:09 |
| *** priteau has quit IRC | 13:09 | |
| cdent | (to the zuul job config) | 13:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Support old & new versions of svm and avx traits https://review.opendev.org/660515 | 13:10 |
| efried | o | 13:10 |
| abhi89 | efried: ok.. let me check on that.. | 13:10 |
| efried | cdent: for the base job? | 13:11 |
| sean-k-mooney | cadding os-traits to the required projects will add it to LIB_FROM_GIT and cause the zuul clone to prepar it in the workspace | 13:11 |
| sean-k-mooney | but that will result in the job running with master of os-tratis | 13:11 |
| sean-k-mooney | not the releaded version | 13:11 |
| sean-k-mooney | so we normally dont want that to be the case | 13:11 |
| efried | mm | 13:11 |
| cdent | sean-k-mooney: why not? | 13:11 |
| efried | because we would get false positives | 13:11 |
| cdent | meh | 13:12 |
| sean-k-mooney | cdent: because we wont be testing with the released version or the version listed in upperconstriats | 13:12 |
| *** mlavalle has quit IRC | 13:12 | |
| sean-k-mooney | so we wont be testing with what people actullly will be deploying | 13:12 |
| efried | right | 13:12 |
| efried | and that would be bad. | 13:12 |
| sean-k-mooney | we could do it in nova-next or a specific job | 13:12 |
| * cdent does not like/agree/something upperconstraints | 13:12 | |
| sean-k-mooney | we just dont wnat to do that in all jobs | 13:13 |
| cdent | or constraints in general | 13:13 |
| sean-k-mooney | cdent: do you use arch | 13:13 |
| cdent | hell, I'm going the whole way: I don't like | 13:13 |
| *** itlinux has joined #openstack-nova | 13:13 | |
| * cdent avoids this trap | 13:13 | |
| aarents | efried: Hi, about https://review.opendev.org/#/c/659054 I had to rebase, it is ok now, can you have a look on it please? | 13:14 |
| sean-k-mooney | hehe look im fine with deploying with os-traits from master as long as we have at least one job that is testing the released version | 13:14 |
| *** mriedem has joined #openstack-nova | 13:14 | |
| sean-k-mooney | maybe there is a feature request here to zuul for a way to add peoject dynamiclaly per patch | 13:15 |
| *** _alastor_ has joined #openstack-nova | 13:15 | |
| efried | sean-k-mooney: ^ this | 13:15 |
| sean-k-mooney | e.g. Depends-on: xyw Require: openstack/os-traits | 13:15 |
| efried | ooo | 13:15 |
| sean-k-mooney | that said we still would not want to merge the patch without the release so not sure how useful that is | 13:16 |
| efried | As it stands, I have to hand-edit .zuul.yaml. And for inherited jobs/templates, I would have to write whole derived jobs for them. | 13:16 |
| efried | sean-k-mooney: It's useful for me to validate that my patch is correct. | 13:16 |
| efried | Because as always I don't want to run all of the nova unit test and functional suites locally. | 13:16 |
| sean-k-mooney | efried: right but outside of that not sure. | 13:17 |
| sean-k-mooney | efried: i recently set up rtox to run my unit tests over ssh on my desktop. they now take ~ 2 mins to run | 13:17 |
| efried | Sure, outside of that it's not very helpful, and needs to be negated once the dep merges, so I can't accidentally merge that patch. | 13:17 |
| efried | aarents: looking... | 13:18 |
| sean-k-mooney | efried: it woudl be useful for test only patch on top of the actul change | 13:18 |
| sean-k-mooney | *test only -> DNM | 13:18 |
| *** ttsiouts has joined #openstack-nova | 13:19 | |
| cdent | efried: clone yourself and fix the core problem: tests are too slow | 13:19 |
| *** itlinux has quit IRC | 13:20 | |
| mriedem | this contributes to ^ https://bugs.launchpad.net/nova/+bug/1829896 | 13:20 |
| openstack | Launchpad bug 1829896 in OpenStack Compute (nova) "libvirt: "Instance failed to shutdown in 60 seconds." in the gate" [Undecided,New] | 13:20 |
| sean-k-mooney | cdent: not if you throw 48 cores at them | 13:20 |
| cdent | 48!? luxury | 13:21 |
| sean-k-mooney | cdent: the full nova py37 tox env takes 72 seconds to run on my desktop or about 2 minutes totoal when you account for the tox startup time and report generation | 13:21 |
| cdent | try the placement tests, I suspect you will go backwards in time | 13:22 |
| sean-k-mooney | cdent: i decomisined the tower server i baught do some ci | 13:22 |
| *** dave-mccowan has joined #openstack-nova | 13:23 | |
| *** _alastor_ has quit IRC | 13:24 | |
| sean-k-mooney | ====== | 13:24 |
| sean-k-mooney | Totals | 13:24 |
| sean-k-mooney | ====== | 13:24 |
| sean-k-mooney | Ran: 152 tests in 0.7772 sec. | 13:24 |
| sean-k-mooney | - Passed: 152 | 13:24 |
| sean-k-mooney | - Skipped: 0 | 13:24 |
| sean-k-mooney | - Expected Fail: 0 | 13:24 |
| sean-k-mooney | - Unexpected Success: 0 | 13:24 |
| sean-k-mooney | - Failed: 0 | 13:24 |
| sean-k-mooney | Sum of execute time for each test: 0.4916 sec. | 13:24 |
| sean-k-mooney | not quite | 13:24 |
| sean-k-mooney | and the time output | 13:25 |
| sean-k-mooney | real 0m5.681s | 13:25 |
| sean-k-mooney | user 1m33.494s | 13:25 |
| sean-k-mooney | sys 0m9.505s | 13:25 |
| sean-k-mooney | that said before i got that working yesterday i would agree way to slow | 13:26 |
| gibi | hehe this rtox python package implements what I have in bash for years. I independently named that bash script 'rtox' | 13:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Support old & new versions of svm and avx traits https://review.opendev.org/660515 | 13:29 |
| *** dtantsur is now known as dtantsur|brb | 13:29 | |
| efried | iiuc, ^ stands a chance of passing functional and tempest, but will still fail unit. | 13:29 |
| *** READ10 has joined #openstack-nova | 13:30 | |
| efried | which does kind of defeat the purpose, as it's unit tests I've changed. | 13:30 |
| sean-k-mooney | gibi: ya im proably goign to stop using it. the python version takes way to long to actully output to stdout | 13:30 |
| efried | The tests I changed succeed locally though. shrug. | 13:31 |
| sean-k-mooney | efried: wait why are we reported avx and svm in a vendor speficic way | 13:31 |
| sean-k-mooney | oh we are not at least for AVX | 13:32 |
| efried | because they're vendor-specific flags | 13:32 |
| sean-k-mooney | efried: you ment VMX not AVX | 13:33 |
| efried | point is, we weren't, but we should have been, so now we are. | 13:33 |
| efried | oh, did I misspell something? :P | 13:33 |
| sean-k-mooney | :) | 13:33 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Support old & new versions of svm and vmx traits https://review.opendev.org/660515 | 13:34 |
| efried | thanks sean-k-mooney, nice catch | 13:34 |
| sean-k-mooney | are the only spelling mistakes i can spot instruction sets? | 13:34 |
| efried | I'll take it. | 13:34 |
| efried | we have plenty of other anal-retentive people to catch the rest. | 13:34 |
| efried | community development ftw | 13:35 |
| sean-k-mooney | that was more a self commentry on how deep the intel brainwashing must have penetrated :P | 13:35 |
| *** tbachman has quit IRC | 13:35 | |
| sean-k-mooney | it bypassed my in ability to spell and inserted an instruction set filter into my brain lol | 13:36 |
| *** eharney has joined #openstack-nova | 13:36 | |
| efried | aarents: I feel like I must be forgetting some background on https://review.opendev.org/#/c/659054/ | 13:39 |
| efried | pieces of this look vaguely familiar. Have we talked about this before? | 13:39 |
| efried | I can see I've not been on the review itself... | 13:39 |
| *** dave-mccowan has quit IRC | 13:40 | |
| stephenfin | efried: I assume you got sorted? I'm knee deep in crappy unit tests atm :) | 13:40 |
| efried | stephenfin: Yes thanks. | 13:40 |
| efried | got an answer anyway, if not sorted how I would like. | 13:41 |
| *** ratailor has quit IRC | 13:41 | |
| *** awalende has quit IRC | 13:43 | |
| *** awalende has joined #openstack-nova | 13:43 | |
| *** liuyulong has quit IRC | 13:46 | |
| *** liuyulong has joined #openstack-nova | 13:46 | |
| *** abhi89 has quit IRC | 13:47 | |
| *** awalende has quit IRC | 13:48 | |
| *** boxiang has joined #openstack-nova | 13:49 | |
| *** hemna has joined #openstack-nova | 13:51 | |
| *** igordc has quit IRC | 13:51 | |
| *** hemna has quit IRC | 13:52 | |
| *** ttsiouts has quit IRC | 13:53 | |
| *** boxiang has quit IRC | 13:53 | |
| dansmith | mriedem: do we still have a job that does a full archive after tempest? | 13:54 |
| dansmith | I see mention in nova-next, but not sure where it's called | 13:56 |
| sean-k-mooney | as in one that runs https://github.com/openstack/nova/blob/master/gate/post_test_hook.sh | 13:56 |
| dansmith | ah yep | 13:57 |
| dansmith | thanks | 13:57 |
| sean-k-mooney | it looks like 3 https://github.com/openstack/nova/search?q=post_test_hook.sh&unscoped_q=post_test_hook.sh | 13:57 |
| mriedem | nova-next is the one you're looking for | 13:58 |
| sean-k-mooney | its done the live migration job too and the grenade version | 13:59 |
| mriedem | not the same scripts dan is looking for | 13:59 |
| sean-k-mooney | oh right they run a different post test hook | 14:00 |
| dansmith | mriedem: okay the --before patch is too stale to have test output, but wanted to see what that run looks like | 14:00 |
| sean-k-mooney | so ya nova-nextg | 14:00 |
| *** tbachman has joined #openstack-nova | 14:06 | |
| *** lpetrut has quit IRC | 14:12 | |
| *** _alastor_ has joined #openstack-nova | 14:18 | |
| openstackgerrit | Surya Seetharaman proposed openstack/python-novaclient master: Allow passing negative values for the locked search_opt in cs.servers.list https://review.opendev.org/659783 | 14:18 |
| *** Luzi has quit IRC | 14:19 | |
| aarents | efried: I think you where about to read this 2 days ago, but you saw that it was no more mergeable. never mind I need a core having a look on this since Matthew has "+1" do you know who can help me on this ? ( https://review.opendev.org/#/c/659054/ ) | 14:25 |
| efried | aarents: I'm reviewing it. I have some issues with the test. Working on formulating a solution... | 14:27 |
| aarents | ok | 14:28 |
| aarents | thanks | 14:28 |
| *** itlinux has joined #openstack-nova | 14:29 | |
| *** dpawlik has quit IRC | 14:29 | |
| *** dtantsur|brb is now known as dtantsur | 14:29 | |
| *** itlinux has quit IRC | 14:30 | |
| *** sridharg has quit IRC | 14:31 | |
| *** ykarel is now known as ykarel|afk | 14:31 | |
| *** itlinux has joined #openstack-nova | 14:31 | |
| *** boxiang has joined #openstack-nova | 14:32 | |
| *** cmart has joined #openstack-nova | 14:35 | |
| *** IvensZambrano has joined #openstack-nova | 14:38 | |
| *** cmart has quit IRC | 14:40 | |
| *** lorenjan has joined #openstack-nova | 14:41 | |
| *** _alastor_ has quit IRC | 14:41 | |
| mriedem | https://www.youtube.com/watch?v=SGZqDzb__bw | 14:43 |
| *** luksky has quit IRC | 14:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.opendev.org/614037 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source https://review.opendev.org/637058 | 14:43 |
| edleafe | mriedem: oh, are you out of /dev/jail? | 14:44 |
| *** udesale has quit IRC | 14:44 | |
| mriedem | let's say yes | 14:44 |
| *** itlinux has quit IRC | 14:44 | |
| * edleafe posts bail for mriedem | 14:44 | |
| *** udesale has joined #openstack-nova | 14:44 | |
| * mriedem puts on disguise | 14:44 | |
| *** mriedem is now known as hansmoleman | 14:44 | |
| prometheanfire | failures for the new fasteners fasteners===0.15 http://logs.openstack.org/54/660254/2/check/cross-nova-functional/a0617a9/testr_results.html.gz | 14:45 |
| openstackgerrit | Merged openstack/nova stable/stein: Exclude fake marker instance when listing servers https://review.opendev.org/657421 | 14:45 |
| hansmoleman | wth is fasteners and what's using it? | 14:47 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova-specs master: Update "add host and hypervisor_hostname flag to create server" spec https://review.opendev.org/660560 | 14:47 |
| *** boxiang has quit IRC | 14:49 | |
| hansmoleman | bah oslo.concurrency http://codesearch.openstack.org/?q=import%20fasteners&i=nope&files=&repos= | 14:49 |
| hansmoleman | prometheanfire: open a bug please | 14:50 |
| *** hemna has joined #openstack-nova | 14:50 | |
| hansmoleman | tssurya: i can address the small issues in https://review.opendev.org/#/c/659783/ if you're busy and then +2 it | 14:52 |
| prometheanfire | hansmoleman: ok, so far only nova has had issue with it | 14:53 |
| *** ttsiouts has joined #openstack-nova | 14:54 | |
| *** itlinux has joined #openstack-nova | 14:54 | |
| *** itlinux has quit IRC | 14:56 | |
| *** lpetrut has joined #openstack-nova | 14:57 | |
| *** hansmoleman is now known as mriedem | 15:00 | |
| *** cfriesen has joined #openstack-nova | 15:01 | |
| *** ykarel|afk is now known as ykarel | 15:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Allow passing negative values for the locked search_opt in cs.servers.list https://review.opendev.org/659783 | 15:07 |
| *** itlinux has joined #openstack-nova | 15:11 | |
| *** mlavalle has joined #openstack-nova | 15:12 | |
| tssurya | hansmoleman: thanks! yea I am snowflake | 15:15 |
| *** guozijn has quit IRC | 15:19 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311 | 15:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | 15:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | 15:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | 15:23 |
| efried | stephenfin: I was considering reworking https://review.opendev.org/#/c/660527/ (get rid of nova.compute.*API()) to just change most of the imports from | 15:24 |
| efried | from nova import compute | 15:24 |
| efried | to | 15:24 |
| efried | from nova.compute import api as compute | 15:24 |
| efried | so that the code itself wouldn't change at all. | 15:24 |
| efried | Again "most of" - some other minor tweaks will be necessary, like where there was already an import of nova.compute.api as compute_api | 15:25 |
| efried | anyway, what do you think of that idea? | 15:25 |
| stephenfin | I must admit I kind of like it how it is atm, with the few exceptions noted | 15:25 |
| efried | The code lines would stay kind of intuitive: compute.API() is nice and clean, clearer than api.API() and less redundant than compute_api.API() | 15:26 |
| efried | okay. | 15:26 |
| stephenfin | Yeah, fair point | 15:26 |
| efried | It's less work to leave it like it is, so I'm not going to fight for this :) | 15:26 |
| stephenfin | I'd be happy with either in that case, actually | 15:26 |
| stephenfin | That's a good point | 15:26 |
| efried | alas, I sense I have sold you on this idea | 15:27 |
| efried | okay, I'll go make it so. | 15:27 |
| *** ttsiouts has quit IRC | 15:27 | |
| stephenfin | Think I've fixed up the issues with the one non-WIP patch that was failing [1] too, so they should all be good to go now [1] https://review.opendev.org/#/c/651311/ | 15:27 |
| stephenfin | It took me too long but it should make mriedem happy (it resolves one of his todo's in the process) | 15:28 |
| *** eharney has quit IRC | 15:28 | |
| *** itlinux has quit IRC | 15:28 | |
| *** itlinux has joined #openstack-nova | 15:30 | |
| mriedem | stephenfin: hmm, you're talking about https://review.opendev.org/#/c/651311/3/nova/compute/manager.py right? would it be possible for us to do that refactor outside of the cells v1 removal series? | 15:31 |
| mriedem | or just separately in the series? | 15:31 |
| *** gyee has joined #openstack-nova | 15:32 | |
| *** macza has joined #openstack-nova | 15:32 | |
| stephenfin | I was afraid you'd say that | 15:33 |
| * stephenfin pulls it back down | 15:33 | |
| openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec https://review.opendev.org/602201 | 15:33 |
| stephenfin | bauzas: https://redhat.bluejeans.com/2519408175/ | 15:34 |
| bauzas | wrong chan, dude | 15:34 |
| *** helenafm has quit IRC | 15:35 | |
| openstackgerrit | Arnaud Morin proposed openstack/nova master: Force refresh instance network info on deletion https://review.opendev.org/660761 | 15:38 |
| *** lpetrut has quit IRC | 15:38 | |
| *** david-lyle has joined #openstack-nova | 15:39 | |
| *** dklyle has quit IRC | 15:40 | |
| *** david-lyle is now known as dklyle | 15:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: dump console log if _clean_shutdown fails https://review.opendev.org/660766 | 15:42 |
| *** itlinux has quit IRC | 15:47 | |
| *** francoisp has quit IRC | 15:53 | |
| *** dklyle has quit IRC | 15:55 | |
| *** david-lyle has joined #openstack-nova | 15:55 | |
| *** itlinux has joined #openstack-nova | 15:55 | |
| *** itlinux has quit IRC | 15:59 | |
| *** derekh has quit IRC | 15:59 | |
| *** itlinux has joined #openstack-nova | 16:00 | |
| *** IvensZambrano has quit IRC | 16:01 | |
| *** ykarel is now known as ykarel|away | 16:01 | |
| *** jangutter has quit IRC | 16:05 | |
| *** wwriverrat has joined #openstack-nova | 16:06 | |
| *** tesseract has quit IRC | 16:10 | |
| *** igordc has joined #openstack-nova | 16:12 | |
| *** tesseract has joined #openstack-nova | 16:14 | |
| *** tesseract has quit IRC | 16:14 | |
| *** ykarel|away has quit IRC | 16:15 | |
| *** dklyle has joined #openstack-nova | 16:15 | |
| *** david-lyle has quit IRC | 16:15 | |
| *** rpittau is now known as rpittau|afk | 16:18 | |
| *** itlinux has quit IRC | 16:20 | |
| *** itlinux has joined #openstack-nova | 16:21 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove cells v1 parameter from 'ComputeTaskAPI.resize_instance' https://review.opendev.org/651311 | 16:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'kwargs' to 'rebuild_instance' https://review.opendev.org/651312 | 16:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop passing 'delete_type' to 'terminate_instance' https://review.opendev.org/651313 | 16:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: filters: Stop handling cells v1 https://review.opendev.org/651314 | 16:22 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'ComputeManager._reschedule' https://review.opendev.org/660774 | 16:22 |
| *** david-lyle has joined #openstack-nova | 16:24 | |
| *** sapd1_x has quit IRC | 16:25 | |
| *** dklyle has quit IRC | 16:25 | |
| mriedem | kaisers: would it be possible to remove the feature parts of this backport? https://review.opendev.org/#/c/660706/ | 16:28 |
| *** cdent has quit IRC | 16:30 | |
| mriedem | kaisers: https://review.opendev.org/#/c/660705/ also mixes in stuff that should have just been master-only IMO, i.e. the privsep conversion | 16:31 |
| *** ttsiouts has joined #openstack-nova | 16:38 | |
| *** udesale has quit IRC | 16:38 | |
| *** david-lyle has quit IRC | 16:40 | |
| *** itlinux has quit IRC | 16:42 | |
| *** udesale has joined #openstack-nova | 16:43 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Run revert resize tests in nova-live-migration https://review.opendev.org/653498 | 16:47 |
| openstackgerrit | sean mooney proposed openstack/nova master: [DNM] use iptables in nova-multinode https://review.opendev.org/660782 | 16:47 |
| *** prometheanfire has left #openstack-nova | 16:47 | |
| *** dklyle has joined #openstack-nova | 16:48 | |
| sean-k-mooney | ^ is just a repoducer so you can ignore it | 16:48 |
| *** itlinux has joined #openstack-nova | 16:48 | |
| *** davidsha has quit IRC | 16:50 | |
| stephenfin | mriedem: Split out that patch too, fwiw https://review.opendev.org/#/c/660774/ | 16:51 |
| * stephenfin -> 🏡 | 16:51 | |
| mriedem | thanks | 16:51 |
| *** Swami has joined #openstack-nova | 16:53 | |
| *** tssurya has quit IRC | 16:58 | |
| mriedem | bauzas: dansmith: melwitt: can one of you hit this stein backport? https://review.opendev.org/#/c/660370/ | 16:59 |
| dansmith | jes | 16:59 |
| dansmith | I'm probably due to go through backports | 16:59 |
| *** francoisp has joined #openstack-nova | 17:00 | |
| melwitt | same | 17:01 |
| dansmith | let me also say.. I really hate the use of partial in here, which seems to be a growing cancer lately | 17:03 |
| *** ttsiouts has quit IRC | 17:08 | |
| *** udesale has quit IRC | 17:12 | |
| melwitt | looks like it's mirroring what we were already doing with post_live_migration | 17:12 |
| *** ricolin has quit IRC | 17:13 | |
| *** itlinux has quit IRC | 17:13 | |
| dansmith | the partials you mean? that's what I'm talking about yeah | 17:14 |
| melwitt | yeah, the partial thing | 17:14 |
| dansmith | oopsie, I approved that xen ssl thing for rocky before stein | 17:19 |
| dansmith | mriedem: this seems like a bug of omission to me that affects support-ability and thus pretty reasonable for stable: https://review.opendev.org/#/c/657125/1 | 17:22 |
| dansmith | mriedem: do you really disagree? | 17:22 |
| *** luksky has joined #openstack-nova | 17:23 | |
| *** eharney has joined #openstack-nova | 17:33 | |
| *** Swami has quit IRC | 17:35 | |
| *** itlinux has joined #openstack-nova | 17:48 | |
| *** ttsiouts has joined #openstack-nova | 17:48 | |
| *** samueldmq has joined #openstack-nova | 17:50 | |
| mriedem | i haven't dug into it much yet, it's big, | 18:03 |
| mriedem | it's also an admin api so i'm less concerned about that | 18:03 |
| mriedem | dansmith: ok +2 on that one now | 18:22 |
| *** frank_wang has quit IRC | 18:24 | |
| *** frank_wang has joined #openstack-nova | 18:25 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Disable limit if affinity(anti)/same(different)host is requested https://review.opendev.org/659239 | 18:32 |
| mriedem | ^ should also be ready to go | 18:34 |
| *** READ10 has quit IRC | 18:34 | |
| mriedem | once https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/stein+label:Code-Review=2 is merged i think we should do a stein release | 18:35 |
| *** dpawlik has joined #openstack-nova | 18:36 | |
| *** ttsiouts has quit IRC | 18:37 | |
| *** itlinux has quit IRC | 18:39 | |
| *** itlinux has joined #openstack-nova | 18:40 | |
| *** itlinux has quit IRC | 18:40 | |
| *** itlinux has joined #openstack-nova | 18:44 | |
| *** slaweq has quit IRC | 18:44 | |
| *** ttsiouts has joined #openstack-nova | 18:45 | |
| dansmith | mriedem: thanks | 18:49 |
| *** itlinux has quit IRC | 18:51 | |
| *** cmart has joined #openstack-nova | 19:08 | |
| *** cmart has quit IRC | 19:23 | |
| *** slaweq has joined #openstack-nova | 19:27 | |
| *** cmart has joined #openstack-nova | 19:28 | |
| *** cmart has quit IRC | 19:33 | |
| *** READ10 has joined #openstack-nova | 19:36 | |
| *** mmethot_ has quit IRC | 19:44 | |
| *** mmethot has joined #openstack-nova | 19:46 | |
| sean-k-mooney | dansmith: for what its worth that bug only happens in a specifci edge casse. | 19:54 |
| sean-k-mooney | dansmith: basically it only happens if the kernel/nic diriver is configred such that it does not bind the VF to the network driver after its detached from the gues or when you pre bind the vfs to vvfio | 19:55 |
| sean-k-mooney | so in some case it would work by acident because libvirt would auto add the missing element and in other cases it would fail which was a crapy operator experience | 19:56 |
| *** tbachman has quit IRC | 19:58 | |
| *** tbachman has joined #openstack-nova | 20:00 | |
| *** ralonsoh has quit IRC | 20:07 | |
| *** liuyulong has quit IRC | 20:11 | |
| *** itlinux has joined #openstack-nova | 20:11 | |
| mriedem | ganso: melwitt: replied in https://review.opendev.org/#/c/659338/ | 20:12 |
| melwitt | thanks | 20:14 |
| *** ttsiouts has quit IRC | 20:19 | |
| *** pcaruana has quit IRC | 20:20 | |
| *** itlinux has quit IRC | 20:21 | |
| openstackgerrit | Merged openstack/nova stable/stein: Reproduce bug #1819460 in functional test https://review.opendev.org/657600 | 20:27 |
| openstack | bug 1819460 in OpenStack Compute (nova) stein "instance stuck in BUILD state due to unhandled exceptions in conductor" [Medium,In progress] https://launchpad.net/bugs/1819460 - Assigned to Balazs Gibizer (balazs-gibizer) | 20:27 |
| openstackgerrit | Merged openstack/nova stable/stein: Fix exception type in test_boot_reschedule_fill_provider_mapping_raises https://review.opendev.org/657601 | 20:30 |
| *** READ10 has quit IRC | 20:30 | |
| mriedem | melwitt: thanks but https://review.opendev.org/#/c/659338/ isn't a backport so you might want to drop the +W | 20:31 |
| *** whoami-rajat has quit IRC | 20:34 | |
| *** ttsiouts has joined #openstack-nova | 20:35 | |
| melwitt | mriedem: oh :( ok | 20:35 |
| melwitt | mriedem: I think I need to change the commit message or something to stop it from going to the gate. I can add [stable-only] to it | 20:38 |
| *** ttsiouts has quit IRC | 20:39 | |
| *** tuxjohnson has joined #openstack-nova | 20:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: [stable-only] Delete allocations even if _confirm_resize raises (part 2) https://review.opendev.org/659338 | 20:46 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional confirm_migration_error test https://review.opendev.org/658834 | 20:46 |
| mriedem | done | 20:46 |
| melwitt | thank you | 20:47 |
| ganso | mriedem: thank you =D | 20:51 |
| *** dpawlik has quit IRC | 20:51 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update description of valid whitelist for non-admin user https://review.opendev.org/642403 | 20:56 |
| sean-k-mooney | having ssh exposed on a static ip is always fun | 21:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Skip existing VMs when hosts apply force_config_drive https://review.opendev.org/659703 | 21:02 |
| sean-k-mooney | i have 4 ip currently trying to brute force my root password. which will be hard since i dont allow password loggin as root | 21:02 |
| mriedem | efried: on the virtual persistent memory spec https://review.opendev.org/#/c/601596/ and cyborg integration spec https://review.opendev.org/#/c/603955/ i'm waiting to see those settle down from the people that have been most involved, but is there light at the end of the tunnel at some point? | 21:04 |
| efried | mriedem: I hope so. What do you mean? | 21:04 |
| mriedem | every time i look at these there are multiple -1s | 21:04 |
| mriedem | for like, months | 21:04 |
| mriedem | i guess i'm saying feel free to ping me to review those when they settle down | 21:05 |
| efried | mriedem: ah, cool, thanks. | 21:05 |
| mriedem | but until them i'm not wanting to jump into reviewing them | 21:05 |
| mriedem | *then | 21:05 |
| efried | yeah, understood. | 21:05 |
| efried | for my part, I'm waiting until you're done tearing the host/hypervisor_hostname spec apart before I re-engage :) | 21:06 |
| *** ttsiouts has joined #openstack-nova | 21:07 | |
| *** IvensZambrano has joined #openstack-nova | 21:08 | |
| sean-k-mooney | mriedem: efried i dont think there is much curn on the cyborg one at this point but sundar also has not updated it in two weeks so that is why most of the -1s are still there | 21:09 |
| efried | Right, I think that one is pretty close, updates still trickling down from PTG discussions. | 21:10 |
| mriedem | efried: this? https://review.opendev.org/#/c/660560/ | 21:10 |
| efried | mriedem: no, https://review.opendev.org/#/c/660560/3 | 21:11 |
| mriedem | i'm just adding it to the nova meeting agenda for a stuck review, i see boxiang is getting some back and forth | 21:11 |
| mriedem | that's the same change :) | 21:11 |
| mriedem | seems the debate is if we should validate the requested host/node in the api and fail fast or fail late in the scheduler with novalidhost | 21:11 |
| efried | thought the whole point of the exercise was to fail early. | 21:11 |
| mriedem | i think unless it's egregious we generally want to validate and fail fast in the api if possible | 21:11 |
| *** ttsiouts has quit IRC | 21:11 | |
| mriedem | the whole point of the spec is to request a host and/or node and have the scheduler filters validate it | 21:12 |
| mriedem | rather than force it through | 21:12 |
| mriedem | which is what we have today (unless you're using the little known query hint) | 21:12 |
| mriedem | anyway, i've said on the code change to take it to the ML or meeting agenda to sort it out with more than 2 people invovled | 21:13 |
| mriedem | if we could throw a generic RequestGroup with the in_tree attribute set in the request spec from the api then the redundancy in the scheduler would be avoided | 21:14 |
| mriedem | but that gets complicated | 21:14 |
| sean-k-mooney | i have not read that one but if we are specifying the host or hypervior host name i assume we would be passing intree to placement and failing in teh scudler if we get no allocation candiates or the filters eliminate the host? | 21:14 |
| efried | Right, I thought we wanted the scheduler filter validation so we would know earlier whether the guest was viable for the host. Rather than "forcing" it to a host it couldn't work on so it would fail late (or worse, pretend to succeed but really be borked) | 21:14 |
| mriedem | efried: that is true | 21:15 |
| mriedem | the debate is if that is good enough or if we should also validate that the requested host/node exist in the API so we can return a 400 if they don't | 21:15 |
| efried | dahhh | 21:15 |
| mriedem | b/c if you don't validate in the api, and they don't exist, you'll get a 202 and then NoValidHost later | 21:15 |
| mriedem | which everyone loves | 21:15 |
| sean-k-mooney | efried: well the current way to force the host is via the AZ e.g. --availability-zone nova:my_host | 21:16 |
| efried | oh, "in the API" meaning before we get to the scheduler | 21:16 |
| efried | f, I don't see why not. How expensive is that check? | 21:16 |
| sean-k-mooney | is it just checkign the api db to see if there is a host mapping for the requested host? | 21:17 |
| sean-k-mooney | if so then cheap | 21:17 |
| *** _alastor_ has joined #openstack-nova | 21:18 | |
| sean-k-mooney | honestly i dont think there is any issue with it failing when it gets to the schduler either | 21:19 |
| mriedem | no it's not doing that, | 21:19 |
| mriedem | just commented on that in the api validatoin code, it won't work as written | 21:19 |
| sean-k-mooney | https://review.opendev.org/#/c/645520/20 is the code change ? | 21:20 |
| mriedem | surya already pointed out the same thing i just did | 21:20 |
| mriedem | sean-k-mooney: yes | 21:20 |
| mriedem | if you request a host, we can look up the host mapping | 21:20 |
| mriedem | if you request only a node, then we have to iterate the cells looking for it | 21:20 |
| mriedem | or let the scheduler do that | 21:20 |
| mriedem | since it already is | 21:21 |
| sean-k-mooney | i would let the schduler do it personally | 21:21 |
| sean-k-mooney | is there a reason not to use in_tree in the placement request as well? | 21:21 |
| mriedem | the scheduler code will use in_tree already | 21:22 |
| mriedem | but it will do the same compute node lookup to find the node uuid | 21:23 |
| mriedem | the RequestSpec.requested_destination currently only has the host and nodename, not the uuid | 21:23 |
| sean-k-mooney | well it could look it up via placmenet i nthe hypervior_host name case | 21:23 |
| sean-k-mooney | the compute node RP name is the hypervior host name i think | 21:24 |
| sean-k-mooney | and in the host case its in the instance mappings in the api db | 21:24 |
| sean-k-mooney | sorry host mappings | 21:24 |
| mriedem | s/instance/host/ | 21:24 |
| sean-k-mooney | so we should not need to iterate over teh cell dbs | 21:24 |
| mriedem | i'm not sure how much i want to rely on the rp name matching the hypervisor_hostname forever | 21:26 |
| mriedem | or always being correct | 21:26 |
| mriedem | especially since you can change the name https://developer.openstack.org/api-ref/placement/?expanded=update-resource-provider-detail#update-resource-provider | 21:26 |
| sean-k-mooney | im just checking that it is infact set to that. but i think we need to for other services to be able to identigy the host | 21:26 |
| sean-k-mooney | e.g. we need a way for neutron to be abel to create nested RPs under the compute node RP | 21:27 |
| mriedem | yes we set the rp name to the compute node hypervisor_hostname in the RT | 21:27 |
| mriedem | https://github.com/openstack/nova/blob/2e85453879533af0b4d0e1178797d26f026a9423/nova/compute/resource_tracker.py#L954 | 21:27 |
| sean-k-mooney | i think its effectivly part of the contract nova has with cyborg and neutron at this point | 21:28 |
| mriedem | heh, well, it's mutable in the placement api | 21:28 |
| *** tuxjohnson has left #openstack-nova | 21:28 | |
| sean-k-mooney | its technically mutable in our config file too | 21:28 |
| mriedem | https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-provider-set | 21:28 |
| sean-k-mooney | well not that but the host paramater | 21:29 |
| mriedem | how so? if you're talking about CONF.host, that's something else | 21:29 |
| sean-k-mooney | ya i was | 21:29 |
| mriedem | hypervisor_hostname comes from the driver | 21:29 |
| mriedem | not the config | 21:29 |
| mriedem | https://github.com/openstack/nova/blob/2e85453879533af0b4d0e1178797d26f026a9423/nova/virt/driver.py#L1622 | 21:29 |
| sean-k-mooney | yep you are right | 21:30 |
| * mriedem screen captures that | 21:30 | |
| mriedem | anyway, i threw it in the stuck review section for the meeting https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 21:32 |
| mriedem | enumerating options in the ML ahead of the meeting would probably be useful | 21:32 |
| *** IvensZambrano has quit IRC | 21:35 | |
| *** slaweq has quit IRC | 21:35 | |
| *** ttsiouts has joined #openstack-nova | 21:45 | |
| *** mriedem has quit IRC | 21:48 | |
| *** mriedem has joined #openstack-nova | 21:52 | |
| aspiers | efried: around? | 22:02 |
| *** ttsiouts has quit IRC | 22:02 | |
| aspiers | just had another idea for how to provide patch_exists() | 22:02 |
| efried | aspiers: yeaux | 22:02 |
| *** ttsiouts has joined #openstack-nova | 22:02 | |
| aspiers | class patch_exists(contextlib.ContextDecorator) | 22:03 |
| aspiers | then it can be used both as a @patch_exists decorator, and via: with patch_exists(...) | 22:03 |
| aspiers | I think there's also a case to be made for providing patch_open in a similar way | 22:04 |
| aspiers | currently there's tons of stuff which does: | 22:05 |
| aspiers | mock_open = mock.mock_open() | 22:05 |
| aspiers | with mock.patch.object(six.moves.builtins, 'open', new=mock_open): | 22:05 |
| aspiers | ... do stuff | 22:05 |
| aspiers | that could be replaced with | 22:05 |
| aspiers | with patch_open(): | 22:06 |
| aspiers | ... do stuff | 22:06 |
| aspiers | and it could support selective patching | 22:06 |
| efried | and custom side effects | 22:06 |
| aspiers | right | 22:06 |
| aspiers | with patch_open() as mock_open: | 22:06 |
| aspiers | mock_open.side_effect = ... | 22:06 |
| efried | whereupon you might as well just say | 22:07 |
| efried | with mock.patch.object(six.moves.builtins, 'open', new=mock.mock_open()) as mock_open: | 22:07 |
| efried | but sure, patch_open would be a neat little helper. | 22:07 |
| aspiers | hrm | 22:08 |
| aspiers | in two minds about this | 22:08 |
| aspiers | there's a danger of trying to reinvent a bunch of the mock API | 22:08 |
| aspiers | with patch_open(side_effect=...) as mock_open: | 22:08 |
| aspiers | etc. | 22:08 |
| aspiers | the bit I'm really missing easy selective patching | 22:09 |
| aspiers | as in "patch opening path X, but pass anything else through to builtins.open" | 22:09 |
| *** slaweq has joined #openstack-nova | 22:11 | |
| aspiers | efried: I can't find any existing implementing of selective patching of open(), although I thought you said you had done that in the past. Maybe outside nova? | 22:11 |
| *** mlavalle has quit IRC | 22:13 | |
| sean-k-mooney | i think we have an example of this in os-vif | 22:14 |
| sean-k-mooney | by selectivly patching you mean mock right | 22:14 |
| sean-k-mooney | you do it like this https://github.com/openstack/os-vif/blob/6f08a3b4f8be77b2b5eae653c05db6e5770b562d/vif_plug_ovs/tests/unit/test_linux_net.py#L65 | 22:14 |
| sean-k-mooney | @mock.patch('six.moves.builtins.open') | 22:14 |
| sean-k-mooney | or this @mock.patch.object(builtins, 'open') | 22:15 |
| *** slaweq has quit IRC | 22:15 | |
| sean-k-mooney | aspiers: oh you were sugging addign a wrapper to make it simpler | 22:17 |
| sean-k-mooney | ya that soudn like a good idea becuse tis a bit of a pain to get right | 22:18 |
| *** itlinux has joined #openstack-nova | 22:21 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove nova.compute.*API() shims https://review.opendev.org/660527 | 22:24 |
| aspiers | sean-k-mooney: yeah exactly | 22:26 |
| efried | aspiers: Sorry, hold on, lemme find | 22:26 |
| efried | aspiers: I just reviewed one this morning in fact. | 22:26 |
| aspiers | sean-k-mooney: except the approach you linked there doesn't work if the code path under test makes additional calls to open or exists | 22:26 |
| aspiers | sean-k-mooney: sometimes that can happen (Especially in functional tests) and then you don't want to hardcode assumptions that those calls happen in a particular order | 22:27 |
| aspiers | you just want to patch when it is called with a certain param, otherwise pass through transparently | 22:27 |
| sean-k-mooney | aspiers: you can pass an iterable of callable as the return value and have it return differnet things but yes that is really just for mocking things in unit tests | 22:28 |
| efried | aspiers: nova/tests/unit/test_versions.py:45 | 22:29 |
| sean-k-mooney | aspiers: in unit test you actully do generally want to encode the order. or rather we generall do in openstack | 22:30 |
| sean-k-mooney | efried: that is not really generic either | 22:31 |
| aspiers | efried: thanks | 22:32 |
| efried | sean-k-mooney: that's the point. aspiers is wanting to write a thing to do that pattern, so it could be used in places like that in a more readable and generic way. | 22:32 |
| aspiers | right | 22:32 |
| sean-k-mooney | well in the unit test we never want it to call real_open | 22:32 |
| sean-k-mooney | and in the functional test im not sure that is vaild either | 22:33 |
| aspiers | in the functional test I'm writing, placement needs to read placement-policy.yaml from the testenv | 22:33 |
| aspiers | there's no way I'm hardcoding that path into my test | 22:33 |
| aspiers | nor any assumption about *when* it needs to read that file | 22:34 |
| efried | mriedem: Do you have a take on whether nova should talk to cyborg with an admin auth or with the user's auth? | 22:34 |
| sean-k-mooney | why does it need to read a file instead of embeding it in a sting | 22:34 |
| aspiers | because it's not mocking or stubbing placement | 22:34 |
| efried | sean-k-mooney: It was just an example. Point is that there are valid and viable reasons unit tests should invoke real open(). | 22:34 |
| aspiers | it's not even testing placement | 22:34 |
| aspiers | exactly | 22:35 |
| efried | so we want to be able to mock it conditionally. | 22:35 |
| efried | I was just dorking with one this morning where libvirt tests set up a TempDir fixture to read and write fake images | 22:35 |
| aspiers | this makes sense when checking files outside the testenv | 22:35 |
| efried | sucker used open()s and other os.path stuff all over the place. | 22:35 |
| sean-k-mooney | well the only valid case would be if they created the file they are opening in which case they would not mock it | 22:35 |
| aspiers | like /etc/nova/release, or /sys/module/kvm_amd/parameters/sev | 22:35 |
| sean-k-mooney | aspiers: well that is the thing we shoudl not be checking files outside the test env | 22:36 |
| sean-k-mooney | the unit test and function test shoudl work on a host without install nova | 22:36 |
| aspiers | sean-k-mooney: ... and that's exactly why I need to selectively patch | 22:36 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove PlacementAPIConnectFailure handling from AggregateAPI https://review.opendev.org/660852 | 22:36 |
| sean-k-mooney | e.g. you shoudl be able to git clone and then run it | 22:36 |
| sean-k-mooney | *run tox -e py36 | 22:36 |
| mriedem | efried: dansmith: ^ for tomorrow, could use some thoughts on how to handle failures in the latter case noted in there | 22:36 |
| aspiers | sean-k-mooney: yes, that is what I am aiming for | 22:36 |
| mriedem | efried: re admin auth it depends on what we're doing i guess and what the cyborg api policy is | 22:37 |
| aspiers | sean-k-mooney: I need to mock the presence and contents of /sys/module/kvm_amd/parameters/sev | 22:37 |
| sean-k-mooney | right so im not seeing why you would ever fall back to real_open | 22:37 |
| aspiers | because of other things like placement-policy.yaml which live inside the testenv | 22:37 |
| efried | mriedem: It sounds like Sundar has thought it through and has been assuming the operations should be done on behalf of the user so that proper policy and quota can be taken into account. Do you see any problem with that approach? | 22:37 |
| aspiers | or temp files created by the test framework like efried said | 22:37 |
| efried | mriedem: johnthetubaguy and I have advised him on enabling service_user, but otherwise, should be okay yes? | 22:38 |
| sean-k-mooney | if they are withing the tox venv i gues its fine | 22:38 |
| mriedem | efried: i think for most things with external-to-nova resources we try to use the user auth, for things with volumes/images/ports | 22:38 |
| sean-k-mooney | just so long as the files are not form the host system | 22:38 |
| mriedem | but there are certain APIs on those resources that we use admin creds, like port binding is admin-only since it's host-level info | 22:38 |
| efried | mriedem: k, so ironic is the outlier. And then there's a little bit of neutron that does admin, not sure what that's about. And then there's a little edge case in cinder that uses admin as well. | 22:39 |
| efried | yeah | 22:39 |
| mriedem | nova didn't even have config to do admin level stuff with cinder until a few releases ago | 22:40 |
| mriedem | to forcefully detach a volume when we didn't have a token | 22:40 |
| mriedem | so if there is host-level stuff we need to do i'd expect those apis to be admin-only by policy in cyborg | 22:41 |
| mriedem | i don't know enough about their api though | 22:41 |
| mriedem | like, you as a user can create an fpga resource and provide that to nova on server create to wire it up right? | 22:41 |
| sean-k-mooney | mriedem: that was one of the thing in the spec we called out | 22:42 |
| sean-k-mooney | e.g. that cyborgs api whoudl be admin by default | 22:42 |
| mriedem | so ironic | 22:42 |
| sean-k-mooney | since its manaing host level resouces that are potentially damaging if used incorrectly | 22:43 |
| mriedem | there are also nova/cinder interactions we probably should have done differently from the start, because some cinder apis that nova uses leak host level connection information and aren't admin apis | 22:43 |
| *** itlinux has quit IRC | 22:43 | |
| mriedem | weee https://bugs.launchpad.net/cinder/+bug/1740950 | 22:43 |
| openstack | Launchpad bug 1740950 in Cinder "Volume details shows attached compute host for non-admins" [Undecided,New] | 22:43 |
| sean-k-mooney | lick the conection context or whatever its called that has the iscsi info | 22:44 |
| sean-k-mooney | attachment? | 22:44 |
| mriedem | heh "If it lingers past Queens release day, we can revisit the advisory task." | 22:44 |
| mriedem | yes the attachment has the connection_info dict | 22:44 |
| sean-k-mooney | ya that has come up a few times | 22:44 |
| sean-k-mooney | in the cyborg case that is one of the open items in the spec here https://review.opendev.org/#/c/603955/12/specs/train/approved/nova-cyborg-interaction.rst@301 | 22:46 |
| sean-k-mooney | :( https://github.com/openstack/cyborg/blob/master/cyborg/common/policy.py#L76-L122 | 22:49 |
| sean-k-mooney | why is the program endpoint using allow ... | 22:50 |
| *** itlinux has joined #openstack-nova | 22:50 | |
| *** mmethot has quit IRC | 22:51 | |
| efried | sean-k-mooney: That (cyborg APIs being admin only) was something you brought up, but it sounds like that's not how they're planning on doing it. | 22:53 |
| mriedem | someone call lbragstad | 22:54 |
| sean-k-mooney | yes well currently anyway can update any fpga recored with there default policy so how they were planning on doing it and what they proably should do are likely not the same thing | 22:54 |
| efried | mriedem: Just this morning someone was asking about a rare failure in the logs where cinder complained of not having admin creds. | 22:55 |
| mriedem | admin-only by default seems smartest and makes the nova interaction strict from the get-go | 22:55 |
| efried | http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-05-22.log.html#t2019-05-22T12:46:19 | 22:55 |
| mriedem | but idk, that might make it hard to allow non-admin stuff later | 22:55 |
| sean-k-mooney | the deployable create/update/delete are adming only | 22:55 |
| efried | mriedem: seems to me like that's worse, because it means we *require* admin creds in the conf, and all operations would be allowable. | 22:56 |
| sean-k-mooney | update and delete on acclertors are admin or own so for those it proably fine | 22:56 |
| efried | cyborg sounds like they have a plan for granular policy (is that the right use of that term?) and if so it makes sense to do user auth from nova. | 22:57 |
| mriedem | efried: without knowing where that users was getting the error i can't really say on that cinder thing, | 22:57 |
| *** macza has quit IRC | 22:57 | |
| mriedem | it was added b/c there is a periodic in the compute which will shelve offload instances after a period of time, and cleanup soft-deleted instances after a period of time, which means doing things on volumes w/o a user token | 22:58 |
| sean-k-mooney | efried: for some things that makes sense but i think there fpga update should ast least be admin_or_owner | 22:58 |
| efried | mriedem: Well, I wound up concluding that it was probably the thing you just mentioned, the parts of cinder where we need the admin creds for those weird periodic edge cases. | 22:58 |
| *** artom has joined #openstack-nova | 22:59 | |
| efried | they didn't have any admin creds in their conf | 22:59 |
| mriedem | ok on the cyborg policy thing, idk, if only we had like a technical committee in openstack or something with security guidelines | 22:59 |
| mriedem | or an auth/identity team... | 22:59 |
| mriedem | but it's 6pm and i'm not sean-k-mooney so i need to drop off | 22:59 |
| efried | o/ | 22:59 |
| sean-k-mooney | o/ | 22:59 |
| *** mriedem has quit IRC | 22:59 | |
| sean-k-mooney | hay look its thursday ... | 23:00 |
| sean-k-mooney | i should proably go to sleep soon. | 23:00 |
| sean-k-mooney | efried: i didnt get to rework the vidoe-model stuff but i shoudl get that done tomorrow | 23:01 |
| efried | no worries | 23:01 |
| *** Sundar has joined #openstack-nova | 23:01 | |
| *** igordc has quit IRC | 23:01 | |
| sean-k-mooney | Sundar: is there a reason that anyone can update any fpga recored even if they dont own it or are not admins https://github.com/openstack/cyborg/blob/master/cyborg/common/policy.py#L119-L121 | 23:03 |
| sean-k-mooney | becaue ^ seams like a bug | 23:03 |
| Sundar | sean-k-mooney: We got some holdovers from previous releases. We need to scrub all these policies for sure. | 23:04 |
| sean-k-mooney | the same issue is there for the deployable program endpoint. | 23:04 |
| sean-k-mooney | Sundar: ok as long as you are aware but that is something that shoudl be backported | 23:05 |
| sean-k-mooney | normally you would not backport that kind of change but in this case i think its needed | 23:05 |
| Sundar | Backport to v1 API? | 23:05 |
| sean-k-mooney | Sundar: yes that would almost qualify for a revert in my book if you had not already released it | 23:06 |
| Sundar | I need to get my head around how these rules interact with API versions | 23:06 |
| *** tkajinam has joined #openstack-nova | 23:06 | |
| sean-k-mooney | normally it would be a microverion bump | 23:07 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Support old & new versions of svm and vmx traits https://review.opendev.org/660515 | 23:08 |
| *** slaweq has joined #openstack-nova | 23:11 | |
| *** baderbuddy has joined #openstack-nova | 23:15 | |
| *** slaweq has quit IRC | 23:15 | |
| *** rcernin has joined #openstack-nova | 23:20 | |
| *** itlinux has quit IRC | 23:28 | |
| Sundar | mriedem, sean-k-mooney: Re. earlier discussion today on https://review.opendev.org/#/c/603955/ , yes, I haven't updated the spec, mainly because I have been trying to understand the implications of moving the bind to compute, etc. | 23:32 |
| *** itlinux has joined #openstack-nova | 23:32 | |
| Sundar | I will shortly update the spec. | 23:32 |
| *** ttsiouts has quit IRC | 23:33 | |
| *** itlinux has quit IRC | 23:46 | |
| *** baderbuddy has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!