Monday, 2019-06-17

« Sunday, 2019-06-16 Index Tuesday, 2019-06-18 »
*** brinzhang has joined #openstack-nova00:10
*** markvoelker has joined #openstack-nova00:24
*** markvoelker has quit IRC00:28
*** ircuser-1 has quit IRC00:36
*** guozijn has joined #openstack-nova01:18
*** markvoelker has joined #openstack-nova01:24
*** markvoelker has quit IRC01:29
*** owalsh has joined #openstack-nova01:39
*** bhagyashris has joined #openstack-nova01:40
*** efried has quit IRC01:45
tonybsean-k-mooney: done.01:55
*** guozijn has quit IRC02:48
*** guozijn has joined #openstack-nova02:51
*** whoami-rajat has joined #openstack-nova03:12
*** guozijn has quit IRC03:21
*** jiaopengju has joined #openstack-nova03:22
openstackgerritMerged openstack/os-vif stable/stein: set ignore_basepython_conflict = True in tox.ini  https://review.opendev.org/66519503:22
*** markvoelker has joined #openstack-nova03:26
openstackgerritMerged openstack/os-vif stable/stein: Fix mock of built in "open" function in unit tests  https://review.opendev.org/66519603:26
*** markvoelker has quit IRC03:31
*** psachin has joined #openstack-nova03:37
*** guozijn has joined #openstack-nova03:46
*** janki has joined #openstack-nova03:47
*** guozijn has quit IRC03:50
*** brinzhang has quit IRC03:52
*** brinzhang has joined #openstack-nova03:52
*** janki has quit IRC03:54
*** janki has joined #openstack-nova03:55
*** janki has quit IRC04:13
*** janki has joined #openstack-nova04:20
*** awalende has joined #openstack-nova04:23
*** awalende has quit IRC04:27
*** ratailor has joined #openstack-nova04:34
*** udesale has joined #openstack-nova05:19
openstackgerritMerged openstack/nova master: Fix :param: in docstring  https://review.opendev.org/66528905:25
*** markvoelker has joined #openstack-nova05:28
*** ivve has quit IRC05:30
*** jiaopengju has quit IRC05:32
*** markvoelker has quit IRC05:32
*** jiaopengju has joined #openstack-nova05:32
*** janki has quit IRC05:36
*** jiaopengju has quit IRC05:39
*** jiaopengju has joined #openstack-nova05:40
*** janki has joined #openstack-nova05:42
*** janki has quit IRC05:43
*** janki has joined #openstack-nova05:44
*** factor has joined #openstack-nova05:48
*** janki has quit IRC05:49
*** janki has joined #openstack-nova05:49
*** janki has quit IRC05:53
*** janki has joined #openstack-nova05:53
*** luksky has joined #openstack-nova05:55
*** Luzi has joined #openstack-nova05:56
*** rcernin has quit IRC06:02
*** jiaopengju has quit IRC06:03
*** brault has quit IRC06:11
*** janki has quit IRC06:18
*** jamesdenton has quit IRC06:22
*** dpawlik has joined #openstack-nova06:23
*** maciejjozefczyk has joined #openstack-nova06:27
*** slaweq has joined #openstack-nova06:32
*** hamdyk has joined #openstack-nova06:33
*** ivve has joined #openstack-nova06:46
*** rpittau|afk is now known as rpittau06:56
*** xek has joined #openstack-nova06:58
*** rcernin has joined #openstack-nova07:00
*** trident has quit IRC07:06
*** trident has joined #openstack-nova07:08
openstackgerritYongli He proposed openstack/nova master: Clean up orphan instances virt driver  https://review.opendev.org/64891207:08
openstackgerritYongli He proposed openstack/nova master: clean up orphan instances  https://review.opendev.org/62776507:08
*** jiaopengju has joined #openstack-nova07:19
*** helenafm has joined #openstack-nova07:20
*** damien_r has joined #openstack-nova07:23
*** tesseract has joined #openstack-nova07:24
*** brault has joined #openstack-nova07:28
*** markvoelker has joined #openstack-nova07:29
*** dtantsur|afk is now known as dtantsur07:30
*** hamdykhader has joined #openstack-nova07:31
*** hamdyk has quit IRC07:34
*** markvoelker has quit IRC07:34
openstackgerritYongli He proposed openstack/nova master: Add server sub-resource topology API  https://review.opendev.org/62147607:35
*** ttsiouts has joined #openstack-nova07:53
*** ralonsoh has joined #openstack-nova08:02
*** takashin has left #openstack-nova08:02
*** ricolin has joined #openstack-nova08:12
*** davidsha has joined #openstack-nova08:13
*** ttsiouts has quit IRC08:14
*** ttsiouts has joined #openstack-nova08:15
openstackgerritTushar Patil proposed openstack/nova-specs master: Update spec: filtering of alloc candidates by forbidden aggregates  https://review.opendev.org/66560508:17
*** ttsiouts has quit IRC08:19
*** ttsiouts has joined #openstack-nova08:20
openstackgerritguangchao.pan proposed openstack/nova master: Add a name for the automatically created volume  https://review.opendev.org/66009608:28
*** ccamacho has joined #openstack-nova08:30
openstackgerritguangchao.pan proposed openstack/nova master: Add a name for the automatically created volume  https://review.opendev.org/66009608:30
*** markvoelker has joined #openstack-nova08:30
*** hjensas|afk is now known as hjensas08:34
*** markvoelker has quit IRC08:35
*** derekh has joined #openstack-nova08:37
*** imacdonn has quit IRC08:40
*** imacdonn has joined #openstack-nova08:40
*** tssurya has joined #openstack-nova08:44
*** pcaruana has joined #openstack-nova08:52
*** luksky has quit IRC08:54
*** tssurya has quit IRC08:55
*** tkajinam has quit IRC09:00
*** ricolin has quit IRC09:14
*** luksky has joined #openstack-nova09:27
*** ccamacho has quit IRC09:30
*** ccamacho has joined #openstack-nova09:31
*** cdent has joined #openstack-nova09:35
*** rcernin has quit IRC09:36
*** finucannot is now known as stephenfin09:36
openstackgerritMark Goddard proposed openstack/nova master: Exit 1 when db sync runs before api_db sync  https://review.opendev.org/66562609:38
openstackgerritMark Goddard proposed openstack/nova master: Update docs on db sync ordering & exit code  https://review.opendev.org/66562709:38
*** brinzhang has quit IRC09:40
openstackgerritMark Goddard proposed openstack/nova master: Exit 1 when db sync runs before api_db sync  https://review.opendev.org/66562609:43
openstackgerritMark Goddard proposed openstack/nova master: Update docs on db sync ordering & exit code  https://review.opendev.org/66562709:43
*** ociuhandu has joined #openstack-nova09:56
*** davidsha has quit IRC09:57
bhagyashrisalex_xu, stephenfin, Sean-k-mooney: Hi, I would just like to hear your opinions on http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007144.html10:19
stephenfinbhagyashris: If sean-k-mooney and alex_xu are around, sure10:20
stephenfinI'm replying to the mails one-by-one at the moment10:20
bhagyashrisstephenfin: ok thank you!10:21
stephenfinbhagyashris: Do you have anything available to push to Gerrit. I'm getting nervous about how close the next deadline is10:22
stephenfin*?10:22
stephenfinI would like to start reviewing something and iterating nice and quickly if necessary10:22
bhagyashrisalex_xu, stephenfin, Sean-k-mooney: I just have concern about this point  http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007144.html10:23
bhagyashrisstephenfin: once that will be resolve then I will push the patches soon10:23
stephenfinbhagyashris: Just replied to that http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007172.html10:23
stephenfinbhagyashris: tl;dr: don't worry about it because we can rely on host aggregrates10:24
stephenfinIf an operator is using them, then pinned instance will always land on hosts in the pinned aggregrate (or whatever it's called). The VCPU inventory of these instances will never be consumed10:25
stephenfin*of these hosts10:25
bhagyashrisstephenfin: I have to request to Matt as well. As he has given -2 and abandoned the patches: https://review.opendev.org/#/q/project:openstack/nova+topic:bp/cpu-resources  I have submitted earlier10:26
stephenfinIf an operator is not using them, then things will be broken, but they were broken before10:26
stephenfinbhagyashris: I can restore those for you if you're planning to re-use them?10:27
bhagyashrisstephenfin: yeah I am plaining to use that patches so that will be great if you can restore it :)10:27
sean-k-mooneybhagyashris: the impmenation you did last cycle was not the same as the current spec. they were abandond becayse they had not been updated in many months and the spec was not approved for last cycle10:28
bhagyashrisstephenfin: checking your reply....10:28
stephenfinbhagyashris: Hmm, yeah, looking at them, perhaps it would be better to submit new reviews10:29
*** markvoelker has joined #openstack-nova10:32
bhagyashrisstephenfin: yeah but the base implementation has not that much change so I was thinking to push on the same. Only the upgrade patch that anyways not uploaded  yet. But if you want to push the new patches then I will push new reviews10:32
stephenfinYeah, probably easier to just change the commit ID. I don't see that much context that would be useful going forward10:34
stephenfinbhagyashris: Do you think you'll have patches available by the end of this week?10:34
stephenfinAt least WIP ones10:34
bhagyashrisstephenfin: ok I will push the new patches. Sure I will submit the WIP patches by end of this week10:35
sean-k-mooneylooking at the old patches i dont see any logic to soft pin floating instance to the shared_cpu_set10:35
sean-k-mooneyi assume that still needs to be written10:35
*** markvoelker has quit IRC10:36
bhagyashrisstephenfin: I just want to ask about your reply that you said the host aggregrates should also be configured correctly that means if user request instance having the flavor extra specs ``resources:PCPU=1 and resources:VPU=1`` on upgrade node then in that case it will report both the VCPU and PCPU resources10:43
stephenfinbhagyashris: No, we're not supporting that at the moment10:43
stephenfinWe can support it in U but not in Train10:43
stephenfinWell, we could support it in Train with a big warning that operators need to do their homework, but the spec doesn't encompass that yet10:44
sean-k-mooneystephenfin: its out of scope of the spec10:44
bhagyashrisstephenfin: means that flavor (having ``resources:PCPU=1 and resources:VCPU=1``) should have "aggregate_instance_extra_specs:pinned": "true" extra specs as well10:44
sean-k-mooneybhagyashris: no10:45
sean-k-mooneybhagyashris: in train we do not plan to allow host to have both pinned and non pinned cpus10:45
stephenfinAs noted in the other email, that was dropped from the spec to focus on getting the important piece - PCPU tracking in placement - done10:45
sean-k-mooney*instances10:45
stephenfinyeah, what sean-k-mooney said10:45
sean-k-mooneyhost can be mixed but instances cannot, in train10:45
bhagyashrissean-k-mooney :  means operator can set either dedicated_set or shared_set only and not the both the set attime ?10:47
stephenfinThey can set both10:47
sean-k-mooneymixing pinned and non pinned cpus in a singel instance was not allowed in the spec last cycle either. it was part fo a different spec.10:48
stephenfincpu_shared_set is also used for emulator threads10:48
stephenfinsean-k-mooney: Nah, it was part of the spec but I scrubbed references to it10:48
stephenfinWhat wasn't included was the NUMA stuff10:48
sean-k-mooneystephenfin: hum maybe the other spec got folded in at some point10:48
stephenfin*was never included10:48
stephenfinQuite possibly, yeah10:48
stephenfinbhagyashris: We're totally for supporting instances with pinned and unpinned instances in the future but not yet. This is just too complex already without adding more complexity10:49
stephenfinand not having it makes upgrades simpler, as you note10:49
stephenfinSo if you have patches adding this functionality, I would leave them to the end of the series and wouldn't focus your attention on them yet. They won't merge so you'd be wasting effort10:50
bhagyashrisstephenfin: if operator can set both the set say cpu_dedicated_set and cpu_shared_set then in that case inventory reported in the placement will be PCPU and VCPU right?10:51
stephenfinYes10:51
sean-k-mooneybhagyashris: what i was refering to before about soft pinning is that when you are mixing pinned guests with floating guests we need to ensure the floating guest only float over teh cpu_shared_set when cpu_dedicated_set is defiend10:52
sean-k-mooneybhagyashris: yep10:52
stephenfinand, in theory, they could stop using host aggregates to separate pinned instances from non-pinned instances at that point10:52
stephenfinbecause the non-pinned instances will only float on the cores listed in cpu_shared_set10:52
stephenfinOr "soft pinning", as sean-k-mooney points out10:53
sean-k-mooneyits the same as what we do for numa10:53
sean-k-mooneyif you dont also enable cpu pinning10:53
sean-k-mooneywe confine the cpus to float over a numa node10:53
stephenfinyup, though we shouldn't care about NUMA affinity for the non-NUMA and non-pinned case10:54
sean-k-mooneycorrect10:54
stephenfinsean-k-mooney: This reinforces how important artom's NUMA live migration work is though10:54
stephenfinwe'll need that to make sure the soft pinning information is recalculated when we live migrate10:54
sean-k-mooneystephenfin: yes we will we already have accounted for that in his work10:56
sean-k-mooneywe support the soft pinning case for numa10:56
stephenfinawesome10:56
sean-k-mooneyso we just need to ensure that we also pass back the info for non pinned guests10:56
stephenfinYup10:56
stephenfinbhagyashris: Any other questions before I disappear for lunch?10:56
sean-k-mooneyso there should be a change in the cpu pinning spec that extend what he is doing for shared instances10:56
sean-k-mooney* not spec but patch series10:57
bhagyashrisstephenfin: but the host aggregates will come into picture only when the host are under that aggregate and that aggregate having meta data pinned and flavor also need to set the extra specs "aggregate_instance_extra_specs:pinned": "true" but as per the new implementation and flavor having new flavor extra specs (``resources:PCPU=1 and resources:VCPU=1``)  and dont have "aggregate_instance_extra_specs:pinned": "true" extra spec10:58
bhagyashriss so in that case it will consume both the inventories10:58
sean-k-mooney"resources:PCPU=1 and resources:VCPU=1" is not valid in train10:59
sean-k-mooneybhagyashris: we can have the api reject instance with that config10:59
stephenfinYeah, you need to stop worrying about that. We can't and won't support it in Train10:59
stephenfinIn fact, we should have an explicit check to prevent that10:59
stephenfinUntil we get to U and submit a new spec for adding this functionality11:00
sean-k-mooneystephenfin: bhagyashris   ya we should alex_xu pointed out that there is already a check in the api tha validates the numa and pinning extra_specs are valide so we can extend it11:00
bhagyashrisstephenfin, sean-k-mooney : but ie user request it separately say in the first request he request resources:PCPU=1 and in second request he request resources:VCPU=1 then it will consume the resources form the same cpu_set11:02
sean-k-mooneybhagyashris: what second request11:02
sean-k-mooneydo you mean two different vms?11:02
bhagyashrissean-k-mooney :  yes11:03
sean-k-mooneythat is fine11:03
sean-k-mooneywe will be allowing one vm with pinning and another with out pinning on the same host11:03
bhagyashrissean-k-mooney : plz check this I have detailed the scenario here : http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007144.html11:04
sean-k-mooneyif and only if it has inveotry of both VCPU and PCPUs11:04
sean-k-mooneybhagyashris: yes as i pointed out that is supported11:04
bhagyashrissean-k-mooney : if that is fine then this is the violation to pinning feature11:04
sean-k-mooneybhagyashris: its not, it would be if and only if you have not set cpu_dedicated_set11:05
sean-k-mooneyyou will not be ably to support mixing vms until after you have cpu_dedicated_set and removed the use of vcpu_pinned_set11:06
sean-k-mooneywhich mean operators should continue to use host aggrages to prevent mixing until they have modified there config to use the new feature11:07
bhagyashrissean-k-mooney :  but as mentioned in the spec if we have vcpu_pin_set set in the Stein and now it's upgraded to Train then will report both the inventory PCPU and VCPU and after that if user request two vim separately  as we discussed above then11:07
*** ttsiouts has quit IRC11:08
bhagyashrissean-k-mooney : I that case it will consume resources from same CPUs and I think that is wrong11:09
*** ttsiouts has joined #openstack-nova11:09
sean-k-mooneywe know11:09
sean-k-mooneyand we are going to allow that as that is the pre train behaviro11:09
sean-k-mooneywe are aware that in that case the floating instace can float over the pinned instances11:10
sean-k-mooneybut mixing vms on the same host will only be supported after you have defiend cpu_dedicated_set11:10
bhagyashrissean-k-mooney : yeah and thats my concern11:10
sean-k-mooneybhagyashris: we intentionlly want to allow that11:10
sean-k-mooneybhagyashris: we need to allow it to allow inplace upgrade of nodes with running instances11:11
bhagyashrissean-k-mooney : ok11:11
*** ttsiouts has quit IRC11:13
sean-k-mooneyone of the requirements for edge workload is we need to be able to do inplace upgrades without draining a host of instaces. going for Train to U we will remove the vcpu_pin_set option which means before upgrading to U you will need to updated your config to remove it.11:14
bhagyashrissean-k-mooney : just want to clear some points 1. As we discussed above that the floating instace can float over the pinned instances is allowed for train release11:15
sean-k-mooneyits only allowed if cpu_dedicated_set is not defined11:15
bhagyashrissean-k-mooney : if user request the both the resources:PCPU and VCPu resources in the same request then that should get rejected11:16
sean-k-mooneyif cpu_dedicated_set is defiend VCPU inventory will only be reported if cpu_shared_set is defiend. if both cpu_shared_set and cpu_dedicated_set are defiend then nova will soft pin floating cores to the cpu_shared_set cpus11:17
*** ociuhandu has quit IRC11:17
sean-k-mooneybhagyashris: yes if the user request VCPUs and PCPUs in the same request it will be reject in the api as part of the boot request before we get to the schduler11:18
bhagyashrissean-k-mooney : and if user sets only cpu_shared_set then in that case VCPU inventory will be reported right?11:19
bhagyashrissean-k-mooney : and that will be used as shared cpu resources11:21
bhagyashrissean-k-mooney : my concern is what will happen if inly cpu_shared_set is define11:22
bhagyashrisonly*11:22
sean-k-mooneyyes if cpu_shared_set is defeind and vcpu_pin_set is not then only VCPUs will be reported11:22
sean-k-mooneyand we should soft pin to that set11:22
*** panda is now known as panda|lunch11:23
sean-k-mooneyif cpu_shared_set is defiend and vcpu_pin_set is defiend then we ignore cpu_shared_set for reporting to placement and do not soft pin the cpus to cpu_shared_set11:23
sean-k-mooneybhagyashris: if they only define cpu_shared_set we soft ping floating instance to the cpu_share_set and only report VCPU for the cores enabeld in teh cpu_shared_set and dont report any PCPU inventory11:25
sean-k-mooneyso the soft pinning of floating instace will not be done if vcpu_pin_set is defiend and will be done in all other cases11:25
sean-k-mooneywe could allow it if all 3 values are defiend but i would prefer to treat that as an error11:26
sean-k-mooneywe can decided that in code reveiw11:26
bhagyashrissean-k-mooney : ok11:26
*** udesale has quit IRC11:28
*** udesale has joined #openstack-nova11:29
*** ociuhandu has joined #openstack-nova11:30
*** shilpasd has joined #openstack-nova11:31
bhagyashrissean-k-mooney : I would just like to know about soft pinning11:32
*** ttsiouts has joined #openstack-nova11:39
*** bhagyashris has quit IRC11:39
*** yankcrime has joined #openstack-nova11:39
*** ratailor has quit IRC11:44
*** jaosorior has joined #openstack-nova11:47
*** jaosorior has quit IRC12:02
*** edleafe has joined #openstack-nova12:02
*** jiaopengju has quit IRC12:11
*** jiaopengju has joined #openstack-nova12:11
*** ratailor has joined #openstack-nova12:12
openstackgerritMerged openstack/nova master: Add 'path' query parameter to console access url  https://review.opendev.org/64937212:14
*** rtjure has quit IRC12:16
*** panda|lunch is now known as panda12:25
*** markvoelker has joined #openstack-nova12:33
*** markvoelker has quit IRC12:38
*** dave-mccowan has joined #openstack-nova12:42
*** ricolin has joined #openstack-nova12:45
*** ratailor has quit IRC12:45
*** psachin has quit IRC12:46
*** jiaopengju has quit IRC13:01
*** lbragstad has joined #openstack-nova13:12
*** lennyb has joined #openstack-nova13:13
*** ricolin has quit IRC13:17
*** beekneemech is now known as bnemec13:18
*** mriedem has joined #openstack-nova13:19
*** yankcrime has left #openstack-nova13:25
*** shilpasd_ has joined #openstack-nova13:26
*** pcaruana|afk| has joined #openstack-nova13:26
*** pcaruana has quit IRC13:26
*** shilpasd__ has quit IRC13:27
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552013:29
*** cfriesen has joined #openstack-nova13:33
*** markvoelker has joined #openstack-nova13:34
*** efried has joined #openstack-nova13:39
*** markvoelker has quit IRC13:39
*** ricolin has joined #openstack-nova13:40
stephenfinsean-k-mooney: Not sure if you've got to them or not, but do all my replies so far match up with what you'd expected?13:43
stephenfinRE: the cpu-resources spec?13:43
sean-k-mooneymore or less13:47
*** slaweq has quit IRC13:47
sean-k-mooneyyou mean on the mailing list post right13:47
sean-k-mooneythe prefilter will default to false in the config13:47
sean-k-mooneyso on upgade it will be disabeld by default13:48
*** pcaruana has joined #openstack-nova13:48
sean-k-mooneyas you are not ment to modify config as part of upgade that means that by default we will get inveoties of both VCPU and PCPU13:48
*** mchlumsky has joined #openstack-nova13:48
sean-k-mooneythen later we can enable the prefilter and add the dedicated_cpu_set and remove teh vcpu_pin_set13:49
*** belmoreira has joined #openstack-nova13:50
*** pcaruana|afk| has quit IRC13:51
sean-k-mooneypersonally i had assumed that defineing the dedicated_cpu_set option is what would have done the reshape fo exisitng instances13:52
sean-k-mooneyreshape is a little impresise what i mean is modifying the allcoation for exsiting instance to consume PCPUs if needed13:53
*** eharney has joined #openstack-nova13:59
shilpasdHi, can anybody help me to test live migration? i using openstack via devstack, and facing below error13:59
shilpasdlibvirtError: operation failed: Failed to connect to remote libvirt URI qemu+tcp://<vm_user>@<compute_node_name>/system: unable to connect to server at '<compute_node_name>:16509': Connection refused13:59
shilpasdFYI: referred 'https://www.mirantis.com/blog/tutorial-openstack-live-migration-with-kvm-hypervisor-and-nfs-shared-storage/' for libvirtd.conf configuration14:00
shilpasdafter running telnet >>Unable to connect to remote host: Connection refused14:01
shilpasdseems configuration issue, can anybody provide me any specific link for live-migration14:02
*** Luzi has quit IRC14:03
mriedemefried: i've half a mind to revert this https://review.opendev.org/#/c/663502/14:05
mriedemhe removed an unused method but it's a regression to not be using that method14:05
mriedemhttps://bugs.launchpad.net/nova/+bug/183026014:05
openstackLaunchpad bug 1830260 in OpenStack Compute (nova) stein "Inefficient host_status lookup when listing servers with details (regression)" [Medium,Triaged]14:05
mriedembut i guess it could be reverted when someone actually fixes the bug14:06
efriedmriedem: ack. in any case, I'd like to understand the path I should have taken as a reviewer to know about that bug and that using this method was a solution14:06
mriedemit's not really your fault. i don't know, but i suspect takashi noticed it when i pointed out the regression in a recent-ish ML thread.14:07
efriedokay14:08
efriedmriedem: I guess a note in the bug mentioning the commit where it was removed so it can be reinstated?14:09
efried...reinstated when fixing the bug?14:09
mriedemyeah good point14:10
*** ircuser-1 has joined #openstack-nova14:11
*** dpawlik has quit IRC14:19
shilpasdmriedem: hi do you have few time, want to discuss @ live migration issue i am facing14:21
sean-k-mooneyso if im following correctly https://bugs.launchpad.net/nova/+bug/1830260 was really intoduced by https://review.opendev.org/#/c/584590/ when that stop calling the method that https://review.opendev.org/#/c/663502/1 removed14:21
openstackLaunchpad bug 1830260 in OpenStack Compute (nova) stein "Inefficient host_status lookup when listing servers with details (regression)" [High,Triaged]14:21
sean-k-mooneyshould ^ have a stein-backport-potential  tag14:23
*** mlavalle has joined #openstack-nova14:23
*** jaosorior has joined #openstack-nova14:23
*** belmoreira has quit IRC14:24
*** davidsha has joined #openstack-nova14:25
*** belmoreira has joined #openstack-nova14:28
sean-k-mooneymriedem: by the way your cross cell resize series should be entering the runway in a day or so. i assume the reviewers guide you sent before is still pretty much accurate? ill try to start on the series again later this weeks but ill re read that in the mean time to reload the context14:33
*** JamesBenson has joined #openstack-nova14:33
*** markvoelker has joined #openstack-nova14:35
*** hamdykhader has quit IRC14:35
*** belmoreira has quit IRC14:39
*** markvoelker has quit IRC14:40
*** belmoreira has joined #openstack-nova14:44
*** pcaruana has quit IRC14:47
openstackgerritStephen Finucane proposed openstack/nova master: docs: Remove references to nova-consoleauth  https://review.opendev.org/65296514:47
openstackgerritStephen Finucane proposed openstack/nova master: tests: Stop starting consoleauth in functional tests  https://review.opendev.org/65296614:47
openstackgerritStephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens  https://review.opendev.org/65296714:47
openstackgerritStephen Finucane proposed openstack/nova master: xvp: Remove use of '_LI' marker  https://review.opendev.org/66542514:47
openstackgerritStephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check  https://review.opendev.org/65296814:47
openstackgerritStephen Finucane proposed openstack/nova master: Remove nova-consoleauth  https://review.opendev.org/65296914:47
openstackgerritStephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict  https://review.opendev.org/65297014:47
openstackgerritStephen Finucane proposed openstack/nova master: docs: Rework nova console diagram  https://review.opendev.org/66014714:47
openstackgerritStephen Finucane proposed openstack/nova master: docs: Integrate 'sphinx.ext.imgconverter'  https://review.opendev.org/66569314:47
openstackgerritStephen Finucane proposed openstack/nova master: Remove dead file  https://review.opendev.org/66569414:47
*** jaosorior has quit IRC14:49
openstackgerritStephen Finucane proposed openstack/nova master: docs: Remove unused Visio diagram  https://review.opendev.org/66569414:49
bauzasmriedem: thanks for having reviewed https://review.opendev.org/#/c/650963/14:50
bauzasmriedem: I just updated with comments, lemme know if you need more details14:50
*** dklyle has joined #openstack-nova14:55
mriedemsean-k-mooney: yes it's as described in the bug. and yes the cross-cell resize review guide in the ML is unchanged.14:59
mriedemshilpasd: what's up14:59
*** brault has quit IRC15:02
*** ivve has quit IRC15:05
*** cdent has quit IRC15:09
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442015:13
aspiersefried, sean-k-mooney: ^^^ changes as discussed last week15:14
*** rajinir has joined #openstack-nova15:14
openstackgerritSylvain Bauza proposed openstack/nova-specs master: Proposes NUMA affinity for vGPUs  https://review.opendev.org/65096315:15
*** luksky has quit IRC15:20
efriedaspiers: ack15:27
aspiersefried: I'm just adding the API-level check to it which Alex pointed out was missing15:27
ralonsohtonyb, hi, can you take a look at https://review.opendev.org/#/c/655694/? Thank you in advance15:28
*** belmoreira has quit IRC15:28
openstackgerritStephen Finucane proposed openstack/nova master: docs: Integrate 'sphinx.ext.imgconverter'  https://review.opendev.org/66569315:28
openstackgerritStephen Finucane proposed openstack/nova master: docs: Remove unused Visio diagram  https://review.opendev.org/66569415:28
*** mrch_ has quit IRC15:32
temkasean-k-mooney, looks like you took a look at https://bugs.launchpad.net/nova/+bug/1826519 - to me that's a cloud-init problem, not a Nova one. You OK to close as Invalid?15:35
openstackLaunchpad bug 1826519 in OpenStack Compute (nova) "Ephemeral disk volume was not mounted after resizing from non-ephemeral flavor" [Undecided,New]15:35
*** temka is now known as artom15:35
artomWhoops15:35
*** tesseract has quit IRC15:38
*** pcaruana has joined #openstack-nova15:40
*** helenafm has quit IRC15:47
*** gyee has joined #openstack-nova15:49
openstackgerritBalazs Gibizer proposed openstack/os-vif master: Insert osprofiler trace info as external_ids to the bridge table  https://review.opendev.org/66571515:49
*** gyee has quit IRC15:49
*** awalende has joined #openstack-nova15:50
*** awalende has quit IRC15:52
*** slaweq has joined #openstack-nova15:53
*** awalende has joined #openstack-nova15:53
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442015:53
*** ttsiouts has quit IRC15:54
*** ttsiouts has joined #openstack-nova15:55
*** trident has quit IRC15:56
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442015:57
aspiersefried: API-level check is now in ^^^15:57
efriedack15:57
aspiersThis should be ready for review. Now it should be easy for me to fix the subsequent SEV guest config changes!15:57
*** awalende has quit IRC15:57
*** trident has joined #openstack-nova15:58
*** ttsiouts has quit IRC15:59
*** damien_r has quit IRC16:03
*** awalende has joined #openstack-nova16:04
*** awalende has quit IRC16:05
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E731 (do not assign a lambda expression, use a def)  https://review.opendev.org/65155416:05
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator)  https://review.opendev.org/65155516:05
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name)  https://review.opendev.org/65210316:05
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence)  https://review.opendev.org/65210416:05
*** awalende has joined #openstack-nova16:05
*** awalende has quit IRC16:08
*** awalende has joined #openstack-nova16:08
*** gyee has joined #openstack-nova16:11
mriedemsean-k-mooney: alex_xu: i went through the pmem spec https://review.opendev.org/#/c/601596/ - lots of questions and comments16:25
openstackgerritMerged openstack/nova master: Ensure controllers all call super  https://review.opendev.org/66095016:26
*** lbragstad has quit IRC16:26
*** dtantsur is now known as dtantsur|afk16:27
sean-k-mooneymriedem: ok i need to finish review that spec again too. i have not done a full review since version 1216:27
*** lbragstad has joined #openstack-nova16:28
mriedemthe biggest nagging feeling i get on that spec is it sounds like these are local block devices and should be modeled as BDMs16:28
mriedemthey really sound like the libvirt lvm image backend with the zero'ing out and such16:29
sean-k-mooneythey are presended to the guest as memory DIMs however16:29
sean-k-mooneynot as block devices16:29
sean-k-mooneybut form a host level they are similar16:29
*** whoami-rajat has quit IRC16:29
*** panda is now known as panda|off16:30
alex_xumriedem: thanks a lot, I will go through them all tomorrow16:30
*** rpittau is now known as rpittau|afk16:31
mriedemsean-k-mooney: yeah i know, and i'm not saying he should change the spec, and modeling as bdms could cause confusion in a different way as well16:32
sean-k-mooneyone other usecase that is out of scope for Train but i expect to see in U is the option to use PMEM inplacem of ram as similarly to how we use hugepages or filebacked memroy. for the current usecase BDMs may make sense but im not sure if it will work for those usecase too in the future16:32
mriedemi guess i just don't like new models and objects and such for new devices but i'm cranky16:33
sean-k-mooneyill go through you review comments properly this week and try to digest it.16:33
sean-k-mooneyi do agree that we have to be carful with what happens if the config options chage16:34
*** udesale has quit IRC16:35
*** ricolin has quit IRC16:35
*** markvoelker has joined #openstack-nova16:37
alex_xuyea, at least from hardware view, it still memory, not the block device16:37
alex_xusean-k-mooney: currently we have a config option which is for file backend memory16:38
alex_xubut it isn't very flexible as I remember, I didn't think about that too much also, since that isn't the usecase we are looking for now also16:39
*** markvoelker has quit IRC16:42
*** eandersson has joined #openstack-nova16:42
*** igordc has joined #openstack-nova16:44
*** slaweq has quit IRC16:47
*** whoami-rajat has joined #openstack-nova16:48
mriedemoh yeah... https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.file_backed_memory16:49
mriedemif you changed that from true to false and restarted with guests on that host we'd have problems16:51
mriedemer >0 to 016:51
*** awalende has quit IRC16:52
*** awalende has joined #openstack-nova16:53
*** ricolin has joined #openstack-nova16:53
*** awalende has quit IRC16:57
*** ivve has joined #openstack-nova16:58
*** keerthigd_ has joined #openstack-nova17:00
*** derekh has quit IRC17:00
*** zbr|ooo has quit IRC17:04
*** zbr|ruck has joined #openstack-nova17:07
*** mrch_ has joined #openstack-nova17:13
*** davidsha has quit IRC17:22
openstackgerritMatt Riedemann proposed openstack/nova master: Remove file-backed memory live migration compat check  https://review.opendev.org/66572817:24
*** artom has quit IRC17:26
*** trident has quit IRC17:27
*** trident has joined #openstack-nova17:29
*** ricolin has quit IRC17:30
*** markvoelker has joined #openstack-nova17:37
*** markvoelker has quit IRC17:43
*** alex_xu has quit IRC17:54
*** awalende has joined #openstack-nova18:01
*** ralonsoh has quit IRC18:09
*** luksky has joined #openstack-nova18:12
openstackgerritAdam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test  https://review.opendev.org/66255518:14
openstackgerritAdam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests  https://review.opendev.org/66255618:14
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633418:14
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> element to guest config for AMD SEV  https://review.opendev.org/63631818:14
openstackgerritAdam Spiers proposed openstack/nova master: Allow guest devices to include <driver iommu='on' />  https://review.opendev.org/64456418:14
openstackgerritAdam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices  https://review.opendev.org/64456518:14
openstackgerritAdam Spiers proposed openstack/nova master: Use <launchSecurity> element when SEV is required  https://review.opendev.org/66255718:14
openstackgerritAdam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested  https://review.opendev.org/66255818:14
*** bauzas has quit IRC18:21
openstackgerritHarald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url  https://review.opendev.org/66455918:21
*** awalende has quit IRC18:23
*** awalende has joined #openstack-nova18:23
sean-k-mooneystephenfin: just an fyi the kolla-ansibel change for removing nova-consoleauth just merged https://review.opendev.org/#/c/661427/18:25
sean-k-mooneyJeffrey4l: thanks for completing ^18:26
*** keerthigd_ has quit IRC18:26
*** bauzas has joined #openstack-nova18:27
*** dpawlik has joined #openstack-nova18:29
hjensasdansmith: Thanks for the review on ^^, you where right and I want to apologize for the 'did you look at the bug' comment. wdyt about the new revision?18:29
*** niceplace has quit IRC18:30
dansmithhjensas: you're still changing the existing format I think, but I'm in the middle of something else.. will comment in a few18:30
hjensasdansmith: thanks, appriciated.18:30
*** niceplace has joined #openstack-nova18:31
*** artom has joined #openstack-nova18:32
*** jbernard has quit IRC18:33
*** awalende_ has joined #openstack-nova18:35
*** jbernard has joined #openstack-nova18:36
*** markvoelker has joined #openstack-nova18:38
*** awalende has quit IRC18:39
mriedemefried: would you agree with this? https://review.opendev.org/#/c/661237/9/nova/compute/api.py@100018:41
efriedmriedem: looking18:41
mriedemalso, there is something really strange about the mock assertions he's making in this change which are passing but i'm not sure why18:41
mriedemyou might have ideas18:41
efriedmriedem: I agree with your comment on PlacementAPIConnectError. Commenting...18:43
openstackgerritHarald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url  https://review.opendev.org/66455918:44
*** pcaruana has quit IRC18:44
*** markvoelker has quit IRC18:45
efriedmriedem: I can play with that mock later on if you want me to.18:48
mriedemi just did http://paste.openstack.org/show/753112/ and it's failing if i don't use the yielded cctxt18:48
mriedemso i left a note about just doing that18:48
efriedBeen in The Worst Chair in Taylor all day so far - power has been out at my house and this coffee shop clearly does not want to encourage long stays.18:49
efriedApparently the power is back on, so I'll be moving shortly :)18:49
mriedembut how have all of the overly loud overly personal conversations around you been going?18:49
efriedokay, I posted my comment agreeing with you about the exception18:49
efriedheh, quite entertaining.18:49
efriedOld folks talking about how things ain't how they used to be.18:50
efriedA job interview.18:50
efriedA married couple fighting.18:50
efriedKids with a baby (was it theirs?)18:50
*** dave-mccowan has quit IRC18:54
*** awalende_ has quit IRC19:03
*** awalende has joined #openstack-nova19:04
*** dave-mccowan has joined #openstack-nova19:05
*** slaweq has joined #openstack-nova19:05
*** awalende has quit IRC19:07
sean-k-mooneygibi: is https://review.opendev.org/#/c/665715/1 for testing or do you intend it to actuly be a feature in the future?19:09
*** maciejjozefczyk has quit IRC19:11
*** dave-mccowan has quit IRC19:14
*** pcaruana has joined #openstack-nova19:17
*** efried has quit IRC19:19
openstackgerritMatt Riedemann proposed openstack/nova master: Deprecate RetryFilter  https://review.opendev.org/66395319:26
openstackgerritMatt Riedemann proposed openstack/nova master: Fix enabled_filters default value in admin config docs  https://review.opendev.org/66575119:26
*** maciejjozefczyk has joined #openstack-nova19:27
*** pcaruana has quit IRC19:27
openstackgerritMatt Riedemann proposed openstack/nova master: Deprecate RetryFilter  https://review.opendev.org/66395319:27
*** eharney has quit IRC19:30
*** trident has quit IRC19:37
*** trident has joined #openstack-nova19:39
*** markvoelker has joined #openstack-nova19:40
*** markvoelker has quit IRC19:45
openstackgerritDustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get  https://review.opendev.org/64289919:47
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for node.list  https://review.opendev.org/65602719:47
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node  https://review.opendev.org/65602819:47
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id  https://review.opendev.org/65969019:47
openstackgerritDustin Cowles proposed openstack/nova master: WIP: Use SDK instead of ironicclient for add/remove instance info from node  https://review.opendev.org/65969119:47
*** mgariepy has quit IRC19:52
*** awalende has joined #openstack-nova19:55
*** cdent has joined #openstack-nova20:01
*** maciejjozefczyk has quit IRC20:04
*** xek has quit IRC20:17
*** mrjk has quit IRC20:19
*** mrjk has joined #openstack-nova20:19
*** whoami-rajat has quit IRC20:19
*** markvoelker has joined #openstack-nova20:41
openstackgerritMerged openstack/nova-specs master: Update spec: filtering of alloc candidates by forbidden aggregates  https://review.opendev.org/66560520:42
*** markvoelker has quit IRC20:46
*** dpawlik has quit IRC20:50
*** artom has quit IRC20:59
*** maciejjozefczyk has joined #openstack-nova21:02
*** Sundar has joined #openstack-nova21:16
*** efried has joined #openstack-nova21:19
openstackgerritmelanie witt proposed openstack/nova master: Log quota legacy method warning only if counting from placement  https://review.opendev.org/66576521:24
melwittmriedem: I realized I accidentally made the log warning happen in cases it shouldn't in the counting quotas follow up patch https://review.opendev.org/#/c/662056/5/nova/quota.py@1315 fix is ^21:26
*** awalende has quit IRC21:28
*** awalende has joined #openstack-nova21:29
mriedemmelwitt: small thing in there21:30
*** eharney has joined #openstack-nova21:30
melwittheh, thanks. I am just constantly doing that, adding the else: argh21:31
openstackgerritmelanie witt proposed openstack/nova master: Log quota legacy method warning only if counting from placement  https://review.opendev.org/66576521:32
mriedemit tooks years of https://pmd.github.io/ forced on me21:32
melwittoh, neat21:33
*** awalende has quit IRC21:34
sean-k-mooneyhuh i didnt know there was an opensouce tool like that21:34
sean-k-mooneyi guess it makes sense but the only cross lanaguage cross plathform static analiser i knew of were closed souce21:35
openstackgerritMatt Riedemann proposed openstack/nova master: Clean up NumInstancesFilter related docs  https://review.opendev.org/66576821:35
*** maciejjozefczyk has quit IRC21:38
*** markvoelker has joined #openstack-nova21:42
*** rcernin has joined #openstack-nova21:43
*** mchlumsky has quit IRC21:43
*** markvoelker has quit IRC21:47
*** slaweq has quit IRC21:51
*** awalende has joined #openstack-nova21:58
*** JamesBenson has quit IRC21:59
*** JamesBenson has joined #openstack-nova22:00
*** awalende has quit IRC22:01
*** cdent has quit IRC22:04
*** slaweq has joined #openstack-nova22:04
*** JamesBenson has quit IRC22:04
*** luksky has quit IRC22:08
*** slaweq has quit IRC22:09
*** ChanServ has quit IRC22:09
*** ChanServ has joined #openstack-nova22:14
*** niven.freenode.net sets mode: +o ChanServ22:14
*** mlavalle has quit IRC22:14
*** luksky has joined #openstack-nova22:21
*** mriedem has quit IRC22:27
*** awalende has joined #openstack-nova22:34
*** slaweq has joined #openstack-nova22:36
*** awalende has quit IRC22:38
*** luksky has quit IRC22:39
Nick_ATrying to inject a password into a kvm guest using libvirt. nova.conf is set up with inject_partition = -1, inject_password = True, inject_key = True. Keys are working but not passwords. What might we be missing?22:39
*** slaweq has quit IRC22:41
*** markvoelker has joined #openstack-nova22:43
*** vishwanathj has joined #openstack-nova22:44
*** francoisp has quit IRC22:45
melwittNick_A: in addition to what's described in https://docs.openstack.org/nova/latest/admin/admin-password-injection.html I think you have to have the qemu guest agent package installed on the guest. not sure why that's not in the doc tho22:47
*** markvoelker has quit IRC22:48
melwittand also hw_qemu_guest_agent=yes image property https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-kvm.html#guest-agent-support22:52
Nick_Amelwitt we actually tried that already - it allows for updating of the password once the instance exists, but we can't seem to set it upon creation/rebuild22:53
melwittNick_A: that seems unexpected. there might be a bug, or maybe I'm just not aware there's something additional needed for it to work for create/rebuild22:55
*** tkajinam has joined #openstack-nova22:55
openstackgerritsean mooney proposed openstack/nova master: create initial image metadata prefilter  https://review.opendev.org/66577522:59
*** sapd1_x has joined #openstack-nova23:01
*** gfhellma has joined #openstack-nova23:05
*** tjgresha has quit IRC23:09
*** awalende has joined #openstack-nova23:13
Nick_AEven the random password generated when we manually openstack server create doesn't work...23:14
openstackgerritSam Morrison proposed openstack/nova stable/rocky: Fix double word hacking test  https://review.opendev.org/66578823:18
openstackgerritSam Morrison proposed openstack/nova stable/queens: Fix double word hacking test  https://review.opendev.org/66579023:19
*** gfhellma has quit IRC23:21
*** vishwanathj has quit IRC23:23
*** vishwanathj has joined #openstack-nova23:24
*** gyee has quit IRC23:28
*** vishwanathj has quit IRC23:28
*** slaweq has joined #openstack-nova23:33
*** slaweq has quit IRC23:40
*** artom has joined #openstack-nova23:43
*** markvoelker has joined #openstack-nova23:44
openstackgerritMerged openstack/nova master: Don't rely on SQLAlchemy collections magically initializing __dict__  https://review.opendev.org/66147223:45
openstackgerritMerged openstack/nova master: docs: remove the RamFilter from example  https://review.opendev.org/66554623:45
*** awalende has quit IRC23:46
*** markvoelker has quit IRC23:48
openstackgerritsean mooney proposed openstack/os-traits master: add libvirt image metadata traits  https://review.opendev.org/65299623:51
openstackgerritsean mooney proposed openstack/os-traits master: add GOP, NONE and VIRTIO grapics models  https://review.opendev.org/66583023:51
« Sunday, 2019-06-16 Index Tuesday, 2019-06-18 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!