Tuesday, 2019-06-18

*** awalende has joined #openstack-nova00:13
*** awalende has quit IRC00:18
*** alex_xu has joined #openstack-nova00:23
*** brinzhang has joined #openstack-nova00:34
*** markvoelker has joined #openstack-nova00:45
*** markvoelker has quit IRC00:50
*** sapd1_x has quit IRC00:55
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442001:03
openstackgerritAdam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test  https://review.opendev.org/66255501:03
openstackgerritAdam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests  https://review.opendev.org/66255601:03
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633401:03
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> element to guest config for AMD SEV  https://review.opendev.org/63631801:03
openstackgerritAdam Spiers proposed openstack/nova master: Allow guest devices to include <driver iommu='on' />  https://review.opendev.org/64456401:03
openstackgerritAdam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices  https://review.opendev.org/64456501:03
openstackgerritAdam Spiers proposed openstack/nova master: Use <launchSecurity> element when SEV is required  https://review.opendev.org/66255701:03
openstackgerritAdam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested  https://review.opendev.org/66255801:03
*** ricolin has joined #openstack-nova01:05
*** Sundar has quit IRC01:12
*** takashin has joined #openstack-nova01:19
*** lbragstad has quit IRC01:22
*** lbragstad has joined #openstack-nova01:22
*** hongbin has joined #openstack-nova01:32
*** _hemna has joined #openstack-nova01:35
*** markvoelker has joined #openstack-nova01:46
*** markvoelker has quit IRC01:50
openstackgerritMerged openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages  https://review.opendev.org/65569401:52
*** rajinir has quit IRC01:52
*** _hemna has quit IRC02:07
openstackgerritsean mooney proposed openstack/nova master: add StorageTransform class to prefilter  https://review.opendev.org/66584402:12
*** _hemna has joined #openstack-nova02:42
*** markvoelker has joined #openstack-nova02:46
*** mgoddard has quit IRC02:48
*** markvoelker has quit IRC02:51
*** kevinluuuuu has joined #openstack-nova02:56
*** mgoddard has joined #openstack-nova03:01
*** tristanC has quit IRC03:01
*** whoami-rajat has joined #openstack-nova03:01
*** tristanC has joined #openstack-nova03:04
*** cfriesen has quit IRC03:13
*** _hemna has quit IRC03:16
*** lbragstad has quit IRC03:26
*** markvoelker has joined #openstack-nova03:47
*** hongbin has quit IRC03:47
*** psachin has joined #openstack-nova03:50
*** markvoelker has quit IRC03:52
*** awalende has joined #openstack-nova03:56
*** udesale has joined #openstack-nova04:00
*** threestrands has joined #openstack-nova04:05
*** brinzh has joined #openstack-nova04:13
*** bhagyashris__ has joined #openstack-nova04:14
*** brinzhang has quit IRC04:17
*** awalende has quit IRC04:29
*** _hemna has joined #openstack-nova04:32
*** janki has joined #openstack-nova04:35
*** markvoelker has joined #openstack-nova04:48
*** markvoelker has quit IRC04:52
*** pcaruana has joined #openstack-nova04:56
*** awalende has joined #openstack-nova05:03
*** _hemna has quit IRC05:05
*** zzzeek has quit IRC05:07
*** awalende has quit IRC05:08
*** zzzeek has joined #openstack-nova05:08
*** rtjure has joined #openstack-nova05:24
*** ivve has quit IRC05:29
*** _hemna has joined #openstack-nova05:35
*** NobodyCam has quit IRC05:35
*** masayukig has quit IRC05:36
*** johnsom has quit IRC05:36
*** csatari has quit IRC05:36
*** NobodyCam has joined #openstack-nova05:36
*** rpittau|afk has quit IRC05:36
*** hogepodge has quit IRC05:36
*** rpittau|afk has joined #openstack-nova05:37
*** csatari has joined #openstack-nova05:37
*** masayukig has joined #openstack-nova05:37
*** hogepodge has joined #openstack-nova05:38
*** johnsom has joined #openstack-nova05:38
*** ratailor has joined #openstack-nova05:40
*** dtantsur|afk is now known as dtantsur05:42
*** Luzi has joined #openstack-nova05:44
*** brinzh has quit IRC05:47
*** brinzhang has joined #openstack-nova05:47
*** markvoelker has joined #openstack-nova05:49
*** udesale has quit IRC05:51
*** udesale has joined #openstack-nova05:52
*** markvoelker has quit IRC05:54
*** _hemna has quit IRC06:10
*** slaweq has joined #openstack-nova06:10
*** brault has joined #openstack-nova06:15
*** janki has quit IRC06:15
*** ratailor has quit IRC06:17
*** ratailor has joined #openstack-nova06:19
*** brinzhang has quit IRC06:22
*** brinzhang has joined #openstack-nova06:23
*** rpittau|afk is now known as rpittau06:28
*** igordc has quit IRC06:32
gibisean-k-mooney: regarding os-vif and osprofiler. The idea come up in neutron to profile the timing of vif plug. To be able to do that we need to make sure the osprofiler info is transferred to neutron during the vif plug. So far the patch is a PoC which is missing the neutron part. In the long run we might want to have support for osprofiling vif plug in some way06:39
*** ivve has joined #openstack-nova06:40
gibisean-k-mooney: it was also discussed yesterday on the neutron performance meeting http://eavesdrop.openstack.org/meetings/neutron_performance/2019/neutron_performance.2019-06-17-16.00.log.html#l-2006:45
*** maciejjozefczyk has joined #openstack-nova06:49
*** markvoelker has joined #openstack-nova06:50
*** hamdyk has joined #openstack-nova06:51
*** dpawlik has joined #openstack-nova06:51
*** markvoelker has quit IRC06:54
*** trident has quit IRC06:57
*** trident has joined #openstack-nova06:59
*** kevinluuuuu has quit IRC07:06
*** luksky has joined #openstack-nova07:08
*** udesale has quit IRC07:11
*** udesale has joined #openstack-nova07:11
*** _hemna has joined #openstack-nova07:11
*** _hemna has quit IRC07:16
*** tesseract has joined #openstack-nova07:24
*** helenafm has joined #openstack-nova07:26
*** jcosmao has quit IRC07:33
*** owalsh has quit IRC07:35
*** owalsh has joined #openstack-nova07:35
*** threestrands has quit IRC07:36
*** jangutter has joined #openstack-nova07:38
*** xek has joined #openstack-nova07:41
openstackgerritYongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology"  https://review.opendev.org/65871607:45
*** _hemna has joined #openstack-nova07:48
openstackgerritTakashi NATSUME proposed openstack/nova master: Fix wrong assert methods  https://review.opendev.org/66589707:49
*** ralonsoh has joined #openstack-nova07:50
*** markvoelker has joined #openstack-nova07:50
*** tssurya has joined #openstack-nova07:55
*** markvoelker has quit IRC07:55
openstackgerritYongli He proposed openstack/nova master: Add server sub-resource topology API  https://review.opendev.org/62147607:58
*** takashin has left #openstack-nova08:00
*** spsurya has joined #openstack-nova08:01
*** yan0s has joined #openstack-nova08:05
*** tetsuro has joined #openstack-nova08:14
*** ttsiouts has joined #openstack-nova08:16
openstackgerritHamdy Khader proposed openstack/nova master: OVS DPDK port representors support  https://review.opendev.org/65878508:21
*** _hemna has quit IRC08:22
*** keerthigd has joined #openstack-nova08:24
*** psachin has quit IRC08:24
*** ociuhandu has quit IRC08:25
*** ttsiouts has quit IRC08:29
*** keerthigd has quit IRC08:29
*** ttsiouts has joined #openstack-nova08:29
*** ttsiouts_ has joined #openstack-nova08:30
*** ttsiouts has quit IRC08:30
*** dklyle has quit IRC08:35
*** david-lyle has joined #openstack-nova08:35
*** priteau has joined #openstack-nova08:39
*** imacdonn has quit IRC08:40
*** imacdonn has joined #openstack-nova08:40
*** ociuhandu has joined #openstack-nova08:41
*** ociuhandu has quit IRC08:46
*** derekh has joined #openstack-nova08:47
*** tkajinam has quit IRC08:50
*** markvoelker has joined #openstack-nova08:51
*** kevinluuuuu has joined #openstack-nova08:55
*** markvoelker has quit IRC08:56
*** helenafm has quit IRC08:57
*** mdbooth has joined #openstack-nova09:03
*** ratailor has quit IRC09:14
*** damien_r has joined #openstack-nova09:14
*** damien_r has quit IRC09:15
*** ociuhandu has joined #openstack-nova09:20
*** martinkennelly has joined #openstack-nova09:20
bhagyashris__stephenfin, sean-k-mooney, alex_xu: Hi,  I have checked the replies on mailing list and encounter in issue so replied to mailing thread http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007190.html  I would like to hear your opinion.09:21
*** cdent has joined #openstack-nova09:23
*** damien_r has joined #openstack-nova09:25
*** damien_r has quit IRC09:25
openstackgerritBoxiang Zhu proposed openstack/nova master: Validate requested host/node during servers create  https://review.opendev.org/66123709:26
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552009:26
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.74: Support Specifying AZ to unshelve  https://review.opendev.org/66513609:30
*** panda|off is now known as panda09:30
*** davidsha has joined #openstack-nova09:33
stephenfinbhagyashris__: Cool, I'll reply now. What email client are you using, btw? It's not quoting replies properly, whatever it is /o\09:33
*** awalende has joined #openstack-nova09:34
*** damien_r has joined #openstack-nova09:35
*** damien_r has quit IRC09:35
bhagyashris__stephenfin:  actaully I am using outlook in browser so it's not quoting properly, sorry for inconvenience :(09:35
stephenfinbhagyashris__: All good. I was going to point this out (hard learned lesson from my Intel days) but it only applies to the desktop version https://that.guru/blog/sane-outlook/09:36
bhagyashris__stephenfin: ohh ok. Thank you !09:42
*** damien_r has joined #openstack-nova09:55
*** damien_r has quit IRC09:55
*** rcernin has quit IRC09:57
bhagyashris__stephenfin: Got your reply thank you! Just one question if operator  set only ``cpu_shared_set`` then in that case what should happen? Will it be reported as VCPU inventory or it should raise error?09:57
stephenfinIt should be ignored for VCPU calculation and a warning raised09:58
bhagyashris__On Train09:58
stephenfinIf cpu_dedicated_set is not defined, then cpu_shared_set should only be used for emulator threads09:58
stephenfinHowever, I think I addressed this in a previous email by saying it was extremely unlikely that cpu_shared_set would be defined without vcpu_pin_set, since it wouldn't offer any advantage (the emulator thread host cores would overlap with the pinned CPU host cores)09:59
bhagyashris__stephenfin: no I am talking about if operator sets only ``cpu_shared_set`` in Train on fresh compute node then it should report the VCPU inventory as per the specs10:01
*** awalende has quit IRC10:01
bhagyashris__Right?10:01
stephenfinThen the spec needs a modification. They also need to set cpu_dedicated_set, even if it's to an empty string10:01
*** awalende has joined #openstack-nova10:01
stephenfinBecause otherwise we can't tell the difference between a freshly deployed node and an upgraded node10:02
*** damien_r has joined #openstack-nova10:02
bhagyashris__stephenfin: ok means on train operator can not set the ``cpu_shared_set`` alone . If it's sets then raised the error that ``cpu_dsedoicated_set`` should be set10:03
stephenfinNot an error, a warning10:03
bhagyashris__Ok ok10:03
stephenfinStating that we are ignoring that value and are instead relying on 'vcpu_pin_set', if configured, or reporting all host cores if not10:04
stephenfinFrom the spec10:04
stephenfin"If the [compute] cpu_dedicated_set config option is not set, a warning will be logged stating that reserved_host_cpus is deprecated and that the operator should set both [compute] cpu_shared_set and [compute] cpu_dedicated_set."10:04
bhagyashris__Then in that case the inventory reported at placement side will be PCPU=0 and VCPU=010:04
*** awalende has quit IRC10:05
stephenfinNo, it'll be PCPU = (len(vcpu_pin_set) | len($total_host_cores))10:05
stephenfinand VCPU = (len(vcpu_pin_set) | len($total_host_cores)) * cpu_allocation_ratio10:05
stephenfini.e. the exact same behavior if cpu_shared_set wasn't defined10:05
stephenfinand cpu_dedicated_set wasn't defined10:06
openstackgerritzhaixiaojun proposed openstack/python-novaclient master: Modify the url of upper_constraints_file  https://review.opendev.org/66593410:06
bhagyashris__means if only the ``cpu_shared_set`` is define then in that case inventory should be reported as PCPU = (len(vcpu_pin_set) | len($total_host_cores)) and VCPU = (len(vcpu_pin_set) | len($total_host_cores)) * cpu_allocation_ratio10:08
bhagyashris__?10:09
stephenfinWhat's the question?10:10
bhagyashris__stephenfin: ^10:10
stephenfinYou seem to just be saying exactly what I just said :)10:10
bhagyashris__stephenfin: my question is if the operator set only ``cpu_shared_set`` in Train on fresh compute node then we will raise the Warning but what inventory will reported at placement side?10:11
stephenfinWhat I just said10:12
stephenfinPCPU = (len(vcpu_pin_set) | len($total_host_cores))10:12
stephenfinVCPU = (len(vcpu_pin_set) | len($total_host_cores)) * cpu_allocation_ratio10:12
bhagyashris__Ok got it10:12
sean-k-mooneyactully that is not correct10:12
bhagyashris__But if operator want to use that not as shared then in that case reporting both PCPU and VCPU the inventory is wrong IMO10:13
sean-k-mooneyif vcpu_pin_set is not defiend and cpu_dedicated_set is not defiend but cpu_shared_set is then we should only report a singel inventory of VCPU=len(cpu_share_set)10:13
stephenfinOhhh, you're right10:14
sean-k-mooneyand set the inventory allcoation raito as neeeded10:14
stephenfinSorry bhagyashris__10:14
bhagyashris__stephenfin, sean-k-mooney : yeah thats whats my understanding from the spec10:14
stephenfinYeah, I guess we'd written off the combination of cpu_shared_set being defined and vcpu_pin_set being undefined as "not gonna happen"10:15
sean-k-mooneyyes so we dont actly multiple the capasity by the allocation raition since the inventory has an allcoation ration filed seperatly as well10:15
sean-k-mooneystephenfin: cpu_share_set and vcpu_pin_set makes sense when doign cpu pinning10:16
sean-k-mooneyas the cpu_shared_set is used for emulator trheads as you know but in that case we report vcpu and pcu based on vcpu_pin_set10:17
stephenfinAgreed. I'm saying cpu_shared_set *without* vcpu_pin_set *doesn't* makes sense when doing CPU pinning10:17
sean-k-mooneywell i guess it could10:17
sean-k-mooneyno it doesnt10:17
sean-k-mooneyyou never want teh emulator thread to overlap with the cpu that you can pin too10:18
sean-k-mooneyso it only makes sense if you have use vcpu_pin_set to restic what cpus you can pin too10:18
stephenfinCorrect10:18
*** _hemna has joined #openstack-nova10:18
stephenfinIt's just annoying that we don't have a check to validate that at the moment10:18
stephenfinI wonder if we should add one and backport it?10:19
stephenfini.e. WARNING: You've set cpu_shared_set without vcpu_pin_set. This is dumb. Stop it.10:19
sean-k-mooneyso if cpu_shared_set was defined on its own then it would only make sense in train to model a host that resultss floating vms being confined to a subset of hosts10:19
sean-k-mooney:)10:20
sean-k-mooneyi like how bitchy the warning is :)10:20
sean-k-mooney+110:20
sean-k-mooneystephenfin: maybe it makes sense to write up a bunch of different configuration in an eterpad with the config args and the expect placmenet inventories which we can use as a set of functional test to implement10:22
*** ttsiouts_ has quit IRC10:23
*** ttsiouts has joined #openstack-nova10:24
bhagyashris__stephenfin, sean-k-mooney : thank you for you opinion ! I will try to push the patches ASAP. And incase any of any doubts I will ping.10:28
*** ttsiouts has quit IRC10:28
*** bhagyashris__ has quit IRC10:31
*** helenafm has joined #openstack-nova10:32
*** brinzhang has quit IRC10:32
*** derekh has quit IRC10:42
*** derekh has joined #openstack-nova10:42
*** bbowen has quit IRC10:44
openstackgerritStephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence)  https://review.opendev.org/65210410:47
openstackgerritStephen Finucane proposed openstack/nova master: tests: Use consistent URL regex substitution  https://review.opendev.org/66594910:47
*** psachin has joined #openstack-nova10:48
*** awalende has joined #openstack-nova10:50
*** awalende has quit IRC10:51
*** _hemna has quit IRC10:52
*** awalende has joined #openstack-nova10:52
*** tetsuro has quit IRC10:56
*** awalende has quit IRC10:56
*** udesale has quit IRC10:57
openstackgerritStephen Finucane proposed openstack/nova master: Integrate 'pre-commit' and deprecate 'tox -e fast8'  https://review.opendev.org/66551811:04
*** _hemna has joined #openstack-nova11:20
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove redundant group host setup  https://review.opendev.org/66595411:22
*** ratailor has joined #openstack-nova11:28
*** luksky has quit IRC11:30
openstackgerritEdward Hope-Morley proposed openstack/nova stable/stein: Fix python3 compatibility of rbd get_fsid  https://review.opendev.org/66451211:33
*** dave-mccowan has joined #openstack-nova11:36
*** awalende has joined #openstack-nova11:49
*** awalende has quit IRC11:51
*** awalende has joined #openstack-nova11:52
*** _hemna has quit IRC11:54
*** awalende has quit IRC11:55
*** luksky has joined #openstack-nova12:02
*** damien_r has quit IRC12:03
*** lpetrut has joined #openstack-nova12:05
*** bbowen has joined #openstack-nova12:05
*** mgariepy has joined #openstack-nova12:14
*** _erlon_ has joined #openstack-nova12:17
*** artom has quit IRC12:22
*** artom has joined #openstack-nova12:23
*** awalende has joined #openstack-nova12:23
*** awalende has quit IRC12:27
openstackgerritHamdy Khader proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support  https://review.opendev.org/66596512:29
*** damien_r has joined #openstack-nova12:31
*** decrypt has joined #openstack-nova12:31
*** udesale has joined #openstack-nova12:32
*** artom has quit IRC12:33
*** artom has joined #openstack-nova12:33
*** damien_r has quit IRC12:38
*** lpetrut has quit IRC12:39
*** mgariepy has quit IRC12:39
*** francoisp has joined #openstack-nova12:40
*** priteau has quit IRC12:49
openstackgerritSurya Seetharaman proposed openstack/nova master: Grab fresh info from the driver during nova start/stop actions  https://review.opendev.org/66597512:49
*** awalende has joined #openstack-nova12:53
*** markvoelker has joined #openstack-nova12:55
*** mgariepy has joined #openstack-nova12:55
*** awalende has quit IRC12:56
*** awalende has joined #openstack-nova12:58
*** markvoelker has quit IRC13:00
*** ratailor has quit IRC13:00
*** awalende has quit IRC13:02
*** awalende_ has joined #openstack-nova13:02
yonglihesean-k-mooney: clean up orphan instances, Checking instance nova metadata added: https://review.opendev.org/#/c/627765/13:03
yonglihesean-k-mooney: You might want to take a look13:03
sean-k-mooneycool jsut responding to a review but ill look at it next13:03
yongliheThanks.13:04
*** mriedem has joined #openstack-nova13:06
*** ttsiouts has joined #openstack-nova13:06
openstackgerritStephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize  https://review.opendev.org/66252213:07
openstackgerritStephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test  https://review.opendev.org/66424513:07
openstackgerritStephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper  https://review.opendev.org/66310213:07
openstackgerritStephen Finucane proposed openstack/nova master: Update docstring of 'revert_resize' function  https://review.opendev.org/66597613:07
jangutterhamdyk: I don't understand https://review.opendev.org/#/c/665965 - I don't see how it's required.13:10
yongliheadd spec "show-server-numa-topology", Got Alex's +2. Hope I can got another +2, thanks guys. https://review.opendev.org/#/c/658716/13:10
*** lbragstad has joined #openstack-nova13:11
hamdykjangutter: when we use hostdev (unmanaged device by libvirt), MAC will need to be set outside of Nova13:13
jangutterhamdyk: yes, which is why it's not used?13:13
jangutterhamdyk: for kernel TC offloads, <interface type='hostdev'> is used.13:14
hamdykwe updated the Nova patch13:14
sean-k-mooneyright but if you want to delegate the mac managment to os-vif it has to work form multiple vendors and cant depend on the presence of a biforcated driver13:15
hamdykjangutter: take a look: https://review.opendev.org/#/c/658785/13:15
hamdyksean-k-mooney: correct, so now we are setting the MAC for bifurcated drivers13:15
sean-k-mooneydo you have a follow up patch that set it for non biforcated driver like i40e13:16
hamdyksean-k-mooney: and maybe later for non-bifurcated13:16
jangutterhamdyk: you realise that introduces a race condition, right?13:17
sean-k-mooneyjangutter: it actully should not.13:17
sean-k-mooneyjangutter: we wait for os-vif to plug the vfs before we start teh vm13:17
hamdykactually we are looking into this (setting MAC for  non-biforcated driver) any insights would be great13:17
janguttersean-k-mooney: ah, so libvirt always pauses?13:18
sean-k-mooneyno we call os-vif.plug before we defien the domain in libvirt13:18
hamdykyes, libvirt waits for event that  plugging was successful13:18
sean-k-mooneyso we fully complete plug before we ever define the domain in libvirt13:18
yonglihemriedem: You have all context about this, It may easier for you than other cores. Hope you could have a time slot.  Thanks, https://review.opendev.org/#/c/658716/13:18
janguttersean-k-mooney: but on reboot? The domain is already defined?13:19
sean-k-mooneyoh hard reboot we destroy and redefine the domain13:19
*** priteau has joined #openstack-nova13:19
sean-k-mooneyon soft reboot we do not unplug the vf for qemu or ovs13:19
hamdykso we are good with the patch?13:20
sean-k-mooneynot really13:20
sean-k-mooneyi would like to check with the ovs folks first13:21
sean-k-mooneyunless we can do it in a vendor neutral way i would prefer to do it in libvirt but im open to being conviced13:21
janguttersean-k-mooney, hamdyk: what happens on upgrade? This would cause an interface type=hostdev to morph to unmanaged PCI passthrough.13:22
sean-k-mooneyif the ovs or dpdk folks are open to adding a way to set the mac via ovs in the future the im oke with the patch13:22
sean-k-mooneyjangutter: only for this once case correct13:22
sean-k-mooneythis code path will not be taken by standard sriov13:23
sean-k-mooneyi have not read the nova patch yet13:23
sean-k-mooneybut while i want to add a generic sriov driver in os-vif i have not sat down an written it yet13:23
janguttersean-k-mooney, hamdyk: there's another key point here, OpenStack is not the only user of this type of plugging, it makes sense to put the common code in libvirt.13:23
janguttersean-k-mooney, hamdyk: If it's in Nova/os-vif, I'd really like to see documentation, (it's just me), so that the reference design prevents other people from making 100 other ways of doing the same.13:24
sean-k-mooneyi can live with it being in os-vif infact it solves some race condition that libvirt creates13:25
sean-k-mooneyjangutter: we shoudl avoid libvirt ever plugging vif if we can13:25
sean-k-mooneyit creates a race between neutron and qemu that cannot be fixed in libvirt by design13:25
janguttersean-k-mooney: I agree. However, this smells more like a "port-on-the-VM" option than a "port-on-the-Switch".13:26
*** damien_r has joined #openstack-nova13:26
sean-k-mooneythe mac address13:26
*** _hemna has joined #openstack-nova13:27
sean-k-mooneyyes perhaps but in that case we would be looking at a qemu change right to set the mac13:27
janguttersean-k-mooney: yep. The confusion comes in that a "let's configure the switch" thing is conflated with "let's configure the virtual thing connected to the switch".13:27
hamdykso, if OVS/DPDK guys are planning to set the VF MAC in the near future that would be great13:27
sean-k-mooneylibvirt is not going to embed a dpdk driver and i dont really want libvirt talking to ovs13:27
janguttersean-k-mooney: agree 100%13:28
sean-k-mooneyhamdyk: im going to ask them on #openvswitch but could you send an email to the openvswich mailing list and ask? im not currently subsribed to it13:29
hamdykso we need to take care of the edge cases (upgrade, soft reboot if it is a problem)13:29
janguttersean-k-mooney: I'm definitely not opposed to this with -2, (and I'm definitely not the official gatekeeper for this decision either).13:29
sean-k-mooneyhamdyk: soft reboot is fine.13:30
sean-k-mooneyhamdyk: upgrades will not modify the xml until the guest reboots13:30
hamdyksean-k-mooney: will do send the email13:30
sean-k-mooneyif they come back and say yes we can add that feature then im ok with proceeding with your patch as a workaound in the short term if we also add a todo to consume the ovs/dpdk feature when available13:31
hamdyksean-k-mooney: so after the guest reboots, os-vif will do the plugging again then setting the MAC, correct ?13:32
sean-k-mooneyhamdyk: i need to revew the nova patch too however13:32
*** ttsiouts has quit IRC13:32
sean-k-mooneyhamdyk: on soft reboot no but it does not need too on hard reboot yes13:32
hamdykI see13:32
*** ttsiouts has joined #openstack-nova13:33
sean-k-mooneysoft reboot we just send a achi command to the guest os and dont teardown the vm13:35
*** ttsiouts_ has joined #openstack-nova13:36
sean-k-mooneyhard reboot we kill teh runnign vm. unplug all the ports and disk redeine the vm and plug all the port/disk/devices again from scratch as if it was a first boot13:36
jangutterhamdyk: You could split out the _set_config_VIFHostDevice section from https://review.opendev.org/#/c/65878513:37
*** ttsiouts has quit IRC13:37
*** pcaruana has quit IRC13:37
jangutterhamdyk: That should be pretty non-controversial.13:38
*** damien_r has quit IRC13:41
*** psachin has quit IRC13:46
*** udesale has quit IRC13:48
*** udesale has joined #openstack-nova13:49
*** mlavalle has joined #openstack-nova13:53
*** liuyulong has joined #openstack-nova13:53
*** pcaruana has joined #openstack-nova13:54
openstackgerritArtom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug  https://review.opendev.org/64488113:55
openstackgerritArtom Lifshitz proposed openstack/nova master: WIP: Include direct-physical in compute manager events check  https://review.opendev.org/66443113:55
openstackgerritArtom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events  https://review.opendev.org/66444213:55
openstackgerritJosephine Seifert proposed openstack/nova-specs master: Spec for the Nova part of Image Encryption  https://review.opendev.org/60869613:55
*** markvoelker has joined #openstack-nova13:56
*** med_ has joined #openstack-nova13:59
*** _hemna has quit IRC14:00
*** mchlumsky has joined #openstack-nova14:00
hamdykjangutter: will do14:07
*** liuyulong has quit IRC14:07
*** Luzi has quit IRC14:12
*** markvoelker has quit IRC14:15
*** _hemna has joined #openstack-nova14:15
*** liuyulong has joined #openstack-nova14:16
*** rajinir has joined #openstack-nova14:17
*** bbowen_ has joined #openstack-nova14:21
*** icarusfactor has joined #openstack-nova14:23
*** bbowen has quit IRC14:24
*** bbowen_ is now known as bbowen14:24
*** icarusfactor has quit IRC14:25
*** factor has quit IRC14:25
*** icarusfactor has joined #openstack-nova14:25
*** awalende_ has quit IRC14:27
*** dpawlik has quit IRC14:27
*** awalende has joined #openstack-nova14:27
*** priteau has quit IRC14:29
*** awalende has quit IRC14:31
*** hamdyk has quit IRC14:33
mdboothlyarwood: LGTM, but missing unit test I think.14:35
*** ttsiouts_ has quit IRC14:36
*** ttsiouts has joined #openstack-nova14:37
*** ohwhyosa has joined #openstack-nova14:38
ohwhyosaHello peoples!14:38
ohwhyosaWhat is the best way to change the keymap in spice / novnc per instance?14:38
ohwhyosaI saw the keymap param in nova.conf and I saw also that it's deprecated14:38
ohwhyosaBut that is more global14:39
ohwhyosaSay I have a french person, a german person and an american person accesing their instances, surely they can change the keympa?14:39
sean-k-mooneyohwhyosa: the best way is for them to do it in the os when they log in14:40
lyarwoodmdbooth: ack thanks14:40
lyarwoodis gerrit dying for anyone else?14:40
sean-k-mooneyohwhyosa: that or they can try and set it in there spice client14:40
*** JamesBenson has joined #openstack-nova14:40
ohwhyosasean-k-mooney, But then, for example, the cirros pass with a :) at the end becomes complicated, and if the only way they had of accessing the machine was via console they'd be screweeeed14:40
ohwhyosasean-k-mooney, Thanks anyway!14:41
ohwhyosaHmmm sean-k-mooney the spice client, the web one?14:41
*** ttsiouts has quit IRC14:41
sean-k-mooneyohwhyosa: no a desktop one14:41
sean-k-mooneyyou can install a spice client locally and use that to conect to the vm directly14:42
sean-k-mooneythat client should be able to set the keymap i think14:42
ohwhyosasean-k-mooney, great! thanks!14:42
*** priteau has joined #openstack-nova14:45
sean-k-mooneystephenfin: you worked on ^ a bit do we have any documenation that could help14:46
*** ttsiouts has joined #openstack-nova14:48
artomsean-k-mooney, errr, don't think support anything besides the webclient for SPICE14:48
artomBecause of the websocket proxy thing14:49
artomThe native client would need to understand websockets14:49
*** tssurya has quit IRC14:49
sean-k-mooneyim not sure about that i think you can get the direct socket url via the api14:50
artomIIRC you get the websocket HTTP URL14:50
sean-k-mooneybut i think you do need to configure you hosts to support it14:50
stephenfinsean-k-mooney: afaik it should be configurable via the VNC/Spice client, if said client supports such a thing14:51
sean-k-mooneymaybe im not sure i have used it with novnc in the past14:51
stephenfinnoVNC does since version 1.0, I think14:51
sean-k-mooneyartom: i would not be surprised if there are spice clients tha tsupprot websocket streams too by they way14:52
artomsean-k-mooney, maybe, but back when I tried https://review.opendev.org/#/c/442040/ there weren't14:53
sean-k-mooneyoh ok. is that just a limitation for spice? im pretty sure i have used remote viewer and other clinets to connect to no vnc in the past14:54
artomAll consoles, I think14:55
artomBecause you can't get to the compute host directly, you need to go through a proxy on the publicly accessible controller14:55
*** cfriesen has joined #openstack-nova14:55
artomAnd all of our proxies use websockets14:55
sean-k-mooney i could have been using virt-manager to connect via the host...14:55
artomTo be able to authenticate the connection first14:56
sean-k-mooneywell that the thing i thought we supported directly connecting to the host without the proxy and that was required for non web clients14:56
sean-k-mooneyanyway got to grab coffee before a meeting14:56
*** bbowen_ has joined #openstack-nova14:57
*** priteau has quit IRC14:58
*** bbowen has quit IRC14:59
*** spsurya has quit IRC15:01
ohwhyosathanks sean-k-mooney artom stephenfin !!15:03
*** eharney has quit IRC15:06
*** damien_r has joined #openstack-nova15:07
*** gyee has joined #openstack-nova15:07
Nick_AWe are trying to inject passwords and keys with libguestfs-tools. keys work fine but not passwords. tried with config drive on and off. any ideas?15:12
*** markvoelker has joined #openstack-nova15:12
*** awalende has joined #openstack-nova15:15
*** _hemna has quit IRC15:19
*** whoami-rajat has quit IRC15:21
*** mrch_ has quit IRC15:22
*** damien_r has quit IRC15:26
*** markvoelker has quit IRC15:31
*** ivve has quit IRC15:33
*** ttsiouts has quit IRC15:33
*** ttsiouts has joined #openstack-nova15:34
*** zbr|ruck is now known as zbr|brb15:34
*** hamzy_ has joined #openstack-nova15:38
openstackgerritLee Yarwood proposed openstack/nova master: libvirt: flatten rbd images when unshelving an instance  https://review.opendev.org/45788615:38
*** ttsiouts has quit IRC15:38
*** mgagne has quit IRC15:39
*** d34dh0r53 has quit IRC15:39
*** luksky has quit IRC15:39
*** davidsha has quit IRC15:39
*** NobodyCam has quit IRC15:39
*** rajinir has quit IRC15:40
*** masayukig has quit IRC15:40
*** hamzy has quit IRC15:40
*** d34dh0r53 has joined #openstack-nova15:40
*** dave-mccowan has quit IRC15:40
*** rajinir has joined #openstack-nova15:40
*** masayukig has joined #openstack-nova15:40
*** NobodyCam has joined #openstack-nova15:40
*** awalende has quit IRC15:41
*** awalende has joined #openstack-nova15:42
*** mgagne has joined #openstack-nova15:42
*** efried has quit IRC15:44
*** awalende has quit IRC15:46
Nick_Avirt-customize works, so it seems libguestfs isn't the issue15:46
*** hamzy_ is now known as hamzy15:48
*** efried has joined #openstack-nova15:49
*** awalende has joined #openstack-nova15:51
openstackgerritStephen Finucane proposed openstack/nova-specs master: Additional upgrade clarifications for cpu-resources  https://review.opendev.org/66603215:52
*** mdbooth_ has joined #openstack-nova15:55
*** gfhellma has joined #openstack-nova15:56
*** helenafm has quit IRC15:56
*** _erlon_ has quit IRC15:57
*** mdbooth has quit IRC15:58
*** mdbooth_ has quit IRC16:00
*** pcaruana has quit IRC16:01
*** igordc has joined #openstack-nova16:03
*** liuyulong has quit IRC16:04
dansmithmriedem: can you circle back to this soonishly? https://review.opendev.org/#/c/644881/16:06
mriedemhttps://www.youtube.com/watch?v=yKNQzFxV-qg16:08
mriedemmm16:09
mriedembuh16:09
mriedemsnuf16:09
dansmithhttps://www.youtube.com/watch?v=9MOAhnQbC6s16:09
mriedemNSFW16:10
*** rpittau is now known as rpittau|afk16:14
*** martinkennelly has quit IRC16:17
*** awalende has quit IRC16:19
*** awalende has joined #openstack-nova16:19
openstackgerritMatt Riedemann proposed openstack/nova master: Fix GET /servers/detail host_status performance regression  https://review.opendev.org/66604216:21
*** vishwanathj has joined #openstack-nova16:22
*** awalende has quit IRC16:23
Nick_AIs this the place to ask about nova-lxd?16:24
dansmithno.16:24
*** gfhellma_ has joined #openstack-nova16:27
sean-k-mooneyNick_A: nova-lxd is an out of tree dirver that is effectivly only supported by cannonical16:27
*** markvoelker has joined #openstack-nova16:28
Nick_Agotcha16:28
sean-k-mooneyNick_A: https://github.com/openstack/nova-lxd#support-and-discussions looks like they use #lxcontainers16:29
Nick_Ahaving trouble getting initial root passwords injected with it for lxc and with libguestfs for kvm16:29
*** gfhellma has quit IRC16:30
sean-k-mooneyNick_A: its not listed here but it does not work for libvirt lxc https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_set_admin_password16:30
sean-k-mooneyNick_A: so i would not be surprised if it was not supported for lxd also16:30
*** yan0s has quit IRC16:31
sean-k-mooneyNick_A: https://github.com/openstack/nova-lxd/blob/bbdd85d5ce70e9b959c6b70a8ebc704ae41a1a79/doc/source/support_matrix/support-matrix.ini#L245-L260 its marked as unknon in there own documuentation so i dont think its suppored16:31
sean-k-mooneyNick_A: if you are using config drive it might work https://github.com/openstack/nova-lxd/blob/d0faf787d92e20a55faf35ea6d95dd4d7ae7e598/nova/virt/lxd/driver.py#L584-L59016:32
Nick_Awe've been trying with and without config drive16:33
Nick_Areviewing your links thank you16:33
sean-k-mooneyya i would suggest using user-data and cloud init instead16:33
sean-k-mooneyfile injection is deprecated for some time now16:34
*** zbr|brb is now known as zbr|ruck16:38
*** pcaruana has joined #openstack-nova16:45
*** ricolin has quit IRC16:46
*** markvoelker has quit IRC16:46
*** cdent has quit IRC16:47
*** igordc has quit IRC16:49
*** gfhellma_ has quit IRC16:52
*** mgariepy has quit IRC16:54
*** mgariepy has joined #openstack-nova16:55
*** yikun has quit IRC16:56
*** panda has quit IRC16:56
*** altlogbot_0 has quit IRC17:00
*** gfhellma has joined #openstack-nova17:01
*** panda has joined #openstack-nova17:01
*** irclogbot_3 has quit IRC17:01
*** altlogbot_2 has joined #openstack-nova17:02
*** irclogbot_0 has joined #openstack-nova17:03
*** udesale has quit IRC17:11
*** _hemna has joined #openstack-nova17:15
*** gfhellma has quit IRC17:18
*** gfhellma has joined #openstack-nova17:18
*** mrch_ has joined #openstack-nova17:19
*** ociuhandu_ has joined #openstack-nova17:24
*** awalende has joined #openstack-nova17:24
*** dtantsur is now known as dtantsur|afk17:25
*** ociuhandu has quit IRC17:26
*** ociuhandu_ has quit IRC17:28
*** gfhellma has quit IRC17:32
*** slaweq has quit IRC17:34
artomdansmith, any chance I could get you to revisit https://review.opendev.org/#/c/644881/ hopefully one last time? I've added logging, and commented pointing out where they're happening in gate jobs. Should show that the patch works as intended and alleviate your reluctance to merge something you can't test17:35
*** igordc has joined #openstack-nova17:35
dansmithartom: I poked mriedem above to look at it17:35
dansmithartom: I will after he does17:35
artomdansmith, ack, appreciated17:35
*** mdbooth has joined #openstack-nova17:36
artomAm I the pony in this situation?17:36
artomI've been worse17:36
*** whoami-rajat has joined #openstack-nova17:37
dansmithhonestly, I have no idea17:41
*** eharney has joined #openstack-nova17:44
*** _hemna has quit IRC17:49
*** awalende has quit IRC17:55
*** awalende has joined #openstack-nova17:56
*** ralonsoh has quit IRC17:56
*** mdbooth has quit IRC17:56
*** awalende_ has joined #openstack-nova17:58
*** awalende has quit IRC17:58
*** markmcclain has quit IRC18:00
*** awalende_ has quit IRC18:02
*** markmcclain has joined #openstack-nova18:02
*** BjoernT has joined #openstack-nova18:04
*** awalende has joined #openstack-nova18:05
*** mdbooth has joined #openstack-nova18:05
*** dpawlik has joined #openstack-nova18:06
*** gfhellma has joined #openstack-nova18:09
mriedemi'm trying to get some timings on this host_status perf regression before i kill this devstack env and then i'll get on that resize revert change18:20
*** vishwanathj has quit IRC18:22
*** _hemna has joined #openstack-nova18:25
*** ociuhandu has joined #openstack-nova18:30
*** slaweq has joined #openstack-nova18:31
*** mdbooth has quit IRC18:33
*** vishwanathj has joined #openstack-nova18:35
*** awalende has quit IRC18:35
*** awalende has joined #openstack-nova18:36
*** ociuhandu has quit IRC18:39
*** awalende has quit IRC18:39
*** derekh has quit IRC18:40
*** awalende has joined #openstack-nova18:40
*** awalende has quit IRC18:43
*** pcaruana has quit IRC18:45
*** slaweq has quit IRC18:54
openstackgerritMatt Riedemann proposed openstack/nova master: Fix GET /servers/detail host_status performance regression  https://review.opendev.org/66604218:56
*** _hemna has quit IRC18:59
*** eharney has quit IRC19:01
*** pcaruana has joined #openstack-nova19:05
*** luksky has joined #openstack-nova19:05
*** vishwanathj has quit IRC19:06
*** decrypt has quit IRC19:07
*** damien_r has joined #openstack-nova19:16
*** bbowen_ has quit IRC19:16
*** damien_r has quit IRC19:16
*** damien_r has joined #openstack-nova19:17
*** efried has quit IRC19:21
openstackgerritMerged openstack/nova master: Add Migration.cross_cell_move and get_by_uuid  https://review.opendev.org/61401219:24
openstackgerritMerged openstack/nova master: Fix enabled_filters default value in admin config docs  https://review.opendev.org/66575119:24
*** JamesBenson has quit IRC19:26
*** _hemna has joined #openstack-nova19:27
*** JamesBenson has joined #openstack-nova19:27
*** awalende has joined #openstack-nova19:29
*** awalende has quit IRC19:32
*** panda has quit IRC19:33
*** JamesBenson has quit IRC19:34
*** efried has joined #openstack-nova19:35
*** JamesBenson has joined #openstack-nova19:36
openstackgerritFrançois Palin proposed openstack/nova stable/queens: Include all network devices in nova diagnostics  https://review.opendev.org/66615219:36
*** _erlon_ has joined #openstack-nova19:38
mriedemman https://review.opendev.org/#/c/644881/ is still queued after nearly 6 hours19:38
openstackgerritFrançois Palin proposed openstack/nova stable/queens: Include all network devices in nova diagnostics  https://review.opendev.org/66615219:38
*** awalende has joined #openstack-nova19:42
*** panda has joined #openstack-nova19:43
*** damien_r has quit IRC19:45
*** slaweq has joined #openstack-nova19:45
*** vishwanathj has joined #openstack-nova19:54
*** ivve has joined #openstack-nova19:55
*** gfhellma_ has joined #openstack-nova19:58
*** vishwanathj has quit IRC19:59
*** _hemna has quit IRC20:00
*** gfhellma has quit IRC20:02
*** bbowen_ has joined #openstack-nova20:13
openstackgerritMerged openstack/nova master: Deprecate RetryFilter  https://review.opendev.org/66395320:19
*** gfhellma has joined #openstack-nova20:20
*** BjoernT has quit IRC20:23
*** gfhellma_ has quit IRC20:23
mriedemartom: dansmith: well the last time i commented was PS23 and now it's at PS32 so pretty hard to do a diff (unless I eyeball the patch sets in separate tabs), but i think i've found enough to -1 for now anyway20:24
artommriedem, cheers :)20:25
artom(Whoever implements "diff of diffs" for Gerrit will have songs written about them)20:25
mriedemmostly easy stuff20:26
mriedembut you've missed some of the 35 conditionals from the existing libvirt driver _create_domain_and_network logic to determine if we should wait for events20:27
artomOh only 35?20:28
*** _hemna has joined #openstack-nova20:28
*** eharney has joined #openstack-nova20:35
*** mgariepy has quit IRC20:36
* artom won't have time to finish this now, need to think about dinner and daycare taxi20:40
*** dpawlik has quit IRC20:52
*** whoami-rajat has quit IRC20:56
*** _hemna has quit IRC21:02
*** xek has quit IRC21:15
sean-k-mooneydansmith: im pretty sure i know the answer to this but the order in which https://github.com/openstack/nova/blob/master/nova/scheduler/request_filter.py#L157-L161 is defined is not ment to change the behavior of the prefilters right?21:17
sean-k-mooneybecause if i reorder that alphabetically then it breaks unit test by changing behvior21:18
sean-k-mooneyALL_REQUEST_FILTERS = [21:19
sean-k-mooney    require_tenant_aggregate,21:19
sean-k-mooney    map_az_to_placement_aggregate,21:19
sean-k-mooney    require_image_type_support,21:19
sean-k-mooney]21:19
sean-k-mooneyworks but21:20
sean-k-mooneyLL_REQUEST_FILTERS = [21:20
sean-k-mooney    map_az_to_placement_aggregate,21:20
sean-k-mooney    require_image_type_support,21:20
sean-k-mooney    require_tenant_aggregate,21:20
sean-k-mooney]21:20
sean-k-mooneybreaks21:20
aspiersooh, interesting21:20
sean-k-mooneyyes .... that is totally the word i would use21:21
aspiers:)21:21
sean-k-mooney:021:21
sean-k-mooneyi was trying to figure out how i broke the teant az fileter with https://review.opendev.org/#/c/665775/1/nova/scheduler/request_filter.py@19521:22
sean-k-mooneybut then i just reorderd them on master and it also broke21:22
aspierssean-k-mooney: would you be able to advise me on an OVO problem?21:27
sean-k-mooneyaspiers: dansmith in case ye are wondering this aggragte https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_request_filter.py#L163-L165 gets returned here https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_request_filter.py#L177 and it should not21:27
sean-k-mooneyaspiers: i can try21:28
aspierssean-k-mooney: so neither of these approaches work https://review.opendev.org/#/c/664420/8..9/nova/virt/hardware.py21:29
aspierssean-k-mooney: and when I changed to hasattr I got a NotImplemented error from the ovo base class because image_meta.py doesn't implement obj_load_attr()21:29
aspiersI tried copying an implementation from one of the other object classes which just does setattr(self, attrname, None), but that errors because None is not a valid value for image properties21:30
aspiersI think the problem is maybe that while outside test environments, ImageMeta objects always have the "properties" property defined, inside test environments they don't21:31
sean-k-mooneyi just did  "if key in request_spec.image.properties:"21:31
sean-k-mooneybut i could be safe and use .get()21:32
aspiersno, I need to test "if properties in image"21:32
aspiersnot for some image property21:32
aspierssee https://review.opendev.org/#/c/664420/9/nova/tests/unit/virt/test_hardware.py@3650 where ImageMeta is constructed without properties21:32
aspiersthis seems common in unit tests21:32
aspiersthey don't bother to populate all the fields21:32
sean-k-mooneye.g. request_spec.get("image",{}).get("properties",{}).get(key)21:32
aspiersI already tried that, it didn't work21:33
aspierswell, I think it might have worked when starting with a request_spec21:33
sean-k-mooneyrequest_spec.get("image",{}).get("properties") will return none if its not set21:33
aspiersbut not when starting with objects.ImageMeta()21:33
sean-k-mooneyyes it will21:34
aspiersin test_hardware.py there are no request_specs21:34
sean-k-mooneythe base ovo implmentes get for all fileds21:34
mriedemwrong21:34
mriedemonly if using the DictCompatMixin21:34
aspiersI will try .get() again but I'm pretty sure I tried that already21:35
mriedem*nova/tests/unit/compute/test_compute_api.py21:35
mriedemoops21:35
mriedemNovaObjectDictCompat21:35
mriedemnot everything uses that21:35
mriedemand we actually want to ween things off relying on it21:35
aspiersAhh interesting21:35
aspiersYeah, the "object or dict" paradigm kinda seemed weird to me21:36
mriedemImageMetaProps.get is it's own special thing21:36
sean-k-mooneymriedem: ah your right its in VersionedObjectDictCompat https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L77321:36
mriedemand ImageMeta doesn't use the dict compat mixin21:36
mriedemand RequestSpec.image is an ImageMeta object21:37
mriedemso you can't do request_spec.get('image', {}).get('properties', {})21:37
sean-k-mooneyya i was actully just assuming it would always be set when we got to the request filetrs21:37
openstackgerritMatt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method  https://review.opendev.org/61403621:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add Instance.hidden field  https://review.opendev.org/63112321:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add TargetDBSetupTask  https://review.opendev.org/62789221:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask  https://review.opendev.org/63158121:38
openstackgerritMatt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask  https://review.opendev.org/63385321:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method  https://review.opendev.org/63329321:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask  https://review.opendev.org/62789021:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method  https://review.opendev.org/63483221:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image  https://review.opendev.org/63760521:38
openstackgerritMatt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask  https://review.opendev.org/62789121:38
mriedemRequestSpec.image should be set when we get to the request filters yes21:38
sean-k-mooneyso i personally was planning on jsut doing "if key in request_spec.image.properties:"21:38
aspiersThe problem I'm having is with the properties getter not being there at all, not with testing for the existence of an individual property21:40
sean-k-mooneyaspiers: in what code21:40
aspiersthe first link I pasted above21:40
dansmithsean-k-mooney: I'm really not sure what you're asking, but I can see the ordering of those needing to be specific21:40
aspiers<aspiers> sean-k-mooney: so neither of these approaches work https://review.opendev.org/#/c/664420/8..9/nova/virt/hardware.py21:40
mriedemaspiers: lots of tests don't use full objects b/c they can be a pain in the ass to construct if you don't need a full object for what you're testing,21:41
mriedemas you add code that relies on more things being set in the object, you have to adjust the tests as necessary21:41
aspiersmriedem: yes exactly, I was trying to avoid needing full objects which is why I'm running into this problem21:41
mriedemsure, so you need something like image=objects.ImageMeta(properties=objects.ImageMetaProps()))21:41
aspiersif I use "image_meta.get('properties')" as the test, I get AttributeError: 'ImageMeta' object has no attribute 'get'"21:42
mriedemyour code could be defensive and do "if 'properties' in image" but that's not really realistic21:42
aspiersAh, so I always have to construct an ImageMetaProps inside?21:42
aspiersI thought I saw existing test code which got away without doing that21:42
aspiersbut maybe it wasn't doing property lookups like my new code does21:42
mriedemif the code didn't care about accessing properties in the ImageMeta object then it didn't need to21:42
sean-k-mooneydansmith: i guess i can add a comment21:42
aspiersmriedem: OK thanks, I'll try that approach21:43
sean-k-mooneydansmith: basically i was hoping we had not wrote the filter to requrie to be run in a specifc order without documenting it21:43
sean-k-mooneydansmith: espcially when the beahvior changes21:43
sean-k-mooneydansmith: my real question is should i try to make it order independent21:44
sean-k-mooneyor should i comment that the order matters and just append my filter to the end21:44
dansmithsean-k-mooney: okay I'm not sure there are any such inter-dependencies at the moment, but I can very much imagine that there could be. it's an internal list, not a configured sequence or anything...21:44
mriedemsince those request filters can be disabled i'm not sure why order should matter - i assumed that order wouldn't matter21:44
sean-k-mooneydansmith: ther is a depenc currently21:44
dansmithmriedem: some of them cascade a bit, like the tenant aggregate one21:45
mriedembut is that a side effect of how the tests are written21:45
sean-k-mooneymriedem: no21:45
dansmithI don't understand what the big deal is, I don't think there's any promise that they are or aren't dependent,21:45
sean-k-mooneyits actully broken if reorderd21:45
dansmithso unless it breaks if you enable one and not the other and it's not documented, then I don't see the problem21:45
*** JamesBenson has quit IRC21:46
dansmithsean-k-mooney: isn't that like saying you expect you can reorder any code or method calls in other places and be surprised that it breaks?21:46
dansmithno promises means no promises21:46
dansmithif we want to have such promises, then we should document, but if not, why are you surprised?21:46
sean-k-mooneyim surprised because i understood that the filter were additive21:47
dansmiths/understood/assumed/ ?21:47
* mriedem has to leave21:47
*** mriedem is now known as mriedem_away21:47
*** tesseract has quit IRC21:47
sean-k-mooneyquickly read the code and that what it appeared to be reorded and the unit test broke21:47
dansmiththe sequence isn't mutable in a config file, so I don't see why we would make that code more complicated to handle the potential reordering of them, when it's in code21:48
sean-k-mooneythe reason we would is so that its easy to extend21:48
*** markvoelker has joined #openstack-nova21:48
dansmithsean-k-mooney: right, but if I quickly read some code and decide I should be able to reorder the code in the live migration routine, it's highly likely that tests will break right?21:48
*** ivve has quit IRC21:48
sean-k-mooneyits not the same thing21:49
dansmithwhy not?21:49
dansmithseems like exactly the same thing to me, except that you made some assumption that it shouldn't be :)21:49
sean-k-mooneymecasue these are filters that extend the request spec21:49
dansmithno,21:49
sean-k-mooneywith addtion constratits21:49
dansmiththey *mutate* the request spec21:49
sean-k-mooneyyes21:49
sean-k-mooneyadditivly21:49
dansmithso it's entirely expected, IMHO, that changing the order of a set of mutations might end up in a different result21:50
dansmithnot additively, that's your implicit assumption :)21:50
sean-k-mooneyis it expected that one that adds a constratin on an az an annothe r on a tenatn would allow an aggate that has neither the tenatn or the az set to work21:50
sean-k-mooneythat https://github.com/openstack/nova/blob/master/nova/tests/unit/scheduler/test_request_filter.py#L154 is the test that fails21:51
sean-k-mooneyaggreate 321:51
sean-k-mooney objects.Aggregate(21:51
sean-k-mooney                uuid=uuids.agg3,21:51
sean-k-mooneymetadata={'other_key': 'owner'})],21:51
sean-k-mooneyget retruned in  reqspec.requested_destination.aggregates[0]21:52
dansmiththis is precisely my point21:52
*** awalende has quit IRC21:52
sean-k-mooneywhen the order chages but we are requireing the project id and teh ax in the request spec21:52
dansmithpretty much all our unit tests assume that the code runs in a specific ordering21:52
dansmithyou think you should be able to reorder those method calls and have the tests not notice, but I have no idea why21:52
dansmithI refer back to my previous example about any random other sequence of code21:53
*** awalende has joined #openstack-nova21:53
sean-k-mooneywhat i think is broke is i think its not correctly comparing project_id='owner' to filter_tenat_id21:53
sean-k-mooneybut maybe im not understanding how that works21:53
sean-k-mooneyanyway if this is the expected behavior ill revert the ordering change and add a comment to document that the ordering is important21:55
sean-k-mooneyi have not actully read throuhg how those filters actully work line by line21:55
sean-k-mooneyso i was just comparing what i changed to determin what could have broken it and then noticed i changed the ordering and asked if it was imporant21:56
*** awalende has quit IRC21:57
*** markvoelker has quit IRC22:00
*** gfhellma_ has joined #openstack-nova22:00
*** gfhellma has quit IRC22:04
sean-k-mooneyanyway ill see if i can repoduce the same issue without reordering the filters as a sperate test.22:05
sean-k-mooneythe test code and filters seam to be working slightly differently then i thought from first reading22:06
*** slaweq has quit IRC22:08
*** mchlumsky has quit IRC22:09
*** slaweq has joined #openstack-nova22:11
*** rajinir has quit IRC22:15
*** slaweq has quit IRC22:16
*** rajinir has joined #openstack-nova22:19
*** _hemna has joined #openstack-nova22:21
*** awalende has joined #openstack-nova22:24
*** gfhellma_ has quit IRC22:25
*** gfhellma_ has joined #openstack-nova22:28
*** awalende has quit IRC22:29
*** icarusfactor has quit IRC22:34
*** icarusfactor has joined #openstack-nova22:34
openstackgerritmelanie witt proposed openstack/nova-specs master: Propose showing server status UNKNOWN when host status UNKNOWN  https://review.opendev.org/66618122:36
*** luksky has quit IRC22:47
*** _hemna has quit IRC22:48
openstackgerritSundar Nadathur proposed openstack/nova-specs master: Nova Cyborg interaction specification.  https://review.opendev.org/60395522:58
*** JamesBenson has joined #openstack-nova22:59
*** tkajinam has joined #openstack-nova23:01
*** awalende has joined #openstack-nova23:03
*** JamesBenson has quit IRC23:04
sean-k-mooneydansmith: on i figured out what was confusing me23:06
sean-k-mooneythe fitler will work in any order23:06
*** rtjure has quit IRC23:07
sean-k-mooneythe mock data we are generating in the unit test is not order indepent23:07
sean-k-mooneyi missed the fact that if you set the side_effect to an iterable then each time the mocked fucntion is called it will return the next item form that iterable so the results i was seing make sense again.23:09
dansmiththis is why I said I'm not aware of any dependencies currently, and that the test expecting that the code runs in a specific order is, you know, pretty common and not a problem to me23:10
dansmithanyway, I gotta run23:10
*** rcernin has joined #openstack-nova23:16
*** rcernin has quit IRC23:17
*** _erlon_ has quit IRC23:17
*** rcernin has joined #openstack-nova23:18
openstackgerritMerged openstack/nova master: Validate requested host/node during servers create  https://review.opendev.org/66123723:21
openstackgerritMerged openstack/nova master: docs: Remove references to nova-consoleauth  https://review.opendev.org/65296523:21
openstackgerritMerged openstack/nova master: tests: Stop starting consoleauth in functional tests  https://review.opendev.org/65296623:21
*** gfhellma_ has quit IRC23:31
*** mlavalle has quit IRC23:33
*** awalende has quit IRC23:36
*** gfhellma_ has joined #openstack-nova23:42
*** gfhellma_ has quit IRC23:49
*** gfhellma_ has joined #openstack-nova23:50
*** gfhellma_ has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!