Tuesday, 2019-07-09

*** spatel has quit IRC00:16
*** nicolasbock has quit IRC00:17
*** brinzhang has joined #openstack-nova00:19
*** tjgresha has quit IRC00:30
*** tjgresha has joined #openstack-nova00:30
*** brinzhang_ has joined #openstack-nova00:32
*** brinzhang has quit IRC00:36
*** spatel has joined #openstack-nova00:54
*** igordc has quit IRC00:59
*** hongbin has joined #openstack-nova01:03
*** sapd1 has joined #openstack-nova01:05
*** rabel has quit IRC01:06
*** rabel has joined #openstack-nova01:06
*** imacdonn has quit IRC01:13
*** imacdonn has joined #openstack-nova01:14
openstackgerritBhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API  https://review.opendev.org/61262601:23
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385101:26
*** bauzas_ has joined #openstack-nova01:29
*** artom has quit IRC01:30
*** altlogbot_0 has quit IRC01:30
*** bauzas has quit IRC01:30
*** bauzas_ is now known as bauzas01:30
*** altlogbot_1 has joined #openstack-nova01:32
*** jamesdenton has quit IRC01:32
*** jangutter has quit IRC01:33
*** jangutter has joined #openstack-nova01:33
*** hemna_ has quit IRC01:34
*** Kimmo_ has quit IRC01:35
*** adriant has joined #openstack-nova01:36
*** hemna_ has joined #openstack-nova01:38
*** _alastor_ has joined #openstack-nova01:43
*** hongbin has quit IRC01:57
openstackgerritHuachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance  https://review.opendev.org/66865602:23
*** tetsuro has joined #openstack-nova02:23
*** tbachman has quit IRC02:38
openstackgerritQiu Fossen proposed openstack/nova master: Add user_id field to the migrations records  https://review.opendev.org/66978502:52
*** yaawang has joined #openstack-nova02:55
*** tetsuro has quit IRC02:56
*** hongbin has joined #openstack-nova02:57
*** lbragstad has quit IRC02:57
*** icarusfactor has quit IRC03:03
*** whoami-rajat has joined #openstack-nova03:12
*** BjoernT has joined #openstack-nova03:17
*** hongbin has quit IRC04:04
*** udesale has joined #openstack-nova04:10
*** etp has joined #openstack-nova04:13
*** tbachman has joined #openstack-nova04:15
*** factor has joined #openstack-nova04:16
*** _alastor_ has quit IRC04:25
*** rcernin has quit IRC04:30
*** rcernin has joined #openstack-nova04:31
*** pcaruana has joined #openstack-nova04:35
*** spatel has quit IRC04:37
*** pcaruana has quit IRC04:38
*** tetsuro has joined #openstack-nova04:49
*** prometheanfire has left #openstack-nova04:56
*** gyee has quit IRC04:59
*** ileixe has quit IRC04:59
*** ileixe has joined #openstack-nova05:01
*** ileixe has quit IRC05:03
*** ileixe has joined #openstack-nova05:03
*** ricolin has joined #openstack-nova05:03
*** ccamacho has quit IRC05:06
*** ratailor has joined #openstack-nova05:17
openstackgerritMerged openstack/nova master: libvirt: manage COMPUTE_STATUS_DISABLED for hypervisor connection  https://review.opendev.org/66870705:19
*** ivve has joined #openstack-nova05:19
*** BjoernT has quit IRC05:26
*** shilpasd has quit IRC05:30
*** luksky11 has joined #openstack-nova05:30
*** Luzi has joined #openstack-nova05:37
*** ratailor has quit IRC05:38
*** shilpasd has joined #openstack-nova05:40
*** ratailor has joined #openstack-nova05:45
*** udesale has quit IRC05:48
*** ccamacho has joined #openstack-nova05:53
openstackgerritBoxiang Zhu proposed openstack/nova master: Update AZ admin doc to mention the new way to specify hosts  https://review.opendev.org/66676705:57
*** rcernin has quit IRC05:57
*** tetsuro has quit IRC05:58
*** udesale has joined #openstack-nova06:06
*** tetsuro has joined #openstack-nova06:06
openstackgerritBhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API  https://review.opendev.org/61262606:07
*** udesale has quit IRC06:09
*** udesale has joined #openstack-nova06:10
*** dpawlik has joined #openstack-nova06:19
openstackgerritguangchao.pan proposed openstack/nova master: Add a name for the automatically created volume  https://review.opendev.org/66009606:26
*** ccamacho has quit IRC06:29
*** ccamacho has joined #openstack-nova06:29
*** etp has quit IRC06:38
*** udesale has quit IRC06:40
*** cdent has joined #openstack-nova06:41
*** ociuhandu has joined #openstack-nova06:46
*** spatel has joined #openstack-nova06:48
*** ociuhandu has quit IRC06:52
*** spatel has quit IRC06:53
*** rpittau|afk is now known as rpittau06:58
*** slaweq has joined #openstack-nova07:02
*** pcaruana has joined #openstack-nova07:03
*** maciejjozefczyk has joined #openstack-nova07:05
*** ircuser-1 has joined #openstack-nova07:05
*** tssurya has joined #openstack-nova07:09
*** awalende has joined #openstack-nova07:16
*** ianw is now known as ianw_pto07:16
*** ttsiouts has joined #openstack-nova07:23
*** udesale has joined #openstack-nova07:24
*** helenafm has joined #openstack-nova07:25
*** ralonsoh has joined #openstack-nova07:30
openstackgerritBrin Zhang proposed openstack/nova master: Specify availability_zone to unshelve  https://review.opendev.org/66385107:34
*** ttsiouts has quit IRC07:38
openstackgerritLuyao Zhong proposed openstack/nova master: db: Add vpmems to instance_extra  https://review.opendev.org/66269707:39
openstackgerritLuyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs  https://review.opendev.org/63454807:39
*** brinzhang_ has quit IRC07:41
*** brinzhang_ has joined #openstack-nova07:42
*** brinzhang_ has quit IRC07:44
*** brinzhang_ has joined #openstack-nova07:44
*** priteau has joined #openstack-nova07:44
*** bhagyashris has joined #openstack-nova07:48
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.opendev.org/63795507:50
*** ratailor_ has joined #openstack-nova07:50
openstackgerritBalazs Gibizer proposed openstack/nova master: Move consts from neutronv2/api to constants module  https://review.opendev.org/66894507:50
*** belmoreira has joined #openstack-nova07:51
*** ratailor has quit IRC07:52
*** ttsiouts has joined #openstack-nova07:57
*** dtantsur|afk is now known as dtantsur07:57
*** yaawang has quit IRC08:01
*** rcernin has joined #openstack-nova08:02
openstackgerritShilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates  https://review.opendev.org/66795208:02
openstackgerritBalazs Gibizer proposed openstack/nova master: Use neutron contants in cmd/manage.py  https://review.opendev.org/66894608:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Add 'resource_request' to neutronv2/constants  https://review.opendev.org/66894708:04
openstackgerritBalazs Gibizer proposed openstack/nova master: Translatable output strings in heal allocation  https://review.opendev.org/66892508:04
*** awalende has quit IRC08:04
*** awalende has joined #openstack-nova08:05
*** rcernin has quit IRC08:11
*** ttsiouts has quit IRC08:11
*** ttsiouts has joined #openstack-nova08:12
*** ttsiouts_ has joined #openstack-nova08:13
*** ociuhandu has joined #openstack-nova08:17
*** ttsiouts has quit IRC08:17
*** panda has quit IRC08:22
*** panda has joined #openstack-nova08:24
*** brinzhang_ has quit IRC08:24
*** brinzhang has joined #openstack-nova08:25
*** rcernin has joined #openstack-nova08:27
*** yaawang has joined #openstack-nova08:42
*** tkajinam has quit IRC08:42
openstackgerritBalazs Gibizer proposed openstack/nova master: Use the safe get_binding_profile  https://review.opendev.org/66981708:42
*** priteau has quit IRC08:47
*** priteau has joined #openstack-nova08:48
*** mdbooth has joined #openstack-nova08:53
openstackgerritBalazs Gibizer proposed openstack/nova stable/rocky: Add support for osprofiler in placement wsgi  https://review.opendev.org/66783208:59
*** belmoreira has quit IRC09:05
*** belmoreira has joined #openstack-nova09:12
*** belmoreira has quit IRC09:13
*** ratailor has joined #openstack-nova09:16
*** ratailor_ has quit IRC09:18
*** yaawang has quit IRC09:18
*** yaawang has joined #openstack-nova09:23
*** mdbooth has quit IRC09:32
*** mdbooth has joined #openstack-nova09:35
*** bhagyashris has quit IRC09:43
*** pcaruana has quit IRC09:48
openstackgerritMatthew Booth proposed openstack/nova master: Whether to use config drive depends on instance.configdrive  https://review.opendev.org/48593009:55
*** ratailor_ has joined #openstack-nova09:58
*** derekh has joined #openstack-nova10:00
*** ratailor has quit IRC10:00
*** priteau has quit IRC10:03
*** tetsuro has quit IRC10:04
*** cdent has quit IRC10:07
*** nicolasbock has joined #openstack-nova10:10
*** ricolin has quit IRC10:14
*** ttsiouts_ has quit IRC10:16
*** ttsiouts has joined #openstack-nova10:17
*** cdent has joined #openstack-nova10:18
*** tetsuro has joined #openstack-nova10:21
*** ttsiouts has quit IRC10:21
*** ricolin has joined #openstack-nova10:22
*** ricolin has quit IRC10:23
*** shilpasd has quit IRC10:24
*** xek_ is now known as xek10:32
*** udesale has quit IRC10:34
*** luksky11 has quit IRC10:40
*** jamesdenton has joined #openstack-nova10:50
*** Kevin_Zheng has quit IRC10:50
*** tbachman has quit IRC10:52
*** tbachman has joined #openstack-nova10:52
*** tetsuro has quit IRC10:53
*** belmoreira has joined #openstack-nova11:01
*** shilpasd has joined #openstack-nova11:01
*** mdbooth has quit IRC11:03
*** mdbooth has joined #openstack-nova11:04
*** ttsiouts has joined #openstack-nova11:04
*** dosaboy has quit IRC11:05
*** nicolasbock has quit IRC11:06
*** dosaboy has joined #openstack-nova11:09
*** mdbooth has quit IRC11:10
*** tesseract has joined #openstack-nova11:11
*** tesseract has quit IRC11:13
*** tesseract has joined #openstack-nova11:15
*** luksky11 has joined #openstack-nova11:16
*** gokhani has quit IRC11:16
*** altlogbot_1 has quit IRC11:19
*** tssurya has quit IRC11:19
*** irclogbot_0 has quit IRC11:19
*** altlogbot_2 has joined #openstack-nova11:20
*** mdbooth has joined #openstack-nova11:22
*** zbr is now known as zbr|lunch11:22
*** tesseract has quit IRC11:23
*** altlogbot_2 has quit IRC11:25
*** mdbooth has quit IRC11:34
*** tbachman has quit IRC11:37
*** mdbooth has joined #openstack-nova11:39
*** belmoreira has quit IRC11:39
*** belmoreira has joined #openstack-nova11:43
openstackgerritBalazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations  https://review.opendev.org/63795511:43
openstackgerritBalazs Gibizer proposed openstack/nova master: Move consts from neutronv2/api to constants module  https://review.opendev.org/66894511:44
*** ricolin has joined #openstack-nova11:44
*** tetsuro has joined #openstack-nova11:44
*** ttsiouts has quit IRC11:44
openstackgerritIvaylo Mitev proposed openstack/nova master: VMware: Attach volumes using adapter type from instance  https://review.opendev.org/61659911:44
*** ttsiouts has joined #openstack-nova11:45
*** ratailor_ has quit IRC11:45
*** artom has joined #openstack-nova11:48
*** ttsiouts has quit IRC11:49
*** jistr_ has joined #openstack-nova11:51
openstackgerritBalazs Gibizer proposed openstack/nova master: Use neutron contants in cmd/manage.py  https://review.opendev.org/66894611:52
openstackgerritBalazs Gibizer proposed openstack/nova master: Use the safe get_binding_profile  https://review.opendev.org/66981711:52
*** niceplace_ has joined #openstack-nova11:52
*** belmoreira has quit IRC11:52
openstackgerritBalazs Gibizer proposed openstack/nova master: Add 'resource_request' to neutronv2/constants  https://review.opendev.org/66894711:52
openstackgerritBalazs Gibizer proposed openstack/nova master: Translatable output strings in heal allocation  https://review.opendev.org/66892511:53
*** ttsiouts has joined #openstack-nova11:53
*** kinrui has joined #openstack-nova11:53
*** udesale has joined #openstack-nova11:55
*** jistr has quit IRC11:55
*** dannins has quit IRC11:55
*** fyx has quit IRC11:55
*** markmcclain has quit IRC11:55
*** niceplace has quit IRC11:55
*** hogepodge has quit IRC11:55
*** jbernard has quit IRC11:55
*** mordred has quit IRC11:55
*** guilhermesp has quit IRC11:55
*** seyeongkim has quit IRC11:55
*** BlackDex has quit IRC11:55
*** mnasiadka has quit IRC11:55
*** kmalloc has quit IRC11:55
*** TheJulia has quit IRC11:55
*** dustinc has quit IRC11:55
*** jrosser has quit IRC11:55
*** fungi has quit IRC11:55
*** lchabert has quit IRC11:56
*** melwitt has quit IRC11:56
*** asettle-PTO has quit IRC11:56
*** belmoreira has joined #openstack-nova11:57
*** zbr|lunch is now known as zbr11:59
*** rcernin has quit IRC11:59
*** irclogbot_3 has joined #openstack-nova12:00
*** dannins has joined #openstack-nova12:01
*** fyx has joined #openstack-nova12:01
*** hogepodge has joined #openstack-nova12:01
*** jbernard has joined #openstack-nova12:01
*** mordred has joined #openstack-nova12:01
*** guilhermesp has joined #openstack-nova12:01
*** seyeongkim has joined #openstack-nova12:01
*** BlackDex has joined #openstack-nova12:01
*** mnasiadka has joined #openstack-nova12:01
*** kmalloc has joined #openstack-nova12:01
*** TheJulia has joined #openstack-nova12:01
*** dustinc has joined #openstack-nova12:01
*** jrosser has joined #openstack-nova12:01
*** lchabert has joined #openstack-nova12:01
*** weshay_PTO is now known as weshay12:01
*** altlogbot_0 has joined #openstack-nova12:02
*** tetsuro has quit IRC12:03
*** altlogbot_0 has quit IRC12:05
*** irclogbot_3 has quit IRC12:05
*** altlogbot_1 has joined #openstack-nova12:08
*** pcaruana has joined #openstack-nova12:10
*** altlogbot_1 has quit IRC12:11
*** tbachman has joined #openstack-nova12:15
*** sapd1_x has joined #openstack-nova12:20
*** kinrui is now known as fungi12:21
*** tssurya has joined #openstack-nova12:27
*** helenafm has quit IRC12:33
*** jistr_ is now known as jistr12:33
*** belmoreira has quit IRC12:42
*** helenafm has joined #openstack-nova12:44
*** belmoreira has joined #openstack-nova12:46
*** belmoreira has quit IRC12:51
*** belmoreira has joined #openstack-nova12:52
openstackgerritArthur Dayne proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication  https://review.opendev.org/62312012:53
*** altlogbot_3 has joined #openstack-nova12:54
*** altlogbot_3 has quit IRC12:57
*** sapd1_x has quit IRC13:00
openstackgerritsean mooney proposed openstack/nova master: make config drives sticky bug 1835822  https://review.opendev.org/66973813:01
openstackbug 1835822 in OpenStack Compute (nova) "vms loose acess to config drive with CONF.force_config_drive=True after hard reboot" [Medium,In progress] https://launchpad.net/bugs/1835822 - Assigned to sean mooney (sean-k-mooney)13:01
yonglihesean-k-mooney: I had finished a new logic per our discuss. Code released without unit test, so you could give advice in advance, https://review.opendev.org/#/c/627765/13:07
*** zul has joined #openstack-nova13:07
sean-k-mooneyi just finsihed ^ so i can take a look before i start my next thing13:08
openstackgerrithuanhongda proposed openstack/nova master: Fix for auth during live-migration (2)  https://review.opendev.org/66986713:10
*** mriedem has joined #openstack-nova13:13
*** priteau has joined #openstack-nova13:14
*** lbragstad has joined #openstack-nova13:15
openstackgerritMerged openstack/nova master: Remove assumption of http error if consumer not exists  https://review.opendev.org/66918813:16
yonglihesean-k-mooney, thanks, looking forward your comment. The 'reap_unknown' options seems not suitable which make that logic  mess. I just collapse the orphan instance clean up use existing 'poweroff' and 'reap' option. Cause we had filter out instance not created by nova, this might acceptably.13:23
*** maciejjozefczyk has quit IRC13:25
*** maciejjozefczyk has joined #openstack-nova13:28
yonglihe@melanie witt, I had your comments addressed mostly, please take a look, thanks.13:30
*** tbachman has quit IRC13:33
*** tbachman has joined #openstack-nova13:34
*** BjoernT has joined #openstack-nova13:34
*** brinzhang has quit IRC13:39
*** brinzhang has joined #openstack-nova13:40
*** mdbooth has quit IRC13:40
*** mdbooth has joined #openstack-nova13:40
sean-k-mooneyyonglihe: ya i think that is much closer to what i was expecting13:41
sean-k-mooneyi left some comments inline13:41
*** slaweq has quit IRC13:43
openstackgerritsean mooney proposed openstack/nova master: Whether to use config drive depends on instance.configdrive  https://review.opendev.org/48593013:43
*** ttsiouts has quit IRC13:47
*** ttsiouts has joined #openstack-nova13:47
*** slaweq has joined #openstack-nova13:49
*** belmoreira has quit IRC13:49
*** ttsiouts has quit IRC13:52
*** BjoernT has quit IRC13:52
*** belmoreira has joined #openstack-nova13:54
mriedemgmann: i'll update the policy rule name in https://review.opendev.org/#/c/645520/3313:54
*** mlavalle has joined #openstack-nova13:57
*** BjoernT has joined #openstack-nova13:57
*** Luzi has quit IRC13:57
*** ttsiouts has joined #openstack-nova13:58
*** tbachman has quit IRC14:02
*** tbachman has joined #openstack-nova14:08
openstackgerritBalazs Gibizer proposed openstack/nova master: Test heal port allocations in nova-next  https://review.opendev.org/66987914:10
mriedemi've got a series of pretty simple "implement update_provider_tree" changes for xen and hyperv here with +2s https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:update_provider_tree which eventually allows us to deprecate the non-upt compact code in the RT and lets us clean up that RT mess in U14:11
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552014:13
*** spatel has joined #openstack-nova14:14
gibimriedem: do we have somebody from xen and hyperv to ack those changes? I looked at the xen one and it seems straitforward to me but I could wait for a xen developer to ack14:17
*** mdbooth has quit IRC14:17
sean-k-mooneygibi: im not sure we have anyone maintaining xen support at the moment14:18
sean-k-mooneyout side of the core team that is14:18
*** whoami-rajat has quit IRC14:18
openstackgerritBoxiang Zhu proposed openstack/nova master: Update AZ admin doc to mention the new way to specify hosts  https://review.opendev.org/66676714:20
*** mdbooth has joined #openstack-nova14:22
gibisean-k-mooney: OK, I left my +2 on the patch.14:23
*** BlackDex has quit IRC14:25
mriedemgibi: lpetrut from hyperv already acked the hyperv one and the CI passed, and it's a cherry pick from the out-of-tree hyperv driver14:26
mriedemwe do'nt have any xen people nor ci14:26
mriedembut the xen change itself is very straightforward - just a port of get_inventory14:26
gibimriedem: I'm +A on the hyperv as I saw lpetrut vote14:26
mriedemthanks14:26
gibimriedem: OK, then I push the +A on the xen patch as well14:27
mriedemwill be nice to eventually remove the spaghetti for that stuff from the RT14:27
*** BlackDex has joined #openstack-nova14:27
gibimriedem: btw, I made my first stab at adding port healing integration test to nova-next https://review.opendev.org/669879 , Eagerly waiting for the gate to tell me why it won't work :)14:28
mriedeminteresting14:29
*** BjoernT_ has joined #openstack-nova14:30
mriedemgibi: i think you put the changes on the wrong job in zuul.yaml14:31
gibimriedem: you are right. :facepalm:14:31
*** BjoernT has quit IRC14:32
mriedemleft another comment, but nova-next isn't zuul v3 native yet,14:33
mriedembut i think you could hack the devstack plugin/services/local.conf into the nova-next job using DEVSTACK_GATE_* variables14:33
mriedemuntil we convert nova-next to zuul v314:33
*** dpawlik has quit IRC14:34
gibimriedem: thanks. I will do the translation to the old format14:34
mriedemthat's probably easier for now14:34
*** awalende has quit IRC14:34
mriedemi might tinker with converting nova-next to zuul v3 separately, i've been meaning to do that anyway14:35
*** awalende has joined #openstack-nova14:35
*** tbachman has quit IRC14:38
gibimriedem: cool, thanks for the quick review, you spared me some CI runs14:39
*** awalende has quit IRC14:39
*** belmoreira has quit IRC14:42
*** mmethot has quit IRC14:44
*** belmoreira has joined #openstack-nova14:45
sean-k-mooneymriedem: by the way we talked about actully enfroceing our policy of deprecating and removing virt drivers/backend without ci. have we pushed a patch to mark xen as deprected yet?14:46
mriedemwe merged a patch to say xen is experimental but not yet deprecated14:47
*** mmethot has joined #openstack-nova14:47
mriedemhttps://github.com/openstack/nova/commit/92c7e0e0b4fcc596e86b493aafb28ee656cb046c#diff-775c4605e52aa43e2ad8c90489216dc814:47
*** BlackDex has quit IRC14:47
sean-k-mooneyi still hope to either spend a day and fix the libvirt/lxc driver or push a patch to deprecate it.14:48
*** BlackDex has joined #openstack-nova14:48
sean-k-mooneybut ya we will still have them for train in anycase14:48
mriedemif you care about lxc then maybe follow / talk to this guy https://review.opendev.org/#/q/owner:miguel%2540midokura.com+(status:open+OR+status:merged)14:49
sean-k-mooneyoh he fixed the bug i was thinking of fixing14:50
sean-k-mooneycool14:50
*** belmoreira has quit IRC14:51
sean-k-mooneyam im not sure how much i care about it but i am somewhat nostalgic in that lxc was second technically container tech i used and it has some usecases still14:51
sean-k-mooneythe two thing i was thinking of doing was fixing that bug and trying to add a ci job14:51
sean-k-mooneybasically if we still offically support it i would like to ci it but if no one is useing it then i dont mind if its removed.14:52
*** ivve has quit IRC14:53
mriedemi had a non-voting nova-lxc ci job for it long ago and had to blacklist a lot of tempest tests and even then it would fail and the failures would snowball hard on the compute14:54
*** belmoreira has joined #openstack-nova14:54
mriedemnbd mounts and such would get messed up from what i remember14:54
mriedemwe don't officially support it btw,14:55
mriedemthere is a warning that gets logged on the start of the driver saying it's not tested14:55
sean-k-mooneyah ok well its still there and i think its more useful the uml14:55
sean-k-mooneyor some of the other non qmeu/kvm libvirt backends14:56
sean-k-mooneyanyway its a low priority14:57
openstackgerritBoxiang Zhu proposed openstack/nova master: Add host and hypervisor_hostname flag to create server  https://review.opendev.org/64552014:57
openstackgerritBoxiang Zhu proposed openstack/nova master: Update AZ admin doc to mention the new way to specify hosts  https://review.opendev.org/66676714:57
mriedemspeaking of priorities, how is that numa aware live migration series coming?14:59
*** tbachman has joined #openstack-nova15:01
mriedemcdent: did i dream this or did you at some point get nova's code coverage job working with unit + functional tests? it only runs unit tests today so we're not reporting all of the coverage.15:04
cdentI think I played with it after I got it working for placement but don't remember if it ever went beyond that. I can play with it again if that seems like a useful thing to do15:05
*** belmoreira has quit IRC15:05
mriedemi played with it at some point too and seem to remember things hanging or crashing somehow15:06
cdentlet's blame eventlet15:07
cdentwhich might mean things are different now15:08
* cdent starts it in background15:08
*** belmoreira has joined #openstack-nova15:08
mriedemright, i think i tried configuring coverage with concurrency=eventlet but that didn't help15:10
mriedemhttps://coverage.readthedocs.io/en/v4.5.x/config.html#run15:11
sean-k-mooneymriedem: its proably failing due to our use of fixture. one of the oslo libs (oslo.fixtures?) i think calles exec directly with a code object and that breaks my debugger15:14
sean-k-mooneythe coverage jobs hooks the debug entry point15:14
openstackgerritBoxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously  https://review.opendev.org/65196915:14
sean-k-mooneyits break on from oslo_utils.fixture import uuidsentinel as uuids15:15
*** _alastor_ has joined #openstack-nova15:22
mriedemi'm actually hitting errors with it trying to find the placement fixture15:25
sean-k-mooneyyep15:27
sean-k-mooneythat was the error i endup having15:27
sean-k-mooneyits in the rewrite module when its actully trying to patch stuff15:27
sean-k-mooneythe point in the code it raise the exception is actully kind of missleading but the final exception you get makes more sense15:28
sean-k-mooneyim not really sure why "from oslo_utils.fixture import uuidsentinel as uuids" has to do with placement but im guessing we are messing with some gloabl state and its not happy15:31
cdentlook at the functional job defs: you have to require placement explicitly15:32
cdenti've done that and I'm running with some moderate form of success15:32
cdentbut it's not done yet15:32
sean-k-mooneyhow do you mean15:32
mriedemdeps =15:32
mriedem  -r{toxinidir}/test-requirements.txt15:32
mriedem  git+https://opendev.org/openstack/placement#egg=openstack-placement15:32
mriedemgood call15:32
*** hamzy has quit IRC15:33
sean-k-mooneyi have placmenet in the functional-py36 env15:33
cdentwe need sean-k-mooney 's 97 million core machine, because this is so slooooow15:34
sean-k-mooneywhat did you mean by require placement explcitly15:34
mriedemcdent: do you have the c extension?15:34
mriedemcoverage --version in the venv should tell you15:34
cdentyes15:35
sean-k-mooneyi can reboot that system into linux and test some things if ye like15:36
sean-k-mooneyi was playing games on it last night so its still booted into windows15:36
cdentunit tests in RbdTestCase are blocking and timing out15:36
cdentnon-linear unit tests are funny15:37
cdentmriedem: my guess is we can make it work but might need to blacklist a few of the "funny" tests15:37
mriedemyeah, i've got it running now too15:38
mriedemusing all 8 cores...hammering15:38
cdentlibvirt _get_new_connection is another issue15:41
mriedemi wonder if that one is eventlet15:41
mriedemi haven't run with concurrency=eventlet yet15:41
cdentit is15:42
mriedemlikely need this in .coveragerc:15:42
mriedemconcurrency =15:42
mriedem  eventlet15:42
mriedem  greenlet15:42
mriedemin the [run] section15:42
cdentit gets chundered up in eventlet tpool proxy call15:42
cdentmy read on the docs was that was just for accounting15:42
cdent(and I added the eventlet bit)15:42
cdentbut not greenlet15:42
*** altlogbot_3 has joined #openstack-nova15:43
sean-k-mooneytechnically its gevent under the covers of both right15:43
*** mdbooth has quit IRC15:43
*** derekh has quit IRC15:44
*** mdbooth has joined #openstack-nova15:44
cdentmriedem: I'm going to restart mine and let it run while I'm away, will post up any findings later15:44
mriedemyup, same15:44
mriedemi could see this being a sinkhole for my day15:44
cdentindeed15:46
cdentbbl15:46
*** altlogbot_3 has quit IRC15:47
*** mdbooth has quit IRC15:49
*** helenafm has quit IRC15:52
*** priteau has quit IRC15:52
sean-k-mooneyfor what its worth i just kicked it off on the 24 core server i have. i have turned off hyper treading for reasons15:55
*** maciejjozefczyk has quit IRC15:55
*** igordc has joined #openstack-nova15:56
sean-k-mooneyhum the cover job seam to only be running the unit test15:58
sean-k-mooneyi dont see where that is set in the tox env15:59
sean-k-mooney89% is not too bad15:59
sean-k-mooneymriedem: cdent care to point out what i need to chagne to get it to run everything16:00
mriedemmine isn't done but this is what i have http://paste.openstack.org/show/754229/16:02
*** hamzy has joined #openstack-nova16:02
mriedemi've mixed some cleanups into that16:02
*** icarusfactor has joined #openstack-nova16:04
sean-k-mooneyok its re running now and ya the functional tests are now running too16:04
sean-k-mooneyactully ill add teh concurrancy stuff16:05
*** factor has quit IRC16:06
*** factor__ has joined #openstack-nova16:06
*** ivve has joined #openstack-nova16:08
*** altlogbot_3 has joined #openstack-nova16:08
*** icarusfactor has quit IRC16:08
sean-k-mooneyshould be done in another miniute or so just grabing a coffee16:09
*** BjoernT_ has quit IRC16:09
*** altlogbot_3 has quit IRC16:13
sean-k-mooneyya im seeing it stall with timeout near the end so we are not mocking something properly although it appears to be in the unit test which is weird16:13
*** BjoernT_ has joined #openstack-nova16:13
sean-k-mooneymaybe we mess up some global state in the functional tests?16:14
sean-k-mooneyi am running these under py37 which also could be related but probably not16:15
sean-k-mooneyhum it look liek the libvirt issue might be real16:18
sean-k-mooneyit looks like some of our mock dont work under python 3.7 and we actully try to connect to libvirt16:19
*** whoami-rajat has joined #openstack-nova16:21
mriedemgibi: now that you're leaving or already gone for the day, i've gone through your tests https://review.opendev.org/#/c/637955/3416:23
mriedemsean-k-mooney: i would not be surprised, probably missing the FakeLibvirtFixture somewhere16:24
mriedembecause several of the libvirt modules have a global libvirt variable which tests are supposed to stub out to be the fakelibvirt module16:25
*** irclogbot_1 has joined #openstack-nova16:25
*** belmoreira has quit IRC16:27
*** irclogbot_1 has quit IRC16:27
mriedemtest_cleanup_volumes_pending_resize is mocking the wrong thing...16:28
mriedemRBDVolumeProxy rather than RbdProxy16:28
sean-k-mooneyim seeing a whole bunch of placement time out where we call _get_guest_config which goes all the  way down to calling _connect in nova.virt.libvirt.host16:28
sean-k-mooneyya i noticed that too16:28
sean-k-mooneyim piping the full output to a file and ill through it up on google drive or something16:29
sean-k-mooneyits more or less done at this point i think just waiting for all the timeouts to fire16:29
*** factor__ has quit IRC16:29
*** factor__ has joined #openstack-nova16:30
sean-k-mooneyall the tox treads are more or less sleeping and then ever so foter a test times out and a bunch suceed16:30
sean-k-mooneytest_min_version_file_backed_bad_ram_allocation_ratio  apparently modifies teh db witout without using the right fixture16:33
*** dtantsur is now known as dtantsur|afk16:34
sean-k-mooneyso ya there are a whole bunc of not so nice errors showing up16:34
mriedemi don't see _check_file_backed_memory_support hitting the db at all16:35
sean-k-mooneymy output could be interleaved16:35
sean-k-mooneyi have a couple of things that look like this16:37
sean-k-mooneyhttp://paste.openstack.org/show/754231/16:37
*** rpittau is now known as rpittau|afk16:37
mriedemthat would be the libvirt host connection callback stuff that calls _set_host_enabled16:38
*** ccamacho has quit IRC16:38
sean-k-mooneyya which is happening because our mocking of the connection info is messed up16:38
sean-k-mooney we should be useing the fake libvirt conenction there or just mocking it out entirely sicne it a unit test16:38
mriedemi've had problems in the past with mocks on the libvirt Host stuff leading to weird intermittent failures16:39
mriedemespecially with the hasVersion type calls16:39
mriedemlike this:16:39
sean-k-mooneyya you mentioned that on my vidoe model patchs16:39
mriedemtest_swap_volume_file16:39
*** luksky11 has quit IRC16:39
mriedem@mock.patch.object(host.Host,16:39
mriedem                   'has_min_version', return_value=True)16:39
mriedemrather than mocking the drvr.host.has_min_version directly16:40
mriedem*drvr._host.has_min_version16:40
mriedemthere are a billion libvirt driver unit tests so untangling that would be pretty hard16:40
sean-k-mooneywell we could do a find an replace16:41
*** spatel has quit IRC16:41
mriedemi don't think it's that easy16:41
sean-k-mooneye.g. if there is one way we know works grep for the broken form16:41
sean-k-mooneyproably not16:41
*** eharney has joined #openstack-nova16:41
sean-k-mooneybut if you know a way that definetly works we can fix the unstable kind as we find them16:41
sean-k-mooneyis there a way we could shorten these timeout for the tests by the way?16:42
mriedemyes16:42
sean-k-mooney e.g. globaly somehow16:42
mriedemOS_TEST_TIMEOUT i think16:42
mriedemit's in tox.ini16:42
sean-k-mooneyor time out the tests them seleves16:43
sean-k-mooneythat might cause issue with some of them but it would be worth trying16:43
mriedemwell it would make this monster coverage thing fail faster yes16:44
mriedemdropping OS_TEST_TIMEOUT=60 would help16:44
sean-k-mooneyi was thinking more doing set.flags in the base test case16:44
mriedemnova.conf doesn't have anything to do with test execution timeout...16:44
*** factor__ has quit IRC16:44
sean-k-mooneyi was wondering if we could modify libvirt timeouts in nova.conf16:44
mriedemnope16:45
openstackgerritMerged openstack/nova master: Implement update_provider_tree  https://review.opendev.org/66741716:45
*** mgoddard has quit IRC16:45
*** mdbooth has joined #openstack-nova16:45
mriedemconfiguring libvirt is kind of a libvirt.conf thing right?16:45
sean-k-mooneyya i guess i think these timeout are comeing form teh python binding or the c lib rather then libvirt16:45
* mriedem gets lunch16:45
sean-k-mooneyill give it another 15mins and if its still timing out ten ill run with OS_TEST_TIMEOUT=30 currently its timing out after 160s16:47
*** _alastor_ has quit IRC16:48
*** ttsiouts has quit IRC16:48
*** mgoddard has joined #openstack-nova16:48
*** ttsiouts has joined #openstack-nova16:48
*** dpawlik has joined #openstack-nova16:49
*** mdbooth has quit IRC16:49
sean-k-mooneyactully i might make that OS_TEST_TIMEOUT=8 im not seeing any test over about 4.5 seconds16:50
sean-k-mooneyoh there is 1 at 13s16:51
*** tssurya has quit IRC16:51
*** ttsiouts has quit IRC16:53
*** _alastor_ has joined #openstack-nova16:55
dansmithartom: I assume you're working on feedback on the resize revert patches yeah?16:55
*** aarents has joined #openstack-nova16:57
*** udesale has quit IRC17:00
*** altlogbot_1 has joined #openstack-nova17:00
*** altlogbot_1 has quit IRC17:05
*** Sundar has joined #openstack-nova17:08
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: coverage job changes  https://review.opendev.org/66991217:09
*** irclogbot_2 has joined #openstack-nova17:11
openstackgerritMerged openstack/nova master: xenapi: implement update_provider_tree  https://review.opendev.org/66743517:12
openstackgerritMerged openstack/nova master: Deprecate non-update_provider_tree compat code  https://review.opendev.org/66744217:12
Sundargibi, efried: Re. https://review.opendev.org/#/c/657464/, there was some discussion over naming, which got resolved in the review of the spec https://review.opendev.org/#/c/603955/12/specs/train/approved/nova-cyborg-interaction.rst@307 . Can we resume the review of 657464?17:13
openstackgerritMerged openstack/nova master: Update COMPUTE_STATUS_DISABLED from set_host_enabled compute call  https://review.opendev.org/66874317:13
*** irclogbot_2 has quit IRC17:13
efriedSundar: As far as I'm concerned, absolutely. Not much I can do though, since I own the patch :)17:14
*** dpawlik has quit IRC17:20
*** igordc has quit IRC17:29
openstackgerritMerged openstack/nova master: Add placement request pre-filter compute_status_filter  https://review.opendev.org/66875217:31
openstackgerritMerged openstack/nova master: Refactor HostAPI.service_update  https://review.opendev.org/66875617:31
openstackgerritMerged openstack/nova master: Sync COMPUTE_STATUS_DISABLED from API  https://review.opendev.org/65459617:32
*** ralonsoh has quit IRC17:36
artomdansmith, yeah17:38
*** gyee has joined #openstack-nova17:39
*** tesseract has joined #openstack-nova17:40
dansmithcool17:41
*** hamzy has quit IRC17:47
*** hamzy has joined #openstack-nova17:52
openstackgerritMerged openstack/nova master: Follow up for pre-filter-disabled-computes series  https://review.opendev.org/66898617:54
*** luksky11 has joined #openstack-nova18:09
*** BjoernT_ has quit IRC18:09
*** eharney has quit IRC18:17
*** eharney has joined #openstack-nova18:30
*** whoami-rajat has quit IRC18:30
*** melwitt has joined #openstack-nova18:34
*** irclogbot_2 has joined #openstack-nova18:37
*** hongbin has joined #openstack-nova18:37
*** tesseract has quit IRC18:39
*** irclogbot_2 has quit IRC18:39
*** panda has quit IRC18:43
*** eharney has quit IRC18:44
*** BjoernT has joined #openstack-nova18:45
*** eharney has joined #openstack-nova18:46
*** hamzy has quit IRC18:49
*** hamzy has joined #openstack-nova18:49
mriedem+2 on the host/hypervisor_hostname on server create api change again https://review.opendev.org/#/c/645520/18:51
*** igordc has joined #openstack-nova18:55
*** ociuhandu has quit IRC19:02
*** factor has joined #openstack-nova19:06
openstackgerritMerged openstack/nova master: Cleanup quota user docs  https://review.opendev.org/66257319:13
openstackgerritMatt Riedemann proposed openstack/nova master: nova-lvm: Disable [validation]/run_validation in tempest.conf  https://review.opendev.org/66217619:16
*** panda has joined #openstack-nova19:19
openstackgerritMatt Riedemann proposed openstack/nova master: Update AZ admin doc to mention the new way to specify hosts  https://review.opendev.org/66676719:30
cdentmriedem: I think you already know this, but my coverage run locked up and stayed locked (until I forced it dead just now) in nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_check_can_live_migrate_dest_file_backed_discard_bad_libvirt19:34
mriedemi also killed mine19:37
mriedembut posted a change19:37
mriedemwhich will probably timeout :)19:37
mriedemah yeah19:39
mriedem@mock.patch.object(fakelibvirt.Connection, 'getVersion')19:39
mriedem    @mock.patch.object(fakelibvirt.Connection, 'getLibVersion')19:39
mriedembut that doesn't mock out conn = self.get_connection()19:40
*** ttsiouts has joined #openstack-nova19:43
*** belmoreira has joined #openstack-nova19:44
*** ttx has quit IRC19:49
*** Hazelesque has quit IRC19:49
*** Hazelesque has joined #openstack-nova19:49
sean-k-mooneyya i have seen the same19:50
*** ttx has joined #openstack-nova19:50
sean-k-mooneyi ws just checking it before i pip out to the shops to get dinner but i was thinking maybe we could run the test in two batchs19:51
sean-k-mooneyrun the funtional test only first then unit tests only then have coverage combine the combine the two into one set of results19:52
openstackgerritMatt Riedemann proposed openstack/nova master: libvirt: remove unused Service.get_by_compute_host mocks  https://review.opendev.org/66993419:54
*** cdent has quit IRC19:57
mriedemsean-k-mooney: huh https://github.com/nedbat/coveragepy/blob/6b72dcbd98c69a7e8c5333d2926c7f871161db7e/coverage/collector.py#L11520:01
mriedemthe docs are really not clear about that20:01
*** lbragstad has quit IRC20:02
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: coverage job changes  https://review.opendev.org/66991220:04
mriedemefried: can you re-approve https://review.opendev.org/#/c/666042/ since i just had to rebase and fix the pep8 thing due to the newly enforced hacking rules20:06
*** ivve has quit IRC20:06
efried...20:06
efrieddone20:08
*** ttsiouts has quit IRC20:09
*** ttsiouts has joined #openstack-nova20:09
mriedemthanks20:10
*** ttsiouts has quit IRC20:14
*** xek has quit IRC20:21
*** irclogbot_0 has joined #openstack-nova20:25
*** irclogbot_0 has quit IRC20:27
*** hamzy has quit IRC20:37
*** _alastor_ has quit IRC20:37
*** _alastor_ has joined #openstack-nova20:37
*** eharney has quit IRC20:37
*** _alastor1 has joined #openstack-nova20:42
*** BjoernT_ has joined #openstack-nova20:43
*** BjoernT has quit IRC20:44
*** _alastor_ has quit IRC20:44
*** ttsiouts has joined #openstack-nova20:53
*** tbachman has quit IRC20:55
*** lbragstad has joined #openstack-nova20:56
*** ttsiouts has quit IRC21:04
*** ttsiouts has joined #openstack-nova21:04
mriedemdansmith: you might have an opinion on this https://review.opendev.org/#/c/669545/21:05
dansmithhrm21:07
dansmithI hate to add a traceback, but probably makes sense in the diaper case21:07
dansmithis there a bug filed that shows what the actual issue was?21:08
dansmithbecause we should definitely not take that path and log a traceback fro anything we can handle21:08
mriedemno bug as far as i know21:09
*** ttsiouts has quit IRC21:09
mriedemlooks like something with nova - or some python-*client downstream - trying to get a response.status_code21:09
mriedemand response is None21:09
mriedemi thought of you b/c of the change i linked in there21:09
*** jmlowe has joined #openstack-nova21:10
dansmithyeah, and that case makes sense to not dump stack I think21:12
dansmithbut if we're not handling it, dumping is the right thing to do I think21:12
dansmithpoint is, I think we should make sure we've fixed the problem that this would be dumping stack for21:13
dansmithin addition to dumping stack for the future21:13
mriedemif you're +2 i'll follow your lead21:14
mriedeminto the bowels of hell21:14
*** irclogbot_3 has joined #openstack-nova21:14
dansmithcommented21:15
*** pcaruana has quit IRC21:19
*** irclogbot_3 has quit IRC21:19
*** _alastor1 has quit IRC21:21
*** Sundar has quit IRC21:21
*** belmoreira has quit IRC21:25
*** belmoreira has joined #openstack-nova21:26
openstackgerritMatt Riedemann proposed openstack/nova master: doc: Replace a wiki link with API ref guide link  https://review.opendev.org/66902721:26
openstackgerritEric Fried proposed openstack/nova master: Perf: Use dicts for ProviderTree roots  https://review.opendev.org/63722521:28
openstackgerritMatt Riedemann proposed openstack/python-novaclient master: Add a guide to add a new microversion support  https://review.opendev.org/66700221:28
openstackgerritMatt Riedemann proposed openstack/nova master: doc: Add links to novaclient contributor guide  https://review.opendev.org/66902821:36
*** belmoreira has quit IRC21:36
*** irclogbot_3 has joined #openstack-nova21:39
*** _alastor1 has joined #openstack-nova21:39
*** belmoreira has joined #openstack-nova21:42
*** irclogbot_3 has quit IRC21:43
*** donnyd is now known as donnyd_pto21:43
*** jmlowe has quit IRC21:51
*** BjoernT_ has quit IRC21:52
*** jmlowe has joined #openstack-nova21:53
*** irclogbot_1 has joined #openstack-nova21:55
*** irclogbot_1 has quit IRC21:59
*** igordc has quit IRC22:00
*** belmoreira has quit IRC22:02
*** rcernin has joined #openstack-nova22:10
*** luksky11 has quit IRC22:12
*** tbachman has joined #openstack-nova22:18
*** tbachman has quit IRC22:31
*** awalende has joined #openstack-nova22:37
efrieddustinc: Bottom SDK patch is in merge conflict, not sure when that happened. I'm going to rebase it and the placement patch and leave the ironic series to you, mkay?22:39
dustincYeah I have it taken care of in local branch, will push it this week22:39
dustincThanks for heads up22:40
openstackgerritEric Fried proposed openstack/nova master: Introduces the openstacksdk to nova  https://review.opendev.org/64366422:40
openstackgerritEric Fried proposed openstack/nova master: Use OpenStack SDK for placement  https://review.opendev.org/65602322:40
*** awalende has quit IRC22:42
efrieddustinc: ^22:44
efriedbe careful not to regress to a previous commit, then. You should pull the bottom patch and rebase your series onto it.22:44
*** altlogbot_0 has joined #openstack-nova22:45
dustincefried: hmm ok, yeah I had already rebased and resolved that conflict locally so will have to figure that out before I push then22:45
efriedright. lmk if you need help.22:46
openstackgerritMerged openstack/nova master: Fix GET /servers/detail host_status performance regression  https://review.opendev.org/66604222:49
openstackgerritMerged openstack/nova master: libvirt: remove unused Service.get_by_compute_host mocks  https://review.opendev.org/66993422:49
*** altlogbot_0 has quit IRC22:49
*** tkajinam has joined #openstack-nova22:52
*** slaweq has quit IRC22:54
*** hongbin has quit IRC22:59
*** tbachman has joined #openstack-nova23:14
openstackgerritMerged openstack/nova master: doc: Replace a wiki link with API ref guide link  https://review.opendev.org/66902723:23
*** tbachman has quit IRC23:27
*** mlavalle has quit IRC23:32
*** takashin has joined #openstack-nova23:44
openstackgerritTakashi NATSUME proposed openstack/python-novaclient master: Deprecate cells v1 and extension commands and APIs  https://review.opendev.org/66959723:56
*** hamzy has joined #openstack-nova23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!