openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a live migration regression test https://review.opendev.org/641200 | 00:04 |
---|---|---|
*** slaweq has joined #openstack-nova | 00:08 | |
*** slaweq has quit IRC | 00:13 | |
*** altlogbot_3 has joined #openstack-nova | 00:29 | |
*** zbr has quit IRC | 00:34 | |
*** altlogbot_3 has quit IRC | 00:37 | |
*** zbr has joined #openstack-nova | 00:44 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression https://review.opendev.org/669958 | 00:59 |
*** mriedem has quit IRC | 00:59 | |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression https://review.opendev.org/669958 | 01:01 |
*** altlogbot_1 has joined #openstack-nova | 01:07 | |
*** tbachman has joined #openstack-nova | 01:08 | |
*** imacdonn has quit IRC | 01:13 | |
*** imacdonn has joined #openstack-nova | 01:14 | |
*** altlogbot_1 has quit IRC | 01:15 | |
openstackgerrit | Merged openstack/python-novaclient master: Add irrelevant files in dsvm job again https://review.opendev.org/668293 | 01:20 |
*** gyee has quit IRC | 01:22 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269 | 01:27 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656 | 01:27 |
*** tetsuro has joined #openstack-nova | 01:47 | |
*** lbragstad has quit IRC | 01:57 | |
*** Kevin_Zheng has joined #openstack-nova | 02:08 | |
*** altlogbot_0 has joined #openstack-nova | 02:19 | |
*** irclogbot_3 has joined #openstack-nova | 02:19 | |
openstackgerrit | Luyao Zhong proposed openstack/nova-specs master: update spec: virtual persistent memory https://review.opendev.org/669970 | 02:23 |
*** altlogbot_0 has quit IRC | 02:25 | |
*** irclogbot_3 has quit IRC | 02:26 | |
*** tkajinam has quit IRC | 02:29 | |
*** tkajinam has joined #openstack-nova | 02:29 | |
*** factor has quit IRC | 02:34 | |
*** factor has joined #openstack-nova | 02:35 | |
*** awalende has joined #openstack-nova | 02:36 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963 | 02:38 |
*** awalende has quit IRC | 02:41 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969 | 02:42 |
*** psachin has joined #openstack-nova | 03:03 | |
*** dklyle has quit IRC | 03:19 | |
*** tetsuro has quit IRC | 03:29 | |
openstackgerrit | Li Liu proposed openstack/nova master: Added Cyborg accelerator external events to Nova https://review.opendev.org/669975 | 03:36 |
*** Li_Liu has joined #openstack-nova | 03:41 | |
*** tetsuro has joined #openstack-nova | 03:57 | |
*** irclogbot_3 has joined #openstack-nova | 04:07 | |
*** bhagyashris has joined #openstack-nova | 04:09 | |
*** irclogbot_3 has quit IRC | 04:12 | |
*** altlogbot_1 has joined #openstack-nova | 04:13 | |
*** altlogbot_1 has quit IRC | 04:17 | |
*** spatel has joined #openstack-nova | 04:22 | |
*** _alastor1 has quit IRC | 04:25 | |
*** udesale has joined #openstack-nova | 04:27 | |
*** spatel has quit IRC | 04:30 | |
*** factor has quit IRC | 04:36 | |
*** whoami-rajat has joined #openstack-nova | 04:52 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Add VirtualPMEM and VirtualPMEMList objs https://review.opendev.org/634548 | 05:00 |
*** dannins has quit IRC | 05:03 | |
*** altlogbot_2 has joined #openstack-nova | 05:03 | |
*** irclogbot_2 has joined #openstack-nova | 05:07 | |
*** ratailor has joined #openstack-nova | 05:11 | |
*** altlogbot_2 has quit IRC | 05:21 | |
*** irclogbot_2 has quit IRC | 05:22 | |
*** ratailor has quit IRC | 05:30 | |
*** ratailor has joined #openstack-nova | 05:32 | |
*** janki has joined #openstack-nova | 05:33 | |
*** pcaruana has joined #openstack-nova | 05:37 | |
*** Luzi has joined #openstack-nova | 05:43 | |
*** belmoreira has joined #openstack-nova | 05:52 | |
*** lei-zh has joined #openstack-nova | 05:56 | |
*** lei-zh has quit IRC | 05:58 | |
*** lei-zh has joined #openstack-nova | 05:59 | |
openstackgerrit | Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969 | 06:05 |
*** rcernin has quit IRC | 06:10 | |
*** rcernin has joined #openstack-nova | 06:11 | |
*** pcaruana has quit IRC | 06:20 | |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 06:27 |
openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245 | 06:27 |
*** lei-zh1 has joined #openstack-nova | 06:29 | |
*** lei-zh has quit IRC | 06:31 | |
*** luksky11 has joined #openstack-nova | 06:37 | |
*** janki has quit IRC | 06:40 | |
*** dpawlik has joined #openstack-nova | 06:44 | |
*** xek has joined #openstack-nova | 06:48 | |
*** Dinesh_Bhor has quit IRC | 06:50 | |
*** slaweq has joined #openstack-nova | 06:54 | |
*** janki has joined #openstack-nova | 06:57 | |
*** gokhani has joined #openstack-nova | 07:00 | |
*** ivve has joined #openstack-nova | 07:02 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 07:03 |
*** altlogbot_2 has joined #openstack-nova | 07:03 | |
*** rpittau|afk is now known as rpittau | 07:04 | |
*** maciejjozefczyk has joined #openstack-nova | 07:04 | |
openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates https://review.opendev.org/667952 | 07:05 |
*** lei-zh1 has quit IRC | 07:05 | |
*** lei-zh1 has joined #openstack-nova | 07:06 | |
*** altlogbot_2 has quit IRC | 07:08 | |
*** lei-zh has joined #openstack-nova | 07:08 | |
*** awalende has joined #openstack-nova | 07:10 | |
*** lei-zh1 has quit IRC | 07:10 | |
*** tssurya has joined #openstack-nova | 07:13 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova master: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/669993 | 07:18 |
*** kaisers has quit IRC | 07:24 | |
*** ttsiouts has joined #openstack-nova | 07:26 | |
*** belmoreira has quit IRC | 07:27 | |
*** helenafm has joined #openstack-nova | 07:27 | |
*** tetsuro has quit IRC | 07:30 | |
*** ratailor has quit IRC | 07:36 | |
*** kaisers has joined #openstack-nova | 07:36 | |
*** ratailor has joined #openstack-nova | 07:37 | |
*** ttsiouts has quit IRC | 07:37 | |
*** ttsiouts has joined #openstack-nova | 07:38 | |
*** brinzhang_ has joined #openstack-nova | 07:38 | |
openstackgerrit | Alexandre arents proposed openstack/nova master: Do not update root_device_name during guest config https://review.opendev.org/670000 | 07:38 |
*** ratailor_ has joined #openstack-nova | 07:39 | |
*** irclogbot_3 has joined #openstack-nova | 07:39 | |
*** brinzhang has quit IRC | 07:41 | |
*** ratailor has quit IRC | 07:41 | |
*** ttsiouts has quit IRC | 07:43 | |
*** kaisers has quit IRC | 07:43 | |
*** irclogbot_3 has quit IRC | 07:44 | |
*** cdent has joined #openstack-nova | 07:45 | |
*** kaisers has joined #openstack-nova | 07:48 | |
*** traskat has joined #openstack-nova | 07:52 | |
*** ttsiouts has joined #openstack-nova | 07:54 | |
*** pcaruana has joined #openstack-nova | 07:54 | |
*** mkrai_ has joined #openstack-nova | 07:58 | |
*** belmoreira has joined #openstack-nova | 07:58 | |
*** takashin has left #openstack-nova | 08:00 | |
openstackgerrit | Yongli He proposed openstack/nova master: Clean up orphan instances virt driver https://review.opendev.org/648912 | 08:09 |
openstackgerrit | Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765 | 08:09 |
*** umbSublime has quit IRC | 08:13 | |
*** ralonsoh has joined #openstack-nova | 08:13 | |
*** tkajinam has quit IRC | 08:14 | |
*** umbSublime has joined #openstack-nova | 08:16 | |
*** priteau has joined #openstack-nova | 08:18 | |
alex_xu | bauzas: do we have a short race window between allocate the gpu mdev and create the domain in the libvirt https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3235 ? | 08:19 |
alex_xu | bauzas: I'm reviewing the vpmem patches, and thinking of where we should allocate the actual device | 08:19 |
*** dtantsur|afk is now known as dtantsur | 08:19 | |
*** derekh has joined #openstack-nova | 08:20 | |
bauzas | alex_xu: AFAIK nope, because we already synchronize https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1865 | 08:21 |
bauzas | it calls https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1873 which eventually calls spawn() https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2251 | 08:22 |
alex_xu | bauzas: that is for avoid mulitple action for a singple instance, but if there are multiple instances are creating at same time | 08:22 |
bauzas | mmmm you're right | 08:24 |
alex_xu | bauzas: it is only protected by https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6415 | 08:24 |
bauzas | yup indeed | 08:24 |
alex_xu | bauzas: but there still have a small window between https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3235 and https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3241 | 08:25 |
bauzas | alex_xu: sure but we only assigned the mdev in the synchronized method | 08:26 |
bauzas | then we only define the XML | 08:26 |
bauzas | so two instances would have different mdevs | 08:26 |
bauzas | two concurrent* | 08:26 |
*** mdbooth has joined #openstack-nova | 08:27 | |
alex_xu | bauzas: but the available device is calculated by all - free, the assigned device is get by list all the libvirt domain | 08:28 |
alex_xu | so both two instances get the available devices by listing existed domain in the libvirt, and may get the same dev | 08:28 |
alex_xu | bauzas: here is the code for populate the mdev devices https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6306 | 08:29 |
alex_xu | s/all - free/all - assigned/ | 08:29 |
bauzas | alex_xu: oh shit you're right | 08:29 |
bauzas | given we're defining the XML out of that semaphore, the assigned mdev couldn't be seen concurrently | 08:30 |
bauzas | excellent point | 08:30 |
bauzas | alex_xu: worth shouting a patch ? or want me to do so ? | 08:30 |
alex_xu | bauzas: you can fix that if you want, actually I'm looking for a solution for pmem | 08:30 |
alex_xu | bauzas: also do we support resize for the instance with vgpu? | 08:31 |
bauzas | alex_xu: I'm working on it | 08:32 |
bauzas | alex_xu: I have a patch up | 08:32 |
bauzas | but I need to work on revert_resize too | 08:32 |
alex_xu | bauzas: where are you claim the mdev? | 08:32 |
bauzas | alex_xu: first, something is missing https://review.opendev.org/#/c/589085/ | 08:33 |
alex_xu | bauzas: that doesn't include the mdev claim | 08:34 |
alex_xu | so I'm thinking whether we should manage those device in the resource tracker instead of virt driver | 08:34 |
alex_xu | s/manage those device/tracking those resource/ | 08:34 |
bauzas | sorry in meeting | 08:36 |
alex_xu | bauzas: no worries, catch up you later | 08:37 |
*** janki has quit IRC | 08:43 | |
*** janki has joined #openstack-nova | 08:51 | |
*** helenafm has quit IRC | 08:53 | |
*** irclogbot_3 has joined #openstack-nova | 08:57 | |
*** helenafm has joined #openstack-nova | 08:58 | |
*** irclogbot_3 has quit IRC | 09:02 | |
*** ccamacho has joined #openstack-nova | 09:03 | |
*** janki has quit IRC | 09:07 | |
bauzas | alex_xu: I'm back | 09:07 |
bauzas | alex_xu: so, we don't technically claim mdevs | 09:08 |
bauzas | alex_xu: as we do with PCI devices | 09:08 |
openstackgerrit | huanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration https://review.opendev.org/670016 | 09:08 |
*** ociuhandu has joined #openstack-nova | 09:09 | |
*** janki has joined #openstack-nova | 09:09 | |
*** belmoreira has quit IRC | 09:12 | |
*** altlogbot_0 has joined #openstack-nova | 09:12 | |
*** altlogbot_0 has quit IRC | 09:14 | |
*** rcernin has quit IRC | 09:17 | |
openstackgerrit | huanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration https://review.opendev.org/670016 | 09:18 |
*** lei-zh has quit IRC | 09:25 | |
*** altlogbot_0 has joined #openstack-nova | 09:26 | |
*** altlogbot_0 has quit IRC | 09:28 | |
*** belmoreira has joined #openstack-nova | 09:28 | |
*** altlogbot_1 has joined #openstack-nova | 09:29 | |
*** belmoreira has quit IRC | 09:29 | |
*** priteau has quit IRC | 09:30 | |
*** belmoreira has joined #openstack-nova | 09:30 | |
*** lei-zh has joined #openstack-nova | 09:31 | |
*** altlogbot_1 has quit IRC | 09:34 | |
openstackgerrit | Merged openstack/nova master: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/669993 | 09:35 |
*** irclogbot_1 has joined #openstack-nova | 09:38 | |
*** mdbooth has quit IRC | 09:39 | |
*** mdbooth has joined #openstack-nova | 09:40 | |
*** irclogbot_1 has quit IRC | 09:40 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configures PMEM namespace https://review.opendev.org/634549 | 09:44 |
*** altlogbot_3 has joined #openstack-nova | 09:45 | |
*** altlogbot_3 has quit IRC | 09:50 | |
alex_xu | bauzas: yes, mdevs needn't claim, you can free to choice any one of free mdevs | 09:58 |
alex_xu | bauzas: vpmem needs the claim, since we need to copy the vpmem data to the destination vpmem | 09:59 |
openstackgerrit | Qiu Fossen proposed openstack/nova master: Correct project/user id descriptions with nova-server-actions https://review.opendev.org/670027 | 10:08 |
*** mkrai_ has quit IRC | 10:17 | |
*** belmoreira has quit IRC | 10:20 | |
*** IvensZambrano has joined #openstack-nova | 10:20 | |
*** irclogbot_1 has joined #openstack-nova | 10:23 | |
*** irclogbot_1 has quit IRC | 10:26 | |
*** artom has quit IRC | 10:27 | |
*** lei-zh has quit IRC | 10:30 | |
*** lei-zh has joined #openstack-nova | 10:30 | |
*** ttsiouts has quit IRC | 10:33 | |
*** ttsiouts has joined #openstack-nova | 10:34 | |
*** mdbooth has quit IRC | 10:35 | |
*** mdbooth has joined #openstack-nova | 10:35 | |
*** lei-zh has quit IRC | 10:35 | |
*** ttsiouts has quit IRC | 10:38 | |
*** shilpasd has quit IRC | 10:38 | |
*** helenafm has quit IRC | 10:40 | |
*** helenafm has joined #openstack-nova | 10:43 | |
*** helenafm has quit IRC | 10:53 | |
*** helenafm has joined #openstack-nova | 10:55 | |
*** janki has quit IRC | 10:55 | |
*** bhagyashris has quit IRC | 10:55 | |
*** belmoreira has joined #openstack-nova | 10:56 | |
*** mdbooth has quit IRC | 11:06 | |
*** ttsiouts has joined #openstack-nova | 11:07 | |
*** tesseract has joined #openstack-nova | 11:08 | |
*** mdbooth has joined #openstack-nova | 11:13 | |
*** mkrai_ has joined #openstack-nova | 11:15 | |
*** francoisp has quit IRC | 11:25 | |
*** francoisp has joined #openstack-nova | 11:27 | |
openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Add conf to not update to placement during instance_claim https://review.opendev.org/670041 | 11:36 |
*** mdbooth_ has joined #openstack-nova | 11:45 | |
*** mdbooth has quit IRC | 11:49 | |
*** mdbooth_ has quit IRC | 11:51 | |
*** udesale has quit IRC | 11:51 | |
*** udesale has joined #openstack-nova | 11:52 | |
*** mdbooth has joined #openstack-nova | 11:59 | |
openstackgerrit | huanhongda proposed openstack/nova stable/pike: [Stable Only] libvirt: Handle volume API failure in post_live_migration https://review.opendev.org/670016 | 11:59 |
*** tbachman has quit IRC | 12:01 | |
*** mdbooth_ has joined #openstack-nova | 12:01 | |
*** mdbooth has quit IRC | 12:04 | |
*** mdbooth_ has quit IRC | 12:06 | |
*** ratailor_ has quit IRC | 12:07 | |
*** belmoreira has quit IRC | 12:17 | |
*** belmoreira has joined #openstack-nova | 12:21 | |
*** spatel has joined #openstack-nova | 12:23 | |
*** spatel has quit IRC | 12:23 | |
*** mchlumsky has joined #openstack-nova | 12:33 | |
*** artom has joined #openstack-nova | 12:34 | |
*** eharney has joined #openstack-nova | 12:37 | |
*** mchlumsky has quit IRC | 12:47 | |
*** priteau has joined #openstack-nova | 12:47 | |
*** mdbooth has joined #openstack-nova | 12:48 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Defaults missing group_policy to 'none' https://review.opendev.org/657796 | 12:48 |
*** mchlumsky has joined #openstack-nova | 12:49 | |
*** belmoreira has quit IRC | 12:54 | |
*** mdbooth_ has joined #openstack-nova | 12:56 | |
*** mdbooth_ has quit IRC | 12:56 | |
*** irclogbot_1 has joined #openstack-nova | 13:07 | |
*** irclogbot_1 has quit IRC | 13:08 | |
*** altlogbot_1 has joined #openstack-nova | 13:11 | |
*** spatel has joined #openstack-nova | 13:14 | |
*** lbragstad has joined #openstack-nova | 13:16 | |
*** altlogbot_1 has quit IRC | 13:16 | |
*** irclogbot_3 has joined #openstack-nova | 13:17 | |
*** belmoreira has joined #openstack-nova | 13:18 | |
*** tbachman has joined #openstack-nova | 13:18 | |
*** irclogbot_3 has quit IRC | 13:22 | |
*** _alastor1 has joined #openstack-nova | 13:22 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Make sure update resource usage when revert_resize https://review.opendev.org/665138 | 13:26 |
*** mkrai_ has quit IRC | 13:28 | |
*** mriedem has joined #openstack-nova | 13:31 | |
*** belmoreira has quit IRC | 13:32 | |
*** belmoreira has joined #openstack-nova | 13:33 | |
*** belmoreira has quit IRC | 13:41 | |
*** belmoreira has joined #openstack-nova | 13:45 | |
sean-k-mooney | mriedem: mind if i push a slightly modified version of your coverage patch | 13:49 |
sean-k-mooney | i have a version that mostly works | 13:49 |
openstackgerrit | Takashi NATSUME proposed openstack/nova stable/stein: doc: Fix a parameter of NotificationPublisher https://review.opendev.org/670064 | 13:50 |
sean-k-mooney | we only get an extra 2% form the functional test by the way | 13:50 |
sean-k-mooney | TOTAL 82128 5924 24452 2240 91% | 13:50 |
yonglihe | sean-k-mooney, thanks for the review. For a instance is deleted, checking the states is not reliable at least for test case it's not correct. The instance.Destroy action call DB delete, which then make the instance.id attr gone. Instance.id not exist means the instance is 'deleted'. | 13:51 |
sean-k-mooney | yonglihe: your current code can delete active instnces | 13:51 |
yonglihe | that what i'm talking about. | 13:52 |
yonglihe | https://www.irccloud.com/pastebin/BSYfEoER/ | 13:52 |
yonglihe | "not instance.obj_attr_is_set('id')" means instance is deleted. | 13:52 |
mriedem | sean-k-mooney: sure | 13:53 |
sean-k-mooney | yonglihe: im not sure that is correct | 13:53 |
mriedem | sean-k-mooney: btw i meant to split that out to do some of the cleanup stuff separately and only try to merge the functional tests in at the end | 13:53 |
mriedem | sean-k-mooney: i can do that split after you update it | 13:53 |
mriedem | i basically wanted to fire and forget yesterday | 13:53 |
*** whoami-rajat has quit IRC | 13:54 | |
sean-k-mooney | well this is actully the diff i was going to push http://paste.openstack.org/show/754262/ | 13:54 |
*** _alastor1 has quit IRC | 13:54 | |
*** whoami-rajat has joined #openstack-nova | 13:54 | |
sean-k-mooney | we cant remove the python hack entirely as running stestr on its own does not record any coverage info | 13:55 |
sean-k-mooney | the -p groups parrallel test by class | 13:55 |
sean-k-mooney | this gets rid of almost all the mocking issues | 13:55 |
sean-k-mooney | i have only 4 failing tests with that | 13:56 |
mriedem | go ahead and push it | 13:56 |
*** BjoernT has joined #openstack-nova | 13:56 | |
cdent | shouldn't we not mask the mocking problems, and fix them instead? | 13:56 |
sean-k-mooney | sure will do | 13:56 |
*** shilpasd has joined #openstack-nova | 13:56 | |
mriedem | i'm doing stable release reviews while tony is on vacation.... | 13:56 |
mriedem | so i'm going to be stuck for awhile | 13:56 |
yonglihe | sean-k-mooney, check this line: https://github.com/openstack/nova/blob/de31466fdb09dd367b23660f71b4ca06f83271a2/nova/objects/instance.py#L611 | 13:56 |
sean-k-mooney | cdent: we should but it proably better to do that after getting the test running | 13:56 |
yonglihe | I'm not sure either. | 13:56 |
yonglihe | seems correct. | 13:56 |
cdent | sean-k-mooney: i was assuming that the test failing was the only way of identifying the failures. tdd and all that | 13:57 |
*** mdbooth has quit IRC | 13:57 | |
*** mkrai_ has joined #openstack-nova | 13:57 | |
sean-k-mooney | cdent we can remove the -p to get them to fail again in the patch that fixes them | 13:57 |
cdent | or we will just ignore it for a few more years :) | 13:58 |
sean-k-mooney | well if its not broke... | 13:58 |
*** mdbooth has joined #openstack-nova | 13:58 | |
cdent | would love to continue talking about this, but unfortunately must head ot appt | 13:58 |
aarents | Hi there, it will be great if someone can have a look to this reproducible bug and related fix: https://review.opendev.org/#/c/670000 | 13:59 |
yonglihe | fake-db does had this behavior for deleted instance, and i also saw while deleted, we save instance.id to instance.delete filed. | 13:59 |
sean-k-mooney | there is a test isolation analasys flag in stestr to figure out what test cause issues | 13:59 |
sean-k-mooney | so im hoping i can just let that run and get a list of the broken tests | 13:59 |
*** cdent has quit IRC | 14:00 | |
yonglihe | sean-k-mooney: I did not got time to test that on machine. I gonna do smoke test tomorrow to make sure it won't delete active instance. Other comments seems reasonable and good, thanks. | 14:01 |
sean-k-mooney | ok i didnt run it locally to test. but that was the main reason for the -1 | 14:03 |
yonglihe | and here is another wired thing i running into. for the unit test | 14:03 |
yonglihe | https://www.irccloud.com/pastebin/Fep61BPV/ | 14:03 |
yonglihe | the assert_calls say 'Calls not found.' | 14:04 |
*** dklyle has joined #openstack-nova | 14:04 | |
sean-k-mooney | by the way an instance not having id set does not mean its deleted it means it has not be created in the db | 14:04 |
yonglihe | but the instance in expect and actual actually just same (but might had wrong order). | 14:05 |
sean-k-mooney | or nolonger exists in the db | 14:05 |
yonglihe | sean-k-mooney: Is it possible only database know what is deleted? and we can not get that information from the instance ? | 14:06 |
sean-k-mooney | anyway that sinip is a little hard to read but you can proably do an order independ check if that is not important | 14:06 |
yonglihe | sean-k-mooney : i don't find one to ignore the order. | 14:07 |
sean-k-mooney | you would have to write it. just asser the call object is in the mock.calls array | 14:07 |
sean-k-mooney | but you would have to construct a mock call object to do that | 14:08 |
yonglihe | replace wiht assert_called_with also does not work, assert_called_with still checking the order, that's so wired for me. | 14:08 |
sean-k-mooney | normally we want the order to be checked | 14:08 |
sean-k-mooney | we have some examples of doing order independ dict comparisons i think | 14:09 |
yonglihe | seems i had to assert the call is in that array. | 14:09 |
sean-k-mooney | https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_has_calls | 14:10 |
yonglihe | I would like to find the example, that's should work. but checking if instance is deleted seems hard? any other condition i can check? | 14:10 |
sean-k-mooney | you can do mock.assert_has_calls(calls, any_order=True) | 14:11 |
yonglihe | sean-k-mooney: thanks, got it. | 14:11 |
*** ttsiouts has quit IRC | 14:11 | |
*** ttsiouts has joined #openstack-nova | 14:12 | |
sean-k-mooney | if you use assert_has_calls you have to create teh mock calls manually like this https://github.com/openstack/nova/blob/de31466fdb09dd367b23660f71b4ca06f83271a2/nova/tests/unit/utils.py#L323-L336 | 14:12 |
sean-k-mooney | here are some example you can follow https://github.com/openstack/nova/search?q=assert_has_calls+any_order%3DTrue&unscoped_q=assert_has_calls+any_order%3DTrue | 14:14 |
*** ttsiouts has quit IRC | 14:16 | |
yonglihe | thanks. for the 'delete' states, i think the 'deleted_at' filed been set seems could filter out the instance is creating at that moment. | 14:17 |
*** jdillaman has joined #openstack-nova | 14:18 | |
yonglihe | 'no id attr' and 'deleted_at' is set before now. | 14:18 |
sean-k-mooney | perhap but again i would use the instance status personally unless you have an example where that does not work | 14:18 |
*** awalende has quit IRC | 14:19 | |
yonglihe | not work in the unite test, that's why i checking other stuff. but the unit test just call the destroy, not set the states right. | 14:19 |
*** awalende has joined #openstack-nova | 14:20 | |
sean-k-mooney | yonglihe: then why not fix the unit tests | 14:20 |
sean-k-mooney | anyway ill leave it up to you | 14:20 |
yonglihe | Sure. do we need checking other stuff if we depend on he vm_state filed? | 14:21 |
sean-k-mooney | leave a comment in the next version based on your testing | 14:21 |
yonglihe | Sure. | 14:21 |
sean-k-mooney | e.g. why you are doing whatever test you come up with | 14:21 |
*** ttsiouts has joined #openstack-nova | 14:22 | |
sean-k-mooney | im not sure but i need to go work on somehting before a meeting soon | 14:23 |
yonglihe | I gonna to verify if that code working on real stack. thanks. I got to run also. | 14:23 |
sean-k-mooney | i think the task state + checking for soft delete would be enough | 14:23 |
yonglihe | Ok , i gonna checking that, | 14:23 |
yonglihe | Have a good day. | 14:24 |
*** awalende has quit IRC | 14:24 | |
*** dklyle has quit IRC | 14:30 | |
sean-k-mooney | johnthetubaguy: by the way i -1 the unifed limits spec but if just declare the discoverablity as out of scope to be resolved in a futrue version of the sdk or in a follow up spec then im fine to swap to +1 on that spec | 14:32 |
sean-k-mooney | once the nits inline are adressed that is | 14:32 |
*** mkrai_ has quit IRC | 14:32 | |
johnthetubaguy | sean-k-mooney: cool, I will respin | 14:33 |
*** mkrai_ has joined #openstack-nova | 14:33 | |
sean-k-mooney | is it safe to assume that the keysone limits api wont have limits for compute resouces if we have not enabled it for nova | 14:34 |
sean-k-mooney | if so the sdk could check that once an cache it or something like that to determin if it should use keystone limits or nova | 14:35 |
sean-k-mooney | so the actully check would be. 1.) is keystone version new enough to support limtis 2.) are instance limits reported in keysonte limits api, if yes to both use keystone if the either are false use nova | 14:36 |
*** dpawlik has quit IRC | 14:37 | |
sean-k-mooney | johnthetubaguy: would somthing like ^ work | 14:37 |
*** Luzi has quit IRC | 14:38 | |
*** belmoreira has quit IRC | 14:38 | |
*** dklyle has joined #openstack-nova | 14:38 | |
johnthetubaguy | sean-k-mooney: Its not a smooth transition that way... nova might still be ignoring keystone, but it might be good enough (assuming default keystone policy means you can list the limits of your project) | 14:40 |
*** altlogbot_0 has joined #openstack-nova | 14:40 | |
johnthetubaguy | it gets worse with hierarchy mind, as everything seems to | 14:40 |
sean-k-mooney | well we dont need to encode that in the spec i was just wondering if there was a huristic the sdk could resonably use | 14:41 |
*** altlogbot_0 has quit IRC | 14:42 | |
sean-k-mooney | it could be as simple as stick it in a config option for now | 14:42 |
*** belmoreira has joined #openstack-nova | 14:43 | |
sean-k-mooney | the clouds.yaml has profiles for clouds that encode there knonw behavior for non discoverable things | 14:43 |
sean-k-mooney | so that is always an option for limits | 14:43 |
sean-k-mooney | at least i think nodepool gets that stuff from clouds.yaml for the sdk | 14:44 |
*** awalende has joined #openstack-nova | 14:48 | |
*** altlogbot_2 has joined #openstack-nova | 14:52 | |
openstackgerrit | Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | 14:52 |
*** awalende has quit IRC | 14:53 | |
*** altlogbot_2 has quit IRC | 14:56 | |
spatel | sean-k-mooney: did you ever see this error http://paste.openstack.org/show/754267/ | 14:59 |
*** Roamer` has joined #openstack-nova | 15:00 | |
*** _alastor1 has joined #openstack-nova | 15:02 | |
*** mdbooth has quit IRC | 15:05 | |
*** mdbooth has joined #openstack-nova | 15:05 | |
stephenfin | johnthetubaguy: Seeing as you've been reviewing docs, could you have a look at https://review.opendev.org/#/c/667164/ ? | 15:07 |
johnthetubaguy | stephenfin: sure | 15:07 |
*** _alastor1 has quit IRC | 15:07 | |
*** altlogbot_3 has joined #openstack-nova | 15:08 | |
*** dklyle has quit IRC | 15:09 | |
*** altlogbot_3 has quit IRC | 15:12 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add Unified Limits Spec https://review.opendev.org/602201 | 15:15 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Remove unused functions from 'ec2utils' https://review.opendev.org/662501 | 15:15 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove unused ec2 objects https://review.opendev.org/662502 | 15:15 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Remove ec2.CloudController https://review.opendev.org/662503 | 15:15 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Pre-move cleanup of utils https://review.opendev.org/662504 | 15:15 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: ec2: Move ec2utils functions to their callers https://review.opendev.org/662505 | 15:15 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Remove 'Debug' middleware https://review.opendev.org/662506 | 15:15 |
*** mkrai_ has quit IRC | 15:17 | |
*** mkrai_ has joined #openstack-nova | 15:18 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Stop using getattr for VIF lookups https://review.opendev.org/666630 | 15:19 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Resolve a TODO and update another https://review.opendev.org/666631 | 15:19 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: vif: Remove dead minimum libvirt checks https://review.opendev.org/666814 | 15:19 |
*** maciejjozefczyk has quit IRC | 15:19 | |
*** irclogbot_0 has joined #openstack-nova | 15:20 | |
Nick_A | We are trying to offload the _base nova image cache using cephfs. our idea was to do a read-only mirror of glance's image pool and mount that to _base on compute. Would nova have problems with that setup? | 15:20 |
*** tbachman has quit IRC | 15:20 | |
openstackgerrit | Merged openstack/nova master: Perf: Use dicts for ProviderTree roots https://review.opendev.org/637225 | 15:21 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Handle libvirt reporting incorrect 4k page quantities https://review.opendev.org/631038 | 15:21 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Split '_get_host_numa_topology' function https://review.opendev.org/631237 | 15:21 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Make overcommit check for pinned instance pagesize aware https://review.opendev.org/631053 | 15:21 |
openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Support filtering of hosts by forbidden aggregates https://review.opendev.org/667952 | 15:22 |
*** irclogbot_0 has quit IRC | 15:22 | |
*** boxiang has joined #openstack-nova | 15:24 | |
*** boxiang has quit IRC | 15:25 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/670096 | 15:25 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/670097 | 15:26 |
*** boxiang has joined #openstack-nova | 15:26 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/670096 | 15:28 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/670097 | 15:28 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/670100 | 15:29 |
*** mkrai_ has quit IRC | 15:30 | |
*** mkrai__ has joined #openstack-nova | 15:30 | |
*** altlogbot_1 has joined #openstack-nova | 15:32 | |
*** BjoernT_ has joined #openstack-nova | 15:33 | |
*** altlogbot_1 has quit IRC | 15:34 | |
*** ivve has quit IRC | 15:34 | |
mriedem | stephenfin: i see https://review.opendev.org/#/c/667164/2 is already approved and you've started backports, but some issues inline | 15:35 |
stephenfin | looking | 15:35 |
*** BjoernT has quit IRC | 15:36 | |
openstackgerrit | sean mooney proposed openstack/nova master: WIP: coverage job changes https://review.opendev.org/669912 | 15:36 |
*** BjoernT has joined #openstack-nova | 15:36 | |
stephenfin | mriedem: Those all look fair. Want me to pull it out of the gate and address those? | 15:36 |
mriedem | that would be nice yes | 15:37 |
artom | There's a thing to re-run just the tests that failed in the last run... right? | 15:37 |
mriedem | artom: not in the gate | 15:37 |
mriedem | locally, | 15:37 |
artom | mriedem, locally | 15:37 |
mriedem | tox -e <whatever> -- --failing | 15:37 |
artom | mriedem++ | 15:37 |
*** BjoernT_ has quit IRC | 15:38 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | 15:38 |
stephenfin | mriedem: 'openstack quota list --compute' won't show the _default_ quotas though, will it? | 15:40 |
stephenfin | (RE: https://review.opendev.org/#/c/667164/2/doc/source/admin/quotas.rst@68) | 15:40 |
mriedem | stephenfin: honestly i don't know how that command works under the covers, | 15:41 |
mriedem | "default" doesn't really mean anything for the compute API if you're not looking at the default class | 15:41 |
mriedem | neutron has an api to see 'defaults' | 15:41 |
mriedem | but i don't think cinder does and nova doesn't besides the class | 15:41 |
*** mkrai__ has quit IRC | 15:42 | |
stephenfin | looks like 'quota list' is no good to us | 15:43 |
stephenfin | "List quotas for all projects with non-default quota values or list detailed | 15:43 |
stephenfin | quota informations for requested project" | 15:43 |
stephenfin | I'll add a note that there are non-compute quotas mixed in there | 15:44 |
*** _alastor1 has joined #openstack-nova | 15:46 | |
mriedem | yeah this feels like a wild goose chase | 15:48 |
mriedem | sorting out the clis and docs is a mess | 15:48 |
openstackgerrit | sean mooney proposed openstack/nova master: WIP: coverage job changes https://review.opendev.org/669912 | 15:50 |
*** _alastor1 has quit IRC | 15:51 | |
*** mlavalle has joined #openstack-nova | 15:55 | |
*** altlogbot_0 has joined #openstack-nova | 15:56 | |
*** tbachman has joined #openstack-nova | 15:58 | |
*** altlogbot_0 has quit IRC | 15:58 | |
*** mdbooth has quit IRC | 15:58 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | 15:59 |
stephenfin | mriedem: ^ addressed what I could of them | 15:59 |
mriedem | ack | 16:00 |
spatel | sean-k-mooney: nevermind after reload rabbitmq cluster it fixed issue. | 16:00 |
*** _erlon_ has joined #openstack-nova | 16:00 | |
*** helenafm has quit IRC | 16:01 | |
*** udesale has quit IRC | 16:01 | |
sean-k-mooney | spatel: sorry i was on a call earlier but yes we have seen that before | 16:02 |
sean-k-mooney | restarting rabbit or the compute agged typicaly fixes it | 16:03 |
spatel | same here | 16:03 |
sean-k-mooney | its related to how oslo.messaging handels retrasmits and connection issue but i think they are trying to fix it | 16:04 |
sean-k-mooney | its not really a nova issue as we dont actuly handel creating the queue/exchanges | 16:04 |
sean-k-mooney | that is all done use by oslo.messaging | 16:05 |
*** ttsiouts has quit IRC | 16:05 | |
*** mkrai__ has joined #openstack-nova | 16:05 | |
*** thgcorrea_ has joined #openstack-nova | 16:06 | |
*** ttsiouts has joined #openstack-nova | 16:06 | |
*** tssurya has quit IRC | 16:09 | |
*** ttsiouts has quit IRC | 16:10 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a placement audit command https://review.opendev.org/670112 | 16:14 |
*** gyee has joined #openstack-nova | 16:16 | |
*** mkrai__ has quit IRC | 16:23 | |
*** belmoreira has quit IRC | 16:26 | |
*** psachin has quit IRC | 16:26 | |
sean-k-mooney | alex_xu: efried thanks for your input on https://review.opendev.org/#/c/662264/. I have abandoned it for train so we can focus on similar uses of placements new feature in train and come back to cache in U | 16:31 |
sean-k-mooney | if im working on that again in U ill propose a placmeent native version that may pull some of the provider yaml stuff it that makes progress | 16:32 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | 16:40 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | 16:40 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Scrub available quotas https://review.opendev.org/670125 | 16:40 |
*** factor has joined #openstack-nova | 16:41 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | 16:42 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Scrub available quotas https://review.opendev.org/670125 | 16:42 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | 16:42 |
*** Sundar has joined #openstack-nova | 16:46 | |
openstackgerrit | Merged openstack/nova master: db: Add vpmems to instance_extra https://review.opendev.org/662697 | 16:48 |
*** altlogbot_1 has joined #openstack-nova | 16:49 | |
*** ricolin has quit IRC | 16:52 | |
*** _alastor1 has joined #openstack-nova | 16:54 | |
*** altlogbot_1 has quit IRC | 16:54 | |
*** dtantsur is now known as dtantsur|afk | 16:57 | |
*** IvensZambrano has quit IRC | 16:57 | |
Sundar | Hello gibi, Could you look at https://review.opendev.org/657464 ? I understand it merited a -1 earlier, but I think we have resolved the naming issues in the Cyborg-Nova spec. Thanks. | 16:59 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Revert resize: wait for events according to hybrid plug https://review.opendev.org/667177 | 16:59 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Pass migration to finish_revert_migration() https://review.opendev.org/668631 | 16:59 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: [DNM] testing bug/1813789 revert resize events https://review.opendev.org/664442 | 16:59 |
*** derekh has quit IRC | 17:01 | |
stephenfin | mriedem, melwitt: If we removed the injected_files, injected_file_content_bytes and injected_file_path_bytes quotas in API v2.57, does that mean the conf options in '[quotas]' should have a note saying the quotas aren't used anymore or something? | 17:06 |
openstackgerrit | Merged openstack/nova master: Remove 'nova.virt.libvirt.compat' https://review.opendev.org/669120 | 17:06 |
stephenfin | I'm not grasping whether those quotas actually do anything any more and, if so, what's enforcing it | 17:07 |
sean-k-mooney | stephenfin: i think we still need them since we still support it for older microversions | 17:16 |
sean-k-mooney | file injection itself is deprecated but you can still use it if you drop back too older microverions | 17:17 |
*** rpittau is now known as rpittau|afk | 17:23 | |
*** rouk has joined #openstack-nova | 17:24 | |
openstackgerrit | Merged openstack/nova master: libvirt: Remove unreachable native QEMU iSCSI initiator config code https://review.opendev.org/668750 | 17:32 |
*** BjoernT has quit IRC | 17:41 | |
*** dpawlik has joined #openstack-nova | 17:47 | |
*** shilpasd has quit IRC | 17:49 | |
openstackgerrit | Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | 17:50 |
*** ociuhandu has quit IRC | 17:53 | |
openstackgerrit | Dakshina Ilangovan proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/612497 | 18:00 |
*** irclogbot_1 has joined #openstack-nova | 18:06 | |
*** belmoreira has joined #openstack-nova | 18:07 | |
*** irclogbot_1 has quit IRC | 18:08 | |
*** tbachman has quit IRC | 18:09 | |
mriedem | stephenfin: what sean-k-mooney said | 18:11 |
*** hemna has quit IRC | 18:11 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP-until-series-is-ready] Introduce live_migration_claim() https://review.opendev.org/635669 | 18:12 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | 18:12 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for sending NUMAMigrateData to the source https://review.opendev.org/634828 | 18:12 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229 | 18:12 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: RPC changes to prepare for NUMA live migration https://review.opendev.org/634605 | 18:12 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | 18:13 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | 18:13 |
*** Sundar has quit IRC | 18:14 | |
*** hongbin has joined #openstack-nova | 18:18 | |
*** tbachman has joined #openstack-nova | 18:23 | |
sean-k-mooney | someday we will have v4 api after the go rewite and then we can drop 2.1 api support | 18:26 |
*** xek has quit IRC | 18:35 | |
*** xek has joined #openstack-nova | 18:36 | |
*** hemna has joined #openstack-nova | 18:44 | |
mriedem | efried: i'm guessing you want to backport this right? https://review.opendev.org/#/c/637225/ | 18:46 |
mriedem | to at least rocky | 18:46 |
*** belmoreira has quit IRC | 18:48 | |
mriedem | lyarwood: fyi in case you never saw this https://bugs.launchpad.net/devstack-plugin-ceph/+bug/1835627 | 18:48 |
openstack | Launchpad bug 1835627 in devstack-plugin-ceph "test_shelve_unshelve_server failing on stable/pike (and probably ocata)" [Undecided,Confirmed] | 18:48 |
*** boxiang has quit IRC | 18:57 | |
*** boxiang has joined #openstack-nova | 18:57 | |
*** belmoreira has joined #openstack-nova | 18:58 | |
*** zhubx has joined #openstack-nova | 18:59 | |
*** priteau has quit IRC | 18:59 | |
*** boxiang has quit IRC | 19:01 | |
*** altlogbot_2 has joined #openstack-nova | 19:02 | |
*** ralonsoh has quit IRC | 19:03 | |
*** altlogbot_2 has quit IRC | 19:04 | |
*** thgcorrea_ has quit IRC | 19:04 | |
*** BjoernT has joined #openstack-nova | 19:11 | |
*** tesseract has quit IRC | 19:16 | |
*** elod has quit IRC | 19:16 | |
*** elod has joined #openstack-nova | 19:18 | |
*** ivve has joined #openstack-nova | 19:18 | |
*** belmoreira has quit IRC | 19:19 | |
*** irclogbot_3 has joined #openstack-nova | 19:20 | |
*** eharney has quit IRC | 19:21 | |
*** irclogbot_3 has quit IRC | 19:22 | |
*** whoami-rajat has quit IRC | 19:24 | |
dansmith | efried: normally I'd like to see the top of a series be nearly ready to go before we merge a db migration for it: https://review.opendev.org/#/c/662697/ | 19:26 |
dansmith | I know you didn't +W, but, just my opinion | 19:26 |
efried | dansmith: I saw that go by and thought of you. | 19:29 |
efried | I considered -2ing for that reason, but then... didn't. | 19:29 |
efried | mriedem: yes, I would like to backport https://review.opendev.org/#/c/637225/ | 19:30 |
dansmith | I would have liked a different column name at least, but alas I missed my slot | 19:30 |
efried | sean-k-mooney: ack. What would be super awesome is if those efforts were sunk into getting us closer to NUMA modeling in placement. The nested magic stuff has merged. | 19:30 |
efried | dansmith: is it too late to correct it? We don't actually need to support mid-stream commit levels, do we? | 19:31 |
dansmith | uh, we do, and it's too late really | 19:31 |
dansmith | we could migrate the migration, but it's not worth it for that | 19:32 |
dansmith | but yes, we've always supported deploying any commit.. the sins that come from dropping that expectation are really bad | 19:32 |
efried | okay | 19:32 |
openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Fix GET /servers/detail host_status performance regression https://review.opendev.org/669958 | 19:42 |
*** belmoreira has joined #openstack-nova | 19:43 | |
efried | dansmith: I appreciate you looking at that vpmem series though. I look at the object stuff and all I can do is compare it to existing things - I don't really understand it. | 19:43 |
efried | btw, the conf thing isn't there because I asked them to put that last, as it's the "master switch" that makes the admin think something should work. Probably some additional refactoring would be appropriate so we're not referencing the conf option before we introduce it. | 19:44 |
mriedem | is that the thing that starts exposing the inventory? | 19:44 |
*** belmoreira has quit IRC | 19:45 | |
mriedem | hopefully they have pretty robust functional testing before that - which you should be able to do with stubs or something w/o the config option | 19:45 |
dansmith | efried: putting the config option after code that uses it is backwards | 19:45 |
mriedem | we've done something like that before to keep a series moving before exposing it in the api, | 19:46 |
dansmith | but not actually referencing a non-existent config option | 19:46 |
mriedem | gibi's bw stuff in stein did something like that | 19:46 |
mriedem | yeah | 19:46 |
mriedem | my cross-cell resize stuff does something like that with the new policy rule - stubs a compute api method way earlier in the series to make functional testing possible before the api actually supports cross-cell resize | 19:47 |
dansmith | wrap the check in a is_thing_enabled() method and patch that in your tests or something | 19:47 |
mriedem | yup that's what both gibi and i did | 19:47 |
dansmith | yeah | 19:47 |
dansmith | i this case, | 19:48 |
dansmith | however, | 19:48 |
mriedem | https://review.opendev.org/#/c/636253/36/nova/tests/functional/test_cross_cell_migrate.py@65 | 19:48 |
dansmith | the config thing is a complex encoded structure in a string list, | 19:48 |
dansmith | which doesn't lend itself to that pattern quite as well | 19:48 |
mriedem | mmm delicious pci whitelist offspring | 19:49 |
dansmith | maybe have the helper return the contents, and then later have it get the value from config and parse it or something | 19:49 |
mriedem | that would lend itself to easier functional testing as well - just stub the helper to return whatever config you are testing | 19:49 |
dansmith | but putting the parsing in a part of the code that complains about the format not being adhered to, well in advance of the patch that introduces the config option and doc is kinda silly | 19:49 |
dansmith | right | 19:49 |
*** openstackgerrit has quit IRC | 19:49 | |
efried | yup, agreed | 19:50 |
dansmith | to be clear, that thing should not just return the string(s), but do the god-awful parsing of the : and | tokens and return a structure | 19:50 |
*** openstackgerrit has joined #openstack-nova | 19:51 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 19:51 |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 19:51 |
dansmith | and I'd like to see that whole stack ready to go at merge time, | 19:51 |
dansmith | not merging dead code in the driver well in advance of the later patch | 19:51 |
mriedem | dansmith: i lost your +2 on https://review.opendev.org/#/c/631123/because of the db migration | 19:52 |
dansmith | I didn't walk up the set any further because it has a bunch of merged or abandoned patches in the middle | 19:52 |
dansmith | so probably needs a good restacking | 19:52 |
dansmith | mriedem: maybe you'll be more careful with this one | 19:53 |
mriedem | ? | 19:53 |
dansmith | you lost the last one I gave you | 19:53 |
mriedem | i'm pretty sure this is the last time i have to rebase this series | 19:54 |
*** factor has quit IRC | 19:55 | |
efried | Do we cover revert_resize in any of our CI jobs? | 19:56 |
mriedem | yes | 19:57 |
mriedem | definitely single node, the trickier is multi-node coverage | 19:57 |
efried | I'm looking at https://review.opendev.org/#/c/665138/ and not finding out a way to tell whether it's doing... anything at all. | 19:58 |
mriedem | http://logs.openstack.org/39/669539/1/check/tempest-full-py3/1555a09/job-output.txt.gz#_2019-07-05_22_24_52_926869 | 19:58 |
artom | efried, you stay away from that stuff. Run, I tell you. RUN! | 19:58 |
artom | efried, you could try using https://review.opendev.org/#/c/664442/ somehow | 19:59 |
sean-k-mooney | efried: for what its worth i have poposed that we dont backfil the libvirt pos feature and instead use any bandwith it frees up to work on things like numa in placment or novas use of placement in general | 19:59 |
efried | sean-k-mooney: proposed internally at RH you mean? | 19:59 |
sean-k-mooney | ya | 19:59 |
efried | that's wonderful. | 20:00 |
efried | I would really like to see us focus on moving forward that way rather than adding to the burden of stuff that helps us stay where we are. | 20:00 |
sean-k-mooney | we will see if that helps or not but my intent at least is to finish off the work i have started and then see what time is left in the cycle | 20:00 |
mriedem | efried: the tempest-slow job has a cold migration test that is doing revert resize but it's skipped http://logs.openstack.org/39/669539/1/check/tempest-slow-py3/cd3cb0e/job-output.txt.gz#_2019-07-05_22_44_58_146668 until sean-k-mooney/artom's fix lands... | 20:00 |
mriedem | so a catch-22 | 20:00 |
mriedem | https://review.opendev.org/#/c/663405/ | 20:01 |
sean-k-mooney | mriedem: dansmith merged your change to add teh iptables job to the experimenatl pipline right so that can be used for testing revert for now | 20:02 |
mriedem | but yeah https://review.opendev.org/#/c/664442/ is the canary | 20:02 |
mriedem | sean-k-mooney: oh yeah that's right | 20:02 |
artom | sean-k-mooney, I thought that was single node? | 20:02 |
mriedem | see? there are only like 5 need-to-know manual on-demand things | 20:02 |
artom | (That being the reason it failed - we didn't test same host revert with OVS hybrid plug) | 20:03 |
mriedem | artom: it is | 20:03 |
mriedem | so neutron-tempest-iptables_hybrid tests ovs hybrid plug same-host resize, | 20:03 |
mriedem | tempest-slow (will eventually) test multi-node revert | 20:03 |
mriedem | but not ovs hybrid plug | 20:03 |
artom | We have same-host resize in tempest-full-py3 too, no? | 20:04 |
mriedem | and tempest-full tests non-hybrid plug same host resize revert | 20:04 |
efried | So I could update https://review.opendev.org/#/c/665138/ to depend-on https://review.opendev.org/#/c/664442/ and that would tell me... what? | 20:04 |
artom | jynx | 20:04 |
mriedem | yes, but not ovs hybrid plug | 20:04 |
mriedem | and single node | 20:04 |
sean-k-mooney | artom: the iptables one is singel node yes | 20:04 |
artom | My brain is leaking | 20:04 |
efried | I'm probably too dense today to understand it anyway; maybe I'll just push it to the back of the queue again until I'm feeling sharp. | 20:04 |
mriedem | and the dnm patch at the top of the series for multi-node ovs hybrid plug=true | 20:04 |
sean-k-mooney | so same host resize revert can be tested which is basically cold migrate | 20:04 |
mriedem | efried: you're likely best leaving it to me and dansmith at this point | 20:04 |
efried | okay | 20:05 |
dansmith | save. yourself. | 20:05 |
mriedem | sean-k-mooney: .... we don't test same-host cold migration in the gate | 20:05 |
sean-k-mooney | technically we might allow same host "migrate" too but never bothered to try that | 20:05 |
artom | dansmith, that's what I said! | 20:05 |
mriedem | b/c the libvirt driver doesn't support that | 20:05 |
mriedem | sean-k-mooney: only the vcenter driver allows that | 20:05 |
artom | But noooo, we need "quality" and for things to "work" | 20:05 |
sean-k-mooney | mriedem: well same host cold migrate isnt really useful | 20:05 |
sean-k-mooney | wait they allow it because its a clustered hypervior | 20:05 |
mriedem | yes | 20:05 |
sean-k-mooney | so im guessing its not really the same host right | 20:05 |
sean-k-mooney | at least internally | 20:06 |
mriedem | different esxi host | 20:06 |
sean-k-mooney | right of course it is | 20:06 |
mriedem | same nova-compute service host | 20:06 |
mriedem | wonder if i could get some questions onto the openstack COA exam | 20:06 |
*** factor has joined #openstack-nova | 20:06 | |
*** zhubx has quit IRC | 20:07 | |
mriedem | "what is a compute node?" BZZZT! | 20:07 |
*** zhubx has joined #openstack-nova | 20:07 | |
sean-k-mooney | when is disk_available_least bigger then free_gb | 20:08 |
efried | a) the same as a compute host | 20:08 |
efried | b) the physical system on which the nova-compute service runs | 20:08 |
efried | c) an ironic instance | 20:08 |
efried | d) all of the above | 20:08 |
dansmith | please, you guys are depressing me | 20:09 |
efried | (btw, I would totally fail that question) | 20:09 |
efried | mriedem: backporting... | 20:11 |
openstackgerrit | Eric Fried proposed openstack/nova stable/stein: Perf: Use dicts for ProviderTree roots https://review.opendev.org/670179 | 20:11 |
efried | I think the rocky backport is going to be dirty, because the mdev stuff I "fixed" wasn't there yet. | 20:12 |
efried | yup | 20:12 |
efried | oh, worse than that | 20:14 |
*** ivve has quit IRC | 20:14 | |
mriedem | unrelated, but while looking at ironic n-cpu job logs for that change on master, i see we hit a provider inventory conflict and we must refresh and re-push and it works | 20:15 |
mriedem | http://logs.openstack.org/25/637225/2/check/ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa/fee37e3/controller/logs/screen-n-cpu.txt.gz#_Jul_10_00_32_51_413640 | 20:15 |
mriedem | b/c the reserved value changed on the node | 20:15 |
mriedem | only question is, does that 409 need to be an error if we're going to refresh associations and try again? | 20:15 |
mriedem | like, "ERROR! .... oh nvm i've got this." | 20:16 |
efried | it's the kind of thing where we would sure want the last one (when we give up retrying) to be an error. | 20:17 |
efried | but yeah, that one could certainly be warning or even info | 20:17 |
*** zhubx has quit IRC | 20:18 | |
*** zhubx has joined #openstack-nova | 20:19 | |
openstackgerrit | Eric Fried proposed openstack/nova stable/rocky: Perf: Use dicts for ProviderTree roots https://review.opendev.org/670182 | 20:22 |
efried | mriedem: ^ | 20:23 |
efried | conflicts pare it down to just one file. | 20:23 |
efried | Should we go to queens? | 20:24 |
mriedem | belmiro's bug was against rocky b/c that's what cern was using at the time, | 20:25 |
mriedem | i'd say maybe wait for someone to ask for it in queens | 20:25 |
efried | ight | 20:26 |
*** boxiang has joined #openstack-nova | 20:27 | |
*** dpawlik has quit IRC | 20:27 | |
*** altlogbot_1 has joined #openstack-nova | 20:28 | |
*** zhubx has quit IRC | 20:28 | |
*** zhubx has joined #openstack-nova | 20:30 | |
*** altlogbot_1 has quit IRC | 20:32 | |
*** boxiang has quit IRC | 20:33 | |
*** eharney has joined #openstack-nova | 20:42 | |
*** dpawlik has joined #openstack-nova | 20:44 | |
*** pcaruana has quit IRC | 20:48 | |
*** dpawlik has quit IRC | 20:48 | |
*** xek_ has joined #openstack-nova | 20:51 | |
*** xek has quit IRC | 20:52 | |
*** dklyle has joined #openstack-nova | 20:55 | |
*** ociuhandu has joined #openstack-nova | 20:59 | |
openstackgerrit | sean mooney proposed openstack/nova master: DNM demonstrate that get_domain_capabilities is broken. https://review.opendev.org/670189 | 21:01 |
sean-k-mooney | efried: aspiers ^ im going rework get_domain_capabilities function so that it does not explode at runtime | 21:02 |
*** altlogbot_3 has joined #openstack-nova | 21:04 | |
*** ociuhandu has quit IRC | 21:08 | |
*** altlogbot_3 has quit IRC | 21:08 | |
*** xek_ has quit IRC | 21:11 | |
efried | neat | 21:15 |
*** altlogbot_1 has joined #openstack-nova | 21:18 | |
*** altlogbot_1 has quit IRC | 21:22 | |
*** boxiang has joined #openstack-nova | 21:23 | |
sean-k-mooney | the test case is a bit contrived as i would otherwise be assert that if i trow an excpetion that it thing explode | 21:23 |
sean-k-mooney | but hopefully its clear that there reason it was passing wa we were hardcoding stuff | 21:23 |
sean-k-mooney | and we dont call it | 21:24 |
*** zhubx has quit IRC | 21:25 | |
openstackgerrit | Merged openstack/nova master: docs: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | 21:26 |
*** admin0 has quit IRC | 21:27 | |
*** spatel has quit IRC | 21:27 | |
sean-k-mooney | im going to change the api of _get_domain_capabilities to match libvirt which allows all args to be set to none so we dont need to invent a default if we dont have one and can just use libvirts instead | 21:28 |
*** dklyle has quit IRC | 21:29 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert nova-next to a zuul v3 job https://review.opendev.org/670196 | 21:36 |
*** zhubx has joined #openstack-nova | 21:36 | |
*** zhubx has quit IRC | 21:39 | |
*** zhubx has joined #openstack-nova | 21:39 | |
*** boxiang has quit IRC | 21:40 | |
*** boxiang has joined #openstack-nova | 21:44 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert nova-next to a zuul v3 job https://review.opendev.org/670196 | 21:44 |
*** zhubx has quit IRC | 21:45 | |
*** factor has quit IRC | 21:45 | |
*** factor has joined #openstack-nova | 21:46 | |
*** takashin has joined #openstack-nova | 21:46 | |
*** irclogbot_3 has joined #openstack-nova | 21:48 | |
*** artom has quit IRC | 21:50 | |
*** irclogbot_3 has quit IRC | 21:52 | |
*** tbachman_ has joined #openstack-nova | 21:59 | |
*** tbachman has quit IRC | 22:00 | |
*** tbachman_ is now known as tbachman | 22:00 | |
*** mchlumsky has quit IRC | 22:10 | |
*** mlavalle has quit IRC | 22:18 | |
*** slaweq has quit IRC | 22:20 | |
*** _erlon_ has quit IRC | 22:30 | |
*** zhubx has joined #openstack-nova | 22:38 | |
*** boxiang has quit IRC | 22:42 | |
*** luksky11 has quit IRC | 22:43 | |
*** rcernin has joined #openstack-nova | 22:48 | |
openstackgerrit | Eric Fried proposed openstack/nova master: Introduces the openstacksdk to nova https://review.opendev.org/643664 | 22:48 |
openstackgerrit | Eric Fried proposed openstack/nova master: Use OpenStack SDK for placement https://review.opendev.org/656023 | 22:48 |
openstackgerrit | Merged openstack/nova master: nova-lvm: Disable [validation]/run_validation in tempest.conf https://review.opendev.org/662176 | 22:58 |
*** hongbin has quit IRC | 23:02 | |
*** altlogbot_3 has joined #openstack-nova | 23:04 | |
*** tkajinam has joined #openstack-nova | 23:06 | |
*** altlogbot_3 has quit IRC | 23:08 | |
*** altlogbot_0 has joined #openstack-nova | 23:14 | |
openstackgerrit | sean mooney proposed openstack/nova master: libvirt: harden get_domain_capabilities https://review.opendev.org/670189 | 23:17 |
*** altlogbot_0 has quit IRC | 23:18 | |
*** altlogbot_1 has joined #openstack-nova | 23:20 | |
*** altlogbot_1 has quit IRC | 23:24 | |
*** altlogbot_0 has joined #openstack-nova | 23:26 | |
*** altlogbot_0 has quit IRC | 23:30 | |
*** hoonetorg has quit IRC | 23:38 | |
*** hoonetorg has joined #openstack-nova | 23:40 | |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 23:43 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for node.list https://review.opendev.org/656027 | 23:43 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node https://review.opendev.org/656028 | 23:43 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id https://review.opendev.org/659690 | 23:43 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for add/remove instance info from node https://review.opendev.org/659691 | 23:43 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for getting network metadata from node https://review.opendev.org/670213 | 23:43 |
*** artom has joined #openstack-nova | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!