Monday, 2019-08-05

« Sunday, 2019-08-04 Index Tuesday, 2019-08-06 »
*** markvoelker has joined #openstack-nova00:02
*** markvoelker has quit IRC00:06
*** brinzhang has joined #openstack-nova00:31
*** markvoelker has joined #openstack-nova00:45
openstackgerritBrin Zhang proposed openstack/nova master: WIP: Filter migrations by user_id/project_id  https://review.opendev.org/67424300:59
openstackgerritBrin Zhang proposed openstack/nova master: WIP: Add user_id and project_id colume to Migration  https://review.opendev.org/67399001:01
*** markvoelker has quit IRC01:09
*** yikun has joined #openstack-nova01:44
*** markvoelker has joined #openstack-nova02:01
*** markvoelker has quit IRC02:06
*** markvoelker has joined #openstack-nova02:32
*** whoami-rajat has joined #openstack-nova02:38
*** markvoelker has quit IRC02:42
*** ricolin has joined #openstack-nova02:51
*** markvoelker has joined #openstack-nova03:13
*** markvoelker has quit IRC03:17
*** psachin has joined #openstack-nova03:29
*** ricolin_ has joined #openstack-nova03:35
*** ricolin has quit IRC03:38
*** yaawang has quit IRC03:42
*** yaawang has joined #openstack-nova03:43
openstackgerritya.wang proposed openstack/nova master: Support report driver migrate feature  https://review.opendev.org/67452203:44
openstackgerritya.wang proposed openstack/nova master: Add property check when create/rebuild/resize.  https://review.opendev.org/67452303:44
openstackgerritya.wang proposed openstack/nova master: Scheduelr translate properties to traits  https://review.opendev.org/67452403:44
openstackgerritya.wang proposed openstack/nova master: Change method: _live_migration_flags  https://review.opendev.org/67452503:44
openstackgerritya.wang proposed openstack/nova master: Add releasenote and update docs.  https://review.opendev.org/67452603:44
*** udesale has joined #openstack-nova04:07
*** dpawlik has joined #openstack-nova04:13
*** dpawlik has quit IRC04:20
*** markvoelker has joined #openstack-nova04:28
*** markvoelker has quit IRC04:33
*** ratailor has joined #openstack-nova04:36
*** ratailor_ has joined #openstack-nova04:41
*** ratailor has quit IRC04:42
*** ratailor__ has joined #openstack-nova05:02
*** janki has joined #openstack-nova05:02
*** ratailor_ has quit IRC05:04
*** Luzi has joined #openstack-nova05:06
*** yaawang has quit IRC05:08
*** yonglihe has quit IRC05:10
*** yaawang has joined #openstack-nova05:10
*** boxiang has quit IRC05:19
*** boxiang has joined #openstack-nova05:20
*** ratailor has joined #openstack-nova05:25
*** ratailor__ has quit IRC05:25
*** yaawang has quit IRC05:29
*** yaawang has joined #openstack-nova05:30
*** ratailor_ has joined #openstack-nova05:34
*** yaawang has quit IRC05:34
*** yaawang has joined #openstack-nova05:35
*** ratailor has quit IRC05:36
*** bhagyashris has joined #openstack-nova05:37
*** jaosorior has joined #openstack-nova05:41
*** dpawlik has joined #openstack-nova05:43
*** boxiang has quit IRC05:56
*** boxiang has joined #openstack-nova05:57
alex_xubauzas: dansmith looking for some feedback on https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:claim_for_instance, both mdev and vpmem are implement06:11
*** yaawang has quit IRC06:15
*** yaawang has joined #openstack-nova06:15
*** dpawlik has quit IRC06:28
*** obre has joined #openstack-nova06:29
*** yaawang has quit IRC06:32
*** mkrai has joined #openstack-nova06:33
*** yaawang has joined #openstack-nova06:33
*** aarents has joined #openstack-nova06:34
*** yaawang has quit IRC06:40
*** yaawang has joined #openstack-nova06:41
*** ricolin__ has joined #openstack-nova06:41
*** ricolin__ is now known as ricolin06:41
*** mkrai has quit IRC06:42
*** dpawlik has joined #openstack-nova06:44
*** ricolin_ has quit IRC06:45
*** mkrai has joined #openstack-nova06:45
openstackgerritYongli He proposed openstack/nova master: Add server sub-resource topology API  https://review.opendev.org/62147606:45
*** belmoreira has joined #openstack-nova06:51
*** aojea has joined #openstack-nova06:52
*** ralonsoh has joined #openstack-nova06:54
*** maciejjozefczyk has joined #openstack-nova07:02
*** maciejjozefczyk has quit IRC07:03
*** rcernin has quit IRC07:04
*** slaweq has joined #openstack-nova07:05
*** xek has joined #openstack-nova07:05
*** pcaruana has joined #openstack-nova07:08
alex_xudansmith: efried, one more corner case found. For same host resize, we only have one domain xml in the libvirt before confirming the resize. So if the host is down, and then the host back again, we will lose the source allocation.07:14
alex_xudannins: efried, one method is we write the device allocations(vgpu, vpmem..) into the filesystem under the dir "instance_base_path + '_resize'"...07:16
*** markvoelker has joined #openstack-nova07:17
*** tesseract has joined #openstack-nova07:17
alex_xudansmith: efried or we just auto confrim that same host resize after the host back, and cleanup other free vpmem.07:25
*** xek has quit IRC07:28
*** jangutter has joined #openstack-nova07:31
*** maciejjozefczyk has joined #openstack-nova07:33
*** ccamacho has joined #openstack-nova07:49
*** markvoelker has quit IRC07:51
*** rpittau|afk is now known as rpittau07:51
*** brault has joined #openstack-nova08:03
*** aojea has quit IRC08:03
*** aojeagarcia has joined #openstack-nova08:03
*** belmoreira has quit IRC08:08
*** yonglihe has joined #openstack-nova08:10
*** tkajinam has quit IRC08:11
*** belmoreira has joined #openstack-nova08:12
*** arxcruz is now known as arxcruz|grb08:18
*** arxcruz|grb is now known as arxcruz|brb08:18
*** tesseract-RH has joined #openstack-nova08:22
*** tesseract has quit IRC08:22
*** tesseract-RH has quit IRC08:24
*** tesseract has joined #openstack-nova08:24
*** avolkov has joined #openstack-nova08:34
*** tssurya has joined #openstack-nova08:41
*** janki has quit IRC08:43
openstackgerritya.wang proposed openstack/nova master: vCPU mdoels selection  https://review.opendev.org/67029808:48
openstackgerritya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags  https://review.opendev.org/67029908:48
openstackgerritya.wang proposed openstack/nova master: Support report multi CPU model traits  https://review.opendev.org/67030008:48
openstackgerritya.wang proposed openstack/nova master: Add release note  https://review.opendev.org/67044108:48
*** jaosorior has quit IRC08:51
*** ksdean has joined #openstack-nova08:52
*** markvoelker has joined #openstack-nova08:56
*** belmoreira has quit IRC09:03
openstackgerritya.wang proposed openstack/nova master: vCPU model selection  https://review.opendev.org/67029809:05
openstackgerritya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags  https://review.opendev.org/67029909:05
openstackgerritya.wang proposed openstack/nova master: Support report multi CPU model traits  https://review.opendev.org/67030009:05
openstackgerritya.wang proposed openstack/nova master: Add release note  https://review.opendev.org/67044109:05
mkraimgoddard, Hi Mark! Can you please take a look at the reconfigure spec whenever you've time? https://review.opendev.org/#/c/672252/09:21
*** markvoelker has quit IRC09:30
*** takashin has left #openstack-nova09:32
*** Luzi has quit IRC09:43
*** janki has joined #openstack-nova09:45
*** dasp has quit IRC09:49
*** dasp has joined #openstack-nova09:49
*** belmoreira has joined #openstack-nova09:49
*** cdent has joined #openstack-nova09:49
*** spsurya has joined #openstack-nova09:50
*** Luzi has joined #openstack-nova09:56
*** jaosorior has joined #openstack-nova10:05
*** mvkr has joined #openstack-nova10:18
*** ociuhandu has joined #openstack-nova10:20
*** bhagyashris has quit IRC10:25
*** janki has quit IRC10:27
*** markvoelker has joined #openstack-nova10:38
*** markvoelker has quit IRC10:43
*** mkrai has quit IRC10:45
*** arxcruz|brb is now known as arxcruz10:52
openstackgerritHuachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance  https://review.opendev.org/66865610:58
*** brault has quit IRC11:11
openstackgerritHuachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance  https://review.opendev.org/66865611:15
*** jaosorior has quit IRC11:23
*** jamesdenton has joined #openstack-nova11:30
*** tbachman has joined #openstack-nova11:47
*** ociuhandu has quit IRC11:49
*** ociuhandu has joined #openstack-nova11:50
kashyapalex_xu: When you get a min, want to put this through?  This fixes a couple of bugs: https://review.opendev.org/#/c/348394/10/11:52
openstackgerritMerged openstack/nova master: Add the support of CPU feature 'AVX512-VNNI'  https://review.opendev.org/67348011:54
*** markvoelker has joined #openstack-nova11:55
*** tbachman has quit IRC11:58
*** gibi_off is now known as gibi12:01
* gibi is back12:01
* kashyap welcomes gibi to a deluge of email and other stuff12:02
*** markvoelker has quit IRC12:02
* kashyap is going to disappear until 23Aug starting tomm...12:02
*** markvoelker has joined #openstack-nova12:02
*** udesale has quit IRC12:06
*** udesale has joined #openstack-nova12:07
*** tssurya has quit IRC12:07
gibikashyap: all those nice emails waiting for me...12:08
gibikashyap: have a nice vacation!12:08
*** tssurya has joined #openstack-nova12:08
*** markvoelker has quit IRC12:09
kashyapThanks!12:09
*** jaosorior has joined #openstack-nova12:10
*** markvoelker has joined #openstack-nova12:11
*** ociuhandu has quit IRC12:12
*** betherly has joined #openstack-nova12:15
openstackgerritBrin Zhang proposed openstack/nova master: WIP: Filter migrations by user_id/project_id  https://review.opendev.org/67424312:20
*** ociuhandu has joined #openstack-nova12:20
*** ratailor_ has quit IRC12:33
*** jroll has quit IRC12:39
*** belmoreira has quit IRC12:39
*** jroll has joined #openstack-nova12:39
*** ccamacho has quit IRC12:43
*** yaawang has quit IRC12:43
*** yaawang has joined #openstack-nova12:45
*** priteau has joined #openstack-nova12:45
*** jamesdenton has quit IRC12:49
*** priteau has quit IRC12:54
alex_xukashyap: I will try tomorrow morning12:55
aspierskashyap: any chance you could review https://review.opendev.org/#/c/673151/ before you go?12:55
aspierskashyap: I mean, finish reviewing it. It blocks the entire SEV series :-(12:56
aspierswelcome back gibi :)12:56
kashyapalex_xu: Sure12:56
kashyapaspiers: Looking12:56
gibiaspiers: thanks :)12:57
kashyapaspiers: I had opened it, and apparently have a little draft (nothing substantial) to your reply.  Will hit send today12:58
*** belmoreira has joined #openstack-nova12:59
aspierskashyap: thanks. If at all possible I would really like to get your +1 before you go13:00
kashyapaspiers: Yes, doing that13:00
kashyapaspiers: A silly XML question13:03
* kashyap is feeling jaded from 4 hours of newbie kayaking yesterday I guess13:03
*** jamesdenton has joined #openstack-nova13:04
aspiers?13:05
kashyapaspiers: http://paste.openstack.org/show/755517/13:06
kashyapThought it's better to use the pastebin13:06
aspiersc.text13:07
aspiersc.attrib is for the ... attributes :)13:07
kashyapErr, indeed.  What am I smoking13:07
aspiersalso, don't use getchildren13:08
kashyap.text holds the additional data...13:08
kashyapaspiers: Oh, I recall you had a patch to replace that, because of new XML library changes13:10
kashyapRight, Element.getchildren() is deprecated13:11
aspiersI haven't done it yet13:11
aspiersbut I will13:11
*** yaawang has quit IRC13:13
*** yaawang has joined #openstack-nova13:13
*** mriedem has joined #openstack-nova13:14
kashyapNod13:15
*** kdean has joined #openstack-nova13:25
*** ksdean has quit IRC13:29
kashyapaspiers: Is this readable to you? :D13:32
kashyap            elif c.tag == "enum" and c.attrib["name"] == "firmware":13:32
kashyap                firmwares = []13:32
kashyap                self.firmwares = [child.text for child in c13:32
kashyap                        if child.tag == "value"]13:32
*** ociuhandu has quit IRC13:32
aspiersyes but couldn't it cause a KeyError if there's an <enum> without a 'name' attribute?13:33
aspierswhich in theory shouldn't happen, but ya know, defensive programming and all that13:33
aspiersthis is probably the kind of thing sean-k-mooney was talking about13:33
kashyapaspiers: Hmm, possibly.  How do you guard?13:33
aspiersit's just a dict :)13:33
aspiersc.attrib.get("name")13:33
belmoreiraHi. I'm testing the nova upgrade from Rocky to Stein. I was trying to do it without control plane interruption but I'm failing. I was hoping that upgrade_levels for the control plane would do it... but no.13:34
aspiersI think sean-k-mooney would advocate //enum[@name='firmware']/value/text() or whatever13:34
kashyapaspiers: Nod on the attrib / dict :-)13:34
kashyapaspiers: Right ... that's the 'xpath' parsing13:35
kashyapaspiers: I wrote this for QE folks: https://kashyapc.fedorapeople.org/Querying-guest-XML-with-xpath.txt13:35
aspiershow is xpath different from xq?13:36
belmoreiraafaik this is not supported, but what are we missing?13:37
kashyap1 sec; call13:38
aspiersbelmoreira: not sure anyone who could answer that is awake yet, unless maybe lyarwood13:39
*** jamesdenton has quit IRC13:44
*** tbachman has joined #openstack-nova13:46
*** Luzi has quit IRC13:46
*** mdbooth has joined #openstack-nova13:47
*** pcaruana has quit IRC13:47
mriedemstephenfin: i'm having a hard time reasoning why this libvirt functional test you wrote here https://logs.opendev.org/22/674422/1/check/nova-tox-functional/ddac573/testr_results.html.gz is failing on a simple optimization change here https://review.opendev.org/#/c/674422/13:48
mriedemlooks like the test expects something to fail which isn't now13:48
mriedemso it's hitting a StopIteration on a mocked call to open a console file for the guest when spawning it for the 3rd time (1 create, 2 rebuilds)13:49
*** BjoernT has joined #openstack-nova13:50
*** Rubueno has joined #openstack-nova13:52
*** BjoernT has quit IRC13:52
RubuenoHi, quick question. We're running OS in accp and prod environments, currently running the same version. Today the nova api returns an unexpected api error in accp when calling "nova list" or "openstack server list --all". It asks to report it at launchpad, just wondering what temlate to follow and whether there's anything I can do at this moment.13:54
*** mdbooth has quit IRC13:56
Rubueno"Unexpected exception in API method: TypeError: __init__() takes at least 4 arguments (2 given)"13:56
*** BjoernT has joined #openstack-nova13:56
kashyapaspiers: BTW, earlier, c.get() does it; no need for c.attrib.get() :-) -- you know why13:57
aspierskashyap: oh yeah, that's even better13:58
aspierskashyap: just to be 100% clear before you vanish for a significant length of time, you're intending to reply to https://review.opendev.org/#/c/673151/ later today right? If you have any nits which you want fixing, I really want to get those done before you go so that you can give an honest +1 :) Not trying to pester as I'm around all day - just making sure :)14:00
*** pcaruana has joined #openstack-nova14:00
*** amodi has quit IRC14:01
kashyapaspiers: Writing right now14:01
aspiersawesome, thanks!14:01
*** belmoreira has quit IRC14:02
kashyapaspiers: Also, note, don't worry - I've been looking at this for a couple of days, not doing it in a hurry :-)14:03
*** belmoreira has joined #openstack-nova14:03
aspierscool14:03
kashyapaspiers: Also, congrats ... you are one of the few people who can distinguish the getCapabilities() and getDomainCapabilities() at feature-level :D14:03
aspiersheh14:04
aspiersWell they're kind of confusing14:04
alex_xumriedem: do you want to give a help on this https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:claim_for_instance? I remember you reviewed the original vgpu code also14:05
kashyapalex_xu: They _are_ confusing.  You'll recall - a few months ago, when you added that 'infra' patch for domCaps, we hashed out doc string accuracy over a couple of days.14:06
aspiersI think that last message was meant for me :)14:07
aspiersYes I do recall that14:07
alex_xukashyap: emmm...what context?14:11
kashyapalex_xu: Err, I'm sorry.  I didn't realize the nick14:11
kashyapYes, it was for aspiers, indeed14:11
alex_xuah14:11
*** spatel has joined #openstack-nova14:12
spatelsean-k-mooney: morning14:12
aspiersspatel: don't think he's around14:12
spatelaspiers: Thanks, yes it seems.  (untill noon tuesday gmt)14:15
*** ociuhandu has joined #openstack-nova14:19
*** eharney has joined #openstack-nova14:20
kashyapaspiers: Can the fix to test_driver.LibvirtConnTestCase.test_cpu_info be separated out?14:20
kashyap(And also test_get_instance_capabilities())14:20
aspiersit could, but is it really worth it?14:20
aarentsHi there, can someone tell me who can review this https://review.opendev.org/#/c/670000/ it is about _get_guest_config() potential bug14:21
kashyapaspiers: Not, probably.  (I was just looking at it form a "is this strictly necessary for this?")14:21
aspiersaarents: that's a great review number14:21
*** mlavalle has joined #openstack-nova14:22
kashyapaspiers: Just so that it makes future git sleuthing (`blame`, or even goodness forbid bacports :D) easier when not mixing absolutely unnedeed changes in the same patch (but add it in on top).14:22
kashyapaspiers: But it's not worth it here14:22
*** _erlon_ has joined #openstack-nova14:23
*** jamesdenton has joined #openstack-nova14:23
aspierskashyap: I can do, I guess all the SEV stuff needs to be rebased anyway14:23
aspierssince I already posted a patch set to address your other nit14:23
kashyapaspiers: Okay, you can do it probably once I hit send shortly14:23
kashyapaspiers: Ahh, right14:23
aspierskashyap: well if I do it, it will invalidate your +114:23
aspierskashyap: so if I do it, it needs to be now14:24
kashyapaspiers: Hehe, I'll give a "future-proof" +1 that, modulo that test rework, I don't have any further changes14:24
aspierskashyap: I'll do it now14:24
kashyapaspiers: I'm mostly writing tiny observations as I saw14:24
kashyapOkay...14:24
aspierskashyap: since we're both insane perfectionists ;-)14:25
aarentsaspiers: Yes, It was not so easy to caught that ;)14:25
*** mriedem has quit IRC14:29
aspierskashyap: while I'm at it, should I split out the assertXmlEquals *options addition?14:29
*** mriedem has joined #openstack-nova14:29
kashyapaspiers: I was thinking about it -- it certainly removes the noise.  And makes it slightly easier to reviewers who're _not_ familiar this area, IMHO14:29
aspiersTrue14:29
aspiersMight as well14:30
*** boxiang has joined #openstack-nova14:35
*** boxiang has quit IRC14:36
*** jaosorior has quit IRC14:36
*** boxiang has joined #openstack-nova14:36
*** boxiang has quit IRC14:38
*** jaosorior has joined #openstack-nova14:39
*** boxiang has joined #openstack-nova14:39
*** boxiang has quit IRC14:39
*** boxiang has joined #openstack-nova14:40
*** mkrai has joined #openstack-nova14:43
*** belmoreira has quit IRC14:48
*** brault has joined #openstack-nova14:50
*** Rubueno has quit IRC14:50
*** belmoreira has joined #openstack-nova14:51
*** Aegil has quit IRC14:52
*** brault has quit IRC14:55
openstackgerritEric Fried proposed openstack/nova master: DNM: Test blank sdk placement proxy  https://review.opendev.org/67462514:56
efriedmriedem, cdent, mordred: would one or more of y'all please check whether I did that ^ right?14:56
mordredefried: I thnik that should do it14:57
*** BjoernT_ has joined #openstack-nova14:57
efriedthx14:58
efriedit's the required-projects thing I can never seem to suss14:58
*** BjoernT has quit IRC14:59
mriedemefried: unrelated to that, i've noticed that we get several warnings from openstacksdk for cinder and barbican not having valid_interfaces in nova conf when functional tests fail,15:01
mriedemhttp://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22WARNING%20%5Bopenstack%5D%20Disabling%20service%5C%22%20AND%20message%3A%5C%22Encountered%20an%20exception%20attempting%20to%20process%20config%20for%20project%5C%22%20AND%20message%3A%5C%22no%20such%20option%20valid_interfaces%20in%20group%5C%22&from=7d15:01
*** bnemec-pto is now known as bnemec15:01
efriedmriedem: that's interesting. Off the cuff, it's gotta be because we're not importing the ksa opts correctly. Investigating...15:02
openstackgerritAdam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types  https://review.opendev.org/67315115:02
openstackgerritAdam Spiers proposed openstack/nova master: Allow assertXmlEqual() to pass options to matchers.XMLMatches  https://review.opendev.org/67462815:02
openstackgerritAdam Spiers proposed openstack/nova master: Fix libvirt driver tests to use LibvirtConfigCapsGuest instances  https://review.opendev.org/67462915:02
aspierskashyap: ^^^15:03
aspiersefried: a couple of those are trivial changes split off from the main patch, and should only take 1--2 mins to review15:03
efriedmriedem: oh, right, we never did finish cutting over cinder or barbican to ksa15:04
efriedmordred: I wonder if it's worth fixing up the oslo.config method to accept a list of services we care about, so the sdk only builds proxies for those...15:05
*** mkrai has quit IRC15:06
*** mkrai has joined #openstack-nova15:06
kashyapaspiers: Ack15:06
mordredefried: the proxy objects themselves are on-demand. it doesn't build something if it's not used15:08
efriedmordred: well, okay, interpreting the conf sections tho15:09
mordredthat could maybe be worth it15:10
*** tbachman has quit IRC15:13
*** BjoernT_ is now known as BjoernT15:14
*** betherly has quit IRC15:29
*** ralonsoh has quit IRC15:29
openstackgerritBalazs Gibizer proposed openstack/nova stable/queens: Stabilize unshelve notification sample tests  https://review.opendev.org/67463615:33
*** ociuhandu has quit IRC15:40
*** ociuhandu has joined #openstack-nova15:40
*** tbachman has joined #openstack-nova15:41
*** ociuhandu has quit IRC15:41
*** ociuhandu has joined #openstack-nova15:42
*** ociuhandu has quit IRC15:43
*** ociuhandu has joined #openstack-nova15:43
*** ociuhandu has quit IRC15:43
*** ociuhandu has joined #openstack-nova15:45
*** ociuhandu has quit IRC15:45
*** ociuhandu has joined #openstack-nova15:45
*** gyee has joined #openstack-nova15:48
*** belmoreira has quit IRC15:52
*** belmoreira has joined #openstack-nova16:02
*** belmoreira has quit IRC16:03
*** tesseract has quit IRC16:04
*** ociuhandu_ has joined #openstack-nova16:04
*** ociuhandu has quit IRC16:07
*** lpetrut has joined #openstack-nova16:09
mriedemstephenfin: after debugging for a few hours i think i figured out the problem,16:13
mriedemhttps://github.com/openstack/nova/blob/433b1662e48db57aaa42e11756fa4a6d8722b386/nova/network/neutronv2/api.py#L1807 builds a list of network dicts with a small subset of the actual network values we'd care about, in this case physical_network16:14
mriedemthat likely means this is mtu is wrong when attaching a port as well https://github.com/openstack/nova/blob/433b1662e48db57aaa42e11756fa4a6d8722b386/nova/network/neutronv2/api.py#L277516:15
*** mkrai has quit IRC16:27
*** ociuhandu_ has quit IRC16:33
*** ociuhandu has joined #openstack-nova16:33
*** ociuhandu has quit IRC16:45
*** mlavalle has quit IRC16:45
*** mlavalle has joined #openstack-nova16:48
*** markvoelker has quit IRC16:49
*** ociuhandu has joined #openstack-nova16:50
efrieddansmith: Please let me know when you're dug out and available for a couple minutes.16:56
*** ricolin has quit IRC16:57
dansmithefried: I'm not dug out, but looking for anything else to do but keep digging16:59
efrieddansmith: oh, neat.16:59
efriedso at last week's meeting we discussed a couple of feature freeze exceptions17:00
efriedand basically gave you the deciding vote for both of them.17:00
dansmiththat's ... odd17:00
*** markvoelker has joined #openstack-nova17:01
efrieddansmith: http://eavesdrop.openstack.org/meetings/nova/2019/nova.2019-08-01-21.00.log.html#l-5917:01
efriedthe old "give action items to the absent guy" trick17:01
dansmithso the image encryption and pcpu ones?17:02
efriedy17:02
dansmithI didn't know the former was even a thing, which might be a bad sign17:02
efriedoh, mriedem seemed to think you had discussed it at the PTG and on IRC.17:02
efriedfungi is TC liaison for the popup team, he might be able to summarize from a xproj perspective.17:03
fungiyup, just catching up real fast17:03
dansmithwell, I was involved in the earlier image encryption stuff17:04
dansmither, the signing stuff I mean17:04
fungiit's the image encryption work the secustack folks have been trying to coordinate between barbican/cinder/glance/nova17:04
openstackgerritMatt Riedemann proposed openstack/nova master: WIP: neutron: avoid redundant show_network calls in _get_physnet_tunneled_info  https://review.opendev.org/67442217:04
fungiso involves interrelated specs in all of them17:04
mriedemefried: not ptg, there was a forum session17:05
mriedemwith nova/cinder/glance17:05
mriedemjohn and dan were there from what i recall17:05
dansmithah right, I remember that for sure17:05
fungimostly hoping that if the idea has legs from nova's side, we don't end up with the corresponding bits implemented in other projects in train but not in nova until unpossible17:05
dansmithI just somehow hadn't come across this spec yet17:05
dansmithseems like mriedem's comments haven't been addressed in several days though17:06
efriedWe discussed that this morning in the meeting, stand by for log...17:06
efriedhttp://eavesdrop.openstack.org/meetings/image_encryption/2019/image_encryption.2019-08-05-13.00.log.html17:07
efriedmriedem: I kinda had to proxy for you design-wise, you prolly want to see whether what was suggested and "agreed upon" makes sense in light of your comments.17:07
*** udesale has quit IRC17:07
fungiand yeah, it seemed like the main reason they ended up needing to request a spec freeze exception was that they were having trouble getting folks to review it, but of course everyone's busy so it's not like i'm pointing fingers17:08
mriedemefried: you mean this? "mhen and i discussed that it would be the best option for now to make "image_key_id" immutable. So that is just can be set in the server create step."17:09
mriedemi think they missed the point17:09
mriedemi think the point i was trying to make in the nova spec was that we'd need a pre-filter to filter out hosts that don't support encrypted images17:09
mriedemlikely by using the combination of image_key_id on the image and some compute capabilities trait17:09
mriedemthat resolves issues around rolling upgrades with old computes and non-libvirt drivers17:10
*** aojeagarcia has quit IRC17:10
efriedoh, okay. I was just climbing online after weekend and hadn't reread the spec before that meeting, so I wasn't really swapped in.17:10
*** aojeagarcia has joined #openstack-nova17:10
mriedemit's the same idea is dansmith's disk format pre-filter,17:10
mriedemdon't land guests with an image on a driver that doesn't support the image17:10
efriedyeah, I get it now, and am remembering those comment threads.17:10
dansmithyeah, which is broken by this btw17:11
efriedno17:11
*** aojeagarcia has quit IRC17:11
efriedthat's filtering by disk_format, not container_format17:11
efriedthis will be adding a container_format filter.17:11
dansmithefried: isn't the disk_format changed in this case as well?17:11
mriedemi need to get lunch before a 1pm call17:11
efriedI don't think so dansmith17:11
efriedbecause the underlying disk_format isn't affected by encryption status17:12
efriediiuc17:12
dansmithI thought that the convo we had indicated that they didn't want the metadetails of the image exposed in the clear17:12
fungiit would be good to get them to say that in the spec if that's a design goal17:12
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities  https://review.opendev.org/67379017:12
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Scaffolding for Secure Boot for KVM/QEMU guests  https://review.opendev.org/67465717:12
efriedI don't know if I was there (read: paying attention, or comprehending things) when that conversation occured. But I thought the important thing was the image content. Why would it matter if the disk format was in the clear?17:13
efriedbut yeah, agree with fungi, that should be stated one way or another17:13
efried(it might be, in one of the other specs)17:13
fungithere are times when i miss having cross-project specs that tie these per-project specs together (and then i remember what an equal amount of pain that additional process was too)17:14
dansmithefried: yeah I dunno, just thought I recalled that being a thing17:15
*** mlavalle has quit IRC17:16
efriedso dansmith fungi perhaps we can take the approach of "spec freeze exception granted conditional upon reaching agreement on the spec details by XXX date"17:16
fungiit's good feedback for the spec, if nothing else. i expect luzi and mhen are afk by now though so are unlikely to answer until tomorrow17:16
dansmithefried: tbh, this seems like a really large thing to get an exception,17:16
efriedyes, and that's a problem - they're EU timezone and the meeting is at 6am Pacific17:16
dansmithespecially given the outstanding comments17:16
efriedIt didn't seem all that huge to me. But I guess this is why you need to be involved.17:17
efriedWhat I don't want to have happen is, all the other projects' stars align, but the effort gets punted to U purely because we didn't get enough eyes on the nova spec early enough to land it before freeze.17:18
dansmithI think there's a bit of papering over the details in the virt/compute side17:18
*** mlavalle has joined #openstack-nova17:18
*** mdbooth has joined #openstack-nova17:19
dansmiththey describe it as somewhat transparent in front of download, which defeats the stated goals, but then later make it sound like it's after download17:19
dansmithI'm adding some comments17:19
efriedOkay, thanks dansmith.17:20
efriedI think it will help with the cross-timezone iteration if we can codify the level of urgency for them to respond and/or edit.17:20
efriedLike giving them a date by which we need to have agreement, as suggested above.17:20
efriedunless you're saying you think it's a no-go regardless17:21
fungithanks dansmith! presumably the risk for an exception is higher if the implementation is going to have fingers into a lot of existing code. i don't know enough about nova to know how much entanglement the implementation pieces would be for nova. i'm mostly around to advocate for the use case from the security sig's perspective, and just to remind that cross-project efforts like this tend to need a bit17:21
fungiof timeline leniency due to trying to not expend extra community energy by having implementations misaligned between projects17:21
dansmithwell, to me, exceptions for specs and implementation are when it's like largely ready and well-reviewed and we just need a week to finish up the nits17:21
dansmithmriedem: what's your thinking on this?17:21
dansmithfungi: well, the spec seems to be a little confused about what layer this happens in, tbh, so I can't even really comment17:22
dansmithbut17:22
dansmiththe image handling code on the compute is largely maligned, complicated, and fragile, so...17:22
fungiyeah, i can't say i'm overly surprised... a lot of it has probably been there since aeons17:23
*** mdbooth has quit IRC17:23
fungimy main goal is to make sure we get expectations set as early as possible for the folks who are working on this, since there may be no point in pushing to get the implementations done in other projects until the u cycle if it's not going to be possible for nova in train17:24
fungiand i wouldn't want the other projects stuck maintaining code for an incomplete feature through an entire release17:25
*** psachin has quit IRC17:28
*** ociuhandu has quit IRC17:28
fungion a positive note, i think there's been a lot of progress getting this effort on all involved projects' radar in this cycle, which bodes well for earlier agreement on details in the next cycle if it needs to be deferred17:29
*** ociuhandu has joined #openstack-nova17:29
*** ash2307 has left #openstack-nova17:29
*** ociuhandu has quit IRC17:31
*** ociuhandu has joined #openstack-nova17:31
efrieddansmith: sounded like mriedem was lunching.17:33
efriedMeanwhile, how about the other one, mixed PCPU/VCPU in one instance17:33
dansmithefried: yep, saw, figured he can answer later17:33
dansmithefried: just commented on the image one, give me a few17:33
efriedOkay. Summary: It seems Stephen, Alex, and Sean have come to an agreement on the design. And it's strictly conditioned on the schedule around the cpu-resources impl.17:34
*** tssurya has quit IRC17:34
dansmithefried: ah, looks like mriedem was +0 during the meeting, and had some of the same concerns re: other drivers, so..17:34
dansmithon the image one I mean17:35
efriedy17:35
*** ociuhandu has quit IRC17:35
dansmithefried: I'm confused, I thought the poll on the ML was that shared+dedicated on one host had no major need from ops17:35
efriedI don't remember that hitting the ML. I just know this is a big deal for the use case involving CPU priority17:36
efriedStemming from Jay's suggestion that, instead of supporting CPU priorities in any native way, we have the operator designate their "high priority" CPUs to the PCPU pool17:37
efriedso in order to have some high and some normal priority CPUs in one instance, we need to be able to support PCPU+VCPU in one instance.17:37
efried(are you thinking of the "NUMA and non-NUMA instances on one host" issue?)17:39
openstackgerritEric Fried proposed openstack/nova master: DNM: Test blank sdk placement proxy  https://review.opendev.org/67462517:41
dansmithefried: yeah, just found it17:41
efriedmordred: I ran that locally (against just one of the failing tests) and it seems to make it happy enough) ---^17:41
efriedbig-ish hammer17:42
*** rpittau is now known as rpittau|afk17:42
dansmithefried: is it really necessary for the user to pick which of their virtual cpus are the dedicated ones?17:49
dansmithlike, I thought the point here was that a flavor would request PCPU=2 and VCPU=2 and get two of each?17:50
aspiersis it just me or could the note about base64 encoding in https://docs.openstack.org/nova/latest/user/metadata.html#user-data be a lot more helpful?17:50
aspiersIMHO it's expecting too much of the average user to know how to base64 encode stuff17:51
efrieddansmith: It is *not* necessary (and Sean & Stephen made it clear that this was never going to be supported) to be able to say which *host* CPUs you get.17:51
aspiersOr if it's not, that means I'm dumber than the average user, because I'm going to have to look it up17:51
efrieddansmith: It's also not necessarily required for you to be able to dictate the set of *virtual* CPU IDs for each.17:51
efrieddansmith: But it is necessary for the VM to be able to figure out which is which once they are assigned.17:52
dansmithefried: certainly not the host cpus, but the mask is letting them choose which vcpus right?17:52
dansmithefried: sure, exposing which is which is fine17:52
efrieddansmith: Isn't that already supported for numa-isms?17:52
fungiaspiers: could probably use some additional prose, yes. short answer is `echo foo|base64`17:52
dansmithbut making them request a complicated mask instead of "two dedicated please" is kinda crazy17:52
mriedemaspiers: the CLI does it for you https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L66917:52
aspiersfungi: thanks. I find it kind of astonishing that the CLI doesn't just do it for you17:52
mriedemso the doc is talking about the API but confusing when giving a CLI example17:52
aspiersmriedem: hah OK17:52
aspiersthat's also astonishing, because it suggests to me that hardly anyone is using this feature?17:53
aspiersor they're just not reading the docs17:53
efrieddansmith: I'm not an expert here, nor have I been following the technical details deeply. But I suspect if a mask is being suggested, it's for compat with some other syntax, like the one for NUMA.17:53
dansmithefried: yes, specifying the numa topology is done via complex masking which is pretty gross17:53
fungiaspiers: i can say i've used it for personal systems, but i don't remember which docs i read17:54
dansmithefried: sure, but when that was defined, we didn't have anything else, as we do today17:54
aspiersmriedem, fungi: having said that, I already tried passing unencoded userdata and I get this:17:54
aspiers__init__.py[WARNING]: Unhandled non-multipart (text/x-not-multipart) userdata: 'b'network:'...'17:54
aspiersmaybe that's a separate issue17:54
efrieddansmith: I can't think of a reason why the mask would be a required thing, vs just a count as you say. But again, that's without having a bunch of context, and without rereading all the comment history leading up to whatever we've landed on at this point.17:55
efriedIt would certainly reduce the test surface17:55
dansmithefried: well, I found a comment from stephenfin which says it was rejected because "it didn't let you choose which ones"17:55
efriedthough I don't imagine it would make much difference on the code side17:55
dansmithbut no explanation of why that's important17:55
fungiaspiers: also i want to say the userdata workflow/model is sort of copied from ec2 so it may have been assumed by the authors that people were familiar with ec2... but yeah docs can always stand to be improved17:55
efriedsince we would (again, guessing) reuse the code that does it for the numa pinsets.17:55
mordredefried: woot17:56
dansmithI guess if you want your dedicated cpu to be one of the ones with a large amount of memory or something, but we're just getting to the point where you're defining all the legacy hardware attributes fo the system and we lose all flexibility17:56
efrieddansmith: I'm pretty sure "just count 'em" is going to be supported as well, just like it is for numa split17:56
efriedbut if we want to say that's the only thing...17:57
efriedI don't see a reason why that would be a problem.17:57
efriedAgain, as long as the VM can figure out which is which.17:57
efriedoh17:57
efriedperhaps it's for when we *do* have numa split17:57
efriedbecause then you would have to be able to say which ones are P/V and which of those are from which NUMA node17:57
efriedbut we could add pinset syntax support at that point?? Not sure.17:58
dansmiththat's what I just said above... if you really want your dedicated cpus to specifically be somewhere17:59
dansmithbut still17:59
dansmithif you want to arrange your DIMMs in a specific order, maybe you want real hardware18:00
dansmithhonestly, I dunno what to say about this one for SFE18:01
dansmithI've seen a couple patches in his code for this,18:01
dansmithand it reports PCPUs to placement as inventory18:02
mriedemtraditionally, for both of these specs, if we're past spec freeze and it's not clear on either, and we're 5 weeks from feature freeze, i'd say there is no point in granting an exception for Train18:02
dansmithI assume that if you put resources:PCPU=1 in a flavor, it'll break everything18:02
mriedemif the goal is to just approve the specs to make life easier for re-approvals in U, then i guess....but i don't see either of these making Train18:02
openstackgerritAdam Spiers proposed openstack/nova master: Don't claim that CLI user data requires manual base64 encoding  https://review.opendev.org/67466518:04
*** spatel has quit IRC18:06
openstackgerritAdam Spiers proposed openstack/nova master: Don't claim that CLI user data requires manual base64 encoding  https://review.opendev.org/67466518:06
openstackgerritMatt Riedemann proposed openstack/nova master: doc: fix physets typo  https://review.opendev.org/67466718:09
aspierskashyap: are you still working on https://review.opendev.org/#/c/673790/ ?18:11
aspierskashyap: because it's definitely broken :)18:11
aspiersif you've already gone I guess I'll try to fix it when I have time18:11
aspierskashyap: well, reviewed anyway18:18
kashyapaspiers: Yes, it's still broken :-)18:23
kashyapaspiers: Ah, you reviewed, will look :-)18:24
aspierskashyap: I didn't see any tests in there18:24
kashyapThanks!  And hehe, you were too polite in saying tests were "missing"18:24
aspierskashyap: did you forget to git add?18:24
aspiersor it's just WIP18:24
kashyapaspiers: I was first getting the parsing right.  The tests are only half-done, and I'm ill :-(18:24
aspiersoh sorry to hear that :-(((18:24
aspierswell, I think I've pointed out the parsing issues18:25
kashyap(Before I need to board a flight early tomm.  The 4 hours kayaking yesterday)18:25
aspiersor maybe I misunderstood18:25
aspiersugh18:25
kashyapThat's what happens if you're an "indoors enthusiast" and go do sportsy things :D18:25
kashyapaspiers: It's WIP.  It will remain dormant until I get back I think.  As nobody else has interest in this area, besides you :D18:26
aspierskashyap: well, when you've finished making changes, push everything you have, mark as WIP, and maybe I can fix it while you're away18:26
aspierskashyap: include the half-done tests so I don't have to start them from scratch18:27
kashyapaspiers: Yeah, first need to go run an errand, will push it from here or tomm from the aiport...18:27
kashyapThanks for the help and review, much appreciated!18:28
aspierssure18:28
aspiersget well soon and have a great vacation!18:29
*** betherly has joined #openstack-nova18:30
*** betherly has quit IRC18:34
*** spatel has joined #openstack-nova18:47
*** spsurya has quit IRC18:49
*** maciejjozefczyk has quit IRC18:52
*** cdent has quit IRC18:59
*** lpetrut has quit IRC19:05
*** igordc has joined #openstack-nova19:08
openstackgerritEric Fried proposed openstack/nova master: WIP: Limit get_sdk_adapter to requested service type  https://review.opendev.org/67467819:12
efriedmriedem: ^ and dep ought to get rid of those warnings you mentioned earlier https://logs.opendev.org/57/666857/6/check/nova-live-migration/a379339/logs/screen-n-cpu.txt.gz#_Aug_01_21_21_25_51795719:13
openstackgerritEric Fried proposed openstack/nova master: DNM: Test blank sdk placement proxy  https://review.opendev.org/67462519:29
efriedmordred: Slight adjustment gets back to the previous behavior (but is even more hacky) ^19:31
efriedsdk isn't running nova tests, is it? Cause we would have a chicken/egg there.19:31
*** betherly has joined #openstack-nova19:41
*** betherly has quit IRC19:45
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities  https://review.opendev.org/67379019:49
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Introduce libvirt/QEMU version constants for Secure Boot  https://review.opendev.org/67465719:49
*** betherly has joined #openstack-nova20:22
*** mdbooth has joined #openstack-nova20:23
*** mdbooth has quit IRC20:23
*** betherly has quit IRC20:27
openstackgerritDustin Cowles proposed openstack/nova master: Provider config file schema and loader  https://review.opendev.org/67334120:33
*** spatel has quit IRC20:42
*** betherly has joined #openstack-nova20:43
*** betherly has quit IRC20:47
*** betherly has joined #openstack-nova21:03
*** eharney has quit IRC21:07
*** betherly has quit IRC21:08
*** weshay is now known as weshay_dentist21:09
*** ircuser-1 has quit IRC21:10
mordredefried: I stepped afk for a minute and had an idea of what I should do WRT the fixture we're talking about ...21:15
efriedoh, good, cause my latest attempt worked (passed tests) but failed miserably (bypassed the bit that was supposed to make the warnings go away)  :(21:15
mordredefried: so, hopefully i'll have something non-hacky for you to look at tomorrow21:15
mordredefried: HAHAHAHA.21:15
efriedlaugh it up fuzzball.21:15
mordredI mean, that's not funny - but it's also funny - so, yeah - let's fix it properly21:16
mordred(also, I think it'll remove some boilerplate in the sdk tests - so win/win all around)21:16
efriednice.21:16
efriedOkay, I'll quit hacking at https://review.opendev.org/#/c/674625/ for the moment then.21:16
efriedthanks mordred21:16
mordredefried: hopefully I'm not completely high :)21:19
efriedmordred: Whatever you do will be better than what I was about to have to do in nova.21:19
*** mriedem has quit IRC21:19
efriedmordred: which was basically mock a proxy object by hand21:19
mordredefried: yeah. let's not do that - there's WAY too much magic under the scenes21:20
mordred:)21:20
efriedtotally21:20
*** mriedem has joined #openstack-nova21:21
efriedmelwitt, mriedem, sean-k-mooney: Any idea why this [1] needs its own RequestContext, instead of reusing the one from the req.environ [2] which is just a couple hops up the call stack?21:26
efried[1] https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/tenant_networks.py#L7021:26
efried[2] https://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/tenant_networks.py#L8021:26
efriedI guess it's because it needs to change the proj/user. Can we use temporary_mutation for that?21:28
*** markvoelker has quit IRC21:29
mriedemprobably. why does it matter? this is a deprecated api as far as i know.21:29
melwittefried: mriedem or sean-k-mooney would know better than I, but my guess is the user_id needs to be ignored for that call (maybe neutron would otherwise return only networks owned by the project + user combo). I dunno about temporary mutation to do it, sounds like that would probably work21:30
efriedmriedem: I'm just trying to hunt down all places where we create a RequestContext and either collapse them or make sure they get the proper global_request_id from whatever invoked them.21:31
*** betherly has joined #openstack-nova21:44
*** betherly has quit IRC21:49
*** whoami-rajat has quit IRC21:58
*** mlavalle has quit IRC22:04
*** betherly has joined #openstack-nova22:05
*** rcernin has joined #openstack-nova22:06
*** betherly has quit IRC22:09
openstackgerritMerged openstack/nova master: Add functional test coverage for bug 1724172  https://review.opendev.org/51255322:11
openstackbug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/172417222:11
*** spatel has joined #openstack-nova22:12
*** avolkov has quit IRC22:14
*** BjoernT has quit IRC22:30
openstackgerritEric Fried proposed openstack/nova master: WIP: Always set a global_request_id in RequestContext  https://review.opendev.org/67413822:33
openstackgerritEric Fried proposed openstack/nova master: WIP: Correct global_request_id sent to Placement  https://review.opendev.org/67412922:33
efriedmelwitt, mriedem: Okay, so I reordered the stack and tried to make nova's RequestContext always dtrt - i.e. a) always set a reasonable global_request_id and b) overwrite threadlocal context always and only when appropriate.22:34
openstackgerritDustin Cowles proposed openstack/nova master: Provider config file schema and loader  https://review.opendev.org/67334122:41
*** markvoelker has joined #openstack-nova22:46
*** tkajinam has joined #openstack-nova22:56
*** markvoelker has quit IRC23:20
*** betherly has joined #openstack-nova23:27
*** betherly has quit IRC23:32
*** spatel has quit IRC23:33
*** owalsh_ has joined #openstack-nova23:58
*** artom has joined #openstack-nova23:59
« Sunday, 2019-08-04 Index Tuesday, 2019-08-06 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!