| *** owalsh has quit IRC | 00:01 | |
| *** betherly has joined #openstack-nova | 00:08 | |
| *** betherly has quit IRC | 00:13 | |
| *** gyee has quit IRC | 00:19 | |
| *** mriedem has quit IRC | 00:38 | |
| eandersson | What populates the placement aggregates hosts? | 00:39 |
|---|---|---|
| eandersson | We have some hosts that are not showing up under aggregates in placement. | 00:40 |
| *** markvoelker has joined #openstack-nova | 00:41 | |
| openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.76: Add delete_on_termination to volume-attach API https://review.opendev.org/673485 | 00:45 |
| *** markvoelker has quit IRC | 00:51 | |
| *** igordc has quit IRC | 01:00 | |
| *** markvoelker has joined #openstack-nova | 01:17 | |
| *** spsurya has joined #openstack-nova | 01:17 | |
| *** betherly has joined #openstack-nova | 01:21 | |
| *** betherly has quit IRC | 01:26 | |
| *** altlogbot_0 has quit IRC | 01:37 | |
| *** markvoelker has quit IRC | 01:38 | |
| *** altlogbot_1 has joined #openstack-nova | 01:38 | |
| *** tetsuro has joined #openstack-nova | 01:39 | |
| openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | 02:04 |
| *** tetsuro has quit IRC | 02:12 | |
| *** weshay_dentist is now known as weshay | 02:13 | |
| *** ricolin has joined #openstack-nova | 02:16 | |
| *** betherly has joined #openstack-nova | 02:23 | |
| *** betherly has quit IRC | 02:27 | |
| *** slaweq has quit IRC | 02:35 | |
| *** BjoernT has joined #openstack-nova | 02:41 | |
| *** markvoelker has joined #openstack-nova | 02:42 | |
| *** betherly has joined #openstack-nova | 02:43 | |
| *** tetsuro has joined #openstack-nova | 02:44 | |
| *** betherly has quit IRC | 02:48 | |
| *** hongbin has joined #openstack-nova | 02:49 | |
| *** tetsuro_ has joined #openstack-nova | 02:51 | |
| *** tetsuro has quit IRC | 02:53 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 02:58 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | 02:58 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | 02:58 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | 02:58 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | 02:58 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | 02:58 |
| dustinc | mriedem, efried: so that is a quick PoC to lazy-initialize the SDK connection. I think the implementation needs a bit more thought but wanted to push up something to try it out and get more feedback. Let me know what you think.... | 02:58 |
| *** BjoernT_ has joined #openstack-nova | 02:58 | |
| *** BjoernT has quit IRC | 02:59 | |
| *** betherly has joined #openstack-nova | 03:04 | |
| *** whoami-rajat has joined #openstack-nova | 03:08 | |
| *** mkrai has joined #openstack-nova | 03:09 | |
| *** betherly has quit IRC | 03:09 | |
| *** markvoelker has quit IRC | 03:15 | |
| *** tetsuro_ has quit IRC | 03:17 | |
| *** tetsuro has joined #openstack-nova | 03:55 | |
| *** hongbin has quit IRC | 04:11 | |
| *** BjoernT_ has quit IRC | 04:12 | |
| *** ircuser-1 has joined #openstack-nova | 04:34 | |
| *** udesale has joined #openstack-nova | 04:38 | |
| *** jhesketh has joined #openstack-nova | 04:54 | |
| *** janki has joined #openstack-nova | 05:04 | |
| *** Luzi has joined #openstack-nova | 05:05 | |
| *** tetsuro has quit IRC | 05:23 | |
| *** tetsuro has joined #openstack-nova | 05:24 | |
| *** tetsuro has quit IRC | 05:27 | |
| *** markvoelker has joined #openstack-nova | 05:28 | |
| *** tetsuro has joined #openstack-nova | 05:30 | |
| *** markvoelker has quit IRC | 05:33 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242 | 05:34 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Refactor some methods for reuse by Cyborg-related code. https://review.opendev.org/673734 | 05:34 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | 05:34 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 05:34 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: WIP: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML. https://review.opendev.org/631245 | 05:34 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 05:34 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726 | 05:34 |
| *** tkajinam has quit IRC | 05:38 | |
| *** tkajinam has joined #openstack-nova | 05:38 | |
| *** jchhatbar has joined #openstack-nova | 05:38 | |
| *** jchhatbar has quit IRC | 05:41 | |
| *** janki has quit IRC | 05:41 | |
| *** jchhatbar has joined #openstack-nova | 05:42 | |
| *** jchhatbar has quit IRC | 05:43 | |
| *** markvoelker has joined #openstack-nova | 06:36 | |
| *** belmoreira has joined #openstack-nova | 06:36 | |
| *** belmoreira has quit IRC | 06:37 | |
| *** belmoreira has joined #openstack-nova | 06:37 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:46 | |
| *** xek has joined #openstack-nova | 07:00 | |
| *** xek has quit IRC | 07:03 | |
| *** tssurya has joined #openstack-nova | 07:04 | |
| *** slaweq has joined #openstack-nova | 07:07 | |
| *** markvoelker has quit IRC | 07:09 | |
| *** aojea has joined #openstack-nova | 07:17 | |
| *** tesseract has joined #openstack-nova | 07:30 | |
| *** jaosorior has quit IRC | 07:34 | |
| *** ralonsoh has joined #openstack-nova | 07:43 | |
| *** cdent has joined #openstack-nova | 07:44 | |
| *** rpittau|afk is now known as rpittau | 07:46 | |
| openstackgerrit | Gorka Eguileor proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190 | 08:02 |
| *** rcernin has quit IRC | 08:04 | |
| *** ociuhandu has joined #openstack-nova | 08:05 | |
| *** ociuhandu has quit IRC | 08:05 | |
| *** xek has joined #openstack-nova | 08:06 | |
| *** tkajinam has quit IRC | 08:06 | |
| *** ccamacho has joined #openstack-nova | 08:07 | |
| *** kashyap has quit IRC | 08:07 | |
| *** ccamacho has quit IRC | 08:08 | |
| *** ccamacho has joined #openstack-nova | 08:08 | |
| *** lpetrut has joined #openstack-nova | 08:10 | |
| *** helenafm has joined #openstack-nova | 08:12 | |
| openstackgerrit | ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407 | 08:13 |
| *** tetsuro has quit IRC | 08:14 | |
| *** avolkov has joined #openstack-nova | 08:16 | |
| *** ratailor has joined #openstack-nova | 08:17 | |
| *** ociuhandu has joined #openstack-nova | 08:17 | |
| *** ociuhandu has quit IRC | 08:30 | |
| *** jaosorior has joined #openstack-nova | 08:35 | |
| *** jaosorior has quit IRC | 08:37 | |
| *** jaosorior has joined #openstack-nova | 08:41 | |
| *** panda|pubholiday is now known as panda | 08:49 | |
| *** ociuhandu has joined #openstack-nova | 08:51 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 08:53 |
| *** sridharg has joined #openstack-nova | 08:54 | |
| *** tetsuro has joined #openstack-nova | 08:58 | |
| *** tetsuro has quit IRC | 09:00 | |
| *** tetsuro has joined #openstack-nova | 09:01 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | 09:02 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Testing I41b7c1653c6a887ee4b08e588c5d422409aebfba with grenade https://review.opendev.org/674760 | 09:02 |
| *** tetsuro has quit IRC | 09:03 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990 | 09:03 |
| *** ociuhandu has quit IRC | 09:05 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990 | 09:05 |
| *** owalsh_ is now known as owalsh | 09:10 | |
| stephenfin | gmann: Could you take a look at https://review.opendev.org/#/c/672805/ this week so we can get https://review.opendev.org/#/c/672800/ merged ? | 09:29 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 09:36 |
| *** ociuhandu has joined #openstack-nova | 09:47 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'nova.objects.instance_numa_topology' https://review.opendev.org/671789 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary try-catch around 'getCPUMap' https://review.opendev.org/671790 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove legacy '_from_dict' functions https://review.opendev.org/537414 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: claims: Remove useless caching https://review.opendev.org/671791 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances' https://review.opendev.org/672565 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary argument https://review.opendev.org/674396 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 09:53 |
| *** elod has quit IRC | 09:58 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Poison context usage in periodic tasks https://review.opendev.org/542891 | 09:59 |
| *** mgoddard has quit IRC | 10:03 | |
| *** elod has joined #openstack-nova | 10:05 | |
| *** mgoddard has joined #openstack-nova | 10:07 | |
| *** yaawang has quit IRC | 10:21 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/rocky: Remove redundant group host setup https://review.opendev.org/674770 | 10:32 |
| *** elod has quit IRC | 10:36 | |
| *** bbowen has quit IRC | 10:38 | |
| *** yaawang has joined #openstack-nova | 10:38 | |
| *** yaawang has quit IRC | 10:44 | |
| *** elod has joined #openstack-nova | 10:48 | |
| *** jaosorior has quit IRC | 11:02 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add '[compute] cpu_dedicated_set' option https://review.opendev.org/671792 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename exception argument https://review.opendev.org/671795 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.get_host_numa_usage_from_instance' https://review.opendev.org/671797 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.host_topology_and_format_from_host' https://review.opendev.org/671798 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'hardware.instance_topology_from_instance' https://review.opendev.org/671799 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework 'hardware.numa_usage_from_instances' https://review.opendev.org/672565 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split NUMA object tests https://review.opendev.org/672336 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove unnecessary argument https://review.opendev.org/674396 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103 | 11:04 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 11:04 |
| *** ociuhandu has quit IRC | 11:13 | |
| *** ociuhandu has joined #openstack-nova | 11:16 | |
| *** ociuhandu has quit IRC | 11:21 | |
| *** ivve has joined #openstack-nova | 11:22 | |
| openstackgerrit | Merged openstack/nova master: Add nova-osprofiler-redis job to experimental queue https://review.opendev.org/674326 | 11:22 |
| *** tbachman has quit IRC | 11:22 | |
| openstackgerrit | Merged openstack/nova master: doc: fix physets typo https://review.opendev.org/674667 | 11:23 |
| *** jaosorior has joined #openstack-nova | 11:31 | |
| *** ociuhandu has joined #openstack-nova | 11:35 | |
| *** bbowen has joined #openstack-nova | 11:36 | |
| *** ociuhandu has quit IRC | 11:40 | |
| *** yaawang has joined #openstack-nova | 11:43 | |
| *** tbachman has joined #openstack-nova | 11:45 | |
| *** ociuhandu has joined #openstack-nova | 11:49 | |
| *** panda is now known as panda|lunch | 11:49 | |
| *** brinzhang_ has joined #openstack-nova | 11:50 | |
| *** brinzhang has quit IRC | 11:50 | |
| *** brinzhang has joined #openstack-nova | 11:50 | |
| *** brinzhang_ has quit IRC | 11:54 | |
| *** aarents has quit IRC | 12:00 | |
| *** ociuhandu has quit IRC | 12:01 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add the virt driver interface for claim and unclaim the devices https://review.opendev.org/670782 | 12:01 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Moves the allocation retrieving early https://review.opendev.org/670783 | 12:01 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Calling the virt driver's claim/unclaim_for_instance in resource tracker https://review.opendev.org/670784 | 12:01 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver https://review.opendev.org/671388 | 12:01 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager https://review.opendev.org/670787 | 12:01 |
| *** zbr is now known as zbr|lunch | 12:01 | |
| openstackgerrit | Alex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222 | 12:01 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus https://review.opendev.org/671398 | 12:01 |
| *** markvoelker has joined #openstack-nova | 12:04 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova stable/stein: Add glanceclient method call debug log https://review.opendev.org/674791 | 12:05 |
| *** markvoelker has quit IRC | 12:06 | |
| *** markvoelker has joined #openstack-nova | 12:06 | |
| sean-k-mooney | efried: have you seen https://review.opendev.org/#/c/674726/1 that would be a hard blocker on cyborg integration proceeding in this cylce if the only instance action that work are basically spawn and delete instance | 12:11 |
| sean-k-mooney | not supporting live migration in v1 is resonable but i think everything else shoudl be supported IMO or its not ready to be integrated. | 12:14 |
| cdent | tssurya: are you still working on https://review.opendev.org/623558 ? I've been doing some profiling in the scheduler and it's definitely clear that multiple-queries to the db is problematic and that stacks approach would be better | 12:17 |
| tssurya | cdent: feel free to update the patch and work on it | 12:19 |
| tssurya | I am not working on it atm | 12:20 |
| cdent | okay. I'm not sure if I will have time or not, but I'll see if I can use it as a starting point | 12:20 |
| tssurya | I guess that patch had that typo https://review.opendev.org/#/c/623558/2/nova/scheduler/host_manager.py@892 which made it a bit wobly | 12:21 |
| tssurya | cdent: thanks :) | 12:21 |
| cdent | :) | 12:21 |
| *** mvkr has quit IRC | 12:21 | |
| *** tbachman has quit IRC | 12:21 | |
| sean-k-mooney | jangutter: stephenfin thanks for reviewing https://review.opendev.org/#/c/672834/2 ill adress the nits and respin it after lunch | 12:21 |
| jangutter | sean-k-mooney: I was thinking about it afterwards: have you seen bridges pop up with ageing_time != 300 ? | 12:22 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Add DeviceManager to the libvirt virt driver https://review.opendev.org/671388 | 12:25 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Populates the existing mediated devices in the libvirt device manager https://review.opendev.org/670787 | 12:25 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Using the claim/unclaim_for_instance for mdevs https://review.opendev.org/671222 | 12:25 |
| openstackgerrit | Alex Xu proposed openstack/nova master: Adds functional test for creating the instance with vgpus https://review.opendev.org/671398 | 12:25 |
| *** tbachman has joined #openstack-nova | 12:25 | |
| *** udesale has quit IRC | 12:32 | |
| *** udesale has joined #openstack-nova | 12:32 | |
| *** hongbin has joined #openstack-nova | 12:34 | |
| sean-k-mooney | jangutter: without the patch? | 12:36 |
| sean-k-mooney | jangutter: or with it | 12:36 |
| jangutter | sean-k-mooney: with the patch, leaving out _setting_ ageing_time. | 12:36 |
| sean-k-mooney | well it should default to your kernel default in that case | 12:37 |
| sean-k-mooney | so it will be 300 unless you have changed it with something like sysctl.conf | 12:37 |
| *** zbr|lunch is now known as zbr | 12:38 | |
| jangutter | sean-k-mooney: yep, or something helpful like NetworkManager changes it for you, etc. Was just wondering if it wouldn't make sense to have the functional test check for 300. | 12:38 |
| sean-k-mooney | for ovs with hybrid plug we woudl still be hardcoding it to 0 | 12:38 |
| sean-k-mooney | ah | 12:38 |
| sean-k-mooney | well we could but i dont know if those helpful service could break it | 12:39 |
| sean-k-mooney | we could maybe assert its no 0 but im not sure if that would always be the case | 12:39 |
| sean-k-mooney | do you want me to add one for that usecase? as i said im not sure if it would always be correct but i suspect it would be | 12:41 |
| *** mkrai has quit IRC | 12:41 | |
| jangutter | sean-k-mooney: I think, whatever choice is made, there's going to be some edge case system that might break it. Both checking != 0 and == 300 could fail so I'd just say pick one and add a NOTE like stephenfin said. | 12:41 |
| sean-k-mooney | ok ill do !=0 and add a note and if we get a bug we can either nuke the test or close it as wont fix | 12:42 |
| sean-k-mooney | or actully maybe i can check sysfs to see if there is a default | 12:43 |
| sean-k-mooney | and skip the test if the default ageing time is 0 | 12:43 |
| jangutter | sean-k-mooney: that might be useful, but I'm almost tempted to say that might point to some bad defaults ppl should investigate. | 12:44 |
| sean-k-mooney | it might but how many people are going to realisticaly run the os-vif functional test beside us | 12:45 |
| jangutter | sean-k-mooney: yep, realistically, the only people interested would be people packaging (i.e. distros). | 12:45 |
| sean-k-mooney | looks like there is no way to set teh bridge againg time globally so i think we are safe with !=0 | 12:50 |
| *** elod is now known as elod_off | 12:50 | |
| sean-k-mooney | e.g. via the kernel networkmanager could always change thinks but that is out of scope for this patch | 12:50 |
| stephenfin | Does boot from volume imply we will not have any swap or ephemeral disk also, or does it just apply to the root disk? | 12:52 |
| sean-k-mooney | it just applies to the root disk | 12:52 |
| sean-k-mooney | if the flaovr has swap those should be local | 12:52 |
| stephenfin | Does that mean this is wrong? https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L400-L401 | 12:52 |
| sean-k-mooney | same for ephemeral | 12:52 |
| stephenfin | it should read something like | 12:53 |
| stephenfin | if is_bfv: | 12:53 |
| stephenfin | disk = (flavor.swap / 1024) + flavor.ephemeral_gb | 12:53 |
| stephenfin | else: | 12:53 |
| sean-k-mooney | 1 that is only used for nova-manage | 12:54 |
| stephenfin | disk = (flavor.swap / 1024) + flavor.ephemeral_gb + flavor.root_gb | 12:54 |
| sean-k-mooney | 2 its a sligtly differet impleatnion of what we do here https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L436-L442 | 12:54 |
| stephenfin | Yeah, and an incorrect one? | 12:54 |
| sean-k-mooney | yep i think so | 12:55 |
| sean-k-mooney | but that is not the only reason that that is slightly broken | 12:55 |
| sean-k-mooney | that being resources_from_flavor | 12:56 |
| stephenfin | yeah, it also shouldn't be setting things to 0. placement doesn't allow that | 12:56 |
| sean-k-mooney | well that is not what i ment but its another bug | 12:56 |
| sean-k-mooney | its ignoring the image which means when you use the nova manage command that executes that function it can ignore the traits on the image | 12:58 |
| sean-k-mooney | actully its not broken | 12:58 |
| sean-k-mooney | its correct | 12:58 |
| sean-k-mooney | rather ((0 if is_bfv else flavor.root_gb) + | 12:58 |
| sean-k-mooney | swap_in_gb + flavor.ephemeral_gb) | 12:58 |
| sean-k-mooney | is correct | 12:58 |
| stephenfin | how? | 12:58 |
| sean-k-mooney | the bracket after root_gb | 12:59 |
| sean-k-mooney | the if only applies to the root gb | 12:59 |
| sean-k-mooney | i guess if you had not swap or ephemeral_gb it woudl still be wrong | 12:59 |
| stephenfin | ah, indeed | 12:59 |
| stephenfin | I missed that. Good spot! | 13:00 |
| *** mriedem has joined #openstack-nova | 13:00 | |
| *** eharney has joined #openstack-nova | 13:00 | |
| stephenfin | Yeah, we should be checking for that but it's not as serious | 13:00 |
| sean-k-mooney | that is handel in the other implemataion here https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L456-L459 | 13:00 |
| sean-k-mooney | if you want to fix it just condtionally append https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L406 | 13:01 |
| *** zhouyao has joined #openstack-nova | 13:07 | |
| *** ociuhandu has joined #openstack-nova | 13:08 | |
| *** mvkr has joined #openstack-nova | 13:11 | |
| *** panda|lunch is now known as panda | 13:12 | |
| efried | dustinc: left a comment. Better as a @property so you don't have to do icky things like passing arbitrary *args, **kwargs or method names as strings | 13:18 |
| openstackgerrit | Chris Dent proposed openstack/nova master: add InstanceList.get_all_uuids_by_hosts() method https://review.opendev.org/623557 | 13:19 |
| openstackgerrit | Chris Dent proposed openstack/nova master: single pass instance info fetch in host manager https://review.opendev.org/623558 | 13:19 |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: add profiling to scheduler https://review.opendev.org/674810 | 13:19 |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Play with cache of host mappings in nova scheduler https://review.opendev.org/674811 | 13:19 |
| cdent | mriedem: then of that ^ stack has some interesting observations about host states | 13:19 |
| cdent | s/then/the end/ | 13:19 |
| sean-k-mooney | cdent: sylvain is on vaction for a few weeks so i or someone else on the team will pick up his placement audit patch | 13:21 |
| sean-k-mooney | cdent: quick question on https://review.opendev.org/#/c/670112/2/nova/cmd/manage.py@2764 | 13:21 |
| sean-k-mooney | cdent: are you asserting that pagination should not be required | 13:21 |
| cdent | hi sean-k-mooney , reading | 13:21 |
| sean-k-mooney | e.g. i can just just remove that not/question | 13:21 |
| cdent | sean-k-mooney: yes, just remove that note, I think. as there's no plan to do pagination (server-side) in placement | 13:22 |
| sean-k-mooney | cool i think the other comment does need to be address | 13:22 |
| cdent | yes | 13:22 |
| sean-k-mooney | i wont get to this today more then likely but ill try and get to it tomrrow or the day after assumeing someone else doesnt pick it up in the mean time | 13:23 |
| mriedem | cdent: where have i seen host mapping caching before.... https://review.opendev.org/#/c/663388/ :) | 13:23 |
| cdent | mriedem: somehow I am not surprised | 13:23 |
| zhouyao | hi sean-k-mooney, could you check this patch? it's been two weeks. https://review.opendev.org/#/c/621646 | 13:23 |
| *** hongbin has quit IRC | 13:24 | |
| cdent | mriedem: i'm confused about the track_instance_changes stuff. why be dependent on that? | 13:24 |
| sean-k-mooney | zhouyao: yes i can take a look but you will need to get input form the core team also. ill try and review again today. | 13:25 |
| cdent | mriedem: hrmm, yours is much more...robust | 13:26 |
| cdent | or at least wordy | 13:26 |
| efried | sean-k-mooney: I tend to agree re cyborg blocking instance operations. I went to figure out what had been committed to in the spec, and it's a tad wobbly, but the approved spec points to this (open) document in the cyborg repo [1] that seems to declare support for things like pause and shelve. | 13:26 |
| efried | [1] https://review.opendev.org/#/c/605237/4/specs/train/approved/instance-ops.rst | 13:26 |
| sean-k-mooney | zhouyao: i see you have added mriedem and stephenfin to the review list i would reach out to alex_xu too | 13:26 |
| *** ratailor has quit IRC | 13:27 | |
| sean-k-mooney | efried: we had it in the spec for last cycle. or at least discussed it but then we removed it form the spec this cycle | 13:27 |
| mriedem | cdent: "i'm confused about the track_instance_changes stuff. why be dependent on that?" you mean yours or mine? | 13:27 |
| mriedem | mine isn't dependent on jay's series | 13:27 |
| sean-k-mooney | efried: a yes we moved it to cyborg this cycle intead of in the nova spec | 13:27 |
| efried | it should really have been in this spec, but people kept complaining it was too long. | 13:28 |
| sean-k-mooney | efried: ya. that said we did disucss this at some lent both in person at the ptg and last cycle | 13:29 |
| efried | sean-k-mooney: Do you remember what was agreed upon? | 13:29 |
| sean-k-mooney | i though it was everything bar live migration | 13:29 |
| sean-k-mooney | but basically https://review.opendev.org/#/c/605237/4/specs/train/approved/instance-ops.rst i think is more or less what i was expecting | 13:30 |
| cdent | mriedem: I mean in yours. Why even mention that config setting? The idea is that if you got to HostMapping, use the cache. it seems that at least some of the time we hit "# Host is running old version, or updates aren't flowing." | 13:30 |
| efried | sean-k-mooney: I maybe remember Sundar talking about this being an interim step in the overall strategy, where subsequent patches will implement support and remove the blockers one by one. | 13:35 |
| sean-k-mooney | efried: perhaps but normally we just dont expost the feature to the user until its done | 13:35 |
| sean-k-mooney | which in this case would mean putting the patch that reads the flavor extra spec at the end | 13:36 |
| mriedem | "updates aren't flowing" == track_instance_changes=False | 13:36 |
| mriedem | when HostState.updated could be Falsey I'd have to check | 13:36 |
| mriedem | i don't mind removing the mention of the config option in my commit message though | 13:36 |
| efried | sean-k-mooney: In any case, I put a hold on the bottom patch, which is something we do anyway on a series like this until it's closer to done. | 13:37 |
| *** zhouyao has quit IRC | 13:37 | |
| sean-k-mooney | i saw that there has been some work started on a fake driver and some tempset tests | 13:37 |
| efried | yes. I understand they've been having a tough time with... follow through from... previously committed resources... | 13:38 |
| sean-k-mooney | i only have a 3 day week this week but im hoping to be able to try out some of this in the next week or two | 13:38 |
| mriedem | hmm, i think set_update_time_on_success isn't using what it once did (RequestSpec vs HostState) | 13:38 |
| mriedem | oh nvm | 13:39 |
| sean-k-mooney | efried: well it does look like at least in the last week or so that progess has been picking up a bit | 13:39 |
| *** BjoernT has joined #openstack-nova | 13:40 | |
| sean-k-mooney | i need to try and review more of this work but i also need to review gibi port migrtion stuff so time is a factor. | 13:40 |
| *** ociuhandu has quit IRC | 13:40 | |
| mriedem | cdent: i think the "older computes" comment is from when edleafe wrote this https://review.opendev.org/#/c/160511/ back in kilo :) | 13:41 |
| *** belmoreira has quit IRC | 13:41 | |
| *** belmoreira has joined #openstack-nova | 13:42 | |
| *** BjoernT has quit IRC | 13:44 | |
| *** BjoernT has joined #openstack-nova | 13:48 | |
| mriedem | cdent: but yeah i suppose we have to hit that method to get the host mapping at least once per host to determine which cell the host is in so we know where to pull the instances from (which cell db), so in your test with 25 fake computes the profiler shows that method was called 25 times | 13:49 |
| cdent | mriedem: the patch prior to my last one there shows how to do profiling in an eventlet situation, in case you want to try it elsewhere | 13:49 |
| mriedem | yup i saw, thanks. that would be useful with something like this god awful mess https://review.opendev.org/#/c/674422/ | 13:49 |
| cdent | (I tried to do 100 fake computes and my compute explored) | 13:49 |
| cdent | exploded even | 13:50 |
| mriedem | i don't think i've been able to go over 30 fake computes in a devstack with 8GB RAM and 8 VCPU | 13:50 |
| mriedem | and 1 API_WORKER per service | 13:50 |
| cdent | I think I could probably make 50, I'm pretty smooth at 25 with 16GB,16vcpu | 13:50 |
| mriedem | you know, i'd give a scratch n sniff sticker if someone threw up a small doc about how to do profiling like this in nova somewhere in https://docs.openstack.org/nova/latest/contributor/#testing | 13:51 |
| cdent | I think I could do that, but it would really depend on the smell | 13:51 |
| efried | gibi, melwitt: Y'all okay if I continue working on the series at https://review.opendev.org/#/c/524306/ ? | 13:52 |
| gibi | efried: it is OK for me. I can keep reviewing the patches. | 13:54 |
| efried | gibi: I'd be fixing the func failures, either in your poison patch or by slotting another one underneath. And melwitt I'd be addressing gibi's comment on the bottom by removing that fixture. | 13:54 |
| efried | gibi: You think the ComputeDriver.get_available_resource signature change is worth doing? | 13:54 |
| *** Luzi has quit IRC | 13:56 | |
| gibi | efried: I need a refresh why we started this series in the first place. What is wrong with generating a new context. I got involved into it due to the testing impact of it | 13:56 |
| dustinc | efried: good point thanks | 13:56 |
| efried | gibi: I'm not completely sure why the series was *started*, but I can tell you why I got involved. | 13:57 |
| gibi | efried: I'm going to dig into the past to see the reason.. | 13:58 |
| efried | gibi: The global_request_id we're logging is coming from whatever RequestContext is in oslo.context's thread local store, which is *not* the same context we're using to pass the X-Openstack-Request-Id header around to other services like Placement. | 13:58 |
| efried | which means that, without additional hacking, we can't actually follow the request from e.g. n-cpu to placement | 13:58 |
| efried | which was the whole point of global_request_id in the first place. | 13:58 |
| gibi | efried: thanks, that seems to be a worthy cause | 13:58 |
| efried | So I've been trying to track down how that whole mechanism works and how we can get it so you can actually grep logs for a request ID and see the flow of an operation. | 13:59 |
| efried | gibi: My latest attempt actually diverged from that series a little bit: https://review.opendev.org/#/c/674138/ | 13:59 |
| gibi | is there any alternative to passing the context to the ComputeDriver.get_available_resource ? | 13:59 |
| efried | To avoid having that one libvirt method call get_admin_context? Yes, melwitt and I talked about storing the context on, like, the compute manager object and accessing it from the virt driver via the virtapi. | 14:00 |
| efried | Questionable which is a worse hack, really. | 14:00 |
| efried | Having it as a param to get_available_resource seems appropriate from a zoomed-out perspective | 14:01 |
| gibi | I see | 14:01 |
| efried | but it's a fairly intrusive change as you can see. | 14:01 |
| efried | but | 14:01 |
| gibi | yepp | 14:01 |
| efried | that's assuming we need to be putting restrictions on get[_admin]_context like this at all. | 14:01 |
| efried | which, if we're doing that more carefully, we might not need to bother with | 14:02 |
| mriedem | cdent: typically root beer and grape are all i offer | 14:02 |
| efried | gibi: https://review.opendev.org/#/c/674138/ operates on the theory that get[_admin]_context should be able to be used wherever, and should (still) not overwrite the thread local store, as long as we're careful about where we *do* overwrite, and as long as we set global_request_id properly/carefully in the right places. | 14:03 |
| efried | so what I did was essentially make overwrite=False the default, and then made sure we're always setting a global_request_id in whatever RequestContext we're using. | 14:04 |
| gibi | efried: I think I like your current ^^ approach than the restriction of get[_admin]_context | 14:04 |
| efried | I need to go poke through the logs and see whether/how it worked. Like, see if a live migration operation gets logged properly throughout all the hosts. | 14:04 |
| efried | btw, on that note, the nova-live-migration job seems to produce only one n-cpu log. Is it the consolidated log from both "nodes"? | 14:05 |
| gibi | I feel there are smaller amount of places where we need to generate new global_request_id than the number of places we call for a new context | 14:05 |
| efried | ++ | 14:05 |
| gibi | efried: there is a subnode-2 folder in the logs | 14:06 |
| gibi | with another n-cpu logs | 14:06 |
| efried | ah! | 14:06 |
| efried | Thanks | 14:06 |
| gibi | so in summary If your approach works then I'm OK to abbandon the old series | 14:07 |
| *** tbachman has quit IRC | 14:07 | |
| efried | gibi: I'm sure there's still more to do. This is not a simple thing. | 14:09 |
| efried | glancing at the n-api log, my initial thought is that the global_request_id is being persisted too long. | 14:09 |
| *** dpawlik has quit IRC | 14:10 | |
| efried | I think what we probably want to do is change it any time we get a new incoming API request. | 14:10 |
| *** tbachman has joined #openstack-nova | 14:10 | |
| *** liuyulong has joined #openstack-nova | 14:10 | |
| efried | As yet, I have no idea where in the code would be a good place to do that... | 14:11 |
| *** ociuhandu has joined #openstack-nova | 14:11 | |
| *** altlogbot_1 has quit IRC | 14:12 | |
| *** N3l1x has joined #openstack-nova | 14:14 | |
| *** N3l1x_ has joined #openstack-nova | 14:14 | |
| *** altlogbot_3 has joined #openstack-nova | 14:14 | |
| *** N3l1x_ has quit IRC | 14:15 | |
| gibi | efried: does this in connection with the fact that periodic tasks also needs a context / global_request_id but they are not triggered by a specific API request? | 14:15 |
| *** ociuhandu has quit IRC | 14:17 | |
| *** aarents__ has joined #openstack-nova | 14:18 | |
| *** mlavalle has joined #openstack-nova | 14:19 | |
| efried | gibi: Yup, that's an issue as well. | 14:19 |
| efried | I'm not sure whether periodics ought to have one global_request_id forever, or if they should get a new one every time they trigger. | 14:20 |
| efried | but I'm *pretty* sure they shouldn't share a global_request_id with any actual operations from an API request | 14:21 |
| cdent | efried: new one each job would be most useful when grepping (or otherwise searching) | 14:23 |
| efried | cdent: "job", are you talking about periodics or API requests? | 14:23 |
| cdent | periodics | 14:23 |
| efried | Okay. Meanwhile cdent I could probably use your wsgi skills here... | 14:24 |
| efried | can you help me find where nova does that middleware thing with the request_id? | 14:24 |
| *** brinzhang has quit IRC | 14:24 | |
| cdent | yeah, one sec | 14:24 |
| *** brinzhang has joined #openstack-nova | 14:25 | |
| efried | actually, I don't think that's what I want. | 14:26 |
| efried | Cause that part is working | 14:26 |
| *** brinzhang has quit IRC | 14:26 | |
| efried | problem right now is, that req ID is persisting way too long in the API thread. | 14:26 |
| cdent | efried: nova/api/compute_req_id.py has a subclass of oslo_middleware.request_id.RequestId | 14:26 |
| *** maciejjozefczyk has quit IRC | 14:26 | |
| efried | Yeah, that's setting the header inbound & outbound, which is working. | 14:27 |
| efried | sorry, inbound only | 14:27 |
| cdent | efried: is it possible that tempest is _sending_ it | 14:27 |
| *** ociuhandu has joined #openstack-nova | 14:27 | |
| *** maciejjozefczyk has joined #openstack-nova | 14:27 | |
| efried | cdent: looks like not. | 14:28 |
| *** maciejjozefczyk has quit IRC | 14:28 | |
| efried | which is actually fine for now | 14:29 |
| cdent | efried: i haven't got enough context loaded in at the moment | 14:29 |
| efried | actually if tempest *were* sending it, I wouldn't be seeing the behavior I'm seeing | 14:29 |
| *** brinzhang has joined #openstack-nova | 14:29 | |
| efried | cdent: So what I'm looking for is this: | 14:29 |
| efried | Presumably the API server sits there waiting for requests | 14:29 |
| *** maciejjozefczyk has joined #openstack-nova | 14:29 | |
| *** brinzhang has quit IRC | 14:29 | |
| efried | when a request comes in, it... spawns? reuses? a thread to handle it | 14:29 |
| *** brinzhang has joined #openstack-nova | 14:30 | |
| efried | Whatever RequestContext that thread gets needs to get a fresh global_request_id | 14:30 |
| efried | early as possible | 14:30 |
| *** maciejjozefczyk has quit IRC | 14:30 | |
| efried | so - I need to grab hold of the code that spins off that thread | 14:30 |
| *** maciejjozefczyk has joined #openstack-nova | 14:31 | |
| efried | (btw, ^ is for API requests obvi. Periodics will be a separate thing entirely.) | 14:31 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/auth.py#L57 is what creates the RequestContext in the compute API | 14:33 |
| *** tbachman has quit IRC | 14:33 | |
| efried | mriedem: yup https://review.opendev.org/#/c/674138/4/nova/api/openstack/auth.py | 14:35 |
| efried | So that's working now | 14:35 |
| efried | the thing I'm trying to tackle now is, I want each API request to get a new global_request_id. | 14:35 |
| *** KeithMnemonic has joined #openstack-nova | 14:36 | |
| efried | because right now it's getting reused for multiple operations | 14:36 |
| efried | Actually, cdent, I think perhaps that compute_req_id might be the place to do it. | 14:36 |
| efried | The superclass is pulling in a request ID from headers if available... but what I can do is *set* a new one if there wasn't one in the header. | 14:36 |
| * efried tries... | 14:37 | |
| *** BjoernT has quit IRC | 14:42 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Always set a global_request_id in RequestContext https://review.opendev.org/674138 | 14:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Correct global_request_id sent to Placement https://review.opendev.org/674129 | 14:43 |
| efried | cdent, mriedem: let's see how that shakes out ^ | 14:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Replace non-nova server fault message https://review.opendev.org/674821 | 14:46 |
| mriedem | dansmith: ^ | 14:46 |
| fungi | i'm watching these go up too, thanks mriedem! | 14:46 |
| dansmith | mriedem: ack | 14:47 |
| *** belmoreira has quit IRC | 14:49 | |
| *** Sundar has joined #openstack-nova | 14:51 | |
| cdent | sorry efried was drawn away into another converation | 14:55 |
| cdent | I had thought that the existing one was supposed to set a new one | 14:56 |
| cdent | (if not present) | 14:56 |
| efried | cdent: If you look at the parent impl, it doesn't. | 14:58 |
| efried | Previous PS of my change did it further down, but too late, and sucked up whatever was in thread local already if one wasn't set. | 14:58 |
| efried | It's possibly the guts of my ensure_global_id never gets hit now, which would possibly be a good thing. | 14:59 |
| efried | mriedem: rebuild... gets a new image or no? | 14:59 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Change the response to migrations of Show Migration Details API https://review.opendev.org/674825 | 15:00 |
| efried | okay, yeah, looks like it. | 15:00 |
| mriedem | efried: optional | 15:01 |
| mriedem | https://docs.openstack.org/api-ref/compute/#rebuild-server-rebuild-action | 15:01 |
| efried | mriedem: ack. I was looking at https://review.opendev.org/#/c/673407/ and requesting a func test for rebuild as well as spawn, but that wouldn't have made any sense if you couldn't specify a new image for rebuild. | 15:01 |
| mriedem | rebuild of a volume-backed server is never a new image - you get a 400 if you try | 15:01 |
| cdent | efried: i'm guessing that middleware is making assumptions about clients, which is unfortunate | 15:02 |
| efried | cdent: whadayamean? | 15:02 |
| cdent | it assumes that an e.g., nova client will set a request id | 15:02 |
| cdent | (the INBOUND_HEADER) | 15:02 |
| efried | oh, you mean oslo's middleware is assuming things about clients | 15:02 |
| mriedem | efried: this compression container_format thing seems to be flying under the radar but is a feature/blueprint | 15:03 |
| efried | mriedem: yes, the above patch just adds an early fail for it. No intention of allowing them to attempt to add support for compressed images in Train. | 15:03 |
| efried | mriedem: above patch is goodness because otherwise we happily create the instance and make it ACTIVE per nova, but the OS doesn't come up so it's nonsense. | 15:04 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | 15:04 |
| efried | mriedem: suspect one of us will get to help them write their func test tho :) | 15:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Replace non-nova server fault message https://review.opendev.org/674828 | 15:05 |
| *** belmoreira has joined #openstack-nova | 15:05 | |
| KeithMnemonic | does anyone know if there are plans to put this on Rocky as well https://review.opendev.org/#/c/649372/ | 15:06 |
| KeithMnemonic | i tried doing a simple cherry pick but there are some merge conflicts so was not sure the level of effort or if there are too many dependencies. | 15:07 |
| efried | mnaser, melwitt: ^ ? | 15:10 |
| mriedem | KeithMnemonic: i don't think there are any plans no | 15:10 |
| *** BjoernT has joined #openstack-nova | 15:10 | |
| mriedem | the comment from melwitt on the master branch change was, "Yeah, I agree a reno would be helpful here. Looks like this breakage/change in noVNC behavior was released on Apr 9 [3], which was during Stein, so we could potentially backport to Stein. I don't know about earlier though... I don't know if we should reasonably expect anyone on < Stein would possibly install noVNC 1.1.0?" | 15:10 |
| mriedem | KeithMnemonic: are you using a distro with rocky that has novnc 1.1.0 or are you building packages from source? | 15:11 |
| KeithMnemonic | the problem is without this vnc consoles to esx hypervisors are broken in rocky | 15:11 |
| KeithMnemonic | so i kind of need rocky to support 1.1.0 | 15:11 |
| mriedem | but why/how are you getting/using novnc 1.1.0? | 15:11 |
| mriedem | distro or rolling your own packages from source? | 15:11 |
| KeithMnemonic | i pulled from github to test outside of nova | 15:12 |
| KeithMnemonic | the issue is reproducible just using novnc 1.0 | 15:12 |
| KeithMnemonic | and is fixed in 1.1 | 15:12 |
| sean-k-mooney | KeithMnemonic: is there a feature in 1.1.0 that you need | 15:12 |
| KeithMnemonic | so we could try and patch 1.0 | 15:12 |
| KeithMnemonic | yeah " the it works" feature | 15:12 |
| sean-k-mooney | no i mean we used older versions in rocky | 15:13 |
| mriedem | the commit message on that change from mnaser says that 1.1.0 is the breaking novnc change, i can't comment on 1.0 | 15:13 |
| *** belmoreira has quit IRC | 15:13 | |
| fungi | this is basically the "maintaining your own distro" problem. if you were a stable server linux distro packaging novnc and considered esx important, you would work out how to backport the esx fix to older novnc you were already shipping | 15:14 |
| KeithMnemonic | so i am just talking about novnc for a minute. the 1.0.0 release do not work with vnc console provide for instances running on esx | 15:14 |
| KeithMnemonic | the 1.1 version does work | 15:14 |
| KeithMnemonic | fungi we can do that | 15:14 |
| *** ccamacho has quit IRC | 15:15 | |
| KeithMnemonic | we (SUSE) is a stable server linux distro | 15:15 |
| sean-k-mooney | ok so esx is the issue | 15:15 |
| *** spatel has joined #openstack-nova | 15:15 | |
| sean-k-mooney | or rather that while we test with 1.0.0 | 15:15 |
| sean-k-mooney | https://github.com/openstack/devstack/blob/1f6bea1768c2066f3dd5604aee569ad633f45fbc/stackrc#L605-L606 | 15:15 |
| fungi | KeithMnemonic: aha, got it, so yes you know this route well | 15:15 |
| sean-k-mooney | we dont test with esx | 15:15 |
| KeithMnemonic | but instead of hacking in patches to noVNC, was wondering if there were plans to support 1.1 in rocky since this effects anyone using rocky and novnc 1.0 | 15:15 |
| sean-k-mooney | which is why 1.0.0 was used for rocky | 15:15 |
| sean-k-mooney | KeithMnemonic: no it only effect those using rocky and novnc with esk | 15:16 |
| sean-k-mooney | *esx | 15:16 |
| sean-k-mooney | if you use libvirt kvm its fine | 15:16 |
| KeithMnemonic | correct | 15:16 |
| fungi | i'm separately curious why it's okay for a stable distro to change the upstream version of novnc but not openstack (though i can guess at the reasons) | 15:16 |
| KeithMnemonic | rocky/novnc/esx | 15:16 |
| KeithMnemonic | so was just looking for any guidance from nova as to which path we need to take and it looks like we need to carry a patched novnc | 15:17 |
| sean-k-mooney | i mean regardless of if this is backported upstream it could be backported in suses distro version of nova | 15:18 |
| sean-k-mooney | looking at the patch | 15:18 |
| sean-k-mooney | its mainly test update | 15:19 |
| sean-k-mooney | i personally dont think it would be a large risk to backport if the path paramter works with loder releases | 15:19 |
| sean-k-mooney | e.g. if using path with 1.0.0 is fine then this seams resonable to backport to me. we are modifying one of the properties on the console_auth_token ovo but we are not modifying the data fields so i think that is safe | 15:21 |
| *** BjoernT has quit IRC | 15:23 | |
| KeithMnemonic | sean-k-mooney: we prefer to track upstream where possible but if you think it is worth trying to backport I can play with it | 15:23 |
| *** hoonetorg has quit IRC | 15:24 | |
| *** hoonetorg has joined #openstack-nova | 15:25 | |
| sean-k-mooney | well we try to do that at redhat too but if i had to choose between carrying this patch to nova an potentially several to novnc i would carry this | 15:25 |
| *** nfakhir has quit IRC | 15:26 | |
| sean-k-mooney | but i think this could be considerd for backport upstream but for OSP we are not shiping novnc 1.1 until stien | 15:26 |
| sean-k-mooney | lyarwood: we dont have any plans to land novnc 1.1 in any rhel 7.x release do we that only used on rhel8 right | 15:28 |
| fungi | KeithMnemonic: to play devil's advocate for a moment, if you prefer to track upstream where possible, then why are you shipping openstack rocky? | 15:28 |
| sean-k-mooney | fungi: you mean openstack rocky with novnc 1.1 | 15:29 |
| fungi | well, they're not currently | 15:29 |
| fungi | seems like if you're carrying a point-in-time snapshot of a project then you're committed to carrying the contemporary versions of its dependencies too | 15:29 |
| *** gyee has joined #openstack-nova | 15:29 | |
| KeithMnemonic | fungi we have not released our next product yet based on > rocky | 15:30 |
| fungi | which is the assumption our stable branch policies are based on | 15:30 |
| fungi | we avoid backporting potentially disruptive changes, including testing against newer versions of dependencies, so as to avoid breaking that assumption for stable distros | 15:31 |
| sean-k-mooney | fungi: well i know from a redhat persoective OSP uses newer versions of some deps then are in upper constraits because the version in the base distor are newer | 15:31 |
| sean-k-mooney | e.g. form an openstack porduct perspective we can donwgrade the version of a dep from that provide by the base os | 15:31 |
| sean-k-mooney | granted that a bit of a specil case for OSP 15 on RHEL 8 since RHEL 8 was based on fedora 28 ish | 15:32 |
| fungi | well, we *try* to test openstack against the newest available dependencies while it's under development, and then we freeze that list of dependencies when we release and make a stable branch | 15:32 |
| sean-k-mooney | so it ended up pulling newer deps then were released when stine was under deveopment | 15:33 |
| fungi | so the dependencies we test stable branches against should be those which were contemporary with the release | 15:33 |
| mnaser | in openstack ansible world, we use source | 15:33 |
| mnaser | so we found out it was broken inside stein | 15:33 |
| *** BjoernT has joined #openstack-nova | 15:33 | |
| lyarwood | sean-k-mooney: we might back to 13 for stable/queens | 15:33 |
| lyarwood | sean-k-mooney: it isn't per RHEL release, it's something we build for each OSP release downstream | 15:34 |
| mnaser | we had to pin the novnc version in openstack-ansible | 15:34 |
| mnaser | (and thats also how i found out it was broken) | 15:34 |
| sean-k-mooney | mnaser: ya we pin it in devstack too | 15:34 |
| mnaser | sean-k-mooney: afaik based on my research devstack deploys the ubuntu package | 15:34 |
| sean-k-mooney | fungi: that is only true for python packages really | 15:34 |
| lyarwood | yeah it's packages in devstack | 15:34 |
| mnaser | at least at the time when i was wondering how that issue wasnt caught | 15:34 |
| sean-k-mooney | mnaser: its a job var. so we default to packages or you can enabel source install | 15:35 |
| sean-k-mooney | but we use 18.04 in the gate and package is the default | 15:35 |
| sean-k-mooney | so it would have been using an older version | 15:35 |
| fungi | sean-k-mooney: it's true for other dependencies too, insofar as we test on lts distros which make the same assumptions about selectively backporting fixes in their packages | 15:35 |
| fungi | and we don't change the distro version we test a given branch on from what it was tested on while that release was still under development | 15:36 |
| sean-k-mooney | fungi: sure but RHEL8 for example was based on the latest fedroa that was availble during stine | 15:36 |
| *** ociuhandu has quit IRC | 15:36 | |
| sean-k-mooney | so it has signifcatly newer packages in some cases | 15:36 |
| fungi | yeah, we test on centos not rhel, and there is no centos 8 (yet) | 15:36 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Replace non-nova server fault message https://review.opendev.org/674848 | 15:36 |
| sean-k-mooney | rhel/centos revs so rarely that it is very uncommon for it to be ahead of the ubunut lts but it was for stien | 15:37 |
| sean-k-mooney | ya hopefully centos 8 will be around soon | 15:37 |
| sean-k-mooney | *available | 15:37 |
| fungi | if red hat had worked with the community to release centos 8 in concert with rhel 8 we would have been testing on it | 15:37 |
| sean-k-mooney | i think the triplo builds are using rhel8 at least some of them are | 15:38 |
| fungi | but since centos releases only get started after rhel releases are made available there is a definite lag between them | 15:38 |
| fungi | probably in rdo's ci system, yes | 15:38 |
| fungi | opendev is unable to test on rhel owing to cloud providers requiring purchased support licenses if you want to boot instances with rhel images | 15:39 |
| fungi | which is why we ended up using centos | 15:39 |
| sean-k-mooney | ya well i think centos is fine for testing | 15:39 |
| sean-k-mooney | it sound like redhat might need to backport this too at some point based lyarwood comment so it might make more sense to do it once upstream | 15:40 |
| fungi | but it does mean that rhel is left out in the cold until centos gets in sync (i have no sympathy there, it's a problem red hat has created through their licensing policies) | 15:40 |
| sean-k-mooney | im surprised that the developer/test licensing would not cover this usecase | 15:41 |
| jangutter | fungi: I seem to recall in 2014 when CentOS got acquired by RH that developers on both sides were pretty adamant in maintaining a "Chinese Wall" between them. | 15:42 |
| fungi | jangutter: yep, there is a similar situation between debian and ubuntu, but since debian is doing their development of each new release completely in the open ubuntu can track that and consume packages slated for the next release without waiting | 15:44 |
| jangutter | fungi: also, epel8 is going to trail centos8 by a bit, so even if it's released it's going to be a bit rocky in places. | 15:44 |
| sean-k-mooney | jangutter: i can realy comment on that as i dont know the history and proably shouldnt for leagl reason anyway but i personally was not expecting the delay to be as long as it has been. that said its a lot of work | 15:44 |
| sean-k-mooney | fungi: well redhat does its dev in fedora | 15:44 |
| fungi | but does rhel consume fedora packages? | 15:45 |
| sean-k-mooney | fedroa is upstream of rhel and centos in downstream of rhel | 15:45 |
| sean-k-mooney | fungi: yes | 15:45 |
| sean-k-mooney | well kind of | 15:45 |
| fungi | so the packages built in fedora are the ones which will appear in rhel | 15:45 |
| sean-k-mooney | rhel8 started as a clone of fedora 28 | 15:45 |
| artom | Dammit, we store image_meta in the DB somewhere, right? | 15:45 |
| fungi | anyway, we're verging way off-topic for #openstack-nova i expect | 15:46 |
| *** ivve has quit IRC | 15:46 | |
| sean-k-mooney | fungi: they get rebuilt and sometimes they are tweek due to versions change but ya i belive that is how it works | 15:46 |
| sean-k-mooney | fungi: ya | 15:46 |
| lyarwood | sean-k-mooney: they are always rebuilt | 15:46 |
| fungi | so in theory centos 8 could also have started as a f28 clone, and instead they chose to wait for rhel to finish 8. got it | 15:46 |
| dansmith | artom: I don't think we store all of it | 15:46 |
| artom | dansmith, the image properties part | 15:47 |
| *** sridharg has quit IRC | 15:47 | |
| artom | They're not *just* in Glance... right? | 15:47 |
| jangutter | sean-k-mooney, fungi: I'm definitely not dissing either side here, fedora, rhel and centos cannot exist without each other, and there's been some long and hard though given their relationships. | 15:47 |
| dansmith | artom: we might copy that into reqspec actually, now that I think of it, but I think we only persist a few selected things into the cell db, IIRC | 15:47 |
| *** igordc has joined #openstack-nova | 15:48 | |
| lyarwood | sean-k-mooney: sorry I'm only half paying attention here, is this all about novnc? | 15:48 |
| *** ociuhandu has joined #openstack-nova | 15:48 | |
| sean-k-mooney | lyarwood: yes tangenaly | 15:48 |
| jangutter | for anyone who's interested in some really funky geometries: https://www.youtube.com/watch?v=HQsUdLPJW20 | 15:48 |
| artom | dansmith, aha, request_specs, thanks! | 15:48 |
| *** helenafm has quit IRC | 15:49 | |
| sean-k-mooney | lyarwood: KeithMnemonic was wondering if https://review.opendev.org/#/c/649372/4 could be backport upstrea to rocky | 15:49 |
| sean-k-mooney | lyarwood: since suse woudl be shipng novnc 1.1 with there rocky release to enable esx console support | 15:49 |
| mriedem | artom: instance_system_metadata, | 15:49 |
| mriedem | keys prefixed with image_ | 15:49 |
| mriedem | artom: https://github.com/openstack/nova/blob/master/nova/utils.py#L870 | 15:50 |
| mriedem | the ImageMeta object would be serialized and stored in the RequestSpec as well like dan said | 15:50 |
| mriedem | launchpad.net is down, yikes | 15:50 |
| efried | who needs it | 15:51 |
| artom | mriedem, ah, thanks, I wasn't seeing what I wanted in my devstack because (obviously) a key doesn't appear unless it's actually set | 15:51 |
| sean-k-mooney | mriedem: its been a while since that happened last | 15:51 |
| dansmith | mriedem: and only a few keys though right? | 15:51 |
| lyarwood | sean-k-mooney: kk, IMHO yes it should, we've already backported it downstream for 15 | 15:51 |
| mriedem | dansmith: i think you're thinking of these https://github.com/openstack/nova/blob/master/nova/utils.py#L72 | 15:52 |
| sean-k-mooney | lyarwood: well it backport upstream for stien | 15:52 |
| *** tbachman has joined #openstack-nova | 15:52 | |
| dansmith | mriedem: right | 15:52 |
| mriedem | i don't think that's all though | 15:52 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/utils.py#L874 | 15:52 |
| sean-k-mooney | KeithMnemonic: but if lyarwood is ok with it then maybe just propose the backport and people can review | 15:53 |
| mriedem | it stores all the image properties (except the bdm ones), | 15:53 |
| mriedem | but only stores a few of the top-level image fields | 15:53 |
| dansmith | mriedem: ah, all the properties but not all the image keys | 15:53 |
| mriedem | right | 15:53 |
| dansmith | gotcha | 15:53 |
| sean-k-mooney | mriedem: https://launchpad.net/nova seam to be fine by the way so maybe refesh | 15:53 |
| mriedem | if only we had a gd docstring on that method to expedite the re-learning of that code :P | 15:53 |
| *** mrjk__ has quit IRC | 15:53 | |
| *** xek has quit IRC | 15:54 | |
| mriedem | sean-k-mooney: maybe if you're in ireland | 15:54 |
| sean-k-mooney | blame comcast/twc/other-isp but ya im obviously getting routed to a different server | 15:55 |
| jangutter | mriedem: well here in South Africa it also seems to work.... Maybe east of the Atlantic? | 15:55 |
| artom | mriedem, dansmith, thanks again! This was for a weird unsupported support request downstream, so I'm not even sure why I spent so much time on it | 15:55 |
| artom | But... good to know they're all over place, I guess :D | 15:55 |
| mriedem | artom: i look forward to your spec for whatever the nutty customer request is | 15:56 |
| mriedem | maybe an api to change the embedded instance image system metadata? | 15:57 |
| artom | DWIM all the time, everytime | 15:57 |
| artom | mriedem, that's... actually pretty spot on | 15:57 |
| artom | And if it can hard reboot the instance as well, after, it's be perfect | 15:57 |
| mriedem | it wouldn't be the first time | 15:57 |
| mriedem | heh, sure | 15:58 |
| sean-k-mooney | artom: so a rebuild without actully updating the root disk | 15:58 |
| mriedem | "i f'ed up the image properties on the image this pet is using, i need to fix those but can't lose the server and can't rebuild it" | 15:58 |
| fungi | mriedem: lp is loading for me... temporary outage? | 15:58 |
| artom | sean-k-mooney, something like that | 15:58 |
| sean-k-mooney | artom: let me guess the updated the metadata on the image and added somthign that change scheduling behavior and then were suprised when non of there old instance had the new behavior | 15:59 |
| artom | sean-k-mooney, no, they want TRIM | 15:59 |
| artom | So need the correct magic disk model/bus imageprops | 15:59 |
| artom | Because TRIM is no longer just for SSDs: https://ceph.com/geen-categorie/openstack-and-ceph-rbd-discard/ <--- that bit is actually genuinely interesting | 16:00 |
| sean-k-mooney | ok so its effectivly the same thing without the schduliing bit | 16:00 |
| mriedem | fungi: must be something weird on my end then but nope still can't access | 16:00 |
| sean-k-mooney | they want to add the disk_bus=scsi imemage meta and enable virtio-scisis as the scsi model | 16:00 |
| artom | mriedem, you're cut off, forced PTO | 16:00 |
| sean-k-mooney | but they want to apply that chagne to existing instances too | 16:01 |
| mriedem | sweet release | 16:01 |
| artom | sean-k-mooney, yeah, we have a KCS for it: https://access.redhat.com/solutions/2532341 | 16:01 |
| artom | ... which explicitly states "it is not possible to change existing VMs configuration." | 16:01 |
| mriedem | artom: then tell them to snapshot their existing servers, add the image meta they want on the snapshots, and re-deploy | 16:01 |
| sean-k-mooney | well without a rebuild | 16:01 |
| sean-k-mooney | but ya | 16:02 |
| openstackgerrit | Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963 | 16:02 |
| mriedem | or rebuild if they don't want to lose keys/uuids/ips whatever | 16:02 |
| jangutter | artom: OpenStack Icehouse got referenced in that article! | 16:02 |
| artom | mriedem, yeah, not sure why a rebuild isn't acceptable | 16:02 |
| fungi | mriedem: yeah, maybe a network problem somewhere then, but it's still working for me (just tried again) | 16:02 |
| sean-k-mooney | and ya trim is used with ceph and lvm thin provisioning to tell the storage backend it can use those blocks for other oversubsried images | 16:02 |
| artom | I guess they forgot to volume-back their valuable pet disks | 16:02 |
| mriedem | artom: b/c it will blow away the root disk | 16:02 |
| mriedem | artom: you can't rebuild + new image on volume-backed servers | 16:03 |
| *** ociuhandu has quit IRC | 16:03 | |
| mriedem | not yet anyway - there is approved spec and code in cinder to support it, but the nova piece was abandoned | 16:03 |
| artom | detach volume -> rebuild -> re-attach? | 16:03 |
| mriedem | you can't detach the root volume | 16:03 |
| sean-k-mooney | artom: rebuild will only nuke the root disk | 16:03 |
| artom | Assuming not bfv, obviously | 16:03 |
| mriedem | again, there is an approved spec for that, but it's abandoned | 16:03 |
| sean-k-mooney | if they have data volumes those would be fine | 16:03 |
| mriedem | fungi: it's back | 16:05 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Replace non-nova server fault message https://review.opendev.org/674859 | 16:05 |
| mriedem | maybe charter has a beef with canonical all of a sudden | 16:05 |
| jangutter | mriedem: it was just a brief outage while they installed the tap on the phone lines. | 16:08 |
| artom | Who needs taps when it's Huawei's equipment >:D | 16:09 |
| dansmith | artom: zing :) | 16:11 |
| sean-k-mooney | mriedem: you use vxhost vms for dev right. if its really a proably you can alwasy use "ssh -D " and forward your traffic via a dev vm to get to launchpad or whatever else is down | 16:11 |
| *** igordc has quit IRC | 16:12 | |
| sean-k-mooney | *really a problem | 16:12 |
| mriedem | sean-k-mooney: no i use vexxhost vms for devstack, which are short-lived b/c $$$ | 16:12 |
| sean-k-mooney | or x11 forward a firefox on the vm | 16:12 |
| mriedem | i do dev on a vm on my laptop | 16:13 |
| sean-k-mooney | mriedem: oh well i can proably give you ssh acess to one of my local systems if it contiues to be an issue | 16:13 |
| artom | :q | 16:15 |
| artom | doh | 16:15 |
| *** tssurya has quit IRC | 16:15 | |
| * artom missed tiling wms | 16:15 | |
| artom | *missed | 16:15 |
| artom | But a mixed-DPI setup essentially requires GNOME, which no longer allows you to swap out your VM | 16:16 |
| *** owalsh_ has joined #openstack-nova | 16:17 | |
| *** ricolin has quit IRC | 16:20 | |
| *** mvkr has quit IRC | 16:20 | |
| *** owalsh has quit IRC | 16:22 | |
| *** aram1s has quit IRC | 16:23 | |
| *** hongbin has joined #openstack-nova | 16:24 | |
| eandersson | mriedem, https://bugs.launchpad.net/nova/+bug/1817633 | 16:28 |
| openstack | Launchpad bug 1817633 in OpenStack Compute (nova) "Listing placement usages causes a circular reference error" [High,Fix committed] - Assigned to Chris Dent (cdent) | 16:28 |
| eandersson | This wouldn't be related to the issue we discussed the other day right? | 16:28 |
| *** hongbin has quit IRC | 16:29 | |
| cdent | eandersson: since that pinged me, I'm not curious, what was the issue the other day? | 16:29 |
| cdent | s/not/now/ | 16:29 |
| eandersson | https://bugs.launchpad.net/nova/+bug/1799309 | 16:29 |
| openstack | Launchpad bug 1799309 in OpenStack Compute (nova) "Migration/Resize fails with Unexpected exception in API method: Circular reference detected" [Undecided,New] | 16:29 |
| eandersson | I attached the chat log to that bug report as well. | 16:29 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Add a document that describes profiling eventlet services https://review.opendev.org/674865 | 16:31 |
| *** owalsh_ has quit IRC | 16:31 | |
| *** owalsh has joined #openstack-nova | 16:31 | |
| *** markvoelker has quit IRC | 16:32 | |
| cdent | eandersson: the placement thing was very specifically about a value being of a bad type | 16:33 |
| eandersson | I see - yea the file referenced no longer exists | 16:34 |
| cdent | mriedem: there's ^ a start at the profiling doc. Probably needs a few iterations (and the usual, oh, chris wrote a thing, see the typos) | 16:34 |
| mriedem | Sundar: you asked for it https://review.opendev.org/#/c/674726/ | 16:39 |
| mriedem | cdent: thanks | 16:39 |
| *** rpittau is now known as rpittau|afk | 16:41 | |
| *** markvoelker has joined #openstack-nova | 16:44 | |
| sean-k-mooney | efried: mriedem Sundar: by the way i would be fine with not supporting some operation in addtion to not support live migration but the current patch block way more operation then im comfortable with | 16:44 |
| sean-k-mooney | with no support for snapshots resize/cold-migrate or live migrate there is not way to do upgrades of the node other then an inplace upgrade | 16:45 |
| mriedem | i'm also not cool with the blocker really, at least without a policy rule to control it or something | 16:47 |
| mriedem | if you do it like vgpus, then it's just docs on what works and what doesn't and anything we don't test is considered experimental and you fix it as bugs later | 16:47 |
| * mriedem notes we do'nt test vgpus at all either anyway | 16:47 | |
| *** cdent has quit IRC | 16:48 | |
| *** BjoernT has quit IRC | 16:48 | |
| sean-k-mooney | mriedem: ya that sound resonable. i am semi ok with 409s for live migratin or something we know upfont wont work | 16:48 |
| dansmith | dear god | 16:49 |
| *** N3l1x has quit IRC | 16:49 | |
| *** ociuhandu has joined #openstack-nova | 16:49 | |
| dansmith | also, are we really adding a flavor property for device profile? | 16:49 |
| sean-k-mooney | it was really blocking interface/volume attach/detach and lock that annoyed me | 16:49 |
| sean-k-mooney | dansmith: its an extra spec | 16:50 |
| dansmith | oh, it's added as a property on flavor, I see | 16:50 |
| dansmith | I don't really like that | 16:50 |
| sean-k-mooney | right but we did that not to need to change the nova apin in the first versions | 16:50 |
| sean-k-mooney | dansmith: but at least your consitent in not liking it every time you see it | 16:51 |
| sean-k-mooney | i think given how long it been waiting we should merge basic integation and consider it experimental. but my version of basic is more then boot, reboot, delete and status. | 16:52 |
| sean-k-mooney | i prefer the docs approch rather then expcit blocker check given that in thory other virt driver will support cyborg at some point so i think doc are better for then api check when they could be virt dirver specifc. | 16:54 |
| *** tbachman has quit IRC | 16:56 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Implement power_off/power_on for the FakeDriver https://review.opendev.org/674876 | 16:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Replace non-nova server fault message https://review.opendev.org/674877 | 16:57 |
| *** ociuhandu has quit IRC | 16:57 | |
| *** ociuhandu has joined #openstack-nova | 16:58 | |
| *** udesale has quit IRC | 17:00 | |
| *** mrjk has joined #openstack-nova | 17:02 | |
| *** ralonsoh has quit IRC | 17:08 | |
| *** BjoernT has joined #openstack-nova | 17:08 | |
| *** betherly has joined #openstack-nova | 17:21 | |
| *** ociuhandu has quit IRC | 17:22 | |
| openstackgerrit | sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072 | 17:22 |
| *** ociuhandu has joined #openstack-nova | 17:23 | |
| *** mgariepy has quit IRC | 17:25 | |
| *** betherly has quit IRC | 17:25 | |
| *** ociuhandu has quit IRC | 17:27 | |
| *** ociuhandu has joined #openstack-nova | 17:28 | |
| *** tbachman has joined #openstack-nova | 17:28 | |
| *** aojea has quit IRC | 17:40 | |
| *** aojea has joined #openstack-nova | 17:41 | |
| *** lpetrut has quit IRC | 17:44 | |
| dansmith | mriedem: bauzas: hmm, we still construct reqspec by from_components() huh? | 17:47 |
| *** ociuhandu has quit IRC | 17:48 | |
| sean-k-mooney | dansmith: i think bauzas is on PTO for the next 2-3 weeks | 17:49 |
| dansmith | oh right, because he's in france and today ends in "day" | 17:49 |
| sean-k-mooney | dansmith: but yes i belive we do | 17:49 |
| dansmith | sean-k-mooney: yeah, that was rhetorical to start a bitch-fest :D | 17:49 |
| sean-k-mooney | hehe i thought it was the from_flavor version that everyone hated | 17:50 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L389-L417 | 17:51 |
| *** betherly has joined #openstack-nova | 17:51 | |
| sean-k-mooney | oh wait im thinking of somthing else | 17:51 |
| *** sapd1_x has joined #openstack-nova | 17:51 | |
| *** spsurya has quit IRC | 17:52 | |
| *** aojea has quit IRC | 17:53 | |
| sean-k-mooney | you mean how its built form this blob of stuff https://github.com/openstack/nova/blob/master/nova/compute/api.py#L897 | 17:53 |
| sean-k-mooney | dansmith: when are you heading on PTO by the way. are you around this week? | 17:54 |
| dansmith | sean-k-mooney: glad to know that me being gone ALL last week was so unimpactful that you didn't even notice | 17:55 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 17:55 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unused '_instance_to_allocations_dict' function https://review.opendev.org/674893 | 17:55 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | 17:55 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 17:55 |
| dansmith | maybe that means I could take another week and nobody would know ;) | 17:55 |
| *** betherly has quit IRC | 17:56 | |
| sean-k-mooney | well i was off since tursday so i dont remember much form last weeks other then i need to relax. no i just noticed you comment that you were going to be off around august 24th in a review | 17:56 |
| sean-k-mooney | maybe that was someone else | 17:57 |
| dansmith | erm, Aug 24 is a saturday, so I do plan to not be around that day, but.. I think maybe you're confusing me with someone else. Which is also super flattering :D | 17:57 |
| mriedem | dansmith: i think i've been working on burning out from_components the last few releases | 17:59 |
| mriedem | like getting resize reschedule to pass the request spec back to conductor so we don't have to build a new one | 17:59 |
| mriedem | some of that compat might be deletable by now too | 17:59 |
| dansmith | okay | 17:59 |
| mriedem | b/c yeah it's been an endless source of bugs | 18:00 |
| dansmith | I can still -1 the cyborg patch for putting all the cyborg interaction inside that method anyway | 18:00 |
| mriedem | "oh we re-constructed it with the wrong stuff huh?" | 18:00 |
| mriedem | well, | 18:00 |
| mriedem | it is used in the api right? and the port resource request stuff is in there | 18:00 |
| dansmith | it is, but we just chuck the port requests into it | 18:01 |
| stephenfin | dansmith: I'm just off home, but could you take a look at this object'y thing at some point this week? https://review.opendev.org/#/c/537414 | 18:01 |
| dansmith | we still do the bdm init after we construct it, which is what we should do here | 18:01 |
| dansmith | stephenfin: okay will try | 18:01 |
| *** ociuhandu has joined #openstack-nova | 18:02 | |
| stephenfin | ta | 18:02 |
| *** lpetrut has joined #openstack-nova | 18:03 | |
| sean-k-mooney | dansmith: yep apparently i was confusing you with kashyap. sorry, dont i just know how to get on your good side :) | 18:04 |
| dansmith | jesus | 18:04 |
| dansmith | one of us should be highly offended | 18:04 |
| *** ociuhandu has quit IRC | 18:04 | |
| *** ociuhandu has joined #openstack-nova | 18:05 | |
| *** igordc has joined #openstack-nova | 18:08 | |
| *** ociuhandu has quit IRC | 18:09 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 18:09 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | 18:09 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | 18:09 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | 18:09 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | 18:09 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | 18:09 |
| *** bbowen_ has joined #openstack-nova | 18:15 | |
| *** bbowen has quit IRC | 18:17 | |
| *** igordc has quit IRC | 18:25 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unused '_instance_to_allocations_dict' function https://review.opendev.org/674893 | 18:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | 18:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | 18:27 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 18:27 |
| *** sapd1_x has quit IRC | 18:28 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Implement power_off/power_on for the FakeDriver https://review.opendev.org/674906 | 18:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: fix unshelve notification test instability https://review.opendev.org/674907 | 18:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Replace non-nova server fault message https://review.opendev.org/674908 | 18:39 |
| mriedem | fungi: that's it for upstream backports ^ | 18:39 |
| fungi | mriedem: awesome, those were the last three i was waiting for. thanks!!! | 18:40 |
| fungi | now to push up the ossa | 18:40 |
| mriedem | np | 18:40 |
| *** jangutter has quit IRC | 18:42 | |
| fungi | which is https://review.opendev.org/674909 for the record | 18:42 |
| *** igordc has joined #openstack-nova | 18:46 | |
| *** tesseract has quit IRC | 18:52 | |
| melwitt | efried: to your earlier question, yes OK with you removing the fixture from the patch to address gibi's -1 to continue work on series | 18:56 |
| *** xek has joined #openstack-nova | 18:57 | |
| *** mriedem has quit IRC | 19:08 | |
| *** mriedem has joined #openstack-nova | 19:09 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Add 'path' query parameter to console access url https://review.opendev.org/674916 | 19:21 |
| melwitt | KeithMnemonic, fungi, mriedem: I'm not clear on why backporting the needed fix for esx in upstream noVNC isn't an option, so in case it is helpful, here is a proposed rocky backport of the nova change with conflicts documented ^ | 19:25 |
| sean-k-mooney | melwitt: i dont think it explcitly not an option. its just novnc 1.1 did not exsit when rocky was developed and we typically dont add support for things after the fact but in this case its trivial | 19:27 |
| KeithMnemonic | melwitt: thanks! i found the fix for noVNC 1.0 to get it to work. do they except patches on older versions still? | 19:27 |
| *** betherly has joined #openstack-nova | 19:30 | |
| melwitt | KeithMnemonic: I don't know, sorry. I mention it based on the earlier discussion in the channel. I don't if they handle fixes for stable/older releases in the same way we do | 19:31 |
| *** ivve has joined #openstack-nova | 19:32 | |
| KeithMnemonic | i have several options. let me see which one is least painful ;-) | 19:33 |
| *** betherly has quit IRC | 19:35 | |
| mriedem | efried: https://docs.openstack.org/python-novaclient/latest/cli/nova.html#nova-migration-list is missing some filter options (migration_type and source_compute) - need a blueprint for novaclient change to add those? | 19:38 |
| mriedem | looks like we do have blueprints for novaclient to actually track stuff... https://blueprints.launchpad.net/python-novaclient | 19:39 |
| mriedem | this is related to what spatel is trying to di in -placement | 19:39 |
| *** Sundar has quit IRC | 19:39 | |
| *** lpetrut has quit IRC | 19:39 | |
| mriedem | and eventually something i'd use to write a troubleshooting guide for manually recovering from https://bugs.launchpad.net/nova/+bug/1829479 | 19:39 |
| openstack | Launchpad bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,Triaged] | 19:39 |
| *** mloza has joined #openstack-nova | 19:41 | |
| *** mloza is now known as atmark | 19:41 | |
| *** bbowen__ has joined #openstack-nova | 19:42 | |
| melwitt | doesn't look promising, I don't see anything that looks like stable branches other than an old branch for v0.6 last updated 3 years ago https://github.com/novnc/noVNC | 19:43 |
| KeithMnemonic | it is literally 3 lines of code so it might be easier for us to carry it locally | 19:44 |
| *** bbowen_ has quit IRC | 19:45 | |
| KeithMnemonic | it was pretty simple to fix once i got looking in the right place | 19:45 |
| melwitt | oh, I see | 19:45 |
| *** bbowen__ has quit IRC | 19:47 | |
| melwitt | well, I think I'm in support of the nova rocky backport given there seems to be no other way to have esx hypervisors consoles work out-of-the-box. though that also comes with caveat of the fact that I'm guessing for rocky noVNC v1.1.0 isn't what's installed out-of-the-box | 19:48 |
| efried | mriedem: you tell me, do we usually require a blueprint for novaclient parity? | 19:48 |
| melwitt | so people would have to know that they need v1.1.0 and install it | 19:48 |
| *** betherly has joined #openstack-nova | 19:50 | |
| mriedem | efried: most blueprints in novaclient these days are tied to nova blueprints for microversion parity, | 19:51 |
| mriedem | i think a standalone feature in novaclient should probably use a blueprint for tracking yeah, | 19:51 |
| mriedem | but don't necessarily think it should fall under spec freeze or anything since it's not on the same release schedule | 19:51 |
| efried | mriedem: specless? | 19:51 |
| mriedem | yes, we don't need specs for novaclient blueprints :) | 19:52 |
| efried | Seems like you could fit the necessary into a bp description. | 19:52 |
| mriedem | https://blueprints.launchpad.net/python-novaclient/+spec/more-migration-list-filters | 19:52 |
| mriedem | i did | 19:52 |
| mriedem | if people want i'll just throw it under open discussion for thursday's meeting | 19:52 |
| efried | wfm | 19:52 |
| efried | should at least do that as a formality. | 19:52 |
| mriedem | ack | 19:53 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | 19:54 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | 19:54 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | 19:54 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | 19:54 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | 19:54 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | 19:54 |
| KeithMnemonic | melwitt: that would be great to have it ported, if that does not fly, i can share the patch to noVNC 1.0 if we need to document or something | 19:55 |
| *** betherly has quit IRC | 19:55 | |
| melwitt | KeithMnemonic: ack. feels like either way, we need to add a note on our consoles docs https://docs.openstack.org/nova/latest/admin/remote-console-access.html that calls out the issue for esx hypervisors and instructions on what to do. I would need your help to know what to write there as far as explaining what/how it is broken for esx | 19:58 |
| *** maciejjozefczyk has quit IRC | 20:02 | |
| KeithMnemonic | ok so lets try for the backport and then the note just mentions needing 1.1? and if that does not work we add the steps to fix with 1.0? does that seem reasonable | 20:03 |
| melwitt | KeithMnemonic: right. my thought: I'd like to have the doc have a note about esx hypervisors and explain what is broken in < v1.1.0 and then instruction will be "install v1.1.0" if the backport succeeds, else "apply this patch" and maybe we could host it either our repo or one of the ops-oriented repos and link to it from the doc | 20:05 |
| KeithMnemonic | ok so here was the issue, https://github.com/novnc/websockify/issues/402 i originally thought it was the websockify piece since it was just disconnecing | 20:06 |
| KeithMnemonic | i can update the issue or try and move it | 20:06 |
| KeithMnemonic | melwitt: this is the issue here "rfb.js:685 Failed while connected: Unsupported encoding (encoding: -260)" | 20:07 |
| KeithMnemonic | so the older 1.0 does not handle encoding "-260" correctly | 20:07 |
| KeithMnemonic | 1.1 does | 20:07 |
| melwitt | ah, perfect, yeah we could just link to that issue for explaining the problem | 20:07 |
| KeithMnemonic | should i move it under novnc? or close and reopen a new one ? | 20:08 |
| KeithMnemonic | i dont think i can move it | 20:08 |
| *** lpetrut has joined #openstack-nova | 20:08 | |
| melwitt | oh, it's under the wrong component (I didn't understand that :P). yeah, I dunno, if it's possible to move it then that makes sense to me | 20:09 |
| KeithMnemonic | so i could close and reopen under novnc/novnc | 20:09 |
| KeithMnemonic | simple enough to close and reopen | 20:09 |
| *** slaweq has quit IRC | 20:09 | |
| melwitt | yeah, might be worth doing for the sake of avoiding confusion | 20:10 |
| openstackgerrit | Merged openstack/nova master: Add functional test for resize crash compute restart revert https://review.opendev.org/670393 | 20:10 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Convert HostMapping.cells to a dict https://review.opendev.org/663387 | 20:12 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cache host to cell mapping in HostManager https://review.opendev.org/663388 | 20:12 |
| melwitt | the noVNC people were responsive back when I proposed this nak'd pull request :P https://github.com/novnc/noVNC/pull/1220 | 20:13 |
| melwitt | so there's a chance they'll add some comments on the issue, that would be cool | 20:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Always set a global_request_id in RequestContext https://review.opendev.org/674138 | 20:14 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Correct global_request_id sent to Placement https://review.opendev.org/674129 | 20:14 |
| efried | what a waste of a ci run | 20:14 |
| *** eharney has quit IRC | 20:22 | |
| *** factor has joined #openstack-nova | 20:22 | |
| KeithMnemonic | melwitt: here you go https://github.com/novnc/noVNC/issues/1273 | 20:23 |
| melwitt | KeithMnemonic: woot thanks | 20:24 |
| KeithMnemonic | that describes the issue and fix if needed | 20:24 |
| KeithMnemonic | it was not exahaustively tested ;-) | 20:25 |
| KeithMnemonic | but i could get to cirros and type commands! | 20:25 |
| *** slaweq has joined #openstack-nova | 20:25 | |
| melwitt | what else do ya need? | 20:25 |
| KeithMnemonic | melwitt: I did not try anything with X for example. I am all set .I will watch the backport progress. If you need anything else from me please let me know. Thanks again | 20:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cache host to cell mapping in HostManager https://review.opendev.org/663388 | 20:28 |
| melwitt | KeithMnemonic: understood. I was trying to be funny, like what else do you need except cirros :P sounds good, thanks. I'll propose a patch for the console docs | 20:28 |
| KeithMnemonic | ah, sorry was too serious today | 20:28 |
| KeithMnemonic | lol | 20:28 |
| melwitt | nah, I'm sure it's me, I'm not good at jokes | 20:29 |
| *** slaweq has quit IRC | 20:30 | |
| *** eharney has joined #openstack-nova | 20:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Update comments in HostManager._get_instance_info https://review.opendev.org/674929 | 20:38 |
| *** mriedem is now known as mriedem_afk | 20:46 | |
| *** priteau has joined #openstack-nova | 20:51 | |
| *** whoami-rajat has quit IRC | 20:56 | |
| efried | occupational hazard | 21:02 |
| *** lpetrut has quit IRC | 21:08 | |
| *** spatel has quit IRC | 21:09 | |
| *** xek has quit IRC | 21:11 | |
| *** igordc has quit IRC | 21:12 | |
| *** mriedem_afk is now known as mriedem | 21:20 | |
| *** betherly has joined #openstack-nova | 21:22 | |
| *** bbowen__ has joined #openstack-nova | 21:24 | |
| *** betherly has quit IRC | 21:26 | |
| *** igordc has joined #openstack-nova | 21:31 | |
| sean-k-mooney | i assume no one here has tried using devstack on centos7 recently? | 21:33 |
| mriedem | you said you were done for the day | 21:33 |
| sean-k-mooney | ya i just checking by devstack install and it failed so im shutting down my sriov hosts | 21:34 |
| sean-k-mooney | but i havent use those in 2 months and i think in that time everything broke | 21:34 |
| sean-k-mooney | so i was hoping it worked so i can do testing tommorw but i think ill be installing ubuntu 18.04 instead tomorrow | 21:35 |
| sean-k-mooney | anyway night o/ | 21:35 |
| *** markvoelker has quit IRC | 21:38 | |
| *** avolkov has quit IRC | 21:45 | |
| *** abaindur has joined #openstack-nova | 21:56 | |
| abaindur | Can a VM be attached to an SR-IOV port as well as an OVS port on different networks? | 21:57 |
| openstackgerrit | Merged openstack/nova master: Pass migration to finish_revert_migration() https://review.opendev.org/668631 | 22:01 |
| openstackgerrit | Merged openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667913 | 22:01 |
| openstack | bug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | 22:01 |
| *** betherly has joined #openstack-nova | 22:13 | |
| *** _mlavalle_1 has joined #openstack-nova | 22:15 | |
| efried | mriedem: Do we have a bug for healing instances with VGPUs? | 22:15 |
| efried | Cause I'm 90% sure that's way busted. | 22:15 |
| efried | healing instance allocations* | 22:15 |
| *** mlavalle has quit IRC | 22:16 | |
| *** betherly has quit IRC | 22:17 | |
| mriedem | heal_allocations doesn't handle nested allocations | 22:18 |
| mriedem | well, not VGPU anyway, i guess the qos ports stuff would be on nested providers | 22:19 |
| efried | exactly | 22:19 |
| *** mlavalle has joined #openstack-nova | 22:21 | |
| *** priteau has quit IRC | 22:21 | |
| *** _mlavalle_1 has quit IRC | 22:22 | |
| mriedem | efried: why is that coming up? | 22:22 |
| mriedem | you were just like, "i want to work on some more terrible stuff" | 22:23 |
| efried | mriedem: I was reviewing stephenfin's patch to consolidate ResourceRequest building | 22:25 |
| efried | He removed a TODO from a spot where we merge all the allocations into a single dict | 22:26 |
| efried | The only place we use that is in heal allocations | 22:26 |
| efried | and looking at heal allocations it is clear that the TODO still very much applies | 22:26 |
| efried | I was considering opening a bug and/or writing a func test to prove how broken it is. | 22:27 |
| efried | so I wanted to know if there was an existing bug | 22:27 |
| efried | but anyway, not today. | 22:27 |
| *** betherly has joined #openstack-nova | 22:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: docs: update 2.23 REST API version history https://review.opendev.org/674948 | 22:37 |
| *** betherly has quit IRC | 22:38 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: document valid GET /os-migrations?migration_type values https://review.opendev.org/674949 | 22:42 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: docs: clarify nova migration-list --host option https://review.opendev.org/674950 | 22:45 |
| openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: docs: clarify nova migration-list --host option https://review.opendev.org/674950 | 22:46 |
| *** tkajinam has joined #openstack-nova | 22:51 | |
| *** igordc has quit IRC | 22:56 | |
| *** abaindur has quit IRC | 23:03 | |
| *** abaindur has joined #openstack-nova | 23:04 | |
| *** betherly has joined #openstack-nova | 23:05 | |
| *** betherly has quit IRC | 23:09 | |
| *** markvoelker has joined #openstack-nova | 23:13 | |
| *** markvoelker has quit IRC | 23:18 | |
| *** abaindur has quit IRC | 23:20 | |
| *** igordc has joined #openstack-nova | 23:20 | |
| *** threestrands has joined #openstack-nova | 23:24 | |
| *** betherly has joined #openstack-nova | 23:25 | |
| *** rcernin has joined #openstack-nova | 23:26 | |
| *** takashin has joined #openstack-nova | 23:27 | |
| *** betherly has quit IRC | 23:30 | |
| *** mriedem has quit IRC | 23:40 | |
| openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | 23:51 |
| *** betherly has joined #openstack-nova | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!