*** dpawlik has joined #openstack-nova | 00:11 | |
*** dpawlik has quit IRC | 00:15 | |
*** bbowen has quit IRC | 00:29 | |
*** ozzzo has quit IRC | 00:39 | |
*** gyee has quit IRC | 00:43 | |
*** markvoelker has quit IRC | 00:57 | |
*** larainema has joined #openstack-nova | 01:00 | |
*** mkrai has joined #openstack-nova | 01:07 | |
*** tetsuro has joined #openstack-nova | 01:12 | |
*** tetsuro has quit IRC | 01:13 | |
openstackgerrit | zhufl proposed openstack/nova master: [Trivial]Remove unused helper check_temp_folder https://review.opendev.org/678973 | 01:28 |
---|---|---|
*** threestrands has joined #openstack-nova | 01:39 | |
*** yikun has joined #openstack-nova | 01:50 | |
*** markvoelker has joined #openstack-nova | 01:52 | |
*** markvoelker has quit IRC | 02:02 | |
*** markvoelker has joined #openstack-nova | 02:03 | |
*** nicolasbock has quit IRC | 02:09 | |
*** eharney has quit IRC | 02:10 | |
*** spsurya has joined #openstack-nova | 02:10 | |
*** dpawlik has joined #openstack-nova | 02:11 | |
*** markvoelker has quit IRC | 02:13 | |
*** markvoelker has joined #openstack-nova | 02:14 | |
*** dpawlik has quit IRC | 02:16 | |
*** sapd1 has joined #openstack-nova | 02:18 | |
*** markvoelker has quit IRC | 02:24 | |
*** ricolin has joined #openstack-nova | 02:25 | |
openstackgerrit | zhufl proposed openstack/nova master: [Trivial]Remove unused helper get_allocated_disk_size https://review.opendev.org/678976 | 02:41 |
*** bbowen has joined #openstack-nova | 02:44 | |
*** itlinux has joined #openstack-nova | 02:44 | |
*** itlinux has quit IRC | 02:45 | |
openstackgerrit | ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407 | 03:06 |
*** psachin has joined #openstack-nova | 03:10 | |
*** gbarros has quit IRC | 03:32 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669 | 03:43 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | 03:43 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229 | 03:43 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | 03:43 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | 03:43 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 03:43 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 03:43 |
*** brinzhang has quit IRC | 03:49 | |
*** brinzhang has joined #openstack-nova | 03:50 | |
*** brinzhang has joined #openstack-nova | 03:51 | |
*** markvoelker has joined #openstack-nova | 04:05 | |
*** markvoelker has quit IRC | 04:10 | |
*** dpawlik has joined #openstack-nova | 04:13 | |
*** sapd1 has quit IRC | 04:14 | |
*** dpawlik has quit IRC | 04:17 | |
*** tkajinam_ has joined #openstack-nova | 04:37 | |
*** itlinux has joined #openstack-nova | 04:39 | |
*** tkajinam has quit IRC | 04:40 | |
*** dave-mccowan has quit IRC | 04:40 | |
*** brault has joined #openstack-nova | 04:50 | |
*** itlinux has quit IRC | 04:52 | |
*** brault has quit IRC | 04:54 | |
*** itlinux has joined #openstack-nova | 05:10 | |
openstackgerrit | melanie witt proposed openstack/nova master: Remove unused args from archive_deleted_rows calls https://review.opendev.org/678988 | 05:14 |
*** udesale has joined #openstack-nova | 05:14 | |
*** itlinux has quit IRC | 05:19 | |
*** ratailor has joined #openstack-nova | 05:19 | |
*** markvoelker has joined #openstack-nova | 05:20 | |
*** markvoelker has quit IRC | 05:25 | |
*** jhesketh has quit IRC | 05:34 | |
*** udesale has quit IRC | 05:38 | |
*** yaawang has quit IRC | 05:39 | |
openstackgerrit | Fan Zhang proposed openstack/nova master: Fix exception translation when creating volume https://review.opendev.org/678991 | 05:40 |
*** yaawang has joined #openstack-nova | 05:40 | |
*** jhesketh has joined #openstack-nova | 05:42 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Retrive the allocations early https://review.opendev.org/678450 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | 05:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | 05:45 |
*** udesale has joined #openstack-nova | 05:45 | |
*** udesale has quit IRC | 05:45 | |
*** udesale has joined #openstack-nova | 05:45 | |
*** Luzi has joined #openstack-nova | 05:46 | |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider config file schema and loader https://review.opendev.org/673341 | 05:49 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Public method to retrieve custom resource providers https://review.opendev.org/676029 | 05:49 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Load the custom resource providers to resource tracker https://review.opendev.org/676522 | 05:49 |
openstackgerrit | zhufl proposed openstack/nova master: [Trivial]Remove unused helper get_allocated_disk_size https://review.opendev.org/678976 | 05:59 |
*** lpetrut has joined #openstack-nova | 06:00 | |
*** dpawlik has joined #openstack-nova | 06:14 | |
*** shilpasd has joined #openstack-nova | 06:18 | |
*** udesale has quit IRC | 06:26 | |
*** udesale has joined #openstack-nova | 06:27 | |
*** slaweq has joined #openstack-nova | 06:27 | |
*** yaawang has quit IRC | 06:31 | |
*** udesale has quit IRC | 06:31 | |
*** slaweq has quit IRC | 06:32 | |
*** yaawang has joined #openstack-nova | 06:33 | |
*** slaweq has joined #openstack-nova | 06:48 | |
*** macz has joined #openstack-nova | 06:52 | |
*** macz has quit IRC | 06:56 | |
dr_gogeta86 | hi | 07:07 |
*** trident has quit IRC | 07:08 | |
dr_gogeta86 | nobody know a common pattern between nova-compute dying and rabbitmq connections falls to zero | 07:09 |
dr_gogeta86 | after a while from 10 to 30 minutes | 07:09 |
dr_gogeta86 | nova-compute kills all rabbitmq | 07:09 |
dr_gogeta86 | and going stuck | 07:09 |
*** rcernin has quit IRC | 07:12 | |
*** trident has joined #openstack-nova | 07:17 | |
*** xek has joined #openstack-nova | 07:17 | |
openstackgerrit | ZhengMa proposed openstack/nova master: Check container_format on instance creation https://review.opendev.org/673407 | 07:17 |
*** ivve has joined #openstack-nova | 07:28 | |
bauzas | good morning Nova | 07:32 |
*** aojea has joined #openstack-nova | 07:42 | |
*** aojeagarcia has joined #openstack-nova | 08:00 | |
*** aojea has quit IRC | 08:01 | |
*** tkajinam_ has quit IRC | 08:02 | |
*** jangutter has joined #openstack-nova | 08:03 | |
*** ccamacho has joined #openstack-nova | 08:04 | |
*** cdent has joined #openstack-nova | 08:05 | |
*** dougsz has joined #openstack-nova | 08:08 | |
*** mdbooth_ has joined #openstack-nova | 08:10 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451 | 08:11 |
*** ralonsoh has joined #openstack-nova | 08:24 | |
*** jaosorior has quit IRC | 08:28 | |
*** jaosorior has joined #openstack-nova | 08:29 | |
*** kashyap has joined #openstack-nova | 08:32 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | 08:33 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | 08:33 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | 08:35 |
kashyap | aspiers: Thanks for the PS-6 changes here, just got back: https://review.opendev.org/#/c/673790/6/ | 08:38 |
kashyap | aspiers: I _do_ owe a couple of drinks! | 08:39 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | 08:40 |
*** derekh has joined #openstack-nova | 08:43 | |
*** jaosorior has quit IRC | 08:46 | |
aspiers | kashyap: yw :) | 09:00 |
kashyap | aspiers: Investigating the "weird" thing you noticed: https://review.opendev.org/#/c/673790/6/nova/tests/unit/virt/libvirt/test_config.py@216 | 09:01 |
*** mtreinish has quit IRC | 09:13 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990 | 09:13 |
*** yedongcan has joined #openstack-nova | 09:13 | |
*** brault has joined #openstack-nova | 09:17 | |
openstackgerrit | ya.wang proposed openstack/nova master: vCPU model selection https://review.opendev.org/670298 | 09:22 |
openstackgerrit | ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299 | 09:22 |
openstackgerrit | ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300 | 09:22 |
*** sapd1 has joined #openstack-nova | 09:24 | |
*** jaosorior has joined #openstack-nova | 09:31 | |
*** dougsz has quit IRC | 09:35 | |
*** yedongcan has quit IRC | 09:37 | |
aspiers | kashyap: replied | 09:45 |
aspiers | stupid question - where's the thing which does linting on our .rst files? | 09:45 |
aspiers | I can't see it in tox.ini | 09:45 |
kashyap | aspiers: Thanks; will look | 09:46 |
kashyap | aspiers: Hmm, I'm unclear why os.loader.features doesn't contain the given keys doesn't make sense. | 09:47 |
*** dougsz has joined #openstack-nova | 09:51 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | 09:57 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | 10:00 |
sean-k-mooney | stephenfin: i noticed another helper function for nomalising tratis i can share between the prefilter and the driver code so im going to pull that out and then respin the first patch to adress your nits | 10:00 |
stephenfin | cool cool | 10:00 |
stephenfin | got some nits on the following one too if you want to wait 5 mins | 10:00 |
sean-k-mooney | also the verion in the prefilter has a bug | 10:01 |
sean-k-mooney | sure im just going to make coffee anyway | 10:01 |
sean-k-mooney | want me to wait untill you review all tree | 10:01 |
sean-k-mooney | then ill adress all your comments | 10:01 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019 | 10:02 |
*** macz has joined #openstack-nova | 10:05 | |
*** macz has quit IRC | 10:09 | |
stephenfin | sean-k-mooney: done | 10:11 |
sean-k-mooney | thanks just looking at the scond one now | 10:12 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | 10:16 |
bauzas | stephenfin: wow, chilling ^ | 10:22 |
* bauzas will use his red pen later in the afternoon | 10:23 | |
sean-k-mooney | bauzas: is that like something taht is almost cool | 10:23 |
bauzas | I should wear a t-shirt saying "I love reshapes" | 10:23 |
sean-k-mooney | if you did we would make you write all of them | 10:24 |
bauzas | \o/ | 10:24 |
bauzas | anyway, lunch now | 10:24 |
*** ricolin has quit IRC | 10:25 | |
*** tbachman has quit IRC | 10:43 | |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452 | 10:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453 | 10:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454 | 10:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | 10:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | 10:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | 10:45 |
openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | 11:03 |
*** cdent has quit IRC | 11:05 | |
*** nicolasbock has joined #openstack-nova | 11:08 | |
*** tesseract has joined #openstack-nova | 11:12 | |
*** sapd1 has quit IRC | 11:14 | |
sean-k-mooney | stephenfin: i hope that answers your question. https://review.opendev.org/#/c/665775/14/nova/scheduler/request_filter.py@176 im going to start reworkign the patches now but your comments make sense | 11:22 |
*** dtantsur|afk is now known as dtantsur | 11:26 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990 | 11:28 |
*** markvoelker has joined #openstack-nova | 11:43 | |
aspiers | kashyap: I'm getting a parse error on your last sentence :) | 11:51 |
*** shilpasd has quit IRC | 11:54 | |
*** brinzhang has quit IRC | 11:57 | |
*** brinzhang has joined #openstack-nova | 11:57 | |
*** jaosorior has quit IRC | 11:58 | |
*** dpawlik has quit IRC | 12:02 | |
aspiers | kashyap: but what I don't understand is why a list of OS bootloader features would be subdivided into two sections called 'type' and 'readonly' | 12:06 |
*** ratailor has quit IRC | 12:06 | |
aspiers | 'type' makes no sense as a category | 12:07 |
*** jaosorior has joined #openstack-nova | 12:11 | |
*** cdent has joined #openstack-nova | 12:15 | |
*** shilpasd has joined #openstack-nova | 12:17 | |
*** nweinber has joined #openstack-nova | 12:18 | |
kashyap | aspiers: Err, sorry for the garbled sentence; I meant, why doesn't os.loader.features with type|readonly make sense. | 12:20 |
kashyap | aspiers: Okay, you don't think 'type' makes sense as as category... | 12:20 |
kashyap | aspiers: Anyway, I'll think a bit more on what I can do there. | 12:24 |
aspiers | kashyap: 'type' makes as much sense as a category as 'category' does | 12:26 |
aspiers | i.e. none | 12:26 |
kashyap | aspiers: Hmm. As you'll recall, it's the "type" ("category"? :-)) of loader. I'll see about reworking | 12:27 |
*** tbachman has joined #openstack-nova | 12:29 | |
*** dpawlik has joined #openstack-nova | 12:30 | |
*** larainema has quit IRC | 12:30 | |
*** brinzhang has quit IRC | 12:39 | |
kashyap | aspiers: Also on your "not understanding" why a list of OS bootloader features would be subdivided into the two sections (enums) -- ask libvirt upstream :D | 12:41 |
kashyap | It _sounds_ like you temporarily forgot (but it's in the commit message, and you've seen it before :-)) the output spit out by getDomainCapabilities() | 12:42 |
* kashyap will now shut up tinker | 12:43 | |
*** ttsiouts has joined #openstack-nova | 12:43 | |
*** mgariepy has joined #openstack-nova | 12:44 | |
*** mdbooth_ has quit IRC | 12:48 | |
*** ricolin has joined #openstack-nova | 12:50 | |
*** mdbooth has joined #openstack-nova | 12:58 | |
alex_xu | aspiers: stephenfin in the end, I confused what the descision at here https://review.opendev.org/#/c/664420/42/nova/scheduler/request_filter.py@206 | 13:05 |
alex_xu | in the end, we said use req filter or not... | 13:06 |
*** gbarros has joined #openstack-nova | 13:06 | |
*** mriedem has joined #openstack-nova | 13:09 | |
*** dave-mccowan has joined #openstack-nova | 13:11 | |
stephenfin | alex_xu: I thought we were going to copy the approach from https://review.opendev.org/#/c/671801/32/nova/scheduler/utils.py | 13:24 |
stephenfin | so that's why I dragged https://review.opendev.org/#/c/674894/ to the front of the series | 13:24 |
stephenfin | mriedem, dansmith: You have been summoned by efried https://review.opendev.org/#/c/675338/ | 13:25 |
stephenfin | alex_xu: Yeah, that's what efried's comments are saying too. I guess aspiers is waiting to make sure that gets in first | 13:26 |
mriedem | stephenfin: why? | 13:27 |
stephenfin | Haven't a notion | 13:27 |
*** mdbooth has quit IRC | 13:27 | |
mriedem | the extra spec in those api samples could just as well be {'fart': 'sniffer'} | 13:27 |
stephenfin | Maybe because it's microversion related | 13:28 |
stephenfin | Yup, that's what I thought | 13:28 |
mriedem | it's not really, | 13:28 |
mriedem | but i see a good reason to -1 the shit out of your patch | 13:28 |
mriedem | oh drat https://review.opendev.org/#/c/675338/11/nova/tests/fixtures.py | 13:28 |
mriedem | you already got it | 13:28 |
stephenfin | #winning | 13:29 |
mriedem | +2 | 13:30 |
*** mdbooth has joined #openstack-nova | 13:35 | |
*** itlinux has joined #openstack-nova | 13:37 | |
mriedem | mdbooth: for https://review.opendev.org/#/c/677736/ i think we're just waiting for your customer to test it and ack it right? | 13:38 |
aspiers | stephenfin, alex_xu, efried: my understanding was that we were going to keep it in req filter for now and then change it later | 13:38 |
aspiers | kashyap: I don't have the slightest issue with features being split into two *meaningful* sections. But a section entitled "type" is totally meaningless. | 13:39 |
mdbooth | mriedem: So... they did test it but they didn't provide the same logs as last time. I've asked them for them, but they haven't been provided yet. | 13:39 |
mriedem | gibi: can i get a re-+W on https://review.opendev.org/#/c/637605/37 ? | 13:39 |
mriedem | mdbooth: did they notice the slow down? | 13:40 |
aspiers | kashyap: Let me take another tack. Please explain to me what this feature section entitled "type" is supposed to contain. | 13:40 |
aspiers | kashyap: And while you're at it, I'd like to understand what the section entitled "readonly" is supposed to contain. | 13:40 |
mdbooth | mriedem: Previously they were seeing compute hosts flapping, but that was only logged by n-api. We don't have logs for n-api. | 13:41 |
mriedem | stephenfin: i've re-ordered some of the less complicated changes in the cross-cell resize series to the bottom, could you take a look at this simple one to plumb passing the power_on flag down through driver.spawn()? https://review.opendev.org/#/c/642590/30 | 13:41 |
stephenfin | I sure can | 13:41 |
* stephenfin clicks | 13:41 | |
mriedem | which incidentally is something i think mdbooth has asked for in the past - the ability to create a stopped server | 13:41 |
mdbooth | mriedem: They *are* experience other environmental issues. | 13:41 |
mriedem | or maybe i'm dreaming that up | 13:41 |
mdbooth | mriedem: Yep, I have asked for that. | 13:41 |
kashyap | aspiers: I agree that a generic section is meaningless. Maybe 'loader_type', which tells _where_ the guest memory should be mapped -- whether it s a 'rom' or 'pflash' ? | 13:41 |
mdbooth | mriedem: So what I wanted to see be sure is: in the presence of their environmental issues, are the compute nodes continuing to flap? | 13:42 |
mdbooth | I'm hoping the answer's no. | 13:42 |
mriedem | right | 13:42 |
aspiers | kashyap: https://libvirt.org/formatdomaincaps.html#elementsOSBIOS doesn't even make sense here | 13:42 |
mdbooth | However, I'm not convinced it's worth waiting, tbh. | 13:42 |
aspiers | kashyap: It says of "type": "Whether loader is a typical BIOS (rom) or an UEFI binary (pflash). This refers to type attribute of the <loader/> element." | 13:43 |
mdbooth | It's a pretty clear bug, and the fix doesn't break anything we test, or a real environment. | 13:43 |
aspiers | kashyap: so it's portraying it as an either/or choice, but the schema places no restriction on the number of <value> elements, and indeed the example even lists *both* rom and pflash | 13:43 |
aspiers | kashyap: Also, there is no "type attribute of the <loader/> element" | 13:44 |
aspiers | kashyap: the docs for 'readonly' are even worse | 13:44 |
kashyap | aspiers: The docs _suck_ in this area | 13:44 |
aspiers | kashyap: and the example gives both yes and no as simultaneous values ... I mean, WT actual F | 13:45 |
kashyap | aspiers: On the either/or choice -- yeah, the docs say that, but the damn 'enum' implies there _could_ be more in future. Grrr | 13:45 |
aspiers | If it is supposed to be a choice between rom and pflash (and maybe others) then it should be <type>rom</type> or <type value="rom"/> | 13:46 |
aspiers | Likewise <readonly>yes</readonly> or <readonly value="yes"/> etc. | 13:46 |
kashyap | aspiers: Yeah, the upstream schema as it stands is not really ideal :-( | 13:46 |
aspiers | but a mapping from 'type' / 'readonly' to a list of values makes no sense | 13:46 |
aspiers | If multiple concurrent types are really allowed then I could get on board with <types>...</types>, or maybe even just about tolerate <enum name='types'>...</enum> | 13:47 |
aspiers | but 'type' (singular) rather than 'types' (plural) ... no | 13:48 |
*** ttsiouts has quit IRC | 13:48 | |
*** ttsiouts has joined #openstack-nova | 13:48 | |
kashyap | Right, so the "reality" is: it is a binary choice as it stands, not a multiple types at the _same_ time. | 13:49 |
aspiers | kashyap: Do you know whether rom and pflash are mutually exclusive values? Or can it actually be both at once? | 13:49 |
aspiers | What is actually valid here? | 13:49 |
kashyap | aspiers: Let me check with Michal Privoznik | 13:49 |
kashyap | (libvirt dev) | 13:49 |
*** itlinux has quit IRC | 13:49 | |
aspiers | kashyap: Thanks. Maybe it's more that the example XML given is wrong | 13:49 |
aspiers | kashyap: I can imagine that they might have written that to show all the <value>s which are allowed, without realising that putting them all together at once is deeply confusing. | 13:50 |
*** eharney has joined #openstack-nova | 13:50 | |
stephenfin | mriedem: We don't need to post to the mailing list when we add a parameter to the virt driver interface like that, do we? | 13:51 |
stephenfin | (the 'power_on' parameter) | 13:51 |
kashyap | aspiers: I completely agree on the confusion there, libvirt upstream definitely needs to address this. | 13:51 |
aspiers | kashyap: thanks for the moral support ;-) | 13:52 |
aspiers | kashyap: I've just pinged Jim Fehlig about it too | 13:52 |
mriedem | stephenfin: "need" to? no. but i can. | 13:53 |
*** ttsiouts has quit IRC | 13:53 | |
artom | stephenfin, depends on who you ask, but it won't hurt | 13:53 |
kashyap | aspiers: Yeah, it is much needed frustration. As you can see, if we're duking around this damn schema so much, it's clearly not us :D | 13:53 |
kashyap | s/much needed/understandable/ | 13:53 |
stephenfin | mriedem: Yeah, I think it would be helpful at least, if you have time | 13:53 |
*** priteau has joined #openstack-nova | 13:55 | |
mriedem | stephenfin: done | 13:56 |
stephenfin | ta | 13:56 |
*** aojeagarcia has quit IRC | 13:58 | |
aspiers | kashyap: Actually this is not just a libvirt issue. The confusion is significantly compounded by placing 'type' and 'readonly' under os.loader.features. | 13:58 |
aspiers | kashyap: It should be os.loader.type and os.loader.readonly instead. | 13:58 |
kashyap | aspiers: In the Nova config class? | 13:58 |
aspiers | kashyap: yes | 13:58 |
aspiers | 'type' is not a feature | 13:59 |
aspiers | kashyap: Imagine future code like: if 'rom' in os.loader.features['type']: ... | 14:00 |
aspiers | kashyap: vs. if os.loader.type == 'rom': | 14:00 |
*** eharney has quit IRC | 14:00 | |
aspiers | or: if 'rom' in os.loader.types: ... | 14:00 |
aspiers | The latter two are instantly understandable; the former is a #wtf moment | 14:01 |
kashyap | aspiers: Nod. Okay, first step is to untangle this by moving type/readonly under os.loader, rather than os.loader.features | 14:02 |
aspiers | Public safety warning: I'm probably using overly antagonistic language right now, due to the mood which the ongoing clusterfuck in British politics has just put me into. Sorry in advance for any offense caused. | 14:02 |
aspiers | kashyap: Yes that would be a very good step I think | 14:03 |
aspiers | kashyap: and then if multiple types are allowed, we can ignore <type> in the libvirt schema and use os.loader.types (plural) instead | 14:03 |
kashyap | aspiers: Okay, Michal confirms - rom|pflash _are_ mutually exclusive. (As we guessed) | 14:04 |
aspiers | Ahah :-) | 14:04 |
aspiers | So the example XML is wrong | 14:04 |
aspiers | and hence our test fixtures too | 14:04 |
aspiers | kashyap: What about 'readonly' and 'secure'? | 14:05 |
kashyap | mprivozn: Yeah, you can't have secure "yes" and "no" at the same time -- that'll be "Schrödinger's XML"... | 14:06 |
kashyap | aspiers: They are also mutually exclusive. | 14:06 |
kashyap | aspiers: Okay, so on the example, this is what Michal says on _why_ both of them are listed: | 14:06 |
aspiers | kashyap: mprivozn isn't here ;-) wrong window? | 14:06 |
kashyap | aspiers: Here: | 14:07 |
kashyap | 16:04 < kashyap> mprivozn: Then, I'll submit a docs change to show just _one_ value under type|readonly|secure: https://libvirt.org/formatdomaincaps.html#elementsOSBIOS | 14:07 |
kashyap | 16:05 < mprivozn> kashyap: please don't | 14:07 |
kashyap | 16:05 < kashyap> (Because accepted values are shown in the below text) | 14:07 |
kashyap | 16:05 < kashyap> mprivozn: Hmm, why not? You wanted them there to show what are the possible values? | 14:07 |
kashyap | 16:05 < mprivozn> kashyap: the idea for domaincaps is to enumerate all accepted values; listing just one variant goes against that | 14:07 |
kashyap | 16:06 < mprivozn> kashyap: forget OSBIOS for a second and take a look at some other examples, diskDevice for instance | 14:07 |
kashyap | aspiers: So following the above example, diskDevice lists 4 different values (disk, cdrom, floppy, lun). | 14:08 |
aspiers | OK, so all the docs are wrong not just this? | 14:09 |
kashyap | aspiers: I.e. it can be _one_ of those values. | 14:09 |
aspiers | I'm sorry, but docs giving example XML which doesn't even validate against the schema (notional or otherwise) does not make sense | 14:09 |
kashyap | aspiers: No, the dev says docs are not wrong, and they intentionally enumerated as such | 14:09 |
aspiers | The allowed values can be listed *below* the example XML, or as comments in it | 14:09 |
kashyap | aspiers: See this point above: "the idea for domaincaps is to enumerate all accepted values; listing just one variant goes against that" | 14:09 |
aspiers | by "domaincaps" he means https://libvirt.org/formatdomaincaps.html ? | 14:10 |
aspiers | or something else? | 14:10 |
kashyap | aspiers: Yes, indeed | 14:10 |
aspiers | should we move this to #libvirt? | 14:10 |
kashyap | #virt, on OFTC, yes | 14:10 |
aspiers | oh OK | 14:10 |
sean-k-mooney | kashyap: isnt #virt internal? | 14:11 |
kashyap | sean-k-mooney: No. #virt is the community channel for libvirt on OFTC | 14:11 |
aspiers | weird, why not #libvirt? | 14:11 |
kashyap | (I mean, yes, too. But external exists, too) | 14:11 |
kashyap | aspiers: Because it includes adjacent projects like virt-manager, virt-tools, libosinfo, etc, in addition to libvirt | 14:12 |
*** cdent has quit IRC | 14:16 | |
*** cdent has joined #openstack-nova | 14:16 | |
*** cdent has quit IRC | 14:22 | |
mriedem | stephenfin: replied on https://review.opendev.org/#/c/637605/37 | 14:22 |
*** openstackgerrit has quit IRC | 14:22 | |
mriedem | and up, thanks for hitting those | 14:22 |
dansmith | mriedem: you wanna look at artom's latest changes on this per our discussion yesterday and opine on whether or not you can tolerate the hackery? https://review.opendev.org/#/c/635669/45 | 14:23 |
stephenfin | Ah, I meant would it make sense to add a 'should_raise' parameter to the 'delete' function (i.e. make it optional). It was a nit though | 14:24 |
stephenfin | should_raise or something along those lines | 14:24 |
mriedem | dansmith: sure | 14:26 |
*** markvoelker has quit IRC | 14:26 | |
dansmith | artom: left some clarifying questions in there, btw | 14:29 |
*** eharney has joined #openstack-nova | 14:29 | |
*** markvoelker has joined #openstack-nova | 14:29 | |
*** dpawlik has quit IRC | 14:29 | |
dansmith | artom: have you looked at why that DNM tempest test failed the live migration job? | 14:32 |
dansmith | looks like during setup, so maybe just something in the script | 14:33 |
dansmith | er, no | 14:33 |
*** amotoki_ has quit IRC | 14:34 | |
*** amotoki has joined #openstack-nova | 14:35 | |
*** markvoelker has quit IRC | 14:37 | |
*** markvoelker has joined #openstack-nova | 14:38 | |
*** Luzi has quit IRC | 14:40 | |
mriedem | https://storage.bhs1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/logs_87/678887/6/check/nova-live-migration/d3d4357/ara-report/result/092050bb-201e-4657-ac3f-16aebd4578ff/ failed but not sure why yet | 14:40 |
mriedem | oh the job timed out | 14:40 |
mriedem | /home/zuul/workspace/devstack-gate/functions.sh: line 1018: 5091 Killed timeout -s 9 ${REMAINING_TIME}m bash -c "source $WORKSPACE/devstack-gate/functions.sh && $cmd" | 14:40 |
dansmith | yeah, but I figure it might be because it was polling for that to go active or something | 14:41 |
dansmith | looks like it started building an instance right around the on the subnode | 14:43 |
mriedem | the funny thing is, | 14:44 |
mriedem | it doesn't even seem to run the live migration stuff | 14:44 |
mriedem | it goes right to the test_evacuate.sh script | 14:44 |
*** gbarros has quit IRC | 14:44 | |
dansmith | yeah | 14:45 |
dansmith | I didn't look to see the ordering | 14:45 |
mriedem | 2019-08-28 04:37:56.230 | 1. test with all local storage (use default for volumes) 2019-08-28 04:37:56.232 | NOTE: test_volume_backed_live_migration is skipped due to https://bugs.launchpad.net/nova/+bug/1524898 2019-08-28 04:37:57.817 | Missing value auth-url required for auth plugin password 2019-08-28 04:37:57.909 | + environment:post_test_hook:L1: /opt/stack/new/nova/gate/test_evacuate.sh | 14:46 |
openstack | Launchpad bug 1524898 in OpenStack Compute (nova) "Volume based live migration aborted unexpectedly" [High,In progress] - Assigned to Lee Yarwood (lyarwood) | 14:46 |
mriedem | maybe the flavor creation is blowing up? | 14:46 |
dansmith | ah | 14:46 |
mriedem | we're losing the tracing too | 14:47 |
dansmith | I still wanna know why this instance didn't build in case it is related to tweaking the claim stuff, | 14:47 |
mriedem | from one of the sourced scripts | 14:47 |
dansmith | but it seems like it's waiting for the neutron event | 14:47 |
dansmith | it's still in building state at the end of the run | 14:48 |
dansmith | ah, artom said something about that early this morning.. | 14:48 |
mriedem | instance c2b876e6-b616-4259-b03b-f0b2bd3d8908 right? | 14:49 |
dansmith | yup | 14:49 |
mriedem | yup start waiting for the event here https://zuul.opendev.org/t/openstack/build/d3d4357c13be452fa8e64a6b612c256d/log/logs/subnode-2/screen-n-cpu.txt.gz#1905 | 14:50 |
mriedem | Aug 28 04:38:17.325822 ubuntu-bionic-vexxhost-vexxhost-sjc1-0010477321 nova-compute[24765]: DEBUG nova.compute.manager [None req-4d7771be-f2e2-429d-87c7-1cd4469cede5 demo admin] [instance: c2b876e6-b616-4259-b03b-f0b2bd3d8908] Preparing to wait for external event network-vif-plugged-afd502d7-a21d-48f2-8607-881a86f0781f {{(pid=24765) prepare_for_instance_event /opt/stack/new/nova/nova/compute/manager.py:329}} | 14:50 |
mriedem | got the event here | 14:51 |
mriedem | https://zuul.opendev.org/t/openstack/build/d3d4357c13be452fa8e64a6b612c256d/log/logs/subnode-2/screen-n-cpu.txt.gz#1941 | 14:51 |
mriedem | Aug 28 04:38:21.643105 ubuntu-bionic-vexxhost-vexxhost-sjc1-0010477321 nova-compute[24765]: DEBUG nova.compute.manager [req-61851260-be42-4748-9d79-4b0ec5c08ed6 req-3c63a866-a638-4ec7-9f56-3a7aeb2e9958 service nova] [instance: c2b876e6-b616-4259-b03b-f0b2bd3d8908] Received event network-vif-plugged-afd502d7-a21d-48f2-8607-881a86f0781f {{(pid=24765) external_instance_event /opt/stack/new/nova/nova/compute/manager.py:8819}} | 14:51 |
mriedem | 4 seconds later | 14:52 |
*** gbarros has joined #openstack-nova | 14:52 | |
*** lpetrut has quit IRC | 14:52 | |
dansmith | presumably unrelated to his change though if we've made it to the neutron event stage | 14:52 |
mriedem | i think during artom's revert resize ovs hybrid plug race thing that evacuate could have the same kind of race b/c of the time that we trigger the event by updating the port binding and when the driver's spawn method start waiting for it | 14:54 |
mriedem | although, if we didn't have a handler registered for the event callback we'd see "Received unexpected event" in the logs | 14:55 |
mriedem | which we don't | 14:55 |
mriedem | so idk what's going on there | 14:55 |
*** mlavalle has joined #openstack-nova | 14:55 | |
mriedem | the guest power state goes from paused > running > paused agin | 14:56 |
mriedem | *agian | 14:56 |
mriedem | gah | 14:56 |
mriedem | but still, i'm wondering why the run_tests script didn't actually run any live migration tests | 14:57 |
*** igordc has joined #openstack-nova | 14:57 | |
kashyap | aspiers: When you get a sec, summarized our discussion from #virt (OFTC) here, for other Stackers: https://review.opendev.org/#/c/673790/ | 14:58 |
*** mkrai_ has joined #openstack-nova | 14:59 | |
*** openstackgerrit has joined #openstack-nova | 15:01 | |
openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 15:01 |
*** mkrai has quit IRC | 15:01 | |
*** shilpasd has quit IRC | 15:02 | |
mriedem | dansmith: artom: let's see if ^ helps | 15:02 |
*** dpawlik has joined #openstack-nova | 15:02 | |
dansmith | cool | 15:02 |
melwitt | mriedem: follow up patch is here https://review.opendev.org/678988 | 15:05 |
*** dpawlik has quit IRC | 15:07 | |
melwitt | dansmith: the multi-cell archive_deleted_rows set (this patch and the one on top of it) have a +2 from mriedem, if you would fancy taking a look please | 15:07 |
melwitt | https://review.opendev.org/507486 | 15:07 |
mriedem | got it | 15:08 |
melwitt | danke | 15:09 |
dansmith | melwitt: I know, I've had it open just have to get to it | 15:14 |
melwitt | ok, thanks. sorry didn't know you already knew | 15:15 |
*** lpetrut has joined #openstack-nova | 15:15 | |
dansmith | yeah, I opened the tab when mriedem pinged us yesterday | 15:15 |
melwitt | k | 15:18 |
*** markvoelker has quit IRC | 15:18 | |
*** donnyd has quit IRC | 15:19 | |
*** donnyd has joined #openstack-nova | 15:20 | |
*** donnyd has quit IRC | 15:20 | |
*** markvoelker has joined #openstack-nova | 15:21 | |
*** donnyd has joined #openstack-nova | 15:21 | |
*** hemna has joined #openstack-nova | 15:22 | |
mriedem | artom: did you ever follow up with getting something on the starlingx weekly meeting about testing the numa LM series? | 15:22 |
*** ivve has quit IRC | 15:24 | |
*** gyee has joined #openstack-nova | 15:26 | |
*** ash2307 has joined #openstack-nova | 15:28 | |
*** ash2307 has left #openstack-nova | 15:28 | |
mriedem | just realized that we have 41 approved blueprints for train with only 12 complete and 2 weeks to FF | 15:30 |
mriedem | probably time to start deferring things that we know aren't going to land | 15:31 |
*** mkrai_ has quit IRC | 15:32 | |
donnyd | so yesterdays test of mounting _base on a shared location didn't go well | 15:34 |
*** dpawlik has joined #openstack-nova | 15:34 | |
donnyd | for some unknown reason qemu-img info reports back that the cached image could not be found | 15:35 |
*** dpawlik has quit IRC | 15:39 | |
*** niceplace_ has joined #openstack-nova | 15:39 | |
*** hemna has quit IRC | 15:40 | |
*** hemna has joined #openstack-nova | 15:41 | |
*** cdent has joined #openstack-nova | 15:46 | |
*** panda is now known as panda|rover | 15:47 | |
mriedem | stephenfin: can we effectively mark this complete? https://blueprints.launchpad.net/nova/+spec/remove-cells-v1 | 16:00 |
mriedem | there are only 2 open changes https://review.opendev.org/#/q/topic:bp/remove-cells-v1+(status:open) | 16:00 |
openstackgerrit | Merged openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | 16:00 |
stephenfin | Yup, it's complete. Those two are very tricky post-removal cleanup patches | 16:00 |
stephenfin | I'll come back to them when I can | 16:01 |
cdent | cells v1 is gone? wooooooo! | 16:03 |
mriedem | melwitt: would be sweet if we can get https://review.opendev.org/#/c/640898/ approved by the end of the week - it's 2 weeks to FF and it'd be nice to land that series in time for train | 16:03 |
*** ricolin has quit IRC | 16:04 | |
*** ricolin has joined #openstack-nova | 16:04 | |
melwitt | mriedem: indeed, I'm gonna update it after this last call I'm on. thanks for reminding | 16:04 |
*** tesseract has quit IRC | 16:08 | |
dansmith | mriedem: are you pretty confident on this archive multi cells thing? I've skimmed the logic and tests and just can't really get myself to go deep on it | 16:09 |
dansmith | seems pretty low risk even if there is something wrong in here, so I'm tempted to just +W based on my skimming | 16:09 |
dansmith | s/seems/should be/ | 16:09 |
*** ricolin has quit IRC | 16:12 | |
openstackgerrit | Merged openstack/nova master: scheduler: Flatten 'ResourceRequest.from_extra_specs', 'from_image_props' https://review.opendev.org/674894 | 16:12 |
openstackgerrit | Merged openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples https://review.opendev.org/675338 | 16:12 |
mriedem | dansmith: bombs away | 16:12 |
mriedem | and yeah i've gone over it several times in detail now | 16:13 |
mriedem | probably annoying detail for melwitt | 16:13 |
mriedem | the nova-next change on top also shows it working as expected | 16:13 |
dansmith | oh sweet I didn't even notice | 16:15 |
*** efried is now known as efried_rollin | 16:16 | |
dansmith | got those as well | 16:16 |
*** itlinux has joined #openstack-nova | 16:17 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add online migration for legacy NUMA objects https://review.opendev.org/537414 | 16:19 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename 'nova.tests.unit.test_nova_manage' https://review.opendev.org/679095 | 16:19 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Ensure online migrations have a unique name https://review.opendev.org/679096 | 16:19 |
stephenfin | mriedem: You'll probably be interested in the last of those ^ | 16:19 |
*** itlinux is now known as itlinux-away | 16:20 | |
dansmith | mriedem: 2019-08-28 16:12:53.222764 | primary | 2019-08-28 16:12:53.222 | Missing value auth-url required for auth plugin password | 16:21 |
dansmith | mriedem: on the grenade lm job | 16:21 |
dansmith | mriedem: the regular one failed with node_failure | 16:21 |
*** itlinux-away has quit IRC | 16:25 | |
*** brault has quit IRC | 16:27 | |
melwitt | thanks dansmith++ | 16:29 |
*** N3l1x has joined #openstack-nova | 16:32 | |
artom | mriedem, dansmith, was on calls in the car all morning, catching up on scrollback | 16:33 |
artom | mriedem, crap, forgot about that starlingx meeting thing :( | 16:33 |
*** macz has joined #openstack-nova | 16:33 | |
artom | Thanks for reminding me | 16:33 |
artom | (And right now I need to drive daughter to school, so I need to run again) | 16:35 |
artom | Though I'll try to respond to dansmith on that initial claims patch before I do so | 16:35 |
dansmith | artom: we should try to get that test patch running again first | 16:36 |
dansmith | I'm guessing we | 16:36 |
dansmith | just need to source openrc first somewhere | 16:36 |
artom | dansmith, yeah, I need to look at that too - sean-k-mooney seemed to also have ideas | 16:38 |
dansmith | gI think I got it | 16:38 |
openstackgerrit | Dan Smith proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 16:39 |
dansmith | pulled a couple lines from the ceph hook which use osc | 16:39 |
dansmith | artom: I think his ideas were about making it suitable for all time, and that's not the point of this :) | 16:39 |
artom | dansmith, heh, indeed, quick and dirty all the way :D | 16:40 |
sean-k-mooney | well i was just suggestin using the way i know works | 16:40 |
sean-k-mooney | but also yes they are the less hacky way of doing it | 16:40 |
sean-k-mooney | if you way works thats good enough for this | 16:40 |
dansmith | I wish we could control which job runs on a patch.. like if the commit message starts with "DNM" then zuul can -2 it and only run tests the commit message asks for or something | 16:41 |
artom | dansmith, https://review.opendev.org/#/c/635669/45 there, hope that answers is | 16:46 |
artom | *it | 16:46 |
dansmith | artom: yeah, although I'm not sure why we need the call out if the current ordering will work | 16:49 |
dansmith | especially if we plan to remove it from the sriov path and have it in here in the long term | 16:49 |
mriedem | dansmith: we could also make that DNM change run faster but commenting out all other jobs except the ones we want to run | 16:49 |
* mriedem goes to get a haircut | 16:49 | |
dansmith | mriedem said he would go through the hackery in there and see if he could stomach it | 16:49 |
*** mriedem is now known as mriedem_away | 16:49 | |
dansmith | post-haircut Iguess | 16:49 |
mriedem_away | i got distracted with the DNM debugging earlier | 16:50 |
dansmith | that's fine, | 16:50 |
dansmith | I want to see that test run anyway | 16:50 |
artom | dansmith, I don't like depending on an ordering that's so far away, but maybe we could call it out in a comment in the compute manager, and lest _test_pci() do its thing | 16:51 |
artom | *let | 16:51 |
dansmith | artom: can you just remove the other accounting and rely on this one? | 16:52 |
dansmith | I mean, I don't want to go all into refactoring it, just curious | 16:52 |
artom | dansmith, that would be a larger effort to make SRIOV live migration use the move claim | 16:52 |
dansmith | and yes, not relying on ordering is good, but.. | 16:52 |
artom | Which should get done, but probably not as part of this series | 16:52 |
dansmith | I'm not sure I understand why it's any different | 16:53 |
dansmith | because SRIOV migration is not a different operation, so I would expect you'd still hit all this code and be fine | 16:53 |
dansmith | but mkay | 16:53 |
artom | I guess I'm just being overly cautious, and don't want to start a potential rabbit hole at this stage? | 16:53 |
dansmith | yeah for sure | 16:53 |
dansmith | just... you said it would work with the current ordering | 16:54 |
artom | Oh, you mean that? yeah, we could do that | 16:54 |
dansmith | no, | 16:54 |
dansmith | I'm taking that to its logical (to me) conclusion | 16:54 |
dansmith | anyway, | 16:54 |
dansmith | this is why we really should have been working on this set at the beginning of a cycle and not the end | 16:54 |
dansmith | so it's frustrating to have to bake in debt like this because of the timeline, | 16:55 |
artom | Yeah | 16:55 |
dansmith | especially if you're going to be busy again early next cycle such that it never gets cleaned up | 16:55 |
artom | I mean, there's no guarantee that we would have stumbled on this earlier, but it's a true thing as a matter of principle, so I can't disagree | 16:55 |
artom | Anyways, I gotta run for first school day | 16:56 |
artom | Well, half-day | 16:56 |
*** artom has quit IRC | 16:56 | |
*** derekh has quit IRC | 16:57 | |
openstackgerrit | Merged openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605 | 16:57 |
openstackgerrit | Merged openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183 | 16:58 |
*** dougsz has quit IRC | 17:01 | |
*** lbragstad has joined #openstack-nova | 17:01 | |
*** itlinux has joined #openstack-nova | 17:02 | |
*** spatel has joined #openstack-nova | 17:06 | |
spatel | sean-k-mooney: hey!! afternoon | 17:06 |
*** itlinux has quit IRC | 17:07 | |
*** dtantsur is now known as dtantsur|afk | 17:08 | |
*** gbarros has quit IRC | 17:14 | |
donnyd | Do people connect cdrom devices for reasons other than config-drive in most cases? | 17:15 |
dansmith | mriedem_away: numa flavor got created after my change | 17:21 |
*** panda|rover is now known as panda|rover|off | 17:23 | |
*** gbarros has joined #openstack-nova | 17:24 | |
jroll | so I'm doing GPU passthrough with a few different devices. one of them apparently exposes some SRIOV PFs, so it's presenting as `type-PF` rather than `type-PCI`, and so passthrough isn't working with a `pci_passthrough` property on the flavor. do I need to like, figure out how to do SRIOV and go that route, or is there a way to tell nova to maek it just a regular PCI device? | 17:25 |
dansmith | mriedem_away: and...failed to boot an instance with it | 17:25 |
*** brault has joined #openstack-nova | 17:30 | |
*** gbarros has quit IRC | 17:33 | |
*** brault has quit IRC | 17:34 | |
*** dpawlik has joined #openstack-nova | 17:35 | |
*** dpawlik has quit IRC | 17:40 | |
*** cdent has quit IRC | 17:42 | |
*** eharney_ has joined #openstack-nova | 17:43 | |
*** eharney has quit IRC | 17:44 | |
*** brault has joined #openstack-nova | 17:44 | |
*** brault has quit IRC | 17:45 | |
*** cdent has joined #openstack-nova | 17:46 | |
*** eharney_ is now known as eharney | 17:46 | |
*** jmlowe has quit IRC | 17:51 | |
*** mmethot has quit IRC | 17:58 | |
*** mmethot has joined #openstack-nova | 17:58 | |
*** jmlowe has joined #openstack-nova | 18:06 | |
sean-k-mooney | dansmith: Failed to start libvirt guest: libvirtError: Requested operation is not valid: cpu affinity is not supported | 18:12 |
*** priteau has quit IRC | 18:12 | |
*** ociuhandu has joined #openstack-nova | 18:12 | |
sean-k-mooney | <domain type='qemu'> | 18:12 |
sean-k-mooney | setting the virt_type to kvm did not work | 18:13 |
*** psachin has quit IRC | 18:13 | |
sean-k-mooney | yep its set to qemu | 18:13 |
sean-k-mooney | https://d8076f0c34babfa2d8fa-c3c714f53a28264bde7e35c9b01061ab.ssl.cf2.rackcdn.com/678887/8/check/nova-live-migration/21801ca/logs/etc/nova/nova-cpu.conf.txt.gz | 18:13 |
sean-k-mooney | which is why the job failed | 18:14 |
sean-k-mooney | the local.conf has LIBVIRT_TYPE=kvm https://d8076f0c34babfa2d8fa-c3c714f53a28264bde7e35c9b01061ab.ssl.cf2.rackcdn.com/678887/8/check/nova-live-migration/21801ca/logs/local.conf.txt.gz | 18:14 |
dansmith | sean-k-mooney: cool, gonna push up a change? | 18:14 |
*** cdent has quit IRC | 18:14 | |
sean-k-mooney | the issue it seams is its set twice | 18:15 |
sean-k-mooney | yes ill fix it | 18:15 |
sean-k-mooney | we just need to set the virt type in the zuul.yaml instead | 18:15 |
dansmith | maybe we need to set it in the hook and restart compute? | 18:15 |
dansmith | okay | 18:15 |
dansmith | er, no the hook won't affect the subnode I guess | 18:16 |
sean-k-mooney | the base gate jobs hardcode it to qemu but we can just override it | 18:16 |
dansmith | ack | 18:16 |
mriedem_away | overriding it is what i did in the run.yaml | 18:21 |
*** mriedem_away is now known as mriedem | 18:21 | |
sean-k-mooney | ya but it didnt work | 18:22 |
lbragstad | johnthetubaguy any chance you'd be willing to take a peek at https://review.opendev.org/#/c/644615/ ? | 18:22 |
sean-k-mooney | https://github.com/openstack/devstack/blob/master/.zuul.yaml#L223 | 18:22 |
sean-k-mooney | im just going to set this | 18:22 |
mriedem | i removed it from the run_test script b/c it was only setting it on the primary and not the subnode compute as well, but we shouldn't need to do that since it's in local.conf | 18:22 |
mriedem | sean-k-mooney: yeah, that's what i did in the run.yaml | 18:22 |
mriedem | sean-k-mooney: https://review.opendev.org/#/c/678887/8/playbooks/legacy/nova-live-migration/run.yaml | 18:22 |
sean-k-mooney | i didnt think you coudl do it there | 18:22 |
sean-k-mooney | or rather i hav enever tried too | 18:23 |
sean-k-mooney | oh ya | 18:23 |
mriedem | it's the legacy way | 18:23 |
sean-k-mooney | so it ended up being there twice | 18:23 |
sean-k-mooney | both with qemu and then with kvm | 18:23 |
*** igordc has quit IRC | 18:23 | |
sean-k-mooney | i dont know why qemu | 18:23 |
sean-k-mooney | won | 18:23 |
sean-k-mooney | but it did | 18:23 |
mriedem | yeah, so i guess just overriding in zuul.yaml might work | 18:24 |
sean-k-mooney | ill set it in all the places | 18:24 |
sean-k-mooney | one of them will work :) | 18:24 |
mriedem | i'd say while doing that, also comment out the jobs we don't care about running | 18:24 |
sean-k-mooney | ya no need to was gate time | 18:25 |
mriedem | could also just do post-config|$NOVA_CPU_CONF | 18:25 |
sean-k-mooney | yep | 18:25 |
mriedem | but i don't really trust that LIBVIRT_TYPE variable | 18:25 |
sean-k-mooney | i can do that too | 18:25 |
mriedem | dansmith: so is it worth me looking at https://review.opendev.org/#/c/635669/45 right now? | 18:26 |
dansmith | yes | 18:26 |
*** tbachman has quit IRC | 18:27 | |
* mriedem puts on diaper | 18:28 | |
*** prometheanfire has quit IRC | 18:32 | |
*** tbachman has joined #openstack-nova | 18:32 | |
*** prometheanfire has joined #openstack-nova | 18:32 | |
openstackgerrit | sean mooney proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 18:32 |
sean-k-mooney | that is proably over kill but it should for the config to what we want it to have | 18:33 |
*** itlinux has joined #openstack-nova | 18:44 | |
*** itlinux has quit IRC | 18:48 | |
openstackgerrit | sean mooney proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 18:50 |
*** bbowen has quit IRC | 18:51 | |
openstackgerrit | sean mooney proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 18:52 |
*** gbarros has joined #openstack-nova | 18:59 | |
*** lpetrut has quit IRC | 19:02 | |
mriedem | dansmith: i've disposed of my soiled diaper | 19:11 |
dansmith | mriedem: I was looking for confirmation that the hacks to avoid disrupting the sriov stuff would fly with you, which I assume from the summary is ... yes? | 19:12 |
mriedem | it's definitely better than it was | 19:13 |
mriedem | being explicit i mean | 19:13 |
dansmith | yes, but... is that a yes? :) | 19:13 |
sean-k-mooney | ill redeploy with this version either later today or tomorow and report what i find. | 19:14 |
*** ociuhandu has quit IRC | 19:14 | |
*** tbachman has quit IRC | 19:15 | |
dansmith | sean-k-mooney: thanks | 19:16 |
*** Sundar has joined #openstack-nova | 19:19 | |
*** ivve has joined #openstack-nova | 19:20 | |
mriedem | dansmith: well, compared to what? the alternative of making numa live migration miss the release to retrofit the sriov pci claim stuff into the actual MoveClaim? if so, then yes this dirty hackery is acceptable i guess | 19:22 |
mriedem | i have a feeling it's a hack that we'll have forever | 19:22 |
mriedem | but such is nova | 19:22 |
dansmith | yes, that's what I mean, and yes that's the shame I cast on artom earlier this morning about not cleaning it up after the release | 19:22 |
dansmith | we'll see if the shame works or not | 19:22 |
*** efried_rollin is now known as efried | 19:22 | |
melwitt | cast shame 3 | 19:23 |
*** itlinux has joined #openstack-nova | 19:23 | |
melwitt | highest level spell | 19:23 |
sean-k-mooney | one way or another we will converge them in U | 19:23 |
mriedem | artom is pretty good at saving throws though | 19:23 |
melwitt | lol | 19:23 |
sean-k-mooney | if artom does not work on it i will. | 19:23 |
dansmith | I'm going to pretend I understand all this dorkery and chuckle | 19:24 |
melwitt | I know, you're just too cool | 19:24 |
mriedem | https://en.wikipedia.org/wiki/Saving_throw god | 19:24 |
sean-k-mooney | what the DC on this charisma check | 19:24 |
mriedem | if it weren't for artom's high charisma he'd have been dead long ago | 19:25 |
dansmith | I just never played any of that stuff so I don't know | 19:25 |
melwitt | sean-k-mooney: I had to google that xD | 19:25 |
melwitt | lol mriedem | 19:25 |
melwitt | that was a good one | 19:26 |
sean-k-mooney | on of my friends runs a game and got me to sit in at teh weekend so that make 3 times i have played a dnd game now... not sure if that is a good or a bad thing | 19:26 |
melwitt | I'm sure it's good. I have never played, I'm video game only | 19:27 |
mriedem | i've never actually played a sit down board game but my brother had all that stuff and i rocked the ibm pc floppies for https://en.wikipedia.org/wiki/Pool_of_Radiance | 19:27 |
sean-k-mooney | most of my iteraction with D&D was baldur's gate on the pc | 19:28 |
melwitt | similar for me. I played https://en.wikipedia.org/wiki/Eye_of_the_Beholder_III:_Assault_on_Myth_Drannor | 19:28 |
*** itlinux_ has joined #openstack-nova | 19:28 | |
*** itlinux has quit IRC | 19:31 | |
dansmith | man ya'll'er dorks | 19:33 |
sean-k-mooney | say the ham radio nerd :) | 19:33 |
melwitt | shots fired | 19:34 |
dansmith | i, uh | 19:34 |
dansmith | well, | 19:34 |
*** nicolasbock has quit IRC | 19:34 | |
dansmith | I guess I'll be proud of being a radio nerd and you all can be, uh, proud of your games :D | 19:34 |
sean-k-mooney | :) | 19:35 |
* dansmith quietly puts sean-k-mooney on "the list" | 19:35 | |
* sean-k-mooney worth it | 19:36 | |
melwitt | lol | 19:36 |
*** eharney has quit IRC | 19:36 | |
*** dpawlik has joined #openstack-nova | 19:36 | |
dansmith | sean-k-mooney: do we need to recheck that LM test | 19:36 |
dansmith | ? | 19:36 |
dansmith | ah, you removed a bunch of other jobs | 19:36 |
dansmith | I thought the zuul report looked weird | 19:37 |
sean-k-mooney | it did but i still have an issue in v11 | 19:37 |
sean-k-mooney | im just goint to remove the sub group stuff | 19:37 |
sean-k-mooney | which is what i did in v10 | 19:37 |
dansmith | okay | 19:37 |
openstackgerrit | sean mooney proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | 19:38 |
*** ash2307 has joined #openstack-nova | 19:39 | |
*** ash2307 has left #openstack-nova | 19:39 | |
*** dpawlik has quit IRC | 19:41 | |
*** ralonsoh has quit IRC | 19:42 | |
sean-k-mooney | ok its actully running this time | 19:43 |
sean-k-mooney | http://zuul.openstack.org/stream/951e3e39a4014163aeb5c238c84a2840?logfile=console.log | 19:43 |
sean-k-mooney | ill keep an eye on it until dinner is done cooking | 19:44 |
melwitt | I'm gonna be out tomorrow and friday, fyi | 19:45 |
*** spatel has quit IRC | 20:03 | |
*** gyee has quit IRC | 20:05 | |
*** itlinux has joined #openstack-nova | 20:06 | |
*** atmark has quit IRC | 20:07 | |
*** mloza has joined #openstack-nova | 20:08 | |
*** itlinux_ has quit IRC | 20:09 | |
*** slaweq has quit IRC | 20:09 | |
*** s10 has joined #openstack-nova | 20:12 | |
*** itlinux has quit IRC | 20:18 | |
*** itlinux has joined #openstack-nova | 20:20 | |
*** tbachman has joined #openstack-nova | 20:21 | |
*** gyee has joined #openstack-nova | 20:23 | |
*** brault has joined #openstack-nova | 20:32 | |
*** itlinux has quit IRC | 20:33 | |
*** itlinux has joined #openstack-nova | 20:33 | |
*** jmlowe has quit IRC | 20:36 | |
*** brault has quit IRC | 20:37 | |
openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914 | 20:38 |
openstackgerrit | sean mooney proposed openstack/nova master: libvirt: use domain capabilities to get supported device models https://review.opendev.org/666915 | 20:38 |
openstackgerrit | sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | 20:38 |
sean-k-mooney | i have artoms series stacking. going for dinner backin 30 mins or so | 20:38 |
openstackgerrit | Merged openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590 | 20:39 |
openstackgerrit | Merged openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035 | 20:39 |
*** xek has quit IRC | 20:39 | |
sean-k-mooney | also it looks like the legacy jobs just entrily ignore the stuff in the zuul.yaml | 20:41 |
sean-k-mooney | it failed again because it used qemu | 20:41 |
*** nweinber has quit IRC | 20:43 | |
*** bbowen has joined #openstack-nova | 20:53 | |
*** eharney has joined #openstack-nova | 20:55 | |
*** markvoelker has quit IRC | 20:58 | |
*** markvoelker has joined #openstack-nova | 20:58 | |
openstackgerrit | Merged openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.opendev.org/507486 | 20:59 |
openstackgerrit | Merged openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840 | 20:59 |
*** belmoreira has joined #openstack-nova | 20:59 | |
melwitt | \o/ | 20:59 |
*** itlinux has quit IRC | 21:00 | |
mriedem | sean-k-mooney: yeah i wasn't sure if that was going to work b/c of the legacy job format, that's why i threw it into the run.yaml | 21:03 |
mriedem | sean-k-mooney: we could....push a dnm devstack patch that removes that LIBVIRT_TYPE=qemu default and add a depends-on from the nova patch | 21:03 |
mriedem | or simply changes the default in devstack to kvm and depends-on that | 21:03 |
*** itlinux has joined #openstack-nova | 21:04 | |
sean-k-mooney | or you know hard code it in nova | 21:10 |
*** markvoelker has quit IRC | 21:10 | |
*** markvoelker has joined #openstack-nova | 21:10 | |
sean-k-mooney | it finished stacking while i was having dinner so ill test it now | 21:11 |
*** slaweq has joined #openstack-nova | 21:11 | |
*** itlinux has quit IRC | 21:12 | |
*** itlinux has joined #openstack-nova | 21:12 | |
*** slaweq has quit IRC | 21:16 | |
*** belmoreira has quit IRC | 21:16 | |
*** jmlowe has joined #openstack-nova | 21:18 | |
mriedem | yeah i guess we could hardcode it in nova in the dnm patch, that's the easiest | 21:20 |
*** artom has joined #openstack-nova | 21:20 | |
*** itlinux has quit IRC | 21:22 | |
*** ircuser-1 has quit IRC | 21:22 | |
*** belmoreira has joined #openstack-nova | 21:25 | |
fungi | any nova-stable-core (besides mriedem, thanks!!!) care to have a look at https://review.opendev.org/678098 ? | 21:27 |
mriedem | melwitt: ^ | 21:27 |
fungi | i've got an advisory staged and just want to set the date on it once i know that's approved, or likely to get approved | 21:27 |
*** nicolasbock has joined #openstack-nova | 21:28 | |
fungi | i wouldn't normally bug folks, but it's been sitting there for a bit | 21:28 |
*** tbachman has quit IRC | 21:32 | |
*** dpawlik has joined #openstack-nova | 21:37 | |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | 21:37 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | 21:37 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | 21:37 |
openstackgerrit | Dustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | 21:37 |
*** markvoelker has quit IRC | 21:39 | |
*** markvoelker has joined #openstack-nova | 21:40 | |
*** dpawlik has quit IRC | 21:41 | |
*** s10 has quit IRC | 21:42 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.77: Support Specifying AZ to unshelve https://review.opendev.org/665136 | 21:43 |
*** markvoelker has quit IRC | 21:45 | |
*** eharney has quit IRC | 21:50 | |
sean-k-mooney | ok i need to do it again but i think the latest patch works. | 21:51 |
*** deepak_mourya_ has quit IRC | 21:51 | |
mriedem | takashin: alex_xu: i think the 2.77 novaclient change is ready https://review.opendev.org/665136 | 21:54 |
*** mriedem has quit IRC | 21:54 | |
*** eharney has joined #openstack-nova | 21:55 | |
*** Sundar has quit IRC | 21:56 | |
sean-k-mooney | artom: dansmith: mriedem: http://paste.openstack.org/show/766650/ that is the vm xml before and after + the pci request before and after and the migration_context object | 22:01 |
sean-k-mooney | the flavor had cpu pinning enabeld. the hosts had non overlapping vcpu_pin_sets so the pinning had to be recalulated and the vm had an sriov-macvtap port | 22:02 |
*** ivve has quit IRC | 22:03 | |
sean-k-mooney | it look like cold migration back to the first host also works | 22:04 |
*** markvoelker has joined #openstack-nova | 22:05 | |
sean-k-mooney | the pci device in teh pci_device table are also updated correctly http://paste.openstack.org/show/766651/ | 22:10 |
*** markvoelker has quit IRC | 22:11 | |
*** slaweq has joined #openstack-nova | 22:11 | |
*** belmoreira has quit IRC | 22:11 | |
*** ccamacho has quit IRC | 22:14 | |
*** ircuser-1 has joined #openstack-nova | 22:15 | |
*** gbarros has quit IRC | 22:15 | |
*** mlavalle has quit IRC | 22:16 | |
*** slaweq has quit IRC | 22:17 | |
*** N3l1x has quit IRC | 22:18 | |
melwitt | fungi: sorry about that. I see smcginnis has got it, thanks | 22:42 |
fungi | yep, thanks for following up! | 22:43 |
fungi | i'm planning to circulate the advisory tomorrow | 22:43 |
sean-k-mooney | melwitt: do we have that backported downstream yet | 22:43 |
sean-k-mooney | if not i can try and do that tomorow | 22:44 |
melwitt | sean-k-mooney: not that I'm aware of | 22:44 |
sean-k-mooney | we havent relesat with stien yet but it would be good to do before we go to rc | 22:44 |
melwitt | fungi: great, thank you for putting it together! | 22:44 |
sean-k-mooney | it doesnt actuly affect our product since we dont support linuxbridge | 22:44 |
sean-k-mooney | so its not as much of an issue downstream | 22:45 |
melwitt | sean-k-mooney: yeah. maybe could bring it up on the team call tomorrow, I'm not sure what would be the guidance about it | 22:45 |
sean-k-mooney | it was discussed downstream i just dont know if we did the backport yet | 22:46 |
melwitt | oh ok | 22:46 |
melwitt | I didn't do it so unless someone else did | 22:46 |
sean-k-mooney | it shoud be trivial enough to do. | 22:47 |
sean-k-mooney | anyway with that ill call it a night | 22:47 |
sean-k-mooney | o/ | 22:47 |
*** tkajinam has joined #openstack-nova | 22:51 | |
melwitt | o/ | 22:53 |
*** macz has quit IRC | 22:57 | |
*** slaweq has joined #openstack-nova | 23:11 | |
*** slaweq has quit IRC | 23:15 | |
*** adriant has quit IRC | 23:17 | |
artom | sean-k-mooney, so that's a woot? | 23:17 |
artom | (If you're not gone) | 23:18 |
*** adriant has joined #openstack-nova | 23:18 | |
*** adriant3 has joined #openstack-nova | 23:19 | |
*** rcernin has joined #openstack-nova | 23:21 | |
*** adriant3 has quit IRC | 23:21 | |
*** adriant4 has joined #openstack-nova | 23:22 | |
*** adriant has quit IRC | 23:23 | |
*** adriant49 has joined #openstack-nova | 23:24 | |
*** adriant49 has quit IRC | 23:24 | |
openstackgerrit | Merged openstack/nova master: [Trivial]Remove unused helper check_temp_folder https://review.opendev.org/678973 | 23:27 |
*** adriant4 has quit IRC | 23:28 | |
*** dpawlik has joined #openstack-nova | 23:38 | |
*** dpawlik has quit IRC | 23:43 | |
*** tetsuro has joined #openstack-nova | 23:44 | |
*** adriant has joined #openstack-nova | 23:48 | |
openstackgerrit | Merged openstack/os-vif stable/stein: only disable mac ageing for ovs hybrid plug https://review.opendev.org/678098 | 23:51 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!