Thursday, 2019-08-29

« Wednesday, 2019-08-28 Index Friday, 2019-08-30 »
*** eharney has quit IRC00:06
*** eharney has joined #openstack-nova00:18
*** gyee has quit IRC00:22
*** tetsuro has quit IRC00:23
*** markvoelker has joined #openstack-nova00:26
*** brinzhang has joined #openstack-nova00:28
*** markvoelker has quit IRC00:30
*** itlinux has joined #openstack-nova00:38
openstackgerritBrin Zhang proposed openstack/nova master: Follow up for specifying az to unshelve  https://review.opendev.org/67916400:41
*** itlinux has quit IRC00:44
*** itlinux has joined #openstack-nova00:48
*** yedongcan has joined #openstack-nova00:56
*** larainema has joined #openstack-nova01:01
openstackgerritArtom Lifshitz proposed openstack/nova master: Introduce live_migration_claim()  https://review.opendev.org/63566901:02
openstackgerritArtom Lifshitz proposed openstack/nova master: New objects for NUMA live migration  https://review.opendev.org/63482701:02
openstackgerritArtom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source  https://review.opendev.org/63522901:02
openstackgerritArtom Lifshitz proposed openstack/nova master: NUMA live migration support  https://review.opendev.org/63460601:02
openstackgerritArtom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration  https://review.opendev.org/64002101:02
openstackgerritArtom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration  https://review.opendev.org/67259501:02
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor  https://review.opendev.org/67888701:02
*** mtanino has joined #openstack-nova01:07
*** slaweq has joined #openstack-nova01:11
*** slaweq has quit IRC01:15
openstackgerritGuo Jingyu proposed openstack/nova master: Define and catch InstanceAgentNotRunning for set-password failure  https://review.opendev.org/66146601:20
*** markvoelker has joined #openstack-nova01:25
*** markvoelker has quit IRC01:30
*** bhagyashris has joined #openstack-nova01:31
*** dpawlik has joined #openstack-nova01:39
*** dpawlik has quit IRC01:43
*** itlinux is now known as itlinux-away01:45
*** ricolin has joined #openstack-nova01:48
*** ricolin has quit IRC02:04
*** ricolin has joined #openstack-nova02:05
*** sapd1 has joined #openstack-nova02:14
*** ricolin has quit IRC02:32
*** brault has joined #openstack-nova02:32
*** ricolin has joined #openstack-nova02:32
*** brault has quit IRC02:36
*** openstackgerrit has quit IRC02:37
*** openstackgerrit has joined #openstack-nova02:44
openstackgerritBrin Zhang proposed openstack/nova master: Follow up for specifying az to unshelve  https://review.opendev.org/67916402:44
openstackgerritMerged openstack/nova master: [Trivial]Remove unused helper get_allocated_disk_size  https://review.opendev.org/67897602:45
openstackgerritMerged openstack/nova master: Remove unused args from archive_deleted_rows calls  https://review.opendev.org/67898802:45
openstackgerritzhufl proposed openstack/nova master: [Trivial]Removed unused helper _extract_query_params  https://review.opendev.org/67917402:54
*** psachin has joined #openstack-nova03:10
*** rcernin has quit IRC03:13
openstackgerritzhufl proposed openstack/nova master: [Trivial]Remove unused helper should_switch_to_postcopy  https://review.opendev.org/67917703:17
*** ricolin has quit IRC03:21
openstackgerritLuyao Zhong proposed openstack/nova master: Claim resources in resource tracker  https://review.opendev.org/67845203:21
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces  https://review.opendev.org/67845303:21
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree  https://review.opendev.org/67845403:21
openstackgerritLuyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup  https://review.opendev.org/67845503:21
openstackgerritLuyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec  https://review.opendev.org/67845603:21
openstackgerritLuyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory  https://review.opendev.org/67847003:21
*** yaawang has quit IRC03:26
*** yaawang has joined #openstack-nova03:27
*** nicolasbock has quit IRC03:31
*** dpawlik has joined #openstack-nova03:40
*** sapd1 has quit IRC03:43
*** dpawlik has quit IRC03:44
*** cervigni has quit IRC03:52
openstackgerritmelanie witt proposed openstack/nova master: Add new policy rule for viewing host status UNKNOWN  https://review.opendev.org/67918103:57
*** udesale has joined #openstack-nova03:59
*** rcernin has joined #openstack-nova04:05
*** adriant has quit IRC04:05
*** adriant has joined #openstack-nova04:05
*** slaweq has joined #openstack-nova04:11
*** slaweq has quit IRC04:16
*** mkrai has joined #openstack-nova04:25
*** dave-mccowan has quit IRC04:41
*** Luzi has joined #openstack-nova05:05
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for validating instance and node  https://review.opendev.org/65602805:06
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for setting instance id  https://review.opendev.org/65969005:06
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for add/remove instance info from node  https://review.opendev.org/65969105:06
openstackgerritDustin Cowles proposed openstack/nova master: Use SDK for getting network metadata from node  https://review.opendev.org/67021305:06
alex_xustephenfin: sounds like you nail down the upgrade design for cpu resource tracking?05:10
*** adriant has quit IRC05:10
*** adriant has joined #openstack-nova05:11
*** markvoelker has joined #openstack-nova05:31
*** itlinux has joined #openstack-nova05:35
*** markvoelker has quit IRC05:36
*** dpawlik has joined #openstack-nova05:41
*** dpawlik has quit IRC05:45
openstackgerritMerged openstack/nova master: Change HostManager to allow scheduling to other cells  https://review.opendev.org/61403705:47
*** factor has joined #openstack-nova05:51
*** rcernin_ has joined #openstack-nova05:52
*** ratailor has joined #openstack-nova05:52
*** rcernin has quit IRC05:55
*** jaosorior has quit IRC05:56
*** dpawlik has joined #openstack-nova06:00
*** udesale has quit IRC06:04
*** udesale has joined #openstack-nova06:05
*** mtanino has quit IRC06:05
*** slaweq has joined #openstack-nova06:11
*** itlinux is now known as itlinux-away06:15
openstackgerritYongli He proposed openstack/nova master: Add server sub-resource topology API  https://review.opendev.org/62147606:15
*** slaweq has quit IRC06:16
openstackgerritBrin Zhang proposed openstack/nova master: Follow up for specifying az to unshelve  https://review.opendev.org/67916406:18
*** lpetrut has joined #openstack-nova06:20
*** sapd1 has joined #openstack-nova06:28
*** markvoelker has joined #openstack-nova06:31
*** udesale has quit IRC06:31
*** udesale has joined #openstack-nova06:32
*** udesale has quit IRC06:36
*** markvoelker has quit IRC06:36
*** udesale has joined #openstack-nova06:36
*** brault has joined #openstack-nova06:37
*** ricolin has joined #openstack-nova06:38
*** brault has quit IRC06:40
*** brault has joined #openstack-nova06:40
*** ircuser-1 has quit IRC06:44
*** ircuser-1 has joined #openstack-nova06:47
*** dougsz has joined #openstack-nova06:48
*** xek has joined #openstack-nova06:55
*** slaweq has joined #openstack-nova06:58
*** aojea has joined #openstack-nova07:00
*** stakeda has joined #openstack-nova07:05
*** mdbooth_ has joined #openstack-nova07:12
*** mdbooth has quit IRC07:15
*** ivve has joined #openstack-nova07:22
*** slaweq has quit IRC07:27
*** slaweq has joined #openstack-nova07:31
*** sapd1 has quit IRC07:39
*** dougsz has quit IRC07:40
*** rcernin_ has quit IRC07:40
*** trident has quit IRC07:40
*** jaosorior has joined #openstack-nova07:42
*** dougsz has joined #openstack-nova07:43
openstackgerritBrin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration  https://review.opendev.org/67399007:49
openstackgerritBrin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id  https://review.opendev.org/67424307:49
*** trident has joined #openstack-nova07:49
*** dougsz has quit IRC07:53
*** priteau has joined #openstack-nova07:54
*** rcernin_ has joined #openstack-nova07:57
*** sapd1 has joined #openstack-nova07:59
*** jaosorior has quit IRC08:01
*** ralonsoh has joined #openstack-nova08:04
*** lpetrut has quit IRC08:08
openstackgerritya.wang proposed openstack/nova master: vCPU model selection  https://review.opendev.org/67029808:10
openstackgerritya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags  https://review.opendev.org/67029908:10
openstackgerritya.wang proposed openstack/nova master: Support reporting multi CPU model traits  https://review.opendev.org/67030008:10
*** markvoelker has joined #openstack-nova08:10
openstackgerritSundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access  https://review.opendev.org/63124208:14
openstackgerritSundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec.  https://review.opendev.org/63124308:14
openstackgerritSundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs.  https://review.opendev.org/63124408:14
openstackgerritSundar Nadathur proposed openstack/nova master: Get resolved Cyborg ARQs and add PCI BDFs to VM's domain XML.  https://review.opendev.org/63124508:14
openstackgerritSundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted.  https://review.opendev.org/67373508:14
*** markvoelker has quit IRC08:15
*** tkajinam has quit IRC08:17
*** cdent has joined #openstack-nova08:18
kashyapaspiers: When you're about, given our discussion yesterday, the fixture here is not wrong (https://review.opendev.org/#/c/673790/6/nova/tests/unit/virt/libvirt/fakelibvirt.py)08:25
kashyap(I also need to include an extra line, on 1411, to include <value>yes</value> for "secure".)08:25
kashyapstephenfin: Hi, in your copious free time, mind lending your eyes to this: https://review.opendev.org/#/c/673790/08:32
*** brinzhang has quit IRC08:36
*** jaosorior has joined #openstack-nova08:37
*** brinzhang has joined #openstack-nova08:37
*** avolkov has joined #openstack-nova08:41
*** sapd1 has quit IRC08:43
stephenfinalex_xu: I think so, yeah08:47
stephenfintl;dr: if '[compute] cpu_dedicated_set' is missing, dual report CPUs for the ComputeNode.numa_topology object but *do not* report PCPUs yet08:47
*** jaosorior has quit IRC08:49
alex_xustephenfin: got it08:59
bauzasstephenfin: alex_xu made a good point, I'll probably need to look at the whole series for https://review.opendev.org/#/c/671793/1609:01
stephenfinbauzas: Yeah, I'd start at the bottom, for sure09:03
stephenfinLet me know if you've any questions09:03
bauzasjust doing it while I listen about some internal call ;)09:03
alex_xustephenfin: bauzas you guys aren't same team in redhat, i guess?09:05
bauzasalex_xu: oh, I'm always alone :p09:06
alex_xuhaha09:06
bauzasjust because I'm French09:06
bauzasbut no, we're in the same team ;)09:06
stephenfinlonnnnnnnerrrrrrr09:06
stephenfin;)09:06
sean-k-mooneyalex_xu: its an internal call about how to handel trael expenses. the rest of us have better things to do like anything that does not invole listening to that09:08
alex_xuah...09:09
alex_xubut always happy to know how much many I can spend :)09:10
sean-k-mooneywe are moving to concour finally. i did not know how good that tool was until i left intel and had to use something else09:10
alex_xuslow, very slow09:12
sean-k-mooneyconcour?09:12
alex_xuI hate take picture for every receipt09:12
alex_xuyes09:12
alex_xuit will be ok in office, but in home, with my vpn...sometime I can't upload the picture successful09:13
sean-k-mooneyour current system requires you to do that. and then email them because we are using an oracle syslte where the website cant attach recpis after you itemis each expense09:13
sean-k-mooneyoh and you have to currently convert all image to pdf first09:14
alex_xuconcour support jpg, so it is ok, but the iphone has another format...I need to save the picture as jpg09:15
sean-k-mooneyand  compress them to not exceed attachment size on the email.09:15
alex_xuhah09:15
sean-k-mooneyiphone uses png and raw filtes right09:16
alex_xuemm...no, I don't remember which format09:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Rename the nova-grenade-live-migration job to nova-grenade-multinode  https://review.opendev.org/67884109:16
openstackgerritBalazs Gibizer proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode  https://review.opendev.org/67921009:16
alex_xu.heic09:17
sean-k-mooneyi have never heared of that09:17
alex_xume too09:17
sean-k-mooneyoh is part of the h265/hvec standard form the MPEG body09:18
alex_xuI guess that is used to support live photo09:20
*** ccamacho has joined #openstack-nova09:21
openstackgerritFan Zhang proposed openstack/nova master: Clear RequestSpec requested_destination and ignore_hosts in confirm/revert resize.  https://review.opendev.org/67921209:28
*** bhagyashris has quit IRC09:32
*** ivve has quit IRC09:44
*** ivve has joined #openstack-nova09:45
*** shilpasd has joined #openstack-nova09:57
openstackgerritsean mooney proposed openstack/nova master: Libvirt: report storage bus traits  https://review.opendev.org/66691410:02
openstackgerritsean mooney proposed openstack/nova master: libvirt: use domain capabilities to get supported device models  https://review.opendev.org/66691510:02
openstackgerritsean mooney proposed openstack/nova master: Add transform_image_metadata request filter  https://review.opendev.org/66577510:02
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Rename 'nova.tests.unit.test_nova_manage'  https://review.opendev.org/67909510:02
openstackgerritStephen Finucane proposed openstack/nova master: Ensure online migrations have a unique name  https://review.opendev.org/67909610:02
openstackgerritStephen Finucane proposed openstack/nova master: objects: Add online migration for legacy NUMA objects  https://review.opendev.org/53741410:02
stephenfinbauzas: Fancy putting this trivial test-only patch and it's predecessor through? https://review.opendev.org/#/c/679096/10:03
*** markvoelker has joined #openstack-nova10:11
shilpasdstephenfin: hi, going through your changes regarding Flatten 'ResourceRequest.from_extra_specs', ...https://github.com/openstack/nova/commit/7abe83f6460b053985c45d5b7af2b0ed5b17b66a10:15
shilpasdstephenfin: accordingly making changes to  https://review.opendev.org/#/c/671075/10/nova/scheduler/request_filter.py@6910:16
shilpasdso help me more to understand the same10:16
stephenfinsure, shoot10:16
shilpasdutils.ResourceRequest will hold all flavor and image related info10:17
shilpasdno need to extract separately, right10:18
stephenfinyeah, the idea is to do any translation from image metadata or flavor extra specs inside that class10:18
stephenfinfor example10:18
stephenfinhttps://review.opendev.org/#/c/671801/32/nova/scheduler/utils.py@10610:19
*** dpawlik has quit IRC10:19
*** markvoelker has quit IRC10:20
stephenfinThis avoids the need to set stuff on the request_spec.flavor.extra_specs field10:20
*** derekh has joined #openstack-nova10:20
*** dtantsur|afk is now known as dtantsur10:24
stephenfinalex_xu: Can you elaborate on https://review.opendev.org/#/c/672693/13/nova/virt/libvirt/driver.py@a5938 ?10:24
shilpasdok got it, now in my changes i have to call utils.ResourceRequest(request_spec)10:25
stephenfinshilpasd: In your case, yeah, that sounds correct10:26
shilpasdstephenfin: tnx for clarification, will update and if further queries will ping you here10:27
*** dpawlik has joined #openstack-nova10:29
*** jawad_axd has joined #openstack-nova10:29
aspiersstephenfin: so that means I have to rewrite https://review.opendev.org/#/c/664420/44/nova/scheduler/request_filter.py@181 now?10:35
aspiersI'm still in the process of grokking your change10:35
stephenfinaspiers: yeah, probably, but (a) I'm happy to help out with that and (b) you're now in a runway10:36
stephenfinaspiers: tl;dr: drop that change to nova/scheduler/request_filter.py and instead add a translation function inside the ResourceRequest object10:37
stephenfinlike we're doing here https://review.opendev.org/#/c/671801/32/nova/scheduler/utils.py@10610:37
stephenfinat least, I think that's the way we're going. Run it by efried in case I'm talking out of my ass :)10:37
stephenfinI need to migrate the 'compute_status_filter' filter across to do the same thing10:38
openstackgerritMerged openstack/nova stable/stein: doc: remove confusing docs about aggregate allocation ratios  https://review.opendev.org/67825410:44
aspiersstephenfin: are you about to move SEV into the etherpad's runways section? I see you updated the history at the bottom10:47
stephenfinI am10:47
stephenfinsorry, got distracted10:47
aspierskewl10:47
aspiershaha np :)10:47
stephenfinmany plates10:47
aspiersindeed10:47
*** mkrai has quit IRC10:53
*** mkrai has joined #openstack-nova10:54
stephenfinkashyap: You asked for a review on https://review.opendev.org/#/c/673790/ but it looks like aspiers has some open comments. Are those resolved? It's not clear10:56
kashyapstephenfin: Hey, yeah.  Discussed with aspiers, too, yesterday on #virt.  Just wanted a different set of eyes, along with ours10:56
stephenfinah, gotcha10:56
stephenfinsure, I'll look after lunch10:56
kashyapSure, thx for remembering :-)10:57
*** mkrai has quit IRC10:57
*** mkrai has joined #openstack-nova10:57
aspiersstephenfin, kashyap: just added some more comments10:59
openstackgerritBrin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id  https://review.opendev.org/67424311:00
kashyapaspiers: /me looks; thank you11:00
*** jaosorior has joined #openstack-nova11:02
kashyapaspiers: Agreed in general.  But as a background, I used the "features" term, as in, they're loader's features.11:04
kashyapaspiers: But happy to of course make the change to enums.  If that's clearer11:04
*** mkrai has quit IRC11:05
* kashyap goes to fiddle11:09
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities  https://review.opendev.org/67379011:12
kashyapaspiers: --^ Better?  Two changes: (a) rename to 'enums; (b) in the tests, use variables for the assertEqual() express.11:13
*** tesseract has joined #openstack-nova11:15
*** shilpasd has quit IRC11:15
*** udesale has quit IRC11:18
*** lpetrut has joined #openstack-nova11:24
aspierskashyap: very close :)11:28
kashyapaspiers: Yeah, you're right.  The damn variable11:28
kashyapLet me remove it :-)11:28
*** lpetrut has quit IRC11:30
aspierskashyap: I understand why you used features first time around. But if I was being pedantic (and I am, because that's what I do), none of "type" / "yes" / "no" are (conceptual) features, whereas they *are* parts of enumerations of allowed components in a schema.11:30
kashyapI "hearby order" the unit tests to succeed11:30
aspiersHehe11:30
kashyap[No?  You won't budge?  Okay, I'll fix it :D]11:31
brinzhangWho can review https://review.opendev.org/#/c/665136/ Specifying AZ to unshelve the server, already +2 by Matt.11:32
kashyapaspiers: Okay, you saw why I did.  And yes, I agree with the pedantry and renaming is the Right Thing.  In future, too, don't hesitate to think out loud and persist that way.  Appreciate it11:32
brinzhangToday is the deadline in runway, thanks :P11:33
*** yedongcan has quit IRC11:35
*** brault has quit IRC11:37
sean-k-mooneyi didnt know we used runways for nova clinent review but i guess that makes sense11:43
brinzhangbeacuse of it belongs to the bp, does need to remove the part of the bp with novaclient or openstackclient patch?11:47
*** cdent has quit IRC11:47
sean-k-mooneybrinzhang: no its fine11:48
sean-k-mooneyits just most people dont get around to doing the client update when they add an new api11:49
*** nicolasbock has joined #openstack-nova11:49
brinzhangsean-k-mooney: yeah, IMO, they belong to the same part of nova and will only reset the bp state if they are all completed, so I add the novalient and OSC11:50
brinzhangsean-k-mooney: If anyone canot necessary, I can remove it from the runway, reduce the work for reviewer :P11:51
sean-k-mooneythe patch is close so i would leave it11:51
sean-k-mooneystephenfin: can are you core on nova-client11:52
sean-k-mooneyyep nova-core is in the group11:53
sean-k-mooneyhttps://review.opendev.org/#/c/665136/ is short11:53
brinzhangYeah11:53
sean-k-mooneywhen you get back form luch that is11:53
brinzhangnova-core has the +1 W permission for novaclient11:54
brinzhangsean-k-mooney: Oh, no, I will go home, maybe tomorrow can see it :)11:55
brinzhangsean-k-mooney: Thanks again.11:55
kashyapaspiers: Hey, before I hit `git review`, you cool with this additional 'diff' for tests? -- http://paste.openstack.org/show/766973/11:58
kashyap(The multiple entries are for different arches...)11:58
*** cdent has joined #openstack-nova12:00
*** brault has joined #openstack-nova12:03
*** nweinber has joined #openstack-nova12:04
sean-k-mooneykashyap: do all those arch support it12:04
sean-k-mooneythe current static data was taken form vrish12:04
sean-k-mooneyif mipsel or sparc does not support secure boot we shoudl not add it12:05
kashyapsean-k-mooney: From my look up all of them seem to do12:05
sean-k-mooneyok12:05
aspiersI had the same question as sean-k-mooney12:05
aspierskashyap: so the diff looks good to me12:06
kashyapsean-k-mooney: I lied, I'm not sure of PPC -- let me check12:06
sean-k-mooneyPPC at lest the 64bit versions definetly supports uefi secure boot12:07
aspierskashyap: you could always add a conditional in the tests to exclude 'secure' for some archs if necessary to maintain realistic fixtures12:08
kashyapAh, okay12:08
*** ratailor has quit IRC12:08
sean-k-mooneyi would prefer to keep the files correct12:08
sean-k-mooneybut yes12:08
kashyapaspiers: True.  I don't want to keep fiddling with it, though12:09
kashyapsean-k-mooney: And SPARC calls it "verified boot" (https://docs.oracle.com/cd/E37838_01/html/E61021/sysauth-vb.html)12:10
*** markvoelker has joined #openstack-nova12:10
sean-k-mooneykerified boot is normally used to refer to something very different12:10
sean-k-mooneyverifed boot is noramlly used to refer to a meserd trusted boot with an attestation server12:12
*** mdbooth has joined #openstack-nova12:12
sean-k-mooneyin this case it does look like tis there name for secure boot12:13
kashyapYeah12:13
kashyapSo, I'll keep it in.12:13
sean-k-mooneyin x86 land verifed boot and secure boot are normally considerd two different things12:13
kashyap(Or we could simply test only for x86)12:13
sean-k-mooneyi think its fine12:14
*** mdbooth_ has quit IRC12:14
kashyapsean-k-mooney: Okay, then, I'll keep them in.  Thanks for looking :-)12:15
*** markvoelker has quit IRC12:16
sean-k-mooneyis hould review that seriese again at some point but im a little busy with like 5 things in flight at the moment which is always fun12:19
openstackgerritKashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities  https://review.opendev.org/67379012:19
sean-k-mooneythat said i think you and aspiers have it well in hand12:20
kashyapsean-k-mooney: I don't have much else besides the above.  Still brewing.12:20
kashyapsean-k-mooney: So you're not missing anything.  And yeah, I know you're already neck-deep in several things12:20
alex_xustephenfin: sean-k-mooney yea, it is behavior change, but agree with that, it is bug12:20
kashyapsean-k-mooney: Might ping for some inputs / another set of eyes along the way.  :-)12:21
*** derekh has quit IRC12:23
sean-k-mooneyalex_xu: it really depends on how we got the cores before. nproc for example by defualt only reports the online core i belive12:24
sean-k-mooneyso it may not be a behavior change if the api we are calling in libvirt does the same12:25
sean-k-mooneybut i suspect it is12:25
sean-k-mooneya behavior change12:25
alex_xuah, right12:25
alex_xubut whatever, I can't think of people want to disable cpu also12:26
sean-k-mooneywell they might in the future for reasons. cough speed select cough12:26
alex_xuhah12:27
sean-k-mooneybut we would want such feature to work with nova not against it12:27
alex_xuno, it isn't disable, it is about you can see or not12:27
alex_xuright12:27
stephenfinsean-k-mooney: I thought I'd got that already. Sure, let me get it12:27
stephenfinalex_xu: If you'd like, I can split that change out into its own fix so we can maybe backport it (though it's low priority)12:28
stephenfinI think we should have a release note too, just in case12:29
alex_xustephenfin: I'm ok with it now, since agree with that it is corner case. maybe release note is enough12:29
stephenfinI'll tack both on at the end and move them in if/when I need to rebase12:29
stephenfincool, reno it is12:29
alex_xucool12:29
*** shilpasd has joined #openstack-nova12:29
alex_xuI also didn't found any problem with https://review.opendev.org/#/c/671800/22, I think what i need is test now12:30
* alex_xu can't image he can't find any misktake through this complex logic code12:30
stephenfinalex_xu: There are quite a few functional tests but they're at the end of the series https://review.opendev.org/#/c/67180112:30
alex_xucool, I need to check it out12:31
stephenfinI think sean-k-mooney is planning to test manually too. I was hoping to do the same myself but I've been prioritizing reviews12:31
stephenfinOh, and Bhagyashri Shewale (NTT) has been testing it for me. I should get them to leave comments if it works as expected12:32
*** larainema has quit IRC12:32
alex_xustephenfin: the first test I want to do is resize12:32
stephenfinOh, I bet I don't have one for that12:32
stephenfinI can put that together later this afternoon though12:32
alex_xu\o/12:32
sean-k-mooneystephenfin: test which PCPUs in placment12:34
sean-k-mooneyor something else12:34
stephenfinyarp12:34
sean-k-mooneyah yes12:34
sean-k-mooneyi plan to test that preferably with artroms and gibis stuff too12:34
sean-k-mooneyso hopfully some of this will start merging to make that simpelre to do12:34
sean-k-mooneywhen you think its a good time to test it let me know and ill test it standalone12:35
*** cdent has quit IRC12:35
stephenfinsean-k-mooney: I think it's good to go now, tbh12:36
sean-k-mooneyok are there specific things you would like me to test12:37
*** markvoelker has joined #openstack-nova12:38
stephenfinYup, if you give me five I can put together a list of test cases for things that I think should be covered12:38
sean-k-mooneycool add it to an etherpad12:38
sean-k-mooneyi can then run through it add updated it with my results12:39
alex_xuI guess resize is just won't be trigger between old and new, since there is no PCPU on old node.12:39
stephenfinYeah, a resize from a host reporting PCPU to one reporting VCPU won't be possible since it won't get past the scheduler12:39
sean-k-mooneywell that depends12:39
sean-k-mooneyif you resize form pinned to non pinned it woudl be12:40
stephenfinGood point, actually12:40
sean-k-mooneya cold migrate would not be12:40
alex_xuoh12:40
*** jaosorior has quit IRC12:41
stephenfinWe have functional coverage for cold migrate (for the NUMA-aware vSwitches feature) already but not resize. Should be easy enough add12:41
sean-k-mooneyya its the same test just with two flavors instead of 112:41
sean-k-mooneywell kind of12:42
*** markvoelker has quit IRC12:42
*** Luzi has quit IRC12:44
*** markvoelker has joined #openstack-nova12:44
*** markvoelker has quit IRC12:44
*** markvoelker has joined #openstack-nova12:45
alex_xuanyway, i want to end today early. see you guys tomorrow~12:45
*** cdent has joined #openstack-nova12:45
stephenfino/12:45
*** shilpasd has quit IRC12:49
*** lpetrut has joined #openstack-nova12:52
*** panda|rover|off is now known as panda|rover12:53
openstackgerritMerged openstack/nova stable/stein: Delete unused get_all_host_states method  https://review.opendev.org/67625512:53
stephenfinsean-k-mooney: https://etherpad.openstack.org/p/nova-cpu-resources12:53
*** derekh has joined #openstack-nova12:58
sean-k-mooneycool ill try and find time to do that proably on tuesday but ill see if i can get to it sooner.13:01
*** nweinber has quit IRC13:01
sean-k-mooneystephenfin: do you want me to test on real hardware or vms13:01
stephenfinVMs should be fine, right?13:01
stephenfinthere's nothing hardware specific about this13:01
sean-k-mooneyok if i dont need to use the hardware im using to test artoms stuff that makes it simpler to test13:02
*** udesale has joined #openstack-nova13:03
*** jaosorior has joined #openstack-nova13:04
*** mriedem has joined #openstack-nova13:07
*** dougsz has joined #openstack-nova13:07
*** zbr has quit IRC13:08
*** Roamer` has joined #openstack-nova13:15
openstackgerritMerged openstack/nova stable/stein: Convert HostMapping.cells to a dict  https://review.opendev.org/67625613:15
openstackgerritMerged openstack/nova stable/stein: Cache host to cell mapping in HostManager  https://review.opendev.org/67625713:15
openstackgerritMerged openstack/nova master: Revert "Filter UnsupportedServiceVersion warning"  https://review.opendev.org/67782513:15
*** zbr has joined #openstack-nova13:16
openstackgerritKobi Samoray proposed openstack/nova master: Avoid fetching metadata when no subnets found  https://review.opendev.org/67924713:17
efriedstephenfin: you around? I keep trying to context-switch in before asking you these questions, but it's always too late by then. So I'm going to be a bit off the cuff here...13:21
stephenfinI am13:21
stephenfingo for it13:21
openstackgerritShilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter  https://review.opendev.org/67107213:21
openstackgerritShilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata  https://review.opendev.org/67107413:21
openstackgerritShilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates  https://review.opendev.org/67107513:21
openstackgerritShilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates  https://review.opendev.org/66795213:21
efriedstephenfin: okay: Am I crazy or do I remember somewhere in the cpu-resources series where you are making a design decision based on the assumption that operators are supposed to be segregating their dedicated instances from their shared instances?13:23
stephenfinthat was there but it's gone now13:23
efriedokay, cause my next question was going to be: ...but post- the feature, you *can* put shared and dedicated instances on the same host, right?13:24
stephenfincorrect13:24
efried...just not shared & dedicated on the same *guest*.13:24
stephenfinyup13:24
efriedcool. Cause otherwise... not much point configuring both shared & dedicated set, eh?  :P13:24
efriedokay, next thing...13:25
efried(in -oslo)13:26
*** mdbooth_ has joined #openstack-nova13:27
*** kaisers has quit IRC13:29
*** tbachman has joined #openstack-nova13:30
*** jmlowe has quit IRC13:30
mriedemdansmith: i've updated this prep resize at dest cross-cell patch to remove some of the unused stuff and cleanup the commit/docstrings https://review.opendev.org/#/c/633293/46 - i'm still not really sold on munging this into the existing prep_resize and tried to explain why in the commit and docstring on the method if that helps13:30
*** mdbooth has quit IRC13:30
mriedemi of course can if it's going to be a blocker, i think it would mean changing prep_resize to consider if migration.cross_cell_move is True and if so, don't reschedule and don't cast to resize_instance on the source13:31
*** mdbooth_ has quit IRC13:32
bauzasefried: I think we stated a lot of implications between shared and pinned instances in the spec13:34
*** dklyle has quit IRC13:35
*** dklyle has joined #openstack-nova13:35
*** priteau has quit IRC13:35
efriedbauzas: Yeah, I just got a poke from elsewhere that made me remember seeing that assumption/limitation in the code somewhere and I was like "wha...?"13:35
*** tbachman has quit IRC13:36
bauzasefried: I'd recommend you to open the spec while you review the cpu-resources series13:36
*** shilpasd has joined #openstack-nova13:36
bauzasthat and take some aspirin13:36
bauzasI've started reviewing it but I'm not yet able to sharpen my pen13:36
efriedyes, I have it (the in-flight edited version) open.13:36
efriedI've been thrashing like a 386 running minecraft though, been reviewing like three patches every other day.13:37
*** gbarros has joined #openstack-nova13:38
*** rcernin_ has quit IRC13:41
openstackgerritBalazs Gibizer proposed openstack/nova master: Move live_migration test hooks under gate/  https://review.opendev.org/67925113:42
*** Sundar has joined #openstack-nova13:42
openstackgerritBalazs Gibizer proposed openstack/nova master: Rename the nova-grenade-live-migration job to nova-grenade-multinode  https://review.opendev.org/67884113:44
openstackgerritMerged openstack/nova master: Docs and functional test for max_local_block_devices  https://review.opendev.org/67826813:44
openstackgerritMerged openstack/nova master: Add a "Caveats" section to the eventlet profiling docs  https://review.opendev.org/67667213:44
openstackgerritMerged openstack/nova master: docs: pretty up return code table or heal_allocations  https://review.opendev.org/67806313:45
openstackgerritMerged openstack/nova master: doc: pretty up return code table for sync_aggregates  https://review.opendev.org/67806413:45
openstackgerritBalazs Gibizer proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode  https://review.opendev.org/67921013:46
Sundarmriedem: Re. the comment in https://etherpad.openstack.org/p/nova-runways-train that tests are failing on Cyborg patches, as of now, they are few and seem unrelated to the code. Even back then, there was really only 1 failure related to the patches. What can we do to get reviews on these patches?13:47
*** efried is now known as efried_afk13:47
*** hongbin has joined #openstack-nova13:48
*** shilpasd22 has joined #openstack-nova13:49
openstackgerritMerged openstack/nova master: rbd: use MAX_AVAIL stat for reporting bytes available  https://review.opendev.org/55669213:49
*** shilpasd has quit IRC13:50
*** jaosorior has quit IRC13:51
*** lpetrut has quit IRC13:51
*** udesale has quit IRC13:51
openstackgerritMerged openstack/nova master: Switch some GitHub URLs to point to opendev.org  https://review.opendev.org/67718513:52
openstackgerritMerged openstack/nova stable/stein: Add useful error log when _determine_version_cap raises DBNotAllowed  https://review.opendev.org/67571413:52
mriedemSundar: fair enough, i just looked through the series and the failed tests and indeed they look unrelated, just need rechecking13:53
mriedemas for review, i didn't know it was ready yet - i thought most of the work was being done on the cyborg side (i see the series there isn't merged yet either)13:53
donnydefried: so it looks like changing consecutive_build_service_disable_threshold=0 solved the issues with ghost disabling of the FN hypervisors. Now I just need to find the proper weight to associate with build_failure_weight_multiplier13:53
mriedemSundar: it might be good to post something short to the mailing list given a status update, e.g. where the nova patches are (what's ready, what's not - known limitations), and what's going on on the cyborg side - and what the status is on getting a fake cyborg driver for integration testing with tempest going so we can have more confidence in the nova patches13:54
*** dave-mccowan has joined #openstack-nova13:55
mriedemdonnyd: i don't think you do if you set consecutive_build_service_disable_threshold=013:55
mriedem0 * any weight multiplier is 013:55
*** rcernin_ has joined #openstack-nova13:55
donnydmriedem: I am going to set that back to an appropriate value, was just making sure that was the reason the hypervisors were being ghost disabled13:55
donnydI don't want actually broken hypervisors to be in system if nova will take care of that for me13:56
*** fnordahl has quit IRC13:56
*** jawad_axd has quit IRC13:56
*** bjolo has quit IRC13:57
*** nweinber has joined #openstack-nova13:57
*** mordred has quit IRC13:57
*** d34dh0r53 has quit IRC13:57
*** jawad_axd has joined #openstack-nova13:57
donnydBut i am thinking changing it back to something reasonable, and then setting a weight that doesn't take it out of system for too long would be a good resolution13:57
*** fnordahl has joined #openstack-nova13:57
*** jawad_axd has quit IRC13:57
*** dougsz has quit IRC13:57
donnydbut I also may not fully understand how build_failure_weight_multiplier works... so I am going to science the crap out of it13:57
*** jawad_axd has joined #openstack-nova13:58
mriedem♪ she blinded me with science ♪13:58
*** mordred has joined #openstack-nova13:59
*** jawad_ax_ has joined #openstack-nova14:00
*** d34dh0r53 has joined #openstack-nova14:01
*** mdbooth has joined #openstack-nova14:02
*** jawad_axd has quit IRC14:02
Sundarmriedem: Yes, but we are able to test with the Cyborg patches. We will merge them soon.14:02
artomHuh, looks like the NUMA functional tests never actually used the NUMATopologyFilter...14:03
bauzasstephenfin: I'm pretty done with the first patch but I'm confused about one last bit14:03
stephenfinhit me14:03
artomAt least, based on the debug logs I'm seeing, that filter's not in there...14:03
artomErr14:03
artomIgnore me :(14:03
bauzasstephenfin: after looking and looking the spec, can't say whether VCPU resources can potentially change or not based on the flags14:03
mriedemartom: see ♪14:04
mriedemdamn14:04
mriedemNUMAServersTestBase14:04
mriedemself.flags(enabled_filters=CONF.filter_scheduler.enabled_filters +14:04
mriedem                                   ['NUMATopologyFilter'],14:04
mriedem                   group='filter_scheduler')14:04
*** jawad_ax_ has quit IRC14:04
artommriedem, right, I know the code's there, I just thought it didn't work for some reason14:04
mriedemthrow a raise Exception('does this work?') into the filter and see14:04
stephenfinartom: They definitely use the filter. We've got checks on its side effects14:04
mriedemprofessional debugging14:04
artomSo it's just my func test then :(14:05
*** ccamacho has quit IRC14:05
bauzasstephenfin: previously, we were only reporting a total VCPUs14:05
bauzasstephenfin: now, we're about to report both VCPU and PCPU14:05
bauzasbased on the flags use14:05
*** roukoswarf has quit IRC14:05
stephenfinbauzas: So if I'm understanding you correctly...14:06
stephenfinPreviously:14:06
*** tbachman has joined #openstack-nova14:06
stephenfinno CPU-related configuration -> report all host CPUs (online and offline) as VCPU14:06
stephenfin'vcpu_pin_set' -> report all host CPUs listed in this option as VCPU14:06
bauzascorrect14:06
stephenfin(and there's a check to make sure everything listed in 'vcpu_pin_set' is online)14:07
sean-k-mooneystephenfin: vcpu_pin_set requried all cpus to be online14:07
mriedemdamn melwitt is out today and tomorrow14:07
sean-k-mooneyif it they were not you could not start the agent14:07
bauzasand dansmith too14:07
stephenfinsean-k-mooney: Ooof, beaten to the punch ;)14:07
bauzasmriedem: ^14:07
mriedemdan is out tomorrow14:07
stephenfinAfter:14:07
mriedemi thought anyway14:07
sean-k-mooneystephenfin: :)14:07
stephenfinno CPU-related configuration -> report all *online* host CPUs as VCPU14:08
bauzasgosh, those people taking perpetual PTOs...14:08
*** jmlowe has joined #openstack-nova14:08
*** spatel has joined #openstack-nova14:08
spatelsean-k-mooney: ^^14:08
spatelI need your 5 min14:08
bauzasstephenfin: so, this is a non-breaking change for no CPU-related config, I agree14:08
stephenfin(we now only report the online ones since it was a bug to report offline ones)14:09
stephenfin'vcpu_pin_set' -> report all host CPUs listed in this option as VCPU14:09
bauzasI agree14:09
bauzasstephenfin: that said, a reno file would be good14:09
*** jawad_axd has joined #openstack-nova14:09
stephenfinI thought I had one?14:09
stephenfinhttps://review.opendev.org/#/c/671793/16/releasenotes/notes/cpu-resources-d4e6a0c12681fa87.yaml ?14:09
mriedemlyarwood: while you're doing stable reviews, can you hit this rocky regression? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/rocky+topic:bug/183956014:10
bauzasstephenfin: sorry, I meant some notes saying we now only report 'active' CPUs14:10
stephenfinohh, yeah14:10
sean-k-mooneyspatel: im just getting back from lunch was about to make coffee whats the issue?14:10
bauzasanyway, back to the interesting case14:10
stephenfinbauzas: alex_xu and I discussed that earlier. I said I'd add a follow-up reno, yeah14:10
stephenfinWas considering making it a bug but we're not going to backport this so meh14:10
bauzascool then, just adding a comment while we speak on it14:10
stephenfin*filing a bug14:10
stephenfinack14:10
bauzasanyway, back to the case where people were playing with vcpu_pin_set and they were getting VCPUs14:12
bauzasnow, we're deprecating this option14:12
artommriedem, addressed your feedback in https://review.opendev.org/#/c/635669/ btw, Zuul failure doesn't look related, despite being in the live migration job14:12
bauzasstephenfin: deprecating it is good and that's what we agreed, but we should still report VCPUs, am I right?14:12
mriedemartom: have you looked into why https://review.opendev.org/#/c/678887/13 is failing?14:12
Roamer`mriedem, thanks for the +2 on the StorPool volume driver's native I/O change. Is there a chance it might get a +W too, or should I bother somebody else, or is it too late in the release cycle or something? it's a practically no-risk change (well, okay, obviously you'd have to trust us on that :))14:13
mriedemRoamer`: takes 2 +2s so you have to find someone else14:13
Roamer`mriedem, thanks14:13
spatelsean-k-mooney: I have VM-1 now i want to build VM-2 on other compute nodes and want to do IP takeover14:13
mriedemanother core please see https://review.opendev.org/#/c/676172/14:13
stephenfinbauzas: Yup, nothing changes from a placement perspective until you unset vcpu_pin_set and set cpu_dedicated_set or cpu_shared_set14:13
sean-k-mooneybauzas: this bit has chagned in the last few days. if you set it we planned to report both vCPUs and pCPUs14:13
lyarwoodmriedem: ack will take a look now14:13
artommriedem, not yet, looking now14:13
*** jawad_axd has quit IRC14:13
bauzassean-k-mooney: that would have been a bug then14:14
Roamer`so, yeah, anybody up for reviewing a trivial "add io=native to the StorPool volume driver" change? :) https://review.opendev.org/#/c/676172/14:14
sean-k-mooneybauzas: what would14:14
spatelI have tried to create fix-ip with neutron but its not letting me do that because of policy issue.14:14
bauzassean-k-mooney: given people were using vcpu_pin_set for pinning, we should stick with only VCPU in this case14:14
sean-k-mooneybauzas: no that breaks upgrades14:14
bauzasgosh14:14
sean-k-mooneyvcpu_pin_set defines the set of host cpu that can be used for pinned or floating vms14:15
mriedemstephenfin: i never saw any operator replies to "More upgrade issues with PCPUs - input wanted" - i wonder if you should re-post that but tag with [nova] ?14:15
bauzassean-k-mooney: what breaks upgrades is having less VCPU between two releases with exact same config options14:15
stephenfinsean-k-mooney: I think you're getting mixed up here14:15
mriedempeople, including myself, filter non-tagged things into a general folder and might have missed it b/c of all the noise14:15
*** dougsz has joined #openstack-nova14:15
stephenfinmriedem: Good call. I need to reply with my resolution for that anyway14:15
artommriedem, aha14:15
artom<domain type='qemu'>14:15
bauzassean-k-mooney: upgrading to Train with no config change should stick with exact same reporting14:15
artomlibvirtError: Requested operation is not valid: cpu affinity is not supported14:16
sean-k-mooneybauzas: yes14:16
artomSo looks like the virt_type=kvm config didn't take14:16
sean-k-mooneywell no14:16
stephenfinsean-k-mooney, bauzas: While 'vcpu_pin_set' is configured, we continue to *only* report VCPU14:16
sean-k-mooneyit should not14:16
sean-k-mooneyand cannot14:16
stephenfinand the exact same amount of them as before14:16
mriedemartom: virt_type=kvm on the controller node https://zuul.opendev.org/t/openstack/build/095bd2d0dff74761a946c29ac69b607a/log/logs/etc/nova/nova-cpu.conf.txt.gz14:16
bauzasbut we're deprecating it, so we're cool14:16
sean-k-mooneyyou did not need to define vcpu_pin_set to use pinning14:16
ivvehey, is there any way to change chipset for kvm/qemu instances from default PIIX3 into ICH9 ? would that be done in nova.conf?14:16
mriedemartom: it's the subnode that is misconfigured https://zuul.opendev.org/t/openstack/build/095bd2d0dff74761a946c29ac69b607a/log/logs/subnode-2/etc/nova/nova-cpu.conf.txt.gz14:16
stephenfinWe will only report PCPU if you set '[compute] cpu_dedicated_set'14:16
mriedemstill has virt_type=qemu14:16
bauzasstephenfin: excellent then14:17
bauzasstephenfin: re-reading https://review.opendev.org/#/c/671793/16/nova/virt/libvirt/driver.py14:17
sean-k-mooneystephenfin: and we will have the global config to contol the schdluer translation right14:17
stephenfinsean-k-mooney: Yup, that's here https://review.opendev.org/#/c/671801/32/nova/conf/workarounds.py14:17
artommriedem, I guess line 1 of https://review.opendev.org/#/c/678887/13/playbooks/legacy/nova-live-migration/run.yaml is at fault14:17
mriedemartom: why?14:18
sean-k-mooneythat needs to be set to true14:18
*** Sundar has quit IRC14:18
artommriedem, I'm assuming "primary" just means the controller14:18
sean-k-mooneystephenfin: we have to have the transaltion disabeld by default14:19
stephenfinsean-k-mooney: This is the important thing that has changed https://review.opendev.org/#/c/671800/22/nova/virt/libvirt/driver.py@664914:19
mriedemartom: oh that line 1 - hosts: primary yeah14:19
mriedemsec, i'm going to take the easy route14:19
artommriedem, you're handling it? OK, I'll stay off then14:19
artom(Thanks!)14:20
stephenfinsean-k-mooney: I'm not sure about that. We didn't do this for the consoleauth workaround option14:20
artommriedem, I think just adding another task with hosts: all that just sets the virt type would work?14:20
bauzasstephenfin: sean-k-mooney: the key thing for a successful upgrade is basically : don't change anything if you upgrade without changing config defaults14:20
bauzasstephenfin: sean-k-mooney: so the workaround necessarly has to be activated manually before Train to U14:21
bauzasI mean, after installing Train, and some time after it14:21
bauzasbut before upgrading to U14:21
*** davee_ has quit IRC14:22
sean-k-mooneystephenfin: on upgrade it needs to keep working as it did before with 0 config chagnes14:22
bauzas(do we have a name btw.) ?14:22
sean-k-mooneyso it has to be disable by defualt14:22
stephenfinbauzas: So you're saying we should disable translation by default too?14:22
*** dougsz has quit IRC14:22
bauzasstephenfin: the default has to14:22
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor  https://review.opendev.org/67888714:22
bauzasstephenfin: that doesn't mean operators won't get it14:22
mriedemartom: hopefully that does it14:22
bauzasstephenfin: but they'll have to opt-in14:22
sean-k-mooneyin triplo we will enable the traslation by defualt for new installs and leave it deiables for upgrades14:22
stephenfinDamn, okay, so that has to change. I was taking what '[workarounds] enable_consoleauth' did as a basis14:23
stephenfinthat was opt-in14:23
*** dpawlik has quit IRC14:23
Roamer`ivve, is hw_machine_type what you're looking for?14:23
sean-k-mooneystephenfin: well this is why i was also saying it should not be in workaround14:23
bauzasstephenfin: I was about to -1 :D14:23
* bauzas needs points :p14:23
artommriedem, while that runs I'll continue faffing about with the func test14:24
artomThanks again14:24
stephenfinbauzas: Leave comments though14:24
stephenfinI won't respin now. Better to wait til more of the series has been reviewed14:24
ivveRoamer`: yes but im kinda wondering how to set the metadata14:24
ivveor set it in nova.conf, guessing [libvirt] stanza14:25
bauzasstephenfin: just did :p14:25
bauzasstephenfin: okay, so back to the bottom patch, I'll need to check that everything keeps the same14:25
bauzasunless you play with the new option14:25
stephenfinthat doesn't kick in til near the end14:26
stephenfinit's a scheduler-only option14:26
ivvenova.conf would be my preference so i don't need image or flavor metas14:26
Roamer`ivve, according to https://docs.openstack.org/nova/stein/configuration/config.html it belongs in the libvirt section of nova.conf, yes14:27
*** mkrai has joined #openstack-nova14:27
openstackgerritEdward Hope-Morley proposed openstack/nova stable/rocky: Force refresh instance info_cache during heal  https://review.opendev.org/67927114:28
ivvehw_machine_type=x86_64=q35 seems to be it14:30
sean-k-mooneyivve: you can set the machine type in the nova.conf but it can also be set in the image14:32
sean-k-mooneyhttps://docs.openstack.org/nova/latest/configuration/config.html#libvirt.hw_machine_type14:33
openstackgerritMerged openstack/python-novaclient master: Microversion 2.77: Support Specifying AZ to unshelve  https://review.opendev.org/66513614:33
ivvethanks.. seems to be quite a few to choose from :)14:33
*** mdbooth has quit IRC14:34
openstackgerritStephen Finucane proposed openstack/nova master: Follow-up for I491eb7abe1405b27c552cdef142c688a46e914f2  https://review.opendev.org/67927314:34
sean-k-mooneyi normally use the unversioned ones14:34
sean-k-mooneyso just set it to "pc" or "q35"14:34
sean-k-mooneyyou can set it to s specific versioned machine type also but it is normally not required on x8614:35
*** dougsz has joined #openstack-nova14:35
kashyapivve: There's a good reason to set a versioned machine type:14:36
dougszHas anyone seen live-migrate fail on Rocky with an empty call to placement? ` Placement API returning an error response: JSON does not validate: {} does not have enough properties`14:36
kashyapivve: (Typically done by installer tools.)  A specific versioned machine type across Compute nodes will guarantee back-n-forth live migration.14:36
openstackgerritEdward Hope-Morley proposed openstack/nova stable/queens: Force refresh instance info_cache during heal  https://review.opendev.org/67927414:37
ivvekashyap: got it, so a least common denominator just as with cpu_models then?14:37
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor  https://review.opendev.org/67888714:38
kashyapivve: Yep14:38
ivvekashyap: im guessing using virsh capabilities to find out what hosts have available to them is the way to go?14:38
kashyapivve: To find out machine type?14:39
ivveye available types14:39
ivvei.e. highest available, lower would obviously be available i guess14:39
ivveas with cpu models / flags14:40
kashyapivve: Yeah.  (Or `qemu-system-x86_64 -machine help | head`)14:40
ivveah cool, great. thanks a bunch!14:40
kashyapstephenfin: Follow-up: I've addressed Adam's feedback, and got his ACK, FWIW.  Might want to queue this - https://review.opendev.org/#/c/673790/14:41
stephenfinkashyap: I sure can, but could you ask me in the morning? /o\ I've a lotttt of tabs open rn14:42
kashyapstephenfin: Certainly.  Ignore it for now14:42
* kashyap can keep building on top of it. But first some meetings--14:43
*** mdbooth has joined #openstack-nova14:51
*** Conqueror has quit IRC14:52
*** dpawlik has joined #openstack-nova14:52
*** dpawlik has quit IRC14:57
*** dougsz has quit IRC14:58
mriedemstephenfin: i'm assuming we can defer this to U at this point? https://blueprints.launchpad.net/nova/+spec/flavor-extra-spec-image-property-validation-extended14:59
stephenfinYup, and anything != cpu-resources assigned to me14:59
stephenfinI'll re-propose the spec after M314:59
*** mkrai has quit IRC15:00
mriedemkashyap: i'm assuming we can defer this to U https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration15:00
kashyapmriedem: Yes, definitely.  My hands are beyond full.  I just want to focus on the other spec.15:01
*** shilpasd22 has quit IRC15:02
*** mkrai has joined #openstack-nova15:02
kashyapAlthough, I won't stop anyone who is raring to pick it up :-)15:02
* kashyap --> back to meeting15:02
*** mlavalle has joined #openstack-nova15:04
mriedemstephenfin: https://blueprints.launchpad.net/nova/+spec/remove-consoleauth is essentially done yeah?15:06
stephenfinYeah. I think it's totally done, actually15:06
* stephenfin checks15:06
*** ratailor has joined #openstack-nova15:06
*** itlinux has joined #openstack-nova15:08
*** mdbooth has quit IRC15:10
*** mdbooth has joined #openstack-nova15:10
*** jawad_axd has joined #openstack-nova15:11
openstackgerritEric Fried proposed openstack/nova master: DRY get_sdk_adapter tests  https://review.opendev.org/67928815:12
efried_afkstephenfin: for you ^ :*15:13
*** efried_afk is now known as efried15:13
stephenfinefried: already done15:13
efriedstephenfin: awesome. Can we +W https://review.opendev.org/#/c/676926/ now?15:14
stephenfinOh, I meant to do that earlier15:14
efriedbe nice if johnthetubaguy were the +A on the next one https://review.opendev.org/#/c/642899/ ... else mriedem?15:14
efried(after that one I'll be able to +2 up the series)15:15
stephenfinefried: not so fast https://review.opendev.org/#/c/656028/3015:15
efriedstephenfin: oh, I of course meant "when they're ready"15:15
stephenfinoh, cool :)15:15
efriedsorry, yeat15:15
efriedyeah15:15
efrieddustinc is hopefully polishing those up later today.15:16
*** jawad_axd has quit IRC15:16
*** udesale has joined #openstack-nova15:17
*** mkrai has quit IRC15:18
*** gbarros has quit IRC15:20
*** mkrai has joined #openstack-nova15:21
mriedemefried: yeah i can get back on that one15:22
efriedthanks mriedem15:22
*** dpawlik has joined #openstack-nova15:23
*** gbarros has joined #openstack-nova15:25
*** tbachman has quit IRC15:28
*** dpawlik has quit IRC15:28
mriedemefried: i'm going to push a novaclient release request so that we can get https://review.opendev.org/#/c/665336/ in for train15:30
mriedemwe'll likely have another novaclient release at FF15:30
efriedmriedem: ack15:31
dustincefried, stephenfin: my plan is to work on the series more today, I gave it a shot late last night but it didn’t seem to work as expected and I was too tired to keep at it.15:32
efrieddustinc: I've got a -1 on the node.list one coming, in case you haven't started yet15:32
stephenfinbauzas: btw https://review.opendev.org/#/c/679273/15:33
efrieddustinc: done, lmk if that doesn't make sense.15:34
dustincThanks efried I’ll check it out in a bit. Out at an appt now.15:46
*** jmlowe has quit IRC15:46
*** mkrai has quit IRC15:50
*** mkrai has joined #openstack-nova15:50
artomstephenfin, sean-k-mooney, sanity check a thing for me. Context is fitting hugepages: https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L632-L65815:55
artomIf the host only has 1 size of pages available (ex: only 2048), that avail_pagesize[:-1] will end up with an empty list15:55
artomAnd the fail15:55
artom*And then15:55
artomIs that a realistic scenario in the real world?15:55
sean-k-mooneythat wont happen.15:56
artomI'm hitting this in func tests, wondering if I'm doing something wrong15:56
*** mkrai has quit IRC15:56
sean-k-mooneyif you have 1 item in the list [0] == [-1]15:56
artom>>> [1][:-1]15:57
artom[]15:57
sean-k-mooneyand [:-1] will b the empty list15:57
artomYeah, which makes https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L647 a problem15:57
sean-k-mooneylets talk about this later15:57
artomOK?15:57
stephenfinartom: but [1][-1:]15:58
*** hongbin has quit IRC15:58
stephenfin[1]15:58
stephenfin[1][:-1] is only used for large pages15:58
sean-k-mooneytrying to listen to matt15:58
stephenfina host won't have only large pages15:58
sean-k-mooneycorrect15:58
artomstephenfin, that'll only get hit if inst_cell.pagesize == MEMPAGES_SMALL15:58
sean-k-mooneythe kernel cannoth run with only hugepages15:58
artomstephenfin, aha, so in the real world, you can't have only 2048 size pages15:58
stephenfincorrect15:59
stephenfinthere have to be 4k pages15:59
artomstephenfin, gotcha, thanks15:59
stephenfinon x86(_64) anyway15:59
sean-k-mooneyif you did they would be the native page size on the system15:59
artomRight, in retrospect, when you put it that way, it seems kinda obvious15:59
stephenfinI don't know what pagesizes are on other platforms15:59
sean-k-mooneynot a hugepage15:59
sean-k-mooneyntataive page size can be bigger then 4k15:59
artomSo I need to setup my fake hostinfo accordingly16:00
sean-k-mooneymem_size small menas that you get teh smallest pageszie on the host16:00
*** gyee has joined #openstack-nova16:00
sean-k-mooneyso if the only one is 2048 then that what you get16:00
*** dpawlik has joined #openstack-nova16:01
*** ratailor has quit IRC16:03
bauzascalling it a day16:06
bauzasstephenfin: I'm a mean guy https://review.opendev.org/#/c/679273/116:06
*** dpawlik has quit IRC16:06
bauzasno, seriously, I'm torn but I feel from an operators perspective that 'upgrades' is better. That said, that would in theory leave us having some kind of nova-manage stuff to do16:06
bauzasnova-status, my bad16:07
stephenfinI was also on the fence16:07
stephenfinI can do upgrades16:07
openstackgerritStephen Finucane proposed openstack/nova master: Follow-up for I491eb7abe1405b27c552cdef142c688a46e914f2  https://review.opendev.org/67927316:07
stephenfinbauzas: ^16:07
openstackgerritMerged openstack/nova master: trivial: Rename 'nova.tests.unit.test_nova_manage'  https://review.opendev.org/67909516:08
bauzasstephenfin: https://docs.openstack.org/nova/latest/contributor/releasenotes.html#when-a-release-note-is-needed makes me torn16:10
bauzas(and that's actually me who wrote this)16:10
*** nweinber has quit IRC16:10
*** nweinber has joined #openstack-nova16:10
stephenfinI'm not planning to backport this fix though16:10
stephenfinso upgrade impact does make sense16:11
*** jmlowe has joined #openstack-nova16:12
*** dougsz has joined #openstack-nova16:14
*** markvoelker has quit IRC16:15
*** markvoelker has joined #openstack-nova16:15
*** dpawlik has joined #openstack-nova16:17
*** jmlowe has quit IRC16:17
*** mdbooth has quit IRC16:19
artomHrmm, is the conductor/scheduler code for live migration host selection even set up to handle the case of no host being found?16:19
mriedemyes16:20
mriedemhttps://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L43916:20
artomOK, then I'm doing something wrong16:21
*** dpawlik has quit IRC16:21
artomOh, wait, are func tests using cast as call?16:21
artomSo it gets bubbled up to the API?16:21
*** ivve has quit IRC16:24
aspiersstephenfin: can I raise exception.FlavorImageConflict from within ResourceRequest?16:25
stephenfinProbably not16:25
stephenfinYou don't _need_ it though, right?16:25
aspiersYes I do16:25
aspiersOtherwise the conflict isn't handled correctly16:26
stephenfinPer the "this happens in the API already" conversation?16:26
stephenfinor am I mixing things up?16:26
aspiersOh I see16:26
aspiersHrm I guess :-/16:26
*** markvoelker has quit IRC16:27
stephenfinIt'll be raised if the API check didn't work for some reason, right?16:27
aspiersYes16:27
stephenfinCool. I wouldn't try handling it16:27
stephenfinLet things die16:27
aspiersOK16:27
stephenfinSomething's wrong. People should know16:28
aspiersRight16:28
stephenfinSweet16:28
*** brinzhang has quit IRC16:35
*** brinzhang has joined #openstack-nova16:36
*** brinzhang has quit IRC16:36
*** markvoelker has joined #openstack-nova16:40
*** nicolasbock has quit IRC16:41
*** nicolasbock has joined #openstack-nova16:41
*** igordc has joined #openstack-nova16:44
*** tbachman has joined #openstack-nova16:45
*** tesseract has quit IRC16:50
*** dougsz has quit IRC16:56
*** derekh has quit IRC16:59
*** derekh has joined #openstack-nova16:59
*** aojea has quit IRC17:00
*** itlinux is now known as itlinux-away17:01
*** itlinux-away has quit IRC17:01
*** dtantsur is now known as dtantsur|afk17:03
*** cdent has quit IRC17:03
*** xek has quit IRC17:05
*** derekh has quit IRC17:09
*** panda|rover is now known as panda|rover|off17:18
*** jmlowe has joined #openstack-nova17:19
*** jawad_axd has joined #openstack-nova17:26
*** jawad_axd has quit IRC17:29
*** ivve has joined #openstack-nova17:31
*** udesale has quit IRC17:34
*** gbarros has quit IRC17:42
*** ralonsoh has quit IRC17:43
*** psachin has quit IRC17:44
*** ricolin has quit IRC17:55
*** spatel has quit IRC17:59
openstackgerritMerged openstack/nova stable/rocky: rt: only map compute node if we created it  https://review.opendev.org/67628018:01
openstackgerritMerged openstack/nova stable/rocky: Add functional regression recreate test for bug 1839560  https://review.opendev.org/67651318:01
openstackbug 1839560 in OpenStack Compute (nova) rocky "ironic: moving node to maintenance makes it unusable afterwards" [High,In progress] https://launchpad.net/bugs/1839560 - Assigned to Matt Riedemann (mriedem)18:01
*** N3l1x has joined #openstack-nova18:09
mriedemartom: ideally any new functional tests for your stuff won't use the CastAsCall fixture18:15
mriedemb/c it makes things unrealistic for how the user would experience the API18:15
*** dpawlik has joined #openstack-nova18:17
mriedemefried: https://review.opendev.org/#/c/679251/ is good now18:19
openstackgerritMerged openstack/nova stable/rocky: Restore soft-deleted compute node with same uuid  https://review.opendev.org/67651418:22
*** dpawlik has quit IRC18:22
sean-k-mooneyby the way i dont know if people say my commnet on patchset 20 last night18:23
sean-k-mooneyhttps://review.opendev.org/#/c/672595/2118:23
artomsean-k-mooney, the test results?18:23
sean-k-mooneyyep18:23
artomThe executive summary would be "woot", correct?18:23
sean-k-mooneyyes18:23
artomWoot!18:24
sean-k-mooneyit seamed to work as intended18:24
sean-k-mooneyi am currently redeployting ot test a different patch18:24
sean-k-mooneyshould i redeploy with v21 after or is it more or less the same18:24
mriedemhttps://review.opendev.org/#/c/678887/ failed again18:25
artommriedem, yeah, I'm done faffing with the tests (for now, I suppose), looking into why virt_type still isn't being set correctly18:25
mriedemthe subnode is still wrong18:25
mriedemhttps://zuul.opendev.org/t/openstack/build/49bea2053e864a9c818840b8c452606a/log/logs/subnode-2/etc/nova/nova-cpu.conf.txt.gz18:25
sean-k-mooneywoudl it be simpler if we jsut wrone a non legacy job to test it18:25
mriedemi'm just going to write a devstack patch to set LIBVIRT_TYPE=kvm and depend on it18:26
sean-k-mooneyhttps://review.opendev.org/#/c/652197/ more or less is that non legacy job18:26
sean-k-mooneybut its failing because of fedora18:26
sean-k-mooneynew version of qemu is breaking oslo utils18:26
sean-k-mooneybut its fedora with the nightly build of qemu so we wont see that in distors for quite some time yet18:27
sean-k-mooneymriedem: and ya that should also work18:27
*** brault has quit IRC18:27
sean-k-mooneyim going to try and get that nfv job passing again before RC118:28
sean-k-mooneybut can you wighin in on one aspect18:28
artommriedem, hah, that's one way of doing it18:28
sean-k-mooneywould you prefer a fedora based job that uses nightly qemu or a ubuntul 18.04 based job that only ran on vexhost/used neted virt18:29
openstackgerritMatt Riedemann proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor  https://review.opendev.org/67888718:29
sean-k-mooneyartom: well we already tried 4 others that didnt work18:29
sean-k-mooneyso its worth a shot18:29
artomI'm not complaining :)18:29
sean-k-mooneyany opipion on ^18:30
sean-k-mooneye.g. should i piviot https://review.opendev.org/#/c/652197/ to just use nested vert on vexhost or try to get teh fedora based job working18:30
*** gbarros has joined #openstack-nova18:30
artomI don't understand the differences between the options well enough to make a call18:30
sean-k-mooneyone ues fedroa an the virt preview repo to get a new enought qemu to support pinning and numa wiht out nested vert18:31
sean-k-mooneyso it would run on all the providers18:31
artomExcept that's now how it's done in real life, right?18:31
sean-k-mooneythe other option is to say screwit and just make it use nested vert and only run it on vexhost18:31
artomSo the second option would be better for a "permanent" CI thing18:32
artomthat's not18:32
sean-k-mooneyit depense if you are emulating other architefure like when rackspace used to run x86 on power its realisitc18:32
sean-k-mooneybut most people will use kvm or xen or hardware accleration18:33
artomSo I think yeah, go with the most realistic scenario18:35
artomAlso, keep in mind Fort Nebula was willing to provide multi-node NUMA flavors, and though infra wasn't thrilled because they want to be cloud-agnostic, they were OK with an experimental manually-triggered job to run on only that nodeset.18:36
mriedemefried: belay that18:36
sean-k-mooneyok in that case ill rebase it on top of your stuff to test that too but i might wait a bit before doing that18:37
artomdonnyd, actually, since we're on the topic, is ^^ still a thing you're planning to do, and do you need any assistance in doing it?18:37
donnydartom: I surely can18:38
sean-k-mooneyit would be nice to get a nightly job running. i can proably propose something if there is a lable wew can use18:38
donnydI wanted to make sure FN was stable and would run jobs without a bunch of FN related issues... seems to me like its going well enough18:38
donnydand I may need some assistance in getting it running18:39
sean-k-mooneyif you can create a flavor and we can add a lable to upstream node pool to provide a limited number of that flavor say 2-4 instances18:39
sean-k-mooneyi can proably do the rest.18:40
sean-k-mooneybut not for a week or two18:40
donnydI already have a custom label for FN nobody uses18:40
sean-k-mooneyyes bute we would need FN-multi_numa on that mapped to a specil flavor with hw:numa_nodes=2 set18:41
donnydoh ok18:42
donnydWell I am up for anything and I can do up to 4 numa nodes because my hypervisors have 4 procs18:42
sean-k-mooneyare they ivybridge or newer?18:43
donnydunlikley - checking18:43
artommriedem, FWIW, I've added next wednesday's stx meeting to my calendar, and installed that 'Zoom' thing they yse18:43
artom*use18:43
sean-k-mooneycause you could do 8 if they have more then 10 cores with a bios tweek but we only need 218:43
sean-k-mooneywith 2 numa nodes we can test everything18:44
sean-k-mooneystx is starlingX18:44
donnydhttps://ark.intel.com/content/www/us/en/ark/products/64607/intel-xeon-processor-e5-4620-16m-cache-2-20-ghz-7-20-gt-s-intel-qpi.html18:44
donnydsandy bridge18:44
donnydno may not be helpful18:44
openstackgerritMerged openstack/nova master: Ensure online migrations have a unique name  https://review.opendev.org/67909618:44
artomsean-k-mooney, yeah, they wanted to test NUMA LM as well18:45
openstackgerritMerged openstack/nova master: Allow strict_proxies for sdk Connection  https://review.opendev.org/67692618:45
sean-k-mooneydonnyd its the generation before intel added cluser on die18:45
artomBut... it might just be faster to get FN running in CI :)18:45
sean-k-mooneybut as i said 2 numa nodes is all that is needed18:45
sean-k-mooneyintel is also ment to be fixing the nfv ci at some point18:46
sean-k-mooneymaybe18:46
donnydso will mine work?18:46
sean-k-mooneyyep18:46
artomsean-k-mooney, let's make a bet on who gets there first, FN in CI, Intel, or stx :D18:46
openstackgerritMatt Riedemann proposed openstack/nova master: Move live_migration test hooks under gate/  https://review.opendev.org/67925118:47
openstackgerritMatt Riedemann proposed openstack/nova master: Rename the nova-grenade-live-migration job to nova-grenade-multinode  https://review.opendev.org/67884118:47
openstackgerritMatt Riedemann proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode  https://review.opendev.org/67921018:47
*** JamesBenson has joined #openstack-nova18:47
mriedemartom: you can ask them to use bluejeans during their meeting18:47
artomIt's OK, I'm not dogmatic about my video conferencing solutions :D18:48
sean-k-mooneyi think me testing stuff manully will be fater tehn all 3. i should start commint with my sean-mooney-ci gerrit account to confuse people18:48
donnydI can work on it later tonight (after my real job) or tomorrow morning (before my real job)18:49
openstackgerritArtom Lifshitz proposed openstack/nova master: Introduce live_migration_claim()  https://review.opendev.org/63566918:49
openstackgerritArtom Lifshitz proposed openstack/nova master: New objects for NUMA live migration  https://review.opendev.org/63482718:49
openstackgerritArtom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source  https://review.opendev.org/63522918:49
openstackgerritArtom Lifshitz proposed openstack/nova master: NUMA live migration support  https://review.opendev.org/63460618:49
openstackgerritArtom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration  https://review.opendev.org/64002118:49
openstackgerritArtom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration  https://review.opendev.org/67259518:49
openstackgerritArtom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor  https://review.opendev.org/67888718:49
donnydany good docs to point me to for setup?18:49
sean-k-mooneydonnyd: i can send you the command or document them in an etherpad if you like18:50
sean-k-mooneyover all there is not too much that you need too do18:50
sean-k-mooneywe jus tneed to know the name of the flavor18:50
openstackgerritMatt Riedemann proposed openstack/nova master: Rename the nova-grenade-live-migration job to nova-grenade-multinode  https://review.opendev.org/67884118:50
openstackgerritMatt Riedemann proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode  https://review.opendev.org/67921018:50
* artom goes for a haircut, gotta look nice for kid's parent teacher meeting tonight18:50
sean-k-mooneyand you need to add a few extra specs18:51
mriedemartom: ha just did ours18:51
*** gbarros has quit IRC18:51
sean-k-mooneyand then 2 patches 1 for the project-config repo to add the new lable to nodepool and 1 to nova to add the perodic job18:51
mriedemunbelievably, the teacher didn't comment on my new fresh haircut18:51
artommriedem, D:18:51
mriedem"oh maya nice to meet....WHO IS THIS HANDSOME DEVIL?!"18:51
artomThe nerve of some people.18:51
*** gbarros has joined #openstack-nova18:52
artomSeriously. The female version of https://www.youtube.com/watch?v=4pXfHLUlZf4.18:52
artom(NFSW)18:52
sean-k-mooneysee now there is plasible deniablity18:52
* artom -> off for real now18:53
donnydsure that would work great sean-k-mooney18:54
donnydI can name things however you like18:54
sean-k-mooneywe just need to know the name to put it in the project-config patch so it does not really matter18:55
*** hongbin has joined #openstack-nova18:58
donnydhave to be something like ubuntu-bionic-fn-numa19:03
donnydcentos-7-fn-numa19:03
sean-k-mooneyyep19:03
*** hongbin has quit IRC19:03
donnydsomething like that.. .whatever you come up with, I will just put it in FN19:03
sean-k-mooneyalthough the ubunutu one is proably enough19:03
donnydwhy not just use the label that is already there and i can fixup the flavor19:04
sean-k-mooneyubuntu-bionic-fn-numa is fine the the lable and then we need a flavor name that can be numa or whatever19:04
donnydubuntu-bionic-expanded19:04
donnydok19:04
*** slaweq has quit IRC19:04
donnydi don't think anyone has ever scheduled a job against it19:05
sean-k-mooneydonnyd: we could but other jobs are not expecting muliptle numa nodes19:05
sean-k-mooneywell you also have the standard lables right19:05
donnydother jobs don't run on it right now19:05
sean-k-mooneyon FN19:05
donnydi created a label that had 16G of memory19:05
donnydyes19:05
sean-k-mooneyoh ok19:05
donnydlook in nl0219:05
donnydi already have a custom label that is completely unused19:06
*** spsurya has quit IRC19:07
sean-k-mooneythese ones https://github.com/openstack/project-config/blob/master/nodepool/nl02.openstack.org.yaml#L33019:07
donnydyep19:07
sean-k-mooneyif you added hw:numa_nodes=2 to those it woudl work too19:07
sean-k-mooneythat would be very close to how the intel ci used to run19:08
donnydwhat do you mean?19:08
donnydyou mean in project-config19:08
sean-k-mooneyno in your nova19:08
donnydoh19:08
donnydok, so I just have to add that meta-data to the flavor19:08
sean-k-mooneyopenstack flavor set "hw:numa_nodes=2" "8cpu-16GBram-80GBdisk"  i think19:09
*** KeithMnemonic has quit IRC19:09
sean-k-mooneynot quite19:09
donnydmaybe --property19:09
sean-k-mooneyopenstack flavor set --property hw:numa_nodes=2 "8cpu-16GBram-80GBdisk"19:10
sean-k-mooneyyep19:10
donnydok19:11
donnyddone19:11
*** slaweq has joined #openstack-nova19:11
donnydbut don't I have to setup something on the hypervisors or OS for NUMA to work?19:11
sean-k-mooneynope19:11
donnydOk, well its there19:11
sean-k-mooneyyou have kvm enabeld correct19:11
sean-k-mooneyand netsted virt?19:12
donnydno... .def not nested19:12
sean-k-mooneykvm is all that is required on the host19:12
donnydbut i can enable nested-virt19:12
donnydnot sure how that would tinker with other jobs19:12
sean-k-mooneyok nested virt woudl be need for use to use kvm in the guest which we would need to test pinning and numa currently19:12
sean-k-mooneythe standard jobs hardcode qemu19:13
sean-k-mooneyso they wont use it19:13
sean-k-mooneyso they should be fine19:13
donnydok19:13
sean-k-mooneywhat os are you running by they way19:13
sean-k-mooneyon the host19:13
donnydIt will take a bit to drain each hypervisor so I can unload and reload kvm with nested virt19:13
donnydubuntu 18.0419:13
sean-k-mooneynested virt used to be broken on ubuntu 18.04 but i think they have fixed in in more recent kernels19:14
sean-k-mooneythere is no rush19:14
sean-k-mooneyi can start getting the job working and then when ever you get a chance to enable nested virt we can do some more testing.19:15
donnydi stand corrected - nested virt is already enabled too19:15
sean-k-mooneycool19:15
*** slaweq has quit IRC19:15
donnydkernel is 4.15.0-58-generic19:16
sean-k-mooneyin that case if i pivot https://review.opendev.org/#/c/652197/ to use nested virt i can add a muti numa version. that targets FN and reuns as a perodic19:16
sean-k-mooneydonnyd: am i need to go do a few tings before i finish up for the day19:17
donnydok19:18
sean-k-mooneybut ill touch base on monday or tueseday next week when i get a chance to look that this again19:18
donnydOk, lmk how else i can help19:19
donnydIn my BIOS i have node-interleaving turned off19:19
donnydis that required for NUMA?19:19
sean-k-mooneyno19:19
sean-k-mooneyinfact if you trun it on19:19
sean-k-mooneyit disable numa19:19
donnydare there any kernel params i can check to see if it will work19:20
sean-k-mooneyls /sys/bus/node/devices/19:20
sean-k-mooneyis ther more then one node19:21
sean-k-mooneyif so it should work. you can always try booting a vm with that flavor too19:21
sean-k-mooneyif it works then its all good19:21
sean-k-mooneyon a numa host it will look like this19:23
sean-k-mooneystack@cloud-3:~/devstack$ ls /sys/bus/node/devices/19:23
sean-k-mooneynode0  node119:23
sean-k-mooneyor in your case you should have node 0-319:23
*** tbachman has quit IRC19:26
openstackgerritMerged openstack/nova master: rt: soften warning case in _remove_deleted_instances_allocations  https://review.opendev.org/67387319:31
donnydsean-k-mooney: I will check it out and report back19:33
donnydubuntu@compute-1:~$ sudo ls /sys/bus/node/devices/19:35
donnydnode0  node1  node2  node319:35
donnydwoot woot19:37
sean-k-mooneyyep that all looks fine19:38
donnydanother plus is that flavor also already has a bit more for memory, so that may be helpful on the nested virt side19:39
sean-k-mooneyit will be helpful for hugepage testing in the vm19:39
sean-k-mooneybecause it means its less of a blancing act between the memroy needed for openstack vs the nested vms19:40
donnydi don't have hugepages enabled19:40
sean-k-mooneyyou dont need them on the host19:40
sean-k-mooneyif you look at https://review.opendev.org/#/c/652197/20/playbooks/nfv/nfv.yaml19:40
sean-k-mooneyyou see in my curent nfv job i ame allocating only a limited amount19:41
donnyddo i look for the same parameters inside the vm?19:41
sean-k-mooneyhow do you mean19:41
sean-k-mooneydo you mean the cpu flags19:41
donnydlooking for numa nodes inside the instance launched with that flavor19:41
donnydthe instance created fine19:42
donnydbut how do i tell if its right19:42
sean-k-mooneyoh ya if you run the sam command in the vm you shoudl see 219:42
prometheanfirehow's the lxml issue coming?19:42
sean-k-mooneyi need to rework it to use the helper function19:42
donnydthere is no /sys/bus/node dir19:42
sean-k-mooneybut its fixed19:42
sean-k-mooneyreally?19:43
donnydno19:43
sean-k-mooneywhat kernel/os is the vm using19:43
donnydi am going to try again with a different image and maybe not use one i am developing on19:43
sean-k-mooneyprometheanfire: https://review.opendev.org/#/c/678964/19:43
sean-k-mooneyill respin it sortly to use self.assertXmlEqual19:44
sean-k-mooneybut once thats done it should be good to go.19:44
sean-k-mooneyprometheanfire: can you unabandon your change by the ay19:44
sean-k-mooney*way19:44
sean-k-mooneyprometheanfire: https://review.opendev.org/#/c/673848/19:44
*** tbachman has joined #openstack-nova19:45
openstackgerritMatt Riedemann proposed openstack/nova master: Test heal port allocations in nova-next  https://review.opendev.org/66987919:45
prometheanfirethe lxml change?19:45
donnydyea, i tried with a different image and its good to go19:45
prometheanfiredone19:46
sean-k-mooneydonnyd: cool can you provide the output of lcpu from the guest too19:46
prometheanfireshould I update it to 4.4.1?19:46
sean-k-mooneyi just want to check the flags19:46
sean-k-mooneyprometheanfire: i used the latest version on pypi for my testing19:46
sean-k-mooneyso you can updated it to whatever that is19:46
prometheanfirewfm19:47
donnydu mean lscpu19:47
sean-k-mooneyyes19:47
donnydhttps://www.irccloud.com/pastebin/dvV8SBKk/19:47
*** brault has joined #openstack-nova19:48
sean-k-mooneyyep so that supports hugepages and vmx is there so nested virt will work in the vm19:48
sean-k-mooneyand it have avx/sse4 so dpdk would work too19:48
sean-k-mooneydonnyd: also you can see it has 2 numa nodes19:49
donnydpretty slick19:49
donnydthat was easy19:49
sean-k-mooneydonnyd: this is totally optionaly but can i ask you to tweek somthing else that annoys me19:49
donnydanything else you need to see19:49
donnydsure19:49
sean-k-mooneycan you add hw:cpu_sockets=2 hw:cpu_cores=2 hw:cpu_threads=219:50
*** eharney has quit IRC19:50
donnydsure thing19:50
sean-k-mooneythat will emulatate a 2 socekt system with 2 core cpus with hyperthreading19:50
sean-k-mooneycurrently the vm thing it has 8 sockets19:51
donnydmore sockets are more better19:52
sean-k-mooneynot when windows and vmware licening used to be per socket19:52
sean-k-mooneyalthough now its per core19:52
*** brault has quit IRC19:52
donnydsean-k-mooney: more sockets is web scale19:53
*** gbarros has quit IRC19:53
openstackgerritMatt Riedemann proposed openstack/nova master: Add FUP unit test for port heal allocations  https://review.opendev.org/67214219:53
sean-k-mooneythe e7 line goes up to 8 i belive an then you get int the craze hyper scaleble skus19:54
donnydhttps://www.irccloud.com/pastebin/QLruofuP/19:54
sean-k-mooneythanks19:55
sean-k-mooneymuch sainer19:55
donnydNP19:55
donnydat some point we probably want to update the labels to reflect what they actually do - but its fine for now19:55
sean-k-mooneyok ill try this configurtion and see if i hit any road blocks. proably next week however.19:55
donnydyea that is cool19:56
sean-k-mooneywell it still has 8 cpus and 16 GB of ram adn 80G of disk19:56
sean-k-mooneythey are now jsut arranged a little differently19:56
donnydyes19:56
donnydthat is a true story19:56
donnydhope nova can make use of it19:56
donnydlmk if there is anything else i can do in FN to make lives easier19:57
sean-k-mooneyi think you have done more then enough for now. the next step is on us/me to get an experimtal job using it19:57
*** slaweq has joined #openstack-nova19:59
donnydbtw for those who won on the bet, I am going to need a piece of that20:01
donnyd:) :) :)20:01
sean-k-mooney:)20:01
*** mdbooth has joined #openstack-nova20:02
*** slaweq has quit IRC20:04
openstackgerritMerged openstack/nova master: add InstanceList.get_all_uuids_by_hosts() method  https://review.opendev.org/62355720:06
openstackgerritMatt Riedemann proposed openstack/nova master: Add functional test for AggregateMultiTenancyIsolation + migrate  https://review.opendev.org/57126520:07
openstackgerritAdam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868020:10
*** slaweq has joined #openstack-nova20:11
openstackgerritAdam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported  https://review.opendev.org/63868020:14
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442020:14
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633420:15
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631820:15
*** slaweq has quit IRC20:16
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456520:17
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661620:17
*** eharney has joined #openstack-nova20:17
*** dpawlik has joined #openstack-nova20:18
*** dpawlik has quit IRC20:23
*** itlinux has joined #openstack-nova20:23
*** mdbooth has quit IRC20:25
*** mlavalle has quit IRC20:26
*** mlavalle has joined #openstack-nova20:26
*** mlavalle has quit IRC20:27
*** mdbooth has joined #openstack-nova20:29
*** nweinber has quit IRC20:30
*** mlavalle has joined #openstack-nova20:32
openstackgerritAdam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption  https://review.opendev.org/66442020:34
openstackgerritAdam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection  https://review.opendev.org/63633420:35
openstackgerritAdam Spiers proposed openstack/nova master: Add <launchSecurity> and <driver iommu='on' /> to config.py  https://review.opendev.org/63631820:37
openstackgerritAdam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required  https://review.opendev.org/64456520:37
openstackgerritAdam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption  https://review.opendev.org/66661620:38
*** factor has quit IRC20:42
*** factor has joined #openstack-nova20:42
*** mdbooth has quit IRC20:43
*** mdbooth has joined #openstack-nova20:43
*** lpetrut has joined #openstack-nova20:45
openstackgerritAdam Spiers proposed openstack/nova master: Indent fake libvirt host capabilities fixtures more nicely  https://review.opendev.org/67933920:45
openstackgerritAdam Spiers proposed openstack/nova master: libvirt/host.py: remove unnecessary temporary variable  https://review.opendev.org/67934020:45
openstackgerritAdam Spiers proposed openstack/nova master: Indent fake libvirt host capabilities fixtures more nicely  https://review.opendev.org/67933920:48
openstackgerritAdam Spiers proposed openstack/nova master: libvirt/host.py: remove unnecessary temporary variable  https://review.opendev.org/67934020:48
*** lpetrut has quit IRC20:51
*** icarusfactor has joined #openstack-nova20:53
*** factor has quit IRC20:54
mriedemefried: meeting today?21:00
efriedf man, can you remind me like five minutes early?21:01
mriedemyou know there are these things called calendars with reminders you can set for meetings21:02
efriedyeah, I should do that21:03
*** tbachman has quit IRC21:05
*** slaweq has joined #openstack-nova21:11
openstackgerritsean mooney proposed openstack/nova master: Revert "vif: Resolve a TODO and update another"  https://review.opendev.org/67577621:13
*** slaweq has quit IRC21:15
*** mdbooth has quit IRC21:21
*** rcernin_ has quit IRC21:25
*** markvoelker has quit IRC21:32
mriedemefried: want to create an ussuri series in launchpad so we can move things there?21:40
efriedmriedem: absolutely. In fact, I would like to delegate that task to someone with a love for launchpad.21:40
efrieds/love/lesser loathing/21:41
efriedand *believe* me, you qualify.21:41
sean-k-mooneyFYI we may have a bug with cold and live migrtion of direct-phyical sriov nics. ill test it tomotow to confim21:41
*** JamesBenson has quit IRC21:41
sean-k-mooneyi think in both cases we dont update the mac to the mac of the new pf on the destination21:42
sean-k-mooneywe got a bug report for it against queens downstream so thats a thing...21:42
*** JamesBenson has joined #openstack-nova21:43
mriedemjust going to delegate your life away huh21:43
sean-k-mooneyalso night all o/21:44
mriedembye sean21:44
mriedemsee you in 3 hours21:44
*** JamesBen_ has joined #openstack-nova21:44
*** luksky has joined #openstack-nova21:46
mriedemdone https://blueprints.launchpad.net/nova/ussuri21:47
*** JamesBenson has quit IRC21:47
*** JamesBen_ has quit IRC21:49
*** mdbooth has joined #openstack-nova22:04
*** slaweq has joined #openstack-nova22:11
*** eharney has quit IRC22:12
*** slaweq has quit IRC22:15
*** dpawlik has joined #openstack-nova22:19
openstackgerritMerged openstack/nova master: DRY get_sdk_adapter tests  https://review.opendev.org/67928822:20
*** mdbooth has quit IRC22:23
*** dpawlik has quit IRC22:24
*** mdbooth has joined #openstack-nova22:24
*** ivve has quit IRC22:25
mriedemefried: artom: i've timed out on being able to review the ironic + sdk and numa live migration claims patches today, but it's on my list for tomorrow morning22:30
mriedema literal physical list b/c i'm in high school again22:30
*** markvoelker has joined #openstack-nova22:35
*** mdbooth has quit IRC22:38
*** luksky has quit IRC22:38
*** markvoelker has quit IRC22:40
*** mdbooth has joined #openstack-nova22:41
*** rcernin has joined #openstack-nova22:43
*** mdbooth has quit IRC22:45
*** mdbooth has joined #openstack-nova22:49
*** mdbooth has quit IRC22:51
*** tkajinam has joined #openstack-nova22:56
*** markvoelker has joined #openstack-nova23:01
*** markvoelker has quit IRC23:11
*** tbachman has joined #openstack-nova23:33
*** gbarros has joined #openstack-nova23:37
*** JamesBenson has joined #openstack-nova23:39
*** itlinux is now known as itlinux-away23:40
*** JamesBenson has quit IRC23:43
*** brinzhang has joined #openstack-nova23:54
*** gyee has quit IRC23:55
*** hongbin has joined #openstack-nova23:59
« Wednesday, 2019-08-28 Index Friday, 2019-08-30 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!