| *** tbachman has joined #openstack-nova | 01:02 | |
| *** tbachman_ has joined #openstack-nova | 01:08 | |
| *** tbachman has quit IRC | 01:09 | |
| *** tbachman_ is now known as tbachman | 01:09 | |
| *** ileixe has quit IRC | 01:35 | |
| *** markvoelker has joined #openstack-nova | 01:36 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix security groups parameters https://review.opendev.org/686517 | 01:36 |
|---|---|---|
| *** markvoelker has quit IRC | 01:40 | |
| *** gbarros has quit IRC | 01:53 | |
| *** SonPham has joined #openstack-nova | 02:10 | |
| SonPham | Hi. what must i do after review my nova-spec to https://review.opendev.org/? | 02:11 |
| *** BjoernT has joined #openstack-nova | 02:20 | |
| *** SonPham has quit IRC | 02:29 | |
| *** BjoernT_ has joined #openstack-nova | 02:29 | |
| *** BjoernT has quit IRC | 02:31 | |
| *** davee__ has joined #openstack-nova | 03:03 | |
| *** davee_ has quit IRC | 03:04 | |
| *** ricolin_ has joined #openstack-nova | 03:18 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Update contributor guide for Ussuri https://review.opendev.org/685630 | 03:25 |
| *** psachin has joined #openstack-nova | 03:26 | |
| *** BjoernT_ has quit IRC | 03:26 | |
| *** BjoernT has joined #openstack-nova | 03:27 | |
| *** BjoernT has quit IRC | 03:28 | |
| *** BjoernT_ has joined #openstack-nova | 03:29 | |
| *** BjoernT_ has quit IRC | 03:34 | |
| *** BjoernT has joined #openstack-nova | 03:34 | |
| *** udesale has joined #openstack-nova | 04:08 | |
| *** BjoernT has quit IRC | 04:10 | |
| *** BjoernT has joined #openstack-nova | 04:12 | |
| *** igordc has joined #openstack-nova | 04:19 | |
| *** BjoernT has quit IRC | 04:26 | |
| *** tetsuro has quit IRC | 04:50 | |
| *** aloga has quit IRC | 05:10 | |
| *** ratailor has joined #openstack-nova | 05:17 | |
| *** igordc has quit IRC | 05:22 | |
| *** tetsuro has joined #openstack-nova | 05:24 | |
| *** HagunKim has joined #openstack-nova | 05:28 | |
| *** aloga has joined #openstack-nova | 05:31 | |
| *** markvoelker has joined #openstack-nova | 05:38 | |
| *** Luzi has joined #openstack-nova | 05:40 | |
| *** markvoelker has quit IRC | 05:42 | |
| *** igordc has joined #openstack-nova | 05:51 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** ircuser-1 has quit IRC | 06:20 | |
| *** pcaruana has joined #openstack-nova | 06:22 | |
| *** Liang__ has joined #openstack-nova | 06:29 | |
| *** Liang__ has quit IRC | 06:30 | |
| *** Liang__ has joined #openstack-nova | 06:30 | |
| *** takashin has left #openstack-nova | 06:32 | |
| *** Liang__ has quit IRC | 06:34 | |
| *** Liang__ has joined #openstack-nova | 06:35 | |
| *** Liang__ has quit IRC | 06:39 | |
| *** Liang__ has joined #openstack-nova | 06:42 | |
| *** Liang__ has quit IRC | 06:44 | |
| *** maciejjozefczyk has joined #openstack-nova | 06:53 | |
| *** ttsiouts has joined #openstack-nova | 06:56 | |
| *** jaosorior has joined #openstack-nova | 07:01 | |
| *** xek has joined #openstack-nova | 07:01 | |
| *** tssurya has joined #openstack-nova | 07:05 | |
| *** aloga has quit IRC | 07:06 | |
| *** ccamacho has joined #openstack-nova | 07:09 | |
| *** aloga has joined #openstack-nova | 07:19 | |
| bauzas | good morning Nova | 07:22 |
| *** ttsiouts has quit IRC | 07:26 | |
| *** ttsiouts has joined #openstack-nova | 07:26 | |
| *** rpittau|afk is now known as rpittau | 07:30 | |
| *** ttsiouts has quit IRC | 07:31 | |
| *** mvkr has quit IRC | 07:46 | |
| *** igordc has quit IRC | 07:50 | |
| *** mvkr has joined #openstack-nova | 08:00 | |
| *** ociuhandu has joined #openstack-nova | 08:10 | |
| *** pcaruana has quit IRC | 08:13 | |
| *** pcaruana has joined #openstack-nova | 08:18 | |
| *** tkajinam has quit IRC | 08:21 | |
| gibi | bauzas: good morning | 08:23 |
| *** ociuhandu has quit IRC | 08:28 | |
| *** ociuhandu has joined #openstack-nova | 08:28 | |
| *** ociuhandu has quit IRC | 08:33 | |
| bauzas | gibi: good morning :) | 08:34 |
| *** ociuhandu has joined #openstack-nova | 08:36 | |
| *** derekh has joined #openstack-nova | 08:40 | |
| *** ociuhandu has quit IRC | 08:41 | |
| *** ttsiouts has joined #openstack-nova | 08:46 | |
| *** awalende has joined #openstack-nova | 09:04 | |
| *** jaosorior has quit IRC | 09:15 | |
| stephenfin | gibi: Morning. Could I get you to look at https://review.opendev.org/#/c/684341/ and https://review.opendev.org/#/c/684342/ , since you've been looking at the rest | 09:27 |
| stephenfin | Please | 09:27 |
| stephenfin | :) | 09:27 |
| *** ricolin_ is now known as ricolin | 09:29 | |
| *** jangutter has joined #openstack-nova | 09:54 | |
| *** panda|off is now known as panda | 09:54 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: VMware:fix get VM root device conditional verify https://review.opendev.org/454441 | 10:20 |
| *** ttsiouts has quit IRC | 10:20 | |
| *** ttsiouts has joined #openstack-nova | 10:21 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: VMware:fix get VM root device conditional verify https://review.opendev.org/454441 | 10:21 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Check enable_new_services option in service.py https://review.opendev.org/540962 | 10:24 |
| *** derekh has quit IRC | 10:25 | |
| *** ttsiouts has quit IRC | 10:25 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: resolve confusing state when rebuilding https://review.opendev.org/535665 | 10:26 |
| gibi | stephenfin: will try to look at today | 10:30 |
| *** jawad_axd has joined #openstack-nova | 10:33 | |
| *** udesale has quit IRC | 10:36 | |
| *** udesale has joined #openstack-nova | 10:36 | |
| openstackgerrit | Rico Lin proposed openstack/nova master: [Gate fix] Avoid use cell_uuid before assignment https://review.opendev.org/686996 | 10:37 |
| *** ratailor has quit IRC | 10:39 | |
| *** tbachman has quit IRC | 10:40 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Improve error log when snapshot fails https://review.opendev.org/356020 | 10:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Handle unset 'connection_info' https://review.opendev.org/686997 | 10:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: don't call sync_guest_time if qga is not enabled https://review.opendev.org/524836 | 10:58 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Clear instance root_device_name in rebuild operation https://review.opendev.org/464991 | 10:59 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Use Placement API to check resource usage https://review.opendev.org/528953 | 11:00 |
| *** cdent has joined #openstack-nova | 11:09 | |
| *** ttsiouts has joined #openstack-nova | 11:09 | |
| *** artom has joined #openstack-nova | 11:11 | |
| *** pcaruana has quit IRC | 11:11 | |
| *** udesale has quit IRC | 11:11 | |
| *** derekh has joined #openstack-nova | 11:12 | |
| *** mdbooth has quit IRC | 11:16 | |
| *** mdbooth has joined #openstack-nova | 11:19 | |
| *** maciejjozefczyk is now known as mjozefcz|lunch | 11:27 | |
| *** markvoelker has joined #openstack-nova | 11:40 | |
| *** ttsiouts has quit IRC | 11:42 | |
| *** ttsiouts has joined #openstack-nova | 11:42 | |
| *** pcaruana has joined #openstack-nova | 11:42 | |
| *** markvoelker has quit IRC | 11:45 | |
| *** ttsiouts has quit IRC | 11:46 | |
| *** markvoelker has joined #openstack-nova | 11:54 | |
| *** HagunKim has quit IRC | 11:57 | |
| *** ttsiouts has joined #openstack-nova | 12:01 | |
| *** tbachman has joined #openstack-nova | 12:07 | |
| *** tetsuro has quit IRC | 12:07 | |
| *** mjozefcz|lunch is now known as mjozefcz | 12:10 | |
| *** tetsuro has joined #openstack-nova | 12:10 | |
| openstackgerrit | sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072 | 12:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Pass user context detaching volume on exceptions https://review.opendev.org/560115 | 12:37 |
| *** jaosorior has joined #openstack-nova | 12:40 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove RBD swap disk if resizing to a flavor without swap https://review.opendev.org/534711 | 12:48 |
| *** dklyle has quit IRC | 12:57 | |
| *** dklyle has joined #openstack-nova | 12:57 | |
| *** dave-mccowan has joined #openstack-nova | 13:04 | |
| *** nweinber has joined #openstack-nova | 13:04 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Convert floating IP tests to ddt https://review.opendev.org/471360 | 13:05 |
| *** gbarros has joined #openstack-nova | 13:12 | |
| *** tellesnobrega has joined #openstack-nova | 13:13 | |
| *** mriedem has joined #openstack-nova | 13:15 | |
| mdbooth | mriedem: If you've got a minute, I wonder if https://review.opendev.org/#/c/683922/1 is sufficiently baked yet. | 13:17 |
| *** BjoernT has joined #openstack-nova | 13:18 | |
| mriedem | we haven't even released train | 13:18 |
| mriedem | so no i don't think so | 13:18 |
| mriedem | i'm talking months | 13:18 |
| mdbooth | Ack, I'll make a note in the review. | 13:19 |
| *** xek has quit IRC | 13:19 | |
| efried | mdbooth: at a glance, it looks like you're going to need a train backport too if you intend to land it in stein and earlier. | 13:19 |
| mdbooth | efried: It's in master | 13:19 |
| efried | mdbooth: master is ussuri rn | 13:20 |
| mdbooth | Ah, yes. I think we landed it just after the branch. | 13:20 |
| mriedem | no it'll be in train | 13:21 |
| mdbooth | Ok, thanks | 13:22 |
| mdbooth | efried: Yep, double checked and it's in train | 13:23 |
| *** ratailor has joined #openstack-nova | 13:23 | |
| efried | ah, yup | 13:23 |
| efried | aspiers: ? | 13:24 |
| *** derekh has quit IRC | 13:24 | |
| *** ociuhandu has joined #openstack-nova | 13:25 | |
| *** beekneemech is now known as bnemec | 13:29 | |
| *** ociuhandu has quit IRC | 13:31 | |
| *** gbarros has quit IRC | 13:35 | |
| *** ociuhandu has joined #openstack-nova | 13:40 | |
| sean-k-mooney | efried: just to clarify when i update my spec with the core liaison section do i qualify as a liaison or should i find a core to add. | 13:40 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Support move operations with qos ports - Ussuri https://review.opendev.org/686779 | 13:42 |
| efried | sean-k-mooney: I think you qualify. That will be a thing reviewers of your spec would be able to debate. | 13:42 |
| sean-k-mooney | ok ill rebase my spec on your patch and set it to me for now | 13:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Avoid raise InstanceNotRunning exception https://review.opendev.org/541152 | 13:44 |
| stephenfin | kashyap: Think you could look into this to see if it makes sense? https://review.opendev.org/#/c/589769/ | 13:45 |
| *** factor has quit IRC | 13:48 | |
| *** jawad_axd has quit IRC | 13:50 | |
| *** jawad_axd has joined #openstack-nova | 13:51 | |
| *** jawad_axd has quit IRC | 13:51 | |
| *** jbernard has quit IRC | 13:51 | |
| *** jawad_axd has joined #openstack-nova | 13:52 | |
| *** jawad_axd has quit IRC | 13:52 | |
| *** ociuhandu has quit IRC | 13:53 | |
| *** ociuhandu has joined #openstack-nova | 13:54 | |
| *** ratailor has quit IRC | 13:54 | |
| *** jamesdenton has quit IRC | 13:56 | |
| *** jamesdenton has joined #openstack-nova | 13:57 | |
| *** ociuhandu has quit IRC | 13:57 | |
| *** ociuhandu has joined #openstack-nova | 13:57 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove workaround for bug #1709118 https://review.opendev.org/524316 | 13:59 |
| openstack | bug 1709118 in OpenStack Compute (nova) "_ContextAuthPlugin needs a refresh" [Low,Confirmed] https://launchpad.net/bugs/1709118 | 13:59 |
| openstackgerrit | Silvan Kaiser proposed openstack/nova stable/queens: Fixes multi-registry config in Quobyte driver https://review.opendev.org/687058 | 14:00 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add boot from volume functional test with a huge request https://review.opendev.org/686734 | 14:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cache image GETs for multi-create/multi-BDM requests https://review.opendev.org/686835 | 14:01 |
| mriedem | lyarwood: i think https://review.opendev.org/#/c/679449/ is probably about the only thing worth getting into the next stable/rocky release if you want to push that through and then i'll queue up the release | 14:04 |
| *** gbarros has joined #openstack-nova | 14:04 | |
| lyarwood | mriedem: ack I'll take a look now | 14:05 |
| *** awalende has quit IRC | 14:05 | |
| tellesnobrega | mriedem, hi, quick question nova reset-state command. I'm wondering if the command delete all ghost vms on the db? In case we do a backup of the DB and restore that later and the vms are gone, how can we clean up the DB | 14:09 |
| mriedem | it does not | 14:10 |
| mriedem | all reset-state does is change the vm_state on the instance and set task_state to None | 14:10 |
| mriedem | it has no interaction with the compute service | 14:11 |
| mriedem | to clean up the db you use the nova-manage db archive_deleted_rows command | 14:11 |
| tellesnobrega | mriedem, awesome | 14:11 |
| mriedem | with the --purge option if you really want to delete the data and not just move it to shadow tables | 14:11 |
| tellesnobrega | thanks, I will take a look | 14:11 |
| mriedem | info is here https://docs.openstack.org/nova/latest/cli/nova-manage.html | 14:12 |
| tellesnobrega | mriedem, thanks | 14:12 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Prevent using blank volume as boot device https://review.opendev.org/171984 | 14:14 |
| *** jrosser has quit IRC | 14:14 | |
| *** jrosser has joined #openstack-nova | 14:15 | |
| *** tellesnobrega has left #openstack-nova | 14:16 | |
| *** artom has quit IRC | 14:24 | |
| *** gshippey has joined #openstack-nova | 14:25 | |
| gibi | stephenfin: I have one question in https://review.opendev.org/#/c/686795/2/nova/tests/fixtures.py@1255 | 14:25 |
| gshippey | Instance wont migrate to a newly provisioned compute host, this is the error in the nova-compute log: During detach_volume, instance disappeared.: InstanceNotFound: Instance 2b5cdc09-e451-4e1d-9044-4d85ffd29b51 could not be found. Has anyone seen anything similar before? | 14:27 |
| stephenfin | looking | 14:28 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove fstype param from ploop init https://review.opendev.org/444970 | 14:28 |
| stephenfin | gibi: Replied | 14:29 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 14:30 |
| efried | alex_xu: ^ | 14:30 |
| efried | thanks for the review. | 14:30 |
| mriedem | stephenfin: kind of hard to care about any ploop/vz patches when their ci hasn't worked in probably over a year | 14:30 |
| stephenfin | That one was fairly trivial so it shouldn't matter, hopefully, but yeah, agreed | 14:31 |
| gibi | stephenfin: thanks | 14:31 |
| mriedem | stephenfin: so...remove your +2 until their CI passes on it? | 14:32 |
| mriedem | it's just code cleanup, not really fixing a bug | 14:32 |
| mriedem | as far as i can tell | 14:32 |
| stephenfin | kewl | 14:32 |
| stephenfin | yeah | 14:32 |
| stephenfin | it is | 14:32 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Repro bug 1845530: versioned discovery is authed https://review.opendev.org/685180 | 14:34 |
| openstack | bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Undecided,In progress] https://launchpad.net/bugs/1845530 - Assigned to Eric Fried (efried) | 14:34 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 14:34 |
| efried | resolved merge conflict ^ | 14:34 |
| *** TxGirlGeek has joined #openstack-nova | 14:36 | |
| openstackgerrit | Silvan Kaiser proposed openstack/nova master: [WIP] Move Nova Quobyte driver to LibvirtMountedFileSystemVolumeDriver https://review.opendev.org/687066 | 14:40 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Repro bug 1845530: versioned discovery is authed https://review.opendev.org/685180 | 14:47 |
| openstack | bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Undecided,In progress] https://launchpad.net/bugs/1845530 - Assigned to Eric Fried (efried) | 14:47 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Allow versioned discovery unauthenticated https://review.opendev.org/685181 | 14:47 |
| *** mlavalle has joined #openstack-nova | 14:47 | |
| efried | mriedem: clarified those comments in the test case -^ | 14:48 |
| *** jawad_axd has joined #openstack-nova | 14:48 | |
| mriedem | stephenfin: remember when you abandon a patch linked to a bug, e.g. https://review.opendev.org/#/c/585978/ - you should probably update the bug to say it's not in progress and remove the owner | 14:49 |
| *** jawad_axd has quit IRC | 14:52 | |
| mriedem | ack | 14:53 |
| mriedem | stephenfin: i know you're busy with cleaning up old patches, but now that you've got my attention on this giant docs rewrite https://review.opendev.org/#/c/667133/ it'd be nice to close that out | 14:54 |
| stephenfin | I can do both of those shortly, yup (y) | 14:55 |
| *** TxGirlGeek has quit IRC | 15:01 | |
| mriedem | thanks | 15:03 |
| *** mriedem is now known as mriedem_afk | 15:03 | |
| *** Sundar has joined #openstack-nova | 15:03 | |
| *** mkrai has joined #openstack-nova | 15:04 | |
| mriedem_afk | gibi: dansmith: how are you feeling about this now? https://review.opendev.org/#/c/633293/ | 15:04 |
| dansmith | will look in a biot | 15:04 |
| gibi | mriedem_afk: I have to get back to that tomorrow | 15:05 |
| *** macz has joined #openstack-nova | 15:08 | |
| donnyd | with the understand I know everyone is busy, is there anything I can do to move the ball forward on LXC | 15:14 |
| *** jawad_axd has joined #openstack-nova | 15:15 | |
| *** Sundar has quit IRC | 15:17 | |
| efried | sean-k-mooney: ^ ? | 15:21 |
| *** jawad_axd has quit IRC | 15:21 | |
| sean-k-mooney | donnyd: specificaly are you refering to https://review.opendev.org/#/c/667976/ or to hardeingin the lxc support in general | 15:25 |
| *** Luzi has quit IRC | 15:25 | |
| donnyd | sean-k-mooney: I am speaking more generally in terms of what can we do to | 15:25 |
| sean-k-mooney | i tested ^ locally and it does indeed work so i think we shoudl merge it | 15:25 |
| donnyd | but yes that too | 15:26 |
| *** ociuhandu has quit IRC | 15:27 | |
| sean-k-mooney | donnyd: mriedem_afk has a WIP lxc job i belive. feature wise the next thing i would like to see fixed is automaic resize of the disk to match the flavor for lxc | 15:27 |
| sean-k-mooney | or rather the filesystem. | 15:27 |
| *** ociuhandu has joined #openstack-nova | 15:27 | |
| sean-k-mooney | i think the block device is resized my nova already but i dont think you can resize the filesystme using growpart/resize2fs inside the lxc contiaer itself | 15:28 |
| sean-k-mooney | once that was working my next wishlist item would be to fix the console. | 15:28 |
| sean-k-mooney | neither of these i suspect would be terible hard to fix but we just have not spent the time to do it. | 15:29 |
| donnyd | Isn't that a cloud-init function anyways | 15:29 |
| sean-k-mooney | it is but i have tried to resize the filesystm from inside the lxc contianer manually and you cant | 15:30 |
| sean-k-mooney | clould init works in teh lxc continer at startup | 15:30 |
| sean-k-mooney | so i wont be able to do it either | 15:30 |
| donnyd | Is that because of privileges to the underlying block device? | 15:30 |
| sean-k-mooney | yep | 15:30 |
| sean-k-mooney | we dont allow you to acess the block deivec in /dev directly with the permission to adjust the filesystem | 15:31 |
| *** ociuhandu has quit IRC | 15:31 | |
| donnyd | So would it be possible to say start the container privileged, let cloud-init do its thing, and then restart unpriv | 15:31 |
| donnyd | should all happen pretty quickly | 15:32 |
| donnyd | With the understanding that right now, this is just kinda where its at | 15:32 |
| sean-k-mooney | maybe but it might be cleaner to just have nova invoke resize2fs on the blockdevice before starting the container | 15:32 |
| donnyd | sure, that would work too | 15:32 |
| sean-k-mooney | i mean nova already grows the backing image to match the flavor root_disk | 15:33 |
| donnyd | does nova blast a filesystem down onto the block device is makes now? | 15:33 |
| sean-k-mooney | it effectly just uses qemu-image to DD the glance iamge but the resizes the image to the flavor size | 15:33 |
| *** ociuhandu has joined #openstack-nova | 15:34 | |
| sean-k-mooney | how this actully works depends on your image backend in nova but the glance image basicaly has a partion table and filesystm | 15:35 |
| sean-k-mooney | and we just donwlaod it and resize it. there are optimisation of copy on write formats liek qcow or backend like ceph | 15:35 |
| *** factor has joined #openstack-nova | 15:35 | |
| donnyd | Ok, so we would have to inspect that filesystem or require meta-datas to tell nova whats in the box. Correct? | 15:36 |
| sean-k-mooney | am im not sure we would. the qemu tools or libguestfs likely can do this for us | 15:37 |
| sean-k-mooney | we would jsut need to call them. | 15:37 |
| *** ttsiouts has quit IRC | 15:38 | |
| *** ttsiouts has joined #openstack-nova | 15:38 | |
| donnyd | Is libguestfs required for all distros or just RH ones? | 15:38 |
| donnyd | Its about the slickest tool in the world for these types of things, but not sure its a req for the .debs | 15:39 |
| *** ttsiouts has quit IRC | 15:43 | |
| *** tssurya has quit IRC | 15:43 | |
| *** artom has joined #openstack-nova | 15:44 | |
| *** markvoelker has quit IRC | 15:45 | |
| *** ociuhandu has quit IRC | 15:48 | |
| *** ociuhandu has joined #openstack-nova | 15:49 | |
| *** ociuhandu has quit IRC | 15:53 | |
| efried | stephenfin: If you still have time today, wanna polish up the "SEV is busted" patch? aspiers has been MIA, so unless something drastic happens, I want to be able to merge that tomorrow so we have a bit of breathing room for the RC. | 15:57 |
| stephenfin | Can do | 15:58 |
| *** TxGirlGeek has joined #openstack-nova | 15:59 | |
| *** markvoelker has joined #openstack-nova | 16:00 | |
| *** rpittau is now known as rpittau|adk | 16:02 | |
| *** rpittau|adk is now known as rpittau|afk | 16:02 | |
| *** jbernard has joined #openstack-nova | 16:05 | |
| *** jbernard has quit IRC | 16:09 | |
| sean-k-mooney | donnyd: libguestfs is currently used for only 1 thing in nova and that thing is kind of broken | 16:10 |
| efried | thanks stephenfin | 16:10 |
| sean-k-mooney | donnyd: it is used to determin the default vaules of some option like disk_bus in th elibvirt dirver based on metadata on the image and i think it can do some interspection | 16:11 |
| sean-k-mooney | so if i could remove the depency for that i would however if we had a valid usecase of it other then that i could see keeping it as a depency | 16:11 |
| *** jbernard has joined #openstack-nova | 16:12 | |
| sean-k-mooney | donnyd: part of the reason i would like to remove libguestfs is currenlty it pulls in the kernel so it makes contianer image 10s-100s of megabytes bigger as it has a full kernel in the image | 16:13 |
| *** macz has quit IRC | 16:17 | |
| ricolin | Hi, Nova team please help to review https://review.opendev.org/#/c/686996/ that error now frequently shows on grenade-heat job | 16:18 |
| *** mkrai has quit IRC | 16:18 | |
| *** ociuhandu has joined #openstack-nova | 16:18 | |
| *** ociuhandu_ has joined #openstack-nova | 16:20 | |
| *** gyee has joined #openstack-nova | 16:22 | |
| *** gyee_ has joined #openstack-nova | 16:22 | |
| *** gyee_ has quit IRC | 16:23 | |
| *** gyee has quit IRC | 16:23 | |
| *** gyee has joined #openstack-nova | 16:23 | |
| *** ociuhandu has quit IRC | 16:23 | |
| *** ociuhandu_ has quit IRC | 16:25 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133 | 16:26 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: docs: Highlight the current broken state of SEV https://review.opendev.org/686414 | 16:32 |
| stephenfin | efried: mriedem_afk: ^ | 16:32 |
| openstackgerrit | Merged openstack/nova stable/rocky: Add useful error log when _determine_version_cap raises DBNotAllowed https://review.opendev.org/679449 | 16:33 |
| openstackgerrit | Merged openstack/nova master: nova-net: Migrate 'test_attach_interfaces' functional tests https://review.opendev.org/684341 | 16:33 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Remove workaround for bug #1709118 https://review.opendev.org/524316 | 16:33 |
| openstack | bug 1709118 in OpenStack Compute (nova) "_ContextAuthPlugin needs a refresh" [Low,Invalid] https://launchpad.net/bugs/1709118 | 16:33 |
| openstackgerrit | Merged openstack/nova master: nova-net: Migrate 'test_simple_tenant_usage' functional tests https://review.opendev.org/684342 | 16:33 |
| efried | stephenfin: fixed pep ---^ | 16:33 |
| openstackgerrit | Merged openstack/nova master: trivial: Neutron fixture cleanup https://review.opendev.org/684343 | 16:33 |
| *** trident has quit IRC | 16:33 | |
| efried | mriedem_afk: easy ksa-ish fix: Remove workaround for bug #1709118 https://review.opendev.org/524316 | 16:34 |
| *** TxGirlGeek has quit IRC | 16:35 | |
| sean-k-mooney | stephenfin: im sure ill find an example quickly but we can trivaly rename config vaules while both deprecteint the old name and still supporting it right. | 16:36 |
| *** ociuhandu has joined #openstack-nova | 16:36 | |
| sean-k-mooney | stephenfin: im pretty sure we have done that several times in the past | 16:36 |
| stephenfin | sean-k-mooney: deprecated_name='old_name' | 16:36 |
| sean-k-mooney | cool | 16:36 |
| efried | stephenfin, mriedem_afk: Can/should we touch the admin guide as well? (SEV caveat) | 16:37 |
| sean-k-mooney | im wondering if we should rename reserved_huge_pages to reserved_mem_pages give it can be used to reserve mempages of any size not just hugepages | 16:37 |
| *** trident has joined #openstack-nova | 16:37 | |
| stephenfin | fine by me | 16:37 |
| efried | stephenfin: yeah, there's already a section on "Impermanent Limitations" | 16:38 |
| efried | https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-kvm.html#impermanent-limitations | 16:38 |
| sean-k-mooney | stephenfin: efried did you see my comment on what actully would be broken in the reno patch | 16:38 |
| efried | sean-k-mooney: yeah, he fixed that part | 16:38 |
| efried | would like you to reviow | 16:39 |
| efried | review | 16:39 |
| sean-k-mooney | cool im finding it now | 16:39 |
| efried | but also want to get the admin doc updated in the same patch. | 16:39 |
| efried | sean-k-mooney: https://review.opendev.org/686414 | 16:39 |
| sean-k-mooney | thanks i just found it | 16:40 |
| eandersson | dking_desktop, I'll let you know if I find anything | 16:40 |
| sean-k-mooney | am the only comment i would make is ``hw_scsi_model=virtio-scsi`` and ``hw_disk_bus=scsi`` or | 16:41 |
| sean-k-mooney | ``hw_cdrom_bus=scsi`` | 16:41 |
| *** ociuhandu has quit IRC | 16:41 | |
| eandersson | efried, you wouldn't happen to know if there has been any recent fixes to instances getting stuck in building / scheduling? | 16:41 |
| sean-k-mooney | should be ``hw_scsi_model=virtio-scsi`` and (``hw_disk_bus=scsi`` or ``hw_cdrom_bus=scsi``) | 16:41 |
| efried | eandersson: depends what you mean by recent, but there have been, yes, stand by... | 16:41 |
| eandersson | :D | 16:41 |
| stephenfin | sean-k-mooney: how about 'and either...'? | 16:41 |
| stephenfin | X and either Y or Z | 16:41 |
| stephenfin | I want to use English :D | 16:41 |
| sean-k-mooney | sure i just want to make that clear | 16:41 |
| stephenfin | yup, agreed | 16:41 |
| eandersson | We are seeing frequent issues with instances stuck in building... with Rocky | 16:42 |
| sean-k-mooney | e.g. hw_cdrom_bugs=scsi wont break it by itself | 16:42 |
| efried | eandersson: oh, I thought it was merged: https://review.opendev.org/#/c/666857/ | 16:42 |
| efried | eandersson: does that ^ match your bug/symptom? | 16:42 |
| efried | eandersson: https://bugs.launchpad.net/nova/+bug/1833581 | 16:42 |
| openstack | Launchpad bug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | 16:42 |
| eandersson | Yea that sounds like it | 16:42 |
| eandersson | Took you 30s :D | 16:43 |
| * efried has finger on the pulse | 16:43 | |
| efried | eandersson: you could hit the "affects me" button. Not sure if that sends gibi an email or not... | 16:44 |
| efried | cdent: skimming the comments, it looks like maybe we were waiting for you to take a look at that fix --^ | 16:44 |
| openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: docs: Highlight the current broken state of SEV https://review.opendev.org/686414 | 16:45 |
| cdent | hello, what? which? | 16:45 |
| efried | cdent: https://review.opendev.org/#/c/666857/ | 16:45 |
| efried | I didn't look at why, just saw a comment from mriedem_afk to that effect | 16:46 |
| cdent | k, thanks, reading | 16:46 |
| efried | "Let's wait to get some more feedback from cdent on this for the vcenter case" | 16:46 |
| *** mriedem_afk is now known as mriedem | 16:47 | |
| efried | PS11 9/18 | 16:47 |
| *** mkrai has joined #openstack-nova | 16:48 | |
| * mriedem has dilated eyes and can't see anything less than 30 point font | 16:49 | |
| efried | 0_0 | 16:49 |
| mriedem | https://data.whicdn.com/images/98587406/superthumb.jpg?t=1390970016 | 16:50 |
| mriedem | gonna get lunch and check back in a bit | 16:51 |
| cdent | efried: left a +1 | 16:51 |
| efried | thanks cdent | 16:51 |
| *** mkrai has quit IRC | 16:54 | |
| *** ociuhandu has joined #openstack-nova | 16:54 | |
| eandersson | That bug sure looks like the issue. The only thing that concerns me is that we saw this hours after compute restarts, but might just have been delayed reports. | 16:55 |
| *** mgoddard has quit IRC | 16:57 | |
| *** cdent has quit IRC | 16:59 | |
| *** mgoddard has joined #openstack-nova | 17:02 | |
| *** jmlowe has quit IRC | 17:02 | |
| *** TxGirlGeek has joined #openstack-nova | 17:05 | |
| efried | eandersson: I was +2 at some point in the past on that fix, and mriedem was just waiting for cdent to ack (I think), so we should be able to merge it fairly soon I would think. Will have to wait until next week to start merging backports, though. | 17:06 |
| eandersson | Sounds good - we do large rolling deployments of computes | 17:07 |
| eandersson | takes forever | 17:07 |
| eandersson | So knowing that it's safe to do so helps a lot. Otherwise we need to disable the apis | 17:08 |
| *** jmlowe has joined #openstack-nova | 17:21 | |
| *** pcaruana has quit IRC | 17:21 | |
| *** psachin has quit IRC | 17:22 | |
| donnyd | sean-k-mooney: Yea that makes sense to me | 17:25 |
| *** nweinber_ has joined #openstack-nova | 17:29 | |
| *** nweinber has quit IRC | 17:32 | |
| efried | stephenfin: I really appreciate the cleanup of oldy moldy change sets, but would you mind leaving a one-line reason when you abandon please? | 17:42 |
| mriedem | efried: i'm +2 on gibi's interrupted build fix now https://review.opendev.org/#/c/666857/ | 17:47 |
| efried | mriedem: cool, thanks, I'll get back to that in the next few minutes. | 17:47 |
| *** nweinber__ has joined #openstack-nova | 17:54 | |
| *** nweinber_ has quit IRC | 17:56 | |
| efried | eandersson: How many instances are you seeing stuck, max? | 17:57 |
| efried | just curious, because it seems like it would be pretty hard to have more than a small number. | 17:58 |
| eandersson | 10+ | 17:58 |
| mriedem | ricolin: your fix looks fine but i want to check what tests could be updated to make sure that's not regressed again | 17:59 |
| eandersson | We had a RabbitMQ outage that could have caused some of them as well. | 17:59 |
| mriedem | eandersson: i know you also reported issues with rescheduling failures in conductor recently | 17:59 |
| efried | eandersson: all from the same compute host? | 18:00 |
| *** jmlowe has quit IRC | 18:00 | |
| mriedem | and we don't put the instances into ERROR state in all cases there | 18:00 |
| eandersson | different hosts | 18:00 |
| efried | okay cool. Trying to assess the probability of the "slow startup" thing noted by cdent and gibi. Seems like it would be pretty low. | 18:00 |
| *** pcaruana has joined #openstack-nova | 18:00 | |
| ricolin | mriedem, thanks | 18:00 |
| *** ociuhandu has quit IRC | 18:01 | |
| eandersson | I was trying to figure out what happened, but couldn't really find anything. | 18:01 |
| eandersson | The VM was in placement, but instance info was not yet updated. | 18:01 |
| *** ociuhandu has joined #openstack-nova | 18:02 | |
| eandersson | btw also a lot of VMs stuck in deleting | 18:02 |
| mriedem | ricolin: tbc those jobs were going to fail anyway because of http://status.openstack.org/elastic-recheck/#1844929 but definitely need to get that unboundlocalerror fixed | 18:02 |
| eandersson | but looks like a different issue | 18:02 |
| eandersson | because when VMs are stuck deleting, restarting nova-compute works everytime. | 18:02 |
| mriedem | because the restart code checks for those | 18:03 |
| eandersson | Been unable to figure out why they got stuck in the first place. | 18:04 |
| eandersson | They spiked the hours after a RabbitMQ cluster failed, but seen it before that as well. | 18:04 |
| mriedem | something blow up between the time the api marks the instance as deleting and then rpc casts to the compute? | 18:04 |
| eandersson | Not that I could find. | 18:04 |
| eandersson | I see RabbitMQ connection errors hours, days before that | 18:06 |
| *** ociuhandu has quit IRC | 18:06 | |
| eandersson | but I feel like it shouldn't be the cause, unless RabbitMQ connections just hang dead | 18:06 |
| eandersson | Maybe due to something like https://github.com/openstack/oslo.messaging/commit/26fccea84371a3690a4d7fe970f8d6c5ba9c154b | 18:06 |
| eandersson | I'll try to dig a bit deeper next time it happens. | 18:07 |
| efried | eandersson, mriedem, gibi: +A that fix, but I think we're going to miss the boat on VirtDriverNotReady more frequently than anticipated in ironic cases. | 18:09 |
| openstackgerrit | Rico Lin proposed openstack/nova master: [Gate fix] Avoid use cell_uuid before assignment https://review.opendev.org/686996 | 18:12 |
| ricolin | mriedem, just add bug link to https://review.opendev.org/#/c/686996/ . | 18:13 |
| mriedem | ricolin: yeah i'm working on fixing the test that was masking the regression though | 18:14 |
| ricolin | mriedem, feel free to update that patch to update the test/ whatever needed | 18:14 |
| mriedem | efried: just depends on order of operations - devstack ironic jobs start ironic-api after nova-compute | 18:15 |
| mriedem | b/c of the devstack plugin structure | 18:15 |
| efried | yes | 18:15 |
| ricolin | it's pretty late for me, so will check on this when I awake tomorrow | 18:15 |
| mriedem | but in a real world deployment doohicky ironic might be up before nova | 18:15 |
| mriedem | ricolin: sure np | 18:15 |
| efried | *might* be | 18:15 |
| efried | I guess we'll see. | 18:16 |
| *** ociuhandu has joined #openstack-nova | 18:16 | |
| *** gbarros has quit IRC | 18:20 | |
| *** ociuhandu has quit IRC | 18:20 | |
| *** ricolin has quit IRC | 18:21 | |
| *** ociuhandu has joined #openstack-nova | 18:21 | |
| *** ociuhandu has quit IRC | 18:23 | |
| *** ociuhandu has joined #openstack-nova | 18:24 | |
| mriedem | melwitt: dansmith: am i overcomplicating this, or should the try/except here https://github.com/openstack/nova/blob/2c6542948f1f57c1a8a8faec1ba61800eaddff2a/nova/context.py#L442 be within the while loop? | 18:27 |
| mriedem | e.g. the first result is a celltimeout but the 2nd yields results | 18:27 |
| dansmith | mriedem: it won't be in the queue until it has timed out so I don't think it matters | 18:28 |
| mriedem | ok so maybe just something i'm seeing in a unit test that is a problem | 18:29 |
| *** ociuhandu has quit IRC | 18:29 | |
| dansmith | although I'm not sure where cell_uuid is coming from in that case | 18:29 |
| mriedem | the order here https://github.com/openstack/nova/blob/1eec451b1ba254ec4c43c77f79b0d2809d6cb9a5/nova/tests/unit/test_context.py#L383 masks the regression being fixed here https://review.opendev.org/#/c/686996/ | 18:29 |
| *** ociuhandu has joined #openstack-nova | 18:29 | |
| mriedem | because we get a result from cell0 so cell_uuid is in scope | 18:30 |
| dansmith | well, that's a terrible reason of course :) | 18:30 |
| mriedem | i've reversed the order of that side_effect and now https://github.com/openstack/nova/blob/1eec451b1ba254ec4c43c77f79b0d2809d6cb9a5/nova/tests/unit/test_context.py#L390 isn't in the results because of the try/except being outside the while loop | 18:30 |
| dansmith | spawn as syncrhonous will make that very unrealistic | 18:30 |
| mriedem | right so i'm just wondering if i chalk this up to fragile unit test and not try to have coverage for the regression case | 18:31 |
| mriedem | or maybe i can just write a new test where the only thing we hit is a failure | 18:31 |
| mriedem | that's probably easier to recreate the unboundlocalerror | 18:31 |
| *** gyee has quit IRC | 18:33 | |
| *** ociuhandu has quit IRC | 18:34 | |
| *** mjozefcz has quit IRC | 18:36 | |
| *** ociuhandu has joined #openstack-nova | 18:39 | |
| *** mriedem has quit IRC | 18:40 | |
| *** mriedem has joined #openstack-nova | 18:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [Gate fix] Avoid use cell_uuid before assignment https://review.opendev.org/686996 | 18:41 |
| mriedem | ok ^ should be good | 18:42 |
| *** CeeMac has joined #openstack-nova | 18:44 | |
| dansmith | mriedem: my 202 API returns nothing, which seems to trip up novaclient | 18:46 |
| dansmith | it's trying to turn the result into an aggregate I think, but it makes no sense for me to return an aggregate | 18:47 |
| dansmith | I think I can do "give me the raw response" in novaclient, but I'm not sure that's the right thing to do | 18:47 |
| dansmith | I'm going to trawl through some other 202 APIs to see if I can find one that doesn't return anything, but figured I'd poke in case you can just tell me what to do :) | 18:48 |
| sean-k-mooney | dansmith: really i thought 202 ment accepted (generally for async calls) and it was normal for the body to be empty. | 18:49 |
| dansmith | sean-k-mooney: me too | 18:49 |
| *** ociuhandu has quit IRC | 18:49 | |
| dansmith | sean-k-mooney: although for a POST->202 I can see expecting to get back the thing you POST'd, maybe with validations, a uuid assigned, or something so I dunno | 18:50 |
| sean-k-mooney | right i dont think haveing a body is wrong | 18:51 |
| sean-k-mooney | i just would think it optional | 18:51 |
| dansmith | yeah | 18:51 |
| sean-k-mooney | i can totally see geting back a handel to the async task | 18:51 |
| dansmith | might just be opinionated novaclient code, I dunno | 18:51 |
| sean-k-mooney | assuming you dont find and relax the restiction in novaclient im sure you could just return {} | 18:53 |
| sean-k-mooney | to make it happy | 18:53 |
| dansmith | well, not if it's trying to turn the result into an aggregate, which is what I think it's doing | 18:53 |
| dansmith | it chokes on the fact that it's None, but that's what it's trying to do | 18:53 |
| mriedem | dansmith: my guess is the novaclient Aggregate class is just biased | 18:53 |
| mriedem | "might just be opinionated novaclient code" yes this | 18:54 |
| *** tbachman has quit IRC | 18:54 | |
| sean-k-mooney | ah right this is for your aggreate image endpoint | 18:54 |
| dansmith | mriedem: ack, so, is it legit to just say raw_response=True so I can get it to chillax? | 18:54 |
| efried | mriedem: unbound local, RC2 yah? | 18:54 |
| mriedem | i think so | 18:54 |
| mriedem | efried: no, it's not in train | 18:54 |
| efried | owait, we didn't put it in train. | 18:54 |
| efried | sorry | 18:54 |
| mriedem | dansmith: you'll also have to pass an object_class | 18:55 |
| mriedem | i think | 18:56 |
| mriedem | otherwise it's going to try and shove it into an Aggregate object | 18:56 |
| dansmith | not for return_raw=True, by my reading | 18:56 |
| mriedem | if obj_class is None: | 18:56 |
| mriedem | obj_class = self.resource_class | 18:56 |
| mriedem | maybe not | 18:56 |
| mriedem | but if there is no body... | 18:56 |
| dansmith | return_raw has returned by then | 18:56 |
| dansmith | ah yeah, guh | 18:56 |
| mriedem | oh right | 18:56 |
| mriedem | yeah | 18:56 |
| mriedem | er no | 18:56 |
| mriedem | :) | 18:56 |
| mriedem | i literally don't trust my eyes right now | 18:57 |
| dansmith | can I just call self.api.client.post myself? | 18:57 |
| sean-k-mooney | i think we do that in a few places | 18:58 |
| sean-k-mooney | althout i have only done that in func tests | 18:58 |
| mriedem | it looks like if you don't, _create expects a body in the response | 18:58 |
| mriedem | sean-k-mooney: you know we're talking about python-novaclient here? | 18:59 |
| mriedem | anyway i have to jump on a call | 18:59 |
| dansmith | mriedem: ack, I'll just do that and wait for reviewers to tell me no | 18:59 |
| sean-k-mooney | mriedem: right fair point i was thinking about usage in nova. | 19:00 |
| dansmith | the good news, at least, | 19:03 |
| dansmith | is that this is all just duck-alignment and that the whole thing works and pre-caches the image as expected | 19:03 |
| sean-k-mooney | :) | 19:04 |
| sean-k-mooney | have you implmented the trotteling code or just the basic poc | 19:04 |
| dansmith | I've done the parallelism=N stuff yeah | 19:05 |
| sean-k-mooney | cool | 19:06 |
| dansmith | I'm going to push up in a sec so I can review it myself and look for tests I'm missing (of which there are many) | 19:06 |
| sean-k-mooney | its funny but i often find the change in media between my ide and the gerrit review helps with things like that | 19:06 |
| dansmith | yes, exactly | 19:07 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_image() driver method and libvirt implementation https://review.opendev.org/687137 | 19:07 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_image() support to the compute rpc, api, and manager https://review.opendev.org/687138 | 19:07 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | 19:07 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add image caching API for aggregates https://review.opendev.org/687140 | 19:07 |
| dansmith | gerrit is where I'm used to looking for those things | 19:07 |
| openstackgerrit | Dan Smith proposed openstack/python-novaclient master: WIP: Add aggregate-cache-images command and client routines https://review.opendev.org/687141 | 19:08 |
| sean-k-mooney | by the way you are not storing the cached state of the image anywhere correct? that is just known on the compute nodes | 19:09 |
| dansmith | I'm really tempted to add a "check only" flag so you can single-shot the api and just say "check and see which of these aren't done to give at least the tiniest bit of reporting, but I think I need to resist the urge | 19:09 |
| dansmith | correct | 19:09 |
| dansmith | per the spec :) | 19:09 |
| *** tbachman has joined #openstack-nova | 19:09 | |
| sean-k-mooney | yep im rebasing my schduler prefilter code to master and just wanted to confirm in my head that it should not conflict | 19:10 |
| dansmith | many of the previous attempts stalled out at the persistence layer so I definitely want to punt on that | 19:10 |
| sean-k-mooney | ya the tangent my brain was one was could you use a weighr to prefer the hosts wher eit was cached by reporting the cached images in the hostSate object | 19:11 |
| sean-k-mooney | anyway not important now | 19:11 |
| dansmith | sean-k-mooney: a weigher for exactly that is one of the ill-fated "previous attempt" items at the bottom of the spec | 19:12 |
| sean-k-mooney | ah i see well there is nothing preventing it being added at a future point in your design | 19:13 |
| dansmith | a sunken treasure for you | 19:13 |
| * sean-k-mooney waits? | 19:14 | |
| dansmith | I want to roll this out and hear the requests and justifications for more complicated stuff | 19:15 |
| sean-k-mooney | ah https://blueprints.launchpad.net/nova/+spec/node-cached-image-weigher | 19:15 |
| sean-k-mooney | ya makes sense | 19:16 |
| *** spartakos has joined #openstack-nova | 19:16 | |
| *** gyee has joined #openstack-nova | 19:18 | |
| *** tbachman has quit IRC | 19:27 | |
| openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914 | 19:30 |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: use domain capabilities to get supported device models https://review.opendev.org/666915 | 19:30 |
| openstackgerrit | sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | 19:30 |
| sean-k-mooney | efried: do you mind removing your -2 from https://review.opendev.org/#/c/666914/ now that master is open for ussuri | 19:31 |
| *** pcaruana has quit IRC | 19:32 | |
| efried | sean-k-mooney: will do, but I'm going to put the bp "Direction" back to pending | 19:32 |
| efried | done | 19:32 |
| sean-k-mooney | efried: ok. | 19:32 |
| sean-k-mooney | so does that mean it can still merger or does it have to wait till m2? | 19:33 |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Add 'Feature Liaison' spec process https://review.opendev.org/685857 | 19:35 |
| efried | sean-k-mooney: You can still merge code. But if when we have this planning discussion (format/timing/etc still tbd) it is decided we're going to cut it, we'll stop merging code for it. | 19:36 |
| sean-k-mooney | ah ok | 19:36 |
| efried | basically you still have to treat it as if it could end up partially merged, just like we normally do. IOW if it's a tightly-coupled series, we'll put -2 on the bottom until it's ready so it's all or nothing; otherwise we can merge it in stages. | 19:40 |
| efried | btw, updated the core liaison (now feature liaison) patch, in case you were in mid-rebase ----^ | 19:40 |
| sean-k-mooney | efried: i upload my spec this morning ill rebase it again and update the section then im going to call it a day | 19:41 |
| sean-k-mooney | oh maybe i did not push that | 19:42 |
| sean-k-mooney | ya i still have it locally | 19:43 |
| *** spartakos has quit IRC | 19:50 | |
| sean-k-mooney | i decied to try out http://spacemacs.org/ at the weekend. i have been using it all day and so far i like it | 19:50 |
| sean-k-mooney | i disabled the vim keybindings but it works pretty well for me so far | 19:51 |
| sean-k-mooney | not sure it will replace pycharm but it might replace my use of nano | 19:51 |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for vm scoped sriov numa affinity https://review.opendev.org/683174 | 19:52 |
| sean-k-mooney | anyway o/ | 19:52 |
| *** xek has joined #openstack-nova | 19:58 | |
| *** spartakos has joined #openstack-nova | 19:59 | |
| *** spartakos has quit IRC | 20:02 | |
| *** rnoriega- has quit IRC | 20:03 | |
| *** nweinber__ has quit IRC | 20:05 | |
| *** igordc has joined #openstack-nova | 20:13 | |
| efried | mriedem: how do we deal with bugs with a proposed fix that's now abandoned? Move back to the latest unassigned state and remove the owner? | 20:17 |
| dansmith | yes | 20:19 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_image() support to the compute rpc, api, and manager https://review.opendev.org/687138 | 20:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | 20:20 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add image caching API for aggregates https://review.opendev.org/687140 | 20:20 |
| mriedem | efried: yeah, there are cases where if i'm familiar with the thing i can just close it as invalid (or fixed by something else) | 20:29 |
| mriedem | if it has to go back through triage or whatever though yeah | 20:29 |
| efried | k, thx | 20:30 |
| mriedem | dansmith: gonna throw your stuff in https://etherpad.openstack.org/p/nova-runways-ussuri ? | 20:31 |
| *** adriant has quit IRC | 20:32 | |
| *** slaweq has quit IRC | 20:33 | |
| *** jmlowe has joined #openstack-nova | 20:36 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Helper to start computes with different HostInfos https://review.opendev.org/686832 | 20:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] Functional tests for NUMA live migration https://review.opendev.org/672595 | 20:39 |
| artom | mriedem, dansmith ^^ if you get a chance to start taking a look | 20:39 |
| artom | I left the main func tests as WIP because I want to add a test for the thing that ya.wang found | 20:39 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add regression test for bug #1843639 https://review.opendev.org/682621 | 20:41 |
| openstack | bug 1843639 in OpenStack Compute (nova) "libvirt: post_live_migration failures to disconnect volumes result in the rollback of live migrations" [Medium,In progress] https://launchpad.net/bugs/1843639 - Assigned to Lee Yarwood (lyarwood) | 20:41 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/682622 | 20:41 |
| mriedem | artom: just a thought, but you don't need to load up every test ever into the same patch for the numa lm functional stuff | 20:41 |
| mriedem | like, happy path + framework stuff and then build on top in separate changes the weird edge cases and failure/rollback scenarios | 20:42 |
| mriedem | that would make it a lot easier to review as well | 20:42 |
| openstackgerrit | Merged openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | 20:42 |
| artom | mriedem, true | 20:42 |
| artom | It'd make the reviewing more breakdown-able, in any case | 20:42 |
| artom | Not sure about easier | 20:42 |
| mriedem | broken down usually means easier | 20:43 |
| mriedem | it would at least be easier for me to get the motivation to get started if it wasn't 1K in a single change... | 20:43 |
| artom | I was thinking in the sense of "reviewing one test method/class per day" can be done in either case | 20:43 |
| mriedem | a single WIP change at that | 20:43 |
| mriedem | i guess it's not 1K | 20:44 |
| artom | If you'd prefer it split into smaller chunks I can do that | 20:44 |
| artom | But you'll just get 5 200LOC patches with a test class each instead of 1 KLOC patch with 5 test classes ;) | 20:44 |
| mriedem | that's essentially what i did with the functional tests for cross-cell resize | 20:45 |
| mriedem | starting here and then going up https://review.opendev.org/#/c/636253/ | 20:45 |
| mriedem | i guess my point is seeing WIP + lots of code makes me really not want to start reviewing it :) | 20:46 |
| mriedem | i will find any reason to procrastinate with something else | 20:46 |
| artom | Fair enough - it's not like I didn't procrastinate :) | 20:46 |
| artom | But... even if I -1 random changes of your for tenuous reasons? ;) | 20:47 |
| artom | *of yours | 20:47 |
| mriedem | you mean that will make me want to review your stuff *more*? | 20:47 |
| artom | It doesn't?! | 20:47 |
| mriedem | it might add to the guilt complex | 20:48 |
| artom | I've been doing it wrong all this time! (by which I mean a week) | 20:48 |
| mriedem | efried: i added cross-cell-resize to the ussuri runways queue, are we able to queue stuff up now? | 20:48 |
| efried | mriedem: might as well. | 20:50 |
| * artom -> kids | 20:50 | |
| mriedem | efried: ok you could probably drop the -2 on https://review.opendev.org/#/c/674243/ as well | 20:50 |
| *** artom has quit IRC | 20:50 | |
| efried | done | 20:51 |
| dansmith | mriedem: how does runways work with the new process? I guess I had kinda imagined that we weren't going to do that | 20:52 |
| mriedem | goto efried | 20:52 |
| efried | (how) did it work before? | 20:52 |
| *** tonyb has joined #openstack-nova | 20:52 | |
| mriedem | i wouldn't think the new spec approval process would change anything about runways | 20:53 |
| mriedem | when feature code is ready queue it up | 20:53 |
| mriedem | i guess i haven't dug into the new definition/direction stuff yet... | 20:53 |
| mriedem | if a blueprint is approved and the code is ready for review i don't know why it wouldn't be in runways though | 20:53 |
| dansmith | yeah, tbh it's less clear to me today than it was last week when we discussed, | 20:54 |
| efried | Right, the only thing the additional "we're gonna constrain stuff" process would change is, if whenever we do the constraining activity we decide to drop something that's already got unmerged code proposed, we would -2 whatever's on bottom at that time. | 20:54 |
| *** CeeMac has quit IRC | 20:54 | |
| dansmith | plus the whole feature chaperone thing has me more confused | 20:54 |
| efried | so play fast an loose until whenever we do that. | 20:54 |
| efried | dansmith: did you read the faq? I updated it a couple hours ago. | 20:54 |
| dansmith | no, but I read the comments that led to the change | 20:54 |
| mriedem | official hand holder is just to help someone navigate the review process as far as i know | 20:55 |
| efried | dev & review. Yes. | 20:55 |
| dansmith | yeah, I get that | 20:55 |
| dansmith | anyway, don't want to get back into it right now | 20:55 |
| *** adriant has joined #openstack-nova | 20:57 | |
| dansmith | mriedem: there's a lot more boilerplate required in API patches since the last time I wrote one.. any chance we have a checklist or something I can follow? | 21:06 |
| dansmith | api samples, api refs, schema crap, etc, etc | 21:06 |
| mriedem | yeah sec | 21:07 |
| mriedem | https://docs.openstack.org/nova/latest/contributor/#the-nova-api | 21:07 |
| dansmith | thanks | 21:10 |
| *** xek has quit IRC | 21:18 | |
| *** markvoelker has quit IRC | 21:29 | |
| *** TxGirlGeek has quit IRC | 21:30 | |
| mriedem | efried: is this what you were asking for and expecting in PS9? https://review.opendev.org/#/c/667133/10/doc/source/user/index.rst@75 | 21:32 |
| mriedem | if what i'm saying is something you agree with, i can approve and fup | 21:32 |
| efried | looking. | 21:33 |
| efried | mriedem: I agree, though this makes it *slightly* easier to find, since the first link in the admin doc is to the user side. | 21:34 |
| efried | I didn't want the existing link removed fwiw, I just wanted a new one added. | 21:34 |
| efried | but also | 21:35 |
| efried | when it comes to docs, as long as we're not injecting anything wrong/regressive, I like the idea of merging quickly even if imperfect just to move things forward. | 21:35 |
| *** BjoernT has quit IRC | 21:35 | |
| efried | anyway, if you want to respin quick and self+2 I'll +A. | 21:35 |
| efried | or fup, either way. | 21:35 |
| mriedem | yeah i'll post a follow up | 21:38 |
| *** tbachman has joined #openstack-nova | 21:41 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: link to user/availability-zones from user home page https://review.opendev.org/687165 | 21:45 |
| *** tbachman has quit IRC | 21:48 | |
| *** tbachman has joined #openstack-nova | 21:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: docs: Highlight the current broken state of SEV https://review.opendev.org/686414 | 21:54 |
| mriedem | efried: what are your thoughts on cutting rc2? it's due thursday, so i guess eod tomorrow if we don't hear from aspiers? | 21:54 |
| efried | mriedem: yes | 21:56 |
| efried | mriedem: as in, merge the 'SEV busted' patch tomorrow and cut the RC as soon as it's in. | 21:56 |
| mriedem | ok | 21:57 |
| openstackgerrit | Merged openstack/nova master: fixtures: Beef up NeutronFixture https://review.opendev.org/686795 | 21:57 |
| mriedem | i'll +2 the docs patch tomorrow | 21:57 |
| dansmith | how invasive is it to just revert large chunks of it? | 21:57 |
| mriedem | likely too risky to rush the other fix at this point anyway | 21:57 |
| efried | mriedem: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-10-04.log.html#t2019-10-04T14:50:21 | 21:57 |
| mriedem | dansmith: i'm assuming there would be a lot of pus and blood | 21:57 |
| efried | mriedem: note that the doc patch is in stable so I can't help you. | 21:57 |
| mriedem | sure, but dan can | 21:58 |
| dansmith | yep | 21:58 |
| efried | dansmith: riskier than not doing that. | 21:58 |
| efried | and it works for common configs | 21:58 |
| dansmith | well, I mean like reverting the piece that even lets you turn it on kinda thing | 21:58 |
| dansmith | sounds like abandonware before delivery event | 21:59 |
| mriedem | you'd just change the libvirt driver _sev_enabled method to return False | 22:01 |
| dansmith | yeah, that doesn't sound so bad | 22:01 |
| dansmith | so imagine it being two months from now and we still have radio silence on a fix and maintenance | 22:01 |
| dansmith | if we reverted the renos and disabled it, we could remove it without much fanfare | 22:01 |
| dansmith | I know that's fairly nuclear, but just worth considering I think | 22:02 |
| mriedem | it would elicit a response at least :) | 22:02 |
| dansmith | also that | 22:02 |
| *** trident has quit IRC | 22:03 | |
| *** trident has joined #openstack-nova | 22:04 | |
| *** slaweq has joined #openstack-nova | 22:11 | |
| *** markvoelker has joined #openstack-nova | 22:11 | |
| *** slaweq has quit IRC | 22:16 | |
| *** mlavalle has quit IRC | 22:18 | |
| *** markvoelker has quit IRC | 22:22 | |
| *** spatel has joined #openstack-nova | 22:23 | |
| *** spatel has quit IRC | 22:27 | |
| *** mriedem has quit IRC | 22:27 | |
| *** gbarros has joined #openstack-nova | 22:29 | |
| *** BjoernT has joined #openstack-nova | 22:37 | |
| *** gbarros has quit IRC | 22:38 | |
| *** BjoernT has quit IRC | 22:42 | |
| *** rcernin has joined #openstack-nova | 23:08 | |
| *** hoonetorg has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
