| *** takashin has joined #openstack-nova | 00:00 | |
| *** hoonetorg has joined #openstack-nova | 00:06 | |
| *** gyee has quit IRC | 00:07 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| *** slaweq has quit IRC | 00:15 | |
| *** markvoelker has joined #openstack-nova | 00:23 | |
| *** markvoelker has quit IRC | 00:28 | |
| openstackgerrit | Merged openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133 | 00:30 |
|---|---|---|
| *** brinzhang has joined #openstack-nova | 00:33 | |
| openstackgerrit | Merged openstack/nova master: fixtures: Handle iterable params for 'NeutronFixture.list_*' https://review.opendev.org/686796 | 00:39 |
| openstackgerrit | Merged openstack/nova master: fixtures: Store 'device_id' when creating port in NeutronFixture https://review.opendev.org/686797 | 00:45 |
| *** tetsuro has quit IRC | 01:05 | |
| *** tetsuro has joined #openstack-nova | 01:16 | |
| *** markvoelker has joined #openstack-nova | 01:26 | |
| *** yaawang has quit IRC | 01:30 | |
| *** yaawang has joined #openstack-nova | 01:31 | |
| *** markvoelker has quit IRC | 01:37 | |
| *** markvoelker has joined #openstack-nova | 01:37 | |
| *** BjoernT has joined #openstack-nova | 01:40 | |
| *** markvoelker has quit IRC | 01:42 | |
| *** yaawang has quit IRC | 01:42 | |
| *** BjoernT has quit IRC | 01:43 | |
| *** yaawang has joined #openstack-nova | 01:44 | |
| *** boxiang has joined #openstack-nova | 01:48 | |
| *** yonglihe has joined #openstack-nova | 01:52 | |
| *** macz has joined #openstack-nova | 01:55 | |
| *** macz has quit IRC | 02:00 | |
| *** markvoelker has joined #openstack-nova | 02:02 | |
| *** yikun has joined #openstack-nova | 02:02 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** tetsuro has quit IRC | 02:14 | |
| *** slaweq has quit IRC | 02:16 | |
| openstackgerrit | Jing Zhang proposed openstack/nova master: [WIP] Default mem_page_size to small for pinned instances https://review.opendev.org/686079 | 02:17 |
| *** tetsuro has joined #openstack-nova | 02:17 | |
| *** rnoriega_ has joined #openstack-nova | 02:19 | |
| openstackgerrit | ya.wang proposed openstack/nova-specs master: Re-propose expose-auto-converge-post-copy spec for Ussuri https://review.opendev.org/687199 | 02:43 |
| *** ricolin has joined #openstack-nova | 02:47 | |
| *** igordc has quit IRC | 02:52 | |
| *** takashin has left #openstack-nova | 03:03 | |
| *** yaawang has quit IRC | 03:07 | |
| *** yaawang has joined #openstack-nova | 03:07 | |
| *** igordc has joined #openstack-nova | 03:19 | |
| *** tetsuro has quit IRC | 03:37 | |
| *** tetsuro has joined #openstack-nova | 03:38 | |
| *** tkajinam has joined #openstack-nova | 03:49 | |
| *** markvoelker has quit IRC | 03:49 | |
| *** yaawang has quit IRC | 04:06 | |
| *** yaawang has joined #openstack-nova | 04:08 | |
| *** mkrai has joined #openstack-nova | 04:08 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** slaweq has quit IRC | 04:16 | |
| *** mkrai has quit IRC | 04:18 | |
| *** fungi has quit IRC | 04:21 | |
| *** fungi has joined #openstack-nova | 04:25 | |
| *** dave-mccowan has quit IRC | 04:41 | |
| openstackgerrit | Merged openstack/nova master: Remove workaround for bug #1709118 https://review.opendev.org/524316 | 04:57 |
| openstack | bug 1709118 in OpenStack Compute (nova) "_ContextAuthPlugin needs a refresh" [Low,Invalid] https://launchpad.net/bugs/1709118 | 04:57 |
| *** brinzhang_ has joined #openstack-nova | 05:12 | |
| *** brinzhang has quit IRC | 05:15 | |
| *** bnemec has quit IRC | 05:19 | |
| *** elod has quit IRC | 05:26 | |
| *** brinzhang has joined #openstack-nova | 05:28 | |
| *** brinzhang has quit IRC | 05:29 | |
| *** brinzhang has joined #openstack-nova | 05:30 | |
| *** brinzhang has joined #openstack-nova | 05:31 | |
| *** brinzhang_ has quit IRC | 05:31 | |
| openstackgerrit | Merged openstack/nova master: [Gate fix] Avoid use cell_uuid before assignment https://review.opendev.org/686996 | 05:42 |
| *** markvoelker has joined #openstack-nova | 05:50 | |
| *** markvoelker has quit IRC | 05:55 | |
| *** psachin has joined #openstack-nova | 05:59 | |
| *** yaawang has quit IRC | 06:06 | |
| *** yaawang has joined #openstack-nova | 06:07 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** brinzhang has joined #openstack-nova | 06:12 | |
| *** slaweq has quit IRC | 06:15 | |
| *** sapd1_x has joined #openstack-nova | 06:19 | |
| *** dtantsur|afk is now known as dtantsur | 06:28 | |
| *** ccamacho has quit IRC | 06:35 | |
| *** slaweq has joined #openstack-nova | 06:35 | |
| *** jaosorior has quit IRC | 06:41 | |
| *** trident has quit IRC | 06:46 | |
| *** damien_r has joined #openstack-nova | 06:49 | |
| *** trident has joined #openstack-nova | 06:49 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Error out interrupted builds https://review.opendev.org/687216 | 06:53 |
| bauzas | good morning Nova | 07:02 |
| *** mjozefcz has joined #openstack-nova | 07:05 | |
| *** rcernin has quit IRC | 07:05 | |
| *** ttsiouts has joined #openstack-nova | 07:10 | |
| *** tesseract has joined #openstack-nova | 07:10 | |
| gibi | bauzas: good morning | 07:13 |
| *** tetsuro has quit IRC | 07:16 | |
| *** tetsuro has joined #openstack-nova | 07:16 | |
| *** awalende has joined #openstack-nova | 07:17 | |
| bauzas | gibi: I was a bit on and off upstream last days so if you need some eyes, tell me | 07:19 |
| *** damien_r has quit IRC | 07:19 | |
| gibi | bauzas: nothing urgent at the moment. I still want to get back to your audit patch | 07:21 |
| bauzas | gibi: I need to write a reno note and some docs like matt asked | 07:21 |
| gibi | bauzas: I saw mriedem's comments. I more interested in trying your code in my devstack | 07:23 |
| *** jaosorior has joined #openstack-nova | 07:24 | |
| bauzas | gibi: that'd be awesome | 07:25 |
| bauzas | gibi: functional tests don't really check children allocations | 07:25 |
| bauzas | gibi: but hopefully it will work this time given you found the root cause last time :) | 07:26 |
| *** ccamacho has joined #openstack-nova | 07:26 | |
| *** ttsiouts has quit IRC | 07:26 | |
| *** ccamacho has quit IRC | 07:27 | |
| *** ttsiouts has joined #openstack-nova | 07:27 | |
| *** ccamacho has joined #openstack-nova | 07:27 | |
| gibi | bauzas: I can try that with bandwith allocation on child RPs. | 07:27 |
| bauzas | ++ | 07:28 |
| bauzas | gibi: I can also do this with VGPU allocations, but i need to reboot my environment :) | 07:28 |
| gibi | bauzas: fortunetly the bandwidth setup does not need any special hardware so it is easy for me to build a devstack | 07:29 |
| bauzas | yeah | 07:29 |
| bauzas | hopefully, VGPU allocations would work with Intel GPU | 07:29 |
| bauzas | but I didn't have time to test those | 07:29 |
| *** mvkr has quit IRC | 07:30 | |
| *** ttsiouts has quit IRC | 07:31 | |
| openstackgerrit | Akihiro Motoki proposed openstack/nova master: doc: Improve PDF document structure https://review.opendev.org/682746 | 07:39 |
| *** mvkr has joined #openstack-nova | 07:43 | |
| *** lpetrut has joined #openstack-nova | 07:45 | |
| *** kaisers has joined #openstack-nova | 07:47 | |
| *** ralonsoh has joined #openstack-nova | 07:48 | |
| *** ttsiouts has joined #openstack-nova | 07:52 | |
| dr_gogeta86 | good morning all | 07:53 |
| *** damien_r has joined #openstack-nova | 08:07 | |
| *** ociuhandu has joined #openstack-nova | 08:16 | |
| *** mvkr has quit IRC | 08:21 | |
| *** tssurya has joined #openstack-nova | 08:22 | |
| *** sapd1_x has quit IRC | 08:27 | |
| *** zhubx has joined #openstack-nova | 08:28 | |
| *** tkajinam has quit IRC | 08:30 | |
| *** jaosorior has quit IRC | 08:32 | |
| *** boxiang has quit IRC | 08:32 | |
| *** mvkr has joined #openstack-nova | 08:34 | |
| *** derekh has joined #openstack-nova | 08:38 | |
| *** rpittau|afk is now known as rpittau | 08:38 | |
| *** xek has joined #openstack-nova | 08:43 | |
| *** priteau has joined #openstack-nova | 08:47 | |
| *** ociuhandu has quit IRC | 08:57 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Remove stale BDMs on reserve_block_device_name failure https://review.opendev.org/682594 | 09:05 |
| *** pcaruana has joined #openstack-nova | 09:30 | |
| *** ociuhandu has joined #openstack-nova | 09:30 | |
| *** brinzhang_ has joined #openstack-nova | 09:33 | |
| *** ociuhandu has quit IRC | 09:35 | |
| *** brinzhang has quit IRC | 09:37 | |
| *** ociuhandu has joined #openstack-nova | 09:43 | |
| *** jaosorior has joined #openstack-nova | 09:44 | |
| *** markvoelker has joined #openstack-nova | 09:53 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1843639 https://review.opendev.org/682621 | 09:56 |
| openstack | bug 1843639 in OpenStack Compute (nova) "libvirt: post_live_migration failures to disconnect volumes result in the rollback of live migrations" [Medium,In progress] https://launchpad.net/bugs/1843639 - Assigned to Artom Lifshitz (notartom) | 09:56 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/682622 | 09:56 |
| *** markvoelker has quit IRC | 09:58 | |
| *** brinzhang_ has quit IRC | 10:01 | |
| *** tetsuro has quit IRC | 10:06 | |
| *** tetsuro has joined #openstack-nova | 10:06 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Improve PDF document structure https://review.opendev.org/682746 | 10:08 |
| *** slaweq_ has joined #openstack-nova | 10:09 | |
| *** slaweq has quit IRC | 10:09 | |
| stephenfin | bauzas: Could I ask you to push through a few trivial patches for me, please? I've a lot of stuff in flight /o\ | 10:10 |
| stephenfin | If you could hit https://review.opendev.org/686211 https://review.opendev.org/686901 https://review.opendev.org/684774 and https://review.opendev.org/#/c/684775/ that's be great | 10:11 |
| stephenfin | https://imgflip.com/s/meme/That-Would-Be-Great.jpg | 10:11 |
| *** tetsuro has quit IRC | 10:11 | |
| *** tetsuro has joined #openstack-nova | 10:13 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Take an instance.uuid lock when rebooting https://review.opendev.org/673463 | 10:17 |
| *** jaosorior has quit IRC | 10:18 | |
| *** tetsuro_ has joined #openstack-nova | 10:20 | |
| *** tetsuro has quit IRC | 10:21 | |
| *** ttsiouts has quit IRC | 10:22 | |
| *** tbachman has quit IRC | 10:25 | |
| *** bbowen has quit IRC | 10:38 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Support move operations with qos ports - Ussuri https://review.opendev.org/686779 | 10:38 |
| gibi | efried: fixed your comments in ^^ | 10:39 |
| *** zhubx has quit IRC | 10:39 | |
| *** zhubx has joined #openstack-nova | 10:40 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove 'adv-config', 'system-admin' subdocs https://review.opendev.org/684402 | 10:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Replacing underscores with dashes https://review.opendev.org/685929 | 10:42 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Strip '.rst' suffix https://review.opendev.org/687264 | 10:42 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove @safe_connect from put_allocations https://review.opendev.org/686579 | 10:45 |
| *** dklyle has quit IRC | 10:49 | |
| *** dklyle has joined #openstack-nova | 10:49 | |
| *** rcernin has joined #openstack-nova | 10:52 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: refactor volume bdm rollback error handling https://review.opendev.org/656500 | 10:55 |
| lyarwood | stephenfin: ^ finally updated that if you have time this wekk. | 10:55 |
| lyarwood | week* | 10:55 |
| *** ociuhandu has quit IRC | 10:56 | |
| *** ociuhandu has joined #openstack-nova | 11:05 | |
| *** ttsiouts has joined #openstack-nova | 11:06 | |
| *** cdent has joined #openstack-nova | 11:09 | |
| *** jamesdenton has quit IRC | 11:11 | |
| *** jamesden_ has joined #openstack-nova | 11:11 | |
| *** gshippey has quit IRC | 11:14 | |
| *** slaweq_ is now known as slaweq | 11:15 | |
| *** xek has quit IRC | 11:15 | |
| *** jamesden_ has quit IRC | 11:19 | |
| *** jamesdenton has joined #openstack-nova | 11:19 | |
| sean-k-mooney | stephenfin: dumb question but how to i add blueprint to the nova team meeting agenda again. there is a wiki page i think right? | 11:20 |
| sean-k-mooney | https://wiki.openstack.org/wiki/Meetings/Nova? | 11:20 |
| sean-k-mooney | im not sure if that is the agenda for last weeks meetin or thi seeks meting | 11:23 |
| *** jamesdenton has quit IRC | 11:24 | |
| *** jamesdenton has joined #openstack-nova | 11:24 | |
| *** dave-mccowan has joined #openstack-nova | 11:28 | |
| gibi | sean-k-mooney: add your stuff to that agenda with a timestamp so when efried goes and updates the agenda for the next meeting he will see that your item is for the upcoming meeting | 11:29 |
| sean-k-mooney | thanks | 11:29 |
| sean-k-mooney | gibi: i bacically want to know if https://blueprints.launchpad.net/nova/+spec/inplace-rebuild-of-numa-instances can proceed as a specless blueprint or if i should write a spec | 11:33 |
| sean-k-mooney | but i have updated the agenda with the timestamp as you suggesteded | 11:33 |
| *** ociuhandu has quit IRC | 11:34 | |
| *** ociuhandu has joined #openstack-nova | 11:35 | |
| gibi | sean-k-mooney: after reading the bp, for me it seems OK to have this as specless as it is only fixing bugs | 11:36 |
| *** ociuhandu has quit IRC | 11:40 | |
| *** bbowen has joined #openstack-nova | 11:40 | |
| sean-k-mooney | gibi: that is what i was hoping. do you think it makes sense to group them as a blueprint as i have | 11:42 |
| sean-k-mooney | i intend to fix the bug as seperate patches in the order i suggested (prevent broken behavior then skip filter if safe) | 11:43 |
| gibi | sean-k-mooney: it is easier to track multiple bugs as a single bp so I agree with your syle | 11:51 |
| gibi | style | 11:51 |
| *** tetsuro_ has quit IRC | 11:52 | |
| kashyap | stephenfin: Just noticed that (WIP) change on skipping CPU comparison check on AArch64. Will comment there. | 11:52 |
| *** tetsuro has joined #openstack-nova | 11:52 | |
| sean-k-mooney | cool i also just fixed all the spelling issue so it should be eaiser for others to parse | 11:52 |
| *** markvoelker has joined #openstack-nova | 11:54 | |
| gibi | sean-k-mooney: thanks for the spelling fix :) | 11:54 |
| *** ociuhandu has joined #openstack-nova | 11:56 | |
| sean-k-mooney | i am trying to get back in to using grammerly more at least of non irc communications | 11:57 |
| *** markvoelker has quit IRC | 11:59 | |
| *** markvoelker has joined #openstack-nova | 12:03 | |
| *** elod has joined #openstack-nova | 12:04 | |
| *** jaosorior has joined #openstack-nova | 12:08 | |
| *** jaosorior has quit IRC | 12:08 | |
| *** jaosorior has joined #openstack-nova | 12:08 | |
| *** ociuhandu has quit IRC | 12:11 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refine comments about move_allocations https://review.opendev.org/686182 | 12:14 |
| openstackgerrit | Merged openstack/nova master: Update contributor guide for Ussuri https://review.opendev.org/685630 | 12:14 |
| *** ociuhandu has joined #openstack-nova | 12:17 | |
| *** tetsuro has quit IRC | 12:20 | |
| *** jangutter_ has joined #openstack-nova | 12:20 | |
| *** jangutter has quit IRC | 12:23 | |
| *** tetsuro has joined #openstack-nova | 12:26 | |
| *** belmoreira has joined #openstack-nova | 12:26 | |
| *** gbarros has joined #openstack-nova | 12:38 | |
| efried | gibi: +2, thanks for the updates | 12:40 |
| gibi | efried: thanks for the review | 12:40 |
| efried | sean-k-mooney: ack meeting agenda | 12:40 |
| efried | alex_xu: Is there more that needs to be done with https://review.opendev.org/#/c/685180/ (test case for unauthed versioned discovery) and its successor (the fix for same)? | 12:43 |
| *** ociuhandu has quit IRC | 12:44 | |
| *** pcaruana has quit IRC | 12:53 | |
| *** spatel has joined #openstack-nova | 12:55 | |
| *** mriedem has joined #openstack-nova | 12:59 | |
| bauzas | stephenfin: dammit, just saw your courtesy ping now :) | 13:02 |
| bauzas | stephenfin: that's what happens when you ping people when they are on gym :) | 13:02 |
| bauzas | and FWIW, just clicked on the 4 changes :) | 13:03 |
| *** cdent_ has joined #openstack-nova | 13:04 | |
| *** cdent has quit IRC | 13:07 | |
| *** cdent_ is now known as cdent | 13:07 | |
| *** lpetrut has quit IRC | 13:08 | |
| mriedem | efried: +2 on https://review.opendev.org/#/c/686414/ now, just let dansmith know when you want to pull the trigger for rc2 | 13:12 |
| *** nweinber__ has joined #openstack-nova | 13:14 | |
| *** rcernin has quit IRC | 13:19 | |
| *** gbarros has quit IRC | 13:20 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: link to user/index from main home page https://review.opendev.org/687292 | 13:23 |
| bauzas | I wonder, does the US already shifted from summer times ? | 13:24 |
| bauzas | (that's in general 2 weeks before Europe hence my wonders) | 13:24 |
| mriedem | not yet | 13:24 |
| mriedem | november 3 | 13:24 |
| bauzas | ack ok | 13:24 |
| bauzas | then Europe is one week *before* this time | 13:25 |
| bauzas | efried: left a comment on https://review.opendev.org/#/c/685857/ | 13:25 |
| bauzas | efried: tl;dr while I'm basically OK with the idea, I just want to clarify the fact that we can't *guarantee* mandatory things | 13:26 |
| bauzas | it's more or less best effort | 13:26 |
| bauzas | although I'm trying hard to stick with this... | 13:26 |
| *** jangutter has joined #openstack-nova | 13:32 | |
| efried | bauzas: Appreciate the reviews, responding now. We can't guarantee anything in this community, as you well know. I can try to make that clearer I suppose. | 13:33 |
| bauzas | efried: yeah, I know you know | 13:33 |
| bauzas | efried: I just want to make it clear by the documentation, that's it | 13:33 |
| efried | ++ | 13:33 |
| efried | aspiers: We're about to pull the trigger on the "SEV limitations" documentation for Train so we can get it into RC2. Unless the fix is, like, completely ready to go right now and you're just about to push it... | 13:34 |
| sean-k-mooney | bauzas: isnt the eu ment to be stoping daylight saving time this year | 13:35 |
| *** xek has joined #openstack-nova | 13:36 | |
| sean-k-mooney | e.g. the clocks will not change next summer | 13:36 |
| *** tbachman has joined #openstack-nova | 13:36 | |
| *** jangutter_ has quit IRC | 13:36 | |
| bauzas | sean-k-mooney: well, that will be different between countries AFAICU | 13:37 |
| stephenfin | efried: Think you could look at https://review.opendev.org/#/c/682746/ today, before it goes into merge conflict again? | 13:37 |
| sean-k-mooney | bauzas: each contry will pick to keep either standard time or daylight savings time | 13:37 |
| bauzas | yup this | 13:37 |
| sean-k-mooney | but across the eu it will nolnger change | 13:37 |
| bauzas | but for example, France and Germany would no longer have same times | 13:38 |
| sean-k-mooney | also if the UK dont pick GMT/UTC i will just give up | 13:38 |
| stephenfin | bauzas: Cool, thanks :) | 13:42 |
| efried | stephenfin: looking | 13:43 |
| *** bnemec has joined #openstack-nova | 13:43 | |
| gibi | mriedem: I have a comment about qos port support in https://review.opendev.org/#/c/633293/49/nova/compute/manager.py@4742 | 13:43 |
| mriedem | gibi: tl;dr add request_spec to the prep_snapshot_based_resize_at_dest method yes? | 13:47 |
| gibi | mriedem: yest | 13:47 |
| mriedem | and finish_snapshot_based_resize_at_dest | 13:47 |
| gibi | mriedem: and for the finish_snapshot_based_resize | 13:47 |
| gibi | yepp | 13:47 |
| mriedem | ok | 13:48 |
| gibi | mriedem: and leave a todo in https://review.opendev.org/#/c/633293/49/nova/compute/manager.py to call _update_pci_request_spec_with_allocated_interface_name() to support qos ports | 13:49 |
| gibi | qos sriov ports | 13:49 |
| gibi | mriedem: btw efried is +2 on the ussuri qos spec so I think it is ready for a +A https://review.opendev.org/#/c/686779/ | 13:51 |
| mriedem | yeah, i wasn't planning on implementing the qos port support in the first round so i'm glad you're ok with todos | 13:54 |
| mriedem | because it's hard enough getting this off the ground with just basic use cases | 13:55 |
| gibi | mriedem: I'm totally OK with TODOs. I can even volunteer to help fixing those TODOs at some point | 13:55 |
| gibi | mriedem: but I want to avoid an extra RPC bump if possible | 13:55 |
| *** ociuhandu has joined #openstack-nova | 13:56 | |
| mriedem | .yeah | 13:57 |
| mriedem | +W on the qos move spec | 13:57 |
| gibi | mriedem: thanks | 13:57 |
| *** mlavalle has joined #openstack-nova | 13:57 | |
| *** ttsiouts has quit IRC | 13:58 | |
| *** ttsiouts has joined #openstack-nova | 13:59 | |
| *** awalende has quit IRC | 14:00 | |
| *** ttsiouts has quit IRC | 14:00 | |
| *** ttsiouts has joined #openstack-nova | 14:00 | |
| alex_xu | efried: nothing more, I just want to pick a time go through the patch again | 14:04 |
| efried | alex_xu: okay, thanks. Any idea who we can get to be a second +2 there? I haven't seen johnthetubaguy in a while... | 14:05 |
| *** gbarros has joined #openstack-nova | 14:05 | |
| alex_xu | efried: good question, and we just lost ken'ichi | 14:05 |
| alex_xu | efried: maybe cdent and gmann can give a review on it | 14:06 |
| efried | stephenfin: +A doc restructure patch | 14:08 |
| cdent | alex_xu: which? | 14:09 |
| alex_xu | cdent: this one https://review.opendev.org/685181 | 14:09 |
| cdent | thanks | 14:09 |
| efried | cdent: you +1ed an earlier version of the test patch underneath it | 14:09 |
| efried | And I was looking for your help on the fix itself before you went on vacay | 14:09 |
| stephenfin | efried: Thanks (y) | 14:10 |
| cdent | yeah, I've gone back to that a few different times, wandered around vaguely over the paste.ini stuff, got a bit sad about that, and then got distracted again. will gaze again now | 14:10 |
| gmann | alex_xu: efried sure, I will check that | 14:10 |
| efried | cdent: yeah, the paste stuff is pretty arcane, but it turns out we're handling the URL mapping bit in nova, so I was able to hack into it a bit. | 14:11 |
| efried | thanks gmann | 14:11 |
| efried | If this flies, there are other projects with the same problem that may need to take similar approaches. | 14:11 |
| openstackgerrit | Merged openstack/nova-specs master: Support move operations with qos ports - Ussuri https://review.opendev.org/686779 | 14:11 |
| efried | neutron and I think cinder | 14:11 |
| cdent | during the future times of tech debt cleanup we should consider adding a wsgi entry point that doesn't use paste.ini (while keeping (perhaps deprecating) for a while the paste way) | 14:12 |
| efried | cdent: I talked with lbragstad about how they cut keystone over to flask | 14:12 |
| cdent | I say this as the maintainer of pastedeploy paste and pastescript: I am not actually maintaining it | 14:13 |
| efried | took them a couple releases | 14:13 |
| efried | but... yes. | 14:13 |
| *** tbachman has quit IRC | 14:13 | |
| * lbragstad has been pushing kmalloc to write up the exact approach we took | 14:13 | |
| lbragstad | we piecemeal'd it because we knew we weren't going to be able to make the complete transition in a single release (but YMMV) | 14:14 |
| cdent | switchign to flask would be awesome, but there are smaller steps to take if getting rid of paste.ini is the intermerdiate goal | 14:15 |
| *** ganso has quit IRC | 14:15 | |
| efried | dansmith: Please merge the "sev busted docs" patch at 9am your time. That's 5pm for aspiers I think, a reasonable approximation of EOD. | 14:15 |
| efried | cdent: intermediate steps that would actually move the ball? Or just replace one icky thing with another icky thing? | 14:16 |
| dansmith | efried: ack | 14:16 |
| lbragstad | cdent yeah - i'd be curious to know how nova tries to break that work up | 14:16 |
| cdent | efried: actually move the ball. all paste.ini does it assemble middleware in a configurable way. If you choose to make it not configurable, you can do the same thing in code, like what placement/deploy.py does | 14:16 |
| cdent | the interior apps remain the same | 14:17 |
| efried | that makes sense. Do we have any idea whether deployments count on the configurability? | 14:17 |
| lbragstad | we implemented some basic plumbing that introduced flask and incrementally moved APIs over from the old paste routers to using flask | 14:17 |
| efried | like, do deployments inject security sniffers or whatever? | 14:17 |
| cdent | a few years ago there was some discussion of paste.ini being an official config file, but I don't know if any hard numbers were available. that's why I was suggesting we have two diferent entry points for some duration | 14:18 |
| efried | oic, with a conf switch that decides which one you're using? | 14:18 |
| mriedem | efried: there are deployments that inject their own middleware yes | 14:19 |
| efried | cdent: community goal: "stop using paste"? | 14:19 |
| *** tbachman has joined #openstack-nova | 14:19 | |
| efried | btw, why is it called "paste"? | 14:19 |
| cdent | that will go as well as stop using wsme (which is even less maintained) | 14:19 |
| mriedem | one example i know of is a middleware from inap (i think?) that translated a request to like a volume-backed flavor | 14:20 |
| * lbragstad feels like that would be about 7 community goals | 14:20 | |
| cdent | it's pastes things (wsgis) together | 14:20 |
| cdent | but it doesn't fix my typing | 14:20 |
| dansmith | I think there was also another thing called paste that did a similar thing that this was modeled after, IIRC | 14:21 |
| dansmith | it's been a loong time | 14:21 |
| dansmith | or maybe a "paste function" in some other middleware stack | 14:21 |
| * cdent expects plone was involved somehow | 14:21 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pull up compute node queries to init_host https://review.opendev.org/682680 | 14:22 |
| cdent | or zope | 14:22 |
| dansmith | I think removing it would be a big deal, meaning removing a big plug point for people | 14:22 |
| lbragstad | +1 dansmith - iirc we asked people over and over if there was anything they *needed* paste for in their deployments | 14:22 |
| dansmith | lbragstad: to be clear, I meant removing it would be a big *bad* deal for the users that make use of it | 14:23 |
| efried | lbragstad: knowing zero about flask, does it also allow customization like paste does? | 14:24 |
| lbragstad | no - not really (or not that i'm aware of) | 14:24 |
| efried | okay, so it really would be taking a nontrivial knob away from deployers. | 14:24 |
| dansmith | I don't think it does | 14:25 |
| cdent | kmalloc had a plan of some kind, but I don't know if it quite happened | 14:25 |
| lbragstad | cdent plan for? | 14:25 |
| donnyd | well also those who may use openstack in customized ways would also be effected | 14:25 |
| cdent | lbragstad: flask middleware customization by file | 14:25 |
| donnyd | say I wanted to make an an integration that isn't upstream yet, paste could also be used that way | 14:26 |
| cdent | I would think, that if we want to make it less configurable there would still be an option to wrap the nova wsgi application with a local custom thing: any wsgi app can be wrapped by another | 14:26 |
| efried | gibi: Sorry if I'm being super dense here, but I don't see how sharing provider allocations are (even theoretically) duplicated by move_allocations | 14:27 |
| gibi | efried: move_allocation takes everything that is allocated by the instance_uuid and moves it to the migration_uuid including the allocation against the sharing rp. Then when the scheduler allocates on the target host is allocates again from the sharing rp | 14:28 |
| cdent | mriedem: since you seem to have a memory, does it contain a reference to recentish performance improvements when listing neutron ports? | 14:28 |
| gibi | efried: if this is a migration with shared disk, it means that during the migration there will be double disk allocation but singulare disk usage | 14:29 |
| efried | gibi: It looks to me as though move_allocations always deletes the allocation from the source | 14:29 |
| gibi | efried: yes, then the scheduler allocates on the dest | 14:29 |
| gibi | efried: when I say duble allocation I mean one piece of disk allocation by the migration_uuid and one piece of allocation by the instance_uuid | 14:30 |
| mriedem | cdent: sorry, context? | 14:30 |
| efried | but I thought the migration UUID is allocating against the dest already | 14:30 |
| gibi | efried: migration uuid is allocates against the source, scheduler allocates against the dest for the intance_uuid as consumer | 14:31 |
| cdent | mriedem: limited context, thus the bad query, trying to see if it pinged a memory for you. basically I'm looking at an internal bug where someone is complaining about 'neutron port-list' consuming a lot of time when there are many instances, and that pinged a memory in me of reading either a bug fix or patch on the nova side related to listing ports being slow | 14:32 |
| efried | gibi: ohhh, so when we're doing a migration, we (1) move_allocations(source_inst/source_host => mig_inst/source_host), and then (2) claim(dest_inst/dest_host), and then (3) delete(mig_inst/source_host) | 14:32 |
| efried | And you're saying that during (2) we would have duplicate sharing provider allocations in theory. | 14:32 |
| openstackgerrit | Merged openstack/nova-specs master: tox -e fast-specs https://review.opendev.org/673356 | 14:33 |
| mriedem | cdent: purely a neutron perf bug? | 14:33 |
| mriedem | or also listing servers being slow b/c of listing ports (security groups)? | 14:33 |
| mriedem | i know of a thing, sec | 14:33 |
| gibi | efried: yes. and for sharing providers this double up is not needed | 14:33 |
| efried | gibi: got it, thank you. | 14:33 |
| mriedem | cdent: is more on the nova server listing side but it's a perf thing https://bugs.launchpad.net/nova/+bug/1567655 | 14:34 |
| openstack | Launchpad bug 1567655 in OpenStack Compute (nova) "500 error when trying to list instances and neutron-server is down" [Medium,Confirmed] | 14:34 |
| cdent | mriedem: I think the thing I'm remember on the nova side was listing servers being slow because neutron being slow and I wanted to reference that thing (for more context) if I could find it, but I couldnt but though tyou might remember | 14:34 |
| gibi | efried: if you can suggest a better wording for the code comment in my patch please do so | 14:34 |
| cdent | see, you did. thank you. | 14:34 |
| cdent | let's see if that's of any use | 14:34 |
| mriedem | cdent: comment 16 is the summary on the perf part of it | 14:34 |
| efried | gibi: It probably makes sense in context, for someone who has that flow (1)(2)(3) in their head. I'll just leave a note on the review for future me and +2. Thanks for bearing with me. | 14:34 |
| gibi | efried: thanks | 14:35 |
| cdent | mriedem: yeah, thanks that helps | 14:35 |
| mriedem | unrelated to listing servers, there are known inefficiencies down in the nova/network/neutronv2/api.py code where nova makes a bunch of small targeted requests to neutron for resources rather than bigger batch requests | 14:36 |
| * cdent nods | 14:36 | |
| mriedem | stuff like https://review.opendev.org/#/c/465792/ | 14:37 |
| cdent | excellent, thanks | 14:38 |
| mriedem | there is an abandoned wip patch related to that from someone at huawei that did a much more extensive refactor to batch up the queries | 14:38 |
| cdent | shame about that | 14:39 |
| mriedem | well, it was pretty crazy | 14:39 |
| mriedem | they are probably running it in their public cloud though... | 14:39 |
| *** tbachman has quit IRC | 14:39 | |
| mriedem | this: https://review.opendev.org/#/c/457845/ | 14:39 |
| cdent | I bet, but if it could someday see the light of day (in a better form?) that would be grand | 14:39 |
| *** ociuhandu has quit IRC | 14:40 | |
| mriedem | if someone were serious about that effort, i think we'd want some before and after profiling numbers like what you did in placement to justify the effort | 14:40 |
| mriedem | i know windriver cared about that stuff because they have users with vms that have like 16 ports attached | 14:41 |
| mriedem | *nfv users | 14:41 |
| cdent | I suspect that it would be of benefit to vmware with their n-thousand instances in one nova-compute mess, but...human resources... | 14:42 |
| * cdent plays a sad and familiar tune | 14:42 | |
| *** jmlowe has quit IRC | 14:42 | |
| * mriedem plays the humpty dance | 14:43 | |
| gibi | stephenfin: quick question in https://review.opendev.org/#/c/686801/3//COMMIT_MSG@9 | 14:45 |
| mriedem | alternatively neutron grows an api that is essentially a view | 14:45 |
| mriedem | i think ^ was bantered about since icehouse days | 14:45 |
| stephenfin | gibi: Yup, that's what I meant. My bad | 14:45 |
| * cdent looks at calendar | 14:45 | |
| gibi | stephenfin: no worries, I just wanted to 100% sure you did what you wanted to do | 14:46 |
| stephenfin | all good :) | 14:46 |
| *** pcaruana has joined #openstack-nova | 14:46 | |
| gibi | :) | 14:46 |
| *** ganso has joined #openstack-nova | 14:47 | |
| *** ociuhandu has joined #openstack-nova | 14:51 | |
| *** ociuhandu has quit IRC | 14:51 | |
| *** ociuhandu has joined #openstack-nova | 14:52 | |
| mriedem | cdent: i've restored https://review.opendev.org/#/c/465792/ to see if i can rebase that since apparently i got it working with kevinbenton's help at one point, and then see if i can tease out some before/after times in a local devstack | 14:56 |
| mriedem | my guess is the server would need to have a few ports attached to notice any different | 14:56 |
| mriedem | *difference | 14:56 |
| *** ociuhandu has quit IRC | 14:57 | |
| *** ociuhandu has joined #openstack-nova | 14:57 | |
| *** macz has joined #openstack-nova | 15:00 | |
| *** jmlowe has joined #openstack-nova | 15:01 | |
| dansmith | mriedem: I was under the impression from your doc that "tox -e api_samples" would create samples I used in the new test I added | 15:01 |
| *** artom has joined #openstack-nova | 15:01 | |
| mriedem | s/your/the/ | 15:02 |
| mriedem | it should generate samples under tox/docs/api_samples yeah | 15:02 |
| mriedem | for the functional api samples tests you run | 15:03 |
| dansmith | do I need to create the microversion dir or something? | 15:03 |
| *** ivve has joined #openstack-nova | 15:03 | |
| mriedem | yeah i think so | 15:03 |
| dansmith | tox -eapi_samples didn't seem to actually run anything though, actually | 15:03 |
| mriedem | b/c it's tox -e api-samples | 15:03 |
| mriedem | not api_samples | 15:03 |
| mriedem | is that a typo in the doc? | 15:03 |
| dansmith | gah | 15:03 |
| dansmith | no | 15:03 |
| dansmith | typo on my end, coupled with I guess I still have that old tox that doesn't complain | 15:04 |
| mriedem | you must have a busted version of tox because that would normally fail if you specify an env that doesn't exist | 15:04 |
| mriedem | yup | 15:04 |
| mriedem | i've got 3.8.0 | 15:04 |
| dansmith | I've got 3.crusty | 15:04 |
| dansmith | still no dice, it fails with looking for those files | 15:06 |
| dansmith | microversion directory was created (by me) and empty | 15:07 |
| dansmith | do I need to create my tpl file manually? | 15:09 |
| gmann | dansmith: yes, template file you need to create, tox env will generate the doc sample file for you | 15:09 |
| dansmith | gmann: okay the docs don't make that very clear | 15:10 |
| efried | alex_xu, bauzas: responded in https://review.opendev.org/#/c/685857/ (feature liaisons) | 15:10 |
| bauzas | cool, on a meeint | 15:10 |
| bauzas | meeting* | 15:10 |
| * bauzas also needs to pay attention to specs now | 15:10 | |
| cdent | efried: did you check if x-server-management url was used anywhere? it appears to be part of the reason why you've appended /auth to the auth_url and that jarred while reviewing | 15:11 |
| efried | jarred like hell when I was writing it too :( | 15:12 |
| efried | cdent: I checked my devstack before and after the patch, and the headers coming back with the version document are the same with keystone/password | 15:12 |
| efried | cdent: note that the noauth middleware exists solely for test, which is confusing that it's a) not under a test/ subdir, and b) documented as conf'able. That confused (me and) stephenfin as well. | 15:13 |
| cdent | yeah, I've left a comment about that | 15:13 |
| cdent | and then fell in this x-server-management hole | 15:13 |
| cdent | I think it is 9yo ancient history | 15:14 |
| *** mjozefcz has quit IRC | 15:14 | |
| efried | cdent: I can't actually find reference to that header in keystone[auth|middleware] | 15:15 |
| cdent | it's not anywhere in .tox/py37 when i grep | 15:15 |
| cdent | see: https://wiki.openstack.org/wiki/Obsolete:API for the main reference i could find | 15:15 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP for I66d8f06f19c5c631e33208580428aa843abb38d2 https://review.opendev.org/678951 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | 15:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058 | 15:16 |
| efried | cdent: results in codesearch all look crusty too. | 15:17 |
| * cdent nods | 15:17 | |
| cdent | rackspace thing | 15:17 |
| *** ociuhandu has quit IRC | 15:17 | |
| efried | last edit on that wiki page was 2013, but the content about that header wasn't changed since 2010. | 15:18 |
| efried | (assume that's what you meant by 9yo) | 15:18 |
| *** gyee has joined #openstack-nova | 15:21 | |
| artom | dansmith, are you using the service user in your image pre-cache series? | 15:21 |
| *** gbarros has quit IRC | 15:21 | |
| dansmith | artom: no, but I think the service token thing is automatic if configured no? /cc mriedem | 15:21 |
| dansmith | artom: meaning not specifically, but service token will be important for this to work in a lot of cases | 15:22 |
| artom | I thought you had to specifically get it? I'm trying to find other examples in the code | 15:22 |
| efried | gibi: stephenfin: I'm going to edit the commit message on https://review.opendev.org/#/c/686801/ without rebasing everything on top of it and then fast approve it, cool? | 15:23 |
| mgagne | mriedem: we no longer use the middleware you mentioned (to force volume-backed flavor) | 15:23 |
| gibi | efried: cool with me | 15:23 |
| mriedem | artom: it's built in if configured | 15:23 |
| dansmith | artom: to use the service user as your credentials I think so, but isn't there some new thing that lets the service use its token to allow use of an expired user token? | 15:23 |
| dansmith | I thought that was automatic | 15:23 |
| *** markvoelker has quit IRC | 15:24 | |
| mriedem | mgagne: oh really, what changed? | 15:24 |
| efried | dansmith: You have to do a thing in code to get service user melded into your context. I don't think we're doing that for cinder yet. But once that's done, it will happen automatically if the service user is set up in your conf. | 15:24 |
| artom | mriedem, so it's automagic from our POV? Ie, if we hit the image API with an expired token, it'll convert to use the nova service user? | 15:25 |
| dansmith | efried: okay that doesn't jive with what mriedem just said | 15:25 |
| mriedem | artom: see https://github.com/openstack/nova/blob/master/nova/service_auth.py#L36 | 15:25 |
| mriedem | efried: this is glance | 15:25 |
| dansmith | efried: or do you mean it's done for glance already (which covers me)? | 15:25 |
| mriedem | and it already goes through ^ | 15:25 |
| mgagne | mriedem: we do have a local orchestrator for one region which requires volume-backed flavor. other regions now have local storage available for all flavors. | 15:25 |
| mriedem | glane was the #1 use case for the service user stuff from osic | 15:25 |
| mriedem | b/c of token timeouts during long snapshots | 15:25 |
| efried | dansmith: sorry, I was wrong about cinder, which already does the service auth wrapper; and yes, so does glance. | 15:25 |
| dansmith | efried: ackj | 15:26 |
| efried | (swedish for 'ack' ^ ) | 15:26 |
| dansmith | mriedem: what is the magic sauce for doing an api samples test with an empty response? | 15:26 |
| mriedem | i'd have to dig | 15:27 |
| mriedem | but i was wondering, is 202 the correct response if there is no body? should it be 204? | 15:27 |
| zigo | If I run "nova host-evacuate-live", will it keep my VMs in their original availability zones? | 15:27 |
| mgagne | mriedem: as for the local orchestrator, the user doesn't have access to the Nova API. If he had access to the API, we would probably have to put that middleware back in. (I don't see that one coming anytime soon) | 15:27 |
| dansmith | mriedem: le shrug | 15:27 |
| mriedem | cdent: "is 202 the correct response if there is no body? should it be 204?" | 15:27 |
| cdent | 204 is if there's no body and you're done | 15:28 |
| dansmith | mriedem: I guess maybe I validate the return value manually instead of calling the thing that would process a template | 15:28 |
| openstackgerrit | Eric Fried proposed openstack/nova master: nova-net: Make even more nova-net stuff optional https://review.opendev.org/686801 | 15:28 |
| dansmith | aight | 15:28 |
| cdent | 202 is "imma do a bit more, check back later" | 15:28 |
| mriedem | cdent: yeah in this case we're not done, | 15:28 |
| mriedem | rpc cast to conductor | 15:28 |
| mriedem | but no response body | 15:28 |
| dansmith | yeah, async but no response | 15:28 |
| gmann | you can skip the verify_response and just check the status code. that is how we did for action APIs with no response | 15:28 |
| cdent | in that 202 is probalby fine as long as somewhere in the response (header or body) there is a reference to how I check back later | 15:29 |
| mriedem | right now there is no checking back later | 15:29 |
| dansmith | yeah, specifically uncheckable | 15:29 |
| mriedem | i.e. there is no status tracking or anything | 15:29 |
| * dansmith listens for cdent's head to explode | 15:30 | |
| cdent | then from the user's standpoint a 204 might make more sense | 15:30 |
| dansmith | gdi cdent | 15:31 |
| dansmith | 202 is less work for me | 15:31 |
| mriedem | heh, how? | 15:31 |
| cdent | dansmith: have a read of https://httpstatuses.com/202 and make your choice. either is probalby fine | 15:31 |
| dansmith | mriedem: because 202 is done and checked in a few places already :) | 15:31 |
| mriedem | that's what i figured | 15:31 |
| mriedem | "The 202 response is intentionally noncommittal. Its purpose is to allow a server to accept a request for some other process (perhaps a batch-oriented process that is only run once per day) without requiring that the user agent's connection to the server persist until the process is completed. " | 15:32 |
| mriedem | sounds spot on | 15:32 |
| mriedem | especially the batch-oriented part | 15:32 |
| dansmith | cdent: right so we picked 202 specifically because all of those things are true.. it's async, it may or may not happen, some constraints are checked later and may cause us to do nothing with no warning | 15:32 |
| dansmith | mriedem: yeah, exactly | 15:32 |
| dansmith | once per day batch is exactly this | 15:33 |
| *** ttsiouts has quit IRC | 15:34 | |
| cdent | yeah, 202 is probably fine | 15:34 |
| mriedem | unrelated to the response code, something i thought about while tossing and turning at 3am last night was that your api validation should probably check that the list of dicts is a unique set of image IDs and 400 if not | 15:34 |
| dansmith | mriedem: already doing that :) | 15:34 |
| mriedem | whew | 15:34 |
| gibi | bauzas: tested your latest audit patch with bandwidth and left the result in https://review.opendev.org/#/c/670112/7 | 15:34 |
| bauzas | gibi: /me is scared | 15:34 |
| efried | fwiw I vote for 202 dansmith cdent mriedem | 15:35 |
| gibi | bauzas: There is some confusing printout, and as you stated the current code does not handle child RPs | 15:35 |
| bauzas | gibi: thanks for the paste, very insightful | 15:35 |
| * bauzas is on a meeting so i can't really digest now, but I'll certainly look at it tomorrow mornign | 15:36 | |
| *** ivve has quit IRC | 15:36 | |
| gibi | bauzas: cleary there is progress as the instance and the compute is found in cell1. | 15:36 |
| gibi | bauzas: no worries. I leave for today now anyhow | 15:36 |
| bauzas | gibi: I appreciate your positivity : | 15:37 |
| bauzas | :p | 15:37 |
| gibi | :) | 15:37 |
| * gibi leaves the building | 15:38 | |
| *** damien_r has quit IRC | 15:42 | |
| *** belmoreira has quit IRC | 15:45 | |
| *** rpittau is now known as rpittau|afk | 15:47 | |
| *** mjozefcz has joined #openstack-nova | 15:48 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 15:49 |
| *** tbachman has joined #openstack-nova | 15:49 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fixtures: Add support for security groups https://review.opendev.org/686802 | 15:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: fixtures: Add support for security groups https://review.opendev.org/686802 | 15:50 |
| artom | dansmith, left some thoughts about exception handling in your series | 15:50 |
| artom | dansmith, tell me if I'm way off base | 15:50 |
| dansmith | artom: ack, thanks | 15:51 |
| dansmith | mriedem: looks like the bulk of our aggregate docs are in the user guide.. is that where you think I should put my stuff? | 15:51 |
| mriedem | dansmith: rebase, that all recently moved and just merged | 15:53 |
| mriedem | https://docs.openstack.org/nova/latest/admin/aggregates.html | 15:53 |
| dansmith | mriedem: like, this week? | 15:53 |
| mriedem | yeah | 15:53 |
| dansmith | mkay | 15:54 |
| mriedem | https://review.opendev.org/#/c/667133/ | 15:54 |
| mriedem | merged last night | 15:54 |
| mriedem | efried: before i make changes please ack that i've answered your questions here https://review.opendev.org/#/c/686835/2/nova/tests/functional/test_boot_from_volume.py@192 | 15:54 |
| mriedem | dansmith: if we had docs on the image cache in general i'd say that would be a good place but we don't have any docs about the image cache :( | 15:56 |
| dansmith | heh | 15:57 |
| mriedem | i guess another place you could stuff it is https://docs.openstack.org/nova/latest/admin/manage-the-cloud.html if that aggregates page isn't a good fit | 15:58 |
| dansmith | erm, the aggregates page seems better than that | 16:01 |
| dansmith | but obviously something image- or imagecache-specific would be better | 16:01 |
| *** cdent has quit IRC | 16:01 | |
| dansmith | I'll add it here in minimal detail and then we should probably shoot for some imagecache doc | 16:01 |
| dansmith | looks like something has reshuffled in that aggregates doc to put the usage section after the more advanced topics | 16:02 |
| mriedem | i think a pretty simple image cache doc could start with a high level description, list of drivers that support it, and the related config options | 16:02 |
| mriedem | dansmith: you'll have to wrestle with stephenfin about that | 16:03 |
| *** dtantsur is now known as dtantsur|afk | 16:03 | |
| dansmith | heh yeah all the google linkage is broken now after that admin/user shuffleup | 16:04 |
| mriedem | yeah i'm not surprised, the patch didn't account for redirects | 16:04 |
| dansmith | yeah that new aggregates page is just kindof a mess and the ordering makes no sense | 16:06 |
| dansmith | I guess I'll just chuck my thing at the bottom | 16:06 |
| openstackgerrit | Merged openstack/nova master: compute: refactor volume bdm rollback error handling https://review.opendev.org/656500 | 16:06 |
| openstackgerrit | Merged openstack/nova master: doc: Improve PDF document structure https://review.opendev.org/682746 | 16:06 |
| openstackgerrit | Merged openstack/nova master: docs: Remove a whole load of unused images, most remainder https://review.opendev.org/686211 | 16:06 |
| openstackgerrit | Merged openstack/nova master: trivial: Change name of network provided by NeutronFixture https://review.opendev.org/686798 | 16:06 |
| openstackgerrit | Merged openstack/nova master: nova-net: Stop mocking the instance network cache https://review.opendev.org/686799 | 16:07 |
| openstackgerrit | Merged openstack/nova master: trivial: Make it obvious where we're getting our names from https://review.opendev.org/686800 | 16:07 |
| *** tesseract has quit IRC | 16:08 | |
| *** N3l1x has joined #openstack-nova | 16:09 | |
| mriedem | luckily infra has a report of active docs 404s | 16:09 |
| sean-k-mooney | the most annoying thing about google+docs is it does not priorties latest | 16:10 |
| mriedem | http://files.openstack.org/docs-404s/ | 16:10 |
| dansmith | sean-k-mooney: that's probably good since we apparently just break our latest a lot | 16:11 |
| mriedem | 5 /nova/latest/user/aggregates.html | 16:11 |
| mriedem | yeah we should have a redirect for that | 16:11 |
| mriedem | stephenfin: ^ | 16:11 |
| *** ociuhandu has joined #openstack-nova | 16:12 | |
| stephenfin | Did I miss one? | 16:13 |
| stephenfin | crap, yeah, let me add it now | 16:13 |
| *** sapd1_x has joined #openstack-nova | 16:14 | |
| mriedem | dansmith: just for tracking: https://bugs.launchpad.net/nova/+bug/1847302 | 16:15 |
| openstack | Launchpad bug 1847302 in OpenStack Compute (nova) "doc: need admin guide for the image cache" [Undecided,New] | 16:15 |
| *** ociuhandu_ has joined #openstack-nova | 16:15 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_image() driver method and libvirt implementation https://review.opendev.org/687137 | 16:16 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_image() support to the compute rpc, api, and manager https://review.opendev.org/687138 | 16:16 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | 16:16 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 16:16 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates https://review.opendev.org/687348 | 16:16 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: fix formatting in mitigation-for-Intel-MDS-security-flaws https://review.opendev.org/687350 | 16:17 |
| *** ociuhandu has quit IRC | 16:18 | |
| dansmith | gibi: (or mriedem) are there any examples of not-instance-related notifications I can copy for image pre-caching? | 16:18 |
| mriedem | there are notifications for aggregates and services | 16:19 |
| mriedem | agg add/remove host i think | 16:19 |
| dansmith | ah yep | 16:19 |
| mriedem | there are also the more generic compute_task.* ones but i'm guessing we should follow the aggregate ones since this is on the aggregates route | 16:20 |
| dansmith | well, the aggregates ones are api-centric, but this would be host-centric | 16:20 |
| mriedem | aggregate.image.cache.start|end? | 16:20 |
| dansmith | i.e. "host foo started downloading a thing" | 16:20 |
| dansmith | no, I want it to be host-specific so you can monitor progress | 16:21 |
| *** ociuhandu_ has quit IRC | 16:22 | |
| dansmith | although I guess notify_about_aggregate_update could be sent from the conductor | 16:22 |
| dansmith | as long as it mentions the host | 16:22 |
| dansmith | that would allow us to notify about timeouts, etc | 16:22 |
| mriedem | i think notify_about_aggregate_update is the legacy thing | 16:23 |
| mriedem | notify_about_aggregate_action is the versioned notification thing | 16:23 |
| mriedem | there is also a legacy notify_about_host_update for things on the os-hosts api | 16:23 |
| dansmith | okay | 16:23 |
| mriedem | and that's likely closer to what you're looking for | 16:23 |
| mriedem | i don't think those got converted to versioned notifications b/c the os-hosts api is deprecated | 16:24 |
| *** igordc has quit IRC | 16:25 | |
| *** TxGirlGeek has joined #openstack-nova | 16:26 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add redirects for '/user/aggregates' https://review.opendev.org/687353 | 16:27 |
| stephenfin | mriedem: ^ | 16:27 |
| mriedem | yar matey | 16:27 |
| mriedem | huh, that patch is triggering functional jobs, must have something missing in our zuul yaml blacklist | 16:30 |
| dansmith | mriedem: so, I'm not really sure what the rules are on our new notifications.. I think I could use AggregatePayload to convey what I want, but not sure if I should | 16:30 |
| dansmith | i.e. AggregatePayload(name="aggregate.imagecache.start", uuid=agg.uuid, hosts=[this_compute]) | 16:30 |
| mriedem | no i don't think that's what you want | 16:30 |
| mriedem | my guess is you'll end up creating a new single purpose thing like VolumeUsagePayload and MetricsPayload | 16:31 |
| mriedem | so, | 16:32 |
| mriedem | maybe you're thinking of something like this: | 16:32 |
| mriedem | 1. generic aggregate payload based thing to start the operation sent from conductor | 16:33 |
| mriedem | 2. start/end notifications per compute which would be a new payload | 16:33 |
| mriedem | 3. end version of #1 in conductor once it's done processing all hosts | 16:33 |
| mriedem | so if a consumer cares about only the overall op being done and not the host specific details they can just listen for that | 16:33 |
| dansmith | yeah | 16:34 |
| *** macz has quit IRC | 16:34 | |
| mriedem | so for 1 and 3 you'd use notify_about_aggregate_action | 16:34 |
| mriedem | with a new action | 16:34 |
| dansmith | so is that a new notification and payload? | 16:34 |
| mriedem | #2 will be a new payload | 16:34 |
| *** macz has joined #openstack-nova | 16:34 | |
| mriedem | notify_about_aggregate_action is what's used for the existing aggregate actions like create/delete/update meta/add and remove host | 16:34 |
| dansmith | meaning, AggregateImageNotification, AggregateImagePayload | 16:34 |
| sean-k-mooney | is the per host version too verbose. not that i think its a bad idea but im wonder would you jsut wait for the conductor start/end | 16:34 |
| mriedem | i think 1 and 3 above fit into that with a new 'cache_images' action or something | 16:34 |
| dansmith | sean-k-mooney: I'm already waiting in the conductor.. I want them to be able to construct the per-host status from notifications if they want, which was part of the original discussion | 16:35 |
| mriedem | i would start with the 1 and 3 cases in conductor since that's pretty trivial | 16:35 |
| sean-k-mooney | dansmith: ah ok | 16:35 |
| mriedem | and then separately bake in the new per-host payload and such | 16:35 |
| mriedem | with gibi's input | 16:35 |
| dansmith | mriedem: yep, separate patch fo'sho | 16:36 |
| sean-k-mooney | dansmith: ya i was wondering if people would go to the effort of reconstructing the hot view but i can see wanting to do that | 16:36 |
| sean-k-mooney | *host | 16:37 |
| dansmith | sean-k-mooney: I want them to be able to so I can use that to deflect requests for a full reporting API, at least initially | 16:37 |
| mriedem | was just going to say that ^ | 16:37 |
| sean-k-mooney | :) | 16:37 |
| mriedem | if per host notifications are too noisy for some deployments we can make that configurable - we have an option to include bdms in instance payloads for example | 16:38 |
| dansmith | yeah | 16:41 |
| dansmith | also, it's two notifications per image per compute.. images take a few seconds to download at a minimum in most real cases, so... meh | 16:41 |
| dansmith | we have a bunch per each instance boot already | 16:41 |
| *** kmalloc has left #openstack-nova | 16:42 | |
| *** factor has quit IRC | 16:43 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Skip functional test jobs for doc redirect changes https://review.opendev.org/687357 | 16:45 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: docs: Add redirects for '/user/aggregates' https://review.opendev.org/687353 | 16:46 |
| *** mjozefcz has quit IRC | 16:46 | |
| *** tssurya has quit IRC | 16:49 | |
| *** sapd1_x has quit IRC | 16:50 | |
| *** derekh has quit IRC | 16:52 | |
| dansmith | mriedem: the fake notifier doesn't grab the versioned kind I guess | 16:54 |
| dansmith | but I don't see a fixture or anything for that | 16:54 |
| efried | mriedem: sorry, was otp, reading (https://review.opendev.org/#/c/686835/2/nova/tests/functional/test_boot_from_volume.py@192) | 16:54 |
| dansmith | ah | 16:54 |
| dansmith | nevermind I think | 16:55 |
| efried | mriedem: ack the above, all makes sense to me, thanks for the response. | 16:56 |
| *** ivve has joined #openstack-nova | 16:57 | |
| *** ricolin has quit IRC | 17:03 | |
| *** priteau has quit IRC | 17:07 | |
| *** spatel has quit IRC | 17:14 | |
| *** ralonsoh has quit IRC | 17:22 | |
| *** xek_ has joined #openstack-nova | 17:23 | |
| *** markvoelker has joined #openstack-nova | 17:25 | |
| *** xek has quit IRC | 17:25 | |
| mriedem | dansmith: you found https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_notifier.py#L152 right? | 17:27 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | 17:27 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | 17:27 |
| openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates https://review.opendev.org/687348 | 17:27 |
| dansmith | mriedem: yeah sorry | 17:27 |
| *** dave-mccowan has quit IRC | 17:28 | |
| *** ccamacho has quit IRC | 17:29 | |
| *** markvoelker has quit IRC | 17:29 | |
| openstackgerrit | Eric Fried proposed openstack/os-traits master: Add method to visualize the os-traits tree https://review.opendev.org/686464 | 17:35 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add boot from volume functional test with a huge request https://review.opendev.org/686734 | 17:39 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Cache image GETs for multi-create/multi-BDM requests https://review.opendev.org/686835 | 17:39 |
| *** gbarros has joined #openstack-nova | 17:43 | |
| mriedem | we might as well revert https://review.opendev.org/684118 since the logging with traceback isn't useful: http://paste.openstack.org/show/782116/ | 17:44 |
| efried | boo | 17:45 |
| efried | mriedem: is it any worse than what was before? | 17:45 |
| mriedem | it's not helpful and the warning loses the cell uuid part of the message | 17:46 |
| mriedem | so i think it's not better | 17:46 |
| *** igordc has joined #openstack-nova | 17:46 | |
| efried | Oh, I thought the whole point was that the cell UUID was being lost before anyway. | 17:47 |
| efried | but then the unboundlocal thing means we don't have it here either | 17:47 |
| efried | sad face | 17:47 |
| *** dave-mccowan has joined #openstack-nova | 17:49 | |
| mriedem | we might have something more useful for the db layer if we extended the cell timeout since we might not be getting the root db layer failure because of connection retries in oslo.db | 17:50 |
| mriedem | but i'm still not sure that's going to help debug the issue | 17:50 |
| mriedem | we already know that during grenade we start mysqld 3 times and at some point things go south after the last restart | 17:50 |
| mriedem | we start seeing all of these "Aborted connection" errors | 17:51 |
| mriedem | a la https://review.opendev.org/#/c/682661 | 17:51 |
| mriedem | random thinking out loud, | 17:53 |
| mriedem | i wonder if with the instance_extra.resources stuff we've tipped the size of the instance extra queries over | 17:53 |
| mriedem | looking at http://codesearch.openstack.org/?q=max_allowed_packet&i=nope&files=&repos= | 17:56 |
| mriedem | it looks like anywhere from 16M to 256M is pretty standard | 17:56 |
| *** TxGirlGeek has quit IRC | 18:03 | |
| *** markvoelker has joined #openstack-nova | 18:06 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Deprecate [api]auth_strategy https://review.opendev.org/687373 | 18:09 |
| mriedem | efried: https://review.opendev.org/687374 for the timeout to cell thing like your patch | 18:12 |
| efried | ack, watching | 18:14 |
| efried | mriedem: ...but it didn't work afaict. | 18:15 |
| *** CeeMac has joined #openstack-nova | 18:21 | |
| openstackgerrit | Eric Fried proposed openstack/os-traits master: Privatize and reorganize base package methods https://review.opendev.org/687378 | 18:23 |
| *** mriedem has quit IRC | 18:31 | |
| *** mriedem has joined #openstack-nova | 18:32 | |
| *** gbarros has quit IRC | 18:45 | |
| *** markvoelker has quit IRC | 18:50 | |
| *** markvoelker has joined #openstack-nova | 18:54 | |
| *** ianw_pto is now known as ianw | 18:59 | |
| *** jmlowe has quit IRC | 19:03 | |
| *** dave-mccowan has quit IRC | 19:10 | |
| *** jmlowe has joined #openstack-nova | 19:17 | |
| *** TxGirlGeek has joined #openstack-nova | 19:20 | |
| *** ociuhandu has joined #openstack-nova | 19:26 | |
| *** ociuhandu has quit IRC | 19:31 | |
| *** psachin has quit IRC | 19:33 | |
| openstackgerrit | Merged openstack/nova stable/train: docs: Highlight the current broken state of SEV https://review.opendev.org/686414 | 19:33 |
| openstackgerrit | Merged openstack/nova master: nova-net: Make even more nova-net stuff optional https://review.opendev.org/686801 | 19:33 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Helper to start computes with different HostInfos https://review.opendev.org/686832 | 19:36 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 19:36 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: [WIP] NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | 19:36 |
| openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | 19:36 |
| *** artom has quit IRC | 19:37 | |
| *** trident has quit IRC | 19:51 | |
| *** trident has joined #openstack-nova | 19:54 | |
| *** dave-mccowan has joined #openstack-nova | 19:59 | |
| *** TxGirlGeek has quit IRC | 20:01 | |
| *** TxGirlGeek has joined #openstack-nova | 20:02 | |
| *** macz has quit IRC | 20:05 | |
| *** TxGirlGeek has quit IRC | 20:06 | |
| *** nweinber__ has quit IRC | 20:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Bulk query floating IPs in _nw_info_get_ips https://review.opendev.org/465792 | 20:18 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: Time how long _nw_info_get_ips takes https://review.opendev.org/687410 | 20:18 |
| *** mtreinish has quit IRC | 20:21 | |
| openstackgerrit | Merged openstack/nova master: doc: fix formatting in mitigation-for-Intel-MDS-security-flaws https://review.opendev.org/687350 | 20:31 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Deprecate [api]auth_strategy and noauth2 https://review.opendev.org/687373 | 20:33 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Murder NoAuthMiddleware https://review.opendev.org/687416 | 20:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: link to user/availability-zones from user home page https://review.opendev.org/687165 | 20:33 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: link to user/index from main home page https://review.opendev.org/687292 | 20:33 |
| efried | mriedem: It turned out to be actually quite easy to bypass noauth and just stub out keystone --^ | 20:33 |
| efried | there's a lot more to be done there, but I was able to get through enough pieces to convince myself that that approach is going to work. | 20:34 |
| efried | the remainder is just cleaning up the leftovers. | 20:34 |
| *** xek_ has quit IRC | 20:34 | |
| mriedem | does ksa/keystonemiddleware provide any fixtures for some of this? | 20:34 |
| mriedem | that would be ideal rather than stubbing keystonemiddleware.auth_token.filter_factory | 20:35 |
| mriedem | oh hello https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/fixture.py | 20:35 |
| *** pcaruana has quit IRC | 20:35 | |
| efried | mriedem: I agree, but that would be a subsequent step in any case. | 20:35 |
| efried | as in, doing this is not taking away anything we were doing before, because we weren't hitting those factories at all | 20:36 |
| efried | I mentioned same in my commit message | 20:36 |
| efried | lbragstad: any idea if there's a fixture for keystonemiddleware.auth_token.filter_factory ? | 20:36 |
| efried | ah, neat | 20:38 |
| efried | lbragstad: cancel, I did not read scrollback thoroughly. | 20:38 |
| lbragstad | yup - looks like you're on the right track | 20:38 |
| *** CeeMac has quit IRC | 20:39 | |
| mriedem | efried: ultra mega -1 on the bottom change | 20:40 |
| mriedem | not the logging thing, the reno | 20:40 |
| efried | mriedem: o ya, I thought of that while I was updating and then forgot again, will do. | 20:41 |
| mriedem | so with https://review.opendev.org/#/c/686414/ i guess we can push rc2 now yeah? | 20:42 |
| mriedem | are you doing that? | 20:42 |
| efried | mriedem: I can, or you can, up to you. | 20:43 |
| mriedem | i'll push it real good | 20:43 |
| efried | ++ | 20:43 |
| mriedem | https://review.opendev.org/687418 | 20:46 |
| *** igordc has quit IRC | 20:59 | |
| *** slaweq has quit IRC | 20:59 | |
| *** mtreinish has joined #openstack-nova | 21:00 | |
| *** igordc has joined #openstack-nova | 21:00 | |
| eandersson | This makes me sad | 21:02 |
| eandersson | https://github.com/openstack/nova/blob/stable/rocky/nova/virt/libvirt/vif.py#L232 | 21:02 |
| eandersson | :'( | 21:02 |
| eandersson | I am pretty sure CentOS 7.x supports more than 8. | 21:02 |
| mriedem | why for | 21:02 |
| mriedem | prove it! | 21:03 |
| eandersson | In fact we have it set to a lot more than 8, but didn't realize that after upgrading it downgraded them | 21:03 |
| mriedem | does the kernel in centros 7.x have some patch that makes that more than 8? | 21:03 |
| eandersson | Probably worth checking with someone from RedHat to confirm | 21:03 |
| mriedem | yar | 21:03 |
| eandersson | My colleague told me he pulled down the source code and confirmed | 21:05 |
| *** ceryx has joined #openstack-nova | 21:06 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove dead reserve_volume compat code in _validate_bdm https://review.opendev.org/687427 | 21:30 |
| mriedem | eandersson: but was it patched in or something? | 21:30 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove dead reserve_volume compat code in _validate_bdm https://review.opendev.org/687427 | 21:31 |
| *** bbowen has quit IRC | 21:34 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove Stein compute compat checks for volume type support https://review.opendev.org/687428 | 21:42 |
| *** markvoelker has quit IRC | 21:43 | |
| mriedem | this is a good easy fix https://review.opendev.org/#/c/678991/ | 21:48 |
| *** kosa777777 has joined #openstack-nova | 21:49 | |
| ceryx | mriedem: I'm the colleague eandersson mentioned. https://elixir.bootlin.com/linux/v3.10/source/drivers/net/tun.c#L115 has the cap set to 8, but that same file from the centos source RPM for that kernel version is https://pastebin.com/2415QjTW. Unsure what version they changed that in though. | 21:54 |
| ceryx | but they set '#define MAX_TAP_QUEUES 256 | 21:55 |
| ceryx | ' rather than DEFAULT_MAX_NUM_RSS_QUEUES (which is still set to 8 in the rhel/centos version) | 21:55 |
| mriedem | ok, i guess that's the question | 21:56 |
| mriedem | and if it's a centos only patch then it's pretty hard to have a condition in nova for that | 21:57 |
| *** gbarros has joined #openstack-nova | 21:59 | |
| kosa777777 | I am also the colleague of eandersson and ceryx, how about having option to set it to certain number on compute itself if operator chooses to not rely on default? | 22:01 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Pre-validate volumes for cross_az_attach=False during create https://review.opendev.org/687430 | 22:03 |
| mriedem | kosa777777: i'd prefer not having options like that but not sure what others think - maybe start by reporting a bug and taking it from there | 22:03 |
| *** ivve has quit IRC | 22:03 | |
| *** gbarros has quit IRC | 22:04 | |
| ceryx | I checked through the centos kernel versions up through 7.7 and they all have that driver hard-coded to #define MAX_TAP_QUEUES 256 :/ | 22:05 |
| mriedem | can you do a git blame and find out the change that patched it? | 22:05 |
| *** TxGirlGeek has joined #openstack-nova | 22:07 | |
| kosa777777 | also "platform.linux_distribution()" would determine if it is CentOS, if that is needed to distinguish Ubuntu from Centos | 22:11 |
| *** gyee has quit IRC | 22:14 | |
| mriedem | let's start with a reported bug with options and discuss there - there could be a [workarounds] group option if people are ok with that | 22:14 |
| eandersson | Yea sounds good | 22:17 |
| *** spatel has joined #openstack-nova | 22:23 | |
| kosa777777 | great | 22:26 |
| *** rcernin has joined #openstack-nova | 22:26 | |
| eandersson | mriedem, do you happen to have an estimate on when we could get an initial version of the backport for making restating computes safe :P | 22:29 |
| eandersson | I could probably take a stab at it, but last time the number of differences between the master and rocky code base was pretty overwhelming | 22:29 |
| mriedem | it starts in train which GAs on oct 17 https://wiki.openstack.org/wiki/Nova/Train_Release_Schedule - after that we can release in train 20.0.1 and move to stein + release and then rocky + release | 22:30 |
| mriedem | so my guess would be early november at the earliest | 22:31 |
| mriedem | meaning, it's not a regression in train so we're not putting it into the train GA right now, it will be in the first patch release after the train GA | 22:31 |
| mriedem | then stein and rocky as normal | 22:32 |
| eandersson | Yea - I mean for me it's more about the patch being pushed, but not necessarily merged. | 22:36 |
| mriedem | you can propose the stein and rocky backports, there are at least 2 patches for that fix b/c there is a functional recreate test patch and then the fix patch | 22:36 |
| mriedem | or you can bribe gibi to move on that | 22:37 |
| eandersson | How do I bribe gibi? beer? :D | 22:37 |
| mriedem | goulash | 22:37 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Deprecate [api]auth_strategy and noauth2 https://review.opendev.org/687373 | 22:43 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Murder NoAuthMiddleware https://review.opendev.org/687416 | 22:43 |
| *** spatel has quit IRC | 22:51 | |
| *** spatel has joined #openstack-nova | 22:52 | |
| *** tkajinam has joined #openstack-nova | 23:00 | |
| *** spatel has quit IRC | 23:05 | |
| *** hoonetorg has quit IRC | 23:12 | |
| *** N3l1x has quit IRC | 23:23 | |
| *** hoonetorg has joined #openstack-nova | 23:25 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Pre-validate volumes for cross_az_attach=False during create https://review.opendev.org/687430 | 23:28 |
| mriedem | dansmith: for your morrow, ^ is an alternative and much less fugly solution for the cross_az_attach=False server create issue that i was trying to fix in https://review.opendev.org/#/c/469675/ | 23:29 |
| mriedem | basically all contained in the api so less passing of garbage down and up through the layers | 23:29 |
| *** markvoelker has joined #openstack-nova | 23:32 | |
| *** bbowen has joined #openstack-nova | 23:37 | |
| *** bbowen has quit IRC | 23:39 | |
| *** tkajinam has quit IRC | 23:39 | |
| *** bbowen has joined #openstack-nova | 23:39 | |
| *** tkajinam has joined #openstack-nova | 23:40 | |
| *** TxGirlGeek has quit IRC | 23:45 | |
| *** mlavalle has quit IRC | 23:45 | |
| *** mriedem has quit IRC | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
