| *** rcernin has quit IRC | 00:17 | |
| *** rcernin has joined #openstack-nova | 00:17 | |
| *** tosky has quit IRC | 00:29 | |
| openstackgerrit | Eric Xie proposed openstack/nova master: Fix incorrect command examples https://review.opendev.org/695832 | 00:45 |
|---|---|---|
| *** Liang__ has joined #openstack-nova | 01:15 | |
| *** ircuser-1 has quit IRC | 01:17 | |
| *** ociuhandu has joined #openstack-nova | 01:25 | |
| *** ociuhandu has quit IRC | 01:32 | |
| *** nanzha has joined #openstack-nova | 01:56 | |
| *** ociuhandu has joined #openstack-nova | 02:02 | |
| *** yedongcan has joined #openstack-nova | 02:05 | |
| *** ociuhandu has quit IRC | 02:06 | |
| *** smcginnis has joined #openstack-nova | 02:10 | |
| *** ociuhandu has joined #openstack-nova | 02:19 | |
| *** ociuhandu has quit IRC | 02:24 | |
| *** chenhaw has joined #openstack-nova | 02:30 | |
| *** macz has joined #openstack-nova | 02:54 | |
| *** macz has quit IRC | 02:59 | |
| *** brinzhang has joined #openstack-nova | 03:07 | |
| *** ociuhandu has joined #openstack-nova | 03:33 | |
| *** ociuhandu has quit IRC | 03:40 | |
| *** vesper11 has quit IRC | 03:45 | |
| *** vesper11 has joined #openstack-nova | 03:47 | |
| *** ricolin has joined #openstack-nova | 03:54 | |
| *** slaweq has joined #openstack-nova | 03:58 | |
| *** davee__ has joined #openstack-nova | 04:03 | |
| *** davee_ has quit IRC | 04:05 | |
| *** brinzhang_ has joined #openstack-nova | 04:11 | |
| *** brinzhang has quit IRC | 04:14 | |
| *** ociuhandu has joined #openstack-nova | 04:14 | |
| *** ociuhandu has quit IRC | 04:22 | |
| *** ociuhandu has joined #openstack-nova | 04:22 | |
| *** ociuhandu has quit IRC | 04:23 | |
| *** ociuhandu has joined #openstack-nova | 04:25 | |
| *** ociuhandu has quit IRC | 04:34 | |
| *** rchurch has quit IRC | 04:35 | |
| *** ociuhandu has joined #openstack-nova | 04:36 | |
| *** nanzha has quit IRC | 04:40 | |
| *** nanzha has joined #openstack-nova | 04:41 | |
| *** ociuhandu has quit IRC | 04:41 | |
| *** macz has joined #openstack-nova | 04:54 | |
| *** ociuhandu has joined #openstack-nova | 04:54 | |
| *** macz has quit IRC | 04:58 | |
| *** ociuhandu has quit IRC | 04:59 | |
| *** nanzha has quit IRC | 05:00 | |
| *** nanzha has joined #openstack-nova | 05:02 | |
| *** brinzhang has joined #openstack-nova | 05:08 | |
| *** mkrai has joined #openstack-nova | 05:09 | |
| *** brinzhang_ has quit IRC | 05:10 | |
| openstackgerrit | Merged openstack/nova master: api-guide: flesh out BUILD and ACTIVE server create transitions https://review.opendev.org/695771 | 05:12 |
| openstackgerrit | Merged openstack/nova master: api-guide: fix the file injection considerations drift https://review.opendev.org/695773 | 05:13 |
| *** udesale has joined #openstack-nova | 05:27 | |
| *** ratailor has joined #openstack-nova | 05:30 | |
| *** ociuhandu has joined #openstack-nova | 05:30 | |
| *** ociuhandu has quit IRC | 05:35 | |
| *** pots has quit IRC | 05:39 | |
| *** pots has joined #openstack-nova | 05:39 | |
| *** brinzhang_ has joined #openstack-nova | 05:40 | |
| *** brinzhang has quit IRC | 05:43 | |
| *** jistr has quit IRC | 05:51 | |
| *** jistr has joined #openstack-nova | 05:56 | |
| *** nanzha has quit IRC | 06:00 | |
| *** jistr has quit IRC | 06:06 | |
| *** jistr has joined #openstack-nova | 06:06 | |
| *** brinzhang has joined #openstack-nova | 06:10 | |
| *** nanzha has joined #openstack-nova | 06:12 | |
| *** brinzhang_ has quit IRC | 06:13 | |
| *** macz has joined #openstack-nova | 06:14 | |
| *** macz has quit IRC | 06:19 | |
| *** nanzha has quit IRC | 06:24 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717 | 06:30 |
| *** nanzha has joined #openstack-nova | 06:36 | |
| *** dpawlik has joined #openstack-nova | 06:46 | |
| *** brinzhang_ has joined #openstack-nova | 06:56 | |
| *** brinzhang has quit IRC | 06:59 | |
| *** rcernin has quit IRC | 07:09 | |
| *** lpetrut has joined #openstack-nova | 07:16 | |
| *** awalende has joined #openstack-nova | 07:16 | |
| *** dtantsur|afk is now known as dtantsur | 07:17 | |
| *** yedongcan has left #openstack-nova | 07:17 | |
| *** slaweq has quit IRC | 07:18 | |
| *** links has joined #openstack-nova | 07:20 | |
| *** awalende has quit IRC | 07:21 | |
| *** nanzha has quit IRC | 07:22 | |
| *** jraju__ has joined #openstack-nova | 07:27 | |
| *** links has quit IRC | 07:28 | |
| *** jangutter has joined #openstack-nova | 07:33 | |
| *** yedongcan has joined #openstack-nova | 07:34 | |
| *** slaweq has joined #openstack-nova | 07:35 | |
| *** ociuhandu has joined #openstack-nova | 07:38 | |
| *** ociuhandu has quit IRC | 07:44 | |
| *** nanzha has joined #openstack-nova | 08:00 | |
| *** tkajinam has quit IRC | 08:06 | |
| *** maciejjozefczyk has joined #openstack-nova | 08:07 | |
| *** tesseract has joined #openstack-nova | 08:16 | |
| bauzas | good morning Nova | 08:19 |
| *** tosky has joined #openstack-nova | 08:21 | |
| *** ccamacho has joined #openstack-nova | 08:25 | |
| *** ccamacho has quit IRC | 08:25 | |
| *** ccamacho has joined #openstack-nova | 08:25 | |
| *** damien_r has joined #openstack-nova | 08:29 | |
| *** macz has joined #openstack-nova | 08:29 | |
| *** awalende has joined #openstack-nova | 08:30 | |
| *** mkrai has quit IRC | 08:31 | |
| *** rpittau|afk is now known as rpittau | 08:33 | |
| *** macz has quit IRC | 08:34 | |
| *** awalende has quit IRC | 08:34 | |
| *** ociuhandu has joined #openstack-nova | 08:35 | |
| *** ociuhandu has quit IRC | 08:40 | |
| *** ratailor_ has joined #openstack-nova | 08:41 | |
| *** awalende has joined #openstack-nova | 08:43 | |
| *** ratailor has quit IRC | 08:43 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909 | 08:44 |
| lyarwood | stephenfin: ^ hope you don't mind, thought I'd sort out the last few failures as the removal came up in RDO over the weekend. | 08:45 |
| *** ociuhandu has joined #openstack-nova | 08:50 | |
| stephenfin | lyarwood: fine by me, but I think it needs to be rebased again | 08:53 |
| stephenfin | "This change depends on a change that failed to merge." | 08:53 |
| lyarwood | stephenfin: ah it's the tempest change? | 08:53 |
| lyarwood | stephenfin: hmm no that's also up to date | 08:54 |
| lyarwood | weird | 08:54 |
| *** ralonsoh has joined #openstack-nova | 08:56 | |
| *** brinzhang has joined #openstack-nova | 08:59 | |
| *** nanzha has quit IRC | 09:00 | |
| *** nanzha has joined #openstack-nova | 09:01 | |
| *** brinzhang_ has quit IRC | 09:01 | |
| *** mns96 has joined #openstack-nova | 09:06 | |
| lyarwood | stephenfin: oh that was my bad, I pushed another PS to the tempest change after pushing the nova change, apologies! | 09:07 |
| lyarwood | recheked | 09:07 |
| lyarwood | rechecked* | 09:07 |
| *** ricolin has quit IRC | 09:16 | |
| *** mkrai has joined #openstack-nova | 09:32 | |
| *** tssurya has joined #openstack-nova | 09:37 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova-specs master: support live migration with virtual persistent memory https://review.opendev.org/695863 | 09:38 |
| *** ociuhandu has quit IRC | 09:40 | |
| *** martinkennelly has joined #openstack-nova | 09:42 | |
| *** derekh has joined #openstack-nova | 09:43 | |
| *** Liang__ has quit IRC | 09:48 | |
| *** ociuhandu has joined #openstack-nova | 09:49 | |
| tssurya | dansmith: whenever you are awake and have some time, review appreciated on this https://review.opendev.org/#/c/689422/ thanks in advance | 09:51 |
| *** ratailor__ has joined #openstack-nova | 09:52 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova-specs master: spec update: virtual persistent memory https://review.opendev.org/695868 | 09:52 |
| *** ociuhandu has quit IRC | 09:54 | |
| *** ratailor_ has quit IRC | 09:55 | |
| *** noonedeadpunk is now known as noonedeadpunk_ | 09:56 | |
| *** noonedeadpunk_ is now known as noonedeadpunk | 09:56 | |
| *** jistr is now known as jistr|afk | 09:58 | |
| *** mkrai has quit IRC | 10:02 | |
| *** takamatsu has quit IRC | 10:05 | |
| *** takamatsu has joined #openstack-nova | 10:06 | |
| openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Use admin neutron client to see if instance has qos ports https://review.opendev.org/694668 | 10:15 |
| stephenfin | dansmith: Could I get some input on RPC versioning issues here, when you're online? https://review.opendev.org/#/c/686814/11 | 10:19 |
| *** jistr|afk is now known as jistr | 10:22 | |
| *** ociuhandu has joined #openstack-nova | 10:31 | |
| *** nanzha has quit IRC | 10:34 | |
| *** ociuhandu has quit IRC | 10:36 | |
| *** nanzha has joined #openstack-nova | 10:38 | |
| *** tobias-urdin has joined #openstack-nova | 10:42 | |
| *** brinzhang_ has joined #openstack-nova | 10:44 | |
| *** brinzhang has quit IRC | 10:47 | |
| *** brinzhang has joined #openstack-nova | 10:49 | |
| *** brinzhang_ has quit IRC | 10:53 | |
| *** awalende_ has joined #openstack-nova | 10:59 | |
| stephenfin | johnthetubaguy: Could you weigh in on https://review.opendev.org/#/c/686814/11/nova/network/rpcapi.py@a211, assuming you know RPC better than I do? | 10:59 |
| *** awalende has quit IRC | 11:02 | |
| *** awalende_ has quit IRC | 11:03 | |
| *** awalende has joined #openstack-nova | 11:04 | |
| *** nanzha has quit IRC | 11:06 | |
| *** nanzha has joined #openstack-nova | 11:06 | |
| *** chenhaw has quit IRC | 11:07 | |
| *** awalende has quit IRC | 11:11 | |
| kashyap | stephenfin: Hi, when you get a moment, want to ACK/NACK these? -- https://review.opendev.org/#/c/694821/3 | 11:11 |
| kashyap | stephenfin: I'd prefer to keep them seperate, although I know they _could_ be squashed. But if that's the "bone of contention" and you insist, can squash :-) | 11:12 |
| *** brinzhang_ has joined #openstack-nova | 11:13 | |
| *** pcaruana has joined #openstack-nova | 11:14 | |
| *** brinzhang has quit IRC | 11:16 | |
| *** yedongcan has left #openstack-nova | 11:22 | |
| *** ociuhandu has joined #openstack-nova | 11:23 | |
| *** openstack has joined #openstack-nova | 11:53 | |
| *** ChanServ sets mode: +o openstack | 11:53 | |
| *** irclogbot_3 has joined #openstack-nova | 11:53 | |
| *** mkrai has quit IRC | 11:54 | |
| *** ociuhandu has joined #openstack-nova | 11:54 | |
| *** awalende has joined #openstack-nova | 11:56 | |
| *** nanzha has quit IRC | 12:03 | |
| *** nanzha has joined #openstack-nova | 12:04 | |
| *** mkrai has joined #openstack-nova | 12:05 | |
| *** elod_ is now known as elod | 12:05 | |
| *** mkrai has quit IRC | 12:14 | |
| *** brinzhang has joined #openstack-nova | 12:14 | |
| *** brinzhang_ has quit IRC | 12:17 | |
| *** nanzha has quit IRC | 12:18 | |
| *** mkrai has joined #openstack-nova | 12:21 | |
| *** artom has joined #openstack-nova | 12:23 | |
| *** brinzhang_ has joined #openstack-nova | 12:29 | |
| *** nanzha has joined #openstack-nova | 12:29 | |
| *** dave-mccowan has joined #openstack-nova | 12:30 | |
| sean-k-mooney | stephenfin: can you take a look at https://review.opendev.org/#/c/674072/ today if you get a chance | 12:32 |
| *** mdbooth_ has quit IRC | 12:32 | |
| *** brinzhang has quit IRC | 12:32 | |
| *** ratailor__ has quit IRC | 12:34 | |
| *** dave-mccowan has quit IRC | 12:35 | |
| *** nanzha has quit IRC | 12:36 | |
| *** nanzha has joined #openstack-nova | 12:37 | |
| *** mdbooth has joined #openstack-nova | 12:40 | |
| *** shilpasd has joined #openstack-nova | 12:40 | |
| *** brinzhang has joined #openstack-nova | 12:43 | |
| *** brinzhang_ has quit IRC | 12:46 | |
| *** damien_r has quit IRC | 12:46 | |
| *** brinzhang_ has joined #openstack-nova | 12:47 | |
| *** brinzhang has quit IRC | 12:48 | |
| gibi | sean-k-mooney, mriedem: hi! do we have live migration functional tests where the server has at least on neutron port? did we added such functional test when the bp neutron-new-port-binding-api has been implemented? | 12:51 |
| gibi | s/at least on/at least one/ | 12:51 |
| *** lpetrut has joined #openstack-nova | 12:53 | |
| kashyap | gibi: Hi, any chance you can have a look at this low-hanging-fruit (that lets us clean up dead code): https://review.opendev.org/#/q/topic:Bump_min_libvirt_and_QEMU_for_Ussuri+(status:open+OR+status:merged) | 12:55 |
| sean-k-mooney | gibi: i would have to check but i dont think the neutron fixture implements the multiple port bindigns workflow | 12:56 |
| * kashyap is trying to get things off his plate before his long PTO in Dec 2nd week starts... | 12:56 | |
| sean-k-mooney | gibi: so i dont think we ahve live migration test that succeed. | 12:56 |
| sean-k-mooney | we have 2 negitive tests i belive | 12:57 |
| gibi | kashyap: added to my list but no promises for today | 12:57 |
| kashyap | gibi: No worries, this week is fine; it's also advertized on the mailing list, etc. (FWIW.) | 12:57 |
| gibi | sean-k-mooney: cool, then I understand why my test with qos + live migration fails with the neutron fixture with vif plug timeout | 12:58 |
| gibi | sean-k-mooney: thanks. I think I will try to enhance the NeutronFixture to cover live migration with qos | 12:58 |
| tobias-urdin | do i understand it correctly that nova refreshes the rbd in the libvirt XML by *adding any new* monitors to the config based on the image backend/connection_info from cinder but doesn't purge old entries? And that this patch tries to make sure it completely refreshes the entries by clearing it and adding the existing ones back in? https://review.opendev.org/#/c/579004/ | 12:59 |
| sean-k-mooney | gibi: right i dont think you wll get the network-vif-plugged event | 13:01 |
| gibi | sean-k-mooney: yeah, now I was able to make an existing test fail with the same problem by simply adding networks="auto" to the boot request | 13:03 |
| sean-k-mooney | that would normally be set by the ovs agent once that tap is create by libvirt. so you need to mock out the activate binding api endpoint in the fixture to send the vif plugged event to neutron | 13:04 |
| gibi | sean-k-mooney: ack | 13:04 |
| gibi | thanks | 13:04 |
| sean-k-mooney | *form neutorn to nova | 13:05 |
| sean-k-mooney | it would be useful to have that by they way | 13:05 |
| sean-k-mooney | so thanks for taking a look at adding it | 13:05 |
| sean-k-mooney | gibi: on a related note did any of the neutron folks respond on that tread regarding backport the agent changes for finding the RP | 13:06 |
| gibi | sean-k-mooney: not yet. I have a face 2 face discussion with rubasov this morning. I hope he will reply at some point | 13:07 |
| gibi | s/have/had/ | 13:07 |
| sean-k-mooney | ok i can poke some of the redhat folks too to comment on it | 13:08 |
| *** tbachman has joined #openstack-nova | 13:11 | |
| *** nanzha has quit IRC | 13:12 | |
| *** brinzhang has joined #openstack-nova | 13:14 | |
| *** brinzhang_ has quit IRC | 13:16 | |
| *** nanzha has joined #openstack-nova | 13:17 | |
| *** mvkr has quit IRC | 13:19 | |
| *** zbr_ has joined #openstack-nova | 13:19 | |
| *** zbr has quit IRC | 13:22 | |
| *** nanzha has quit IRC | 13:24 | |
| *** nanzha has joined #openstack-nova | 13:30 | |
| gibi | sean-k-mooney: I opened a neutron bug https://bugs.launchpad.net/neutron/+bug/1853840 | 13:33 |
| openstack | Launchpad bug 1853840 in neutron "Neutron fails to create bandwidth providers if CONF.host is set" [Undecided,New] | 13:33 |
| *** damien_r has joined #openstack-nova | 13:33 | |
| sean-k-mooney | gibi: thanks flagged this internally they will try to discuss it in the neutron team meeting if they have time | 13:34 |
| *** mriedem has joined #openstack-nova | 13:37 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event https://review.opendev.org/695900 | 13:40 |
| stephenfin | sean-k-mooney: Sure, I can do that | 13:41 |
| stephenfin | sean-k-mooney: out of curiosity, am I correct in assuming the firewall implementations found in nova only apply when using nova-network? | 13:41 |
| sean-k-mooney | yes | 13:42 |
| stephenfin | cool | 13:42 |
| stephenfin | Deeeeeelete. | 13:42 |
| sean-k-mooney | although we used to have some anit spoof rules we enforced | 13:42 |
| sean-k-mooney | we should be useing the noop driver when using neutron for like 3 years at this point | 13:42 |
| stephenfin | that's what I was thinking | 13:43 |
| sean-k-mooney | it was ok to haver it enabled for a time but the allowed adress paris extentaion in neutron allow the vm ot have multipel mac and ip addresses on a singel port | 13:44 |
| sean-k-mooney | and the nova anti spoof rules dont know about those | 13:44 |
| sean-k-mooney | so since that was added you shoudl disable teh nova ones and rely on neutrons | 13:44 |
| *** jaosorior has joined #openstack-nova | 13:47 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_KVM_AARCH64_VERSION https://review.opendev.org/695901 | 13:48 |
| gibi | sean-k-mooney: thanks | 13:48 |
| kashyap | Whoops, I linked to the wrong Change-Id, /me updates... | 13:49 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_KVM_AARCH64_VERSION https://review.opendev.org/695901 | 13:50 |
| *** KeithMnemonic has joined #openstack-nova | 13:54 | |
| *** nanzha has quit IRC | 13:56 | |
| *** nanzha has joined #openstack-nova | 13:58 | |
| *** brinzhang_ has joined #openstack-nova | 14:02 | |
| *** brinzhang has quit IRC | 14:04 | |
| *** brinzhang_ has quit IRC | 14:07 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905 | 14:08 |
| *** jcosmao has joined #openstack-nova | 14:09 | |
| mriedem | dansmith: you might want to weigh in on this https://review.opendev.org/#/c/686814/11/nova/network/rpcapi.py | 14:10 |
| mriedem | the client rpc api methods being removed are not called from anywhere, but that add_network_to_project one just looks weird since it never used a version | 14:10 |
| shilpasd | gibi: hi, how i can edit agenda for next nova meeting 'https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting'? | 14:11 |
| gibi | shilpasd: you can edit the wiki and add your item to the agenda. please add your name as well to know who to ping on the meeting | 14:12 |
| gibi | shilpasd: you can add to the Open discussion topic | 14:13 |
| shilpasd | gibi: thanks will check that | 14:15 |
| mriedem | stephenfin: on https://review.opendev.org/#/c/686816/ you remove the nova-network binary but not the actual module code until nova/network/* - is that coming in later changes? | 14:16 |
| mriedem | *under nova/network | 14:16 |
| stephenfin | mriedem: Correct | 14:16 |
| stephenfin | there's a _lot_ of unwinding to be done before I can remove all of that | 14:16 |
| *** jdillaman has joined #openstack-nova | 14:16 | |
| stephenfin | :( | 14:16 |
| mriedem | so basically a lot of small(ish) patches like https://review.opendev.org/#/c/686814/ ? | 14:16 |
| stephenfin | for the most part, yeah | 14:17 |
| stephenfin | currently working on stripping out the firewall feature. That's a beefy one | 14:17 |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_QEMU_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/695915 | 14:17 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-guide: flesh out flavor extra specs and image properties https://review.opendev.org/695776 | 14:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-guide: flesh out networking concepts https://review.opendev.org/695777 | 14:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-guide: flesh out todos in user doc https://review.opendev.org/695778 | 14:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: remove admin/manage-users https://review.opendev.org/695779 | 14:19 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: api-guide: remove empty sections about inter-service interactions https://review.opendev.org/695774 | 14:19 |
| *** READ10 has joined #openstack-nova | 14:25 | |
| *** jraju__ has quit IRC | 14:32 | |
| *** KeithMnemonic has quit IRC | 14:33 | |
| mriedem | anyone remember where the hard 64kib limit on injected_file_content_bytes is enforced? | 14:38 |
| dansmith | mriedem: isn't it on the implied size of the text field in the db? | 14:39 |
| mriedem | i guess i was thinking user_data | 14:39 |
| mriedem | https://docs.openstack.org/nova/latest/user/metadata.html#metadata-userdata | 14:39 |
| dansmith | oh right right | 14:39 |
| mriedem | https://bugs.launchpad.net/nova/+bug/1853635 | 14:41 |
| openstack | Launchpad bug 1853635 in OpenStack Compute (nova) "Config_drive file throws Request is too large" [Undecided,New] | 14:41 |
| mriedem | was trying to triage that | 14:41 |
| sean-k-mooney | we have a downstream bug for that i think that got reported like 2 weeks ago | 14:44 |
| sean-k-mooney | ill see if i can find it | 14:44 |
| sean-k-mooney | artom: you were looking at ^ with dvd or dhill 2 weeks ago right | 14:46 |
| artom | sean-k-mooney, it rings a bell | 14:48 |
| artom | With dhill, though I don't know how that ended | 14:48 |
| artom | The logging made no sense | 14:48 |
| artom | It was a 413, but no other details in the API logs | 14:49 |
| artom | Which were in debug | 14:49 |
| artom | So it made me think maybe a middleware somewhere was doing it | 14:49 |
| artom | And I think efried as kind enough to offer to help since he had played with paste | 14:49 |
| artom | ... and then we all forgot about it | 14:49 |
| sean-k-mooney | i think we found a place where there awas a hardcoded limit | 14:49 |
| efried | still happy to help there, lmk what you need | 14:50 |
| artom | efried, ack, appreciated :) | 14:50 |
| artom | Though at this point we're still speculatively rambling, methinks | 14:50 |
| *** tbachman has quit IRC | 14:51 | |
| sean-k-mooney | i cant find it in my history or via BZ so i dont know if i still have the data on it | 14:53 |
| artom | sean-k-mooney, did he ever actually file a bz though? | 14:53 |
| artom | I'll ask | 14:53 |
| sean-k-mooney | maybe not that could be why i cant find it | 14:54 |
| *** tbachman has joined #openstack-nova | 14:54 | |
| fungi | quick question, mhen mentioned in the image encryption pop-up team meeting an hour ago that during the ptg some nova folks were discussing the spec reproposal with luzi and suggested that they wanted someone to fix ephemeral disk encryption to use luks before adding image encryption support. this is all third-hand so i'm sure i'm missing a bunch of details, but curious if anyone can fill in the gaps | 14:55 |
| fungi | there (the two features don't, at face value, seem to be directly related to one another) | 14:55 |
| fungi | http://eavesdrop.openstack.org/meetings/image_encryption/2019/image_encryption.2019-11-25-13.00.log.html | 14:55 |
| sean-k-mooney | fungi: you want to speak to mdbooth | 14:56 |
| fungi | ahh, so he's working on overhauling ephemeral disk encryption in nova? | 14:57 |
| sean-k-mooney | fungi: mdbooth wanted epmeral disk encryption to be a prequisite for image encryption | 14:57 |
| *** eharney has joined #openstack-nova | 14:57 | |
| sean-k-mooney | im not sure if he is working on it or not | 14:57 |
| fungi | got it. does nova use the ephemeral disk subsystem for caching images? | 14:57 |
| fungi | i'm just trying to understand the interrelationship | 14:57 |
| sean-k-mooney | but he felt strongly that have enycpeted image in galce that were stored in non encyped form on the hypervior was not very useful | 14:58 |
| fungi | so you're saying the images when they get stored on the hypervisor use the ephemeral disk mechanism? | 14:58 |
| sean-k-mooney | in the libvirt case the root disk is storead as a qcow or raw file on the host by defualt | 14:59 |
| sean-k-mooney | with both a cache of the iamge and a backing file in the qcow case | 14:59 |
| fungi | so what does that have to do with the ephemeral disk feature? | 15:00 |
| mriedem | stephenfin: on https://review.opendev.org/#/c/686814/ i tend to think you should just leave the server-side manager stuff alone and leave that for some change at the end of that series where you delete it in a single change | 15:00 |
| mriedem | stephenfin: everything else is just deleting client-side code | 15:00 |
| mriedem | not sure how dansmith feels about that strategy or if it's worthwhiel | 15:00 |
| mriedem | *worthwhile | 15:00 |
| sean-k-mooney | fungi: well qemu cannot execute from a gpg encryped imagae as far as i am aware | 15:00 |
| dansmith | mriedem: ++ | 15:00 |
| sean-k-mooney | fungi: so you would have to decrypt it on the host to be able to boot the vm | 15:00 |
| fungi | sean-k-mooney: got it, so the idea was to decrypt into an encrypted ephemeral disk and then boot that? | 15:01 |
| stephenfin | mriedem, dansmith: what about other changes where there's call to things like virt driver methods? | 15:01 |
| sean-k-mooney | fungi: yes using qemus nataive luks support | 15:01 |
| dansmith | stephenfin: those would be from server methods, so during/after those are removed? | 15:02 |
| sean-k-mooney | fungi: so that you dont have to us dmcrype or something lease hat would mount the disk and decypte it via the kernel | 15:02 |
| stephenfin | um, can you say that again but differently? | 15:02 |
| fungi | sean-k-mooney: so just to make sure i understand the interrelationship, nova boots images from ephemeral disks? or the plan would be to add booting from ephemeral disk? | 15:02 |
| mriedem | fungi: if luks is involved i'd ask lyarwood | 15:03 |
| sean-k-mooney | fungi: by defualt with libvirt nova boots all image from epheral root disk in qcow or raw format | 15:03 |
| sean-k-mooney | unless you are using boot form cinder volume or confire a different iamge backend like ceph | 15:04 |
| fungi | mriedem: well, sounds like luks isn't involved today with ephemeral disks, and that's apparently the objection/prerequisite which was raised | 15:04 |
| sean-k-mooney | fungi: right today we dont support booting with encryped root disk excpu vai that lvm driver i belvie | 15:04 |
| sean-k-mooney | and that has other issues | 15:05 |
| fungi | sean-k-mooney: got it, thanks, so the idea is that for non-boot-from-volume scenarios, to make sure we don't store the retrieved image unencrypted, the ephemeral disk mechanism needs to support an encryption container format which qemu can boot directly | 15:06 |
| *** mvkr has joined #openstack-nova | 15:06 | |
| sean-k-mooney | fungi: yep | 15:06 |
| fungi | perfect, that was the missing connection for me. thanks!!! | 15:06 |
| sean-k-mooney | the current encyped image support declared that out of scope | 15:06 |
| sean-k-mooney | but mdbooth and lyarwood wanted to make it a prerequsite even though its another feature | 15:07 |
| fungi | right, unfortunately i think due to their limited bandwidth they're going to focus on boot-from-volume for now and revisit support in nova later | 15:07 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Improve metadata server performance with large security groups https://review.opendev.org/695925 | 15:07 |
| sean-k-mooney | fungi: my understading is cidner does not currently support booting form an encyped volume either | 15:08 |
| fungi | right, but they're up for moving forward on the spec to add that | 15:08 |
| sean-k-mooney | fungi: mdbooth mentioned somting about that being inded for cinder backups but nova vms | 15:08 |
| sean-k-mooney | *intended | 15:08 |
| fungi | ahh, i'll take a closer look at the cinder spec to confirm | 15:09 |
| sean-k-mooney | *not for nova vms | 15:09 |
| fungi | thanks again | 15:09 |
| lyarwood | sean-k-mooney: we can boot from an encrypted volume | 15:09 |
| * lyarwood reads up | 15:09 | |
| *** ociuhandu has quit IRC | 15:10 | |
| sean-k-mooney | lyarwood: ok but is that only with ceph | 15:10 |
| lyarwood | and yeah, we need to kill off the existing ephemeral disk encryption support in the Libvirt driver before we reintroduce a sane version tbh | 15:10 |
| sean-k-mooney | with isci the volume wouls be mounted on the host | 15:10 |
| lyarwood | sean-k-mooney: nope, that's pretty much any backend | 15:10 |
| lyarwood | sean-k-mooney: nope, that's native | 15:10 |
| lyarwood | sean-k-mooney: native allowed us to support rbd encrypted volumes for the first time | 15:11 |
| lyarwood | sean-k-mooney: everything else was already supported and just switched to being native within QEMU in Queens | 15:11 |
| sean-k-mooney | lyarwood: ok | 15:11 |
| *** awalende has quit IRC | 15:11 | |
| aarents | mriedem: hi, can you confirm that commit message is ok like tht https://review.opendev.org/#/c/670000/ it was the last blocking point. | 15:12 |
| *** tbachman has quit IRC | 15:12 | |
| sean-k-mooney | but we do still mont the voluems on the host via the kernel right they are just but encypeted? | 15:12 |
| sean-k-mooney | lyarwood: im asking because fo the local caching spec | 15:12 |
| sean-k-mooney | that was implying that iscsi based volumes are mounted on the host and passed to qemu as a block deice wo they could add a caching layer | 15:13 |
| lyarwood | sean-k-mooney: yeah so for iSCSI/LVM etc we still end up with host devices but these are never decrypted on the host now | 15:13 |
| sean-k-mooney | i assume we use qemus native encryption support to use the encyped volumes form teh host | 15:14 |
| sean-k-mooney | cool | 15:14 |
| sean-k-mooney | fungi: so basicly we would like to get to the same state for non boot form volume guests | 15:14 |
| * lyarwood should really write a spec for this | 15:15 | |
| *** awalende has joined #openstack-nova | 15:16 | |
| *** awalende has quit IRC | 15:17 | |
| mriedem | lyarwood: do we even have *any* in-tree docs about encryption features in nova today? | 15:18 |
| mriedem | would probably be good to level set from there | 15:18 |
| lyarwood | mriedem: do releasenotes count /s | 15:19 |
| mriedem | no | 15:19 |
| lyarwood | aww, okay then no | 15:19 |
| lyarwood | mriedem: and yeah that's a valid point | 15:19 |
| mriedem | i hope you already knew the answer to that | 15:19 |
| *** jdillaman has quit IRC | 15:19 | |
| lyarwood | mriedem: https://www.urbandictionary.com/define.php?term=%2Fs yarp I did sorry | 15:20 |
| *** tbachman has joined #openstack-nova | 15:20 | |
| mriedem | you should have jk lol'ed me with a winking smiley | 15:21 |
| mriedem | that's more my speed | 15:21 |
| fungi | lyarwood: sean-k-mooney: mriedem: thanks a bunch, that's all very useful info | 15:21 |
| lyarwood | I'll fire a few roflcopters next time mriedem :) | 15:22 |
| fungi | and a lolercoaster for good measure? | 15:22 |
| lyarwood | rude not to | 15:23 |
| mriedem | lol ;P | 15:24 |
| * artom lmaos | 15:24 | |
| *** kaliya has joined #openstack-nova | 15:28 | |
| *** kaliya has quit IRC | 15:31 | |
| mriedem | aarents: dansmith: +2 https://review.opendev.org/#/c/670000/ | 15:34 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional recreate test for bug 1829479 and bug 1817833 https://review.opendev.org/695932 | 15:41 |
| openstack | bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,In progress] https://launchpad.net/bugs/1829479 - Assigned to Matt Riedemann (mriedem) | 15:41 |
| openstack | bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] https://launchpad.net/bugs/1817833 - Assigned to Matt Riedemann (mriedem) | 15:41 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Test openstacksdk weakrefs https://review.opendev.org/695934 | 15:45 |
| *** jaosorior has quit IRC | 15:45 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional recreate test for bug 1852610 https://review.opendev.org/695935 | 15:48 |
| openstack | bug 1852610 in OpenStack Compute (nova) stein "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Undecided,New] https://launchpad.net/bugs/1852610 | 15:48 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Add functional recreate revert resize test for bug 1852610 https://review.opendev.org/695938 | 15:53 |
| openstack | bug 1852610 in OpenStack Compute (nova) stein "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Undecided,New] https://launchpad.net/bugs/1852610 | 15:53 |
| *** macz has joined #openstack-nova | 15:56 | |
| *** macz has quit IRC | 15:56 | |
| *** ociuhandu has joined #openstack-nova | 15:58 | |
| *** ociuhandu has quit IRC | 16:03 | |
| *** jaosorior has joined #openstack-nova | 16:04 | |
| *** _mlavalle_1 has joined #openstack-nova | 16:04 | |
| *** tbachman has quit IRC | 16:05 | |
| *** mlavalle has quit IRC | 16:07 | |
| *** mkrai has quit IRC | 16:09 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Block deleting compute services with in-progress migrations https://review.opendev.org/695940 | 16:14 |
| *** openstackstatus has joined #openstack-nova | 16:15 | |
| *** ChanServ sets mode: +v openstackstatus | 16:15 | |
| *** nanzha has quit IRC | 16:18 | |
| openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_FILE_BACKED_VERSION https://review.opendev.org/695942 | 16:21 |
| *** shilpasd has quit IRC | 16:28 | |
| aarents | mriedem: thanks | 16:30 |
| *** aloga has quit IRC | 16:33 | |
| *** aloga has joined #openstack-nova | 16:33 | |
| *** ircuser-1 has joined #openstack-nova | 16:37 | |
| mriedem | could i get a couple of stable cores to look at these https://review.opendev.org/#/q/topic:bug/1849409+branch:stable/rocky ? | 16:38 |
| *** rpittau is now known as rpittau|afk | 16:40 | |
| lyarwood | mriedem: ack looking | 16:40 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815 | 16:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-network' binary https://review.opendev.org/686816 | 16:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Blast most references to nova-network https://review.opendev.org/686817 | 16:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs https://review.opendev.org/686814 | 16:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP https://review.opendev.org/686818 | 16:44 |
| *** dtantsur is now known as dtantsur|afk | 16:44 | |
| gibi | sean-k-mooney: heads up, as the neutron meeting is at the US slot this week I won't be awake | 16:48 |
| *** lpetrut has quit IRC | 16:51 | |
| lyarwood | stephenfin: https://review.opendev.org/#/q/topic:bug/1853495 - would you mind taking a look at this today if you have time? | 16:51 |
| stephenfin | yup, burning through some reviews atm | 16:52 |
| *** dklyle has quit IRC | 16:53 | |
| *** dklyle has joined #openstack-nova | 16:54 | |
| *** tbachman has joined #openstack-nova | 16:54 | |
| mriedem | lyarwood: questoin in that nova change | 16:54 |
| lyarwood | mriedem: I think the ref is wrong or cinderclient changes it, let me grep around and confirm. | 16:55 |
| *** udesale has quit IRC | 16:57 | |
| lyarwood | mriedem: https://github.com/openstack/nova/blob/6fea2682364cddf66c499936a8c66895ef94dd5b/nova/volume/cinder.py#L313 - my bad, it's us. | 16:58 |
| mriedem | https://github.com/openstack/cinder/blob/62b69b51aab32500d3aa76677011f9db4bf4c14c/cinder/api/v2/views/volumes.py#L81 | 16:58 |
| stephenfin | lyarwood, mriedem: looks like we do funky stuff in nova/volume/cinder.py via '_untranslate_volume_summary_view' | 16:58 |
| mriedem | ah | 16:58 |
| stephenfin | nice | 16:58 |
| *** tssurya has quit IRC | 17:00 | |
| openstackgerrit | Merged openstack/nova master: api-guide: flesh out flavor extra specs and image properties https://review.opendev.org/695776 | 17:05 |
| openstackgerrit | Merged openstack/nova master: api-guide: flesh out networking concepts https://review.opendev.org/695777 | 17:05 |
| openstackgerrit | Merged openstack/nova master: api-guide: flesh out todos in user doc https://review.opendev.org/695778 | 17:05 |
| mriedem | lyarwood: some questions in there | 17:06 |
| lyarwood | mriedem: looking | 17:06 |
| mriedem | so volume_type on volume create is optional and if not specified the cinder scheduler picks one (and there is a default backend), | 17:07 |
| mriedem | the api-ref talks a bit about when volume_type is required but doesn't mention for encrypted volumes built from snapshots, which volume_type is clearly required due to the bug | 17:07 |
| mriedem | i'm just wondering if we should only pass the volume_type if the original volume was encrypted=True | 17:08 |
| mriedem | i might have answered my own question though, | 17:09 |
| mriedem | i don't think you can delete a volume type in cinder while there are volumes using it, | 17:09 |
| mriedem | and i don't think you can delete a volume that has snapshots | 17:09 |
| mriedem | smcginnis: ^? | 17:09 |
| lyarwood | yeah you can't I was just checking that | 17:09 |
| *** jcosmao has left #openstack-nova | 17:09 | |
| lyarwood | and again yes AFAIK you can't remove volumes with snapshots | 17:09 |
| lyarwood | so copying over volume_type from the original if one isn't provided should be safe | 17:10 |
| mriedem | so maybe this is fine and if it turns out there is some weird problem later we fix that as necessary | 17:10 |
| mriedem | i'm guessing you'll want to backport this too so hopefully we're all good | 17:10 |
| lyarwood | yup indeed, I tried to keep it as self contained as possible | 17:11 |
| *** awalende has joined #openstack-nova | 17:12 | |
| *** jcosmao has joined #openstack-nova | 17:15 | |
| *** jaosorior has quit IRC | 17:16 | |
| *** awalende has quit IRC | 17:17 | |
| smcginnis | mriedem: Correct. | 17:18 |
| smcginnis | Don't have the full context here, but the plan described sounds good to me. | 17:18 |
| *** igordc has joined #openstack-nova | 17:18 | |
| *** damien_r has quit IRC | 17:19 | |
| *** takamatsu has quit IRC | 17:27 | |
| *** FlorianFa has quit IRC | 17:29 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing os-services policies https://review.opendev.org/669181 | 17:30 |
| openstackgerrit | Merged openstack/nova stable/stein: Use admin neutron client to see if instance has qos ports https://review.opendev.org/694668 | 17:32 |
| *** takamatsu has joined #openstack-nova | 17:32 | |
| mriedem | stephenfin: you should fix this in your series somewhere https://review.opendev.org/#/c/686816/12/doc/source/install/get-started-compute.rst@28 | 17:40 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-services https://review.opendev.org/645427 | 17:45 |
| gmann | johnthetubaguy: did not get this comment. we can re-use the check_str itself - https://review.opendev.org/#/c/645452/14/nova/policies/base.py@69 | 17:52 |
| * johnthetubaguy has a look | 17:52 | |
| johnthetubaguy | gmann: the use case I was thinking about is having a nova specific read only role, its nice if that only needs one rule changing | 17:53 |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | 17:57 |
| *** tesseract has quit IRC | 17:57 | |
| gmann | johnthetubaguy: and the currently defined check_str like SYSTEM_READER use those rule instead of direct check_str ? | 17:59 |
| *** jaosorior has joined #openstack-nova | 17:59 | |
| *** macz has joined #openstack-nova | 18:03 | |
| gmann | johnthetubaguy: got it. i did not think the override case. | 18:04 |
| johnthetubaguy | gmann: no worries, we could in theory add it later, but probably good to add it from the start | 18:05 |
| *** derekh has quit IRC | 18:05 | |
| gmann | yeah. | 18:05 |
| *** tbachman has quit IRC | 18:18 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default rules and mapping in policy base class https://review.opendev.org/645452 | 18:29 |
| *** martinkennelly has quit IRC | 18:30 | |
| *** mns96 has quit IRC | 18:36 | |
| *** tbachman has joined #openstack-nova | 18:39 | |
| *** igordc has quit IRC | 18:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Suppress policy deprecated warnings in tests https://review.opendev.org/676670 | 18:43 |
| *** ociuhandu has joined #openstack-nova | 18:45 | |
| *** cmorpheus is now known as cmurphy | 18:50 | |
| *** ociuhandu has quit IRC | 18:51 | |
| *** mriedem has quit IRC | 18:52 | |
| *** mriedem has joined #openstack-nova | 18:52 | |
| *** ociuhandu has joined #openstack-nova | 18:52 | |
| *** ralonsoh has quit IRC | 18:58 | |
| gmann | johnthetubaguy: for new policy rule added due to granularity, new name should be fine right? we decided not to change name for any existing policy - https://review.opendev.org/#/c/648480/18/nova/policies/services.py@22 | 19:00 |
| *** maciejjozefczyk has quit IRC | 19:01 | |
| efried | kashyap: Forgive me if you've already had this argument^Wdiscussion with stephenfin, but why are we not squashing at least the three "remove MIN_*" patches into the bump patch? | 19:07 |
| efried | to me, "do X and get rid of dead code that was made obsolete by X" counts as "one logical change". | 19:08 |
| efried | "I did it separately as it cleanly highlights that we consciously picked those versions based on distro research. If we squash it in, the intention just gets buried in this noise." meh meh meh | 19:10 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Remove stale BDMs on reserve_block_device_name failure https://review.opendev.org/682594 | 19:17 |
| *** eharney has quit IRC | 19:18 | |
| *** macz has quit IRC | 19:21 | |
| * efried feeds | 19:21 | |
| *** mriedem has quit IRC | 19:24 | |
| *** ociuhandu has quit IRC | 19:32 | |
| *** mriedem has joined #openstack-nova | 19:33 | |
| *** ociuhandu has joined #openstack-nova | 19:33 | |
| *** ociuhandu has quit IRC | 19:38 | |
| *** jdillaman has joined #openstack-nova | 19:38 | |
| *** READ10 has quit IRC | 19:43 | |
| openstackgerrit | Merged openstack/nova stable/queens: Don't delete compute node, when deleting service other than nova-compute https://review.opendev.org/695383 | 19:50 |
| openstackgerrit | Merged openstack/nova stable/rocky: Add functional regression test for bug 1849409 https://review.opendev.org/690720 | 19:50 |
| openstack | bug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | 19:50 |
| *** igordc has joined #openstack-nova | 19:55 | |
| *** eharney has joined #openstack-nova | 20:32 | |
| dansmith | artom: when I pay you to just agree with all my review comments, you're supposed to make it look non-obvious | 20:33 |
| artom | dansmith, ok, 0. You don't pay nearly enough. 1. I only agreed on one thing. 2. I disagreed on the big thing. | 20:37 |
| dansmith | artom: each comment was like "I agree with Dan and his bribe money, ...." :P | 20:38 |
| artom | dansmith, either I misunderstood you, or you misunderstood me. | 20:39 |
| artom | I thought you were saying you don't want the workaround conf option approach. I'm saying the "real" fix isn't backportable, so OK. | 20:39 |
| *** macz has joined #openstack-nova | 20:46 | |
| *** igordc has quit IRC | 20:47 | |
| *** ociuhandu has joined #openstack-nova | 20:50 | |
| dansmith | artom: no, I know | 20:51 |
| *** igordc has joined #openstack-nova | 20:53 | |
| artom | dansmith, but seriously, "subtlety" is only available in the Premium package, you need to upgrade | 20:54 |
| dansmith | I'm calling my credit card company | 20:55 |
| artom | *snerk* | 20:56 |
| artom | "I'd like to charge back these bribes I made" | 20:57 |
| artom | "Turns out corruption isn't the panacea I was hoping for." | 20:57 |
| dansmith | sounds legit to me, I'm sure they've got my back | 21:00 |
| dansmith | just like reporting that your dealer to the cops when he stiffed you on the dime bag | 21:00 |
| *** READ10 has joined #openstack-nova | 21:10 | |
| *** ociuhandu has quit IRC | 21:11 | |
| *** ociuhandu has joined #openstack-nova | 21:12 | |
| *** spatel has joined #openstack-nova | 21:15 | |
| *** ociuhandu has quit IRC | 21:17 | |
| artom | Hey man, get with the advanced countries, my dealer's *the government* | 21:17 |
| mriedem | artom: dansmith: i've tl;dr'ed the patch, i need someone to ack on the path forward because i'm getting mixed messages on the nova changes and the os-traits change from efried | 21:22 |
| mriedem | if it's more work than it's worth i'll just abandon all of it and let the bugs continue to get opened | 21:22 |
| efried | what are we talking about? | 21:24 |
| artom | mriedem, I obviously don't have +/-2 powers, but seems like a simple enough patch, so if it fixes some people's issues, don't see why not | 21:24 |
| artom | Sure, it's not the prettiest thing I've ever seen, but... frankly, neither is most of Nova :P | 21:25 |
| *** spatel has quit IRC | 21:26 | |
| mriedem | efried: https://review.opendev.org/#/q/topic:bug/1748697+(status:open+OR+status:merged) | 21:27 |
| mriedem | artom: as for pretty, you try having hundreds (thousands?) of random people put their dirty fingers all over you for 10 years and see how pretty you are | 21:28 |
| artom | mriedem, oh, I fully understand *why* | 21:29 |
| mriedem | (apparently 989 contributors according to github) | 21:29 |
| mriedem | i've long advocated for py black pre-commit hooks but just no one else wants it :) | 21:30 |
| *** rcernin has joined #openstack-nova | 21:31 | |
| *** pcaruana has quit IRC | 21:38 | |
| artom | Oh this is weird... | 21:40 |
| artom | I'm triaging a downstream bug related to external events | 21:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add functional regression test for bug 1849409 https://review.opendev.org/690724 | 21:41 |
| openstack | bug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | 21:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix listing deleted servers with a marker https://review.opendev.org/690725 | 21:41 |
| artom | 17:34:14.868 No waiting events found dispatching network-vif-plugged-3dccb72d-c922-4032-8f34-d7421fe2cff6 | 21:41 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add a way to exit early from a wait_for_instance_event() https://review.opendev.org/695985 | 21:41 |
| dansmith | efried: ^ | 21:41 |
| artom | 17:33:48.037 | 21:41 |
| efried | dansmith: ack | 21:41 |
| artom | 17:33:48.037 Preparing to wait for external event network-vif-plugged-3dccb72d-c922-4032-8f34-d7421fe2cff6 | 21:41 |
| artom | So I guess something is consuming those events before? | 21:42 |
| artom | Sorry for rubber-ducking y'all | 21:42 |
| dansmith | artom: mriedem: remember the race-to-wait-for-event stuff with neutron and migration? | 21:43 |
| dansmith | the patch I just pushed up would probably have helped us | 21:43 |
| mriedem | how could i forget | 21:43 |
| artom | dansmith, I do, but this isn't it. It's boot. | 21:43 |
| dansmith | artom: yep, talking about that other thing | 21:43 |
| artom | dansmith, ack, yeah | 21:43 |
| artom | Looking | 21:43 |
| dansmith | lots of event'n going on today | 21:43 |
| dansmith | I don't remember the exact details of the neutron thing, but if we could have checked with one poll to see if a thing was done, we could have used this to safely be graceful about when the events show up and not lose our race-proof-ness | 21:46 |
| dansmith | I think it was coming early for some backends, which is what this is about | 21:46 |
| *** abaindur has joined #openstack-nova | 21:46 | |
| artom | dansmith, I haven't grokked your patch fully, but I'm not sure about that. We were getting the events *before* we even started waiting for them | 21:47 |
| dansmith | right, that's what this is for | 21:47 |
| dansmith | we're about to have a situation where for cyborg, an event could come before we're ready to wait for it | 21:47 |
| dansmith | and we want to be able to handle that good situation (work is done before we have to stop and wait) without losing our race-proof-ness | 21:47 |
| *** takashin has joined #openstack-nova | 21:48 | |
| artom | Oh, that's your second para in the commit message | 21:51 |
| mriedem | artom: we were getting them before we were waiting b/c the compute manager updating the port binding which trigggered the event before the driver's finish_revert_migration or whatever registered the event listener | 21:51 |
| mriedem | so, we do control what was triggering the event | 21:51 |
| artom | mriedem, yep | 21:52 |
| dansmith | mriedem: I thought there was some component of it where we weren't use based on vif type if it came early or late? but maybe I'm remembering one of the reverted attempts? | 21:52 |
| dansmith | s/use/sure/ | 21:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add functional regression test for bug 1849409 https://review.opendev.org/690734 | 21:52 |
| openstack | bug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | 21:52 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix listing deleted servers with a marker https://review.opendev.org/690735 | 21:52 |
| mriedem | we do base it on vif type or something | 21:53 |
| dansmith | ack, well, anyway, if we _can_ get in front of it, that's better obviously | 21:53 |
| mriedem | https://github.com/openstack/nova/blob/ee25a82c2c1c12b0e290ed524e4d66b1a8a7a500/nova/compute/manager.py#L4459 | 21:53 |
| * artom is not going down that road again. | 21:53 | |
| artom | (That apparently broke Midonet, for unclear reasons: https://review.opendev.org/#/c/675021/) | 21:54 |
| *** _mlavalle_1 has quit IRC | 21:56 | |
| *** mlavalle has joined #openstack-nova | 21:56 | |
| mriedem | can i abandon that yet? | 21:59 |
| mriedem | if they don't care enough to pursue since oct 1 it must not be a big deal | 22:00 |
| * artom won't complain | 22:01 | |
| artom | daycare taxi time | 22:02 |
| mriedem | done | 22:03 |
| mriedem | you should crank up the space truckin' organ solo from made in japan for the kiddies | 22:04 |
| efried | dansmith: Reviewed, thanks for putting that together. | 22:04 |
| *** slaweq has quit IRC | 22:06 | |
| *** mriedem has quit IRC | 22:17 | |
| *** threestrands has joined #openstack-nova | 22:22 | |
| *** KeithMnemonic has joined #openstack-nova | 22:41 | |
| openstackgerrit | Takashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043 | 22:42 |
| openstackgerrit | Merged openstack/nova master: Pick NEXT_MIN libvirt/QEMU versions for "V" release https://review.opendev.org/694821 | 22:47 |
| *** slaweq has joined #openstack-nova | 22:49 | |
| *** tkajinam has joined #openstack-nova | 23:09 | |
| *** slaweq has quit IRC | 23:10 | |
| *** abaindur has quit IRC | 23:10 | |
| *** abaindur has joined #openstack-nova | 23:11 | |
| *** abaindur has quit IRC | 23:11 | |
| *** abaindur has joined #openstack-nova | 23:11 | |
| *** abaindur has joined #openstack-nova | 23:13 | |
| *** mlavalle has quit IRC | 23:26 | |
| *** ociuhandu has joined #openstack-nova | 23:30 | |
| *** kaisers1 has quit IRC | 23:31 | |
| *** jaosorior has quit IRC | 23:33 | |
| *** kaisers has joined #openstack-nova | 23:34 | |
| *** ociuhandu has quit IRC | 23:35 | |
| *** tosky has quit IRC | 23:36 | |
| openstackgerrit | Eric Fried proposed openstack/nova-specs master: Spec: Ussuri: Encrypted Emulated Virtual TPM https://review.opendev.org/686804 | 23:41 |
| efried | dansmith: Simplified this ^ by restricting backup of vTPM data to only shelve and backup. Reasoning and effects are explained in the spec. It actually simplifies things considerably. I think with proper documentation, this is the happy middle ground. | 23:42 |
| *** jcosmao has left #openstack-nova | 23:42 | |
| *** macz has quit IRC | 23:57 | |
| *** macz has joined #openstack-nova | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!