| *** macz has quit IRC | 00:05 | |
| *** mdbooth has quit IRC | 00:12 | |
| *** mdbooth has joined #openstack-nova | 00:19 | |
| *** mmethot_ has quit IRC | 00:21 | |
| *** mmethot has joined #openstack-nova | 00:22 | |
| openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: doc: Update Testing document https://review.opendev.org/695995 | 00:23 |
|---|---|---|
| openstackgerrit | Guo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120 | 00:59 |
| *** jbernard has quit IRC | 01:00 | |
| *** Liang__ has joined #openstack-nova | 01:02 | |
| *** Liang__ is now known as LiangFang | 01:04 | |
| *** mvkr has quit IRC | 01:04 | |
| *** awalende has joined #openstack-nova | 01:05 | |
| *** awalende has quit IRC | 01:10 | |
| *** nanzha has joined #openstack-nova | 01:10 | |
| *** ociuhandu has joined #openstack-nova | 01:12 | |
| *** igordc has quit IRC | 01:13 | |
| openstackgerrit | Merged openstack/nova master: Do not update root_device_name during guest config https://review.opendev.org/670000 | 01:14 |
| *** jbernard has joined #openstack-nova | 01:14 | |
| *** mvkr has joined #openstack-nova | 01:17 | |
| *** nanzha has quit IRC | 01:19 | |
| *** nanzha has joined #openstack-nova | 01:19 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | 01:27 |
| *** ociuhandu has quit IRC | 01:28 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default rules and mapping in policy base class https://review.opendev.org/645452 | 01:34 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Suppress policy deprecated warnings in tests https://review.opendev.org/676670 | 01:35 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Suppress policy deprecated warnings in tests https://review.opendev.org/676670 | 01:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | 01:37 |
| *** ociuhandu has joined #openstack-nova | 01:40 | |
| *** yaawang has joined #openstack-nova | 01:41 | |
| *** ociuhandu has quit IRC | 01:44 | |
| *** ricolin has joined #openstack-nova | 01:46 | |
| *** eharney has quit IRC | 01:49 | |
| *** nanzha has quit IRC | 01:58 | |
| *** mkrai has joined #openstack-nova | 02:02 | |
| *** nanzha has joined #openstack-nova | 02:10 | |
| *** brinzhang has joined #openstack-nova | 02:15 | |
| openstackgerrit | Huachang Wang proposed openstack/nova master: Refactor the code path of creating instance with a NUMA topology https://review.opendev.org/688932 | 02:18 |
| openstackgerrit | Huachang Wang proposed openstack/nova master: Assign instance dedicated CPU set through `cpu_pinning` field https://review.opendev.org/688933 | 02:18 |
| openstackgerrit | Huachang Wang proposed openstack/nova master: Introduce a new instance CPU allocation policy: mixed https://review.opendev.org/688934 | 02:18 |
| openstackgerrit | Huachang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 02:18 |
| openstackgerrit | Huachang Wang proposed openstack/nova master: More tests for validating CPU policy by 'resources:PCPU' and 'resources:VCPU' https://review.opendev.org/696007 | 02:18 |
| openstackgerrit | Huachang Wang proposed openstack/nova master: support unbalanced dedicatd CPU distribution on instance NUMA nodes https://review.opendev.org/696008 | 02:19 |
| openstackgerrit | Huachang Wang proposed openstack/nova master: Create 'mixed' instance from PCPU and VCPU resources https://review.opendev.org/696009 | 02:19 |
| *** yaawang has quit IRC | 02:36 | |
| *** ociuhandu has joined #openstack-nova | 02:38 | |
| openstackgerrit | Eric Xie proposed openstack/nova master: Fix incorrect command examples https://review.opendev.org/695832 | 02:38 |
| *** yaawang has joined #openstack-nova | 02:38 | |
| *** ociuhandu has quit IRC | 02:48 | |
| *** nanzha has quit IRC | 02:52 | |
| *** nanzha has joined #openstack-nova | 02:53 | |
| *** chenhaw has joined #openstack-nova | 02:53 | |
| *** tonyb has joined #openstack-nova | 03:00 | |
| *** ricolin has quit IRC | 03:03 | |
| *** awalende has joined #openstack-nova | 03:13 | |
| *** mkrai has quit IRC | 03:14 | |
| *** mkrai_ has joined #openstack-nova | 03:14 | |
| *** awalende has quit IRC | 03:18 | |
| *** artom has quit IRC | 03:20 | |
| *** artom has joined #openstack-nova | 03:21 | |
| *** ociuhandu has joined #openstack-nova | 03:43 | |
| *** ociuhandu has quit IRC | 03:47 | |
| *** nanzha has quit IRC | 03:50 | |
| *** ociuhandu has joined #openstack-nova | 03:53 | |
| *** nanzha has joined #openstack-nova | 03:55 | |
| *** READ10 has quit IRC | 03:59 | |
| *** hongbin has joined #openstack-nova | 04:00 | |
| *** ociuhandu has quit IRC | 04:01 | |
| *** ociuhandu has joined #openstack-nova | 04:02 | |
| *** ociuhandu has quit IRC | 04:07 | |
| *** ricolin has joined #openstack-nova | 04:08 | |
| *** udesale has joined #openstack-nova | 04:14 | |
| *** ricolin has quit IRC | 04:29 | |
| openstackgerrit | Merged openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | 04:39 |
| openstackgerrit | Merged openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | 04:40 |
| openstackgerrit | Merged openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | 04:40 |
| *** ratailor has joined #openstack-nova | 05:11 | |
| *** nanzha has quit IRC | 05:20 | |
| *** mkrai_ has quit IRC | 05:21 | |
| *** mkrai has joined #openstack-nova | 05:21 | |
| *** nanzha has joined #openstack-nova | 05:24 | |
| *** ociuhandu has joined #openstack-nova | 05:30 | |
| *** brinzhang_ has joined #openstack-nova | 05:31 | |
| *** ociuhandu has quit IRC | 05:35 | |
| *** brinzhang has quit IRC | 05:35 | |
| *** brinzhang has joined #openstack-nova | 05:36 | |
| *** brinzhang_ has quit IRC | 05:36 | |
| *** brinzhang has quit IRC | 05:37 | |
| *** tkajinam has quit IRC | 05:37 | |
| *** brinzhang has joined #openstack-nova | 05:37 | |
| *** tkajinam has joined #openstack-nova | 05:38 | |
| *** bhagyashris has joined #openstack-nova | 05:45 | |
| *** brinzhang has quit IRC | 05:46 | |
| openstackgerrit | Merged openstack/nova stable/train: Join migration_context and flavor in Migration.instance https://review.opendev.org/694408 | 05:52 |
| *** markmcclain has quit IRC | 05:56 | |
| *** markmcclain has joined #openstack-nova | 05:57 | |
| *** mkrai has quit IRC | 05:58 | |
| *** mkrai_ has joined #openstack-nova | 05:58 | |
| *** links has joined #openstack-nova | 05:59 | |
| *** nanzha has quit IRC | 06:05 | |
| *** nanzha has joined #openstack-nova | 06:06 | |
| *** hongbin has quit IRC | 06:18 | |
| *** mkrai_ has quit IRC | 06:23 | |
| *** mkrai has joined #openstack-nova | 06:25 | |
| *** sapd1 has joined #openstack-nova | 06:28 | |
| *** threestrands has quit IRC | 06:29 | |
| *** pcaruana has joined #openstack-nova | 06:32 | |
| *** takashin has left #openstack-nova | 06:32 | |
| *** ratailor has quit IRC | 06:38 | |
| *** udesale has quit IRC | 06:40 | |
| *** udesale has joined #openstack-nova | 06:41 | |
| *** ratailor has joined #openstack-nova | 06:42 | |
| *** yedongcan has joined #openstack-nova | 06:42 | |
| *** nanzha has quit IRC | 06:45 | |
| *** nanzha has joined #openstack-nova | 06:54 | |
| *** sapd1 has quit IRC | 06:57 | |
| *** nanzha has quit IRC | 06:59 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717 | 07:00 |
| *** nanzha has joined #openstack-nova | 07:08 | |
| *** nanzha has quit IRC | 07:20 | |
| *** nanzha has joined #openstack-nova | 07:21 | |
| *** slaweq has joined #openstack-nova | 07:23 | |
| *** chenhaw has quit IRC | 07:26 | |
| *** chenhaw has joined #openstack-nova | 07:26 | |
| *** slaweq has quit IRC | 07:28 | |
| *** udesale has quit IRC | 07:34 | |
| *** udesale has joined #openstack-nova | 07:35 | |
| *** nanzha has quit IRC | 07:44 | |
| *** damien_r has joined #openstack-nova | 07:57 | |
| *** mns96 has joined #openstack-nova | 07:57 | |
| *** slaweq has joined #openstack-nova | 07:57 | |
| *** nanzha has joined #openstack-nova | 07:58 | |
| *** chenhaw has quit IRC | 08:01 | |
| *** maciejjozefczyk has joined #openstack-nova | 08:02 | |
| *** brinzhang has joined #openstack-nova | 08:03 | |
| *** mns96 has quit IRC | 08:04 | |
| *** tesseract has joined #openstack-nova | 08:16 | |
| *** ratailor has quit IRC | 08:17 | |
| *** ratailor_ has joined #openstack-nova | 08:18 | |
| *** chenhaw has joined #openstack-nova | 08:18 | |
| *** tkajinam has quit IRC | 08:19 | |
| *** tosky has joined #openstack-nova | 08:25 | |
| *** nanzha has quit IRC | 08:33 | |
| *** brinzhang has quit IRC | 08:38 | |
| *** nanzha has joined #openstack-nova | 08:43 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Use long_rpc_timeout in reserve_block_device_name https://review.opendev.org/693537 | 08:50 |
| *** ralonsoh has joined #openstack-nova | 08:53 | |
| *** priteau has joined #openstack-nova | 08:59 | |
| *** macz has joined #openstack-nova | 08:59 | |
| *** mns96 has joined #openstack-nova | 09:01 | |
| kashyap | efried: Noted on your "meh"; can squash...could've squashed (but it's already merged). Thx! | 09:02 |
| *** macz has quit IRC | 09:03 | |
| *** tssurya has joined #openstack-nova | 09:04 | |
| kashyap | (And also thanks to stephenfin for the reviews, as usual.) | 09:04 |
| *** ociuhandu has joined #openstack-nova | 09:04 | |
| kashyap | stephenfin: Oops, good catch on "test_min_version_file_backed_ok"! | 09:07 |
| *** ociuhandu has quit IRC | 09:08 | |
| *** nanzha has quit IRC | 09:09 | |
| *** nanzha has joined #openstack-nova | 09:10 | |
| *** nanzha has quit IRC | 09:29 | |
| *** nanzha has joined #openstack-nova | 09:33 | |
| *** ociuhandu has joined #openstack-nova | 09:37 | |
| *** martinkennelly has joined #openstack-nova | 09:42 | |
| *** ociuhandu has quit IRC | 09:43 | |
| *** ociuhandu has joined #openstack-nova | 09:44 | |
| *** abaindur has quit IRC | 09:47 | |
| *** ociuhandu has quit IRC | 09:48 | |
| *** derekh has joined #openstack-nova | 09:49 | |
| stephenfin | bauzas: If you're bored, three dead simple patches here for you https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:drop-python2-support | 09:50 |
| bauzas | stephenfin: lol | 09:50 |
| bauzas | stephenfin: I'm bored by an internal customer issue, fer sur | 09:50 |
| *** damien_r has quit IRC | 09:54 | |
| *** damien_r has joined #openstack-nova | 09:54 | |
| *** bhagyashris has quit IRC | 09:59 | |
| *** nanzha has quit IRC | 09:59 | |
| *** bhagyashris has joined #openstack-nova | 09:59 | |
| *** ociuhandu has joined #openstack-nova | 10:00 | |
| *** LiangFang has quit IRC | 10:09 | |
| *** nanzha has joined #openstack-nova | 10:09 | |
| johnthetubaguy | stephenfin: just went back to the nova-net removal, can't we delete all of that nova/network/api.py as its the class we use to talk to the binary you removed in the patch before? | 10:11 |
| stephenfin | johnthetubaguy: Maybe? I'm not really sure. The RPC client/server divide constantly trips me up | 10:12 |
| stephenfin | I have been trying to avoid huge patches though because no one will review them. That feels like one such patch | 10:13 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Filter hypervisors by service host https://review.opendev.org/695716 | 10:13 |
| stephenfin | assuming I have to remove references from elsewhere while I'm at it | 10:13 |
| johnthetubaguy | understood | 10:13 |
| johnthetubaguy | I just wonder if you remove this bit: | 10:13 |
| johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/network/__init__.py | 10:13 |
| johnthetubaguy | that might mean a bunch of stuff just gets deleted, as its no longer used | 10:13 |
| johnthetubaguy | a large set of just red, with zuul +1 might get a quick ish review | 10:14 |
| stephenfin | let me try | 10:14 |
| stephenfin | I think I have that done _somewhere_, but who knows where | 10:14 |
| johnthetubaguy | heh, OK | 10:14 |
| * stephenfin has about a half dozen "remove nova-network" series on the fly locally | 10:15 | |
| stephenfin | thank God for cherry-pick | 10:15 |
| johnthetubaguy | if doing it results in a silly change, that is all good | 10:15 |
| johnthetubaguy | heh | 10:15 |
| *** ivve has joined #openstack-nova | 10:35 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove references to nova-net service from tests https://review.opendev.org/686818 | 10:49 |
| kashyap | sean-k-mooney: Hey, can you remind again: upstream supports multique virtio-net, yes? | 10:50 |
| kashyap | s/que/queue/ | 10:50 |
| *** lpetrut has joined #openstack-nova | 10:52 | |
| *** takamatsu has quit IRC | 10:55 | |
| *** udesale has quit IRC | 10:58 | |
| *** dpawlik has quit IRC | 11:00 | |
| *** ociuhandu has quit IRC | 11:03 | |
| *** nanzha has quit IRC | 11:07 | |
| johnthetubaguy | kashyap: I have used that with a customer, with some success | 11:08 |
| kashyap | johnthetubaguy: I see | 11:09 |
| kashyap | Good to hear | 11:09 |
| johnthetubaguy | good when you have lots of small packets | 11:09 |
| kashyap | johnthetubaguy: I ask because, a QEMU dev was just mentioning an OOM bug for a Windows guest w/ multiqueue enabled | 11:09 |
| kashyap | (Recently fixed, /me goes to check) | 11:10 |
| *** nanzha has joined #openstack-nova | 11:10 | |
| johnthetubaguy | heh, thank goodness they doing run windows then :) | 11:10 |
| johnthetubaguy | oops | 11:10 |
| kashyap | :D | 11:10 |
| johnthetubaguy | don't^ | 11:10 |
| johnthetubaguy | I forget the negative :) | 11:10 |
| kashyap | johnthetubaguy: Yeah, it's a guest-crash ... trying to find the upstream commit/release, if you're curious | 11:11 |
| *** jaosorior has joined #openstack-nova | 11:13 | |
| *** nanzha has quit IRC | 11:17 | |
| *** tetsuro has quit IRC | 11:18 | |
| *** priteau has quit IRC | 11:19 | |
| *** nanzha has joined #openstack-nova | 11:24 | |
| *** dpawlik has joined #openstack-nova | 11:27 | |
| *** nanzha has quit IRC | 11:29 | |
| *** nanzha has joined #openstack-nova | 11:29 | |
| *** dpawlik has quit IRC | 11:31 | |
| *** yedongcan has left #openstack-nova | 11:32 | |
| *** tbachman has quit IRC | 11:40 | |
| *** rcernin has quit IRC | 11:40 | |
| *** ociuhandu has joined #openstack-nova | 11:41 | |
| *** macz has joined #openstack-nova | 11:41 | |
| *** mkrai has quit IRC | 11:44 | |
| *** macz has quit IRC | 11:45 | |
| *** ociuhandu has quit IRC | 11:46 | |
| *** dpawlik has joined #openstack-nova | 11:53 | |
| *** dpawlik has quit IRC | 11:58 | |
| *** derekh has quit IRC | 12:01 | |
| *** derekh has joined #openstack-nova | 12:01 | |
| *** mkrai has joined #openstack-nova | 12:03 | |
| openstackgerrit | Merged openstack/nova master: Reset instance to current vm_state if rolling back in resize_instance https://review.opendev.org/691908 | 12:04 |
| openstackgerrit | Merged openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Ussuri" https://review.opendev.org/695056 | 12:08 |
| openstackgerrit | Merged openstack/nova master: doc: remove admin/manage-users https://review.opendev.org/695779 | 12:08 |
| *** klippo has joined #openstack-nova | 12:14 | |
| *** dtantsur|afk is now known as dtantsur | 12:20 | |
| *** udesale has joined #openstack-nova | 12:21 | |
| openstackgerrit | Merged openstack/nova master: Drop neutron-grenade-multinode job https://review.opendev.org/694789 | 12:23 |
| *** sean-k-mooney has quit IRC | 12:39 | |
| tssurya | @nova-api experts like alex_xu, gmann: Is this a bug or a feature ? : https://github.com/openstack/nova/blob/d621914442855ce67ce0b99003f7e69e8ee515e6/nova/api/openstack/identity.py#L61 | 12:39 |
| tssurya | shouldn't we be blocking this action if we know its wrong ? | 12:39 |
| *** ccamacho has quit IRC | 12:40 | |
| *** sean-k-mooney has joined #openstack-nova | 12:40 | |
| *** nanzha has quit IRC | 12:45 | |
| *** jawad_axd has joined #openstack-nova | 12:48 | |
| *** dpawlik has joined #openstack-nova | 12:51 | |
| *** dpawlik has quit IRC | 12:56 | |
| *** ccamacho has joined #openstack-nova | 13:02 | |
| *** ratailor_ has quit IRC | 13:03 | |
| *** tbachman has joined #openstack-nova | 13:04 | |
| *** tbachman has quit IRC | 13:08 | |
| *** bbowen has joined #openstack-nova | 13:13 | |
| *** tbachman has joined #openstack-nova | 13:16 | |
| *** ociuhandu has joined #openstack-nova | 13:20 | |
| *** liuyulong has joined #openstack-nova | 13:23 | |
| *** ociuhandu has quit IRC | 13:26 | |
| *** tbachman has quit IRC | 13:27 | |
| *** tbachman has joined #openstack-nova | 13:31 | |
| *** mriedem has joined #openstack-nova | 13:35 | |
| mriedem | gibi: if you have some time, https://review.opendev.org/#/c/643451/46 and the one after it are negative functional tests for cross-cell resize and have +2s already | 13:38 |
| *** jaosorior has quit IRC | 13:38 | |
| gibi | mriedem: ack. I will try. | 13:38 |
| mriedem | thanks | 13:39 |
| mriedem | aarents: were you going to propose backports for this? https://review.opendev.org/#/c/670000/ | 13:39 |
| aarents | yes why not | 13:40 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Join migration_context and flavor in Migration.instance https://review.opendev.org/696083 | 13:40 |
| openstackgerrit | Alexandre arents proposed openstack/nova master: Flatten qcow2 images when unshelving an instance https://review.opendev.org/696084 | 13:41 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: Reset instance to current vm_state if rolling back in resize_instance https://review.opendev.org/696085 | 13:42 |
| aarents | mriedem: thanks about you reply on ml about "unshelved bug", when you will have time can you review https://review.opendev.org/696084 it is about flatten also qcow2 disk during unshelve | 13:44 |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | 13:45 |
| mriedem | aarents: i've added mdbooth to that since he's going to be more of an authority on that change than me | 13:51 |
| aarents | mriedem: ok thks | 13:52 |
| mriedem | though it should be pretty easy to recreate in tempest right? make sure devstack is configured to use the qcow2 image backend (it might be by default?) and write a tempest test that shelve/unshelves an instance and then resizes it - without your fix that should fail correct? | 13:52 |
| *** mdbooth has quit IRC | 13:55 | |
| *** mdbooth has joined #openstack-nova | 13:57 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/train: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/696088 | 13:58 |
| *** tkajinam has joined #openstack-nova | 14:00 | |
| aarents | mriedem: Hum, I'm not sure this bug can be always detected during a resize, for exemple issue is typically detected when instance is unbootable, it shoud depends of the data diff between shelved image and original image, but we can imagine in tempest scenario something reproducible 100% by checking generated data or something like that. | 14:03 |
| *** huaqiang has joined #openstack-nova | 14:08 | |
| *** dpawlik has joined #openstack-nova | 14:12 | |
| *** bhagyashris has quit IRC | 14:13 | |
| *** bbowen has quit IRC | 14:17 | |
| *** bbowen has joined #openstack-nova | 14:20 | |
| *** ociuhandu has joined #openstack-nova | 14:22 | |
| dpawlik | stephenfin: can I add nova-core group for this review? https://review.opendev.org/#/c/687909/ | 14:23 |
| stephenfin | dpawlik: you can, but I don't know how much it'll help | 14:23 |
| stephenfin | is there a rush on merging it? | 14:24 |
| *** ociuhandu has quit IRC | 14:27 | |
| *** links has quit IRC | 14:32 | |
| *** dpawlik has quit IRC | 14:44 | |
| *** jawad_axd has quit IRC | 14:48 | |
| *** ociuhandu has joined #openstack-nova | 14:49 | |
| *** ociuhandu has quit IRC | 14:54 | |
| *** dpawlik has joined #openstack-nova | 14:56 | |
| dpawlik | stephenfin: not so big :) | 15:00 |
| *** jaosorior has joined #openstack-nova | 15:04 | |
| *** huaqiang has quit IRC | 15:07 | |
| *** ociuhandu has joined #openstack-nova | 15:19 | |
| mriedem | dpawlik: adding the entire core team to a review is generally discouraged as bad behavior | 15:19 |
| *** tkajinam has quit IRC | 15:19 | |
| efried | that's perhaps a culture we should seek to amend in light of falling numbers. | 15:21 |
| *** mns96 has quit IRC | 15:22 | |
| efried | What's your alternative? Hang out in IRC and pounce on someone? Or just wait and pray? | 15:22 |
| mriedem | adding the entire core team to lots of reviews isn't going to make people start reviewing things | 15:23 |
| efried | I've always thought that was kind of a crappy expectation for casual contributors. | 15:23 |
| mriedem | if it's important, yes, ask in irc or in the meeting | 15:23 |
| mriedem | you can post things on the meeting for awareness without actually attending | 15:23 |
| *** dpawlik has quit IRC | 15:23 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | 15:23 |
| mriedem | we've said multiple times that most if not all cores are ok with people asking for reviews in here (within reason) | 15:24 |
| efried | "lots of reviews" principle applies regardless of the method | 15:24 |
| efried | anyway, sorry, /me crawls back into hole | 15:24 |
| *** ociuhandu has quit IRC | 15:28 | |
| *** martinkennelly has quit IRC | 15:29 | |
| mriedem | stephenfin: another way to get eyes on that series is putting it in runways - which has basically been empty all of ussuri | 15:31 |
| mriedem | so i'm not sure why we're even doing runways anymore | 15:31 |
| artom | mriedem, playing devil's advocate for a bit, a new contributor might now even know runways are a thing | 15:32 |
| artom | *not even | 15:32 |
| mriedem | i was going to tell dpawlik but they left | 15:32 |
| mriedem | is dpawlik red hat? | 15:32 |
| artom | mriedem, not to my knowledge | 15:33 |
| artom | If they are, they're not Nova | 15:33 |
| mriedem | at least they are documented https://docs.openstack.org/nova/latest/contributor/process.html#runways | 15:34 |
| mriedem | ok dpawlik is ovh https://www.stackalytics.com/?user_id=daniel-pawlik | 15:36 |
| mriedem | ovh devs aren't new to openstack or nova | 15:36 |
| artom | mriedem, so, putting myself in the shoes of a new contributor, that link doesn't tell me "put your series in this etherpad and monitor it. When it hits a runway, be available to respond to feedback quickly and iterate fast." | 15:36 |
| mriedem | so i'd hope that within their dev team they can explain how things work | 15:36 |
| mriedem | artom: so write up some contributor docs | 15:36 |
| sean-k-mooney | i added https://review.opendev.org/#/c/674072/ to the runway queue for what its worth. i thought i already had but i guess not | 15:36 |
| artom | mriedem, can't argue with that :) | 15:36 |
| mriedem | writing up stuff like this is near impossible, because it's either too much or not enough content | 15:37 |
| mriedem | i'm pretty sure there are summit videos on this topic but people would have to find and watch them | 15:37 |
| mriedem | within an organization of decent size with multiple developers there should also be mentoring | 15:37 |
| mriedem | that's what we had at ibm when i was new to openstack | 15:37 |
| sean-k-mooney | speaking of which are there any from china? | 15:37 |
| artom | I know there are no magic bullets | 15:37 |
| efried | mdbooth: it looks like mriedem was expecting you to weigh in on https://review.opendev.org/#/c/693537/ before it goes. Might you have a chance to hit that soon? | 15:37 |
| mriedem | sean-k-mooney: any what from china? | 15:38 |
| artom | mriedem, it's been a while since we've had someone entirely new to openstack join RH, but we did try to help francoisp get up to speed when he came in | 15:38 |
| *** derekh has quit IRC | 15:38 | |
| sean-k-mooney | ya it looks liek they start going up last week | 15:38 |
| sean-k-mooney | mriedem: summit videos | 15:38 |
| artom | That was really the only example I can think of | 15:38 |
| artom | Everyone else we hired from upstream, so to speak | 15:38 |
| *** derekh has joined #openstack-nova | 15:38 | |
| mriedem | sean-k-mooney: the vidoes i saw posted were sparse - mostly keynotes and some vendor things | 15:38 |
| mriedem | i'm pretty sure there is also a welcome wagon sig or something in openstack | 15:39 |
| mriedem | so there are resources, but people need to do some work to find them | 15:39 |
| *** ociuhandu has joined #openstack-nova | 15:42 | |
| artom | stephenfin, hey, so https://review.opendev.org/#/c/672595/ is still around. Can I help in any way to get another round of review from you on that? | 15:43 |
| artom | Split it? Take over something of yours? | 15:43 |
| stephenfin | nah, I just need to do it, but I have my head stuck into the removal of the nova-network security group driver. Could I look at it tomorrow? | 15:44 |
| artom | stephenfin, sure - no huge rush, at this point. | 15:44 |
| artom | I wanted to backport it to Train, but I probably missed the train (zing!) on that | 15:45 |
| artom | I'll try anyways when it merges, see how it goes | 15:45 |
| *** awalende has joined #openstack-nova | 15:45 | |
| *** awalende has quit IRC | 15:50 | |
| *** mlavalle has joined #openstack-nova | 15:51 | |
| *** spatel has joined #openstack-nova | 15:54 | |
| *** mriedem has quit IRC | 15:55 | |
| openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | 15:58 |
| *** mriedem has joined #openstack-nova | 15:59 | |
| *** dpawlik has joined #openstack-nova | 16:00 | |
| *** ivve has quit IRC | 16:02 | |
| *** dtantsur is now known as dtantsur|afk | 16:03 | |
| *** dpawlik has quit IRC | 16:04 | |
| gmann | tssurya: but we do not know whether it is wrong or right. if keystone permissions to GET project is more strict than nova user, then project might exist but not shown to nova | 16:20 |
| *** jangutter has quit IRC | 16:22 | |
| tssurya | gmann: sure but the problem with the current implementation is that it treats everything as "right". Even if the project is invalid, we end up giving the user the right to feed anything into the flavor_projects table | 16:22 |
| *** tesseract has quit IRC | 16:23 | |
| gmann | tssurya: but it is 403, in case of invalid it will hit 404 condition. not 404 means project is there | 16:28 |
| *** ociuhandu has quit IRC | 16:33 | |
| *** ociuhandu has joined #openstack-nova | 16:34 | |
| *** Sundar has joined #openstack-nova | 16:34 | |
| openstackgerrit | Merged openstack/nova master: api-guide: remove empty sections about inter-service interactions https://review.opendev.org/695774 | 16:34 |
| openstackgerrit | Eric Fried proposed openstack/nova master: DNM: Test openstacksdk weakrefs https://review.opendev.org/695934 | 16:35 |
| tssurya | gmann: not really there can be a 403 on a case where the project doesn't exist right ? | 16:35 |
| *** damien_r has quit IRC | 16:35 | |
| tssurya | because tenant doesn't have permission to verify if the project exists ? | 16:35 |
| gmann | tssurya: not sure keystone does that and return 404 instead of 403. I know neutron return otherway- any PUT/DELETE request first call the GET and return 404 even resource exist and no permissions to GET(they do not return 403 because that is somehow telling resource exit). | 16:39 |
| tssurya | gmann: yea I guess keystone is returning 403 which nova is silently ignoring | 16:40 |
| gmann | i think keystone return 403 for permissions denied on GET project not 404. lbragstad ? | 16:40 |
| gmann | lbragstad can confirm this for us. | 16:40 |
| lbragstad | gmann it depends | 16:40 |
| lbragstad | if you're technically authorized to get a project (e.g., you're a system administrator) you'll get a 404 | 16:41 |
| lbragstad | if you don't have the right authorization - then you get a 403 | 16:41 |
| gmann | yeah that is what nova assume- https://github.com/openstack/nova/blob/fd67f69cfdaf04620f2e8a5f1fbf5737096965d8/nova/api/openstack/identity.py#L26 | 16:41 |
| lbragstad | gmann ok - yeah, that looks right | 16:42 |
| gmann | 403 means project is valid and exist and its only permission issue | 16:42 |
| gmann | lbragstad: thanks for quick confirmation. | 16:42 |
| lbragstad | well - the project may exist, but your first problem is that you're hitting a permission issue | 16:42 |
| tssurya | gmann: I don't think 403 ensures project exists | 16:43 |
| lbragstad | if you hit a 403, you should fix the permission issue and eventually retry | 16:43 |
| tssurya | because we have a couple of non-existing entries in our flavor_projects | 16:43 |
| tssurya | non-existing project entries* | 16:43 |
| lbragstad | a 403 isn't conclusive that the project exists | 16:44 |
| gmann | tssurya: but in those cases, we will get 404 right | 16:44 |
| tssurya | lbragstad: yea that makes sense | 16:44 |
| tssurya | gmann: nope we don't get the 404 | 16:44 |
| tssurya | I had a user inject "ABCD" project into the database :D | 16:45 |
| gmann | tssurya: yeah it is 'may' exist | 16:45 |
| tssurya | which doesn't exist | 16:45 |
| tssurya | hehe | 16:45 |
| *** macz has joined #openstack-nova | 16:45 | |
| tssurya | I've opened a bug here: https://bugs.launchpad.net/nova/+bug/1854053 | 16:46 |
| openstack | Launchpad bug 1854053 in OpenStack Compute (nova) "_add_tenant_access silently ignores 403" [Undecided,New] | 16:46 |
| tssurya | probably nova should raise for a 403 or prompt user to retry or something | 16:46 |
| *** mkrai has quit IRC | 16:47 | |
| gmann | tssurya: with default policy which is admin only should work but if overridden then yes it can make non-exist project entry in flavor access | 16:49 |
| tssurya | gmann: yea that's true, in this case it was done from a service project by a user having admin role | 16:50 |
| mriedem | tssurya: without reading all of the scrollback, "sure but the problem with the current implementation is that it treats everything as "right". Even if the project is invalid, we end up giving the user the right to feed anything into the flavor_projects table" is exactly how that api worked before that change to validate the project id provided | 16:50 |
| tssurya | nevertheless allowing "ok" and then feeding whatever value is coming from the user is not ok | 16:50 |
| mriedem | the project id validation is best effort | 16:51 |
| tssurya | mriedem: aha, I didn't know the history | 16:51 |
| gmann | tssurya: mriedem i think we should only proceed the request for 2xx case and rest all return 400 with error message of what we get from keystone | 16:52 |
| mriedem | so in this case we're using the token from the request context or the configurable keystone auth in nova? | 16:52 |
| mriedem | gmann: which is an api change | 16:52 |
| mriedem | by configurable keystone auth in nova i mean this https://docs.openstack.org/nova/latest/configuration/config.html#keystone | 16:53 |
| gmann | yeah | 16:53 |
| mriedem | service user configured in nova to talk to keystone | 16:53 |
| mriedem | like we do for neutron and cinder | 16:53 |
| *** dpawlik has joined #openstack-nova | 16:54 | |
| mriedem | so doesn't that just mean the service user configured in nova to talk to keystone doesn't have enough permissions to know if the given project_id exists? | 16:54 |
| tssurya | mriedem: right | 16:54 |
| tssurya | exactly | 16:54 |
| tssurya | https://github.com/openstack/nova/blob/fd67f69cfdaf04620f2e8a5f1fbf5737096965d8/nova/api/openstack/identity.py#L62 | 16:55 |
| mriedem | yeah, so my point is, it sounds like this is a config issue in your deployment | 16:55 |
| mriedem | i.e. why can't you grant access to the service user that is doing this check on behalf of nova? | 16:55 |
| tssurya | the service user already has an admin role, I think this happens because the project is not admin project ? | 16:56 |
| mriedem | idk | 16:57 |
| mriedem | isn't that also configurable in keystone? | 16:57 |
| mriedem | i.e. the policy to GET a project by id - it's not hard-coded to admin project only is it? | 16:57 |
| gmann | mriedem: but point is users do not know it was permission issue for them or they are adding wrong project | 16:57 |
| tssurya | probably, I'll see if it can be tweaked on the config side for our particular scenario, | 16:58 |
| tssurya | but in general its strange nova allows entries from users that don't have permission | 16:58 |
| mriedem | gmann: if the service user nova is configured with has permissions to ask the question "does this project exist" that's all this utility code is used for | 16:58 |
| *** dpawlik has quit IRC | 16:58 | |
| gmann | policy can be changed to make it work properly and with default policy it should work at long as keystone system scope is enabled | 16:59 |
| mriedem | and again, this was added as best effort to close a leak where the flavor access and quotas apis would just blindly take whatever project id and assume it existed and shove it into the nova db | 16:59 |
| gmann | mriedem: from API usage they do not know nova does this check internally ? | 16:59 |
| tssurya | mriedem: yea if its best effort, I'll probably just tweak it downstream then and write it in our documentation | 17:00 |
| mriedem | i don't understand the question. if configured properly and nova determines the project doesn't exist (404 from keystone) the compute API users will also get a 404 | 17:00 |
| gmann | mriedem: yeah agree on best effort but if API return the permissions issue to user and then they ask provider to modify the permission or ask other right user to add the tenant in flavor access | 17:00 |
| mriedem | i see 3 options: | 17:01 |
| mriedem | 1. close the bug as invalid - tweak your config (we could add docs, idk if that would be found or help) to do what you need to avoid the 403 from keystone | 17:02 |
| gmann | mriedem: no. if permissions issue then keystone return 403 (which means project may exist or not) and nova proceed the request with 200. so user does not know if that is correct or not. | 17:02 |
| mriedem | 2. change the 403 case as an error and raise it back to the compute api caller - maybe enough time has passed to not worry about backward compat with the old non-validating behavior | 17:02 |
| mriedem | 3. add a config option to toggle what the behavior of the api should be in the 403 case, default to backward compat, but allow making it raise for those that want that, but that means you need to know to twiddle that config which if you know that, you likely know you can just fix the permissions for your service user | 17:03 |
| tssurya | I vote for 2 | 17:03 |
| mriedem | of course you do :) | 17:03 |
| tssurya | :D | 17:03 |
| mriedem | one thing to point out for #2 is that the quota set and flavor access add/remove style write APIs are admin-only by default, so if we do change the behavior of that 403 it would only be on admin apis, not end-user apis | 17:05 |
| gmann | 3rd is not good option. config driven API not good. | 17:06 |
| tssurya | ack | 17:06 |
| *** ivve has joined #openstack-nova | 17:06 | |
| gmann | even admin only API it still API change in option 2 | 17:06 |
| mriedem | option 1 is the only non-api change | 17:06 |
| mriedem | we're not going to microversion this imo | 17:06 |
| mriedem | if that's what you're thinking | 17:07 |
| gmann | with option 1 yes no microversion but option 2 need microverion | 17:07 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add a way to exit early from a wait_for_instance_event() https://review.opendev.org/695985 | 17:07 |
| mriedem | not really | 17:07 |
| mriedem | i don't necessarily think we need a microversion to prevent you from shooting yourself in the foot | 17:07 |
| mriedem | we have a few cases where we've made the api error on cases that are wrong | 17:07 |
| tssurya | dansmith: when you have time would you lightly review the idea in https://review.opendev.org/#/c/689422/ ? thanks in advance :) | 17:08 |
| mriedem | and would just fail later, e.g. attaching sriov ports (not supported), rebuilding volume-backed instances with a new image (not supported) | 17:08 |
| gmann | mriedem: yes but here we are changing the behavior. user does not permissions to GET project and project exist is right request and nvoa is 200 currently which will be 400. | 17:08 |
| mriedem | gmann: the "user" in this case is an admin | 17:09 |
| gmann | yes | 17:09 |
| *** udesale has quit IRC | 17:09 | |
| dansmith | tssurya: -1.9 | 17:10 |
| mriedem | i'm agreeing that re-raising the 403 from keystone would be a behavior change | 17:10 |
| tssurya | I would prefer not to have a microversion to fix this, but I don't know if its "okay" to do it | 17:10 |
| mriedem | but i'm not agreeing it requires a microversion | 17:10 |
| mriedem | we didn't add the project id validation in a new microversion either, because it was stopping a leaky bug | 17:10 |
| tssurya | dansmith: bad idea ? | 17:10 |
| mriedem | iow, i shouldn't have to request a microversion to tell nova to properly do validation | 17:11 |
| dansmith | tssurya: can't get past the typo in the commit message ;P | 17:11 |
| dansmith | tssurya: I added two people that should look at it | 17:11 |
| tssurya | dansmith: haha :P | 17:11 |
| mriedem | she said "lightly review" | 17:11 |
| tssurya | thanks :) | 17:11 |
| dansmith | mriedem: true story | 17:11 |
| gmann | mriedem: but we cannot say that this nova API is only for users having GET project permission ? | 17:11 |
| tssurya | mriedem, dansmith: by "light" I mean the idea of removing them, those parts of code are grey areas for me | 17:12 |
| mriedem | i usually ask dan to lightly review my stuff when i want him to just rubberstamp it :) | 17:12 |
| dansmith | tssurya: I'm sure you're right that it needs to happen.. I'm not super strong in that area of the code as well | 17:12 |
| gmann | i mean we cannot say in current code behavior or doc | 17:12 |
| tssurya | dansmith: ack, I'll wait for the experts you tagged to respond | 17:13 |
| mriedem | gmann: i'm lost in what you're asking and what you're proposing | 17:13 |
| tssurya | mriedem:hehe | 17:13 |
| mriedem | gmann: because earlier you said "(10:52:19 AM) gmann: tssurya: mriedem i think we should only proceed the request for 2xx case and rest all return 400 with error message of what we get from keystone" | 17:13 |
| gmann | option 1 (telling via document for right permissions for this API) options 2 do the same via code. I like later one but that need microversion change IMO | 17:13 |
| gmann | yeah but IMO it need microverison change | 17:13 |
| mriedem | and i disagree | 17:14 |
| gmann | on microverison only right ? | 17:14 |
| mriedem | 1. request at 2.1 -> blast off my foot, ouch....reads docs.... 2. oh request at 2.97 - 403 (it works!) | 17:14 |
| mriedem | i am a disagreeable troll on most everything but on this point yes just the microversion thing | 17:15 |
| *** ociuhandu has quit IRC | 17:15 | |
| sean-k-mooney | it might be worth updating the "when do you need a micorverions bump" doc to note its not required if you are blocking knonw broken behavior using an error code that could previously be retruned form teh api | 17:17 |
| gmann | it break the success cases from 200->400. because GET project permission is not actually required for this API only things is how nova check the project exist or not? | 17:17 |
| gmann | sean-k-mooney: i think that is covered, broken behavior is ok to fix without microversion. | 17:18 |
| tssurya | gmann: so you are fine to go ahead without microversion ? | 17:18 |
| mriedem | maybe y'all duke it out in the mailing list and let others weigh in | 17:18 |
| gmann | but this is little tricky where it is mix of success and broken case because keystone 403 does not mean project does not exist always | 17:19 |
| gmann | tssurya: no, i am saying it need microversion if we change the keystone's 403 case to failure case. | 17:20 |
| tssurya | I'll post it on ML and we can see if there are people who care about this | 17:20 |
| *** igordc has joined #openstack-nova | 17:20 | |
| gmann | or we request keystone with no auth way ? do not know how | 17:20 |
| gmann | +1 | 17:20 |
| *** spatel has quit IRC | 17:28 | |
| *** gshippey has joined #openstack-nova | 17:30 | |
| *** jaosorior has quit IRC | 17:32 | |
| openstackgerrit | Merged openstack/nova master: compute: Take an instance.uuid lock when rebooting https://review.opendev.org/673463 | 17:34 |
| *** openstackgerrit has quit IRC | 17:49 | |
| *** derekh has quit IRC | 18:00 | |
| *** tbachman has quit IRC | 18:10 | |
| *** tssurya has quit IRC | 18:12 | |
| *** openstackgerrit has joined #openstack-nova | 18:14 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Take an instance.uuid lock when rebooting https://review.opendev.org/696151 | 18:14 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: compute: Take an instance.uuid lock when rebooting https://review.opendev.org/696152 | 18:15 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: compute: Take an instance.uuid lock when rebooting https://review.opendev.org/696153 | 18:16 |
| *** Sundar has quit IRC | 18:16 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Take an instance.uuid lock when rebooting https://review.opendev.org/696154 | 18:16 |
| *** jaosorior has joined #openstack-nova | 18:26 | |
| *** openstackgerrit has quit IRC | 18:35 | |
| efried | dansmith: I'm confused by some of the new wording, which might just be me, but pretty sure the test has a mistake https://review.opendev.org/#/c/695985/ | 18:35 |
| dansmith | efried: ah, frack, that was supposed to get dedented | 18:37 |
| efried | :) | 18:37 |
| efried | dansmith: but please add the self.fail() as well | 18:37 |
| dansmith | efried: you mean a self.fail after the early exit to make sure we don't get there right? | 18:38 |
| efried | correct | 18:38 |
| dansmith | sure | 18:38 |
| efried | self.fail('this code should have been unreachable!') | 18:38 |
| dansmith | self.fail('I could totally take eric in a a street fight') | 18:39 |
| dansmith | we'll never run that code, so we'll never know | 18:39 |
| efried | hahaha | 18:40 |
| *** openstackgerrit has joined #openstack-nova | 18:41 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add a way to exit early from a wait_for_instance_event() https://review.opendev.org/695985 | 18:41 |
| gmann | johnthetubaguy: these test change is due to base class assert on error message. these tests will be changed only where granularity is added which should not be many or we can remove the error message checks . - https://review.opendev.org/#/c/648480/20/nova/tests/unit/policies/test_services.py@63 | 18:51 |
| *** ralonsoh has quit IRC | 18:51 | |
| openstackgerrit | Merged openstack/nova stable/train: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/696088 | 18:54 |
| *** dpawlik has joined #openstack-nova | 18:55 | |
| *** CeeMac has quit IRC | 18:57 | |
| *** dpawlik has quit IRC | 18:59 | |
| *** artom has quit IRC | 19:01 | |
| *** artom has joined #openstack-nova | 19:03 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default rules and mapping in policy base class https://review.opendev.org/645452 | 19:05 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Suppress policy deprecated warnings in tests https://review.opendev.org/676670 | 19:05 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | 19:07 |
| efried | dansmith: +2, thanks. | 19:08 |
| efried | Can I get you to look at the vTPM spec again please? | 19:08 |
| efried | https://review.opendev.org/#/c/686804/ | 19:08 |
| dansmith | no | 19:08 |
| *** maciejjozefczyk has quit IRC | 19:08 | |
| *** lpetrut has quit IRC | 19:08 | |
| efried | mriedem: if you have a minute, would you please take a look at https://review.opendev.org/695985 (lets us fix races to wait_for_instance_event()) | 19:09 |
| dansmith | efried: mriedem: just left a comment about _how_ we'll use this with cyborg to close that race: https://review.opendev.org/#/c/631244/46/nova/compute/manager.py@2627 | 19:12 |
| efried | dansmith: ++ makes perfect sense. Do you have a strong opinion about whether the bind should be kicked off from conductor instead of compute at this point? | 19:14 |
| dansmith | efried: I think it'd be better if we did it from conductor for all the reasons I originally thought that | 19:14 |
| dansmith | so unless there's some new revelation about why that's bad, I have the same opinion | 19:15 |
| efried | I think it might have had something to do with how easy/hard it is to clean up. But I can't think why it would matter. | 19:16 |
| efried | otherwise it's just a question of having to redo the code moar. | 19:16 |
| dansmith | well, the major benefit is the overlap of work getting done to build the accelerator before we get down to the last minute | 19:16 |
| sean-k-mooney | the only issue i was aware of was it would require use to pass the arq info as part of the spawn call to the compute | 19:17 |
| dansmith | if you do it from conductor, you're letting cyborg know about things before you take the trip over rabbit to the compute, wait in the parallel build queue, set up volumes, networking, etc, etc | 19:17 |
| sean-k-mooney | but we may already need to do that | 19:17 |
| dansmith | the current code is not passing it, AFAICT, and building all of that into the compute, | 19:17 |
| dansmith | which is another good reason not to do it on the compute | 19:17 |
| dansmith | the more the compute implies about the request from the state of the system, the harder it is to effect an upgrade that changes those implications later | 19:18 |
| sean-k-mooney | right but i think they choose to build it on the compute initally to avoid the rpc chagne to pass it | 19:18 |
| sean-k-mooney | i prefer doing it in the conductor too by the way | 19:18 |
| sean-k-mooney | i just think that is why the current code does not | 19:18 |
| dansmith | right now, all the computes are examining the flavor directly and doing what they think they need to | 19:18 |
| dansmith | if we change something about how that works, conductor gets upgraded first and can change the behavior, just passing the arq to the compute, which just needs to wait and hook it up | 19:19 |
| *** eharney has joined #openstack-nova | 19:20 | |
| mriedem | efried: the bind from compute/conductor thing was in the ML awhile back, probably worth dredging that up if we're changing our minds now | 19:39 |
| *** abaindur has joined #openstack-nova | 19:39 | |
| *** abaindur has quit IRC | 19:40 | |
| mriedem | from what i remember, i think i also pushed for conductor but then after lots of wah wah it's easier from compute without a bunch of rpc interface changes i relented | 19:40 |
| *** abaindur has joined #openstack-nova | 19:40 | |
| dansmith | mriedem: we had originally said it would be from conductor, then the spec changed | 19:40 |
| dansmith | mriedem: the spec seemed to call out the eventing as the primary reason why it had to happen from compute | 19:40 |
| dansmith | which is both not correct, and also laughably terrible in the implementation currently proposed | 19:40 |
| mriedem | i don't remember the details, i just know it came up in the ML | 19:41 |
| sean-k-mooney | it also came up in the denver and maybe dubling ptg | 19:41 |
| sean-k-mooney | its been a while | 19:41 |
| sean-k-mooney | i think long term we all agreed teh conductor was better. | 19:41 |
| mriedem | ok, let me rephrase: the last time i remember there being thoughtful and documented takes on that was in the ML | 19:42 |
| mriedem | rather than some undocumented stuff from dubling | 19:42 |
| sean-k-mooney | i think at some point there was a request to avoid the rpc chagne but i dont really rememebr | 19:42 |
| mriedem | "i don't really remember" is why i refer back to the ML | 19:42 |
| sean-k-mooney | ya fair | 19:42 |
| dansmith | I don't remember a thread on the ML, but there was discussion and documentation on the spec, which seemed to be the most fresh to me | 19:42 |
| dansmith | https://review.opendev.org/#/c/603955/11/specs/train/approved/nova-cyborg-interaction.rst@250 | 19:43 |
| dansmith | this ^ | 19:44 |
| mriedem | wacka wacka http://lists.openstack.org/pipermail/openstack-discuss/2019-June/thread.html#6979 | 19:44 |
| dansmith | the discussion basically says either can do it, but it's hard to do it from conductor and then catch the event from compute | 19:44 |
| dansmith | that is not a problem | 19:44 |
| dansmith | mriedem: looks like that ended with you still opting for as much in conductor as possible | 19:46 |
| dansmith | but no real summarizing agreement that it should be in compute | 19:46 |
| mriedem | in http://lists.openstack.org/pipermail/openstack-discuss/2019-June/007013.html i'm saying please create arqs in conductor and bind in compute, like john was trying to do with ports at one time | 19:46 |
| *** eharney has quit IRC | 19:46 | |
| mriedem | bind generates the event if that's what is important | 19:47 |
| sean-k-mooney | isnt that what we agreed to do | 19:47 |
| dansmith | right, but bind is the thing that takes a long time, | 19:47 |
| dansmith | so doing that in conductor is what gets us the most gain | 19:47 |
| dansmith | the original email states the reason for moving is because of the eventing being hard, which is is not | 19:47 |
| mriedem | having not really any skin in this game, it doesn't really matter to me anyone re this cyborg series | 19:48 |
| mriedem | i agree the original email is mostly excuses | 19:48 |
| mriedem | minimal change to get a thing to sort of work as a poc | 19:48 |
| mriedem | to which i said essentially, yeah that's why we have a lot of turdy spaghetti code we've wanted to refactor for years | 19:48 |
| mriedem | and why artom calls nova fugly | 19:48 |
| dansmith | yeah, understand.. the reason for moving to compute based on the spec and that original email seemed to be excuses around eventing, which are not valid, | 19:49 |
| dansmith | so I'd prefer we revert back to the original plan which had good reasoning, which is to overlap the programming with all the other things we can do in parallel, | 19:49 |
| dansmith | which means bind at conductor | 19:49 |
| sean-k-mooney | they baically need to do the equvalent of double check locking in the driver. check if its bound start waiting for event, check if its bound again incase you mised it and if so cancel waiting if not wait | 19:50 |
| mriedem | does that include building a new interface into conductor so when the api receives the external event it can route it to conductor rather than compute? | 19:50 |
| dansmith | sean-k-mooney: did you see the explanation I linked above about how to do the check and event without the race? | 19:50 |
| dansmith | sean-k-mooney: they do not need to check twice | 19:50 |
| dansmith | mriedem: no it does not | 19:50 |
| dansmith | read this: https://review.opendev.org/#/c/631244/46/nova/compute/manager.py@2627 | 19:51 |
| sean-k-mooney | no but i trust you when you say there is a way to do that | 19:51 |
| sean-k-mooney | but neighter woudl be hard to do | 19:51 |
| dansmith | neighter? | 19:51 |
| sean-k-mooney | neither | 19:51 |
| dansmith | oh | 19:51 |
| sean-k-mooney | ya that was more off then normal | 19:52 |
| dansmith | the double check doesn't actually help, AFAICT, it would have to be N checks i.e. polling | 19:52 |
| sean-k-mooney | well once you have register to wait for the event if you check the status and its not complete you can just wait | 19:52 |
| dansmith | sean-k-mooney: right, that's one check and that's what I mention in the above comment | 19:53 |
| dansmith | it's just that you need a new thing to be able to exit the wait after you have started if you know it is not necessary which is not easy today | 19:53 |
| dansmith | you said "equivalent of double check" so, I see what you mean now | 19:53 |
| sean-k-mooney | ah ok i was suggesting checking that api once ot skip that incase its already done but that is not needed | 19:53 |
| dansmith | yes | 19:53 |
| dansmith | skip is the thing we can't do without the patch I proposed | 19:53 |
| sean-k-mooney | gotch ya | 19:54 |
| mriedem | so tl;dr create and bind the arq in conductor, cast to compute to build, compute grabs the event lock and checks to see if it should wait based on the cyborg api - if so, wait, if not, cancel the wait since the event taint comin | 19:56 |
| dansmith | basically yeah | 19:56 |
| mriedem | i suppose it's out of the question waiting for the cyborg series to be rebased and integrated with said wait-or-cancel function | 19:57 |
| openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/696175 | 19:58 |
| dansmith | mriedem: I've already proposed the patch, efried has already asked you to +W, and yes, the cyborg set will need to use it to get my +2 :) | 19:59 |
| dansmith | mriedem: or did you mean waiting to merge the new skip thing until the cyborg set is using it? | 20:00 |
| mriedem | i was hoping to see the latter before having to dig into the new thing, to show something using it successfully outside of unit tests - but i realize that might be awhile | 20:02 |
| dansmith | mriedem: oh that's fine, I don't care that much, but I think it's probably good to get that just landed ahead of time so the set doesn't get too much bigger.. | 20:02 |
| dansmith | I'd also propose we land the test base refactor, once it gets unfscked | 20:03 |
| mriedem | i'm not sure why that test base refactor is even needed | 20:03 |
| mriedem | it's just noise imo | 20:03 |
| dansmith | me either, I haven't gotten that far yet, but someone else had a similar one up too Ithought | 20:03 |
| dansmith | was it mdbooth you said? | 20:03 |
| mriedem | "i like 85% of this base class but don't need the other %15 right now, so rip it all apart!" | 20:03 |
| mriedem | yes | 20:03 |
| mriedem | and i have the same feelings about his | 20:04 |
| dansmith | *shrug* whatever | 20:04 |
| dansmith | I couldn't get past the other issues with the refactor to care about reasoning I guess :P | 20:04 |
| mriedem | there i've -1ed both of them | 20:07 |
| *** damien_r has joined #openstack-nova | 20:25 | |
| *** damien_r has quit IRC | 20:27 | |
| *** damien_r has joined #openstack-nova | 20:27 | |
| openstackgerrit | Alexandre arents proposed openstack/nova master: Flatten qcow2 images when unshelving an instance https://review.opendev.org/696084 | 20:44 |
| *** ccamacho has quit IRC | 20:46 | |
| *** tosky has quit IRC | 20:46 | |
| *** dpawlik has joined #openstack-nova | 20:55 | |
| *** dpawlik has quit IRC | 21:00 | |
| openstackgerrit | Merged openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815 | 21:12 |
| openstackgerrit | sean mooney proposed openstack/nova master: block rebuild when numa topology changed https://review.opendev.org/687957 | 21:14 |
| openstackgerrit | sean mooney proposed openstack/nova master: Disable NUMATopologyFilter on rebuild https://review.opendev.org/689861 | 21:14 |
| openstackgerrit | sean mooney proposed openstack/nova master: block rebuild when numa topology changed https://review.opendev.org/687957 | 21:18 |
| openstackgerrit | sean mooney proposed openstack/nova master: Disable NUMATopologyFilter on rebuild https://review.opendev.org/689861 | 21:18 |
| sean-k-mooney | artom: bauzas hopefully ye are happy with ^ | 21:19 |
| *** threestrands has joined #openstack-nova | 21:27 | |
| *** tbachman has joined #openstack-nova | 21:30 | |
| *** igordc has quit IRC | 21:33 | |
| *** d34dh0r53 has quit IRC | 21:39 | |
| *** igordc has joined #openstack-nova | 21:39 | |
| *** d34dh0r53 has joined #openstack-nova | 21:39 | |
| openstackgerrit | sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072 | 21:49 |
| *** damien_r has quit IRC | 21:53 | |
| *** jaosorior has quit IRC | 21:59 | |
| *** abaindur has quit IRC | 22:01 | |
| *** abaindur has joined #openstack-nova | 22:01 | |
| *** ociuhandu has joined #openstack-nova | 22:02 | |
| artom | sean-k-mooney, yarp, I'll look tomorrow | 22:04 |
| *** rcernin has joined #openstack-nova | 22:04 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Amend cross-cell-resize spec https://review.opendev.org/696197 | 22:05 |
| *** ociuhandu has quit IRC | 22:08 | |
| *** pcaruana has quit IRC | 22:16 | |
| mriedem | dansmith: efried: btw, to whom it may concern, i'm out tomorrow and back monday | 22:24 |
| efried | ack | 22:24 |
| mriedem | assuming i survive snowmaggaedon | 22:24 |
| dansmith | ack, I'm headed out early tomorrow | 22:24 |
| efried | it's 72 here | 22:24 |
| efried | eat your heart out | 22:24 |
| mriedem | i will not | 22:24 |
| dansmith | yeah, I'll keep what I got but thanks | 22:25 |
| melwitt | it's 52F here | 22:25 |
| mriedem | laura isn't traveling with me (she's on call) but she suggested we get me an AWD vehicle today just b/c her weather travel anxiety by proxy is on high alert | 22:25 |
| melwitt | I love AWD | 22:26 |
| mriedem | hers is, so she can make it across town to work | 22:27 |
| mriedem | me, i just know to not jerk and drive (tm) | 22:27 |
| dansmith | mriedem: better 'splain that one for people about to dial 9-1-H-R | 22:28 |
| * artom doesn't bite. | 22:28 | |
| mriedem | http://nymag.com/intelligencer/2014/12/south-dakota-yanks-dont-jerk-drive-campaign.html | 22:28 |
| melwitt | lol | 22:28 |
| melwitt | aren't they the same ones doing, "Meth. I'm on it"? | 22:29 |
| mriedem | yes | 22:29 |
| mriedem | 2 for 2 on successful ad campaigns | 22:29 |
| melwitt | indeed | 22:29 |
| *** slaweq has quit IRC | 22:37 | |
| *** dlbewley has quit IRC | 22:43 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | 22:44 |
| *** dpawlik has joined #openstack-nova | 22:56 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the target in os-services APIs policy https://review.opendev.org/676688 | 22:58 |
| *** dpawlik has quit IRC | 23:01 | |
| *** tkajinam has joined #openstack-nova | 23:08 | |
| *** slaweq has joined #openstack-nova | 23:11 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies https://review.opendev.org/657698 | 23:12 |
| *** slaweq has quit IRC | 23:15 | |
| *** gshippey has quit IRC | 23:30 | |
| *** ociuhandu has joined #openstack-nova | 23:30 | |
| *** ociuhandu has quit IRC | 23:35 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!