| *** ivve has quit IRC | 00:04 | |
| *** macz has quit IRC | 00:21 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | 00:26 |
|---|---|---|
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add RevertResizeTask https://review.opendev.org/638046 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Flesh out RevertResizeTask.rollback https://review.opendev.org/695334 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional cross-cell revert test with detached volume https://review.opendev.org/695335 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.opendev.org/651650 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353 | 00:26 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add test_resize_cross_cell_weigher_filtered_to_target_cell_by_spec https://review.opendev.org/695336 | 00:26 |
| *** mriedem has quit IRC | 00:26 | |
| *** mlavalle has quit IRC | 00:28 | |
| *** tetsuro has joined #openstack-nova | 00:28 | |
| openstackgerrit | Merged openstack/nova stable/rocky: Fix listing deleted servers with a marker https://review.opendev.org/690721 | 00:34 |
| openstackgerrit | Merged openstack/nova stable/stein: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/696175 | 00:35 |
| *** igordc has quit IRC | 00:42 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/696217 | 00:43 |
| *** eharney has joined #openstack-nova | 00:43 | |
| *** slaweq has joined #openstack-nova | 00:50 | |
| *** slaweq has quit IRC | 00:55 | |
| *** dpawlik has joined #openstack-nova | 00:57 | |
| *** eharney has quit IRC | 00:57 | |
| *** Liang__ has joined #openstack-nova | 01:00 | |
| *** dpawlik has quit IRC | 01:02 | |
| openstackgerrit | Merged openstack/nova master: zuul: Make functional job inherit from openstack parents https://review.opendev.org/688425 | 01:07 |
| openstackgerrit | Merged openstack/nova master: zuul: Remove unnecessary 'tox_install_siblings' https://review.opendev.org/695235 | 01:07 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 01:08 |
| *** bauzas has quit IRC | 01:14 | |
| *** ociuhandu has joined #openstack-nova | 01:21 | |
| *** bauzas has joined #openstack-nova | 01:24 | |
| *** nanzha has joined #openstack-nova | 01:24 | |
| *** ociuhandu has quit IRC | 01:26 | |
| *** ociuhandu has joined #openstack-nova | 01:32 | |
| *** Liang__ has quit IRC | 01:37 | |
| *** ociuhandu has quit IRC | 01:37 | |
| *** adriant has quit IRC | 01:39 | |
| *** spsurya has joined #openstack-nova | 01:40 | |
| *** slaweq has joined #openstack-nova | 01:43 | |
| *** slaweq has quit IRC | 01:47 | |
| *** ricolin has joined #openstack-nova | 01:52 | |
| *** mdbooth has quit IRC | 01:55 | |
| *** mdbooth has joined #openstack-nova | 01:56 | |
| *** adriant has joined #openstack-nova | 02:00 | |
| *** slaweq has joined #openstack-nova | 02:00 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/696217 | 02:05 |
| *** slaweq has quit IRC | 02:09 | |
| *** slaweq has joined #openstack-nova | 02:14 | |
| *** slaweq has quit IRC | 02:25 | |
| *** slaweq has joined #openstack-nova | 02:29 | |
| *** slaweq has quit IRC | 02:36 | |
| *** trungnv has joined #openstack-nova | 02:52 | |
| *** slaweq has joined #openstack-nova | 02:56 | |
| *** dpawlik has joined #openstack-nova | 02:58 | |
| *** chenhaw has quit IRC | 03:00 | |
| *** dpawlik has quit IRC | 03:03 | |
| *** ociuhandu has joined #openstack-nova | 03:04 | |
| *** slaweq has quit IRC | 03:06 | |
| *** ociuhandu has quit IRC | 03:10 | |
| *** abaindur has quit IRC | 03:15 | |
| *** mkrai has joined #openstack-nova | 03:17 | |
| *** trungnv has quit IRC | 03:18 | |
| *** slaweq has joined #openstack-nova | 03:30 | |
| *** slaweq has quit IRC | 03:34 | |
| *** udesale has joined #openstack-nova | 03:44 | |
| *** slaweq has joined #openstack-nova | 03:55 | |
| *** slaweq has quit IRC | 03:59 | |
| *** ociuhandu has joined #openstack-nova | 04:05 | |
| *** ociuhandu has quit IRC | 04:10 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| *** slaweq has quit IRC | 04:16 | |
| *** bhagyashris has joined #openstack-nova | 04:19 | |
| *** slaweq has joined #openstack-nova | 04:39 | |
| *** slaweq has quit IRC | 04:46 | |
| *** slaweq has joined #openstack-nova | 04:48 | |
| *** slaweq has quit IRC | 04:53 | |
| *** bhagyashris has quit IRC | 04:57 | |
| *** bhagyashris has joined #openstack-nova | 04:59 | |
| *** dpawlik has joined #openstack-nova | 04:59 | |
| *** slaweq has joined #openstack-nova | 05:00 | |
| *** dpawlik has quit IRC | 05:04 | |
| openstackgerrit | jichenjc proposed openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228 | 05:04 |
| *** ratailor has joined #openstack-nova | 05:07 | |
| *** ociuhandu has joined #openstack-nova | 05:08 | |
| *** slaweq has quit IRC | 05:09 | |
| *** slaweq has joined #openstack-nova | 05:11 | |
| *** ociuhandu has quit IRC | 05:13 | |
| *** slaweq has quit IRC | 05:16 | |
| *** ociuhandu has joined #openstack-nova | 05:30 | |
| *** ociuhandu has quit IRC | 05:35 | |
| *** links has joined #openstack-nova | 05:41 | |
| *** spatel has joined #openstack-nova | 05:43 | |
| *** spatel has quit IRC | 05:47 | |
| *** threestrands has quit IRC | 05:51 | |
| *** psachin has joined #openstack-nova | 06:09 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** Luzi has joined #openstack-nova | 06:11 | |
| *** slaweq has quit IRC | 06:16 | |
| *** chenhaw has joined #openstack-nova | 06:27 | |
| *** huaqiang has joined #openstack-nova | 06:33 | |
| *** pcaruana has joined #openstack-nova | 06:34 | |
| *** dpawlik has joined #openstack-nova | 06:45 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717 | 06:47 |
| *** nanzha has quit IRC | 06:51 | |
| *** nanzha has joined #openstack-nova | 06:51 | |
| *** liuyulong has quit IRC | 07:07 | |
| *** slaweq has joined #openstack-nova | 07:11 | |
| *** lpetrut has joined #openstack-nova | 07:13 | |
| *** slaweq has quit IRC | 07:16 | |
| *** ociuhandu has joined #openstack-nova | 07:20 | |
| *** ociuhandu has quit IRC | 07:20 | |
| *** ociuhandu has joined #openstack-nova | 07:21 | |
| *** nanzha has quit IRC | 07:21 | |
| *** ociuhandu has quit IRC | 07:26 | |
| *** ratailor has quit IRC | 07:28 | |
| *** ratailor has joined #openstack-nova | 07:30 | |
| *** nanzha has joined #openstack-nova | 07:31 | |
| *** belmoreira has joined #openstack-nova | 07:43 | |
| *** jangutter has joined #openstack-nova | 07:51 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:57 | |
| *** slaweq has joined #openstack-nova | 07:57 | |
| *** nanzha has quit IRC | 08:00 | |
| *** nanzha has joined #openstack-nova | 08:01 | |
| *** tesseract has joined #openstack-nova | 08:04 | |
| *** bhagyashris has quit IRC | 08:09 | |
| *** awalende has joined #openstack-nova | 08:16 | |
| *** tkajinam has quit IRC | 08:21 | |
| *** bhagyashris has joined #openstack-nova | 08:24 | |
| *** damien_r has joined #openstack-nova | 08:26 | |
| *** ociuhandu has joined #openstack-nova | 08:28 | |
| *** tosky has joined #openstack-nova | 08:30 | |
| *** nanzha has quit IRC | 08:41 | |
| *** tssurya has joined #openstack-nova | 08:41 | |
| *** nanzha has joined #openstack-nova | 08:43 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to allow live migration with ports https://review.opendev.org/696245 | 08:51 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings https://review.opendev.org/696246 | 08:51 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture https://review.opendev.org/696247 | 08:51 |
| *** ociuhandu has quit IRC | 08:52 | |
| *** ociuhandu has joined #openstack-nova | 08:52 | |
| *** Dinesh_Bhor has joined #openstack-nova | 08:55 | |
| *** ociuhandu has quit IRC | 08:57 | |
| *** rpittau|afk is now known as rpittau | 08:57 | |
| *** ociuhandu has joined #openstack-nova | 08:58 | |
| *** ivve has joined #openstack-nova | 08:58 | |
| *** ccamacho has joined #openstack-nova | 09:02 | |
| *** mns96 has joined #openstack-nova | 09:05 | |
| *** ociuhandu has quit IRC | 09:08 | |
| *** nanzha has quit IRC | 09:11 | |
| *** ralonsoh has joined #openstack-nova | 09:12 | |
| *** nanzha has joined #openstack-nova | 09:13 | |
| *** nanzha has quit IRC | 09:21 | |
| *** nanzha has joined #openstack-nova | 09:25 | |
| *** klippo has quit IRC | 09:27 | |
| *** openstackstatus has quit IRC | 09:30 | |
| *** ociuhandu has joined #openstack-nova | 09:31 | |
| *** nanzha has quit IRC | 09:32 | |
| *** nanzha has joined #openstack-nova | 09:34 | |
| *** udesale has quit IRC | 09:35 | |
| *** udesale has joined #openstack-nova | 09:37 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-network' binary https://review.opendev.org/686816 | 09:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Blast most references to nova-network https://review.opendev.org/686817 | 09:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs https://review.opendev.org/686814 | 09:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove references to nova-net service from tests https://review.opendev.org/686818 | 09:37 |
| kashyap | stephenfin: Isn't 'dissociate' a real word, too? | 09:38 |
| * kashyap looks up ... | 09:38 | |
| *** dpawlik has quit IRC | 09:38 | |
| stephenfin | bauzas: Got time for a daily dose of nova-network removal fun? https://review.opendev.org/#/c/686817/ | 09:39 |
| *** udesale has quit IRC | 09:39 | |
| *** derekh has joined #openstack-nova | 09:39 | |
| kashyap | stephenfin: He said elsewhere he's off for 10-ish minutes as he's changing IPs | 09:39 |
| *** udesale has joined #openstack-nova | 09:39 | |
| kashyap | (Okay, 'dissociate' and 'disassociate' are synonyms, as expected. No gradational difference.) | 09:40 |
| stephenfin | ^ yeah, figured it would be a UK/US English thing | 09:40 |
| *** udesale has quit IRC | 09:41 | |
| *** udesale has joined #openstack-nova | 09:41 | |
| *** udesale has quit IRC | 09:42 | |
| *** udesale has joined #openstack-nova | 09:42 | |
| bauzas | stephenfin: I can, once I figure out how to unbreak my internal network :) | 09:43 |
| *** martinkennelly has joined #openstack-nova | 09:43 | |
| *** bauzas has quit IRC | 09:47 | |
| *** bauzas has joined #openstack-nova | 09:48 | |
| *** nanzha has quit IRC | 09:54 | |
| *** udesale has quit IRC | 10:03 | |
| *** udesale has joined #openstack-nova | 10:04 | |
| openstackgerrit | Edward Hope-Morley proposed openstack/nova stable/rocky: Force refresh instance info_cache during heal https://review.opendev.org/679271 | 10:05 |
| *** jaosorior has joined #openstack-nova | 10:06 | |
| * bauzas is back | 10:09 | |
| bauzas | with a new IPv4 address | 10:09 |
| gibi | bauzas: some feedback on https://review.opendev.org/#/c/670112/ but mosly it looks good. If you respin ping me and I will +2 it | 10:11 |
| bauzas | gibi: I work on a customer issue since 2 days, but sure, thanks | 10:12 |
| gibi | bauzas: ack | 10:13 |
| *** threestrands has joined #openstack-nova | 10:24 | |
| *** rcernin has quit IRC | 10:31 | |
| *** ociuhandu has quit IRC | 10:34 | |
| *** ociuhandu has joined #openstack-nova | 10:34 | |
| *** mlycka has joined #openstack-nova | 10:36 | |
| *** jaosorior has quit IRC | 10:38 | |
| *** ociuhandu has quit IRC | 10:39 | |
| *** rcernin has joined #openstack-nova | 10:46 | |
| *** tkajinam has joined #openstack-nova | 10:50 | |
| *** dtantsur|afk is now known as dtantsur | 10:56 | |
| *** ociuhandu has joined #openstack-nova | 10:59 | |
| *** sapd1 has joined #openstack-nova | 10:59 | |
| *** ociuhandu has quit IRC | 11:04 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: [stable-only] Disable cinder-backup service in nova-next job https://review.opendev.org/690593 | 11:04 |
| *** ociuhandu has joined #openstack-nova | 11:10 | |
| *** ociuhandu has quit IRC | 11:15 | |
| *** udesale has quit IRC | 11:19 | |
| *** ociuhandu has joined #openstack-nova | 11:24 | |
| *** rcernin has quit IRC | 11:31 | |
| *** sapd1 has quit IRC | 11:39 | |
| *** tbachman has quit IRC | 11:43 | |
| *** mkrai has quit IRC | 11:51 | |
| *** s10 has joined #openstack-nova | 11:51 | |
| jangutter | "bauzas: with a new IPv4 address", I read that minutes after reading https://arstechnica.com/gadgets/2019/11/europe-is-fresh-out-of-ipv4-addresses/ | 11:53 |
| s10 | Is it expected with https://review.opendev.org/#/q/I856a3032c83fc2f605d8c9b6e5aa3bcfa415f96a to get errors from the nova-compute on empty hosts like "Could not retrieve compute node resource provider" in code path "if not allocations:"? There are no allocations on hosts without instances, but resource provider exists. | 11:57 |
| *** threestrands has quit IRC | 11:59 | |
| *** gshippey has joined #openstack-nova | 12:06 | |
| s10 | This error came only to the stable/rocky and stable/queens backports. | 12:11 |
| *** tkajinam has quit IRC | 12:11 | |
| *** tkajinam has joined #openstack-nova | 12:15 | |
| *** tkajinam has quit IRC | 12:16 | |
| *** cz2 is now known as swagnemite | 12:16 | |
| *** tbachman has joined #openstack-nova | 12:22 | |
| gibi | s10: there is a bug and a fix proposed https://review.opendev.org/#/c/694581/ | 12:30 |
| *** ratailor has quit IRC | 12:30 | |
| gibi | https://bugs.launchpad.net/nova/+bug/1852759 | 12:31 |
| openstack | Launchpad bug 1852759 in OpenStack Compute (nova) rocky "false error log at compute restart during error out stuck instances" [Low,In progress] - Assigned to Balazs Gibizer (balazs-gibizer) | 12:31 |
| *** ociuhandu has quit IRC | 12:32 | |
| *** ociuhandu has joined #openstack-nova | 12:33 | |
| *** damien_r has quit IRC | 12:34 | |
| openstackgerrit | Surya Seetharaman proposed openstack/nova master: Include removal of ephemeral backing files in the image cache manager https://review.opendev.org/689422 | 12:35 |
| *** ociuhandu has quit IRC | 12:37 | |
| alex_xu | tssurya: I'm not sure whether it is bug. I guess we only trigger that code path when nova side allow normal user can look up other user quota | 12:38 |
| alex_xu | or keystone side policy shrink the authorization | 12:40 |
| tssurya | alex_xu: we have a ML discussion here http://lists.openstack.org/pipermail/openstack-discuss/2019-November/011184.html | 12:40 |
| tssurya | would be great to hear your thoughts too | 12:40 |
| alex_xu | tssurya: cool, i will check | 12:40 |
| *** slaweq has quit IRC | 12:44 | |
| *** dtantsur is now known as dtantsur|brb | 12:48 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova stable/rocky: Fix false ERROR message at compute restart https://review.opendev.org/694581 | 12:55 |
| *** slaweq has joined #openstack-nova | 12:56 | |
| *** damien_r has joined #openstack-nova | 12:59 | |
| *** eharney has joined #openstack-nova | 13:13 | |
| *** dpawlik has joined #openstack-nova | 13:15 | |
| openstackgerrit | Merged openstack/nova stable/stein: Join migration_context and flavor in Migration.instance https://review.opendev.org/696083 | 13:25 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Mask the token used to allow access to consoles https://review.opendev.org/220622 | 13:29 |
| gibi | melwitt, mriedem: I have updated ^^ | 13:29 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Support re-configure the delete_on_termination in server https://review.opendev.org/693828 | 13:32 |
| *** udesale has joined #openstack-nova | 13:38 | |
| *** s10 has quit IRC | 13:40 | |
| *** Luzi has quit IRC | 13:47 | |
| *** tbachman has quit IRC | 13:47 | |
| *** eharney has quit IRC | 13:47 | |
| *** s10 has joined #openstack-nova | 13:48 | |
| *** tbachman has joined #openstack-nova | 13:49 | |
| *** psachin has quit IRC | 13:53 | |
| *** eharney has joined #openstack-nova | 13:55 | |
| *** damien_r has quit IRC | 13:55 | |
| *** gryf has quit IRC | 14:01 | |
| *** bhagyashris has quit IRC | 14:08 | |
| *** tbachman has quit IRC | 14:09 | |
| *** slaweq has quit IRC | 14:13 | |
| *** tbachman has joined #openstack-nova | 14:14 | |
| *** Roamer` has quit IRC | 14:20 | |
| *** ociuhandu has joined #openstack-nova | 14:28 | |
| *** s10 has quit IRC | 14:34 | |
| *** ociuhandu has quit IRC | 14:40 | |
| efried | gibi: you got a minute? | 14:43 |
| gibi | efried: sure | 14:44 |
| efried | I was looking at one of the cyborg patches last night | 14:44 |
| efried | and it led me to looking at how bandwidth resource groups are being sent around | 14:44 |
| efried | which I had never looked at before (I didn't review the original bw series for $reasons) | 14:44 |
| efried | it looks like we're doing this thing where we populate RequestSpec.requested_resources... | 14:46 |
| gibi | yepp | 14:46 |
| efried | ...rather than just populating the ResourceRequest directly from the flavor/image | 14:46 |
| gibi | the bandwidth request is coming from neutron not from flavor/image | 14:47 |
| efried | which makes sense I guess because we need to get the... yes | 14:47 |
| efried | but theoretically... | 14:48 |
| efried | is there a reason we would need to populate requested_resources that way? | 14:48 |
| efried | The difference being that requested_resources is going to be persisted in the RequestSpec as part of the Instance? | 14:48 |
| efried | whereas the ResourceRequest is ephemeral? | 14:48 |
| gibi | RequestSpec.requested_resources is ephemar too | 14:49 |
| gibi | it is explicitly not persisted with the rest of the RequestSpec | 14:49 |
| gibi | as far as I see ResourceRequest is only created right before we generate the a | 14:49 |
| gibi | generate the a_c query | 14:49 |
| gibi | while RequestSpec is created a lot earlier and also kept around a lot more | 14:50 |
| gibi | e.g. sent down to the compute after scheduling | 14:50 |
| *** priteau has joined #openstack-nova | 14:50 | |
| gibi | I think this ML post is at least partially realted http://lists.openstack.org/pipermail/openstack-discuss/2019-May/005920.html | 14:51 |
| efried | gibi: I think what I'm asking (and maybe dansmith also could weigh in on this) is: In general if it's possible simply to use the flavor/image-meta to construct the request groups, like what these guys do: | 14:53 |
| efried | https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/utils.py#L141-L143 | 14:53 |
| efried | ...then would there be any other reason to use RequestSpec.requested_resources instead? | 14:53 |
| * efried reads... | 14:53 | |
| dansmith | efried: that was supposed to be a hack | 14:53 |
| efried | dansmith: which was? the thing I linked? | 14:53 |
| dansmith | because the requested_resources stuff wasn't ready for ... something | 14:53 |
| dansmith | efried: doing it via the flavor | 14:53 |
| gibi | efried: how do you use flavor/image-meta to construct the bandwidth related request groups? | 14:54 |
| efried | gibi: oh, you wouldn't necessarily for bw, I don't know. | 14:55 |
| dansmith | efried: https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/request_filter.py#L188 | 14:55 |
| efried | presumably that one is more involved, requires going back to neutron API etc. | 14:55 |
| efried | dansmith: that makes it sound like using the *request spec* is the hacky one. | 14:56 |
| efried | i.e. if we want to make sure we don't persist the "interpreted request groups", they're better off being put in the ResourceRequest constructor. | 14:56 |
| dansmith | efried: it's using the *flavor* in the request_spec, instead of requested_resources | 14:56 |
| gibi | efried: there is a gap, an itch, something. We have flavor to describe the nova related resource requst, we have the neutron port that describes the networking related resource request. And we need a common, internal place where we collect these. And that should be the RequestSpec. But today we have different ways to collect the resource request there | 14:57 |
| dansmith | efried: there was a big thing when we merged that code, something that couldn't be done with requested_resources because of traits in the unnumbered group or some such, so that flavor-based approach was the workaround until that got resolved | 14:57 |
| dansmith | efried: I'm sure mriedem remembers, but he's out | 14:57 |
| gibi | we store a flavor in the RequestSpec but also a list of RequestGroups | 14:57 |
| *** swagnemite is now known as cz2 | 14:57 | |
| gibi | dansmith, efried: at the moment the requested_resources list does not have _all_ the request groups represented as resources reqeusted throigh the flavor are not added to the requested_resources | 14:58 |
| gibi | so there is no unnumbered group there either | 14:59 |
| dansmith | gibi: I don't remember the details, I could try to find that review | 14:59 |
| efried | Right -- no matter what, ResourceRequest.__init__ is going to parse the flavor. | 14:59 |
| dansmith | gibi: but we couldn't request the trait via requested_resources | 14:59 |
| gibi | dansmith: yes, as you would need to add that to the unnumbered group but there is no unnumbered group in the requested_resources | 14:59 |
| dansmith | ah okay I see | 15:00 |
| gibi | efried: yes, at the end ResourceRequest.__init__ uses the flavor,image and the requested_resources to construc the a_c query | 15:00 |
| dansmith | https://review.opendev.org/#/c/656413/2/nova/scheduler/request_filter.py@105 | 15:01 |
| dansmith | anyway, since the (ab)use of the flavor is only transient, not stored or exposed anywhere, it makes it fairly obscure what is going on, IMHO | 15:01 |
| gibi | https://github.com/openstack/nova/blob/23995b4f9945aa242f6a9e7bd5bc700c27f31eb2/nova/objects/request_spec.py#L491 | 15:01 |
| gibi | here is a TODO that is hard to fix ^^ | 15:02 |
| gibi | as per my mail http://lists.openstack.org/pipermail/openstack-discuss/2019-May/005920.html | 15:02 |
| openstackgerrit | Merged openstack/nova stable/stein: Add --dry-run option to heal_allocations CLI https://review.opendev.org/693199 | 15:02 |
| *** slaweq has joined #openstack-nova | 15:04 | |
| efried | it looks like | 15:07 |
| efried | --> in _provision_instances we populate the RequestSpec.requested_resources, but only with part of the info available | 15:07 |
| efried | --> from select_destinations we call resources_from_request_spec which | 15:07 |
| efried | ---> calls ResourceRequest.__init__ with the RequestSpec, (that ignores the requested_resources and only processes the flavor/image) | 15:07 |
| efried | ---> *then* appends RequestSpec.requested_resources into the ResourceRequest | 15:07 |
| efried | then we call GET /a_c | 15:07 |
| *** ociuhandu has joined #openstack-nova | 15:07 | |
| gibi | yepp that sounds like it | 15:08 |
| efried | _provision_instances happens on the conductor side? | 15:08 |
| gibi | I think it happens at the nova-api side | 15:09 |
| *** links has quit IRC | 15:09 | |
| efried | sorry, yeah, this whole thing happens on the controller side, duh. | 15:09 |
| gibi | it is called from nova.api.openstack.compute.servers.ServersController.create during boot | 15:10 |
| *** belmoreira has quit IRC | 15:13 | |
| *** awalende has quit IRC | 15:19 | |
| *** awalende has joined #openstack-nova | 15:25 | |
| *** ricolin_ has joined #openstack-nova | 15:26 | |
| *** belmoreira has joined #openstack-nova | 15:26 | |
| *** dtantsur|brb is now known as dtantsur | 15:26 | |
| *** ricolin has quit IRC | 15:28 | |
| *** ricolin_ is now known as ricolin | 15:29 | |
| *** awalende has quit IRC | 15:29 | |
| *** ociuhandu has quit IRC | 15:32 | |
| *** ociuhandu has joined #openstack-nova | 15:32 | |
| *** ricolin has quit IRC | 15:34 | |
| *** jaosorior has joined #openstack-nova | 15:34 | |
| efried | gibi, bauzas, stephenfin: do y'all want to have a meeting tomorrow or should I cancel? (US folk will be out) | 15:38 |
| stephenfin | I don't have anything to bring up | 15:39 |
| gibi | me neither but I can be present | 15:39 |
| * stephenfin is still working on nova-network removal. It's awful | 15:39 | |
| efried | let me see if anyone has put topics on the agenda. If not, I'll cancel. | 15:39 |
| efried | it looks like shilpasd wants to talk about disk provider stuff. | 15:40 |
| gibi | I reviewd the sharing disk spec today it looks good to me | 15:41 |
| *** dpawlik has quit IRC | 15:41 | |
| gibi | but somebody else should check at least the API impact part | 15:41 |
| stephenfin | Because it's stuck? | 15:41 |
| stephenfin | Maybe we can unstick it now | 15:41 |
| efried | I don't know. I saw gibi's review but haven't dug in | 15:41 |
| gibi | the API impact part needs eyes I would say | 15:41 |
| gibi | bauzas was involved but he is busy downstream recently | 15:42 |
| efried | If nothing else it gives her a scheduled time to talk to a couple of cores. So, gibi would you mind running that meeting? | 15:42 |
| gibi | efried: I can do that, yes | 15:42 |
| efried | thank you sir. | 15:42 |
| *** mloza has joined #openstack-nova | 15:42 | |
| *** ricolin has joined #openstack-nova | 15:43 | |
| *** damien_r has joined #openstack-nova | 15:43 | |
| *** hoonetorg has quit IRC | 15:51 | |
| bauzas | gibi: efried: thanks | 15:53 |
| bauzas | sorry for being busy at the moment :( | 15:53 |
| gibi | bauzas: no worries | 15:53 |
| * bauzas wants to be more in upstream this cycle | 15:54 | |
| efried | gibi, dansmith: stephenfin: can you see any problem with putting the appending of RequestSpec.resource_requests [1] directly into ResourceRequest.__init__ [2]? | 15:54 |
| efried | [1] https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/utils.py#L546-L551 | 15:54 |
| efried | [2] https://opendev.org/openstack/nova/src/branch/master/nova/scheduler/utils.py#L60 | 15:54 |
| efried | Since we're passing in the RequestSpec anyway, it makes sense to me to consolidate that. | 15:54 |
| gibi | efried: that refactoring make sense to me | 15:55 |
| gibi | efried: is it part of a bigger surgery series? | 15:56 |
| efried | gibi: not specifically, no. It's a standalone "make this shit make more sense to efried" patch. | 15:56 |
| gibi | efried: ack. go for it! | 15:56 |
| melwitt | gibi: ack thanks | 15:57 |
| sean-k-mooney | efried: sorry i was not following but im going to rework my prefilter patches soon | 15:57 |
| sean-k-mooney | what is the tldr of what is beign changed | 15:57 |
| sean-k-mooney | are we ditching adding the stuff to the falvor temportaly and moveing to use requested_resouces | 15:57 |
| sean-k-mooney | which i know was the long term plan | 15:57 |
| stephenfin | efried: Looks sane. I'm not sure why I didn't do that when I refactored all that so might be worth giving git-blame a quick whirl | 15:58 |
| stephenfin | but otherwise LGTM | 15:58 |
| *** amodi has quit IRC | 15:58 | |
| efried | stephenfin: it makes sense why you didn't do it when you refactored ResourceRequest, because (code stack wise) resources_from_request_spec is not actually "near" ResourceRequest.__init__. | 15:59 |
| efried | they're sort of cousins | 15:59 |
| *** tbachman has quit IRC | 15:59 | |
| stephenfin | ah, makes sense | 15:59 |
| efried | and theoretically there would have been more extensive test fallout. Though practically I'm not sure there will be any test impact, as the places that use ResourceRequest.__init__ either don't care about RequestSpec.resource_requests, or *should* care and are currently ignoring it. | 16:00 |
| sean-k-mooney | efried: is the requested_resources in the request spec still just resocue request and not traits | 16:00 |
| efried | sean-k-mooney: It's a list of RequestGroup | 16:00 |
| efried | RequestGroup includes traits | 16:00 |
| efried | well, theoretically it does. | 16:01 |
| efried | I don't know if it actually does for bw | 16:01 |
| efried | but it will for accels | 16:01 |
| sean-k-mooney | right but can i create a resouce group with no resouce requests and just traits | 16:01 |
| efried | um | 16:01 |
| efried | I don't see any reason code-wise that that shouldn't work | 16:03 |
| *** lpetrut has quit IRC | 16:03 | |
| sean-k-mooney | so in my prefilter changes i have this add_trait funciton https://review.opendev.org/#/c/665775/21/nova/scheduler/request_filter.py@52 | 16:03 |
| sean-k-mooney | which when i wrote it i wanted to refactor all the exsiting prefilters to use | 16:04 |
| efried | sean-k-mooney: ...except that I don't think nova is yet using the placement microversion that allows a resourceless request group. | 16:04 |
| *** hoonetorg has joined #openstack-nova | 16:04 | |
| sean-k-mooney | but at least in the prefilter case for image type or the device modeles which im addeing supprot for there are not resouce requests | 16:04 |
| sean-k-mooney | right | 16:04 |
| efried | So: I thought there might be some places in the nova side where we check and forbid resourceless request groups, but I don't see them on a quick skim | 16:05 |
| efried | But: placement is going to bounce it if you try. | 16:05 |
| sean-k-mooney | right so i woudl either have to continue to modify the flavor for the traits case so they get included in the unnumbered group | 16:05 |
| *** awalende has joined #openstack-nova | 16:05 | |
| sean-k-mooney | or we woudl need to increase the microverion we use | 16:06 |
| openstackgerrit | Alexandre arents proposed openstack/nova stable/train: Do not update root_device_name during guest config https://review.opendev.org/696339 | 16:06 |
| efried | which would be nbd, and we're going to want to do it very soon anyway. | 16:06 |
| efried | but hm, I don't see which microversion added support for resourceless request groups. | 16:06 |
| sean-k-mooney | nbd? | 16:07 |
| efried | (no big deal) | 16:07 |
| sean-k-mooney | oh ok cool | 16:07 |
| sean-k-mooney | also i should be in a meeting so brb | 16:07 |
| efried | 1.35 supports root_required, which is actually the place we should be doing traits like that. | 16:07 |
| sean-k-mooney | ok ill read up on that | 16:08 |
| *** ivve has quit IRC | 16:08 | |
| * efried digs up spec | 16:08 | |
| sean-k-mooney | i just want to make sure i can refactor my stuff to work with what you are doining when i start on it again | 16:08 |
| *** tbachman has joined #openstack-nova | 16:09 | |
| efried | so yeah, this appears to have happened https://docs.openstack.org/placement/latest/specs/train/implemented/2005575-nested-magic-1.html#resourceless-request-groups but I can't figure out which microversion we did it in. | 16:09 |
| efried | ah, looks like it's part of the same_subtree microversion. | 16:10 |
| efried | which is 1.36 | 16:10 |
| *** awalende has quit IRC | 16:10 | |
| efried | but for your purposes, root_required might be better | 16:10 |
| efried | in fact, for many things where we're currently just using the unnumbered request group, we should be using root_required instead. | 16:11 |
| efried | that may even let gibi resolve that TODO he mentioned earlier... | 16:11 |
| *** mlavalle has joined #openstack-nova | 16:12 | |
| gibi | efried: interesting. It would remove the motivation (e.g. the pain) to try to do the bigger surgery discussed in the ML post linked above | 16:16 |
| efried | pretty sure that's why we did it in the first place. | 16:16 |
| gibi | I'am totally not against using root_required | 16:18 |
| gibi | for the prefilters | 16:18 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Mask the token used to allow access to consoles https://review.opendev.org/220622 | 16:24 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extend NeutronFixture to handle multiple bindings https://review.opendev.org/696246 | 16:24 |
| *** tbachman has quit IRC | 16:25 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not mock setup net and migrate inst in NeutronFixture https://review.opendev.org/696247 | 16:26 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905 | 16:30 |
| efried | gibi: do bw requests have traits today? | 16:30 |
| *** mloza has quit IRC | 16:30 | |
| gibi | efried: yes they have | 16:31 |
| gibi | custom traits | 16:31 |
| efried | cause there's a few paths that were using ResourceRequest.__init__, without processing RequestSpec.requested_resources, in order to accumulate all the traits for a request. | 16:31 |
| efried | That seems like a hole, but one that probably doesn't matter; I need to look closer at what those traits were being used for. | 16:32 |
| gibi | exampl of a port with resource request http://paste.openstack.org/show/786810/ | 16:32 |
| *** tssurya has quit IRC | 16:32 | |
| gibi | if you see a possible bug then link me to the holes and I will try to help | 16:33 |
| efried | okay, example, isolate_aggregates collects all the traits | 16:34 |
| efried | which means if you wanted to isolate based on a trait in a bw request, it wouldn't work before (but will once I push this "refactor") | 16:34 |
| gibi | ohh | 16:36 |
| gibi | what an interesting feature interaction | 16:36 |
| efried | I guess I should cover that in test, huh. | 16:38 |
| gibi | logically it is a bug but from end user perspective I don't see why the admin would want to isolate aggregates based on physnet or vnic type | 16:39 |
| efried | right. | 16:39 |
| gibi | as those are the two traits that could come today from ports | 16:39 |
| efried | the only other example is libvirt driver accumulating cpu flags, which *should* never exist on a bw request | 16:39 |
| efried | or an accel request?? maybe?? | 16:39 |
| *** macz has joined #openstack-nova | 16:39 | |
| gibi | yeah a bw request will not have cpu flag traits | 16:40 |
| openstackgerrit | Alexandre arents proposed openstack/nova stable/stein: Do not update root_device_name during guest config https://review.opendev.org/696351 | 16:43 |
| openstackgerrit | Alexandre arents proposed openstack/nova stable/rocky: Do not update root_device_name during guest config https://review.opendev.org/696353 | 16:44 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Process requested_resources in ResourceRequest init https://review.opendev.org/696354 | 16:46 |
| efried | gibi, stephenfin: ^ | 16:46 |
| gibi | efried: ack | 16:49 |
| *** udesale has quit IRC | 16:53 | |
| *** _gryf has joined #openstack-nova | 16:53 | |
| *** udesale has joined #openstack-nova | 16:55 | |
| *** _gryf is now known as gryf | 16:55 | |
| *** eharney has quit IRC | 17:00 | |
| *** dtantsur is now known as dtantsur|brb | 17:01 | |
| stephenfin | efried: Care to send this docs patch on its way? https://review.opendev.org/#/c/686817 | 17:03 |
| efried | ... | 17:03 |
| *** tosky has quit IRC | 17:03 | |
| stephenfin | I chose you by lucky dip, if that makes you feel better | 17:04 |
| stephenfin | I imagine it does | 17:05 |
| *** ociuhandu has quit IRC | 17:05 | |
| *** udesale has quit IRC | 17:06 | |
| * efried googles "lucky dip" | 17:20 | |
| efried | got it. And I was folded funny, so I got picked. | 17:20 |
| efried | btw, '...' is "on it, please stand by". | 17:21 |
| efried | dunno why so many people are confused by that. | 17:21 |
| *** mns96 has quit IRC | 17:24 | |
| *** tbachman has joined #openstack-nova | 17:40 | |
| efried | stephenfin: +2, couple of typos, I'll fast approve if you want to respin for those. | 17:40 |
| efried | afaict no conflicts on the subsequent patches, so no need to rebase them | 17:41 |
| efried | did I miss you? :( | 17:43 |
| sean-k-mooney | maybe ill ping him on watsap an tell him to check irc but he normally heads home around now | 17:48 |
| *** martinkennelly has quit IRC | 17:48 | |
| *** tesseract has quit IRC | 17:53 | |
| *** david-lyle has joined #openstack-nova | 17:54 | |
| *** dklyle has quit IRC | 17:55 | |
| *** priteau has quit IRC | 17:55 | |
| *** alex_xu has quit IRC | 17:57 | |
| *** derekh has quit IRC | 18:01 | |
| efried | dansmith: do we need RPC version bump when adding a method to an OVO? | 18:11 |
| dansmith | no | 18:11 |
| efried | cool, thx | 18:12 |
| dansmith | efried: if it's remotable, you need a version bump on the object, but neither affect a regular rpc interface | 18:12 |
| efried | if the *method* is remotable? | 18:12 |
| dansmith | only methods are remotable, so.. yes | 18:12 |
| efried | (as opposed to the *object*, which doesn't make sense... yeah) | 18:12 |
| dansmith | objects are sendable over rpc only if they are *registered*, but their version(s) are handled independently (and automatically) from rpc versions | 18:13 |
| *** rpittau is now known as rpittau|afk | 18:14 | |
| openstackgerrit | Merged openstack/nova stable/stein: [stable-only] Disable cinder-backup service in nova-next job https://review.opendev.org/690593 | 18:15 |
| *** ricolin has quit IRC | 18:16 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Reusable RequestGroup.add_{resource|trait} https://review.opendev.org/696380 | 18:19 |
| efried | gibi, stephenfin: there's another sanity refactor ^ | 18:19 |
| *** dtantsur|brb is now known as dtantsur | 18:20 | |
| *** gouthamr has quit IRC | 18:20 | |
| *** gouthamr has joined #openstack-nova | 18:21 | |
| *** huaqiang has quit IRC | 18:23 | |
| *** rnoriega- has quit IRC | 18:23 | |
| *** huaqiang has joined #openstack-nova | 18:23 | |
| *** Alon_KS has quit IRC | 18:23 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: docs: Blast most references to nova-network https://review.opendev.org/686817 | 18:26 |
| *** dtantsur has quit IRC | 18:27 | |
| *** macz has quit IRC | 18:27 | |
| *** Alon_KS has joined #openstack-nova | 18:27 | |
| efried | stephenfin: I went ahead and fixed up those typos and fast approved that docs patch ^ | 18:28 |
| *** dtantsur has joined #openstack-nova | 18:29 | |
| *** rnoriega_ has joined #openstack-nova | 18:29 | |
| *** jangutter has quit IRC | 18:31 | |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | 18:52 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | 18:52 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | 18:52 |
| openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | 18:52 |
| *** mlycka has quit IRC | 18:54 | |
| *** jaosorior has quit IRC | 19:01 | |
| *** ociuhandu has joined #openstack-nova | 19:22 | |
| *** damien_r has quit IRC | 19:25 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: Make removal of host from aggregate consistent https://review.opendev.org/696392 | 19:29 |
| *** spsurya has quit IRC | 19:30 | |
| *** ralonsoh has quit IRC | 19:31 | |
| *** amodi has joined #openstack-nova | 19:41 | |
| *** dtantsur is now known as dtantsur|afk | 19:46 | |
| *** mdbooth has quit IRC | 19:57 | |
| *** mdbooth has joined #openstack-nova | 19:58 | |
| *** _gryf has joined #openstack-nova | 20:03 | |
| *** david-lyle has quit IRC | 20:04 | |
| *** bbowen has quit IRC | 20:05 | |
| *** gryf is now known as _gryf_ | 20:05 | |
| *** _gryf is now known as gryf | 20:05 | |
| *** haleyb is now known as haleyb|away | 20:06 | |
| *** ociuhandu has quit IRC | 20:09 | |
| *** dklyle has joined #openstack-nova | 20:16 | |
| *** pooja_pf9 has joined #openstack-nova | 20:25 | |
| *** mloza has joined #openstack-nova | 20:28 | |
| *** maciejjozefczyk has quit IRC | 20:33 | |
| *** ociuhandu has joined #openstack-nova | 20:43 | |
| *** ociuhandu has quit IRC | 20:48 | |
| *** artom has quit IRC | 21:09 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Reusable RequestGroup.add_{resource|trait} https://review.opendev.org/696380 | 21:38 |
| *** bbowen has joined #openstack-nova | 21:45 | |
| *** artom has joined #openstack-nova | 21:49 | |
| *** slaweq has quit IRC | 21:49 | |
| *** bbowen has quit IRC | 21:54 | |
| *** rcernin has joined #openstack-nova | 21:56 | |
| *** ociuhandu has joined #openstack-nova | 22:02 | |
| *** tobias-urdin has left #openstack-nova | 22:05 | |
| *** pcaruana has quit IRC | 22:06 | |
| *** ociuhandu has quit IRC | 22:07 | |
| *** ociuhandu has joined #openstack-nova | 22:29 | |
| efried | dansmith: still around? | 22:42 |
| efried | mm, now I see where you said you were headed out early | 22:43 |
| *** ociuhandu has quit IRC | 22:44 | |
| *** CeeMac has joined #openstack-nova | 22:48 | |
| *** pooja_pf9 has quit IRC | 22:51 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: Make removal of host from aggregate consistent https://review.opendev.org/696392 | 23:05 |
| *** ociuhandu has joined #openstack-nova | 23:07 | |
| *** ociuhandu has quit IRC | 23:11 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Reusable RequestGroup.add_{resource|trait} https://review.opendev.org/696380 | 23:17 |
| openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use string suffixes and provider mappings https://review.opendev.org/696418 | 23:17 |
| efried | gibi: ^ ! | 23:17 |
| *** efried is now known as efried_pto | 23:23 | |
| *** mlavalle has quit IRC | 23:48 | |
| *** ociuhandu has joined #openstack-nova | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!