| *** jmlowe has quit IRC | 00:01 | |
| *** slaweq has joined #openstack-nova | 00:11 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 00:11 |
|---|---|---|
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | 00:11 |
| openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | 00:11 |
| *** slaweq has quit IRC | 00:16 | |
| *** tbachman has quit IRC | 00:17 | |
| *** damien_r has quit IRC | 00:18 | |
| *** damien_r has joined #openstack-nova | 00:19 | |
| *** igordc has quit IRC | 00:28 | |
| *** tetsuro has joined #openstack-nova | 00:32 | |
| *** damien_r has quit IRC | 00:40 | |
| *** igordc has joined #openstack-nova | 00:59 | |
| *** luksky has quit IRC | 01:04 | |
| *** gyee has quit IRC | 01:13 | |
| *** Liang__ has joined #openstack-nova | 01:40 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655 | 01:48 |
| *** TxGirlGeek has quit IRC | 01:49 | |
| *** brinzhang has joined #openstack-nova | 01:50 | |
| *** damien_r has joined #openstack-nova | 02:02 | |
| *** damien_r has quit IRC | 02:02 | |
| *** damien_r has joined #openstack-nova | 02:02 | |
| *** tinwood has quit IRC | 02:10 | |
| *** slaweq has joined #openstack-nova | 02:11 | |
| *** tinwood has joined #openstack-nova | 02:12 | |
| *** slaweq has quit IRC | 02:16 | |
| *** gentoora- has joined #openstack-nova | 02:29 | |
| *** gentoorax has quit IRC | 02:30 | |
| *** gentoora- is now known as gentoorax | 02:30 | |
| *** nweinber has joined #openstack-nova | 02:37 | |
| *** ccamacho has quit IRC | 02:50 | |
| *** brinzhang has quit IRC | 02:59 | |
| *** nweinber has quit IRC | 03:07 | |
| *** nweinber has joined #openstack-nova | 03:09 | |
| *** sapd1 has joined #openstack-nova | 03:20 | |
| *** adriant has quit IRC | 03:26 | |
| *** psachin has joined #openstack-nova | 03:35 | |
| *** nweinber has quit IRC | 03:39 | |
| *** damien_r has quit IRC | 03:42 | |
| *** damien_r has joined #openstack-nova | 03:54 | |
| *** damien_r has quit IRC | 04:01 | |
| *** igordc has quit IRC | 04:08 | |
| *** slaweq has joined #openstack-nova | 04:11 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 04:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581 | 04:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245 | 04:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 04:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940 | 04:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553 | 04:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554 | 04:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227 | 04:14 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | 04:14 |
| *** slaweq has quit IRC | 04:16 | |
| *** damien_r has joined #openstack-nova | 04:34 | |
| *** damien_r has quit IRC | 04:39 | |
| *** udesale has joined #openstack-nova | 04:40 | |
| *** sapd1 has quit IRC | 04:46 | |
| *** ociuhandu has joined #openstack-nova | 04:58 | |
| *** sapd1 has joined #openstack-nova | 04:59 | |
| *** links has joined #openstack-nova | 05:00 | |
| *** ociuhandu has quit IRC | 05:02 | |
| *** adriant has joined #openstack-nova | 05:05 | |
| *** jmlowe has joined #openstack-nova | 05:05 | |
| *** jmlowe has quit IRC | 05:08 | |
| *** adriant has quit IRC | 05:09 | |
| *** damien_r has joined #openstack-nova | 05:09 | |
| *** adriant has joined #openstack-nova | 05:10 | |
| *** damien_r has quit IRC | 05:14 | |
| *** jmlowe has joined #openstack-nova | 05:16 | |
| *** sapd1 has quit IRC | 05:24 | |
| *** damien_r has joined #openstack-nova | 05:32 | |
| *** damien_r has quit IRC | 05:37 | |
| *** brinzhang has joined #openstack-nova | 05:41 | |
| *** jmlowe has quit IRC | 05:55 | |
| *** jmlowe has joined #openstack-nova | 05:57 | |
| *** jmlowe has quit IRC | 06:04 | |
| *** damien_r has joined #openstack-nova | 06:06 | |
| *** hariii2503 has joined #openstack-nova | 06:10 | |
| *** slaweq has joined #openstack-nova | 06:11 | |
| *** damien_r has quit IRC | 06:11 | |
| *** slaweq has quit IRC | 06:16 | |
| hariii2503 | Hi Guys . I am writing a python script to get some data from nova python client . | 06:29 |
| hariii2503 | I m getting authentication error , when I used below commands | 06:29 |
| hariii2503 | from novaclient import client | 06:30 |
| hariii2503 | nova = client.Client(VERSION, USERNAME, PASSWORD, PROJECT_ID, AUTH_URL) | 06:30 |
| hariii2503 | nova.servers.list() | 06:30 |
| hariii2503 | Please help me in this | 06:30 |
| hariii2503 | openstack version is stein | 06:30 |
| *** Liang__ has quit IRC | 06:30 | |
| *** ratailor has joined #openstack-nova | 06:34 | |
| *** damien_r has joined #openstack-nova | 06:44 | |
| *** udesale_ has joined #openstack-nova | 06:46 | |
| *** brinzhang has quit IRC | 06:47 | |
| *** udesale has quit IRC | 06:47 | |
| *** damien_r has quit IRC | 06:49 | |
| *** slaweq has joined #openstack-nova | 07:06 | |
| *** diconico07 has quit IRC | 07:06 | |
| *** eharney has quit IRC | 07:08 | |
| *** luksky has joined #openstack-nova | 07:14 | |
| *** eharney has joined #openstack-nova | 07:21 | |
| *** jawad_axd has joined #openstack-nova | 07:26 | |
| *** ratailor has quit IRC | 07:26 | |
| *** brinzhang has joined #openstack-nova | 07:27 | |
| *** ratailor has joined #openstack-nova | 07:27 | |
| *** ralonsoh has joined #openstack-nova | 07:31 | |
| *** brinzhang has quit IRC | 07:45 | |
| openstackgerrit | Victor Coutellier proposed openstack/nova-specs master: Non-admin user can filter their instances by AZs https://review.opendev.org/701763 | 07:45 |
| *** brinzhang has joined #openstack-nova | 07:45 | |
| *** tesseract has joined #openstack-nova | 07:47 | |
| *** damien_r has joined #openstack-nova | 07:51 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:53 | |
| *** damien_r has quit IRC | 07:56 | |
| *** udesale_ has quit IRC | 07:58 | |
| *** udesale_ has joined #openstack-nova | 07:58 | |
| openstackgerrit | Victor Coutellier proposed openstack/nova-specs master: Non-admin user can filter their instances by AZs https://review.opendev.org/701763 | 08:04 |
| *** dpawlik has quit IRC | 08:14 | |
| *** rpittau|afk is now known as rpittau | 08:14 | |
| *** tkajinam has quit IRC | 08:15 | |
| *** ccamacho has joined #openstack-nova | 08:19 | |
| *** damien_r has joined #openstack-nova | 08:22 | |
| *** dpawlik has joined #openstack-nova | 08:23 | |
| *** udesale_ has quit IRC | 08:28 | |
| *** damien_r has quit IRC | 08:35 | |
| *** HagunKim has joined #openstack-nova | 08:36 | |
| *** iurygregory has joined #openstack-nova | 08:42 | |
| *** tosky has joined #openstack-nova | 08:46 | |
| *** damien_r has joined #openstack-nova | 08:51 | |
| *** damien_r has quit IRC | 08:55 | |
| *** luksky has quit IRC | 08:58 | |
| *** damien_r has joined #openstack-nova | 09:13 | |
| *** xek_ has joined #openstack-nova | 09:17 | |
| *** damien_r has quit IRC | 09:18 | |
| *** ivve has joined #openstack-nova | 09:19 | |
| *** dtantsur|afk is now known as dtantsur | 09:29 | |
| *** derekh has joined #openstack-nova | 09:33 | |
| *** udesale has joined #openstack-nova | 09:35 | |
| *** luksky has joined #openstack-nova | 09:35 | |
| *** damien_r has joined #openstack-nova | 09:38 | |
| *** martinkennelly has joined #openstack-nova | 09:38 | |
| *** kiseok7 has quit IRC | 09:39 | |
| *** damien_r has quit IRC | 09:42 | |
| *** damien_r has joined #openstack-nova | 09:46 | |
| *** damien_r has quit IRC | 09:51 | |
| openstackgerrit | Victor Coutellier proposed openstack/nova-specs master: Non-Admin user can filter their instances by more filters https://review.opendev.org/701763 | 09:54 |
| *** damien_r has joined #openstack-nova | 09:56 | |
| *** damien_r has quit IRC | 10:01 | |
| stephenfin | bauzas: Could you hit https://review.opendev.org/#/c/695380/ ? | 10:05 |
| stephenfin | Appears to be the only remaining issue we have for the py3 goal | 10:05 |
| *** salmankhan has joined #openstack-nova | 10:09 | |
| *** IvensZambrano has joined #openstack-nova | 10:24 | |
| *** ratailor has quit IRC | 10:24 | |
| *** ratailor has joined #openstack-nova | 10:26 | |
| *** ratailor has quit IRC | 10:26 | |
| *** ratailor has joined #openstack-nova | 10:27 | |
| *** spatel has joined #openstack-nova | 10:29 | |
| *** ratailor has quit IRC | 10:29 | |
| *** IvensZambrano has quit IRC | 10:30 | |
| *** ratailor has joined #openstack-nova | 10:30 | |
| *** ratailor has quit IRC | 10:31 | |
| *** ratailor has joined #openstack-nova | 10:32 | |
| *** spatel has quit IRC | 10:34 | |
| *** ratailor has quit IRC | 10:40 | |
| *** ratailor has joined #openstack-nova | 10:41 | |
| *** ratailor has quit IRC | 10:41 | |
| *** ratailor has joined #openstack-nova | 10:44 | |
| *** pcaruana has quit IRC | 10:46 | |
| *** spatel has joined #openstack-nova | 10:47 | |
| jawad_axd | Hi all ! Question is, from instances, download/upload speed is around 10MB/s while from underlying host is 80MB/s. How can I increase/tune bandwidth parameters? I am using Stein,linux bridge,vxlans setup.Any pointers? | 10:51 |
| *** udesale has quit IRC | 10:53 | |
| *** ratailor_ has joined #openstack-nova | 10:55 | |
| *** ratailor has quit IRC | 10:58 | |
| *** damien_r has joined #openstack-nova | 11:04 | |
| *** damien_r has quit IRC | 11:09 | |
| *** damien_r has joined #openstack-nova | 11:13 | |
| *** rpittau is now known as rpittau|bbl | 11:14 | |
| donnyd | @jawad_axd you need to look for your bottleneck. Download speeds can depend on a lot of different things | 11:22 |
| donnyd | maybe start with some simple iperf testing in and out of the tenant space. | 11:22 |
| donnyd | What are you using for a storage backend on your instances - that is the second place i would look | 11:23 |
| donnyd | maybe also try some fio disk benchmarking to ensure your instances can write to disk at faster than 10MB/s | 11:24 |
| *** ociuhandu has joined #openstack-nova | 11:25 | |
| *** ociuhandu has quit IRC | 11:26 | |
| *** ociuhandu has joined #openstack-nova | 11:26 | |
| jawad_axd | @donnyd I am using ceph as storage backend. | 11:29 |
| donnyd | I would start with a disk benchmark then | 11:30 |
| jawad_axd | Okay..thats good pointer. I will look into it. Thanks | 11:30 |
| donnyd | also maybe reachout to #openstack-operators | 11:30 |
| jawad_axd | Sure. | 11:31 |
| donnyd | that is where all the operators hang out and you may get to an end a little sooner there | 11:31 |
| *** ociuhandu has quit IRC | 11:31 | |
| donnyd | np @jawad_axd | 11:32 |
| *** avolkov has joined #openstack-nova | 11:36 | |
| *** ratailor_ has quit IRC | 11:46 | |
| *** pcaruana has joined #openstack-nova | 11:48 | |
| *** brinzhang has quit IRC | 11:52 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: Fix volume attachment rollback https://review.opendev.org/704847 | 11:57 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Re-propose the flavor extra spec validation spec https://review.opendev.org/682655 | 12:09 |
| *** damien_r has quit IRC | 12:17 | |
| *** damien_r has joined #openstack-nova | 12:18 | |
| openstackgerrit | sean mooney proposed openstack/os-vif master: [OVS] VLAN tag should be set in the Port register https://review.opendev.org/703373 | 12:19 |
| *** pcaruana has quit IRC | 12:21 | |
| *** damien_r has quit IRC | 12:22 | |
| *** mvkr has quit IRC | 12:26 | |
| gibi | stephenfin: there are two additional places that uses USE_PYTHON3 in our tree. Can we get rid of those as well now? https://review.opendev.org/#/c/695380 | 12:32 |
| sean-k-mooney | gibi: you mean in the legacy jobs | 12:35 |
| sean-k-mooney | gibi: we could remove them there at this point too however i htink we might need to keep it for grenade | 12:35 |
| *** xek_ has quit IRC | 12:36 | |
| gibi | sean-k-mooney: do we have grenade job where the from state is py27 and the dest state is py36? | 12:36 |
| sean-k-mooney | no | 12:36 |
| sean-k-mooney | at least not intentionally | 12:36 |
| sean-k-mooney | we are having issue related to that however | 12:37 |
| sean-k-mooney | specificly because on train devstack install under py2 and py3 on train when you enable py3 | 12:37 |
| gibi | I see. | 12:37 |
| gibi | my knowledge is limited here so I follow your lead | 12:38 |
| sean-k-mooney | and that causees issues with osc and other console script still being the python 2 version in the py3 only ussuri | 12:38 |
| sean-k-mooney | gibi: i belive its still one of the issue tosky is trying to fix in the new zuul v3 native grenade job to get plugins to work | 12:38 |
| gibi | sean-k-mooney: OK, thanks | 12:39 |
| gibi | stephenfin: +A-d https://review.opendev.org/#/c/695380/ | 12:39 |
| sean-k-mooney | gibi: did you have a chance to review the numa proposal following the conversation efried and i had yesterday | 12:40 |
| stephenfin | gibi: Thanks. Looks like sean-k-mooney addressed your earlier question :) | 12:40 |
| sean-k-mooney | stephenfin: acully ^ goes for you and bauzas | 12:40 |
| stephenfin | I saw the etherpad, yup. LGTM | 12:42 |
| sean-k-mooney | stephenfin: bauzas gibi https://review.opendev.org/#/c/552924/15/specs/ussuri/approved/numa-topology-with-rps.rst@126 is the main comment. | 12:42 |
| sean-k-mooney | stephenfin: cool | 12:43 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Re-propose the flavor extra spec validation spec https://review.opendev.org/682655 | 12:43 |
| sean-k-mooney | hehe i was just reviewing that | 12:43 |
| sean-k-mooney | although its small so ill start again | 12:43 |
| gibi | sean-k-mooney: I read the scrollback but did not read the etherpad and the review yet. stay tuned | 12:45 |
| sean-k-mooney | will do | 12:46 |
| sean-k-mooney | the etherpad has a diagram which hopefully makes the design clear | 12:46 |
| sean-k-mooney | when it comes to placement pictures help a lot | 12:46 |
| gibi | totally agree ^^ | 12:47 |
| sean-k-mooney | stephenfin: im happy with the latest version of the extra spec validation | 12:55 |
| gibi | stephenfin: I have one, hopefully the last question in https://review.opendev.org/#/c/682655/5/specs/ussuri/approved/flavor-extra-spec-validators.rst@152 | 12:58 |
| openstackgerrit | Merged openstack/nova-specs master: Non-Admin user can filter their instances by more filters https://review.opendev.org/701763 | 13:02 |
| stephenfin | gibi: replied | 13:03 |
| *** damien_r has joined #openstack-nova | 13:03 | |
| sean-k-mooney | stephenfin: if you are storing the validator in a dict you could use set_defautl to get the right behavior | 13:06 |
| sean-k-mooney | depending on how you are doing the lookup | 13:06 |
| stephenfin | set_default? | 13:06 |
| sean-k-mooney | on a dict set default only sets the value if the key is not already present | 13:07 |
| stephenfin | oh, I was going to hard fail if it was there | 13:07 |
| stephenfin | rather than ignore it | 13:07 |
| sean-k-mooney | so if you regeister all the intree ones first by namespace and then the out of tree ones the intree would win | 13:07 |
| sean-k-mooney | ya thats an option | 13:08 |
| sean-k-mooney | but i have found that if you try to block peole doing things they will find a way to work around it | 13:08 |
| sean-k-mooney | like with os-vif | 13:08 |
| sean-k-mooney | we blocked people form importing our internal module by requireing the plugins to start with os_vif to only support intree plugins | 13:09 |
| sean-k-mooney | so a vendor that will go unnamed renamed there plugin to be able to import them | 13:09 |
| stephenfin | \o/ | 13:10 |
| kashyap | Stable folks, am I correct in assuming that this is a "feature" and not a likely backport candidate for Train? -- https://opendev.org/openstack/nova/commit/de512f2c02 | 13:12 |
| gibi | stephenfin: thank. I'm +2 on the extra spec validation again | 13:12 |
| kashyap | It's a small, non-invasive change, though | 13:12 |
| sean-k-mooney | kashyap changing default ya i think that is not a backport candiate | 13:13 |
| stephenfin | kashyap: not stable-core, but the change in behaviour of the extra spec suggests to me it's not backportable, no | 13:13 |
| stephenfin | jinx | 13:13 |
| sean-k-mooney | :) | 13:13 |
| stephenfin | gimme my coke, damn it | 13:13 |
| lyarwood | yup, I wouldn't describe it as non-invasive tbh | 13:13 |
| kashyap | stephenfin: sean-k-mooney: Yeah, guessed as much | 13:13 |
| sean-k-mooney | kashyap: also i missed that merging congrats its nice to have that done | 13:13 |
| sean-k-mooney | kashyap: i also would not really like to backport that downstream | 13:14 |
| kashyap | lyarwood: Yeah, I was a "broad" def of "non-invasive" (db changes, etc) | 13:14 |
| kashyap | sean-k-mooney: I won't. Just wondering, in case people come knocking | 13:14 |
| sean-k-mooney | kashyap: we could maybe add it to 16 since that is not released yet | 13:14 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: api: Add support for extra spec validation https://review.opendev.org/704643 | 13:14 |
| *** ociuhandu has joined #openstack-nova | 13:14 | |
| sean-k-mooney | but ya i think that will have to wait to 17 | 13:14 |
| stephenfin | don't bother reviewing that ^ I've still a lot to do | 13:15 |
| sean-k-mooney | stephenfin: by the way you dont need to my "we shoudl really move this" comments | 13:15 |
| stephenfin | eh, it's good to note for the future | 13:16 |
| sean-k-mooney | we shoudl totally rename/move them at somepoint but ya not related to your work | 13:16 |
| *** hariii2503 has quit IRC | 13:17 | |
| stephenfin | efried: When you're about, if you'd care to provide docs for these (or point me to someone that could) I'd be most grateful https://review.opendev.org/#/c/704643/3/nova/api/validation/extra_specs/powervm.py | 13:17 |
| tosky | sean-k-mooney, gibi: we don't have jobs which starts from py27 and ends with py3*; the patch which backports the "don't install python2 library packages" has been backported to train a few hours ago, so grenade jobs should be fine for a final review (and merge) now | 13:18 |
| gibi | sean-k-mooney, efried: I like the numa modeling proposal. thanks for crafting it | 13:18 |
| gibi | tosky: ack, thanks | 13:19 |
| tosky | gibi: afaik (gmann can provide a better answer), we don't support at all that py2->py3 scenario; if you want to test the train->master migration, just deploy train with py3 | 13:20 |
| sean-k-mooney | tosky: awsome | 13:20 |
| *** ociuhandu has quit IRC | 13:20 | |
| sean-k-mooney | tosky: that more because we dont have a good way of cleaning the packages | 13:21 |
| *** maciejjozefczyk has quit IRC | 13:21 | |
| gmann | yeah and do not have someone to do that | 13:21 |
| sean-k-mooney | well we are also not sure if there could in be a difference in the rpc traffic somehow | 13:22 |
| sean-k-mooney | we dont think there will be but that was one of the worries. e.g. the ovo we send over amqp could some how be incompatiable | 13:23 |
| *** xek has joined #openstack-nova | 13:23 | |
| sean-k-mooney | i dont think that is the case but i know it was raised in the past | 13:23 |
| sean-k-mooney | no one has reported upgrade issues at least so its untested in the gate but appears to work in reality | 13:24 |
| *** nweinber has joined #openstack-nova | 13:26 | |
| *** artom has quit IRC | 13:26 | |
| gmann | yeah, other integration py2 job on train or older release along with py3 jobs can tell both py version works well and should not be issue on upgrade with py2 version too. but yes it is not tested on gate. | 13:26 |
| gibi | stephenfin: if you can fix the funct test then I can +2 https://review.opendev.org/#/c/662522 | 13:28 |
| *** rpittau|bbl is now known as rpittau | 13:29 | |
| *** maciejjozefczyk has joined #openstack-nova | 13:30 | |
| *** mlycka has joined #openstack-nova | 13:31 | |
| *** mlycka has quit IRC | 13:31 | |
| *** mrch_ has joined #openstack-nova | 13:47 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | 13:55 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/695180 | 13:55 |
| bauzas | gibi: I updated the audit command for fixing the tests | 14:00 |
| bauzas | gibi: I also saw your other change for the PlacementFixture | 14:00 |
| bauzas | as you want | 14:00 |
| efried | stephenfin: Hah, "docs". | 14:01 |
| efried | I fear there were never actually docs. But let me go refresh my memory on where they're translated over to actual PowerVM-isms (which *should* have docs... somewhere). | 14:03 |
| *** pcaruana has joined #openstack-nova | 14:03 | |
| efried | I don't think it would be super unreasonable for you to assign the work to the #openstack-powervm team to track that down. But only if you don't want it to get done. | 14:04 |
| openstackgerrit | Merged openstack/nova-specs master: Add action event fault details https://review.opendev.org/699669 | 14:04 |
| *** alistarle has joined #openstack-nova | 14:07 | |
| gibi | bauzas: ack, I will look back after my call | 14:07 |
| *** alistarle has quit IRC | 14:08 | |
| *** bjolo has joined #openstack-nova | 14:09 | |
| openstackgerrit | Merged openstack/os-vif master: move os-vif-ovs to be a non legacy job. https://review.opendev.org/701601 | 14:10 |
| openstackgerrit | Merged openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support" https://review.opendev.org/703672 | 14:10 |
| sean-k-mooney | efried: am i wrong in thinking that all extra spec are ment to have a spec or at least a blueprint associated with them when added | 14:10 |
| sean-k-mooney | efried: today we would also add docs and a release note to that list | 14:10 |
| efried | sean-k-mooney: I don't recall a rule like that, but it's not a bad one. | 14:11 |
| sean-k-mooney | but im wondering if those would be documented in the nova spec repo | 14:11 |
| sean-k-mooney | efried: well its technically an api change even though its an unversioned one | 14:11 |
| efried | You'll have to slap my five-years-ago wrist. | 14:11 |
| sean-k-mooney | normally the accompany bigger features so they get pulled into a spec or blueprint by default | 14:12 |
| efried | There certainly aren't in-repo docs for the powervm: extra specs. | 14:12 |
| efried | or in the oot driver repo, for that matter. | 14:13 |
| openstackgerrit | waleed mousa proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/705018 | 14:13 |
| sean-k-mooney | so looks like it was intoduced in tree in ocata | 14:14 |
| sean-k-mooney | https://github.com/openstack/nova-specs/blob/master/specs/ocata/approved/powervm-nova-compute-driver.rst | 14:14 |
| sean-k-mooney | actully pike | 14:15 |
| efried | took us a while | 14:15 |
| efried | I don't think you'll find docs for the extra specs though. | 14:15 |
| sean-k-mooney | its ther in queens too | 14:16 |
| sean-k-mooney | look liek ye added feature each release for a few releases | 14:16 |
| efried | yes | 14:16 |
| efried | stephenfin: This is going to be a manual process (for someone) I'm afraid. | 14:16 |
| sean-k-mooney | speaking of manual proces i better go update the spec repo with the implemented spec for train | 14:17 |
| sean-k-mooney | there is a script to do that it just needs to be run | 14:18 |
| *** eharney has quit IRC | 14:18 | |
| *** dtantsur is now known as dtantsur|brb | 14:18 | |
| sean-k-mooney | but ya no info in the spec repo. i guess sice it was out of tree there was no need | 14:18 |
| *** mriedem has joined #openstack-nova | 14:19 | |
| efried | it just goes to show that the only consumer was internal anyway, and already knew what all that stuff meant. | 14:19 |
| sean-k-mooney | when yw were working on it day to day | 14:19 |
| sean-k-mooney | hopefully there are code comments for each of them | 14:20 |
| efried | nope. | 14:20 |
| efried | I never knew/understood all of them even when I was working on it day to day. | 14:20 |
| efried | Very specialized knowledge for operators of a power data center. | 14:20 |
| efried | some pretty mysterious stuff in there. | 14:20 |
| sean-k-mooney | in that case the only thing that will save us is commit history | 14:20 |
| efried | no | 14:20 |
| efried | commit history won't help | 14:20 |
| efried | why would commit history have documentation if we don't have documentation? | 14:21 |
| sean-k-mooney | the commit that added it should at least explain what it does to soem degree | 14:21 |
| sean-k-mooney | am i hoping for too much | 14:21 |
| efried | yeah, no. | 14:21 |
| *** dklyle has quit IRC | 14:21 | |
| efried | Maybe for newer ones that were added after the main blob was put in. | 14:22 |
| sean-k-mooney | well then i second your suggest to punt this to #openstack-powervm | 14:22 |
| sean-k-mooney | oh i ment the out of tree drivers git repo history not the nova one | 14:23 |
| efried | yeah, I know what you meant. Same answer. | 14:23 |
| sean-k-mooney | :) | 14:23 |
| sean-k-mooney | im going to grab breakfast/lunch brb | 14:24 |
| efried | Oh snap! stephenfin: turns out PowerVC (the $ product that sits on top of this) allows you to pass the extra specs through, and actually documented them: https://www.ibm.com/support/knowledgecenter/SSXK2N_1.4.4/com.ibm.powervc.standard.help.doc/powervc_pg_flavorsextraspecs_hmc.html | 14:29 |
| *** ociuhandu has joined #openstack-nova | 14:29 | |
| *** Liang__ has joined #openstack-nova | 14:32 | |
| *** psachin has quit IRC | 14:32 | |
| *** links has quit IRC | 14:33 | |
| *** pcaruana has quit IRC | 14:34 | |
| sean-k-mooney | damb good fined. so ya powervm:dedicated_proc is cpu pinning like i guessed | 14:35 |
| efried | As you probably already figured out, VMBuilder._ATTRS_MAP [1] is the list of extra specs the powervm driver pays attention to. | 14:35 |
| efried | And we know those are all the allowable keys because [2] and [3]. | 14:35 |
| efried | I think you'll find these are a subset of what's in the above doc; that's just because the in-tree driver is still behind the oot driver. For your purposes, just ignore the rest. | 14:35 |
| efried | [1] https://opendev.org/openstack/nova/src/branch/master/nova/virt/powervm/vm.py#L376 | 14:35 |
| efried | [2] https://opendev.org/openstack/nova/src/branch/master/nova/virt/powervm/vm.py#L442-L443 | 14:35 |
| efried | [3] https://opendev.org/openstack/nova/src/branch/master/nova/virt/powervm/vm.py#L466-L473 | 14:35 |
| efried | sean-k-mooney: I think it's actually a bit more complex than that. | 14:35 |
| efried | I think dedicated proc means you get a whole physical processor. | 14:36 |
| efried | whereas shared means you get a piece of one | 14:36 |
| sean-k-mooney | well its pinnign with the isolate polciy in libvirt parlance | 14:36 |
| efried | but I think you're pinned regardless. | 14:36 |
| efried | because powervm can hard partition a proc | 14:36 |
| sean-k-mooney | oh ok well it its basicaly hw:cpu_policy=dedicated + hw:cpu_thread_policy=isolate pre train | 14:37 |
| efried | so you can have, like, 20 virtual procs off of a physical proc, but you can set a minimum guarantee. | 14:37 |
| sean-k-mooney | at least the semantic meaning is the same | 14:37 |
| efried | I suspect powervm ops would disagree with you, but I'm not knowledgeable enough to do so :P | 14:38 |
| efried | Let me put it this way: if the semantic meaning were the same, we would have just mapped the existing extra specs. | 14:38 |
| sean-k-mooney | are you sure about that :) | 14:38 |
| efried | no | 14:38 |
| sean-k-mooney | adding your own might have just been quicker | 14:38 |
| efried | but pretty sure. | 14:38 |
| *** ociuhandu has quit IRC | 14:39 | |
| sean-k-mooney | in anycase when this validation work is complete i think it would be workthseeing if we can normalise the extra specs | 14:39 |
| efried | If we had all the dev resources in the world, sure. | 14:40 |
| efried | realistically, I see no chance of that happening. | 14:40 |
| sean-k-mooney | i dont think it will mater in all cacuse but the powervm:shared_weight seam a lot like the cpu:shares option the libvirt and vmware | 14:41 |
| sean-k-mooney | ya i guess | 14:41 |
| sean-k-mooney | anyway really food this time o/ stephenfin when you get a chance can you review https://review.opendev.org/#/c/703373/ in os-vif | 14:42 |
| *** artom has joined #openstack-nova | 14:43 | |
| *** artom has quit IRC | 14:48 | |
| *** jawad_axd has quit IRC | 14:50 | |
| *** dklyle has joined #openstack-nova | 14:50 | |
| *** jawad_axd has joined #openstack-nova | 14:50 | |
| *** francoisp has joined #openstack-nova | 14:53 | |
| *** jawad_ax_ has joined #openstack-nova | 14:54 | |
| *** jawad_a__ has joined #openstack-nova | 14:55 | |
| *** jawad_axd has quit IRC | 14:55 | |
| francoisp | hello lyarwood, stephenfin, doing code rework for https://review.opendev.org/#/c/669674/ and I have a question for you: | 14:58 |
| francoisp | stephenfin you put in a comment at nova/conf/compute.py, line 871: | 14:58 |
| francoisp | "If something is failing to complete after 5 loops, surely that's an issue that bumping the value will only mask?" | 14:58 |
| francoisp | I understand we want do do away with the config option, and stick with a hard-coded value for max number of re-tries. | 14:58 |
| francoisp | are you suggesting we use a lower value (ex.: max 3 retries) ? | 14:58 |
| *** udesale has joined #openstack-nova | 14:58 | |
| *** jawad_ax_ has quit IRC | 14:58 | |
| *** jawad_a__ has quit IRC | 15:00 | |
| *** pcaruana has joined #openstack-nova | 15:02 | |
| *** ociuhandu has joined #openstack-nova | 15:03 | |
| *** salmankhan1 has joined #openstack-nova | 15:03 | |
| *** salmankhan has quit IRC | 15:04 | |
| *** salmankhan1 is now known as salmankhan | 15:04 | |
| *** trident has quit IRC | 15:06 | |
| *** artom has joined #openstack-nova | 15:11 | |
| *** NostawRm has quit IRC | 15:15 | |
| *** mrch_ has quit IRC | 15:15 | |
| *** NostawRm has joined #openstack-nova | 15:16 | |
| *** trident has joined #openstack-nova | 15:17 | |
| *** eharney has joined #openstack-nova | 15:18 | |
| *** jaosorior has joined #openstack-nova | 15:21 | |
| *** ociuhandu has quit IRC | 15:22 | |
| *** jaosorior has quit IRC | 15:27 | |
| *** ccamacho has quit IRC | 15:27 | |
| *** Sundar has joined #openstack-nova | 15:28 | |
| Sundar | Hello dansmith, sean-k-mooney: I am here if you have any questions. | 15:28 |
| *** psachin has joined #openstack-nova | 15:28 | |
| dansmith | Sundar: about what? the latest rev? I haven't gone through anything yet this morning, but was hoping efried was going to take the next pass through pretty soon | 15:31 |
| efried | "pretty soon" yah. | 15:33 |
| efried | stephenfin: sending https://review.opendev.org/#/c/682655/ | 15:34 |
| efried | bauzas: I didn't give you a chance for another swing at ^ -- please lmk if you have issues. | 15:34 |
| * bauzas clicks | 15:34 | |
| bauzas | oh cool | 15:34 |
| bauzas | honestly, I trust you | 15:34 |
| *** salmankhan1 has joined #openstack-nova | 15:35 | |
| bauzas | if I have time, I'll leave a +1 for the posterity | 15:35 |
| efried | cool | 15:35 |
| efried | bauzas: did you get a chance to catch up on the discussion for the numa topo spec? | 15:35 |
| bauzas | efried: unfortunately no | 15:36 |
| bauzas | yesterday evening my time you mean ? | 15:36 |
| efried | Yes, but summarized in the spec comments and an etherpad linked therefrom. No need to read the whole IRC log. | 15:36 |
| sean-k-mooney | bauzas: efried sumerised it in the spec and linked to the conversation on irc and an ehterpad | 15:36 |
| efried | bauzas: no real hurry (other than spec freeze in a couple weeks), but buzz me or sean-k-mooney if you have concerns or need clarification or whatever. | 15:37 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 15:37 |
| *** salmankhan has quit IRC | 15:38 | |
| *** salmankhan1 is now known as salmankhan | 15:38 | |
| stephenfin | gibi: fixed those functional tests ^ | 15:39 |
| bauzas | sean-k-mooney: efried: no worries, i'll look at it | 15:39 |
| stephenfin | got burned by my own refactoring work /o\ | 15:39 |
| stephenfin | I really need to stop changing how those things work | 15:39 |
| bauzas | and thanks for discussing this, even if I was parenting | 15:39 |
| bauzas | gibi: stephenfin: efried: we have this very old cmd that would help ops, if you like getting it a swing https://review.opendev.org/#/c/670112/ | 15:40 |
| bauzas | mriedem would be surprised if we eventually merge it :p | 15:40 |
| sean-k-mooney | after backporting acrouss 4 release im not sure you can resist it | 15:40 |
| sean-k-mooney | the sad part is each refactoring does make them better | 15:41 |
| stephenfin | bauzas: Oh, that looks hairy. Can you ask me Monday once FOSDEM's behind me? :) | 15:42 |
| bauzas | stephenfin: well, if you're not hit by the Coronavirus, of course :D | 15:43 |
| * bauzas couldn't resist to mention this thread that was LOLesque | 15:43 | |
| * stephenfin packs hand sanitizer | 15:43 | |
| sean-k-mooney | na stephen has better taste in beer then to be hit by that | 15:43 |
| *** ociuhandu has joined #openstack-nova | 15:43 | |
| *** spatel has quit IRC | 15:43 | |
| bauzas | at least there should be good news | 15:44 |
| bauzas | the Delirium bar shouldn't be packed like usual times | 15:44 |
| bauzas | stephenfin: ^ | 15:44 |
| * bauzas has an idea how to make room at the Delirium : just cough | 15:45 | |
| *** priteau has joined #openstack-nova | 15:46 | |
| openstackgerrit | Merged openstack/nova-specs master: Re-propose the flavor extra spec validation spec https://review.opendev.org/682655 | 15:46 |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Address comments on 'flavor-extra-spec-validators' spec https://review.opendev.org/705047 | 15:48 |
| *** ratailor has joined #openstack-nova | 15:48 | |
| * sean-k-mooney look like icould have gone to fosdem after all since i wont be closing on the house for another week at this point :( | 15:49 | |
| *** ratailor_ has joined #openstack-nova | 15:50 | |
| *** spatel has joined #openstack-nova | 15:53 | |
| bauzas | every year I consider going to FOSDEM | 15:53 |
| *** ratailor has quit IRC | 15:54 | |
| bauzas | and every year I think it wouldn't be worth the energy I would need for being a speaker | 15:54 |
| bauzas | so, unless I pay... | 15:54 |
| Sundar | dansmith: I responded and addressed your comments in my latest update last night. Understand you want efried to review first. | 15:54 |
| dansmith | ack | 15:54 |
| Sundar | efried: I understand you have other things to take care of. I'll wait. | 15:55 |
| sean-k-mooney | bauzas: jay was thinking of going this year. i was hoping to see him but since i taough i would be getting the keys to the house im buying on monday i did not want to travel this weekend | 15:55 |
| bauzas | that also means I would miss a skiing weekend. Unfair. | 15:56 |
| efried | Sundar: I need to do some PM-ish paperwork (reconcile blueprints with specs, kind of thing) ahead of this afternoon's meeting, but reviewing your series is next on my list after that. | 15:57 |
| Sundar | efried: Thanks. | 15:59 |
| *** jmlowe has joined #openstack-nova | 16:00 | |
| *** gyee has joined #openstack-nova | 16:04 | |
| *** iurygregory has quit IRC | 16:05 | |
| *** maciejjozefczyk has quit IRC | 16:06 | |
| *** dtantsur|brb is now known as dtantsur | 16:06 | |
| *** xek has quit IRC | 16:10 | |
| *** ivve has quit IRC | 16:10 | |
| *** mvkr has joined #openstack-nova | 16:13 | |
| openstackgerrit | Merged openstack/nova-specs master: Address comments on 'flavor-extra-spec-validators' spec https://review.opendev.org/705047 | 16:16 |
| efried | stephenfin: did you see response earlier about powervm extra specs? | 16:16 |
| *** eharney has quit IRC | 16:16 | |
| stephenfin | efried: I did. Did you happen to leave comments on the patch, out of curiosity? | 16:16 |
| *** eharney has joined #openstack-nova | 16:16 | |
| stephenfin | If not, could you? I probably won't get a chance to respin that until next week now | 16:17 |
| efried | stephenfin: The code side? No, I wasn't planning to do a pass through that until... uh, later. But assuming you've got a placeholder in there for powervm, I'll go stuff the link in there. | 16:18 |
| efried | stephenfin: done | 16:20 |
| stephenfin | ta | 16:21 |
| *** jawad_axd has joined #openstack-nova | 16:23 | |
| *** tbachman has joined #openstack-nova | 16:25 | |
| stephenfin | gibi: quick question: what move operations, if any, did we support for instances with QoS interfaces in Train? | 16:27 |
| *** jawad_axd has quit IRC | 16:27 | |
| * stephenfin notes he has to review the remainder of that series again | 16:27 | |
| efried | stephenfin: per release notes, cold migrate and resize https://docs.openstack.org/releasenotes/nova/train.html | 16:37 |
| efried | mm, runways could use a refresh https://etherpad.openstack.org/p/nova-runways-ussuri | 16:39 |
| *** mlavalle has joined #openstack-nova | 16:39 | |
| efried | Is anyone paying attention to those anymore? | 16:39 |
| efried | lyarwood: I'm going to move stable device rescue into a slot, mkay? | 16:40 |
| *** udesale has quit IRC | 16:43 | |
| lyarwood | efried: yarp, was going to ask about runways in the meeting this evening. | 16:43 |
| lyarwood | efried: I assume this means they are still a thing? | 16:43 |
| *** jawad_axd has joined #openstack-nova | 16:43 | |
| efried | I don't know. I, for one, hadn't looked at that etherpad in *months* | 16:44 |
| lyarwood | kk | 16:44 |
| efried | Easy enough to update it though, in case anyone is. | 16:44 |
| efried | dustinc: Reckon it wouldn't be wrong for you to put provider config in there | 16:45 |
| efried | what's the status btw? Are we waiting for an update based on gibi's last round of review? | 16:46 |
| *** ociuhandu has quit IRC | 16:46 | |
| *** jawad_axd has quit IRC | 16:48 | |
| stephenfin | efried, bauzas, dansmith, <Anyone else that cares>: We had a bug reported downstream complaining that the 'os-hypervisors' API doesn't list CPUs in the new cpu_(shared|dedicated)_set config options. That was intentional on my behalf because the API is awful and I wanted to deprecate it | 16:51 |
| stephenfin | I think we can get most of that information from placement now so it's also unnecessary | 16:51 |
| *** ociuhandu has joined #openstack-nova | 16:51 | |
| bauzas | yup, we can tell the people who pay us : 'go use osc-placement' | 16:52 |
| stephenfin | Anyone know of a reason to keep it, and do I need a spec to deprecate it in a microversion or is a specless BP good enough? | 16:52 |
| efried | stephenfin: if we can deprecate that API, let's do that. | 16:52 |
| efried | ahcrap, I can never remember how that works. gmann? | 16:52 |
| bauzas | last time we discussed, some ops disagreed AFAICR | 16:52 |
| bauzas | I would first raise the problem in a ML thread | 16:52 |
| * gibi had a 3 hour long call, reading scrollback now | 16:53 | |
| bauzas | and ask ops what they think | 16:53 |
| dansmith | if you want to deprecate then a microversion yeah | 16:53 |
| bauzas | and yeah a microversion if so | 16:53 |
| efried | A microversion to deprecate? Or a microversion to remove? | 16:53 |
| kashyap | gibi: 3-hour long call, and then right after working? You deserve a drink | 16:54 |
| stephenfin | Well, to remove | 16:54 |
| efried | the former doesn't make a lot of sense, does it? Is there some kind of signal we give in a response? | 16:54 |
| stephenfin | But it'll still be there in the older microversions | 16:54 |
| openstackgerrit | Merged openstack/os-vif master: [OVS] VLAN tag should be set in the Port register https://review.opendev.org/703373 | 16:54 |
| stephenfin | i.e. we won't HTTP 410 of course | 16:54 |
| gibi | kashyap: I wrap up my day quickly then drink :) | 16:54 |
| gibi | stephenfin, bauzas: I added your patches to my queue for re-review for tomorrow | 16:55 |
| bauzas | np, thanks | 16:55 |
| bauzas | gibi: and I totally understand your pain of long-running meetings | 16:55 |
| gibi | stephenfin: qos + move in train, based on https://review.opendev.org/#/q/topic:bp/support-move-ops-with-qos-ports it is resize and cold migrate that is supported in train | 16:56 |
| melwitt | yeah, if you want to deprecate os-hypervisors, I think that should (1) be run by some ops people like bauzas said and (2) make sure everything you can get in one swoop from os-hypervisors is also gettable from placement in one swoop. maybe two swoops would also be ok, or I guess could talk about placement cli batching. just some things to think about | 16:58 |
| gibi | efried: about the provider config, I think the ball is at dustinc | 16:58 |
| bauzas | agreed with melwitt, the (2) is important | 16:58 |
| bauzas | and IIRC, that was why we never deprecated this API | 16:59 |
| bauzas | because of the feature gap | 16:59 |
| bauzas | but maybe I'm wrong, so I would just propose to identify all the parity between the API and the osc-placement calls and document it | 16:59 |
| melwitt | yeah, I assumed that's why it's still around but tbh I have never dug in more | 16:59 |
| bauzas | it would be easier to pull the trigger and convince people after that | 16:59 |
| stephenfin | melwitt: So come up with a osc-placement replacement for the 'openstack hypervisor show' command? | 17:00 |
| bauzas | I can't recollect in my mind but I remember we had a convo around it in some f2f like summit or ptg | 17:00 |
| bauzas | stephenfin: document it first | 17:00 |
| bauzas | and then ask whether ops are okay with the replacement as it is | 17:00 |
| bauzas | (that'd be my recommendation in order not to freak out ops) | 17:01 |
| melwitt | stephenfin: no sorry, I was just saying if it takes multiple calls to placement to gather the same data that os-hypervisors gives in one call (I don't know if it does, but if this is the case) then consider a osc-placement cli batch command to give operators that ease that they had before with os-hypervisors | 17:01 |
| stephenfin | Ah, gotcha | 17:01 |
| * stephenfin adds a TODO to investigate this before posting to the list | 17:01 | |
| melwitt | ++ yeah this is all hypothetical until you dig in, just wanted to cover the considerations at a high level | 17:02 |
| *** jawad_axd has joined #openstack-nova | 17:04 | |
| *** ratailor_ has quit IRC | 17:05 | |
| *** factor has quit IRC | 17:08 | |
| *** tesseract has quit IRC | 17:08 | |
| *** jawad_axd has quit IRC | 17:08 | |
| openstackgerrit | Merged openstack/nova master: zuul: Remove unnecessary 'USE_PYTHON3' https://review.opendev.org/695380 | 17:09 |
| gibi | dansmith: if you have time, I replied to your comments in https://review.opendev.org/#/c/702261 | 17:12 |
| *** jmlowe has quit IRC | 17:12 | |
| efried | dustinc: are you planning to do anything further with https://review.opendev.org/#/q/topic:bp/openstacksdk-in-nova+status:open ? | 17:12 |
| *** ociuhandu has quit IRC | 17:13 | |
| *** ociuhandu has joined #openstack-nova | 17:13 | |
| dansmith | gibi: okay I'll have to rebuild context on it | 17:15 |
| *** Sundar has quit IRC | 17:16 | |
| dansmith | gibi: are you saying that we've received an instance with a modified pci request over rpc from the destination and we're doing the refresh to dump that and avoid persisting the changed-but-no-longer-relevant field on the instance? | 17:17 |
| gibi | dansmith: exactly | 17:19 |
| dansmith | if so, refresh seems like a big hammer for that because it will drop any other changes we have on the instance that we might want (even if that happens in the future). Looks like refresh can't take a list of fields (which I guess makes sense) so I don't really have an alternative | 17:19 |
| *** jmlowe has joined #openstack-nova | 17:19 | |
| *** priteau has quit IRC | 17:21 | |
| gibi | dansmith: right now I don't feel we have a problem with refresh, but if it happens in the future then we need to extend the ovo interface or start saveing the old value of the pci request somewhere | 17:21 |
| dansmith | refresh isn't an ovo thing, it's an instance thing | 17:21 |
| efried | sean-k-mooney: You still planning to drive https://review.opendev.org/#/q/topic:bp/image-metadata-prefiltering+status:open in ussuri? | 17:21 |
| gibi | dansmith: ohh, then I can hack on it right now | 17:21 |
| dansmith | gibi: what about checking obj_what_changed() right before the refresh and asserting that it's either empty or just contains the pci request info and logging a warning if not? | 17:22 |
| dansmith | gibi: in fact if you did that you could avoid the expensive refresh for everyone else if it's not SRIOV | 17:23 |
| gibi | dansmith: I can do that. But I can also extend the refresh() call with an optiona; field list | 17:23 |
| dansmith | gibi: I'm less excited about the latter just because of the potential effort in validating it, but it seems like that might be useful | 17:23 |
| *** jmlowe has quit IRC | 17:24 | |
| dansmith | gibi: I think the reason we didn't initially do that is because you may be creating a franken-instance where you've pulled some updates from the db and not others, which are co-dependent and then would save it back in an inconsistent state | 17:24 |
| gibi | dansmith: OK. I will follow your suggestion and check obj_what_changed and log a warning if we would drop other fields than pci | 17:24 |
| dansmith | gibi: and avoid the refresh if nothing is changed yeah? | 17:24 |
| gibi | yepp | 17:24 |
| *** jmlowe has joined #openstack-nova | 17:24 | |
| dansmith | cool | 17:24 |
| gibi | and make a note about selective refresh for later | 17:24 |
| gibi | dansmith: thanks! | 17:24 |
| *** jawad_axd has joined #openstack-nova | 17:25 | |
| dansmith | ack, also note my piconit :) | 17:25 |
| gibi | ack :) | 17:25 |
| * gibi leaves for today | 17:28 | |
| gibi | o/ | 17:28 |
| *** jawad_axd has quit IRC | 17:29 | |
| *** ociuhandu has quit IRC | 17:30 | |
| *** nweinber has quit IRC | 17:32 | |
| *** nweinber has joined #openstack-nova | 17:32 | |
| *** evrardjp has joined #openstack-nova | 17:33 | |
| *** TxGirlGeek has joined #openstack-nova | 17:40 | |
| gmann | cmurphy: can you revisit this review. i replied in the comment, https://review.opendev.org/#/c/701624/ | 17:41 |
| gmann | doing deprecation in base rule is to avoid adding the deprecation warning in each rule using base rule as their check_str | 17:41 |
| gmann | cmurphy: you can find more discussion here on doing deprecation in base rule than specific rules - https://review.opendev.org/#/c/676682/4/nova/policies/admin_actions.py | 17:44 |
| *** jawad_axd has joined #openstack-nova | 17:45 | |
| *** salmankhan has quit IRC | 17:46 | |
| *** jmlowe has quit IRC | 17:48 | |
| efried | stephenfin: is there anything further to be done for https://blueprints.launchpad.net/nova/+spec/remove-xvpvncproxy or can I mark it complete? | 17:49 |
| stephenfin | efried: Nope, melwitt and mriedem closed it out a few weeks back. It's done. | 17:50 |
| efried | sweet | 17:50 |
| *** jawad_axd has quit IRC | 17:50 | |
| *** jmlowe has joined #openstack-nova | 17:51 | |
| cmurphy | gmann: i will come back to it today, thanks for pointing me to the discussion | 17:51 |
| cmurphy | i'm hoping lbragstad could also offer some insights ^ | 17:52 |
| gmann | cmurphy: thanks | 17:52 |
| gmann | +1 | 17:52 |
| *** dtantsur is now known as dtantsur|afk | 17:52 | |
| *** nweinber has quit IRC | 17:57 | |
| *** derekh has quit IRC | 18:00 | |
| *** rpittau is now known as rpittau|afk | 18:02 | |
| *** jawad_axd has joined #openstack-nova | 18:06 | |
| *** igordc has joined #openstack-nova | 18:09 | |
| *** jmlowe has quit IRC | 18:10 | |
| *** ralonsoh has quit IRC | 18:11 | |
| *** jawad_axd has quit IRC | 18:11 | |
| *** jmlowe has joined #openstack-nova | 18:21 | |
| *** luksky has quit IRC | 18:25 | |
| efried | dansmith: Are you pursuing this https://review.opendev.org/#/c/693226/ ? (nova-audit) | 18:26 |
| efried | If so, would you please throw out a bp for it? I'm getting those ducks lined up. | 18:26 |
| *** jawad_axd has joined #openstack-nova | 18:27 | |
| dansmith | efried: no, I had abandoned it | 18:28 |
| efried | oh, looks like melwitt restored it. melwitt ^ ? | 18:28 |
| melwitt | I had restored it to encourage ops review, I was told the abandonedness confused the people who would comment on it | 18:29 |
| *** jmlowe has quit IRC | 18:29 | |
| efried | melwitt: k. Been a couple weeks. If you wouldn't mind putting up a blueprint so it's properly trackable. Then I guess we can go-no-go it at spec freeze time. | 18:30 |
| melwitt | efried: yeah, makes sense. I will do that | 18:30 |
| *** jawad_axd has quit IRC | 18:31 | |
| *** nweinber has joined #openstack-nova | 18:32 | |
| *** martinkennelly has quit IRC | 18:37 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Deprecate base rules in favor of new rules https://review.opendev.org/701624 | 18:37 |
| *** jmlowe has joined #openstack-nova | 18:38 | |
| gmann | cmurphy: lbragstad done ^^ | 18:38 |
| *** bnemec has joined #openstack-nova | 18:41 | |
| *** ivve has joined #openstack-nova | 18:47 | |
| *** jawad_axd has joined #openstack-nova | 18:47 | |
| *** jawad_axd has quit IRC | 18:52 | |
| *** jmlowe has quit IRC | 19:05 | |
| *** luksky has joined #openstack-nova | 19:14 | |
| openstackgerrit | Merged openstack/nova master: Use COMPUTE_SAME_HOST_COLD_MIGRATE trait during migrate https://review.opendev.org/695220 | 19:22 |
| openstackgerrit | Merged openstack/nova stable/stein: Remove 'test_cold_migrate_with_physnet_fails' test https://review.opendev.org/702971 | 19:22 |
| *** bnemec has quit IRC | 19:24 | |
| *** Liang__ has quit IRC | 19:29 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | 19:34 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | 19:35 |
| openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | 19:35 |
| *** jmlowe has joined #openstack-nova | 19:48 | |
| stephenfin | sean-k-mooney: want to drop your -W from https://review.opendev.org/#/c/703115/ now that the stable/stein changes have merged | 19:52 |
| sean-k-mooney | done | 19:53 |
| *** TxGirlGeek has quit IRC | 20:05 | |
| *** hamzy_ has joined #openstack-nova | 20:11 | |
| *** hamzy has quit IRC | 20:14 | |
| *** psachin has quit IRC | 20:16 | |
| *** READ10 has joined #openstack-nova | 20:25 | |
| *** jawad_axd has joined #openstack-nova | 20:31 | |
| *** jawad_axd has quit IRC | 20:35 | |
| *** rcernin has quit IRC | 20:36 | |
| *** artom has quit IRC | 20:49 | |
| *** gentoorax has quit IRC | 20:50 | |
| *** gentoorax has joined #openstack-nova | 20:51 | |
| *** jawad_axd has joined #openstack-nova | 20:51 | |
| *** jawad_axd has quit IRC | 20:56 | |
| efried | Nova meeting shortly in #openstack-meeting | 20:57 |
| *** TxGirlGeek has joined #openstack-nova | 21:07 | |
| *** jawad_axd has joined #openstack-nova | 21:12 | |
| *** eharney has quit IRC | 21:15 | |
| *** jawad_axd has quit IRC | 21:16 | |
| *** dpawlik has quit IRC | 21:25 | |
| *** jawad_axd has joined #openstack-nova | 21:32 | |
| *** READ10 has quit IRC | 21:36 | |
| *** jawad_axd has quit IRC | 21:37 | |
| *** damien_r has quit IRC | 21:42 | |
| *** slaweq has quit IRC | 21:43 | |
| *** slaweq has joined #openstack-nova | 21:45 | |
| *** spatel has quit IRC | 21:46 | |
| melwitt | efried: created https://blueprints.launchpad.net/nova/+spec/nova-audit | 21:48 |
| efried | thanks melwitt | 21:49 |
| *** tbachman has quit IRC | 21:52 | |
| *** jawad_axd has joined #openstack-nova | 21:53 | |
| *** slaweq has quit IRC | 21:55 | |
| *** jawad_axd has quit IRC | 21:57 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126 | 22:16 |
| *** jawad_axd has joined #openstack-nova | 22:21 | |
| *** tbachman has joined #openstack-nova | 22:21 | |
| *** efried has quit IRC | 22:24 | |
| *** jawad_axd has quit IRC | 22:25 | |
| *** efried has joined #openstack-nova | 22:25 | |
| *** sapd1 has joined #openstack-nova | 22:25 | |
| *** sapd1_ has quit IRC | 22:26 | |
| *** nweinber has quit IRC | 22:30 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127 | 22:40 |
| *** jawad_axd has joined #openstack-nova | 22:42 | |
| *** jmlowe has quit IRC | 22:43 | |
| *** jawad_axd has quit IRC | 22:47 | |
| *** mriedem has left #openstack-nova | 22:51 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126 | 22:52 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126 | 22:55 |
| *** READ10 has joined #openstack-nova | 23:00 | |
| *** ivve has quit IRC | 23:07 | |
| *** tkajinam has joined #openstack-nova | 23:10 | |
| *** READ10 has quit IRC | 23:14 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126 | 23:14 |
| *** avolkov has quit IRC | 23:14 | |
| *** rcernin has joined #openstack-nova | 23:20 | |
| *** luksky has quit IRC | 23:21 | |
| *** jawad_axd has joined #openstack-nova | 23:23 | |
| *** jawad_axd has quit IRC | 23:28 | |
| melwitt | gmann: question on https://review.opendev.org/701629 | 23:40 |
| *** jawad_axd has joined #openstack-nova | 23:44 | |
| gmann | melwitt: replied. I am removing user_id from policy target in https://review.opendev.org/#/c/701642/ | 23:45 |
| gmann | melwitt: but if we keep this operation restriction at user level then we can keep. | 23:45 |
| gmann | we do not pass user_id for most of the(i think all except user level API like keypair etc) API. it is all enforced at project level | 23:46 |
| melwitt | gmann: ok. I'm thinking from the perspective of us having to keep the legacy policy behavior for some time or some transition period. is my understanding correct? | 23:46 |
| melwitt | because from the look of the old tests, we support letting operators restrict password change to only the user set on the instance | 23:47 |
| gmann | melwitt: yeah, that is good point. We can keep supporting it same way till we completely migrate to new | 23:48 |
| melwitt | I'm happy to be wrong but I thought we were keeping current support as-is for now and if we want to change it, need some signal about deprecation and a transition period before dropping | 23:49 |
| melwitt | I was reading this part of the spec again https://specs.openstack.org/openstack/nova-specs/specs/ussuri/approved/policy-defaults-refresh.html#backward-compatibility-and-migration-plan | 23:50 |
| gmann | yeah. by removing the user_id from target we can break some deployment. | 23:52 |
| melwitt | "Remove any project or user checks from the policy file defaults, as this is now done in code, without breaking user-id-based-policy-enforcement" | 23:52 |
| *** jawad_axd has quit IRC | 23:52 | |
| melwitt | I'm wondering if we removed any in the already merged patches | 23:53 |
| gmann | no, this is first one where user_id is passed and i updated to remove that. in "pass actual target" patches I pass the actual target wherever needed. like owner rule where project_id is needed. | 23:54 |
| melwitt | ok | 23:55 |
| gmann | "pass actual target" patches can tell us if any where we are changing user-level enforcement | 23:55 |
| melwitt | ok, that is good to know | 23:56 |
| melwitt | not directly related to this, I do wonder if operators would be disappointed to lose user-level enforcement in the future on something like a admin password. but that's a separate issue | 23:57 |
| melwitt | I see now in the pass actual target, thanks for the tip https://review.opendev.org/#/c/701642/1/nova/api/openstack/compute/admin_password.py | 23:58 |
| gmann | yeah, i think we need to change that with separate discussion if everyone ok. else keep it as it is. | 23:58 |
| gmann | melwitt: i found one bug in attach_interface policy which is admin_or_owner but it pass for every context because project_id is not passed in policy target | 23:59 |
| melwitt | yeah, agreed. I can't predict what operators would want to see there, would be a good question for the forum and if no one cares about user-level enforcement, we remove it after the transition period | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!