| gmann | because our policy doc say it is admin_or_owner but code is buggy so I am thinking whether we can fix this as bug or leave this operation open for everyone | 00:00 |
|---|---|---|
| melwitt | gmann: bug in the legacy policy or bug in the more recently policy patches merged? | 00:00 |
| gmann | legacy | 00:00 |
| melwitt | sigh ... I'm not surprised, there's a lot of bugs/quirks there. | 00:00 |
| gmann | this one - https://review.opendev.org/#/c/705126/4 | 00:00 |
| gmann | i added the test with admin_or_owner context to pass and other proejct to fail. but those tests fail as you can see in gate. | 00:01 |
| melwitt | I guess my instinct would be to fix the bug first and then stack the new stuff on top, but that might be just me | 00:01 |
| gmann | yeah that is what i was thinking. so that we can see the bug and fix first and then start the new policy defaults | 00:02 |
| melwitt | I see. well, that's a good sign for the new test coverage I guess :) | 00:02 |
| gmann | yeah | 00:02 |
| melwitt | it's catching bugs | 00:02 |
| gmann | i will file bug and put fix as separate change. | 00:02 |
| melwitt | sounds great ++ | 00:03 |
| melwitt | add me as reviewer when you have it ready | 00:03 |
| gmann | sure, thanks | 00:03 |
| *** TxGirlGeek has quit IRC | 00:07 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-attach-interfaces policy to be admin_or_owner https://review.opendev.org/705135 | 00:22 |
| *** toabctl has quit IRC | 00:24 | |
| *** tetsuro has quit IRC | 00:24 | |
| *** tetsuro has joined #openstack-nova | 00:24 | |
| *** tetsuro has quit IRC | 00:25 | |
| *** tetsuro has joined #openstack-nova | 00:26 | |
| *** toabctl has joined #openstack-nova | 00:27 | |
| *** tosky has quit IRC | 00:28 | |
| *** jawad_axd has joined #openstack-nova | 00:30 | |
| *** jawad_axd has quit IRC | 00:34 | |
| *** mlavalle has quit IRC | 00:35 | |
| *** jawad_axd has joined #openstack-nova | 00:51 | |
| *** jawad_axd has quit IRC | 00:55 | |
| *** jawad_axd has joined #openstack-nova | 01:12 | |
| *** jawad_axd has quit IRC | 01:16 | |
| *** Dinesh_Bhor has quit IRC | 01:22 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:26 | |
| *** ociuhandu has joined #openstack-nova | 01:31 | |
| *** jawad_axd has joined #openstack-nova | 01:32 | |
| *** ociuhandu has quit IRC | 01:35 | |
| *** jawad_axd has quit IRC | 01:37 | |
| *** igordc has quit IRC | 01:43 | |
| *** rchurch_ has joined #openstack-nova | 02:02 | |
| *** rchurch has quit IRC | 02:04 | |
| *** sapd1_x has joined #openstack-nova | 02:12 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-attach-interfaces policy to be admin_or_owner https://review.opendev.org/705135 | 02:12 |
| *** jawad_axd has joined #openstack-nova | 02:14 | |
| *** nweinber has joined #openstack-nova | 02:14 | |
| *** nweinber has quit IRC | 02:14 | |
| *** jawad_axd has quit IRC | 02:18 | |
| *** nweinber has joined #openstack-nova | 02:19 | |
| gmann | melwitt: ^^ | 02:31 |
| openstackgerrit | Merged openstack/nova stable/stein: Block rebuild when NUMA topology changed https://review.opendev.org/702972 | 02:34 |
| *** jawad_axd has joined #openstack-nova | 02:35 | |
| *** jawad_axd has quit IRC | 02:40 | |
| *** kaisers has quit IRC | 02:40 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127 | 02:51 |
| *** kaisers has joined #openstack-nova | 02:55 | |
| *** nweinber has quit IRC | 02:56 | |
| *** links has joined #openstack-nova | 03:02 | |
| *** tetsuro has quit IRC | 03:05 | |
| *** tetsuro_ has joined #openstack-nova | 03:05 | |
| *** gyee has quit IRC | 03:05 | |
| *** psachin has joined #openstack-nova | 03:38 | |
| *** tbachman has quit IRC | 03:52 | |
| melwitt | gmann: ack thanks, will look tomorrow | 04:26 |
| *** jmlowe has joined #openstack-nova | 04:30 | |
| *** jmlowe has quit IRC | 04:39 | |
| *** jmlowe has joined #openstack-nova | 04:39 | |
| *** jmlowe has quit IRC | 04:44 | |
| *** psachin has quit IRC | 04:47 | |
| *** udesale has joined #openstack-nova | 04:48 | |
| *** jmlowe has joined #openstack-nova | 04:50 | |
| *** damien_r has joined #openstack-nova | 04:58 | |
| *** jmlowe has quit IRC | 04:59 | |
| *** jmlowe has joined #openstack-nova | 05:03 | |
| *** damien_r has quit IRC | 05:10 | |
| *** jmlowe has quit IRC | 05:24 | |
| *** jmlowe has joined #openstack-nova | 05:26 | |
| *** brinzhang has joined #openstack-nova | 05:26 | |
| *** yedongcan has joined #openstack-nova | 05:30 | |
| *** jmlowe has quit IRC | 05:32 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #openstack-nova | 05:33 | |
| *** rcernin has quit IRC | 05:39 | |
| *** jmlowe has joined #openstack-nova | 05:53 | |
| *** jmlowe has quit IRC | 05:59 | |
| *** tetsuro_ has quit IRC | 06:04 | |
| *** tbachman has joined #openstack-nova | 06:08 | |
| *** jmlowe has joined #openstack-nova | 06:10 | |
| *** tbachman has quit IRC | 06:14 | |
| *** jmlowe has quit IRC | 06:15 | |
| *** tetsuro has joined #openstack-nova | 06:19 | |
| *** tetsuro has quit IRC | 06:25 | |
| *** ratailor has joined #openstack-nova | 06:43 | |
| *** udesale has quit IRC | 06:49 | |
| *** slaweq has joined #openstack-nova | 06:59 | |
| *** StevenK has quit IRC | 07:06 | |
| *** StevenK has joined #openstack-nova | 07:06 | |
| *** Jeffrey4l has quit IRC | 07:06 | |
| *** avolkov has joined #openstack-nova | 07:12 | |
| *** Jeffrey4l has joined #openstack-nova | 07:12 | |
| *** tetsuro has joined #openstack-nova | 07:12 | |
| *** tetsuro has quit IRC | 07:17 | |
| *** udesale has joined #openstack-nova | 07:19 | |
| *** jawad_axd has joined #openstack-nova | 07:28 | |
| *** tetsuro has joined #openstack-nova | 07:29 | |
| *** psachin has joined #openstack-nova | 07:29 | |
| *** tetsuro_ has joined #openstack-nova | 07:41 | |
| *** ralonsoh has joined #openstack-nova | 07:42 | |
| *** udesale has quit IRC | 07:43 | |
| *** yedongcan has quit IRC | 07:43 | |
| *** udesale has joined #openstack-nova | 07:44 | |
| *** tetsuro has quit IRC | 07:44 | |
| *** tetsuro has joined #openstack-nova | 07:46 | |
| *** yedongcan has joined #openstack-nova | 07:46 | |
| *** tetsuro__ has joined #openstack-nova | 07:47 | |
| *** tetsuro_ has quit IRC | 07:49 | |
| *** tetsuro has quit IRC | 07:50 | |
| *** luksky has joined #openstack-nova | 07:51 | |
| *** dpawlik has joined #openstack-nova | 08:01 | |
| *** luksky has quit IRC | 08:02 | |
| *** yedongcan has quit IRC | 08:02 | |
| *** yedongcan has joined #openstack-nova | 08:05 | |
| *** maciejjozefczyk has joined #openstack-nova | 08:07 | |
| *** rpittau|afk is now known as rpittau | 08:16 | |
| *** mrch_ has joined #openstack-nova | 08:20 | |
| *** yedongcan has quit IRC | 08:21 | |
| *** vishalmanchanda has quit IRC | 08:21 | |
| *** tetsuro has joined #openstack-nova | 08:23 | |
| *** yedongcan has joined #openstack-nova | 08:23 | |
| *** tosky has joined #openstack-nova | 08:23 | |
| *** tesseract has joined #openstack-nova | 08:25 | |
| *** tetsuro__ has quit IRC | 08:25 | |
| *** jawad_axd has quit IRC | 08:27 | |
| *** spatel has joined #openstack-nova | 08:28 | |
| *** tetsuro has quit IRC | 08:32 | |
| *** tetsuro_ has joined #openstack-nova | 08:32 | |
| *** spatel has quit IRC | 08:33 | |
| *** yedongcan has quit IRC | 08:35 | |
| *** yedongcan has joined #openstack-nova | 08:36 | |
| *** jawad_axd has joined #openstack-nova | 08:38 | |
| *** ebbex has joined #openstack-nova | 08:40 | |
| *** psachin has quit IRC | 08:53 | |
| *** tetsuro_ has quit IRC | 08:53 | |
| *** yedongcan has quit IRC | 08:53 | |
| *** luksky has joined #openstack-nova | 08:54 | |
| *** yedongcan has joined #openstack-nova | 08:56 | |
| *** iurygregory has joined #openstack-nova | 08:57 | |
| *** dtantsur|afk is now known as dtantsur | 09:12 | |
| *** yedongcan has quit IRC | 09:13 | |
| *** yedongcan has joined #openstack-nova | 09:14 | |
| *** derekh has joined #openstack-nova | 09:17 | |
| *** ccamacho has joined #openstack-nova | 09:29 | |
| *** Liang__ has joined #openstack-nova | 09:32 | |
| *** martinkennelly has joined #openstack-nova | 09:39 | |
| *** francoisp has quit IRC | 09:42 | |
| *** ratailor has quit IRC | 09:46 | |
| gibi | dansmith: I've investigated the obj_what_changed() way to detect if the pci requests need s refres during live migraton rollback but this idea fails for mutliple reasons. See my answer in https://review.opendev.org/#/c/702261/4/nova/compute/manager.py@8563 | 09:46 |
| *** ratailor has joined #openstack-nova | 09:49 | |
| *** yedongcan has quit IRC | 10:07 | |
| *** yedongcan has joined #openstack-nova | 10:10 | |
| *** lpetrut has joined #openstack-nova | 10:14 | |
| jawad_axd | Hi all. M writing once again here. Question is, iperf3 shows 9.89 Gbits/sec between hosts while instances on same network on these two hosts have iperf3 108 MBytes/sec from inside. How come bandwidth is so poor inside instances? I am using centos7.7, stein, linux bridge,vxlan setup. Any suggestions? | 10:17 |
| gibi | jawad_axd: when you measure performance between the two hosts does the packets are going throigh the same linux bridge as the guests uses in the other measurement between guests? | 10:27 |
| *** sapd1_x has quit IRC | 10:28 | |
| jawad_axd | Nope. Performance between physical hosts is using another bridge at physical NIC. Its just for reference point for guest performance. While guests using bridges created by neutron. | 10:32 |
| gibi | jawad_axd: what I would do is to add layers from the guest-guest test to the host-host test one by one to see which layer causes the degradation | 10:34 |
| stephenfin | bauzas: Could you take a look at these today? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/remove-nova-network-ussuri | 10:36 |
| bauzas | sure | 10:36 |
| bauzas | I need to go to the gym but I can do it later | 10:36 |
| stephenfin | ta | 10:36 |
| gibi | bauzas: I'm +2 again on the placmenet audit patch https://review.opendev.org/#/c/670112/ | 10:42 |
| bauzas | cool thanks ! | 10:42 |
| gibi | stephenfin: I'm +2 on https://review.opendev.org/#/c/662522/16 but it need another rebase | 10:44 |
| *** salmankhan has joined #openstack-nova | 10:44 | |
| *** rpittau is now known as rpittau|bbl | 11:06 | |
| *** martinkennelly has quit IRC | 11:11 | |
| *** martinkennelly has joined #openstack-nova | 11:12 | |
| *** yedongcan has left #openstack-nova | 11:21 | |
| *** ociuhandu has joined #openstack-nova | 11:28 | |
| *** xek has joined #openstack-nova | 11:56 | |
| *** jaosorior has joined #openstack-nova | 11:58 | |
| *** derekh has quit IRC | 11:59 | |
| *** xek has quit IRC | 12:08 | |
| *** ociuhandu has quit IRC | 12:10 | |
| *** links has quit IRC | 12:15 | |
| *** ociuhandu has joined #openstack-nova | 12:19 | |
| *** ratailor has quit IRC | 12:26 | |
| *** kplant has joined #openstack-nova | 12:43 | |
| *** xek has joined #openstack-nova | 12:51 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | 12:58 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | 12:58 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | 12:58 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.82 allowing boot from volume rescue https://review.opendev.org/701430 | 12:58 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Support boot from volume instance rescue https://review.opendev.org/701431 | 12:58 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 12:58 |
| *** kplant has left #openstack-nova | 13:04 | |
| *** xek_ has joined #openstack-nova | 13:04 | |
| *** jaosorior has quit IRC | 13:05 | |
| *** xek has quit IRC | 13:06 | |
| *** rpittau|bbl is now known as rpittau | 13:08 | |
| *** francoisp has joined #openstack-nova | 13:10 | |
| *** nweinber has joined #openstack-nova | 13:11 | |
| *** xek_ has quit IRC | 13:20 | |
| *** damien_r has joined #openstack-nova | 13:20 | |
| *** jmlowe has joined #openstack-nova | 13:23 | |
| *** nweinber has quit IRC | 13:25 | |
| *** ociuhandu has quit IRC | 13:28 | |
| *** jmlowe has quit IRC | 13:28 | |
| *** mriedem has joined #openstack-nova | 13:40 | |
| *** eharney has joined #openstack-nova | 13:44 | |
| *** luksky has quit IRC | 13:49 | |
| *** artom has joined #openstack-nova | 13:55 | |
| *** tbachman has joined #openstack-nova | 13:57 | |
| *** jawad_axd has quit IRC | 14:00 | |
| *** jawad_axd has joined #openstack-nova | 14:01 | |
| *** mrch_ has quit IRC | 14:02 | |
| *** tbachman_ has joined #openstack-nova | 14:03 | |
| *** ociuhandu has joined #openstack-nova | 14:03 | |
| *** tbachman has quit IRC | 14:03 | |
| *** tbachman_ is now known as tbachman | 14:03 | |
| *** mlavalle has joined #openstack-nova | 14:03 | |
| *** jawad_ax_ has joined #openstack-nova | 14:04 | |
| *** sapd1_x has joined #openstack-nova | 14:05 | |
| *** jawad_a__ has joined #openstack-nova | 14:05 | |
| *** jawad_axd has quit IRC | 14:06 | |
| *** ociuhandu has quit IRC | 14:08 | |
| *** jawad_ax_ has quit IRC | 14:08 | |
| *** jawad_a__ has quit IRC | 14:10 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704866 | 14:17 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Deprecate base rules in favor of new rules https://review.opendev.org/701624 | 14:17 |
| *** tbachman has quit IRC | 14:18 | |
| *** spatel has joined #openstack-nova | 14:19 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reduce gen conflict in COMPUTE_STATUS_DISABLED handling https://review.opendev.org/704866 | 14:22 |
| gmann | cmurphy: updated the deprecation warning text. also replied on admin acrtion policy patch. | 14:23 |
| *** spatel has quit IRC | 14:24 | |
| *** ociuhandu has joined #openstack-nova | 14:27 | |
| *** nweinber has joined #openstack-nova | 14:31 | |
| *** xek_ has joined #openstack-nova | 14:32 | |
| *** rnoriega_ has quit IRC | 14:34 | |
| *** brinzhang has quit IRC | 14:37 | |
| *** rnoriega_ has joined #openstack-nova | 14:38 | |
| *** tbachman has joined #openstack-nova | 14:46 | |
| *** mriedem has left #openstack-nova | 14:56 | |
| dansmith | gibi: I replied just now | 15:05 |
| dansmith | gibi: I think my original concerns are all still in place and "it's not as easy to check because of other bugs" doesn't really change my feeling on what is right | 15:05 |
| dansmith | I shan't block on it, but I'm not loving it, nor really sure what the right thing to do is (other than fix those other things) | 15:06 |
| dansmith | also, a decorator causing an instance lazy load is pretty gross :/ | 15:07 |
| *** luksky has joined #openstack-nova | 15:11 | |
| dansmith | and I'm not sure why flavor is being marked as dirty, because it seems like it shouldn't be from what I'm seeing... hmm.. | 15:11 |
| openstackgerrit | Merged openstack/nova stable/stein: Disable NUMATopologyFilter on rebuild https://review.opendev.org/702973 | 15:16 |
| *** ociuhandu has quit IRC | 15:17 | |
| *** ociuhandu has joined #openstack-nova | 15:19 | |
| *** mriedem has joined #openstack-nova | 15:19 | |
| *** ociuhandu has quit IRC | 15:19 | |
| *** ociuhandu has joined #openstack-nova | 15:20 | |
| *** udesale_ has joined #openstack-nova | 15:20 | |
| *** jawad_axd has joined #openstack-nova | 15:21 | |
| *** udesale has quit IRC | 15:23 | |
| *** xek__ has joined #openstack-nova | 15:26 | |
| *** eharney has quit IRC | 15:27 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_password policies https://review.opendev.org/701629 | 15:29 |
| *** xek_ has quit IRC | 15:29 | |
| *** pcaruana has quit IRC | 15:30 | |
| gmann | melwitt: ^^ updated the admin password for user level enforcement tests. | 15:31 |
| melwitt | gmann: cool thanks | 15:32 |
| gmann | and i abandon this which were removing the user_id from policy target. test in 70629 should keep working for user enforcement through out the policy changes - https://review.opendev.org/#/c/701642/1 | 15:33 |
| *** Sundar has joined #openstack-nova | 15:34 | |
| *** jawad_axd has quit IRC | 15:34 | |
| melwitt | k makes sense | 15:34 |
| *** lpetrut has quit IRC | 15:35 | |
| *** salmankhan has quit IRC | 15:36 | |
| *** salmankhan has joined #openstack-nova | 15:36 | |
| *** belmoreira has quit IRC | 15:37 | |
| openstackgerrit | Merged openstack/nova stable/stein: FUP for in-place numa rebuild https://review.opendev.org/702974 | 15:43 |
| *** luksky has quit IRC | 15:45 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | 15:46 |
| melwitt | gmann: reviewing https://review.opendev.org/705135 I'm wondering if we should add a policy test for "fails with other project" (the testing that was originally missing the bug) | 15:46 |
| gmann | melwitt: I am adding those in this where tests failing now and with this fix it should pass - https://review.opendev.org/#/c/705126/ | 15:48 |
| gmann | i need to rebase that on top of fix to show the test passing. is that fine ? | 15:48 |
| melwitt | yeah, was just about to ask that | 15:48 |
| gmann | ok | 15:49 |
| *** bnemec has joined #openstack-nova | 15:49 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-attach-interfaces policy to be admin_or_owner https://review.opendev.org/705135 | 15:49 |
| *** pcaruana has joined #openstack-nova | 15:49 | |
| *** luksky has joined #openstack-nova | 15:49 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127 | 15:49 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126 | 15:50 |
| gmann | done. | 15:50 |
| melwitt | thanks! | 15:50 |
| efried | sean-k-mooney: if you're about, would you please confirm that https://review.opendev.org/#/c/702981/ is correct, and I'll send it | 15:52 |
| sean-k-mooney | ill take a look now | 15:52 |
| *** READ10 has joined #openstack-nova | 15:54 | |
| sean-k-mooney | efried: so an exception will be raised if the pagesize is not supported. so if we get to that line i think it means we dont have enough left of that size based on https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L660 im just reading futher | 15:56 |
| efried | It's a debug log, so I'm not going to make a big deal out of it. I'll fast approve if it's correct. If it's an improvement, that'd be even better :) | 15:59 |
| cmurphy | gmann: thanks, will review again today | 15:59 |
| gmann | cmurphy: thanks | 15:59 |
| sean-k-mooney | well it depens on how you interpert support. it cant suport the request. because its out of space. that is how that was intended to be interpreted | 15:59 |
| sean-k-mooney | efried: im leaving a comment now but i think we can just change the message to | 16:00 |
| sean-k-mooney | remove the or | 16:00 |
| sean-k-mooney | e.g. "Host does not support requested memory pagesize as there are not enough free pages." | 16:01 |
| efried | ack, thanks sean-k-mooney | 16:02 |
| stephenfin | what other stable core can I annoy to merge this? https://review.opendev.org/#/c/663888/ | 16:04 |
| stephenfin | it's been open for aaaaaaages | 16:04 |
| *** rpittau is now known as rpittau|afk | 16:05 | |
| sean-k-mooney | stephenfin: you can try annoying dansmith but im not sure that will end well for you :P | 16:06 |
| sean-k-mooney | although technically no | 16:06 |
| sean-k-mooney | since that would be 3 form redhat | 16:07 |
| melwitt | I'd ping elod to review (I hope that's his nick) | 16:08 |
| sean-k-mooney | tonyb: johnthetubaguy can you take a look at https://review.opendev.org/#/c/663888/ for stephenfin | 16:08 |
| *** IvensZambrano has joined #openstack-nova | 16:14 | |
| dansmith | sean-k-mooney: pretty sure we said that's not a problem on stable especially for clean backports, and especially for something like this | 16:18 |
| *** sapd1_x has quit IRC | 16:19 | |
| sean-k-mooney | ya i think you are right | 16:19 |
| *** TxGirlGeek has joined #openstack-nova | 16:20 | |
| stephenfin | dansmith: cheers | 16:20 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Validate huge pages https://review.opendev.org/399653 | 16:28 |
| stephenfin | sean-k-mooney, efried, bauzas: That ought to be useful if/when we start working on mempage modelling in placement ^ | 16:29 |
| stephenfin | also artom who cares about functional tests ^ | 16:31 |
| * stephenfin goes to review artom's functional tests | 16:31 | |
| artom | stephenfin, yep, I'll take a look - and thanks for re-visiting NUMA func tests :) | 16:32 |
| *** martinkennelly has quit IRC | 16:32 | |
| artom | There's one outstanding piece of dansmith's feedback I need to address though, about forcing servers on hosts | 16:32 |
| sean-k-mooney | stephenfin: more func test for this stuff is always useful | 16:34 |
| sean-k-mooney | if we can use that as a basis to also validate the placemnt reshape that will be needed even more so | 16:34 |
| *** iurygregory has quit IRC | 16:36 | |
| *** dpawlik has quit IRC | 16:37 | |
| efried | wow, neat, a 3+yo patch | 16:37 |
| *** dpawlik has joined #openstack-nova | 16:37 | |
| *** luksky has quit IRC | 16:44 | |
| *** jdillaman has quit IRC | 16:45 | |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: Fix volume attachment rollback https://review.opendev.org/704847 | 16:59 |
| artom | stephenfin, there, done | 17:00 |
| stephenfin | wonderful | 17:00 |
| stephenfin | 1:1 then I'll finish my comments on yours | 17:01 |
| stephenfin | (it's 90% there) | 17:01 |
| openstackgerrit | Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256 | 17:03 |
| *** ociuhandu has quit IRC | 17:06 | |
| *** READ10 has quit IRC | 17:09 | |
| stephenfin | artom: done | 17:10 |
| efried | Hey kids, it looks like blockdiag 2.0.0 breaks our docs build. I'm working on it. | 17:11 |
| artom | stephenfin, thank you! I'll go do sean-k-mooney's downstream review, then circle back here | 17:11 |
| artom | efried, would you say that it's... block-ing us? :D | 17:11 |
| efried | yeah, just give me a few minutes to diag-nose it. | 17:11 |
| dansmith | like, by smell? | 17:12 |
| efried | just so | 17:12 |
| gibi | dansmith: thanks. I have to get back to that patch next week. I appreciate your time and I see your point how a future instance.save() can ruin things. | 17:12 |
| dansmith | gibi: ack, I've been looking at some of the related things you found too | 17:13 |
| *** gyee has joined #openstack-nova | 17:13 | |
| efried | stephenfin: jfyi although I opened an issue against blockdiag, I suspect it's possible the problem is in the monkeypatching in doc/source/conf.py | 17:14 |
| efried | mm, maybe not, removing that didn't resolve. But I went and built docs in another repo that uses blockdiag (networking-bagpipe) and didn't have the same problem. | 17:15 |
| stephenfin | efried: Looks like that project has had a lot of releases since so that monkeypatching probably isn't necessary any more. However, I'm not sure how it would affect things. What's the error? | 17:16 |
| openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | 17:17 |
| efried | stephenfin: https://github.com/blockdiag/blockdiag/issues/126 | 17:17 |
| stephenfin | could you edit that comment so I can read it. Just indent everything by 4 or add ``` before and after the code blocks | 17:18 |
| *** udesale_ has quit IRC | 17:18 | |
| stephenfin | please and thanks :) | 17:18 |
| efried | stephenfin: done | 17:18 |
| efried | stephenfin: hm, I don't actually see blockdiag being *used* in our repo. | 17:19 |
| stephenfin | neither do I, now that you say it | 17:20 |
| openstackgerrit | Vladyslav Drok proposed openstack/nova master: Fix volume attachment rollback https://review.opendev.org/704847 | 17:20 |
| efried | stephenfin: except for a static svg | 17:21 |
| efried | stephenfin: which I would have thought, since it was static, wouldn't affect anything... but we're also using the svg2pdfconverter | 17:21 |
| efried | so maybe | 17:21 |
| stephenfin | Remove it and see what happens? :) | 17:21 |
| efried | remove the svg? | 17:21 |
| stephenfin | Looks like da7e1ede9e73bf0e107b9b37954f204cea544439 may have remove the vestigial traces of blockdiag | 17:22 |
| stephenfin | nah, the extension | 17:22 |
| efried | ... | 17:22 |
| stephenfin | We do use seqdiag | 17:23 |
| stephenfin | but I think that's a different project | 17:23 |
| stephenfin | yup, sure is | 17:23 |
| efried | removing the rsvgconverter extension didn't resolve. | 17:24 |
| openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | 17:25 |
| openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | 17:28 |
| *** martinkennelly has joined #openstack-nova | 17:28 | |
| *** xek__ has quit IRC | 17:28 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Validate huge pages https://review.opendev.org/399653 | 17:29 |
| openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Fix boot_roles in InstanceSystemMetadata https://review.opendev.org/698040 | 17:30 |
| openstackgerrit | Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256 | 17:32 |
| efried | stephenfin: hm, I also tried blacklisting in doc/requirements but that didn't work. ISTR something about upper-constraints overriding no matter what you do locally. | 17:32 |
| sean-k-mooney | efried: is repoducing as simple as pull master and run tox -e docs locally | 17:33 |
| stephenfin | sean-k-mooney: yup | 17:33 |
| *** evrardjp has quit IRC | 17:33 | |
| stephenfin | oh, okay, seqdiag uses blockdiag. Lovely | 17:33 |
| stephenfin | as does actdiag | 17:33 |
| *** evrardjp has joined #openstack-nova | 17:34 | |
| sean-k-mooney | cool ill take a look while i wait for test to finish | 17:34 |
| sean-k-mooney | ok it sould like we need a temproy cap then | 17:34 |
| stephenfin | efried: Does that other project also use stestr, out of curiosity? | 17:35 |
| stephenfin | actually, nvm | 17:35 |
| stephenfin | this is docs, not tests | 17:35 |
| sean-k-mooney | right we are invoking sphinx not stestr | 17:36 |
| stephenfin | efried: This is the thing I introduced the monkeypatching to fix | 17:37 |
| sean-k-mooney | we should just put blockdiag<2.0.0 in upper-constrats.txt | 17:37 |
| stephenfin | I remember now. I bet they've moved some modules around | 17:37 |
| efried | I tried to remove the monkeypatching and it didn't help | 17:38 |
| sean-k-mooney | well they did a major version bump so likely | 17:38 |
| *** tesseract has quit IRC | 17:38 | |
| sean-k-mooney | the just went form 1.5.4 to 2.0.0 | 17:38 |
| dustinc | efried: no, I probably won't be working on this further https://review.opendev.org/#/q/topic:bp/openstacksdk-in-nova+status:open | 17:38 |
| efried | it looks to me like a bug in blockdiag itself, it's trying to get a BufferedReader's buffer. | 17:38 |
| efried | dustinc: okay, I'm going to push the blueprint out of ussuri then. | 17:39 |
| openstackgerrit | Merged openstack/nova stable/rocky: tox: Stop build *all* docs in 'docs' https://review.opendev.org/663888 | 17:40 |
| openstackgerrit | Elod Illes proposed openstack/nova master: DNM: test whether 'logs' content is gzipped https://review.opendev.org/705256 | 17:41 |
| efried | dustinc: You can abandon the changes I guess. If we find a new owner, we can restore them. | 17:41 |
| dustinc | efried: will do, thanks | 17:42 |
| sean-k-mooney | efried: it does not look like they change that code recently | 17:42 |
| *** ociuhandu has joined #openstack-nova | 17:43 | |
| efried | dustinc: You're still driving the provider config changes for the near term though, right? Looks to me like the next action is to you, to rev based on gibi's comments. You agree? | 17:43 |
| dustinc | efried: yes, but priority is low for me at the moment | 17:43 |
| efried | okay. Please let me know if someone needs to take over. | 17:43 |
| stephenfin | efried: done. patch coming | 17:46 |
| sean-k-mooney | efried: it looks like the correct way to get the buffer would be to call getbuffer https://docs.python.org/3/library/io.html#io.BytesIO.getbuffer | 17:46 |
| efried | stephenfin: cool. where? | 17:47 |
| efried | in blockdiag or nova or... | 17:47 |
| stephenfin | for us | 17:47 |
| stephenfin | could be ages before blockdiag get their act together | 17:47 |
| *** dtantsur is now known as dtantsur|afk | 17:47 | |
| efried | okay, so I should leave the issue open there. | 17:48 |
| sean-k-mooney | stephenfin: im goint to quickly just chagne the deference to the call to function call locally and see if that ifxes it | 17:48 |
| sean-k-mooney | i assume that is what you are going to monky patch | 17:49 |
| sean-k-mooney | or is it something else | 17:49 |
| *** READ10 has joined #openstack-nova | 17:49 | |
| efried | also if you have reason to believe we no longer need the old monkey patches, could remove those. | 17:50 |
| efried | separate patch | 17:50 |
| efried | brb | 17:50 |
| stephenfin | ack | 17:50 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263 | 17:51 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263 | 17:53 |
| efried | stephenfin: tbc, will this ^ work with all versions of blockdiag? | 17:56 |
| stephenfin | yeah, it's the more correct fix tbh | 17:56 |
| efried | okay cool. | 17:56 |
| *** martinkennelly has quit IRC | 17:56 | |
| stephenfin | per commit message, we were previously relying on an import through via module | 17:57 |
| stephenfin | direct import, no problemo | 17:57 |
| sean-k-mooney | stephenfin: so if i just comment out there replacement of the getreader form codec it just works | 17:58 |
| stephenfin | sean-k-mooney: that's what I'm essentially doing | 17:58 |
| stephenfin | and we should submit a patch to the project to fix that | 17:58 |
| *** ociuhandu has quit IRC | 17:58 | |
| sean-k-mooney | ya im runing there tests now | 17:59 |
| stephenfin | but the reason we monkeypatched this in the first place was that the project was on life-support | 17:59 |
| *** ociuhandu has joined #openstack-nova | 17:59 | |
| efried | I'll just validate it locally with a couple versions and then fast approve | 17:59 |
| stephenfin | looks like it's revived now so we can hopefully fix it there and bump our minimum to 2.0.1 or whatever | 17:59 |
| *** Sundar has quit IRC | 18:02 | |
| stephenfin | efried: I'm not going to bother respinning those since hopefully the fixup patches from sean-k-mooney and I will resolve them pretty soon | 18:07 |
| stephenfin | and if they don't, who cares | 18:07 |
| efried | not I, until the next time it breaks :P | 18:08 |
| sean-k-mooney | ignoring one test failure that they have on there master branch it passes there test so im going to submit a pull request to blockdiag | 18:08 |
| *** maciejjozefczyk has quit IRC | 18:14 | |
| *** IvensZambrano has quit IRC | 18:17 | |
| *** eharney has joined #openstack-nova | 18:21 | |
| *** salmankhan has quit IRC | 18:22 | |
| *** ociuhandu has quit IRC | 18:22 | |
| *** tosky has quit IRC | 18:36 | |
| *** luksky has joined #openstack-nova | 18:42 | |
| *** ralonsoh has quit IRC | 18:51 | |
| *** igordc has joined #openstack-nova | 19:03 | |
| *** mgariepy has quit IRC | 19:06 | |
| *** eharney has quit IRC | 19:09 | |
| *** mgariepy has joined #openstack-nova | 19:09 | |
| cmurphy | lbragstad: could you help sanity check https://review.opendev.org/#/c/676682/6/nova/policies/admin_actions.py | 19:16 |
| *** eharney has joined #openstack-nova | 19:21 | |
| *** eharney has quit IRC | 19:26 | |
| *** eharney has joined #openstack-nova | 19:26 | |
| *** pcaruana has quit IRC | 19:30 | |
| efried | stephenfin: Sending the blockdiag patch. Sorry for the delay, had some distractions. Do you want to fup to fix those links? | 19:38 |
| *** jamesdenton has quit IRC | 19:40 | |
| *** READ10 has quit IRC | 19:53 | |
| lbragstad | cmurphy is the question about where the deprecation should live? | 19:57 |
| *** efried has quit IRC | 19:58 | |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Define Cyborg ARQ binding notification event. https://review.opendev.org/692707 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227 | 19:59 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | 19:59 |
| *** dklyle has quit IRC | 20:15 | |
| *** efried has joined #openstack-nova | 20:16 | |
| *** dklyle has joined #openstack-nova | 20:19 | |
| *** eharney has quit IRC | 20:49 | |
| *** Liang__ has quit IRC | 20:51 | |
| openstackgerrit | Merged openstack/nova master: docs: Fix the monkeypatching of blockdiag https://review.opendev.org/705263 | 20:53 |
| cmurphy | lbragstad: yes basically | 21:13 |
| *** nweinber has quit IRC | 21:32 | |
| *** mriedem has left #openstack-nova | 21:54 | |
| *** eharney has joined #openstack-nova | 22:01 | |
| *** tosky has joined #openstack-nova | 22:05 | |
| *** KeithMnemonic has quit IRC | 22:06 | |
| *** ociuhandu has joined #openstack-nova | 22:20 | |
| *** ociuhandu has quit IRC | 22:26 | |
| *** rchurch_ has quit IRC | 22:31 | |
| *** rchurch has joined #openstack-nova | 22:33 | |
| *** mriedem has joined #openstack-nova | 22:42 | |
| *** nweinber has joined #openstack-nova | 22:49 | |
| *** avolkov has quit IRC | 23:01 | |
| *** damien_r has quit IRC | 23:14 | |
| *** nweinber has quit IRC | 23:17 | |
| *** eharney has quit IRC | 23:20 | |
| *** jmlowe has joined #openstack-nova | 23:21 | |
| *** mlavalle has quit IRC | 23:29 | |
| *** spatel has joined #openstack-nova | 23:38 | |
| *** spatel has quit IRC | 23:42 | |
| *** igordc has quit IRC | 23:52 | |
| *** damien_r has joined #openstack-nova | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!