*** ociuhandu has joined #openstack-nova | 00:04 | |
*** ociuhandu has quit IRC | 00:09 | |
*** eharney has quit IRC | 00:15 | |
*** nicolasbock has quit IRC | 00:18 | |
*** eharney has joined #openstack-nova | 00:27 | |
*** brinzhang has joined #openstack-nova | 00:29 | |
*** nweinber has quit IRC | 00:33 | |
*** takamatsu has quit IRC | 00:35 | |
*** macz_ has quit IRC | 00:36 | |
*** sean-k-mooney has joined #openstack-nova | 00:39 | |
*** tbachman has joined #openstack-nova | 00:43 | |
sean-k-mooney | dansmith: efried just heading to bed but my multinode cyborg tempest full job https://review.opendev.org/#/c/709641/5 just completed https://48ef08cde8cc22034a1d-8011a2266d21f0c09baf1c83d6d5002e.ssl.cf5.rackcdn.com/709641/5/check/cyborg-multinode-tempest-full/e4d260f/testr_results.html | 00:48 |
---|---|---|
sean-k-mooney | i have only skimmed them quickly but i belive it shows that vms can be booted with cyborg flavor initail since tempest.api.compute.servers.test_create_server.ServersTestJSON.test_host_name_is_same_as_server_name passed i change the default flavor to request a fake deivce | 00:49 |
sean-k-mooney | it also repoduced teh 401 issue where the keystone middelware eventually starts rejecting the token because it think it expires | 00:50 |
sean-k-mooney | and i can see the live migration operations fail with Details: {'code': 400, 'message': 'No valid host was found. Unable to move instance 229ab495-b151-4522-b8dd-fa5818e302dd to host ubuntu-bionic-vexxhost-sjc1-0014809343. The instance has complex allocations on the source host so move cannot be forced.'} | 00:51 |
sean-k-mooney | so i think that is implying that 1 the vm was created with the cybrog resouces and two live migration is being rejected before we get to the driver which is good | 00:52 |
sean-k-mooney | that was from test_live_block_migration | 00:52 |
*** takamatsu has joined #openstack-nova | 00:52 | |
sean-k-mooney | anyway im calling it a night o/ hopefully that will be useful as it is repoducing the same issues i was seeing and its now automated so easy to rerun | 00:54 |
*** sean-k-mooney has quit IRC | 00:59 | |
*** brinzhang_ has joined #openstack-nova | 01:04 | |
*** brinzhang_ has quit IRC | 01:05 | |
*** brinzhang_ has joined #openstack-nova | 01:06 | |
*** brinzhang has quit IRC | 01:08 | |
*** ileixe has joined #openstack-nova | 01:09 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-volumes-attachments policies https://review.opendev.org/709929 | 01:55 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-volumes-attachments policy https://review.opendev.org/709388 | 02:00 |
*** ociuhandu has joined #openstack-nova | 02:06 | |
*** ociuhandu has quit IRC | 02:11 | |
*** gyee has quit IRC | 02:13 | |
*** brinzhang has joined #openstack-nova | 02:33 | |
*** kaisers_away has quit IRC | 02:34 | |
*** brinzhang_ has quit IRC | 02:36 | |
*** ileixe has quit IRC | 02:46 | |
*** mkrai has joined #openstack-nova | 02:46 | |
*** mkrai has quit IRC | 02:52 | |
*** mkrai_ has joined #openstack-nova | 02:52 | |
*** Nel1x has quit IRC | 03:04 | |
*** xiaolin has joined #openstack-nova | 03:07 | |
*** nweinber has joined #openstack-nova | 03:08 | |
*** zhanglong has joined #openstack-nova | 03:13 | |
*** nweinber has quit IRC | 03:17 | |
*** Nel1x has joined #openstack-nova | 03:22 | |
*** zhanglong has quit IRC | 03:36 | |
*** zhanglong has joined #openstack-nova | 03:37 | |
*** hongbin has joined #openstack-nova | 03:49 | |
*** ileixe has joined #openstack-nova | 03:53 | |
*** chenhaw has joined #openstack-nova | 03:55 | |
*** chenhaw has quit IRC | 03:55 | |
*** chenhaw has joined #openstack-nova | 03:57 | |
*** chenhaw has quit IRC | 03:58 | |
*** nweinber has joined #openstack-nova | 03:59 | |
*** brinzhang_ has joined #openstack-nova | 03:59 | |
*** brinzhang_ has quit IRC | 04:01 | |
*** brinzhang_ has joined #openstack-nova | 04:01 | |
*** brinzhang has quit IRC | 04:02 | |
*** brinzhang_ has quit IRC | 04:03 | |
*** brinzhang_ has joined #openstack-nova | 04:03 | |
*** brinzhang_ has quit IRC | 04:04 | |
*** brinzhang_ has joined #openstack-nova | 04:05 | |
*** nweinber has quit IRC | 04:09 | |
*** yedongcan has quit IRC | 04:10 | |
*** mkrai_ has quit IRC | 04:17 | |
*** mkrai has joined #openstack-nova | 04:17 | |
*** brinzhang has joined #openstack-nova | 04:23 | |
*** brinzhang has quit IRC | 04:25 | |
*** brinzhang has joined #openstack-nova | 04:25 | |
*** brinzhang_ has quit IRC | 04:26 | |
*** factor has quit IRC | 04:31 | |
*** factor has joined #openstack-nova | 04:31 | |
*** mkrai has quit IRC | 04:37 | |
*** mkrai_ has joined #openstack-nova | 04:38 | |
*** hongbin has quit IRC | 04:39 | |
*** yaawang has joined #openstack-nova | 04:44 | |
*** imacdonn has quit IRC | 04:47 | |
*** imacdonn has joined #openstack-nova | 04:47 | |
*** brinzhang_ has joined #openstack-nova | 04:48 | |
*** Nel1x has quit IRC | 04:50 | |
*** brinzhang_ has quit IRC | 04:50 | |
*** brinzhang_ has joined #openstack-nova | 04:50 | |
*** brinzhang has quit IRC | 04:51 | |
*** brinzhang_ has quit IRC | 04:52 | |
*** brinzhang_ has joined #openstack-nova | 04:52 | |
*** zhanglong has quit IRC | 04:53 | |
*** brinzhang_ has quit IRC | 04:54 | |
*** brinzhang_ has joined #openstack-nova | 04:54 | |
*** zhanglong has joined #openstack-nova | 04:55 | |
*** brinzhang_ has quit IRC | 04:56 | |
*** brinzhang_ has joined #openstack-nova | 04:56 | |
*** brinzhang_ has quit IRC | 04:58 | |
*** brinzhang_ has joined #openstack-nova | 04:59 | |
*** brinzhang_ has quit IRC | 05:12 | |
*** brinzhang_ has joined #openstack-nova | 05:12 | |
*** brinzhang_ has quit IRC | 05:14 | |
*** brinzhang_ has joined #openstack-nova | 05:14 | |
*** brinzhang_ has quit IRC | 05:15 | |
*** brinzhang_ has joined #openstack-nova | 05:16 | |
*** brinzhang_ has quit IRC | 05:17 | |
*** brinzhang_ has joined #openstack-nova | 05:18 | |
*** brinzhang_ has quit IRC | 05:18 | |
*** brinzhang_ has joined #openstack-nova | 05:19 | |
*** tetsuro has quit IRC | 05:20 | |
*** tetsuro has joined #openstack-nova | 05:22 | |
*** links has joined #openstack-nova | 05:25 | |
*** vishalmanchanda has joined #openstack-nova | 05:34 | |
*** evrardjp has quit IRC | 05:34 | |
*** evrardjp has joined #openstack-nova | 05:35 | |
*** tetsuro has quit IRC | 05:39 | |
*** udesale has joined #openstack-nova | 05:41 | |
*** udesale has quit IRC | 05:41 | |
*** udesale has joined #openstack-nova | 05:41 | |
*** larainema has joined #openstack-nova | 05:51 | |
*** zhanglong has quit IRC | 05:58 | |
*** zhanglong has joined #openstack-nova | 06:01 | |
*** ratailor has joined #openstack-nova | 06:06 | |
*** kozhukalov has joined #openstack-nova | 06:08 | |
*** ociuhandu has joined #openstack-nova | 06:08 | |
*** ociuhandu has quit IRC | 06:13 | |
*** ratailor has quit IRC | 06:18 | |
*** zhanglong has quit IRC | 06:20 | |
*** brinzhang_ has quit IRC | 06:20 | |
*** brinzhang_ has joined #openstack-nova | 06:21 | |
*** ratailor has joined #openstack-nova | 06:21 | |
*** zhanglong has joined #openstack-nova | 06:22 | |
*** brinzhang_ has quit IRC | 06:22 | |
*** brinzhang_ has joined #openstack-nova | 06:23 | |
*** brinzhang has joined #openstack-nova | 06:24 | |
*** udesale has quit IRC | 06:24 | |
*** brinzhang has quit IRC | 06:25 | |
*** udesale has joined #openstack-nova | 06:25 | |
*** brinzhang has joined #openstack-nova | 06:25 | |
*** brinzhang has joined #openstack-nova | 06:27 | |
*** brinzhang has quit IRC | 06:27 | |
*** brinzhang_ has quit IRC | 06:28 | |
*** brinzhang has joined #openstack-nova | 06:28 | |
*** brinzhang has quit IRC | 06:29 | |
*** brinzhang has joined #openstack-nova | 06:30 | |
*** tetsuro has joined #openstack-nova | 06:31 | |
*** brinzhang has quit IRC | 06:31 | |
*** brinzhang has joined #openstack-nova | 06:32 | |
*** brinzhang has quit IRC | 06:33 | |
*** brinzhang has joined #openstack-nova | 06:34 | |
*** brinzhang has quit IRC | 06:35 | |
*** brinzhang has joined #openstack-nova | 06:36 | |
*** brinzhang has quit IRC | 06:39 | |
*** brinzhang has joined #openstack-nova | 06:40 | |
*** brinzhang has quit IRC | 06:42 | |
*** brinzhang has joined #openstack-nova | 06:42 | |
*** rcernin has quit IRC | 06:47 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Fix os-volumes-attachments policy to be admin_or_owner https://review.opendev.org/709955 | 06:51 |
*** ociuhandu has joined #openstack-nova | 07:02 | |
*** ociuhandu has quit IRC | 07:07 | |
*** mkrai_ has quit IRC | 07:10 | |
*** udesale has quit IRC | 07:12 | |
*** udesale has joined #openstack-nova | 07:12 | |
*** mkrai has joined #openstack-nova | 07:27 | |
*** xiaolin has quit IRC | 07:33 | |
brinzhang | melwitt, gmann, stephenfin: is bug 1864776 real? can you all check? | 07:35 |
openstack | bug 1864776 in OpenStack Compute (nova) "os-volumes-attachments API policy is allowed for everyone even policy defaults is admin_or_owner" [Undecided,In progress] https://launchpad.net/bugs/1864776 - Assigned to Brin Zhang (zhangbailin) | 07:35 |
brinzhang | gmann: the new policy of admin_api is {self.legacy_admin_context, self.system_admin_context, self.project_admin_context}, and new policy of the admin_or_owner is {self.legacy_admin_context, self.system_admin_context, self.project_admin_context, self.project_member_context, self.system_member_context, self.system_reader_context, self.system_foo_context, self.project_foo_context, self.project_reader_context, self.other_project_member_context}, | 07:40 |
brinzhang | it's all of the author contexts.} | 07:40 |
brinzhang | gmann: Understand of this right? | 07:40 |
*** ociuhandu has joined #openstack-nova | 07:42 | |
*** slaweq_ has joined #openstack-nova | 07:42 | |
*** slaweq_ is now known as slaweq | 07:45 | |
*** ociuhandu has quit IRC | 07:48 | |
*** brinzhang_ has joined #openstack-nova | 08:00 | |
*** brinzhang_ has quit IRC | 08:02 | |
*** brinzhang_ has joined #openstack-nova | 08:02 | |
*** brinzhang has quit IRC | 08:03 | |
*** ociuhandu has joined #openstack-nova | 08:05 | |
*** tesseract has joined #openstack-nova | 08:06 | |
*** jawad_axd has joined #openstack-nova | 08:07 | |
*** mkrai has quit IRC | 08:10 | |
*** mkrai has joined #openstack-nova | 08:10 | |
*** ociuhandu has quit IRC | 08:11 | |
*** mkrai has quit IRC | 08:16 | |
*** mkrai_ has joined #openstack-nova | 08:16 | |
*** udesale has quit IRC | 08:18 | |
*** brinzhang has joined #openstack-nova | 08:21 | |
*** yaawang has quit IRC | 08:21 | |
*** yaawang has joined #openstack-nova | 08:21 | |
*** iurygregory has joined #openstack-nova | 08:21 | |
*** brinzhang has quit IRC | 08:21 | |
*** brinzhang has joined #openstack-nova | 08:22 | |
*** rcernin has joined #openstack-nova | 08:22 | |
*** maciejjozefczyk has joined #openstack-nova | 08:22 | |
*** brinzhang_ has quit IRC | 08:23 | |
*** brinzhang has quit IRC | 08:23 | |
*** brinzhang has joined #openstack-nova | 08:24 | |
*** brinzhang has quit IRC | 08:26 | |
*** brinzhang has joined #openstack-nova | 08:26 | |
*** brinzhang has quit IRC | 08:28 | |
*** damien_r has joined #openstack-nova | 08:28 | |
*** brinzhang has joined #openstack-nova | 08:29 | |
*** amoralej|off is now known as amoralej | 08:31 | |
*** brinzhang has quit IRC | 08:31 | |
*** brinzhang has joined #openstack-nova | 08:31 | |
*** brinzhang has quit IRC | 08:33 | |
*** brinzhang has joined #openstack-nova | 08:33 | |
*** brinzhang has quit IRC | 08:35 | |
*** brinzhang has joined #openstack-nova | 08:35 | |
*** brinzhang has quit IRC | 08:37 | |
*** brinzhang has joined #openstack-nova | 08:38 | |
*** brinzhang has joined #openstack-nova | 08:39 | |
*** udesale has joined #openstack-nova | 08:39 | |
*** brinzhang has quit IRC | 08:40 | |
*** brinzhang has joined #openstack-nova | 08:41 | |
*** mkrai_ has quit IRC | 08:42 | |
*** mkrai__ has joined #openstack-nova | 08:42 | |
*** mlycka has joined #openstack-nova | 08:52 | |
*** ralonsoh has joined #openstack-nova | 08:53 | |
*** tkajinam has quit IRC | 08:57 | |
*** lennyb has quit IRC | 09:06 | |
*** lennyb has joined #openstack-nova | 09:07 | |
*** ociuhandu has joined #openstack-nova | 09:08 | |
*** xek_ has joined #openstack-nova | 09:19 | |
*** ociuhandu has quit IRC | 09:22 | |
*** psachin has joined #openstack-nova | 09:25 | |
*** tesseract has quit IRC | 09:35 | |
*** tesseract has joined #openstack-nova | 09:36 | |
*** ociuhandu has joined #openstack-nova | 09:42 | |
*** martinkennelly has joined #openstack-nova | 09:49 | |
*** jangutter has joined #openstack-nova | 09:57 | |
*** jangutter has quit IRC | 09:57 | |
*** jangutter has joined #openstack-nova | 09:57 | |
*** jangutter has quit IRC | 09:58 | |
*** jangutter has joined #openstack-nova | 09:59 | |
openstackgerrit | Kevin Zhao proposed openstack/nova master: Add default cpu model for aarch64 https://review.opendev.org/709494 | 10:04 |
*** ociuhandu has quit IRC | 10:11 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | 10:16 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | 10:16 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | 10:16 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.82 allowing boot from volume rescue https://review.opendev.org/701430 | 10:16 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 10:16 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | 10:16 |
gibi | rm_work: responded in https://review.opendev.org/#/c/709280 I'm happy to help with technicalities but I missing the what the feature is supposed to achive and how the existing impl in neutron works | 10:18 |
rm_work | gibi: just read it, thanks! | 10:19 |
rm_work | so, the key is that it's not really a feature for end users at all -- it's for service integration cases | 10:20 |
rm_work | the octavia use-case is here: https://review.opendev.org/#/c/706153/ | 10:20 |
rm_work | gibi: as it is, neutron has been creating aggregates for each segment_it in a routed network automatically, for like... 3 cycles already maybe? | 10:21 |
*** ociuhandu has joined #openstack-nova | 10:21 | |
rm_work | so for example, if i take a look at my Staging environment's aggregate list, it looks like this: http://paste.openstack.org/show/7YyK5FtL2OiXgErAjMbM/ | 10:24 |
rm_work | that aggregate was automatically created by neutron because it was configured as a routed network with a segment and those HVs were assigned to that segment in neutron | 10:24 |
rm_work | gibi: i don't think there's really any further work to be done -- this filter *just works* already for the intended purpose -- allowing services to hint to nova which aggregate to schedule to, based on network segment | 10:25 |
rm_work | the real challenge is just getting it merged :) | 10:26 |
rm_work | I know of at least two companies running this filter on live clouds already, one of them for many years | 10:26 |
rm_work | the second use-case is live-migrate, and I already have the basic patch for it (again, has been running for quite a while in some clouds) but I'm not spending the effort to get it all prettified yet until I have some confidence that this filter might be accepted | 10:27 |
gibi | rm_work: reading back ... | 10:28 |
rm_work | this is it though: http://paste.openstack.org/show/Z8ZYksr4uisFUddFoyOu/ | 10:29 |
rm_work | basically all I could ask from you is a +1 instead of a -1 if you understand what I'm going for here | 10:29 |
rm_work | trying to unlock useful features that have been stuck downstream because people didn't have the energy to do what I'm doing and post them upstream with tests and docs, and convince people to review :D | 10:30 |
*** ociuhandu has quit IRC | 10:31 | |
gibi | rm_work: so the new scheduler hint routed_segments is a list of segment ids | 10:31 |
rm_work | yes | 10:32 |
gibi | rm_work: and the filter try to find an aggregate that has a name that ends with such segment id | 10:32 |
rm_work | users can't actually see segment_ids, so it's not really useful for the end-user side -- it's designed for service interactions | 10:32 |
rm_work | yes, as that's the neutron spec to auto-create aggregates with segment_ids with that name format | 10:32 |
gibi | rm_work: do you have a link to that neutron spec? | 10:33 |
rm_work | let me look | 10:33 |
gibi | so how the 'service' that calls nova knows the segment id it needs to pass in the scheduler hint? | 10:33 |
rm_work | nova side: https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/neutron-routed-networks.html#proposed-change | 10:36 |
rm_work | neutron side: https://specs.openstack.org/openstack/neutron-specs/specs/newton/routed-networks.html | 10:36 |
gibi | thanks | 10:36 |
gibi | I have to read up | 10:37 |
rm_work | gibi: so for the octavia case, the issue is that we need both of the service-vms we build to be in the same segment as the VIP (an unbound neutron port) we create | 10:37 |
rm_work | so, we simply look at that port, then look at the subnet it's on, and get the segment_id, then boot using that | 10:37 |
gibi | rm_work: thanks ^^ | 10:37 |
rm_work | for the live-migrate case in nova, it's basically the same -- all the ports need to be pluggable to the new VM, so the new VM needs to have access to the same segments -- so it looks at all the ports on the old VM, gets the subnets->segments from them, and then does the migrate to a host that schedules with all of the relevant segments | 10:38 |
rm_work | you probably don't have to read the ENTIRETY of both specs to get the idea, and I don't know whether they ended up matching the implementation EXACTLY, but I can answer questions | 10:39 |
ileixe | rm_work: gibi: sorry to hijack, may I ask one more question? | 10:40 |
rm_work | o/ | 10:40 |
gibi | rm_work: thanks. This description helped me a lot | 10:41 |
ileixe | You said normal users were unaware of segments, does it mean normal user does not make VM using routed network? | 10:41 |
rm_work | when routed-networks are in use, the user is really not even aware of it | 10:41 |
rm_work | it's all handled inside nova/neutron | 10:41 |
rm_work | as far as the user is aware, they simply ask for a VM on a network, and it happens | 10:42 |
ileixe | Yes, so what happens to the normal user? | 10:42 |
ileixe | then they are not using routed network, right? | 10:42 |
gibi | rm_work: can we trade? :) I will support your way forward to either have the filter or the placement based sollution in ussuri, in reaturn you can help me reviewing the tempest patch? | 10:42 |
rm_work | so in the normal workflow, the user will do a nova boot, and it will go for scheduling, schedule to any HV, and then network plugging will be deferred to neutron instead of nova picking the IP | 10:42 |
rm_work | then neutron will look at the HV it was scheduled to, pick an appropriate segment, and do the IP assignment/plug on the neutron side | 10:42 |
rm_work | routed networks is kinda just... something that a cloud either needs (and thus uses) or doesn't. in a cloud that's routed-network enabled, there really aren't *non-routed* networks, usually (at least, not that i've seen) | 10:44 |
gibi | so for first boot neutron will select the segment, but for live migrate nova should select a host that supports the same segment | 10:44 |
rm_work | it's really a network implementation choice | 10:44 |
rm_work | gibi: correct | 10:44 |
rm_work | currently, live-migrate cannot work in a routed-network enabled cloud | 10:44 |
gibi | rm_work: wooot! Finally I undestood it :) | 10:44 |
rm_work | because the scheduling doesn't understand it, and will pick some random HV based on other scheduling criteria, and then that HV may not actually be in the correct aggregate for plugging the old port :) | 10:45 |
*** sean-k-mooney has joined #openstack-nova | 10:45 | |
gibi | plugging the old port in live migrate case fails becuase the port is already assigned to segment? while in the normal boot case the port is in a deferred state so the plug wont fail | 10:45 |
rm_work | yes | 10:46 |
* gibi gaining speed :) | 10:46 | |
rm_work | live-migrate needs to keep the old address (port) | 10:46 |
rm_work | a segment is a subnet attribute | 10:46 |
rm_work | port has an address (which is part of a subnet) | 10:46 |
sean-k-mooney | gibi: pluging the port on live migration would work if we live migrated to the same netwrok segment | 10:46 |
rm_work | so one Network can have many Subnets, each which is a separate segment | 10:46 |
gibi | ok, so during cold migrate if the port needs to be plugged to another segment then it will change IP address but it si not a problem as the guest is rebooted anyhow | 10:47 |
ileixe | "neutron will look at the HV it was scheduled to, pick an appropriate segment, and do the IP assignment/plug on the neutron side" <- that's the point that I was unaware of | 10:47 |
rm_work | sean-k-mooney: right, so that's what we're talking about -- this simple filter allows for that | 10:47 |
ileixe | Thanks for explanation I will look at it | 10:47 |
sean-k-mooney | gibi: it should not change ip | 10:47 |
gibi | sean-k-mooney: but if it changes segment then it will change IP | 10:47 |
rm_work | I actually haven't even paid attention to cold-migrate, we don't do it either, or care :D it may have the same issue as live-migrate | 10:48 |
gibi | ahh I see | 10:48 |
rm_work | I am not sure | 10:48 |
sean-k-mooney | that my point its not vaild for the port to change its ip on a move operation so it cannot change segment | 10:48 |
rm_work | right | 10:48 |
sean-k-mooney | which is why it fails today | 10:48 |
rm_work | sean-k-mooney: https://review.opendev.org/#/c/709280/ | 10:48 |
gibi | rm_work: look, I understand you dont care but I as a nova maintainer needs to care. Hence my previous -1 as I did not understood the feature | 10:48 |
rm_work | this is a very very simple way to get live-migrate and other service-to-service use-cases unblocked | 10:49 |
sean-k-mooney | we use ip_allocation=defer to allow the ip to be allcoated when we bind the port but it cannoth change again after that point | 10:49 |
rm_work | gibi: right, sorry, I didn't mean that I don't care if all features work -- i mean i didn't care personally so hadn't checked whether it was the same issue -- this would solve it anyway if it is, and not affect it if it isn't | 10:49 |
rm_work | i'm not going to propose a feature that breaks other stuff :) | 10:49 |
gibi | sean-k-mooney: I rely on you about defining what is the expected behavior of a port during cold migrate in the current case so if you say it should not change IP then it accept that | 10:50 |
rm_work | sure, and in that case, this would allow to solve for cold-migrate as well | 10:50 |
rm_work | in the same way | 10:50 |
gibi | rm_work: no worries. I need to act as a guardian not you. I just explained why I was -1 | 10:51 |
sean-k-mooney | rm_work: just looking at it now but how is the segment id passed to nova? a schduler hint or somehting like that | 10:51 |
rm_work | sean-k-mooney: scheduler hint, yes | 10:51 |
sean-k-mooney | --hint routed_segments=96a9316a-54cb-4043-9ccc-b9cacd0d4d52 | 10:52 |
* gibi needs to read mriedem's patch as well as that was an alternative solution | 10:52 | |
sean-k-mooney | so is that uuid a placement aggreate uuid | 10:52 |
sean-k-mooney | so we convert that to a member_of ? | 10:52 |
gibi | right now I like the simplicity of the filter, but I does not like matching the _name_ of the aggregate as that feels hackish | 10:52 |
rm_work | sean-k-mooney: this is a neutron segment_id | 10:52 |
rm_work | gibi: yeah I am not a huge fan of name-comparison as a matcher either, but per the spec it DOES work | 10:53 |
rm_work | so, this stuff is also in Placement as well | 10:53 |
rm_work | and in Placement it has a little tighter mapping | 10:53 |
sean-k-mooney | right so filters are not allowed to call other servcies rest apis so im wondering how nova knows if a host is connected to the segment | 10:53 |
gibi | rm_work: yeah I got it that this aggregate naming thing was how it is speced and implemented | 10:53 |
rm_work | sean-k-mooney: nova aggregates | 10:53 |
gibi | sean-k-mooney: ^^ | 10:53 |
sean-k-mooney | if we have nova host aggreates we dont need a new filter | 10:54 |
rm_work | sean-k-mooney: see for example http://paste.openstack.org/show/7YyK5FtL2OiXgErAjMbM/ | 10:54 |
rm_work | we don't know the correct nova aggregate | 10:54 |
rm_work | other services would know the segment_id | 10:54 |
rm_work | nove understands the host-aggregates internally and how they map to segments | 10:55 |
rm_work | sorry, when I say "we" in this case I mean other services | 10:55 |
rm_work | (I am speaking from the Octavia point of view, for example) | 10:55 |
rm_work | What Octavia has is a port, with a subnet and thus a segment_id | 10:56 |
rm_work | Octavia needs to tell Nova to schedule to the aggregate that has that segment_id | 10:56 |
*** brinzhang_ has joined #openstack-nova | 10:57 | |
rm_work | I guess you're saying that there exists a filter already that would allow us to specify an aggregate for scheduling, and we could just look that up? | 10:57 |
sean-k-mooney | i think there is one that would allow that yes | 10:58 |
sean-k-mooney | i tought we could use the json filter for that but it looks like the answer is no | 10:58 |
gibi | sean-k-mooney: AggregateInstanceExtraSpec filter works based on flavors and aggregate extra spec. but we only have the aggregate name to match | 10:58 |
rm_work | sean-k-mooney: so here is the example patch for how to make live-migrate work with this: http://paste.openstack.org/show/Z8ZYksr4uisFUddFoyOu/ | 10:59 |
*** brinzhang_ has quit IRC | 10:59 | |
rm_work | gibi: i guess TECHNICALLY it's possible for other services to query nova for aggregate list, and do the matchup on their own | 10:59 |
sean-k-mooney | gibi: ya the aggreate image and extraspec filters are not the right granulatrity | 10:59 |
*** brinzhang_ has joined #openstack-nova | 10:59 | |
sean-k-mooney | i was considering the compute capabliteis filter | 10:59 |
rm_work | assuming we could pass an aggregate_id? | 10:59 |
sean-k-mooney | but setting the segment on each host would be a pain | 11:00 |
gibi | rm_work: you could not pass agg_id either, you can specify agg extra_spec in the flavor | 11:00 |
rm_work | in the *flavor*? | 11:00 |
rm_work | yeah, that's not workable | 11:00 |
sean-k-mooney | the issue with the filter based approch is if you change the default result set size form placment it can end up retruning only hosts that cant pass the filter | 11:00 |
*** brinzhang has quit IRC | 11:00 | |
sean-k-mooney | its the issue that cern had with only 10 results | 11:01 |
rm_work | hmm | 11:01 |
gibi | rm_work: yeah in the flavor, so I getting to grasp why you are in pain | 11:01 |
sean-k-mooney | /results/allocation_candiates | 11:01 |
*** priteau has joined #openstack-nova | 11:01 | |
rm_work | yeah we don't want to lock one flavor to one aggregate T_T | 11:01 |
rm_work | sean-k-mooney: hmm interesting... | 11:01 |
sean-k-mooney | i dont think we should do this as a filter. we could do it as a pre-filter | 11:02 |
gibi | sean-k-mooney: that is a valid point, but limit is configurable so the deployer can ask for a lot of candidates via a big limit to avoid this | 11:02 |
sean-k-mooney | and transfrom the hint into a member_of | 11:02 |
rm_work | so if we had, say, 100 HVs and 10 segments... it's possible that the filter would only even have 10 hosts as candidates, none of which are in the target filters? | 11:02 |
gibi | sean-k-mooney: pre-filter is mriedem's approach | 11:02 |
rm_work | *target segments? | 11:02 |
gibi | rm_work: the ac limit is 1000 by default but yes | 11:02 |
rm_work | ahaha ok | 11:02 |
sean-k-mooney | gibi: yes although i think we need a much more holistic aproch as i said in my comment on his patch | 11:03 |
gibi | sean-k-mooney: I'm totally up for a holistic approach I just did not understand mriedem's way of doing this yet | 11:03 |
gibi | but this current discussion will help about that | 11:03 |
sean-k-mooney | ack | 11:04 |
gibi | sean-k-mooney: so your approach would be to take the hint and use it as a member_of query. As these aggregates are nova aggregatest they are expected to be mirrored in placement too so member_of would work | 11:06 |
rm_work | yeah so the point of doing it this way was to try to make it LESS controversial :D | 11:06 |
sean-k-mooney | well my short term hack yes | 11:06 |
*** mlycka has quit IRC | 11:06 | |
sean-k-mooney | i dont think we should need a hint | 11:07 |
rm_work | simplify the use-case target (admin, not users) and make it an optional filter, not in normal code-path | 11:07 |
gibi | and this way we could avoid the issue with the a_c limit | 11:07 |
rm_work | so yeah, they're in placement | 11:07 |
sean-k-mooney | i want neutron to pass the placmeent aggretae and not require the create of any nova aggreates | 11:07 |
*** ociuhandu has joined #openstack-nova | 11:07 | |
sean-k-mooney | the ip segments should be mirrored by neutron into placement as aggretes | 11:07 |
gibi | sean-k-mooney: and since qos nova support we have a way to pass traits and RCs but not aggregates from neutron to nova | 11:07 |
sean-k-mooney | yes so we would have to extend that | 11:08 |
sean-k-mooney | but that would be next cycle at the earliest | 11:08 |
*** tesseract has quit IRC | 11:08 | |
gibi | so the full solution needs a neutron change. I guess rm_work will hate that delay :) | 11:08 |
sean-k-mooney | so if we ignore the approch i would like to do for now | 11:08 |
gibi | sean-k-mooney: agree | 11:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643 | 11:09 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion 2.82, extra spec validation https://review.opendev.org/708436 | 11:09 |
sean-k-mooney | i would be semi ok with an experimental pre-filer with the understanding that we will proably remove it next cycle | 11:09 |
sean-k-mooney | as a FFE | 11:09 |
sean-k-mooney | if we were to do it as a post filter they are plugable and i dont see why it should be in tree | 11:09 |
gibi | sean-k-mooney: that pre-filter will be based on a scheduler hint? | 11:09 |
sean-k-mooney | pre-filters are not plugable so they have to be in tree | 11:09 |
sean-k-mooney | i think that is the shortest path yes | 11:10 |
gibi | I see | 11:11 |
sean-k-mooney | so you dont set ip_allocation defer and precreate the neutron port. neutron assigns it an ip form a segment, then you boot the vm with that port and pass the segment as a hint | 11:11 |
*** tesseract has joined #openstack-nova | 11:11 | |
sean-k-mooney | since the hint will be stored in the request spec it should lock the vm to that segment form then on | 11:12 |
sean-k-mooney | this would alos work the if you just passed the network to nova and let it create the port | 11:12 |
*** ociuhandu has quit IRC | 11:12 | |
gibi | mriedem approach assumes that the segment_id == placement aggregate id so nova cna read the segment id from neutron and construct the placement query without any extra hack | 11:13 |
sean-k-mooney | yes | 11:14 |
gibi | that would remove the need of a hint | 11:14 |
sean-k-mooney | yes | 11:14 |
gibi | so it would remove the ~ API impact due to the hint | 11:14 |
rm_work | sean-k-mooney: so, a post-filter that isn't in-tree, can't be a dependency of other services? I think? | 11:15 |
sean-k-mooney | it does require ues to lookup the segment of every neutron port however | 11:15 |
rm_work | I mean... | 11:15 |
sean-k-mooney | rm_work: well not normally no | 11:15 |
sean-k-mooney | rm_work: what other service are you thinking of | 11:15 |
rm_work | so, I'm trying to merge code in octavia that would use this | 11:15 |
rm_work | I linked the change earlier... let me find it again | 11:15 |
gibi | sean-k-mooney: we do lookup of neutron port information anyhow due to qos so while it is an extra query it is not a totally new thing in the boot and migrate code path | 11:15 |
sean-k-mooney | well you could package the filter in octavia | 11:15 |
sean-k-mooney | then i think it would be fine | 11:16 |
sean-k-mooney | but really im not sure there is time to do this this cycle | 11:16 |
rm_work | https://review.opendev.org/#/c/706153/ | 11:16 |
rm_work | sean-k-mooney: i was hoping an "optional filter" that was essentially just a few lines would be easier to digest, and we could merge it with less controversy T_T | 11:17 |
sean-k-mooney | well from a paper work point of view that is not really allowed but being pragmatic maybe. this technical requirs a spec | 11:17 |
gibi | rm_work: the problem is the new hint, if we merge the filter now, we cannot really remove it later when a better approach is made as the hint becomes an API | 11:17 |
rm_work | it's fine, we are already running this filter internally (it's very simple to drop-in, as you say) so it's not a big deal. I am trying to unlock some of these features we're using to more folks by putting it upstream | 11:18 |
sean-k-mooney | rm_work: yep which is nice to see | 11:18 |
rm_work | for example: we have octavia working in a routed-network setup, and we have live-migrate working | 11:19 |
gibi | rm_work: and by being here and helping me understand the feature you actually made it a bit more likely that there will be upstream support for this | 11:19 |
rm_work | sorry, the "we" in this case is actually two orgs, but I've worked for both of them, heh | 11:19 |
sean-k-mooney | rm_work: for what its worth you could get the same effect by having an availabity zone per ip segment | 11:19 |
gibi | rm_work: so you made a good step forward here. sorry that this is not that straight forward that is could be. but I think we are in a good track | 11:19 |
rm_work | (I am working with jroll currently) | 11:20 |
rm_work | sean-k-mooney: unfortunately that's not an option, heh | 11:20 |
sean-k-mooney | that is what i know people have done in the past | 11:20 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | 11:20 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-volumes-attachments policy https://review.opendev.org/709388 | 11:20 |
sean-k-mooney | so there are a few paths forward. | 11:21 |
sean-k-mooney | 1.) experimtal prefilter that is disabled by default which would lookup the segment id of each port and add a member of | 11:21 |
sean-k-mooney | 2.) post filter that woudl use a schduler hint (packaged in octavia) | 11:21 |
sean-k-mooney | 3.) wait for full solution next cycle | 11:22 |
gibi | I think I can give some help in 1.) | 11:22 |
sean-k-mooney | and start on the spec now to have agreement | 11:22 |
rm_work | well, we'd also like to use the same filter for nova live-migrate, and ironic | 11:22 |
rm_work | so maybe 1 is ok, and we can continue to use the filter for now | 11:22 |
rm_work | and swap over when this is ready upstream | 11:23 |
gibi | rm_work, sean-k-mooney: I will write a summary for the ML about this discussion to see what others think | 11:23 |
gibi | I'm not jumping into writing a full spec yet | 11:24 |
sean-k-mooney | so the only thing i really care about here is ensuring that whatever we decide it does not tie our hands next cycle. which is why i want it to be experimental | 11:24 |
gibi | rm_work: I would appreciate if you could review the currently proposed tempest tests https://review.opendev.org/#/c/665155/16/tempest/scenario/test_routed_provider_network.py | 11:24 |
rm_work | ok | 11:26 |
gibi | rm_work: thanks | 11:26 |
gibi | sean-k-mooney: sure, this is why I don't like the in three hint idea, as that would become an API | 11:26 |
gibi | sean-k-mooney: pre-filter can be a lot more fluid impl, and later we can make neutron to provide the agg ids in the resource_request | 11:27 |
sean-k-mooney | gibi: ya i could live with the perfromance hit if its disabled by default meaning we have to do the api query for the port info in the prefilter | 11:27 |
sean-k-mooney | gibi: yep and even the allcoations in some cases | 11:28 |
sean-k-mooney | wehn you create a port that is consuming an ip it should realy have allready created a placmente allocation for that | 11:28 |
gibi | sean-k-mooney: agreed, this pre-filter is costly so it should be disable by default | 11:29 |
sean-k-mooney | so we would want to pass the aggreate 1 the allcotion unless you defer the ip asginment | 11:29 |
sean-k-mooney | *agggreate and the allocation | 11:29 |
gibi | sean-k-mooney: agree, that allocating IPs needs to be handled as resources in placement but that is really fare in the future based on your current amount of people working on this | 11:29 |
gibi | s/your/our/ | 11:30 |
sean-k-mooney | if we put a concerted effort in i think it could be done next cycle but this would require a resonable amount of work in neutron | 11:30 |
rm_work | i thought neutron already DID all the work in placement | 11:31 |
rm_work | there's more? | 11:31 |
sean-k-mooney | it does not do it the way we want it to | 11:31 |
sean-k-mooney | it is reporting segments as placmenet aggreates | 11:31 |
sean-k-mooney | but its not reporting inventoreis of ips as sharing aggreates | 11:32 |
gibi | sean-k-mooney: at the moment this is not prioritized on my end so I won't commit to this as a spec for the next cycle. I will try to ease the immediate pain with a pre-filter | 11:32 |
*** jaosorior has joined #openstack-nova | 11:32 | |
sean-k-mooney | nor is its tracking segmenation id per segmentation_type (vlan,vxlan,...) and mapping those to addtional aggreates | 11:32 |
gibi | rm_work: there is always more work :) | 11:33 |
sean-k-mooney | yep | 11:33 |
sean-k-mooney | its frustrating becasue i have wanted to solve this problem for longer then plamcnet has existed | 11:34 |
sean-k-mooney | gibi: did you come to intel shannon with jay after the briton mid cycle | 11:34 |
gibi | sean-k-mooney: nope, I wasn't there | 11:35 |
rm_work | yeah that was kinda why i like the simplicity of the filter... it just... works? there's not really many complications | 11:35 |
rm_work | but yeah, it's not the absolute most optimal | 11:35 |
openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Don't print user_data for 'nova show' https://review.opendev.org/708850 | 11:35 |
rm_work | the question is, would we be able to get anything else in the forseeable future? lol | 11:36 |
rm_work | because this filter was technically mergable like ... in newton | 11:36 |
sean-k-mooney | ah ok well i pitched the idea of a json toploogy api for neutron that basicaly exposed a tree based view of resouces and capablites of network backend. this was pre placment and was a staic view but ya i have been wanting to fix this but not had time too for years. | 11:36 |
*** mkrai__ has quit IRC | 11:36 | |
sean-k-mooney | rm_work: actully the prefilter will not just work it will increase the likelyhood of novalid host on a modertly full cloud | 11:37 |
sean-k-mooney | at least if you dont use ip_alloction defer | 11:38 |
sean-k-mooney | if you use the default ip_allocation=immediate | 11:38 |
rm_work | yeah we use defer | 11:38 |
rm_work | this is not for nova to use for initial scheduling really | 11:39 |
sean-k-mooney | then when the neutron port is created it will get an ip and a segment and then we will only consider that segment | 11:39 |
sean-k-mooney | ya with defer it will work as we will schdule to any host then we will only assgin an ip when we bind it the host | 11:39 |
sean-k-mooney | from that point on it will not migrate outside of that segment | 11:40 |
rm_work | right, not intending to mess with the initial scheduling stuff | 11:40 |
rm_work | it's for re-scheduling tasks | 11:40 |
rm_work | like what octavia or live-migrate does | 11:40 |
sean-k-mooney | the same would be true fo nova careated ports actully since we do that on the compute node | 11:41 |
rm_work | when we're already locked to a segment due to an existing port | 11:41 |
sean-k-mooney | ya | 11:41 |
sean-k-mooney | the only case that breaks is precreated port where you have not set ip_allocaton | 11:41 |
sean-k-mooney | the only case that breaks is precreated port where you have not set ip_allocaton=defer | 11:42 |
rm_work | err no, that's exactly one of our cases | 11:43 |
rm_work | octavia creates a port, it gets an IP... then we need to boot nova VMs in that segment | 11:43 |
sean-k-mooney | can octavia use ip_allocatio=defer in that case | 11:45 |
rm_work | no | 11:45 |
sean-k-mooney | ok then it will work until the cloud start to get full | 11:46 |
rm_work | the whole point of us creating that port is to pre-allocate an IP up-front | 11:46 |
sean-k-mooney | or that aggreate | 11:46 |
rm_work | yes, that's true | 11:46 |
*** brinzhang has joined #openstack-nova | 11:46 | |
sean-k-mooney | righ if you preallcoate the ip up front then that determins the segemnt so and with the prefilter we will not consider any other host | 11:46 |
sean-k-mooney | with all the pros and cons that brings | 11:47 |
rm_work | yeah that is why this filter is fine for us, we always know the segment we want | 11:47 |
sean-k-mooney | fundemetally there is no way around that | 11:47 |
sean-k-mooney | but you dont know if there is enough compute resouces in that segment to run the vm | 11:47 |
sean-k-mooney | so you will have to handel the no valid host case | 11:48 |
rm_work | we have no choice | 11:48 |
sean-k-mooney | and either choose a differnt segment or give up | 11:48 |
rm_work | usually we are doing this on an object that has existing for a long time | 11:48 |
rm_work | we have a VIP port, and two VMs that serve HAProxy behind it | 11:48 |
*** martinkennelly has quit IRC | 11:48 | |
rm_work | they are in a keepalived pair | 11:48 |
rm_work | when one fails, we need to boot a new one in the same segment | 11:49 |
*** brinzhang_ has quit IRC | 11:49 | |
rm_work | there is no choice | 11:49 |
sean-k-mooney | for routed networks yes | 11:49 |
sean-k-mooney | although | 11:49 |
sean-k-mooney | only the vip needs to stay the same | 11:49 |
sean-k-mooney | sorry | 11:49 |
sean-k-mooney | octavia the vip is assigned to the vm you are booting | 11:49 |
sean-k-mooney | rm_work: the vip is the public loadblancer ip right? | 11:50 |
sean-k-mooney | the one that applciation will use to connect to the services that are behind it | 11:51 |
*** ociuhandu has joined #openstack-nova | 11:51 | |
rm_work | yes | 11:51 |
rm_work | the VIP is static and is known to the user | 11:51 |
sean-k-mooney | yep | 11:52 |
rm_work | and will always persist (it is unbound, and uses allowed-address-pairs) | 11:52 |
sean-k-mooney | ya | 11:52 |
sean-k-mooney | so even in routed network you could use a /32 route to make that available rigth even if the ha proxy vm ip is not in the same subnet range | 11:53 |
rm_work | so, i'm aware we will have problems if the aggregate fills up, but we have no choice :( | 11:53 |
rm_work | that'd be possible if we had a different network architecture, maybe | 11:53 |
*** mlycka has joined #openstack-nova | 11:53 | |
rm_work | as it is, we cannot | 11:53 |
sean-k-mooney | well bgp would be able to supprot that | 11:54 |
sean-k-mooney | but ya ok | 11:54 |
mlycka | Hello. Is there a specific person responsible for adding new version templates and folders to nova-spec? | 11:54 |
sean-k-mooney | not really we have scripts that do it | 11:54 |
*** ociuhandu has quit IRC | 11:55 | |
mlycka | Right right...when are you likely to run them for V? | 11:55 |
sean-k-mooney | mlycka: but you did remind me i need to go update my patch to move implemented specs | 11:55 |
sean-k-mooney | mlycka: usually not until after m3 | 11:55 |
rm_work | yeah I would kill for working BGP :D | 11:55 |
mlycka | m3? | 11:55 |
sean-k-mooney | milestone 3 so i think start of april | 11:56 |
mlycka | Crud | 11:56 |
sean-k-mooney | we just past the spec freeze for U so we usally dont want to start reviewing new spec right away however you could put up a review against the backlog folder and just update it when its created | 11:57 |
mlycka | I need to move a blueprint proposal to V from U, 'cause I managed to miss my window by being busy and I need to restore it | 11:57 |
sean-k-mooney | ah ok well let me check something | 11:58 |
mlycka | Sure, thanks. | 11:58 |
sean-k-mooney | ok we dont have a script for the new folder although code is welcome. anyone can do it so you have two options. 1 propose a patch that creates the folder and copys the ussuirt template and renames it. 2 restore your spec and propose it to the backlog | 12:00 |
sean-k-mooney | if you go with option 1 just rebase your current spec on top | 12:00 |
sean-k-mooney | it just proably wont get looked at for a little bit | 12:01 |
mlycka | Yeah, that's fair enough. Is the template going to be the same for Victoria then? | 12:01 |
*** brinzhang_ has joined #openstack-nova | 12:02 | |
*** nicolasbock has joined #openstack-nova | 12:03 | |
mlycka | Also, do I need to file a bug for that or is there an existing one or do I just propose a patch without a bug? | 12:03 |
*** TristanSullivan has quit IRC | 12:03 | |
*** brinzhang_ has quit IRC | 12:03 | |
*** brinzhang_ has joined #openstack-nova | 12:04 | |
*** brinzhang has quit IRC | 12:05 | |
openstackgerrit | Merged openstack/nova master: trivial: Remove FakeScheduler https://review.opendev.org/707224 | 12:07 |
openstackgerrit | Merged openstack/nova master: conf: Deprecate '[scheduler] driver' https://review.opendev.org/707225 | 12:07 |
openstackgerrit | Merged openstack/nova master: docs: Improve documentation on writing custom scheduler filters https://review.opendev.org/707226 | 12:08 |
openstackgerrit | Merged openstack/nova master: trivial: Use recognized extra specs in tests https://review.opendev.org/708435 | 12:08 |
gibi | sean-k-mooney, rm_work: mail is up on the ML http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012846.html | 12:08 |
rm_work | ok | 12:10 |
rm_work | so basically i guess i just keep running this filter and my patches as-is downstream, and try to participate in getting this moving forward upstream so eventually we can drop it :D | 12:10 |
gibi | rm_work: good strategy | 12:11 |
*** ratailor has quit IRC | 12:14 | |
sean-k-mooney | gibi: thanks ill take a look at it in a while | 12:16 |
sean-k-mooney | gibi: before that however im going to try and go through https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/provider-config-file today and adress some/all of your comments | 12:18 |
sean-k-mooney | assuming they are not really hard | 12:18 |
gibi | sean-k-mooney: cool. ping me if you need some clarification. honestly I lost the context on that so I dont remember if my comments were hard or not | 12:20 |
sean-k-mooney | well i have not looked at the code before so you know better then i do :) but so far they look ok. i think dustinc is not really around much at the momenet/forseeable future so im going to try and help move it along a bit | 12:21 |
*** maciejjozefczyk has quit IRC | 12:23 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/rocky: Avoid circular reference during serialization https://review.opendev.org/709798 | 12:24 |
gibi | this is a stable only bugfix so it need some non stable core to look at ^^ | 12:24 |
gibi | bauzas, stephenfin: ^^ | 12:25 |
*** psachin has quit IRC | 12:25 | |
sean-k-mooney | why is jsonutils.dumps being used instead of to_primitive? | 12:29 |
openstackgerrit | Marek Lyčka proposed openstack/nova-specs master: Adds spec infrastructure for Victoria https://review.opendev.org/710023 | 12:29 |
*** ociuhandu has joined #openstack-nova | 12:30 | |
sean-k-mooney | oh i guess you are trying to convert it to a dictionay | 12:30 |
sean-k-mooney | by round tripping the data through json | 12:30 |
gibi | sean-k-mooney: the legacy_spec is a dict form of a RequestSpec object | 12:31 |
sean-k-mooney | ya so we cant just use obj_to_primitive | 12:31 |
gibi | but it is a special dict form | 12:31 |
sean-k-mooney | becasue that wont give us what we want | 12:31 |
gibi | it would give us a different dict | 12:32 |
sean-k-mooney | yep so it wont work here | 12:32 |
sean-k-mooney | why do we need to use legacy requests specs in this case? | 12:32 |
sean-k-mooney | i taught we had already moved to ovo form in rocky but i guess not fully | 12:33 |
*** udesale_ has joined #openstack-nova | 12:34 | |
sean-k-mooney | oh its becasue of the workaround for bug #1529084 | 12:36 |
openstack | bug 1529084 in oslo.messaging "RPC fake driver should accept datetime items for data" [Undecided,Fix released] https://launchpad.net/bugs/1529084 - Assigned to Balazs Gibizer (balazs-gibizer) | 12:36 |
*** udesale has quit IRC | 12:36 | |
sean-k-mooney | that intoduced the seriasiation and deserialisation but missed the fact it wont recurse to the nested ovos which is what you are fixing | 12:37 |
sean-k-mooney | another fix would be to fix the rpc fake dirver to accept datimes in dicst and remvoe the jsonutils calls entirely | 12:39 |
gibi | sean-k-mooney: since stein we doesn't use the legacy dict but pass around the ovo, but that is an RPC change it is not backportable | 12:39 |
gibi | sean-k-mooney: but yeah, we we can somehow remove the need of the json.loads(json.dumps(..) stuff that would also help | 12:40 |
*** maciejjozefczyk has joined #openstack-nova | 12:40 | |
*** ociuhandu has quit IRC | 12:40 | |
sean-k-mooney | well the comment says its done beacase teh fake rpc driver does not support datetimes in dicts | 12:41 |
sean-k-mooney | so if we fix that then we could remove it right | 12:41 |
sean-k-mooney | i assume there was a reason bauzas didnt do that orgininally | 12:41 |
sean-k-mooney | other then this was faster | 12:41 |
gibi | I'm not sure what will happen if the dump an load is removed and then the rpc will try to serialize the dict again with ovos inside | 12:42 |
sean-k-mooney | gibi: anway i have not checked that setting default=... will work but your change looks resonable to me | 12:42 |
gibi | sean-k-mooney: the solution is basically change how the to_primitive works during dumps to trigger the ovo serialization instead of stuck in an infinite loop | 12:43 |
sean-k-mooney | ya i was assuming "default=jsonutils.to_primitive" if not set | 12:44 |
gibi | I also filed a bug to oslo.serialization https://bugs.launchpad.net/oslo.serialization/+bug/1864678 | 12:44 |
openstack | Launchpad bug 1864678 in oslo.serialization "jsonutils.to_primitive does not follow the protocol required by json.dump" [Medium,Triaged] | 12:44 |
sean-k-mooney | so you are just passing an extra argment to it with functools.partial | 12:44 |
gibi | sean-k-mooney: yeas, that is the default by default (sic) | 12:44 |
gibi | sean-k-mooney: yes | 12:44 |
sean-k-mooney | yep so that all makes sense to me. its not the cleanest thing long term but its the minimal backportable change which is more important | 12:45 |
gibi | I'm not sure that the fix of https://bugs.launchpad.net/oslo.messaging/+bug/1529084 can be backported to pike | 12:46 |
openstack | Launchpad bug 1529084 in oslo.messaging "RPC fake driver should accept datetime items for data" [Undecided,Fix released] - Assigned to Balazs Gibizer (balazs-gibizer) | 12:46 |
gibi | and the the we can bump oslo.messaging version on the stable branches | 12:46 |
gibi | then remove the loads(dumps(..)) part from nova, and backport it to pike | 12:47 |
sean-k-mooney | you mean to rocky | 12:47 |
gibi | sean-k-mooney: rocky is the first stable that is affected | 12:47 |
gibi | I have to backport the whole thing to pike | 12:47 |
sean-k-mooney | ah you have other cherry picks | 12:47 |
gibi | as we have a failure downstream | 12:47 |
gibi | in pike | 12:47 |
sean-k-mooney | gotch ya | 12:47 |
gibi | so my target is to fix pike, and sure I will fix every broken stable along the way but I wan't to do this with minimal change | 12:48 |
gibi | a new oslo.messaging version would be a lot harder business | 12:48 |
sean-k-mooney | not a core but i +1'd it anyway since it makes sense after our disucsstion stephenfin its pretty quick if you can take a look | 12:48 |
gibi | sean-k-mooney: thanks! | 12:48 |
sean-k-mooney | hehe i some how dont think the intel pmem ci is going to work on rocky | 12:53 |
sean-k-mooney | they might want to fix that at some point | 12:53 |
*** brinzhang has joined #openstack-nova | 12:54 | |
brinzhang | gmann: is that true of bug 1864776? | 12:55 |
openstack | bug 1864776 in OpenStack Compute (nova) "os-volumes-attachments API policy is allowed for everyone even policy defaults is admin_or_owner" [Undecided,In progress] https://launchpad.net/bugs/1864776 - Assigned to Brin Zhang (zhangbailin) | 12:55 |
brinzhang | gmann: I was pushed the fixed patch https://review.opendev.org/#/c/709955/, and rebase this patch I was tested https://review.opendev.org/#/c/709929/1/nova/tests/unit/policies/test_volumes.py, it also need everyone contexts to authorize the admin_or_owner role | 13:01 |
*** jangutter has quit IRC | 13:01 | |
*** jangutter_ has joined #openstack-nova | 13:01 | |
brinzhang | gmann: I am not sure this bug is true, while you are free, pls review, thanks | 13:02 |
*** psachin has joined #openstack-nova | 13:05 | |
*** ociuhandu has joined #openstack-nova | 13:06 | |
*** amoralej is now known as amoralej|lunch | 13:14 | |
*** nweinber has joined #openstack-nova | 13:27 | |
*** brinzhang has quit IRC | 13:27 | |
*** brinzhang has joined #openstack-nova | 13:29 | |
*** brinzhang has quit IRC | 13:30 | |
*** brinzhang__ has joined #openstack-nova | 13:30 | |
*** brinzhang has joined #openstack-nova | 13:31 | |
*** brinzhang_ has quit IRC | 13:32 | |
*** brinzhang has quit IRC | 13:32 | |
*** brinzhang has joined #openstack-nova | 13:33 | |
*** brinzhang has quit IRC | 13:34 | |
*** brinzhang has joined #openstack-nova | 13:35 | |
*** ltomasbo has joined #openstack-nova | 13:36 | |
*** ltomasbo has left #openstack-nova | 13:36 | |
*** brinzhang has quit IRC | 13:36 | |
*** brinzhang has joined #openstack-nova | 13:37 | |
*** nicolasbock has quit IRC | 13:40 | |
*** nicolasbock has joined #openstack-nova | 13:40 | |
*** tbachman has quit IRC | 13:42 | |
*** brinzhang has quit IRC | 13:46 | |
*** nweinber has quit IRC | 13:46 | |
*** nweinber has joined #openstack-nova | 13:47 | |
openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Don't print user_data for 'nova show' https://review.opendev.org/708850 | 13:48 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643 | 13:50 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion 2.82, extra spec validation https://review.opendev.org/708436 | 13:50 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037 | 13:50 |
*** brinzhang has joined #openstack-nova | 13:52 | |
*** ileixe has quit IRC | 13:52 | |
*** ileixe has joined #openstack-nova | 13:53 | |
*** Liang__ has joined #openstack-nova | 13:53 | |
*** Liang__ is now known as LiangFang | 13:54 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP: Hey let's support routed networks y'all! https://review.opendev.org/656885 | 13:54 |
brinzhang__ | stephenfin: do you have time the check this bug? That prevent my next work https://bugs.launchpad.net/nova/+bug/1864776 | 13:55 |
openstack | Launchpad bug 1864776 in OpenStack Compute (nova) "os-volumes-attachments API policy is allowed for everyone even policy defaults is admin_or_owner" [Undecided,In progress] - Assigned to Brin Zhang (zhangbailin) | 13:55 |
brinzhang__ | that's the default policy refresh patch | 13:56 |
brinzhang__ | stephenfin: if it's true, I will rebase others on the fixed patch, otherwise I will abandon this fix, and push new patc to go continue | 13:57 |
*** ileixe has quit IRC | 13:58 | |
*** amoralej|lunch is now known as amoralej | 13:59 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Reintroduce volume based LM tests https://review.opendev.org/536105 | 14:00 |
*** mkrai has joined #openstack-nova | 14:00 | |
*** canori01 has joined #openstack-nova | 14:04 | |
*** slaweq has quit IRC | 14:05 | |
canori01 | hey guys, is it possible to update the root disk for an in-use flavor in the database (such that new instances using that flavor take the change)or would that break things? | 14:05 |
*** zhanglong has quit IRC | 14:06 | |
*** zhanglong has joined #openstack-nova | 14:07 | |
*** dasp has quit IRC | 14:08 | |
*** mkrai has quit IRC | 14:08 | |
*** jmlowe has quit IRC | 14:09 | |
*** slaweq has joined #openstack-nova | 14:09 | |
*** jmlowe has joined #openstack-nova | 14:09 | |
brinzhang__ | canori01: Which things would you like to change of the root disk? | 14:09 |
brinzhang__ | canori01:It is not recommended to change the configuration of the root disk directly in db. | 14:11 |
brinzhang__ | May cause strange things due to incomplete modification. | 14:12 |
*** zhanglong has quit IRC | 14:14 | |
*** zhanglong has joined #openstack-nova | 14:16 | |
canori01 | brinzhang: Only thing I want to change is the root disk size from 0 to something like 20 or 50G | 14:21 |
*** jmlowe has quit IRC | 14:29 | |
*** jmlowe has joined #openstack-nova | 14:32 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382 | 14:33 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix incorrect vm and task state after build failure race https://review.opendev.org/689388 | 14:33 |
*** links has quit IRC | 14:36 | |
*** ociuhandu has quit IRC | 14:37 | |
*** zhanglong has quit IRC | 14:38 | |
*** sean-k-mooney has quit IRC | 14:38 | |
*** iurygregory has quit IRC | 14:49 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.82 allowing boot from volume rescue https://review.opendev.org/701430 | 14:50 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | 14:50 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | 14:50 |
*** mlycka has quit IRC | 14:55 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | 15:01 |
*** psachin has quit IRC | 15:05 | |
*** tbachman has joined #openstack-nova | 15:07 | |
*** ociuhandu has joined #openstack-nova | 15:11 | |
*** sean-k-mooney has joined #openstack-nova | 15:14 | |
*** ociuhandu has quit IRC | 15:16 | |
*** mugsie has quit IRC | 15:20 | |
*** mugsie has joined #openstack-nova | 15:22 | |
*** brinzhang has quit IRC | 15:22 | |
*** brinzhang has joined #openstack-nova | 15:23 | |
*** iurygregory has joined #openstack-nova | 15:34 | |
*** ociuhandu has joined #openstack-nova | 15:41 | |
*** psachin has joined #openstack-nova | 15:46 | |
*** mkrai has joined #openstack-nova | 15:47 | |
*** dasp has joined #openstack-nova | 15:52 | |
*** jawad_axd has quit IRC | 15:56 | |
*** psachin has quit IRC | 15:57 | |
*** iurygregory has quit IRC | 16:05 | |
efried | sean-k-mooney: Re token expiring on that cyborg job: is the conf set up with a service token? | 16:06 |
sean-k-mooney | i am not sure but the confs are in the job logs | 16:12 |
sean-k-mooney | it should not fail in either case | 16:12 |
sean-k-mooney | once it start happening you have to restart all the nova services to fix it | 16:12 |
*** eharney has quit IRC | 16:19 | |
*** maciejjozefczyk has quit IRC | 16:21 | |
sean-k-mooney | efried: so no https://48ef08cde8cc22034a1d-8011a2266d21f0c09baf1c83d6d5002e.ssl.cf5.rackcdn.com/709641/5/check/cyborg-multinode-tempest-full/e4d260f/controller/logs/etc/nova/nova_conf.txt | 16:22 |
sean-k-mooney | the service user section https://docs.openstack.org/nova/latest/configuration/config.html#service-user | 16:23 |
sean-k-mooney | is not configured but it should not need to be confitured for it to work | 16:24 |
*** udesale_ has quit IRC | 16:24 | |
sean-k-mooney | it might allow you to mask the issue | 16:24 |
efried | sean-k-mooney: so the failure is happening from a later operation, not from the middle of a long-running operation? | 16:27 |
*** brinzhang has quit IRC | 16:35 | |
*** brinzhang has joined #openstack-nova | 16:36 | |
*** psachin has joined #openstack-nova | 16:36 | |
*** brinzhang has quit IRC | 16:37 | |
*** brinzhang has joined #openstack-nova | 16:38 | |
*** brinzhang has quit IRC | 16:38 | |
gmann | brinzhang__: sure, sorry for late response. I will review your patches today | 16:46 |
*** xek__ has joined #openstack-nova | 16:48 | |
*** tesseract has quit IRC | 16:50 | |
efried | sean-k-mooney: can I get your nod on https://review.opendev.org/#/c/709902/ (rocky EM patch) for os-vif please? | 16:50 |
*** xek_ has quit IRC | 16:51 | |
*** maysams has quit IRC | 16:52 | |
*** gyee has joined #openstack-nova | 16:52 | |
*** eharney has joined #openstack-nova | 16:55 | |
*** jaosorior has quit IRC | 16:57 | |
*** mkrai has quit IRC | 17:02 | |
*** ociuhandu has quit IRC | 17:03 | |
efried | lyarwood: https://review.opendev.org/#/c/709902/1/deliverables/rocky/nova.yaml lgty? | 17:06 |
lyarwood | efried: ack yes, elod ^? | 17:12 |
*** psachin has quit IRC | 17:12 | |
*** damien_r has quit IRC | 17:13 | |
*** TristanSullivan has joined #openstack-nova | 17:14 | |
*** ociuhandu has joined #openstack-nova | 17:30 | |
sean-k-mooney | efried: it can start failing with a 401 in the middel of an operation and once it has it will continue to fail for seperate operations | 17:33 |
sean-k-mooney | and yes ill look at the em patch now | 17:33 |
*** evrardjp has quit IRC | 17:34 | |
*** evrardjp has joined #openstack-nova | 17:35 | |
sean-k-mooney | there is one pending bugfix i want to back port to all affected branch in os-vif but rocky predates the issue so yes that commit looks correct | 17:35 |
sean-k-mooney | ill +1 the review | 17:35 |
sean-k-mooney | efried: basicaly the way i first hit the cybrog issue was i booted a vm. did a bunch of life cycle operation on it and then tried to delete it and that failed befaue the token was rejected. | 17:38 |
sean-k-mooney | when i tried to do the operation (deleting the arq) myself it worked | 17:38 |
sean-k-mooney | if i listed device profiles myslef it also worked but when i tried to boot anotuher vm after that point it failed beacuse the nova api was not able to retive the device profile info | 17:39 |
sean-k-mooney | so if i use osc to query cyborg directly everthing is fine. if i use osc to boot a vm and nova tires to query cyborg on my behalf it was failing but only after the services had been running for a while like an hour or so | 17:40 |
*** vishalmanchanda has quit IRC | 17:47 | |
*** jangutter_ has quit IRC | 17:47 | |
*** jangutter has joined #openstack-nova | 17:48 | |
*** jangutter has quit IRC | 17:50 | |
*** tbachman has quit IRC | 17:51 | |
*** ociuhandu has quit IRC | 18:05 | |
*** ociuhandu has joined #openstack-nova | 18:05 | |
*** ociuhandu has quit IRC | 18:11 | |
*** lucidguy has joined #openstack-nova | 18:23 | |
lucidguy | Anyone recall me asking for assistance with >1tb ram instances? I FIGURED IT OUT!!! only took days. | 18:24 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/708745 | 18:25 |
lyarwood | lucidguy: what was it? | 18:27 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/708745 | 18:27 |
*** nweinber_ has joined #openstack-nova | 18:29 | |
*** nweinber has quit IRC | 18:31 | |
*** priteau has quit IRC | 18:32 | |
sean-k-mooney | updating other people code when you have never reviewed it and are just following gerrit comments is hard | 18:32 |
*** amoralej is now known as amoralej|off | 18:33 | |
sean-k-mooney | the changes arent hard but the mental load to make sure what you are doing is correct is way higher then when its your code | 18:33 |
*** igordc has joined #openstack-nova | 18:37 | |
melwitt | lucidguy: don't leave us hanging | 18:39 |
*** maciejjozefczyk has joined #openstack-nova | 18:42 | |
*** mriedem has joined #openstack-nova | 18:42 | |
*** igordc has quit IRC | 18:43 | |
sean-k-mooney | lucidguy: was it the alingment of jupiture | 18:44 |
sean-k-mooney | *jupiter | 18:44 |
*** ociuhandu has joined #openstack-nova | 18:46 | |
*** N3l1x has joined #openstack-nova | 18:48 | |
*** ociuhandu has quit IRC | 18:51 | |
*** maciejjozefczyk has quit IRC | 18:57 | |
*** dpawlik has quit IRC | 19:01 | |
openstackgerrit | Merged openstack/python-novaclient master: Don't print user_data for 'nova show' https://review.opendev.org/708850 | 19:15 |
*** dpawlik has joined #openstack-nova | 19:18 | |
*** TristanSullivan has quit IRC | 19:31 | |
*** ociuhandu has joined #openstack-nova | 19:34 | |
*** nweinber__ has joined #openstack-nova | 19:35 | |
*** nweinber_ has quit IRC | 19:38 | |
*** eharney has quit IRC | 19:38 | |
*** ociuhandu has quit IRC | 19:40 | |
*** TristanSullivan has joined #openstack-nova | 19:49 | |
lucidguy | sean-k-mooney? | 19:51 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | 19:51 |
*** eharney has joined #openstack-nova | 19:51 | |
lucidguy | sean-k-mooney: By default instances are launched with 40bit cpu memory address space, that does not allow for >1tb memory in an instances. qemu on Ubuntu 18.04 allow to choose a machine architecture that maps the instances address space with the local HV which is 46bits. In the end of the day all I had to do is upgrade to 18.04(Bionic) and add one line to nova.conf on the HV. | 19:53 |
*** tbachman has joined #openstack-nova | 20:05 | |
openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | 20:08 |
*** ociuhandu has joined #openstack-nova | 20:08 | |
*** ociuhandu has quit IRC | 20:12 | |
sean-k-mooney | lucidguy: ah yes that makes sense | 20:20 |
sean-k-mooney | intel cpus only recently went to 48bit adress space | 20:20 |
sean-k-mooney | so im nost surpiesed the same limiation of reduced adress space was present for vms | 20:21 |
sean-k-mooney | lucidguy: did you fix it by changing the machine type to q35? | 20:21 |
sean-k-mooney | lucidguy: or did you add something else to the nova.conf | 20:22 |
sean-k-mooney | for example the cpu_model? | 20:22 |
sean-k-mooney | also a stackdump is not an approriate way of telling the enduser that you need to change somthing like that | 20:23 |
sean-k-mooney | i hope they have adressed that in a future version of qemu/kvm | 20:23 |
sean-k-mooney | gibi: efried: i tried to keep my changes in https://review.opendev.org/#/c/673341/ as minimal as possible while adressing the comments. | 20:24 |
sean-k-mooney | i will try to get through the other patches in the series tommorow. there were some race condition in the test code that took me a while to figure out | 20:25 |
sean-k-mooney | they are fixed now | 20:25 |
*** ociuhandu has joined #openstack-nova | 20:28 | |
*** kozhukalov has quit IRC | 20:33 | |
*** kozhukalov has joined #openstack-nova | 20:36 | |
*** ileixe has joined #openstack-nova | 20:36 | |
*** sean-k-mooney has quit IRC | 20:41 | |
*** tbachman has quit IRC | 20:42 | |
*** mgariepy has quit IRC | 20:45 | |
*** tbachman has joined #openstack-nova | 20:56 | |
*** nweinber__ has quit IRC | 20:59 | |
*** eharney has quit IRC | 21:00 | |
*** larainema has quit IRC | 21:03 | |
*** rcernin has quit IRC | 21:21 | |
*** ralonsoh has quit IRC | 21:22 | |
*** bnemec has quit IRC | 21:23 | |
*** priteau has joined #openstack-nova | 21:28 | |
*** kozhukalov has quit IRC | 21:29 | |
*** slaweq has quit IRC | 21:32 | |
*** ociuhandu has quit IRC | 21:36 | |
*** ociuhandu has joined #openstack-nova | 21:37 | |
*** ociuhandu has quit IRC | 21:41 | |
*** ociuhandu has joined #openstack-nova | 21:50 | |
*** ociuhandu has quit IRC | 22:02 | |
*** ociuhandu has joined #openstack-nova | 22:02 | |
*** ociuhandu has quit IRC | 22:07 | |
*** tbachman has quit IRC | 22:11 | |
*** priteau has quit IRC | 22:11 | |
*** mriedem has quit IRC | 22:14 | |
*** mriedem has joined #openstack-nova | 22:15 | |
*** mriedem has left #openstack-nova | 22:19 | |
*** tbachman has joined #openstack-nova | 22:27 | |
*** eharney has joined #openstack-nova | 22:31 | |
*** tbachman has quit IRC | 22:34 | |
*** ociuhandu has joined #openstack-nova | 22:40 | |
*** nweinber__ has joined #openstack-nova | 22:45 | |
*** ociuhandu has quit IRC | 22:45 | |
*** nweinber__ has quit IRC | 22:47 | |
*** rcernin has joined #openstack-nova | 22:49 | |
*** tkajinam has joined #openstack-nova | 22:53 | |
*** rchurch has quit IRC | 22:59 | |
*** rchurch has joined #openstack-nova | 23:00 | |
*** N3l1x has quit IRC | 23:02 | |
*** brinzhang__ has quit IRC | 23:05 | |
efried | sean-k-mooney: Earlier, we were toying with cutting cyborg over to using sdk instead of ksa. We held off because there were a couple more quirks to be ironed out. It's possible sdk would automatically refresh the token for us -- mordred? | 23:11 |
efried | sean-k-mooney: It's been a minute, but I think on the code side you just have to s/get_ksa_adapter/get_sdk_adapter/ to make the switch. If so, perhaps we could stuff that change in between the series and your tester somehow and see if it fixes the problem. | 23:15 |
efried | If so, then unit/functional tests would just need small tweaks to make it go. | 23:16 |
*** bnemec has joined #openstack-nova | 23:18 | |
*** tbachman has joined #openstack-nova | 23:31 | |
mordred | efried: sdk in general should refresh tokens | 23:36 |
mordred | efried: however, it's possible there are specifics I should page in | 23:37 |
mordred | also - we just landed cyborg support in sdk | 23:37 |
*** xek__ has quit IRC | 23:37 | |
mordred | efried: I'm EOD today - but I'd be happy to interact with folks on it tomorrow to see if we need to do anything | 23:38 |
*** TristanSullivan has quit IRC | 23:44 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!