Thursday, 2020-03-05

« Wednesday, 2020-03-04 Index Friday, 2020-03-06 »
*** dklyle has joined #openstack-nova00:02
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies  https://review.opendev.org/70748500:03
*** ozzzo has quit IRC00:06
*** brinzhang_ has joined #openstack-nova00:07
*** brinzhang has quit IRC00:11
*** slaweq has joined #openstack-nova00:11
*** brinzhang has joined #openstack-nova00:12
*** abaindur has quit IRC00:13
*** abaindur has joined #openstack-nova00:13
*** brinzhang_ has quit IRC00:15
*** nweinber__ has joined #openstack-nova00:16
*** dklyle has quit IRC00:19
*** toabctl has quit IRC00:19
*** toabctl has joined #openstack-nova00:22
*** dklyle has joined #openstack-nova00:22
*** slaweq has quit IRC00:27
*** igordc has quit IRC00:33
*** mvkr has quit IRC00:41
openstackgerritBrin Zhang proposed openstack/nova master: Correct the actual target in os-instance-actions policy  https://review.opendev.org/71041100:53
*** igordc has joined #openstack-nova00:53
*** happyhemant has quit IRC00:55
openstackgerritBrin Zhang proposed openstack/nova master: Correct the actual target in os-instance-actions policy  https://review.opendev.org/71041100:56
*** nweinber__ has quit IRC01:04
*** mvkr has joined #openstack-nova01:06
*** gyee has quit IRC01:10
*** slaweq has joined #openstack-nova01:11
*** sapd1 has joined #openstack-nova01:16
*** slaweq has quit IRC01:16
*** lbragstad_ has joined #openstack-nova01:34
*** lbragstad has quit IRC01:36
*** brinzhang_ has joined #openstack-nova01:49
*** tkajinam has quit IRC01:49
*** tkajinam has joined #openstack-nova01:50
*** brinzhang_ has quit IRC01:50
*** brinzhang_ has joined #openstack-nova01:51
*** brinzhang has quit IRC01:52
*** igordc has quit IRC02:07
*** slaweq has joined #openstack-nova02:11
*** zhanglong has joined #openstack-nova02:12
openstackgerritMerged openstack/nova stable/train: Make RBD imagebackend flatten method idempotent  https://review.opendev.org/70765002:15
*** slaweq has quit IRC02:16
openstackgerritMerged openstack/nova master: Remove oslo_db.sqlalchemy.compat reference  https://review.opendev.org/71109302:28
openstackgerritMerged openstack/nova master: Introduce scope_types in os-agents policy  https://review.opendev.org/70164502:47
*** brinzhang has joined #openstack-nova02:50
*** psachin has joined #openstack-nova02:50
*** brinzhang_ has quit IRC02:53
*** spatel has joined #openstack-nova03:04
*** lbragstad_ has quit IRC03:09
*** slaweq has joined #openstack-nova03:11
*** nicolasbock has joined #openstack-nova03:12
*** slaweq has quit IRC03:16
*** mkrai has joined #openstack-nova03:36
*** yedongcan has joined #openstack-nova03:39
*** larainema has joined #openstack-nova03:44
*** abaindur has quit IRC03:51
*** links has joined #openstack-nova03:56
*** spatel has quit IRC04:05
*** spatel has joined #openstack-nova04:06
*** udesale has joined #openstack-nova04:09
*** slaweq has joined #openstack-nova04:11
*** slaweq has quit IRC04:16
*** zhanglong has quit IRC04:23
*** nicolasbock has quit IRC04:30
*** brinzhang has quit IRC04:36
*** brinzhang has joined #openstack-nova04:37
*** brinzhang has quit IRC04:37
openstackgerritMerged openstack/nova master: libvirt: Remove native LUKS compat code  https://review.opendev.org/66912104:44
*** bbowen_ has quit IRC05:00
*** bbowen_ has joined #openstack-nova05:00
*** slaweq has joined #openstack-nova05:11
*** sapd1 has quit IRC05:12
*** abaindur has joined #openstack-nova05:22
*** zhanglong has joined #openstack-nova05:30
*** udesale has quit IRC05:31
*** evrardjp has quit IRC05:35
*** evrardjp has joined #openstack-nova05:35
*** slaweq has quit IRC05:38
*** udesale has joined #openstack-nova05:39
*** factor has quit IRC05:47
*** factor has joined #openstack-nova05:48
*** yedongcan has quit IRC06:05
*** spatel has quit IRC06:07
*** efried has quit IRC06:07
*** efried1 has joined #openstack-nova06:07
*** sapd1 has joined #openstack-nova06:09
*** efried1 is now known as efried06:09
*** rnoriega_ has quit IRC06:41
*** rnoriega_ has joined #openstack-nova06:46
*** threestrands has quit IRC06:48
*** abaindur has quit IRC06:55
*** abaindur has joined #openstack-nova06:55
*** damien_r has joined #openstack-nova07:00
*** ccamacho has quit IRC07:02
*** damien_r has quit IRC07:20
*** efried has quit IRC07:22
openstackgerritEric Xie proposed openstack/nova master: Catch exception when use invalid architecture of image  https://review.opendev.org/71136307:22
*** efried has joined #openstack-nova07:22
*** efried has quit IRC07:23
*** efried has joined #openstack-nova07:23
*** mkrai has quit IRC07:27
*** liuyulong has quit IRC07:31
*** rnoriega_ has quit IRC07:39
*** haleyb|away has quit IRC07:39
*** kashyap has quit IRC07:39
*** kukacz_ has joined #openstack-nova07:42
*** tetsuro has joined #openstack-nova07:44
*** bbowen_ has quit IRC07:48
*** bbowen_ has joined #openstack-nova07:49
*** happyhemant has joined #openstack-nova07:50
*** tesseract has joined #openstack-nova07:52
*** damien_r has joined #openstack-nova07:54
*** rnoriega_ has joined #openstack-nova07:55
*** iurygregory has joined #openstack-nova07:56
*** maciejjozefczyk has joined #openstack-nova07:59
*** brinzhang has joined #openstack-nova08:03
*** ccamacho has joined #openstack-nova08:11
*** tkajinam has quit IRC08:16
*** abaindur has quit IRC08:21
*** mkrai has joined #openstack-nova08:21
*** ralonsoh has joined #openstack-nova08:22
*** abaindur has joined #openstack-nova08:22
*** abaindur has joined #openstack-nova08:23
*** rnoriega_ has quit IRC08:25
*** rnoriega_ has joined #openstack-nova08:28
*** zhanglong has quit IRC08:31
*** zhanglong has joined #openstack-nova08:40
*** zhanglong has quit IRC08:44
*** amoralej|off is now known as amoralej08:45
*** rpittau|afk is now known as rpittau08:46
*** andreykurilin has quit IRC08:56
*** andreykurilin has joined #openstack-nova08:56
*** _erlon_ has quit IRC09:07
*** tinwood has quit IRC09:08
*** portdirect has quit IRC09:08
*** StevenK has quit IRC09:08
*** mkrai has quit IRC09:08
*** tosky has joined #openstack-nova09:25
*** tetsuro has quit IRC09:29
*** mkrai has joined #openstack-nova09:38
*** _erlon_ has joined #openstack-nova09:43
*** tinwood has joined #openstack-nova09:43
*** portdirect has joined #openstack-nova09:43
*** StevenK has joined #openstack-nova09:43
*** openstackstatus has quit IRC09:45
*** martinkennelly has joined #openstack-nova09:51
*** rishabhhpe97 has joined #openstack-nova09:55
*** raghavendrat has joined #openstack-nova09:59
*** jangutter has joined #openstack-nova09:59
*** abaindur has quit IRC09:59
raghavendratHi,09:59
raghavendratIn nova, unable to attach interface to instance.10:00
raghavendratOutput is available here: http://paste.openstack.org/show/790328/10:00
raghavendratAppreciate if anyone can provide any pointers.10:00
*** ociuhandu has joined #openstack-nova10:03
*** raghavendrat has quit IRC10:04
*** ociuhandu has quit IRC10:13
*** derekh has joined #openstack-nova10:13
*** psachin has quit IRC10:23
*** dtantsur|afk is now known as dtantsur10:24
*** mkrai has quit IRC10:26
*** spatel has joined #openstack-nova10:28
*** bbowen_ has quit IRC10:31
*** bbowen has joined #openstack-nova10:32
*** spatel has quit IRC10:33
*** ociuhandu has joined #openstack-nova10:33
*** ociuhandu has quit IRC10:38
openstackgerritBrin Zhang proposed openstack/nova master: Add test coverage of existing os-instance-actions policies  https://review.opendev.org/70777710:38
*** mkrai has joined #openstack-nova10:38
*** jangutter has quit IRC10:39
*** jangutter_ has joined #openstack-nova10:39
*** rishabhhpe97 has quit IRC10:41
*** jangutter_ has quit IRC10:42
*** jangutter has joined #openstack-nova10:43
*** udesale has quit IRC10:49
*** mkrai has quit IRC10:56
openstackgerritBrin Zhang proposed openstack/nova master: Introduce scope_types in os-instance-action policy  https://review.opendev.org/70775111:08
*** maciejjozefczyk is now known as mjozefcz|lunch11:15
*** bbowen has quit IRC11:16
*** bbowen has joined #openstack-nova11:16
*** slaweq has joined #openstack-nova11:18
*** ociuhandu has joined #openstack-nova11:20
openstackgerritStephen Finucane proposed openstack/nova stable/train: Functional test for UnexpectedDeletingTaskStateError  https://review.opendev.org/71121011:22
openstackgerritStephen Finucane proposed openstack/nova stable/train: Unplug VIFs as part of cleanup of networks  https://review.opendev.org/71125111:22
stephenfinlyarwood: have squashed in your fix for the race there now ^11:22
*** rpittau is now known as rpittau|bbl11:27
openstackgerritStephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation  https://review.opendev.org/70464311:37
openstackgerritStephen Finucane proposed openstack/nova master: api: Add microversion 2.83, extra spec validation  https://review.opendev.org/70843611:37
openstackgerritStephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs  https://review.opendev.org/71003711:37
*** tesseract-RH has joined #openstack-nova11:40
*** tbachman has quit IRC11:42
*** tesseract has quit IRC11:43
*** nicolasbock has joined #openstack-nova11:47
*** ociuhandu has quit IRC11:47
*** ociuhandu has joined #openstack-nova11:48
lyarwoodstephenfin: ack thanks, I'll review shortly11:54
brinzhangstephenfin: I was update the os-volume_attachments api of policy-defaults-refresh, if you have time, hope you can review11:58
brinzhangstephenfin: the fist patch is https://review.opendev.org/#/c/709955/2, has +2 by John Garbutt11:59
brinzhangstephenfin: the bp/destroy-instance-with-datavolume implement depends on these patches, thanks12:00
openstackgerritBrin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies  https://review.opendev.org/70647012:03
*** tetsuro has joined #openstack-nova12:03
*** tetsuro has quit IRC12:06
*** amoralej is now known as amoralej|lunch12:06
*** mjozefcz|lunch is now known as maciejjozefczyk12:10
lyarwoodstephenfin: https://review.opendev.org/#/q/status:open+topic:bug/1861071 - would you mind taking another run at this today?12:14
*** dpawlik has quit IRC12:14
openstackgerritBrin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API  https://review.opendev.org/70617912:15
lyarwoodhttps://review.opendev.org/#/q/topic:bug/1861071_followups is also ready for review again if you have time12:15
*** dpawlik has joined #openstack-nova12:15
*** brinzhang has quit IRC12:16
*** slaweq has quit IRC12:18
*** dpawlik has quit IRC12:22
*** dpawlik has joined #openstack-nova12:36
*** nweinber__ has joined #openstack-nova12:39
*** shilpasd has joined #openstack-nova12:50
*** ociuhandu has quit IRC13:01
*** dave-mccowan has joined #openstack-nova13:11
*** udesale has joined #openstack-nova13:14
*** sapd1 has quit IRC13:17
*** takamatsu has joined #openstack-nova13:22
*** ociuhandu has joined #openstack-nova13:28
*** ociuhandu has quit IRC13:31
*** shilpasd has quit IRC13:31
*** brinzhang has joined #openstack-nova13:31
*** ociuhandu has joined #openstack-nova13:31
*** shilpasd has joined #openstack-nova13:34
efriedNova meeting in ~25 mins in #openstack-meeting13:35
shilpasdefried: thanks, i will be IN13:36
*** tbachman has joined #openstack-nova13:36
openstackgerritEric Fried proposed openstack/nova master: Stop using PlacementDirect  https://review.opendev.org/64088713:36
efriedstephenfin: Cleaning house, that ^ is an oldymoldy that I just rebased manually. mriedem was +2 before. Would you consider fast approving?13:37
efriedHighly recommend switching on "ignore whitespace = All" to review effectively.13:37
*** cgoncalves has quit IRC13:41
*** sapd1 has joined #openstack-nova13:44
*** cgoncalves has joined #openstack-nova13:45
*** rpittau|bbl is now known as rpittau13:45
*** mgariepy has quit IRC13:46
*** kashyap has joined #openstack-nova13:47
stephenfinefried: Thanks for the tip with whitespace all. Yeah, it's test only so let's do it13:52
efriedthanks13:52
*** mgariepy has joined #openstack-nova13:52
efriednova meeting now14:01
*** alistarle has joined #openstack-nova14:04
openstackgerritMatt Riedemann proposed openstack/nova stable/rocky: Add retry_on_deadlock to migration_update DB API  https://review.opendev.org/71146114:05
*** lbragstad has joined #openstack-nova14:13
*** spatel has joined #openstack-nova14:21
*** tbachman has quit IRC14:26
*** spatel has quit IRC14:26
*** alistarle has quit IRC14:30
*** amoralej|lunch is now known as amoralej14:31
*** ociuhandu has quit IRC14:33
*** ociuhandu has joined #openstack-nova14:33
*** haleyb has joined #openstack-nova14:36
*** ociuhandu has quit IRC14:38
*** cgoncalves has quit IRC14:39
*** cgoncalves has joined #openstack-nova14:40
*** haleyb is now known as haleyb|away14:50
*** spatel has joined #openstack-nova14:54
*** rishabhhpe has joined #openstack-nova14:56
brinzhangroot@ubuntu-OpenStack:~# nova flavor-show 114:59
brinzhang+----------------------------+----------------------------+14:59
brinzhang| Property                   | Value                      |14:59
brinzhang+----------------------------+----------------------------+14:59
brinzhang| OS-FLV-DISABLED:disabled   | False                      |14:59
brinzhang| OS-FLV-EXT-DATA:ephemeral  | 0                          |14:59
brinzhangthis is part of from flavor-show14:59
*** tframbo has joined #openstack-nova14:59
dansmithyeah, it's a column field, not an extra spec15:00
efriedbrinzhang: right, so how do you set it to True?15:00
dansmithfrom looking at all the APIs, there's no way for it to become true15:00
efriedah, neat.15:00
brinzhangNo, it cannot to be changed now15:00
dansmith    disabled = Column(Boolean, default=False)15:00
dansmithtframbo: what version of nova?15:01
tframboRocky15:01
dansmithinstalled from where?15:01
brinzhangin 2013 year, https://review.opendev.org/#/c/61291/ this patch want to change this set, but fast abandon15:02
tframbogithub.com15:02
dansmithbrinzhang: yeah, a good example of why we try to closely examine our features and merge them when ready :)15:02
tframboI have seen the master branch ,it also can't change15:02
dansmithtframbo: what backend database?15:02
tframbomaraidb15:03
dansmithtframbo: really not sure how this could be happening then15:03
dansmithtframbo: can you post the output of "use nova_api; SELECT * FROM flavors;" ?15:04
efrieddansmith: Perhaps I'm misunderstanding, but I think tframbo is saying they want to be able to change the value to 'true'15:04
efriedi.e. they want to be able to disable the flavor15:04
dansmithefried: oh I thought he was saying it's always true when they create flavors15:04
dansmith(based on context from yesterday)15:04
openstackgerritStephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation  https://review.opendev.org/70464315:04
openstackgerritStephen Finucane proposed openstack/nova master: api: Add microversion 2.83, extra spec validation  https://review.opendev.org/70843615:04
openstackgerritStephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs  https://review.opendev.org/71003715:04
tframboyeah ,I just want to set it to true15:04
brinzhangdansmith: I think tframbo want to re-set this property15:05
dansmithtframbo: ah, sorry I misunderstood.. as brinzhang said, it is half a feature that was never finished15:05
dansmithyep, sorry, my bad15:05
efriediow we have this property that's part of the API and the output but doesn't do anything and can't be changed.15:05
brinzhangdansmith: yes, it's not completed, maybe we can consider whether to do this in the future15:05
efriedso, tframbo, what you're asking is essentially "let's finish this feature". To do that, you would need to produce a blueprint and a spec, as well as a compelling use case for being able to do it in the first place.15:06
efriedWe're past spec freeze for the current release, but you could get started working on proposing it for the Victoria release.15:06
dansmithand implement it, or find someone interested in doing so15:06
efriedHas anyone else asked for it since Havana to your knowledge dansmith?15:07
brinzhangNow in our create flavor, the request body does not contain this proerty15:07
dansmithefried: not that I've ever heard of15:07
dansmithnot really sure what the point of it would be15:07
efriedseems like, since we now copy the flavor body into the instance, there's an easy workaround for this: delete the flavor15:07
*** ociuhandu has joined #openstack-nova15:07
dansmithit came from a time before we kept flavors with instances15:07
efriedjynx15:07
dansmithright, the only case I can imagine is wanting to keep flavors for records of what things were booted from, but it seems confusing to me for the user,15:08
dansmithunless disabled flavors are filtered most of the time15:08
dansmithbut it's so much easier to just see it in the instance detail15:08
brinzhangIf we want to do this feature, I think I can continue this, but we should consider, whether pay time to do ^^15:08
dansmithbrinzhang: we should only do it if there is a compelling reason to, not just because "it's half finished already"15:09
dansmithI'd rather see the field go away personally15:09
efriedyeah, if we do anything at all, that would be my vote15:09
brinzhangdansmith: yeah, agree15:09
efriedtframbo: let me clarify: We now copy flavor information into the instance record, so that any changes to the original flavor (including deleting it) don't get confused with how the instance was originally created.15:09
efriedtframbo: which means there's really no need to "disable" a flavor -- just delete it instead.15:10
efrieddansmith: since what release do we do the flavor-into-instance copy?15:10
efriedcertainly before rocky.15:10
dansmithtechnially, not sure, a long time.. not sure when we *expose* it15:10
dansmithbut it was sdague era, IIRC, so it's been a while15:10
dansmith2.4715:11
efriedmicroversion 2.47...15:11
efried...pike.15:11
dansmith201715:12
brinzhanghttps://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id4315:12
*** rishabhhpe has quit IRC15:12
tframboyeah ,I just want to know the "disable" value , if is meaningful.if is unuseful, we might should delete it.15:12
*** rishabhhpe has joined #openstack-nova15:12
*** luyao has joined #openstack-nova15:16
efriedtframbo: agree. Though that would require a microversion, so it may not be worth the effort. Perhaps the next time gmann does an "API cleanup" sweep...15:16
efriedtframbo: you could propose to filter it out of the CLI output I suppose. Though again, not sure that would be worth the effort.15:16
efriedOkay, I'm going to go take actual vacation for a couple days, and then I'm really gone. o/15:17
brinzhangyes, we should consider is it worth to do15:17
*** efried is now known as efried_gone15:18
brinzhangtoo later for me, good morning everyone ^^15:18
brinzhangbye15:18
tframbothank you ,all15:18
tframbobye15:18
brinzhanglater..15:20
brinzhangdansmith: Can you review these bug fix? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/166345615:20
*** jaosorior has quit IRC15:20
brinzhangdansmith: stephenfin want to get your check ^^15:21
dansmithbrinzhang: I'm not sure why stephenfin +2d that but also said it should be done in oslo.db15:21
dansmithI dunno if TimestampMixin does the time the same way, but if it didn't or it changed, it would be confusing that we're setting it to one thing and then potentially have that roll backwards, forwards, or be different from the create time15:23
dansmithwhy not fix this at the oslo.db layer and not merge this?15:23
brinzhangdansmith: I tend to use the current implementation, and I think it's good enough.15:23
dansmithI'm not sure what that means15:24
stephenfindansmith: I don't know what that means either but the oslo.db part wouldn't fix this entirely15:26
dansmithI see now it's add/delete host that they want it updated at15:26
dansmiththe thing I don't like here,15:26
stephenfinbrinzhang is saying that when we add a new host to an aggregate, we should update the updated_at updated15:26
stephenfinyeah15:26
dansmithis that I don't know that oslo.db is using time.utcnow() (I expect it is, but..)15:27
stephenfinthe updated_at of the aggregate itself15:27
*** links has quit IRC15:27
dansmithso us doing that here just worries me a little that if that changed or there was some other detail, we could have situations where updated is before created, etc15:27
dansmithwhich is just messy15:27
stephenfinIt's using 'timeutils.utcnow()'15:28
stephenfinI'm not sure how you'd approach this if you'd want it wholly contained in oslo.db though15:28
stephenfinWe want to say if a "child" is updated, set the 'updated_at' for the child and also the "parent" linked by the fk15:29
dansmithstephenfin: make TimestampMixin have a .touch() method15:30
dansmithbrinzhang: I -1'd for a couple of things.. I'm really not sure why this is important, but we should be consistent if we're going to do this, IMHO15:30
dansmithbrinzhang: it seems very weird to me to get an aggregate updated when I add a host, but not when I set some property on that aggregate, which from the user's perspective is a direct property of the aggregate itself15:31
stephenfin(or more specifically, when updating an instance of AggregateHost, also update the Aggregate referenced via the 'aggregate_id' field)15:31
*** sapd1 has quit IRC15:31
openstackgerritJohn Garbutt proposed openstack/nova master: Fix os-console-output policy to be admin_or_owner  https://review.opendev.org/70672515:32
dansmithstephenfin: yep, could do it that way too15:32
stephenfinHmm, I can't reason how that would work15:32
stephenfinthe touch() thing15:32
*** tframbo has quit IRC15:32
dansmithagg = query(); agg.touch(); agg.save() ?15:32
stephenfinoh, you mean manually call that whenever we update an AggregateHost instance?15:32
dansmithyeah15:32
dansmithmove what we're doing into the mixin so the time stuff is all in the same place15:32
stephenfingotcha15:32
*** mriedem has joined #openstack-nova15:33
stephenfinthat could work but you've to remember to do it manually for everything that has a "parent" relationship15:33
dansmithstephenfin: that's what this patch is doing right?15:34
stephenfintrue15:34
stephenfinI was going to ask what it gave us over what we're doing, but you already said that15:34
stephenfin(the time stuff is all in the same place)15:34
dansmithright15:35
dansmithjust because times, timezones, resolution etc is an often screwed up thing, and could even be db backend specific15:35
stephenfinI assume iterating through all foreign key columns on a model, seeing if they have an updated_at row, and updating it if so, would be too clever?15:35
stephenfins/row/column/15:36
dansmithstephenfin: not FKs but relationships on the db model you mean15:36
dansmithbut no, that'd be fine too, it's just more work and testing I think15:36
stephenfinah, yeah, relationships15:36
luyaohi ,everyone, I have a question about the do_cleanup flag in live migration15:37
luyaothe 'do_cleanup' seems just a flag to mark if the instance path need be cleaned, https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L818515:38
luyaobut it control more things , e.g. https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L8354, if do_cleanup is False, it will not invoke driver.cleanup which also do _unflug_vifs and _undefine_domain15:38
luyaois this BUG?15:38
*** brinzhang has quit IRC15:45
*** Sundar has joined #openstack-nova15:47
*** sapd1 has joined #openstack-nova15:48
*** spatel has quit IRC15:52
*** spatel has joined #openstack-nova15:54
*** ociuhandu has quit IRC15:55
*** ociuhandu has joined #openstack-nova15:57
*** spatel has quit IRC15:59
*** ociuhandu has quit IRC16:02
*** ociuhandu has joined #openstack-nova16:02
*** spatel has joined #openstack-nova16:05
*** mlavalle has joined #openstack-nova16:10
*** gyee has joined #openstack-nova16:18
*** KeithMnemonic1 has joined #openstack-nova16:19
*** jangutter has quit IRC16:21
*** KeithMnemonic has quit IRC16:23
*** eharney has quit IRC16:25
*** damien_r has quit IRC16:28
*** damien_r has joined #openstack-nova16:33
*** TxGirlGeek has joined #openstack-nova16:40
*** udesale has quit IRC16:44
*** rishabhhpe has quit IRC16:46
*** rishabhhpe has joined #openstack-nova16:48
*** ccamacho has quit IRC16:48
*** ociuhandu_ has joined #openstack-nova16:54
melwittluyao: as far as I know, that behavior is not a bug16:55
*** rcernin has quit IRC16:55
*** ociuhandu has quit IRC16:58
luyaomelwitt: thanks for your reply, so why we don’t need to undefine the domain or unplug the bugs if do_cleanup is false16:58
luyaos/bugs/vifs16:58
*** ociuhandu_ has quit IRC16:59
*** tesseract-RH has quit IRC17:01
melwittluyao: hmm ... maybe we should ask artom, I see his comments in that code block17:03
artommelwitt, after the call, I'd have to reload context :)17:03
luyaoartom: hah, thanks in advance :)17:07
artomSo it's set by https://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/compute/manager.py#L816017:07
melwittthe do_cleanup is about whether the instance is on shared storage, if it is on shared storage we don't need to destroy the domain or change the vifs right? because the instance doesn't really have to "move"17:08
artomI thought shared storage was just the disk17:12
artomEverything else lives on the compute host directly17:12
artomNo?17:12
melwittlyarwood halp17:12
melwittI guess I don't know anymore. I feel like I used to, but maybe that was a dream17:13
kashyapartom: Yes, shared storage means: just the disk, in general ...17:14
kashyap(Only memory and device state will be live-migrated in shared storage setup.)17:14
kashyapOn changing the VIFs, I'm not 100% sure, I also feel like melwitt :D17:15
artomluyao, maybe you could tell us what behaviour you're seeing that you think is a bug17:15
artommelwitt, my comment is only there because I added the instance.refresh() call17:16
artomEverything else predates me17:16
melwittkashyap: heh17:16
* artom disavows all responsibility ;)17:16
melwittnicely played17:16
kashyap`git shortlog --nse /path/to/file/name` is your weapon, luyao17:16
kashyap(And pick the top three or four members to harass)17:16
luyaoartom: I think do_cleanup is just a flag to tell if we need cleanup instance file during migration right?17:17
kashyap(Or even a fine-grained one: `git blame -C -M -L line-$x:line-$y /path/to/file/name/`)17:17
artomluyao, the way it's set, yeah17:18
artomluyao, but it could be used for other things, but still be correct17:18
artomThe code is kinda messy, but if it works, it works17:18
luyaobut in the code path, if do_cleanup is false, the whole driver.cleanup will not be invoked, but except for instance files cleanup ,we also have other things like undefine domain and unplug vifs17:18
artomluyao, which is why I'm asking if there's a specific behaviour/error you're asking about17:19
artomBecause debating the code itself is kinda pointless. There are years and years of multiple people doing multiple things, all for valid reasons17:19
artomTo end up with the mess with have now :)17:19
luyaoartom: no, I write my own patch ,and alex_xu comment at this, we are both not sure of this17:20
artomluyao, link the patch please :)17:20
luyaohttps://review.opendev.org/#/c/687856/10/nova/compute/manager.py@862317:20
artomTbh, I won't able to look now because I'm running on very little sleep, but I'll try to look later17:20
*** tbachman has joined #openstack-nova17:21
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-admin-password  https://review.opendev.org/70163017:21
*** igordc has joined #openstack-nova17:22
luyaoartom: OK, thanks. It's too late for me so I'm going to sleep too.  :D17:22
artomluyao, ack :)17:22
lyarwoodmelwitt: sorry was afk, reading17:24
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-admin-password policies  https://review.opendev.org/70163917:24
toskychecking a pending patch on stable/pike - it seems that nova-live-migration has still some issues there, and other patches are blocked too17:25
*** Sundar has quit IRC17:25
*** rpittau is now known as rpittau|afk17:25
toskyI think we already discussed about this, are there any updates?17:26
melwitttosky: we did, no updates yet sorry. sean-k-mooney had been trying to get time to do a bit of debugging but afaik they didn't get to it yet17:28
toskyoki, np17:29
lyarwoodluyao: we unplug VIFS regardless of that value in post_live_migration_at_source https://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/virt/libvirt/driver.py#L9260-L926717:29
toskyit's not the most important thing (in the long run, I just want to remove a legacy job from openstack-zuul-jobs :)17:29
lyarwoodluyao: iirc Libvirt itself handles the removal of the domain17:30
*** damien_r has quit IRC17:31
*** eharney has joined #openstack-nova17:31
lyarwoodluyao: https://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/virt/libvirt/driver.py#L909-L911 yeah it does17:31
*** ociuhandu has joined #openstack-nova17:32
melwitttosky: yeah, it's odd that it fails so much more on pike than on master. that's part of why digging in will be hard, find what's happening and what's different. I see occasional failures on master but obvious pike is failing nearly all the time last I saw17:32
melwitt*obviously17:32
*** martinkennelly has quit IRC17:34
*** evrardjp has quit IRC17:35
*** evrardjp has joined #openstack-nova17:35
*** ociuhandu has quit IRC17:36
melwittlyarwood++17:38
openstackgerritMerged openstack/nova master: Stop using PlacementDirect  https://review.opendev.org/64088717:40
*** dtantsur is now known as dtantsur|afk17:40
luyaolyarwood: before rollback live migration at destination ，it also check the do_cleanup flag，in this case，i think we need destroy the domain at target host manually right?17:44
lyarwoodluyao: just looking at the review now, I didn't get that we were talking about rollback sorry17:45
lyarwoodluyao: it depends on the failure tbh, we ask Libvirt to persist the domain but only on a successful migration17:46
lyarwoodhttps://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/virt/libvirt/driver.py#L913-L91517:47
lyarwoodhttps://github.com/openstack/nova/blob/19cbbbebddadb125b8123ce0350b7146b29a59c6/nova/virt/libvirt/guest.py#L609-L61117:47
luyaolyarwood: I understand it may not trigger error in real env, but do_cleanup flag setting and the code path it controls is a little confusing17:50
luyaosince do_cleanup is just tell if the instance path file is shared17:52
lyarwoodluyao: yeah very, I've added a comment, I think we could look into calling rollback_live_migration_at_destination regardless of that value in a seperate change17:52
lyarwoodluyao: I don't know if that's going to break assumptions in other drivers that support LM17:52
luyaolyarwood: thanks for your comments I’ll go into it further tomorrow :)17:58
*** derekh has quit IRC18:00
*** slaweq has joined #openstack-nova18:11
*** kaisers1 has quit IRC18:15
*** martinkennelly has joined #openstack-nova18:16
*** ccamacho has joined #openstack-nova18:20
openstackgerritJason Anderson proposed openstack/nova master: Use fair locks in resource tracker  https://review.opendev.org/71152818:22
*** kaisers has joined #openstack-nova18:31
*** shilpasd has quit IRC18:32
*** eharney has quit IRC18:34
*** amoralej is now known as amoralej|off18:35
*** rishabhhpe has quit IRC18:37
*** umbSublime has quit IRC18:39
*** kukacz_ has quit IRC18:41
*** slaweq has quit IRC18:47
*** ralonsoh has quit IRC18:57
*** larainema has quit IRC19:03
*** jaosorior has joined #openstack-nova19:08
*** nweinber__ has quit IRC19:16
*** eharney has joined #openstack-nova19:48
*** maciejjozefczyk has quit IRC19:53
openstackgerritVictor Coutellier proposed openstack/nova master: Non-Admin user can filter their instances by more filters  https://review.opendev.org/70160919:58
*** ociuhandu has joined #openstack-nova20:09
*** martinkennelly has quit IRC20:19
mlozaI'm trying to do a live migrate on a instance between computes and both have same model but different processor series. I'm getting this error20:22
mloza Live Migration failure: operation failed: guest CPU doesn't match specification: missing features: virt-ssbd: libvirtError: operation failed: guest CPU doesn't match specification: missing features: virt-ssbd20:22
*** ociuhandu has quit IRC20:25
*** ociuhandu has joined #openstack-nova20:28
*** vishalmanchanda has quit IRC20:31
*** abaindur has joined #openstack-nova20:32
*** bbowen has quit IRC20:34
*** bbowen has joined #openstack-nova20:34
mriedemmloza: https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-kvm.html#specify-the-cpu-model-of-kvm-guests might be helpful20:35
*** trident has quit IRC20:37
*** ociuhandu has quit IRC20:37
*** ociuhandu has joined #openstack-nova20:38
*** ociuhandu has quit IRC20:43
*** nweinber__ has joined #openstack-nova20:45
*** trident has joined #openstack-nova20:47
*** bbowen has quit IRC20:48
*** slaweq has joined #openstack-nova20:48
*** bbowen has joined #openstack-nova20:48
*** rcernin has joined #openstack-nova20:53
*** cgoncalves has quit IRC20:53
*** cgoncalves has joined #openstack-nova20:56
*** nicolasbock has quit IRC21:05
*** xek_ has quit IRC21:07
*** cgoncalves has quit IRC21:10
*** cgoncalves has joined #openstack-nova21:11
*** rcernin has quit IRC21:18
*** eharney has quit IRC21:18
*** dpawlik has quit IRC21:18
*** nweinber__ has quit IRC21:20
mlozamriedem: tahnsk21:25
mlozathanks*21:25
*** spatel has quit IRC21:29
openstackgerritMerged openstack/nova master: Fix os-console-output policy to be admin_or_owner  https://review.opendev.org/70672521:33
*** slaweq has quit IRC21:33
*** imacdonn has quit IRC22:04
*** imacdonn has joined #openstack-nova22:05
*** abaindur has quit IRC22:14
*** abaindur has joined #openstack-nova22:15
*** iurygregory has quit IRC22:18
*** TxGirlGeek has quit IRC22:35
*** tkajinam has joined #openstack-nova22:45
*** ociuhandu has joined #openstack-nova23:07
*** ociuhandu has quit IRC23:11
*** tbachman has quit IRC23:25
mlozaI specified cpu_mode = custom and cpu_models = EPYC-IBRS but I can't turn on the instance23:28
mlozaI get this error ': Invalid: Config requested a custom CPU model, but no model name was provided'23:28
mlozaI have x86_EPYC-IBRS.xml in /usr/share/libvirt/cpu_map/23:29
*** spatel has joined #openstack-nova23:30
*** vishalmanchanda has joined #openstack-nova23:34
*** spatel has quit IRC23:35
*** brinzhang has joined #openstack-nova23:42
openstackgerritGhanshyam Mann proposed openstack/nova master: Add a tests to check when legacy access is removed  https://review.opendev.org/71081323:49
*** bbowen has quit IRC23:51
*** bbowen has joined #openstack-nova23:52
*** brinzhang_ has joined #openstack-nova23:57
« Wednesday, 2020-03-04 Index Friday, 2020-03-06 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!