*** brinzhang has quit IRC | 00:01 | |
*** mriedem has left #openstack-nova | 00:11 | |
*** tbachman has joined #openstack-nova | 00:29 | |
*** tbachman has quit IRC | 00:39 | |
*** bbowen has quit IRC | 00:43 | |
*** bbowen has joined #openstack-nova | 00:43 | |
*** larainema has joined #openstack-nova | 00:47 | |
*** bbowen has quit IRC | 00:47 | |
*** brinzhang has joined #openstack-nova | 00:51 | |
*** brinzhang_ has quit IRC | 00:54 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476 | 00:55 |
---|---|---|
openstackgerrit | Brin Zhang proposed openstack/nova master: Correct the actual target in os-instance-actions policy https://review.opendev.org/710411 | 00:59 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-instance-actions policies https://review.opendev.org/707777 | 00:59 |
*** tetsuro has joined #openstack-nova | 01:02 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-admin-password https://review.opendev.org/701630 | 01:05 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-admin-password policies https://review.opendev.org/701639 | 01:06 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add a tests to check when legacy access is removed https://review.opendev.org/710813 | 01:06 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476 | 01:06 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485 | 01:06 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476 | 01:09 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485 | 01:09 |
*** igordc has quit IRC | 01:18 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485 | 01:23 |
*** mlavalle has quit IRC | 01:24 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing console_output policies https://review.opendev.org/706724 | 01:26 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040 | 01:27 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing console_output policies https://review.opendev.org/706724 | 01:28 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040 | 01:28 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040 | 01:29 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041 | 01:29 |
*** brinzhang has quit IRC | 01:35 | |
*** brinzhang has joined #openstack-nova | 01:35 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041 | 01:36 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726 | 01:38 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727 | 01:38 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727 | 01:39 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726 | 01:39 |
*** tosky has quit IRC | 01:39 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038 | 01:39 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038 | 01:40 |
*** spatel has joined #openstack-nova | 01:40 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039 | 01:41 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039 | 01:45 |
*** KeithMnemonic1 has quit IRC | 01:52 | |
*** KeithMnemonic1 has joined #openstack-nova | 01:53 | |
*** adriant has quit IRC | 01:53 | |
*** adrianc has quit IRC | 01:54 | |
*** lbragstad_ has joined #openstack-nova | 01:54 | |
*** adriant has joined #openstack-nova | 01:54 | |
*** adrianc has joined #openstack-nova | 01:54 | |
*** lbragstad has quit IRC | 01:57 | |
*** owalsh has quit IRC | 01:58 | |
*** gyee has quit IRC | 02:00 | |
*** tbachman has joined #openstack-nova | 02:02 | |
*** owalsh has joined #openstack-nova | 02:07 | |
*** zhanglong has joined #openstack-nova | 02:11 | |
*** igordc has joined #openstack-nova | 02:25 | |
*** abaindur has quit IRC | 02:27 | |
*** happyhemant has quit IRC | 02:34 | |
*** brinzhang has quit IRC | 02:40 | |
*** brinzhang has joined #openstack-nova | 02:41 | |
*** tetsuro_ has joined #openstack-nova | 02:44 | |
*** tetsuro has quit IRC | 02:48 | |
brinzhang | damsmith: as mriedem said in https://review.opendev.org/#/c/694428/4, I think this issue was triggered when I modified the os-instance-actions APIs default policy [1]. I am not particularly familiar with @serialize_args. Can you suggest or submit some fixes? | 02:48 |
brinzhang | dansmith: [1]https://review.opendev.org/#/c/706470/7, it's functional error report https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5a7/706179/6/check/openstack-tox-py36/5a7826b/testr_results.html | 02:50 |
brinzhang | damsmith: when microversion > 2.51, we can show the instance action events for a server, but now the non-admin can get the ['host', 'traceback'], that should belong to admin role, this validates mriedem's comment. | 02:53 |
*** tetsuro has joined #openstack-nova | 02:54 | |
*** tetsuro_ has quit IRC | 02:56 | |
openstackgerrit | norman shen proposed openstack/nova stable/rocky: Relex python3 version for pep8 https://review.opendev.org/711577 | 02:58 |
brinzhang | dansmith: I was said maybe be not correct, I am not sure they are the same issue, please check. | 03:10 |
openstackgerrit | Eric Xie proposed openstack/nova master: Catch exception when use invalid architecture of image https://review.opendev.org/711363 | 03:18 |
brinzhang | dansmith: bug 1866292 mainly trace for non-admin can get the 'traceback' | 03:22 |
openstack | bug 1866292 in OpenStack Compute (nova) "non-admin shouldn't get the ['host', 'traceback'] of os-instance-actions's events" [Undecided,New] https://launchpad.net/bugs/1866292 | 03:22 |
openstackgerrit | Merged openstack/nova stable/train: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711276 | 03:30 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API https://review.opendev.org/706179 | 03:49 |
*** brinzhang_ has joined #openstack-nova | 03:59 | |
*** brinzhang has quit IRC | 04:02 | |
*** links has joined #openstack-nova | 04:27 | |
*** sapd1 has quit IRC | 04:34 | |
*** sapd1 has joined #openstack-nova | 04:46 | |
*** mkrai has joined #openstack-nova | 04:52 | |
*** spatel has quit IRC | 04:53 | |
*** udesale has joined #openstack-nova | 04:55 | |
*** mkrai has quit IRC | 05:12 | |
*** dave-mccowan has quit IRC | 05:17 | |
*** zhanglong has quit IRC | 05:22 | |
*** zhanglong has joined #openstack-nova | 05:24 | |
*** abaindur has joined #openstack-nova | 05:27 | |
*** abaindur has joined #openstack-nova | 05:27 | |
*** abaindur has quit IRC | 05:28 | |
*** abaindur has joined #openstack-nova | 05:29 | |
*** psachin has joined #openstack-nova | 05:29 | |
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #openstack-nova | 05:35 | |
*** lbragstad_ has quit IRC | 05:50 | |
*** sapd1 has quit IRC | 06:01 | |
*** mkrai has joined #openstack-nova | 06:11 | |
*** sapd1 has joined #openstack-nova | 06:18 | |
*** udesale_ has joined #openstack-nova | 06:21 | |
*** udesale has quit IRC | 06:23 | |
*** udesale has joined #openstack-nova | 06:28 | |
*** sorrison has quit IRC | 06:29 | |
*** udesale_ has quit IRC | 06:29 | |
*** sorrison has joined #openstack-nova | 06:31 | |
*** links has quit IRC | 06:32 | |
*** udesale_ has joined #openstack-nova | 06:33 | |
*** udesale has quit IRC | 06:35 | |
*** ratailor has joined #openstack-nova | 06:37 | |
*** igordc has quit IRC | 06:41 | |
*** links has joined #openstack-nova | 06:54 | |
*** lpetrut has joined #openstack-nova | 07:10 | |
*** lpetrut has quit IRC | 07:11 | |
*** lpetrut has joined #openstack-nova | 07:11 | |
*** iurygregory has joined #openstack-nova | 07:18 | |
*** slaweq has joined #openstack-nova | 07:23 | |
*** maciejjozefczyk has joined #openstack-nova | 07:50 | |
*** damien_r has joined #openstack-nova | 07:54 | |
*** tesseract has joined #openstack-nova | 07:56 | |
*** ccamacho has quit IRC | 08:09 | |
*** ccamacho has joined #openstack-nova | 08:09 | |
*** ccamacho has quit IRC | 08:10 | |
*** ccamacho has joined #openstack-nova | 08:10 | |
*** ociuhandu has joined #openstack-nova | 08:17 | |
*** ociuhandu has quit IRC | 08:27 | |
*** ociuhandu has joined #openstack-nova | 08:29 | |
*** tkajinam has quit IRC | 08:29 | |
*** ociuhandu has quit IRC | 08:34 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Reproduce bug 1862633 https://review.opendev.org/709166 | 08:37 |
openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | 08:37 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/709167 | 08:37 |
gibi | elod, lyarwood: ^^ updated the commit message on the bottom backport patch as requested | 08:38 |
*** amoralej|off is now known as amoralej | 08:39 | |
*** tosky has joined #openstack-nova | 08:40 | |
*** dtantsur|afk is now known as dtantsur | 08:55 | |
lyarwood | gibi: ack done, thanks | 08:57 |
lyarwood | elod: https://review.opendev.org/#/c/709167/ LGTM to me also now. | 08:57 |
*** rpittau|afk is now known as rpittau | 08:58 | |
*** tetsuro has quit IRC | 09:00 | |
*** tetsuro_ has joined #openstack-nova | 09:01 | |
elod | lyarwood: thanks, +W'd :] | 09:01 |
*** tetsuro_ has quit IRC | 09:03 | |
*** _kukacz has joined #openstack-nova | 09:05 | |
*** happyhemant has joined #openstack-nova | 09:06 | |
*** _kukacz has quit IRC | 09:09 | |
*** _kukacz has joined #openstack-nova | 09:09 | |
gibi | lyarwood, elod: thanks a bunch | 09:19 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Fix os-volumes-attachments policy to be admin_or_owner https://review.opendev.org/709955 | 09:19 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-volumes-attachments policies https://review.opendev.org/709929 | 09:19 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-volumes-attachments policy https://review.opendev.org/709388 | 09:19 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-volumes-attachments policies https://review.opendev.org/710190 | 09:19 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828 | 09:19 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194 | 09:19 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | 09:19 |
*** martinkennelly has joined #openstack-nova | 09:32 | |
openstackgerrit | Merged openstack/nova stable/train: Reproduce bug 1862633 https://review.opendev.org/709166 | 09:33 |
openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | 09:33 |
*** trident has quit IRC | 09:34 | |
brinzhang_ | gibi: Do you have time to check this functional failed? https://review.opendev.org/#/c/706470/ | 09:35 |
brinzhang_ | gibi: I am not sure whether is it a bug, I create a bug in launchpad, for bug 1866292 | 09:36 |
openstack | bug 1866292 in OpenStack Compute (nova) "non-admin shouldn't get the ['host', 'traceback'] of os-instance-actions's events" [Undecided,New] https://launchpad.net/bugs/1866292 | 09:36 |
*** trident has joined #openstack-nova | 09:36 | |
gibi | brinzhang_: I will check.. | 09:41 |
brinzhang_ | gibi: thanks ^^ | 09:41 |
*** zhanglong has quit IRC | 09:48 | |
gibi | brinzhang_: I cannot reproduce the issue in devstack with demo user | 09:57 |
gibi | brinzhang_: http://paste.openstack.org/show/790383/ | 09:57 |
gibi | brinzhang_: so I think it could be a specific problem in the func test en | 09:57 |
gibi | env | 09:57 |
brinzhang_ | gibi: yes, I was changed it's default policy, I think caused by the new policy | 09:58 |
gibi | I can pull down your patch in my devstack to see if it changes the behavior | 09:59 |
brinzhang_ | gibi: I debuged in my devstack, and it has the same issue with that CI result | 09:59 |
brinzhang_ | gibi: cool, thanks | 10:00 |
openstackgerrit | John Garbutt proposed openstack/nova master: Introduce scope_types in os-aggregates policy https://review.opendev.org/701652 | 10:02 |
lyarwood | does anyone recall where the legacy zuul migration guide lives now? I'm getting 404's for the links I'm finding. | 10:02 |
lyarwood | https://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html ah ha! | 10:03 |
brinzhang_ | lyarwood: can you provide the old.. cool, let me try | 10:03 |
brinzhang_ | lyarwood: ignore above word^^ | 10:04 |
lyarwood | brinzhang_: https://docs.openstack.org/infra/manual/zuulv3.html | 10:06 |
lyarwood | brinzhang_: returns a 404 now | 10:06 |
lyarwood | brinzhang_: still cached by Google apparently | 10:06 |
brinzhang_ | lyarwood: https://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html this is not what would you want to get? | 10:07 |
lyarwood | brinzhang_: yes sorry that's what I was looking for | 10:08 |
brinzhang_ | lyarwood: ^^ | 10:08 |
*** xek_ has joined #openstack-nova | 10:09 | |
stephenfin | bauzas, gibi: Could you guys close out these remaining nova-network patches today so I can mark the blueprint finished? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/remove-nova-network-ussuri | 10:12 |
* bauzas is doing some bug scrubbing but will take a look | 10:12 | |
*** derekh has joined #openstack-nova | 10:13 | |
stephenfin | they're mostly removals of code, so should be easy to use | 10:14 |
johnthetubaguy | brinzhang_: I may have accidentally spotted why your tests are filing for this patch: https://review.opendev.org/#/c/706470/7/nova/policies/instance_actions.py | 10:15 |
kashyap | lyarwood: Hey, once the fixed libgrypt packages trickle down to distributions, we will eventually deprecate and remove the workaround, yeah? -- https://review.opendev.org/#/c/708030/3 | 10:16 |
brinzhang_ | johnthetubaguy: let me try.. | 10:16 |
*** ralonsoh has joined #openstack-nova | 10:17 | |
lyarwood | kashyap: I'd leave it in place tbh, migration from the workaround is simple and it could be useful if anything like this ever happened again. | 10:18 |
lyarwood | kashyap: migration being actual live or cold migration to a host where the workaround is diabled | 10:18 |
lyarwood | disabled* | 10:19 |
lyarwood | I had an AI to check that we generate the correct XML for the domain in that case but I'm 99.9% sure we would | 10:19 |
johnthetubaguy | stephenfin: is there are reason you don't just delete the squalchmy models, does it break the db migration testing or something? | 10:21 |
stephenfin | johnthetubaguy: dansmith told me not to | 10:21 |
*** ratailor_ has joined #openstack-nova | 10:22 | |
stephenfin | I chose not to argue :) | 10:22 |
*** ratailor has quit IRC | 10:23 | |
johnthetubaguy | so I thought we have to delete the sql alchemy objects before we can drop stuff in the DB a release later, but its been a while since we did that, no totally sure we ever have | 10:23 |
brinzhang_ | johnthetubaguy: no, I removed your point, but it has the same issue, you can see http://paste.openstack.org/show/790386/ | 10:23 |
stephenfin | johnthetubaguy: I've no idea. FWIW though, this is the same thing I did for the cells v1 removal. I have a separate series up now to remove those models | 10:25 |
johnthetubaguy | stephenfin: sounds like we are being consistent, which is all good | 10:25 |
kashyap | lyarwood: Yeah, we can leave it in place, but also have to note explicitly that "updating to this new version of libgcrypt" == you don't need the workaround. | 10:26 |
* kashyap back in a few | 10:26 | |
johnthetubaguy | brinzhang_: i suspect the context object getting into your method for an admin call doesn't have the scope in it, or something like that | 10:29 |
johnthetubaguy | brinzhang_: I think gmann did see some similar errors, but hasn't fixed those yet either | 10:30 |
brinzhang_ | johnthetubaguy: Oh yeah, i didn't pay attention to this, the scope of the context object has a problem, can you know which field it is | 10:32 |
johnthetubaguy | brinzhang_: try adding the system_scope=all here: https://github.com/openstack/nova/blob/f176ffe6e57e21c4c5d9f33a3c9e47476d10acc9/nova/tests/fixtures.py#L916 | 10:32 |
johnthetubaguy | not totally sure... but I think that is the place | 10:32 |
brinzhang_ | johnthetubaguy: ok, let me try | 10:32 |
brinzhang_ | johnthetubaguy: do you point here https://opendev.org/openstack/nova/src/branch/master/nova/tests/fixtures.py#L916? we can not open github fastly | 10:38 |
gibi | stephenfin: I will try to look at those today | 10:38 |
johnthetubaguy | brinzhang_: yeah, sorry, that is where I meant, it is created a fake object, line 948 is what that code is matching on | 10:39 |
stephenfin | Thanks. Let me know if anything isn't immediately obvious :) | 10:39 |
brinzhang_ | johnthetubaguy: That changed to "is_admin = user_id == 'admin and system_scope=all'"? | 10:39 |
stephenfin | gibi: Also, all hail the new leader 👑 | 10:39 |
johnthetubaguy | ah, no, I think you need to add system_scope='all' into the kwargs when user_id == 'admin' | 10:39 |
johnthetubaguy | basically, so it looks like we get a new style admin | 10:40 |
brinzhang_ | johnthetubaguy: sure | 10:40 |
johnthetubaguy | ... having said that, it does suggest the deprecation rules are not quite working as expected, I would ask gmann for more info | 10:41 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Use neutronclient's port binding APIs https://review.opendev.org/706295 | 10:43 |
*** hoonetorg has quit IRC | 10:44 | |
brinzhang_ | johnthetubaguy: it seems not correct, the failed test case is fot non-admin, if we add system_scope='admin' if is_admin=True, that we just change the admin's context, the non-admin context also same as before | 10:47 |
brinzhang_ | and it has the same issue | 10:47 |
johnthetubaguy | ah, OK, I missed that | 10:47 |
johnthetubaguy | curious | 10:47 |
brinzhang_ | http://paste.openstack.org/show/790390/ this is my change, and the test result alos same before | 10:47 |
brinzhang_ | and I think the if always False. | 10:48 |
*** abaindur has quit IRC | 10:52 | |
*** mkrai has quit IRC | 10:52 | |
*** _kukacz has quit IRC | 10:59 | |
*** _kukacz has joined #openstack-nova | 10:59 | |
*** _kukacz has quit IRC | 11:02 | |
*** _kukacz has joined #openstack-nova | 11:02 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604 | 11:05 |
*** brinzhang has joined #openstack-nova | 11:12 | |
*** brinzhang__ has joined #openstack-nova | 11:12 | |
*** brinzhang_ has quit IRC | 11:13 | |
*** jangutter has joined #openstack-nova | 11:18 | |
*** martinkennelly has quit IRC | 11:33 | |
*** rpittau is now known as rpittau|bbl | 11:36 | |
openstackgerrit | Merged openstack/nova stable/train: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/709167 | 11:37 |
openstackgerrit | Qiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED,shelve the instance failed https://review.opendev.org/711609 | 11:37 |
*** tbachman has quit IRC | 11:43 | |
*** ociuhandu has joined #openstack-nova | 11:46 | |
openstackgerrit | Johannes Kulik proposed openstack/nova master: Validate id as integer for os-aggregates https://review.opendev.org/710214 | 11:46 |
openstackgerrit | Merged openstack/nova master: Remove old policy enforcement in attach_interfaces https://review.opendev.org/705127 | 11:49 |
openstackgerrit | Merged openstack/nova master: Add test coverage of existing attach_interfaces policies https://review.opendev.org/705126 | 11:49 |
openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-attach-interfaces https://review.opendev.org/705799 | 11:50 |
openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-console-auth-tokens https://review.opendev.org/706688 | 11:50 |
*** N3l1x has joined #openstack-nova | 11:53 | |
*** brinzhang__ has quit IRC | 11:53 | |
happyhemant | stephenfin: hey hi stephenfin any idea about spoo checking caus it suppose to be ON. https://www.irccloud.com/pastebin/FHzoKqNc/ | 11:54 |
happyhemant | stephenfin: i tried to enable it but this is what am i getting on computes https://www.irccloud.com/pastebin/weWf4L2z/ | 11:55 |
happyhemant | what could be wrong here ? | 11:55 |
gibi | brinzhang: sorry, I did not see what is wrong with that functional test. I hope johnthetubaguy can help | 11:57 |
*** zigo has quit IRC | 12:02 | |
*** purplerbot has quit IRC | 12:04 | |
*** Vek has quit IRC | 12:04 | |
*** irclogbot_3 has quit IRC | 12:05 | |
*** amotoki has quit IRC | 12:05 | |
*** aarents has quit IRC | 12:06 | |
*** aloga has quit IRC | 12:06 | |
*** aarents has joined #openstack-nova | 12:07 | |
*** aloga has joined #openstack-nova | 12:08 | |
*** irclogbot_1 has joined #openstack-nova | 12:08 | |
*** maciejjozefczyk has quit IRC | 12:08 | |
*** amotoki has joined #openstack-nova | 12:09 | |
*** purplerbot has joined #openstack-nova | 12:10 | |
*** zigo has joined #openstack-nova | 12:12 | |
*** psachin has quit IRC | 12:13 | |
*** nicolasbock has joined #openstack-nova | 12:18 | |
*** maciejjozefczyk has joined #openstack-nova | 12:22 | |
*** bbowen has joined #openstack-nova | 12:23 | |
brinzhang | gibi: yeah, thanks. I think johnthethubaguy and gmann can help, they may need to talk something of that failed, that when I will join. | 12:28 |
*** ratailor_ has quit IRC | 12:28 | |
*** zigo has quit IRC | 12:31 | |
*** dtantsur is now known as dtantsur|afk | 12:33 | |
openstackgerrit | Merged openstack/nova master: Correct the actual target in os-instance-actions policy https://review.opendev.org/710411 | 12:44 |
openstackgerrit | Merged openstack/nova master: Add test coverage of existing os-instance-actions policies https://review.opendev.org/707777 | 12:44 |
openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-admin-password https://review.opendev.org/701630 | 12:44 |
openstackgerrit | Merged openstack/nova master: Add new default roles in os-admin-password policies https://review.opendev.org/701639 | 12:45 |
openstackgerrit | Merged openstack/nova master: Add a tests to check when legacy access is removed https://review.opendev.org/710813 | 12:45 |
openstackgerrit | Merged openstack/nova master: Add test coverage of existing console_output policies https://review.opendev.org/706724 | 12:45 |
*** hoonetorg has joined #openstack-nova | 12:46 | |
*** zigo has joined #openstack-nova | 12:50 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-instance-action policy https://review.opendev.org/707751 | 12:53 |
brinzhang | stephenfin: can you +A again, I was reabseed because of the conflict https://review.opendev.org/#/c/707751/ | 12:55 |
*** udesale has joined #openstack-nova | 12:55 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | 12:56 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API https://review.opendev.org/706179 | 12:56 |
*** udesale_ has quit IRC | 12:57 | |
*** psachin has joined #openstack-nova | 13:03 | |
*** tbachman has joined #openstack-nova | 13:07 | |
*** ociuhandu has quit IRC | 13:08 | |
*** ociuhandu has joined #openstack-nova | 13:08 | |
*** martinkennelly has joined #openstack-nova | 13:10 | |
*** Luzi has joined #openstack-nova | 13:11 | |
gibi | stephenfin: I'm +2 all the way up in the nova-net patches | 13:13 |
*** ociuhandu has quit IRC | 13:15 | |
*** salmankhan has joined #openstack-nova | 13:16 | |
*** rpittau|bbl is now known as rpittau | 13:18 | |
*** derekh has quit IRC | 13:25 | |
*** ociuhandu has joined #openstack-nova | 13:27 | |
openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-console-output https://review.opendev.org/707040 | 13:29 |
*** spatel has joined #openstack-nova | 13:30 | |
*** spatel has quit IRC | 13:30 | |
*** trident has quit IRC | 13:30 | |
openstackgerrit | Merged openstack/nova master: Add new default roles in os-console-output policies https://review.opendev.org/707041 | 13:32 |
openstackgerrit | Merged openstack/nova master: Fix os-volumes-attachments policy to be admin_or_owner https://review.opendev.org/709955 | 13:32 |
openstackgerrit | Merged openstack/nova master: Add test coverage of existing os-volumes-attachments policies https://review.opendev.org/709929 | 13:32 |
*** trident has joined #openstack-nova | 13:32 | |
openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-volumes-attachments policy https://review.opendev.org/709388 | 13:36 |
openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-aggregates policy https://review.opendev.org/701652 | 13:36 |
*** abaindur has joined #openstack-nova | 13:37 | |
*** abaindur has quit IRC | 13:42 | |
*** vishalmanchanda has quit IRC | 13:44 | |
*** LiangFang has quit IRC | 13:45 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604 | 13:48 |
*** Luzi has quit IRC | 13:50 | |
gmann | brinzhang: getting coffee. I will check the error. is it instance action one ? | 13:53 |
*** mkrai has joined #openstack-nova | 13:58 | |
*** Vek has joined #openstack-nova | 14:00 | |
brinzhang | gmann: yes, it's the failed patch https://review.opendev.org/#/c/706470/ | 14:02 |
*** ygk_12345 has joined #openstack-nova | 14:04 | |
brinzhang | gmann: the failed is the non-admin expected response is not match the actual response, and the 'traceback' in the actual response, it's should return when the user is non-admin | 14:05 |
brinzhang | gmann: thanks for your check. | 14:05 |
gmann | ok | 14:06 |
brinzhang | johnthetubaguy: thanks +A for that rebase patch | 14:06 |
*** derekh has joined #openstack-nova | 14:08 | |
kashyap | bauzas: stephenfin: Heya, for allocating huge pages, have we already considered the existing libvirt API allocPages()? (I don't see it in the source from a lazy `grep`) | 14:10 |
kashyap | Documentation: https://libvirt.org/html/libvirt-libvirt-host.html#virNodeAllocPages | 14:10 |
*** owalsh has quit IRC | 14:10 | |
*** ygk_12345 has quit IRC | 14:11 | |
*** psachin has quit IRC | 14:11 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Reproduce bug 1862633 https://review.opendev.org/711626 | 14:13 |
openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | 14:13 |
bauzas | kashyap: good question, I dunno | 14:16 |
kashyap | bauzas: Okay, I'll make a mental note to explore it. | 14:17 |
*** owalsh has joined #openstack-nova | 14:18 | |
*** lbragstad has joined #openstack-nova | 14:18 | |
*** nweinber__ has joined #openstack-nova | 14:21 | |
stephenfin | kashyap: What's the context? | 14:22 |
*** trident has quit IRC | 14:22 | |
*** spatel has joined #openstack-nova | 14:22 | |
kashyap | stephenfin: I was triaging a downstream bug, where Nova ends up scheduling a VM to a host w/ insufficient huge pages | 14:22 |
kashyap | Therefore it fails to start on the dest host with: | 14:23 |
kashyap | [quote] | 14:23 |
kashyap | qemu-kvm: -object memory-backend-file,id=ram-node0,prealloc=yes,mem-path=/dev/hugepages/libvirt/qemu/22-instance-00000688,share=yes,size=17179869184,host-nodes=0,policy=bind: unable to map backing store for guest RAM: Cannot allocate memory | 14:23 |
kashyap | [/quote] | 14:23 |
stephenfin | kashyap: My guess is that they have something else on the host using hugepages and have configured the reserved hugepages config opt | 14:23 |
*** trident has joined #openstack-nova | 14:24 | |
kashyap | stephenfin: So maybe we should get the huge pages usage from the host go from there | 14:24 |
kashyap | (And also the Nova config attribute you mention) | 14:24 |
kashyap | Thanks for the idea | 14:24 |
stephenfin | kashyap: '[DEFAULT] reserved_huge_pages', btw | 14:24 |
johnthetubaguy | I have seen that when the NUMA config was bad, by accident | 14:25 |
johnthetubaguy | i.e. not enough huge pages on a single numa node, as that is what I implicitly requested | 14:25 |
*** mkrai has quit IRC | 14:25 | |
stephenfin | johnthetubaguy: But we do track hugepages on a per-node basis, right? | 14:26 |
stephenfin | so there must be something on that node outside of nova consuming those hugepages | 14:26 |
stephenfin | or our tracking is broken | 14:26 |
*** spatel has quit IRC | 14:27 | |
johnthetubaguy | I guess, I thought I saw that for that case too, but I kinda stopped digging for other reasons | 14:27 |
kashyap | So, Nova does something bespoke to account for memory? (/me should read the code) | 14:27 |
johnthetubaguy | it was a while back mind | 14:27 |
kashyap | johnthetubaguy: What do you mean "bad NUMA config"? What is a "good one", in Nova's parlance? | 14:27 |
stephenfin | kashyap: Look for references to NUMAPagesTopology | 14:28 |
stephenfin | we use that object to do our tracking | 14:28 |
johnthetubaguy | its more that if you don't specify it, you are requesting a single numa node with all the RAM | 14:28 |
johnthetubaguy | if you are trying to request the whole node, which is two numa nodes, that is going to fail | 14:28 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/711629 | 14:29 |
kashyap | stephenfin: Noted; thanks for the pointer. | 14:29 |
stephenfin | so 64GB RAM from a two node host with exactly 64GB total (32GB per node)? | 14:29 |
johnthetubaguy | yeah, something like that | 14:30 |
stephenfin | gibi++ Thanks, btw :) | 14:30 |
stephenfin | brinzhang: looks like johnthetubaguy beat me to it | 14:30 |
johnthetubaguy | stephenfin: gmann has added some nice extra policy testing for you to take a peak at btw: https://review.opendev.org/#/c/707039/4/nova/tests/unit/policies/test_create_backup.py | 14:31 |
*** links has quit IRC | 14:31 | |
johnthetubaguy | basically test what happen after we lift all the deprecations, at some point in the future (or via deployer config) | 14:32 |
*** cgoncalves has quit IRC | 14:32 | |
kashyap | stephenfin: Also, isn't it tricky (read: "needs bespoke script") to get the all the mapped huge pages usage by different applications on the host? | 14:33 |
gmann | brinzhang: johnthetubaguy seems we passed extra bit of project id here - https://review.opendev.org/#/c/710411/4/nova/api/openstack/compute/instance_actions.py@166 | 14:33 |
gmann | that rule was admin only and does not need project_id | 14:33 |
johnthetubaguy | gmann: good catch, should by empty dictionary there | 14:34 |
*** cgoncalves has joined #openstack-nova | 14:34 | |
*** iurygregory has quit IRC | 14:34 | |
johnthetubaguy | gmann: mind you, the correct project is better than not specifying a target, so still a step forward I guess ;) | 14:35 |
kashyap | stephenfin: E.g. this short Perl script, which does some huge pages accounting: https://serverfault.com/questions/527085/linux-non-transparent-per-process-hugepage-accounting/644471#644471 | 14:36 |
gmann | johnthetubaguy: but in that case it can be used as owner also with override in rule | 14:36 |
johnthetubaguy | gmann: ... thinking about that more, if someone wants to make that non-admin (similar issue for live-migration) we will need that back in | 14:36 |
johnthetubaguy | gmann: heh, +1 what you just said, basically | 14:36 |
johnthetubaguy | gmann: this stuff is rock hard | 14:37 |
gmann | johnthetubaguy: yeah but it is right or wrong :) ? because we do not allow the same for any other admin only policy | 14:37 |
gmann | admin only by default | 14:37 |
johnthetubaguy | we probably should allow that, for things where it is not strictly a system level thing | 14:38 |
*** Liang__ has joined #openstack-nova | 14:39 | |
johnthetubaguy | but, we are getting ahead of ourselves I guess | 14:39 |
*** cgoncalves has quit IRC | 14:39 | |
johnthetubaguy | this is about digging out of crazy land, so we can add more options in the future | 14:39 |
brinzhang | gmann, johnthetubaguy: I change that to the target={}, but it has the same issue, http://paste.openstack.org/show/790395/ | 14:40 |
*** iurygregory has joined #openstack-nova | 14:40 | |
johnthetubaguy | gmann: is brinzhang hitting the same issue you are here: https://review.opendev.org/#/c/706689 | 14:41 |
johnthetubaguy | I am not sure what is causing the problem though :( | 14:41 |
gmann | johnthetubaguy: ok, let's go case by case and judge the not-strict-system-cases or upon user request . i will leave instance action also in that catagory | 14:41 |
*** cgoncalves has joined #openstack-nova | 14:41 | |
*** amoralej is now known as amoralej|lunch | 14:41 | |
johnthetubaguy | gmann: +1 | 14:41 |
gmann | johnthetubaguy: brinzhang i think i observed some wired things on aggregate policy also but could not debug those yet. let me debug it | 14:42 |
johnthetubaguy | gmann: +1 thanks | 14:42 |
*** ociuhandu has quit IRC | 14:42 | |
brinzhang | gmann: thanks | 14:42 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Reproduce bug 1862633 https://review.opendev.org/711626 | 14:43 |
openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | 14:43 |
openstackgerrit | Balazs Gibizer proposed openstack/nova stable/stein: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/711629 | 14:44 |
*** udesale has quit IRC | 14:45 | |
gibi | stephenfin: would be nice to get a second opinion on https://review.opendev.org/#/c/666245/ It seems to be working but I'm a bit affraid of what this change means on a busy deployment | 14:46 |
*** eharney has joined #openstack-nova | 14:47 | |
*** dave-mccowan has joined #openstack-nova | 14:53 | |
*** ratailor has joined #openstack-nova | 14:53 | |
stephenfin | gibi: ack, will do | 14:55 |
mloza | I specificied cpu_models=x86_EPYC-IBRS in nova.conf but I keep getting this error ': Invalid: Config requested a custom CPU model, but no model name was provided' | 14:56 |
mloza | The model exist in /usr/share/libvirt/cpu_map/x86_EPYC-IBRS.xml | 14:56 |
mloza | This is in stable/stein | 14:57 |
*** _kukacz has quit IRC | 14:58 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: workarounds: Add option to disable native LUKSv1 decryption by QEMU https://review.opendev.org/708030 | 14:59 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: workarounds: Connect RBD volumes to the compute host as block devices https://review.opendev.org/708029 | 14:59 |
*** owalsh has quit IRC | 15:00 | |
*** spatel has joined #openstack-nova | 15:01 | |
*** amoralej|lunch is now known as amoralej | 15:02 | |
*** ociuhandu has joined #openstack-nova | 15:16 | |
*** tbachman has quit IRC | 15:20 | |
*** ociuhandu has quit IRC | 15:21 | |
*** ociuhandu has joined #openstack-nova | 15:21 | |
*** lpetrut has quit IRC | 15:25 | |
johnthetubaguy | mloza: I think stein only supports the option cpu_model: https://docs.openstack.org/nova/stein/configuration/config.html#libvirt.cpu_model | 15:28 |
*** mriedem has joined #openstack-nova | 15:30 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Use neutronclient's port binding APIs https://review.opendev.org/706295 | 15:33 |
*** owalsh has joined #openstack-nova | 15:34 | |
*** maciejjozefczyk_ has joined #openstack-nova | 15:34 | |
*** maciejjozefczyk has quit IRC | 15:36 | |
mloza | johnthetubaguy: yeah. I just noticed now. I was checking the latest docs of nova. I didn't know that they renamed cpu_model to cpu_models in the train release | 15:37 |
*** brinzhang has quit IRC | 15:38 | |
*** owalsh has quit IRC | 15:40 | |
*** ratailor has quit IRC | 15:41 | |
*** brinzhang has joined #openstack-nova | 15:41 | |
*** TxGirlGeek has joined #openstack-nova | 15:43 | |
*** spatel has quit IRC | 15:45 | |
openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-instance-action policy https://review.opendev.org/707751 | 15:47 |
*** owalsh has joined #openstack-nova | 15:50 | |
*** bnemec is now known as beekneemech | 15:53 | |
*** owalsh_ has joined #openstack-nova | 15:53 | |
*** owalsh- has joined #openstack-nova | 15:54 | |
stephenfin | gibi: so what were your specific concerns for https://review.opendev.org/#/c/666245/ ? | 15:56 |
*** mriedem has quit IRC | 15:57 | |
*** owalsh has quit IRC | 15:57 | |
*** owalsh_ has quit IRC | 15:58 | |
*** _kukacz has joined #openstack-nova | 16:08 | |
*** spatel has joined #openstack-nova | 16:10 | |
*** _kukacz has quit IRC | 16:11 | |
*** maciejjozefczyk_ has quit IRC | 16:11 | |
*** _kukacz has joined #openstack-nova | 16:12 | |
*** _kukacz has quit IRC | 16:14 | |
*** jaosorior has quit IRC | 16:14 | |
*** mriedem has joined #openstack-nova | 16:15 | |
stephenfin | dansmith: Can this go ahead now? https://review.opendev.org/#/c/708707/ I'm guessing it's blocking the alembic upper-constraint bump (https://review.opendev.org/#/c/708706/) | 16:15 |
dansmith | I was just looking since I got the review email from you | 16:15 |
dansmith | I think this had to be tested against the bump, | 16:16 |
dansmith | and then again against the current version | 16:16 |
dansmith | so since it's passing now I guess? | 16:16 |
dansmith | prometheanfire: ^ | 16:16 |
*** _kukacz has joined #openstack-nova | 16:16 | |
*** mlavalle has joined #openstack-nova | 16:18 | |
*** _kukacz has quit IRC | 16:26 | |
prometheanfire | we talking about the alembic thing? | 16:27 |
prometheanfire | I'm waiting on nova, so no blocker from me | 16:27 |
dansmith | prometheanfire: https://review.opendev.org/#/c/708707/4 | 16:28 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604 | 16:28 |
*** gyee has joined #openstack-nova | 16:29 | |
gibi | stephenfin: that patch introduces a waitall call for the nova-compute stop codepath. So I can imagine it can change the timing of the nova-compute service restart scenarios in real deployments | 16:30 |
stephenfin | gibi: Yup. There will definitely be knock on effects. That's only for graceful shutdown though, so people could still force things, right? | 16:31 |
gibi | stephenfin: e.g. nova-compute will wait for the all the ongoing instances to boot up before it stops which could take significant time due to e.g. image download | 16:31 |
gibi | right, tooling can send kill signalls for sure | 16:31 |
*** owalsh has joined #openstack-nova | 16:32 | |
dansmith | also probably long-running periodics, like resource update for lots of ironic nodes | 16:32 |
stephenfin | It's not unlimited though. Not by default | 16:32 |
stephenfin | I checked and graceful_shutdown_timeout defaults to a minute | 16:32 |
dansmith | no, it's not | 16:32 |
dansmith | actually, nevermind what I said about the resource update, because that does drop and re-acquire | 16:33 |
stephenfin | so at worst we're introducing an extra 60 second delay | 16:33 |
dansmith | stephenfin: where's the 60 second limit? | 16:33 |
*** owalsh_ has joined #openstack-nova | 16:33 | |
stephenfin | dansmith: https://github.com/openstack/oslo.service/blob/master/oslo_service/_options.py#L51 | 16:34 |
dansmith | is that something the service does? | 16:34 |
stephenfin | yeah, if this comment is to be believed https://review.opendev.org/#/c/666245/16/nova/compute/manager.py@1511 | 16:34 |
dansmith | where's the implementation of that though? | 16:34 |
*** owalsh| has joined #openstack-nova | 16:34 | |
dansmith | https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L333 | 16:34 |
dansmith | does it with sigalrm so should break us out of that otherwise infinite wait | 16:35 |
*** damien_r has quit IRC | 16:35 | |
*** owalsh^ has joined #openstack-nova | 16:35 | |
*** owalsh- has quit IRC | 16:35 | |
*** owalsh has quit IRC | 16:37 | |
gibi | OK, so it is really just an extra 60 seconds delay | 16:37 |
stephenfin | that's my understanding, yes | 16:37 |
stephenfin | I think that's reasonable. We have a reno too | 16:37 |
gibi | I feel better that none of you freaked out about that patch. | 16:38 |
*** owalsh_ has quit IRC | 16:38 | |
dansmith | I haven't really reviewed | 16:38 |
dansmith | can I have a few minutes? | 16:38 |
gibi | dansmith: sure | 16:38 |
gibi | dansmith: but you already know the basic idea of the patch | 16:38 |
dansmith | yeah | 16:38 |
dansmith | we already have a build semaphore and config for it | 16:39 |
dansmith | this would seem to complicate that a bit | 16:39 |
*** owalsh| has quit IRC | 16:39 | |
stephenfin | Does this need a microversion? https://review.opendev.org/#/c/709431/ | 16:40 |
stephenfin | tl;dr: We've been using '/hypervisors' in our 'links' pagination field, rather than '/os-hypervisors' | 16:40 |
gibi | stephenfin: I think we don't want API users to opt into a bugfix | 16:41 |
stephenfin | yes, that's my thinking too | 16:41 |
gibi | this feels a clear bugfix to me | 16:41 |
dansmith | gibi: stephenfin: https://review.opendev.org/#/c/666245/16 | 16:42 |
stephenfin | oh, I never even thought of that /o\ good spot | 16:43 |
gibi | dansmith: good catch | 16:43 |
dansmith | the change should be small.. just remove the new conf and the old semaphore, wire the group to the old conf | 16:44 |
gibi | yeah, make sense | 16:44 |
gibi | stephenfin: I'm +2 on the os-hypervisors bugfix | 16:45 |
stephenfin | gibi: Just checked and looks like os-keypairs is also wrong | 16:46 |
gibi | stephenfin: soo you won a bug to fix ;) | 16:47 |
gibi | dansmith: if you are in a reviewing mood then the last pieces of the qos bp needs a second core https://review.opendev.org/#/q/status:open+bp/support-move-ops-with-qos-ports-ussuri | 16:47 |
dansmith | gibi: I'm in a -1ing mood.. do you want to take that gamble? :D | 16:48 |
gibi | dansmith: if it is as valid -1 as on the graceful shutdown patch then please go ahead | 16:49 |
*** ociuhandu_ has joined #openstack-nova | 16:54 | |
*** ociuhandu has quit IRC | 16:57 | |
*** ociuhandu_ has quit IRC | 16:58 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix os-keypairs pagination links https://review.opendev.org/711662 | 17:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Rename directory for os-keypairs samples https://review.opendev.org/711663 | 17:03 |
stephenfin | gibi: ^ | 17:03 |
stephenfin | (second one's just a nice-to-have) | 17:03 |
gibi | stephenfin: thanks, looking | 17:03 |
*** rpittau is now known as rpittau|afk | 17:04 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Fix hypervisors paginted collection_name. https://review.opendev.org/711664 | 17:04 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Fix hypervisors paginted collection_name. https://review.opendev.org/711664 | 17:05 |
dansmith | gibi: https://review.opendev.org/#/c/705475/4/nova/api/openstack/common.py | 17:05 |
*** iurygregory has quit IRC | 17:05 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Fix hypervisors paginted collection_name. https://review.opendev.org/711669 | 17:08 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Fix hypervisors paginted collection_name. https://review.opendev.org/711670 | 17:08 |
gibi | dansmith: so you mean we need a service version bump even without RPC change. | 17:11 |
dansmith | gibi: you're depending on a behavior change on the compute nodes from the api node.. even though there's not an RPC signature change, you don't know when/if those computes can do what you're asking | 17:12 |
gibi | dansmith: yeah. you are right. without the compute side change the port binding won't be updated during unshelve. | 17:14 |
dansmith | this is really *why* we have service version.. the tie to RPC just makes it easier to ensure we can also look up rpc versions for auto pinning | 17:15 |
gibi | dansmith: in theory it would be the goal of the scheduler to select a host during unshelve that is capable of supporting the server with qos port | 17:16 |
dansmith | yeah, you could enforce it there too, but that seems messy-er | 17:17 |
gibi | dansmith: would it be a compute host capability? | 17:17 |
dansmith | you'd basically need a new filter or a trait | 17:17 |
dansmith | we're doing the trait approach for cyborg because it's more than just newness that we're looking for | 17:17 |
dansmith | so yeah, if you want to go that route that's fine, but it'd be a lot simpler to just do the service version :) | 17:18 |
gibi | dansmith: another option is global compute service level check in the api | 17:18 |
gibi | which do seems easier | 17:18 |
dansmith | yeah, that's what I was suggesting.. gobal check | 17:18 |
dansmith | meaning, api keeps it disabled until everything is upgraded, which is the more common way we do this kind of thing | 17:18 |
gibi | OK. I get it. global check it is | 17:18 |
dansmith | basically replace your "return False" with "return $version >= $minimum" | 17:19 |
*** martinkennelly has quit IRC | 17:19 | |
gibi | yepp | 17:19 |
gibi | regarding microversion bump. I think that ship is sailed when we enabled migrate, resize, evac and live migrate support for qos without microversion bump | 17:20 |
gibi | it would be equally weird to bump now | 17:21 |
dansmith | ack, that's why I didn't -1 | 17:24 |
dansmith | I figured there was context I was missing | 17:24 |
dansmith | and you did say in a comment "if we decide to do so" | 17:24 |
dansmith | so I figured....you (all) decided | 17:24 |
openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | 17:25 |
gibi | dansmith: it was the train PTG where we decided to go for the move support without microversion bumps. I made a mistake not change the error messages to not forcast such bum | 17:26 |
gibi | p | 17:26 |
gibi | anyhow I will work on the service level check | 17:26 |
dansmith | ack | 17:26 |
gibi | thanks for the review | 17:26 |
*** spatel has quit IRC | 17:30 | |
*** tbachman has joined #openstack-nova | 17:34 | |
*** evrardjp has quit IRC | 17:35 | |
*** evrardjp has joined #openstack-nova | 17:35 | |
*** artom has quit IRC | 17:38 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP images: Make JSON the default output format of calls to qemu-img info https://review.opendev.org/711679 | 17:38 |
*** artom has joined #openstack-nova | 17:38 | |
openstackgerrit | melanie witt proposed openstack/nova master: Add logging of ironic driver hash ring to aid in debugging https://review.opendev.org/711680 | 17:44 |
melwitt | dansmith: do you think ^ is a reasonable or did you think lower()ing names in the hash ring is something we should also do? | 17:47 |
*** maciejjozefczyk has joined #openstack-nova | 17:47 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-atttach-inerfaces policies https://review.opendev.org/706672 | 17:48 |
dansmith | melwitt: I think we probably need to lower() the things we put into the hash ring | 17:49 |
dansmith | potentially checking for conflicts that would only arise due to case might be prudent, | 17:49 |
dansmith | but I can't imagine differing-only-by-case is anything other than a point of confusion for people | 17:49 |
melwitt | yeah, that's what I was wondering | 17:50 |
melwitt | wondering/thinking | 17:50 |
melwitt | thanks | 17:50 |
gmann | johnthetubaguy: brinzhang this is issue, you used same policy rule with two different check_str - https://review.opendev.org/#/c/706470/8/nova/policies/instance_actions.py@31 | 17:54 |
*** amoralej is now known as amoralej|off | 17:54 | |
gmann | so basically event policy has deprecation of admin_or_owner depends on order it goes in oslo policy | 17:55 |
*** tbachman has quit IRC | 17:59 | |
*** derekh has quit IRC | 18:00 | |
*** jangutter has quit IRC | 18:01 | |
*** tbachman has joined #openstack-nova | 18:08 | |
*** eharney has quit IRC | 18:12 | |
*** tesseract has quit IRC | 18:15 | |
*** larainema has quit IRC | 18:16 | |
*** maciejjozefczyk has quit IRC | 18:16 | |
*** spatel has joined #openstack-nova | 18:17 | |
*** spatel has quit IRC | 18:17 | |
*** spatel has joined #openstack-nova | 18:17 | |
openstackgerrit | melanie witt proposed openstack/nova master: Lowercase ironic driver hash ring hosts and add logging https://review.opendev.org/711680 | 18:18 |
melwitt | dansmith: updated ^ | 18:19 |
*** igordc has joined #openstack-nova | 18:20 | |
*** igordc has quit IRC | 18:20 | |
melwitt | also TheJulia or jroll fyi ^ | 18:26 |
TheJulia | melwitt: I'll take a look after I'm done cooking my wifey some lunch | 18:27 |
melwitt | heh k | 18:27 |
*** gmann is now known as gmann_lunch | 18:27 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova master: [Trivial] Fix code comment of admin password tests https://review.opendev.org/711734 | 18:29 |
*** maciejjozefczyk has joined #openstack-nova | 18:29 | |
*** gmann_lunch is now known as gmann | 18:32 | |
*** ralonsoh has quit IRC | 18:40 | |
*** happyhemant has quit IRC | 18:40 | |
*** ociuhandu has joined #openstack-nova | 18:47 | |
*** ociuhandu has quit IRC | 18:52 | |
jroll | melwitt: nice, thanks | 19:00 |
melwitt | thanks for reviewing! | 19:00 |
*** salmankhan has quit IRC | 19:00 | |
openstackgerrit | Merged openstack/nova master: Name Enums https://review.opendev.org/708707 | 19:02 |
*** eharney has joined #openstack-nova | 19:09 | |
*** maciejjozefczyk has quit IRC | 19:15 | |
melwitt | thanks for the review TheJulia ! | 19:32 |
TheJulia | So turns out, someone renaming a conductor would also do some... bad things | 19:32 |
TheJulia | but only lock individual machines | 19:32 |
*** abaindur has joined #openstack-nova | 19:39 | |
*** maciejjozefczyk has joined #openstack-nova | 19:41 | |
melwitt | TheJulia: good thinkin to go check that | 19:43 |
*** nweinber__ has quit IRC | 19:44 | |
*** abaindur has quit IRC | 19:44 | |
*** maciejjozefczyk has quit IRC | 19:44 | |
openstackgerrit | Merged openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727 | 19:50 |
openstackgerrit | Merged openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726 | 19:50 |
openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038 | 19:53 |
openstackgerrit | Merged openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039 | 19:53 |
mloza | How can I allow member to see the OS-EXT-SRV-ATTR of the instance ? | 19:56 |
mloza | Nvm. I found it nova policy.json | 20:06 |
*** tbachman has quit IRC | 20:13 | |
*** abaindur has joined #openstack-nova | 20:16 | |
*** N3l1x has quit IRC | 20:36 | |
*** spatel has quit IRC | 20:44 | |
donnyd | need to re-create the flavor for multi-numa - does anyone remember what meta-data was needed for the NFV jobs besides sean-k-mooney | 20:45 |
*** ociuhandu has joined #openstack-nova | 20:55 | |
*** brinzhang has quit IRC | 21:11 | |
*** dave-mccowan has quit IRC | 21:11 | |
*** _erlon_ has quit IRC | 21:11 | |
*** tinwood has quit IRC | 21:13 | |
*** portdirect has quit IRC | 21:13 | |
*** StevenK has quit IRC | 21:13 | |
*** ChanServ has quit IRC | 21:13 | |
*** melwitt has quit IRC | 21:13 | |
*** johnsom has quit IRC | 21:13 | |
*** tonyb[m] has quit IRC | 21:13 | |
*** f0o has quit IRC | 21:13 | |
*** kevinz has quit IRC | 21:13 | |
*** jungleboyj has quit IRC | 21:13 | |
*** aspiers has quit IRC | 21:13 | |
*** corvus has quit IRC | 21:13 | |
*** Hazelesque has quit IRC | 21:13 | |
*** mugsie has quit IRC | 21:13 | |
*** Jeffrey4l has quit IRC | 21:13 | |
*** klindgren has quit IRC | 21:13 | |
*** jrosser has quit IRC | 21:13 | |
*** donnyd has quit IRC | 21:13 | |
*** cz3 has quit IRC | 21:13 | |
*** fyx has quit IRC | 21:13 | |
*** knikolla has quit IRC | 21:13 | |
*** logan- has quit IRC | 21:13 | |
*** rajinir has quit IRC | 21:13 | |
*** pas-ha has quit IRC | 21:13 | |
*** dustinc has quit IRC | 21:13 | |
*** jroll has quit IRC | 21:13 | |
*** pots has quit IRC | 21:13 | |
*** DinaBelova has quit IRC | 21:13 | |
*** ociuhandu has quit IRC | 21:13 | |
*** zigo has quit IRC | 21:13 | |
*** aloga has quit IRC | 21:13 | |
*** mgariepy has quit IRC | 21:13 | |
*** mgoddard has quit IRC | 21:13 | |
*** zzzeek has quit IRC | 21:13 | |
*** benj_ has quit IRC | 21:13 | |
*** bhagyashris has quit IRC | 21:13 | |
*** eandersson has quit IRC | 21:13 | |
*** amoralej|off has quit IRC | 21:13 | |
*** asettle has quit IRC | 21:13 | |
*** ildikov has quit IRC | 21:13 | |
*** arxcruz|rover has quit IRC | 21:13 | |
*** spotz has quit IRC | 21:13 | |
*** kevinbenton has quit IRC | 21:13 | |
*** nicolasbock has quit IRC | 21:13 | |
*** bcm has quit IRC | 21:13 | |
*** awestin1 has quit IRC | 21:13 | |
*** gmann has quit IRC | 21:13 | |
*** tristanC has quit IRC | 21:13 | |
*** smcginnis has quit IRC | 21:13 | |
*** csatari has quit IRC | 21:13 | |
*** kukacz has quit IRC | 21:13 | |
*** cgoncalves has quit IRC | 21:13 | |
*** lbragstad has quit IRC | 21:13 | |
*** slaweq has quit IRC | 21:13 | |
*** kaisers has quit IRC | 21:13 | |
*** kashyap has quit IRC | 21:13 | |
*** prometheanfire has quit IRC | 21:13 | |
*** jhesketh has quit IRC | 21:13 | |
*** yoctozepto has quit IRC | 21:13 | |
*** ccstone has quit IRC | 21:13 | |
*** ioni has quit IRC | 21:13 | |
*** lifeless has quit IRC | 21:13 | |
*** dtruong has quit IRC | 21:13 | |
*** tbarron has quit IRC | 21:13 | |
*** ianw has quit IRC | 21:13 | |
*** tobberydberg has quit IRC | 21:13 | |
*** obre has quit IRC | 21:13 | |
*** gibi has quit IRC | 21:13 | |
*** antonym has quit IRC | 21:13 | |
*** amorin has quit IRC | 21:13 | |
*** owalsh^ has quit IRC | 21:13 | |
*** purplerbot has quit IRC | 21:13 | |
*** irclogbot_1 has quit IRC | 21:13 | |
*** ccamacho has quit IRC | 21:13 | |
*** KeithMnemonic1 has quit IRC | 21:13 | |
*** rnoriega_ has quit IRC | 21:13 | |
*** efried_gone has quit IRC | 21:13 | |
*** mvkr has quit IRC | 21:13 | |
*** johnthetubaguy has quit IRC | 21:13 | |
*** Corwin_ has quit IRC | 21:13 | |
*** vesper11 has quit IRC | 21:13 | |
*** evrardjp has quit IRC | 21:13 | |
*** luyao has quit IRC | 21:13 | |
*** CeeMac has quit IRC | 21:13 | |
*** masayukig has quit IRC | 21:13 | |
*** dasp has quit IRC | 21:13 | |
*** raorn has quit IRC | 21:13 | |
*** arne_wiebalck has quit IRC | 21:13 | |
*** mnasiadka has quit IRC | 21:13 | |
*** fungi has quit IRC | 21:13 | |
*** d34dh0r53 has quit IRC | 21:13 | |
*** tonyb has quit IRC | 21:13 | |
*** rm_work has quit IRC | 21:13 | |
*** ab-a has quit IRC | 21:13 | |
*** seba has quit IRC | 21:13 | |
*** Alon_KS has quit IRC | 21:13 | |
*** abaindur has quit IRC | 21:13 | |
*** artom has quit IRC | 21:13 | |
*** mriedem has quit IRC | 21:13 | |
*** hoonetorg has quit IRC | 21:13 | |
*** factor has quit IRC | 21:13 | |
*** toabctl has quit IRC | 21:13 | |
*** tobiash has quit IRC | 21:13 | |
*** ircuser-1 has quit IRC | 21:13 | |
*** elod has quit IRC | 21:13 | |
*** alex_xu has quit IRC | 21:13 | |
*** yaawang has quit IRC | 21:13 | |
*** johanssone has quit IRC | 21:13 | |
*** ebbex has quit IRC | 21:13 | |
*** redrobot has quit IRC | 21:13 | |
*** ganso has quit IRC | 21:13 | |
*** dansmith has quit IRC | 21:13 | |
*** jkulik has quit IRC | 21:13 | |
*** lchabert has quit IRC | 21:13 | |
*** gryf has quit IRC | 21:13 | |
*** hemna has quit IRC | 21:13 | |
*** klippo has quit IRC | 21:13 | |
*** guilhermesp has quit IRC | 21:13 | |
*** ericyoung has quit IRC | 21:13 | |
*** rmk has quit IRC | 21:13 | |
*** fnordahl has quit IRC | 21:13 | |
*** gouthamr has quit IRC | 21:13 | |
*** toanster has quit IRC | 21:13 | |
*** frickler has quit IRC | 21:13 | |
*** mordred has quit IRC | 21:13 | |
*** diconico07 has quit IRC | 21:13 | |
*** andreaf has quit IRC | 21:13 | |
*** dtantsur|afk has quit IRC | 21:13 | |
*** TxGirlGeek has quit IRC | 21:13 | |
*** tosky has quit IRC | 21:13 | |
*** sorrison has quit IRC | 21:13 | |
*** sapd1 has quit IRC | 21:13 | |
*** adrianc has quit IRC | 21:13 | |
*** mtreinish has quit IRC | 21:13 | |
*** lyarwood has quit IRC | 21:13 | |
*** NostawRm has quit IRC | 21:13 | |
*** bjolo has quit IRC | 21:13 | |
*** bauzas has quit IRC | 21:13 | |
*** etp has quit IRC | 21:13 | |
*** mlavalle has quit IRC | 21:13 | |
*** bbowen has quit IRC | 21:13 | |
*** NobodyCam has quit IRC | 21:13 | |
*** TheJulia has quit IRC | 21:13 | |
*** eharney has quit IRC | 21:13 | |
*** gyee has quit IRC | 21:13 | |
*** trident has quit IRC | 21:13 | |
*** amotoki has quit IRC | 21:13 | |
*** aarents has quit IRC | 21:13 | |
*** xek_ has quit IRC | 21:13 | |
*** takamatsu has quit IRC | 21:13 | |
*** andreykurilin has quit IRC | 21:13 | |
*** dklyle has quit IRC | 21:13 | |
*** openstackgerrit has quit IRC | 21:13 | |
*** lennyb has quit IRC | 21:13 | |
*** stephenfin has quit IRC | 21:13 | |
*** beekneemech has quit IRC | 21:13 | |
*** gary_perkins has quit IRC | 21:13 | |
*** vdrok has quit IRC | 21:13 | |
*** jdillaman has quit IRC | 21:13 | |
*** lucidguy has quit IRC | 21:13 | |
*** mnaser has quit IRC | 21:13 | |
*** rpittau|afk has quit IRC | 21:13 | |
*** coreycb has quit IRC | 21:13 | |
*** cmurphy has quit IRC | 21:13 | |
*** ttx has quit IRC | 21:13 | |
*** Anticimex has quit IRC | 21:13 | |
*** ociuhandu has joined #openstack-nova | 21:13 | |
*** abaindur has joined #openstack-nova | 21:13 | |
*** eharney has joined #openstack-nova | 21:13 | |
*** artom has joined #openstack-nova | 21:13 | |
*** evrardjp has joined #openstack-nova | 21:13 | |
*** owalsh^ has joined #openstack-nova | 21:13 | |
*** gyee has joined #openstack-nova | 21:13 | |
*** mlavalle has joined #openstack-nova | 21:13 | |
*** mriedem has joined #openstack-nova | 21:13 | |
*** TxGirlGeek has joined #openstack-nova | 21:13 | |
*** brinzhang has joined #openstack-nova | 21:13 | |
*** dave-mccowan has joined #openstack-nova | 21:13 | |
*** cgoncalves has joined #openstack-nova | 21:13 | |
*** trident has joined #openstack-nova | 21:13 | |
*** lbragstad has joined #openstack-nova | 21:13 | |
*** zigo has joined #openstack-nova | 21:13 | |
*** hoonetorg has joined #openstack-nova | 21:13 | |
*** bbowen has joined #openstack-nova | 21:13 | |
*** nicolasbock has joined #openstack-nova | 21:13 | |
*** purplerbot has joined #openstack-nova | 21:13 | |
*** amotoki has joined #openstack-nova | 21:13 | |
*** irclogbot_1 has joined #openstack-nova | 21:13 | |
*** aloga has joined #openstack-nova | 21:13 | |
*** aarents has joined #openstack-nova | 21:13 | |
*** xek_ has joined #openstack-nova | 21:13 | |
*** tosky has joined #openstack-nova | 21:13 | |
*** ccamacho has joined #openstack-nova | 21:13 | |
*** slaweq has joined #openstack-nova | 21:13 | |
*** sorrison has joined #openstack-nova | 21:13 | |
*** sapd1 has joined #openstack-nova | 21:13 | |
*** adrianc has joined #openstack-nova | 21:13 | |
*** KeithMnemonic1 has joined #openstack-nova | 21:13 | |
*** kaisers has joined #openstack-nova | 21:13 | |
*** luyao has joined #openstack-nova | 21:13 | |
*** mgariepy has joined #openstack-nova | 21:13 | |
*** kashyap has joined #openstack-nova | 21:13 | |
*** takamatsu has joined #openstack-nova | 21:13 | |
*** StevenK has joined #openstack-nova | 21:13 | |
*** portdirect has joined #openstack-nova | 21:13 | |
*** tinwood has joined #openstack-nova | 21:13 | |
*** _erlon_ has joined #openstack-nova | 21:13 | |
*** andreykurilin has joined #openstack-nova | 21:13 | |
*** rnoriega_ has joined #openstack-nova | 21:13 | |
*** efried_gone has joined #openstack-nova | 21:13 | |
*** factor has joined #openstack-nova | 21:13 | |
*** mvkr has joined #openstack-nova | 21:13 | |
*** dklyle has joined #openstack-nova | 21:13 | |
*** toabctl has joined #openstack-nova | 21:13 | |
*** CeeMac has joined #openstack-nova | 21:13 | |
*** mgoddard has joined #openstack-nova | 21:13 | |
*** openstackgerrit has joined #openstack-nova | 21:13 | |
*** NobodyCam has joined #openstack-nova | 21:13 | |
*** vdrok has joined #openstack-nova | 21:13 | |
*** masayukig has joined #openstack-nova | 21:13 | |
*** TheJulia has joined #openstack-nova | 21:13 | |
*** johnthetubaguy has joined #openstack-nova | 21:13 | |
*** prometheanfire has joined #openstack-nova | 21:13 | |
*** Corwin_ has joined #openstack-nova | 21:13 | |
*** klippo has joined #openstack-nova | 21:13 | |
*** vesper11 has joined #openstack-nova | 21:13 | |
*** mtreinish has joined #openstack-nova | 21:13 | |
*** tobiash has joined #openstack-nova | 21:13 | |
*** ircuser-1 has joined #openstack-nova | 21:13 | |
*** lyarwood has joined #openstack-nova | 21:13 | |
*** dasp has joined #openstack-nova | 21:13 | |
*** ChanServ has joined #openstack-nova | 21:13 | |
*** elod has joined #openstack-nova | 21:13 | |
*** lennyb has joined #openstack-nova | 21:13 | |
*** jdillaman has joined #openstack-nova | 21:13 | |
*** stephenfin has joined #openstack-nova | 21:13 | |
*** alex_xu has joined #openstack-nova | 21:13 | |
*** Anticimex has joined #openstack-nova | 21:13 | |
*** bauzas has joined #openstack-nova | 21:13 | |
*** etp has joined #openstack-nova | 21:13 | |
*** andreaf has joined #openstack-nova | 21:13 | |
*** dtantsur|afk has joined #openstack-nova | 21:13 | |
*** rmk has joined #openstack-nova | 21:13 | |
*** fnordahl has joined #openstack-nova | 21:13 | |
*** gouthamr has joined #openstack-nova | 21:13 | |
*** toanster has joined #openstack-nova | 21:13 | |
*** frickler has joined #openstack-nova | 21:13 | |
*** dansmith has joined #openstack-nova | 21:13 | |
*** jkulik has joined #openstack-nova | 21:13 | |
*** lchabert has joined #openstack-nova | 21:13 | |
*** gryf has joined #openstack-nova | 21:13 | |
*** hemna has joined #openstack-nova | 21:13 | |
*** orwell.freenode.net sets mode: +o ChanServ | 21:13 | |
*** tonyb has joined #openstack-nova | 21:13 | |
*** ab-a has joined #openstack-nova | 21:13 | |
*** rm_work has joined #openstack-nova | 21:13 | |
*** seba has joined #openstack-nova | 21:13 | |
*** Alon_KS has joined #openstack-nova | 21:13 | |
*** ttx has joined #openstack-nova | 21:13 | |
*** cmurphy has joined #openstack-nova | 21:13 | |
*** tristanC has joined #openstack-nova | 21:13 | |
*** smcginnis has joined #openstack-nova | 21:13 | |
*** csatari has joined #openstack-nova | 21:13 | |
*** kukacz has joined #openstack-nova | 21:13 | |
*** ioni has joined #openstack-nova | 21:13 | |
*** lifeless has joined #openstack-nova | 21:13 | |
*** dtruong has joined #openstack-nova | 21:13 | |
*** tbarron has joined #openstack-nova | 21:13 | |
*** ianw has joined #openstack-nova | 21:13 | |
*** tobberydberg has joined #openstack-nova | 21:13 | |
*** obre has joined #openstack-nova | 21:13 | |
*** gibi has joined #openstack-nova | 21:13 | |
*** antonym has joined #openstack-nova | 21:13 | |
*** amorin has joined #openstack-nova | 21:13 | |
*** ildikov has joined #openstack-nova | 21:13 | |
*** arxcruz|rover has joined #openstack-nova | 21:13 | |
*** spotz has joined #openstack-nova | 21:13 | |
*** kevinbenton has joined #openstack-nova | 21:13 | |
*** ericyoung has joined #openstack-nova | 21:13 | |
*** amoralej|off has joined #openstack-nova | 21:13 | |
*** benj_ has joined #openstack-nova | 21:13 | |
*** bhagyashris has joined #openstack-nova | 21:13 | |
*** eandersson has joined #openstack-nova | 21:13 | |
*** melwitt has joined #openstack-nova | 21:13 | |
*** johnsom has joined #openstack-nova | 21:13 | |
*** tonyb[m] has joined #openstack-nova | 21:13 | |
*** f0o has joined #openstack-nova | 21:13 | |
*** jungleboyj has joined #openstack-nova | 21:13 | |
*** aspiers has joined #openstack-nova | 21:13 | |
*** corvus has joined #openstack-nova | 21:13 | |
*** Hazelesque has joined #openstack-nova | 21:13 | |
*** logan- has joined #openstack-nova | 21:13 | |
*** rajinir has joined #openstack-nova | 21:13 | |
*** pas-ha has joined #openstack-nova | 21:13 | |
*** dustinc has joined #openstack-nova | 21:13 | |
*** jroll has joined #openstack-nova | 21:13 | |
*** pots has joined #openstack-nova | 21:13 | |
*** DinaBelova has joined #openstack-nova | 21:13 | |
*** gmann has joined #openstack-nova | 21:13 | |
*** knikolla has joined #openstack-nova | 21:13 | |
*** coreycb has joined #openstack-nova | 21:13 | |
*** awestin1 has joined #openstack-nova | 21:13 | |
*** rpittau|afk has joined #openstack-nova | 21:13 | |
*** fyx has joined #openstack-nova | 21:13 | |
*** bcm has joined #openstack-nova | 21:13 | |
*** cz3 has joined #openstack-nova | 21:13 | |
*** donnyd has joined #openstack-nova | 21:13 | |
*** jrosser has joined #openstack-nova | 21:13 | |
*** mnaser has joined #openstack-nova | 21:13 | |
*** ccstone has joined #openstack-nova | 21:13 | |
*** d34dh0r53 has joined #openstack-nova | 21:13 | |
*** gary_perkins has joined #openstack-nova | 21:13 | |
*** fungi has joined #openstack-nova | 21:13 | |
*** yoctozepto has joined #openstack-nova | 21:13 | |
*** kevinz has joined #openstack-nova | 21:13 | |
*** mnasiadka has joined #openstack-nova | 21:13 | |
*** guilhermesp has joined #openstack-nova | 21:13 | |
*** jhesketh has joined #openstack-nova | 21:13 | |
*** klindgren has joined #openstack-nova | 21:13 | |
*** zzzeek has joined #openstack-nova | 21:13 | |
*** arne_wiebalck has joined #openstack-nova | 21:13 | |
*** Jeffrey4l has joined #openstack-nova | 21:13 | |
*** diconico07 has joined #openstack-nova | 21:13 | |
*** asettle has joined #openstack-nova | 21:13 | |
*** raorn has joined #openstack-nova | 21:13 | |
*** mordred has joined #openstack-nova | 21:13 | |
*** ganso has joined #openstack-nova | 21:13 | |
*** bjolo has joined #openstack-nova | 21:13 | |
*** redrobot has joined #openstack-nova | 21:13 | |
*** NostawRm has joined #openstack-nova | 21:13 | |
*** ebbex has joined #openstack-nova | 21:13 | |
*** johanssone has joined #openstack-nova | 21:13 | |
*** yaawang has joined #openstack-nova | 21:13 | |
*** mugsie has joined #openstack-nova | 21:13 | |
*** lucidguy has joined #openstack-nova | 21:13 | |
*** beekneemech has joined #openstack-nova | 21:13 | |
*** factor has quit IRC | 21:13 | |
*** factor has joined #openstack-nova | 21:13 | |
*** factor has quit IRC | 21:16 | |
*** tbachman has joined #openstack-nova | 21:16 | |
*** factor has joined #openstack-nova | 21:16 | |
*** abaindur has quit IRC | 21:19 | |
*** nicolasbock has quit IRC | 21:42 | |
*** imacdonn has quit IRC | 22:05 | |
*** imacdonn has joined #openstack-nova | 22:05 | |
*** abaindur has joined #openstack-nova | 22:13 | |
*** mriedem has quit IRC | 22:15 | |
*** factor has quit IRC | 22:15 | |
*** abaindur has quit IRC | 22:32 | |
*** abaindur has joined #openstack-nova | 22:33 | |
*** xek_ has quit IRC | 22:37 | |
brinzhang | gmann: So https://review.opendev.org/#/c/706470/8/nova/policies/instance_actions.py@29 is why the functional-py36 failed? | 22:40 |
*** ociuhandu has quit IRC | 22:40 | |
*** ociuhandu has joined #openstack-nova | 22:41 | |
*** spatel has joined #openstack-nova | 22:41 | |
*** spatel has quit IRC | 22:42 | |
brinzhang | gmann: you are right, thanks. | 22:44 |
brinzhang | gmann: but I have a question, why we dont need https://review.opendev.org/#/c/706470/8/nova/tests/unit/fake_policy.py@49 this fake policy? | 22:44 |
*** ociuhandu has quit IRC | 22:45 | |
*** jrosser has quit IRC | 22:51 | |
*** jrosser has joined #openstack-nova | 22:53 | |
*** igordc has joined #openstack-nova | 23:17 | |
gmann | brinzhang: it is needed, i am saying that policy should have exist before as that was old policy but somehow we missed | 23:20 |
brinzhang | gmann: but, if I keep this policy in fake, the functional-py36 failed too(same issue), otherwise it will run success. | 23:22 |
brinzhang | gmann: that's why I dont understand why I must delete it | 23:23 |
gmann | brinzhang: fake policy make all the policy accessible to everyone so that tests can verify the things without worry about right policy allowablecontext | 23:24 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-atttach-inerfaces policies https://review.opendev.org/706672 | 23:24 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | 23:24 |
gmann | you modified the deprecation stuff also ? | 23:24 |
brinzhang | gmann: no | 23:25 |
brinzhang | I rebased on your os-attach-interfaces patch | 23:26 |
gmann | ok, let's fix all those comments and then it should pass | 23:26 |
brinzhang | gmann: I was updated, you can review again | 23:27 |
*** mlavalle has quit IRC | 23:27 | |
gmann | what happen is, in your patch where you deprecated wrong policy rule, event policy is deprecated with admin_or_owner and so does non-admin was able to access the traceback of events | 23:27 |
brinzhang | gmann: I want to separate the GET interface, do you agree? | 23:28 |
brinzhang | add '**:list' and '***:show' to restrict the list and show API | 23:29 |
gmann | separate ? | 23:29 |
gmann | yeah, that is what i commented on review, we need granularity on those | 23:29 |
brinzhang | yes, I will follow up this later | 23:30 |
brinzhang | gmann: thanks, I know what I am confusing question. | 23:30 |
gmann | ohk. | 23:31 |
brinzhang | I think while johnthetubaguy week up, he will see that run success ^^ | 23:31 |
openstackgerrit | melanie witt proposed openstack/nova master: Lowercase ironic driver hash ring and ignore case in cache https://review.opendev.org/711680 | 23:32 |
*** rcernin has joined #openstack-nova | 23:33 | |
*** TxGirlGeek has quit IRC | 23:36 | |
*** TxGirlGeek has joined #openstack-nova | 23:36 | |
*** lbragstad_ has joined #openstack-nova | 23:46 | |
*** lbragstad has quit IRC | 23:49 | |
brinzhang | gmann: if I granularity on the os-instance-actions GET (list/show) API, does need to add a releasenote? | 23:49 |
brinzhang | gmann: or you will add realeasenote for refresh default policy topic? | 23:51 |
*** tosky has quit IRC | 23:51 | |
brinzhang | I mean, in your end patch, you will summary this topic changes, and add a total realeasenote to record these changes? | 23:52 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!