Friday, 2020-03-06

« Thursday, 2020-03-05 Index Saturday, 2020-03-07 »
*** brinzhang has quit IRC00:01
*** mriedem has left #openstack-nova00:11
*** tbachman has joined #openstack-nova00:29
*** tbachman has quit IRC00:39
*** bbowen has quit IRC00:43
*** bbowen has joined #openstack-nova00:43
*** larainema has joined #openstack-nova00:47
*** bbowen has quit IRC00:47
*** brinzhang has joined #openstack-nova00:51
*** brinzhang_ has quit IRC00:54
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete  https://review.opendev.org/70747600:55
openstackgerritBrin Zhang proposed openstack/nova master: Correct the actual target in os-instance-actions policy  https://review.opendev.org/71041100:59
openstackgerritBrin Zhang proposed openstack/nova master: Add test coverage of existing os-instance-actions policies  https://review.opendev.org/70777700:59
*** tetsuro has joined #openstack-nova01:02
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-admin-password  https://review.opendev.org/70163001:05
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-admin-password policies  https://review.opendev.org/70163901:06
openstackgerritGhanshyam Mann proposed openstack/nova master: Add a tests to check when legacy access is removed  https://review.opendev.org/71081301:06
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete  https://review.opendev.org/70747601:06
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies  https://review.opendev.org/70748501:06
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete  https://review.opendev.org/70747601:09
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies  https://review.opendev.org/70748501:09
*** igordc has quit IRC01:18
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies  https://review.opendev.org/70748501:23
*** mlavalle has quit IRC01:24
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing console_output policies  https://review.opendev.org/70672401:26
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output  https://review.opendev.org/70704001:27
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing console_output policies  https://review.opendev.org/70672401:28
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output  https://review.opendev.org/70704001:28
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-console-output  https://review.opendev.org/70704001:29
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies  https://review.opendev.org/70704101:29
*** brinzhang has quit IRC01:35
*** brinzhang has joined #openstack-nova01:35
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-console-output policies  https://review.opendev.org/70704101:36
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies  https://review.opendev.org/70672601:38
openstackgerritGhanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner  https://review.opendev.org/70672701:38
openstackgerritGhanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner  https://review.opendev.org/70672701:39
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies  https://review.opendev.org/70672601:39
*** tosky has quit IRC01:39
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup  https://review.opendev.org/70703801:39
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup  https://review.opendev.org/70703801:40
*** spatel has joined #openstack-nova01:40
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies  https://review.opendev.org/70703901:41
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies  https://review.opendev.org/70703901:45
*** KeithMnemonic1 has quit IRC01:52
*** KeithMnemonic1 has joined #openstack-nova01:53
*** adriant has quit IRC01:53
*** adrianc has quit IRC01:54
*** lbragstad_ has joined #openstack-nova01:54
*** adriant has joined #openstack-nova01:54
*** adrianc has joined #openstack-nova01:54
*** lbragstad has quit IRC01:57
*** owalsh has quit IRC01:58
*** gyee has quit IRC02:00
*** tbachman has joined #openstack-nova02:02
*** owalsh has joined #openstack-nova02:07
*** zhanglong has joined #openstack-nova02:11
*** igordc has joined #openstack-nova02:25
*** abaindur has quit IRC02:27
*** happyhemant has quit IRC02:34
*** brinzhang has quit IRC02:40
*** brinzhang has joined #openstack-nova02:41
*** tetsuro_ has joined #openstack-nova02:44
*** tetsuro has quit IRC02:48
brinzhangdamsmith: as mriedem said in https://review.opendev.org/#/c/694428/4, I think this issue was triggered when I modified the os-instance-actions APIs default policy [1]. I am not particularly familiar with @serialize_args. Can you suggest or submit some fixes?02:48
brinzhangdansmith: [1]https://review.opendev.org/#/c/706470/7, it's functional error report https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_5a7/706179/6/check/openstack-tox-py36/5a7826b/testr_results.html02:50
brinzhangdamsmith: when microversion > 2.51, we can show the instance action events for a server, but now the non-admin can get the ['host', 'traceback'], that should belong to admin role, this validates mriedem's comment.02:53
*** tetsuro has joined #openstack-nova02:54
*** tetsuro_ has quit IRC02:56
openstackgerritnorman shen proposed openstack/nova stable/rocky: Relex python3 version for pep8  https://review.opendev.org/71157702:58
brinzhangdansmith: I was said maybe be not correct, I am not sure they are the same issue, please check.03:10
openstackgerritEric Xie proposed openstack/nova master: Catch exception when use invalid architecture of image  https://review.opendev.org/71136303:18
brinzhangdansmith: bug 1866292 mainly trace for non-admin can get the 'traceback'03:22
openstackbug 1866292 in OpenStack Compute (nova) "non-admin shouldn't get the ['host', 'traceback'] of os-instance-actions's events" [Undecided,New] https://launchpad.net/bugs/186629203:22
openstackgerritMerged openstack/nova stable/train: libvirt: Ignore DiskNotFound during update_available_resource  https://review.opendev.org/71127603:30
openstackgerritBrin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API  https://review.opendev.org/70617903:49
*** brinzhang_ has joined #openstack-nova03:59
*** brinzhang has quit IRC04:02
*** links has joined #openstack-nova04:27
*** sapd1 has quit IRC04:34
*** sapd1 has joined #openstack-nova04:46
*** mkrai has joined #openstack-nova04:52
*** spatel has quit IRC04:53
*** udesale has joined #openstack-nova04:55
*** mkrai has quit IRC05:12
*** dave-mccowan has quit IRC05:17
*** zhanglong has quit IRC05:22
*** zhanglong has joined #openstack-nova05:24
*** abaindur has joined #openstack-nova05:27
*** abaindur has joined #openstack-nova05:27
*** abaindur has quit IRC05:28
*** abaindur has joined #openstack-nova05:29
*** psachin has joined #openstack-nova05:29
*** evrardjp has quit IRC05:35
*** evrardjp has joined #openstack-nova05:35
*** lbragstad_ has quit IRC05:50
*** sapd1 has quit IRC06:01
*** mkrai has joined #openstack-nova06:11
*** sapd1 has joined #openstack-nova06:18
*** udesale_ has joined #openstack-nova06:21
*** udesale has quit IRC06:23
*** udesale has joined #openstack-nova06:28
*** sorrison has quit IRC06:29
*** udesale_ has quit IRC06:29
*** sorrison has joined #openstack-nova06:31
*** links has quit IRC06:32
*** udesale_ has joined #openstack-nova06:33
*** udesale has quit IRC06:35
*** ratailor has joined #openstack-nova06:37
*** igordc has quit IRC06:41
*** links has joined #openstack-nova06:54
*** lpetrut has joined #openstack-nova07:10
*** lpetrut has quit IRC07:11
*** lpetrut has joined #openstack-nova07:11
*** iurygregory has joined #openstack-nova07:18
*** slaweq has joined #openstack-nova07:23
*** maciejjozefczyk has joined #openstack-nova07:50
*** damien_r has joined #openstack-nova07:54
*** tesseract has joined #openstack-nova07:56
*** ccamacho has quit IRC08:09
*** ccamacho has joined #openstack-nova08:09
*** ccamacho has quit IRC08:10
*** ccamacho has joined #openstack-nova08:10
*** ociuhandu has joined #openstack-nova08:17
*** ociuhandu has quit IRC08:27
*** ociuhandu has joined #openstack-nova08:29
*** tkajinam has quit IRC08:29
*** ociuhandu has quit IRC08:34
openstackgerritBalazs Gibizer proposed openstack/nova stable/train: Reproduce bug 1862633  https://review.opendev.org/70916608:37
openstackbug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)08:37
openstackgerritBalazs Gibizer proposed openstack/nova stable/train: Clean up allocation if unshelve fails due to neutron  https://review.opendev.org/70916708:37
gibielod, lyarwood: ^^ updated the commit message on the bottom backport patch as requested08:38
*** amoralej|off is now known as amoralej08:39
*** tosky has joined #openstack-nova08:40
*** dtantsur|afk is now known as dtantsur08:55
lyarwoodgibi: ack done, thanks08:57
lyarwoodelod: https://review.opendev.org/#/c/709167/ LGTM to me also now.08:57
*** rpittau|afk is now known as rpittau08:58
*** tetsuro has quit IRC09:00
*** tetsuro_ has joined #openstack-nova09:01
elodlyarwood: thanks, +W'd :]09:01
*** tetsuro_ has quit IRC09:03
*** _kukacz has joined #openstack-nova09:05
*** happyhemant has joined #openstack-nova09:06
*** _kukacz has quit IRC09:09
*** _kukacz has joined #openstack-nova09:09
gibilyarwood, elod: thanks a bunch09:19
openstackgerritBrin Zhang proposed openstack/nova master: Fix os-volumes-attachments policy to be admin_or_owner  https://review.opendev.org/70995509:19
openstackgerritBrin Zhang proposed openstack/nova master: Add test coverage of existing os-volumes-attachments policies  https://review.opendev.org/70992909:19
openstackgerritBrin Zhang proposed openstack/nova master: Introduce scope_types in os-volumes-attachments policy  https://review.opendev.org/70938809:19
openstackgerritBrin Zhang proposed openstack/nova master: Add new default roles in os-volumes-attachments policies  https://review.opendev.org/71019009:19
openstackgerritBrin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments  https://review.opendev.org/69382809:19
openstackgerritBrin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API  https://review.opendev.org/71119409:19
openstackgerritBrin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API  https://review.opendev.org/71096509:19
*** martinkennelly has joined #openstack-nova09:32
openstackgerritMerged openstack/nova stable/train: Reproduce bug 1862633  https://review.opendev.org/70916609:33
openstackbug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)09:33
*** trident has quit IRC09:34
brinzhang_gibi: Do you have time to check this functional failed? https://review.opendev.org/#/c/706470/09:35
brinzhang_gibi: I am not sure  whether is it a bug, I create a bug in launchpad, for bug 186629209:36
openstackbug 1866292 in OpenStack Compute (nova) "non-admin shouldn't get the ['host', 'traceback'] of os-instance-actions's events" [Undecided,New] https://launchpad.net/bugs/186629209:36
*** trident has joined #openstack-nova09:36
gibibrinzhang_: I will check..09:41
brinzhang_gibi: thanks ^^09:41
*** zhanglong has quit IRC09:48
gibibrinzhang_: I cannot reproduce the issue in devstack with demo user09:57
gibibrinzhang_: http://paste.openstack.org/show/790383/09:57
gibibrinzhang_: so I think it could be a specific problem in the func test en09:57
gibienv09:57
brinzhang_gibi: yes, I was changed it's default policy, I think caused by the new policy09:58
gibiI can pull down your patch in my devstack to see if it changes the behavior09:59
brinzhang_gibi: I debuged in my devstack, and it has the same issue with that CI result09:59
brinzhang_gibi: cool, thanks10:00
openstackgerritJohn Garbutt proposed openstack/nova master: Introduce scope_types in os-aggregates policy  https://review.opendev.org/70165210:02
lyarwooddoes anyone recall where the legacy zuul migration guide lives now? I'm getting 404's for the links I'm finding.10:02
lyarwoodhttps://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html ah ha!10:03
brinzhang_lyarwood: can you provide the old.. cool, let me try10:03
brinzhang_lyarwood: ignore above word^^10:04
lyarwoodbrinzhang_: https://docs.openstack.org/infra/manual/zuulv3.html10:06
lyarwoodbrinzhang_: returns a 404 now10:06
lyarwoodbrinzhang_: still cached by Google apparently10:06
brinzhang_lyarwood: https://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html this is not what would you want to get?10:07
lyarwoodbrinzhang_: yes sorry that's what I was looking for10:08
brinzhang_lyarwood: ^^10:08
*** xek_ has joined #openstack-nova10:09
stephenfinbauzas, gibi: Could you guys close out these remaining nova-network patches today so I can mark the blueprint finished? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/remove-nova-network-ussuri10:12
* bauzas is doing some bug scrubbing but will take a look10:12
*** derekh has joined #openstack-nova10:13
stephenfinthey're mostly removals of code, so should be easy to use10:14
johnthetubaguybrinzhang_: I may have accidentally spotted why your tests are filing for this patch: https://review.opendev.org/#/c/706470/7/nova/policies/instance_actions.py10:15
kashyaplyarwood: Hey, once the fixed libgrypt packages trickle down to distributions, we will eventually deprecate and remove the workaround, yeah? -- https://review.opendev.org/#/c/708030/310:16
brinzhang_johnthetubaguy: let me try..10:16
*** ralonsoh has joined #openstack-nova10:17
lyarwoodkashyap: I'd leave it in place tbh, migration from the workaround is simple and it could be useful if anything like this ever happened again.10:18
lyarwoodkashyap: migration being actual live or cold migration to a host where the workaround is diabled10:18
lyarwooddisabled*10:19
lyarwoodI had an AI to check that we generate the correct XML for the domain in that case but I'm 99.9% sure we would10:19
johnthetubaguystephenfin: is there are reason you don't just delete the squalchmy models, does it break the db migration testing or something?10:21
stephenfinjohnthetubaguy: dansmith told me not to10:21
*** ratailor_ has joined #openstack-nova10:22
stephenfinI chose not to argue :)10:22
*** ratailor has quit IRC10:23
johnthetubaguyso I thought we have to delete the sql alchemy objects before we can drop stuff in the DB a release later, but its been a while since we did that, no totally sure we ever have10:23
brinzhang_johnthetubaguy: no, I removed your point, but it has the same issue, you can see http://paste.openstack.org/show/790386/10:23
stephenfinjohnthetubaguy: I've no idea. FWIW though, this is the same thing I did for the cells v1 removal. I have a separate series up now to remove those models10:25
johnthetubaguystephenfin: sounds like we are being consistent, which is all good10:25
kashyaplyarwood: Yeah, we can leave it in place, but also have to note explicitly that "updating to this new version of libgcrypt"  == you don't need the workaround.10:26
* kashyap back in a few10:26
johnthetubaguybrinzhang_: i suspect the context object getting into your method for an admin call doesn't have the scope in it, or something like that10:29
johnthetubaguybrinzhang_: I think gmann did see some similar errors, but hasn't fixed those yet either10:30
brinzhang_johnthetubaguy: Oh yeah, i didn't pay attention to this, the scope of the context object has a problem, can you know which field it is10:32
johnthetubaguybrinzhang_: try adding the system_scope=all here: https://github.com/openstack/nova/blob/f176ffe6e57e21c4c5d9f33a3c9e47476d10acc9/nova/tests/fixtures.py#L91610:32
johnthetubaguynot totally sure... but I think that is the place10:32
brinzhang_johnthetubaguy: ok, let me try10:32
brinzhang_johnthetubaguy: do you point here https://opendev.org/openstack/nova/src/branch/master/nova/tests/fixtures.py#L916? we can not open github fastly10:38
gibistephenfin: I will try to look at those today10:38
johnthetubaguybrinzhang_: yeah, sorry, that is where I meant, it is created a fake object, line 948 is what that code is matching on10:39
stephenfinThanks. Let me know if anything isn't immediately obvious :)10:39
brinzhang_johnthetubaguy: That changed to "is_admin = user_id == 'admin and system_scope=all'"?10:39
stephenfingibi: Also, all hail the new leader 👑10:39
johnthetubaguyah, no, I think you need to add system_scope='all' into the kwargs when user_id == 'admin'10:39
johnthetubaguybasically, so it looks like we get a new style admin10:40
brinzhang_johnthetubaguy: sure10:40
johnthetubaguy... having said that, it does suggest the deprecation rules are not quite working as expected, I would ask gmann for more info10:41
openstackgerritStephen Finucane proposed openstack/nova master: Use neutronclient's port binding APIs  https://review.opendev.org/70629510:43
*** hoonetorg has quit IRC10:44
brinzhang_johnthetubaguy: it seems not correct, the failed test case is fot non-admin, if we add system_scope='admin' if is_admin=True, that we just change the admin's context, the non-admin context also same as before10:47
brinzhang_and it has the same issue10:47
johnthetubaguyah, OK, I missed that10:47
johnthetubaguycurious10:47
brinzhang_http://paste.openstack.org/show/790390/ this is my change, and the test result alos same before10:47
brinzhang_and I think the if always False.10:48
*** abaindur has quit IRC10:52
*** mkrai has quit IRC10:52
*** _kukacz has quit IRC10:59
*** _kukacz has joined #openstack-nova10:59
*** _kukacz has quit IRC11:02
*** _kukacz has joined #openstack-nova11:02
openstackgerritLee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job  https://review.opendev.org/71160411:05
*** brinzhang has joined #openstack-nova11:12
*** brinzhang__ has joined #openstack-nova11:12
*** brinzhang_ has quit IRC11:13
*** jangutter has joined #openstack-nova11:18
*** martinkennelly has quit IRC11:33
*** rpittau is now known as rpittau|bbl11:36
openstackgerritMerged openstack/nova stable/train: Clean up allocation if unshelve fails due to neutron  https://review.opendev.org/70916711:37
openstackgerritQiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED，shelve the instance failed  https://review.opendev.org/71160911:37
*** tbachman has quit IRC11:43
*** ociuhandu has joined #openstack-nova11:46
openstackgerritJohannes Kulik proposed openstack/nova master: Validate id as integer for os-aggregates  https://review.opendev.org/71021411:46
openstackgerritMerged openstack/nova master: Remove old policy enforcement in attach_interfaces  https://review.opendev.org/70512711:49
openstackgerritMerged openstack/nova master: Add test coverage of existing attach_interfaces policies  https://review.opendev.org/70512611:49
openstackgerritMerged openstack/nova master: Introduce scope_types in os-attach-interfaces  https://review.opendev.org/70579911:50
openstackgerritMerged openstack/nova master: Introduce scope_types in os-console-auth-tokens  https://review.opendev.org/70668811:50
*** N3l1x has joined #openstack-nova11:53
*** brinzhang__ has quit IRC11:53
happyhemantstephenfin: hey hi stephenfin  any idea about spoo checking caus it suppose to be ON.  https://www.irccloud.com/pastebin/FHzoKqNc/11:54
happyhemantstephenfin:  i tried to enable it but this is what am i getting on computes  https://www.irccloud.com/pastebin/weWf4L2z/11:55
happyhemantwhat could be wrong here ?11:55
gibibrinzhang: sorry, I did not see what is wrong with that functional test. I hope johnthetubaguy can help11:57
*** zigo has quit IRC12:02
*** purplerbot has quit IRC12:04
*** Vek has quit IRC12:04
*** irclogbot_3 has quit IRC12:05
*** amotoki has quit IRC12:05
*** aarents has quit IRC12:06
*** aloga has quit IRC12:06
*** aarents has joined #openstack-nova12:07
*** aloga has joined #openstack-nova12:08
*** irclogbot_1 has joined #openstack-nova12:08
*** maciejjozefczyk has quit IRC12:08
*** amotoki has joined #openstack-nova12:09
*** purplerbot has joined #openstack-nova12:10
*** zigo has joined #openstack-nova12:12
*** psachin has quit IRC12:13
*** nicolasbock has joined #openstack-nova12:18
*** maciejjozefczyk has joined #openstack-nova12:22
*** bbowen has joined #openstack-nova12:23
brinzhanggibi: yeah, thanks. I think johnthethubaguy and gmann can help, they may need to talk something of that failed, that when I will join.12:28
*** ratailor_ has quit IRC12:28
*** zigo has quit IRC12:31
*** dtantsur is now known as dtantsur|afk12:33
openstackgerritMerged openstack/nova master: Correct the actual target in os-instance-actions policy  https://review.opendev.org/71041112:44
openstackgerritMerged openstack/nova master: Add test coverage of existing os-instance-actions policies  https://review.opendev.org/70777712:44
openstackgerritMerged openstack/nova master: Introduce scope_types in os-admin-password  https://review.opendev.org/70163012:44
openstackgerritMerged openstack/nova master: Add new default roles in os-admin-password policies  https://review.opendev.org/70163912:45
openstackgerritMerged openstack/nova master: Add a tests to check when legacy access is removed  https://review.opendev.org/71081312:45
openstackgerritMerged openstack/nova master: Add test coverage of existing console_output policies  https://review.opendev.org/70672412:45
*** hoonetorg has joined #openstack-nova12:46
*** zigo has joined #openstack-nova12:50
openstackgerritBrin Zhang proposed openstack/nova master: Introduce scope_types in os-instance-action policy  https://review.opendev.org/70775112:53
brinzhangstephenfin: can you +A again, I was reabseed because of the conflict https://review.opendev.org/#/c/707751/12:55
*** udesale has joined #openstack-nova12:55
openstackgerritBrin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies  https://review.opendev.org/70647012:56
openstackgerritBrin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API  https://review.opendev.org/70617912:56
*** udesale_ has quit IRC12:57
*** psachin has joined #openstack-nova13:03
*** tbachman has joined #openstack-nova13:07
*** ociuhandu has quit IRC13:08
*** ociuhandu has joined #openstack-nova13:08
*** martinkennelly has joined #openstack-nova13:10
*** Luzi has joined #openstack-nova13:11
gibistephenfin: I'm +2 all the way up in the nova-net patches13:13
*** ociuhandu has quit IRC13:15
*** salmankhan has joined #openstack-nova13:16
*** rpittau|bbl is now known as rpittau13:18
*** derekh has quit IRC13:25
*** ociuhandu has joined #openstack-nova13:27
openstackgerritMerged openstack/nova master: Introduce scope_types in os-console-output  https://review.opendev.org/70704013:29
*** spatel has joined #openstack-nova13:30
*** spatel has quit IRC13:30
*** trident has quit IRC13:30
openstackgerritMerged openstack/nova master: Add new default roles in os-console-output policies  https://review.opendev.org/70704113:32
openstackgerritMerged openstack/nova master: Fix os-volumes-attachments policy to be admin_or_owner  https://review.opendev.org/70995513:32
openstackgerritMerged openstack/nova master: Add test coverage of existing os-volumes-attachments policies  https://review.opendev.org/70992913:32
*** trident has joined #openstack-nova13:32
openstackgerritMerged openstack/nova master: Introduce scope_types in os-volumes-attachments policy  https://review.opendev.org/70938813:36
openstackgerritMerged openstack/nova master: Introduce scope_types in os-aggregates policy  https://review.opendev.org/70165213:36
*** abaindur has joined #openstack-nova13:37
*** abaindur has quit IRC13:42
*** vishalmanchanda has quit IRC13:44
*** LiangFang has quit IRC13:45
openstackgerritLee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job  https://review.opendev.org/71160413:48
*** Luzi has quit IRC13:50
gmannbrinzhang: getting coffee. I will check the error. is it instance action one ?13:53
*** mkrai has joined #openstack-nova13:58
*** Vek has joined #openstack-nova14:00
brinzhanggmann: yes, it's the failed patch https://review.opendev.org/#/c/706470/14:02
*** ygk_12345 has joined #openstack-nova14:04
brinzhanggmann: the failed is the non-admin expected response is not match the actual response, and the 'traceback' in the actual response, it's should return when the user is non-admin14:05
brinzhanggmann: thanks for your check.14:05
gmannok14:06
brinzhangjohnthetubaguy: thanks +A for that rebase patch14:06
*** derekh has joined #openstack-nova14:08
kashyapbauzas: stephenfin: Heya, for allocating huge pages, have we already considered the existing libvirt API allocPages()?  (I don't see it in the source from a lazy `grep`)14:10
kashyapDocumentation: https://libvirt.org/html/libvirt-libvirt-host.html#virNodeAllocPages14:10
*** owalsh has quit IRC14:10
*** ygk_12345 has quit IRC14:11
*** psachin has quit IRC14:11
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: Reproduce bug 1862633  https://review.opendev.org/71162614:13
openstackbug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)14:13
bauzaskashyap: good question, I dunno14:16
kashyapbauzas: Okay, I'll make a mental note to explore it.14:17
*** owalsh has joined #openstack-nova14:18
*** lbragstad has joined #openstack-nova14:18
*** nweinber__ has joined #openstack-nova14:21
stephenfinkashyap: What's the context?14:22
*** trident has quit IRC14:22
*** spatel has joined #openstack-nova14:22
kashyapstephenfin: I was triaging a downstream bug, where Nova ends up scheduling a VM to a host w/ insufficient huge pages14:22
kashyapTherefore it fails to start on the dest host with:14:23
kashyap[quote]14:23
kashyapqemu-kvm: -object memory-backend-file,id=ram-node0,prealloc=yes,mem-path=/dev/hugepages/libvirt/qemu/22-instance-00000688,share=yes,size=17179869184,host-nodes=0,policy=bind: unable to map backing store for guest RAM: Cannot allocate memory14:23
kashyap[/quote]14:23
stephenfinkashyap: My guess is that they have something else on the host using hugepages and have configured the reserved hugepages config opt14:23
*** trident has joined #openstack-nova14:24
kashyapstephenfin: So maybe we should get the huge pages usage from the host go from there14:24
kashyap(And also the Nova config attribute you mention)14:24
kashyapThanks for the idea14:24
stephenfinkashyap: '[DEFAULT] reserved_huge_pages', btw14:24
johnthetubaguyI have seen that when the NUMA config was bad, by accident14:25
johnthetubaguyi.e. not enough huge pages on a single numa node, as that is what I implicitly requested14:25
*** mkrai has quit IRC14:25
stephenfinjohnthetubaguy: But we do track hugepages on a per-node basis, right?14:26
stephenfinso there must be something on that node outside of nova consuming those hugepages14:26
stephenfinor our tracking is broken14:26
*** spatel has quit IRC14:27
johnthetubaguyI guess, I thought I saw that for that case too, but I kinda stopped digging for other reasons14:27
kashyapSo, Nova does something bespoke to account for memory?  (/me should read the code)14:27
johnthetubaguyit was a while back mind14:27
kashyapjohnthetubaguy: What do you mean "bad NUMA config"?  What is a "good one", in Nova's parlance?14:27
stephenfinkashyap: Look for references to NUMAPagesTopology14:28
stephenfinwe use that object to do our tracking14:28
johnthetubaguyits more that if you don't specify it, you are requesting a single numa node with all the RAM14:28
johnthetubaguyif you are trying to request the whole node, which is two numa nodes, that is going to fail14:28
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: Clean up allocation if unshelve fails due to neutron  https://review.opendev.org/71162914:29
kashyapstephenfin: Noted; thanks for the pointer.14:29
stephenfinso 64GB RAM from a two node host with exactly 64GB total (32GB per node)?14:29
johnthetubaguyyeah, something like that14:30
stephenfingibi++ Thanks, btw :)14:30
stephenfinbrinzhang: looks like johnthetubaguy beat me to it14:30
johnthetubaguystephenfin: gmann has added some nice extra policy testing for you to take a peak at btw: https://review.opendev.org/#/c/707039/4/nova/tests/unit/policies/test_create_backup.py14:31
*** links has quit IRC14:31
johnthetubaguybasically test what happen after we lift all the deprecations, at some point in the future (or via deployer config)14:32
*** cgoncalves has quit IRC14:32
kashyapstephenfin: Also, isn't it tricky (read: "needs bespoke script") to get the all the mapped huge pages usage by different applications on the host?14:33
gmannbrinzhang: johnthetubaguy seems we passed extra bit of project id here - https://review.opendev.org/#/c/710411/4/nova/api/openstack/compute/instance_actions.py@16614:33
gmannthat rule was admin only and does not need project_id14:33
johnthetubaguygmann: good catch, should by empty dictionary there14:34
*** cgoncalves has joined #openstack-nova14:34
*** iurygregory has quit IRC14:34
johnthetubaguygmann: mind you, the correct project is better than not specifying a target, so still a step forward I guess ;)14:35
kashyapstephenfin: E.g. this short Perl script, which does some huge pages accounting: https://serverfault.com/questions/527085/linux-non-transparent-per-process-hugepage-accounting/644471#64447114:36
gmannjohnthetubaguy: but in that case it can be used as owner also with override in rule14:36
johnthetubaguygmann: ... thinking about that more, if someone wants to make that non-admin (similar issue for live-migration) we will need that back in14:36
johnthetubaguygmann: heh, +1 what you just said, basically14:36
johnthetubaguygmann: this stuff is rock hard14:37
gmannjohnthetubaguy: yeah but it is right or wrong :) ? because we do not allow the same for any other admin only policy14:37
gmannadmin only by default14:37
johnthetubaguywe probably should allow that, for things where it is not strictly a system level thing14:38
*** Liang__ has joined #openstack-nova14:39
johnthetubaguybut, we are getting ahead of ourselves I guess14:39
*** cgoncalves has quit IRC14:39
johnthetubaguythis is about digging out of crazy land, so we can add more options in the future14:39
brinzhanggmann, johnthetubaguy: I change that to the target={}, but it has the same issue, http://paste.openstack.org/show/790395/14:40
*** iurygregory has joined #openstack-nova14:40
johnthetubaguygmann: is brinzhang hitting the same issue you are here: https://review.opendev.org/#/c/70668914:41
johnthetubaguyI am not sure what is causing the problem though :(14:41
gmannjohnthetubaguy: ok, let's go case by case and judge the not-strict-system-cases or upon user request . i will leave instance action also in that catagory14:41
*** cgoncalves has joined #openstack-nova14:41
*** amoralej is now known as amoralej|lunch14:41
johnthetubaguygmann: +114:41
gmannjohnthetubaguy: brinzhang i think i observed some wired things on aggregate policy also  but could not debug those yet. let me debug it14:42
johnthetubaguygmann: +1 thanks14:42
*** ociuhandu has quit IRC14:42
brinzhanggmann: thanks14:42
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: Reproduce bug 1862633  https://review.opendev.org/71162614:43
openstackbug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)14:43
openstackgerritBalazs Gibizer proposed openstack/nova stable/stein: Clean up allocation if unshelve fails due to neutron  https://review.opendev.org/71162914:44
*** udesale has quit IRC14:45
gibistephenfin: would be nice to get a second opinion on https://review.opendev.org/#/c/666245/ It seems to be working but I'm a bit affraid of what this change means on a busy deployment14:46
*** eharney has joined #openstack-nova14:47
*** dave-mccowan has joined #openstack-nova14:53
*** ratailor has joined #openstack-nova14:53
stephenfingibi: ack, will do14:55
mlozaI specificied cpu_models=x86_EPYC-IBRS in nova.conf but I keep getting this error ': Invalid: Config requested a custom CPU model, but no model name was provided'14:56
mlozaThe model exist in /usr/share/libvirt/cpu_map/x86_EPYC-IBRS.xml14:56
mlozaThis is in stable/stein14:57
*** _kukacz has quit IRC14:58
openstackgerritLee Yarwood proposed openstack/nova master: workarounds: Add option to disable native LUKSv1 decryption by QEMU  https://review.opendev.org/70803014:59
openstackgerritLee Yarwood proposed openstack/nova master: workarounds: Connect RBD volumes to the compute host as block devices  https://review.opendev.org/70802914:59
*** owalsh has quit IRC15:00
*** spatel has joined #openstack-nova15:01
*** amoralej|lunch is now known as amoralej15:02
*** ociuhandu has joined #openstack-nova15:16
*** tbachman has quit IRC15:20
*** ociuhandu has quit IRC15:21
*** ociuhandu has joined #openstack-nova15:21
*** lpetrut has quit IRC15:25
johnthetubaguymloza: I think stein only supports the option cpu_model: https://docs.openstack.org/nova/stein/configuration/config.html#libvirt.cpu_model15:28
*** mriedem has joined #openstack-nova15:30
openstackgerritStephen Finucane proposed openstack/nova master: Use neutronclient's port binding APIs  https://review.opendev.org/70629515:33
*** owalsh has joined #openstack-nova15:34
*** maciejjozefczyk_ has joined #openstack-nova15:34
*** maciejjozefczyk has quit IRC15:36
mlozajohnthetubaguy: yeah. I just noticed now. I was checking the latest docs of nova. I didn't know that they renamed cpu_model to cpu_models in the train release15:37
*** brinzhang has quit IRC15:38
*** owalsh has quit IRC15:40
*** ratailor has quit IRC15:41
*** brinzhang has joined #openstack-nova15:41
*** TxGirlGeek has joined #openstack-nova15:43
*** spatel has quit IRC15:45
openstackgerritMerged openstack/nova master: Introduce scope_types in os-instance-action policy  https://review.opendev.org/70775115:47
*** owalsh has joined #openstack-nova15:50
*** bnemec is now known as beekneemech15:53
*** owalsh_ has joined #openstack-nova15:53
*** owalsh- has joined #openstack-nova15:54
stephenfingibi: so what were your specific concerns for https://review.opendev.org/#/c/666245/ ?15:56
*** mriedem has quit IRC15:57
*** owalsh has quit IRC15:57
*** owalsh_ has quit IRC15:58
*** _kukacz has joined #openstack-nova16:08
*** spatel has joined #openstack-nova16:10
*** _kukacz has quit IRC16:11
*** maciejjozefczyk_ has quit IRC16:11
*** _kukacz has joined #openstack-nova16:12
*** _kukacz has quit IRC16:14
*** jaosorior has quit IRC16:14
*** mriedem has joined #openstack-nova16:15
stephenfindansmith: Can this go ahead now? https://review.opendev.org/#/c/708707/ I'm guessing it's blocking the alembic upper-constraint bump (https://review.opendev.org/#/c/708706/)16:15
dansmithI was just looking since I got the review email from you16:15
dansmithI think this had to be tested against the bump,16:16
dansmithand then again against the current version16:16
dansmithso since it's passing now I guess?16:16
dansmithprometheanfire: ^16:16
*** _kukacz has joined #openstack-nova16:16
*** mlavalle has joined #openstack-nova16:18
*** _kukacz has quit IRC16:26
prometheanfirewe talking about the alembic thing?16:27
prometheanfireI'm waiting on nova, so no blocker from me16:27
dansmithprometheanfire: https://review.opendev.org/#/c/708707/416:28
openstackgerritLee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job  https://review.opendev.org/71160416:28
*** gyee has joined #openstack-nova16:29
gibistephenfin: that patch introduces a waitall call for the nova-compute stop codepath. So I can imagine it can change the timing of the nova-compute service restart scenarios in real deployments16:30
stephenfingibi: Yup. There will definitely be knock on effects. That's only for graceful shutdown though, so people could still force things, right?16:31
gibistephenfin: e.g. nova-compute will wait for the all the ongoing instances to boot up before it stops which could take significant time due to e.g. image download16:31
gibiright, tooling can send kill signalls for sure16:31
*** owalsh has joined #openstack-nova16:32
dansmithalso probably long-running periodics, like resource update for lots of ironic nodes16:32
stephenfinIt's not unlimited though. Not by default16:32
stephenfinI checked and graceful_shutdown_timeout defaults to a minute16:32
dansmithno, it's not16:32
dansmithactually, nevermind what I said about the resource update, because that does drop and re-acquire16:33
stephenfinso at worst we're introducing an extra 60 second delay16:33
dansmithstephenfin: where's the 60 second limit?16:33
*** owalsh_ has joined #openstack-nova16:33
stephenfindansmith: https://github.com/openstack/oslo.service/blob/master/oslo_service/_options.py#L5116:34
dansmithis that something the service does?16:34
stephenfinyeah, if this comment is to be believed https://review.opendev.org/#/c/666245/16/nova/compute/manager.py@151116:34
dansmithwhere's the implementation of that though?16:34
*** owalsh| has joined #openstack-nova16:34
dansmithhttps://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L33316:34
dansmithdoes it with sigalrm so should break us out of that otherwise infinite wait16:35
*** damien_r has quit IRC16:35
*** owalsh^ has joined #openstack-nova16:35
*** owalsh- has quit IRC16:35
*** owalsh has quit IRC16:37
gibiOK, so it is really just an extra 60 seconds delay16:37
stephenfinthat's my understanding, yes16:37
stephenfinI think that's reasonable. We have a reno too16:37
gibiI feel better that none of you freaked out about that patch.16:38
*** owalsh_ has quit IRC16:38
dansmithI haven't really reviewed16:38
dansmithcan I have a few minutes?16:38
gibidansmith: sure16:38
gibidansmith: but you already know the basic idea of the patch16:38
dansmithyeah16:38
dansmithwe already have a build semaphore and config for it16:39
dansmiththis would seem to complicate that a bit16:39
*** owalsh| has quit IRC16:39
stephenfinDoes this need a microversion? https://review.opendev.org/#/c/709431/16:40
stephenfintl;dr: We've been using '/hypervisors' in our 'links' pagination field, rather than '/os-hypervisors'16:40
gibistephenfin: I think we don't want API users to opt into a bugfix16:41
stephenfinyes, that's my thinking too16:41
gibithis feels a clear bugfix to me16:41
dansmithgibi: stephenfin: https://review.opendev.org/#/c/666245/1616:42
stephenfinoh, I never even thought of that /o\ good spot16:43
gibidansmith: good catch16:43
dansmiththe change should be small.. just remove the new conf and the old semaphore, wire the group to the old conf16:44
gibiyeah, make sense16:44
gibistephenfin: I'm +2 on the os-hypervisors bugfix16:45
stephenfingibi: Just checked and looks like os-keypairs is also wrong16:46
gibistephenfin: soo you won a bug to fix ;)16:47
gibidansmith: if you are in a reviewing mood then the last pieces of the qos bp needs a second core https://review.opendev.org/#/q/status:open+bp/support-move-ops-with-qos-ports-ussuri16:47
dansmithgibi: I'm in a -1ing mood.. do you want to take that gamble? :D16:48
gibidansmith: if it is as valid -1 as on the graceful shutdown patch then please go ahead16:49
*** ociuhandu_ has joined #openstack-nova16:54
*** ociuhandu has quit IRC16:57
*** ociuhandu_ has quit IRC16:58
openstackgerritStephen Finucane proposed openstack/nova master: Fix os-keypairs pagination links  https://review.opendev.org/71166217:03
openstackgerritStephen Finucane proposed openstack/nova master: trivial: Rename directory for os-keypairs samples  https://review.opendev.org/71166317:03
stephenfingibi: ^17:03
stephenfin(second one's just a nice-to-have)17:03
gibistephenfin: thanks, looking17:03
*** rpittau is now known as rpittau|afk17:04
openstackgerritStephen Finucane proposed openstack/nova stable/train: Fix hypervisors paginted collection_name.  https://review.opendev.org/71166417:04
openstackgerritStephen Finucane proposed openstack/nova stable/train: Fix hypervisors paginted collection_name.  https://review.opendev.org/71166417:05
dansmithgibi: https://review.opendev.org/#/c/705475/4/nova/api/openstack/common.py17:05
*** iurygregory has quit IRC17:05
openstackgerritStephen Finucane proposed openstack/nova stable/stein: Fix hypervisors paginted collection_name.  https://review.opendev.org/71166917:08
openstackgerritStephen Finucane proposed openstack/nova stable/rocky: Fix hypervisors paginted collection_name.  https://review.opendev.org/71167017:08
gibidansmith: so you mean we need a service version bump even without RPC change.17:11
dansmithgibi: you're depending on a behavior change on the compute nodes from the api node.. even though there's not an RPC signature change, you don't know when/if those computes can do what you're asking17:12
gibidansmith: yeah. you are right. without the compute side change the port binding won't be updated during unshelve.17:14
dansmiththis is really *why* we have service version.. the tie to RPC just makes it easier to ensure we can also look up rpc versions for auto pinning17:15
gibidansmith: in theory it would be the goal of the scheduler to select a host during unshelve that is capable of supporting the server with qos port17:16
dansmithyeah, you could enforce it there too, but that seems messy-er17:17
gibidansmith: would it be a compute host capability?17:17
dansmithyou'd basically need a new filter or a trait17:17
dansmithwe're doing the trait approach for cyborg because it's more than just newness that we're looking for17:17
dansmithso yeah, if you want to go that route that's fine, but it'd be a lot simpler to just do the service version :)17:18
gibidansmith: another option is global compute service level check in the api17:18
gibiwhich do seems easier17:18
dansmithyeah, that's what I was suggesting.. gobal check17:18
dansmithmeaning, api keeps it disabled until everything is upgraded, which is the more common way we do this kind of thing17:18
gibiOK. I get it. global check it is17:18
dansmithbasically replace your "return False" with "return $version >= $minimum"17:19
*** martinkennelly has quit IRC17:19
gibiyepp17:19
gibiregarding microversion bump. I think that ship is sailed when we enabled migrate, resize, evac and live migrate support for qos without microversion bump17:20
gibiit would be equally weird to bump now17:21
dansmithack, that's why I didn't -117:24
dansmithI figured there was context I was missing17:24
dansmithand you did say in a comment "if we decide to do so"17:24
dansmithso I figured....you (all) decided17:24
openstackgerritJohn Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit  https://review.opendev.org/61518017:25
gibidansmith: it was the train PTG where we decided to go for the move support without microversion bumps. I made a mistake not change the error messages to not forcast such bum17:26
gibip17:26
gibianyhow I will work on the service level check17:26
dansmithack17:26
gibithanks for the review17:26
*** spatel has quit IRC17:30
*** tbachman has joined #openstack-nova17:34
*** evrardjp has quit IRC17:35
*** evrardjp has joined #openstack-nova17:35
*** artom has quit IRC17:38
openstackgerritLee Yarwood proposed openstack/nova master: WIP images: Make JSON the default output format of calls to qemu-img info  https://review.opendev.org/71167917:38
*** artom has joined #openstack-nova17:38
openstackgerritmelanie witt proposed openstack/nova master: Add logging of ironic driver hash ring to aid in debugging  https://review.opendev.org/71168017:44
melwittdansmith: do you think ^ is a reasonable or did you think lower()ing names in the hash ring is something we should also do?17:47
*** maciejjozefczyk has joined #openstack-nova17:47
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in os-atttach-inerfaces policies  https://review.opendev.org/70667217:48
dansmithmelwitt: I think we probably need to lower() the things we put into the hash ring17:49
dansmithpotentially checking for conflicts that would only arise due to case might be prudent,17:49
dansmithbut I can't imagine differing-only-by-case is anything other than a point of confusion for people17:49
melwittyeah, that's what I was wondering17:50
melwittwondering/thinking17:50
melwittthanks17:50
gmannjohnthetubaguy: brinzhang this is issue, you used same policy rule with two different check_str - https://review.opendev.org/#/c/706470/8/nova/policies/instance_actions.py@3117:54
*** amoralej is now known as amoralej|off17:54
gmannso basically event policy has deprecation of admin_or_owner depends on order it goes in oslo policy17:55
*** tbachman has quit IRC17:59
*** derekh has quit IRC18:00
*** jangutter has quit IRC18:01
*** tbachman has joined #openstack-nova18:08
*** eharney has quit IRC18:12
*** tesseract has quit IRC18:15
*** larainema has quit IRC18:16
*** maciejjozefczyk has quit IRC18:16
*** spatel has joined #openstack-nova18:17
*** spatel has quit IRC18:17
*** spatel has joined #openstack-nova18:17
openstackgerritmelanie witt proposed openstack/nova master: Lowercase ironic driver hash ring hosts and add logging  https://review.opendev.org/71168018:18
melwittdansmith: updated ^18:19
*** igordc has joined #openstack-nova18:20
*** igordc has quit IRC18:20
melwittalso TheJulia or jroll fyi ^18:26
TheJuliamelwitt: I'll take a look after I'm done cooking my wifey some lunch18:27
melwittheh k18:27
*** gmann is now known as gmann_lunch18:27
openstackgerritGhanshyam Mann proposed openstack/nova master: [Trivial] Fix code comment of admin password tests  https://review.opendev.org/71173418:29
*** maciejjozefczyk has joined #openstack-nova18:29
*** gmann_lunch is now known as gmann18:32
*** ralonsoh has quit IRC18:40
*** happyhemant has quit IRC18:40
*** ociuhandu has joined #openstack-nova18:47
*** ociuhandu has quit IRC18:52
jrollmelwitt: nice, thanks19:00
melwittthanks for reviewing!19:00
*** salmankhan has quit IRC19:00
openstackgerritMerged openstack/nova master: Name Enums  https://review.opendev.org/70870719:02
*** eharney has joined #openstack-nova19:09
*** maciejjozefczyk has quit IRC19:15
melwittthanks for the review TheJulia !19:32
TheJuliaSo turns out, someone renaming a conductor would also do some... bad things19:32
TheJuliabut only lock individual machines19:32
*** abaindur has joined #openstack-nova19:39
*** maciejjozefczyk has joined #openstack-nova19:41
melwittTheJulia: good thinkin to go check that19:43
*** nweinber__ has quit IRC19:44
*** abaindur has quit IRC19:44
*** maciejjozefczyk has quit IRC19:44
openstackgerritMerged openstack/nova master: Fix os-create-backup policy to be admin_or_owner  https://review.opendev.org/70672719:50
openstackgerritMerged openstack/nova master: Add test coverage of existing create_backup policies  https://review.opendev.org/70672619:50
openstackgerritMerged openstack/nova master: Introduce scope_types in os-create-backup  https://review.opendev.org/70703819:53
openstackgerritMerged openstack/nova master: Add new default roles in os-create-backup policies  https://review.opendev.org/70703919:53
mlozaHow can I allow member to see the OS-EXT-SRV-ATTR of the instance ?19:56
mlozaNvm. I found it nova policy.json20:06
*** tbachman has quit IRC20:13
*** abaindur has joined #openstack-nova20:16
*** N3l1x has quit IRC20:36
*** spatel has quit IRC20:44
donnydneed to re-create the flavor for multi-numa  - does anyone remember what meta-data was needed for the NFV jobs besides sean-k-mooney20:45
*** ociuhandu has joined #openstack-nova20:55
*** brinzhang has quit IRC21:11
*** dave-mccowan has quit IRC21:11
*** _erlon_ has quit IRC21:11
*** tinwood has quit IRC21:13
*** portdirect has quit IRC21:13
*** StevenK has quit IRC21:13
*** ChanServ has quit IRC21:13
*** melwitt has quit IRC21:13
*** johnsom has quit IRC21:13
*** tonyb[m] has quit IRC21:13
*** f0o has quit IRC21:13
*** kevinz has quit IRC21:13
*** jungleboyj has quit IRC21:13
*** aspiers has quit IRC21:13
*** corvus has quit IRC21:13
*** Hazelesque has quit IRC21:13
*** mugsie has quit IRC21:13
*** Jeffrey4l has quit IRC21:13
*** klindgren has quit IRC21:13
*** jrosser has quit IRC21:13
*** donnyd has quit IRC21:13
*** cz3 has quit IRC21:13
*** fyx has quit IRC21:13
*** knikolla has quit IRC21:13
*** logan- has quit IRC21:13
*** rajinir has quit IRC21:13
*** pas-ha has quit IRC21:13
*** dustinc has quit IRC21:13
*** jroll has quit IRC21:13
*** pots has quit IRC21:13
*** DinaBelova has quit IRC21:13
*** ociuhandu has quit IRC21:13
*** zigo has quit IRC21:13
*** aloga has quit IRC21:13
*** mgariepy has quit IRC21:13
*** mgoddard has quit IRC21:13
*** zzzeek has quit IRC21:13
*** benj_ has quit IRC21:13
*** bhagyashris has quit IRC21:13
*** eandersson has quit IRC21:13
*** amoralej|off has quit IRC21:13
*** asettle has quit IRC21:13
*** ildikov has quit IRC21:13
*** arxcruz|rover has quit IRC21:13
*** spotz has quit IRC21:13
*** kevinbenton has quit IRC21:13
*** nicolasbock has quit IRC21:13
*** bcm has quit IRC21:13
*** awestin1 has quit IRC21:13
*** gmann has quit IRC21:13
*** tristanC has quit IRC21:13
*** smcginnis has quit IRC21:13
*** csatari has quit IRC21:13
*** kukacz has quit IRC21:13
*** cgoncalves has quit IRC21:13
*** lbragstad has quit IRC21:13
*** slaweq has quit IRC21:13
*** kaisers has quit IRC21:13
*** kashyap has quit IRC21:13
*** prometheanfire has quit IRC21:13
*** jhesketh has quit IRC21:13
*** yoctozepto has quit IRC21:13
*** ccstone has quit IRC21:13
*** ioni has quit IRC21:13
*** lifeless has quit IRC21:13
*** dtruong has quit IRC21:13
*** tbarron has quit IRC21:13
*** ianw has quit IRC21:13
*** tobberydberg has quit IRC21:13
*** obre has quit IRC21:13
*** gibi has quit IRC21:13
*** antonym has quit IRC21:13
*** amorin has quit IRC21:13
*** owalsh^ has quit IRC21:13
*** purplerbot has quit IRC21:13
*** irclogbot_1 has quit IRC21:13
*** ccamacho has quit IRC21:13
*** KeithMnemonic1 has quit IRC21:13
*** rnoriega_ has quit IRC21:13
*** efried_gone has quit IRC21:13
*** mvkr has quit IRC21:13
*** johnthetubaguy has quit IRC21:13
*** Corwin_ has quit IRC21:13
*** vesper11 has quit IRC21:13
*** evrardjp has quit IRC21:13
*** luyao has quit IRC21:13
*** CeeMac has quit IRC21:13
*** masayukig has quit IRC21:13
*** dasp has quit IRC21:13
*** raorn has quit IRC21:13
*** arne_wiebalck has quit IRC21:13
*** mnasiadka has quit IRC21:13
*** fungi has quit IRC21:13
*** d34dh0r53 has quit IRC21:13
*** tonyb has quit IRC21:13
*** rm_work has quit IRC21:13
*** ab-a has quit IRC21:13
*** seba has quit IRC21:13
*** Alon_KS has quit IRC21:13
*** abaindur has quit IRC21:13
*** artom has quit IRC21:13
*** mriedem has quit IRC21:13
*** hoonetorg has quit IRC21:13
*** factor has quit IRC21:13
*** toabctl has quit IRC21:13
*** tobiash has quit IRC21:13
*** ircuser-1 has quit IRC21:13
*** elod has quit IRC21:13
*** alex_xu has quit IRC21:13
*** yaawang has quit IRC21:13
*** johanssone has quit IRC21:13
*** ebbex has quit IRC21:13
*** redrobot has quit IRC21:13
*** ganso has quit IRC21:13
*** dansmith has quit IRC21:13
*** jkulik has quit IRC21:13
*** lchabert has quit IRC21:13
*** gryf has quit IRC21:13
*** hemna has quit IRC21:13
*** klippo has quit IRC21:13
*** guilhermesp has quit IRC21:13
*** ericyoung has quit IRC21:13
*** rmk has quit IRC21:13
*** fnordahl has quit IRC21:13
*** gouthamr has quit IRC21:13
*** toanster has quit IRC21:13
*** frickler has quit IRC21:13
*** mordred has quit IRC21:13
*** diconico07 has quit IRC21:13
*** andreaf has quit IRC21:13
*** dtantsur|afk has quit IRC21:13
*** TxGirlGeek has quit IRC21:13
*** tosky has quit IRC21:13
*** sorrison has quit IRC21:13
*** sapd1 has quit IRC21:13
*** adrianc has quit IRC21:13
*** mtreinish has quit IRC21:13
*** lyarwood has quit IRC21:13
*** NostawRm has quit IRC21:13
*** bjolo has quit IRC21:13
*** bauzas has quit IRC21:13
*** etp has quit IRC21:13
*** mlavalle has quit IRC21:13
*** bbowen has quit IRC21:13
*** NobodyCam has quit IRC21:13
*** TheJulia has quit IRC21:13
*** eharney has quit IRC21:13
*** gyee has quit IRC21:13
*** trident has quit IRC21:13
*** amotoki has quit IRC21:13
*** aarents has quit IRC21:13
*** xek_ has quit IRC21:13
*** takamatsu has quit IRC21:13
*** andreykurilin has quit IRC21:13
*** dklyle has quit IRC21:13
*** openstackgerrit has quit IRC21:13
*** lennyb has quit IRC21:13
*** stephenfin has quit IRC21:13
*** beekneemech has quit IRC21:13
*** gary_perkins has quit IRC21:13
*** vdrok has quit IRC21:13
*** jdillaman has quit IRC21:13
*** lucidguy has quit IRC21:13
*** mnaser has quit IRC21:13
*** rpittau|afk has quit IRC21:13
*** coreycb has quit IRC21:13
*** cmurphy has quit IRC21:13
*** ttx has quit IRC21:13
*** Anticimex has quit IRC21:13
*** ociuhandu has joined #openstack-nova21:13
*** abaindur has joined #openstack-nova21:13
*** eharney has joined #openstack-nova21:13
*** artom has joined #openstack-nova21:13
*** evrardjp has joined #openstack-nova21:13
*** owalsh^ has joined #openstack-nova21:13
*** gyee has joined #openstack-nova21:13
*** mlavalle has joined #openstack-nova21:13
*** mriedem has joined #openstack-nova21:13
*** TxGirlGeek has joined #openstack-nova21:13
*** brinzhang has joined #openstack-nova21:13
*** dave-mccowan has joined #openstack-nova21:13
*** cgoncalves has joined #openstack-nova21:13
*** trident has joined #openstack-nova21:13
*** lbragstad has joined #openstack-nova21:13
*** zigo has joined #openstack-nova21:13
*** hoonetorg has joined #openstack-nova21:13
*** bbowen has joined #openstack-nova21:13
*** nicolasbock has joined #openstack-nova21:13
*** purplerbot has joined #openstack-nova21:13
*** amotoki has joined #openstack-nova21:13
*** irclogbot_1 has joined #openstack-nova21:13
*** aloga has joined #openstack-nova21:13
*** aarents has joined #openstack-nova21:13
*** xek_ has joined #openstack-nova21:13
*** tosky has joined #openstack-nova21:13
*** ccamacho has joined #openstack-nova21:13
*** slaweq has joined #openstack-nova21:13
*** sorrison has joined #openstack-nova21:13
*** sapd1 has joined #openstack-nova21:13
*** adrianc has joined #openstack-nova21:13
*** KeithMnemonic1 has joined #openstack-nova21:13
*** kaisers has joined #openstack-nova21:13
*** luyao has joined #openstack-nova21:13
*** mgariepy has joined #openstack-nova21:13
*** kashyap has joined #openstack-nova21:13
*** takamatsu has joined #openstack-nova21:13
*** StevenK has joined #openstack-nova21:13
*** portdirect has joined #openstack-nova21:13
*** tinwood has joined #openstack-nova21:13
*** _erlon_ has joined #openstack-nova21:13
*** andreykurilin has joined #openstack-nova21:13
*** rnoriega_ has joined #openstack-nova21:13
*** efried_gone has joined #openstack-nova21:13
*** factor has joined #openstack-nova21:13
*** mvkr has joined #openstack-nova21:13
*** dklyle has joined #openstack-nova21:13
*** toabctl has joined #openstack-nova21:13
*** CeeMac has joined #openstack-nova21:13
*** mgoddard has joined #openstack-nova21:13
*** openstackgerrit has joined #openstack-nova21:13
*** NobodyCam has joined #openstack-nova21:13
*** vdrok has joined #openstack-nova21:13
*** masayukig has joined #openstack-nova21:13
*** TheJulia has joined #openstack-nova21:13
*** johnthetubaguy has joined #openstack-nova21:13
*** prometheanfire has joined #openstack-nova21:13
*** Corwin_ has joined #openstack-nova21:13
*** klippo has joined #openstack-nova21:13
*** vesper11 has joined #openstack-nova21:13
*** mtreinish has joined #openstack-nova21:13
*** tobiash has joined #openstack-nova21:13
*** ircuser-1 has joined #openstack-nova21:13
*** lyarwood has joined #openstack-nova21:13
*** dasp has joined #openstack-nova21:13
*** ChanServ has joined #openstack-nova21:13
*** elod has joined #openstack-nova21:13
*** lennyb has joined #openstack-nova21:13
*** jdillaman has joined #openstack-nova21:13
*** stephenfin has joined #openstack-nova21:13
*** alex_xu has joined #openstack-nova21:13
*** Anticimex has joined #openstack-nova21:13
*** bauzas has joined #openstack-nova21:13
*** etp has joined #openstack-nova21:13
*** andreaf has joined #openstack-nova21:13
*** dtantsur|afk has joined #openstack-nova21:13
*** rmk has joined #openstack-nova21:13
*** fnordahl has joined #openstack-nova21:13
*** gouthamr has joined #openstack-nova21:13
*** toanster has joined #openstack-nova21:13
*** frickler has joined #openstack-nova21:13
*** dansmith has joined #openstack-nova21:13
*** jkulik has joined #openstack-nova21:13
*** lchabert has joined #openstack-nova21:13
*** gryf has joined #openstack-nova21:13
*** hemna has joined #openstack-nova21:13
*** orwell.freenode.net sets mode: +o ChanServ21:13
*** tonyb has joined #openstack-nova21:13
*** ab-a has joined #openstack-nova21:13
*** rm_work has joined #openstack-nova21:13
*** seba has joined #openstack-nova21:13
*** Alon_KS has joined #openstack-nova21:13
*** ttx has joined #openstack-nova21:13
*** cmurphy has joined #openstack-nova21:13
*** tristanC has joined #openstack-nova21:13
*** smcginnis has joined #openstack-nova21:13
*** csatari has joined #openstack-nova21:13
*** kukacz has joined #openstack-nova21:13
*** ioni has joined #openstack-nova21:13
*** lifeless has joined #openstack-nova21:13
*** dtruong has joined #openstack-nova21:13
*** tbarron has joined #openstack-nova21:13
*** ianw has joined #openstack-nova21:13
*** tobberydberg has joined #openstack-nova21:13
*** obre has joined #openstack-nova21:13
*** gibi has joined #openstack-nova21:13
*** antonym has joined #openstack-nova21:13
*** amorin has joined #openstack-nova21:13
*** ildikov has joined #openstack-nova21:13
*** arxcruz|rover has joined #openstack-nova21:13
*** spotz has joined #openstack-nova21:13
*** kevinbenton has joined #openstack-nova21:13
*** ericyoung has joined #openstack-nova21:13
*** amoralej|off has joined #openstack-nova21:13
*** benj_ has joined #openstack-nova21:13
*** bhagyashris has joined #openstack-nova21:13
*** eandersson has joined #openstack-nova21:13
*** melwitt has joined #openstack-nova21:13
*** johnsom has joined #openstack-nova21:13
*** tonyb[m] has joined #openstack-nova21:13
*** f0o has joined #openstack-nova21:13
*** jungleboyj has joined #openstack-nova21:13
*** aspiers has joined #openstack-nova21:13
*** corvus has joined #openstack-nova21:13
*** Hazelesque has joined #openstack-nova21:13
*** logan- has joined #openstack-nova21:13
*** rajinir has joined #openstack-nova21:13
*** pas-ha has joined #openstack-nova21:13
*** dustinc has joined #openstack-nova21:13
*** jroll has joined #openstack-nova21:13
*** pots has joined #openstack-nova21:13
*** DinaBelova has joined #openstack-nova21:13
*** gmann has joined #openstack-nova21:13
*** knikolla has joined #openstack-nova21:13
*** coreycb has joined #openstack-nova21:13
*** awestin1 has joined #openstack-nova21:13
*** rpittau|afk has joined #openstack-nova21:13
*** fyx has joined #openstack-nova21:13
*** bcm has joined #openstack-nova21:13
*** cz3 has joined #openstack-nova21:13
*** donnyd has joined #openstack-nova21:13
*** jrosser has joined #openstack-nova21:13
*** mnaser has joined #openstack-nova21:13
*** ccstone has joined #openstack-nova21:13
*** d34dh0r53 has joined #openstack-nova21:13
*** gary_perkins has joined #openstack-nova21:13
*** fungi has joined #openstack-nova21:13
*** yoctozepto has joined #openstack-nova21:13
*** kevinz has joined #openstack-nova21:13
*** mnasiadka has joined #openstack-nova21:13
*** guilhermesp has joined #openstack-nova21:13
*** jhesketh has joined #openstack-nova21:13
*** klindgren has joined #openstack-nova21:13
*** zzzeek has joined #openstack-nova21:13
*** arne_wiebalck has joined #openstack-nova21:13
*** Jeffrey4l has joined #openstack-nova21:13
*** diconico07 has joined #openstack-nova21:13
*** asettle has joined #openstack-nova21:13
*** raorn has joined #openstack-nova21:13
*** mordred has joined #openstack-nova21:13
*** ganso has joined #openstack-nova21:13
*** bjolo has joined #openstack-nova21:13
*** redrobot has joined #openstack-nova21:13
*** NostawRm has joined #openstack-nova21:13
*** ebbex has joined #openstack-nova21:13
*** johanssone has joined #openstack-nova21:13
*** yaawang has joined #openstack-nova21:13
*** mugsie has joined #openstack-nova21:13
*** lucidguy has joined #openstack-nova21:13
*** beekneemech has joined #openstack-nova21:13
*** factor has quit IRC21:13
*** factor has joined #openstack-nova21:13
*** factor has quit IRC21:16
*** tbachman has joined #openstack-nova21:16
*** factor has joined #openstack-nova21:16
*** abaindur has quit IRC21:19
*** nicolasbock has quit IRC21:42
*** imacdonn has quit IRC22:05
*** imacdonn has joined #openstack-nova22:05
*** abaindur has joined #openstack-nova22:13
*** mriedem has quit IRC22:15
*** factor has quit IRC22:15
*** abaindur has quit IRC22:32
*** abaindur has joined #openstack-nova22:33
*** xek_ has quit IRC22:37
brinzhanggmann: So https://review.opendev.org/#/c/706470/8/nova/policies/instance_actions.py@29 is why the functional-py36 failed?22:40
*** ociuhandu has quit IRC22:40
*** ociuhandu has joined #openstack-nova22:41
*** spatel has joined #openstack-nova22:41
*** spatel has quit IRC22:42
brinzhanggmann: you are right, thanks.22:44
brinzhanggmann: but I have a question, why we dont need https://review.opendev.org/#/c/706470/8/nova/tests/unit/fake_policy.py@49 this fake policy?22:44
*** ociuhandu has quit IRC22:45
*** jrosser has quit IRC22:51
*** jrosser has joined #openstack-nova22:53
*** igordc has joined #openstack-nova23:17
gmannbrinzhang: it is needed, i am saying that policy should have exist before as that was old policy but somehow we missed23:20
brinzhanggmann: but, if I keep this policy in fake, the functional-py36 failed too(same issue), otherwise it will run success.23:22
brinzhanggmann: that's why I dont understand why I must delete it23:23
gmannbrinzhang: fake policy make all the policy accessible to everyone so that tests can verify the things without worry about right policy allowablecontext23:24
openstackgerritBrin Zhang proposed openstack/nova master: Add new default roles in os-atttach-inerfaces policies  https://review.opendev.org/70667223:24
openstackgerritBrin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies  https://review.opendev.org/70647023:24
gmannyou modified the deprecation stuff also ?23:24
brinzhanggmann: no23:25
brinzhangI rebased on your os-attach-interfaces patch23:26
gmannok, let's fix all those comments and then it should pass23:26
brinzhanggmann: I was updated, you can review again23:27
*** mlavalle has quit IRC23:27
gmannwhat happen is, in your patch where you deprecated wrong policy rule, event policy is deprecated with admin_or_owner and so does non-admin was able to access the traceback of events23:27
brinzhanggmann: I want to separate the GET interface, do you agree?23:28
brinzhangadd '**:list' and '***:show' to restrict the list and show API23:29
gmannseparate ?23:29
gmannyeah, that is what i commented on review, we need granularity on those23:29
brinzhangyes, I will follow up this later23:30
brinzhanggmann: thanks, I know what I am confusing question.23:30
gmannohk.23:31
brinzhangI think while johnthetubaguy week up, he will see that run success ^^23:31
openstackgerritmelanie witt proposed openstack/nova master: Lowercase ironic driver hash ring and ignore case in cache  https://review.opendev.org/71168023:32
*** rcernin has joined #openstack-nova23:33
*** TxGirlGeek has quit IRC23:36
*** TxGirlGeek has joined #openstack-nova23:36
*** lbragstad_ has joined #openstack-nova23:46
*** lbragstad has quit IRC23:49
brinzhanggmann: if I granularity on the os-instance-actions GET (list/show) API, does need to add a releasenote?23:49
brinzhanggmann: or you will add realeasenote for refresh default policy topic?23:51
*** tosky has quit IRC23:51
brinzhangI mean, in your end patch, you will summary this topic changes, and add a total realeasenote to record these changes?23:52
« Thursday, 2020-03-05 Index Saturday, 2020-03-07 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!