*** vishalmanchanda has joined #openstack-nova | 00:05 | |
*** tetsuro has joined #openstack-nova | 00:06 | |
*** macz_ has quit IRC | 00:06 | |
*** chenhaw1 has joined #openstack-nova | 00:15 | |
*** chenhaw1 has quit IRC | 00:16 | |
*** tetsuro has quit IRC | 00:18 | |
*** tetsuro has joined #openstack-nova | 00:18 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-volumes-attachments policies https://review.opendev.org/710190 | 00:18 |
---|---|---|
openstackgerrit | Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828 | 00:18 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194 | 00:18 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | 00:18 |
*** tetsuro has quit IRC | 00:21 | |
*** tetsuro has joined #openstack-nova | 00:22 | |
*** dklyle has quit IRC | 00:22 | |
brinzhang_ | johnthethubaguy: Rebased done https://review.opendev.org/#/c/710190/5, thanks | 00:22 |
brinzhang_ | gmann: How about this os-instance-actions failed test case? https://review.opendev.org/#/c/706470/ | 00:24 |
*** ccamacho has joined #openstack-nova | 01:25 | |
*** hongbin has joined #openstack-nova | 01:31 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-volumes-attachments policies https://review.opendev.org/710190 | 01:50 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828 | 01:50 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194 | 01:50 |
openstackgerrit | Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965 | 01:50 |
*** TxGirlGeek has quit IRC | 02:02 | |
*** tbachman_ has joined #openstack-nova | 02:03 | |
*** tbachman has quit IRC | 02:05 | |
*** tbachman_ is now known as tbachman | 02:05 | |
*** happyhemant has quit IRC | 02:05 | |
*** brinzhang_ has quit IRC | 02:14 | |
*** brinzhang_ has joined #openstack-nova | 02:15 | |
*** nicolasbock has joined #openstack-nova | 02:26 | |
*** zhanglong has joined #openstack-nova | 02:29 | |
*** yaawang has quit IRC | 02:47 | |
*** tbachman_ has joined #openstack-nova | 02:50 | |
*** yaawang has joined #openstack-nova | 02:50 | |
*** tbachman has quit IRC | 02:51 | |
*** tbachman_ is now known as tbachman | 02:51 | |
openstackgerrit | Merged openstack/nova stable/train: Fix hypervisors paginted collection_name. https://review.opendev.org/711664 | 03:02 |
*** vishalmanchanda has quit IRC | 03:05 | |
*** nicolasbock has quit IRC | 03:06 | |
*** yaawang has quit IRC | 03:07 | |
*** yaawang has joined #openstack-nova | 03:08 | |
*** vishalmanchanda has joined #openstack-nova | 03:31 | |
*** mkrai has joined #openstack-nova | 03:43 | |
*** hongbin has quit IRC | 03:47 | |
*** lbragstad_ has joined #openstack-nova | 03:54 | |
*** rcernin has quit IRC | 04:04 | |
*** rcernin has joined #openstack-nova | 04:04 | |
*** yaawang has quit IRC | 04:28 | |
*** yaawang has joined #openstack-nova | 04:29 | |
*** dave-mccowan has quit IRC | 04:40 | |
*** lbragstad_ has quit IRC | 05:34 | |
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #openstack-nova | 05:35 | |
*** ociuhandu has joined #openstack-nova | 06:07 | |
*** ociuhandu has quit IRC | 06:12 | |
*** links has joined #openstack-nova | 06:15 | |
*** ccstone has quit IRC | 06:23 | |
*** eandersson has quit IRC | 06:23 | |
*** eandersson has joined #openstack-nova | 06:24 | |
*** ccstone has joined #openstack-nova | 06:24 | |
*** mkrai has quit IRC | 06:38 | |
*** udesale has joined #openstack-nova | 06:41 | |
*** dpawlik has joined #openstack-nova | 07:21 | |
*** sapd1 has joined #openstack-nova | 07:23 | |
*** ociuhandu has joined #openstack-nova | 07:28 | |
*** tetsuro has quit IRC | 07:29 | |
*** ociuhandu has quit IRC | 07:35 | |
*** ccamacho has quit IRC | 07:35 | |
*** ccamacho has joined #openstack-nova | 07:35 | |
*** mkrai has joined #openstack-nova | 07:41 | |
*** tetsuro has joined #openstack-nova | 07:43 | |
*** damien_r has joined #openstack-nova | 07:54 | |
*** slaweq has joined #openstack-nova | 07:56 | |
*** xek_ has joined #openstack-nova | 07:57 | |
*** ociuhandu has joined #openstack-nova | 08:05 | |
*** tkajinam has quit IRC | 08:08 | |
*** tesseract has joined #openstack-nova | 08:11 | |
*** ociuhandu has quit IRC | 08:18 | |
*** tosky has joined #openstack-nova | 08:18 | |
*** yaawang has quit IRC | 08:20 | |
*** yaawang has joined #openstack-nova | 08:21 | |
gibi | lyarwood: thanks for volunteering for the stable liaison role | 08:27 |
*** amoralej|off is now known as amoralej | 08:29 | |
gibi | alex_xu, brinzhang_: looking at the meeting slot ML thread, I see will be discriminated by the 16:00 UTC slot. So I'm thinking about possible solutions for you | 08:31 |
gibi | my current running assumption is to have a single 16:00 UTC meeting slot on every Thrusday | 08:32 |
gibi | and on Thrusday UTC 8:00 or 9:00 have a unofficial office hours for you to have a way to talk about issues you want to bring up on the team meeting | 08:34 |
gibi | this would be like a trial | 08:35 |
gibi | see if it works | 08:35 |
gibi | I will dedicate time on Thursday 8:00 UTC anyhow to myself to update the meeting agenda, so having an office hour like thing at the same time seems appropriate | 08:36 |
brinzhang_ | ok gibi, I will try to participate in 16:00 UTC Thrusday. If I ca n’t catch up, I will check the IRC meeting record. If there are any questions, I will ask at your office time. | 08:41 |
brinzhang_ | Similarly, if there is a problem that needs to be discussed, it will be sent to openstack-nova on Thursday 8: 00UTC or 9: 00UTC | 08:41 |
lyarwood | gibi: np | 08:42 |
gibi | brinzhang_: cool, thanks | 08:43 |
*** rpittau|afk is now known as rpittau | 08:43 | |
*** priteau has joined #openstack-nova | 08:44 | |
*** zhanglong has quit IRC | 08:48 | |
*** ralonsoh has joined #openstack-nova | 08:50 | |
*** ociuhandu has joined #openstack-nova | 08:53 | |
*** ociuhandu has quit IRC | 09:09 | |
*** ygk_12345 has joined #openstack-nova | 09:23 | |
*** martinkennelly has joined #openstack-nova | 09:24 | |
*** ygk_12345 has left #openstack-nova | 09:24 | |
*** priteau has quit IRC | 09:28 | |
*** tetsuro has quit IRC | 09:31 | |
*** sapd1 has quit IRC | 09:39 | |
*** mkrai has quit IRC | 09:46 | |
*** sapd1 has joined #openstack-nova | 09:46 | |
*** derekh has joined #openstack-nova | 09:58 | |
*** udesale has quit IRC | 10:01 | |
*** dtantsur|afk is now known as dtantsur | 10:06 | |
*** gibi has quit IRC | 10:06 | |
*** gibi has joined #openstack-nova | 10:07 | |
*** mkrai has joined #openstack-nova | 10:13 | |
*** ociuhandu has joined #openstack-nova | 10:17 | |
*** tbachman has quit IRC | 10:37 | |
*** mkrai has quit IRC | 11:00 | |
*** zhanglong has joined #openstack-nova | 11:15 | |
*** tkajinam has joined #openstack-nova | 11:15 | |
*** rpittau is now known as rpittau|bbl | 11:16 | |
*** udesale has joined #openstack-nova | 11:25 | |
*** udesale_ has joined #openstack-nova | 11:29 | |
*** udesale has quit IRC | 11:32 | |
*** Luzi has joined #openstack-nova | 11:37 | |
*** tbachman has joined #openstack-nova | 11:38 | |
*** udesale_ has quit IRC | 11:38 | |
*** ociuhandu has quit IRC | 11:40 | |
*** ociuhandu has joined #openstack-nova | 11:40 | |
*** udesale has joined #openstack-nova | 11:41 | |
*** ociuhandu has quit IRC | 11:46 | |
*** udesale has quit IRC | 11:47 | |
*** nicolasbock has joined #openstack-nova | 11:54 | |
*** tbachman has quit IRC | 12:03 | |
*** tbachman has joined #openstack-nova | 12:07 | |
*** tbachman_ has joined #openstack-nova | 12:11 | |
*** tbachman has quit IRC | 12:12 | |
*** tbachman_ is now known as tbachman | 12:12 | |
*** nicolasbock has quit IRC | 12:13 | |
*** sean-k-mooney has joined #openstack-nova | 12:14 | |
sean-k-mooney | gibi: o/ | 12:14 |
sean-k-mooney | gibi: im going to try and take another look at the provider.yaml stuff today and see how much i can get through | 12:14 |
*** nicolasbock has joined #openstack-nova | 12:15 | |
sean-k-mooney | if you have no objection to https://docs.python.org/3/library/functools.html#functools.lru_cache i might swap to using that instead of the module cache. | 12:15 |
gibi | sean-k-mooney: o/ | 12:16 |
gibi | sean-k-mooney: I have no objection | 12:16 |
gibi | sean-k-mooney: ping me if my comments are not clear | 12:16 |
sean-k-mooney | sure will do | 12:16 |
sean-k-mooney | im not sure i fully follow what addtional semantic checks i need to add in the third patch | 12:18 |
sean-k-mooney | well i know we shoudl be deduping providers | 12:19 |
sean-k-mooney | based on by name vs by uuid vs by $COMPUTE_NODE | 12:19 |
sean-k-mooney | i just havent fully loaded enough of the code into my head to fully grapse that yet | 12:20 |
sean-k-mooney | but if i get stuck ill let ye know | 12:20 |
sean-k-mooney | on https://review.opendev.org/#/c/676522/41/nova/compute/resource_tracker.py@1730 is the exception for all compute nodes | 12:21 |
gibi | yeah, I think the core comment is about identifying the same provider 3 different ways | 12:21 |
sean-k-mooney | so one thing that confused me a bit is why to we error in that case instead of merging | 12:22 |
sean-k-mooney | e.g. if i do both by name and by uuid | 12:22 |
sean-k-mooney | and add different providers/inventories in each it should be fine right | 12:23 |
gibi | both behavior could be acceptable but I guess the spec said every RP should be mentioned only once | 12:23 |
gibi | let me look i tup | 12:23 |
sean-k-mooney | ok ya well im not going to change it | 12:23 |
sean-k-mooney | no its fine i was just wondering if there was a fundemental reason i missed | 12:24 |
gibi | "In the event that a resource provider is identified by both explicit UUID/NAME and $COMPUTE_NODE, only the UUID/NAME record will be used." | 12:25 |
gibi | https://specs.openstack.org/openstack/nova-specs/specs/ussuri/approved/provider-config-file.html | 12:25 |
sean-k-mooney | right that make sense | 12:25 |
sean-k-mooney | but it does sate what happens if you use both UUID and NAME right | 12:25 |
gibi | I did not found any reference about that case yet | 12:26 |
sean-k-mooney | anyway its not an issue right now. if we want to support that in the future we can | 12:26 |
gibi | "The consuming nova-compute service will error and fail to start if the" | 12:27 |
gibi | # same value is used more than once across all provider configs for name | 12:27 |
gibi | # or uuid. | 12:27 |
sean-k-mooney | ah ok perfect | 12:27 |
sean-k-mooney | im not sure why we chose that but i also dont partically care enough to argure that its too limiting | 12:27 |
*** zhanglong has quit IRC | 12:28 | |
sean-k-mooney | i suspect most people will just use the name | 12:28 |
gibi | yeah, name for computes, uuid for ironic nodes | 12:29 |
*** ociuhandu has joined #openstack-nova | 12:29 | |
sean-k-mooney | isnint the ironic node RP name also the uuid | 12:29 |
sean-k-mooney | the name has to be unique so that what i would have done to make it as simple as possible but uuid for ironic makes sense | 12:30 |
gibi | yes, for ironic name and uuid are the same in placement | 12:31 |
*** happyhemant has joined #openstack-nova | 12:40 | |
openstackgerrit | Merged openstack/nova stable/rocky: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711278 | 12:41 |
*** ociuhandu has quit IRC | 12:43 | |
*** ociuhandu has joined #openstack-nova | 12:44 | |
*** ociuhandu has quit IRC | 12:49 | |
*** rpittau|bbl is now known as rpittau | 12:54 | |
*** eharney has quit IRC | 12:59 | |
*** xek_ is now known as xek | 13:01 | |
*** lbragstad_ has joined #openstack-nova | 13:01 | |
*** lbragstad_ is now known as lbragstad | 13:12 | |
*** lbragstad has quit IRC | 13:13 | |
mordred | smcginnis: https://review.opendev.org/#/c/710214/ | 13:15 |
mordred | smcginnis: that would be the patch that broke that test | 13:16 |
*** lbragstad has joined #openstack-nova | 13:16 | |
*** amoralej is now known as amoralej|lunch | 13:22 | |
mordred | jkulik: https://review.opendev.org/#/c/710214/ caused a behavior change and broke SDK's functional tests | 13:22 |
gibi | mordred: did you depend on the HTTP 500 from nova? or what was the exact behavior change that broke the SDK? | 13:23 |
*** nweinber__ has joined #openstack-nova | 13:24 | |
mordred | the opposite - we were getting NotFound before when trying to delete something by name | 13:24 |
mordred | and now we're getting BadRequest | 13:24 |
mordred | to be fair - there's ALSO a bug in SDK which this has shown | 13:24 |
gibi | can nova do something to help SDK out? the only thing I can imagine is to revert https://review.opendev.org/#/c/710214/ and re-propose it with a microversion bump on the API | 13:25 |
gibi | would that help? | 13:26 |
mordred | which is that we were accepting a name_or_id argument to our delete method and then it looks like we're passing taht straight on - which will never have worked | 13:26 |
mordred | gibi: I'm not sure - I keep going back and forth about whether the behavior change is one of those "someone might break but that person was already broken" times | 13:26 |
gibi | yeah, I'm hesitant too | 13:27 |
mordred | I think the more I talk out loud about it - the more I'm coming to think it's actually all a bug on our side that this just showed | 13:27 |
gibi | if SDK is need to be changed anyhow then I would not jump on the revert | 13:32 |
gibi | but I can be convinced otherwise | 13:33 |
mordred | gibi: yeah - I just pushed up https://review.opendev.org/712068 - we had a layer that was erroneously passing name_or_id. we weren't noticing the change because we trapped for ResourceNotFound and then returned False (saying we didn't delete it) - so we _were_ telling the user it wasn't working ... but we can do better there and delete by name (with a GET first) if they pass us a nane | 13:38 |
*** eharney has joined #openstack-nova | 13:43 | |
*** brinzhang has joined #openstack-nova | 13:44 | |
*** ociuhandu has joined #openstack-nova | 13:44 | |
jkulik | mordred: I'm sorry, that this caused you problems. Any way I could have checked for this? | 13:46 |
mordred | jkulik: well - maybe we should consider running sdk functional tests on nova changes | 13:47 |
mordred | other than that - it was really just uncovering a latent bug on our side - so I think it's a good breakage :) | 13:47 |
brinzhang | gibi, lyarwood: I find some patch always failed by nova-live-migration task, sometimes we recheck it, that it can be passed, but sut still fails | 13:48 |
brinzhang | gibi, lyarwood:such as https://review.opendev.org/#/c/706897/ and https://review.opendev.org/#/c/700072/ | 13:48 |
brinzhang | From their zuul log, I am not find some useful message caused by live migration failed, or I missing something | 13:49 |
brinzhang | I think we should find why it always failed, IMO, that always a hidden danger | 13:50 |
*** dklyle has joined #openstack-nova | 13:51 | |
brinzhang | lyarwood: I saw you want to migrate nova-live-migration job https://review.opendev.org/#/c/711604/3, that can fix this issue? I will check together :) | 13:54 |
*** tbachman has quit IRC | 13:54 | |
openstackgerrit | Monty Taylor proposed openstack/nova master: Run sdk functional tests on nova changes https://review.opendev.org/712092 | 13:57 |
sean-k-mooney | brinzhang: i dont think that lyarwood new job will fix it | 13:57 |
sean-k-mooney | brinzhang: but it will make it less complex | 13:57 |
sean-k-mooney | so that might help us determin why its failing | 13:57 |
mordred | gibi, jkulik, smcginnis: ^^ sake of argument patch to run sdk functional tests over here | 13:58 |
brinzhang | sean-k-mooney: cool, that good | 13:58 |
*** mlavalle has joined #openstack-nova | 13:59 | |
brinzhang | sean-k-mooney: maybe lyarwood wants to migrate this job to zuulv3 | 13:59 |
brinzhang | I remembered he looks for that migrate v3 documents the day before yesterday | 14:00 |
*** Liang__ has quit IRC | 14:00 | |
sean-k-mooney | brinzhang: yes that is what he is doing | 14:01 |
sean-k-mooney | brinzhang: so i was suggesting spliting the job into two 1 for ceph image backend and one for cinder/lvm and qcow block migration | 14:02 |
sean-k-mooney | that will avoid the reconfiguration of the services in the post script and create 2 shorter jobs | 14:02 |
sean-k-mooney | brinzhang: lyarwood was also considering if the evacuation tests should be seperate. or not | 14:03 |
*** dave-mccowan has joined #openstack-nova | 14:03 | |
sean-k-mooney | i think they should stay in the same job | 14:03 |
sean-k-mooney | we should be able to merge the nova-livemiration-ceph job with devstack-plugin-ceph-tempest-py3 | 14:03 |
sean-k-mooney | and just run that multinode with live migration enabled | 14:04 |
*** _mlavalle_1 has joined #openstack-nova | 14:04 | |
brinzhang | sean-k-mooney: yeah, agree | 14:04 |
sean-k-mooney | so ideally the total job cout wont increase and devstack-plugin-ceph-tempest-py3 will just get sligly longer since it will be multi node and and nova-livemigation with cinder/qcow will get shorter | 14:05 |
*** _mlavalle_2 has joined #openstack-nova | 14:05 | |
lyarwood | brinzhang: it isn't going to help stable/pike | 14:05 |
brinzhang | they should stay in the same job, but when find that issue that we can separate it as two job, but finally we should merged | 14:05 |
lyarwood | there's an open bug for the vif plugging issue in master | 14:06 |
sean-k-mooney | lyarwood: there is? | 14:06 |
sean-k-mooney | that sound like something i should proably be aware of | 14:06 |
*** mriedem has joined #openstack-nova | 14:07 | |
*** mlavalle has quit IRC | 14:07 | |
lyarwood | sean-k-mooney: it's an old one, I'll dig it up in a min | 14:07 |
lyarwood | sean-k-mooney: http://status.openstack.org/elastic-recheck/#1813789 | 14:07 |
sean-k-mooney | ah ok | 14:08 |
sean-k-mooney | oh right this si a rache with registering for the event | 14:08 |
sean-k-mooney | *this is a race | 14:08 |
gibi | mordred: I have a meeting in paralle. I will read back later | 14:09 |
lyarwood | brinzhang: for stable/pike we might want to make the LM job NV tbh unless anyone steps up to fix it | 14:09 |
*** _mlavalle_1 has quit IRC | 14:09 | |
brinzhang | lyarwood: Maybe vif plug has some influence, let's take a look | 14:09 |
brinzhang | lyarwood: For stable / pike, I agree with you. | 14:10 |
sean-k-mooney | we skipped this on master https://review.opendev.org/#/c/663405/ | 14:11 |
sean-k-mooney | https://review.opendev.org/#/c/667177/ i think is the final fix | 14:14 |
sean-k-mooney | we went back and fort a few times | 14:14 |
brinzhang | sean-k-mooney: this is in stable/stein, right? so from stable/stein we skip to test the migration | 14:14 |
brinzhang | sean-k-mooney: oh..sorry, that's vif-plug issue | 14:15 |
sean-k-mooney | ya but that should already be on rock too | 14:16 |
sean-k-mooney | https://review.opendev.org/#/c/670648/2 | 14:16 |
dansmith | I wonder if it's time to consider dropping the vmware driver? http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013066.html | 14:17 |
sean-k-mooney | right so ^ is marked as a partial fix for https://bugs.launchpad.net/nova/+bug/1813789 | 14:17 |
openstack | Launchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,In progress] - Assigned to Artom Lifshitz (notartom) | 14:17 |
sean-k-mooney | dansmith: well one devstack failure is proably not enough but if we have no idea how to fix it an no one responds the maybe | 14:18 |
artom | sean-k-mooney, that patch was very specific to revert resize tho | 14:19 |
sean-k-mooney | it would help if they had included the compute agent patch | 14:19 |
dansmith | sean-k-mooney: point being that was a week ago with no answer | 14:19 |
dansmith | sean-k-mooney: and I don't even know who to point them to these days | 14:19 |
sean-k-mooney | artom: yes it was but i think there were other cases too | 14:19 |
artom | sean-k-mooney, yeah, but IIRC those were a different cause? | 14:20 |
sean-k-mooney | dansmith: ya i would say cdent but ya | 14:20 |
artom | I don't think we ever dug into those | 14:20 |
sean-k-mooney | artom: probably i just remember this being really hairy to untangel | 14:20 |
artom | sean-k-mooney, that it as | 14:20 |
dansmith | sean-k-mooney: and no vmware CI reporting lately, that I've seen | 14:20 |
artom | *was | 14:20 |
sean-k-mooney | dansmith: i guess we could propose deprecation if its not fix by ussuring and drop it in Victoria? | 14:21 |
sean-k-mooney | *ussuri | 14:21 |
sean-k-mooney | dansmith: we have to give 1 cycle notice right | 14:22 |
dansmith | sean-k-mooney: yeah, all I mean by "consider dropping" is starting the clock | 14:22 |
sean-k-mooney | ya did we ever follow through on the xen support | 14:23 |
sean-k-mooney | was it xen we talked about one of the other dirvers a few months ago right | 14:23 |
dansmith | yep, it's been deprecated and warning on startup for a while | 14:26 |
dansmith | don't think I've heard anything from anyone | 14:26 |
dansmith | Well, only since september I guess.. maybe that's too soon still | 14:26 |
*** amoralej|lunch is now known as amoralej | 14:28 | |
dansmith | I guess we did merge a trivial log message fix to xenapi in January | 14:28 |
dansmith | hardly indicates heavy usage though :) | 14:28 |
dansmith | quality warning has been in place since May 2019 | 14:29 |
*** nicolasbock has quit IRC | 14:30 | |
dansmith | last actual change was Feb 2019, but from canonical which may or may not indicate actual usage, just a failed test or something | 14:30 |
*** nicolasbock has joined #openstack-nova | 14:31 | |
*** Wellie has joined #openstack-nova | 14:31 | |
*** links has quit IRC | 14:32 | |
*** Luzi has quit IRC | 14:32 | |
lyarwood | stephenfin: https://review.opendev.org/#/c/706900/ - could you hit this again when you have time? | 14:34 |
sean-k-mooney | dansmith: ya well we could always move it out of tree, into a repo in the x namespace and if people care they can use it or step up to support it for xen | 14:35 |
dansmith | -2 on that plan :) | 14:36 |
dansmith | it's in the git tree if they want to find it | 14:36 |
sean-k-mooney | i know you hate out of tree drivers | 14:36 |
sean-k-mooney | well i was wondering should we be removing it form in tree | 14:36 |
sean-k-mooney | i assume that was what you were evenutally proposing for vmware if we start the clock and no one steps up | 14:37 |
mordred | people still use xen? | 14:38 |
*** iurygregory has quit IRC | 14:39 | |
dansmith | mordred: no, that's the point :) | 14:39 |
*** brinzhang has quit IRC | 14:39 | |
dansmith | sean-k-mooney: removing it from the tree does't remove it from the git history and previous releases | 14:39 |
dansmith | sean-k-mooney: and it's likely not working now anyway | 14:40 |
mordred | yeah - I agree with dansmith - it's always there - if new people want to work on it, they can always start with a revert patch reverting the removal | 14:40 |
mordred | doesn't need an x/ repo | 14:41 |
sean-k-mooney | dansmith: oh that is what you ment by it being in git | 14:41 |
sean-k-mooney | dansmith: ok that makes more sense | 14:42 |
sean-k-mooney | mordred: i think one of the issue with the xenserver driver is that it relise on python 2 | 14:42 |
sean-k-mooney | mordred: libvirt/xen does not have that limitaion as far as i am aware but the xen direct driver definetly had issues with python 3 elast year | 14:43 |
*** iurygregory has joined #openstack-nova | 14:43 | |
sean-k-mooney | lyarwood: the privsep discussion has come up a bunch of times. be we did not want to change how we use privsep until we had finished the rootwrap removal | 14:44 |
*** mkrai has joined #openstack-nova | 14:46 | |
sean-k-mooney | lyarwood: the hacking check i was refing too was the one that require you to do "import nova.privsep.x" instead of from nova.privsep import x | 14:47 |
sean-k-mooney | so that when you use a privaldaged function it must be fully spelled out | 14:47 |
lyarwood | sean-k-mooney: kk wasn't aware of the previous discussion then or I've conveniently forgtten them :) | 14:48 |
sean-k-mooney | lyarwood: nova currently only has 1 privsep context which basically give all privladged calls full root permissions | 14:50 |
sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/privsep/__init__.py | 14:50 |
sean-k-mooney | so the way we currently use it provides very little securtiy benifit | 14:50 |
openstackgerrit | Dan Smith proposed openstack/nova master: Deprecate the vmwareapi driver https://review.opendev.org/712101 | 14:50 |
*** tbachman has joined #openstack-nova | 14:51 | |
lyarwood | sean-k-mooney: I can follow up and tighten this up under https://review.opendev.org/#/q/topic:bug/1861071_followups but for the intital bugfix series that I want to backport I'd like to avoid as much churn as possible tbh | 14:52 |
sean-k-mooney | lyarwood: what we should be doing is creating multiple context with a limited set of permission and only granting the permissions that are needed. | 14:52 |
sean-k-mooney | ya that is fair. i think we should be considring this a potential blueprint/work item for victoria at this point | 14:53 |
sean-k-mooney | i would prefer not to propagate more examples of the patteren but i agree wew should not mix this with the bug fix | 14:54 |
lyarwood | sean-k-mooney: kk thanks, I'll try to take a swing at that later this week and tbh that work will bleed into the V release anyway at this point. | 14:56 |
*** _mlavalle_2 has quit IRC | 14:58 | |
*** TxGirlGeek has joined #openstack-nova | 14:58 | |
sean-k-mooney | lyarwood: ya im debating if we should defer it to a dedicated effort | 14:58 |
sean-k-mooney | like the nova-net removal | 14:59 |
lyarwood | sean-k-mooney: ah understood | 15:01 |
mriedem | vmware ci hasn't reported reliably in forever | 15:03 |
dansmith | mriedem: yeah I was going to point out that it doesn't report on this patch as evidence, assuming it doesn't | 15:03 |
dansmith | I haven't seen it report on vmware-touching patches in a while | 15:04 |
mriedem | heh, i haven't seen vmware touching patches in awhile | 15:04 |
dansmith | well, some things that touch all the drivers should have gotten a report | 15:05 |
mriedem | the vmware ci just hasn't worked in a couple of years | 15:06 |
mriedem | i think they got the band together long enough to make it work for the live migration patch because i said i wouldn't +2 it otherwise (and it needed to be multinode and show it passing live migrate) | 15:06 |
mriedem | but after that... | 15:06 |
mriedem | the xen driver was deprecated in train so it's probably too early to drop that in ussuri yeah? V at the earliest i'd think. | 15:06 |
mriedem | since anyone using xen isn't likely upgrading much these days anyway... | 15:07 |
openstackgerrit | Dan Smith proposed openstack/nova master: Deprecate the vmwareapi driver https://review.opendev.org/712101 | 15:09 |
mriedem | i'm happy to give a tenured +2 on ^ though :) | 15:09 |
dansmith | mriedem: yeah I commented on the xenapi driver a little earlier | 15:10 |
dansmith | seems like we should probably wait until V for that, just to be squeaky clean, even though I doubt anyone cares anymore | 15:10 |
mriedem | pep8 pass on that line you had to wrap? | 15:10 |
mriedem | someone will care 1 year after it's already deleted :/ | 15:10 |
mriedem | "care" | 15:11 |
mriedem | dansmith: i think you've got a pep8 error | 15:12 |
mriedem | line too long | 15:12 |
dansmith | mriedem: do I? | 15:12 |
mriedem | it was 79 before | 15:12 |
dansmith | fast8: commands succeeded | 15:12 |
mriedem | oh, well i'll +2 then | 15:13 |
*** ociuhandu has quit IRC | 15:17 | |
*** tkajinam has quit IRC | 15:17 | |
*** ociuhandu has joined #openstack-nova | 15:17 | |
*** ociuhandu has quit IRC | 15:23 | |
*** mkrai has quit IRC | 15:34 | |
*** KeithMnemonic has joined #openstack-nova | 15:38 | |
*** gyee has joined #openstack-nova | 15:43 | |
*** macz_ has joined #openstack-nova | 15:46 | |
*** macz_ has quit IRC | 15:47 | |
*** macz_ has joined #openstack-nova | 15:48 | |
*** ociuhandu has joined #openstack-nova | 15:48 | |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Fix os-keypairs pagination links https://review.opendev.org/711895 | 15:55 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Fix os-keypairs pagination links https://review.opendev.org/711896 | 15:56 |
openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Fix os-keypairs pagination links https://review.opendev.org/711898 | 15:58 |
*** vishalmanchanda has quit IRC | 16:05 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass allocations to virt drivers when resizing https://review.opendev.org/589085 | 16:06 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass allocations to virt drivers when reverting resize https://review.opendev.org/712118 | 16:06 |
*** lbragstad has quit IRC | 16:07 | |
*** lbragstad has joined #openstack-nova | 16:08 | |
*** tbachman has quit IRC | 16:18 | |
*** tbachman has joined #openstack-nova | 16:23 | |
*** damien_r has quit IRC | 16:25 | |
*** aarents has quit IRC | 16:27 | |
*** aarents has joined #openstack-nova | 16:27 | |
*** trident has quit IRC | 16:34 | |
*** trident has joined #openstack-nova | 16:36 | |
stephenfin | lyarwood: dead easy stable patch for you here https://review.opendev.org/711895 | 16:41 |
*** mlavalle has joined #openstack-nova | 16:44 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | 16:48 |
*** tbachman has quit IRC | 16:51 | |
lyarwood | stephenfin: are there many more of these? | 16:58 |
stephenfin | I think that's the only other one | 16:59 |
lyarwood | kk | 16:59 |
stephenfin | it's the only one I could spot anyway | 16:59 |
*** tbachman has joined #openstack-nova | 17:04 | |
*** tbachman_ has joined #openstack-nova | 17:06 | |
*** tesseract has quit IRC | 17:07 | |
*** tbachman has quit IRC | 17:08 | |
*** tbachman_ is now known as tbachman | 17:08 | |
*** rpittau is now known as rpittau|afk | 17:10 | |
*** ociuhandu has quit IRC | 17:10 | |
*** ccamacho has quit IRC | 17:15 | |
openstackgerrit | Monty Taylor proposed openstack/nova master: Run sdk functional tests on nova changes https://review.opendev.org/712092 | 17:33 |
*** evrardjp has quit IRC | 17:35 | |
*** _kukacz has joined #openstack-nova | 17:35 | |
*** evrardjp has joined #openstack-nova | 17:35 | |
*** dtantsur is now known as dtantsur|afk | 17:36 | |
openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | 17:45 |
openstackgerrit | John Garbutt proposed openstack/nova master: Add unified limits configuration https://review.opendev.org/712137 | 17:45 |
openstackgerrit | John Garbutt proposed openstack/nova master: Add tests for the UnifiedLimits quota driver https://review.opendev.org/712138 | 17:45 |
openstackgerrit | John Garbutt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/712139 | 17:45 |
openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Add tests for API using unified limits driver https://review.opendev.org/712140 | 17:45 |
openstackgerrit | John Garbutt proposed openstack/nova master: Make unified limits APIs return reserved of 0 https://review.opendev.org/712141 | 17:45 |
openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce api and db limits https://review.opendev.org/712142 | 17:45 |
openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Update quota_class APIs for db and api limits https://review.opendev.org/712143 | 17:45 |
*** derekh has quit IRC | 18:00 | |
*** trident has quit IRC | 18:08 | |
*** amoralej is now known as amoralej|off | 18:08 | |
*** trident has joined #openstack-nova | 18:18 | |
*** martinkennelly has quit IRC | 18:32 | |
*** factor has joined #openstack-nova | 18:36 | |
*** brinzhang has joined #openstack-nova | 18:51 | |
*** efried has joined #openstack-nova | 18:52 | |
*** efried has quit IRC | 18:54 | |
*** brinzhang_ has quit IRC | 18:54 | |
*** ralonsoh has quit IRC | 19:07 | |
*** eharney has quit IRC | 19:08 | |
*** igordc has joined #openstack-nova | 19:09 | |
*** mugsie has quit IRC | 19:23 | |
*** mugsie has joined #openstack-nova | 19:26 | |
*** openstackgerrit has quit IRC | 19:32 | |
*** nweinber__ has quit IRC | 19:41 | |
*** brinzhang_ has joined #openstack-nova | 19:41 | |
*** brinzhang has quit IRC | 19:45 | |
donnyd | sean-k-mooney: can you kick off a multi-numa job if you have anything that can be - I was hoping to test to make sure it works | 19:54 |
*** lbragstad_ has joined #openstack-nova | 19:55 | |
*** eharney has joined #openstack-nova | 19:56 | |
*** lbragstad has quit IRC | 19:58 | |
sean-k-mooney | donnyd: just rechecked https://review.opendev.org/#/c/708977/ | 19:59 |
*** slaweq has quit IRC | 20:03 | |
sean-k-mooney | donnyd: seams to be working fine http://zuul.openstack.org/stream/a34b85c571ed47db8c4f1a4b2f1a0d82?logfile=console.log | 20:07 |
*** openstackstatus has joined #openstack-nova | 20:19 | |
*** ChanServ sets mode: +v openstackstatus | 20:19 | |
*** tbachman_ has joined #openstack-nova | 20:25 | |
*** tbachman has quit IRC | 20:26 | |
*** brinzhang has joined #openstack-nova | 20:26 | |
*** dave-mccowan has quit IRC | 20:27 | |
*** brinzhang_ has quit IRC | 20:29 | |
*** tbachman_ has quit IRC | 20:30 | |
*** tbachman has joined #openstack-nova | 20:31 | |
*** brinzhang_ has joined #openstack-nova | 20:37 | |
*** brinzhang has quit IRC | 20:40 | |
*** tbachman has quit IRC | 20:40 | |
donnyd | Woot woot | 20:50 |
*** _kukacz has quit IRC | 20:51 | |
*** rcernin has quit IRC | 20:53 | |
*** tbachman has joined #openstack-nova | 21:03 | |
*** xek has quit IRC | 21:07 | |
*** sapd1_x has joined #openstack-nova | 21:09 | |
*** lbragstad_ has quit IRC | 21:11 | |
*** openstackgerrit has joined #openstack-nova | 21:11 | |
openstackgerrit | Monty Taylor proposed openstack/nova master: Run sdk functional tests on nova changes https://review.opendev.org/712092 | 21:11 |
*** sapd1 has quit IRC | 21:13 | |
*** factor has quit IRC | 21:19 | |
*** brinzhang has joined #openstack-nova | 21:22 | |
*** tbachman has quit IRC | 21:25 | |
*** brinzhang_ has quit IRC | 21:26 | |
*** zhanglong has joined #openstack-nova | 21:37 | |
*** ociuhandu has joined #openstack-nova | 21:37 | |
openstackgerrit | Merged openstack/nova stable/stein: Fix hypervisors paginted collection_name. https://review.opendev.org/711669 | 21:54 |
*** mriedem has left #openstack-nova | 22:10 | |
*** tbachman has joined #openstack-nova | 22:11 | |
*** evrardjp has quit IRC | 22:17 | |
*** evrardjp has joined #openstack-nova | 22:18 | |
*** zhanglong has quit IRC | 22:31 | |
*** evrardjp has quit IRC | 22:31 | |
*** evrardjp has joined #openstack-nova | 22:33 | |
*** dpawlik has quit IRC | 22:40 | |
*** ociuhandu has quit IRC | 22:41 | |
*** tkajinam has joined #openstack-nova | 22:53 | |
*** igordc has quit IRC | 22:58 | |
*** lbragstad_ has joined #openstack-nova | 23:00 | |
*** zhanglong has joined #openstack-nova | 23:14 | |
*** lbragstad_ has quit IRC | 23:25 | |
*** rcernin has joined #openstack-nova | 23:26 | |
*** nicolasbock has quit IRC | 23:29 | |
*** zhanglong has quit IRC | 23:32 | |
*** macz_ has quit IRC | 23:35 | |
*** lbragstad_ has joined #openstack-nova | 23:38 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!