| *** mlavalle has quit IRC | 00:00 | |
| *** tetsuro_ has joined #openstack-nova | 00:00 | |
| openstackgerrit | sean mooney proposed openstack/nova master: [WIP] cyborg evacuate support https://review.opendev.org/715326 | 00:00 |
|---|---|---|
| *** kevinz has joined #openstack-nova | 00:03 | |
| *** tetsuro has quit IRC | 00:03 | |
| *** nweinber has joined #openstack-nova | 00:11 | |
| *** nweinber has quit IRC | 00:15 | |
| *** factor has quit IRC | 00:19 | |
| *** factor has joined #openstack-nova | 00:20 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Correct limits policy check_str https://review.opendev.org/715672 | 00:26 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Combine the limits policies in single place https://review.opendev.org/715678 | 00:27 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing limits policies https://review.opendev.org/715674 | 00:27 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in limits policy https://review.opendev.org/715680 | 00:27 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in limits policies https://review.opendev.org/715760 | 00:32 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | 00:32 |
| *** tetsuro has joined #openstack-nova | 00:37 | |
| *** tetsuro_ has quit IRC | 00:40 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-agents policies https://review.opendev.org/701648 | 00:40 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-agents policy https://review.opendev.org/701649 | 00:42 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing hypervisors policies https://review.opendev.org/715029 | 00:42 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-hypervisors https://review.opendev.org/715036 | 00:42 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-hypervisors policies https://review.opendev.org/715071 | 00:48 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-hypervisors policy https://review.opendev.org/715074 | 00:49 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Correct limits policy check_str https://review.opendev.org/715672 | 00:49 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Combine the limits policies in single place https://review.opendev.org/715678 | 00:50 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing limits policies https://review.opendev.org/715674 | 00:50 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in limits policy https://review.opendev.org/715680 | 00:50 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in limits policies https://review.opendev.org/715760 | 00:50 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | 00:50 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in limits policies https://review.opendev.org/715760 | 00:51 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | 00:51 |
| *** tetsuro_ has joined #openstack-nova | 00:52 | |
| *** tetsuro_ has quit IRC | 00:57 | |
| *** macz_ has joined #openstack-nova | 01:00 | |
| *** TxGirlGeek has quit IRC | 01:04 | |
| *** macz_ has quit IRC | 01:05 | |
| *** tetsuro_ has joined #openstack-nova | 01:05 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in lock server policy https://review.opendev.org/716114 | 01:09 |
| *** tetsuro_ has quit IRC | 01:10 | |
| *** Liang__ has joined #openstack-nova | 01:12 | |
| *** luyao has joined #openstack-nova | 01:24 | |
| *** zhanglong has joined #openstack-nova | 01:28 | |
| *** sapd1_y has joined #openstack-nova | 01:29 | |
| *** sapd1 has quit IRC | 01:31 | |
| openstackgerrit | wangjiajing proposed openstack/nova stable/rocky: Perfect unit test of 'test_no_migrations_have_downgrade'. https://review.opendev.org/716118 | 01:40 |
| brinzhang_ | gmann: do you know what the dot in update-dot-volume-attachment-req.json file name? | 01:46 |
| brinzhang_ | I cannot understand 'dot' what does it mean :( | 01:46 |
| gmann | brinzhang_: 'delete_on_termination' | 01:59 |
| brinzhang_ | gmann: maybe, but look like not easy to know | 02:03 |
| *** spatel has joined #openstack-nova | 02:03 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in lock server policies https://review.opendev.org/716122 | 02:15 |
| *** bnemec has quit IRC | 02:19 | |
| *** sapd1 has joined #openstack-nova | 02:20 | |
| *** sapd1_y has quit IRC | 02:21 | |
| *** bnemec has joined #openstack-nova | 02:28 | |
| *** zhenguo_ has joined #openstack-nova | 02:33 | |
| *** macz_ has joined #openstack-nova | 02:49 | |
| openstackgerrit | Merged openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554 | 02:52 |
| *** macz_ has quit IRC | 02:53 | |
| *** hongbin has joined #openstack-nova | 03:00 | |
| *** hongbin has quit IRC | 03:05 | |
| *** mkrai has joined #openstack-nova | 03:10 | |
| *** psachin has joined #openstack-nova | 03:29 | |
| *** threestrands has joined #openstack-nova | 03:39 | |
| *** toabctl has joined #openstack-nova | 03:39 | |
| *** ociuhandu has joined #openstack-nova | 03:43 | |
| *** ociuhandu has quit IRC | 03:48 | |
| *** toabctl has quit IRC | 04:03 | |
| *** toabctl has joined #openstack-nova | 04:07 | |
| *** ccamacho has quit IRC | 04:08 | |
| *** spatel has quit IRC | 04:11 | |
| *** eharney has quit IRC | 04:19 | |
| *** artom has quit IRC | 04:31 | |
| *** eharney has joined #openstack-nova | 04:31 | |
| *** evrardjp has quit IRC | 04:36 | |
| *** evrardjp has joined #openstack-nova | 04:36 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing migrate server policies https://review.opendev.org/716128 | 04:36 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing migrate server policies https://review.opendev.org/716128 | 04:39 |
| *** udesale has joined #openstack-nova | 04:42 | |
| *** zhenguo_ has quit IRC | 04:42 | |
| *** ratailor has joined #openstack-nova | 04:45 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in migrate server https://review.opendev.org/716130 | 04:47 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in migrate server policies https://review.opendev.org/716132 | 04:53 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in migrate server policy https://review.opendev.org/716134 | 04:57 |
| *** tetsuro_ has joined #openstack-nova | 05:04 | |
| *** tetsuro has quit IRC | 05:07 | |
| *** dave-mccowan has joined #openstack-nova | 05:15 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing migrations policies https://review.opendev.org/716136 | 05:17 |
| *** Liang__ is now known as LiangFang | 05:18 | |
| *** links has joined #openstack-nova | 05:29 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in list migrations https://review.opendev.org/716141 | 05:31 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing migrations policies https://review.opendev.org/716136 | 05:31 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in list migrations https://review.opendev.org/716141 | 05:31 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in migrations policies https://review.opendev.org/716145 | 05:38 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in migrations policy https://review.opendev.org/716147 | 05:41 |
| *** mkrai has quit IRC | 05:48 | |
| *** mkrai has joined #openstack-nova | 05:48 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | 06:12 |
| *** dpawlik has joined #openstack-nova | 06:20 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing pause server policies https://review.opendev.org/716161 | 06:20 |
| *** dpawlik has quit IRC | 06:28 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix unpause server policy to be admin_or_owner https://review.opendev.org/716165 | 06:31 |
| *** sapd1_y has joined #openstack-nova | 06:35 | |
| *** sapd1 has quit IRC | 06:38 | |
| *** vishalmanchanda has joined #openstack-nova | 06:39 | |
| *** dklyle has quit IRC | 06:41 | |
| openstackgerrit | Andreas Jaeger proposed openstack/os-vif master: Update hacking for Python3 https://review.opendev.org/715651 | 06:45 |
| *** dpawlik has joined #openstack-nova | 06:47 | |
| *** xek has joined #openstack-nova | 06:49 | |
| openstackgerrit | Andreas Jaeger proposed openstack/nova-specs master: Update hacking for Python3 https://review.opendev.org/715650 | 06:50 |
| *** slaweq has joined #openstack-nova | 07:00 | |
| *** nightmare_unreal has joined #openstack-nova | 07:03 | |
| *** mkrai has quit IRC | 07:13 | |
| *** mkrai has joined #openstack-nova | 07:14 | |
| *** tetsuro_ has quit IRC | 07:15 | |
| *** rpittau|afk is now known as rpittau | 07:17 | |
| *** tesseract has joined #openstack-nova | 07:22 | |
| *** ociuhandu has joined #openstack-nova | 07:24 | |
| *** maciejjozefczyk has joined #openstack-nova | 07:24 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in lock server policies https://review.opendev.org/716122 | 07:25 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing lock server policies https://review.opendev.org/716057 | 07:28 |
| *** iurygregory has quit IRC | 07:28 | |
| *** ociuhandu has quit IRC | 07:29 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in lock server policy https://review.opendev.org/716114 | 07:29 |
| *** tosky has joined #openstack-nova | 07:29 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in lock server policies https://review.opendev.org/716122 | 07:29 |
| *** iurygregory has joined #openstack-nova | 07:29 | |
| *** sapd1 has joined #openstack-nova | 07:31 | |
| *** sapd1_y has quit IRC | 07:33 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing pause server policies https://review.opendev.org/716161 | 07:36 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227 | 07:40 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726 | 07:40 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | 07:40 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add release notes for Cyborg-Nova integration. https://review.opendev.org/716185 | 07:40 |
| openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186 | 07:40 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in pause server policy https://review.opendev.org/716187 | 07:41 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in pause server policies https://review.opendev.org/716191 | 07:48 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in migrations policies https://review.opendev.org/716145 | 07:54 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in migrations policy https://review.opendev.org/716147 | 07:54 |
| *** ociuhandu has joined #openstack-nova | 07:55 | |
| *** ralonsoh has joined #openstack-nova | 08:02 | |
| *** tetsuro has joined #openstack-nova | 08:07 | |
| brinzhang_ | gibi: hi | 08:11 |
| gibi | brinzhang_: hi | 08:12 |
| gibi | on a meeting, so expect a slower response | 08:12 |
| brinzhang_ | gibi: Now I have time to update the bp/destroy-instance-with-datavolume https://review.opendev.org/#/c/711194/9//COMMIT_MSG@16, with this releasenote name, what have so suggestion? | 08:13 |
| brinzhang_ | gibi: no problem, just a quick question :) | 08:13 |
| gibi | maybe update-delete-on-termination-for-attached-volume | 08:16 |
| brinzhang_ | gibi: I think dansmith's mean is mainly to say separate the update and swap volume policies | 08:17 |
| brinzhang_ | In https://review.opendev.org/#/c/693828/21, we are already have a releasenote fot this change | 08:18 |
| *** yaawang has quit IRC | 08:23 | |
| gibi | ahh | 08:24 |
| *** yaawang has joined #openstack-nova | 08:25 | |
| brinzhang_ | how about separate-upodate-and-swap-volume-policy-for-attachment ? | 08:25 |
| gibi | sounds go (except s/upodate/update/) | 08:26 |
| brinzhang_ | ok, I will create it. | 08:26 |
| *** threestrands has quit IRC | 08:26 | |
| gibi | thanks | 08:28 |
| brinzhang_ | gibi: thanks too. | 08:28 |
| *** zhanglong has quit IRC | 08:33 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Allow PUT volume attachments API to modify delete_on_termination https://review.opendev.org/693828 | 08:34 |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194 | 08:34 |
| *** martinkennelly has joined #openstack-nova | 08:37 | |
| brinzhang_ | damsmith, gmann, gibi: updated the bp/destroy-instance-with-datavolume patch, and there is a question asked by gmann https://review.opendev.org/#/c/693828/21/nova/api/openstack/compute/volumes.py@475, wait dansmith to check, if need to change, that you can update that change to the latest pach | 08:38 |
| *** avolkov has joined #openstack-nova | 08:39 | |
| *** jangutter has joined #openstack-nova | 08:41 | |
| *** hrw has left #openstack-nova | 08:41 | |
| *** jangutter has quit IRC | 08:41 | |
| *** derekh has joined #openstack-nova | 08:42 | |
| *** jangutter has joined #openstack-nova | 08:42 | |
| *** Luzi has joined #openstack-nova | 08:44 | |
| *** zhanglong has joined #openstack-nova | 08:48 | |
| *** ociuhandu has quit IRC | 08:49 | |
| *** ociuhandu has joined #openstack-nova | 08:50 | |
| *** lpetrut has joined #openstack-nova | 08:53 | |
| *** rcernin has quit IRC | 08:54 | |
| *** priteau has joined #openstack-nova | 08:59 | |
| *** dtantsur|afk is now known as dtantsur | 09:00 | |
| gibi | brinzhang_: ack | 09:04 |
| gibi | I'm reviewing the patch now | 09:04 |
| brinzhang_ | gibi: cool, thanks~ | 09:06 |
| *** LiangFang has quit IRC | 09:16 | |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | 09:21 |
| openstackgerrit | Luyao Zhong proposed openstack/nova master: support live migration with vpmem https://review.opendev.org/687856 | 09:21 |
| *** zhanglong has quit IRC | 09:21 | |
| *** zhanglong has joined #openstack-nova | 09:22 | |
| luyao | stephenfin: Hi, stephenfin , thanks for reviewing the first patch, I hope the second patch for vpmem live migration also looks good to you. :) https://review.opendev.org/#/c/687856 | 09:23 |
| *** sapd1_y has joined #openstack-nova | 09:25 | |
| luyao | stephenfin: I haven'ted add release notes for the notification body change in patch https://review.opendev.org/#/c/715362/, if it's better to have I'll add. Thanks for gibi's comments. :) | 09:26 |
| gibi | luyao: don't worry about that I think we never did reno for such change | 09:27 |
| luyao | gibi: OK, get it. :) | 09:27 |
| *** sapd1 has quit IRC | 09:28 | |
| *** sapd1 has joined #openstack-nova | 09:31 | |
| *** sapd1_y has quit IRC | 09:33 | |
| *** priteau has quit IRC | 09:41 | |
| *** sapd1_y has joined #openstack-nova | 09:41 | |
| *** sapd1 has quit IRC | 09:43 | |
| *** zhanglong has quit IRC | 09:45 | |
| *** ociuhandu has quit IRC | 09:46 | |
| *** sapd1 has joined #openstack-nova | 09:47 | |
| *** sapd1_y has quit IRC | 09:48 | |
| *** tetsuro has quit IRC | 09:50 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion 2.85, extra spec validation https://review.opendev.org/708436 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037 | 09:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add support for new cyborg extra specs https://review.opendev.org/716222 | 09:53 |
| *** ociuhandu has joined #openstack-nova | 09:58 | |
| *** rcernin has joined #openstack-nova | 09:59 | |
| *** tesseract has quit IRC | 10:03 | |
| openstackgerrit | Stephen Finucane proposed openstack/os-vif master: trivial: Remove some rules from flake8 ignore list https://review.opendev.org/716223 | 10:07 |
| *** ccamacho has joined #openstack-nova | 10:07 | |
| *** tesseract has joined #openstack-nova | 10:08 | |
| *** yaawang has quit IRC | 10:08 | |
| nightmare_unreal | how to deal with this error msg : This test uses methods that set internal oslo_db state, but it does not claim to use the database. This will conflict with the setup of tests that do use the database and cause failures later. | 10:08 |
| openstackgerrit | Merged openstack/nova-specs master: Update hacking for Python3 https://review.opendev.org/715650 | 10:08 |
| *** ociuhandu has quit IRC | 10:09 | |
| *** yaawang has joined #openstack-nova | 10:09 | |
| *** ociuhandu has joined #openstack-nova | 10:10 | |
| *** rcernin has quit IRC | 10:14 | |
| *** ociuhandu has quit IRC | 10:14 | |
| *** ociuhandu has joined #openstack-nova | 10:14 | |
| openstackgerrit | Andreas Jaeger proposed openstack/python-novaclient master: Update to hacking 3.0 https://review.opendev.org/716228 | 10:20 |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459 | 10:22 |
| *** haleyb has quit IRC | 10:25 | |
| *** amoralej|off has quit IRC | 10:36 | |
| *** rnoriega_ has quit IRC | 10:36 | |
| *** zzzeek has quit IRC | 10:44 | |
| *** zzzeek has joined #openstack-nova | 10:45 | |
| *** rnoriega_ has joined #openstack-nova | 10:51 | |
| *** rpittau is now known as rpittau|bbl | 11:05 | |
| openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459 | 11:06 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in os-agents policies https://review.opendev.org/701648 | 11:11 |
| bauzas | gibi: stephenfin: when you're around, i have a question about a reshape | 11:27 |
| *** sapd1_y has joined #openstack-nova | 11:28 | |
| bauzas | gibi: stephenfin: context is -1 for a reshape https://541e2403478ac154d5eb-056bfb946e355d1a1a86dc411a70c5ec.ssl.cf2.rackcdn.com/715489/1/check/nova-tox-functional-py36/481510f/testr_results.html | 11:30 |
| *** sapd1 has quit IRC | 11:30 | |
| bauzas | but I removed the support | 11:30 |
| *** jangutter has quit IRC | 11:34 | |
| *** psachin has quit IRC | 11:35 | |
| gibi | bauzas: ack. I'm on a meeting. Will ping you after | 11:35 |
| bauzas | cool thanks | 11:35 |
| *** psachin has joined #openstack-nova | 11:36 | |
| bauzas | gibi: stephenfin tl;dr: it's about deleting some upgrade support for Rocky>Stein in https://review.opendev.org/#/c/715489/1/nova/virt/libvirt/driver.py@7008a | 11:37 |
| bauzas | but the reshape functional test won't support it then | 11:37 |
| *** sapd1 has joined #openstack-nova | 11:45 | |
| gibi | brinzhang_, dansmith: the notification sample test failure shows a relevant problem in the new implementation https://review.opendev.org/#/c/693828 | 11:45 |
| *** sapd1_y has quit IRC | 11:48 | |
| *** rnoriega_ has quit IRC | 11:50 | |
| brinzhang_ | gibi: the serverId is in the request path https://review.opendev.org/#/c/693828/22/nova/api/openstack/compute/schemas/volumes.py@100 | 11:52 |
| brinzhang_ | but what is 'id'? | 11:53 |
| gibi | I think id is the attachment id | 11:53 |
| *** psachin has quit IRC | 11:53 | |
| brinzhang_ | PUT /servers/{server_id}/os-volume_attachments/{volume_id} | 11:54 |
| brinzhang_ | gibi: I am not sure the id and serverId does need to add the request body, looks like we dont need that while we update an attachment | 11:55 |
| *** psachin has joined #openstack-nova | 11:55 | |
| kevinz | gibi: can you take a look at this https://review.opendev.org/#/c/714311/ and https://review.opendev.org/712607, those two already get one +2 | 11:55 |
| kevinz | Thanks | 11:55 |
| gibi | brinzhang_: it is about how we define RESTFull | 11:58 |
| gibi | brinzhang_: if we want that the GET response can be sent back as PUT request then we need that the GET rsp matches with the PUT req | 11:59 |
| *** ralonsoh has quit IRC | 11:59 | |
| *** ralonsoh has joined #openstack-nova | 12:00 | |
| gibi | kevinz: ack, I will try | 12:00 |
| kevinz | gibi: Thanks ~ | 12:00 |
| gibi | bauzas: so you think there is a fault in the functional test test_create_servers_with_vgpu ? | 12:02 |
| bauzas | gibi: not really | 12:02 |
| bauzas | gibi: tbc we supported a reshape for Stein | 12:02 |
| bauzas | for Rocky>Stein | 12:02 |
| bauzas | now, we're in Ussuri | 12:02 |
| brinzhang_ | gibi: yeah, as you think it's should keep the same, but we add the tag, device, because swap volume need these parameters, so we should add them in the reqeust body, if we are just update the delete flag for the attachemt, these are invalid, do we need to add these check, such as attachment_id and serverId cannot be changed | 12:02 |
| bauzas | gibi: so I can remove the upgrade support that we created | 12:03 |
| bauzas | gibi: but then, of course the reshape method won't longer work | 12:03 |
| bauzas | gibi: so I should probably remove it too, right? (and the tests) | 12:03 |
| bauzas | but then I think about FFU | 12:03 |
| brinzhang_ | gibi: so form this side, I think they are redundant to add the PUT request body, maybe dansmith have some idea of this. | 12:04 |
| gibi | brinzhang_: let's ask dansmith how serious he want the two json body to match | 12:04 |
| *** ociuhandu has quit IRC | 12:04 | |
| gibi | bauzas: yeah FFU support is a question | 12:04 |
| *** ociuhandu has joined #openstack-nova | 12:04 | |
| *** zzzeek has quit IRC | 12:05 | |
| *** zzzeek has joined #openstack-nova | 12:06 | |
| gibi | bauzas: if we can say that we dont support FFU between Rocky - Ussuri then we can remove the reshape code | 12:06 |
| bauzas | gibi: ... or I would just leave the upgrade support until we agree on that | 12:07 |
| bauzas | gibi: but do we have already some consensus about those kind of questions ? | 12:07 |
| gibi | bauzas: yeah, I think we had the agreement in the past that we keep reshape support for a while | 12:07 |
| bauzas | am I the first folk asking about it ? | 12:07 |
| gibi | bauzas: I think we don't have | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | 12:07 |
| gibi | or at least I dont rememer | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695 | 12:07 |
| bauzas | hum | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696 | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697 | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203 | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | 12:07 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | 12:08 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | 12:08 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | 12:08 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | 12:08 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706 | 12:08 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt: set host CPUs for the mixed instance https://review.opendev.org/714655 | 12:08 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | 12:08 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | 12:08 |
| openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | 12:08 |
| *** rnoriega_ has joined #openstack-nova | 12:08 | |
| gibi | bauzas: I think it is worth to ask the others how they think about it | 12:08 |
| bauzas | gibi: I think we would need to have some policy about it | 12:08 |
| gibi | yeah | 12:08 |
| bauzas | gibi: because before FFU, it was simple | 12:08 |
| gibi | I can imagine that the default policy is not to remove reshape, eer | 12:08 |
| gibi | ever | 12:09 |
| bauzas | gibi: we were just removing upgrade support after one release | 12:09 |
| bauzas | gibi: but now, I no longer know when we should do it | 12:09 |
| *** jangutter has joined #openstack-nova | 12:09 | |
| bauzas | gibi: and like you say, some operators could tell us to just support reshapes for a whole | 12:09 |
| bauzas | if so, uhu | 12:10 |
| *** ociuhandu has quit IRC | 12:10 | |
| brinzhang_ | gibi: http://paste.openstack.org/show/791394/ https://review.opendev.org/#/c/693828/22/nova/tests/functional/api_sample_tests/test_volumes.py@305 | 12:13 |
| brinzhang_ | I debuged in http://paste.openstack.org/show/791394/ | 12:13 |
| *** slaweq has quit IRC | 12:14 | |
| *** jangutter has quit IRC | 12:14 | |
| *** slaweq_ has joined #openstack-nova | 12:14 | |
| *** rpittau|bbl is now known as rpittau | 12:15 | |
| gibi | brinzhang_: what do you mean? | 12:16 |
| gibi | I simply removed the sub and the test still passed. | 12:17 |
| gibi | so the sub is unused | 12:17 |
| brinzhang_ | gibi: yes, it unused | 12:17 |
| *** artom has joined #openstack-nova | 12:17 | |
| *** artom has quit IRC | 12:18 | |
| brinzhang_ | gibi: gibi: when the data volume attached to the server, the delete_on_termination will be set to False by default https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py:_attach_volume() | 12:18 |
| *** artom has joined #openstack-nova | 12:18 | |
| *** mkrai has quit IRC | 12:18 | |
| brinzhang_ | gibi: I think that's why the sub['delete_on_termination'] is unused reason | 12:19 |
| brinzhang_ | https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py#L4505 | 12:20 |
| gibi | brinzhang_: I think the sub is not used as it is not referred in the template update-volume-attachment-delete-flag-req | 12:22 |
| gibi | nova/tests/functional/api_sample_tests/api_samples/os-volumes/v2.85/update-volume-attachment-delete-flag-req.json.tpl | 12:23 |
| brinzhang_ | gibi: you mean we can change ""delete_on_termination": true" to ""delete_on_termination": %(delete_on_termination)s" to resolve this issue? | 12:25 |
| gibi | if you replace the "delete_on_termination": true with "delete_on_termination": "%(delete_on_termination)s" | 12:25 |
| gibi | then the subs will be applied | 12:25 |
| brinzhang_ | yeah, I will try | 12:26 |
| brinzhang_ | gibi: it's true, thanks for you explain ^^ | 12:27 |
| openstackgerrit | Maciej Józefczyk proposed openstack/nova master: [WIP] Respect multiple segments in network https://review.opendev.org/716275 | 12:29 |
| openstackgerrit | Maciej Józefczyk proposed openstack/nova master: [WIP] Respect multiple segments in network https://review.opendev.org/716275 | 12:30 |
| gibi | bauzas: I only found two mentions in the nova doc about FFU | 12:30 |
| bauzas | gibi: I'm writing a ML thread FWIW | 12:31 |
| gibi | $ egrep -e "fast forward|FFU" -R doc/ | 12:31 |
| gibi | doc/source/user/cells.rst: be a gap for other deployment tools. Consider also the FFU case | 12:31 |
| gibi | doc/source/reference/upgrade-checks.rst: fast forward upgrading from Ocata to Rocky, something could have been | 12:32 |
| gibi | bauzas: yeah thanks. | 12:32 |
| gibi | bauzas: one way to remove reshape is to add an upgrade check | 12:33 |
| bauzas | gibi: http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013709.html | 12:35 |
| johnthetubaguy | are we not meant to be able to FFU between *any* release, like gibi said, we are probably just missing an upgrade check | 12:37 |
| bauzas | gibi: mmm, that'd make sense | 12:37 |
| openstackgerrit | Maciej Józefczyk proposed openstack/nova master: [WIP] Respect multiple segments in network https://review.opendev.org/716275 | 12:38 |
| johnthetubaguy | bauzas: can your code be activated without any nova services running? | 12:38 |
| *** udesale_ has joined #openstack-nova | 12:38 | |
| bauzas | gibi: but since reshapes are made automatically when you restart nova-compute in Stein or later, that doesn't need an operator modification | 12:38 |
| bauzas | johnthetubaguy: nope, you need to restart nova-compute, that's the main concern | 12:39 |
| johnthetubaguy | bauzas: in which case we can't remove that code until we have one | 12:39 |
| johnthetubaguy | when we then enforce to be run via an upgrade check | 12:39 |
| gibi | bauzas: we need to make sure that all the compute was started up one during FFU _before_ Ussuri | 12:39 |
| johnthetubaguy | then following release we can drop the code | 12:39 |
| bauzas | and I think we started discussing on this kind of problem, but we haven't had an agreement *yet* | 12:39 |
| gibi | yeah, I don't find any agreement | 12:40 |
| gibi | but the above upgrade check based solution could be a good proposal | 12:40 |
| bauzas | johnthetubaguy: the problem I have with this direction is that usually we write an upgrade check for asking operators to do *something* before upgrading | 12:40 |
| bauzas | johnthetubaguy: in this specific case, what would it be ? restart n-cpu? | 12:40 |
| johnthetubaguy | bauzas: we need to give the operators a way to do something though, we *cannot* requite nova-compute to be started | 12:40 |
| johnthetubaguy | s/requite/require/ | 12:41 |
| *** udesale has quit IRC | 12:41 | |
| johnthetubaguy | at least that was my understanding of the situation | 12:41 |
| bauzas | johnthetubaguy: well, I think we drafted this discussion somewhere sometimes in a PTG and we said it should be a separate module that would be run off nova services | 12:41 |
| bauzas | it, being the reshape codes (with a trailing s, please note) | 12:42 |
| bauzas | but we honestly never designed it | 12:42 |
| sean-k-mooney | johnthetubaguy: requireing n-cpu to be started breaks ffu | 12:42 |
| johnthetubaguy | I was fairly sure it had to be nova-manage, possibly running on each compute node... but yeah I guess we didn't | 12:42 |
| johnthetubaguy | sean-k-mooney: exactly what I am saying, +1 | 12:42 |
| sean-k-mooney | but only if we remove the code before x releases | 12:42 |
| bauzas | and i don't disagree with it | 12:42 |
| sean-k-mooney | e.g. we have to keep the reshape and code for ~3 release if we require you to start the agent | 12:43 |
| bauzas | but given we never thought more about that, we never agreed on *when* and *how* to remove such reshape codes | 12:43 |
| johnthetubaguy | I guess we can't remove the code till we design a way to get rid of it | 12:43 |
| bauzas | agreed | 12:43 |
| johnthetubaguy | cool | 12:44 |
| sean-k-mooney | i think osa and ooo are the only tools that do ffu | 12:44 |
| *** jangutter has joined #openstack-nova | 12:44 | |
| sean-k-mooney | and i think both only support 3 releases max so at most we should need to keep it for 3 releases | 12:44 |
| johnthetubaguy | I kinda got the impression the packages folks were going to adopt it at some point | 12:44 |
| *** zzzeek has quit IRC | 12:44 | |
| sean-k-mooney | ffu | 12:44 |
| bauzas | sean-k-mooney: the problem is that we need to leave this code for 5 releases then | 12:44 |
| johnthetubaguy | yeah | 12:45 |
| sean-k-mooney | honestly i thnk ffu was a mistake to begin with and we should have followed kolla anisbles lead and gone with rolling upgrades | 12:45 |
| *** ociuhandu has joined #openstack-nova | 12:45 | |
| bauzas | ie. we can assume that people could FFU from Train to Victoria or W | 12:45 |
| *** zzzeek has joined #openstack-nova | 12:45 | |
| bauzas | actually, it's a bad example, nevermind | 12:45 |
| sean-k-mooney | for me ffu was a fairly major design mistake | 12:45 |
| bauzas | the worst case scenario is in my case : upgrade from Rocky to Ussuri | 12:46 |
| johnthetubaguy | I think for FFU we basically have to say *any* to *any*, else its pointless | 12:46 |
| johnthetubaguy | well, that or we only care about osa/ooo | 12:46 |
| bauzas | so, at least in my case, Ussuri *has to* support FFU | 12:46 |
| johnthetubaguy | bauzas: are you saying punt the conversation to the PTG? | 12:47 |
| bauzas | I mean, only if we agree on a 3-release time window as a maximum | 12:47 |
| bauzas | johnthetubaguy: I'm saying I'm shooting myself in the foot, yes | 12:47 |
| * gibi needs on a meeting again | 12:47 | |
| johnthetubaguy | heh, I was just checking ;) | 12:47 |
| * gibi needs to be on a meeting again | 12:47 | |
| sean-k-mooney | johnthetubaguy: redhat is moving ore ffu cycle to 2 release by the way | 12:47 |
| bauzas | johnthetubaguy: I have concerns about how the virtual PTG would be productive, but let's be it | 12:48 |
| *** jangutter has quit IRC | 12:48 | |
| johnthetubaguy | it depends how much work folks do ahead of time, it *can* work well, seen that in kolla | 12:48 |
| * bauzas always has to manage his productivity with 2 kids at home and schools closed | 12:48 | |
| sean-k-mooney | so every second release will be an LTS and the plan is to ffu between those, although that plan could change. the first case of this will be train to victorica | 12:48 |
| ebbex | I'm having issues with live-migration on stable/stein, at first neutron was complaining about port_id existing on the target (even though status was inactive), so I removed the port_id in neutron.ml2_port_binding{s,_levels}. Now when trying to migrate I got this stack-trace; http://paste.openstack.org/show/791395/ and a vm_state error. Which databases and tables should I look at to fix this? | 12:49 |
| bauzas | sean-k-mooney: the whole point of FFU is that we don't have *LTS* releases | 12:49 |
| bauzas | every release can be seen as a LTS one | 12:49 |
| sean-k-mooney | bauzas: FFU encurages them | 12:49 |
| bauzas | no | 12:49 |
| sean-k-mooney | yes | 12:49 |
| sean-k-mooney | that is why we have so many people on osp 10 and 13 | 12:49 |
| bauzas | every single user of FFU can just promote any release as an LTS | 12:50 |
| sean-k-mooney | it makes upgrading harder at least with ooo | 12:50 |
| bauzas | sure, for redhat, but what about other FFU users ? | 12:50 |
| sean-k-mooney | its mainly just redhat | 12:50 |
| sean-k-mooney | osa support it | 12:50 |
| bauzas | we provided the tools for this, we can't just say 'heh, it's just redhat' | 12:50 |
| bauzas | hah, jinxed | 12:50 |
| sean-k-mooney | but they can do better upgrades without it | 12:51 |
| johnthetubaguy | I like to think windows 10 adopted the same approach as kolla-ansible (although clearly factually incorrect) | 12:51 |
| bauzas | I just think we entered a rabbit hole | 12:51 |
| bauzas | honestly, we have to be pragmatic and solve the problem that johnthetubaguy stated : n-cpu restart shouldn't be a prereq | 12:52 |
| bauzas | that's it | 12:52 |
| sean-k-mooney | if we dont cap the limit on ffu we can never remove reshape code which i dont think is a resonable constratint | 12:52 |
| bauzas | then we can argue on the tooling we would make | 12:52 |
| johnthetubaguy | the question to ooo and osa, is runing a nova-manage command on every compute node a big deal or not | 12:52 |
| bauzas | sean-k-mooney: if reshape code isn't tied to a specific nova module, I'm fine with it | 12:52 |
| johnthetubaguy | bauzas: does reshape need details from the compute node? | 12:53 |
| johnthetubaguy | I was assuming it does | 12:53 |
| gibi | bauzas: is it expensive to keep the reshape code? | 12:53 |
| sean-k-mooney | johnthetubaguy: in general yes | 12:53 |
| bauzas | johnthetubaguy: you know what ? when we started to draft it, I was even on a stance about a specific other library | 12:53 |
| sean-k-mooney | somethimes that info will be stored in the db but not always | 12:53 |
| johnthetubaguy | could we make operators supply enough enough to not need that info? | 12:53 |
| bauzas | johnthetubaguy: again, the problem is that we haven't designed the expected API between the compute service and the reshape code | 12:53 |
| sean-k-mooney | in the numa case im expecting most of the inf would be in the resouce track numa toplogy blob so it might not need to have acess to the compute node but that depends on if we remove the info form the db or not | 12:54 |
| johnthetubaguy | +1 gibi's question | 12:54 |
| bauzas | I personnally wrote my own reshape code by writing some hard dependencies | 12:54 |
| bauzas | (IIRC, it's even requiring libvirtd to run) | 12:54 |
| johnthetubaguy | sounds like we could write something that we backport to train that fixes this on the api node | 12:55 |
| sean-k-mooney | johnthetubaguy: for the vgpus no | 12:55 |
| johnthetubaguy | well, then we need that info from the operator | 12:55 |
| sean-k-mooney | johnthetubaguy: we dont track those in the db | 12:55 |
| bauzas | I need to look at the reshape spaghetti code for the vgpus | 12:55 |
| bauzas | and see what assumptions I made | 12:55 |
| johnthetubaguy | and we would need something from placement, as its API will not be up? | 12:56 |
| bauzas | johnthetubaguy: we *at least* need placement-api to be up and running | 12:56 |
| johnthetubaguy | not allowed | 12:56 |
| bauzas | yeah I know | 12:56 |
| johnthetubaguy | would need placement-manage to take something | 12:56 |
| bauzas | but that's what we merged | 12:56 |
| johnthetubaguy | yep yep | 12:57 |
| johnthetubaguy | we merged something that violates the rules for FFU | 12:57 |
| bauzas | correct | 12:57 |
| bauzas | well, technically, you need to start n-cpu and placement in Stein | 12:57 |
| bauzas | when you FFU from Rocky to Train | 12:57 |
| bauzas | that's the prereq | 12:57 |
| *** ociuhandu has quit IRC | 12:58 | |
| *** jangutter has joined #openstack-nova | 12:58 | |
| *** jangutter has quit IRC | 12:58 | |
| bauzas | (but honestly, since Ussuri works, you can FFU to Ussuri and do the reshape then) | 12:58 |
| *** dklyle has joined #openstack-nova | 12:58 | |
| johnthetubaguy | sounds like we keep it till at least Z | 12:58 |
| *** ociuhandu has joined #openstack-nova | 12:58 | |
| bauzas | oh yeagh | 12:58 |
| *** jangutter has joined #openstack-nova | 12:58 | |
| bauzas | or we write something to fix that in V | 12:59 |
| sean-k-mooney | i know that ffu in k8s land or rather openshift has stopper versions | 12:59 |
| bauzas | or W | 12:59 |
| johnthetubaguy | sounds like we have better things to do | 12:59 |
| sean-k-mooney | e.g. you can fast forwared but they publish a list of verions you must stop at and start the kublet before continuing | 12:59 |
| johnthetubaguy | sean-k-mooney: they also break their public API most releases | 12:59 |
| sean-k-mooney | that is basically what we have | 12:59 |
| bauzas | the problem is that this little assumption that we could be in non-nested world makes my life on feature development much harder | 12:59 |
| bauzas | which is something I can expose to my management | 13:00 |
| sean-k-mooney | johnthetubaguy: well its technically versioned so you can use the older version but yes | 13:00 |
| bauzas | and say that we need to work on a solution in V or W | 13:00 |
| johnthetubaguy | sean-k-mooney: till they remove it, yep | 13:00 |
| johnthetubaguy | not saying its bad, just different | 13:00 |
| johnthetubaguy | they have a different context | 13:00 |
| johnthetubaguy | sounds like if we wait a few more releases, it will sort its-self out one way or the other | 13:01 |
| sean-k-mooney | yes and no, they have a different approch. we have similar but not idential scopes. they do applciation lifecyle management better and openstack is better sutied to infrastuture | 13:01 |
| johnthetubaguy | like gibi said, maybe the cost isn't that high | 13:01 |
| johnthetubaguy | sean-k-mooney: agreed | 13:02 |
| *** nweinber has joined #openstack-nova | 13:02 | |
| johnthetubaguy | personally, running something on every compute node sounds a lot like starting up n-cpu | 13:02 |
| johnthetubaguy | so really we just shouldn't do that kind of thing | 13:02 |
| sean-k-mooney | well if your calling if FFU | 13:03 |
| sean-k-mooney | i like how kolla-ansible does there upgrades | 13:03 |
| johnthetubaguy | so we need some comprimise where the easy thing (just reshape after upgrade) works for most folks, and the last few folks have some workaround (supply info about the shape of their hosts to some nova-manage) | 13:03 |
| johnthetubaguy | but that's just my take | 13:03 |
| *** ociuhandu has quit IRC | 13:04 | |
| bauzas | gibi: I know you're on a meeting, but do we already have an etherpad for the virtual Victoria PTG ? | 13:04 |
| gibi | bauzas: yes, https://etherpad.openstack.org/p/nova-victoria-ptg | 13:04 |
| *** ociuhandu has joined #openstack-nova | 13:04 | |
| bauzas | thanks | 13:04 |
| sean-k-mooney | gibi: one thing i think we need to plan for are some cross project sessions too | 13:04 |
| gibi | sean-k-mooney: true. Do you have topic for cross-project discussion? | 13:05 |
| sean-k-mooney | not specifcally but i was concerned that that topic had not come up | 13:05 |
| gibi | sean-k-mooney: I think you can simply add that to the current etherpad (just start a new section that indicate that this is a cross project topic that needs anohter team) | 13:05 |
| gibi | you mean people are not thinking about cross project topics because there is no place to put them? | 13:06 |
| sean-k-mooney | ther are things like the unified limits work johnthetubaguy et al are working on that i think needs to continue but i did not really have anything i wanted to drive | 13:06 |
| sean-k-mooney | gibi: i think when we talk about a virtual ptg many teams are just thinking about there team, not the collabative cross team stuff we also do at the ptg | 13:07 |
| gibi | sean-k-mooney: OK, I hope the affected people will propose topics | 13:07 |
| bauzas | that reminds me I have to provide my toughts on two ML threads from gibi | 13:07 |
| gibi | sean-k-mooney: added a Cross project topics section | 13:10 |
| sean-k-mooney | gibi: one topic that comes to mind actully is the schduling supprot for routed networks | 13:11 |
| sean-k-mooney | or network aware schduling in general | 13:11 |
| *** slaweq_ is now known as slaweq | 13:11 | |
| sean-k-mooney | that said im not sure i plan to work on that in the near term so im not going to add it | 13:11 |
| sean-k-mooney | but i know the neuton team are interested in that topic | 13:12 |
| gibi | sean-k-mooney: ack, that is actually one thing I can add as I started looking at that from nova perspective | 13:13 |
| gibi | sean-k-mooney: added one item for routed nets | 13:15 |
| *** ociuhandu has quit IRC | 13:15 | |
| *** ratailor has quit IRC | 13:15 | |
| *** ociuhandu has joined #openstack-nova | 13:16 | |
| sean-k-mooney | gibi: cool, i kind of wrote up how i think it should work in the comment on matts poc | 13:16 |
| sean-k-mooney | but that was more involed then the minium viable change | 13:16 |
| gibi | sean-k-mooney: if you have input then do not hesitate to write it up, I kept that patch on the minimum viable change level but we can agree to do a bigger change in V | 13:17 |
| gibi | sean-k-mooney: my idea was that the current minimum viable patch does not need neutron change | 13:18 |
| sean-k-mooney | unless you are doing sriov nova just assumes that the destination host will be able to support the networking that is requested. this has always been the case and has worked because for the most part ops make there vxlan and vlans span the datacenter but it has never really been a correct assumtion to make. | 13:18 |
| johnthetubaguy | routed networks make the opposite assumption, you usually don't get to pick the IP until you know where has compute resources (unless you are re-using a port, when there are other issues in play). | 13:19 |
| sean-k-mooney | johnthetubaguy: correct and nova currently is not aware of those constraints | 13:20 |
| sean-k-mooney | which is why live migration basially does not work unless you spcify a host in the same segment | 13:20 |
| johnthetubaguy | yeah, only does a safety check | 13:20 |
| *** ociuhandu has quit IRC | 13:21 | |
| sean-k-mooney | my toughts on the topic are partly summerised in https://review.opendev.org/#/c/656885/ in my top comment on 25 of feb | 13:21 |
| johnthetubaguy | live-migration scheduling is an interesting one... I don't really see a use case for it, but I hey. | 13:21 |
| sean-k-mooney | johnthetubaguy: you dont see a usecase for allowing live migration to move the vm to another host in the same network segment where it can keep its ip | 13:22 |
| *** rnoriega_ has quit IRC | 13:22 | |
| johnthetubaguy | operationally, for our customers, its super rare you want it "to go somewhere the scheduler picks", sure we can make up cases where its needed | 13:23 |
| sean-k-mooney | well that is the oppisite feedback we are geting from the neutron folks | 13:23 |
| johnthetubaguy | I think there is a bigger issue there, you want to define live-migratable pools, etc, etc. | 13:24 |
| johnthetubaguy | well I look forward to better understanding those folks use cases | 13:24 |
| sean-k-mooney | johnthetubaguy: yes i tired to adress the more generic case to include vlan awarenes and ip pools modeled in placment in my comment | 13:25 |
| sean-k-mooney | basically using placment aggreates to model pool affinity with sharing resouce providers modelign ip capsity,vlan/vxlan ids(as segmenation_ids) ectra and traits modeling the type of network | 13:26 |
| johnthetubaguy | I still think folks most likely want host aggregate style live-migratable "zones", etc | 13:27 |
| *** brinzhang has joined #openstack-nova | 13:28 | |
| sean-k-mooney | well peole used to use AZs for that to take advandgte of the fact we dont migrate across AZs by defualt | 13:29 |
| gibi | johnthetubaguy, sean-k-mooney: It would be good to get feedback on the use cases I collected as functional tests https://review.opendev.org/#/c/656885/7/nova/tests/functional/test_servers.py and https://review.opendev.org/#/c/711071/1/nova/tests/functional/test_servers.py | 13:30 |
| sean-k-mooney | johnthetubaguy: but that is essically what you would get, the vm would migrate withing the placmenet aggreate with the current poc | 13:30 |
| *** brinzhang_ has quit IRC | 13:31 | |
| sean-k-mooney | e.g. the placment aggreate created by neutron that mapes to the ip segment | 13:31 |
| johnthetubaguy | sean-k-mooney: targeting a placement aggregate rather than a host, with some way of defaulting to the "current" live-migration tagged placement aggregate, would be crazy useful, but its not just network concerns | 13:32 |
| *** rnoriega_ has joined #openstack-nova | 13:32 | |
| *** ociuhandu has joined #openstack-nova | 13:32 | |
| johnthetubaguy | I have a bunch of use cases around that area, but often its independent of xvlan reach, etc. | 13:33 |
| *** macz_ has joined #openstack-nova | 13:38 | |
| *** zzzeek has quit IRC | 13:38 | |
| *** pooja_pf9 has joined #openstack-nova | 13:38 | |
| pooja_pf9 | Hello.. has anyone run into this os-brick issue with multipath failure reported in https://bugs.launchpad.net/nova/+bug/1414527? | 13:39 |
| openstack | Launchpad bug 1414527 in OpenStack Compute (nova) "The multipath device descriptors remove failed when the volume has partition" [Undecided,Confirmed] | 13:39 |
| *** zzzeek has joined #openstack-nova | 13:39 | |
| pooja_pf9 | Is there any known workaround for this issue or plan to fix it in nova? | 13:40 |
| *** macz_ has quit IRC | 13:42 | |
| *** Luzi has quit IRC | 13:54 | |
| huaqiang | stephenfin: my new patches are based on your patches, I haven't changed most of them, but my operations changed the commit hash for most of your pathes, | 13:54 |
| huaqiang | hope it will not trouble you | 13:55 |
| *** bnemec has quit IRC | 14:00 | |
| *** lpetrut has quit IRC | 14:01 | |
| *** lpetrut has joined #openstack-nova | 14:08 | |
| sean-k-mooney | johnthetubaguy: yes it also matters for storage/cinder az and well jsut general falut domains although you can model that via host aggregates | 14:12 |
| * johnthetubaguy nods | 14:12 | |
| dansmith | brinzhang: are you addressing feedback on that patch? | 14:12 |
| *** mkrai has joined #openstack-nova | 14:13 | |
| sean-k-mooney | johnthetubaguy: what i wanted to do was build on the resouce requests in the neutron port and have neutron pass traits and aggreates as constratins via the same mechanisum | 14:13 |
| *** haleyb has joined #openstack-nova | 14:14 | |
| *** bnemec has joined #openstack-nova | 14:16 | |
| johnthetubaguy | sean-k-mooney: sure, it just seems boring compared to the wider use cases | 14:17 |
| artom | Anyone seens https://zuul.opendev.org/t/openstack/build/e0e47deeb33b476db792fd8b83680fbb before? | 14:18 |
| artom | Warning: Permanently added '198.72.124.121' (ECDSA) to the list of known hosts. | 14:18 |
| artom | rsync: link_stat "/var/lib/zuul/builds/e0e47deeb33b476db792fd8b83680fbb/work/ca-bundle.pem" failed: No such file or directory (2) | 14:18 |
| artom | rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1183) [sender=3.1.1] | 14:18 |
| artom | Asking here because... not really sure where Zuul job questions belong | 14:18 |
| artom | I guess I'm doing something wrong in my .zuul.yml | 14:19 |
| *** mriedem has joined #openstack-nova | 14:20 | |
| *** bnemec has quit IRC | 14:22 | |
| sean-k-mooney | no i dont think that is related to your job | 14:22 |
| sean-k-mooney | i think its an issue win one of the other playbooks | 14:22 |
| *** dave-mccowan has quit IRC | 14:23 | |
| *** ociuhandu has quit IRC | 14:24 | |
| *** ociuhandu has joined #openstack-nova | 14:26 | |
| *** zzzeek has quit IRC | 14:28 | |
| *** ociuhandu has quit IRC | 14:31 | |
| *** dave-mccowan has joined #openstack-nova | 14:31 | |
| *** zzzeek has joined #openstack-nova | 14:32 | |
| *** ociuhandu has joined #openstack-nova | 14:35 | |
| *** tetsuro has joined #openstack-nova | 14:36 | |
| artom | sean-k-mooney, inorite? | 14:39 |
| artom | Except it's consistently reproducible | 14:39 |
| *** tetsuro has quit IRC | 14:40 | |
| *** sapd1_y has joined #openstack-nova | 14:43 | |
| *** tkajinam has quit IRC | 14:45 | |
| *** sapd1 has quit IRC | 14:45 | |
| *** spatel has joined #openstack-nova | 14:49 | |
| spatel | sean-k-mooney: is it possible that SR-IOV support security group? (i did google and didn't find any vendor who provide that card/nic) | 14:51 |
| openstackgerrit | Merged openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227 | 14:54 |
| openstackgerrit | Corey Bryant proposed openstack/nova stable/queens: hardware: fix memory check usage for small/large pages https://review.opendev.org/716328 | 14:54 |
| sean-k-mooney | the nics dont in generally but you can sometimes use a heriachical port binding driver to implement security groups at the top of rack switch | 14:54 |
| sean-k-mooney | if your using hardware offloade ovs which use ovs as the contol plane and sriov as the dataplane then it can technically do security groups | 14:55 |
| sean-k-mooney | but normally if you use sriov then no | 14:55 |
| spatel | sean-k-mooney: thanks for the explanation :) | 14:58 |
| *** lbragstad_ has joined #openstack-nova | 15:02 | |
| *** lbragstad has quit IRC | 15:03 | |
| *** macz_ has joined #openstack-nova | 15:03 | |
| *** dave-mccowan has quit IRC | 15:04 | |
| *** pooja_pf9 has quit IRC | 15:06 | |
| openstackgerrit | Merged openstack/python-novaclient master: Update to hacking 3.0 https://review.opendev.org/716228 | 15:12 |
| gibi | sean-k-mooney: do you happen to know if we support booting with UEFI + PXE over IPv6? | 15:14 |
| sean-k-mooney | in ironic? | 15:14 |
| *** spatel has quit IRC | 15:14 | |
| gibi | in nova + libvirt + qemu kvm | 15:15 |
| sean-k-mooney | gibi: i dont think we support pxe boot in nova | 15:15 |
| sean-k-mooney | gibi: i know we can enable the boot menu but i dont think we support pxe booting officaly | 15:15 |
| gibi | thanks | 15:16 |
| *** vishalmanchanda has quit IRC | 15:18 | |
| *** spatel has joined #openstack-nova | 15:22 | |
| *** maciejjozefczyk has quit IRC | 15:36 | |
| *** tesseract has quit IRC | 15:37 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add support for new cyborg extra specs https://review.opendev.org/716222 | 15:38 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion 2.85, extra spec validation https://review.opendev.org/708436 | 15:38 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037 | 15:38 |
| *** vishalmanchanda has joined #openstack-nova | 15:41 | |
| *** avolkov has quit IRC | 15:49 | |
| *** nweinber has quit IRC | 15:51 | |
| *** nweinber has joined #openstack-nova | 15:54 | |
| *** udesale_ has quit IRC | 16:01 | |
| *** rpittau is now known as rpittau|afk | 16:07 | |
| *** jangutter has quit IRC | 16:08 | |
| *** dtantsur is now known as dtantsur|afk | 16:08 | |
| dansmith | gibi: around? | 16:10 |
| gibi | dansmith: yes | 16:11 |
| dansmith | gibi: "doh" and "duh" on the rpc cast, thanks for that | 16:11 |
| *** bnemec has joined #openstack-nova | 16:11 | |
| dansmith | gibi: what do you want to do about it? we can move the non-swap parameter updates before the swap | 16:12 |
| dansmith | which means we'll update those values and then if the swap fails, we will have made part of the changes but not all, but given how swap works, there isn't much choice | 16:12 |
| gibi | hm hm | 16:14 |
| gibi | if changing the order does not mean that we update the d-o-t on the old volume attachment the swap that with a new attachement with default d-o-t then I'm OK with it | 16:15 |
| dansmith | or go back to what I had, which was swap or d-o-t, but not both, although I definitely get the argument that you'd expect to be able to update all at once | 16:15 |
| dansmith | gibi: I think because it looks up the BDM and updates it with the new volume that it should be fine | 16:15 |
| *** eharney has quit IRC | 16:15 | |
| gibi | OK, then I suggest to do the reordeing. If swap fails then we need to accept a partial PUT | 16:16 |
| gibi | as swap is async | 16:16 |
| dansmith | ack | 16:16 |
| dansmith | gibi: by the way, on your comment about the notification test, | 16:16 |
| dansmith | when enabling debug, I did not see the compute manager code logging the messages that should have come out | 16:17 |
| dansmith | so I'm not sure the compute manager code is really running, even though that *seems* to be where the finish notification comes from | 16:17 |
| gibi | with 2.85 you don't as the whole test failed before the compute had a chance to progress with the message | 16:17 |
| dansmith | but I ran out of time trying to trace that down and the logs weren't coming.. | 16:18 |
| dansmith | ahh, that makes sense | 16:18 |
| gibi | yeah, it was not a trivial thing. I spent at least an hour figuring it out why it behaves differently | 16:18 |
| dansmith | the notification stuff is too confusing in general so I didn't trust myself | 16:18 |
| dansmith | and with no logs from compute manager... I tried putting castascall on there, butI got many more errors | 16:19 |
| *** eharney has joined #openstack-nova | 16:19 | |
| dansmith | gibi: can you check my reply here? https://review.opendev.org/#/c/693828/22/nova/api/openstack/compute/schemas/volumes.py | 16:19 |
| gibi | looking | 16:19 |
| *** mlavalle has joined #openstack-nova | 16:20 | |
| gibi | dansmith: you copy the POST req schema, but that is different from the schema of the GET response | 16:21 |
| gibi | if we want that the client GET the current attachment, change a field in it, then PUT it back, then PUT needs to accept the format of the GET response | 16:21 |
| gibi | or did I missunderstood the intention here? | 16:22 |
| dansmith | let me go look for an example of a get | 16:22 |
| *** tobias-urdin has joined #openstack-nova | 16:22 | |
| dansmith | are you saying because volumeAttachments[] vs volumeAttachment ? | 16:23 |
| dansmith | 2.79 GET of a single attachment looks the same to me, no? | 16:23 |
| gibi | it has id in it | 16:24 |
| dansmith | https://docs.openstack.org/api-ref/compute/?expanded=update-server-detail,list-volume-attachments-for-an-instance-detail,show-a-detail-of-a-volume-attachment-detail#show-a-detail-of-a-volume-attachment | 16:24 |
| *** lpetrut has quit IRC | 16:24 | |
| tobias-urdin | doing upgrade testing after upgrade nova-compute throws a RuntimeError: maximum recursion depth exceeded while calling a Python object http://paste.openstack.org/show/791412/ | 16:25 |
| gibi | crate only allows volumeId and device | 16:25 |
| gibi | create | 16:25 |
| dansmith | ah, okay gotcha | 16:25 |
| tobias-urdin | based on traceback i've tried upgrading oslo.db 5.0.2 and oslo.concurrency 3.30.0 (and all other oslo for that matter) but it won't start | 16:25 |
| gibi | you added tag and d-o-t | 16:25 |
| dansmith | I thought you were saying it was structurally quite different or something | 16:25 |
| gibi | I meant we have different amout of fields | 16:25 |
| gibi | structure seems to be the same | 16:26 |
| dansmith | okay I guess I missed serverId although I thought I had it in there | 16:26 |
| gibi | just GET returns extra fields which PUT does not allow | 16:26 |
| dansmith | yep, I see now | 16:26 |
| *** mkrai has quit IRC | 16:26 | |
| gibi | serverId and id (which is the attachment id based on the doc) | 16:27 |
| gmann | dansmith: gibi : should we allow tag update also in this - https://review.opendev.org/#/c/693828/21/nova/api/openstack/compute/volumes.py@475 | 16:31 |
| dansmith | gmann: sorry I should have said something, but I looked into it and it requires an rpc call to update that, so I think we should punt | 16:32 |
| gmann | dansmith: ohk. it's not our DB only things. got it. | 16:33 |
| dansmith | yeah | 16:33 |
| tobias-urdin | anybody has an idea what could be causing the traceback? :) http://paste.openstack.org/show/791412/ | 16:35 |
| *** evrardjp has quit IRC | 16:36 | |
| * gibi leaves for today | 16:36 | |
| *** evrardjp has joined #openstack-nova | 16:36 | |
| *** psachin has quit IRC | 16:50 | |
| *** dustinc has joined #openstack-nova | 17:00 | |
| *** ryneq has quit IRC | 17:00 | |
| *** derekh has quit IRC | 17:02 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove future imports https://review.opendev.org/714675 | 17:07 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/714676 | 17:07 |
| openstackgerrit | Merged openstack/os-vif master: Update hacking for Python3 https://review.opendev.org/715651 | 17:26 |
| *** links has quit IRC | 17:32 | |
| *** ociuhandu has quit IRC | 17:33 | |
| *** ociuhandu has joined #openstack-nova | 17:34 | |
| *** ociuhandu has quit IRC | 17:39 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in lock server policy https://review.opendev.org/716114 | 17:44 |
| sean-k-mooney | stephenfin: didnt efried already sumbit a patch for https://review.opendev.org/#/c/714676/ | 17:47 |
| sean-k-mooney | did he abandon it? | 17:47 |
| sean-k-mooney | stephenfin: https://review.opendev.org/#/c/708262/ | 17:49 |
| sean-k-mooney | stephenfin: it looks like you have fixed import ordering and some other minor thinks so i guess your patch is more complete but you should probably cherry-pick the hacking change ontop of your patch | 17:54 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Allow PUT volume attachments API to modify delete_on_termination https://review.opendev.org/693828 | 18:00 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in lock server policies https://review.opendev.org/716122 | 18:01 |
| *** mgariepy has quit IRC | 18:15 | |
| *** brinzhang_ has joined #openstack-nova | 18:17 | |
| *** brinzhang has quit IRC | 18:20 | |
| *** mgariepy has joined #openstack-nova | 18:21 | |
| *** nightmare_unreal has quit IRC | 18:33 | |
| efried | stephenfin, sean-k-mooney: feel free to take over or abandon mine as needed. | 18:33 |
| efried | but yeah, the hacking change should be included in the series. | 18:33 |
| *** mgariepy has quit IRC | 18:35 | |
| *** martinkennelly has quit IRC | 18:35 | |
| *** ralonsoh has quit IRC | 18:40 | |
| *** mgariepy has joined #openstack-nova | 18:48 | |
| *** d34dh0r53 has quit IRC | 18:56 | |
| openstackgerrit | Corey Bryant proposed openstack/nova stable/queens: hardware: fix memory check usage for small/large pages https://review.opendev.org/716328 | 19:01 |
| openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: libvirt: check for AMD SEV only on x86-64 https://review.opendev.org/714425 | 19:06 |
| stephenfin | sean-k-mooney: Ah, I'd forgotten about that. Will combine | 19:10 |
| *** dustinc has quit IRC | 19:23 | |
| *** iurygregory has quit IRC | 19:27 | |
| *** vishalmanchanda has quit IRC | 19:28 | |
| *** luyao has quit IRC | 19:32 | |
| openstackgerrit | Merged openstack/nova master: [Community goal] Update contributor documentation https://review.opendev.org/712420 | 19:33 |
| openstackgerrit | Merged openstack/nova master: Fix os-ips policy to be admin_or_owner https://review.opendev.org/715496 | 19:33 |
| openstackgerrit | Merged openstack/nova master: Add test coverage of existing ips policies https://review.opendev.org/715477 | 19:34 |
| openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-ips https://review.opendev.org/715529 | 19:34 |
| openstackgerrit | Merged openstack/nova master: Add new default roles in os-ips policies https://review.opendev.org/715545 | 19:34 |
| openstackgerrit | Merged openstack/nova master: Pass the actual target in os-agents policy https://review.opendev.org/701649 | 20:03 |
| *** ociuhandu has joined #openstack-nova | 20:12 | |
| *** ociuhandu has quit IRC | 20:18 | |
| *** mgariepy has quit IRC | 20:21 | |
| *** xek has quit IRC | 20:26 | |
| *** mgariepy has joined #openstack-nova | 20:34 | |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in unlock override policy https://review.opendev.org/716428 | 20:46 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | 20:55 |
| dansmith | gmann: you around? | 20:55 |
| dansmith | owalsh has a question for you :) | 20:55 |
| gmann | dansmith: hi | 20:55 |
| dansmith | gmann: http://paste.openstack.org/show/kckeKCDgq679ixa2g5IK/ | 20:55 |
| dansmith | gmann: when running nova-manage with an empty policies file | 20:56 |
| owalsh | nova-manage cell_v2 discover_hosts --by-service if it matters | 20:56 |
| dansmith | owalsh: I gotta step away for a bit to get ready for something, but from poking around I feel like gmann is probably your mann :) | 20:58 |
| owalsh | dansmith: ack, thanks | 20:58 |
| gmann | :) | 20:58 |
| openstackgerrit | sean mooney proposed openstack/nova master: [WIP] cyborg evacuate support https://review.opendev.org/715326 | 20:58 |
| owalsh | gmann: already covered by one of the bp/policy-default-refresh patches? | 20:59 |
| gmann | owalsh: those are new defaults and it add the deprecation even you have not override it. but old token keep working as they are maintained as deprecated rule till now. | 20:59 |
| gmann | yeah | 20:59 |
| owalsh | gmann: cool, so should go away once they all merge | 21:00 |
| gmann | owalsh: we are changing all the policy to adopt the system scope and new defaults like read-only etc | 21:00 |
| *** rcernin has joined #openstack-nova | 21:02 | |
| gmann | owalsh: warnings will stay till we remove the deprecated old rules in 1 or 2 cycle from now | 21:03 |
| owalsh | gmann: ack, thanks, expect I'll get asked about the warning quite often until then :-) | 21:05 |
| gmann | owalsh: basically signal to adopt the scope check, those are configurable for now and disabled as default. our goal is to 1. remove the old deprecated roles 2. enable scope check together. but you can always move to new policy by configuring the enforce_scope=Ture | 21:09 |
| gmann | i am still working on those and should provide a doc on 'how to migrate to new policy' once done. | 21:09 |
| gmann | owalsh: i hope those warnings are not much disturbing (as they are for every rule). | 21:10 |
| melwitt | gmann: ++ I was just gonna say I wonder if we can improve that warning message and link to a doc explaining the details and process for migrating. a main point in it is the user being able to tell whether they need to migrate at all, based on their existing policy | 21:11 |
| melwitt | at a minimum once you have written a doc, we should update the warning message to include the link to the documentation | 21:11 |
| gmann | melwitt: that is good idea. it will be easy to link doc to warning | 21:12 |
| *** nweinber has quit IRC | 21:16 | |
| *** slaweq has quit IRC | 21:19 | |
| *** iurygregory has joined #openstack-nova | 21:21 | |
| owalsh | gmann: so for default (empty) policy file we will still get warning for 1-2 cycles? | 21:21 |
| owalsh | or just if deprecated roles are used in the policy? | 21:21 |
| dansmith | it definitely sucks to warn about deprecated policy when the deprecated things are defaults | 21:22 |
| dansmith | if we can't tell what is deprecated (defaults vs. overrides) I would argue we should squelch that warning | 21:22 |
| gmann | owalsh: all becasue defaults are deprecated | 21:25 |
| gmann | it is for all rule as we use those defaults rules as check_str for every rule and oslo policy just add warning for those | 21:27 |
| gmann | not sure how to combine those. | 21:27 |
| gmann | one way is disable oslo warning completely and add a single combined warning form nova policy code with link to migration doc. | 21:30 |
| bnemec | The deprecations are warning you that something might break next cycle and you should test with the future defaults now. | 21:34 |
| gmann | bnemec: we test with both old and new but with disable wanring. | 21:35 |
| dansmith | bnemec: sounds like he has deprecated our existing defaults | 21:36 |
| dansmith | which is why I think we should *not* show this to the user | 21:36 |
| dansmith | there's nothing they can do about it, other than ignore | 21:36 |
| dansmith | it teaches our users to ignore deprecation warnings which is majorly uncool | 21:36 |
| bnemec | Ah, this is a different type of deprecation than what I was thinking of. | 21:38 |
| gmann | and each warning teach what is new defaults to that operator can overidde if anything breaking for them | 21:38 |
| gmann | though that info is present in policy doc also | 21:38 |
| dansmith | gmann: I'm not sure what you're saying | 21:39 |
| bnemec | I think the intent when a policy rule name is changing is that if the new policy name is in the policy file then we don't log the warning. | 21:39 |
| *** artom has quit IRC | 21:39 | |
| dansmith | if the user has made no policy choices and we're logging things telling them that their policy is deprecated, that's a problem | 21:39 |
| dansmith | also, why are we logging this from nova-manage? | 21:40 |
| dansmith | we're just making admin eyes bleed if we complain about something not even related to nova-manage on each command invocation | 21:40 |
| gmann | dansmith: i mean each warning say old default of xyz rule is replaced with one of new default. for example legacy admin to system_reader | 21:40 |
| dansmith | gmann: but we're complaining about our own defaults right? | 21:41 |
| gmann | yeah | 21:41 |
| bnemec | That's fair, we've actually shut off the policy deprecations in some cli tools and unit tests. | 21:41 |
| dansmith | *that* is not okay | 21:41 |
| dansmith | if we have no way to distinguish then we need to squelch the warning until we've fixed all our defaults | 21:42 |
| gmann | i think waning should be added once during api service only | 21:42 |
| dansmith | and, we shouldn't be making those warnings on nova-manage invocations | 21:42 |
| dansmith | gmann: not for our own defaults | 21:42 |
| dansmith | if we're telling the user something is wrong and the thing that is wrong is our default, we're teaching them to ignore our deprecation warnings | 21:43 |
| bnemec | But the user needs to take action. They _shouldn't_ ignore these messages. | 21:43 |
| *** spatel has quit IRC | 21:44 | |
| gmann | own default but still operator rely on those and new default can change the behaviour if they have new roles like read only etc | 21:44 |
| dansmith | gmann: that's what release notes are for | 21:44 |
| gmann | scope is disabled by default so no issue there | 21:44 |
| dansmith | logging that once per startup is totally unreasonable, IMHO | 21:44 |
| owalsh | could nova status upgrade check validate any policy overrides if they exist? | 21:45 |
| dansmith | also that | 21:45 |
| bnemec | If a policy is overridden then you don't get the message. | 21:45 |
| dansmith | nova-status is supposed to be a dynamic release note checker | 21:45 |
| gmann | for this case, i agree on that because it is for every rule and lot of warnings | 21:46 |
| bnemec | cmurphy did have a patch up to further consolidate the deprecation messages, but I feel like there were other concerns with it. | 21:46 |
| gmann | yeah, if rule is override there is no warning for default change. it warn only if rule name change | 21:48 |
| dansmith | we tell people not to override every rule, and almost nobody would override everything, | 21:48 |
| melwitt | gmann: what is happening here is that the defaults are being deprecated and new defaults will be activated in one or two cycles right? maybe a Upgrade release note saying "the default policies are going to change in the W release, please review them" is good enough? | 21:48 |
| dansmith | which means everyone will receive that warning | 21:48 |
| dansmith | melwitt: ++ | 21:49 |
| dansmith | this is precisely what nova-status and renos are for | 21:49 |
| gmann | yeah new defaults are not enforced by default. | 21:50 |
| bnemec | The new defaults are active already. They're just OR'd with the old defaults (if an explicit override is not set) to make sure that the rules are at least as permissive as the old rule so nobody is broken without notice. | 21:50 |
| dansmith | I have to run to a thing, | 21:50 |
| dansmith | but tldr of my opinion is.. there *has* to be a way to make this message go away.. I'd prefer reno/status. If not, then there has to be some way to say "OKAY I GOT IT" | 21:50 |
| melwitt | gmann: and include instructions on how to set enforce_scope = True to see and try the new defaults? also instructions on how to dump the new defaults to review | 21:50 |
| gmann | dansmith: melwitt reno is planned at the end. | 21:50 |
| bnemec | There is. You explicitly set the new rule in your policy file and the deprecation warning goes away. | 21:51 |
| dansmith | bnemec: but we've spent years telling people NOT to do that | 21:51 |
| gmann | bnemec: but that is not expected | 21:51 |
| gmann | yeah what dansmith mentioned | 21:51 |
| melwitt | yeah ... that seems backwards. shouldn't default mean an empty policy file? | 21:51 |
| dansmith | yes | 21:51 |
| bnemec | It's essentially the operator saying, yes, we've looked at this change and it's fine. | 21:51 |
| melwitt | that's what we made a big deal about policy in code back when that was added | 21:52 |
| gmann | true | 21:52 |
| dansmith | copying defaults into the policy file to shut it the eff up moves us backwards many years | 21:52 |
| melwitt | not sure I'd want to confuse users by saying "ok now go set every single rule in your policy file" that seems counterintuitive | 21:52 |
| melwitt | I would imagine their takeaway from that is we've removed policy-in-code and we're back to the old way | 21:53 |
| dansmith | right, because they won't go to the trouble of understanding why, | 21:53 |
| dansmith | they will just hear that is the solution to make it stop warning | 21:54 |
| bnemec | I will say I don't think the policy deprecation mechanism was designed for deprecating the entire policy file at once, like we're doing now. | 21:54 |
| melwitt | yes, I agree this is not the usual thing | 21:54 |
| gmann | yeah, in this case where all defaults are changing warning is too much. | 21:54 |
| bnemec | Also, the redundant rule tool was designed to let them clean up their policy files once the deprecation process is over. | 21:55 |
| gmann | for one or two policy change and name etc then it is fine | 21:55 |
| bnemec | It will tell them that they have rules in their policy file that don't need to be there anymore. | 21:55 |
| gmann | yup that wanring make sense. | 21:55 |
| * dansmith runs away | 21:55 | |
| bnemec | I wonder if we should make that a runtime check instead of a separate tool. | 21:56 |
| gmann | if rule name changing | 21:56 |
| * bnemec pages lbragstad_ too | 21:57 | |
| bnemec | He knows way more about why things work the way they do than I do. | 21:57 |
| melwitt | taking some steps back, I feel like we have changed the defaults for a reason right, that we think they are better defaults. when I say new defaults become "active" I mean when they become the only default, when we're no longer OR'ing them. I feel like maybe we don't need to sound an alarm about it, but rather let the notice in the release notes explain the upcoming change and how to dump the new defaults to review. that is our normal | 22:04 |
| melwitt | way to communicate upcoming changes to our operators | 22:04 |
| *** mriedem has quit IRC | 22:16 | |
| openstackgerrit | melanie witt proposed openstack/nova master: Add info about affinity requests to the troubleshooting doc https://review.opendev.org/715092 | 22:22 |
| sean-k-mooney | dansmith: if you are about can you read the question i left in https://review.opendev.org/#/c/715326/4. basicaily im wondering if i should be binding the arqs in teh conductor during evacuate or on the destinaiton node. and if the conducrot are we ok with the rpc change that will required like we did in build_and_run_instance | 22:30 |
| sean-k-mooney | dansmith: im done for the day so no rush but ill try and rework that tomorrow | 22:31 |
| *** sapd1 has joined #openstack-nova | 22:44 | |
| *** sapd1_y has quit IRC | 22:46 | |
| *** tkajinam has joined #openstack-nova | 22:49 | |
| *** tosky has quit IRC | 22:54 | |
| *** macz_ has quit IRC | 23:06 | |
| gmann | melwitt: dansmith lgtm. I will propose the disable warnings when I cut the releasenotes and doc for new defautls. | 23:18 |
| gmann | i think gibi planning this in ussuri highlights also which also good enough signals | 23:18 |
| openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in limits policy https://review.opendev.org/715761 | 23:26 |
| *** artom has joined #openstack-nova | 23:37 | |
| *** gibi has quit IRC | 23:57 | |
| *** gibi has joined #openstack-nova | 23:57 | |
| *** seba has quit IRC | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!