Wednesday, 2020-04-01

*** spatel has joined #openstack-nova00:09
openstackgerritMerged openstack/nova master: Add test coverage of existing hypervisors policies  https://review.opendev.org/71502900:14
brinzhang_gibi, dansmith: I have reviewed your talking, and saw comment in the latest patch, I will update the update_volume_attachment_v285 to a new schema as raw from gmann suggestion00:18
brinzhang_dansmith: I will update the comments left by gmann to the latest patch.00:24
brinzhang_dansmith: I will add you to the core-author, thanks00:25
lbragstad_we decided to OR deprecated policies with the new defaults so that we could allow for a smoother migration to the new policy enforcement concept00:27
*** lbragstad_ is now known as lbragstad00:27
lbragstadwe felt compelled to add deprecation warnings so that operators would know if/when a user's permissions adhered to the old policy concepts, and not the new way00:28
lbragstadideally, the operator would take that as an action to either adjust the users permissions to fit the new concept (oh, they're an operator they need the 'admin' role on the system) or evaluate if that user really needed that authorization00:30
lbragstadbut, i can totally empathize with warning overload and i can understand how that might teach users the wrong thing by being overly noisy00:32
*** spatel has quit IRC00:33
lbragstadmaybe we could introduce a simpler way of opting into the new concept, instead of telling people to write policies back into a file for warnings to go away (only to remove them later if they're fine with the new defaults)00:38
*** tetsuro has joined #openstack-nova00:38
gmannlbragstad: yeah, i am thinking to add warning disable flag per rule in DocumentedRuleDefault so that we can 1. skip the common default change policy to log warning 2. but at same time rule name change keep adding warning.00:44
gmanni mean instead of global flag, support per rule flag and policy implementor decide which rule they want  to add warning.00:44
gmannbecause if rule name is changed and rule is in policy file we should add warning.00:45
gmannthat is case in nova case when granularity is added to adopt the new defaults00:45
*** macz_ has joined #openstack-nova00:51
*** macz_ has quit IRC00:55
*** zhanglong has joined #openstack-nova00:58
openstackgerritBrin Zhang proposed openstack/nova master: Allow PUT volume attachments API to modify delete_on_termination  https://review.opendev.org/69382801:01
brinzhang_dansmith: gmann: https://review.opendev.org/#/c/693828/ addressed your comments01:01
*** ociuhandu has joined #openstack-nova01:04
lbragstadgmann warnings for policy removal/renames make sense01:06
lbragstadthat functionality could also be incorporated into another oslo.policy cli tool (if it isn't already?)01:07
*** ociuhandu has quit IRC01:08
gmannlbragstad: or we can suppress warning based on global flags (new flag) but policy renaming always log warning . keeping this one always and rest all based on flag - https://github.com/openstack/oslo.policy/blob/c483dee1f306b698448fbee9169038159209e916/oslo_policy/policy.py#L67001:14
gmannbrinzhang_: thanks i will check01:14
lbragstadgmann yeah - that makes sense01:15
brinzhang_gmann: what do you thinf of this change? https://review.opendev.org/#/c/693828/23/nova/api/openstack/compute/volumes.py@49501:15
lbragstadgmann how much policy work does nova have left?01:15
lbragstadthe reviews have been on my list, but i clearly haven't gotten around to them01:16
brinzhang_update an attachments not swap, we will update the attachment firstly, then check the attachment_id !=volumeId, then do swap, that will all admin_or_owner firstly, and then do admin policy01:17
gmannlbragstad: i think ~18 policy are left01:17
lbragstadtotal?!01:17
gmanncounting :)01:17
lbragstadwow - nice work, gmann01:18
gmannlbragstad:  around 5001:18
brinzhang_dansmith, gmann: this looks so strange, is it?01:18
gmannlbragstad: let me propose warning thing in this week and you can check if that make sense especially from other project point of view01:19
lbragstadgmann ok - do we want to think about a different way for people to opt into the new concept, though?01:20
gmannlbragstad: did not get ?01:20
lbragstadtoday, if i upgrade to Ussuri and nova has all these new defaults, i need to override all of them to opt into the new way of doing things01:21
gmannbrinzhang_: you mean we are going to 403 late if non-admin try to update_swap ?01:21
lbragstadgmann do we want to make that easier by not having operators write policies into a file01:22
*** spatel has joined #openstack-nova01:22
brinzhang_gmann: 403?01:22
lbragstadbut still allow them to opt into the new system01:22
lbragstadlike what dansmith and melwitt were saying earlier01:23
gmannlbragstad: ohk. they do not need to write policy. if they enable scope and add new defaults in their system then they adopt the new policy01:23
gmannor you are saying new things only and no old things supported ?01:23
lbragstadlet's say i want to adopt this right away and i don't want policies OR'd01:24
gmannbrinzhang_: i mean policy unauthorize error for non-admin doing update + swap.01:24
lbragstadthat requires me (as the operator) to go and update my nova policy file to override all the policies with their new defaults, right?01:25
brinzhang_gmann: yes01:25
gmannyeah if they want to stop old tokens/role then yes they need to override01:25
brinzhang_gmann: maybe we should move L494 to L497, what do you think?01:25
gmannbut in nova case it is easy as we are controlling those via common base rules01:25
gmannlbragstad: we are testing that simulation also- basically operator needs to do this - https://github.com/openstack/nova/blob/c31de903dd73de1c0a41bcfe4c867daa6eb10f85/nova/tests/unit/policies/base.py#L10301:26
gmannbrinzhang_: we cannot do that becasue swap operation is async and might not be completed before we update deleet flag.01:28
gmannbrinzhang_: we can move the both policy checks in starting. i mean check id !=volume_id then check swap policy also.01:28
lbragstadgmann i wonder if we could come up with a way to opt in without having to write to the policy file (after reading the scrollback, i can see how that might be misleading to operators if we've told them not to do that in the past)01:30
gmannbrinzhang_: anyways that part we can do in https://review.opendev.org/#/c/711194/1001:30
gmannlbragstad: i see your point. how about doing it via enforce_scope ? if it is true along with scope enable we remove the ORing old rules ?01:31
lbragstadgmann yeah - i think that would work01:32
gmannbasically enforce_scope flag is new policy though we kept new defaults roles separate but still someone want to adopt both at same time01:32
brinzhang_gmann: I have an doubt, if the swaped volume is a new volume, maybe we will get bdm raised exception.VolumeBDMNotFound, that we dont do _update_volume_regular(), and cannot completed the swap operation, right?01:33
lbragstadwe originally intended that to be an all-or-nothing option01:33
gmannlbragstad: for existing project who have already exposed reno or doc which is keystone only :). does that flag scope change is bad for user ?01:33
lbragstadso - operators would only set it once they 1.) updated their policies (which might not be needed anymore) and 2.) audited their users to make sure the ones that need system scope have it01:33
gmannyeah.01:34
lbragstadgmann i need to think through it a bit more01:34
lbragstadi doubt anyone is running enforce_scope in production, yet?01:35
gmannok, in that way it make sense to make it all-or-nothing.01:36
gmannbecause new flag controlling scope and defaults roles separately does not make sense.01:38
lbragstadyeah - you mean using the old policies and setting enforce scope to True?01:38
gmannand overahead for us also to maintain the old deprecated things01:38
gmannyeah.01:38
lbragstadi agree - but i'm not an operator :)01:39
gmann:) me too, johnthetubaguy can answer this better01:39
gmannthat is how we did the tests for new system. scope + new rules - https://github.com/openstack/nova/blob/c31de903dd73de1c0a41bcfe4c867daa6eb10f85/nova/tests/unit/policies/test_deferred_delete.py#L12101:41
gmannthat was what johnthetubaguy idea to see how operator will use the new policy but he can tell if any operator want to do scope + old rule01:42
*** luyao has joined #openstack-nova01:42
lbragstadgmann ah - yeah, we took a similar approach01:42
lbragstadin keystone01:42
gmannnice01:42
lbragstadusing a config option would make that easier though01:43
lbragstadand cleaner01:43
*** eharney has quit IRC01:46
gmannbrinzhang_: so swap-only is all ok. and if anyone requesting update + swap and update fail (say VolumeBDMNotFound) then it is ok to fail before doing swap. I mean request is for two operations so we either do both with success otherwise fail and failing before swap is good.01:48
gmannotherwise we end up doing multi-success things which is bad01:49
brinzhang_gmann: I know, but there is an issue, when microversion >=2.85, if the volumeId != id in the request body, I think this will greatly affect the functional requirements of the swap volume.01:51
brinzhang_if this is only a policy check issue, it is easy to resolve, but it is not01:52
gmannbrinzhang_: ohk, you mean user do not have swap-only options with >2.85 ?01:53
brinzhang_gmann: I will leave comments of this concern, wait for gibi, and dansmith with together consider of that.01:54
gmannbrinzhang_: i think we are ok here as swap_volume also does get bdm - https://github.com/openstack/nova/blob/c31de903dd73de1c0a41bcfe4c867daa6eb10f85/nova/compute/api.py#L477701:55
brinzhang_gmann: no, I mean, if the user want to do swap volume01:55
gmannso there is extra things before swap01:55
brinzhang_gmann, can you refer you link to https://opendev.org/openstack/nova/src/branch/master/nova/compute/api.py?01:56
brinzhang_github is so slowly for me01:56
gmannbrinzhang_:  _update_volume_regular does not do any extra things what swap_volume does01:56
gmannbrinzhang_: https://opendev.org/openstack/nova/src/commit/c31de903dd73de1c0a41bcfe4c867daa6eb10f85/nova/compute/api.py#L477701:57
brinzhang_gmann: my concern is bdm = objects.BlockDeviceMapping.get_by_volume_and_instance(context, volume_id, instance.uuid), I am afarid this code failed01:57
gmannbrinzhang_: but that is what swap_volume also does. above link01:58
*** eharney has joined #openstack-nova01:58
brinzhang_gmann: the old volume's bdm, will be copied to the new volume's bdm?02:02
brinzhang_gmann: do you think we can get this exception? https://opendev.org/openstack/nova/src/branch/master/nova/objects/block_device.py#L28102:07
*** yaawang has quit IRC02:08
*** yaawang has joined #openstack-nova02:08
gmannbrinzhang_: it can but it can be raised from swap_volume also so updating failing on this first for update+swap request is ok.02:09
gmannbecause there also we get old volume bdsm02:10
gmannbdm02:10
brinzhang_if microversion > 2.85 to do update+swap for a new volume (instance_uuid is None, not attached to the instance), the bdm will be always failed, right?02:12
brinzhang_because we do update firstly02:13
gmannbrinzhang_: yeah and swap also fail for the same.02:14
brinzhang_so for microversion > 2.85, this feature is invalid, I think02:14
*** sapd1_y has joined #openstack-nova02:16
*** sapd1 has quit IRC02:19
gmannbrinzhang_: on swap, bdm will be updated with new volume id.02:33
gmann>2.85 either we fail during update or during swap is same thing.02:34
brinzhang_gmann: if we swap firstly, then update, maybe we can reduce the failed scenario, but looks also not very good for the user when microversion >= 2.8502:36
openstackgerritMerged openstack/nova master: Introduce scope_types in os-hypervisors  https://review.opendev.org/71503602:39
gmannbrinzhang_: that is problem what gibi commented.swap is rpc async call02:39
*** macz_ has joined #openstack-nova02:39
gmannhttps://review.opendev.org/#/c/693828/22/nova/api/openstack/compute/volumes.py@48102:39
brinzhang_yeah, I know this, I looked at they are talked records02:40
*** macz_ has quit IRC02:43
brinzhang_gibi: We considered swap rpc asynchronously, but we lost the high availability of the interface. Do you have any suggestions?02:44
*** lbragstad has quit IRC02:45
brinzhang_gmann: I left comment with talked by us in the latest patch, I think dansmith and gibi can read that when they are wake up. and you can also reply someting in line.02:46
*** mkrai has joined #openstack-nova02:53
openstackgerritLuyao Zhong proposed openstack/nova master: partial support for live migration with specific resources  https://review.opendev.org/71536203:13
openstackgerritLuyao Zhong proposed openstack/nova master: support live migration with vpmem  https://review.opendev.org/68785603:13
*** tetsuro has quit IRC03:15
*** tetsuro has joined #openstack-nova03:19
*** psachin has joined #openstack-nova03:20
*** tetsuro has quit IRC03:20
*** spatel has quit IRC03:26
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in migrate server  https://review.opendev.org/71613003:27
*** sapd1 has joined #openstack-nova03:31
*** sapd1_y has quit IRC03:32
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in migrate server policies  https://review.opendev.org/71613203:39
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in migrate server policy  https://review.opendev.org/71613403:40
openstackgerritSundar Nadathur proposed openstack/nova master: Add release notes for Cyborg-Nova integration.  https://review.opendev.org/71618503:46
openstackgerritSundar Nadathur proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails.  https://review.opendev.org/71618603:46
*** tetsuro has joined #openstack-nova03:52
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in migrate server policy  https://review.opendev.org/71613403:57
openstackgerritGhanshyam Mann proposed openstack/nova master: Pass the actual target in unlock override policy  https://review.opendev.org/71642804:06
alex_xustephenfin: after reading the ffu discussion recently, I'm thinking maybe we can't remove this code https://review.opendev.org/#/c/714699/504:06
openstackgerritBrin Zhang proposed openstack/nova master: Allow PUT volume attachments API to modify delete_on_termination  https://review.opendev.org/69382804:17
*** macz_ has joined #openstack-nova04:27
*** macz_ has quit IRC04:32
*** evrardjp has quit IRC04:36
*** evrardjp has joined #openstack-nova04:36
*** ratailor has joined #openstack-nova04:49
openstackgerritBrin Zhang proposed openstack/nova master: Separate update and swap volume policies  https://review.opendev.org/71119404:53
*** dklyle has quit IRC05:00
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing remote console policies  https://review.opendev.org/71648205:03
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in remote consoles policy  https://review.opendev.org/71648305:10
*** udesale has joined #openstack-nova05:12
*** udesale has quit IRC05:14
*** udesale has joined #openstack-nova05:14
openstackgerritMerged openstack/nova master: Block unsupported instance operations with accelerators.  https://review.opendev.org/67472605:20
*** vishalmanchanda has joined #openstack-nova05:22
*** links has joined #openstack-nova05:30
*** larainema has joined #openstack-nova05:31
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in remote console policies  https://review.opendev.org/71648405:32
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing remote console policies  https://review.opendev.org/71648205:48
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in remote consoles policy  https://review.opendev.org/71648305:49
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in remote console policies  https://review.opendev.org/71648405:49
*** ociuhandu has joined #openstack-nova05:52
*** Liang__ has joined #openstack-nova05:56
*** ociuhandu has quit IRC05:57
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing rescue policies  https://review.opendev.org/71648606:04
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in rescue server policy  https://review.opendev.org/71648806:08
*** mkrai has quit IRC06:27
*** kplant has joined #openstack-nova06:32
*** nightmare_unreal has joined #openstack-nova06:35
openstackgerritMerged openstack/nova master: Add new default roles in os-hypervisors policies  https://review.opendev.org/71507106:37
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in rescue server policies  https://review.opendev.org/71649606:38
*** mkrai has joined #openstack-nova06:38
*** irclogbot_3 has quit IRC06:49
*** bbowen has quit IRC06:50
*** bbowen has joined #openstack-nova06:50
*** prometheanfire has quit IRC06:51
*** spotz has quit IRC06:51
*** prometheanfire has joined #openstack-nova06:51
*** tobiash has quit IRC06:51
*** jhesketh has quit IRC06:52
*** irclogbot_3 has joined #openstack-nova06:53
*** maciejjozefczyk has joined #openstack-nova06:53
*** irclogbot_3 has quit IRC06:53
*** jhesketh has joined #openstack-nova06:53
*** psachin has quit IRC06:53
*** tobiash has joined #openstack-nova06:53
*** aarents has quit IRC06:54
*** tonyb has quit IRC06:54
*** irclogbot_3 has joined #openstack-nova06:54
*** ociuhandu has joined #openstack-nova06:55
*** Liang__ has quit IRC06:56
*** yaawang has quit IRC06:56
*** Liang__ has joined #openstack-nova06:57
*** yaawang has joined #openstack-nova06:59
*** tonyb has joined #openstack-nova06:59
*** ociuhandu has quit IRC07:00
*** priteau has joined #openstack-nova07:00
brinzhang_sean-k-mooney: gibi: what do you think of this releasenote change? https://review.opendev.org/#/c/716185/2/releasenotes/notes/accelerator-requests-6c9a6fef77ab776a.yaml@11 I am ok add this in releasenote for nova-cyborg interaction feature07:01
*** Liang__ is now known as LiangFang07:01
*** aarents has joined #openstack-nova07:01
brinzhang_sean-k-mooney: gibi: do we need add these in the API guide? that the user can know what action they can do while the instance has some accelerators.07:02
brinzhang_s/while/if07:02
*** ociuhandu has joined #openstack-nova07:03
*** slaweq has joined #openstack-nova07:03
*** ociuhandu has quit IRC07:08
*** tesseract has joined #openstack-nova07:12
*** rcernin has quit IRC07:15
*** belmoreira has joined #openstack-nova07:16
gibibrinzhang_: do we have api guide for cyborg interaction?07:17
gibibrinzhang_: at least I don't find it07:17
gibibrinzhang_: but sure an api guide would be good to have07:17
brinzhang_gibi: that also what I want to see too.07:18
gibisomething similar to https://github.com/openstack/nova/blob/master/api-guide/source/port_with_resource_request.rst07:18
gibibrinzhang_: could you please note this api-guide request in the reno review07:19
gibi?07:19
brinzhang_gibi: I will asked Sundar in wechat, wait later :)07:20
brinzhang_gibi: I left some comments in https://review.opendev.org/#/c/693828/24, can you see fast?07:21
gibibrinzhang_: will do in a couple of minutes (on a daily standup meeting now)07:22
brinzhang_gibi: thanks^^07:23
*** tesseract has quit IRC07:28
*** ociuhandu has joined #openstack-nova07:28
*** tesseract has joined #openstack-nova07:31
*** tosky has joined #openstack-nova07:32
*** rpittau|afk is now known as rpittau07:37
*** xek has joined #openstack-nova07:37
*** ttsiouts has joined #openstack-nova07:46
*** ralonsoh has joined #openstack-nova07:55
*** dtantsur|afk is now known as dtantsur08:04
*** ociuhandu has quit IRC08:08
*** ociuhandu has joined #openstack-nova08:09
*** ociuhandu has quit IRC08:14
*** ociuhandu has joined #openstack-nova08:15
*** tkajinam has quit IRC08:18
gibibrinzhang_: replied in https://review.opendev.org/#/c/69382808:31
openstackgerritjayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell  https://review.opendev.org/71445908:32
brinzhang_gibi: I will looked into, thanks08:39
*** martinkennelly has joined #openstack-nova08:42
*** kashyap has joined #openstack-nova08:55
*** priteau has quit IRC09:03
gibibrinzhang_: also feedback on https://review.opendev.org/#/c/71119409:04
jkulikCould someone have a look at this, please? https://review.opendev.org/#/c/713863/09:04
gibijkulik: could you please file a bug09:08
jkulikgibi: if that helps, sure09:08
gibijkulik: also, is this something that worked well in the past and then broken by a certain release?09:08
jkuliknope. never worked properly for us09:09
jkulikwe're on queens ;)09:09
gibijkulik: yes it helps as it feels like a bug, and bugs tend to be backported to stable branches. All these tracking is easier if there is a bug that connect the patches on different branches09:09
jkulikok, got it. will create a bug and mention it in the commit-message09:09
*** tetsuro has quit IRC09:09
jkulikthank you09:09
gibijkulik: I see. If you can write a sort reproduction steps in the bug report then I will try to repoduce it in my devstack to confirm the bug09:10
*** zhanglong has quit IRC09:12
brinzhang_gibi: with https://review.opendev.org/#/c/71114 I also have some doubt, hope dansmith can have some good idea.09:15
brinzhang_gibi: A question, I will update the novalcinet to support v2.85, do I need to add all request parameter to the volume-update CLI?09:15
brinzhang_gibi: We just can update the delete flag, how about just only update the delete_on_termination to the volume-update CLI to support update volume?09:16
gibibrinzhang_: I think it is OK to update the CLI to only offer d-o-t update09:17
gibithat is the main use case for the end user anyhow09:17
brinzhang_other parameters, e.g. device, id, serverId, tag, that should keep same value, so I think we dont add that in the CLI09:17
gibiI agree09:17
brinzhang_gibi: ok, I will do by this way, thanks09:18
bauzasgibi: around for a question about reshapes ?09:21
bauzasand your vgpu func test ?09:21
gibibauzas: sure, hit me09:25
bauzasgibi: okay, so I wonder why you mocked https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_reshape.py#L96-L10109:27
bauzasgibi: you started two instances without having any supported types09:27
bauzasgibi: so the instances wouldn't have any VGPU allocations09:27
*** belmoreira has quit IRC09:29
bauzasoh, but you created some VGPU inventories...09:29
gibibauzas: before that there is a placement update09:29
gibiyeah09:29
gibithat09:29
gibiI guess this is a simplification09:30
bauzasmmm ok09:30
gibiin a good test the virt driver should report the new vgpu inventory09:30
gibiI don't remember why I don't added a new fake driver that does that09:31
gibiI guess there was complications09:31
bauzaswhat I honestly wonder is whether your test is valid for a reshape09:31
*** avolkov has joined #openstack-nova09:31
bauzasbecause when you restart nova-compute, you get a reshape, right?09:31
bauzasin this case, when allocating an instance for this node, you get the nested RPs09:31
*** ratailor has quit IRC09:32
bauzasI mean, we only have VGPU inventories on the root RP for nodes that were not restarted09:32
bauzas(or <Stein)09:32
*** ratailor has joined #openstack-nova09:33
gibithis test tries to create instances with old type of allocation then hit the reshape by restarting the compute09:34
bauzasI see09:35
gibiif the virt driver report the vgpu at fist start then with the current code reshape is triggered, so I had to simulate and old tree somehow09:35
gibithen trigger a reshape09:35
openstackgerritMerged openstack/nova master: Add cyborg tempest job.  https://review.opendev.org/67099909:36
gibisee https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_reshape.py#L5309:36
bauzasgibi: but you agree with the fact it wouldn't be possible to create an instance having old types of allocations with Stein or Ussuri ?09:36
gibiI agree. But to test reshap in >=Stein I have to simualte an old tree09:37
gibihence the hack in the test09:37
bauzasI mean, the _allocate_mdev() code in libvirt that's eventually called when creating an instance would be different between Rocky and Stein09:37
*** martinkennelly has quit IRC09:37
gibithat is a valid point, I haven't simulated the Rocky _allocate_mdev code09:37
bauzasI mean, I wrote https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7011-L701309:38
gibiI guess creating a proper test is only possible a grenade job that upgrades from Rocky to Stein09:38
bauzasbut I think it wasn't needed09:39
bauzasyeah maybe09:39
bauzasanyway, I need to think about what do do09:39
bauzasyour test is nice and i don't want to remove it09:39
tobias-urdincontinue troubleshooting https://bugs.launchpad.net/oslo.config/+bug/1869929 seems like some issue with a nova dependency or import order issues, have a complete reproduce and a solution, but the solution is to remove the @db.select_db_reader_mode decorator from two functions in nova/objects/service.py09:40
gibiyeah. feel free to remove the func test if it does not make sense any more. The hack there is definitely partially simulate Rocky state09:40
openstackLaunchpad bug 1869929 in oslo.config "RuntimeError: maximum recursion depth exceeded while calling a Python object" [Undecided,New]09:40
bauzasgibi: well, I just feel we would just need to create a new instance without asking for VGPUs and then creating the VGPU allocations directly09:41
gibibauzas: if you remove the func test from master, we will still have it on stable branches where this test is more relevant09:41
bauzas(for the func test)09:41
tobias-urdin^ if anybody knows import could potentially cause it, trying to track down changes to imports between the versions, seems like nova.cells.rpcapi changed09:41
gibibauzas: but then mdev assignments will be missing, isn't it?09:42
bauzasah shit you're right, indeed09:42
gibibauzas: so that will be partial from a different perspective09:42
bauzasyeah09:42
bauzasanyway, I'll think about it09:43
gibibauzas: cool. let me know if I can help09:43
bauzaswe still need to support the reshape for Ussuri like we said09:43
bauzasso maybe a comment telling it's not really possible to have no parent UUID would be simple09:43
*** owalsh has quit IRC09:50
openstackgerritJohannes Kulik proposed openstack/nova master: Don't recompute weighers' minval/maxval attributes  https://review.opendev.org/71386309:50
*** owalsh has joined #openstack-nova09:50
jkulikgibi, bug for ^ is here https://bugs.launchpad.net/nova/+bug/187009609:50
openstackLaunchpad bug 1870096 in OpenStack Compute (nova) "soft-affinity weight not normalized base on server group's maximum" [Undecided,In progress] - Assigned to Johannes Kulik (jkulik)09:50
gibijkulik: ack, I will check09:51
gibithanks09:51
*** seba has joined #openstack-nova09:54
*** LiangFang has quit IRC10:00
openstackgerritSylvain Bauza proposed openstack/nova master: Provide the parent pGPU when creating a new vGPU  https://review.opendev.org/71548910:06
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Support different vGPU types per pGPU  https://review.opendev.org/71549010:06
bauzasgibi: if you wanna look at what I wrote about what we discussed ^10:09
bauzasFWIW, this is a Ussuri target blueprint10:10
bauzastargeted*10:10
bauzasI have to finish the last bits tho10:10
bauzasbut that should be okay10:10
*** rpittau is now known as rpittau|bbl10:16
*** ociuhandu has quit IRC10:21
*** ociuhandu has joined #openstack-nova10:22
*** bbowen has quit IRC10:26
*** ociuhandu has quit IRC10:28
*** mkrai has quit IRC10:29
gibibauzas: ack, will check later10:29
*** mkrai has joined #openstack-nova10:31
*** rcernin has joined #openstack-nova10:34
*** ociuhandu has joined #openstack-nova10:44
*** ociuhandu has quit IRC10:45
*** ociuhandu has joined #openstack-nova10:46
*** derekh has joined #openstack-nova10:49
*** ociuhandu has quit IRC10:59
*** ociuhandu has joined #openstack-nova11:00
*** ociuhandu has quit IRC11:05
*** bbowen has joined #openstack-nova11:28
*** ociuhandu has joined #openstack-nova11:37
*** ttsiouts has quit IRC11:42
*** ttsiouts has joined #openstack-nova11:44
*** ociuhandu has quit IRC11:47
*** ociuhandu has joined #openstack-nova11:48
*** zhanglong has joined #openstack-nova11:52
*** ociuhandu has quit IRC11:56
*** zhanglong has quit IRC11:57
*** zhanglong has joined #openstack-nova11:58
*** ociuhandu has joined #openstack-nova12:01
*** sapd1_x has quit IRC12:03
*** rpittau|bbl is now known as rpittau12:07
*** spotz has joined #openstack-nova12:07
*** martinkennelly has joined #openstack-nova12:11
openstackgerritBrin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI  https://review.opendev.org/71265112:21
*** mkrai has quit IRC12:21
*** derekh has quit IRC12:25
*** ociuhandu has quit IRC12:37
*** derekh has joined #openstack-nova12:45
*** dave-mccowan has joined #openstack-nova12:50
*** dave-mccowan has quit IRC12:54
*** sapd1_x has joined #openstack-nova12:57
*** lbragstad has joined #openstack-nova12:58
*** nweinber has joined #openstack-nova13:04
*** udesale_ has joined #openstack-nova13:09
*** ratailor has quit IRC13:11
*** udesale has quit IRC13:11
*** ociuhandu has joined #openstack-nova13:15
*** ociuhandu has quit IRC13:20
*** zhanglong has quit IRC13:21
*** mgariepy has quit IRC13:24
*** mgariepy has joined #openstack-nova13:25
*** liuyulong has joined #openstack-nova13:26
*** rouk has joined #openstack-nova13:27
sean-k-mooneybrinzhang_: we should still have the info in the release note but im fine with also having a dedicated page in the api guide for this13:35
*** ociuhandu has joined #openstack-nova13:35
sean-k-mooneythis being cyborg13:35
openstackgerritSylvain Bauza proposed openstack/nova master: Provide the parent pGPU when creating a new vGPU  https://review.opendev.org/71548913:36
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Support different vGPU types per pGPU  https://review.opendev.org/71549013:36
*** ttsiouts has quit IRC13:38
*** sapd1_x has quit IRC13:42
*** mkrai has joined #openstack-nova13:46
openstackgerritSylvain Bauza proposed openstack/nova master: Provide the parent pGPU when creating a new vGPU  https://review.opendev.org/71548913:46
openstackgerritSylvain Bauza proposed openstack/nova master: WIP: Support different vGPU types per pGPU  https://review.opendev.org/71549013:46
*** ttsiouts has joined #openstack-nova13:48
*** Liang__ has joined #openstack-nova13:55
*** sapd1_x has joined #openstack-nova13:55
*** Liang__ is now known as LiangFang13:56
*** damien_r has quit IRC14:13
*** ttsiouts has quit IRC14:17
*** sapd1_x has quit IRC14:17
kevinzsean-k-mooney: Hi, when you have time, pls take a look at https://review.opendev.org/714311 and https://review.opendev.org/712607, already got +2 before :-)14:23
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Always provide the size in bytes when calling virDomainBlockResize  https://review.opendev.org/70759014:29
openstackgerritStephen Finucane proposed openstack/nova master: images: Remove Libvirt specific configurable use from qemu_img_info  https://review.opendev.org/70759114:29
openstackgerritStephen Finucane proposed openstack/nova master: libvirt: Remove QEMU_VERSION_REQ_SHARED  https://review.opendev.org/71023914:29
openstackgerritStephen Finucane proposed openstack/nova master: images: Make JSON the default output format of calls to qemu-img info  https://review.opendev.org/71167914:29
sean-k-mooneykevinz: https://review.opendev.org/#/c/712607/16 looks good to me ill take alook at the other too14:30
*** sapd1_x has joined #openstack-nova14:30
sean-k-mooneybauzas: are you free for 30 seconds to review two trivail patches for kevinz https://review.opendev.org/#/c/712607/16 and https://review.opendev.org/#/c/714311/3 both look good to me.14:37
bauzassean-k-mooney: lemme look14:37
kevinzsean-k-mooney:bauzas: Thanks a lot14:39
bauzasthose are conflicting with my own changes, but i'll forget about this when reviewing :)14:39
*** martinkennelly has quit IRC14:40
*** macz_ has joined #openstack-nova14:40
*** sapd1_x has quit IRC14:41
*** ratailor has joined #openstack-nova14:41
*** martinkennelly has joined #openstack-nova14:45
*** links has quit IRC14:45
*** sapd1_x has joined #openstack-nova14:46
sean-k-mooneyah the allocation candiate changes14:47
sean-k-mooneyyes. i will need to take a look at those as i think i will need to use them if i want to support migration/resize with cyborg14:48
sean-k-mooneydansmith gibi are either of ye around?14:50
gibiI'm here14:50
*** dklyle has joined #openstack-nova14:51
sean-k-mooneycool am for the cyborg evacuate support https://review.opendev.org/#/c/715326/ should i do the arq binding on the conductor like we do for spawn or on the compute node14:51
sean-k-mooneyi started doing it on the compute node but i think i should move it to the conductor14:51
sean-k-mooneyso that cyborg can start to program the device asyc of nova14:52
sean-k-mooneygibi: any thoughts?14:52
dansmithsean-k-mooney: condutor for sure unless there's some really compelling reason otherwise14:54
sean-k-mooneydansmith: cool only reason not to is i start doing it the other way first which is easily solved via copy paste :)14:55
gibisean-k-mooney: yeah, qos stuff is also done there14:55
sean-k-mooneydansmith: should i alther the rpc to pass the arqs14:55
gibiI mean in the conducotr for evac14:55
dansmithsean-k-mooney: we did for spawn because it's so much more efficient14:56
dansmithsean-k-mooney: the early stuff landed without it because it was less change, but that's the only reason14:56
sean-k-mooneyso you would be in favor of just doing it for evac too14:57
sean-k-mooneyok ill rework the change to bump the rpc and move the recreation of the arq and bindign to the conductor and do the same wait on the compute we do for spawn14:59
*** lpetrut has joined #openstack-nova14:59
sean-k-mooneythanks14:59
*** lbragstad has quit IRC15:03
*** ttsiouts has joined #openstack-nova15:03
*** lbragstad has joined #openstack-nova15:04
*** mriedem has joined #openstack-nova15:05
*** lpetrut has quit IRC15:06
*** lbragstad_ has joined #openstack-nova15:06
*** lbragstad_ has quit IRC15:11
openstackgerritmelanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929  https://review.opendev.org/70147815:11
openstackbug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/184492915:11
*** tesseract-RH has joined #openstack-nova15:12
*** tesseract has quit IRC15:15
*** sapd1_x has quit IRC15:15
*** lbragstad_ has joined #openstack-nova15:17
*** martinkennelly has quit IRC15:18
*** mkrai has quit IRC15:19
*** lbragstad_ has quit IRC15:22
*** LiangFang has quit IRC15:23
*** sapd1_x has joined #openstack-nova15:28
*** mkrai has joined #openstack-nova15:29
*** gyee has joined #openstack-nova15:36
gibijkulik: thanks for the bugfix https://review.opendev.org/#/c/713863 it looks good to me15:39
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage db purge to nova-audit  https://review.opendev.org/70878316:01
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage db archive_deleted_rows to nova-audit  https://review.opendev.org/70878416:01
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage cell_v2 discover_hosts to nova-manage  https://review.opendev.org/70878516:01
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage cell_v2 map_instances to nova-audit  https://review.opendev.org/70878616:01
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage placement sync_aggregates to nova-audit  https://review.opendev.org/70878716:01
openstackgerritmelanie witt proposed openstack/nova master: Move nova-manage placement heal_allocations to nova-audit  https://review.opendev.org/70878816:01
melwittbauzas: fyi this is what I have so far ^16:02
bauzasmelwitt: all cool, will look at those16:05
melwittthanks :)16:06
gmannmelwitt: in case you missed. I hope it covers the requirement you mentioned during policy spec - https://review.opendev.org/#/c/716134/16:11
gmannmelwitt: basically for server action, we are going with same approach. default to system admin ( for current admin-only actions) but give operator a options to assign that role to project also. keeping scope as system and project both16:12
melwittgmann: I think that makes sense, but I'm initially unclear how this didn't show up as a bug fix like some of the others?16:14
*** rpittau is now known as rpittau|afk16:15
gmannmelwitt: they are admin only in policy also and does not pass server project id. other policy bugs are on mismatch on what policy say and what API pass to policy.16:16
melwittgmann: oh right, derp. thanks. sorry, I get confused by some of these16:17
gmannor we can say we are extending these action to be do-able by project with new defaults16:17
openstackgerritMerged openstack/nova master: Add new default roles in os-flavor-access policies  https://review.opendev.org/71369716:27
openstackgerritMerged openstack/nova master: Add test coverage of existing migrate server policies  https://review.opendev.org/71612816:28
openstackgerritMerged openstack/nova master: Add test coverage of existing migrations policies  https://review.opendev.org/71613616:28
*** mkrai has quit IRC16:35
*** evrardjp has quit IRC16:36
*** evrardjp has joined #openstack-nova16:36
*** tesseract-RH has quit IRC16:39
*** martinkennelly has joined #openstack-nova16:43
gmanngibi: brinzhang_ this lgtm, 1 comment on few more tests  - https://review.opendev.org/#/c/693828/2516:48
openstackgerritMerged openstack/nova master: Fix unlock server policy to be admin_or_owner  https://review.opendev.org/71607116:54
*** dtantsur is now known as dtantsur|afk17:07
openstackgerritMerged openstack/nova master: Fix unpause server policy to be admin_or_owner  https://review.opendev.org/71616517:09
openstackgerritMerged openstack/nova master: Add test coverage of existing pause server policies  https://review.opendev.org/71616117:09
openstackgerritMerged openstack/nova master: Add test coverage of existing lock server policies  https://review.opendev.org/71605717:09
openstackgerritMerged openstack/nova master: Introduce scope_types in pause server policy  https://review.opendev.org/71618717:10
openstackgerritMerged openstack/nova master: Add new default roles in pause server policies  https://review.opendev.org/71619117:10
openstackgerritMerged openstack/nova master: Introduce scope_types in migrate server  https://review.opendev.org/71613017:10
openstackgerritMerged openstack/nova master: Add new default roles in migrate server policies  https://review.opendev.org/71613217:10
openstackgerritMerged openstack/nova master: Pass the actual target in migrate server policy  https://review.opendev.org/71613417:11
openstackgerritMerged openstack/nova master: Add new default roles in lock server policies  https://review.opendev.org/71612217:11
openstackgerritMerged openstack/nova master: Pass the actual target in unlock override policy  https://review.opendev.org/71642817:11
openstackgerritMerged openstack/nova master: Add test coverage of existing rescue policies  https://review.opendev.org/71648617:11
openstackgerritMerged openstack/nova master: Introduce scope_types in rescue server policy  https://review.opendev.org/71648817:11
openstackgerritMerged openstack/nova master: Add test coverage of existing remote console policies  https://review.opendev.org/71648217:12
openstackgerritMerged openstack/nova master: Introduce scope_types in remote consoles policy  https://review.opendev.org/71648317:12
*** ratailor has quit IRC17:16
openstackgerritGhanshyam Mann proposed openstack/nova master: DNM: showing policy enforcement for PUT attachments  https://review.opendev.org/71667917:22
*** d34dh0r53 has joined #openstack-nova17:23
*** nightmare_unreal has quit IRC17:24
gmanngibi: brinzhang_ dansmith commented on policy enforcement for PUT attachments. showed example for  covering all cases-  https://review.opendev.org/71667917:27
*** udesale_ has quit IRC17:29
*** ociuhandu has quit IRC17:45
*** lbragstad has quit IRC17:47
*** ociuhandu has joined #openstack-nova17:49
_erlon_hi guys, is the Nova meeting for tomorrow up? I don't see any topics on the agenda: https://wiki.openstack.org/wiki/Meetings/Nova17:52
gmann_erlon_: i think yes (it is not explicitly cancneld). may be gibi will update agenda and dates soon .17:54
_erlon_gmann: ok, thanks, Ill fill up my topic tomorrow17:55
*** ociuhandu has quit IRC17:56
*** gmann is now known as gmann_lunch17:56
*** lbragstad_ has joined #openstack-nova17:59
*** lbragstad_ is now known as lbragstad17:59
*** lbragstad has quit IRC18:00
*** lbragstad has joined #openstack-nova18:00
*** mloza has joined #openstack-nova18:11
*** lbragstad_ has joined #openstack-nova18:20
*** lbragstad has quit IRC18:23
*** ociuhandu has joined #openstack-nova18:25
*** gmann_lunch is now known as gmann18:28
*** lbragstad_ is now known as lbragstad18:28
*** ociuhandu has quit IRC18:28
*** ociuhandu has joined #openstack-nova18:29
*** sapd1_x has quit IRC18:43
*** larainema has quit IRC18:46
*** lbragstad has quit IRC18:50
openstackgerritMerged openstack/nova master: libvirt: Always provide the size in bytes when calling virDomainBlockResize  https://review.opendev.org/70759018:53
openstackgerritMerged openstack/nova master: images: Remove Libvirt specific configurable use from qemu_img_info  https://review.opendev.org/70759118:53
openstackgerritMerged openstack/nova master: libvirt: Remove QEMU_VERSION_REQ_SHARED  https://review.opendev.org/71023918:54
openstackgerritMerged openstack/nova master: Pass the actual target in os-hypervisors policy  https://review.opendev.org/71507418:55
openstackgerritMerged openstack/nova master: Correct limits policy check_str  https://review.opendev.org/71567218:55
openstackgerritVictor Coutellier proposed openstack/python-novaclient master: Microversion 2.83 - Add more filters for the nova list command  https://review.opendev.org/71308918:57
*** bbowen has quit IRC19:03
*** d34dh0r53 has quit IRC19:09
*** d34dh0r53 has joined #openstack-nova19:20
*** luyao has quit IRC19:27
*** ralonsoh has quit IRC19:28
*** rouk has quit IRC19:35
*** ociuhandu has quit IRC19:39
*** derekh has quit IRC19:40
*** ociuhandu has joined #openstack-nova19:40
*** ociuhandu has quit IRC19:45
*** ociuhandu has joined #openstack-nova19:57
openstackgerritGhanshyam Mann proposed openstack/nova master: Combine the limits policies in single place  https://review.opendev.org/71567819:58
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in remote console policies  https://review.opendev.org/71648420:02
*** bbowen has joined #openstack-nova20:16
*** xek has quit IRC20:17
*** igordc has joined #openstack-nova20:27
*** vishalmanchanda has quit IRC20:39
*** slaweq has quit IRC20:54
*** slaweq has joined #openstack-nova21:12
*** N3l1x has joined #openstack-nova21:15
*** ociuhandu has quit IRC21:16
*** ociuhandu has joined #openstack-nova21:17
*** ociuhandu has quit IRC21:22
*** ttsiouts has quit IRC21:22
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing security groups policies  https://review.opendev.org/71677921:30
*** mriedem has left #openstack-nova21:51
*** ttsiouts has joined #openstack-nova21:54
*** ttsiouts has quit IRC21:59
*** frickler_ has joined #openstack-nova22:03
*** martinkennelly has quit IRC22:04
*** melwitt has quit IRC22:08
*** aspiers has quit IRC22:08
*** rmk has quit IRC22:08
*** fnordahl has quit IRC22:08
*** frickler has quit IRC22:08
*** nweinber has quit IRC22:09
*** avolkov has quit IRC22:11
*** rs91 has joined #openstack-nova22:11
rs91Has anyone run into this os-brick issue with multipath failure reported in https://bugs.launchpad.net/nova/+bug/1414527? Is there any known workaround for this issue or plan to fix it in nova?22:12
openstackLaunchpad bug 1414527 in OpenStack Compute (nova) "The multipath device descriptors remove failed when the volume has partition" [Undecided,Confirmed]22:12
*** spatel has joined #openstack-nova22:19
openstackgerritGhanshyam Mann proposed openstack/nova master: Correct secutrity groups policy check_str  https://review.opendev.org/71678222:26
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing security groups policies  https://review.opendev.org/71677922:27
*** rmk has joined #openstack-nova22:30
*** slaweq has quit IRC22:31
*** ttsiouts has joined #openstack-nova22:36
*** rs91 has quit IRC22:37
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing security groups policies  https://review.opendev.org/71677922:41
*** macz_ has quit IRC22:44
*** spatel has quit IRC22:44
*** aspiers has joined #openstack-nova22:45
*** lbragstad has joined #openstack-nova22:47
*** melwitt has joined #openstack-nova22:50
*** tkajinam has joined #openstack-nova22:55
*** tosky has quit IRC23:03
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in security groups policy  https://review.opendev.org/71678623:10
openstackgerritMerged openstack/nova master: Add new default roles in rescue server policies  https://review.opendev.org/71649623:30
*** tetsuro has joined #openstack-nova23:44
*** dklyle has quit IRC23:55
*** david-lyle has joined #openstack-nova23:55
*** david-lyle has quit IRC23:55
*** dklyle has joined #openstack-nova23:57
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in security group policies  https://review.opendev.org/71679323:57
openstackgerritGhanshyam Mann proposed openstack/nova master: Add test coverage of existing security groups policies  https://review.opendev.org/71677923:58
openstackgerritGhanshyam Mann proposed openstack/nova master: Introduce scope_types in security groups policy  https://review.opendev.org/71678623:58
openstackgerritGhanshyam Mann proposed openstack/nova master: Add new default roles in security group policies  https://review.opendev.org/71679323:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!