*** tosky has quit IRC | 00:10 | |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785 | 00:24 |
---|---|---|
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 00:24 |
openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 00:25 |
*** zzzeek has quit IRC | 00:28 | |
*** zzzeek has joined #openstack-nova | 00:31 | |
*** JamesBenson has joined #openstack-nova | 00:44 | |
*** JamesBenson has quit IRC | 00:50 | |
openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job for pyflakes, request version conflict https://review.opendev.org/c/openstack/placement/+/766994 | 00:54 |
openstackgerrit | Wenping Song proposed openstack/nova master: Remove redundant code in instance delete https://review.opendev.org/c/openstack/nova/+/759577 | 00:55 |
*** hemanth_n has joined #openstack-nova | 00:55 | |
*** zer0def has left #openstack-nova | 00:56 | |
*** k_mouza has joined #openstack-nova | 01:00 | |
*** efried has quit IRC | 01:01 | |
*** k_mouza has quit IRC | 01:04 | |
*** swp20 has joined #openstack-nova | 01:07 | |
*** rcernin has quit IRC | 01:12 | |
*** LinPeiWen has quit IRC | 01:20 | |
*** rcernin has joined #openstack-nova | 01:20 | |
*** JamesBenson has joined #openstack-nova | 01:23 | |
gmann | gibi: melwitt lyarwood this fixes the placement gate (l-c job )- https://review.opendev.org/c/openstack/placement/+/766994 | 01:24 |
*** zzzeek has quit IRC | 01:24 | |
gmann | gibi: melwitt lyarwood I have moved it to latest hacking version which is easy than solving the old hacking + old pyflake compatible versions. | 01:25 |
*** LinPeiWen has joined #openstack-nova | 01:25 | |
*** zzzeek has joined #openstack-nova | 01:26 | |
*** JamesBenson has quit IRC | 01:28 | |
*** songwenping_ has joined #openstack-nova | 01:31 | |
*** swp20 has quit IRC | 01:35 | |
*** songwenping__ has joined #openstack-nova | 01:37 | |
*** macz_ has quit IRC | 01:37 | |
*** macz_ has joined #openstack-nova | 01:38 | |
*** songwenping_ has quit IRC | 01:41 | |
*** swp20 has joined #openstack-nova | 01:58 | |
*** songwenping__ has quit IRC | 01:58 | |
*** mlavalle has quit IRC | 02:16 | |
*** k_mouza has joined #openstack-nova | 02:38 | |
*** rcernin has quit IRC | 02:42 | |
*** k_mouza has quit IRC | 02:42 | |
*** rcernin has joined #openstack-nova | 02:54 | |
*** hamalq_ has quit IRC | 02:55 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 03:06 |
*** JamesBenson has joined #openstack-nova | 03:24 | |
*** JamesBenson has quit IRC | 03:28 | |
*** lemko3 has joined #openstack-nova | 03:35 | |
*** lemko has quit IRC | 03:38 | |
*** lemko3 is now known as lemko | 03:38 | |
*** sapd1 has joined #openstack-nova | 04:03 | |
*** k_mouza has joined #openstack-nova | 04:46 | |
*** k_mouza has quit IRC | 04:51 | |
*** vishalmanchanda has joined #openstack-nova | 05:04 | |
*** zzzeek has quit IRC | 05:11 | |
*** zzzeek has joined #openstack-nova | 05:13 | |
*** zzzeek has quit IRC | 05:20 | |
*** zzzeek has joined #openstack-nova | 05:25 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #openstack-nova | 05:33 | |
*** brinzhang has joined #openstack-nova | 05:55 | |
*** zzzeek has quit IRC | 06:04 | |
*** mtreinish has quit IRC | 06:05 | |
*** zzzeek has joined #openstack-nova | 06:06 | |
*** zzzeek has quit IRC | 06:16 | |
*** zzzeek has joined #openstack-nova | 06:18 | |
*** ratailor has joined #openstack-nova | 06:18 | |
*** zzzeek has quit IRC | 06:30 | |
*** zzzeek has joined #openstack-nova | 06:31 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 06:38 |
*** macz_ has quit IRC | 06:38 | |
*** avolkov has joined #openstack-nova | 06:44 | |
*** zzzeek has quit IRC | 06:56 | |
*** zzzeek has joined #openstack-nova | 06:58 | |
*** rcernin has quit IRC | 07:06 | |
*** ratailor has quit IRC | 07:08 | |
*** brinzhang has quit IRC | 07:10 | |
*** brinzhang has joined #openstack-nova | 07:10 | |
*** ratailor has joined #openstack-nova | 07:13 | |
*** zzzeek has quit IRC | 07:18 | |
*** zzzeek has joined #openstack-nova | 07:20 | |
*** gyee has quit IRC | 07:21 | |
*** JamesBenson has joined #openstack-nova | 07:26 | |
*** zzzeek has quit IRC | 07:28 | |
*** zzzeek has joined #openstack-nova | 07:28 | |
*** JamesBenson has quit IRC | 07:32 | |
*** spatel has joined #openstack-nova | 07:33 | |
*** mtreinish has joined #openstack-nova | 07:37 | |
*** spatel has quit IRC | 07:38 | |
*** rcernin has joined #openstack-nova | 07:43 | |
*** dklyle has quit IRC | 07:45 | |
*** rcernin has quit IRC | 07:48 | |
*** slaweq has quit IRC | 07:56 | |
gibi | sean-k-mooney: I do see that these test are slower then the others in the CI, but I don't see any timeout in nova. When it fails it fails from an exception from the db driver | 07:56 |
*** slaweq has joined #openstack-nova | 07:58 | |
*** rcernin has joined #openstack-nova | 07:59 | |
*** rcernin has quit IRC | 08:04 | |
*** rpittau|afk is now known as rpittau | 08:06 | |
*** rcernin has joined #openstack-nova | 08:08 | |
*** rcernin has quit IRC | 08:12 | |
*** LinPeiWen has quit IRC | 08:15 | |
*** andrewbonney has joined #openstack-nova | 08:17 | |
*** tesseract has joined #openstack-nova | 08:23 | |
*** LinPeiWen has joined #openstack-nova | 08:24 | |
gibi | gmann: I've left comment in https://review.opendev.org/c/openstack/placement/+/766994 | 08:25 |
*** rcernin has joined #openstack-nova | 08:33 | |
*** rcernin has quit IRC | 08:34 | |
*** macz_ has joined #openstack-nova | 08:35 | |
bauzas | good morning Nova | 08:37 |
hemanth_n | sean-k-mooney: hey regarding backports which we discussed yesterday, I am afraid it requires more patches to backport to ussuri. For now i found these 3 bfe7b7f3ee340012b3a9f1294ce86b07456ab206, 6c4d1a6aabb101466d2a2d05ed4c6240425b76b5, 0ab8a03c782851d4019c90e6159bd1f83c0658e6 and tests are failing still which implies more patches are needed (placement fixtures related ones are needed for sure). I want to take a pause and see if this is the | 08:38 |
hemanth_n | direction we want given lot many patches are required to make the patch i submitted clean cherrypick.. thoughts? | 08:38 |
*** macz_ has quit IRC | 08:39 | |
*** tosky has joined #openstack-nova | 08:41 | |
*** zzzeek has quit IRC | 08:43 | |
*** zzzeek has joined #openstack-nova | 08:44 | |
*** LinPeiWen has quit IRC | 08:53 | |
bauzas | gmann: gibi: is https://review.opendev.org/c/openstack/placement/+/766994 helping the placement CI ? | 08:56 |
bauzas | we have a lof of open reviews from lbragstad about secure-rbac https://review.opendev.org/q/topic:%22secure-rbac%22+(status:open%20OR%20status:merged) , and I want to make sure that it would help | 08:56 |
*** lpetrut has joined #openstack-nova | 08:57 | |
bauzas | whoops, bad gerrit query https://review.opendev.org/q/topic:%2522secure-rbac%2522+(status:open+OR+status:merged)+project:openstack/placement | 08:57 |
*** zzzeek has quit IRC | 09:04 | |
*** zzzeek has joined #openstack-nova | 09:04 | |
*** LinPeiWen has joined #openstack-nova | 09:07 | |
*** derekh has joined #openstack-nova | 09:08 | |
*** jangutter has joined #openstack-nova | 09:09 | |
*** zzzeek has quit IRC | 09:11 | |
*** zzzeek has joined #openstack-nova | 09:13 | |
*** zzzeek has quit IRC | 09:27 | |
*** JamesBenson has joined #openstack-nova | 09:29 | |
*** zzzeek has joined #openstack-nova | 09:30 | |
*** martinkennelly has joined #openstack-nova | 09:31 | |
*** JamesBenson has quit IRC | 09:33 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/pike: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766497 | 09:35 |
*** ociuhandu has joined #openstack-nova | 09:37 | |
*** jangutter_ has joined #openstack-nova | 09:52 | |
*** jangutter has quit IRC | 09:55 | |
*** k_mouza has joined #openstack-nova | 09:59 | |
*** martinkennelly has quit IRC | 10:11 | |
*** vishalmanchanda has quit IRC | 10:22 | |
*** rpittau is now known as rpittau|bbl | 10:27 | |
*** vishalmanchanda has joined #openstack-nova | 10:30 | |
gibi | bauzas: regarding the rbac thing I need to rely on gmann but as far as I know we did similar things in nova in Victoria | 10:37 |
bauzas | yup for sure | 10:37 |
gibi | bauzas: regarding the lower constraint fix I that is needed to unblock the placement gate | 10:37 |
bauzas | let's wait for gmann's reply | 10:37 |
*** spatel has joined #openstack-nova | 10:39 | |
*** ociuhandu has quit IRC | 10:40 | |
*** spatel has quit IRC | 10:44 | |
*** zzzeek has quit IRC | 10:45 | |
*** zzzeek has joined #openstack-nova | 10:47 | |
*** zzzeek has quit IRC | 10:53 | |
*** zzzeek has joined #openstack-nova | 10:56 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add requested_networks field to RequestSpec object https://review.opendev.org/c/openstack/nova/+/749977 | 10:57 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | 10:57 |
*** dtantsur|afk is now known as dtantsur | 11:00 | |
*** avolkov has quit IRC | 11:12 | |
*** zzzeek has quit IRC | 11:16 | |
*** zzzeek has joined #openstack-nova | 11:20 | |
*** ociuhandu has joined #openstack-nova | 11:21 | |
*** ociuhandu has quit IRC | 11:25 | |
*** JamesBenson has joined #openstack-nova | 11:30 | |
*** JamesBenson has quit IRC | 11:34 | |
*** zzzeek has quit IRC | 11:39 | |
*** zzzeek has joined #openstack-nova | 11:40 | |
gibi | does somebody already looked into the volume handling timeout happening fairly frequently on master in tempest? there is a long timeout (196s) that runs out in various volume handling operations | 11:50 |
gibi | e.g. detach | 11:50 |
*** zzzeek has quit IRC | 11:50 | |
*** zzzeek has joined #openstack-nova | 11:55 | |
*** mgariepy has quit IRC | 11:59 | |
*** JamesBenson has joined #openstack-nova | 12:00 | |
lyarwood | gibi: I have not but I can if you point me at an example | 12:01 |
* lyarwood has been working on downstream things all week thus far sorry | 12:01 | |
elod | lyarwood: I'm back from PTO and I can work with the 'make LC non-voting' patch if you need help with that | 12:01 |
gibi | lyarwood: no started looking at https://zuul.opendev.org/t/openstack/build/fce6478a6842495f851b8c88336f0049 | 12:01 |
gibi | now | 12:01 |
lyarwood | elod: cool, as above I haven't had much time to push things along | 12:01 |
lyarwood | elod: if you want to try get https://review.opendev.org/c/openstack/nova/+/766738 passing that would be awesome | 12:02 |
elod | lyarwood: sure, I'll look at that patch too! thanks :) | 12:04 |
*** JamesBenson has quit IRC | 12:08 | |
*** JamesBenson has joined #openstack-nova | 12:08 | |
*** zzzeek has quit IRC | 12:10 | |
*** zzzeek has joined #openstack-nova | 12:10 | |
openstackgerrit | Elod Illes proposed openstack/nova stable/ussuri: [stable-only] lower-contraints: Bump various packages https://review.opendev.org/c/openstack/nova/+/766738 | 12:21 |
*** raildo has joined #openstack-nova | 12:25 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: add openstack-python3-wallaby-jobs-arm64 job https://review.opendev.org/c/openstack/nova/+/742094 | 12:31 |
lyarwood | gibi: so I think this is just a race between the instance delete and following volume delete | 12:32 |
lyarwood | gibi: we need the volume to be listed as available before we try to delete it | 12:32 |
gibi | so we need to wait for the instance to be deleted? | 12:32 |
lyarwood | gibi: trying to write this up in a tempest bug now | 12:32 |
lyarwood | gibi: it's technically async to that | 12:32 |
lyarwood | gibi: n-cpu deletes the volume attachment and that eventually leads c-vol to mark the volume as available again | 12:33 |
lyarwood | gibi: I just need to trace the cinder side through to confirm the race but n-cpu hasn't logged the call to delete the volume attachment for some reason | 12:33 |
gibi | ohh, so we would neet to wait for the volume become available before we call delete on it | 12:33 |
lyarwood | yeah indeed | 12:33 |
lyarwood | that's awkward but that's life with async APIs | 12:33 |
gibi | yeah, I think that is OK to add as a fix | 12:34 |
gibi | lyarwood: so the tearDownClass() needs to be smarter or we need to extend a specific test case? | 12:36 |
lyarwood | oh wait, actually it looks like n-cpu didn't delete the attachment | 12:37 |
*** teoobo_ has joined #openstack-nova | 12:44 | |
teoobo_ | stephenfin: thanks for the code review | 12:45 |
*** ratailor has quit IRC | 12:46 | |
lyarwood | gibi: ah ha! it's actually slow snapshot creation in c-vol that's causing this | 12:55 |
lyarwood | gibi: that's also async | 12:55 |
lyarwood | gibi: there's a TODO from Matt in the test that we should sort out to handle this, adding a waiter on the snapshot state etc | 12:55 |
gibi | lyarwood: I admire you that you was able to found this, I alway lost in the cinder logs | 12:56 |
*** ociuhandu has joined #openstack-nova | 12:58 | |
*** zzzeek has quit IRC | 12:58 | |
*** zzzeek has joined #openstack-nova | 12:58 | |
gibi | is there a way I can help fixing this in tempest? | 12:58 |
gibi | I mean is it easy (for somebody like me without much tempest knowledge) to fix in tempest? | 13:00 |
lyarwood | gibi: haha thanks, I didn't have to sacrifice anything or anyone this time ;) | 13:04 |
lyarwood | gibi: so I think we just need to wait until the volume snapshot is ready | 13:04 |
gibi | I can hack on that if you have better things to do | 13:04 |
lyarwood | gibi: the issue here is that we are using the Nova imageCreate API that creates the volume snapshot for us indirectly | 13:04 |
lyarwood | gibi: no I can write this up and fix it | 13:04 |
gibi | cool, thanks | 13:05 |
lyarwood | gibi: just need to extract the volume snapshot details from the image metadata | 13:05 |
*** mgariepy has joined #openstack-nova | 13:07 | |
*** macz_ has joined #openstack-nova | 13:07 | |
*** macz_ has quit IRC | 13:07 | |
gibi | so it is not _that_ simple :) | 13:08 |
lyarwood | https://bugs.launchpad.net/tempest/+bug/1908269 | 13:10 |
openstack | Launchpad bug 1908269 in tempest "test_snapshot_volume_backed_multiattach not waiting for volume snapshot to become available" [Undecided,New] | 13:10 |
lyarwood | haha no nothing to do with bdms is | 13:10 |
*** rpittau|bbl is now known as rpittau | 13:12 | |
*** zzzeek has quit IRC | 13:13 | |
*** zzzeek has joined #openstack-nova | 13:16 | |
*** songwenping_ has joined #openstack-nova | 13:20 | |
*** brinzhang has quit IRC | 13:21 | |
*** brinzhang has joined #openstack-nova | 13:22 | |
*** swp20 has quit IRC | 13:22 | |
*** brinzhang has quit IRC | 13:23 | |
*** brinzhang has joined #openstack-nova | 13:23 | |
gibi | lyarwood: thanks for the bugreport | 13:25 |
lyarwood | gibi: np, just rebuilding a devstack env, the fix should be trivial | 13:28 |
lyarwood | famous last words and all | 13:28 |
gibi | :) | 13:31 |
*** jangutter has joined #openstack-nova | 13:52 | |
*** jangutter has quit IRC | 13:52 | |
*** vishalmanchanda has quit IRC | 13:52 | |
*** jangutter has joined #openstack-nova | 13:53 | |
*** jangutter_ has quit IRC | 13:53 | |
*** jangutter has quit IRC | 13:53 | |
*** jangutter has joined #openstack-nova | 13:53 | |
*** spatel has joined #openstack-nova | 13:56 | |
gmann | gibi: bauzas checking | 13:57 |
*** mlavalle has joined #openstack-nova | 13:58 | |
*** spatel has quit IRC | 13:59 | |
openstackgerrit | Merged openstack/nova master: Remove outdated comment from tox.ini https://review.opendev.org/c/openstack/nova/+/765534 | 14:01 |
*** spatel has joined #openstack-nova | 14:01 | |
gmann | gibi: bauzas on policy stuff in placement, I am waiting for the test case to be added and then we can start review. anyways I will check and leave the comment there. | 14:10 |
bauzas | all cool | 14:10 |
gibi | gmann: thanks for following that | 14:11 |
gmann | gibi: I will update the l-c fix comments after QA office hour. | 14:12 |
gibi | gmann: cool | 14:12 |
sean-k-mooney | gibi: did you see my ping yesterday | 14:14 |
sean-k-mooney | oh you did | 14:14 |
sean-k-mooney | it still might be worht a try setting the timeout | 14:15 |
*** tbachman has quit IRC | 14:15 | |
*** efried has joined #openstack-nova | 14:22 | |
*** nweinber has joined #openstack-nova | 14:23 | |
gibi | sean-k-mooney: you want get the test to time out if it slow? or you want to prevent the test to time out when it is slow? | 14:26 |
sean-k-mooney | manila just set a 5 minute timeout to workaround slow nodes | 14:28 |
sean-k-mooney | vs the default which i think is 60 seconds | 14:28 |
gibi | sean-k-mooney: we don't have per test timeout I saw these test run and pass after 300 seconds on the gate | 14:30 |
sean-k-mooney | thats what the manila patch added | 14:30 |
gibi | hm, I saw these in the nova test suite | 14:31 |
sean-k-mooney | https://review.opendev.org/c/openstack/manila/+/291397/ | 14:31 |
gibi | sean-k-mooney: yeah, I saw this patch yesterday, what I say is that in nova we don't have a per test case timeout, and also I see that in nova these tests run for a long time (both in case of failing or passing) | 14:33 |
gibi | so I don't see how the extra timeout for these tests would help | 14:36 |
gibi | logstash don't want to help me know to show some examples | 14:37 |
gibi | I only found one: TestNovaAPIMigrationsWalkMySQL.test_walk_versions [192.038984s] ... FAILED | 14:37 |
gibi | TestNovaAPIMigrationsWalkPostgreSQL.test_walk_versions [43.027941s] | 14:37 |
*** ralonsoh has quit IRC | 14:40 | |
*** ralonsoh has joined #openstack-nova | 14:41 | |
sean-k-mooney | ah ok so its likely not a timeout issue | 14:41 |
sean-k-mooney | i did see a timeout in one of the logs | 14:42 |
sean-k-mooney | but i asumed that was a test timeout | 14:42 |
gibi | sean-k-mooney: link me the timeout case then I can double check that | 14:43 |
gibi | I see them failing after random amont of time. the only time sensitvity I can see is that when it fails then the execution is slower then when it passes | 14:44 |
gibi | but I saw slow passing executions too | 14:44 |
gibi | I just haven't seen a fast failing execution | 14:44 |
openstackgerrit | Ghanshyam proposed openstack/nova stable/rocky: DNM: testing gate https://review.opendev.org/c/openstack/nova/+/767027 | 14:54 |
*** LinPeiWen has quit IRC | 14:54 | |
*** hemanth_n has quit IRC | 14:58 | |
lyarwood | gibi: https://review.opendev.org/c/openstack/tempest/+/767165 btw, should resolve this. | 14:58 |
lyarwood | gibi: did you write an ER query for this btw? | 14:58 |
* lyarwood isn't sure it's worth it with the fix up now but could write one if you haven't | 14:59 | |
openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/766994 | 14:59 |
gibi | lyarwood: I haven't as I was not able to find the root cause | 14:59 |
lyarwood | k np | 14:59 |
gibi | lyarwood: and I agree that as we have the fix the ER query is less important now | 14:59 |
gibi | lyarwood: thanks for the tempest fix | 15:01 |
gibi | I might ping in the future with cinder timeouts :) | 15:01 |
gibi | I might ping _you_ :) | 15:03 |
lyarwood | gibi: always happy to help, even if it debugging cinder timeouts ;) | 15:05 |
lyarwood | it is* | 15:05 |
gibi | honestly, I'm so lost in cinder that I alway get stuck with these failures, give up and go do something else :) | 15:06 |
*** lpetrut has quit IRC | 15:07 | |
*** ociuhandu has quit IRC | 15:07 | |
lyarwood | gibi: I'm the same with Neutron and PCI stuff tbh | 15:08 |
lyarwood | actually not the PCI stuff anymore | 15:09 |
gibi | lyarwood: you can ping me with PCI stuff if needed | 15:09 |
gibi | ohh | 15:09 |
gibi | bumer | 15:09 |
lyarwood | but the Neutron flows still confuse the hell out of me | 15:09 |
gibi | I have nothing to offer :D | 15:09 |
bauzas | hmmm, TIL I learned that AZ is mandatory even if the doc says it's optional https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id70 | 15:10 |
bauzas | gibi: others ^ | 15:10 |
*** ociuhandu has joined #openstack-nova | 15:10 | |
*** ociuhandu has quit IRC | 15:10 | |
bauzas | https://docs.openstack.org/api-ref/compute/?expanded=unshelve-restore-shelved-server-unshelve-action-detail#unshelve-restore-shelved-server-unshelve-action | 15:11 |
bauzas | availability_zone (Optional) | 15:11 |
bauzas | 15:11 | |
bauzas | body | 15:11 |
bauzas | 15:11 | |
bauzas | string | 15:11 |
bauzas | 15:11 | |
bauzas | The availability zone name. Specifying an availability zone is only allowed when the server status is SHELVED_OFFLOADED otherwise a 409 HTTPConflict response is returned. | 15:11 |
bauzas | New in version 2.77 | 15:11 |
bauzas | what the heck it is | 15:11 |
* bauzas grumbles at https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L31 | 15:11 | |
bauzas | so, basically, if you use the latest microversion, we break you | 15:12 |
bauzas | you need to pass a specific AZ | 15:12 |
bauzas | when unshelving | 15:12 |
lyarwood | https://github.com/openstack/nova/blob/240ee3091c5ec458753983afa90e3a0cc11dc322/nova/api/openstack/compute/shelve.py#L95-L98 | 15:13 |
gibi | bauzas: is it an api ref doc bug or a code bug? | 15:13 |
lyarwood | so wouldn't {'unshelve': null} still work? | 15:13 |
bauzas | lyarwood: no | 15:14 |
bauzas | see https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L31 | 15:14 |
bauzas | gibi: well, the doc says it's an optional field | 15:14 |
bauzas | and honestly, I don't know why it should be a mandatory field | 15:14 |
* bauzas looks at the spec | 15:15 | |
bauzas | I'm a bit afraid we ask AZs everytime people want to unshelve | 15:15 |
gibi | bauzas: would it be defaulted to 'nova' if not provided? | 15:15 |
lyarwood | I think {'unshelve': null} still works looking at the API code at least | 15:15 |
bauzas | lyarwood: no because of the schema | 15:15 |
bauzas | lyarwood: and I tested it | 15:15 |
lyarwood | huh it lists null as an acceptable type above | 15:16 |
gibi | hm, maybe we made the same too strict then, the code works without az provided | 15:16 |
lyarwood | kk if you've tested it then | 15:16 |
gibi | ohh, null is special cased | 15:16 |
bauzas | gibi: lyarwood: http://paste.openstack.org/show/801061/ | 15:16 |
gibi | so unshelve: null OK but unshelve:{} is not | 15:17 |
bauzas | anyway, I need to get my kids | 15:17 |
* bauzas goes off for 30 mins | 15:17 | |
lyarwood | Value: {} | 15:17 |
lyarwood | ack np | 15:17 |
gibi | I vaguely remember other cases when we disallow {} for a server action | 15:18 |
gibi | yepp, we have similar construct for lock, migrate and rescue, but they are not the same as they not require anything in {}. So it is interesting why we deviated from this pattern in case of unshelve | 15:23 |
gibi | gmann: I still think we should not try to satify both W503 and W504 at the same time just for the sake of the rules as it does not promote a good code style in my eyes | 15:27 |
gmann | gibi: if we make all operator in same line with bracket '(' then W503 is automatically solved. that give more consistency also. | 15:30 |
gmann | I mean fixing it in that consistent way automatically solve the both | 15:30 |
gibi | gmann: as far as I see you wrapped only the parts of the condition into and extra () that is over the line length | 15:32 |
gibi | (amount_needed < min_unit or amount_needed > max_unit or ( | 15:32 |
gibi | amount_needed % step_size != 0)) | 15:32 |
gibi | eg ^^ | 15:32 |
gibi | here it is strange why we have an extra () only for the last or but not the other ors | 15:33 |
gibi | I still think that we should not try to satisfy both W504 and W503 at the same time. we should decide to wrap the line before the operatr (504) or after the operator (503) | 15:34 |
*** ociuhandu has joined #openstack-nova | 15:37 | |
*** k_mouza has quit IRC | 15:38 | |
*** k_mouza has joined #openstack-nova | 15:39 | |
*** markmcclain has joined #openstack-nova | 15:39 | |
openstackgerrit | Matteo Sposato proposed openstack/nova master: Refactoring of functional.regression.test_bug_1702454 https://review.opendev.org/c/openstack/nova/+/765997 | 15:40 |
*** dklyle has joined #openstack-nova | 15:41 | |
*** arne_wiebalck has quit IRC | 15:43 | |
openstackgerrit | Matteo Sposato proposed openstack/nova master: Refactoring of functional.regression.test_bug_1702454 https://review.opendev.org/c/openstack/nova/+/765997 | 15:45 |
openstackgerrit | Matteo Sposato proposed openstack/nova master: Functional tests remmoved direct post call https://review.opendev.org/c/openstack/nova/+/766068 | 15:45 |
*** ociuhandu has quit IRC | 15:45 | |
*** arne_wiebalck has joined #openstack-nova | 15:46 | |
*** ociuhandu has joined #openstack-nova | 15:46 | |
openstackgerrit | Matteo Sposato proposed openstack/nova master: Functional tests removed direct post call https://review.opendev.org/c/openstack/nova/+/766068 | 15:47 |
*** ociuhandu has quit IRC | 15:51 | |
gmann | gibi: ok. so doing in nova way and ignore W504 ? | 15:53 |
gibi | gmann: that would give us the consistency with nova too. So yes. If I would start a new project then I might use W504 instead and keep the binary operator at the beginnig of the line as that feels like the more imporant information. | 15:55 |
gmann | gibi: yeah, i think consistency is imp for easy maintenance. will update the patch. | 15:55 |
gibi | gmann: thanks, I hope I did not sound too demanding above | 15:58 |
*** ralonsoh has quit IRC | 15:58 | |
gmann | gibi: no, it would take much time, i think less things to fix may be :) | 15:58 |
*** ralonsoh has joined #openstack-nova | 15:59 | |
*** songwenping_ has quit IRC | 15:59 | |
*** songwenping_ has joined #openstack-nova | 16:00 | |
gibi | gmann: yeah, the above example pass W503 without the extra () | 16:00 |
gibi | at least I think | 16:00 |
gibi | it does | 16:00 |
gmann | yeah, there are only few with W503 i think. | 16:01 |
*** mgariepy has quit IRC | 16:02 | |
*** ociuhandu has joined #openstack-nova | 16:04 | |
*** ociuhandu has quit IRC | 16:08 | |
*** ociuhandu has joined #openstack-nova | 16:08 | |
*** ralonsoh has quit IRC | 16:15 | |
*** ralonsoh has joined #openstack-nova | 16:15 | |
openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/767182 | 16:20 |
openstackgerrit | Ghanshyam proposed openstack/placement master: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/766994 | 16:21 |
gibi | gmann: do you wanted to push two separate patches for this ^^ ? | 16:22 |
gmann | gibi: i meshed up the commit id initially. abandon the new commit and kept in old one | 16:23 |
*** ralonsoh has quit IRC | 16:23 | |
gmann | gibi: this is all good now https://review.opendev.org/c/openstack/placement/+/766994 | 16:23 |
gibi | looking... | 16:23 |
gmann | need to have strong coffee i think :) | 16:24 |
bauzas | gibi: lyarwood: I'm back, should I write then some bug asking to support {} for the unshelve action | 16:25 |
gibi | I was lazy today to brew coffee, trying to survive with black tea | 16:25 |
bauzas | ? | 16:25 |
gibi | bauzas: I think that is a reasonable think to ask for | 16:25 |
gibi | I don't see why we forbid the unshelve: {} format | 16:25 |
gibi | brinzhang: do you happen to rememeber the reasoning here ^^ | 16:26 |
gibi | brinzhang: we are trying to figure out why your patch made the az mandatory in https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L31 | 16:27 |
bauzas | gibi: thanks, let's wait for brinzhang | 16:28 |
sean-k-mooney | isnt it an instance action | 16:28 |
sean-k-mooney | dont we need the action in the payload | 16:28 |
gibi | sean-k-mooney: the action is unshelve | 16:28 |
gibi | so that is alway in the payload | 16:28 |
sean-k-mooney | https://docs.openstack.org/api-ref/compute/?expanded=unshelve-restore-shelved-server-unshelve-action-detail#unshelve-restore-shelved-server-unshelve-action | 16:28 |
gibi | but unshelve has an optional parameter the az | 16:28 |
sean-k-mooney | ya so { | 16:28 |
sean-k-mooney | "unshelve": null | 16:29 |
sean-k-mooney | } | 16:29 |
sean-k-mooney | Example Unshelve server (unshelve | 16:29 |
sean-k-mooney | is allowed | 16:29 |
sean-k-mooney | you are just suggesting {} instead of null | 16:29 |
*** ralonsoh has joined #openstack-nova | 16:29 | |
sean-k-mooney | if so sure that seams fine | 16:29 |
gibi | sean-k-mooney: yeah we could allow both as far as I see | 16:29 |
gibi | sean-k-mooney: and lock, migrate and rescue allows it | 16:29 |
*** ociuhandu has quit IRC | 16:31 | |
sean-k-mooney | yep anyway got to go to a doctors apointment ill be back online tomorrow | 16:31 |
gibi | sean-k-mooney: o/ | 16:31 |
gibi | bauzas: you can send https://review.opendev.org/c/openstack/placement/+/766994 thorugh if you wish | 16:32 |
gmann | yeah for most of server action request body are like 'allowed anything but API ignore those' | 16:32 |
bauzas | gibi: looking | 16:33 |
bauzas | all good | 16:33 |
gibi | thanks bauzas | 16:34 |
*** ociuhandu has joined #openstack-nova | 16:34 | |
bauzas | sec | 16:35 |
*** jamesdenton has quit IRC | 16:36 | |
*** jamesden_ has joined #openstack-nova | 16:36 | |
*** ociuhandu has quit IRC | 16:39 | |
bauzas | gibi: gmann: I'm unclear, https://review.opendev.org/c/openstack/placement/+/766994/9/placement/conf/database.py changes aren't related to neither W503 nor W504 | 16:41 |
bauzas | and while we don't accept single lines in modules, we accept in nova indentations like L58 | 16:42 |
gmann | bauzas: that is E128 | 16:42 |
bauzas | yup, I was looking at https://www.flake8rules.com/rules/E128.html | 16:43 |
bauzas | but E128 anti-pattern is accepted by nova IIRC | 16:43 |
bauzas | and tbc, my concern is that you're changing for supporting E128 without explaining why | 16:44 |
gmann | yeah in nova we ignored E128 https://github.com/openstack/nova/blob/master/tox.ini#L259 | 16:44 |
gmann | bauzas: placement was using too old hacking checks. | 16:44 |
gmann | moving to new one end up with these multiple updates | 16:45 |
*** k_mouza has quit IRC | 16:47 | |
bauzas | gmann: okay, but then why not ignoring E128 and then not modify all the placement code ? | 16:47 |
gmann | gibi: bauzas we can. even we can keep the same ignore list as in nova https://github.com/openstack/nova/blob/master/tox.ini#L259 | 16:47 |
bauzas | gmann: I'd indeed prefer this way | 16:47 |
bauzas | given we did cut from nova | 16:47 |
gmann | so that we can keep future consistency also | 16:48 |
bauzas | when branching placement | 16:48 |
gmann | bauzas: ok, let me update that. | 16:48 |
bauzas | gibi: thoughts on it ? | 16:48 |
gmann | k, waiting for gibi. | 16:49 |
gibi | I'm meh on this. I think the new rules are meaningful and pretty cheap to introduce in placement so I'm happy to take them in | 16:49 |
gibi | introducing them to nova would make a lot of code change I guess | 16:49 |
stephenfin | I'd rather we kept the default list too | 16:49 |
gibi | stephenfin: default, meansh what is in nova's tox.ini? | 16:49 |
stephenfin | probably not worth the effort for nova, but the placement changes are done already | 16:49 |
stephenfin | no, what's in placement's tox.ini now | 16:50 |
*** ociuhandu has joined #openstack-nova | 16:50 | |
gibi | yeah, I tend to agree with stephenfin | 16:50 |
gmann | yeah there are no other changes need in placement for those checks | 16:50 |
bauzas | my point is that we're changing placement code for the sake of a new hacking revision | 16:50 |
bauzas | I'd rather prefer to make nova and placement consistent in terms of style | 16:50 |
bauzas | besides the fact this would allow us to merge this change without needing to touch at the code | 16:51 |
bauzas | and later, we could just unignore rules one by one in placement if we really wish | 16:51 |
bauzas | baby steps, here, baby steps | 16:51 |
bauzas | 1/ upgrade hacking and ignore same list | 16:52 |
bauzas | 2/ unignore a specific rule and modify the code accordingly | 16:52 |
bauzas | 3/ iterate over every ignored rule | 16:52 |
gibi | bauzas: if you are after to split the hacking version change and the introdcution of new rules into separate patches then fine, but the current patch is not too big too | 16:52 |
gmann | bauzas: but this change with not-ignoring does not change much code | 16:52 |
stephenfin | if there were a significant amount of changes then I'd agree, but it doesn't seem worth the effort here | 16:52 |
bauzas | gibi: the problem is that we are silently changing placement without really explaining which hacking errors we wanted to fixc | 16:53 |
gibi | bauzas: sure, we can add a list of new rules applied to the commit message | 16:53 |
bauzas | and I don't think it's hard to just split this change in twice if you really want to unignore E128 and all the other rules | 16:53 |
gibi | OK, I'm fine in both ways: a) add a bit more text the commit message about the new rules that required the code change OR b) split the current patch into two | 16:54 |
gmann | giving it unblock the gate I preferred to move the code to latest hacking which is easy than doing one by one. | 16:54 |
gibi | gmann: agree, new hacknig is better | 16:55 |
gmann | I can add checks fix in commit msg. | 16:55 |
stephenfin | I don't think E128 is a big issue. W503/W504 seem to be the bulk of it. We could drop one of those, seeing as they conflict | 16:55 |
gmann | yeah W504 is ignored now | 16:55 |
stephenfin | sweet, then I don't care :) | 16:56 |
gmann | https://review.opendev.org/c/openstack/placement/+/766994/9/tox.ini | 16:56 |
bauzas | phew ok | 16:57 |
bauzas | I just feel we're overcomplicating | 16:57 |
bauzas | bumping hacking and providing the right ignore list will allow the gate to pass without needing to touch code | 16:57 |
bauzas | unless I'm missing something obvious | 16:58 |
bauzas | my take is, gmann had to touch code instead of amending the ignore list in order to fix the gate, I just feel it was unnecessary | 16:58 |
stephenfin | bauzas: not quite; a couple of the checks have been improved in newer versions of flake8 etc. To ignore those you'd have to disable the check and actually regress | 16:58 |
bauzas | stephenfin: why then nova isn't a problem ? | 16:59 |
stephenfin | because we fixed them there | 16:59 |
stephenfin | example: https://review.opendev.org/c/openstack/placement/+/766994/9/placement/conf/database.py | 16:59 |
stephenfin | that extra newline was (mistakenly) not required in an old version of flake8 | 16:59 |
bauzas | for the extra newline, OK | 17:00 |
bauzas | for the continuous indentation, that's still there | 17:00 |
bauzas | so, ok, I mixed things | 17:00 |
gmann | nova is on 3.1.0. i could move placement too to that but 4.0.0 is already out to moving to it is easy. | 17:00 |
bauzas | gmann has to fix single lines within modules, but can just continue to leave uncontinuous indentation if he wishes | 17:01 |
gmann | anyways code is up and green so merging it is faster than splitting the patch now | 17:01 |
* bauzas shrugs | 17:01 | |
bauzas | well, I'm OK to remove my -1 for the sake of merging | 17:02 |
bauzas | but honestly, this is confisuing | 17:03 |
gmann | bauzas: how about if i explain those check fixes in cmt msg ? | 17:04 |
bauzas | I'm just saying we're again touching code for the beauty of our eyes and we're overcomplicating things, exactly like we did a couple of times in nova | 17:04 |
bauzas | but meh, I bail out | 17:04 |
bauzas | so, stephenfin can look at the change, I removed my -1 | 17:05 |
* gibi already bailed :D | 17:05 | |
bauzas | the +2 from gibi is there, so... | 17:05 |
gibi | yeah | 17:05 |
gibi | honestly I don't feel this as such a big issue | 17:05 |
gibi | but that jsutme | 17:05 |
gibi | just me | 17:05 |
gmann | bauzas: you seems do not like hacking checks much :) | 17:05 |
bauzas | it's more or less a matter of touching production code for the sake of ourselves being pedantic :) | 17:06 |
bauzas | but okay | 17:06 |
bauzas | gmann: well, I'm just pragmatic about things that work | 17:07 |
bauzas | but fair enough | 17:07 |
gmann | I see your point. | 17:08 |
*** mgariepy has joined #openstack-nova | 17:15 | |
*** k_mouza has joined #openstack-nova | 17:19 | |
stephenfin | ta, done | 17:20 |
*** teoobo__ has joined #openstack-nova | 17:24 | |
*** k_mouza has quit IRC | 17:24 | |
*** hamalq has joined #openstack-nova | 17:25 | |
*** teoobo_ has quit IRC | 17:26 | |
*** hamalq_ has joined #openstack-nova | 17:27 | |
*** teoobo__ has quit IRC | 17:28 | |
*** dtantsur is now known as dtantsur|afk | 17:29 | |
*** hamalq has quit IRC | 17:31 | |
stephenfin | gmann: Could you look at https://review.opendev.org/c/openstack/nova/+/765798/ at some point? | 17:33 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Merge 'test_hypervisor_status' into 'test_hypervisors' https://review.opendev.org/c/openstack/nova/+/764039 | 17:33 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Drop statistics-style fields from os-hypervisors https://review.opendev.org/c/openstack/nova/+/764040 | 17:33 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Change default policy for '/os-hypervisors' https://review.opendev.org/c/openstack/nova/+/765798 | 17:33 |
stephenfin | I'm not sure if I'm tackling that correctly | 17:33 |
stephenfin | Also, resolved your comment on https://review.opendev.org/c/openstack/nova/+/764039 | 17:33 |
gmann | stephenfin: sure, checking | 17:33 |
stephenfin | lyarwood: you'd probably be interested in this at some point https://bugs.launchpad.net/nova/+bug/1906266 | 17:36 |
openstack | Launchpad bug 1906266 in OpenStack Compute (nova) "After upgrade: "libvirt.libvirtError: Requested operation is not valid: format of backing image %s of image %s was not specified"" [Undecided,New] | 17:36 |
*** tesseract has quit IRC | 17:36 | |
lyarwood | stephenfin: didn't we fix that a while ago? | 17:37 |
* lyarwood looks | 17:37 | |
stephenfin | yup, they're saying the fix is incomplete | 17:37 |
gmann | stephenfin: yeah that is right way, as system scope is disable by default and we still have old legacy rule in deprecated rule so we are good, - https://review.opendev.org/c/openstack/nova/+/765798/2/nova/policies/hypervisors.py#b37 | 17:37 |
lyarwood | oh for existing images you actually need to add the backing format in, there's nothing n-cpu can do iirc | 17:38 |
gmann | stephenfin: no microversion needed for policy default, but please add releasenotes for that. I am checking other patches in that series | 17:38 |
stephenfin | gmann++ Great, thanks :) | 17:38 |
lyarwood | tbh I thought this was relaxed | 17:38 |
openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | 17:39 |
stephenfin | maybe it was; they don't give any details about the versions they're using | 17:39 |
stephenfin | lyarwood: https://github.com/libvirt/libvirt/commit/ae9e6c2a2b75d958995c661f7bb64ed4353a6404 | 17:43 |
stephenfin | the few patches I grepped from https://www.redhat.com/archives/libvir-list/2020-February/msg00616.html appear to be in v6.1.0 | 17:44 |
lyarwood | ah! | 17:46 |
lyarwood | the error is still there but we don't get there now | 17:46 |
*** rpittau is now known as rpittau|afk | 17:46 | |
stephenfin | that's my reading of it too, yeah | 17:47 |
ganso | Hi nova folks! Yesterday I logged bug https://bugs.launchpad.net/nova/+bug/1908133 and it has been closed as a duplicated. I'd like to discuss what possible workarounds there are (there are no mentions of workarounds in the duplicate entry). In my "steps to reproduce" I took 2 different approaches, the second one being relying on placement to control the shared allocations, but it is quite 100%, as I am not sure I am configuring it correctly. The | 17:50 |
openstack | Launchpad bug 1522307 in OpenStack Compute (nova) "duplicate for #1908133 Disk usage not work for shared storage" [Medium,Confirmed] | 17:50 |
ganso | instructions in the placement docs are not very detailed to achieve what I need. Is anyone familiar with this use case or can think of any possible workarounds? | 17:50 |
*** ociuhandu_ has joined #openstack-nova | 17:52 | |
*** ociuhandu has quit IRC | 17:55 | |
*** ociuhandu_ has quit IRC | 17:57 | |
*** derekh has quit IRC | 18:00 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Change default policy for '/os-hypervisors' https://review.opendev.org/c/openstack/nova/+/765798 | 18:06 |
*** k_mouza has joined #openstack-nova | 18:43 | |
*** k_mouza has quit IRC | 18:52 | |
*** gyee has joined #openstack-nova | 19:00 | |
jawad_axd | Hi folks! Error 43, windows 10 with gpu passthrough. Added img_hide_hypervisor_id=True to image property. Is there anything I need to do to load nvidia drivers in windows instance? | 19:13 |
jawad_axd | *anything else | 19:14 |
*** andrewbonney has quit IRC | 19:17 | |
*** artom has quit IRC | 19:25 | |
*** adrian-a has joined #openstack-nova | 19:29 | |
openstackgerrit | Ghanshyam proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | 19:48 |
openstackgerrit | Ghanshyam proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | 19:49 |
openstackgerrit | Elod Illes proposed openstack/nova stable/ussuri: [stable-only] fix lower-constraints and disable qos resize https://review.opendev.org/c/openstack/nova/+/766738 | 20:02 |
*** artom has joined #openstack-nova | 20:42 | |
*** lbragstad has quit IRC | 20:43 | |
openstackgerrit | Merged openstack/nova master: libvirt: make cross cell resize spawn from snapshot image https://review.opendev.org/c/openstack/nova/+/765561 | 20:44 |
*** jawad_axd has quit IRC | 20:59 | |
*** raildo has quit IRC | 21:03 | |
*** JamesBenson has quit IRC | 21:13 | |
*** JamesBenson has joined #openstack-nova | 21:14 | |
*** ociuhandu has joined #openstack-nova | 21:17 | |
*** JamesBenson has quit IRC | 21:19 | |
*** rcernin has joined #openstack-nova | 21:25 | |
*** ociuhandu_ has joined #openstack-nova | 21:26 | |
*** ociuhandu has quit IRC | 21:29 | |
*** ociuhandu has joined #openstack-nova | 21:30 | |
*** k_mouza has joined #openstack-nova | 21:31 | |
*** ociuhandu_ has quit IRC | 21:32 | |
*** k_mouza has quit IRC | 21:35 | |
*** nweinber has quit IRC | 21:41 | |
*** jangutter_ has joined #openstack-nova | 21:42 | |
*** ociuhandu_ has joined #openstack-nova | 21:44 | |
*** ociuhandu has quit IRC | 21:45 | |
*** jangutter has quit IRC | 21:45 | |
*** ociuhandu has joined #openstack-nova | 21:45 | |
*** ociuhandu_ has quit IRC | 21:46 | |
*** ociuhandu_ has joined #openstack-nova | 21:46 | |
*** ociuhand_ has joined #openstack-nova | 21:48 | |
*** JamesBenson has joined #openstack-nova | 21:49 | |
*** ociuhandu_ has quit IRC | 21:49 | |
*** ociuhandu has quit IRC | 21:49 | |
*** lbragstad has joined #openstack-nova | 21:53 | |
*** JamesBenson has quit IRC | 21:54 | |
*** trident has quit IRC | 21:56 | |
*** markguz_ has joined #openstack-nova | 21:56 | |
*** trident has joined #openstack-nova | 22:00 | |
*** spatel has quit IRC | 22:11 | |
*** markguz_ has quit IRC | 22:38 | |
*** JamesBenson has joined #openstack-nova | 22:51 | |
*** ociuhand_ has quit IRC | 22:58 | |
*** macz_ has joined #openstack-nova | 23:09 | |
*** adrian-a has quit IRC | 23:20 | |
*** k_mouza has joined #openstack-nova | 23:31 | |
*** slaweq has quit IRC | 23:32 | |
*** k_mouza has quit IRC | 23:36 | |
*** artom has quit IRC | 23:47 | |
*** artom has joined #openstack-nova | 23:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!