Wednesday, 2020-12-16

*** tosky has quit IRC00:04
openstackgerritGhanshyam proposed openstack/placement master: Remove deprecated [placement]/policy_file config option  https://review.opendev.org/c/openstack/placement/+/76440900:13
openstackgerritGhanshyam proposed openstack/placement master: [goal] Deprecate the JSON formatted policy file  https://review.opendev.org/c/openstack/placement/+/76439400:13
gmanngibi: bauzas stephenfin please check these two placement patches also. for json->yaml migration community goal.  https://review.opendev.org/c/openstack/placement/+/764409  https://review.opendev.org/c/openstack/placement/+/76439400:15
gmann764409 is to remove the deprecated policy_file config option which is needed for this migration00:16
*** sapd1 has quit IRC00:32
brinzhanggibi, bauzas, sean-k-mooney: Since Microversion 2.77, we support specifying an avaiability_zone to unshleve an instance, it allowed {'unshelve': null} and {'unshelve': {'availability_zone': <string>}}, but we restrict the empty dict {'unshelve': {}} as the request body for unshelve. this restrict asked by gmann in https://review.opendev.org/c/openstack/nova/+/663851/16/nova/api/openstack/compute/schemas/servers.py#66300:56
brinzhanggibi, bauzas, sean-k-mooney, gmann: this is the record https://review.opendev.org/c/openstack/nova/+/663851/13/nova/api/openstack/compute/schemas/servers.py#65900:57
*** macz_ has quit IRC00:58
gmannbrinzhang: yeah as this action API need specific request body so disallow empty make sense. for other action API there is no specific request body so allowing null or anything is what we have during legacy way00:59
brinzhangand we note that in https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L28-L3100:59
brinzhanggmann: yes, I think gibi and bauzas's concern in the docs description, because of the availability_zone is optional, but we allowed request {'unshelve': {'availability_zone': <string>}}, if we dont chose the availability_zone, it will be {'unshelve': {}01:02
gmannok and we only allow {'unshelve': null} in that case01:03
*** LinPeiWen has joined #openstack-nova01:04
gmannbrinzhang: may be we can update it in api-ref too https://docs.openstack.org/api-ref/compute/?expanded=unshelve-restore-shelved-server-unshelve-action-detail01:04
brinzhangyes, I think this is reasonable too01:04
gmannsaying 2.77 onwards01:05
brinzhanggmann: ok, let submit a patch to add a Note for the availability_zone01:05
brinzhangs/let/ let me01:06
gmann+101:06
brinzhangWill do, and pls review it later01:06
gmannthanks01:08
*** rcernin_ has joined #openstack-nova01:09
*** rcernin has quit IRC01:10
brinzhanggmann: how abot saying: Since microversion 2.77, we are allowed to request {'unshelve': null} and {'unshelve': {'availability_zone': <string>}}, but not allowed to request {'unshelve': {}}.01:12
gmannbrinzhang: yeah, little modification- Since microversion 2.77, allowed request body schema are {'unshelve': null} or {'unshelve': {'availability_zone': <string>}}, and {'unshelve': {}} request body is not allowed.01:16
*** mlavalle has quit IRC01:30
*** _mlavalle_1 has joined #openstack-nova01:30
brinzhanggmann: and let me register a bug to trace this change01:31
sean-k-mooneygmann: brinzhang  we were suggesting allowing {} ealier today01:32
sean-k-mooneyi think its perfectly consitent to treat null and {} the same01:33
gmannsean-k-mooney: {} means allowed everything or any unknown request body which is later ignored so confusing for users. where {'unshelve': null} means allow only empty request body01:35
gmannsean-k-mooney: like for {}. i can pass {'unshelve': {'unknown': 'anything', ....}}01:35
gmannthat was the reason we thought of improving it in 2.7701:36
*** k_mouza has joined #openstack-nova01:36
*** JamesBenson has quit IRC01:39
*** kevinz has joined #openstack-nova01:40
*** k_mouza has quit IRC01:41
openstackgerritBrin Zhang proposed openstack/nova master: Improving the description for az of unshleve API  https://review.opendev.org/c/openstack/nova/+/76725101:50
brinzhangsean-k-mooney: yeah, I agree with gmann, while I do the change of specifying az to unshelve a server, already talked, also with mriedem01:51
*** hoonetorg has quit IRC01:52
brinzhanggmann: done, pls review  https://review.opendev.org/c/openstack/nova/+/76725101:52
*** spatel has joined #openstack-nova01:59
*** hoonetorg has joined #openstack-nova02:03
*** artom has quit IRC02:12
*** dasp has quit IRC02:20
*** dasp has joined #openstack-nova02:21
*** hemanth_n has joined #openstack-nova02:26
*** benj_- has joined #openstack-nova02:35
*** benj_ has quit IRC02:35
*** benj_- is now known as benj_02:35
*** LinPeiWen has quit IRC02:45
*** rcernin_ has quit IRC02:46
openstackgerritMerged openstack/nova master: Refactoring of functional.regression.test_bug_1702454  https://review.opendev.org/c/openstack/nova/+/76599702:47
*** macz_ has joined #openstack-nova02:55
*** mgoddard has quit IRC02:58
*** macz_ has quit IRC03:00
*** LinPeiWen has joined #openstack-nova03:05
*** songwenping__ has joined #openstack-nova03:12
*** songwenping_ has quit IRC03:16
*** sapd1 has joined #openstack-nova03:23
*** jamesden_ has quit IRC03:29
*** sapd1 has quit IRC03:35
*** gyee has quit IRC03:43
*** macz_ has joined #openstack-nova03:46
*** macz_ has quit IRC03:50
*** littleboyfury has joined #openstack-nova03:58
*** ociuhandu has joined #openstack-nova04:13
*** ociuhandu has quit IRC04:17
*** JamesBenson has joined #openstack-nova04:24
*** JamesBenson has quit IRC04:28
*** JamesBenson has joined #openstack-nova04:29
*** littleboyfury has quit IRC04:32
*** k_mouza has joined #openstack-nova04:48
*** k_mouza has quit IRC04:53
*** sapd1 has joined #openstack-nova05:00
*** vishalmanchanda has joined #openstack-nova05:02
*** hamalq_ has quit IRC05:16
*** sapd1 has quit IRC05:17
*** JamesBenson has quit IRC05:29
*** JamesBenson has joined #openstack-nova05:30
*** JamesBenson has quit IRC05:30
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-nova05:33
*** JamesBenson has joined #openstack-nova05:35
*** spatel has quit IRC05:36
*** zzzeek has quit IRC05:39
*** JamesBenson has quit IRC05:39
*** zzzeek has joined #openstack-nova05:39
*** zzzeek has quit IRC05:46
*** zzzeek has joined #openstack-nova05:48
*** ratailor has joined #openstack-nova05:49
*** zzzeek has quit IRC06:02
*** zzzeek has joined #openstack-nova06:06
openstackgerritWenping Song proposed openstack/nova master: Resume accelerator guest state when a host is booted  https://review.opendev.org/c/openstack/nova/+/76727306:11
*** zzzeek has quit IRC07:40
*** zzzeek has joined #openstack-nova07:41
*** dklyle has quit IRC07:41
*** ociuhandu has joined #openstack-nova07:50
*** zzzeek has quit IRC07:53
*** ociuhandu has quit IRC07:54
*** zzzeek has joined #openstack-nova07:55
*** slaweq has joined #openstack-nova08:00
*** teoobo_ has joined #openstack-nova08:04
*** andrewbonney has joined #openstack-nova08:07
openstackgerritMamduh proposed openstack/os-vif stable/ussuri: Fix - os-vif fails to get the correct UpLink Representor  https://review.opendev.org/c/openstack/os-vif/+/76596708:10
*** tesseract has joined #openstack-nova08:15
openstackgerritMerged openstack/placement master: Fix l-c job and move to latest hacking 4.0.0  https://review.opendev.org/c/openstack/placement/+/76699408:16
*** rpittau|afk is now known as rpittau08:18
openstackgerritMamduh proposed openstack/os-vif stable/train: Fix - os-vif fails to get the correct UpLink Representor  https://review.opendev.org/c/openstack/os-vif/+/76597008:20
gibibrinzhang, gmann: thanks for the historical context on unshelve: {}08:22
gibiso the goal was to only allow unshelve:null but not unshelve:{'unknow': ''} but this still not mean we have to forbid unshelve:{}08:23
*** ociuhandu has joined #openstack-nova08:31
*** zzzeek has quit IRC08:31
*** tosky has joined #openstack-nova08:33
openstackgerritMamduh proposed openstack/os-vif stable/stein: Fix - os-vif fails to get the correct UpLink Representor  https://review.opendev.org/c/openstack/os-vif/+/76597408:33
*** zzzeek has joined #openstack-nova08:34
*** zzzeek has quit IRC08:39
*** zzzeek has joined #openstack-nova08:41
*** jawad_axd has joined #openstack-nova08:43
*** mgoddard has joined #openstack-nova08:46
*** ociuhandu has quit IRC08:51
openstackgerritMamduh proposed openstack/os-vif stable/rocky: Fix - os-vif fails to get the correct UpLink Representor  https://review.opendev.org/c/openstack/os-vif/+/76597708:56
*** zzzeek has quit IRC08:59
*** zzzeek has joined #openstack-nova09:00
openstackgerritMamduh proposed openstack/os-vif stable/queens: Fix - os-vif fails to get the correct UpLink Representor  https://review.opendev.org/c/openstack/os-vif/+/76598309:00
gibiI think what what brinzhang proposed in the comment of https://review.opendev.org/c/openstack/nova/+/663851/13/nova/api/openstack/compute/schemas/servers.py#659  allows unshelve: {}, unshelve:{"availability_zone": "foo"}, unshelve: null, but forbid unshelve: {"foo": "bar"}09:01
gibibauzas: you too ^^09:01
gibiwhich I think what is bauzas after09:02
*** zzzeek has quit IRC09:05
brinzhanggibi: yes, that what I want to do privous, but after talked with gmann and mriedem, I was restrict the unshelve:{} request after PS1309:05
*** mgoddard has quit IRC09:06
*** zzzeek has joined #openstack-nova09:06
gibibrinzhang: I see that gmann requested the restriction of unshelve: {},09:06
gibiI don't see mriedem requesting that though09:07
*** mgoddard has joined #openstack-nova09:07
gibigmann: could you elaborate on 01:59 < gmann> brinzhang: yeah as this action API need specific request body so disallow empty09:07
brinzhangmaybe talked in IRC, sorry, I dont have the cleayly remember09:07
gibi               make sense. for other action API there is no specific request body so allowing09:07
gibi               null or anything is what we have during legacy way09:08
gibigmann: what do you mean by specific request body? how this is differ from the lock action?09:08
gibibrinzhang: no worries, we have gmann to help :)09:08
gibi(it is just the timezone differences that will make it hard to get a decisions)09:08
brinzhanggibi: and Isubmit a patch for update the description of unshleve az parameter https://review.opendev.org/c/openstack/nova/+/76725109:09
*** zzzeek has quit IRC09:11
*** zzzeek has joined #openstack-nova09:14
*** adrian-a has joined #openstack-nova09:17
*** derekh has joined #openstack-nova09:18
*** zzzeek has quit IRC09:23
*** aarents has quit IRC09:24
*** zzzeek has joined #openstack-nova09:25
elodlyarwood if you have a minute: can you hit this one? >>> https://review.opendev.org/c/openstack/nova/+/766497 (bandit 1.7.0 is not yet yanked, so maybe it's worth to push the bandit cap fixes, too... though that's also not a quick fix...)09:28
*** adrian-a has quit IRC09:29
elodthe swift side has already merged09:29
*** adrian-a has joined #openstack-nova09:30
*** jawad_axd has quit IRC09:30
*** jawad_axd has joined #openstack-nova09:30
*** vishalmanchanda has quit IRC09:36
*** zzzeek has quit IRC09:41
lyarwoodelod: ACK'd lets do this09:41
* lyarwood -> coffee09:41
*** zzzeek has joined #openstack-nova09:42
*** tosky_ has joined #openstack-nova09:47
*** tosky is now known as Guest2437209:49
*** tosky_ is now known as tosky09:49
*** Guest24372 has quit IRC09:50
bauzasgibi: morning, saw your pings with brinzhang09:53
gibilyarwood: about the lower contraint jobs, after elod summarized the situation to me as a nova PTL I think if we got blocked on the lower constraints jobs and we have no time to fix it then make it non-voting and ask the help of the deployers relying on that job to fix it09:54
elodand just an addition: lower-constraints jobs are (mostly) fixed, so this ^^^ is only valid for the future I think09:56
elodlyarwood: thx \o/09:56
*** zzzeek has quit IRC09:57
*** lpetrut has joined #openstack-nova09:57
*** zzzeek has joined #openstack-nova09:58
bauzasdoes anyone know how to fix a blank page from Zuul with Firefox ?09:59
bauzasit does work fine with Chrome09:59
bauzasand I flushed cookes09:59
bauzascookies*09:59
*** dtantsur|afk is now known as dtantsur09:59
gibibauzas: havn't seen that problem yet in my firefox10:00
bauzasthat's weird10:00
bauzasI get the 200s10:00
bauzasbut looks like javascript is blocked or something like this10:00
bauzasah, gotcha10:01
bauzasgot a console exception10:01
bauzasException { name: "NS_ERROR_FILE_CORRUPTED", message: "", result: 2152857611, filename: "https://zuul.opendev.org/static/js/main.a8854164.chunk.js"10:01
bauzasgibi: could you try refreshing your local cache ?10:02
bauzasanyhow, the gate looks busted10:02
gibilet me check in a private mode10:02
bauzasall the jobs are in "queued" state10:03
gibibauzas: this openes for me in a private mode or in an empty firefox profile https://zuul.opendev.org/t/openstack/build/fce6478a6842495f851b8c88336f0049/log/compute1/logs/screen-c-vol.txt10:03
bauzassuper weirdo10:04
gibithere are jobs running https://zuul.opendev.org/t/openstack/status10:05
bauzasgibi: could you please tell me which main.js version you have ?10:05
gibibut we have 155 check queu10:05
bauzasmine https://zuul.opendev.org/static/js/main.a8854164.chunk.js is failing10:05
gibibauzas: on which page?10:05
gibiI have this https://zuul.opendev.org/static/js/main.67746290.chunk.js10:05
bauzasnot the same version10:06
gibiI'm not even sure it is them same main10:06
gibiwho knows10:06
*** vishalmanchanda has joined #openstack-nova10:07
bauzasgibi: this JS was loaded on https://zuul.opendev.org/t/openstack/build/fce6478a6842495f851b8c88336f0049/log/compute1/logs/screen-c-vol.txt10:08
gibiI have this as well https://zuul.opendev.org/static/js/main.a8854164.chunk.js10:08
gibiin another pag10:08
gibie10:08
bauzaswhich FF version ?10:08
bauzasmine is 83.010:08
gibi83.0 (64-bit)10:09
bauzasand the check pipeline is super late, indeed10:09
bauzasergh10:09
bauzasi'm then confused10:09
bauzasok, restarted FF and now it works...10:10
bauzaswhat the heck10:10
bauzassorry for the noise10:10
bauzasanyway, as I said, zuul is slow this morning10:10
bauzasI sent https://review.opendev.org/c/openstack/nova/+/749068/ to gerrit yesterday, but no jobs run yet10:11
*** zzzeek has quit IRC10:13
*** zzzeek has joined #openstack-nova10:14
* bauzas runs off 10:14
*** aarents has joined #openstack-nova10:22
*** jangutter has joined #openstack-nova10:22
openstackgerritWenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client  https://review.opendev.org/c/openstack/nova-specs/+/74018410:25
*** jangutter_ has quit IRC10:26
*** lbragstad has quit IRC10:31
*** lbragstad has joined #openstack-nova10:31
*** ociuhandu has joined #openstack-nova10:41
*** JamesBenson has joined #openstack-nova10:42
*** ociuhandu_ has joined #openstack-nova10:44
*** zzzeek has quit IRC10:44
*** ociuhandu_ has quit IRC10:46
*** JamesBenson has quit IRC10:47
*** zzzeek has joined #openstack-nova10:47
*** ociuhandu_ has joined #openstack-nova10:47
*** ociuhandu has quit IRC10:47
*** jangutter_ has joined #openstack-nova10:49
*** jangutter has quit IRC10:50
*** ociuhandu_ has quit IRC10:52
*** ociuhandu has joined #openstack-nova10:52
*** ociuhandu has quit IRC10:53
*** tkajinam has quit IRC10:54
*** zzzeek has quit IRC11:07
*** k_mouza has joined #openstack-nova11:08
*** zzzeek has joined #openstack-nova11:09
*** artom has joined #openstack-nova11:13
*** macz_ has joined #openstack-nova11:18
*** JamesBenson has joined #openstack-nova11:20
*** macz_ has quit IRC11:23
*** JamesBenson has quit IRC11:25
sean-k-mooneygmann: no i was suggest allowing explictly {} so null or empty dict11:32
sean-k-mooneyallowing {} does not meant allowing anytihng11:33
*** zzzeek has quit IRC11:41
*** zzzeek has joined #openstack-nova11:44
*** jangutter_ is now known as jangutter11:46
*** raildo has joined #openstack-nova11:53
*** ociuhandu has joined #openstack-nova11:55
*** zzzeek has quit IRC11:55
*** tbachman has joined #openstack-nova11:57
*** zzzeek has joined #openstack-nova11:57
*** ociuhandu has quit IRC11:59
*** JamesBenson has joined #openstack-nova12:00
*** mgariepy has quit IRC12:02
*** JamesBenson has quit IRC12:03
*** JamesBenson has joined #openstack-nova12:04
*** zzzeek has quit IRC12:11
*** k_mouza has quit IRC12:13
*** ratailor has quit IRC12:13
*** sapd1 has joined #openstack-nova12:13
*** k_mouza has joined #openstack-nova12:13
*** zzzeek has joined #openstack-nova12:13
*** songwenping__ has quit IRC12:17
*** brinzhang_ has joined #openstack-nova12:17
*** songwenping__ has joined #openstack-nova12:17
*** k_mouza has quit IRC12:17
*** zzzeek has quit IRC12:18
*** LinPeiWen has quit IRC12:20
*** zzzeek has joined #openstack-nova12:20
*** brinzhang has quit IRC12:21
*** k_mouza has joined #openstack-nova12:29
*** zzzeek has quit IRC12:31
*** zzzeek has joined #openstack-nova12:32
*** ociuhandu has joined #openstack-nova12:58
*** hemanth_n has quit IRC13:03
*** mgariepy has joined #openstack-nova13:09
*** ociuhandu has quit IRC13:12
*** ociuhandu has joined #openstack-nova13:13
openstackgerritMerged openstack/nova stable/pike: [stable-only] Cap bandit to 1.6.2  https://review.opendev.org/c/openstack/nova/+/76649713:14
*** teoobo_ has quit IRC13:15
*** ociuhandu has quit IRC13:18
openstackgerritLance Bragstad proposed openstack/placement master: Bump oslo.log version to 4.3.0  https://review.opendev.org/c/openstack/placement/+/76022913:18
openstackgerritLance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly  https://review.opendev.org/c/openstack/placement/+/76678513:18
openstackgerritLance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers  https://review.opendev.org/c/openstack/placement/+/76024013:18
openstackgerritAndrew Bonney proposed openstack/nova master: Fix URL construction for 'nova-manage placement audit'  https://review.opendev.org/c/openstack/nova/+/76734813:20
*** ociuhandu has joined #openstack-nova13:21
*** spatel has joined #openstack-nova13:22
*** ociuhandu has quit IRC13:24
*** ociuhandu has joined #openstack-nova13:24
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos  https://review.opendev.org/c/openstack/nova/+/75689513:27
openstackgerritBalazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation  https://review.opendev.org/c/openstack/nova/+/75710913:28
*** brinzhang_ has quit IRC13:29
*** brinzhang_ has joined #openstack-nova13:29
openstackgerritBalazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation  https://review.opendev.org/c/openstack/nova/+/75711013:30
openstackgerritBalazs Gibizer proposed openstack/nova master: Factor out port resource deallocation  https://review.opendev.org/c/openstack/nova/+/75711113:31
*** k_mouza has quit IRC13:31
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name  https://review.opendev.org/c/openstack/nova/+/75761413:33
*** zzzeek has quit IRC13:34
openstackgerritBalazs Gibizer proposed openstack/nova master: Support interface attach with qos ports  https://review.opendev.org/c/openstack/nova/+/75653013:34
*** zzzeek has joined #openstack-nova13:36
*** k_mouza has joined #openstack-nova13:37
openstackgerritAdit Sarfaty proposed openstack/nova master: Retry on vmware create_vm when it fails  https://review.opendev.org/c/openstack/nova/+/76458613:37
*** zzzeek has quit IRC13:45
*** nweinber has joined #openstack-nova13:48
*** zzzeek has joined #openstack-nova13:49
*** ociuhandu has quit IRC13:54
*** lbragstad has quit IRC13:54
*** lbragstad has joined #openstack-nova13:57
*** lbragstad has quit IRC13:57
*** lbragstad has joined #openstack-nova13:58
*** liuyulong has joined #openstack-nova13:59
*** lbragstad_ has joined #openstack-nova14:03
*** ociuhandu has joined #openstack-nova14:04
*** ociuhandu has quit IRC14:05
*** ociuhandu has joined #openstack-nova14:05
*** lbragstad has quit IRC14:05
*** ociuhandu has quit IRC14:08
*** ociuhandu has joined #openstack-nova14:09
*** ociuhandu has quit IRC14:29
*** brinzhang_ has quit IRC14:31
*** brinzhang_ has joined #openstack-nova14:32
*** ociuhandu has joined #openstack-nova14:40
openstackgerritElod Illes proposed openstack/nova stable/queens: [stable-only] Cap bandit to 1.6.2  https://review.opendev.org/c/openstack/nova/+/76736414:43
*** ociuhandu has quit IRC14:51
*** belmoreira has joined #openstack-nova15:01
*** zzzeek has quit IRC15:06
*** zzzeek has joined #openstack-nova15:08
*** spatel has quit IRC15:09
*** ralonsoh has quit IRC15:15
*** ralonsoh has joined #openstack-nova15:15
openstackgerritsean mooney proposed openstack/nova master: only wait for plugtime events in pre-live-migration  https://review.opendev.org/c/openstack/nova/+/76736815:19
openstackgerritBalazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation  https://review.opendev.org/c/openstack/nova/+/75710915:22
openstackgerritBalazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation  https://review.opendev.org/c/openstack/nova/+/75711015:22
*** lpetrut has quit IRC15:23
openstackgerritBalazs Gibizer proposed openstack/nova master: Factor out port resource deallocation  https://review.opendev.org/c/openstack/nova/+/75711115:23
openstackgerritBalazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name  https://review.opendev.org/c/openstack/nova/+/75761415:23
openstackgerritBalazs Gibizer proposed openstack/nova master: Support interface attach with qos ports  https://review.opendev.org/c/openstack/nova/+/75653015:26
openstackgerritBalazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py  https://review.opendev.org/c/openstack/nova/+/76515215:29
*** tbachman has quit IRC15:30
*** tbachman has joined #openstack-nova15:30
gibistephenfin: fixed your comments in the qos series15:35
gibialso I finished the main  patch https://review.opendev.org/c/openstack/nova/+/75653015:35
openstackgerritBalazs Gibizer proposed openstack/nova master: Remove unused Instance method  https://review.opendev.org/c/openstack/nova/+/75761515:37
*** ociuhandu has joined #openstack-nova15:41
*** liuyulong has quit IRC15:42
*** _mlavalle_1 has quit IRC15:46
*** adrian-a has quit IRC15:52
*** ociuhandu has quit IRC15:53
*** k_mouza has quit IRC15:53
*** k_mouza has joined #openstack-nova15:54
*** macz_ has joined #openstack-nova16:04
*** mgariepy has quit IRC16:04
*** ociuhandu has joined #openstack-nova16:08
openstackgerritBalazs Gibizer proposed openstack/nova master: Reproduce bug 1907522 in functional test  https://review.opendev.org/c/openstack/nova/+/76679116:12
openstackbug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host <host>" [High,In progress] https://launchpad.net/bugs/1907522 - Assigned to Balazs Gibizer (balazs-gibizer)16:12
openstackgerritBalazs Gibizer proposed openstack/nova master: Fallback to same-cell resize with qos ports  https://review.opendev.org/c/openstack/nova/+/76692516:13
gibistephenfin: and fixued up this as well ^^16:15
*** mlavalle has joined #openstack-nova16:16
gmanngibi: for specific budy I mean, rest of the action APIs like lock does not take any parameter in request body so they are allowed everything since legacy time. But in unshelve API, 2.77 version added AZ to be a valid param in request body so in this action API we said if user can pass AZ as valid param then let's allow null or AZ only and block everything else.16:17
gibigmann: lock takes a lock_reason optionally similarly how unshelve takes AZ optionally16:17
gibihttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/lock_server.py16:18
gmanngibi: ah yeah, we have not added 'locked_reason' as required.16:21
gibiwe not added AZ as required either16:21
gmanngibi: so we can pass anything in cok API like lock: {'unknown': 'unknown'}16:22
gibino you cannot16:22
gibias additionalProperties false16:22
gmannhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L3116:22
gmannhere it is ^^16:22
gmannthat required is specially to block the empty dict so that we can have more strict shcema.16:23
gmannlet me check comments again if any other reason16:23
gibigmann: but why we need more sticter schema?16:23
*** jawad_axd has quit IRC16:23
gibithe meaning of unshelve: {} and unshelve: null is the same from the impl perspective (except the schema)16:24
gmanngibi: schema main idea is to have a very strict checks so that user will only be able to pass the usable parameters and everything else will be 40016:24
gibisure, I'm OK not to allow 'unknown':'unknown'16:25
gibiwhat I see that our API acceptr "<action>":{} and "<action>": null in mot of the cases but not for unshelve16:26
openstackgerritBalazs Gibizer proposed openstack/nova master: stabilize unit test asserting log  https://review.opendev.org/c/openstack/nova/+/76479616:29
openstackgerritBalazs Gibizer proposed openstack/nova master: stabilize set_host libvirt driver unit test  https://review.opendev.org/c/openstack/nova/+/76479716:31
gmanngibi: this was the original discussion on disallow the {} and make it more strict like pass None or AZ. - https://review.opendev.org/c/openstack/nova/+/663851/34/nova/api/openstack/compute/schemas/servers.py#69516:38
gmanngibi: that time we did not update api-ref for that16:39
gmannI personally did not see passing or allowing {} is more easy or ok than None16:39
*** mgariepy has joined #openstack-nova16:41
gibibut now has two different type of server action API, the unshelve where {} is disallowed and other actions where {} is allowed16:42
gibifor me the meaning of null and {} are the same16:42
gibiso unshelve now seems special, and I guess this was why bauzas was surprised16:43
bauzasgibi: also the fact that we changed the behaviour between 2.1 and 2.7716:44
bauzaseven if that's a microversion16:44
gibiso in pre 2.77 {} is OK but later it is disallowed?16:44
gibithat also feels a bit unnecesserly hars for the users16:45
gmannyeah there is no change for pre-27716:45
gibithe meaning of {} pre 2.77 is the same as null. And we could keep this meaning after 2.77 but we chose to change it16:45
gmannfor all other action except lock afrer 2.52 and unshelve after277, everything is allowed.16:45
gmannbauzas: pre 2.77 there is no change, you can pass {} or any unknown param16:46
gmannbauzas: gibi all action APIs does not use schema so they accept anything in request body and we improved that in lock and unshelve action as they started accepting request body. where two different pattern were selected for both of these APIs. in latest which is 2.77 unshelve we started disallow {} too16:48
bauzasgmann: gibi: sorry, on a meeting16:48
bauzasbut yeah, {} was accepted before 2.77 and now not16:48
gmannI cannot say which one is more correct but I think disallowing {} make is more specific16:48
*** ociuhandu_ has joined #openstack-nova16:49
*** markguz_ has joined #openstack-nova16:50
gibifrom api user perspective who is upgrading from pre 2.77 to 2.77 the new schema is overly restrictive for no good reason (from the api user perspective)16:50
gibiif we have technical reasons then fine, but I don't see any usability reasons to disallow {}16:51
*** ociuhandu has quit IRC16:52
*** dklyle has joined #openstack-nova16:52
openstackgerritBalazs Gibizer proposed openstack/nova master: Optionally prevent nova-compute start with DB credentials  https://review.opendev.org/c/openstack/nova/+/76217616:53
gibican some core other than stephen look at this simple revert https://review.opendev.org/c/openstack/nova/+/755995 it re-enables a good chunk of test coverage16:53
*** ociuhandu has joined #openstack-nova16:53
bauzasgibi: I'll do16:53
gibithanks16:53
bauzasbut then I need to leave16:53
bauzasdone16:54
gibibauzas: thanks.16:55
gibiI need to leave soon too16:55
* bauzas leaves16:55
bauzas(taxi dad)16:55
gibio/16:55
*** ociuhandu_ has quit IRC16:57
openstackgerritGhanshyam proposed openstack/placement master: Remove deprecated [placement]/policy_file config option  https://review.opendev.org/c/openstack/placement/+/76440916:57
gmanngibi: ^^ updated this16:57
gibigmann: looking16:58
*** ralonsoh is now known as ralonsoh|afk17:00
*** ociuhandu_ has joined #openstack-nova17:02
gibigmann: replied about the new init parameter17:02
gmannchecking17:04
*** ociuhandu has quit IRC17:05
gmanngibi: yeah, we can remove that as it was just for testing things and pick of policy file is on oslo side now17:06
gmannupdating17:06
gibithanks17:06
*** ociuhandu_ has quit IRC17:07
*** gyee has joined #openstack-nova17:07
openstackgerritGhanshyam proposed openstack/placement master: Remove deprecated [placement]/policy_file config option  https://review.opendev.org/c/openstack/placement/+/76440917:09
openstackgerritBalazs Gibizer proposed openstack/nova master: Use the non polling notification waiter in func test  https://review.opendev.org/c/openstack/nova/+/75844517:10
openstackgerritBalazs Gibizer proposed openstack/nova master: Create a fixture around fake_notifier  https://review.opendev.org/c/openstack/nova/+/75844617:10
gmanngibi: done ^^17:10
*** rpittau is now known as rpittau|afk17:11
openstackgerritGhanshyam proposed openstack/placement master: [goal] Deprecate the JSON formatted policy file  https://review.opendev.org/c/openstack/placement/+/76439417:11
gibilooking17:12
openstackgerritBalazs Gibizer proposed openstack/nova master: Use NotificationFixture for legacy notifications too  https://review.opendev.org/c/openstack/nova/+/75844817:13
gibigmann: I'm +2 on both policy patch now, thanks for proposing them17:13
gmanngibi: thanks.17:14
gmannI am going to write the unit tests also for placement policy like we did in nova so that new policy changes can be validated correctly. but sometime next week17:14
openstackgerritBalazs Gibizer proposed openstack/nova master: Test the NotificationFixture  https://review.opendev.org/c/openstack/nova/+/75845017:14
openstackgerritBalazs Gibizer proposed openstack/nova master: Move fake_notifier impl under NotificationFixture  https://review.opendev.org/c/openstack/nova/+/75845117:16
*** ociuhandu has joined #openstack-nova17:18
*** ociuhandu has quit IRC17:23
*** sean-k-mooney1 has joined #openstack-nova17:24
*** sean-k-mooney has quit IRC17:25
*** dklyle has quit IRC17:30
*** dklyle has joined #openstack-nova17:30
*** hamalq has joined #openstack-nova17:30
*** belmoreira has quit IRC17:34
*** hamalq_ has joined #openstack-nova17:34
*** k_mouza has quit IRC17:35
*** hamalq has quit IRC17:38
*** sapd1 has quit IRC17:38
sean-k-mooney1gibi: gmann  so im about to drop for the day but where did we settelon on allowing {} in unshleve17:46
sean-k-mooney1to me blocking it seams wrong and a bug that shoudl be corrected. { "unkonwn" :"unknown"} != {} the former should be blocked but i think the latter shoudl be treaded the same as null17:47
gibigmann: ack, thanks17:49
gibisean-k-mooney1: I don't think we had a final agreement17:49
gibiwe just stopped arguing:)17:49
sean-k-mooney1ok i might be back latter after dinner. but that is my perspective on the topic in anycase17:50
*** tesseract has quit IRC18:06
gibisean-k-mooney1: ack, I share your view18:12
melwittsurely there's precedent for this? I thought a lot of the server actions apis are this way18:16
melwittif other apis treat null == {} then it seems ok. if they don't, I would make it consistent with the other apis18:21
*** sean-k-mooney2 has joined #openstack-nova18:23
*** derekh has quit IRC18:26
*** sean-k-mooney1 has quit IRC18:26
openstackgerritMerged openstack/nova master: Revert "Temporarily disable parts of heal port allocation test"  https://review.opendev.org/c/openstack/nova/+/75599518:38
*** adrian-a has joined #openstack-nova18:39
gmannsean-k-mooney2: ack, as gibi mentioned, no final agreement yet we can discuss further18:45
gmannmelwitt: all other action API except lock-2.56 and unshelve-2.77 except everything in request, {} or {unknown: unknown} because there is no schema for those as per legacy compatibility.18:47
gmannlock-2.56 and unshelve-2.77 started accepted more param in request body and new schema for those follow different pattern. lock does not block {} but unshelve block {}18:48
melwittgmann: sorry not sure I parse that. you're saying that all apis except lock-2.56 and unshelve-2.77 do not accept {} as null. but that lock-2.56 and unshelve-2.77 do accept it?18:49
melwittand that is because the older apis have legacy behavior18:49
gmannmelwitt: no, all other action APIs except {}, null, or  {unknown: unknown}18:50
*** dtantsur is now known as dtantsur|afk18:50
gmanns/expect/accept18:50
gmannlock after 2.56 and unshelve after 2.77 started then schema checks but both in different pattern18:51
melwittoh, ok. seems like unshelve should too by consistency. I may be missing some additional context18:51
gmannthis is more context on that - https://review.opendev.org/c/openstack/nova/+/663851/34/nova/api/openstack/compute/schemas/servers.py#69518:51
melwittok so this decision would likely affect all apis going to a newer microversion?18:52
gmannbut yeah i agree on consistency part but which one we follow that is for discussion18:52
melwittI see. so we will either make unshelve allow {} or make lock disallow {}18:52
gmannmelwitt: yeah if we improve the other action APIs or when they have some request body change in new microversion then they will follow the pattern we decide now18:53
melwittgot it18:53
gmannyeah18:53
melwittok, so I think {unknown: unknown} seems like the weirdest one that makes sense to block in new apis18:54
gmannand brinzhang_  started to document the current behavior in api-ref https://review.opendev.org/c/openstack/nova/+/76725118:54
melwitt(as sean said earlier)18:54
gmannmelwitt: yeah {unknown: unknown}  will be blocked for all new mprovement18:54
gmannimprovement18:54
melwittthe {} makes some sense though and I could imagine veteran users being caught by surprise if we say that is no longer allowed to represent null18:54
melwittso it will be tradeoff between api purity vs user ease it seems18:55
melwittI think I'd be slightly in favor of allowing {} for the user ease reason18:57
melwittI do appreciate that it is redundant with null though18:58
gmannok, if user considering {} as null then not breaking existing users make sense.18:58
melwittyeah I mean, I think the use case will be automation or something that is setting values by a dict and when there is nothing they just do {} instead of saying "if nothing then null". but I don't know whether that is a thing people do19:00
gmanni see, i think in python code it make sense as many automation might default to {} if nothing like kwargs or so.19:03
gmanni agree on doing it consistently.19:06
gmannmelwitt: sean-k-mooney2 bauzas gibi let's do it in all action APIs to have consistency . i added this in api cleanup etherpad L89.  https://etherpad.opendev.org/p/nova-api-cleanup19:07
gmannmay be late in this cycle to do? if so we can do in X cycle?19:07
gmannbrinzhang_: ^^19:08
gmannor we can do one more 'multiple API improvement' microversion and pick few more improvement to do along with this.19:09
sean-k-mooney2gmann: i woudl proably pair it with the return codes cleanup19:10
sean-k-mooney2so number 8 on line 7319:10
gmannsean-k-mooney2: that is huge change and in past discussion we thought it is not worth to do as it may change many users scripts or so.19:11
sean-k-mooney2gmann: stephenfin has a patch for that up19:12
gmannbut I am ok to re-iterate it19:12
gmannyeah19:12
sean-k-mooney2so i assumed that would get done this cycle19:12
gmannthat needed spec which i think stephenfin said not worth or so but let me check that19:13
sean-k-mooney2it was a lower priority this cycle so i dont know if he filed one or was going to19:13
gmannhttps://review.opendev.org/c/openstack/nova/+/74950519:14
gmannthat is waiting for spec19:15
sean-k-mooney2stephenfin might have been hoping to do it as a specless blueprint since its resolving exisitng todos in the code but ya i know it lower on his list then the other items he is working on this cycle19:16
gmannyeah. let's discuss it in X cycle PTG to pick few of them which are worth to do19:17
sean-k-mooney2works for me19:17
sean-k-mooney2i would like to see teh is_public flavor atitbue change done too at somepoint19:18
gmann:) was typing that.19:18
sean-k-mooney2but not enought to prioritise it this cycle19:18
gmannthat is worth to fix19:18
sean-k-mooney2it is but on its own it a lot of work for littel benifit19:18
sean-k-mooney2with other changes it much much more resonable to me19:19
gmannyeah with other improvement19:19
*** andrewbonney has quit IRC19:26
*** zzzeek has quit IRC19:36
*** zzzeek has joined #openstack-nova19:38
*** lbragstad_ is now known as lbragstad19:54
*** zzzeek has quit IRC20:03
*** zzzeek has joined #openstack-nova20:07
*** jdillaman has quit IRC20:13
*** zzzeek has quit IRC20:14
*** zzzeek has joined #openstack-nova20:17
*** zzzeek has quit IRC20:25
*** zzzeek has joined #openstack-nova20:27
*** ociuhandu has joined #openstack-nova20:35
*** nweinber_ has joined #openstack-nova20:36
*** nweinber has quit IRC20:39
*** ociuhandu has quit IRC20:40
*** vishalmanchanda has quit IRC20:56
*** sean-k-mooney has joined #openstack-nova20:56
*** sean-k-mooney2 has quit IRC20:59
*** adrian-a has quit IRC21:19
*** larainema has quit IRC21:24
*** brinzhang0 has joined #openstack-nova21:42
*** songwenping_ has joined #openstack-nova21:43
*** brinzhang_ has quit IRC21:45
*** songwenping__ has quit IRC21:47
*** dklyle has quit IRC22:04
*** ralonsoh|afk has quit IRC22:09
*** rcernin has joined #openstack-nova22:17
*** dklyle has joined #openstack-nova22:21
*** spatel has joined #openstack-nova22:30
*** raildo has quit IRC22:30
*** spatel has quit IRC22:34
*** spatel has joined #openstack-nova22:40
*** slaweq has quit IRC22:42
*** spatel has quit IRC22:43
*** derekh has joined #openstack-nova22:58
*** tkajinam has joined #openstack-nova22:59
*** haleyb is now known as haleyb|away23:18
*** nweinber_ has quit IRC23:37

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!