| *** tosky has quit IRC | 00:03 | |
| *** jangutter has quit IRC | 00:06 | |
| *** brinzhang has joined #openstack-nova | 00:17 | |
| *** jangutter has joined #openstack-nova | 00:23 | |
| *** LinPeiWen86 has joined #openstack-nova | 00:40 | |
| *** zzzeek has quit IRC | 00:44 | |
| *** zzzeek has joined #openstack-nova | 00:46 | |
| *** macz_ has joined #openstack-nova | 01:24 | |
| *** macz_ has quit IRC | 01:28 | |
| *** zoharm1 has joined #openstack-nova | 01:29 | |
| *** zoharm has quit IRC | 01:33 | |
| openstackgerrit | Keigo Noha proposed openstack/nova stable/rocky: Change default num_retries for glance to 3 https://review.opendev.org/c/openstack/nova/+/771120 | 02:06 |
|---|---|---|
| *** zenkuro has quit IRC | 02:17 | |
| *** benj_ has quit IRC | 02:18 | |
| *** benj_ has joined #openstack-nova | 02:19 | |
| *** LinPeiWen86 has quit IRC | 02:21 | |
| *** tobberydberg has quit IRC | 02:23 | |
| *** tobberydberg has joined #openstack-nova | 02:35 | |
| *** rcernin has quit IRC | 02:41 | |
| *** rcernin has joined #openstack-nova | 02:58 | |
| *** rcernin has quit IRC | 03:03 | |
| *** rcernin has joined #openstack-nova | 03:03 | |
| *** mkrai has joined #openstack-nova | 03:06 | |
| *** zoharm has joined #openstack-nova | 03:10 | |
| *** zoharm1 has quit IRC | 03:12 | |
| *** jangutter_ has joined #openstack-nova | 03:20 | |
| *** zzzeek has quit IRC | 03:22 | |
| *** jangutter has quit IRC | 03:22 | |
| *** zzzeek has joined #openstack-nova | 03:23 | |
| *** psachin has joined #openstack-nova | 03:33 | |
| *** links has joined #openstack-nova | 04:27 | |
| *** ratailor has joined #openstack-nova | 04:39 | |
| *** LinPeiWen1 has joined #openstack-nova | 04:49 | |
| *** Mamduhala has joined #openstack-nova | 04:54 | |
| *** vishalmanchanda has joined #openstack-nova | 05:10 | |
| *** zzzeek has quit IRC | 05:10 | |
| *** zzzeek has joined #openstack-nova | 05:14 | |
| *** psachin has quit IRC | 05:18 | |
| *** psachin has joined #openstack-nova | 05:22 | |
| *** bbowen has quit IRC | 05:54 | |
| *** bbowen_ has joined #openstack-nova | 05:54 | |
| *** Mamduhala has quit IRC | 06:26 | |
| openstackgerrit | Adit Sarfaty proposed openstack/nova master: Retry on vmware create_vm when it fails https://review.opendev.org/c/openstack/nova/+/764586 | 07:04 |
| *** lpetrut has joined #openstack-nova | 07:14 | |
| *** mkrai has quit IRC | 07:20 | |
| *** CeeMac has joined #openstack-nova | 07:22 | |
| *** ralonsoh has joined #openstack-nova | 07:28 | |
| *** manuvakery1 has joined #openstack-nova | 07:41 | |
| *** lpetrut_ has joined #openstack-nova | 07:45 | |
| *** lpetrut_ has quit IRC | 07:45 | |
| *** lpetrut_ has joined #openstack-nova | 07:46 | |
| *** lpetrut has quit IRC | 07:48 | |
| *** danpawlik5 has quit IRC | 07:51 | |
| *** dpawlik7 has joined #openstack-nova | 07:53 | |
| *** ociuhandu has joined #openstack-nova | 07:53 | |
| *** rcernin has quit IRC | 07:53 | |
| *** rcernin has joined #openstack-nova | 07:57 | |
| *** ociuhandu has quit IRC | 07:58 | |
| *** rpittau|afk is now known as rpittau | 07:59 | |
| *** hemanth_n has joined #openstack-nova | 07:59 | |
| *** slaweq has joined #openstack-nova | 08:04 | |
| *** tesseract has joined #openstack-nova | 08:07 | |
| *** andrewbonney has joined #openstack-nova | 08:16 | |
| *** mkrai has joined #openstack-nova | 08:23 | |
| *** dtantsur|afk is now known as dtantsur | 08:32 | |
| *** tosky has joined #openstack-nova | 08:44 | |
| *** ociuhandu has joined #openstack-nova | 09:01 | |
| *** rcernin has quit IRC | 09:13 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/770926 | 09:20 |
| lyarwood | ^ stephenfin should be good now, there was however a weird but unrelated grenade failure in the last run | 09:20 |
| lyarwood | https://bugs.launchpad.net/tempest/+bug/1912178 | 09:20 |
| openstack | Launchpad bug 1912178 in tempest "Links are not allowed as constraints (pip 20.2.4)" [Undecided,New] | 09:20 |
| stephenfin | ack | 09:20 |
| *** rcernin has joined #openstack-nova | 09:24 | |
| *** derekh has joined #openstack-nova | 09:38 | |
| *** martinkennelly has joined #openstack-nova | 09:53 | |
| *** ociuhandu has quit IRC | 10:00 | |
| *** ociuhandu has joined #openstack-nova | 10:01 | |
| *** ociuhandu has quit IRC | 10:01 | |
| *** ociuhandu has joined #openstack-nova | 10:01 | |
| lyarwood | did we depreacte xen support in the libvirt driver? | 10:08 |
| * lyarwood is currently dealing with the min version fallout and the horror that is nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase._check_xml_and_uri | 10:08 | |
| lyarwood | https://review.opendev.org/c/openstack/nova/+/749055 yup | 10:10 |
| lyarwood | stephenfin: you didn't have a series to remove xen already did you? | 10:10 |
| stephenfin | from libvirt? | 10:10 |
| stephenfin | I did, yeah | 10:10 |
| lyarwood | ah where? I only see the xenapi stuff | 10:11 |
| * lyarwood looks harder | 10:11 | |
| stephenfin | https://review.opendev.org/q/topic:%22bp%252Fremove-deprecated-libvirt-virt-types%22+(status:open%20OR%20status:merged) | 10:11 |
| lyarwood | *facepalm* sorry the same topic, of course! | 10:11 |
| lyarwood | I'll rebase my version bump on that series and give it a review | 10:12 |
| *** mkrai has quit IRC | 10:33 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING https://review.opendev.org/c/openstack/nova/+/754702 | 10:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for UML https://review.opendev.org/c/openstack/nova/+/743230 | 10:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231 | 10:36 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754700 | 10:36 |
| lyarwood | okay done ^ gibi I've put the MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING removal patch at the base of that series so we don't hold up your device detach rewrite | 10:36 |
| *** ociuhandu has quit IRC | 10:53 | |
| *** ociuhandu has joined #openstack-nova | 10:53 | |
| *** ociuhandu has quit IRC | 11:00 | |
| *** ociuhandu has joined #openstack-nova | 11:01 | |
| *** ftarasenko has joined #openstack-nova | 11:03 | |
| *** dpawlik7 has quit IRC | 11:06 | |
| *** ociuhandu has quit IRC | 11:06 | |
| *** ociuhandu has joined #openstack-nova | 11:07 | |
| *** dpawlik7 has joined #openstack-nova | 11:09 | |
| *** songwenping__ has joined #openstack-nova | 11:10 | |
| gibi | lyarwood: thanks. I rebased my effort top of that | 11:11 |
| gibi | lyarwood: btw, the event handling patch seems to work well on the gate, I still have to add some unit tests and I will consider splitting the patch as it is getting huge | 11:11 |
| *** ociuhandu has quit IRC | 11:13 | |
| lyarwood | gibi: ack cool, it's on my list to review later today either way | 11:13 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: trivial: Resolve (most) flake8 3.x issues https://review.opendev.org/c/openstack/nova/+/770943 | 11:14 |
| openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: Switch to hacking 2.x https://review.opendev.org/c/openstack/nova/+/770944 | 11:14 |
| gibi | lyarwood: have you heard back from libvirt folks about the timeout length in libvirt? | 11:14 |
| lyarwood | elod: ^ not sure how you feel about this btw | 11:14 |
| lyarwood | gibi: oh I didn't reach out to them after our discussion last week as it looks like the failure case is sync and doesn't have a timeout | 11:15 |
| lyarwood | gibi: I can confirm with them if you'd like | 11:15 |
| songwenping__ | sean-k-mooney, gibi, bauzas: hi guys, i review your chat record, do you means when the host is power off, we should set arqs to UNKNOWN state through cyborg-api; when the host is power on and during the cyborg-agent init, we should set arqs to PROVISIONING and create mdevs, and then set them to BOUND when the mdevs created. | 11:15 |
| gibi | lyarwood: I trust your judgement. I misunderstood you previously about the timeout then, I though we have sync and async case as well | 11:15 |
| lyarwood | kashyap: ^ not sure if you'd know, basically we are trying to work out if libvirt has an internal timeout before it emits the DeviceRemovalFailedEvent event | 11:16 |
| openstackgerrit | YumengBao proposed openstack/nova-specs master: Libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | 11:16 |
| kashyap | lyarwood: Hi, incidentally, just reading here. :-) | 11:16 |
| gibi | but then I we got back to the point where we don't know how long to wait for the event. if we timeout too soon then the retry will cause the same issue in libvirt as before | 11:16 |
| lyarwood | kashyap: AFAICT it doesn't and would just emit that event synchronously on a failure | 11:16 |
| *** ociuhandu has joined #openstack-nova | 11:17 | |
| lyarwood | gibi: but I think it's safer to wait for longer now | 11:17 |
| kashyap | lyarwood: Hmm, what's the exact event name? This? VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED | 11:17 |
| gibi | kashyap: yes | 11:17 |
| lyarwood | kashyap: but the failure one | 11:18 |
| * lyarwood checks | 11:18 | |
| kashyap | Right; just trying to find the precise name | 11:18 |
| lyarwood | VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED | 11:18 |
| gibi | lyarwood: we can wait longer yes, I can bump the current 60sec to longer and see what happens on the gate. current I see some timeout in tempest with 60sec (then retry succeeds) so we can at least see if the timeout case go away if I bump the timeout value in the driver | 11:18 |
| kashyap | lyarwood: Okay; Peter Krempa / Michal from upstream libvirt might know; let me check on OFTC | 11:19 |
| lyarwood | gibi: oh it doesn't need to be 60 seconds between attempts | 11:19 |
| lyarwood | gibi: our previous issues were caused with a 5 second retry or lower iirc | 11:20 |
| gibi | lyarwood: it is 60sec now and still see one or two timeout in a tempest run | 11:20 |
| lyarwood | gibi: not between requests | 11:20 |
| lyarwood | gibi: it builds up, the first is 5 seconds | 11:20 |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: add port scoped numa affinity spec https://review.opendev.org/c/openstack/nova-specs/+/765901 | 11:21 |
| kashyap | lyarwood: gibi: So, from the libvirt ocmmit that introduced the said event, it says the following: | 11:21 |
| kashyap | [quote] | 11:21 |
| kashyap | Since we didn't opt to use one single event for device lifecycle for a | 11:21 |
| kashyap | VM we are missing one last event if the device removal failed. This | 11:21 |
| kashyap | event will be emitted once we asked to eject the device but for some | 11:21 |
| kashyap | reason it is not possible. | 11:21 |
| kashyap | [/quote] | 11:21 |
| lyarwood | right, I've also looked at the code and it looks like it's just a direct synchronous failure with that call, IOW it doesn't come after a timeout. | 11:22 |
| kashyap | Looking at the code, I don't see particularly any timeout: https://www.redhat.com/archives/libvir-list/2016-April/msg00196.html | 11:22 |
| kashyap | Jinx | 11:22 |
| kashyap | But let me confirm w/ Peter | 11:22 |
| gibi | lyarwood: but then who the event base code can help compared to the current retry code. that retry also wait syncronosly for libvirt to return | 11:23 |
| gibi | if the event also sync then waiting for the event is equivalent to wait for the detach call to return from libvirt | 11:23 |
| gibi | or do I miss something? | 11:23 |
| *** tbachman has quit IRC | 11:24 | |
| gibi | I can verify something from the logs. I can check if there is a case when the detach returns before and then the detach event arrives significantly later | 11:26 |
| gibi | if there is such case then waiting for the event make sense | 11:26 |
| kashyap | gibi: Can you give a link to your patch, again, please? | 11:26 |
| gibi | https://review.opendev.org/c/openstack/nova/+/770246 | 11:26 |
| kashyap | Thx | 11:26 |
| *** xarlos has joined #openstack-nova | 11:32 | |
| kashyap | gibi: lyarwood: So ... it indeed looks like a sync failure; danpb on #virt also says this: that event is issued when ACPI refuses the unplug explicitly. | 11:33 |
| kashyap | gibi: lyarwood: But if the guest OS is just slow or not responding, we don't get that event. | 11:34 |
| *** Yumeng has joined #openstack-nova | 11:34 | |
| gibi | kashyap: so there is a case when we eventually need to time out an retry? | 11:34 |
| *** ociuhandu has quit IRC | 11:34 | |
| gibi | the case when the guest OS did not respond | 11:34 |
| *** ociuhandu has joined #openstack-nova | 11:35 | |
| kashyap | gibi: Yeah, looks liks so -- how else do we take into acount the the guest OS's slowness or unresponsiveness | 11:35 |
| gibi | but we should not retry too soon to avoid interrupting an ongoing detach in libvirt as that caused our issue in detach in the first place | 11:35 |
| kashyap | Yeah, exactly that too... | 11:36 |
| kashyap | gibi: Also, wait: | 11:36 |
| kashyap | gibi: DanPB reminds: "if you get that event I don't htink you want to retry - that's an unconditional failure IIUC" | 11:36 |
| gibi | kashyap: so if we get the failure event then we fail, if we get timeout we retry. if we get a sync failure about device missing then we retry with persistent=False | 11:38 |
| Yumeng | hi sean-k-mooney, gibi, bauzas. Thank you for the discussion on Jan 15 about vGPU spec. I agree sean's suggestion about host reboot case and updated a new patch . Pls help to review at your convenience.Thanks! https://review.opendev.org/c/openstack/nova-specs/+/750116 | 11:39 |
| lyarwood | gibi: yeah sorry had to go afk | 11:40 |
| hemanth_n | lyarwood: could you please review https://review.opendev.org/c/openstack/nova/+/761725 when you get some time | 11:40 |
| lyarwood | hemanth_n: ack will do | 11:40 |
| kashyap | gibi: How does the sync failure of the missing device manifest? | 11:40 |
| gibi | kashyap: https://review.opendev.org/c/openstack/nova/+/770246/7/nova/virt/libvirt/driver.py#45 | 11:41 |
| * kashyap clicks | 11:41 | |
| lyarwood | kashyap: if the device has already been removed from the persistent config but remains in the live config | 11:41 |
| gibi | we get a libvirtError with VIR_ERR_DEVICE_MISSING | 11:41 |
| gibi | as far as I see there is no failed event in this case | 11:41 |
| lyarwood | gibi: yeah I don't think libvirt gets as far as calling QEMU | 11:42 |
| lyarwood | gibi: for QEMU to then emit the event back to libvirt etc | 11:42 |
| kashyap | Thx, both | 11:42 |
| kashyap | Ah, looks like VIR_ERR_DEVICE_MISSING was added in libvirt for Nova :) | 11:44 |
| gibi | ooh :) | 11:44 |
| kashyap | Otherwise, we were `grep`ing for error message; which is unreliable | 11:44 |
| kashyap | Proper error code was due anyway; Nova just uncovered the bug | 11:45 |
| *** xek has joined #openstack-nova | 11:45 | |
| gibi | ahh I know that. I thought there was some deeper reason. Yeas lyarwood just removed the grepping from nova as we have new enough libvirt to rely on the error code instead | 11:46 |
| *** ociuhandu has quit IRC | 11:49 | |
| *** ociuhandu has joined #openstack-nova | 11:49 | |
| gibi | Logs look good. I see cases where the detach sequence is the following: | 11:50 |
| gibi | * first attempt times out after 60sec waiting for the event from libvirt | 11:50 |
| gibi | * second attempt fails synchronously with device not found | 11:50 |
| gibi | * third attempt with persistent=False succeeds | 11:50 |
| gibi | so I assume the first attempt only removed the device from the persistent config | 11:51 |
| gibi | hence the second attempt fail | 11:51 |
| gibi | then the third succeed as it does not try to remove it from the persistent config | 11:51 |
| lyarwood | yeah the first should always remove it from the persistent config | 11:53 |
| lyarwood | so you can call the second with persistent=False | 11:53 |
| *** raildo has joined #openstack-nova | 11:53 | |
| lyarwood | as we did previously | 11:53 |
| kashyap | gibi: FWIW, I summarized the IRC chat here: https://review.opendev.org/c/openstack/nova/+/770246/7/nova/virt/libvirt/driver.py#2330 | 11:54 |
| *** ociuhandu has quit IRC | 11:54 | |
| gibi | lyarwood: still that first timeout seems wrong, why not we get an event | 11:55 |
| * kashyap --> lunch | 11:55 | |
| lyarwood | gibi: I think it's a single event once detached from both the persistent and live config | 11:55 |
| gibi | lyarwood: and we need to send two detach to have detach it from both config? | 11:55 |
| gibi | if yes then it make sense | 11:56 |
| *** jangutter has joined #openstack-nova | 11:56 | |
| *** jangutter has quit IRC | 11:56 | |
| *** jangutter has joined #openstack-nova | 11:57 | |
| *** jangutter_ has quit IRC | 11:59 | |
| *** zenkuro has joined #openstack-nova | 12:08 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove 'hypervisor_version' from 'libvirt_info' https://review.opendev.org/c/openstack/nova/+/744199 | 12:08 |
| lyarwood | gibi: one request can detach the device from both | 12:13 |
| lyarwood | gibi: it just depends on the guestOS for the device to be detached from the live config | 12:13 |
| gibi | lyarwood: so the first detach attempt triggers the detach from both the persistent and the live config. The detach call returns, but we timeout waiting for the event. So I have to assume that either a) we didn't wait long enough to get the event b) we _have to_ send two detach to get the device detached from the live config. | 12:15 |
| gibi | or c) libvirt does not send the event in some case | 12:16 |
| gibi | but that seems wrong | 12:16 |
| lyarwood | right so for a and b we retry the detach | 12:17 |
| lyarwood | we can even check if the device is in either config before doing that | 12:17 |
| lyarwood | but it should always be gone from the persistent config at that point | 12:18 |
| lyarwood | just to go back to the original blind retry issue | 12:18 |
| lyarwood | the issue with that approach in CI was the time between actual detach calls to libvirt and then down into QEMU was tiny | 12:19 |
| lyarwood | so much so that they would overlap and cause the undocumented QEMU behaviour | 12:19 |
| lyarwood | with your approach I really think it's safe to wait for longer between attempts to detach now, so something like 20 to 30 seconds | 12:20 |
| *** ociuhandu has joined #openstack-nova | 12:20 | |
| lyarwood | I know you're waiting for 60 at the moment but as I said before the previous behaviour was to start at 5 seconds and increase that with each iteration | 12:20 |
| *** lpetrut__ has joined #openstack-nova | 12:22 | |
| sean-k-mooney | Yumeng: +1 on the vgpu spec. https://review.opendev.org/c/openstack/nova-specs/+/750116 | 12:22 |
| sean-k-mooney | gibi: bauzas ^ if you have time to re review i think that is ready | 12:22 |
| gibi | I still don't see the difference between the old and the new approach. In both code wait a predefined time before retry, and in both code this waiting is only happen if the first try fails, if the first try succeeds then no waiting happens. So I don't see why we are in the better situation with the new code | 12:22 |
| *** mkrai has joined #openstack-nova | 12:23 | |
| gibi | sean-k-mooney: ack | 12:23 |
| sean-k-mooney | gibi: didnt the old code retyr regardless of failure or success | 12:23 |
| sean-k-mooney | i tought it just started teh time out and retired without waiting | 12:23 |
| gibi | sean-k-mooney: the old case also checked the existence of the device in the live config before retry | 12:23 |
| sean-k-mooney | for an event | 12:23 |
| sean-k-mooney | gibi: right but that is not a vaild check | 12:24 |
| gibi | sean-k-mooney: that is what we do both in the old and the new code | 12:24 |
| sean-k-mooney | the issue is that with new qemu issuing a second detach cancles the operation | 12:24 |
| gibi | sean-k-mooney: but it seems waiting for the event times out | 12:24 |
| sean-k-mooney | so it may still be in the live domain but that does not mean you can send a second detach | 12:24 |
| lyarwood | right, the main thing I wanted here was to allow n-cpu to wait longer between requests to libvirt to detach | 12:25 |
| *** lpetrut_ has quit IRC | 12:25 | |
| gibi | sean-k-mooney: it seems that the libvirt detach call returns at the same time when the detach event is sent, so the whole thing seems synchronous | 12:25 |
| lyarwood | thus making it harder if not impossible for us to hit the weird undocumented QEMU behaviour | 12:25 |
| gibi | sean-k-mooney: but then I don't know how we was able to step on the first detach handling with the retry | 12:26 |
| sean-k-mooney | gibi: i think that depends on the load | 12:26 |
| gibi | lyarwood: but then finding the right timeout is the goal both in the new and the old code. but for that we don't have to blow up the old code | 12:26 |
| sean-k-mooney | i dont think it is synconos jsut look that way with light load | 12:27 |
| sean-k-mooney | gibi: you could simulate that with cgroups/taskset | 12:27 |
| lyarwood | gibi: so the old code is also a mess | 12:27 |
| gibi | sean-k-mooney: above kashyap and lyarwood said it looks synchronous | 12:27 |
| sean-k-mooney | you could limit the execution time of libvirtd | 12:27 |
| gibi | lyarwood: fair the old code is a mess and can be factored to be cleaner | 12:27 |
| sean-k-mooney | gibi: i see havent looked at ti too closely | 12:28 |
| lyarwood | gibi: and about things being sync or async, I was talking about the failure event | 12:28 |
| gibi | lyarwood: ohh, I missed that then | 12:28 |
| sean-k-mooney | so the even is asyc right | 12:28 |
| lyarwood | gibi: I think the success event can be async | 12:28 |
| gibi | lyarwood: so the happy case still can be async? | 12:28 |
| sean-k-mooney | but on a fast host it will be almost instant | 12:28 |
| lyarwood | right | 12:28 |
| gibi | cool, then the event waiting code is better | 12:28 |
| lyarwood | right that allows us to wait longer | 12:29 |
| lyarwood | as we should get an event back when the device does eventually detach | 12:29 |
| gibi | I will do more test to see why we don't get any event back from libvirt at the first detach attempt | 12:30 |
| gibi | in the above scenario | 12:30 |
| gibi | as that missing event is bothering me | 12:30 |
| sean-k-mooney | gibi: you could try doing "sudo cpulimit -l 1 -e libvirtd" or "sudo cpulimit -l 1 -p <libvirtd pid>" | 12:31 |
| gibi | sean-k-mooney: thanks I will try | 12:31 |
| sean-k-mooney | that should limit libvirt to 1% of 1 core | 12:31 |
| lyarwood | gibi: we don't get the event as the device is still attached to the live config | 12:33 |
| lyarwood | gibi: and failure is for sync failures where QEMU rejects the request to detach | 12:34 |
| gibi | lyarwood: but we expect that libvirt will detach from the live config as we asked for it | 12:34 |
| gibi | in the first request | 12:34 |
| lyarwood | gibi: we expect that it should try | 12:34 |
| gibi | and if fails then it should tell us it failed, isn't it? | 12:34 |
| kashyap | gibi: lyarwood: So, Peter Krempa came back; let me post the chat summary snippet here, from #virt, OFTC: | 12:35 |
| lyarwood | gibi: no, again the failure event is for when QEMU tells libvirt that it can't detach the device when the request is initially made | 12:35 |
| lyarwood | gibi: if that request is accepted but the guestos doesn't allow the device to detach then we don't get anything back | 12:35 |
| lyarwood | that's my understanding at least, lets see what kashyap has | 12:35 |
| kashyap | lyarwood: Yeah; now I hear some additional subtleties; I'm going to post the full summary on the change; and we all can read and discuss here | 12:36 |
| *** rcernin has quit IRC | 12:36 | |
| *** ociuhandu has quit IRC | 12:38 | |
| *** ociuhandu has joined #openstack-nova | 12:38 | |
| *** LinPeiWen1 has quit IRC | 12:42 | |
| *** eandersson has quit IRC | 12:44 | |
| *** eandersson has joined #openstack-nova | 12:44 | |
| *** zoharm1 has joined #openstack-nova | 12:45 | |
| *** Luzi has joined #openstack-nova | 12:46 | |
| *** ociuhandu has quit IRC | 12:46 | |
| *** brinzhang_ has joined #openstack-nova | 12:46 | |
| *** bhagyashris has quit IRC | 12:47 | |
| *** bhagyashris has joined #openstack-nova | 12:47 | |
| kashyap | gibi: lyarwood: Done; see here (I also like DanPB's advice on dealin w/ active vs. inactive config separately): https://review.opendev.org/c/openstack/nova/+/770246/7/nova/virt/libvirt/driver.py#2330 | 12:48 |
| *** zoharm has quit IRC | 12:48 | |
| *** brinzhang_ has quit IRC | 12:48 | |
| *** brinzhang_ has joined #openstack-nova | 12:48 | |
| *** purplerbot has quit IRC | 12:49 | |
| *** brinzhang_ has quit IRC | 12:50 | |
| *** brinzhang_ has joined #openstack-nova | 12:51 | |
| kashyap | Let me know if that answers your question; if not, please note there, if anything doesn't add up :-) | 12:51 |
| gibi | sorry, I'm on a call | 12:51 |
| kashyap | No rush at all | 12:51 |
| *** rcernin has joined #openstack-nova | 12:55 | |
| *** CeeMac has quit IRC | 12:56 | |
| *** vishalmanchanda has quit IRC | 12:56 | |
| *** tobberydberg has quit IRC | 12:56 | |
| *** brinzhang has quit IRC | 12:56 | |
| *** jrosser has quit IRC | 12:56 | |
| *** efried has quit IRC | 12:56 | |
| *** cgoncalves has quit IRC | 12:56 | |
| *** johanssone has quit IRC | 12:56 | |
| *** logan- has quit IRC | 12:56 | |
| *** ociuhandu has joined #openstack-nova | 12:57 | |
| *** artom has joined #openstack-nova | 12:58 | |
| *** CeeMac has joined #openstack-nova | 12:59 | |
| *** vishalmanchanda has joined #openstack-nova | 12:59 | |
| *** tobberydberg has joined #openstack-nova | 12:59 | |
| *** jrosser has joined #openstack-nova | 12:59 | |
| *** efried has joined #openstack-nova | 12:59 | |
| *** cgoncalves has joined #openstack-nova | 12:59 | |
| *** johanssone has joined #openstack-nova | 12:59 | |
| *** logan- has joined #openstack-nova | 12:59 | |
| *** arne_wiebalck has quit IRC | 12:59 | |
| *** logan- has quit IRC | 12:59 | |
| *** logan- has joined #openstack-nova | 13:00 | |
| gibi | kashyap: thanks for the summary, I will work DanPB's suggestion into the patch as handling the live an the persistent config separately feels cleaner to me too | 13:00 |
| *** rcernin has quit IRC | 13:00 | |
| *** arne_wiebalck has joined #openstack-nova | 13:01 | |
| kashyap | Np | 13:03 |
| *** masterpe has quit IRC | 13:03 | |
| *** ociuhandu has quit IRC | 13:05 | |
| *** purplerbot has joined #openstack-nova | 13:06 | |
| *** links has quit IRC | 13:08 | |
| *** links has joined #openstack-nova | 13:13 | |
| *** rcernin has joined #openstack-nova | 13:13 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231 | 13:22 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754700 | 13:22 |
| *** eharney has joined #openstack-nova | 13:25 | |
| *** rcernin has quit IRC | 13:27 | |
| *** ociuhandu has joined #openstack-nova | 13:32 | |
| *** ratailor has quit IRC | 13:35 | |
| *** ociuhandu has quit IRC | 13:36 | |
| *** ociuhandu has joined #openstack-nova | 13:36 | |
| *** ratailor has joined #openstack-nova | 13:38 | |
| openstackgerrit | Brin Zhang proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336 | 13:43 |
| *** ratailor has quit IRC | 13:44 | |
| *** Yumeng has quit IRC | 13:48 | |
| *** masterpe has joined #openstack-nova | 13:56 | |
| *** lbragstad has joined #openstack-nova | 14:03 | |
| *** sapd1 has joined #openstack-nova | 14:12 | |
| *** lbragstad has quit IRC | 14:16 | |
| *** lbragstad has joined #openstack-nova | 14:19 | |
| *** lbragstad has quit IRC | 14:20 | |
| *** lbragstad has joined #openstack-nova | 14:20 | |
| *** zoharm has joined #openstack-nova | 14:21 | |
| *** zoharm1 has quit IRC | 14:23 | |
| stephenfin | sean-k-mooney: Can you fix the failures on https://review.opendev.org/c/openstack/nova-specs/+/765901 real quick? | 14:24 |
| sean-k-mooney | oh it failed yes ill do it now | 14:25 |
| *** whoami-rajat__ has joined #openstack-nova | 14:25 | |
| sean-k-mooney | sorry should have ran pep8 | 14:26 |
| *** ociuhandu has quit IRC | 14:29 | |
| sean-k-mooney | stephenfin: for the leading underscore | 14:30 |
| sean-k-mooney | for [2] | 14:30 |
| *** ociuhandu has joined #openstack-nova | 14:30 | |
| sean-k-mooney | shoudl it be [_2] | 14:30 |
| stephenfin | *trailing | 14:30 |
| stephenfin | [2]_ | 14:30 |
| sean-k-mooney | oh | 14:30 |
| sean-k-mooney | and the first one does not need that? | 14:31 |
| stephenfin | you already have it on the first one :) | 14:31 |
| sean-k-mooney | oh for [1]_ | 14:31 |
| sean-k-mooney | i have another instance of [2] before that | 14:31 |
| sean-k-mooney | cool ill fix them all | 14:31 |
| *** ociuhandu has quit IRC | 14:34 | |
| *** ociuhandu has joined #openstack-nova | 14:34 | |
| *** arturo has left #openstack-nova | 14:34 | |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: add port scoped numa affinity spec https://review.opendev.org/c/openstack/nova-specs/+/765901 | 14:35 |
| sean-k-mooney | stephenfin: i think ^ fixes everything | 14:36 |
| sean-k-mooney | let me know if there is anything else and ill respin | 14:36 |
| stephenfin | will do | 14:36 |
| *** hemanth_n has quit IRC | 14:39 | |
| *** hemanth_n has joined #openstack-nova | 14:42 | |
| stephenfin | sean-k-mooney: I have my doubt about that policy amendment to the modernize os-hypervisors API spec | 14:44 |
| stephenfin | "namely the idea that we shoudl allow users with the PROECT_ADMIN role to list all hyperviors there project is allowed to acess via the summary endpoint" | 14:44 |
| stephenfin | there doesn't appear to be anything that restrict projects to specific hypervisor(s) | 14:45 |
| stephenfin | at least there's no tenant or project attribute of the ComputeNode or Service objects | 14:45 |
| stephenfin | did you have something specific in mind? | 14:46 |
| *** Luzi has quit IRC | 14:48 | |
| *** dpawlik7 has quit IRC | 14:52 | |
| *** hemanth_n has quit IRC | 14:53 | |
| *** jangutter_ has joined #openstack-nova | 14:53 | |
| *** jangutter has quit IRC | 14:56 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move query param generation to RequestGroup o.vo https://review.opendev.org/c/openstack/nova/+/756894 | 15:00 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/c/openstack/nova/+/756895 | 15:01 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109 | 15:03 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110 | 15:04 |
| *** mkrai has quit IRC | 15:05 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111 | 15:06 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614 | 15:08 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/utils.py https://review.opendev.org/c/openstack/nova/+/769942 | 15:09 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720 | 15:10 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530 | 15:12 |
| *** nightmare_unreal has joined #openstack-nova | 15:12 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152 | 15:13 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove unused Instance method https://review.opendev.org/c/openstack/nova/+/757615 | 15:14 |
| *** psachin has quit IRC | 15:14 | |
| sean-k-mooney | stephenfin: i intened to reuse the aggreate metadtaa used for the teannt afinity filters | 15:15 |
| sean-k-mooney | we use the same metadat for both the placment prefilter or the post filter | 15:15 |
| sean-k-mooney | the prefilter allwos you to do stict tenant isolation | 15:15 |
| sean-k-mooney | so that only a given tenatn can use member of a give aggreate | 15:15 |
| *** dpawlik7 has joined #openstack-nova | 15:17 | |
| sean-k-mooney | stephenfin: https://docs.openstack.org/nova/rocky/admin/configuration/schedulers.html#tenant-isolation-with-placement | 15:18 |
| sean-k-mooney | you do openstack aggregate set --property filter_tenant_id=9691591f913949818a514f95286a6b90 myagg | 15:18 |
| sean-k-mooney | to restict the usage | 15:19 |
| sean-k-mooney | stephenfin: so the check you would do is simple. | 15:19 |
| sean-k-mooney | gretrive all aggreate with the current teant id | 15:19 |
| sean-k-mooney | show only host in those aggreates | 15:19 |
| sean-k-mooney | stephenfin: if the list is of aggrates is empty then list all hosts | 15:20 |
| sean-k-mooney | since that tenant is unconfiged | 15:20 |
| stephenfin | makes sense | 15:20 |
| *** dpawlik7 has quit IRC | 15:26 | |
| *** lpetrut__ has quit IRC | 15:27 | |
| *** dpawlik9 has joined #openstack-nova | 15:27 | |
| *** dpawlik9 is now known as dpawlik | 15:27 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Do not inherit os_glance properties on snapshot https://review.opendev.org/c/openstack/nova/+/771234 | 15:31 |
| *** ociuhandu has quit IRC | 15:32 | |
| *** songwenping__ has quit IRC | 15:32 | |
| *** ociuhandu has joined #openstack-nova | 15:33 | |
| *** manuvakery1 has quit IRC | 15:33 | |
| *** nweinber has joined #openstack-nova | 15:35 | |
| *** ociuhandu has quit IRC | 15:37 | |
| *** efried has quit IRC | 15:39 | |
| *** efried has joined #openstack-nova | 15:40 | |
| *** efried has quit IRC | 15:41 | |
| *** efried has joined #openstack-nova | 15:47 | |
| *** nweinber_ has joined #openstack-nova | 15:49 | |
| stephenfin | gibi: Could you stick https://review.opendev.org/c/openstack/nova/+/764482/ on your review queue, please? | 15:49 |
| *** nweinber_ has quit IRC | 15:50 | |
| gibi | stephenfin: on it | 15:50 |
| lyarwood | has anyone hit https://bugs.launchpad.net/tempest/+bug/1912178 locally today? | 15:53 |
| openstack | Launchpad bug 1912178 in tempest "Links are not allowed as constraints (pip 20.2.4)" [Undecided,New] | 15:53 |
| stephenfin | not me | 15:53 |
| gibi | lyarwood: yes | 15:53 |
| lyarwood | weird, I'm not sure what is adding the URI to the constraints list | 15:53 |
| lyarwood | oh cool not just me then, cool | 15:54 |
| gibi | lyarwood: I think devstack edits the constraints list based on what repos/libs you asked in the local.conf to be cloned | 15:54 |
| gibi | lyarwood: as far as I understand the issue appears if somehow the pip version gets updated in your devstack vm | 15:55 |
| gibi | lyarwood: for me, in a clean ubuntu 20.04 the first devstack stach.sh works | 15:55 |
| gibi | but subsequnt unstack.sh && stack.sh fails with the above rror | 15:55 |
| *** swp20 has joined #openstack-nova | 15:56 | |
| lyarwood | gibi: yeah I was about to say I've not touched the version of pip in this env | 15:56 |
| gibi | lyarwood: I suspect that the stach.sh runs some update if it is not in a clean vM | 15:57 |
| gibi | but I have no proof | 15:57 |
| *** swp20 has quit IRC | 15:57 | |
| *** swp20 has joined #openstack-nova | 15:58 | |
| *** swp20 has quit IRC | 16:00 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP/DNM libvirt: Start emitting DeviceRemovedEvent and DeviceRemovalFailedEvent events https://review.opendev.org/c/openstack/nova/+/749929 | 16:00 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | 16:00 |
| *** swp20 has joined #openstack-nova | 16:00 | |
| lyarwood | gibi: fun, so I've updated pip and it seems to be working now | 16:02 |
| gibi | hm, interesting | 16:02 |
| *** nweinber has quit IRC | 16:03 | |
| *** macz_ has joined #openstack-nova | 16:04 | |
| *** ociuhandu has joined #openstack-nova | 16:04 | |
| *** macz_ has quit IRC | 16:04 | |
| *** macz_ has joined #openstack-nova | 16:05 | |
| *** nweinber has joined #openstack-nova | 16:07 | |
| *** ociuhandu has quit IRC | 16:09 | |
| stephenfin | bauzas: If you've a chance this week, care to look at https://review.opendev.org/q/topic:bp/compact-db-migrations-wallaby ? dansmith and gibi have already looked through it, so I need a final pair of eyes | 16:14 |
| bauzas | sure, will do | 16:14 |
| stephenfin | you can ignore the apidb series at the bottom for now - I suspect I need to rework some of that | 16:14 |
| stephenfin | cool, thanks | 16:15 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove 'hypervisor_version' from 'libvirt_info' https://review.opendev.org/c/openstack/nova/+/744199 | 16:25 |
| *** ociuhandu has joined #openstack-nova | 16:29 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: Add generate schemas tool https://review.opendev.org/c/openstack/nova/+/769796 | 16:29 |
| *** sapd1 has quit IRC | 16:31 | |
| *** ociuhandu has quit IRC | 16:33 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231 | 16:35 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754700 | 16:35 |
| *** raildo_ has joined #openstack-nova | 16:42 | |
| *** sapd1 has joined #openstack-nova | 16:42 | |
| *** eandersson8 has joined #openstack-nova | 16:43 | |
| *** kashyap has quit IRC | 16:44 | |
| *** raildo has quit IRC | 16:44 | |
| *** slaweq has quit IRC | 16:44 | |
| *** slaweq has joined #openstack-nova | 16:45 | |
| *** eandersson has quit IRC | 16:45 | |
| *** zzzeek has quit IRC | 16:45 | |
| *** ociuhandu has joined #openstack-nova | 16:45 | |
| *** eandersson8 is now known as eandersson | 16:45 | |
| *** zzzeek has joined #openstack-nova | 16:46 | |
| *** rpittau is now known as rpittau|afk | 16:49 | |
| *** kashyap` has joined #openstack-nova | 16:50 | |
| *** tesseract has quit IRC | 16:51 | |
| openstackgerrit | Merged openstack/python-novaclient master: Deprecate agent commands and APIs https://review.opendev.org/c/openstack/python-novaclient/+/769068 | 16:51 |
| gibi | lyarwood, kashyap`: back from some testing. If a domain has both a persistent and a live config, then detaching from only the persistent domain first works but does not generate an event. detaching from the live first then detaching from the persistent second does not work none of them generate event (but if the 3rd attempt is live again then that works). | 16:52 |
| kashyap` | gibi: On a call; but reading (as I'm not speaking) ... | 16:53 |
| gibi | so it seems we always need to detach from the persistent first, don't wait for any event, then detach from the live, and wait for event | 16:53 |
| *** ociuhandu has quit IRC | 16:53 | |
| kashyap` | Wait, you're contrasting "persistent" vs. "live" -- my brain was expecting either persistent vs. transient; or live vs offline :-) | 16:54 |
| gibi | the code call them persistent and live | 16:54 |
| gibi | this is where I learned :) | 16:54 |
| gibi | detach from persistent is detach with VIR_DOMAIN_AFFECT_CONFIG | 16:55 |
| gibi | detach from live is detach with VIR_DOMAIN_AFFECT_LIVE flag | 16:55 |
| kashyap` | (Sometimes libvirt terminology gives a damn headache) | 16:56 |
| kashyap` | (For ther record, I was referring to: https://wiki.libvirt.org/page/VM_lifecycle#Transient_guest_domains_vs_Persistent_guest_domains) | 16:56 |
| kashyap` | gibi: Hmm, but I _think_ I see what you mean | 16:57 |
| kashyap` | "live config" often implies it's not persistent (i.e. it is "transient") | 16:57 |
| kashyap` | Either way; back to the original issue | 16:57 |
| gibi | so | 17:00 |
| gibi | I can make it work it just wierdly order dependent | 17:00 |
| kashyap` | gibi: Hmm, so that behaviour of "no event when detaching from live config first" sounds strange and inconsistent. | 17:00 |
| gibi | and also the persistent side does not generate event | 17:00 |
| *** ociuhandu has joined #openstack-nova | 17:00 | |
| gibi | kashyap`: yeah | 17:00 |
| kashyap` | gibi: Let me ask Peter; if this is a "bug or a feature" ;-) | 17:01 |
| *** ociuhandu has quit IRC | 17:01 | |
| *** ociuhandu has joined #openstack-nova | 17:02 | |
| *** takamatsu has quit IRC | 17:02 | |
| *** ociuhandu has quit IRC | 17:02 | |
| gibi | kashyap`: could be some kind of complication in my test as well. I try to re-test it with a simpler tempest test as now there is rescue involved as well | 17:03 |
| kashyap` | gibi: I want to phrase the (complex) problem in my own words, so tell me if this is correct: | 17:05 |
| kashyap` | (Because I'm not clear in _which_ combination the event is generated and in which not) | 17:06 |
| kashyap` | - Assume a domain has both a persistent (i.e. inactive) and a live config. | 17:06 |
| kashyap` | - Detach a device from the inactive config first --> detach successful; but does not generate an event | 17:06 |
| kashyap` | - Detach a device from the live config first, then detach it from the persistent config --> the second detach fails; and no event generated in both cases | 17:06 |
| kashyap` | gibi: Is that correct? (With the final point being: if the third attempt in the last step is a live config --> then the detach works) | 17:07 |
| gibi | kashyap`: Detach a device from the live config first, then detach it from the | 17:08 |
| gibi | persistent config | 17:08 |
| gibi | in this case both detach returns without generating event, and the device remains attached (at least in the live config) | 17:08 |
| kashyap` | Aah --> both of them fail (i.e. detach not succesful) and nor do they generate an event? | 17:09 |
| gibi | nova only checks the live config so I can only say that the detach failed from the live config as teh device remains there. | 17:10 |
| gibi | but meanwhile I simplifed the test | 17:10 |
| gibi | and now | 17:10 |
| gibi | I can start with live detach first and it succeeds and generates event as well | 17:11 |
| gibi | so there is some complication my first test scenario that makes the behavior different | 17:11 |
| kashyap` | gibi: The event is _REMOVAL_FAILED, yeah? | 17:11 |
| kashyap` | gibi: If you like, I can start an upstream thread w/ the libvirt folks on libvir-list, and Cc you | 17:12 |
| gibi | kashyap`: when I get event it is VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED | 17:13 |
| gibi | kashyap`: I think I've never seen VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED in my tests ever | 17:13 |
| kashyap` | Err, sorry; it's a succesful removal | 17:13 |
| gibi | kashyap`: let's not rush with that mail, I think I tested too much first | 17:13 |
| kashyap` | gibi: No rush at all :-) Just outlining as an option | 17:14 |
| gibi | and I have to figure out what extra the nova rescue does | 17:14 |
| gibi | that makes the behavior different | 17:14 |
| gibi | because with a simple ACTIVE instance the live first scenario works | 17:14 |
| gibi | as expected | 17:14 |
| gibi | removes the device and generates event | 17:14 |
| kashyap` | Right; gibi - while it's fresh in your mind, do you want to quickly add a note on the scenarios you've tested and the ones that are "weird"? | 17:15 |
| kashyap` | Doesn't have to be now; I know it's EoD in CET. Tomm is fine too | 17:15 |
| gibi | sure I will comment on the patch | 17:15 |
| gibi | lyarwood: you mentioned that I could check the device both in the persistent config and in the live config. do you have a pointer how to check in the persistent config? | 17:16 |
| kashyap` | Excellent; this hot unplug thing is always muddy; so many variables involved. | 17:16 |
| kashyap` | gibi: I wonder if lyarwood meant 'nodedev-list' | 17:22 |
| kashyap` | (No, wait - that's for listing devices on the host) | 17:22 |
| kashyap` | Normally, there should be a '--persitent' flag for most of the listing ('domiflist', 'domblklist', et al) APIs. | 17:27 |
| gibi | kashyap`: yeah, I'm doing this from the nova code | 17:27 |
| kashyap` | gibi: So what do you want to check? Query the presence of a device from peristent config? | 17:27 |
| gibi | yes | 17:28 |
| gibi | nova currently query the live config only | 17:28 |
| kashyap` | gibi: Are you referring to this? | 17:31 |
| kashyap` | device_name_for_logging=self.vif_driver.get_vif_devname(vif), | 17:31 |
| kashyap` | live=live, | 17:31 |
| gibi | kashyap`: https://github.com/openstack/nova/blob/5b65812ef2c6ac46bea30e2e603284eac232339e/nova/virt/libvirt/guest.py#L315 | 17:33 |
| gibi | this is how nova checks if a device is in the config and I think it is checking the live config | 17:33 |
| * kashyap` clicks | 17:33 | |
| gibi | kashyap`: for vifs the code is here https://github.com/openstack/nova/blob/5b65812ef2c6ac46bea30e2e603284eac232339e/nova/virt/libvirt/guest.py#L230 | 17:34 |
| gibi | I guess the key is self._domain.XMLDesc(0) in both case but I failed to find the proper doc what 0 means and what else I can plug there | 17:35 |
| *** links has quit IRC | 17:35 | |
| gibi | anyhow I have to drop off | 17:35 |
| gibi | for today | 17:35 |
| kashyap` | gibi: Ah, it's all custom parsing of the XML | 17:35 |
| *** ociuhandu has joined #openstack-nova | 17:35 | |
| gibi | yep | 17:35 |
| kashyap` | Yeah, I need to head out shortly too; we can work it out tomm | 17:35 |
| gibi | kashyap`: thanks for the help, let's continue this tomorrow | 17:35 |
| gibi | o/ | 17:35 |
| *** ociuhandu has quit IRC | 17:40 | |
| *** ociuhandu has joined #openstack-nova | 17:41 | |
| *** artom has quit IRC | 17:42 | |
| *** ociuhandu has quit IRC | 17:51 | |
| *** artom has joined #openstack-nova | 17:52 | |
| *** ociuhandu has joined #openstack-nova | 17:53 | |
| *** ociuhandu has quit IRC | 17:58 | |
| *** ralonsoh has quit IRC | 17:58 | |
| *** vishalmanchanda has quit IRC | 17:59 | |
| *** kashyap` is now known as kashyap | 18:01 | |
| *** dasp has quit IRC | 18:13 | |
| *** nweinber has quit IRC | 18:16 | |
| *** ociuhandu has joined #openstack-nova | 18:22 | |
| *** nweinber has joined #openstack-nova | 18:24 | |
| *** dasp has joined #openstack-nova | 18:25 | |
| *** ociuhandu has quit IRC | 18:35 | |
| gmann | gibi: stephenfin can either of you check this- https://review.opendev.org/c/openstack/placement/+/764394 | 18:42 |
| *** ociuhandu has joined #openstack-nova | 18:53 | |
| *** whoami-rajat__ has quit IRC | 18:55 | |
| elod | lyarwood: sorry, I was off today, but will look into the patches tomorrow | 18:56 |
| *** ociuhandu has quit IRC | 19:01 | |
| openstackgerrit | sean mooney proposed openstack/nova-specs master: libvirt: support vdpa kernel networking https://review.opendev.org/c/openstack/nova-specs/+/764999 | 19:01 |
| sean-k-mooney | artom: im proably going to call it there for today let me know if there is anything else you want me to adress in ^ | 19:04 |
| sean-k-mooney | it will be tomorrow before i get to it proably | 19:04 |
| artom | sean-k-mooney, cool, thanks! | 19:04 |
| artom | Guyze. | 19:04 |
| artom | Guyze guyze guyzes. | 19:05 |
| *** zoharm has quit IRC | 19:05 | |
| artom | http://www.hardware.py/ is available! | 19:05 |
| artom | Aww, it's restricted :( | 19:06 |
| *** raildo_ is now known as raildo | 19:09 | |
| sean-k-mooney | hehe while agree the docs to that moduel are lacking im not sure it need its own webseit even thouh it could definetly fill one | 19:10 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy https://review.opendev.org/c/openstack/nova-specs/+/765551 | 19:12 |
| *** andrewbonney has quit IRC | 19:25 | |
| *** artom has quit IRC | 19:28 | |
| *** nightmare_unreal has quit IRC | 19:29 | |
| *** vishalmanchanda has joined #openstack-nova | 19:30 | |
| *** artom has joined #openstack-nova | 19:30 | |
| *** elod has quit IRC | 19:33 | |
| *** elod has joined #openstack-nova | 19:35 | |
| *** ociuhandu has joined #openstack-nova | 19:56 | |
| *** ociuhandu has quit IRC | 20:01 | |
| *** slaweq has quit IRC | 20:24 | |
| *** slaweq has joined #openstack-nova | 20:56 | |
| *** ociuhandu has joined #openstack-nova | 20:58 | |
| *** amodi has joined #openstack-nova | 21:07 | |
| *** ociuhandu has quit IRC | 21:09 | |
| *** ociuhandu has joined #openstack-nova | 21:10 | |
| *** ociuhandu has quit IRC | 21:13 | |
| *** ociuhandu has joined #openstack-nova | 21:13 | |
| *** xek has quit IRC | 21:26 | |
| *** ociuhandu has quit IRC | 21:26 | |
| *** nweinber has quit IRC | 21:56 | |
| *** vishalmanchanda has quit IRC | 22:09 | |
| *** raildo has quit IRC | 22:16 | |
| *** slaweq has quit IRC | 22:20 | |
| *** slaweq has joined #openstack-nova | 22:24 | |
| *** rcernin has joined #openstack-nova | 22:39 | |
| *** slaweq has quit IRC | 23:14 | |
| *** brinzhang_ has quit IRC | 23:20 | |
| *** brinzhang has joined #openstack-nova | 23:31 | |
| *** derekh has quit IRC | 23:41 | |
| *** ociuhandu has joined #openstack-nova | 23:49 | |
| *** macz_ has quit IRC | 23:52 | |
| *** ociuhandu has quit IRC | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!